]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agorbd-wnbd: improve image map error message 51665/head
Lucian Petrut [Mon, 22 May 2023 10:01:19 +0000 (10:01 +0000)]
rbd-wnbd: improve image map error message

"rbd-wnbd map" commands are delegated to the centralized
ceph-rbd Windows service, which in turn will create the
actual image mapping. This allows the daemons to continue
running even after the current session ends.

rbd-wnbd communicates with the service through a named pipe.
If the operation fails, we're only getting an error code.

This change will print the according error message based on the
error code, suggesting the user to check the logs or use
foreground mode ("-f") for additional information.

We could also capture the entire subprocess console output and
print it in case of errors. This can be quite verbose, so we'll
keep it simple for now.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2 years agoMerge pull request #51480 from sseshasa/wip-fix-pr48703-followup
Sridhar Seshasayee [Mon, 22 May 2023 11:07:53 +0000 (16:37 +0530)]
Merge pull request #51480 from sseshasa/wip-fix-pr48703-followup

osd/scheduler: Reset ephemeral changes to mClock built-in profile

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51646 from anthonyeleven/anthonyeleven/clean-up-cecil-the-seastore
Anthony D'Atri [Mon, 22 May 2023 09:52:29 +0000 (05:52 -0400)]
Merge pull request #51646 from anthonyeleven/anthonyeleven/clean-up-cecil-the-seastore

doc/dev/crimson: Improve crimson.rst

2 years agodoc/dev/crimson: Improve crimson.rst 51646/head
Anthony D'Atri [Sun, 21 May 2023 12:39:56 +0000 (08:39 -0400)]
doc/dev/crimson: Improve crimson.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 years agoMerge pull request #51552 from rhcs-dashboard/fix-61215-main
Nizamudeen A [Mon, 22 May 2023 07:11:24 +0000 (12:41 +0530)]
Merge pull request #51552 from rhcs-dashboard/fix-61215-main

mgr/dashboard: Status column in Cluster > Hosts shows empty

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51589 from rhcs-dashboard/services-running
Nizamudeen A [Mon, 22 May 2023 07:09:52 +0000 (12:39 +0530)]
Merge pull request #51589 from rhcs-dashboard/services-running

mgr/dashboard: merge running and size columns in services page

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51565 from rhcs-dashboard/helper-user-suspend
Nizamudeen A [Mon, 22 May 2023 07:07:49 +0000 (12:37 +0530)]
Merge pull request #51565 from rhcs-dashboard/helper-user-suspend

mgr/dashboard: add helper on the rgw user Suspended

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
2 years agoMerge pull request #51562 from rhcs-dashboard/fix-nan-undefined-values
Nizamudeen A [Mon, 22 May 2023 07:06:53 +0000 (12:36 +0530)]
Merge pull request #51562 from rhcs-dashboard/fix-nan-undefined-values

mgr/dashboard: fix Nan undefined values and add empty pipe on expand-cluster

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51553 from rhcs-dashboard/fix-61216-main
Nizamudeen A [Mon, 22 May 2023 07:05:20 +0000 (12:35 +0530)]
Merge pull request #51553 from rhcs-dashboard/fix-61216-main

mgr/dashboard: Show a helper for Unmanaged checkbox in service creation form

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51557 from rhcs-dashboard/fix-61222-main
Nizamudeen A [Mon, 22 May 2023 07:02:55 +0000 (12:32 +0530)]
Merge pull request #51557 from rhcs-dashboard/fix-61222-main

mgr/dashboard: show the host's IP address on Hosts page

Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51551 from rhcs-dashboard/keys-visibility
Nizamudeen A [Mon, 22 May 2023 06:54:35 +0000 (12:24 +0530)]
Merge pull request #51551 from rhcs-dashboard/keys-visibility

mgr/dashboard: more visibility for keys

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoMerge pull request #51319 from rzarzynski/wip-doc-deprecate-cache-tiering
zdover23 [Mon, 22 May 2023 01:37:56 +0000 (11:37 +1000)]
Merge pull request #51319 from rzarzynski/wip-doc-deprecate-cache-tiering

doc: deprecate the cache tiering

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agoMerge pull request #51452 from phlogistonjohn/jjm-cephadm-byte-compile
Adam King [Sun, 21 May 2023 20:20:43 +0000 (16:20 -0400)]
Merge pull request #51452 from phlogistonjohn/jjm-cephadm-byte-compile

cephadm: call compile_dir to byte compile zipapp py files

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #51321 from adk3798/no-mon-service
Adam King [Sun, 21 May 2023 19:55:23 +0000 (15:55 -0400)]
Merge pull request #51321 from adk3798/no-mon-service

mgr/cephadm: verify mon spec exists before trying to grab from spec store

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #51172 from adk3798/require-image-for-inspect
Adam King [Sun, 21 May 2023 19:42:36 +0000 (15:42 -0400)]
Merge pull request #51172 from adk3798/require-image-for-inspect

cephadm: require --image is passed to inspect-image

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #51618 from kavfixnel/main
Anthony D'Atri [Sat, 20 May 2023 21:32:28 +0000 (17:32 -0400)]
Merge pull request #51618 from kavfixnel/main

doc: Add missing `ceph` command in documentation section `REPLACING A…

2 years agodoc: Add missing `ceph` command in documentation section `REPLACING AN OSD` 51618/head
Alexander Proschek [Sat, 20 May 2023 21:06:09 +0000 (14:06 -0700)]
doc: Add missing `ceph` command in documentation section `REPLACING AN OSD`

Signed-off-by: Alexander Proschek <alexander.proschek@protonmail.com>
Signed-off-by: Alexander Proschek <alexander.proschek@protonmail.com>
2 years agoMerge pull request #51574 from phlogistonjohn/jjm-remove-extra-mypy
Adam King [Sat, 20 May 2023 15:09:07 +0000 (11:09 -0400)]
Merge pull request #51574 from phlogistonjohn/jjm-remove-extra-mypy

python-common: remove redundant call to mypy in tox.ini

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #50616 from batrick/i59120
Yuri Weinstein [Sat, 20 May 2023 14:04:13 +0000 (10:04 -0400)]
Merge pull request #50616 from batrick/i59120

qa: use parallel gzip for compressing logs

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agoMerge pull request #51594 from zdover23/wip-doc-2023-05-20-rados-operations-data...
zdover23 [Fri, 19 May 2023 17:12:45 +0000 (03:12 +1000)]
Merge pull request #51594 from zdover23/wip-doc-2023-05-20-rados-operations-data-placement

doc/rados: edit data-placement.rst

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agodoc/rados: edit data-placement.rst 51594/head
Zac Dover [Fri, 19 May 2023 16:26:45 +0000 (02:26 +1000)]
doc/rados: edit data-placement.rst

Edit doc/rados/data-placement.rst.

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51318 from Matan-B/wip-matanb-c-avoid-msg-con
Yuri Weinstein [Fri, 19 May 2023 16:16:56 +0000 (12:16 -0400)]
Merge pull request #51318 from Matan-B/wip-matanb-c-avoid-msg-con

crimson: Avoid any Message's connection usage

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #50469 from ifed01/wip-ifed-fix-bluefs-prealloc
Yuri Weinstein [Fri, 19 May 2023 16:13:03 +0000 (12:13 -0400)]
Merge pull request #50469 from ifed01/wip-ifed-fix-bluefs-prealloc

os/bluestore: proper override rocksdb::WritableFile::Allocate

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2 years agoMerge pull request #50210 from NitzanMordhai/wip-nitzan-c-write-operations-inject...
Yuri Weinstein [Fri, 19 May 2023 16:11:48 +0000 (12:11 -0400)]
Merge pull request #50210 from NitzanMordhai/wip-nitzan-c-write-operations-inject-sockert

test/c_write_operations: set RETURNVEC on expected cmpext failure

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #45921 from trociny/wip-ceph-objectstore-tool-dump-data-dir
Yuri Weinstein [Fri, 19 May 2023 16:11:23 +0000 (12:11 -0400)]
Merge pull request #45921 from trociny/wip-ceph-objectstore-tool-dump-data-dir

tools/ceph-objectstore-tool: make dump-export optionally dump object data

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #45852 from brucen1030/wip_optimize_excl_lock_for_librbd
Yuri Weinstein [Fri, 19 May 2023 16:10:20 +0000 (12:10 -0400)]
Merge pull request #45852 from brucen1030/wip_optimize_excl_lock_for_librbd

osd: don't require RWEXCL lock for stat+write ops

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agoMerge pull request #51494 from cbodley/wip-61168
Casey Bodley [Fri, 19 May 2023 13:17:52 +0000 (09:17 -0400)]
Merge pull request #51494 from cbodley/wip-61168

qa/rgw: add POOL_APP_NOT_ENABLED to log-ignorelist

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #51582 from mdw-at-linuxbox/wip-main-unused
Casey Bodley [Fri, 19 May 2023 13:09:47 +0000 (09:09 -0400)]
Merge pull request #51582 from mdw-at-linuxbox/wip-main-unused

rgw: remove unused routine in rgw_admin

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agomgr/dashboard: merge running and size columns in services page 51589/head
Pere Diaz Bou [Fri, 19 May 2023 09:54:38 +0000 (11:54 +0200)]
mgr/dashboard: merge running and size columns in services page

Fixes: https://tracker.ceph.com/issues/61295
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2 years agoMerge pull request #51555 from rhcs-dashboard/rearrange-embedded-graphana-buttons
Nizamudeen A [Fri, 19 May 2023 09:30:04 +0000 (15:00 +0530)]
Merge pull request #51555 from rhcs-dashboard/rearrange-embedded-graphana-buttons

mgr/dashboard: fix spacing of embedded grafana buttons

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51533 from rhcs-dashboard/fix-tooltip-silence-form
Nizamudeen A [Fri, 19 May 2023 09:28:51 +0000 (14:58 +0530)]
Merge pull request #51533 from rhcs-dashboard/fix-tooltip-silence-form

mgr/dashboard: fix tooltip for alerts silence matchers

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51556 from rhcs-dashboard/disable-create-osd
Nizamudeen A [Fri, 19 May 2023 09:27:38 +0000 (14:57 +0530)]
Merge pull request #51556 from rhcs-dashboard/disable-create-osd

mgr/dashboard: add warning message on why osd creation disabled

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51541 from rhcs-dashboard/filter-hosts
Nizamudeen A [Fri, 19 May 2023 09:25:46 +0000 (14:55 +0530)]
Merge pull request #51541 from rhcs-dashboard/filter-hosts

mgr/dashboard: filte hosts by services

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agoMerge pull request #51532 from rhcs-dashboard/reorder-daemon-page
Nizamudeen A [Fri, 19 May 2023 09:23:25 +0000 (14:53 +0530)]
Merge pull request #51532 from rhcs-dashboard/reorder-daemon-page

mgr/dashboard: reorder rgw daemons list items

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
2 years agomgr/dashboard: Status column in Cluster > Hosts shows empty 51552/head
Aashish Sharma [Wed, 17 May 2023 12:07:41 +0000 (17:37 +0530)]
mgr/dashboard: Status column in Cluster > Hosts shows empty

Fixes: https://tracker.ceph.com/issues/61215
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agomgr/dashboard: show the host's IP address on Hosts page 51557/head
Aashish Sharma [Wed, 17 May 2023 13:40:35 +0000 (19:10 +0530)]
mgr/dashboard: show the host's IP address on Hosts page

Fixes: https://tracker.ceph.com/issues/61222
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agomgr/dashboard: more visibility for keys 51551/head
Nizamudeen A [Thu, 18 May 2023 08:14:01 +0000 (13:44 +0530)]
mgr/dashboard: more visibility for keys

Fixes: https://tracker.ceph.com/issues/61239
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: Show a helper for Unmanaged checkbox in service creation form 51553/head
Aashish Sharma [Wed, 17 May 2023 12:31:41 +0000 (18:01 +0530)]
mgr/dashboard: Show a helper for Unmanaged checkbox in service creation form

Fixes: https://tracker.ceph.com/issues/61216
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #51567 from rhcs-dashboard/remove-card-title
Nizamudeen A [Fri, 19 May 2023 08:34:35 +0000 (14:04 +0530)]
Merge pull request #51567 from rhcs-dashboard/remove-card-title

mgr/dashboard: remove title tooltip of cards landing page

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51362 from Svelar/filestore-drop
Ilya Dryomov [Fri, 19 May 2023 08:12:29 +0000 (10:12 +0200)]
Merge pull request #51362 from Svelar/filestore-drop

vstart: remove filestore options and config snippets

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51580 from zdover23/wip-doc-2023-04-19-radosgw-dynamicresharding
zdover23 [Fri, 19 May 2023 08:11:20 +0000 (18:11 +1000)]
Merge pull request #51580 from zdover23/wip-doc-2023-04-19-radosgw-dynamicresharding

doc/radosgw: explain multisite dynamic sharding

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/radosgw: explain multisite dynamic sharding 51580/head
Zac Dover [Thu, 18 May 2023 21:07:02 +0000 (07:07 +1000)]
doc/radosgw: explain multisite dynamic sharding

Add a note to doc/radosgw/dynamicresharding.rst and a note to
doc/radosgw/multisite.rst that explains that dynamic resharding is not
supported in releases prior to Reef.

This commit is made in response to a request from Mathias Chapelain.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51406 from votdev/issue_59689_sso_str_decode
Nizamudeen A [Fri, 19 May 2023 07:26:01 +0000 (12:56 +0530)]
Merge pull request #51406 from votdev/issue_59689_sso_str_decode

mgr/dashboard: SSO error: AttributeError: 'str' object has no attribute 'decode'

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>
2 years agomgr/dashboard: fix spacing of embedded grafana buttons 51555/head
Pedro Gonzalez Gomez [Thu, 18 May 2023 10:10:11 +0000 (12:10 +0200)]
mgr/dashboard: fix spacing of embedded grafana buttons

Fixes: https://tracker.ceph.com/issues/61220
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agomgr/dashboard: fix Nan undefined values and add empty pipe on expand-cluster 51562/head
Pedro Gonzalez Gomez [Thu, 18 May 2023 11:47:16 +0000 (13:47 +0200)]
mgr/dashboard: fix Nan undefined values and add empty pipe on expand-cluster

Fixes: https://tracker.ceph.com/issues/61207
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agoMerge pull request #51564 from cloudbehl/rgeDeamonsGateway
Nizamudeen A [Fri, 19 May 2023 06:56:19 +0000 (12:26 +0530)]
Merge pull request #51564 from cloudbehl/rgeDeamonsGateway

mgr/dashboard: Change Daemons in Object Gateway section to Gateways

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51563 from rhcs-dashboard/encryption-defaults
Nizamudeen A [Fri, 19 May 2023 06:54:43 +0000 (12:24 +0530)]
Merge pull request #51563 from rhcs-dashboard/encryption-defaults

mgr/dashboard: put some default values on rgw encryption config form

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
2 years agoMerge pull request #51554 from rhcs-dashboard/roles-breadcrumbs
Nizamudeen A [Fri, 19 May 2023 06:47:17 +0000 (12:17 +0530)]
Merge pull request #51554 from rhcs-dashboard/roles-breadcrumbs

mgr/dashboard: fix rgw roles breadcrumbs

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agoMerge pull request #51550 from rhcs-dashboard/hide-selected-gw-dropdown
Nizamudeen A [Fri, 19 May 2023 06:43:28 +0000 (12:13 +0530)]
Merge pull request #51550 from rhcs-dashboard/hide-selected-gw-dropdown

mgr/dashboard: remove Selected Object Gateway dropdown

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agoMerge pull request #51546 from rhcs-dashboard/add-scroll-inside-tables
Nizamudeen A [Fri, 19 May 2023 06:42:13 +0000 (12:12 +0530)]
Merge pull request #51546 from rhcs-dashboard/add-scroll-inside-tables

mgr/dashboard: add-scroll-in-key-value-tables

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51529 from rhcs-dashboard/encyrption-form-default
Nizamudeen A [Fri, 19 May 2023 06:39:45 +0000 (12:09 +0530)]
Merge pull request #51529 from rhcs-dashboard/encyrption-form-default

mgr/dashboard: default encryption type to sse-s3 in rgw

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agorgw: remove unused routine in rgw_admin 51582/head
Marcus Watts [Thu, 26 Aug 2021 09:08:00 +0000 (05:08 -0400)]
rgw: remove unused routine in rgw_admin

Routine "dump_bi_entry" contains logic to decode rgw_bucket_dir_entry
which can contain etags to be fixed.  However, it turns out this
routine is never called, so let's just get rid of it.  (The replacement
code lives in cls land.)

Fixes: https://tracker.ceph.com/issues/61260
Signed-off-by: Marcus Watts <mwatts@redhat.com>
2 years agoMerge pull request #50691 from amathuria/wip-amat-out-of-order
Samuel Just [Thu, 18 May 2023 22:29:33 +0000 (15:29 -0700)]
Merge pull request #50691 from amathuria/wip-amat-out-of-order

mClockScheduler: Set priority cutoff in the mClock Scheduler

Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
2 years agoMerge pull request #51572 from zdover23/wip-doc-2023-04-19-rados-operations-devices
zdover23 [Thu, 18 May 2023 19:46:59 +0000 (05:46 +1000)]
Merge pull request #51572 from zdover23/wip-doc-2023-04-19-rados-operations-devices

doc/rados: line-edit devices.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agopython-common: remove redundant call to mypy in tox.ini 51574/head
John Mulligan [Wed, 17 May 2023 20:57:39 +0000 (16:57 -0400)]
python-common: remove redundant call to mypy in tox.ini

In the previous change to this tox.ini file, I created a dedicated env
for running mypy but forgot to remove the previous call to mypy that
was happening after the call to pytest.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
2 years agoqa/tasks: Allow override of recovery configs for tests 51480/head
Sridhar Seshasayee [Thu, 18 May 2023 09:18:09 +0000 (14:48 +0530)]
qa/tasks: Allow override of recovery configs for tests

With mClock scheduler enabled, a small subset of config options related
to recovery limits are not allowed to be modified unless
osd_mclock_override_recovery_settings option is enabled. This override
option is disabled by default. The following options cannot be modified
without enabling the override option:

 - osd_max_backfills
 - osd_recovery_max_active[_(hdd|ssd)]

The above options are removed from the mon kv store which effectively
restores them to the default values.

This was resulting in tests for example,
test_cluster_configuration.ClusterConfigurationTest to fail since it
modifies the recovery options and expects to verify the modified value.

Therefore, for tests, osd_mclock_override_recovery_settings option is
enabled in vstart_runner.py so that current and future tests
are not affected.

Fixes: https://tracker.ceph.com/issues/61155
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
2 years agodoc/rados: line-edit devices.rst 51572/head
Zac Dover [Thu, 18 May 2023 14:13:41 +0000 (00:13 +1000)]
doc/rados: line-edit devices.rst

Edit doc/rados/operations/devices.rst.

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agomgr/dashboard: add warning message on why osd creation disabled 51556/head
Pere Diaz Bou [Wed, 17 May 2023 14:32:43 +0000 (16:32 +0200)]
mgr/dashboard: add warning message on why osd creation disabled

When no options are present when creating OSDs, you can see the form
with lots of things disabled without having a clear explanation. This
PR introduces a warning banner with a description on why it is
happening.

Fixes: https://tracker.ceph.com/issues/61223
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2 years agomgr/dashboard: add helper on the rgw user Suspended 51565/head
Nizamudeen A [Thu, 18 May 2023 12:10:42 +0000 (17:40 +0530)]
mgr/dashboard: add helper on the rgw user Suspended

Fixes: https://tracker.ceph.com/issues/61247
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: remove title tooltip of cards landing page 51567/head
Pedro Gonzalez Gomez [Thu, 18 May 2023 12:16:10 +0000 (14:16 +0200)]
mgr/dashboard: remove title tooltip of cards landing page

Fixes: https://tracker.ceph.com/issues/61250
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agoMerge pull request #51530 from rhcs-dashboard/fix-61213-main
Pere Diaz Bou [Thu, 18 May 2023 12:08:46 +0000 (14:08 +0200)]
Merge pull request #51530 from rhcs-dashboard/fix-61213-main

mgr/dashboard: Rename Cluster > Monitoring to Alerts and change Cluster>Users to Cluster>Ceph Users

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard:Change Daemons > Object Gateway section to Gateways 51564/head
Ankush Behl [Thu, 18 May 2023 11:55:56 +0000 (17:25 +0530)]
mgr/dashboard:Change Daemons > Object Gateway section to Gateways
- Change the Daemons to Gateways
- Changing the breadcrums to call it Gateways
- In list page Calling Daemons List as Gateways List

Fixes: https://tracker.ceph.com/issues/61245
Signed-off-by: Ankush Behl <cloudbehl@gmail.com>
2 years agomgr/dashboard: put some default values on rgw encryption config form 51563/head
Nizamudeen A [Thu, 18 May 2023 12:03:44 +0000 (17:33 +0530)]
mgr/dashboard: put some default values on rgw encryption config form

Fixes: https://tracker.ceph.com/issues/61246
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: filte hosts by services 51541/head
Pere Diaz Bou [Wed, 17 May 2023 16:17:50 +0000 (18:17 +0200)]
mgr/dashboard: filte hosts by services

Fixes: https://tracker.ceph.com/issues/61242
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2 years agomgr/dashboard: fix rgw roles breadcrumbs 51554/head
Nizamudeen A [Thu, 18 May 2023 10:48:08 +0000 (16:18 +0530)]
mgr/dashboard: fix rgw roles breadcrumbs

Fixes: https://tracker.ceph.com/issues/61241
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51547 from mitsu-ko/patch2
Ilya Dryomov [Thu, 18 May 2023 10:09:12 +0000 (12:09 +0200)]
Merge pull request #51547 from mitsu-ko/patch2

doc: fix underbar to hyphen in stripe-unit and stripe-count

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agomgr/dashboard: add-scroll-in-key-value-tables 51546/head
Pedro Gonzalez Gomez [Thu, 18 May 2023 07:14:50 +0000 (09:14 +0200)]
mgr/dashboard: add-scroll-in-key-value-tables

Fixes: https://tracker.ceph.com/issues/61220
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agomgr/dashboard: reorder rgw daemons list items 51532/head
Nizamudeen A [Wed, 17 May 2023 11:54:52 +0000 (17:24 +0530)]
mgr/dashboard: reorder rgw daemons list items

Fixes: https://tracker.ceph.com/issues/61212
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: Rename Cluster > Monitoring to Alerts and change Cluster>Users to... 51530/head
Aashish Sharma [Wed, 17 May 2023 11:17:15 +0000 (16:47 +0530)]
mgr/dashboard: Rename Cluster > Monitoring to Alerts and change Cluster>Users to Cluster>Ceph Users

Fixes: https://tracker.ceph.com/issues/61213
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #51531 from rhcs-dashboard/rename-service-details-to-daemons
Aashish Sharma [Thu, 18 May 2023 08:43:19 +0000 (14:13 +0530)]
Merge pull request #51531 from rhcs-dashboard/rename-service-details-to-daemons

mgr/dashboard: rename Service>Details to Service>Daemons

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: default encryption type to sse-s3 in rgw 51529/head
Nizamudeen A [Wed, 17 May 2023 10:57:59 +0000 (16:27 +0530)]
mgr/dashboard: default encryption type to sse-s3 in rgw

by default the form doesn't select any values, so i am defaulting it to
sse-s3

Fixes: https://tracker.ceph.com/issues/61211
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoosd/scheduler: Reset ephemeral changes to mClock built-in profile
Sridhar Seshasayee [Mon, 15 May 2023 07:16:54 +0000 (12:46 +0530)]
osd/scheduler: Reset ephemeral changes to mClock built-in profile

This is a follow-up to PR: https://github.com/ceph/ceph/pull/48703.
This commit also considers changes made ephemerally using either the
'daemon' or the 'tell' interfaces to override the built-in mClock
QoS parameters. In such a scenario, the ephemeral changes are removed
using the rm_val() method exposed by the config subsytem and logging
this information.

Other changes:

1. Add a standalone test to exercise the fix.
2. Add documentation note on the outcome of the attempt to modify
   built-in profile defaults.

Fixes: https://tracker.ceph.com/issues/61155
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
2 years agomon/MonCap: Allow default osd profile to run "config rm" with restriction
Sridhar Seshasayee [Tue, 16 May 2023 17:29:41 +0000 (22:59 +0530)]
mon/MonCap: Allow default osd profile to run "config rm" with restriction

This is a follow-up to PR: https://github.com/ceph/ceph/pull/48703.
Modify the mon caps to allow OSDs to run the "config rm" command with
restriction to remove only the following config keys from the mon store:
- osd_max_backfills
- osd_recovery_max_active(.*)
  - osd_recovery_max_active and
  - osd_recovery_max_active_(hdd|ssd)
- osd_mclock_scheduler_(.*) -> all the QoS specific config options.

The above is similar to the change in mon caps to run the "config set"
command as implemented in PR: https://github.com/ceph/ceph/pull/42853.

Fixes: https://tracker.ceph.com/issues/61155
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
2 years agomgr/dashboard: fix tooltip for alerts silence matchers 51533/head
avanthakkar [Wed, 17 May 2023 12:14:00 +0000 (17:44 +0530)]
mgr/dashboard: fix tooltip for alerts silence matchers

Fixes: https://tracker.ceph.com/issues/61208
Signed-off-by: avanthakkar <avanjohn@gmail.com>
2 years agodoc: fix under bar to hyphen in stripe-unit and stripe-count 51547/head
Mitsumasa KONDO [Wed, 17 May 2023 06:27:24 +0000 (15:27 +0900)]
doc: fix under bar to hyphen in stripe-unit and stripe-count

Signed-off-by: Mitsumasa KONDO <kondo.mitsumasa@gmail.com>
2 years agoMerge pull request #51449 from amathuria/wip-rbd-suite-change-mclock-profile
Ilya Dryomov [Thu, 18 May 2023 07:28:00 +0000 (09:28 +0200)]
Merge pull request #51449 from amathuria/wip-rbd-suite-change-mclock-profile

qa/tasks: Changing default mClock profile to high_recovery_ops

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge PR #49691 into main
Venky Shankar [Thu, 18 May 2023 07:19:33 +0000 (12:49 +0530)]
Merge PR #49691 into main

* refs/pull/49691/head:
qa: add test for opening a file via a hard link that is not in the same mds as the inode
mds: rdlock_path_xlock_dentry supports returning auth target inode

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agomgr/dashboard: remove Selected Object Gateway dropdown 51550/head
Nizamudeen A [Thu, 18 May 2023 06:24:53 +0000 (11:54 +0530)]
mgr/dashboard: remove Selected Object Gateway dropdown

Only from Daemons and Multisite page because its not needed there.

Fixes: https://tracker.ceph.com/issues/61230
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoqa/tasks: Change default mClock profile to high_recovery_ops 51449/head
Aishwarya Mathuria [Thu, 11 May 2023 17:20:15 +0000 (22:50 +0530)]
qa/tasks: Change default mClock profile to high_recovery_ops

With the new mClock default profile, tests were failing with "Exiting scrub checking -- not all pgs scrubbed" due to slower scrubs.
Changing the default profile to high_recovery_ops for testing purposes will fix this issue.

Fixes: https://tracker.ceph.com/issues/61228
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2 years agoMerge pull request #46985 from fengyueqiao/fix-the-comment-of-RecoveryState-hierarchical
Samuel Just [Wed, 17 May 2023 23:34:02 +0000 (16:34 -0700)]
Merge pull request #46985 from fengyueqiao/fix-the-comment-of-RecoveryState-hierarchical

osd: fix the comment of RecoveryState hierarchical structure

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51534 from zdover23/wip-doc-2023-05-17-cephfs-mirroring-cleanup
zdover23 [Wed, 17 May 2023 21:20:28 +0000 (07:20 +1000)]
Merge pull request #51534 from zdover23/wip-doc-2023-05-17-cephfs-mirroring-cleanup

doc/cephfs: line-edit "Mirroring Module"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #51444 from jianwei1216/handle_osd_map_use_deep_copy
Yuri Weinstein [Wed, 17 May 2023 20:09:00 +0000 (13:09 -0700)]
Merge pull request #51444 from jianwei1216/handle_osd_map_use_deep_copy

osd/OSDMap: improve efficiency for OSD::handle_osd_map

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #50531 from YiteGu/op-delayed-detail
Yuri Weinstein [Wed, 17 May 2023 20:08:33 +0000 (13:08 -0700)]
Merge pull request #50531 from YiteGu/op-delayed-detail

osd/OpRequest: Add detail description for delayed op in osd log file

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agomgr/dashboard: rename Service>Details to Service>Daemons 51531/head
Pere Diaz Bou [Wed, 17 May 2023 11:19:10 +0000 (13:19 +0200)]
mgr/dashboard: rename Service>Details to Service>Daemons

Daemons and services are not interchangeable in cephadm terms. As stated
in the docs: `A daemon is a systemd unit that is running and part of a
service.` https://docs.ceph.com/en/latest/cephadm/services/#daemon-status

Fixes: https://tracker.ceph.com/issues/61214
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2 years agodoc: deprecate the cache tiering 51319/head
Radosław Zarzyński [Tue, 2 May 2023 15:52:23 +0000 (17:52 +0200)]
doc: deprecate the cache tiering

This topic has been discussed many times; recently at the Dev
Summit of Cephalocon 2023.

This commit is the minial version of the work, contained entirely
within the `doc`. However, likely it will be expanded as there
were ideas like e.g. adding cache tiering back experimental feature
list (Sam) to warn users when deploying a new cluster.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
2 years agodoc/cephfs: line-edit "Mirroring Module" 51534/head
Zac Dover [Wed, 17 May 2023 12:25:38 +0000 (22:25 +1000)]
doc/cephfs: line-edit "Mirroring Module"

Line-edit the "Mirroring Module" section of
doc/cephfs/cephfs-mirroring.rst. Add prompts and formatting where such
things contribute to the realization of adequate sentences.

This commit is a follow-up to https://github.com/ceph/ceph/pull/51505.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51513 from cbodley/wip-59490
Casey Bodley [Wed, 17 May 2023 13:04:35 +0000 (09:04 -0400)]
Merge pull request #51513 from cbodley/wip-59490

rgw: use string_view to parse Accept header

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoMerge pull request #51279 from pkalever/cleanup-logs
Ilya Dryomov [Wed, 17 May 2023 08:46:47 +0000 (10:46 +0200)]
Merge pull request #51279 from pkalever/cleanup-logs

librbd: clean up a few log messages

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge PR #50594 into main
Venky Shankar [Wed, 17 May 2023 06:17:15 +0000 (11:47 +0530)]
Merge PR #50594 into main

* refs/pull/50594/head:
mds: remove inappropriate initialization of num_imported

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #51505 from vshankar/wip-cephfs-mirror-add-explanation
zdover23 [Wed, 17 May 2023 04:51:30 +0000 (14:51 +1000)]
Merge pull request #51505 from vshankar/wip-cephfs-mirror-add-explanation

doc: explain cephfs mirroring `peer_add` step in detail

Reviewed-by: Zac Dover <zac.dover.proton.me>
2 years agoMerge pull request #51297 from Matan-B/wip-matanb-locker-request-str
Ilya Dryomov [Tue, 16 May 2023 18:34:38 +0000 (20:34 +0200)]
Merge pull request #51297 from Matan-B/wip-matanb-locker-request-str

librbd/managed_lock/GetLockerRequest: Fix no valid lockers case

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51454 from ajarr/wip-59713
Ilya Dryomov [Tue, 16 May 2023 18:28:33 +0000 (20:28 +0200)]
Merge pull request #51454 from ajarr/wip-59713

rbd_support: recover from "double blocklisting"

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agolibrbd: cleanup few log lines 51279/head
Prasanna Kumar Kalever [Fri, 28 Apr 2023 08:46:35 +0000 (14:16 +0530)]
librbd: cleanup few log lines

Currently:
2023-04-28T12:20:17.135+0530 7f1a7ccd2640 20 librbd::ExclusiveLock: 0x7f1a4c000b60 block_requestsr=0
[...]
2023-04-28T12:20:17.135+0530 7f1a7ccd2640 20 librbd::ManagedLock: 0x7f1a4c000b78 is_lock_owner: =1
[...]
2023-04-18T21:18:50.695+0530 7f0a1ffff640 20 librbd::ImageWatcher: 0x7f0a10007840 remote async request finished: [4305,140018014309120,1] = -110

Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
2 years agorgw: use string_view to parse Accept header 51513/head
Casey Bodley [Tue, 16 May 2023 12:24:29 +0000 (08:24 -0400)]
rgw: use string_view to parse Accept header

avoid copying the header into a separate buffer to do comparisons

Fixes: https://tracker.ceph.com/issues/59490
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agovstart: modify FreeBSD objectstore to memstore. 51362/head
Rongqi Sun [Tue, 16 May 2023 07:23:52 +0000 (15:23 +0800)]
vstart: modify FreeBSD objectstore to memstore.

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
2 years agoosd/OSDMap: improve efficiency for OSD::handle_osd_map 51444/head
zhangjianwei [Thu, 11 May 2023 13:34:13 +0000 (13:34 +0000)]
osd/OSDMap: improve efficiency for OSD::handle_osd_map

- improve OSDMap::decode performance by page-aligning bufferlist
  - align osdmap buffer memory pages in OSDService::_get_map_bl()
  - align osdmap bluffer memory pages in OSDService::get_inc_map_bl
- use OSDMap::deepish_copy_from in OSD::handle_osd_map instead of OSDMap::decode

co-author: yanghonggang <yanghonggang_yewu@cmss.chinamobile.com>
Signed-off-by: zhangjianwei <zhangjianwei2_yewu@cmss.chinamobile.com>
2 years agodoc: explain cephfs mirroring `peer_add` step in detail 51505/head
Venky Shankar [Tue, 16 May 2023 05:25:34 +0000 (10:55 +0530)]
doc: explain cephfs mirroring `peer_add` step in detail

@zdover23 reached out regarding missing explanation for `peer_add`
step in cephfs mirroring documentation. Add some explanation and
and example to make the step clear.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #51492 from zdover23/wip-doc-2023-05-16-start-os-recommendations
zdover23 [Tue, 16 May 2023 05:10:18 +0000 (15:10 +1000)]
Merge pull request #51492 from zdover23/wip-doc-2023-05-16-start-os-recommendations

doc/start: KRBD feature flag support note

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agoMerge pull request #51385 from rhcs-dashboard/fix-cephPgImbalance-regression
Nizamudeen A [Tue, 16 May 2023 04:47:34 +0000 (10:17 +0530)]
Merge pull request #51385 from rhcs-dashboard/fix-cephPgImbalance-regression

mgr/dashboard: fix regression caused by cephPgImabalance alert

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #50537 from mrstarke/main
Casey Bodley [Mon, 15 May 2023 21:09:28 +0000 (17:09 -0400)]
Merge pull request #50537 from mrstarke/main

rgw/swift: check position of first slash in slo manifest files

Reviewed-by: Ali Maredia <amaredia@redhat.com>