]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agocrimson/os/seastore/backref_manager: scan backref entries by journal seq 51750/head
Zhang Song [Thu, 25 May 2023 08:30:44 +0000 (16:30 +0800)]
crimson/os/seastore/backref_manager: scan backref entries by journal seq

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agoMerge pull request #50037 from rhcs-dashboard/cypress-10
Nizamudeen A [Thu, 25 May 2023 07:57:05 +0000 (13:27 +0530)]
Merge pull request #50037 from rhcs-dashboard/cypress-10

mgr/dashboard: update to cypress 10

Reviewed-by: Pegonzal <NOT@FOUND>
2 years agomgr/dashboard: fix the hosts e2e failure 50037/head
Nizamudeen A [Wed, 24 May 2023 15:05:51 +0000 (20:35 +0530)]
mgr/dashboard: fix the hosts e2e failure

Fixes: https://tracker.ceph.com/issues/61354
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: fix the cephadm grafana e2e failure
Nizamudeen A [Wed, 24 May 2023 08:35:32 +0000 (14:05 +0530)]
mgr/dashboard: fix the cephadm grafana e2e failure

Fixes: https://tracker.ceph.com/issues/61354
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51696 from rhcs-dashboard/fix-requirement-test-regression
Nizamudeen A [Thu, 25 May 2023 05:25:21 +0000 (10:55 +0530)]
Merge pull request #51696 from rhcs-dashboard/fix-requirement-test-regression

mgr/dashboard: fix regression caused by -  bcc92adb96d1ab8155d30cb51933b0d07b398cdc

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #51730 from anthonyeleven/anthonyeleven/formatting
zdover23 [Wed, 24 May 2023 22:55:51 +0000 (08:55 +1000)]
Merge pull request #51730 from anthonyeleven/anthonyeleven/formatting

doc/rados/operations: Fix erasure-code-jerasure.rst fix

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agodoc/rados/operations: Fix erasure-code-jerasure.rst fix 51730/head
Anthony D'Atri [Wed, 24 May 2023 13:57:42 +0000 (09:57 -0400)]
doc/rados/operations: Fix erasure-code-jerasure.rst fix

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 years agoMerge PR #50501 into main
Patrick Donnelly [Wed, 24 May 2023 21:04:07 +0000 (17:04 -0400)]
Merge PR #50501 into main

* refs/pull/50501/head:
mon/MDSMonitor: do not propose on error in prepare_update

Reviewed-by: Rishabh Dave <ridave@redhat.com>
2 years agoMerge PR #51407 into main
Patrick Donnelly [Wed, 24 May 2023 21:01:03 +0000 (17:01 -0400)]
Merge PR #51407 into main

* refs/pull/51407/head:
mon/MDSMonitor: check fscid in pending exists in current

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #51656 from amathuria/wip-amat-mclock-change-default-scrub-cost
Laura Flores [Wed, 24 May 2023 17:04:24 +0000 (12:04 -0500)]
Merge pull request #51656 from amathuria/wip-amat-mclock-change-default-scrub-cost

osd: Change scrub cost in case of mClock scheduler

2 years agomgr/dashboard: update to cypress 10
Nizamudeen A [Wed, 8 Feb 2023 15:49:31 +0000 (21:19 +0530)]
mgr/dashboard: update to cypress 10

Fixes: https://tracker.ceph.com/issues/61354
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51713 from cbodley/wip-58953
Casey Bodley [Wed, 24 May 2023 14:38:44 +0000 (10:38 -0400)]
Merge pull request #51713 from cbodley/wip-58953

cmake: cls_rgw and cls_fifo depend on fmt

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
2 years agoMerge pull request #50858 from zdover23/wip-doc-2023-04-04-rados-operations-monitorin...
Anthony D'Atri [Wed, 24 May 2023 11:39:07 +0000 (07:39 -0400)]
Merge pull request #50858 from zdover23/wip-doc-2023-04-04-rados-operations-monitoring-osd-pg-question-2-active-set

doc/rados/operations: Acting Set question

2 years agomgr/dashboard: fix regression caused by bcc92adb96d1ab8155d30cb51933b0d07b398cdc 51696/head
Aashish Sharma [Tue, 23 May 2023 08:26:28 +0000 (13:56 +0530)]
mgr/dashboard: fix regression caused by bcc92adb96d1ab8155d30cb51933b0d07b398cdc

This PR intends to revert the changendone in requirements-test.tzt by PR
50643

Fixes: bcc92adb96d1ab8155d30cb51933b0d07b398cdc
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agodoc/rados/operations: Acting Set question 50858/head
Zac Dover [Tue, 4 Apr 2023 03:59:46 +0000 (13:59 +1000)]
doc/rados/operations: Acting Set question

Clear up a paragraph that describes the behavior of the Acting Set.

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51723 from anthonyeleven/anthonyeleven/tracker-58723
Anthony D'Atri [Wed, 24 May 2023 00:52:00 +0000 (20:52 -0400)]
Merge pull request #51723 from anthonyeleven/anthonyeleven/tracker-58723

doc: Update jerasure.org references

2 years agoMerge pull request #50847 from smanjara/wip-fix-ret-bucket-sync-status
Shilpa Jagannath [Tue, 23 May 2023 23:32:21 +0000 (19:32 -0400)]
Merge pull request #50847 from smanjara/wip-fix-ret-bucket-sync-status

rgw/multisite: fix ret handling in bucket read_sync_status()

2 years agodoc: Update jerasure.org references 51723/head
Anthony D'Atri [Tue, 23 May 2023 23:13:33 +0000 (19:13 -0400)]
doc: Update jerasure.org references

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 years agoMerge pull request #51679 from zdover23/wip-doc-2023-05-23-mgr-telemetry-leaderboard
zdover23 [Tue, 23 May 2023 22:04:26 +0000 (08:04 +1000)]
Merge pull request #51679 from zdover23/wip-doc-2023-05-23-mgr-telemetry-leaderboard

doc/mgr: edit "leaderboard" in telemetry.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #50438 from SUSE/wip-fix-58477
Ilya Dryomov [Tue, 23 May 2023 20:02:55 +0000 (22:02 +0200)]
Merge pull request #50438 from SUSE/wip-fix-58477

Fix FTBFS on gcc 13

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #51511 from soumyakoduri/wip-skoduri-bucket-repl
Soumya Koduri [Tue, 23 May 2023 17:09:01 +0000 (22:39 +0530)]
Merge pull request #51511 from soumyakoduri/wip-skoduri-bucket-repl

rgw/multisite: Fix issue with parsing replication rules

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agocmake: cls_rgw and cls_fifo depend on fmt 51713/head
Casey Bodley [Mon, 22 May 2023 16:33:06 +0000 (12:33 -0400)]
cmake: cls_rgw and cls_fifo depend on fmt

Fixes: https://tracker.ceph.com/issues/58953
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agorgw/multisite: Fix issue with parsing replication rules 51511/head
Soumya Koduri [Tue, 16 May 2023 10:10:36 +0000 (15:40 +0530)]
rgw/multisite: Fix issue with parsing replication rules

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2 years agoMerge pull request #50598 from rzarzynski/wip-crimson-only-tcmalloc-lsan-supp
Radoslaw Zarzynski [Tue, 23 May 2023 10:58:33 +0000 (12:58 +0200)]
Merge pull request #50598 from rzarzynski/wip-crimson-only-tcmalloc-lsan-supp

crimson/osd: add embedded suppression ruleset for LSan

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
2 years agoMerge pull request #51665 from petrutlucian94/map_err
Ilya Dryomov [Tue, 23 May 2023 10:46:55 +0000 (12:46 +0200)]
Merge pull request #51665 from petrutlucian94/map_err

rbd-wnbd: improve image map error message

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoosd: mClock default_min reservation should be 0 51656/head
Aishwarya Mathuria [Tue, 23 May 2023 10:43:08 +0000 (16:13 +0530)]
osd: mClock default_min reservation should be 0

All the mClock profiles enforce no minimum reservation for the background best-effort client.
For this purpose, the default_min value should 0 and not 1.

Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2 years agoMerge pull request #51682 from zdover23/wip-doc-2023-05-23-glossary-bluestore
zdover23 [Tue, 23 May 2023 08:14:05 +0000 (18:14 +1000)]
Merge pull request #51682 from zdover23/wip-doc-2023-05-23-glossary-bluestore

doc/glossary: update bluestore entry

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoosd: Change scrub cost in case of mClock scheduler
Aishwarya Mathuria [Fri, 19 May 2023 11:46:11 +0000 (17:16 +0530)]
osd: Change scrub cost in case of mClock scheduler

With osd_op_queue as WPQ, high costs were assigned to scrub in order to throttle it effectively.
In the case of mClock scheduler, mClock parameters are used to do the throttling and the cost should represent a realistic value.

Fixes: https://tracker.ceph.com/issues/61313
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
2 years agoMerge pull request #51590 from rhcs-dashboard/rbd-snapshot-disabled-fix
Nizamudeen A [Tue, 23 May 2023 05:41:32 +0000 (11:11 +0530)]
Merge pull request #51590 from rhcs-dashboard/rbd-snapshot-disabled-fix

mgr/dashboard: fix create snapshot is disabled for rbd images

Reviewed-by: Pegonzal <NOT@FOUND>
2 years agodoc/glossary: update bluestore entry 51682/head
Zac Dover [Mon, 22 May 2023 21:41:09 +0000 (07:41 +1000)]
doc/glossary: update bluestore entry

Update the BlueStore entry in the glossary, explaining that as of Reef
BlueStore and only BlueStore (and not FileStore) is the storage backend
for Ceph.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51265 from cbodley/wip-59471
Casey Bodley [Tue, 23 May 2023 01:57:07 +0000 (21:57 -0400)]
Merge pull request #51265 from cbodley/wip-59471

rgw/s3: ListObjectsV2 returns correct object owners

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agodoc/mgr: edit "leaderboard" in telemetry.rst 51679/head
Zac Dover [Mon, 22 May 2023 20:06:52 +0000 (06:06 +1000)]
doc/mgr: edit "leaderboard" in telemetry.rst

Standardize the presentation of commands in the "Leaderboard" section of
doc/mgr/telemetry.rst.

Follow-up to https://github.com/ceph/ceph/pull/50977

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51651 from zdover23/wip-doc-2023-05-22-cache-tiering-deprecation...
zdover23 [Mon, 22 May 2023 20:00:13 +0000 (06:00 +1000)]
Merge pull request #51651 from zdover23/wip-doc-2023-05-22-cache-tiering-deprecation-notes

doc: note deprecation of Cache Tiering in Reef

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge PR #49553 into main
Patrick Donnelly [Mon, 22 May 2023 19:42:28 +0000 (15:42 -0400)]
Merge PR #49553 into main

* refs/pull/49553/head:
mds: wait reintegrate to finish when unlinking
message: make MClientReply inherit MMDSOp
mds: notify the waiters in replica MDSs

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #51535 from rzarzynski/wip-bs-include-bdev-in-cbt-logs
Yuri Weinstein [Mon, 22 May 2023 18:33:40 +0000 (14:33 -0400)]
Merge pull request #51535 from rzarzynski/wip-bs-include-bdev-in-cbt-logs

os/bluestore: CBT includes bdev's logs when --log-file is set

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2 years agoMerge pull request #51528 from NitzanMordhai/wip-nitzan-tests-using-override-instead...
Yuri Weinstein [Mon, 22 May 2023 18:33:10 +0000 (14:33 -0400)]
Merge pull request #51528 from NitzanMordhai/wip-nitzan-tests-using-override-instead-overrides

tests: change override to overrides so conf will take affect

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoMerge pull request #51352 from rosinL/crimson-crush-hook
Yuri Weinstein [Mon, 22 May 2023 18:32:35 +0000 (14:32 -0400)]
Merge pull request #51352 from rosinL/crimson-crush-hook

crimson/osd: add crush_location_hook feature to crimson

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #51498 from athanatos/sjust/wip-scrub-59049
Laura Flores [Mon, 22 May 2023 16:48:19 +0000 (11:48 -0500)]
Merge pull request #51498 from athanatos/sjust/wip-scrub-59049

src/osd/scrubber: process MapsCompared event syncronously

2 years agomgr/dashboard: fix create snapshot is disabled for rbd images 51590/head
Nizamudeen A [Fri, 19 May 2023 11:18:14 +0000 (16:48 +0530)]
mgr/dashboard: fix create snapshot is disabled for rbd images

also the rename and rollback option in the snapshot list is enabled even if there isn't anything in the list

also disabled the Mirror Image Snapshot option in the Create RBD
Snapshot form (only shown for images configured with Snapshot mirroring)
with the helpe

Fixes: https://tracker.ceph.com/issues/61296
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51658 from rhcs-dashboard/daemon-details-fix
Nizamudeen A [Mon, 22 May 2023 15:38:23 +0000 (21:08 +0530)]
Merge pull request #51658 from rhcs-dashboard/daemon-details-fix

mgr/dashboard: fix broken daemon details tab

Reviewed-by: cloudbehl <NOT@FOUND>
2 years agoMerge PR #51661 into reef
Venky Shankar [Mon, 22 May 2023 15:07:21 +0000 (20:37 +0530)]
Merge PR #51661 into reef

* refs/pull/51661/head:
Revert "mds: fix client isn't responding to mclientcaps(revoke)"

Reviewed-by: Xiubo Li <xiubli@redhat.com>
2 years agoMerge pull request #51090 from banuchka/mgr/prometheus-plugin-fix-2-bugs-implemented...
Nizamudeen A [Mon, 22 May 2023 14:36:42 +0000 (20:06 +0530)]
Merge pull request #51090 from banuchka/mgr/prometheus-plugin-fix-2-bugs-implemented-by-PR#48204,-PR#49519

mgr/prometheus: fix pool_objects_repaired and daemon_health_metrics format

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
2 years agoMerge pull request #51393 from adk3798/fix-related-service-logging
Adam King [Mon, 22 May 2023 14:16:48 +0000 (10:16 -0400)]
Merge pull request #51393 from adk3798/fix-related-service-logging

mgr/cephadm: lower log level when logging about related services

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #50657 from guits/remove-filestore-cv
Guillaume Abrioux [Mon, 22 May 2023 13:06:39 +0000 (15:06 +0200)]
Merge pull request #50657 from guits/remove-filestore-cv

ceph-volume: drop filestore support

2 years agorbd-wnbd: improve image map error message 51665/head
Lucian Petrut [Mon, 22 May 2023 10:01:19 +0000 (10:01 +0000)]
rbd-wnbd: improve image map error message

"rbd-wnbd map" commands are delegated to the centralized
ceph-rbd Windows service, which in turn will create the
actual image mapping. This allows the daemons to continue
running even after the current session ends.

rbd-wnbd communicates with the service through a named pipe.
If the operation fails, we're only getting an error code.

This change will print the according error message based on the
error code, suggesting the user to check the logs or use
foreground mode ("-f") for additional information.

We could also capture the entire subprocess console output and
print it in case of errors. This can be quite verbose, so we'll
keep it simple for now.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
2 years agoMerge pull request #51480 from sseshasa/wip-fix-pr48703-followup
Sridhar Seshasayee [Mon, 22 May 2023 11:07:53 +0000 (16:37 +0530)]
Merge pull request #51480 from sseshasa/wip-fix-pr48703-followup

osd/scheduler: Reset ephemeral changes to mClock built-in profile

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51646 from anthonyeleven/anthonyeleven/clean-up-cecil-the-seastore
Anthony D'Atri [Mon, 22 May 2023 09:52:29 +0000 (05:52 -0400)]
Merge pull request #51646 from anthonyeleven/anthonyeleven/clean-up-cecil-the-seastore

doc/dev/crimson: Improve crimson.rst

2 years agoRevert "mds: fix client isn't responding to mclientcaps(revoke)" 51661/head
Venky Shankar [Mon, 22 May 2023 09:35:57 +0000 (15:05 +0530)]
Revert "mds: fix client isn't responding to mclientcaps(revoke)"

Signed-off-by: Venky Shankar <vshankar@redhat.com>
2 years agodoc/dev/crimson: Improve crimson.rst 51646/head
Anthony D'Atri [Sun, 21 May 2023 12:39:56 +0000 (08:39 -0400)]
doc/dev/crimson: Improve crimson.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
2 years agomgr/dashboard: fix broken daemon details tab 51658/head
Nizamudeen A [Mon, 22 May 2023 08:11:00 +0000 (13:41 +0530)]
mgr/dashboard: fix broken daemon details tab

Fixes: https://tracker.ceph.com/issues/61329
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51552 from rhcs-dashboard/fix-61215-main
Nizamudeen A [Mon, 22 May 2023 07:11:24 +0000 (12:41 +0530)]
Merge pull request #51552 from rhcs-dashboard/fix-61215-main

mgr/dashboard: Status column in Cluster > Hosts shows empty

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51589 from rhcs-dashboard/services-running
Nizamudeen A [Mon, 22 May 2023 07:09:52 +0000 (12:39 +0530)]
Merge pull request #51589 from rhcs-dashboard/services-running

mgr/dashboard: merge running and size columns in services page

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51565 from rhcs-dashboard/helper-user-suspend
Nizamudeen A [Mon, 22 May 2023 07:07:49 +0000 (12:37 +0530)]
Merge pull request #51565 from rhcs-dashboard/helper-user-suspend

mgr/dashboard: add helper on the rgw user Suspended

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
2 years agoMerge pull request #51562 from rhcs-dashboard/fix-nan-undefined-values
Nizamudeen A [Mon, 22 May 2023 07:06:53 +0000 (12:36 +0530)]
Merge pull request #51562 from rhcs-dashboard/fix-nan-undefined-values

mgr/dashboard: fix Nan undefined values and add empty pipe on expand-cluster

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51553 from rhcs-dashboard/fix-61216-main
Nizamudeen A [Mon, 22 May 2023 07:05:20 +0000 (12:35 +0530)]
Merge pull request #51553 from rhcs-dashboard/fix-61216-main

mgr/dashboard: Show a helper for Unmanaged checkbox in service creation form

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51557 from rhcs-dashboard/fix-61222-main
Nizamudeen A [Mon, 22 May 2023 07:02:55 +0000 (12:32 +0530)]
Merge pull request #51557 from rhcs-dashboard/fix-61222-main

mgr/dashboard: show the host's IP address on Hosts page

Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51551 from rhcs-dashboard/keys-visibility
Nizamudeen A [Mon, 22 May 2023 06:54:35 +0000 (12:24 +0530)]
Merge pull request #51551 from rhcs-dashboard/keys-visibility

mgr/dashboard: more visibility for keys

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agoosd: use fmt::format_to(...) to fix FTBFS on gcc 13 50438/head
Tim Serong [Wed, 8 Mar 2023 02:45:57 +0000 (13:45 +1100)]
osd: use fmt::format_to(...) to fix FTBFS on gcc 13

Without this the build will fail on gcc 13 with errors like:

src/osd/scrubber/scrub_backend.cc:1309:14: error: call of overloaded 'format_to(std::back_insert_iterator<fmt::v9::basic_memory_buffer<char> >, const char [35], const char*, const uint64_t&, const uint64_t&, pg_shard_t&)' is ambiguous
  1309 |     format_to(std::back_inserter(out),
       |     ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~
  1310 |               "{}size {} != size {} from shard {}",
       |               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  1311 |               sep(error),
       |               ~~~~~~~~~~~
  1312 |               candidate.size,
       |               ~~~~~~~~~~~~~~~
  1313 |               auth.size,
       |               ~~~~~~~~~~
  1314 |               auth_shard);
       |               ~~~~~~~~~~~
 /usr/include/fmt/core.h:3233:17: note: candidate: 'OutputIt fmt::v9::format_to(OutputIt, format_string<T ...>, T&& ...) [with OutputIt = std::back_insert_iterator<basic_memory_buffer<char> >; T = {const char*, const long unsigned int&, const long unsigned int&, pg_shard_t&}; typename std::enable_if<detail::is_output_iterator<OutputIt, char>::value, int>::type <anonymous> = 0; format_string<T ...> = basic_format_string<char, const char*, const long unsigned int&, const long unsigned int&, pg_shard_t&>]'
 3233 | FMT_INLINE auto format_to(OutputIt out, format_string<T...> fmt, T&&... args)
      |                 ^~~~~~~~~
 /usr/include/c++/13/format:3761:5: note: candidate: '_Out std::format_to(_Out, format_string<_Args ...>, _Args&& ...) [with _Out = back_insert_iterator<fmt::v9::basic_memory_buffer<char> >; _Args = {const char*, const long unsigned int&, const long unsigned int&, pg_shard_t&}; format_string<_Args ...> = basic_format_string<char, const char*, const long unsigned int&, const long unsigned int&, pg_shard_t&>]'
  3761 |     format_to(_Out __out, format_string<_Args...> __fmt, _Args&&... __args)
       |     ^~~~~~~~~

Fixes: https://tracker.ceph.com/issues/58477
Signed-off-by: Tim Serong <tserong@suse.com>
2 years agoMerge pull request #51319 from rzarzynski/wip-doc-deprecate-cache-tiering
zdover23 [Mon, 22 May 2023 01:37:56 +0000 (11:37 +1000)]
Merge pull request #51319 from rzarzynski/wip-doc-deprecate-cache-tiering

doc: deprecate the cache tiering

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
2 years agodoc: note deprecation of Cache Tiering in Reef 51651/head
Zac Dover [Mon, 22 May 2023 01:35:26 +0000 (11:35 +1000)]
doc: note deprecation of Cache Tiering in Reef

Add a note to the documentation that cache tiering is deprecated in
Reef.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51452 from phlogistonjohn/jjm-cephadm-byte-compile
Adam King [Sun, 21 May 2023 20:20:43 +0000 (16:20 -0400)]
Merge pull request #51452 from phlogistonjohn/jjm-cephadm-byte-compile

cephadm: call compile_dir to byte compile zipapp py files

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #51321 from adk3798/no-mon-service
Adam King [Sun, 21 May 2023 19:55:23 +0000 (15:55 -0400)]
Merge pull request #51321 from adk3798/no-mon-service

mgr/cephadm: verify mon spec exists before trying to grab from spec store

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #51172 from adk3798/require-image-for-inspect
Adam King [Sun, 21 May 2023 19:42:36 +0000 (15:42 -0400)]
Merge pull request #51172 from adk3798/require-image-for-inspect

cephadm: require --image is passed to inspect-image

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #51618 from kavfixnel/main
Anthony D'Atri [Sat, 20 May 2023 21:32:28 +0000 (17:32 -0400)]
Merge pull request #51618 from kavfixnel/main

doc: Add missing `ceph` command in documentation section `REPLACING A…

2 years agodoc: Add missing `ceph` command in documentation section `REPLACING AN OSD` 51618/head
Alexander Proschek [Sat, 20 May 2023 21:06:09 +0000 (14:06 -0700)]
doc: Add missing `ceph` command in documentation section `REPLACING AN OSD`

Signed-off-by: Alexander Proschek <alexander.proschek@protonmail.com>
Signed-off-by: Alexander Proschek <alexander.proschek@protonmail.com>
2 years agoMerge pull request #51574 from phlogistonjohn/jjm-remove-extra-mypy
Adam King [Sat, 20 May 2023 15:09:07 +0000 (11:09 -0400)]
Merge pull request #51574 from phlogistonjohn/jjm-remove-extra-mypy

python-common: remove redundant call to mypy in tox.ini

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #50616 from batrick/i59120
Yuri Weinstein [Sat, 20 May 2023 14:04:13 +0000 (10:04 -0400)]
Merge pull request #50616 from batrick/i59120

qa: use parallel gzip for compressing logs

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agoMerge pull request #51594 from zdover23/wip-doc-2023-05-20-rados-operations-data...
zdover23 [Fri, 19 May 2023 17:12:45 +0000 (03:12 +1000)]
Merge pull request #51594 from zdover23/wip-doc-2023-05-20-rados-operations-data-placement

doc/rados: edit data-placement.rst

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agodoc/rados: edit data-placement.rst 51594/head
Zac Dover [Fri, 19 May 2023 16:26:45 +0000 (02:26 +1000)]
doc/rados: edit data-placement.rst

Edit doc/rados/data-placement.rst.

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51318 from Matan-B/wip-matanb-c-avoid-msg-con
Yuri Weinstein [Fri, 19 May 2023 16:16:56 +0000 (12:16 -0400)]
Merge pull request #51318 from Matan-B/wip-matanb-c-avoid-msg-con

crimson: Avoid any Message's connection usage

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Liu-Chunmei <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #50469 from ifed01/wip-ifed-fix-bluefs-prealloc
Yuri Weinstein [Fri, 19 May 2023 16:13:03 +0000 (12:13 -0400)]
Merge pull request #50469 from ifed01/wip-ifed-fix-bluefs-prealloc

os/bluestore: proper override rocksdb::WritableFile::Allocate

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2 years agoMerge pull request #50210 from NitzanMordhai/wip-nitzan-c-write-operations-inject...
Yuri Weinstein [Fri, 19 May 2023 16:11:48 +0000 (12:11 -0400)]
Merge pull request #50210 from NitzanMordhai/wip-nitzan-c-write-operations-inject-sockert

test/c_write_operations: set RETURNVEC on expected cmpext failure

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #45921 from trociny/wip-ceph-objectstore-tool-dump-data-dir
Yuri Weinstein [Fri, 19 May 2023 16:11:23 +0000 (12:11 -0400)]
Merge pull request #45921 from trociny/wip-ceph-objectstore-tool-dump-data-dir

tools/ceph-objectstore-tool: make dump-export optionally dump object data

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #45852 from brucen1030/wip_optimize_excl_lock_for_librbd
Yuri Weinstein [Fri, 19 May 2023 16:10:20 +0000 (12:10 -0400)]
Merge pull request #45852 from brucen1030/wip_optimize_excl_lock_for_librbd

osd: don't require RWEXCL lock for stat+write ops

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agoMerge pull request #51494 from cbodley/wip-61168
Casey Bodley [Fri, 19 May 2023 13:17:52 +0000 (09:17 -0400)]
Merge pull request #51494 from cbodley/wip-61168

qa/rgw: add POOL_APP_NOT_ENABLED to log-ignorelist

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
2 years agoMerge pull request #51582 from mdw-at-linuxbox/wip-main-unused
Casey Bodley [Fri, 19 May 2023 13:09:47 +0000 (09:09 -0400)]
Merge pull request #51582 from mdw-at-linuxbox/wip-main-unused

rgw: remove unused routine in rgw_admin

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agomgr/dashboard: merge running and size columns in services page 51589/head
Pere Diaz Bou [Fri, 19 May 2023 09:54:38 +0000 (11:54 +0200)]
mgr/dashboard: merge running and size columns in services page

Fixes: https://tracker.ceph.com/issues/61295
Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
2 years agoMerge pull request #51555 from rhcs-dashboard/rearrange-embedded-graphana-buttons
Nizamudeen A [Fri, 19 May 2023 09:30:04 +0000 (15:00 +0530)]
Merge pull request #51555 from rhcs-dashboard/rearrange-embedded-graphana-buttons

mgr/dashboard: fix spacing of embedded grafana buttons

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51533 from rhcs-dashboard/fix-tooltip-silence-form
Nizamudeen A [Fri, 19 May 2023 09:28:51 +0000 (14:58 +0530)]
Merge pull request #51533 from rhcs-dashboard/fix-tooltip-silence-form

mgr/dashboard: fix tooltip for alerts silence matchers

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51556 from rhcs-dashboard/disable-create-osd
Nizamudeen A [Fri, 19 May 2023 09:27:38 +0000 (14:57 +0530)]
Merge pull request #51556 from rhcs-dashboard/disable-create-osd

mgr/dashboard: add warning message on why osd creation disabled

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51541 from rhcs-dashboard/filter-hosts
Nizamudeen A [Fri, 19 May 2023 09:25:46 +0000 (14:55 +0530)]
Merge pull request #51541 from rhcs-dashboard/filter-hosts

mgr/dashboard: filte hosts by services

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agoMerge pull request #51532 from rhcs-dashboard/reorder-daemon-page
Nizamudeen A [Fri, 19 May 2023 09:23:25 +0000 (14:53 +0530)]
Merge pull request #51532 from rhcs-dashboard/reorder-daemon-page

mgr/dashboard: reorder rgw daemons list items

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
2 years agomgr/dashboard: Status column in Cluster > Hosts shows empty 51552/head
Aashish Sharma [Wed, 17 May 2023 12:07:41 +0000 (17:37 +0530)]
mgr/dashboard: Status column in Cluster > Hosts shows empty

Fixes: https://tracker.ceph.com/issues/61215
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agomgr/dashboard: show the host's IP address on Hosts page 51557/head
Aashish Sharma [Wed, 17 May 2023 13:40:35 +0000 (19:10 +0530)]
mgr/dashboard: show the host's IP address on Hosts page

Fixes: https://tracker.ceph.com/issues/61222
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agomgr/dashboard: more visibility for keys 51551/head
Nizamudeen A [Thu, 18 May 2023 08:14:01 +0000 (13:44 +0530)]
mgr/dashboard: more visibility for keys

Fixes: https://tracker.ceph.com/issues/61239
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: Show a helper for Unmanaged checkbox in service creation form 51553/head
Aashish Sharma [Wed, 17 May 2023 12:31:41 +0000 (18:01 +0530)]
mgr/dashboard: Show a helper for Unmanaged checkbox in service creation form

Fixes: https://tracker.ceph.com/issues/61216
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
2 years agoMerge pull request #51567 from rhcs-dashboard/remove-card-title
Nizamudeen A [Fri, 19 May 2023 08:34:35 +0000 (14:04 +0530)]
Merge pull request #51567 from rhcs-dashboard/remove-card-title

mgr/dashboard: remove title tooltip of cards landing page

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51362 from Svelar/filestore-drop
Ilya Dryomov [Fri, 19 May 2023 08:12:29 +0000 (10:12 +0200)]
Merge pull request #51362 from Svelar/filestore-drop

vstart: remove filestore options and config snippets

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51580 from zdover23/wip-doc-2023-04-19-radosgw-dynamicresharding
zdover23 [Fri, 19 May 2023 08:11:20 +0000 (18:11 +1000)]
Merge pull request #51580 from zdover23/wip-doc-2023-04-19-radosgw-dynamicresharding

doc/radosgw: explain multisite dynamic sharding

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/radosgw: explain multisite dynamic sharding 51580/head
Zac Dover [Thu, 18 May 2023 21:07:02 +0000 (07:07 +1000)]
doc/radosgw: explain multisite dynamic sharding

Add a note to doc/radosgw/dynamicresharding.rst and a note to
doc/radosgw/multisite.rst that explains that dynamic resharding is not
supported in releases prior to Reef.

This commit is made in response to a request from Mathias Chapelain.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51406 from votdev/issue_59689_sso_str_decode
Nizamudeen A [Fri, 19 May 2023 07:26:01 +0000 (12:56 +0530)]
Merge pull request #51406 from votdev/issue_59689_sso_str_decode

mgr/dashboard: SSO error: AttributeError: 'str' object has no attribute 'decode'

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Tim Serong <tserong@suse.com>
2 years agomgr/dashboard: fix spacing of embedded grafana buttons 51555/head
Pedro Gonzalez Gomez [Thu, 18 May 2023 10:10:11 +0000 (12:10 +0200)]
mgr/dashboard: fix spacing of embedded grafana buttons

Fixes: https://tracker.ceph.com/issues/61220
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agomgr/dashboard: fix Nan undefined values and add empty pipe on expand-cluster 51562/head
Pedro Gonzalez Gomez [Thu, 18 May 2023 11:47:16 +0000 (13:47 +0200)]
mgr/dashboard: fix Nan undefined values and add empty pipe on expand-cluster

Fixes: https://tracker.ceph.com/issues/61207
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agoMerge pull request #51564 from cloudbehl/rgeDeamonsGateway
Nizamudeen A [Fri, 19 May 2023 06:56:19 +0000 (12:26 +0530)]
Merge pull request #51564 from cloudbehl/rgeDeamonsGateway

mgr/dashboard: Change Daemons in Object Gateway section to Gateways

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51563 from rhcs-dashboard/encryption-defaults
Nizamudeen A [Fri, 19 May 2023 06:54:43 +0000 (12:24 +0530)]
Merge pull request #51563 from rhcs-dashboard/encryption-defaults

mgr/dashboard: put some default values on rgw encryption config form

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
2 years agoMerge pull request #51554 from rhcs-dashboard/roles-breadcrumbs
Nizamudeen A [Fri, 19 May 2023 06:47:17 +0000 (12:17 +0530)]
Merge pull request #51554 from rhcs-dashboard/roles-breadcrumbs

mgr/dashboard: fix rgw roles breadcrumbs

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agoMerge pull request #51550 from rhcs-dashboard/hide-selected-gw-dropdown
Nizamudeen A [Fri, 19 May 2023 06:43:28 +0000 (12:13 +0530)]
Merge pull request #51550 from rhcs-dashboard/hide-selected-gw-dropdown

mgr/dashboard: remove Selected Object Gateway dropdown

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agoMerge pull request #51546 from rhcs-dashboard/add-scroll-inside-tables
Nizamudeen A [Fri, 19 May 2023 06:42:13 +0000 (12:12 +0530)]
Merge pull request #51546 from rhcs-dashboard/add-scroll-inside-tables

mgr/dashboard: add-scroll-in-key-value-tables

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #51529 from rhcs-dashboard/encyrption-form-default
Nizamudeen A [Fri, 19 May 2023 06:39:45 +0000 (12:09 +0530)]
Merge pull request #51529 from rhcs-dashboard/encyrption-form-default

mgr/dashboard: default encryption type to sse-s3 in rgw

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
2 years agorgw: remove unused routine in rgw_admin 51582/head
Marcus Watts [Thu, 26 Aug 2021 09:08:00 +0000 (05:08 -0400)]
rgw: remove unused routine in rgw_admin

Routine "dump_bi_entry" contains logic to decode rgw_bucket_dir_entry
which can contain etags to be fixed.  However, it turns out this
routine is never called, so let's just get rid of it.  (The replacement
code lives in cls land.)

Fixes: https://tracker.ceph.com/issues/61260
Signed-off-by: Marcus Watts <mwatts@redhat.com>