]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agodoc/rados: edit bluestore-config-ref.rst (1 of x) 51790/head
Zac Dover [Fri, 26 May 2023 08:59:36 +0000 (18:59 +1000)]
doc/rados: edit bluestore-config-ref.rst (1 of x)

Edit the first part of doc/rados/configuration/bluestore-config-ref.rst.

https://tracker.ceph.com/issues/58485

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 3879e4ad417dddef1247521c199925a679d490ac)

2 years agoMerge pull request #51617 from adk3798/wip-59635-quincy
Adam King [Fri, 26 May 2023 21:06:30 +0000 (17:06 -0400)]
Merge pull request #51617 from adk3798/wip-59635-quincy

quincy: mgr/cephadm: allow configuring anonymous access for grafana

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #51664 from sseshasa/wip-61335-quincy
Yuri Weinstein [Fri, 26 May 2023 13:50:03 +0000 (09:50 -0400)]
Merge pull request #51664 from sseshasa/wip-61335-quincy

quincy: osd/scheduler: Reset ephemeral changes to mClock built-in profile

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51413 from kamoltat/wip-ksirivad-backport-quincy
Yuri Weinstein [Fri, 26 May 2023 13:48:55 +0000 (09:48 -0400)]
Merge pull request #51413 from kamoltat/wip-ksirivad-backport-quincy

quincy:mon/Monitor.cc: exit function if !osdmon()->is_writeable() && mon/OSDMonitor: Added extra check before mon.go_recovery_stretch_mode()

Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #50931 from ifed01/wip-ifed-fix-spillover-alert-qui
Yuri Weinstein [Fri, 26 May 2023 13:48:16 +0000 (09:48 -0400)]
Merge pull request #50931 from ifed01/wip-ifed-fix-spillover-alert-qui

quincy: os/bluestore: fix spillover alert

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2 years agoMerge pull request #49938 from NitzanMordhai/wip-58612-quincy
Yuri Weinstein [Fri, 26 May 2023 13:47:22 +0000 (09:47 -0400)]
Merge pull request #49938 from NitzanMordhai/wip-58612-quincy

quincy: Wip nitzan fixing few rados/test.sh

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #51129 from petrutlucian94/wip-59479-quincy
Ilya Dryomov [Fri, 26 May 2023 10:38:48 +0000 (12:38 +0200)]
Merge pull request #51129 from petrutlucian94/wip-59479-quincy

quincy: win32_deps_build: avoid pip

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agowin32_deps_build: avoid pip 51129/head
Lucian Petrut [Thu, 6 Apr 2023 11:05:47 +0000 (11:05 +0000)]
win32_deps_build: avoid pip

We're currently installing cython with pip when using Ubuntu
to cross compile Ceph for Windows. This can fail with recent
Python versions if attempting to use the global env:

  error: externally-managed-environment

  × This environment is externally managed
  ╰─> To install Python packages system-wide, try apt install
      python3-xyz, where xyz is the package you are trying to
      install.

Cython isn't really needed by the Windows build so we can go
ahead and drop it. We were hoping to use the Python bindings
on Windows, however Python extensions can't be cross compiled.

We're no longer using pip either, so we're dropping the dependency.
g++ was getting installed as a pip dependency, so we'll have to
include that instead. Note that g++ is used when building the boost
b2 tool.

While at it, we'll also ensure that git is installed.

Fixes: https://tracker.ceph.com/issues/59354
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
(cherry picked from commit 041618ea9b9b09b8dcf00170417b246eaaabce8b)

Conflicts:
win32_deps_build.sh
        -> commit 4954fe1 ("win32: add rhel option") not in quincy

[1] https://github.com/ceph/ceph/commit/4954fe19e5594ca5cac1d639fcfa49941abbbfa9

2 years agowin32: install wget when building on ubuntu
Ken Dreyer [Tue, 13 Sep 2022 16:44:18 +0000 (12:44 -0400)]
win32: install wget when building on ubuntu

The build process requires wget. Install this on Ubuntu platforms.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
(cherry picked from commit 1b4db7c477151d554a32fc937410d699318a290e)

2 years agowin32: install deps with DEBIAN_FRONTEND=noninteractive
Ken Dreyer [Tue, 13 Sep 2022 16:44:05 +0000 (12:44 -0400)]
win32: install deps with DEBIAN_FRONTEND=noninteractive

This simplifies the installation process when I run it in an interactive
terminal.

Signed-off-by: Ken Dreyer <kdreyer@redhat.com>
(cherry picked from commit 100990cfa628d20cceed5d74c6d2374f32dc58ff)

2 years agoMerge pull request #51728 from amathuria/wip-quincy-change-default-scrub-cost
Laura Flores [Thu, 25 May 2023 23:00:33 +0000 (18:00 -0500)]
Merge pull request #51728 from amathuria/wip-quincy-change-default-scrub-cost

quincy: osd: Change scrub cost in case of mClock scheduler

2 years agomgr/cephadm: allow configuring anonymous access for grafana 51617/head
Adam King [Tue, 21 Mar 2023 18:12:03 +0000 (14:12 -0400)]
mgr/cephadm: allow configuring anonymous access for grafana

In case users want to not allow anonymous viewers
to view the grafana dashboard but don't want to use
a full custom config

Fixes: https://tracker.ceph.com/issues/59117
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit e6690dde7b384d7d13e1a17119c648acfadee638)

2 years agoMerge pull request #50562 from ljflores/wip-59092-quincy
Laura Flores [Thu, 25 May 2023 15:04:23 +0000 (10:04 -0500)]
Merge pull request #50562 from ljflores/wip-59092-quincy

quincy: rgw: LDAP fix resource leak with wrong credentials

2 years agoMerge pull request #51616 from adk3798/wip-59630-quincy
Adam King [Thu, 25 May 2023 14:24:47 +0000 (10:24 -0400)]
Merge pull request #51616 from adk3798/wip-59630-quincy

quincy: mgr/cephadm: support for nfs backed by VIP

Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #51218 from adk3798/wip-59549-quincy
Adam King [Thu, 25 May 2023 14:23:36 +0000 (10:23 -0400)]
Merge pull request #51218 from adk3798/wip-59549-quincy

quincy: mgr/cephadm: asyncio based universal timeout for ssh/cephadm commands

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #51756 from zdover23/wip-doc-2023-05-25-backport-51754-to-quincy
Anthony D'Atri [Thu, 25 May 2023 11:14:22 +0000 (07:14 -0400)]
Merge pull request #51756 from zdover23/wip-doc-2023-05-25-backport-51754-to-quincy

quincy: doc/rados: fix link in common.rst

2 years agodoc/rados: fix link in common.rst 51756/head
Zac Dover [Thu, 25 May 2023 09:01:49 +0000 (19:01 +1000)]
doc/rados: fix link in common.rst

Fix a link in doc/rados/configuration/common.rst that was missing its
final letter, causing a 404 error when readers attempted to follow it.

This bug was reported by stalwart friend of the Ceph documentation
project Eugen Block, who is here credited as a co-author. This bug was
reported at https://pad.ceph.com/p/Report_Documentation_Bugs.

Co-authored-by: Eugen Block <eblock@nde.ag>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 8128ce20fef3d75c6251691d10af21861c01e155)

2 years agoMerge pull request #51752 from zdover23/wip-doc-2023-05-25-backport-51745-to-quincy
Anthony D'Atri [Thu, 25 May 2023 10:01:40 +0000 (06:01 -0400)]
Merge pull request #51752 from zdover23/wip-doc-2023-05-25-backport-51745-to-quincy

quincy: doc/rados: edit filestore-config-ref.rst

2 years agodoc/rados: edit filestore-config-ref.rst 51752/head
Zac Dover [Thu, 25 May 2023 00:16:51 +0000 (10:16 +1000)]
doc/rados: edit filestore-config-ref.rst

Edit doc/rados/configuration/filestore-config-ref.rst.

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 1202e4207bc182d83f193adb1557359d52687103)

2 years agoosd: mClock default_min reservation should be 0 51728/head
Aishwarya Mathuria [Tue, 23 May 2023 10:43:08 +0000 (16:13 +0530)]
osd: mClock default_min reservation should be 0

All the mClock profiles enforce no minimum reservation for the background best-effort client.
For this purpose, the default_min value should 0 and not 1.

Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
(cherry picked from commit 05848b4957713c5c98c249e15eb8de01d1c6a1e6)

2 years agoosd: Change scrub cost in case of mClock scheduler
Aishwarya Mathuria [Fri, 19 May 2023 11:46:11 +0000 (17:16 +0530)]
osd: Change scrub cost in case of mClock scheduler

With osd_op_queue as WPQ, high costs were assigned to scrub in order to throttle it effectively.
In the case of mClock scheduler, mClock parameters are used to do the throttling and the cost should represent a realistic value.

Fixes: https://tracker.ceph.com/issues/61313
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
(cherry picked from commit 43544d296c5fc14aaf638ddf21de9ea9d99f6059)

src/osd/OSD.cc: We are using osd_scrub_chunk_max in the scrub cost calculation here.

2 years agoMerge pull request #51740 from zdover23/wip-doc-2023-05-25-backport-50858-to-quincy
Anthony D'Atri [Thu, 25 May 2023 02:14:32 +0000 (22:14 -0400)]
Merge pull request #51740 from zdover23/wip-doc-2023-05-25-backport-50858-to-quincy

quincy: doc/rados/operations: Acting Set question

2 years agoMerge pull request #51743 from zdover23/wip-doc-2023-05-25-backport-51730-to-quincy
Anthony D'Atri [Thu, 25 May 2023 02:13:42 +0000 (22:13 -0400)]
Merge pull request #51743 from zdover23/wip-doc-2023-05-25-backport-51730-to-quincy

quincy: doc/rados/operations: Fix erasure-code-jerasure.rst fix

2 years agodoc/rados/operations: Fix erasure-code-jerasure.rst fix 51743/head
Anthony D'Atri [Wed, 24 May 2023 13:57:42 +0000 (09:57 -0400)]
doc/rados/operations: Fix erasure-code-jerasure.rst fix

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 2a3177e60d93742d3125f3ef0913dfeb8743e8bf)

2 years agodoc/rados/operations: Acting Set question 51740/head
Zac Dover [Tue, 4 Apr 2023 03:59:46 +0000 (13:59 +1000)]
doc/rados/operations: Acting Set question

Clear up a paragraph that describes the behavior of the Acting Set.

https://tracker.ceph.com/issues/58485

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 3bc9cfd83b3b836775433c7f1b075fe397b56463)

2 years agoMerge pull request #51568 from amathuria/wip-61231-quincy
Ilya Dryomov [Wed, 24 May 2023 20:41:13 +0000 (22:41 +0200)]
Merge pull request #51568 from amathuria/wip-61231-quincy

quincy: qa/tasks: Changing default mClock profile to high_recovery_ops

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51428 from idryomov/wip-59393-quincy
Ilya Dryomov [Wed, 24 May 2023 20:15:24 +0000 (22:15 +0200)]
Merge pull request #51428 from idryomov/wip-59393-quincy

quincy: librbd: localize snap_remove op for mirror snapshots

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2 years agoMerge pull request #51217 from adk3798/wip-59547-quincy
Adam King [Wed, 24 May 2023 19:40:10 +0000 (15:40 -0400)]
Merge pull request #51217 from adk3798/wip-59547-quincy

quincy: mgr/cephadm: allow setting mon crush locations through mon service spec

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #51455 from ajarr/wip-59711-quincy
Ilya Dryomov [Wed, 24 May 2023 18:12:02 +0000 (20:12 +0200)]
Merge pull request #51455 from ajarr/wip-59711-quincy

quincy:  mgr/rbd_support: recover from rados client blocklisting

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51060 from idryomov/wip-59431-quincy
Ilya Dryomov [Wed, 24 May 2023 18:10:42 +0000 (20:10 +0200)]
Merge pull request #51060 from idryomov/wip-59431-quincy

quincy: qa/suites/rbd: install qemu-utils in addition to qemu-block-extra on Ubuntu

Reviewed-by: Ramana Raja <rraja@redhat.com>
2 years agoMerge pull request #50920 from chrisphoffman/wip-59369-quincy
Ilya Dryomov [Wed, 24 May 2023 18:09:42 +0000 (20:09 +0200)]
Merge pull request #50920 from chrisphoffman/wip-59369-quincy

quincy: librbd: don't wait for a watch in send_acquire_lock() if client is blocklisted

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #50873 from idryomov/wip-59208-quincy
Ilya Dryomov [Wed, 24 May 2023 18:09:02 +0000 (20:09 +0200)]
Merge pull request #50873 from idryomov/wip-59208-quincy

quincy: librbd: fix wrong attribute for rbd_quiesce_complete api

Reviewed-by: Mykola Golub <mgolub@suse.com>
2 years agoMerge pull request #50837 from pkalever/wip-59062-quincy
Ilya Dryomov [Wed, 24 May 2023 18:07:47 +0000 (20:07 +0200)]
Merge pull request #50837 from pkalever/wip-59062-quincy

quincy: librbd: report better errors when failing to enable mirroring on an image

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51432 from Svelar/wip-59686-quincy
Adam King [Wed, 24 May 2023 18:06:21 +0000 (14:06 -0400)]
Merge pull request #51432 from Svelar/wip-59686-quincy

quincy: cephadm: eliminate duplication of sections

Reviewed-by: Adam King <adking@redhat.com>
2 years agolibrbd: localize snap_remove op for mirror snapshots 51428/head
Christopher Hoffman [Wed, 19 Apr 2023 15:26:27 +0000 (15:26 +0000)]
librbd: localize snap_remove op for mirror snapshots

A client may attempt a lock request not quickly enough to
obtain exclusive lock for operations when another competing
client responds quicker. This can happen when a peer site has
different performance characteristics or latency. Instead of
relying on this unpredictable behavior, localize operation to
primary cluster.

Fixes: https://tracker.ceph.com/issues/59393
Signed-off-by: Christopher Hoffman <choffman@redhat.com>
(cherry picked from commit ac552c9b4d65198db8038d397a3060d5a030917d)

Conflicts:
src/cls/rbd/cls_rbd.cc [ commit 3a93b40721a1 ("librbd:
  s/boost::variant/std::variant/") not in quincy ]
src/librbd/mirror/snapshot/UnlinkPeerRequest.cc [ ditto ]

2 years agoMerge pull request #51356 from rhcs-dashboard/wip-59632-quincy
Adam King [Wed, 24 May 2023 18:04:16 +0000 (14:04 -0400)]
Merge pull request #51356 from rhcs-dashboard/wip-59632-quincy

quincy: mgr/cephadm: update monitoring stack versions

Reviewed-by: Adam King <adking@redhat.com>
2 years agomgr/cephadm: asyncio based universal timeout for ssh/cephadm commands 51218/head
Adam King [Mon, 20 Mar 2023 19:31:12 +0000 (15:31 -0400)]
mgr/cephadm: asyncio based universal timeout for ssh/cephadm commands

Since we already have make use of asyncio for our ssh commands,
we can use asyncio's timeout on waiting for concurrent futures to complete
as a way to have universal timeouts on our cephadm commands.
This change also creates a contextmanager that will catch any asyncio.TimeoutError.
Using the contextmanager along with calls to the wait_async function
will catch any timeout exception raised and convert it into an appropriate
OrchetratorError including information about what and where for the timeout
if it was provided (host where run, what command). This allows us to guarantee a
background ssh command eventually returns and inform users of any
timeouts by raising a health warning or logging the error instead
of sitting idle indefinitely

Fixes: https://tracker.ceph.com/issues/54024
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit adf13c82ebb75a132709aa0b0bbc1d4fef7643a7)

Conflicts:
src/pybind/mgr/cephadm/services/osd.py
src/pybind/mgr/cephadm/tests/test_cephadm.py

2 years agoMerge pull request #51173 from idryomov/wip-58887-quincy
Ilya Dryomov [Wed, 24 May 2023 17:53:26 +0000 (19:53 +0200)]
Merge pull request #51173 from idryomov/wip-58887-quincy

quincy: librbd: remove previous incomplete primary snapshot after successfully creating a new one

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
2 years agomgr/cephadm: pass --timeout to cephadm binary commands
Adam King [Thu, 16 Mar 2023 18:20:48 +0000 (14:20 -0400)]
mgr/cephadm: pass --timeout to cephadm binary commands

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 00d4203ec60ed42840b1b318af49e4e697bd04f2)

2 years agomgr/cephadm: verify mon spec exists before trying to grab from spec store 51217/head
Adam King [Tue, 2 May 2023 22:59:18 +0000 (18:59 -0400)]
mgr/cephadm: verify mon spec exists before trying to grab from spec store

In a normal deployment, we generally shouldn't have
to worry about this. This is more for teuthology
which does deployments in a weird way that can cause
there to be no mon spec in the cluster. Fixes an issue
seen when backporting the mon crush location work
to quincy where an upgrade test would fail with

```
[WRN] UPGRADE_REDEPLOY_DAEMON: Upgrading daemon mon.b on host smithi047 failed.
    Upgrade daemon: mon.b: Service mon not found.
```

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 8aab7beefbb52f47573ad7fce932552ad5c0b2fa)

2 years agodoc/cephadm: document setting mon crush locations through spec
Adam King [Thu, 12 Jan 2023 20:13:15 +0000 (15:13 -0500)]
doc/cephadm: document setting mon crush locations through spec

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit cd96b70b676369298bfb06acb394d415918d0683)

2 years agoqa/suites/orch/cephadm: teuth test for mon crush locations
Adam King [Thu, 12 Jan 2023 20:00:12 +0000 (15:00 -0500)]
qa/suites/orch/cephadm: teuth test for mon crush locations

Trying to add a feature where mon crush locations
can be set through the orchestrator using the mon
service spec. This is meant to be a test for that.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 8c52a0a77b2ddad077d1de47ea67b89904e47e99)

2 years agomgr/cephadm: Set mon crush locations based on service spec
Adam King [Mon, 28 Nov 2022 16:59:59 +0000 (11:59 -0500)]
mgr/cephadm: Set mon crush locations based on service spec

The part of this that added the --set-crush-location flag
when deploying the mon was handled in another commit. This
piece is to finish the functionality by having cephadm set
the location through commands to handle when multiple
bucket=loc pairs are specified for a single monitor

Fixes: https://tracker.ceph.com/issues/58101
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 2672a719067bdc71486240e99d98e42678681d44)

2 years agomgr/cephadm: redo service level config when spec is updated
Adam King [Mon, 28 Nov 2022 19:14:58 +0000 (14:14 -0500)]
mgr/cephadm: redo service level config when spec is updated

Previously, the service config function was only called
when we deploy a new daemon for that service. That meant
that updates to the spec such as changing a cert that don't
affect the daemon placement wouldn't trigger the service level
config to happen again. With this change, we now mark
the service as needing its config function ran if a daemon
for the service is added/removed or if the spec is updated.

Fixes: https://tracker.ceph.com/issues/58100
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 1d50a2cdfb32b60b352cc03a83f8d1c35f2ae178)

2 years agomgr/cephadm: set --set-crush-location for mons based on crush location in spec
Adam King [Thu, 17 Nov 2022 11:42:33 +0000 (06:42 -0500)]
mgr/cephadm: set --set-crush-location for mons based on crush location in spec

Necessary to do this for stretch mode tiebreaker mon replacement

Fixes: https://tracker.ceph.com/issues/58101
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit ffec37156ffea174292ccabe6ede524333b30789)

2 years agopython-common/service_spec: introduce mon spec with new crush_locations field
Adam King [Thu, 10 Nov 2022 20:01:33 +0000 (15:01 -0500)]
python-common/service_spec: introduce mon spec with new crush_locations field

In order to allow having cephadm set the crush locations
for the mons. For helping with setting up stretch mode
with a cephadm cluster

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 416da86b04b6a35fdeae9105728c99020a0ce6df)

2 years agoMerge pull request #51216 from adk3798/wip-59545-quincy
Adam King [Wed, 24 May 2023 17:32:13 +0000 (13:32 -0400)]
Merge pull request #51216 from adk3798/wip-59545-quincy

quincy: cephadm: reschedule haproxy from an offline host

Reviewed-by: Michael Fritch <mfritch@suse.com>
2 years agoMerge pull request #51215 from adk3798/wip-59521-quincy
Adam King [Wed, 24 May 2023 17:30:53 +0000 (13:30 -0400)]
Merge pull request #51215 from adk3798/wip-59521-quincy

quincy: orchestrator: add `--no-destroy` arg to `ceph orch osd rm`

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>
2 years agoMerge pull request #51053 from adk3798/quincy-revert-cephadm-ceph-exporter
Adam King [Wed, 24 May 2023 17:29:34 +0000 (13:29 -0400)]
Merge pull request #51053 from adk3798/quincy-revert-cephadm-ceph-exporter

quincy: Revert "ceph-exporter: cephadm changes"

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
2 years agoMerge pull request #51329 from trociny/wip-59618-quincy
Mykola Golub [Wed, 24 May 2023 16:53:51 +0000 (19:53 +0300)]
Merge pull request #51329 from trociny/wip-59618-quincy

quincy: rgw/rados: check_quota() uses real bucket owner

2 years agoMerge pull request #51044 from kotreshhr/wip-59416-quincy
Yuri Weinstein [Wed, 24 May 2023 14:29:08 +0000 (10:29 -0400)]
Merge pull request #51044 from kotreshhr/wip-59416-quincy

quincy: mgr: Add one finisher thread per module

Reviewed-by: Kotresh HR <khiremat@redhat.com>
2 years agoMerge pull request #51300 from yuvalif/wip-yuval-bucket-name-quincy
Shilpa Jagannath [Wed, 24 May 2023 13:18:03 +0000 (09:18 -0400)]
Merge pull request #51300 from yuvalif/wip-yuval-bucket-name-quincy

quincy: rgw/lua: allow bucket name override in pre request

2 years agoMerge pull request #51726 from zdover23/wip-doc-2023-05-24-backport-51273-to-quincy
zdover23 [Wed, 24 May 2023 03:15:10 +0000 (13:15 +1000)]
Merge pull request #51726 from zdover23/wip-doc-2023-05-24-backport-51273-to-quincy

quincy: doc: Update jerasure.org references

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc: Update jerasure.org references 51726/head
Anthony D'Atri [Tue, 23 May 2023 23:13:33 +0000 (19:13 -0400)]
doc: Update jerasure.org references

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 5e60e0de275f7260aeae9e664ca22ebfdf8fc5f9)

2 years agoMerge pull request #51721 from zdover23/wip-doc-2023-05-24-backport-51679-to-quincy
Anthony D'Atri [Tue, 23 May 2023 22:29:02 +0000 (18:29 -0400)]
Merge pull request #51721 from zdover23/wip-doc-2023-05-24-backport-51679-to-quincy

quincy: doc/mgr: edit "leaderboard" in telemetry.rst

2 years agoMerge pull request #51653 from zdover23/wip-doc-2023-05-22-backport-51319-to-quincy
zdover23 [Tue, 23 May 2023 22:13:01 +0000 (08:13 +1000)]
Merge pull request #51653 from zdover23/wip-doc-2023-05-22-backport-51319-to-quincy

quincy: doc: deprecate the cache tiering

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
2 years agodoc/mgr: edit "leaderboard" in telemetry.rst 51721/head
Zac Dover [Mon, 22 May 2023 20:06:52 +0000 (06:06 +1000)]
doc/mgr: edit "leaderboard" in telemetry.rst

Standardize the presentation of commands in the "Leaderboard" section of
doc/mgr/telemetry.rst.

Follow-up to https://github.com/ceph/ceph/pull/50977

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4935ad8aed2aa796015473de5b38cc973ba85ba1)

2 years agoMerge pull request #51496 from cbodley/wip-55703-quincy
Yuri Weinstein [Tue, 23 May 2023 19:54:47 +0000 (15:54 -0400)]
Merge pull request #51496 from cbodley/wip-55703-quincy

quincy: rgw multisite: complete fix for metadata sync issue

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agoMerge pull request #50892 from cfsnyder/wip-58511-quincy
Yuri Weinstein [Tue, 23 May 2023 19:51:13 +0000 (15:51 -0400)]
Merge pull request #50892 from cfsnyder/wip-58511-quincy

quincy: rgw: optimizations for handling ECANCELED errors from within get_obj_state

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agoMerge pull request #50962 from yuvalif/wip-58284-quincy
Yuri Weinstein [Tue, 23 May 2023 19:49:15 +0000 (15:49 -0400)]
Merge pull request #50962 from yuvalif/wip-58284-quincy

quincy: rgw/notifications: send mtime in complete multipart upload event

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agoMerge pull request #50208 from cfsnyder/wip-58212-quincy
Yuri Weinstein [Tue, 23 May 2023 19:47:15 +0000 (15:47 -0400)]
Merge pull request #50208 from cfsnyder/wip-58212-quincy

quincy: rgw: concurrency for multi object deletes

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #49808 from yuvalif/wip-58285-quincy
Yuri Weinstein [Tue, 23 May 2023 19:46:17 +0000 (15:46 -0400)]
Merge pull request #49808 from yuvalif/wip-58285-quincy

quincy: rgw/notifications: sending metadata in COPY and CompleteMultipartUpload

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agoMerge pull request #51512 from Matan-B/wip-61150-quincy
Yuri Weinstein [Tue, 23 May 2023 15:21:28 +0000 (11:21 -0400)]
Merge pull request #51512 from Matan-B/wip-61150-quincy

quincy: OSD: Fix check_past_interval_bounds()

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51694 from zdover23/wip-doc-2023-05-23-backport-51682-to-quincy
Anthony D'Atri [Tue, 23 May 2023 12:10:56 +0000 (08:10 -0400)]
Merge pull request #51694 from zdover23/wip-doc-2023-05-23-backport-51682-to-quincy

quincy: doc/glossary: update bluestore entry

2 years agodoc/glossary: update bluestore entry 51694/head
Zac Dover [Mon, 22 May 2023 21:41:09 +0000 (07:41 +1000)]
doc/glossary: update bluestore entry

Update the BlueStore entry in the glossary, explaining that as of Reef
BlueStore and only BlueStore (and not FileStore) is the storage backend
for Ceph.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit bcee264276128f622c35e3aab81fdecb2b8afc10)

2 years agoMerge pull request #50979 from batrick/i59294
Yuri Weinstein [Mon, 22 May 2023 23:27:51 +0000 (19:27 -0400)]
Merge pull request #50979 from batrick/i59294

quincy: MgrMonitor: batch commit OSDMap and MgrMap mutations

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
2 years agoMerge pull request #50964 from ajarr/wip-58998-quincy
Yuri Weinstein [Mon, 22 May 2023 23:26:45 +0000 (19:26 -0400)]
Merge pull request #50964 from ajarr/wip-58998-quincy

quincy: mgr: store names of modules that register RADOS clients in the MgrMap

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
2 years agoMerge pull request #50893 from cfsnyder/wip-59329-quincy
Yuri Weinstein [Mon, 22 May 2023 23:26:10 +0000 (19:26 -0400)]
Merge pull request #50893 from cfsnyder/wip-59329-quincy

quincy: kv/RocksDBStore: Add CompactOnDeletion support

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2 years agoMerge pull request #50693 from kamoltat/wip-ksirivad-backport-quincy-50334
Yuri Weinstein [Mon, 22 May 2023 23:25:27 +0000 (19:25 -0400)]
Merge pull request #50693 from kamoltat/wip-ksirivad-backport-quincy-50334

quincy: pybind/mgr/pg_autoscaler: Reorderd if statement for the func: _maybe_adjust

Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #50480 from ljflores/wip-58954-quincy
Yuri Weinstein [Mon, 22 May 2023 23:24:51 +0000 (19:24 -0400)]
Merge pull request #50480 from ljflores/wip-58954-quincy

quincy: mgr/telemetry: make sure histograms are formatted in `all` commands

Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>
2 years agoqa/tasks: Allow override of recovery configs for tests 51664/head
Sridhar Seshasayee [Thu, 18 May 2023 09:18:09 +0000 (14:48 +0530)]
qa/tasks: Allow override of recovery configs for tests

With mClock scheduler enabled, a small subset of config options related
to recovery limits are not allowed to be modified unless
osd_mclock_override_recovery_settings option is enabled. This override
option is disabled by default. The following options cannot be modified
without enabling the override option:

 - osd_max_backfills
 - osd_recovery_max_active[_(hdd|ssd)]

The above options are removed from the mon kv store which effectively
restores them to the default values.

This was resulting in tests for example,
test_cluster_configuration.ClusterConfigurationTest to fail since it
modifies the recovery options and expects to verify the modified value.

Therefore, for tests, osd_mclock_override_recovery_settings option is
enabled in vstart_runner.py so that current and future tests
are not affected.

Fixes: https://tracker.ceph.com/issues/61155
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit aed71b56be3420d5e499453280e8aee017ce2dd5)

2 years agoosd/scheduler: Reset ephemeral changes to mClock built-in profile
Sridhar Seshasayee [Mon, 15 May 2023 07:16:54 +0000 (12:46 +0530)]
osd/scheduler: Reset ephemeral changes to mClock built-in profile

This is a follow-up to PR: https://github.com/ceph/ceph/pull/48703.
This commit also considers changes made ephemerally using either the
'daemon' or the 'tell' interfaces to override the built-in mClock
QoS parameters. In such a scenario, the ephemeral changes are removed
using the rm_val() method exposed by the config subsytem and logging
this information.

Other changes:

1. Add a standalone test to exercise the fix.
2. Add documentation note on the outcome of the attempt to modify
   built-in profile defaults.

Fixes: https://tracker.ceph.com/issues/61155
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit 414ac7dd2ce48d2a31f798e8df09bd3c975e95b1)

2 years agomon/MonCap: Allow default osd profile to run "config rm" with restriction
Sridhar Seshasayee [Tue, 16 May 2023 17:29:41 +0000 (22:59 +0530)]
mon/MonCap: Allow default osd profile to run "config rm" with restriction

This is a follow-up to PR: https://github.com/ceph/ceph/pull/48703.
Modify the mon caps to allow OSDs to run the "config rm" command with
restriction to remove only the following config keys from the mon store:
- osd_max_backfills
- osd_recovery_max_active(.*)
  - osd_recovery_max_active and
  - osd_recovery_max_active_(hdd|ssd)
- osd_mclock_scheduler_(.*) -> all the QoS specific config options.

The above is similar to the change in mon caps to run the "config set"
command as implemented in PR: https://github.com/ceph/ceph/pull/42853.

Fixes: https://tracker.ceph.com/issues/61155
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit 69160081eea908ba1d5841b6b827352515fb304e)

2 years agodoc: deprecate the cache tiering 51653/head
Radosław Zarzyński [Tue, 2 May 2023 15:52:23 +0000 (17:52 +0200)]
doc: deprecate the cache tiering

This topic has been discussed many times; recently at the Dev
Summit of Cephalocon 2023.

This commit is the minial version of the work, contained entirely
within the `doc`. However, likely it will be expanded as there
were ideas like e.g. adding cache tiering back experimental feature
list (Sam) to warn users when deploying a new cluster.

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
(cherry picked from commit 535b8db33ea03fbab7ef0c4df5251658f956b0c5)

2 years agoMerge pull request #51620 from zdover23/wip-doc-2023-05-21-backport-51618-to-quincy
zdover23 [Mon, 22 May 2023 01:27:31 +0000 (11:27 +1000)]
Merge pull request #51620 from zdover23/wip-doc-2023-05-21-backport-51618-to-quincy

quincy: doc: Add missing `ceph` command in documentation section `REPLACING A…

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agomgr/cephadm: lower log level when logging about related services 51616/head
Adam King [Mon, 8 May 2023 14:11:24 +0000 (10:11 -0400)]
mgr/cephadm: lower log level when logging about related services

This was recently added in https://github.com/ceph/ceph/commit/088d2c4205c599a7d4f2ce4de8e2af8e129adac8
and seems to work fine, but logging these things at info
level spams the log as every single service every serve
loop iteration is reporting on whether it has related
daemons. This changes it to only log when it finds
related daemons or when it prefers a host due to those
related daemons, and do both of those at only debug level.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 3693544e56b2480547c21575ab70ec2e67977b94)

2 years agodoc: Add missing `ceph` command in documentation section `REPLACING AN OSD` 51620/head
Alexander Proschek [Sat, 20 May 2023 21:06:09 +0000 (14:06 -0700)]
doc: Add missing `ceph` command in documentation section `REPLACING AN OSD`

Signed-off-by: Alexander Proschek <alexander.proschek@protonmail.com>
Signed-off-by: Alexander Proschek <alexander.proschek@protonmail.com>
(cherry picked from commit 0557d5e465556adba6d25db62a40ba55a5dd2400)

2 years agomgr/cephadm: prefer same hosts as related service daemons when picking arbitrary...
Adam King [Wed, 5 Apr 2023 00:45:23 +0000 (20:45 -0400)]
mgr/cephadm: prefer same hosts as related service daemons when picking arbitrary hosts

For now, just for linking ingress services and
their backend services. The idea is if one, or both,
of the ingress service and backend service is using a
count, to try and get them to deploy their daemons
on the same host(s). If the placements have explicit
placements (not using count) we still stick to
those placements regardless.

This should enable something like specifying a host
for the backend service and leaving the ingress
placement as just "count: 1" and having the ingress
service get on the same host as the backend service
daemon. This is particularly useful for the keepalive-only
(VIP but no haproxy) over NFS setup where the keepalive
must share a host with the NFS to function, but will
also be useful for other VIP only setups we may do
in the future.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 088d2c4205c599a7d4f2ce4de8e2af8e129adac8)

2 years agoqa/cephadm: teuth test for keepalive-only ingress over nfs
Adam King [Mon, 13 Mar 2023 20:50:14 +0000 (16:50 -0400)]
qa/cephadm: teuth test for keepalive-only ingress over nfs

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit e90583083379192cee1e6c58300dcadb3fd20376)

2 years agomgr/cephadm: unit test for keepalive only nfs conf
Adam King [Fri, 10 Feb 2023 03:02:33 +0000 (22:02 -0500)]
mgr/cephadm: unit test for keepalive only nfs conf

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit e104fdcd3af87bd770501de8486258df56a13251)

2 years agodoc/cephadm: document keepalive only nfs
Adam King [Fri, 10 Feb 2023 02:31:34 +0000 (21:31 -0500)]
doc/cephadm: document keepalive only nfs

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 5de3312dece60027070bf940e3746dc0769548ea)

2 years agomgr/cephadm: support for nfs backed by VIP
Adam King [Wed, 20 Jul 2022 21:55:07 +0000 (17:55 -0400)]
mgr/cephadm: support for nfs backed by VIP

Fixes: https://tracker.ceph.com/issues/55663
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit bb0a0f9d87f50b27c8b32aff8288f14fc3b97045)

2 years agoMerge pull request #51596 from zdover23/wip-doc-2023-05-20-backport-51594-to-quincy
zdover23 [Fri, 19 May 2023 20:19:48 +0000 (06:19 +1000)]
Merge pull request #51596 from zdover23/wip-doc-2023-05-20-backport-51594-to-quincy

quincy: doc/rados: edit data-placement.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: edit data-placement.rst 51596/head
Zac Dover [Fri, 19 May 2023 16:26:45 +0000 (02:26 +1000)]
doc/rados: edit data-placement.rst

Edit doc/rados/data-placement.rst.

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 32600c27c4dca6b9d5fae9892c0a1660b672781c)

2 years agoMerge pull request #51586 from zdover23/wip-doc-2023-05-19-backport-51580-to-quincy
Anthony D'Atri [Fri, 19 May 2023 12:13:53 +0000 (08:13 -0400)]
Merge pull request #51586 from zdover23/wip-doc-2023-05-19-backport-51580-to-quincy

quincy: doc/radosgw: explain multisite dynamic sharding

2 years agodoc/radosgw: explain multisite dynamic sharding 51586/head
Zac Dover [Thu, 18 May 2023 21:07:02 +0000 (07:07 +1000)]
doc/radosgw: explain multisite dynamic sharding

Add a note to doc/radosgw/dynamicresharding.rst and a note to
doc/radosgw/multisite.rst that explains that dynamic resharding is not
supported in releases prior to Reef.

This commit is made in response to a request from Mathias Chapelain.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d4ed4223d914328361528990f89f1ee4acd30e79)

2 years agoMerge pull request #51577 from zdover23/wip-doc-2023-05-19-backport-51572-to-quincy
Anthony D'Atri [Thu, 18 May 2023 22:42:16 +0000 (18:42 -0400)]
Merge pull request #51577 from zdover23/wip-doc-2023-05-19-backport-51572-to-quincy

quincy: doc/rados: line-edit devices.rst

2 years agodoc/rados: line-edit devices.rst 51577/head
Zac Dover [Thu, 18 May 2023 14:13:41 +0000 (00:13 +1000)]
doc/rados: line-edit devices.rst

Edit doc/rados/operations/devices.rst.

Co-authored-by: Cole Mitchell <cole.mitchell@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 8d589b43d76a4e291c96c3750d068dba18eb9309)

2 years agoMerge pull request #51490 from zdover23/wip-doc-2023-05-16-backport-51485-to-quincy
zdover23 [Thu, 18 May 2023 14:50:20 +0000 (00:50 +1000)]
Merge pull request #51490 from zdover23/wip-doc-2023-05-16-backport-51485-to-quincy

quincy: doc/start/os-recommendations: drop 4.14 kernel and reword guidance

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoqa/tasks: Change default mClock profile to high_recovery_ops 51568/head
Aishwarya Mathuria [Thu, 11 May 2023 17:20:15 +0000 (22:50 +0530)]
qa/tasks: Change default mClock profile to high_recovery_ops

With the new mClock default profile, tests were failing with "Exiting scrub checking -- not all pgs scrubbed" due to slower scrubs.
Changing the default profile to high_recovery_ops for testing purposes will fix this issue.

Fixes: https://tracker.ceph.com/issues/61228
Signed-off-by: Aishwarya Mathuria <amathuri@redhat.com>
(cherry picked from commit a7c0029eccdc1bb9c49a943ed4d62295197f0de0)

2 years agoMerge pull request #51543 from zdover23/wip-doc-2023-05-18-backport-51534-to-quincy
Anthony D'Atri [Wed, 17 May 2023 22:44:15 +0000 (18:44 -0400)]
Merge pull request #51543 from zdover23/wip-doc-2023-05-18-backport-51534-to-quincy

quincy: doc/cephfs: line-edit "Mirroring Module"

2 years agodoc/cephfs: line-edit "Mirroring Module" 51543/head
Zac Dover [Wed, 17 May 2023 12:25:38 +0000 (22:25 +1000)]
doc/cephfs: line-edit "Mirroring Module"

Line-edit the "Mirroring Module" section of
doc/cephfs/cephfs-mirroring.rst. Add prompts and formatting where such
things contribute to the realization of adequate sentences.

This commit is a follow-up to https://github.com/ceph/ceph/pull/51505.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dd8855d9a934bcdd6a026f1308ba7410b1e143e3)

2 years agoMerge pull request #51521 from zdover23/wip-doc-2023-05-17-backport-51505-to-quincy
Anthony D'Atri [Wed, 17 May 2023 12:56:56 +0000 (08:56 -0400)]
Merge pull request #51521 from zdover23/wip-doc-2023-05-17-backport-51505-to-quincy

quincy: doc: explain cephfs mirroring `peer_add` step in detail

2 years agoMerge pull request #51525 from aaSharma14/wip-61179-quincy
Nizamudeen A [Wed, 17 May 2023 12:30:18 +0000 (18:00 +0530)]
Merge pull request #51525 from aaSharma14/wip-61179-quincy

quincy: mgr/dashboard: fix regression caused by cephPgImabalance alert

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agomgr/dashboard: fix regression caused by cephPgImabalance alert 51525/head
Aashish Sharma [Mon, 8 May 2023 07:19:13 +0000 (12:49 +0530)]
mgr/dashboard: fix regression caused by cephPgImabalance alert

because of an earlier fix delivered, there is a regression caused by it
due to which alerts are not getting displayed in the active alerts tab.
This PR intends to fix this issue.

Fixes: https://tracker.ceph.com/issues/59666
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit d0a1431fb836f1dd227df85f9e75e098edfdeac9)

2 years agodoc: explain cephfs mirroring `peer_add` step in detail 51521/head
Venky Shankar [Tue, 16 May 2023 05:25:34 +0000 (10:55 +0530)]
doc: explain cephfs mirroring `peer_add` step in detail

@zdover23 reached out regarding missing explanation for `peer_add`
step in cephfs mirroring documentation. Add some explanation and
and example to make the step clear.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 6a6e887ff1f7f7d76db7f30f8410783b2f8153b0)

2 years agoMerge pull request #51503 from zdover23/wip-doc-2023-05-16-backport-51492-to-quincy
Anthony D'Atri [Wed, 17 May 2023 00:49:59 +0000 (20:49 -0400)]
Merge pull request #51503 from zdover23/wip-doc-2023-05-16-backport-51492-to-quincy

quincy: doc/start: KRBD feature flag support note

2 years agomessages/MOSDMap: Remove get_oldest/newest 51512/head
Matan Breizman [Wed, 1 Feb 2023 09:56:44 +0000 (09:56 +0000)]
messages/MOSDMap: Remove get_oldest/newest

cluster_osdmap_trim_lower_bound and newest_map are public.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit 0c5f02ed5c79232e81e4ce5e6656e7502acb0ac6)

2 years agocrimson/osd: Rename MOSDMap::oldest_map users
Matan Breizman [Wed, 1 Feb 2023 09:32:53 +0000 (09:32 +0000)]
crimson/osd: Rename MOSDMap::oldest_map users

Note: this commit was manually fixed (crimson only)

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit 3f92107d99f4ee6a521e994728418ce7cffd2d95)

2 years agomessages/MOSDMap: Rename oldest_map to cluster_osdmap_trim_lower_bound
Matan Breizman [Wed, 1 Feb 2023 08:49:19 +0000 (08:49 +0000)]
messages/MOSDMap: Rename oldest_map to cluster_osdmap_trim_lower_bound

Previously, MOSDMap messages sent to other OSDs were populated with the
superblocks's oldest_map. We should, instead, use the superblock's
cluster_osdmap_trim_lower_bound because oldest map is merely a marker
for each osd's trimming progress.

As specified in the docs:
***
We use cluster_osdmap_trim_lower_bound rather than a specific osd's oldest_map
because we don't necessarily trim all MOSDMap::oldest_map. In order to avoid
doing too much work at once we limit the amount of osdmaps trimmed using
``osd_target_transaction_size`` in OSD::trim_maps().
For this reason, a specific OSD's oldest_map can lag behind
OSDSuperblock::cluster_osdmap_trim_lower_bound
for a while.
***

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit 721c9aea1869bf95a167b8879756b4f71fbf41bf)