]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
2 years agorgw/test: allow passing vstart parameters to multisite tests script 52475/head
Yuval Lifshitz [Sun, 16 Jul 2023 16:52:47 +0000 (16:52 +0000)]
rgw/test: allow passing vstart parameters to multisite tests script

via the VSTART_PARAMETERS env variable

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
2 years agoMerge pull request #52465 from zdover23/wip-doc-2023-07-15-rados-configuration-ceph...
zdover23 [Sun, 16 Jul 2023 09:16:32 +0000 (19:16 +1000)]
Merge pull request #52465 from zdover23/wip-doc-2023-07-15-rados-configuration-ceph-conf-2-of-x

doc/rados: edit ceph-conf.rst (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: edit ceph-conf.rst (2 of x) 52465/head
Zac Dover [Sat, 15 Jul 2023 01:09:20 +0000 (11:09 +1000)]
doc/rados: edit ceph-conf.rst (2 of x)

Edit doc/rados/configuration/ceph-conf.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51317 from rishabh-d-dave/mdscaps-combinations
Rishabh Dave [Sat, 15 Jul 2023 02:35:56 +0000 (08:05 +0530)]
Merge pull request #51317 from rishabh-d-dave/mdscaps-combinations

mds: allow all types of mds capsq

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge pull request #52185 from YiteGu/raise-prio-before-queue-op
Yuri Weinstein [Fri, 14 Jul 2023 20:31:56 +0000 (16:31 -0400)]
Merge pull request #52185 from YiteGu/raise-prio-before-queue-op

osd/perf_counters: raise prio of before queue op perfcounter

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #52088 from gazdi31/fix_1
Yuri Weinstein [Fri, 14 Jul 2023 20:30:39 +0000 (16:30 -0400)]
Merge pull request #52088 from gazdi31/fix_1

mon/ConfigMonitor: update crush_location from osd entity

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #50393 from rhcs-dashboard/mirror-con
Yuri Weinstein [Fri, 14 Jul 2023 20:30:12 +0000 (16:30 -0400)]
Merge pull request #50393 from rhcs-dashboard/mirror-con

msgr: AsyncMessenger faulted connections metrics

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #50291 from batrick/i55606
Yuri Weinstein [Fri, 14 Jul 2023 20:28:40 +0000 (16:28 -0400)]
Merge pull request #50291 from batrick/i55606

pybind/mgr: reopen database handle on blocklist

Reviewed-by: Ramana Raja <rraja@redhat.com>
2 years agoMerge pull request #51947 from alimaredia/wip-counter-dump-array-add
Yuri Weinstein [Fri, 14 Jul 2023 20:26:00 +0000 (16:26 -0400)]
Merge pull request #51947 from alimaredia/wip-counter-dump-array-add

common: `counter dump` command revision

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
2 years agoMerge pull request #51493 from smanjara/wip-data-sync-fairness
Shilpa Jagannath [Fri, 14 Jul 2023 20:11:53 +0000 (16:11 -0400)]
Merge pull request #51493 from smanjara/wip-data-sync-fairness

rgw: data sync fairness

2 years agoMerge pull request #52431 from ronen-fr/wip-rf-fix-opsfmt
Casey Bodley [Fri, 14 Jul 2023 14:34:30 +0000 (10:34 -0400)]
Merge pull request #52431 from ronen-fr/wip-rf-fix-opsfmt

OSD, common: fix fmtlib v8 handling of OpSchedItem

Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51941 from Posrabi/wip-disk-frag-simulator
Adam Kupczyk [Fri, 14 Jul 2023 14:02:40 +0000 (16:02 +0200)]
Merge pull request #51941 from Posrabi/wip-disk-frag-simulator

test/objectstore: Fragmentation Simulator

2 years agosrc/tests/mds: improve test coverage in TestMDSAuthCaps 51317/head
Rishabh Dave [Tue, 9 May 2023 12:32:17 +0000 (18:02 +0530)]
src/tests/mds: improve test coverage in TestMDSAuthCaps

Currently we check if the right caps parse successfully and the wrong
caps fail to parse. Increase the test coverage by adding one more
tests -- dump the right caps in to a string after the parsing is
successfully and then re-parse the caps and check if re-parsed caps
dumps to the exact same string.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agosrc/tests/mds: add tests for all combinations of MDS caps
Rishabh Dave [Tue, 9 May 2023 09:00:37 +0000 (14:30 +0530)]
src/tests/mds: add tests for all combinations of MDS caps

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agomds: allow all types of MDS caps
Rishabh Dave [Sun, 30 Apr 2023 13:01:00 +0000 (18:31 +0530)]
mds: allow all types of MDS caps

MDS caps can contain 5 components: name of a CephFS, a path inside
CephFS, a flag for enabling root squashing mechanism, a UID and list of
GIDs. These 5 components result in 31 combinations, so there can be 31
types of MDS caps. Out of these, the current main branch only allows 11
combinations. This restriction is strange and inappropriate. Ideally,
all combinations should be allowed.

This strange restriction must've been created unintentionally by
previous developers while adding FS name and root squash to MDS caps. A
TODO for a allowing a subset of these combination was also left in
codebase:
https://github.com/ceph/ceph/blob/reef/src/mds/MDSAuthCaps.cc#L69

Fixes: https://tracker.ceph.com/issues/59388
Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agoMerge pull request #51879 from cloudbehl/pool-creation
Nizamudeen A [Fri, 14 Jul 2023 11:00:03 +0000 (16:30 +0530)]
Merge pull request #51879 from cloudbehl/pool-creation

mgr/dashboard: Create Default pool for Ceph Block

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #52402 from zdover23/wip-doc-2023-07-12-rados-operations-add-or...
zdover23 [Fri, 14 Jul 2023 09:04:23 +0000 (19:04 +1000)]
Merge pull request #52402 from zdover23/wip-doc-2023-07-12-rados-operations-add-or-rm-osds-2-of-x

doc/rados: edit add-or-rm-osds (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: edit add-or-rm-osds (2 of x) 52402/head
Zac Dover [Tue, 11 Jul 2023 21:58:59 +0000 (07:58 +1000)]
doc/rados: edit add-or-rm-osds (2 of x)

Edit doc/rados/operations/add-or-rm-osds.rst (2 of x).

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #52423 from zdover23/wip-doc-2023-07-13-rados-configuration-ceph...
zdover23 [Fri, 14 Jul 2023 07:57:19 +0000 (17:57 +1000)]
Merge pull request #52423 from zdover23/wip-doc-2023-07-13-rados-configuration-ceph-conf-1-of-x

doc/rados: edit ceph-conf.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agoMerge pull request #51831 from rhcs-dashboard/disable-promote
Nizamudeen A [Fri, 14 Jul 2023 07:24:23 +0000 (12:54 +0530)]
Merge pull request #51831 from rhcs-dashboard/disable-promote

mgr/dashboard: disable promote on mirroring not enabled

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #52351 from rhcs-dashboard/upgrade-ui
Nizamudeen A [Fri, 14 Jul 2023 05:55:59 +0000 (11:25 +0530)]
Merge pull request #52351 from rhcs-dashboard/upgrade-ui

mgr/dashboard: cluster upgrade base UI component

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
2 years agodoc/rados: edit ceph-conf.rst 52423/head
Zac Dover [Thu, 13 Jul 2023 08:41:51 +0000 (18:41 +1000)]
doc/rados: edit ceph-conf.rst

Edit doc/rados/configuration/ceph-conf.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #52420 from aravind-wdc/split_buf
Yingxin [Fri, 14 Jul 2023 03:53:53 +0000 (11:53 +0800)]
Merge pull request #52420 from aravind-wdc/split_buf

crimson/os/seastore/zbd: zbdsegmentmanager write path fixes.

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #52122 from adk3798/teuth-test-custom-config
Adam King [Thu, 13 Jul 2023 23:47:29 +0000 (19:47 -0400)]
Merge pull request #52122 from adk3798/teuth-test-custom-config

qa/cephadm: testing for extra daemon/container features

Reviewed-by: John Mulligan <jmulligan@redhat.com>
2 years agoMerge pull request #40787 from lxbsz/rename
Rishabh Dave [Thu, 13 Jul 2023 18:46:52 +0000 (00:16 +0530)]
Merge pull request #40787 from lxbsz/rename

client: wait rename to finish

Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2 years agoMerge pull request #52365 from rishabh-d-dave/mdsauthcaps-improve
Rishabh Dave [Thu, 13 Jul 2023 14:33:32 +0000 (20:03 +0530)]
Merge pull request #52365 from rishabh-d-dave/mdsauthcaps-improve

MDSAuthCaps: minor improvements

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
2 years agocommon: fix fmtlib v8 handling of OpSchedItem 52431/head
Ronen Friedman [Thu, 13 Jul 2023 13:57:08 +0000 (08:57 -0500)]
common: fix fmtlib v8 handling of OpSchedItem

by providing a formatter for Message & derivatives
that is implemented directly (not using operator<<).

This is only a first step, to be followed by an
implementation of a usable print() function for Message & co.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agocrimson/os/seastore/zbd: Split iovs in case of bigger buffer sizes. 52420/head
Aravind Ramesh [Tue, 11 Jul 2023 04:09:36 +0000 (06:09 +0200)]
crimson/os/seastore/zbd: Split iovs in case of bigger buffer sizes.

In Seastore's ZBDSegmentManager, during long running write workloads
if write buffer size exceeds max buf size(IOV_MAX, 16MB),
it was resulting in an assert:
ceph/src/include/buffer.h:1189 : In function 'void ceph::buffer::v15_2_0::list::prepare_iov(VectorT*) const [with VectorT = std::vector<iovec>]', ceph_assert(%s)

This case is handled in BlockSegmentManager by splitting the
IO vectors to appropriate sizes and assert does not happen.

Updated the ZBDSegmentManager to similarly split IO vectors to
appropriate size.

Signed-off-by: Aravind Ramesh <Aravind.Ramesh@wdc.com>
2 years agoMerge pull request #52223 from Matan-B/wip-matanb-crimson-pp-naming
Matan [Thu, 13 Jul 2023 13:00:33 +0000 (16:00 +0300)]
Merge pull request #52223 from Matan-B/wip-matanb-crimson-pp-naming

crimson/osd/osd_operations: consistent naming to pipeline users

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
2 years agoMerge PR #52356 into main
Patrick Donnelly [Thu, 13 Jul 2023 12:53:51 +0000 (08:53 -0400)]
Merge PR #52356 into main

* refs/pull/52356/head:
doc/cephfs: add note to isolate metadata pool osds

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
2 years agoMerge pull request #46960 from xdavidwu/client-readdir-performance
Rishabh Dave [Thu, 13 Jul 2023 12:33:43 +0000 (18:03 +0530)]
Merge pull request #46960 from xdavidwu/client-readdir-performance

client: readdir_r_cb: get rstat for dir only if using rbytes for size

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2 years agomgr/dashboard: Create Default pool for Ceph Block 51879/head
Ankush Behl [Thu, 1 Jun 2023 14:22:21 +0000 (19:52 +0530)]
mgr/dashboard: Create Default pool for Ceph Block

- Create Default pool "rbd" if your cluster doesn't have rbd pool
- Fix the messaging consistency between block images and block mirroring

Signed-off-by: Ankush Behl <cloudbehl@gmail.com>
2 years agomds-client: make client_dirsize_rbytes unchangeable in runtime 46960/head
Pinghao Wu [Thu, 14 Jul 2022 09:36:00 +0000 (17:36 +0800)]
mds-client: make client_dirsize_rbytes unchangeable in runtime

kclient also has this option, and is unchangeable unless remounted.
Let's keep parity with kclient.

Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
2 years agoclient: readdir_r_cb: get rstat for dir only if using rbytes for size
Pinghao Wu [Tue, 5 Jul 2022 08:19:26 +0000 (16:19 +0800)]
client: readdir_r_cb: get rstat for dir only if using rbytes for size

When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.

This fixes performance when `client_dirsize_rbytes` is off after #38222.

Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
2 years agoMerge pull request #52390 from xxhdx1985126/wip-61952
Yingxin [Thu, 13 Jul 2023 08:24:24 +0000 (16:24 +0800)]
Merge pull request #52390 from xxhdx1985126/wip-61952

crimson/os/object_data_handler: splitting right side doesn't mean splitting only one extent

Reviewed-by: Xinyu Huang <xinyu.huang@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agoMerge pull request #52352 from rhcs-dashboard/add-more-decimals
Nizamudeen A [Thu, 13 Jul 2023 08:23:01 +0000 (13:53 +0530)]
Merge pull request #52352 from rhcs-dashboard/add-more-decimals

mgr/dashboard: Add more decimals in latency graph

Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #52081 from YiteGu/mds-optracked-have-no-slow-op-threshold
Rishabh Dave [Thu, 13 Jul 2023 07:29:26 +0000 (12:59 +0530)]
Merge pull request #52081 from YiteGu/mds-optracked-have-no-slow-op-threshold

mds/MDSRank: Add set_history_slow_op_size_and_threshold for op_tracker

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
2 years agoMerge pull request #50569 from rishabh-d-dave/CephManager-in-CephFSTestCase
Rishabh Dave [Thu, 13 Jul 2023 07:14:22 +0000 (12:44 +0530)]
Merge pull request #50569 from rishabh-d-dave/CephManager-in-CephFSTestCase

qa/cephfs: add helper methods in CephFSTestCase

Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agomgr/dashboard: cluster upgrade base UI component 52351/head
Nizamudeen A [Fri, 7 Jul 2023 05:50:21 +0000 (11:20 +0530)]
mgr/dashboard: cluster upgrade base UI component

- Base layout for the Upgrade Component
- Shows the Upgrade available button when an upgrade is available

Fixes: https://tracker.ceph.com/issues/61927
Signed-off-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge PR #51959 into main
Venky Shankar [Thu, 13 Jul 2023 05:48:34 +0000 (11:18 +0530)]
Merge PR #51959 into main

* refs/pull/51959/head:
qa: test for session ls with filters
mds: session ls command appears twice in command listing

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge PR #51278 into main
Venky Shankar [Thu, 13 Jul 2023 05:47:16 +0000 (11:17 +0530)]
Merge PR #51278 into main

* refs/pull/51278/head:
mgr/snap_schedule: rephrase log message when pruning
doc: add note about snap-schedule snapshot retention
qa: test user defined number of snaps retention spec
mgr/snap_schedule: adapt test to new argument list
doc/cephfs: Add note how mds_max_snaps_per_dir affects snapshot retention
mgr/snap_schedule: Use mds_max_snaps_per_dir as snapshot count limit

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
2 years agoMerge PR #52175 into main
Venky Shankar [Thu, 13 Jul 2023 05:42:55 +0000 (11:12 +0530)]
Merge PR #52175 into main

* refs/pull/52175/head:
client: force sending cap revoke ack always

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #52419 from pcuzner/doc-fix
Anthony D'Atri [Thu, 13 Jul 2023 03:32:59 +0000 (23:32 -0400)]
Merge pull request #52419 from pcuzner/doc-fix

docs: fix nfs cluster create syntax

2 years agodocs: fix nfs cluster create syntax 52419/head
Paul Cuzner [Thu, 13 Jul 2023 03:13:42 +0000 (15:13 +1200)]
docs: fix nfs cluster create syntax

The ceph prefix was missing from the command
example.

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
2 years agoMerge pull request #52417 from cbodley/wip-61975
Casey Bodley [Wed, 12 Jul 2023 20:39:36 +0000 (16:39 -0400)]
Merge pull request #52417 from cbodley/wip-61975

osd: qualify fmt::format_to() for gcc13

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoMerge pull request #51909 from NitzanMordhai/wip-nitzan-divergent-priors-test-3-pick-osd
Yuri Weinstein [Wed, 12 Jul 2023 18:36:45 +0000 (14:36 -0400)]
Merge pull request #51909 from NitzanMordhai/wip-nitzan-divergent-priors-test-3-pick-osd

qa/standalone/osd/divergent-prior.sh: Divergent test 3 with pg_autoscale_mode on pick divergent osd

Reviewed-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
2 years agoMerge pull request #51782 from rzarzynski/wip-bs-stdfloor
Yuri Weinstein [Wed, 12 Jul 2023 18:35:51 +0000 (14:35 -0400)]
Merge pull request #51782 from rzarzynski/wip-bs-stdfloor

os/bluestore: specify namespace for the std::floor usage in BlueStore.h

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
2 years agoosd: qualify fmt::format_to() for gcc13 52417/head
Casey Bodley [Wed, 12 Jul 2023 17:30:28 +0000 (13:30 -0400)]
osd: qualify fmt::format_to() for gcc13

/home/cbodley/ceph/src/osd/scheduler/OpSchedulerItem.h:672:21: error: call of overloaded ‘format_to(fmt::v9::basic_format_context<fmt::v9::appender, char>::it
erator, const char [59], const spg_t&, std::string, class_t, unsigned int, const std::__cxx11::basic_string<char>&, int, epoch_t, const std::__cxx11::basic_st
ring<char>&)’ is ambiguous
  672 |     return format_to(
      |            ~~~~~~~~~^
  673 |         ctx.out(), "OpSchedulerItem({} {} class_id {} prio {}{} cost {} e{}{})",
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  674 |         opsi.get_ordering_token(), opsi.qitem->print(),
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  675 |         static_cast<class_t>(opsi.get_scheduler_class()), opsi.get_priority(),
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  676 |         qos_cost, opsi.get_cost(), opsi.get_map_epoch(), pushes);
      |         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/cbodley/ceph/src/fmt/include/fmt/core.h:3233:17: note: candidate: ‘OutputIt fmt::v9::format_to(OutputIt, format_string<T ...>, T&& ...) [with OutputIt =
 appender; T = {const spg_t&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, unsigned char, unsigned int, const std::__cxx11
::basic_string<char, std::char_traits<char>, std::allocator<char> >&, int, unsigned int, const std::__cxx11::basic_string<char, std::char_traits<char>, std::a
llocator<char> >&}; typename std::enable_if<detail::is_output_iterator<OutputIt, char>::value, int>::type <anonymous> = 0; format_string<T ...> = basic_format
_string<char, const spg_t&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, unsigned char, unsigned int, const std::__cxx11::
basic_string<char, std::char_traits<char>, std::allocator<char> >&, int, unsigned int, const std::__cxx11::basic_string<char, std::char_traits<char>, std::all
ocator<char> >&>]’
 3233 | FMT_INLINE auto format_to(OutputIt out, format_string<T...> fmt, T&&... args)
      |                 ^~~~~~~~~
/usr/include/c++/13/format:3745:5: note: candidate: ‘_Out std::format_to(_Out, format_string<_Args ...>, _Args&& ...) [with _Out = fmt::v9::appender; _Args =
{const spg_t&, __cxx11::basic_string<char, char_traits<char>, allocator<char> >, unsigned char, unsigned int, const __cxx11::basic_string<char, char_traits<ch
ar>, allocator<char> >&, int, unsigned int, const __cxx11::basic_string<char, char_traits<char>, allocator<char> >&}; format_string<_Args ...> = basic_format_
string<char, const spg_t&, __cxx11::basic_string<char, char_traits<char>, allocator<char> >, unsigned char, unsigned int, const __cxx11::basic_string<char, ch
ar_traits<char>, allocator<char> >&, int, unsigned int, const __cxx11::basic_string<char, char_traits<char>, allocator<char> >&>]’
 3745 |     format_to(_Out __out, format_string<_Args...> __fmt, _Args&&... __args)
      |     ^~~~~~~~~

Fixes: https://tracker.ceph.com/issues/61975
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #52370 from ronen-fr/wip-rf-opitem-fmt
Ronen Friedman [Wed, 12 Jul 2023 15:04:53 +0000 (18:04 +0300)]
Merge pull request #52370 from ronen-fr/wip-rf-opitem-fmt

osd: an fmtlib formatter for OpSchedulerItem

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #48672 from nokia/fix_do_cmake_python_for_rocky
Ilya Dryomov [Wed, 12 Jul 2023 09:07:12 +0000 (11:07 +0200)]
Merge pull request #48672 from nokia/fix_do_cmake_python_for_rocky

do_cmake.sh: build with correct python version on Rocky

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
2 years agocrimson/osd/osd_operations/pg_advance_map: peering_request_pg_pipeline getter 52223/head
Matan Breizman [Tue, 27 Jun 2023 07:05:28 +0000 (07:05 +0000)]
crimson/osd/osd_operations/pg_advance_map: peering_request_pg_pipeline getter

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agocrimson/osd/osd_operations: consistent naming to pipeline users
Matan Breizman [Wed, 28 Jun 2023 09:07:26 +0000 (09:07 +0000)]
crimson/osd/osd_operations: consistent naming to pipeline users

Rename pp/bp to client_pp or peering_pp.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
2 years agoMerge pull request #50706 from rhcs-dashboard/dashboard-import-export-multisite
Aashish Sharma [Wed, 12 Jul 2023 05:22:56 +0000 (10:52 +0530)]
Merge pull request #50706 from rhcs-dashboard/dashboard-import-export-multisite

mgr/dashboard:  import export functionality for RGW multisite

Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #52342 from ljflores/wip-whitelist-api
Nizamudeen A [Wed, 12 Jul 2023 04:51:45 +0000 (10:21 +0530)]
Merge pull request #52342 from ljflores/wip-whitelist-api

qa/tasks: set defer_client_eviction_on_laggy_osds=false in api tests

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agoMerge pull request #52224 from Matan-B/wip-matanb-unused-make-oid
Yuri Weinstein [Tue, 11 Jul 2023 22:15:02 +0000 (18:15 -0400)]
Merge pull request #52224 from Matan-B/wip-matanb-unused-make-oid

osd/OSD.h: cleanup unused make_*_oid methods

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #51573 from adamemerson/wip-boost-the-boost
Yuri Weinstein [Tue, 11 Jul 2023 22:14:27 +0000 (18:14 -0400)]
Merge pull request #51573 from adamemerson/wip-boost-the-boost

build: Bump boost to 1.82

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #51034 from rzarzynski/wip-bug-59429
Yuri Weinstein [Tue, 11 Jul 2023 22:13:34 +0000 (18:13 -0400)]
Merge pull request #51034 from rzarzynski/wip-bug-59429

crimson/osd: fix ENOENT on accessing RadosGW user's index of buckets

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agoMerge pull request #52345 from ljflores/wip-tracker-59057
Laura Flores [Tue, 11 Jul 2023 22:04:32 +0000 (17:04 -0500)]
Merge pull request #52345 from ljflores/wip-tracker-59057

qa/suites/rados/singleton/all: remove test_envlibrados_for_rocksdb

2 years agoMerge pull request #52020 from Dazul/cephadm-keepalived-choose-unicast-or-interface
Adam King [Tue, 11 Jul 2023 21:04:35 +0000 (17:04 -0400)]
Merge pull request #52020 from Dazul/cephadm-keepalived-choose-unicast-or-interface

cephadm: Split multicast interface and unicast_ip in keepalived.conf

Reviewed-by: Adam King <adking@redhat.com>
2 years agoMerge pull request #51880 from adk3798/host-unreachable-func
Adam King [Tue, 11 Jul 2023 20:56:56 +0000 (16:56 -0400)]
Merge pull request #51880 from adk3798/host-unreachable-func

mgr/cephadm: add is_host_<status> functions to HostCache

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agoMerge pull request #51718 from rkachach/fix_issue_57016
Adam King [Tue, 11 Jul 2023 20:55:14 +0000 (16:55 -0400)]
Merge pull request #51718 from rkachach/fix_issue_57016

Adding rollback mechanism to handle bootstrap failures

Reviewed-by: Adam King <adking@redhat.com>
2 years agoqa/tasks: set defer_client_eviction_on_laggy_osds=false in api tests 52342/head
Laura Flores [Thu, 6 Jul 2023 15:20:46 +0000 (10:20 -0500)]
qa/tasks: set defer_client_eviction_on_laggy_osds=false in api tests

We expect laggy OSDs in this testing environment,
so it makes sense to disable this warning.

Fixes: https://tracker.ceph.com/issues/61907
Signed-off-by: Laura Flores <lflores@redhat.com>
2 years agoMerge pull request #51472 from yuvalif/wip-yuval-fix-59738
Yuval Lifshitz [Tue, 11 Jul 2023 17:02:23 +0000 (20:02 +0300)]
Merge pull request #51472 from yuvalif/wip-yuval-fix-59738

rgw/lua: fix infinite loop in case of multimap iterations

2 years agoqa/cephadm: test for extra daemon features 52122/head
Adam King [Mon, 19 Jun 2023 18:24:23 +0000 (14:24 -0400)]
qa/cephadm: test for extra daemon features

Specifically, extra_container_args, extra_entrypoint_args,
and custom_configs.

This also provides testing for the CustomContainer
class which previously had no usage in any
of the teuthology tests

Signed-off-by: Adam King <adking@redhat.com>
2 years agopython-common/service_spec: add extra_entrypoint_args to CephExporter Spec
Adam King [Mon, 26 Jun 2023 20:42:52 +0000 (16:42 -0400)]
python-common/service_spec: add extra_entrypoint_args to CephExporter Spec

Similar to the mon, there's no reason for Ceph Exporter
in particular not to have this, it's just missing because
of the timing of when it was merged in.

Signed-off-by: Adam King <adking@redhat.com>
2 years agomgr/cephadm: add extra_entrypoint_args to mon spec
Adam King [Mon, 19 Jun 2023 20:07:31 +0000 (16:07 -0400)]
mgr/cephadm: add extra_entrypoint_args to mon spec

There was no reason for the mon spec to not include
this option. I believe this was just an oversight caused
by the addition of the mon spec and extra_entrypoint_args
in separate PRs around the same time.

Signed-off-by: Adam King <adking@redhat.com>
2 years agomgr/cephadm: add extra_container_args and custom_configs to CustomContainer
Adam King [Mon, 19 Jun 2023 19:46:45 +0000 (15:46 -0400)]
mgr/cephadm: add extra_container_args and custom_configs to CustomContainer

CustomContainer was skipped previously for the extra_container_args
and custom_configs feature as these could already be done
using other fields within the custom container service spec
(the "args" and "files" fields respectively). It seems
desirable for us to allow setting these things for custom
containers the same as for other services for uniformity sake
and this allows us to use custom containers to test
these features.

Signed-off-by: Adam King <adking@redhat.com>
2 years agodoc/cephfs: add note to isolate metadata pool osds 52356/head
Patrick Donnelly [Fri, 7 Jul 2023 12:42:58 +0000 (08:42 -0400)]
doc/cephfs: add note to isolate metadata pool osds

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
2 years agoMerge pull request #52300 from cbodley/wip-rgw-zonegroup-feature-compress-encrypted
Casey Bodley [Tue, 11 Jul 2023 12:26:20 +0000 (08:26 -0400)]
Merge pull request #52300 from cbodley/wip-rgw-zonegroup-feature-compress-encrypted

rgw: require zonegroup feature to compress encrypted objects

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
2 years agoMerge pull request #52222 from rhcs-dashboard/cluster-upgrade-apis
Nizamudeen A [Tue, 11 Jul 2023 10:19:55 +0000 (15:49 +0530)]
Merge pull request #52222 from rhcs-dashboard/cluster-upgrade-apis

mgr/dashboard: expose cluster upgrade  API endpoints

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
2 years agocrimson/os/seastore/zbd: increase padding byte buffer size.
Aravind Ramesh [Wed, 5 Jul 2023 16:58:24 +0000 (18:58 +0200)]
crimson/os/seastore/zbd: increase padding byte buffer size.

Before closing a segment, seastore writes a tail information
at the end of the segment, since ZBD zones are serially write
required, if a zone is not fully written to the end, it writes
padding bytes till the tail section.
Increase the size of write chunks to reduce the number of writes.

Signed-off-by: Aravind Ramesh <aravind.ramesh@wdc.com>
2 years agocrimson/os/object_data_handler: splitting right side doesn't mean 52390/head
Xuehan Xu [Tue, 11 Jul 2023 08:22:59 +0000 (16:22 +0800)]
crimson/os/object_data_handler: splitting right side doesn't mean
splitting only one extent

Fixes: https://tracker.ceph.com/issues/61952
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
2 years agoMerge pull request #52306 from cyx1231st/wip-seastar-multi-core-osd-cleanup
Matan [Tue, 11 Jul 2023 06:59:08 +0000 (09:59 +0300)]
Merge pull request #52306 from cyx1231st/wip-seastar-multi-core-osd-cleanup

crimson/osd: fixes and cleanups around multi-core OSD

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
2 years agoMerge pull request #52355 from rhcs-dashboard/cleanup-script-remove-dash-cephadm-e2e
Nizamudeen A [Tue, 11 Jul 2023 05:01:18 +0000 (10:31 +0530)]
Merge pull request #52355 from rhcs-dashboard/cleanup-script-remove-dash-cephadm-e2e

mgr/dashboard: move cephadm e2e cleanup to jenkins job config

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
2 years agoMerge pull request #52366 from zdover23/wip-doc-2023-07-09-rados-operations-add-or...
zdover23 [Mon, 10 Jul 2023 22:03:57 +0000 (08:03 +1000)]
Merge pull request #52366 from zdover23/wip-doc-2023-07-09-rados-operations-add-or-rm-osds-1-of-x

doc/rados: edit add-or-rm-osds (1 of x)

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agodoc/rados: edit add-or-rm-osds (1 of x) 52366/head
Zac Dover [Sun, 9 Jul 2023 02:50:11 +0000 (12:50 +1000)]
doc/rados: edit add-or-rm-osds (1 of x)

Edit docs/rados/operations/add-or-rm-osds.

Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #52371 from zdover23/wip-doc-2023-07-10-rados-troubleshooting...
zdover23 [Mon, 10 Jul 2023 19:05:44 +0000 (05:05 +1000)]
Merge pull request #52371 from zdover23/wip-doc-2023-07-10-rados-troubleshooting-mon-emdash

doc/rados: introduce emdash

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
2 years agomgr/dashboard: Add more decimals in latency graph 52352/head
Pedro Gonzalez Gomez [Fri, 7 Jul 2023 08:07:56 +0000 (10:07 +0200)]
mgr/dashboard: Add more decimals in latency graph
Fixes: https://tracker.ceph.com/issues/61930
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
2 years agoMerge pull request #52338 from vedanshbhartia/coverity_1512094
Soumya Koduri [Mon, 10 Jul 2023 17:35:57 +0000 (23:05 +0530)]
Merge pull request #52338 from vedanshbhartia/coverity_1512094

rgw: Add check for whether RGWObjState was created in dbstore.cc

Reviewed-by: Soumya Koduri <skoduri@redhat.com>
2 years agoMerge pull request #52372 from soumyakoduri/wip-skoduri-lc-acl
Daniel Gryniewicz [Mon, 10 Jul 2023 14:00:41 +0000 (10:00 -0400)]
Merge pull request #52372 from soumyakoduri/wip-skoduri-lc-acl

rgw/dbstore: Do not update mtime for attr change

reviewed-by: Daniel Gryniewicz <dang@redhat.com>

2 years agoMerge pull request #52369 from zhscn/wip-transaction-conflict
Yingxin [Mon, 10 Jul 2023 09:16:02 +0000 (17:16 +0800)]
Merge pull request #52369 from zhscn/wip-transaction-conflict

crimson/os/seastore: add metrics about total invalidated transactions

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
2 years agorgw/dbstore: Do not update mtime for attr change 52372/head
Soumya Koduri [Fri, 7 Jul 2023 11:05:57 +0000 (16:35 +0530)]
rgw/dbstore: Do not update mtime for attr change

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
2 years agoMerge pull request #52091 from cyx1231st/wip-seastar-msgr-multi-core-perf
Yingxin [Mon, 10 Jul 2023 03:07:20 +0000 (11:07 +0800)]
Merge pull request #52091 from cyx1231st/wip-seastar-msgr-multi-core-perf

crimson/tools/perf_crimson_msgr: integrate multi-core msgr with various improvements

Reviewed-by: Samuel Just <sjust@redhat.com>
2 years agocrimson/os/seastore: add metrics about total invalidated transactions 52369/head
Zhang Song [Sun, 9 Jul 2023 04:22:58 +0000 (12:22 +0800)]
crimson/os/seastore: add metrics about total invalidated transactions

Signed-off-by: Zhang Song <zhangsong325@gmail.com>
2 years agodoc/rados: introduce emdash 52371/head
Zac Dover [Mon, 10 Jul 2023 02:26:04 +0000 (12:26 +1000)]
doc/rados: introduce emdash

Introduce the emdash character in
docs/rados/troubleshooting/troubleshooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoosd: an fmtlib formatter for OpSchedulerItem 52370/head
Ronen Friedman [Sun, 9 Jul 2023 09:41:54 +0000 (04:41 -0500)]
osd: an fmtlib formatter for OpSchedulerItem

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
2 years agoMerge pull request #52327 from batrick/i61865
zdover23 [Sun, 9 Jul 2023 02:54:02 +0000 (12:54 +1000)]
Merge pull request #52327 from batrick/i61865

doc: add information on expediting MDS recovery

Reviewed-by: Zac Dover <zac.dover@proton.me>
2 years agoMDSAuthCaps: use string and vector directly 52365/head
Rishabh Dave [Sat, 24 Jun 2023 04:15:03 +0000 (09:45 +0530)]
MDSAuthCaps: use string and vector directly

Since std::string and std::vector are brought into the current namespace
at the beginning of MDSAuthCaps.cc, write "string" and "vector" instead
of "std::string" and "std::vector" respectively.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
2 years agoMerge pull request #51781 from rzarzynski/wip-bs-no-inc-in-middle
Yuri Weinstein [Fri, 7 Jul 2023 21:10:03 +0000 (17:10 -0400)]
Merge pull request #51781 from rzarzynski/wip-bs-no-inc-in-middle

os/bluestore: get rid of inclusion-in-the-middle from BlueStore.cc

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2 years agoMerge pull request #51275 from mchangir/mon-block-osd-pool-mksnap-for-fs-pools
Yuri Weinstein [Fri, 7 Jul 2023 21:09:07 +0000 (17:09 -0400)]
Merge pull request #51275 from mchangir/mon-block-osd-pool-mksnap-for-fs-pools

mon: block osd pool mksnap for fs pools

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
2 years agoMerge pull request #50326 from ifed01/wip-ifed-better-osd-robust
Yuri Weinstein [Fri, 7 Jul 2023 21:08:35 +0000 (17:08 -0400)]
Merge pull request #50326 from ifed01/wip-ifed-better-osd-robust

osd: improve OSD robustness.

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
2 years agoMerge pull request #52360 from zdover23/wip-doc-2023-07-08-radosgw-multisite
zdover23 [Fri, 7 Jul 2023 19:05:43 +0000 (05:05 +1000)]
Merge pull request #52360 from zdover23/wip-doc-2023-07-08-radosgw-multisite

doc/radosgw: add Zonegroup policy explanation

Reviewed-by: Casey Bodley <cbodley@redhat.com>
2 years agoPendingReleaseNotes: note rgw's compress-encrypted zonegroup feature flag 52300/head
Casey Bodley [Mon, 3 Jul 2023 19:06:29 +0000 (15:06 -0400)]
PendingReleaseNotes: note rgw's compress-encrypted zonegroup feature flag

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agodoc/rgw: document compress-encrypted zonegroup feature flag
Casey Bodley [Mon, 3 Jul 2023 18:59:51 +0000 (14:59 -0400)]
doc/rgw: document compress-encrypted zonegroup feature flag

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agoMerge pull request #52301 from adk3798/cephadm-fix-rgw-migration
Adam King [Fri, 7 Jul 2023 18:33:11 +0000 (14:33 -0400)]
Merge pull request #52301 from adk3798/cephadm-fix-rgw-migration

mgr/cephadm: fix rgw spec migration with simple specs

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
2 years agorgw: require zonegroup feature to compress encrypted objects
Casey Bodley [Mon, 3 Jul 2023 19:00:17 +0000 (15:00 -0400)]
rgw: require zonegroup feature to compress encrypted objects

Reef adds support for combining server-side encryption and compression,
but previous releases would not replicate such objects correctly. gate
the feature behind a zonegroup feature flag to require that all zones
upgrade to reef before enabling. this feature is not enabled by default
in new zonegroups

Fixes: https://tracker.ceph.com/issues/57905
Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agodoc/rgw: don't capitalize zonegroup feature flags
Casey Bodley [Mon, 3 Jul 2023 18:59:24 +0000 (14:59 -0400)]
doc/rgw: don't capitalize zonegroup feature flags

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agorgw: don't enable all zone features by default
Casey Bodley [Fri, 7 Jul 2023 17:00:06 +0000 (13:00 -0400)]
rgw: don't enable all zone features by default

on zonegroup creation, all `supported` features get enabled by default.
however, some features should remain opt-in. add a separate list of
`enabled` features for the subset of features we want enabled by default
on zonegroup creation

Signed-off-by: Casey Bodley <cbodley@redhat.com>
2 years agodoc/radosgw: add Zonegroup policy explanation 52360/head
Zac Dover [Fri, 7 Jul 2023 17:35:15 +0000 (03:35 +1000)]
doc/radosgw: add Zonegroup policy explanation

Add revised Zonegroup policy for "multi-zonegroups". This commit
includes changes that Casey Bodley made in
https://github.com/ceph/ceph/pull/52324#discussion_r1253482258 and that
I have integrated into the docs only now.

Co-authored-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
2 years agoMerge pull request #51863 from phlogistonjohn/jjm-cephadm-argument-spec
Adam King [Fri, 7 Jul 2023 15:11:40 +0000 (11:11 -0400)]
Merge pull request #51863 from phlogistonjohn/jjm-cephadm-argument-spec

cephadm: add a new ArgumentSpec type for advanced argument handling

Reviewed-by: Adam King <adking@redhat.com>