]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Ronen Friedman [Sat, 22 Jul 2023 15:27:55 +0000 (10:27 -0500)]
cephx: initializing two member variables in the ctors
Eliminating compiler warnings.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
zdover23 [Sat, 22 Jul 2023 05:25:32 +0000 (15:25 +1000)]
Merge pull request #52542 from zdover23/wip-doc-2023-07-19-rados-configuration-ceph-conf-3-of-x
doc/rados: edit ceph-conf.rst (3 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 19 Jul 2023 13:00:38 +0000 (23:00 +1000)]
doc/rados: edit ceph-conf.rst (3 of x)
Edit doc/rados/configuration/ceph-conf.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Fri, 21 Jul 2023 14:18:33 +0000 (10:18 -0400)]
Merge pull request #52475 from yuvalif/wip-yuval-multisite-vstart-params
rgw/test: allow passing vstart parameters to multisite tests script
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Ilya Dryomov [Fri, 21 Jul 2023 10:14:57 +0000 (12:14 +0200)]
Merge pull request #52057 from nbalacha/tracker-61672
rbd-mirror: fix race preventing local image deletion
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
Yuri Weinstein [Thu, 20 Jul 2023 21:46:56 +0000 (17:46 -0400)]
Merge pull request #52025 from rzarzynski/wip-ec-drop-unused-requires_overwrite
osd: drop the unused ECTransaction::requires_overwrite()
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
Ilya Dryomov [Thu, 20 Jul 2023 20:56:21 +0000 (22:56 +0200)]
Merge pull request #52491 from cbodley/wip-61566
valgrind: replace suppression for EVP_DecryptFinal_ex
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Ilya Dryomov [Thu, 20 Jul 2023 19:03:19 +0000 (21:03 +0200)]
Merge pull request #52427 from petrutlucian94/fix_win32_boost
win32_deps_build: skip patching removed boost files
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Casey Bodley [Thu, 20 Jul 2023 18:51:05 +0000 (14:51 -0400)]
Merge pull request #52143 from cbodley/wip-61567
test/pybind: replace nose with pytest
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Anthony D'Atri [Thu, 20 Jul 2023 17:54:43 +0000 (13:54 -0400)]
Merge pull request #52563 from zdover23/wip-doc-2023-07-21-governance-orman-email-update
doc: governance.rst - update D Orman
Zac Dover [Thu, 20 Jul 2023 17:35:52 +0000 (03:35 +1000)]
doc: governance.rst - update D Orman
Update David Orman's email address in doc/governance.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Laura Flores [Thu, 20 Jul 2023 17:19:41 +0000 (12:19 -0500)]
Merge pull request #52544 from rhcs-dashboard/debug-make-check
install-deps: remove the legacy resolver flags
Casey Bodley [Thu, 20 Jul 2023 13:23:52 +0000 (09:23 -0400)]
valgrind: remove stale openssl suppressions
years ago in commit
fe97a000990632dbe9734e0d3a96df627f104f7a , the
signature of authenticated_decrypt_update_final() changed and this
suppression no longer matches its mangled form:
- fun:_ZN4ceph6crypto6onwire25AES128GCM_OnWireRxHandler34authenticated_decrypt_update_finalEONS_6buffer7v*4listEj
+ fun:_ZN4ceph6crypto6onwire25AES128GCM_OnWireRxHandler34authenticated_decrypt_update_finalERNS_6buffer7v15_2_04listE
the fact that we didn't notice must mean that we don't need the
suppressions anymore
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Yuri Weinstein [Thu, 20 Jul 2023 14:26:10 +0000 (10:26 -0400)]
Merge pull request #52374 from rosinL/wip-cleanup
crush/CrushLocation: remove useless flag
Reviewed-by: Samuel Just <sjust@redhat.com>
Casey Bodley [Wed, 19 Jul 2023 17:19:46 +0000 (13:19 -0400)]
valgrind: suppress uninitialized value in OpenSSL
Fixes: https://tracker.ceph.com/issues/61566
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Nizamudeen A [Wed, 19 Jul 2023 14:05:05 +0000 (19:35 +0530)]
install-deps: remove the legacy resolver flags
This was a workaround that was introduced long time ago. This will be
something that could be deprectaed at some point [1]. And its preventing some of the dependencies to be
downloaded or stored into the wheelhouse. Deps like jsonschema, parse,
mypy, cryptography etc.
[1] https://pip.pypa.io/en/latest/user_guide/#deprecation-timeline
Fixes: https://tracker.ceph.com/issues/62082
Signed-off-by: Nizamudeen A <nia@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 16:10:32 +0000 (12:10 -0400)]
Merge pull request #49332 from shreyanshjain7174/stuck_peering
mon: stuck peering since warning is misleading
Reviewed-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 16:06:32 +0000 (12:06 -0400)]
Merge pull request #51438 from NitzanMordhai/wip-nitzan-cbt-perf-ci
cbt perf ci
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 16:06:05 +0000 (12:06 -0400)]
Merge pull request #50301 from liuqinfei/support_compile_on_openeuler_main
ceph.spec.in: add support for openEuler OS
Reviewed-by: Rongqi Sun <sunrongqi@huawei.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 16:04:08 +0000 (12:04 -0400)]
Merge pull request #49480 from flyingcircusio/fix-mon-delete-iterator
mon: fix iterator mishandling in PGMap::apply_incremental
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 16:00:45 +0000 (12:00 -0400)]
Merge pull request #52021 from xxhdx1985126/wip-61650
osd/PeeringState: recheck pg readability when renewing leases for no-replica pools
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Wed, 19 Jul 2023 15:33:28 +0000 (11:33 -0400)]
Merge pull request #50441 from cbodley/wip-qa-distros-centos9
qa/distros: add centos stream 9 as supported distro
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Ilya Dryomov [Wed, 19 Jul 2023 09:41:55 +0000 (11:41 +0200)]
Merge pull request #52124 from idryomov/wip-61733
mon/MonClient: resurrect original client_mount_timeout handling
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Matan [Wed, 19 Jul 2023 07:45:15 +0000 (10:45 +0300)]
Merge pull request #52266 from amathuria/wip-crimson-amat-fix-config-show
crimson/mgr: Fix config show command
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Venky Shankar [Tue, 18 Jul 2023 14:45:24 +0000 (20:15 +0530)]
Merge PR #51539 into main
* refs/pull/51539/head:
doc: users now need to provide scrub_mdsdir and recursive flags
qa: add recursive flag to test_flag_scrub_mdsdir
mds: remove code to bypass dumping empty header scrub info
mds: dump_values no more needed
mds: enqueue ~mdsdir at the time of enqueing root
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Casey Bodley [Tue, 18 Jul 2023 13:28:48 +0000 (09:28 -0400)]
Merge pull request #51700 from cfsnyder/wip-cfsnyder-put-404
rgw: fix consistency bug with OLH objects
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Lucian Petrut [Fri, 14 Jul 2023 10:16:47 +0000 (10:16 +0000)]
test/common: skip unittest_back_trace with mingw-gcc
We're getting an ICE when trying to compile this test using
mingw-gcc and recent Boost versions. Note that mingw-llvm works fine.
during IPA pass: inline
/mnt/data/workspace/ceph.pr/src/test/common/test_back_trace.cc:44:1:
internal compiler error: Segmentation fault
44 | }
| ^
0x7f9c4a86c51f ???
./signal/../sysdeps/unix/sysv/linux/x86_64/libc_sigaction.c:0
0x7f9c4a853d8f __libc_start_call_main
../sysdeps/x86/libc-start.c:58
0x7f9c4a853e3f __libc_start_main_impl
../sysdeps/nptl/libc_start_call_main.h:392
For now, we'll just skip the test when using mingw-gcc. Note
that we're planing to switch to mingw-llvm anyway:
https://github.com/ceph/ceph/pull/51197
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Lucian Petrut [Thu, 13 Jul 2023 10:48:14 +0000 (10:48 +0000)]
win32_deps_build: skip patching removed boost files
We're attempting to patch some Python files that have been removed
from recent Boost versions.
Now that the Boost version has been bumped, we'll need to address
this in order to unblock the Windows build.
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
Adam Kupczyk [Tue, 18 Jul 2023 12:27:24 +0000 (14:27 +0200)]
Merge pull request #52193 from aclamk/wip-aclamk-fix-55260
os/bluestore: Fixes ceph-bluestore-tool bluefs-bdev-new-db
Venky Shankar [Tue, 18 Jul 2023 10:40:24 +0000 (16:10 +0530)]
Merge PR #52173 into main
* refs/pull/52173/head:
mds: MDLog::_recovery_thread: handle the errors gracefully
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Casey Bodley [Wed, 21 Jun 2023 12:08:58 +0000 (08:08 -0400)]
qa/suites: install pytest for pybind tasks
Signed-off-by: Casey Bodley <cbodley@redhat.com>
zdover23 [Mon, 17 Jul 2023 13:19:46 +0000 (23:19 +1000)]
Merge pull request #52483 from bluikko/patch-15
doc/mgr/rgw.rst: add missing "ceph" command in cli specification
Reviewed-by: Zac Dover <zac.dover@proton.me>
Ville Ojamo [Mon, 17 Jul 2023 13:05:39 +0000 (20:05 +0700)]
doc/mgr/rgw.rst: add missing "ceph" command in cli specification
The line begins with a prompt so I would
expect it to be a "complete" command,
including the `ceph` binary to run with all
the various listed arguments.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Venky Shankar [Mon, 17 Jul 2023 08:29:40 +0000 (13:59 +0530)]
Merge PR #51383 into main
* refs/pull/51383/head:
client: clean up the queue_cap_snap() code to remove unnecessary check
client: always add one new capsnap if Fb is used and Fw is not used
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Mon, 17 Jul 2023 08:27:41 +0000 (13:57 +0530)]
Merge PR #51850 into main
* refs/pull/51850/head:
client: do not send metrics until the MDS rank is ready
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Guillaume Abrioux [Mon, 17 Jul 2023 07:21:34 +0000 (09:21 +0200)]
Merge pull request #52422 from guits/cv-add-raw-osd-id-param
ceph-volume: add --osd-id option to raw prepare
zdover23 [Mon, 17 Jul 2023 06:50:14 +0000 (16:50 +1000)]
Merge pull request #52476 from bluikko/patch-14
doc/mgr/rgw.rst: fix multisite typed wrong
Reviewed-by: Rongqi Sun (Svelar) <sunrongqi@huawei.co>
Ville Ojamo [Mon, 17 Jul 2023 03:35:46 +0000 (10:35 +0700)]
doc/mgr/rgw.rst: multisite typed wrong
Multisite is typed wrong as mutlisite so fix the spelling.
Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
Yuval Lifshitz [Sun, 16 Jul 2023 16:52:47 +0000 (16:52 +0000)]
rgw/test: allow passing vstart parameters to multisite tests script
via the VSTART_PARAMETERS env variable
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
zdover23 [Sun, 16 Jul 2023 09:16:32 +0000 (19:16 +1000)]
Merge pull request #52465 from zdover23/wip-doc-2023-07-15-rados-configuration-ceph-conf-2-of-x
doc/rados: edit ceph-conf.rst (2 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sat, 15 Jul 2023 01:09:20 +0000 (11:09 +1000)]
doc/rados: edit ceph-conf.rst (2 of x)
Edit doc/rados/configuration/ceph-conf.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Rishabh Dave [Sat, 15 Jul 2023 02:35:56 +0000 (08:05 +0530)]
Merge pull request #51317 from rishabh-d-dave/mdscaps-combinations
mds: allow all types of mds capsq
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Yuri Weinstein [Fri, 14 Jul 2023 20:31:56 +0000 (16:31 -0400)]
Merge pull request #52185 from YiteGu/raise-prio-before-queue-op
osd/perf_counters: raise prio of before queue op perfcounter
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Fri, 14 Jul 2023 20:30:39 +0000 (16:30 -0400)]
Merge pull request #52088 from gazdi31/fix_1
mon/ConfigMonitor: update crush_location from osd entity
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Fri, 14 Jul 2023 20:30:12 +0000 (16:30 -0400)]
Merge pull request #50393 from rhcs-dashboard/mirror-con
msgr: AsyncMessenger faulted connections metrics
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Yuri Weinstein [Fri, 14 Jul 2023 20:28:40 +0000 (16:28 -0400)]
Merge pull request #50291 from batrick/i55606
pybind/mgr: reopen database handle on blocklist
Reviewed-by: Ramana Raja <rraja@redhat.com>
Yuri Weinstein [Fri, 14 Jul 2023 20:26:00 +0000 (16:26 -0400)]
Merge pull request #51947 from alimaredia/wip-counter-dump-array-add
common: `counter dump` command revision
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Shilpa Jagannath [Fri, 14 Jul 2023 20:11:53 +0000 (16:11 -0400)]
Merge pull request #51493 from smanjara/wip-data-sync-fairness
rgw: data sync fairness
Casey Bodley [Fri, 14 Jul 2023 14:34:30 +0000 (10:34 -0400)]
Merge pull request #52431 from ronen-fr/wip-rf-fix-opsfmt
OSD, common: fix fmtlib v8 handling of OpSchedItem
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Adam Kupczyk [Fri, 14 Jul 2023 14:02:40 +0000 (16:02 +0200)]
Merge pull request #51941 from Posrabi/wip-disk-frag-simulator
test/objectstore: Fragmentation Simulator
Rishabh Dave [Tue, 9 May 2023 12:32:17 +0000 (18:02 +0530)]
src/tests/mds: improve test coverage in TestMDSAuthCaps
Currently we check if the right caps parse successfully and the wrong
caps fail to parse. Increase the test coverage by adding one more
tests -- dump the right caps in to a string after the parsing is
successfully and then re-parse the caps and check if re-parsed caps
dumps to the exact same string.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Tue, 9 May 2023 09:00:37 +0000 (14:30 +0530)]
src/tests/mds: add tests for all combinations of MDS caps
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Sun, 30 Apr 2023 13:01:00 +0000 (18:31 +0530)]
mds: allow all types of MDS caps
MDS caps can contain 5 components: name of a CephFS, a path inside
CephFS, a flag for enabling root squashing mechanism, a UID and list of
GIDs. These 5 components result in 31 combinations, so there can be 31
types of MDS caps. Out of these, the current main branch only allows 11
combinations. This restriction is strange and inappropriate. Ideally,
all combinations should be allowed.
This strange restriction must've been created unintentionally by
previous developers while adding FS name and root squash to MDS caps. A
TODO for a allowing a subset of these combination was also left in
codebase:
https://github.com/ceph/ceph/blob/reef/src/mds/MDSAuthCaps.cc#L69
Fixes: https://tracker.ceph.com/issues/59388
Signed-off-by: Rishabh Dave <ridave@redhat.com>
N Balachandran [Fri, 14 Jul 2023 12:56:15 +0000 (18:26 +0530)]
rbd-mirror: fix race preventing local image deletion
On primary image deletion, a race between InstanceReplayer::release_image()
(which calls ImageReplayer::stop())and ImageReplayer::handle_bootstrap()
may prevent the non-primary image from being deleted. Because
ImageReplayer::handle_bootstrap() checks if the start has been canceled
before processing -ENOLINK, m_delete_requested is not set to true and the
local image is not deleted.
This commit sets m_delete_requested to true before checking if the
start has been canceled to ensure that the image is deleted during shut_down,
and updates ImageReplayer::bootstrap() to cancel the BootstrapRequest
and prevent a potentially long time spent in an image sync if ImageReplayer
stop is requested.
Fixes: https://tracker.ceph.com/issues/61672
Signed-off-by: N Balachandran <nibalach@redhat.com>
Cory Snyder [Wed, 12 Jul 2023 14:08:07 +0000 (14:08 +0000)]
rgw: fix/improve test_rgw_versioning.py tests
Signed-off-by: Cory Snyder <csnyder@1111systems.com>
Nizamudeen A [Fri, 14 Jul 2023 11:00:03 +0000 (16:30 +0530)]
Merge pull request #51879 from cloudbehl/pool-creation
mgr/dashboard: Create Default pool for Ceph Block
Reviewed-by: Nizamudeen A <nia@redhat.com>
zdover23 [Fri, 14 Jul 2023 09:04:23 +0000 (19:04 +1000)]
Merge pull request #52402 from zdover23/wip-doc-2023-07-12-rados-operations-add-or-rm-osds-2-of-x
doc/rados: edit add-or-rm-osds (2 of x)
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Tue, 11 Jul 2023 21:58:59 +0000 (07:58 +1000)]
doc/rados: edit add-or-rm-osds (2 of x)
Edit doc/rados/operations/add-or-rm-osds.rst (2 of x).
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Fri, 14 Jul 2023 07:57:19 +0000 (17:57 +1000)]
Merge pull request #52423 from zdover23/wip-doc-2023-07-13-rados-configuration-ceph-conf-1-of-x
doc/rados: edit ceph-conf.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Nizamudeen A [Fri, 14 Jul 2023 07:24:23 +0000 (12:54 +0530)]
Merge pull request #51831 from rhcs-dashboard/disable-promote
mgr/dashboard: disable promote on mirroring not enabled
Reviewed-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Fri, 14 Jul 2023 05:55:59 +0000 (11:25 +0530)]
Merge pull request #52351 from rhcs-dashboard/upgrade-ui
mgr/dashboard: cluster upgrade base UI component
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Zac Dover [Thu, 13 Jul 2023 08:41:51 +0000 (18:41 +1000)]
doc/rados: edit ceph-conf.rst
Edit doc/rados/configuration/ceph-conf.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Yingxin [Fri, 14 Jul 2023 03:53:53 +0000 (11:53 +0800)]
Merge pull request #52420 from aravind-wdc/split_buf
crimson/os/seastore/zbd: zbdsegmentmanager write path fixes.
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Adam King [Thu, 13 Jul 2023 23:47:29 +0000 (19:47 -0400)]
Merge pull request #52122 from adk3798/teuth-test-custom-config
qa/cephadm: testing for extra daemon/container features
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Rishabh Dave [Thu, 13 Jul 2023 18:46:52 +0000 (00:16 +0530)]
Merge pull request #40787 from lxbsz/rename
client: wait rename to finish
Reviewed-by: Kefu Chai <kchai@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Thu, 13 Jul 2023 14:33:32 +0000 (20:03 +0530)]
Merge pull request #52365 from rishabh-d-dave/mdsauthcaps-improve
MDSAuthCaps: minor improvements
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Ronen Friedman [Thu, 13 Jul 2023 13:57:08 +0000 (08:57 -0500)]
common: fix fmtlib v8 handling of OpSchedItem
by providing a formatter for Message & derivatives
that is implemented directly (not using operator<<).
This is only a first step, to be followed by an
implementation of a usable print() function for Message & co.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Aravind Ramesh [Tue, 11 Jul 2023 04:09:36 +0000 (06:09 +0200)]
crimson/os/seastore/zbd: Split iovs in case of bigger buffer sizes.
In Seastore's ZBDSegmentManager, during long running write workloads
if write buffer size exceeds max buf size(IOV_MAX, 16MB),
it was resulting in an assert:
ceph/src/include/buffer.h:1189 : In function 'void ceph::buffer::v15_2_0::list::prepare_iov(VectorT*) const [with VectorT = std::vector<iovec>]', ceph_assert(%s)
This case is handled in BlockSegmentManager by splitting the
IO vectors to appropriate sizes and assert does not happen.
Updated the ZBDSegmentManager to similarly split IO vectors to
appropriate size.
Signed-off-by: Aravind Ramesh <Aravind.Ramesh@wdc.com>
Matan [Thu, 13 Jul 2023 13:00:33 +0000 (16:00 +0300)]
Merge pull request #52223 from Matan-B/wip-matanb-crimson-pp-naming
crimson/osd/osd_operations: consistent naming to pipeline users
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
Patrick Donnelly [Thu, 13 Jul 2023 12:53:51 +0000 (08:53 -0400)]
Merge PR #52356 into main
* refs/pull/52356/head:
doc/cephfs: add note to isolate metadata pool osds
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Jos Collin [Fri, 23 Jun 2023 06:16:26 +0000 (11:46 +0530)]
mds: MDLog::_recovery_thread: handle the errors gracefully
A write fails if the MDS is already blocklisted due to the 'fs fail' issued by the qa tests.
Handle those write failures gracefully, even when the MDS is stopping.
Fixes: https://tracker.ceph.com/issues/61201
Signed-off-by: Jos Collin <jcollin@redhat.com>
Rishabh Dave [Thu, 13 Jul 2023 12:33:43 +0000 (18:03 +0530)]
Merge pull request #46960 from xdavidwu/client-readdir-performance
client: readdir_r_cb: get rstat for dir only if using rbytes for size
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Ankush Behl [Thu, 1 Jun 2023 14:22:21 +0000 (19:52 +0530)]
mgr/dashboard: Create Default pool for Ceph Block
- Create Default pool "rbd" if your cluster doesn't have rbd pool
- Fix the messaging consistency between block images and block mirroring
Signed-off-by: Ankush Behl <cloudbehl@gmail.com>
Pinghao Wu [Thu, 14 Jul 2022 09:36:00 +0000 (17:36 +0800)]
mds-client: make client_dirsize_rbytes unchangeable in runtime
kclient also has this option, and is unchangeable unless remounted.
Let's keep parity with kclient.
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
Pinghao Wu [Tue, 5 Jul 2022 08:19:26 +0000 (16:19 +0800)]
client: readdir_r_cb: get rstat for dir only if using rbytes for size
When `client_dirsize_rbytes` is off, there should be no need for getting
rstat on readdir operations.
This fixes performance when `client_dirsize_rbytes` is off after #38222.
Fixes: https://tracker.ceph.com/issues/61999
Signed-off-by: Pinghao Wu <xdavidwuph@gmail.com>
Yingxin [Thu, 13 Jul 2023 08:24:24 +0000 (16:24 +0800)]
Merge pull request #52390 from xxhdx1985126/wip-61952
crimson/os/object_data_handler: splitting right side doesn't mean splitting only one extent
Reviewed-by: Xinyu Huang <xinyu.huang@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Nizamudeen A [Thu, 13 Jul 2023 08:23:01 +0000 (13:53 +0530)]
Merge pull request #52352 from rhcs-dashboard/add-more-decimals
mgr/dashboard: Add more decimals in latency graph
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Guillaume Abrioux [Thu, 13 Jul 2023 08:09:03 +0000 (08:09 +0000)]
ceph-volume: add --osd-id option to raw prepare
This adds the support of the --osd-id option to the raw prepare command.
Fixes: https://tracker.ceph.com/issues/61995
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
Rishabh Dave [Thu, 13 Jul 2023 07:29:26 +0000 (12:59 +0530)]
Merge pull request #52081 from YiteGu/mds-optracked-have-no-slow-op-threshold
mds/MDSRank: Add set_history_slow_op_size_and_threshold for op_tracker
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Rishabh Dave [Thu, 13 Jul 2023 07:14:22 +0000 (12:44 +0530)]
Merge pull request #50569 from rishabh-d-dave/CephManager-in-CephFSTestCase
qa/cephfs: add helper methods in CephFSTestCase
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Nizamudeen A [Fri, 7 Jul 2023 05:50:21 +0000 (11:20 +0530)]
mgr/dashboard: cluster upgrade base UI component
- Base layout for the Upgrade Component
- Shows the Upgrade available button when an upgrade is available
Fixes: https://tracker.ceph.com/issues/61927
Signed-off-by: Nizamudeen A <nia@redhat.com>
Venky Shankar [Thu, 13 Jul 2023 05:48:34 +0000 (11:18 +0530)]
Merge PR #51959 into main
* refs/pull/51959/head:
qa: test for session ls with filters
mds: session ls command appears twice in command listing
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 13 Jul 2023 05:47:16 +0000 (11:17 +0530)]
Merge PR #51278 into main
* refs/pull/51278/head:
mgr/snap_schedule: rephrase log message when pruning
doc: add note about snap-schedule snapshot retention
qa: test user defined number of snaps retention spec
mgr/snap_schedule: adapt test to new argument list
doc/cephfs: Add note how mds_max_snaps_per_dir affects snapshot retention
mgr/snap_schedule: Use mds_max_snaps_per_dir as snapshot count limit
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 13 Jul 2023 05:42:55 +0000 (11:12 +0530)]
Merge PR #52175 into main
* refs/pull/52175/head:
client: force sending cap revoke ack always
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Anthony D'Atri [Thu, 13 Jul 2023 03:32:59 +0000 (23:32 -0400)]
Merge pull request #52419 from pcuzner/doc-fix
docs: fix nfs cluster create syntax
Paul Cuzner [Thu, 13 Jul 2023 03:13:42 +0000 (15:13 +1200)]
docs: fix nfs cluster create syntax
The ceph prefix was missing from the command
example.
Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
Casey Bodley [Wed, 12 Jul 2023 20:39:36 +0000 (16:39 -0400)]
Merge pull request #52417 from cbodley/wip-61975
osd: qualify fmt::format_to() for gcc13
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Yuri Weinstein [Wed, 12 Jul 2023 18:36:45 +0000 (14:36 -0400)]
Merge pull request #51909 from NitzanMordhai/wip-nitzan-divergent-priors-test-3-pick-osd
qa/standalone/osd/divergent-prior.sh: Divergent test 3 with pg_autoscale_mode on pick divergent osd
Reviewed-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
Yuri Weinstein [Wed, 12 Jul 2023 18:35:51 +0000 (14:35 -0400)]
Merge pull request #51782 from rzarzynski/wip-bs-stdfloor
os/bluestore: specify namespace for the std::floor usage in BlueStore.h
Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Casey Bodley [Wed, 12 Jul 2023 17:30:28 +0000 (13:30 -0400)]
osd: qualify fmt::format_to() for gcc13
/home/cbodley/ceph/src/osd/scheduler/OpSchedulerItem.h:672:21: error: call of overloaded ‘format_to(fmt::v9::basic_format_context<fmt::v9::appender, char>::it
erator, const char [59], const spg_t&, std::string, class_t, unsigned int, const std::__cxx11::basic_string<char>&, int, epoch_t, const std::__cxx11::basic_st
ring<char>&)’ is ambiguous
672 | return format_to(
| ~~~~~~~~~^
673 | ctx.out(), "OpSchedulerItem({} {} class_id {} prio {}{} cost {} e{}{})",
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
674 | opsi.get_ordering_token(), opsi.qitem->print(),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
675 | static_cast<class_t>(opsi.get_scheduler_class()), opsi.get_priority(),
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
676 | qos_cost, opsi.get_cost(), opsi.get_map_epoch(), pushes);
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/home/cbodley/ceph/src/fmt/include/fmt/core.h:3233:17: note: candidate: ‘OutputIt fmt::v9::format_to(OutputIt, format_string<T ...>, T&& ...) [with OutputIt =
appender; T = {const spg_t&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, unsigned char, unsigned int, const std::__cxx11
::basic_string<char, std::char_traits<char>, std::allocator<char> >&, int, unsigned int, const std::__cxx11::basic_string<char, std::char_traits<char>, std::a
llocator<char> >&}; typename std::enable_if<detail::is_output_iterator<OutputIt, char>::value, int>::type <anonymous> = 0; format_string<T ...> = basic_format
_string<char, const spg_t&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, unsigned char, unsigned int, const std::__cxx11::
basic_string<char, std::char_traits<char>, std::allocator<char> >&, int, unsigned int, const std::__cxx11::basic_string<char, std::char_traits<char>, std::all
ocator<char> >&>]’
3233 | FMT_INLINE auto format_to(OutputIt out, format_string<T...> fmt, T&&... args)
| ^~~~~~~~~
/usr/include/c++/13/format:3745:5: note: candidate: ‘_Out std::format_to(_Out, format_string<_Args ...>, _Args&& ...) [with _Out = fmt::v9::appender; _Args =
{const spg_t&, __cxx11::basic_string<char, char_traits<char>, allocator<char> >, unsigned char, unsigned int, const __cxx11::basic_string<char, char_traits<ch
ar>, allocator<char> >&, int, unsigned int, const __cxx11::basic_string<char, char_traits<char>, allocator<char> >&}; format_string<_Args ...> = basic_format_
string<char, const spg_t&, __cxx11::basic_string<char, char_traits<char>, allocator<char> >, unsigned char, unsigned int, const __cxx11::basic_string<char, ch
ar_traits<char>, allocator<char> >&, int, unsigned int, const __cxx11::basic_string<char, char_traits<char>, allocator<char> >&>]’
3745 | format_to(_Out __out, format_string<_Args...> __fmt, _Args&&... __args)
| ^~~~~~~~~
Fixes: https://tracker.ceph.com/issues/61975
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Ronen Friedman [Wed, 12 Jul 2023 15:04:53 +0000 (18:04 +0300)]
Merge pull request #52370 from ronen-fr/wip-rf-opitem-fmt
osd: an fmtlib formatter for OpSchedulerItem
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Ilya Dryomov [Wed, 12 Jul 2023 09:07:12 +0000 (11:07 +0200)]
Merge pull request #48672 from nokia/fix_do_cmake_python_for_rocky
do_cmake.sh: build with correct python version on Rocky
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Matan Breizman [Tue, 27 Jun 2023 07:05:28 +0000 (07:05 +0000)]
crimson/osd/osd_operations/pg_advance_map: peering_request_pg_pipeline getter
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Wed, 28 Jun 2023 09:07:26 +0000 (09:07 +0000)]
crimson/osd/osd_operations: consistent naming to pipeline users
Rename pp/bp to client_pp or peering_pp.
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Aashish Sharma [Wed, 12 Jul 2023 05:22:56 +0000 (10:52 +0530)]
Merge pull request #50706 from rhcs-dashboard/dashboard-import-export-multisite
mgr/dashboard: import export functionality for RGW multisite
Reviewed-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Wed, 12 Jul 2023 04:51:45 +0000 (10:21 +0530)]
Merge pull request #52342 from ljflores/wip-whitelist-api
qa/tasks: set defer_client_eviction_on_laggy_osds=false in api tests
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Yuri Weinstein [Tue, 11 Jul 2023 22:15:02 +0000 (18:15 -0400)]
Merge pull request #52224 from Matan-B/wip-matanb-unused-make-oid
osd/OSD.h: cleanup unused make_*_oid methods
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Tue, 11 Jul 2023 22:14:27 +0000 (18:14 -0400)]
Merge pull request #51573 from adamemerson/wip-boost-the-boost
build: Bump boost to 1.82
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Yuri Weinstein [Tue, 11 Jul 2023 22:13:34 +0000 (18:13 -0400)]
Merge pull request #51034 from rzarzynski/wip-bug-59429
crimson/osd: fix ENOENT on accessing RadosGW user's index of buckets
Reviewed-by: Samuel Just <sjust@redhat.com>
Laura Flores [Tue, 11 Jul 2023 22:04:32 +0000 (17:04 -0500)]
Merge pull request #52345 from ljflores/wip-tracker-59057
qa/suites/rados/singleton/all: remove test_envlibrados_for_rocksdb