doc/rados: edit troubleshooting-mon.rst (2 of x)

Edit the second part of
doc/rados/troubleshooting/troubleshooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9938955c091274313c345d680001558810e33d2d)

Merge pull request #52826 from zdover23/wip-doc-2023-08-05-backport-52778-to-quincy

quincy: doc/rados: edit operations/add-or-rm-mons (2 of x)

doc/rados: edit operations/add-or-rm-mons (2 of x)

Edit the second part of doc/rados/operations/add-or-rm-mons.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4e790603d9e4645234d3953e88a34dd3a8a10068)

Merge pull request #52320 from mkogan1/wip-59739-quincy

quincy: rgw: D3N cache objects which oid contains slash

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #52322 from batrick/wip-61898-quincy

quincy: pybind: drop GIL during library callouts

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #52243 from batrick/wip-61425-quincy

quincy: mon/MDSMonitor: ignore extraneous up:boot messages

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #52239 from batrick/wip-61415-quincy

quincy: mon/MDSMonitor: do not propose on error in prepare_update

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #52234 from batrick/wip-61412-quincy

quincy: mon/MDSMonitor: check fscid in pending exists in current

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #52158 from cbodley/wip-57642-quincy

quincy: rgw: avoid string_view to temporary in RGWBulkUploadOp

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #51102 from RaminNietzsche/wip-ifed-fix-require-osd-release-to-quincy

quincy: mon: avoid exception when setting require-osd-release more than 2

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #51002 from ifed01/wip-ifed-bluefs-duplicate-dir-link-qui

quincy: os/bluestore/bluefs: fix dir_link might add link that already exists in compact log

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>

Merge pull request #52804 from zdover23/wip-doc-2023-08-04-backport-52800-to-quincy

quincy: doc/rgw: several response headers are supported

doc/rgw: several response headers are supported

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit ab6ec66a2f82c3dfb3807d5e76d3290ff30bf613)

Merge pull request #52564 from adamemerson/wip-62097-quincy

quincy: build: Remove ceph-libboost* packages in install-deps

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #52780 from zdover23/wip-doc-2023-08-03-backport-52775-to-quincy

quincy: doc: for EC we recommend K+1

doc: for EC we recommend K+1

Update the doc to match the reality in the code. I don't know where
the recommendation to have min_size = k+2 came from, but for awhile
now we've defaulted to K+1. See PR #8008.

Signed-off-by: Dan van der Ster <dan.vanderster@clyso.com>
(cherry picked from commit 68faf88e6babf7e5c2cce2b4d9b80a159b38c30d)

mgr: fix some flake8 complaints

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit d199782fb5f3c22f1cd5fda6ddf1d64f40a92726)

Merge pull request #52759 from zdover23/wip-doc-2023-08-02-backport-51960-to-quincy

quincy: doc: improve doc/dev/encoding.rst

doc: improve doc/dev/encoding.rst

Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
(cherry picked from commit 83bef6668d319685923df927f32590b4e1795746)

Merge pull request #52713 from zdover23/wip-doc-2023-08-01-backport-52131-to-quincy

quincy: doc/radosgw: correct emphasis in rate limit section

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radosgw: correct emphasis in rate limit section

Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
(cherry picked from commit 50bfbab6d9a30b3ba6ec4f4c8df9059298c28a7f)

build: install-deps.sh installs system boost on Jammy

Since on Jammy system boost is new enough for Quincy and we don't have
Jammy packages for older boost (we only have those for Focal), just
install the system packages rather than fetching ceph-libboost.

No analogous commit exists in main as while main's Jammy case installs
ceph-libboost, we just need a system package here.

Fixes: https://tracker.ceph.com/issues/62102
Signed-off-by: Adam Emerson <aemerson@redhat.com>

build: Remove old ceph-libboost* packages in install-deps

Here, we extract `clean_boost_on_ubuntu()` and call it before other
installs on Debian distributions so that if we install a system boost,
a potentially newer `ceph-libboost` won't get in the way.

As the sources.list.d being removed in the original cleanup code isn't
the one we're currently installing in the install code, add a removal
for the currently used source, then do apt-update so packages from the
removed source are no longer included as available.

Two subsidiary dev packages from conflicting boost libraries can be
installed, but it leaves apt in an inconsistent state. To clean this
up, add `--fix-missing` to the removal line and call
`clean_boost_on_ubuntu()` before other uses of apt.

Fixes: https://tracker.ceph.com/issues/62097
Signed-off-by: Adam Emerson <aemerson@redhat.com>
(cherry picked from commit 0c3f511e14af639b6509e69b889258b2f718f8fd)

Conflicts:
install-deps.sh
 - Different boost version for Quincy than Squid.
 - ci_debug does not exist in Quincy
 - whitespace
 - No INSTALL_EXTRA

Fixes: https://tracker.ceph.com/issues/62102
Signed-off-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #52694 from zdover23/wip-doc-2023-07-29-backport-52668-to-quincy

quincy: doc/radosgw: Add missing space to date option spec in admin.rst

Merge pull request #52696 from zdover23/wip-doc-2023-07-29-backport-52685-to-quincy

quincy: doc/mgr/ceph_api: Promptify example commands in index.rst

doc/mgr/ceph_api: Promptify example commands in index.rst

Use the more modern prompt block instead of
using code blocks for example commands.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit 4f9bd62f374d2f6bf74296d87e5205960464c349)

doc/radosgw: Add missing space to date option spec in admin.rst

The start time and end time CLI option specification is missing a space between the date and the optional time value. Also expand the text to talk about "optional time" after the date.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit dd16ad9055f134433d9bd6410cd31eb0fc918723)

Merge pull request #52289 from idryomov/wip-61364-quincy

quincy: rbd-wnbd: improve image map error message

Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #52288 from idryomov/wip-59641-quincy

quincy: librbd/managed_lock/GetLockerRequest: Fix no valid lockers case

Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #50785 from vshankar/tr-59021

quincy: mds: record and dump last tid for trimming completed requests (or flushes)

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #50780 from mchangir/wip-59016-quincy

quincy: mgr/snap_schedule: add debug log for paths failing snapshot creation

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #50595 from neesingh-rh/wip-58985-quincy

quincy: cephfs-top: Handle `METRIC_TYPE_NONE` fields for sorting

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #50365 from neesingh-rh/wip-58865-quincy

quincy: cephfs-top: Some fixes in `choose_field()` for sorting

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #52613 from zdover23/wip-doc-2023-07-25-backport-49889-to-quincy

quincy: doc/rados/configuration: add links to MON DNS

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rados/configuration: add links to MON DNS

Add two links to MON DNS lookup and an anchor in the destination document.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit 06cb5652157a53b25e8ae588f375548b1df72d2d)

Merge pull request #52594 from zdover23/wip-doc-2023-07-23-backport-52587-to-quincy

quincy: doc/rados: edit ceph-conf.rst (4 of x)

doc/rados: edit ceph-conf.rst (4 of x)

Edit doc/rados/configuration/ceph-conf.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ac47899863390ff9f2adf658273e1d61760a68c2)

Merge pull request #52589 from zdover23/wip-doc-2023-07-22-backport-52542-to-quincy

quincy: doc/rados: edit ceph-conf.rst (3 of x)

doc/rados: edit ceph-conf.rst (3 of x)

Edit doc/rados/configuration/ceph-conf.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b1fb80ae088e4f00f207454433111f6597715ed8)

Merge pull request #52573 from zdover23/wip-doc-2023-07-21-backport-52563-to-quincy

quincy: doc: governance.rst - update D Orman

doc: governance.rst - update D Orman

Update David Orman's email address in doc/governance.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 46f503975e124680b29333e3972c4c937a641c10)

Merge pull request #52286 from idryomov/wip-61616-quincy

quincy: librbd: avoid object map corruption in snapshots taken under I/O

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #52189 from ajarr/wip-61705-quincy

quincy: mgr/rbd_support: add user-friendly stderr message when module is not ready

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #52283 from idryomov/wip-57343-quincy

quincy: test/cli-integration/rbd: iSCSI REST API responses aren't pretty-printed anymore

Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge pull request #52487 from zdover23/wip-doc-2023-07-17-backport-52483-to-quincy

quincy: doc/mgr/rgw.rst: add missing "ceph" command in cli specification

doc/mgr/rgw.rst: add missing "ceph" command in cli specification

The line begins with a prompt so I would
expect it to be a "complete" command,
including the `ceph` binary to run with all
the various listed arguments.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit 37ea3e50f09be5490d7ec614798822aa6f86eaec)

Merge pull request #52479 from zdover23/wip-doc-2023-07-17-backport-52476-to-quincy

quincy: doc/mgr/rgw.rst: multisite typed wrong

Reviewed-by: Rongqi Sun (Svelar) <sunrongqi@huawei.co>

doc/mgr/rgw.rst: multisite typed wrong

Multisite is typed wrong as mutlisite so fix the spelling.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit 33b8fdb20329342ef91a391a99065fdb88c16b23)

Merge pull request #52471 from zdover23/wip-doc-2023-07-16-backport-52465-to-quincy

quincy: doc/rados: edit ceph-conf.rst (2 of x)

doc/rados: edit ceph-conf.rst (2 of x)

Edit doc/rados/configuration/ceph-conf.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 69b9b20be14c7775e434b25753678533eb163a3f)

Merge pull request #52464 from zdover23/wip-doc-2023-07-15-backport-52356-to-quincy

quincy: doc/cephfs: add note to isolate metadata pool osds

doc/cephfs: add note to isolate metadata pool osds

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 4e2e61f16438dcd5eb35854091114d18b6fe9a9e)

Merge pull request #52388 from rhcs-dashboard/cleanup-script-quincy

quincy: mgr/dashboard: move cephadm e2e cleanup to jenkins job config

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #52449 from zdover23/wip-doc-2023-07-14-backport-52423-to-quincy

quincy: doc/rados: edit ceph-conf.rst

Merge pull request #52451 from zdover23/wip-doc-2023-07-14-backport-52402-to-quincy

quincy: doc/rados: edit add-or-rm-osds (2 of x)

doc/rados: edit add-or-rm-osds (2 of x)

Edit doc/rados/operations/add-or-rm-osds.rst (2 of x).

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d83fa5352aa556c4e559e66dd461c200cc86c709)

doc/rados: edit ceph-conf.rst

Edit doc/rados/configuration/ceph-conf.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dd8d91b0ded8be70bec3f40f499d7cf9432c9f23)

Merge pull request #52424 from zdover23/wip-doc-2023-07-13-backport-52419-to-quincy

quincy: docs: fix nfs cluster create syntax

Merge pull request #50103 from seanhoughton/wip-55614-quincy

quincy: RGW - Fix NoSuchTagSet error

Reviewed-by: Casey Bodley <cbodley@redhat.com>

docs: fix nfs cluster create syntax

The ceph prefix was missing from the command
example.

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
(cherry picked from commit 43b5f4b4f92341803753fcd3b67132546829e362)

Merge pull request #52062 from guits/wip-61153-quincy

quincy: ceph-volume: fix a bug in `get_lvm_fast_allocs()` (batch)

mgr/dashboard: move cephadm e2e cleanup to jenkins job config

Follows: https://github.com/ceph/ceph-build/pull/2145

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit a407f0b7834585c087001059d6cec613e524538b)

Merge pull request #52384 from zdover23/wip-doc-2023-07-11-backport-52366-to-quincy

quincy: doc/rados: edit add-or-rm-osds (1 of x)

doc/rados: edit add-or-rm-osds (1 of x)

Edit docs/rados/operations/add-or-rm-osds.

Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a3ab5a7ad8a44c702089294b107d09dca3a98139)

Merge pull request #52382 from zdover23/wip-doc-2023-07-11-backport-52371-to-quincy

quincy: doc/rados: introduce emdash

doc/rados: introduce emdash

Introduce the emdash character in
docs/rados/troubleshooting/troubleshooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a971a3a66a93ce52898f201a41a9aa13e0dd8bfc)

Merge pull request #52368 from zdover23/wip-doc-2023-07-09-backport-52327-to-quincy

quincy: doc: add information on expediting MDS recovery

doc: add information on expediting MDS recovery

Fixes: https://tracker.ceph.com/issues/61865
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 0a15144c584d4445bd037340f053aa64b9c13f32)

Merge pull request #52362 from zdover23/wip-doc-2023-07-08-backport-52360-to-quincy

quincy: doc/radosgw: add Zonegroup policy explanation

doc/radosgw: add Zonegroup policy explanation

Add revised Zonegroup policy for "multi-zonegroups". This commit
includes changes that Casey Bodley made in
https://github.com/ceph/ceph/pull/52324#discussion_r1253482258 and that
I have integrated into the docs only now.

Co-authored-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c6400ed79b1233a2238342e4931edf341f1c7b9f)

Merge pull request #52349 from zdover23/wip-doc-2023-07-07-backport-52324-to-quincy

quincy: doc/radosgw: add Zonegroup purpose

Merge pull request #52332 from rhcs-dashboard/wip-61910-quincy

quincy: mgr/dashboard: fix a bug where data would plot wrongly

Reviewed-by: avanthakkar avanjohn@gmail.com

doc/radosgw: add Zonegroup purpose

Add a note about the telos of zonegroups. The information added in this
commit was originally sent to ceph-users by Casey Bodley on 30 Jun 2023
in response to a question from Yixin Jin. Alexander Patrakov then
suggested that Casey's response should be added to
doc/radsogw/multisite.rst.

Co-authored-by: Casey Bodley <cbodley@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5c46a1a00962918c885e434986d0f846c3ee4730)

mgr/dashboard: fix a bug where data would plot on the graphs without converting to the data units of the graph

Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 7aa70a16a54c3387b2e021763ca1d118d6785835)

Merge pull request #52282 from zdover23/wip-doc-2023-07-02-backport-52280-to-quincy

quincy: doc/radosgw: refine "Zones" in multisite.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

pybind/rbd: drop GIL when calling into librbd

This was missing for rbd_mirror_peer_site_add() and
rbd_get_data_pool_id().

While at it, add a test for data_pool_id().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 1a60f66b0a13089c789e2e056b925ac6fef75021)

Conflicts:
src/test/pybind/test_rbd.py: trivial import noise

pybind/cephfs: drop gil during cephfs callouts

This has disastorous consequences including the possibility of deadlock.
In the best case, you have the rmdir holding the GIL until the MDS
responds!

Fixes: https://tracker.ceph.com/issues/61869
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 5d249a4c978198f1e8974affac0297b71bebada5)

doc/radosgw: refine "Zones" in multisite.rst

Describe in greater detail the function of Zones in serving S3 objects,
as requested by Alexander Patrakov here:
https://github.com/ceph/ceph/pull/49981#issuecomment-1615866374.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 8dab6c066c4dd3699c7b7c80f7a30a0e18326bba)

quincy: rgw: D3N cache objects which oid contains slash

Fixes: https://tracker.ceph.com/issues/59739
Signed-off-by: Mark Kogan <mkogan@redhat.com>
(cherry picked from commit fcb91f3e2a6fd8066ac33950d421e0a9b9b4b490)

 Conflicts:
src/rgw/rgw_aio.cc
src/rgw/rgw_d3n_cacherequest.h
src/rgw/rgw_d3n_datacache.cc

Merge pull request #52299 from zdover23/wip-doc-2023-07-04-backport-51422-to-quincy

quincy: doc/rgw/lua: add info uploading a script in cephadm deployment

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rgw/lua: add info uploading a script in cephadm deployment

Signed-off-by: Yuval Lifshitz <yuvalif@yahoo.com>
(cherry picked from commit 5cec4f719581e93760c22419e701c563a8688de9)

Merge pull request #52312 from zdover23/wip-doc-2023-07-05-backport-52207-to-quincy

quincy: doc/rados: edit crush-map-edits (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rados: edit crush-map-edits (2 of x)

Edit doc/rados/operations/crush-map-edits.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ae04debe9e2fa18c1cb8745b0573ff56576fd3b0)

Merge pull request #52310 from zdover23/wip-doc-2023-07-05-backport-52308-to-quincy

quincy: doc/dev: remove seqdiag assets

Reviewed-by: Josh Durgin <jdurgin@redhat.com>

doc/dev: remove seqdiag assets

Remove seqdiag assets to determine whether the docs can be built if they
are absent. (Currently they cannot be built when they are present.) If
this works, then these diagrams will be replaced, probably with .png
files.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ce96ddd4c7da65351deaf14dc4f8b42f5148a352)

rbd-wnbd: improve image map error message

"rbd-wnbd map" commands are delegated to the centralized
ceph-rbd Windows service, which in turn will create the
actual image mapping. This allows the daemons to continue
running even after the current session ends.

rbd-wnbd communicates with the service through a named pipe.
If the operation fails, we're only getting an error code.

This change will print the according error message based on the
error code, suggesting the user to check the logs or use
foreground mode ("-f") for additional information.

We could also capture the entire subprocess console output and
print it in case of errors. This can be quite verbose, so we'll
keep it simple for now.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
(cherry picked from commit 5bbcfc82970bd3a76536a7dd554096bec70ddc2d)

test/librbd: add empty cookie and blank address tests

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 43f2e4ad08b5a1855313e9aebe79ee235f7e5e16)

librbd/managed_lock/GetLockerRequest: Fix no valid lockers case

See:
`m_locker->address = iter->second.addr.get_legacy_str();`

In the case where `iter->second.addr` is an empty address,
m_locker->address string is assigned with "0)/0" and therfore
will never result in an empty string.

Use `is_blank_ip()` before `get_legacy_str()`

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit 7482beeea9b1bc8c3cbdac425e7afb8ebdc9f270)

qa/workunits/rbd: make continuous export-diff test actually work

The current version is pretty useless:

- "rbd bench" writes the same byte (0xff) over and over again, so
  almost all checksumming is in vain
- snapshots are taken in a steady state (i.e. not under I/O), so no
  race conditions can get exposed
- even with these caveats, it's not wired up into the suite

Redo this workunit to be a reliable reproducer for the issue fixed
in the previous commit and wire it up for both krbd and rbd-nbd.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit acb270a3dd07211f06aa11f8792a333f3a1b796d)

librbd: stop passing IOContext to image dispatch write methods

This is a major footgun since any value passed e.g. at the API layer
may be stale by the time we get to object dispatch.  All callers are
passing the IOContext returned by get_data_io_context() for their
ImageCtx anyway, highlighting that the parameter is fictitious.

Only the read method can meaningfully take IOContext.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 584f865ae116185087176715ced014b625f04e82)

Conflicts:
src/librbd/api/Io.cc [ commit 37057ba2f6bb ("librbd: pass
  image_extents to create_{discard,write_same}()") and ImageArea
  support not in quincy ]
src/librbd/cache/ImageWriteback.cc [ ditto ]
src/librbd/io/ImageDispatchSpec.h [ ditto ]
src/librbd/crypto/luks/FormatRequest.cc [ ImageArea support not
  in quincy ]
src/test/librbd/io/test_mock_ImageRequest.cc [ ditto ]
src/test/librbd/journal/test_mock_Replay.cc [ ditto ]
src/librbd/crypto/luks/FlattenRequest.cc [ commit 84601d68a74f
  ("librbd/crypto: add format-specific flattening operation")
  not in quincy ]

librbd: use an up-to-date snap context when owning the exclusive lock

By effectively moving capturing of the snap context to the API layer,
commit 1d0a3b17f590 ("librbd: pass IOContext to image-extent IO
dispatch methods") introduced a nasty regression.  The snap context can
be captured only after exclusive lock is safely held for the duration
of dealing with the image request and even then must be refreshed if
a snapshot creation request is accepted from a peer.  This is needed to
ensure correctness of the object map in general and fast-diff states in
particular (OBJECT_EXISTS vs OBJECT_EXISTS_CLEAN) and object deltas
computed based off of them.  Otherwise the object map that is forked
for the snapshot isn't guaranteed to accurately reflect the contents of
the snapshot when the snapshot is taken under I/O (as in disabling the
object map may lead to different results being returned for reads).

The regression affects mainly differential backup and snapshot-based
mirroring use cases with object-map and/or fast-diff enabled: since
some object deltas may be incomplete, the destination image may get
corrupted.

This commit represents a reasonable minimal fix: IOContext passed
through to ImageDispatch is effected only for reads and just gets
ignored for writes.  The next commit cleans up further by undoing the
passing of IOContext through the image dispatch layers for writes.

Fixes: https://tracker.ceph.com/issues/61616
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit e4b1e0466354942c935e9eca2ab2858e75049415)

Conflicts:
src/librbd/io/ImageDispatch.cc [ ImageArea support not in
  quincy ]
src/librbd/io/ImageRequest.cc [ ditto ]
src/librbd/io/ImageRequest.h [ ditto ]
src/librbd/journal/Replay.cc [ ditto ]

test/cli-integration/rbd: iSCSI REST API responses aren't pretty-printed anymore

See https://github.com/ceph/ceph-iscsi/pull/263 and
https://github.com/pallets/flask/pull/2193.  Flask stopped
pretty-printing by default in 1.0:

  Change the default for JSONIFY_PRETTYPRINT_REGULAR to False.
  json.jsonify returns a compact format by default, and an indented
  format in debug mode.

Fixes: https://tracker.ceph.com/issues/57343
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 1cec9e83c02c366b5274739ae11297b6fca8584f)

Merge pull request #52279 from zdover23/wip-doc-2023-07-01-backport-52277-to-quincy

quincy: doc/radosgw: s/s3select/S3 Select/

doc/radosgw: s/s3select/S3 Select/

Correct several misspelling of "S3 Select". Hat tip to Anthony D'Atri,
who caught this in an earlier PR.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 71c327ef4f56a6ec900a8c5ea071aaf8005a60a5)

Merge pull request #52188 from zdover23/wip-doc-2023-06-26-backport-52181-2nd-attempt-to-quincy

quincy: doc/radosgw: remove pipes from s3select.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

Merge pull request #52220 from zdover23/wip-doc-2023-06-28-backport-52194-to-quincy

quincy: doc/radosgw: edit "Overview" in s3select.rst

Merge pull request #52263 from zdover23/wip-doc-2023-06-30-backport-52250-to-quincy

quincy: doc/radosgw: edit "Basic Workflow" in s3select.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/radosgw: edit "Basic Workflow" in s3select.rst

Edit the "Basic Workflow" section in doc/radosgw/s3select.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4d2c09b683421552cfb4df7f467f2d9a6c9c7c26)

mon/MDSMonitor: ignore extraneous up:boot messages

An MDS sends up:boot beacons until it sees an MDSMap with it joined.  If
the mons are delaying the proposal, including because of quorum loss, of
the new FSMap, the subsequent up:boot messages would cause the
MDSMonitor to wrongly interpret the booting MDS to replace itself.
Instead, just ignore up:boot messages (as intended) when we know the MDS
has been added to the pending map.

Fixes: https://tracker.ceph.com/issues/59318
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 2e0bcc3c333d7fca2e06eafa1e3dc3a7c3ae1b36)

qa: add test case for mds sending multiple boot messages

Test case for [1].

[1] https://tracker.ceph.com/issues/59318

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit f194b277ec56c1c47c5c2b0186c995c96ef265af)