]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
23 months agodoc: improve submodule update command - README.md 52991/head
Zac Dover [Tue, 15 Aug 2023 03:28:00 +0000 (13:28 +1000)]
doc: improve submodule update command - README.md

Improve the portion of README.md that directs the reader to update the
submodules. Previously, the text assumed that the reader knew that they
should cd into the ceph directory. Now the text is explicit about the
necessity of this action.

Signed-off-by: Zac Dover <zac.dover@proton.me>
23 months agoMerge pull request #52857 from cyx1231st/wip-crimson-cleanup-osd-sharddispatcher
Yingxin [Tue, 15 Aug 2023 02:57:47 +0000 (10:57 +0800)]
Merge pull request #52857 from cyx1231st/wip-crimson-cleanup-osd-sharddispatcher

crimson/osd: cleanup and drop OSD::ShardDispatcher

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
23 months agoMerge pull request #52869 from rhcs-dashboard/fs-subvolumes-rm
Nizamudeen A [Mon, 14 Aug 2023 16:55:29 +0000 (22:25 +0530)]
Merge pull request #52869 from rhcs-dashboard/fs-subvolumes-rm

mgr/dashboard: cephfs subvolume remove

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
23 months agomgr/dashboard: cephfs subvolume remove 52869/head
Nizamudeen A [Mon, 7 Aug 2023 15:32:55 +0000 (21:02 +0530)]
mgr/dashboard: cephfs subvolume remove

Fixes: https://tracker.ceph.com/issues/62349
Signed-off-by: Nizamudeen A <nia@redhat.com>
23 months agoMerge PR #52547 into main
Venky Shankar [Mon, 14 Aug 2023 12:22:47 +0000 (17:52 +0530)]
Merge PR #52547 into main

* refs/pull/52547/head:
qa: add test cases for vanilla ops commands
mds: dump locks when printing mutation ops
common/TrackedOp: support overriding the _dump method
mds: remove op field obsoleted by more usable "reqid"
mds: dump metareq_t instead of full op
mds: add lock type to formatter dump of SimpleLock
mds: mark print methods const
mds: drop MDRequestImpl::msg_lock
mds: lock TrackedOp when dumping
mds: avoid recursive locks dumping state
common/TrackedOp: fix race updating description with proper lock
common/Formatter: add support for dumping null
common/Formatter: refactor generating xml name

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
23 months agoMerge PR #52577 into main
Venky Shankar [Mon, 14 Aug 2023 12:21:50 +0000 (17:51 +0530)]
Merge PR #52577 into main

* refs/pull/52577/head:
mds: adjust cap acquisition throttles

Reviewed-by: Venky Shankar <vshankar@redhat.com>
23 months agoMerge PR #52834 into main
Venky Shankar [Mon, 14 Aug 2023 12:20:47 +0000 (17:50 +0530)]
Merge PR #52834 into main

* refs/pull/52834/head:
mount.fuse.ceph: strip the 'nofail' option from those that fuse will see

Reviewed-by: Venky Shankar <vshankar@redhat.com>
23 months agoMerge pull request #48705 from theanalyst/cmake-fmt-versionbump
Ilya Dryomov [Mon, 14 Aug 2023 09:47:58 +0000 (11:47 +0200)]
Merge pull request #48705 from theanalyst/cmake-fmt-versionbump

cmake: ensure fmt lib is at least 8.1.1

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
23 months agoMerge pull request #52865 from cloudbehl/status-popover
Nizamudeen A [Mon, 14 Aug 2023 06:58:25 +0000 (12:28 +0530)]
Merge pull request #52865 from cloudbehl/status-popover

mgr/dashboard: open popup with hover for cluster status

Reviewed-by: Nizamudeen A <nia@redhat.com>
23 months agoMerge pull request #52861 from rhcs-dashboard/fs-subvolumes-edit
Nizamudeen A [Mon, 14 Aug 2023 06:48:37 +0000 (12:18 +0530)]
Merge pull request #52861 from rhcs-dashboard/fs-subvolumes-edit

mgr/dashboard: provide ability to edit cephfs subvolume

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
23 months agoMerge pull request #52966 from zdover23/wip-doc-2023-08-14-src-tools-rados
zdover23 [Mon, 14 Aug 2023 05:01:52 +0000 (15:01 +1000)]
Merge pull request #52966 from zdover23/wip-doc-2023-08-14-src-tools-rados

doc: update rados.cc

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
23 months agoMerge pull request #51141 from xxhdx1985126/wip-seastore-clone
Yingxin [Mon, 14 Aug 2023 01:47:38 +0000 (09:47 +0800)]
Merge pull request #51141 from xxhdx1985126/wip-seastore-clone

crimson/os/seastore: OP_CLONE in seastore

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
23 months agodoc: update rados.cc 52966/head
Zac Dover [Sun, 13 Aug 2023 23:47:46 +0000 (09:47 +1000)]
doc: update rados.cc

Clarify a line in ceph/src/tools/rados/rados.cc.

Signed-off-by: Zac Dover <zac.dover@proton.me>
23 months agoMerge pull request #52963 from zdover23/wip-doc-2023-08-13-rados-troubleshooting...
zdover23 [Sun, 13 Aug 2023 18:07:13 +0000 (04:07 +1000)]
Merge pull request #52963 from zdover23/wip-doc-2023-08-13-rados-troubleshooting-cpu-profiling

doc/troubleshooting: edit cpu-profiling.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
23 months agodoc/troubleshooting: edit cpu-profiling.rst 52963/head
Zac Dover [Sun, 13 Aug 2023 06:55:55 +0000 (16:55 +1000)]
doc/troubleshooting: edit cpu-profiling.rst

Improve the language in the "oprofile" section of the RADOS
Troubleshooting Guide.

Signed-off-by: Zac Dover <zac.dover@proton.me>
23 months agoMerge pull request #52957 from zdover23/wip-doc-2023-08-12-rados-ops-monitoring-osd
zdover23 [Fri, 11 Aug 2023 19:06:56 +0000 (05:06 +1000)]
Merge pull request #52957 from zdover23/wip-doc-2023-08-12-rados-ops-monitoring-osd

doc/rados: update monitoring-osd-pg.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
23 months agomgr/dashboard: provide ability to edit cephfs subvolume 52861/head
Nizamudeen A [Mon, 7 Aug 2023 12:56:09 +0000 (18:26 +0530)]
mgr/dashboard: provide ability to edit cephfs subvolume

Fixes: https://tracker.ceph.com/issues/62347
Signed-off-by: Nizamudeen A <nia@redhat.com>
23 months agoMerge pull request #52645 from rhcs-dashboard/cephfs-vol-rm
Nizamudeen A [Fri, 11 Aug 2023 18:53:00 +0000 (00:23 +0530)]
Merge pull request #52645 from rhcs-dashboard/cephfs-vol-rm

mgr/dashboard: cephfs volume rm and rename

Reviewed-by: Pegonzal <NOT@FOUND>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
23 months agomgr/dashboard: cephfs volume rm and rename 52645/head
avanthakkar [Tue, 1 Aug 2023 08:05:22 +0000 (13:35 +0530)]
mgr/dashboard: cephfs volume rm and rename

Fixes: https://tracker.ceph.com/issues/62408
Signed-off-by: avanthakkar <avanjohn@gmail.com>
23 months agoMerge pull request #52932 from adk3798/cephadm-reef-latest-stable-release
Adam King [Fri, 11 Aug 2023 15:50:18 +0000 (11:50 -0400)]
Merge pull request #52932 from adk3798/cephadm-reef-latest-stable-release

cephadm: bump LATEST_STABLE_RELEASE to "reef"

Reviewed-by: John Mulligan <jmulligan@redhat.com>
23 months agoMerge pull request #52510 from pritha-srivastava/wip-rgw-61916-test-failures
Casey Bodley [Fri, 11 Aug 2023 15:36:37 +0000 (11:36 -0400)]
Merge pull request #52510 from pritha-srivastava/wip-rgw-61916-test-failures

rgw/auth: Fix the return code returned by AuthStrategy,

Reviewed-by: Casey Bodley <cbodley@redhat.com>
23 months agodoc/rados: update monitoring-osd-pg.rst 52957/head
Zac Dover [Fri, 11 Aug 2023 15:25:32 +0000 (01:25 +1000)]
doc/rados: update monitoring-osd-pg.rst

Ingest Anthony D'Atri's notes from
https://github.com/ceph/ceph/pull/50856#discussion_r1289532902
which should have been included earlier.

Signed-off-by: Zac Dover <zac.dover@proton.me>
23 months agoMerge pull request #50856 from zdover23/wip-doc-2023-04-04-rados-operations-monitorin...
zdover23 [Fri, 11 Aug 2023 14:15:40 +0000 (00:15 +1000)]
Merge pull request #50856 from zdover23/wip-doc-2023-04-04-rados-operations-monitoring-osd-pg-question-1

doc/rados/ops: question about down and in OSDS

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
23 months agoMerge pull request #52907 from cloudbehl/add-telemetry
Nizamudeen A [Fri, 11 Aug 2023 13:28:26 +0000 (18:58 +0530)]
Merge pull request #52907 from cloudbehl/add-telemetry

mgr/dashboard: Add telemetry link in dashboard

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Yaarit Hatuka <yaarithatuka@gmail.com>
23 months agoMerge pull request #52903 from cloudbehl/rgw-details
Nizamudeen A [Fri, 11 Aug 2023 13:06:04 +0000 (18:36 +0530)]
Merge pull request #52903 from cloudbehl/rgw-details

mgr/dashboard: RGW Details card cleanup

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
23 months agodoc/rados/ops: question about down and in OSDS 50856/head
Zac Dover [Thu, 10 Aug 2023 03:26:08 +0000 (13:26 +1000)]
doc/rados/ops: question about down and in OSDS

Clear up a confusing sentence that purports to explain OSDS that are
both "down" and "in".

Signed-off-by: Zac Dover <zac.dover@proton.me>
23 months agoMerge pull request #52945 from kotreshhr/doc-mgr-deadlock
zdover23 [Fri, 11 Aug 2023 12:10:59 +0000 (22:10 +1000)]
Merge pull request #52945 from kotreshhr/doc-mgr-deadlock

doc: Add a note on possible deadlock on volume deletion

Reviewed-by: Zac Dover <zac.dover@proton.me>
23 months agodoc: Add a note on possible deadlock on volume deletion 52945/head
Kotresh HR [Fri, 11 Aug 2023 11:32:59 +0000 (17:02 +0530)]
doc: Add a note on possible deadlock on volume deletion

Fixes: https://tracker.ceph.com/issues/62407
Signed-off-by: Kotresh HR <khiremat@redhat.com>
23 months agomgr/dashboard: Add telemetry link in dashboard 52907/head
cloudbehl [Wed, 9 Aug 2023 18:05:08 +0000 (23:35 +0530)]
mgr/dashboard: Add telemetry link in dashboard

Fixes: https://tracker.ceph.com/issues/62380
Signed-off-by: cloudbehl <cloudbehl@gmail.com>
23 months agoMerge PR #52765 into main
Venky Shankar [Fri, 11 Aug 2023 06:09:52 +0000 (11:39 +0530)]
Merge PR #52765 into main

* refs/pull/52765/head:
mgr/volumes: Fix pending_subvolume_deletions in volume info
qa: Add testcase for pending_subvolume_deletions count

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
23 months agocephadm: bump LATEST_STABLE_RELEASE to "reef" 52932/head
Adam King [Thu, 10 Aug 2023 15:04:55 +0000 (11:04 -0400)]
cephadm: bump LATEST_STABLE_RELEASE to "reef"

Now that reef is out, we should tell users
that it's the latest stable release, rather
than quincy

Signed-off-by: Adam King <adking@redhat.com>
23 months agoMerge pull request #52886 from rhcs-dashboard/cephfs-sbuvolumegroup-create
Pedro Gonzalez Gomez [Thu, 10 Aug 2023 14:49:50 +0000 (16:49 +0200)]
Merge pull request #52886 from rhcs-dashboard/cephfs-sbuvolumegroup-create

mgr/dashboard: create subvolume groups

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
23 months agoMerge pull request #52178 from phlogistonjohn/jjm-cephadm-init-ctrs
Adam King [Thu, 10 Aug 2023 12:37:49 +0000 (08:37 -0400)]
Merge pull request #52178 from phlogistonjohn/jjm-cephadm-init-ctrs

cephadm: add basic init containers support

Reviewed-by: John Mulligan <jmulligan@redhat.com>
23 months agoMerge pull request #52876 from kchheda3/wip-noti-logs
Yuval Lifshitz [Thu, 10 Aug 2023 07:38:49 +0000 (10:38 +0300)]
Merge pull request #52876 from kchheda3/wip-noti-logs

rgw: enrich the failed debug log line for sync notification

reviwed-by: BBoozmen, khu102-bloomberg, yuvalif, thotz

23 months agomgr/dashboard: create subvolumegroup 52886/head
Pedro Gonzalez Gomez [Wed, 9 Aug 2023 00:05:40 +0000 (02:05 +0200)]
mgr/dashboard: create subvolumegroup

Fixes: https://tracker.ceph.com/issues/62363
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
23 months agocrimson/os/seastore: debug outputs 51141/head
xuxuehan [Fri, 26 May 2023 08:03:59 +0000 (16:03 +0800)]
crimson/os/seastore: debug outputs

Signed-off-by: xuxuehan <xuxuehan@qianxin.com>
23 months agocrimson/os/seastore/object_data_handler: take indirect offset into
Xuehan Xu [Wed, 12 Jul 2023 10:35:17 +0000 (18:35 +0800)]
crimson/os/seastore/object_data_handler: take indirect offset into
account when reading object data

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
23 months agocrimson/os/seastore/transaction_manager: don't remove intermediate
Xuehan Xu [Tue, 11 Jul 2023 10:30:03 +0000 (18:30 +0800)]
crimson/os/seastore/transaction_manager: don't remove intermediate
mapping when remapping pins

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
23 months agocrimson/os/seastore/transaction_manager: remap indirect mappings
Xuehan Xu [Tue, 11 Jul 2023 09:48:53 +0000 (17:48 +0800)]
crimson/os/seastore/transaction_manager: remap indirect mappings

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
23 months agocrimson/os/seastore/transaction_manager: remove extents for physical lba mappings...
xuxuehan [Thu, 25 May 2023 03:02:29 +0000 (11:02 +0800)]
crimson/os/seastore/transaction_manager: remove extents for physical lba mappings if necessary
when removing indirect lba mappings

Signed-off-by: xuxuehan <xuxuehan@qianxin.com>
23 months agocrimson/os/seastore/lba_manager: decrease refcount of the physical lba
Xuehan Xu [Wed, 17 May 2023 03:35:20 +0000 (03:35 +0000)]
crimson/os/seastore/lba_manager: decrease refcount of the physical lba
mappings when removing indirect lba mappings

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
23 months agocrimson/os/seastore/onode_manager: erase onodes from the OnodeTree at the moment...
xuxuehan [Fri, 26 May 2023 07:55:44 +0000 (15:55 +0800)]
crimson/os/seastore/onode_manager: erase onodes from the OnodeTree at the moment of erase_onode

Signed-off-by: xuxuehan <xuxuehan@qianxin.com>
23 months agocrimson/os/seastore/object_data_handler: don't reserve lba space when truncating...
Xuehan Xu [Sun, 23 Apr 2023 06:22:52 +0000 (06:22 +0000)]
crimson/os/seastore/object_data_handler: don't reserve lba space when truncating objects to zero size

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
23 months agotest/crimson/seastore: add OP_CLONE unittest case
Xuehan Xu [Sun, 2 Apr 2023 06:10:59 +0000 (14:10 +0800)]
test/crimson/seastore: add OP_CLONE unittest case

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
23 months agocrimson/os/seastore/lba_manager: take lba entry indirection into account when getting...
Xuehan Xu [Sat, 6 May 2023 03:01:58 +0000 (03:01 +0000)]
crimson/os/seastore/lba_manager: take lba entry indirection into account when getting lba mappings

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
23 months agocrimson/os/seastore: implement OP_CLONE
Xuehan Xu [Wed, 29 Mar 2023 10:07:20 +0000 (18:07 +0800)]
crimson/os/seastore: implement OP_CLONE

Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
23 months agoMerge pull request #52635 from rhcs-dashboard/list-subvolume-groups
Nizamudeen A [Thu, 10 Aug 2023 04:30:17 +0000 (10:00 +0530)]
Merge pull request #52635 from rhcs-dashboard/list-subvolume-groups

mgr/dashboard: List subvolume groups

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: cloudbehl <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
23 months agoMerge pull request #52702 from zdover23/wip-doc-2023-07-31-documenting-ceph-linking...
zdover23 [Thu, 10 Aug 2023 01:13:10 +0000 (11:13 +1000)]
Merge pull request #52702 from zdover23/wip-doc-2023-07-31-documenting-ceph-linking-customs

doc/start: update linking conventions

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
23 months agoMerge pull request #52715 from zdover23/wip-doc-2023-08-01-radosgw-admin-rate-limit...
zdover23 [Thu, 10 Aug 2023 01:06:20 +0000 (11:06 +1000)]
Merge pull request #52715 from zdover23/wip-doc-2023-08-01-radosgw-admin-rate-limit-management

doc/radosgw: update rate limit management

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
23 months agoMerge pull request #52225 from yuvalif/wip-yuval-58412
Yuval Lifshitz [Wed, 9 Aug 2023 20:15:39 +0000 (23:15 +0300)]
Merge pull request #52225 from yuvalif/wip-yuval-58412

rgw/lua: give tables fully qualified names

23 months agoMerge pull request #52864 from adk3798/cephadm-debian-recommends
Adam King [Wed, 9 Aug 2023 19:29:10 +0000 (15:29 -0400)]
Merge pull request #52864 from adk3798/cephadm-debian-recommends

debian/control: add docker-ce as recommends for cephadm package

Reviewed-by: John Mulligan <jmulligan@redhat.com>
23 months agoqa/cephadm: add test case to verify custom container init_containers 52178/head
John Mulligan [Tue, 25 Jul 2023 17:16:13 +0000 (13:16 -0400)]
qa/cephadm: add test case to verify custom container init_containers

Add a 2nd custom container yaml to the test_extra_daemon_features.yaml
file that uses two init containers. Add verification that the init
containers (and primary) ran successfully.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agodoc/cephadm: document init_containers params for custom containers
John Mulligan [Tue, 11 Jul 2023 13:20:28 +0000 (09:20 -0400)]
doc/cephadm: document init_containers params for custom containers

Add documentation covering the new init_containers parameter and the
parameters within each init container's configuration.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agopybind/mgr/cephadm/tests: add test_deploy_custom_container_with_init_ctrs
John Mulligan [Thu, 22 Jun 2023 18:12:24 +0000 (14:12 -0400)]
pybind/mgr/cephadm/tests: add test_deploy_custom_container_with_init_ctrs

This adds a test case to explicitly check custom containers with init
containers.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agopybind/mgr/cephadm: add test_deploy_custom_container test case
John Mulligan [Wed, 21 Jun 2023 20:44:22 +0000 (16:44 -0400)]
pybind/mgr/cephadm: add test_deploy_custom_container test case

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agopybind/mgr/cephadm: reformat a long input line
John Mulligan [Wed, 21 Jun 2023 20:35:14 +0000 (16:35 -0400)]
pybind/mgr/cephadm: reformat a long input line

Use the parenthesized format with each import on a line for
readability.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agopybind/mgr/cephadm: add init_containers field to CephadmDaemonDeploySpec
John Mulligan [Thu, 15 Jun 2023 18:39:48 +0000 (14:39 -0400)]
pybind/mgr/cephadm: add init_containers field to CephadmDaemonDeploySpec

This will permit the transfer of init_containers from a spec to the
structure that actually generates the deploy JSON.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agopybind/mgr/cephadm: add support for init_containers in deploy
John Mulligan [Mon, 5 Jun 2023 22:49:02 +0000 (18:49 -0400)]
pybind/mgr/cephadm: add support for init_containers in deploy

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agopybind/mgr/cephadm: add init_containers field to exchange module
John Mulligan [Mon, 5 Jun 2023 22:48:42 +0000 (18:48 -0400)]
pybind/mgr/cephadm: add init_containers field to exchange module

This will permit serializing init_container information for sending
to cephadm binary.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agopython-common: add init_containers field to CustomContainerSpec
John Mulligan [Fri, 23 Jun 2023 18:07:06 +0000 (14:07 -0400)]
python-common: add init_containers field to CustomContainerSpec

This allows custom containers to run init containers before the
primary container starts.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agopython-common: reformat service_spec import line
John Mulligan [Mon, 26 Jun 2023 14:15:57 +0000 (10:15 -0400)]
python-common: reformat service_spec import line

Use the "black" style of multi-line import with parens.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agopython-common: add InitContainerSpec type
John Mulligan [Fri, 23 Jun 2023 18:06:45 +0000 (14:06 -0400)]
python-common: add InitContainerSpec type

The InitContainerSpec type will be used to define explicit "init
containers" - containers that are expected to run and then exit
and are executed prior to running a primary container.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: add a test case to cover generating init containers
John Mulligan [Wed, 14 Jun 2023 16:01:23 +0000 (12:01 -0400)]
cephadm: add a test case to cover generating init containers

Add a test case that covers the act of setting init_containers in
the deploy config on a custom container instance. This test executes
custom containers that both specify custom volume_mounts and not,
which are expected to "inherit" the volume_mounts of the primary
container's config.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: use an f-string for readability
John Mulligan [Wed, 21 Jun 2023 14:55:37 +0000 (10:55 -0400)]
cephadm: use an f-string for readability

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: support deploying with explicit init containers
John Mulligan [Wed, 14 Jun 2023 16:02:20 +0000 (12:02 -0400)]
cephadm: support deploying with explicit init containers

Complete the deployment functions so that any custom containers defined
with "init_containers" will add said init containers to the commands
to be executed.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: add get_deployment_init_containers
John Mulligan [Wed, 14 Jun 2023 16:02:10 +0000 (12:02 -0400)]
cephadm: add get_deployment_init_containers

Add get_deployment_init_containers to extract any init containers from
the deploy configuration context. Currently, all init containers are to
be explicitly defined, not inferred from the service type.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: add function to write init container commands
John Mulligan [Wed, 14 Jun 2023 16:02:00 +0000 (12:02 -0400)]
cephadm: add function to write init container commands

Add functions that write commands to clean up and execute init
containers. These init containers will be executed before the
main container as part of unit.run files (for now).

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: add an InitContainer class
John Mulligan [Wed, 7 Jun 2023 13:46:07 +0000 (09:46 -0400)]
cephadm: add an InitContainer class

Add a new InitContainer class that is similar to CephContainer but
will not assume certain defaults and is expected to run for a "short"
period before exiting. These init containers will be used to preform
tasks before a long running container is started.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: add identity field to CephContainer
John Mulligan [Thu, 22 Jun 2023 20:18:03 +0000 (16:18 -0400)]
cephadm: add identity field to CephContainer

Add an optional identity field based on the new DaemonIdentity type
to help name/identify the CephContainers. I would have preferred to make
this field mandatory but there are so many places in the code that
call CephContainer now, I didn't want to have to touch them all at once.
CephContainer objects created using the for_daemon classmethod *will*
all have DaemonIdentity set.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: add an identity field to BasicContainer
John Mulligan [Fri, 23 Jun 2023 17:43:47 +0000 (13:43 -0400)]
cephadm: add an identity field to BasicContainer

Use the new DaemonIdentity class to help identify a container.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: add DaemonIdentity type
John Mulligan [Fri, 23 Jun 2023 15:49:57 +0000 (11:49 -0400)]
cephadm: add DaemonIdentity type

It's an extremely common pattern in cephadm to need a triple of
(fsid, daemon_type, daemon_id). These triples are used to generate
various names and paths etc. Add a new type, DaemonIdentity, that
can represent these values in a more convient package. It has an
additional optional field "subcomponent" that can represent a
part of a daemon/service.
It is expected to be used in an immutable manner like a namedtuple,
but I didn't end using a namedtuple because cephadm doesn't make
much use of them and the syntax to combine namedtuple and type hints
is awkward.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: move common parts of CephContainer into BasicContainer
John Mulligan [Wed, 21 Jun 2023 18:08:03 +0000 (14:08 -0400)]
cephadm: move common parts of CephContainer into BasicContainer

Move a bunch of logic out of CephContainer and into BasicContainer.
BasicContainer needs to be more general than CephContainer so it
adds a few parameters that don't exist in CephContainer and
CephContainer will provide defaults for those values.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: add BasicContainer stub class
John Mulligan [Wed, 21 Jun 2023 18:05:18 +0000 (14:05 -0400)]
cephadm: add BasicContainer stub class

Add a BasicContainer class that will act as a base class for
CephContainer and any future XyzContainer classes. The class
is currently a stub that provides no functionality.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: break up deploy_daemon_units into more functions
John Mulligan [Tue, 6 Jun 2023 21:16:08 +0000 (17:16 -0400)]
cephadm: break up deploy_daemon_units into more functions

Break up deploy_daemon_units which had a lot of various "sub-tasks"
implemented within the main body of the function. Splitting up
the function makes each function's scope smaller, more readily testable
and more readable.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: refactor _write_container_cmd_to_bash function
John Mulligan [Tue, 6 Jun 2023 20:48:00 +0000 (16:48 -0400)]
cephadm: refactor _write_container_cmd_to_bash function

Refactor the _write_container_cmd_to_bash such that it now uses a
new _bash_cmd helper function and tries to avoid non-DRY repetition
of the same pattern of shell command expression.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: rename argument to container from c
John Mulligan [Tue, 6 Jun 2023 20:17:57 +0000 (16:17 -0400)]
cephadm: rename argument to container from c

Rename argument to "container" from "c" because a one character
variable at a large function's scope (or anywhere outside of a
comprehension) is a understanding/readability issue (IMO).

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: reformat deploy_daemon arguments to make it readable
John Mulligan [Tue, 6 Jun 2023 20:00:08 +0000 (16:00 -0400)]
cephadm: reformat deploy_daemon arguments to make it readable

Reformat the deploy_daemon function's arguments to use the "black"
one-line-per-argument style, which is significantly more readable IMO.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: add a test case for custom container type
John Mulligan [Wed, 14 Jun 2023 15:01:27 +0000 (11:01 -0400)]
cephadm: add a test case for custom container type

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agocephadm: move custom container tests to a dedicated file
John Mulligan [Wed, 14 Jun 2023 14:22:07 +0000 (10:22 -0400)]
cephadm: move custom container tests to a dedicated file

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agomgr/dashboard: RGW Details card cleanup 52903/head
cloudbehl [Wed, 9 Aug 2023 10:54:00 +0000 (16:24 +0530)]
mgr/dashboard: RGW Details card cleanup

Fixes: https://tracker.ceph.com/issues/62377
Signed-off-by: cloudbehl <cloudbehl@gmail.com>
23 months agomgr/dashboard: list subvolume groups 52635/head
Pedro Gonzalez Gomez [Tue, 25 Jul 2023 16:16:35 +0000 (18:16 +0200)]
mgr/dashboard: list subvolume groups

Fixes: https://tracker.ceph.com/issues/62168
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
23 months agorgw/lua: allow metatable fields to be cached 52225/head
Yuval Lifshitz [Thu, 22 Jun 2023 09:06:21 +0000 (09:06 +0000)]
rgw/lua: allow metatable fields to be cached

this is by making metatable names fully qualified names
that contain the entire "path" for reaching them and not
just the name of the object they point to.

with the fix, the code would either create a new metatable,
as in this case:

local o1 = Request.Object
-- new metatable is created to represent the Object in Request.Object
local o2 = Request.CopyFrom.Object
-- new metatable (with different upvalues) is created to represent Request.CopyFrom.Object
print(o1.Name)
print(o2.Name)

or, will reuse an existing metatable, as in this case:

local o1 = Request.Object
-- new metatable is created to represent the Object in Request.Object
local o2 = Request.Object
-- reuse the same metatable
print(o1.Name)
print(o2.Name)

Fixes: https://tracker.ceph.com/issues/58412
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
23 months agorgw/lua: expose correct value in Request.Bucket.User
Yuval Lifshitz [Wed, 21 Jun 2023 13:02:50 +0000 (13:02 +0000)]
rgw/lua: expose correct value in Request.Bucket.User

a change in zipper caused bucket->get_info().owner to return an empty
string. so the lua value now expose: bucket->get_owner()->get_id()

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
23 months agoMerge pull request #52273 from yuvalif/wip-yuval-lua-mem-limit
Yuval Lifshitz [Wed, 9 Aug 2023 13:35:22 +0000 (16:35 +0300)]
Merge pull request #52273 from yuvalif/wip-yuval-lua-mem-limit

rgw/lua: add configurable memory limit for the lua state

23 months agoMerge pull request #52154 from rhcs-dashboard/hosts-pagination
Nizamudeen A [Wed, 9 Aug 2023 09:21:37 +0000 (14:51 +0530)]
Merge pull request #52154 from rhcs-dashboard/hosts-pagination

mgr/dashboard: host pagination

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
23 months agomgr/dashboard: open popup on hover cluster status 52865/head
cloudbehl [Mon, 7 Aug 2023 18:08:09 +0000 (23:38 +0530)]
mgr/dashboard: open popup on hover cluster status

Fixes: https://tracker.ceph.com/issues/62351
Signed-off-by: cloudbehl <cloudbehl@gmail.com>
23 months agoMerge pull request #52745 from zdover23/wip-doc-2023-08-02-rados-operations-add-or...
zdover23 [Wed, 9 Aug 2023 01:24:47 +0000 (11:24 +1000)]
Merge pull request #52745 from zdover23/wip-doc-2023-08-02-rados-operations-add-or-rm-mons-1-of-x

doc/rados: edit operations/add-or-rm-mons (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
23 months agoMerge pull request #52884 from phlogistonjohn/jjm-doc-typo-fix
zdover23 [Wed, 9 Aug 2023 00:39:17 +0000 (10:39 +1000)]
Merge pull request #52884 from phlogistonjohn/jjm-doc-typo-fix

doc/cephadm: fix typo in cephadm initial crush location section

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
23 months agodoc/cephadm: fix typo in cephadm initial crush location section 52884/head
John Mulligan [Tue, 8 Aug 2023 20:35:49 +0000 (16:35 -0400)]
doc/cephadm: fix typo in cephadm initial crush location section

A minor typo fix found while skimming through the cephadm docs:
"will no remove" -> "will not remove".

Signed-off-by: John Mulligan <jmulligan@redhat.com>
23 months agorgw: enrich the sync notification failed log line. 52876/head
kchheda3 [Tue, 8 Aug 2023 11:51:23 +0000 (17:21 +0530)]
rgw: enrich the sync notification failed log line.

Signed-off-by: kchheda3 <kchheda3@bloomberg.net>
23 months agodoc/rados: edit operations/add-or-rm-mons (1 of x) 52745/head
Zac Dover [Wed, 2 Aug 2023 02:47:50 +0000 (12:47 +1000)]
doc/rados: edit operations/add-or-rm-mons (1 of x)

Edit the first part of doc/rados/operations/add-or-rm-mons.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
23 months agoqa: add test cases for vanilla ops commands 52547/head
Patrick Donnelly [Thu, 27 Jul 2023 00:46:55 +0000 (20:46 -0400)]
qa: add test cases for vanilla ops commands

To test they work, not that the output is useful.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
23 months agomds: dump locks when printing mutation ops
Patrick Donnelly [Tue, 18 Jul 2023 01:22:04 +0000 (21:22 -0400)]
mds: dump locks when printing mutation ops

For debugging where an operation may be stuck.

Fixes: https://tracker.ceph.com/issues/62086
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
23 months agocommon/TrackedOp: support overriding the _dump method
Patrick Donnelly [Wed, 26 Jul 2023 17:14:46 +0000 (13:14 -0400)]
common/TrackedOp: support overriding the _dump method

When dumping an op, it may be desirable to alter how it is dumped depending on
which locks are held. As it happens, I plan to dump extra information if the
mds_lock is held!

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
23 months agomds: remove op field obsoleted by more usable "reqid"
Patrick Donnelly [Fri, 21 Jul 2023 16:50:10 +0000 (12:50 -0400)]
mds: remove op field obsoleted by more usable "reqid"

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
23 months agomds: dump metareq_t instead of full op
Patrick Donnelly [Thu, 20 Jul 2023 13:41:53 +0000 (09:41 -0400)]
mds: dump metareq_t instead of full op

This avoids infinite recursion when dumping locks with xlock_by
non-null.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
23 months agomds: add lock type to formatter dump of SimpleLock
Patrick Donnelly [Wed, 19 Jul 2023 15:50:24 +0000 (11:50 -0400)]
mds: add lock type to formatter dump of SimpleLock

Otherwise you can't easily know which lock it is in the corresponding
MDSCacheObject.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
23 months agomds: mark print methods const
Patrick Donnelly [Wed, 19 Jul 2023 15:52:29 +0000 (11:52 -0400)]
mds: mark print methods const

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
23 months agomds: drop MDRequestImpl::msg_lock
Patrick Donnelly [Fri, 21 Jul 2023 17:05:15 +0000 (13:05 -0400)]
mds: drop MDRequestImpl::msg_lock

TrackedOp::lock is already suitable for this purpose.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
23 months agomds: lock TrackedOp when dumping
Patrick Donnelly [Fri, 21 Jul 2023 16:56:27 +0000 (12:56 -0400)]
mds: lock TrackedOp when dumping

The MDS does not generally bother locking a Mutation before changing
anything so this lock provides weak protection. In any case, try to
improve on that...

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>