rgw/sal: get_placement_target_names() returns void

the function returned an integer error code, but two callers were
incorrectly testing the return value as a boolean

the function just returns placement ids that are in-memory, so none of
the drivers have a failure case; change the return value to void

Fixes: https://tracker.ceph.com/issues/62771
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 3ad17ed3b222701bb6f4e3150989584645789d7c)

Merge pull request #53569 from zdover23/wip-doc-2023-09-21-backport-53176-to-reef

reef: doc: add note for removing (automatic) partitioning policy

Reviewed-by: Venky Shankar <vshankar@redhat.com>

doc: add note for removing (automatic) partitioning policy

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 20d027eb9d54ab4f6ba03dfc17d1c4c42eac1055)

Merge pull request #53536 from zdover23/wip-doc-2023-09-20-backport-53532-to-reef

reef: doc/man: s/kvstore-tool/monstore-tool/

doc/man: s/kvstore-tool/monstore-tool/

s/kvstore-tool/monstore-tool/ in accordance with Ilya's remark here:
https://github.com/ceph/ceph/pull/53450#discussion_r1329804085

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 231afc83131c366db46e9d0345f6928c1871ce4d)

Merge pull request #52950 from k0ste/wip-61722-reef

reef: Bluestore: fix bluestore collection_list latency perf counter

Merge pull request #53519 from zdover23/wip-doc-2023-09-19-backport-53518-to-reef

reef: doc/dev: Fix typos in files cephfs-mirroring.rst and deduplication.rst

doc/dev: Fix typos in files cephfs-mirroring.rst and deduplication.rst

Typo Error in Doc cephfs-mirroring.rst , replace RAODS with RADOS
Typo Error in Doc deduplication.rst , replace RAODS with RADOS

Signed-off-by: Daniel Parkes <dparkes@redhat.com>
(cherry picked from commit 06358e8d17a0e0fbd5d94b14595ade778a4fb5eb)

Merge pull request #53491 from zdover23/wip-doc-2023-09-18-backport-53490-to-reef

reef: doc/architecture: "Edit HA Auth" (one of several)

doc/architecture: "Edit HA Auth" (one of several)

Edit "High Availability Authentication" in doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e50c3e1c08ff09f44bb3a3b6f733b612b9f838d7)

Merge pull request #53488 from zdover23/wip-doc-2023-09-17-backport-53487-to-reef

reef: doc/architecture: Edit "HA Auth"

doc/architecture: Edit "HA Auth"

Edit "High Availability Authentication" in doc/architecture.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4cbef54bbaf363dd26a7d1711f3d839f88d4c2a8)

Merge pull request #53413 from trociny/wip-62506-reef

reef: rgw: handle http options CORS with v4 auth

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #53476 from zdover23/wip-doc-2023-09-15-backport-53450-to-reef

reef: doc/man: edit ceph-monstore-tool.rst

doc/man: edit ceph-monstore-tool.rst

Clean up the English in doc/man/8/ceph-monstore-tool.rst. Put all
commands in the imperative mood; make sentences more direct.

Follows https://github.com/ceph/ceph/pull/52860.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 02177f6368532c14b09f84e22efd64a7f7936b34)

Merge pull request #53429 from kamoltat/wip-ksirivad-reef-backport-50334

reef: pybind/mgr/pg_autoscaler: Reorderd if statement for the func: _maybe_adjust
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #53451 from zdover23/wip-doc-2023-09-14-backport-53444-to-reef

reef: doc/architecture: edit "High Avail. Monitors"

doc/architecture: edit "High Avail. Monitors"

Improve the sentence structure in the "High Availability Monitors"
section of doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 57019c346917e6f155d89452d768bd93bdd2e51c)

Merge pull request #53434 from zdover23/wip-doc-2023-09-13-backport-53423-to-reef

reef: doc/architecture: edit "Cluster Map"

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

doc/architecture: edit "Cluster Map"

Edit the section "Cluster Map" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit cc8dce2531e8fac64345c4b85087f52149e9a9d0)

Merge pull request #53427 from zdover23/wip-doc-2023-09-13-backport-53422-to-reef

reef: doc/glossary: add "primary affinity" to glossary

qa/workunits/mon/pg_autoscaler: Added bug-reproducer/test

Added a bug-reproducer/test to fix:

https://tracker.ceph.com/issues/58894

Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit 009430b5548db028fe8d48b2469544eca419b526)

pybind/mgr/pg_autoscaler: Reorderd if statement for the func: _maybe_adjust

Problem:

In the func `_maybe_adjust` we have this condition
where `if not p['would_adjust']: continue` which
would get triggered before `if p['pg_autoscale_mode'] == 'warn':`
if we don't have `pg_autoscale_mode` as `on`. This causes:
the autoscaler to not throw any warnings.

Solution:
Move `if p['pg_autoscale_mode'] == 'warn':` to be
higher than `if not p['would_adjust']: continue`.

Fixes: https://tracker.ceph.com/issues/58894
Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit c43fe7f07631bd0d795b711a100b9220b996ace0)

doc/glossary: add "primary affinity" to glossary

Add "Primary Affinity" to the glossary and link to the information in
the RADOS documentation that (more or less) explains it.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit f3a3f10e9ce0bf96d5eba25a786cdd254340878b)

Merge pull request #53420 from zdover23/wip-doc-2023-09-12-backport-53389-to-reef

doc: Add warning on manual CRUSH rule removal

Merge pull request #53402 from rishabh-d-dave/wip-62806-reef

reef: doc/cephfs: write cephfs commands fully in docs

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc: Add warning on manual CRUSH rule removal

Add warning for "osd erasure-code-profile rm" section under rados/operations.

Signed-off-by: Alvin Owyong <70066269+alvinowyong@users.noreply.github.com>
(cherry picked from commit f944fa8ddb022656dac3f1faebe81a7de37380f6)

rgw/auth: move http options v4 logic to get_v4_canonical_method()

Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>
(cherry picked from commit dbc0a4ed2dd6a92d06e585dda25b1325464efefb)

rgw/auth: handle HTTP OPTIONS with v4 auth

This adds code to properly verify the signature
for HTTP OPTIONS calls that is preflight CORS
requests passing the expected method in the
access-control-request-method header.

Fixes: https://tracker.ceph.com/issues/62033
Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>
(cherry picked from commit 814cae52baf04d9c3f0f3bd04b8e2daf16eb3874)

rgw/auth: check auth for http options requests

If we get a HTTP OPTIONS request we previously always
allowed the anonymous engine to handle the request even
if other auth was given in the request.

Fixes: https://tracker.ceph.com/issues/62033
Signed-off-by: Tobias Urdin <tobias.urdin@binero.com>
(cherry picked from commit 135b6fc20e8ad094ed94e05bfb1975578abbbdab)

Merge pull request #53394 from rhcs-dashboard/wip-62794-reef

reef: mgr/dashboard: display the groups in cephfs subvolume tab

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #53382 from aaSharma14/wip-62767-reef

reef: mgr/dashboard: Object gateway inventory card incorrect Buckets and user count

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/cephfs: write cephfs commands fully in docs

We write CephFS commands incompletely in docs. For example, "ceph tell
mds.a help" is simply written as "tell mds.a help". This might confuse
the reader and it won't harm to write the command in full.

Fixes: https://tracker.ceph.com/issues/62791
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit e63b573d3edc272d83ee1b5eb3dace037f762d87)

Merge pull request #53352 from idryomov/wip-61505-reef

reef: qa/suites/upgrade: enable default RBD image features

Reviewed-by: Mykola Golub <mgolub@suse.com>

mgr/dashboard: CephFS add groups in subvolume tab

Adds subvolume groups into the subvolume tabs in order to select the subvolumes from the appropiate group.
Also adds the capabilities to manage the subvolume groups of the subvolume in the different actions, create, edit, remove.

Fixes: https://tracker.ceph.com/issues/62675
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 041bc0c362bf4109416ecc12bc44aa7496ebb9d1)

Merge pull request #53392 from rhcs-dashboard/wip-62792-reef

reef: mgr/dashboard: fix rgw port manipulation error in dashboard

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #53386 from rhcs-dashboard/wip-62717-reef

reef: mgr/dashboard: remove green tick on old password field

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #53378 from rhcs-dashboard/wip-62786-reef

reef: mgr/dashboard: add validator for size field in the forms

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: fix rgw port manipulation error in dashboard

Fixes: https://tracker.ceph.com/issues/62735
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 9529163d29ab2d7fdb1e20b4066196dbb838917f)

Merge pull request #53388 from rhcs-dashboard/wip-62790-reef

reef: mgr/dashboard: images -> edit -> disable checkboxes for layering and deef-flatten

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: images: disable checkboxes for layering & deef-flatten

Fixes: https://tracker.ceph.com/issues/62502
Signed-off-by: avanthakkar <avanjohn@gmail.com>
(cherry picked from commit 9e820cf42e22a6586f18edc4232e1ce1f4e2c443)

mgr/dashboard: remove green tick on old password field

a green tick is showing to the field where we enter the old password in
login password change form. It starts showing green tick as soon as we
start typing on it. Removing that because its misleads the user.

Fixes: https://tracker.ceph.com/issues/62644
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 798a95dece66095db8ef0de9ed81c99fe23c4a11)

Merge pull request #53381 from aaSharma14/wip-62768-reef

reef: mgr/dashboard: Object gateway sync status cards keeps loading when multisite is not configured

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #53380 from aaSharma14/wip-62765-reef

reef: mgr/dashboard: rgw multisite topology view shows blank table for multisite entities

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #53379 from aaSharma14/wip-62766-reef

reef: mgr/dashboard: replace sync progress bar with last synced timestamp in rgw multisite sync status card

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: Object gateway inventory card incorrect Buckets and user count

Inventory(Buckets and users) data is wrong when you have buckets across multiple daemons.

Fixes: https://tracker.ceph.com/issues/62565
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit f12dc8f9680b3b6f73fba897822c192bcd402b43)

mgr/dashboard: Object gateway sync status cards keeps loading when multisite is not configured

Fixes: https://tracker.ceph.com/issues/62665
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 88042039409edcc6d3d6ea394bcc5a01e1adfb80)

mgr/dashboard: rgw multisite topology view shows blank table for multisite entities

Toplology view in multi-site dashboard displaying blank table regarding realm, zonegroup and zones in chrome browser

Fixes: https://tracker.ceph.com/issues/62677
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit de84e35d144bb978a6946d1335641fcec20ce58a)

mgr/dashboard: replace sync status bar with last synced timestamp in rgw multisite sync status card

Fixes: https://tracker.ceph.com/issues/62684
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 62df37c1ae801745494cefd418a3abbb85ff8815)

mgr/dashboard: add validator for size field in the forms

Fixes: https://tracker.ceph.com/issues/62655
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 51bf62cb1bf1b03947bfebca89635d54ec647369)

Merge pull request #53372 from zdover23/wip-doc-2023-09-11-backport-53371-to-reef

reef: doc/architecture.rst - edit a sentence

doc/architecture.rst - edit a sentence

Change the sentence structure of a sentence because the verb
"experience" looked like the abstract noun "experience" when I read it
with fresh eyes. I chose the perhaps TESOL-unfriendly verb "incur", but
I believe it is right.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 436fbf7a3e0960ebb51a0dc66d9c1d405bf6875f)

Merge pull request #53366 from zdover23/wip-doc-2023-09-10-backport-53353-to-reef

reef: doc/architecture.rst - edit up to "Cluster Map"

doc/architecture.rst - edit up to "Cluster Map"

Edit doc/architecture.rst up to "Cluster Map", but not including
"Cluster Map".

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b3538f8ade14014f6d34c7d6271cb37a0fdd8bb5)

Merge pull request #53349 from zdover23/wip-doc-2023-09-09-backport-53334-to-reef

reef: doc: update test cluster commands in README.md

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

qa/suites/upgrade: enable default RBD image features

Until commit 9fe05da41370 ("Revert "test: adjust rbd test case guards
to handle new defaults""), default RBD image features were enabled only
in Python API tests; C/C++ API tests were still exercising format 1
(6-7 years after its deprecation!).

Enable format 2 with default image features universally across upgrade
suites.

Fixes: https://tracker.ceph.com/issues/61505
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 05e24270a2efe85bcdceade87b0e91efcfca3001)

Merge pull request #53347 from zdover23/wip-doc-2023-09-09-backport-53335-to-reef

reef: doc/configuration: edit "bg" in mon-config-ref.rst

doc: update test cluster commands in README.md

The "rbd" pool has not been created by default since Luminous. This
commit removes a command that assumed the existence of the "rbd" pool.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 8d606003af59cac2cd8f6f9ca02e6506bde705f0)

doc/configuration: edit "bg" in mon-config-ref.rst

Edit the English in the section "Background" in
doc/rados/configuration/mon-config-ref.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d009f0757cb34cf1cc9ac107905235d1b2ac65cd)

Merge pull request #52927 from guits/wip-62039-reef

reef: ceph-volume: add --osd-id option to raw prepare

Merge pull request #52942 from ifed01/wip-ifed-fix-55260-ree

reef: os/bluestore: don't require bluestore_db_block_size when attaching new

Merge pull request #52619 from guits/wip-62151-reef

reef: ceph-volume: fix raw list for lvm devices

Merge pull request #52980 from k0ste/wip-62155-reef

reef: ceph-volume: fix raw list for lvm devices

Merge pull request #52875 from ifed01/wip-ifed-encrypted-ceph-volume-ref

reef: ceph_volume: support encrypted volumes for lvm new-db/new-wal/migrate commands

Merge pull request #53286 from guits/wip-62708-reef

reef: ceph-volume/cephadm: support lv devices in inventory

Merge pull request #53304 from rhcs-dashboard/wip-62719-reef

reef: mgr/dashboard: remove used and total used columns in favor of usage bar

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #53317 from zdover23/wip-doc-2023-09-07-backport-53300-to-reef

reef: doc/rados: add bulk flag to pools.rst

Merge pull request #53315 from zdover23/wip-doc-2023-09-07-backport-53314-to-reef

reef: doc/man: radosgw-admin.rst typo

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rados: add bulk flag to pools.rst

Add a link in pools.rst to the section in placement-groups.rst
describing the commands used to manage pools that are flagged "--bulk".

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 31f1224f611b560af7c42131ef38f0aa6dcdffb3)

doc/man: radosgw-admin.rst typo

Edit the text in the "bucket radoslist" entry.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit fb808732e8c8f9b64a443aa3ea30a677b1347be3)

Merge pull request #53312 from zdover23/wip-doc-2023-09-07-backport-53302-to-reef

reef: doc/man: remove docs about support for unix domain sockets

doc/man: remove docs about support for unix domain sockets

doc/man: support for unix domain sockets is not implemented, hence we
removed documentation about it.

(Note: the changes in this commit were the work of Rok Jaklič in
https://github.com/ceph/ceph/pull/48537. This pull request has been
raised because that pull request was for some mysterious reason causing
merge conflicts that were never resolved.)

Co-authored-by: Rok Jaklič rjaklic@gmail.com
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit fa40b7ef560fc60a107dad1604650e0bcf27e77e)

mgr/dashboard: remove used and total used columns in favor of usage bar

Fixes: https://tracker.ceph.com/issues/62697
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 802410d4b15c63e756c31672816ef8985341b47c)

Merge pull request #53254 from rhcs-dashboard/wip-62657-reef

reef: mgr/dashboard: fix image columns naming

Reviewed-by: Nizamudeen A <nia@redhat.com>

ceph-volume: support partitions in inventory

This makes ceph-volume report partitions in inventory.
A partition is a valid device for `ceph-volume lvm prepare`
so we should report them in inventory (when using `--list-all`
parameter).

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 00ba00fdfab8cb4969d46838e44cff3a03fc16ca)

ceph-volume: drop is_locked_raw_device()

This functions works for what it is supposed to do:

check if a device is busy.

That being said, this induces a race condition in `get_devices()`

Indeed, it does:

1/ `os.open()` with `(os.O_RDWR | os.O_EXCL)`
2/ `os.close()`

The second call has an effect: it triggers a udev event which causes
systemd-udevd to re-process the device. This seems to be a question of
millisecond but because of this, /sys (sysfs) isn't fully populated as
expected. Given that get_devices() collects a lot of details from sysfs
in a loop, some of these details can be missed.

ceph-volume overall doesn't make decisions based on `is_locked_raw_device()`
This detail is used only for reporting (inventory).
For this reason, dropping this function seems reasonnable.
As a compromise, we can check if the device has partitions and/or a FileSystem
on it.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 2422ad867dff9d526d7e8be543178c897991097f)

ceph-volume: add two unit tests

This adds two unit tests in order to cover `test_get_mapper_from_lv_path()`
and `test_get_lv_path_from_mapper()` functions from `api.lvm`

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit a485883f62df388ed19bd91a996ec543c0a9a30f)

cephadm: add new config option

This adds a new config option 'inventory_list_all' so one can make
the command `ceph orch device ls` report lvm devices too as they are
valid devices that can be used to be prepared as OSDs.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit e98ec820cf3acd1711d09e63ec5df8787a369cef)

ceph-volume: add new parameter '--list-all' to inventory

The inventory should report LV devices as they are valid devices that
can be used to be prepared as OSDs.

Fixes: https://tracker.ceph.com/issues/62362
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 605da29be9ef2903d4d84a624c4376963d6d8ed8)

ceph-volume: support type=lvm in get_devices()

LV devices are valid devices, they shouldn't be filtered in
`disk.get_devices()`

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 5470a86f9259843130d379515b96f5ced7969f27)

ceph-volume: add two helper functions

this adds `get_lv_path_from_mapper()` and `get_mapper_from_lv_path()`
functions in api.lvm.

they will help translating either an LV path from `/dev/mapper/LV`
to the format `/dev/VG/LV` or the opposite.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit c7164dfd599a1b406f9f1c870212cc0cbf08317d)

Merge pull request #53220 from rhcs-dashboard/wip-62642-reef

reef: mgr/dashboard: cleanup rbd-mirror process in dashboard e2e

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #53267 from zdover23/wip-doc-2023-09-04-backport-53264-to-reef

reef: doc/man/8: improve radosgw-admin.rst

doc/man/8: improve radosgw-admin.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit d986537f9b06e7e848b9624718a2eda21bb54f70)

Merge pull request #53261 from zdover23/wip-doc-2023-09-03-backport-50360-to-reef

reef: doc/radosgw: multisite - edit "migrating a single-site"

doc/radosgw: multisite - edit "migrating a single-site"
Add the import step of the section "Migrating a Single-Site Deployment to Multi-Site"
in doc/radosgw/multisite.rst. The field "name" and "api_name" should be matched.

Signed-off-by: Qi Tao <tgfree7@gmail.com>
(cherry picked from commit 579c14055d202429ad25a469c30a3d68e0329391)

Merge pull request #53260 from zdover23/wip-doc-2023-09-02-backport-48180-to-reef

reef: doc: make instructions to get an updated cephadm common

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #53258 from zdover23/wip-doc-2023-09-02-backport-53247-to-reef

reef: doc/README.md - improve "Running a test cluster"

doc: make instructions to get an updated cephadm common

As discussed in person and over the ceph orch weekly, we want all users
to use a recent supported version of cephadm. Previously, the
instructions only had those downloading cephadm with curl using the
"add-repo" and "install" commands to get a up-to-date cephadm build.
According to ADK we've seen cases of users get "old" distro packages
in the past. Change the instructions so that the "update cephadm" steps
are common after acquiring a "bootstrap copy" of cephadm.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit d7921e88d69b4bc355da9c0327cc33e59e7d7abb)
(cherry picked from commit d11cf0e82aab8d4cef9d423e5d463a373eaf383a)
(cherry picked from commit 9ad38033cc5c7f177cb8fe3bae696682687e0346)

doc: update the cephadm download instructions

Starting with reef, cephadm is a compiled (zipapp) python application.
The cephadm script has been renamed and thus the old curl-based
download instructions will no loner work. While cephadm still has
no dependencies outside the Python stdlib, this will be changed in
future versions so it is no longer appropriate to just download the
source file of cephadm and run it either.

This change updates the `Install cephadm` section of the doc to explain
how to acquire a "compiled" version of cephadm as well as:
* moving and tweaking the note that the two installation methods are
  distinct
* adding a new note linking to instructions on building cephadm
* moving the distribution-specific installations before the curl-based
  installation to subtly hint that we prefer you to get it using
  packages if you can
* Noting cephadm's minimal required python verision and how to run it
  with a particular python version.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit d11cf0e82aab8d4cef9d423e5d463a373eaf383a)

doc: add instructions for compiling cephadm

Now that cephadm is based on zipapp, add a short section to the
developer docs explaining how to build cephadm yourself.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit 9ad38033cc5c7f177cb8fe3bae696682687e0346)

doc/README.md - improve "Running a test cluster"

Improve the English in the section "Running a test cluster in the
ceph/README.md file.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 420ecc7addaad1969cb634289c2399ea38ea9a90)

Merge pull request #53256 from zdover23/wip-doc-2023-09-02-backport-53249-to-reef

reef: doc/start: correct ABC test chart

doc/start: correct ABC test chart

Signed-off-by: Dmitry Kvashnin <dm.kvashnin@gmail.com>
(cherry picked from commit fdbd567d913bdacbbd36d2c3b9180af8a1750228)

mgr/dashboard: fix image columns naming

Fixes: https://tracker.ceph.com/issues/62551
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 338bb5c8a46e2a84fd139c392302e7ff846d3ef8)

Merge pull request #53124 from adk3798/reef-batch-pre-refactor

reef: cephadm batch backport Aug 23

Reviewed-by: John Mulligan <jmulligan@redhat.com>

mgr/cephadm: filter hosts that can't support VIP for ingress

Keepalive daemons need the host to have an interface
on which they can set up their VIP. If a host
does not have any interface that can work, we should
filter it out

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 17bc76f5bb6b3ef8c962ce31a80c5a3a43b5bdd2)

mgr/cephadm: select IPs/interface based on VIP for keepalive conf

We need to make sure the keepalive conf sets
the unicast src and peer IPs to be the ones
in the same subnet as the VIP we're setting up,
as well as specify the correct interface. Otherwise,
the keepalive daemons don't speak to each other
properly and all end up going into MASTER state.

Fixes: https://tracker.ceph.com/issues/62276
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 58ddc4e20f7cead1f2594241450f4beb5230c746)

Conflicts:
src/pybind/mgr/cephadm/tests/test_services.py

Cephadm: Add first_virtual_router_id to generated yaml on test

It seems that the ServiceSpec, when dump to yaml will generate
a yaml with first_virtual_router_id, as its default value is 50.

Signed-off-by: Luis Domingues <domingues.luis@protonmail.ch>
(cherry picked from commit 0901f98a05e5d55b8b3cc17a0cae38094ae88a6f)
(cherry picked from commit 929cf28a1edb47db9e9e18e0212a919072c33c7b)

cephadm: Add parameter to set keepalived's virtual router id

When deploying more than 1 ingress, two instances of keepalived
can be generated with the same virtual_router_id. This commit
adds posibility to change the virtual_router_id of keepalived
from the spec file.

Signed-off-by: Luis Domingues <domingues.luis@protonmail.ch>
(cherry picked from commit bb69368fb5cd1def58cbe638dbd4d3bcf63e431f)
(cherry picked from commit 12cb31447e9a4efe02b32b03271d288a2ebcb0ab)

cephadm: Split multicast interface and unicast_ip in keepalived.conf

When deploying keepalived, cephadm set interface and unicast_src_ip
in keepalived.conf. However, having both options are set, but
if unicast_src_ip is not in the interface set by 'interface',
the instrances of keepalived will not properly commuicate.

This commit makes both options exclusive, and add an option to set
either one or the other. Default is set to 'interface', as it seems
multicast is the default way to deploy keepalived.

Signed-off-by: Luis Domingues <domingues.luis@protonmail.ch>
(cherry picked from commit 0dfe3e68a9284736f643a06acfda719cec0a6ea4)
(cherry picked from commit 837c273da2aa3dd3b3fe09b9ac04fd032149de6d)

cephadm: fixups for unit tests

These fixes really should be part of the commits
that brought in/changed the tests, but it's
difficult to find the exact commits as part of
this batch backport so I'm doing these minor fixups
in their own commit

Signed-off-by: Adam King <adking@redhat.com>