]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
21 months agodoc/architecture: edit "Data Scrubbing" 53723/head
Zac Dover [Thu, 28 Sep 2023 18:40:08 +0000 (04:40 +1000)]
doc/architecture: edit "Data Scrubbing"

Edit the "Data Scrubbing" listitem in the list of benefits conferred by
the use by OSDs of the aggregate power of the cluster, in the section
"Smart Daemons Enable Hyperscale" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agoMerge PR #53594 into main
Venky Shankar [Fri, 29 Sep 2023 04:31:17 +0000 (10:01 +0530)]
Merge PR #53594 into main

* refs/pull/53594/head:
qa: fix "no orch backend set" in nfs suite

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge pull request #53707 from zdover23/wip-doc-2023-09-28-architecture-12-of-x
zdover23 [Thu, 28 Sep 2023 21:35:45 +0000 (07:35 +1000)]
Merge pull request #53707 from zdover23/wip-doc-2023-09-28-architecture-12-of-x

doc/architecture: edit "OSD Membership and Status"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agodoc/architecture: edit "OSD Membership and Status" 53707/head
Zac Dover [Thu, 28 Sep 2023 03:55:02 +0000 (13:55 +1000)]
doc/architecture: edit "OSD Membership and Status"

Edit "OSD Membership and Status" in the "Smart Daemons Enable
Hyperscale" section of doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agoMerge pull request #53608 from cbodley/wip-62536
Casey Bodley [Thu, 28 Sep 2023 14:37:20 +0000 (15:37 +0100)]
Merge pull request #53608 from cbodley/wip-62536

qa/rgw/sts: keycloak task installs java manually

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
21 months agoMerge pull request #53432 from liu-chunmei/seastore_device_size
Liu-Chunmei [Thu, 28 Sep 2023 03:11:47 +0000 (20:11 -0700)]
Merge pull request #53432 from liu-chunmei/seastore_device_size

crimson/vstart: default seastore_device_size will be out of space f…

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
21 months agoMerge pull request #53607 from cfsnyder/wip-cfsnyder-bucket-check-bug
Casey Bodley [Wed, 27 Sep 2023 17:38:42 +0000 (18:38 +0100)]
Merge pull request #53607 from cfsnyder/wip-cfsnyder-bucket-check-bug

rgw: fix radosgw-admin bucket check stat calculation bug

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #52393 from yuvalif/wip-yuval-enable-trace-lua
Yuval Lifshitz [Wed, 27 Sep 2023 15:07:28 +0000 (18:07 +0300)]
Merge pull request #52393 from yuvalif/wip-yuval-enable-trace-lua

common/tracer: remove is_enabled check in add_span methods

reviewed-by: cbodley, ljflores

21 months agoMerge pull request #53523 from rhcs-dashboard/add-ceph-daemon-label-labeled-counters
Ilya Dryomov [Wed, 27 Sep 2023 07:27:04 +0000 (09:27 +0200)]
Merge pull request #53523 from rhcs-dashboard/add-ceph-daemon-label-labeled-counters

exporter: add ceph_daemon labels to labeled counters as well

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
21 months agoMerge pull request #52828 from rhcs-dashboard/angular-15
Nizamudeen A [Wed, 27 Sep 2023 05:41:35 +0000 (11:11 +0530)]
Merge pull request #52828 from rhcs-dashboard/angular-15

mgr/dashboard: upgrade to angular v15

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
21 months agoMerge pull request #53596 from rhcs-dashboard/fix-validations-in-cephfs-forms
Nizamudeen A [Wed, 27 Sep 2023 05:13:14 +0000 (10:43 +0530)]
Merge pull request #53596 from rhcs-dashboard/fix-validations-in-cephfs-forms

mgr/dashboard: fix cephfs forms validations

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
21 months agoMerge PR #53529 into main
Venky Shankar [Wed, 27 Sep 2023 04:27:25 +0000 (09:57 +0530)]
Merge PR #53529 into main

* refs/pull/53529/head:
doc: update colorama, packaging
cephfs-shell: drop LooseVersion for version.parse

Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge pull request #53685 from zdover23/wip-doc-2023-09-27-architecture-11-of-x
zdover23 [Tue, 26 Sep 2023 20:54:06 +0000 (06:54 +1000)]
Merge pull request #53685 from zdover23/wip-doc-2023-09-27-architecture-11-of-x

doc/architecture: edit "OSDs service clients directly"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agodoc/architecture: edit "OSDs service clients directly" 53685/head
Zac Dover [Tue, 26 Sep 2023 20:00:34 +0000 (06:00 +1000)]
doc/architecture: edit "OSDs service clients directly"

Edit "OSDs service clients directly" in the list in
"Smart Daemons Enable Hyperscale" in doc/architecure.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agoMerge pull request #53615 from ronen-fr/wip-rf-great-move
Ronen Friedman [Tue, 26 Sep 2023 14:34:41 +0000 (17:34 +0300)]
Merge pull request #53615 from ronen-fr/wip-rf-great-move

tools, rgw/test: add std:: qualifiers to 'move'

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
21 months agoMerge pull request #53048 from YiteGu/add-slow-count-committed-kv
Laura Flores [Tue, 26 Sep 2023 14:22:44 +0000 (10:22 -0400)]
Merge pull request #53048 from YiteGu/add-slow-count-committed-kv

os/bluestore: add some slow count for bluestore

21 months agoMerge pull request #52930 from leonid-s-usov/msg_wait
Laura Flores [Tue, 26 Sep 2023 14:22:23 +0000 (10:22 -0400)]
Merge pull request #52930 from leonid-s-usov/msg_wait

msg/AsyncMessenger: re-evaluate the stop condition when woken up in 'wait()'

21 months agoMerge pull request #52906 from sseshasa/wip-fix-config-dump-pretty-print
Laura Flores [Tue, 26 Sep 2023 14:22:08 +0000 (10:22 -0400)]
Merge pull request #52906 from sseshasa/wip-fix-config-dump-pretty-print

mon/ConfigMonitor: Show localized name in "config dump --format json" output

21 months agoMerge pull request #52200 from jinmyeonglee/61819
Laura Flores [Tue, 26 Sep 2023 14:21:51 +0000 (10:21 -0400)]
Merge pull request #52200 from jinmyeonglee/61819

client: append to buffer list to save all result from wildcard command

21 months agoMerge pull request #50585 from ssdohammer-sl/fix-metadata-obj-promote
Laura Flores [Tue, 26 Sep 2023 14:21:14 +0000 (10:21 -0400)]
Merge pull request #50585 from ssdohammer-sl/fix-metadata-obj-promote

osd: chunked type manifest object not to be promoted

21 months agomgr/dashboard: upgrade to cypress 12 52828/head
Nizamudeen A [Fri, 15 Sep 2023 11:11:19 +0000 (16:41 +0530)]
mgr/dashboard: upgrade to cypress 12

Looks like chrome 117 will need cypress >=12.15.0
https://github.com/cypress-io/cypress-documentation/issues/5479

Signed-off-by: Nizamudeen A <nia@redhat.com>
21 months agomgr/dashboard: adapt and refactor jest test files
Nizamudeen A [Wed, 6 Sep 2023 05:09:51 +0000 (10:39 +0530)]
mgr/dashboard: adapt and refactor jest test files

Use the `configureTestBed` as the placeholder for adding the
declarations, imports... that is required for the unit tests to run

Fixes: https://tracker.ceph.com/issues/62844
Signed-off-by: Nizamudeen A <nia@redhat.com>
21 months agoMerge pull request #51923 from kamoltat/wip-ksirivad-fix-61570
Kamoltat (Junior) Sirivadhna [Tue, 26 Sep 2023 13:45:18 +0000 (09:45 -0400)]
Merge pull request #51923 from kamoltat/wip-ksirivad-fix-61570

pybind/mgr/pg_autoscaler: fix warn when not too few pgs
Reviewed-by: Laura Flores <lflores@redhat.com>
21 months agoMerge pull request #53324 from aclamk/wip-aclamk-osd-op-scraper-fixes
Adam Kupczyk [Tue, 26 Sep 2023 13:20:36 +0000 (15:20 +0200)]
Merge pull request #53324 from aclamk/wip-aclamk-osd-op-scraper-fixes

Set of scraper improvements

21 months agoexporter: add ceph_daemon labels to labeled counters as well 53523/head
avanthakkar [Tue, 19 Sep 2023 08:18:43 +0000 (13:48 +0530)]
exporter: add ceph_daemon labels to labeled counters as well

Exporter missed adding the `ceph_daemon` or `instance_id`
labels(in case if rgw metrics) to the new labeled performance counters.

Fixes: https://tracker.ceph.com/issues/62874
Signed-off-by: avanthakkar <avanjohn@gmail.com>
21 months agoMerge pull request #53284 from xxhdx1985126/wip-seastore-remap-intermediate_key
Yingxin [Tue, 26 Sep 2023 08:36:43 +0000 (16:36 +0800)]
Merge pull request #53284 from xxhdx1985126/wip-seastore-remap-intermediate_key

crimson/os/seastore/transaction_manager: move intermediate_key by "remap_offset" when remapping the "back" half of the original pin

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
21 months agoMerge pull request #53455 from xxhdx1985126/wip-seastore-no-touch-pending
Yingxin [Tue, 26 Sep 2023 08:35:16 +0000 (16:35 +0800)]
Merge pull request #53455 from xxhdx1985126/wip-seastore-no-touch-pending

crimson/os/seastore/cache: don't add EXIST_CLEAN extents to lru

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
21 months agoMerge pull request #53657 from zdover23/wip-doc-2023-09-26-architecture-10-of-x
zdover23 [Tue, 26 Sep 2023 04:38:38 +0000 (14:38 +1000)]
Merge pull request #53657 from zdover23/wip-doc-2023-09-26-architecture-10-of-x

doc/architecture: edit "SDEH"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agodoc/architecture: edit "SDEH" 53657/head
Zac Dover [Mon, 25 Sep 2023 21:40:42 +0000 (07:40 +1000)]
doc/architecture: edit "SDEH"

Edit the front matter of the "Smart Daemons Enable Hyperscale" section
of doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agocrimson/os/seastore/cache: replace is_clean by is_stable_clean wherever 53455/head
Xuehan Xu [Tue, 26 Sep 2023 03:30:54 +0000 (11:30 +0800)]
crimson/os/seastore/cache: replace is_clean by is_stable_clean wherever
possible

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
21 months agocrimson/os/seastore/transaction_manager: move intermediate_key by 53284/head
Xuehan Xu [Tue, 5 Sep 2023 08:03:29 +0000 (16:03 +0800)]
crimson/os/seastore/transaction_manager: move intermediate_key by
"remap_offset" when remapping the "back" half of the original pin

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
21 months agoMerge pull request #52442 from kamoltat/wip-ksirivad-fix-tracker-61922
Kamoltat (Junior) Sirivadhna [Mon, 25 Sep 2023 21:57:38 +0000 (17:57 -0400)]
Merge pull request #52442 from kamoltat/wip-ksirivad-fix-tracker-61922

pybind/mgr/pg_autoscaler: noautoscale flag retains individual pool configs
Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
21 months agoMerge pull request #51926 from adk3798/host-drain-zap
Adam King [Mon, 25 Sep 2023 17:39:54 +0000 (13:39 -0400)]
Merge pull request #51926 from adk3798/host-drain-zap

mgr/cephadm: add ability to zap OSDs' devices while draining host

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
21 months agoMerge pull request #53589 from adk3798/cephadm-refactor-host-facts
Adam King [Mon, 25 Sep 2023 17:38:07 +0000 (13:38 -0400)]
Merge pull request #53589 from adk3798/cephadm-refactor-host-facts

cephadm: create host_facts.py in cephadmlib

Reviewed-by: John Mulligan <jmulligan@redhat.com>
21 months agocephadm: format black host_facts.py 53589/head
Adam King [Thu, 21 Sep 2023 20:28:09 +0000 (16:28 -0400)]
cephadm: format black host_facts.py

Signed-off-by: Adam King <adking@redhat.com>
21 months agocephadm: create host_facts.py in cephadmlib
Adam King [Thu, 21 Sep 2023 20:25:31 +0000 (16:25 -0400)]
cephadm: create host_facts.py in cephadmlib

For storing classes/functions related to gathering
information about the hosts such as disk enclosures
and networks

Signed-off-by: Adam King <adking@redhat.com>
21 months agoqa/workunits: modified tests for noautoscale flag change 52442/head
Kamoltat [Thu, 13 Jul 2023 19:41:29 +0000 (19:41 +0000)]
qa/workunits: modified tests for noautoscale flag change

modified:

`qa/workunits/mon/test_noautoscale_flag.sh`
`qa/workunits/cephtool/test.sh`

adding test coverage to files mentioned above

Fixes: https://tracker.ceph.com/issues/61922
Signed-off-by: Kamoltat <ksirivad@redhat.com>
21 months agoMerge pull request #53482 from adk3798/cephadm-refactor-decorators
Adam King [Mon, 25 Sep 2023 12:32:39 +0000 (08:32 -0400)]
Merge pull request #53482 from adk3798/cephadm-refactor-decorators

cephadm: start decorators.py in cephadmlib

Reviewed-by: John Mulligan <jmulligan@redhat.com>
21 months agoMerge pull request #53479 from rhcs-dashboard/upgrade-ui-popover-fix
Pedro Gonzalez Gomez [Mon, 25 Sep 2023 10:24:58 +0000 (12:24 +0200)]
Merge pull request #53479 from rhcs-dashboard/upgrade-ui-popover-fix

mgr/dashboard: remove empty popover when there are no health warns

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
21 months agorgw: fix output formatting of bucket index check admin api 53607/head
Cory Snyder [Mon, 25 Sep 2023 10:06:41 +0000 (10:06 +0000)]
rgw: fix output formatting of bucket index check admin api

The bucket index check admin API was previously returning invalid
JSON.

Signed-off-by: Cory Snyder <csnyder@1111systems.com>
21 months agoMerge pull request #53512 from rhcs-dashboard/promqls-enhancements
Nizamudeen A [Mon, 25 Sep 2023 07:45:11 +0000 (13:15 +0530)]
Merge pull request #53512 from rhcs-dashboard/promqls-enhancements

mgr/dashboard: fix prometheus queries subscriptions

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
21 months agoMerge pull request #53631 from zdover23/wip-doc-2023-09-25-architecture-9-of-x
zdover23 [Mon, 25 Sep 2023 05:06:22 +0000 (15:06 +1000)]
Merge pull request #53631 from zdover23/wip-doc-2023-09-25-architecture-9-of-x

doc/architecture: edit "HA Authentication"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agodoc/architecture: edit "HA Authentication" 53631/head
Zac Dover [Mon, 25 Sep 2023 04:34:06 +0000 (14:34 +1000)]
doc/architecture: edit "HA Authentication"

Edit "High Availability Authentication" in doc/architecture.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agoMerge pull request #53575 from rkachach/fix_issue_62838
Adam King [Sun, 24 Sep 2023 13:48:20 +0000 (09:48 -0400)]
Merge pull request #53575 from rkachach/fix_issue_62838

mgr/cephadm: removing double quotes from the generated nvmeof config

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
21 months agocephadm: black format initial decorators.py 53482/head
Adam King [Fri, 15 Sep 2023 13:48:29 +0000 (09:48 -0400)]
cephadm: black format initial decorators.py

Signed-off-by: Adam King <adking@redhat.com>
21 months agocephadm: start decorators.py in cephadmlib
Adam King [Fri, 15 Sep 2023 13:44:58 +0000 (09:44 -0400)]
cephadm: start decorators.py in cephadmlib

Originally, wanted to move all the decorators into
their own files. Unfortunately, that isn't possible
at this time as most of them depend on things that
are still within cephadm.py This includes

list_daemons
_rm_cluster
is_fsid
termcolor
ContainerInfo
Ceph

and I'm sure I'm missing some others. We'll have to
revisit this again later when more of these things
have moved, or they can be slowly moved as their
dependencies are.

Signed-off-by: Adam King <adking@redhat.com>
21 months agoMerge pull request #53468 from phlogistonjohn/jjm-cephadm-move-container-types
Adam King [Sun, 24 Sep 2023 13:39:47 +0000 (09:39 -0400)]
Merge pull request #53468 from phlogistonjohn/jjm-cephadm-move-container-types

cephadm: move container types

Reviewed-by: Adam King <adking@redhat.com>
21 months agoMerge pull request #53613 from zdover23/wip-doc-2023-09-23-architecture-8-of-x
zdover23 [Sat, 23 Sep 2023 17:52:15 +0000 (03:52 +1000)]
Merge pull request #53613 from zdover23/wip-doc-2023-09-23-architecture-8-of-x

doc/architecture: "Edit HA Auth"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agodoc/architecture: "Edit HA Auth" 53613/head
Zac Dover [Sat, 23 Sep 2023 02:26:18 +0000 (12:26 +1000)]
doc/architecture: "Edit HA Auth"

Rewrite the explanation of how a client authenticates against a monitor.
This is a rewrite of a single paragraph, and has been set apart in its
own PR so that it can receive the maximum amount of scrutiny that the
upstream Ceph community can muster.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agoMerge pull request #53097 from mkogan1/rgw-wip-t62141-valg-supp
Casey Bodley [Sat, 23 Sep 2023 15:11:38 +0000 (16:11 +0100)]
Merge pull request #53097 from mkogan1/rgw-wip-t62141-valg-supp

valgrind: UninitCondition under __run_exit_handlers suppression

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #49405 from tchaikov/clang-16
Kefu Chai [Sat, 23 Sep 2023 12:23:15 +0000 (20:23 +0800)]
Merge pull request #49405 from tchaikov/clang-16

run-make-check.sh: use clang-17 if available

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
21 months agoMerge pull request #51890 from lxbsz/wip-61394
Rishabh Dave [Sat, 23 Sep 2023 09:24:14 +0000 (14:54 +0530)]
Merge pull request #51890 from lxbsz/wip-61394

test: unmount the mountpoint just before exiting

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
21 months agorun-make-check.sh: use clang-17 if available 49405/head
Kefu Chai [Tue, 13 Dec 2022 07:54:04 +0000 (15:54 +0800)]
run-make-check.sh: use clang-17 if available

now that clang-17 has been released, let's use it if available.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
21 months agorgw/test: add std:: qualifiers to 'move' 53615/head
Ronen Friedman [Sat, 23 Sep 2023 06:10:08 +0000 (01:10 -0500)]
rgw/test: add std:: qualifiers to 'move'

to silence compiler warnings.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
21 months agotools: add std:: qualifiers to 'move'
Ronen Friedman [Sat, 23 Sep 2023 06:06:14 +0000 (01:06 -0500)]
tools: add std:: qualifiers to 'move'

to silence compiler warnings.
e.g. (ceph_dedup_tool.cc:1104:32: warning: unqualified call to
'std::move' [-Wunqualified-std-cast-call]
     estimate_threads.push_back(move(ptr));
                               ^
                               std::

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
21 months agoMerge pull request #53546 from mcv21/deb_package_fixes
Kefu Chai [Sat, 23 Sep 2023 05:43:12 +0000 (13:43 +0800)]
Merge pull request #53546 from mcv21/deb_package_fixes

debian: update to dh compat 12, fix more serious packaging errors, correct copyright syntax

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
21 months agoMerge pull request #50611 from cbodley/wip-rgw-sal-list-buckets
Casey Bodley [Fri, 22 Sep 2023 22:20:20 +0000 (23:20 +0100)]
Merge pull request #50611 from cbodley/wip-rgw-sal-list-buckets

rgw/sal: list_buckets() returns RGWBucketEnts

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
21 months agoqa: fix "no orch backend set" in nfs suite 53594/head
Dhairya Parmar [Fri, 22 Sep 2023 12:41:31 +0000 (18:11 +0530)]
qa: fix "no orch backend set" in nfs suite

Fixes: https://tracker.ceph.com/issues/62870
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
21 months agoqa/rgw/sts: keycloak task installs java manually 53608/head
Casey Bodley [Fri, 22 Sep 2023 21:37:33 +0000 (17:37 -0400)]
qa/rgw/sts: keycloak task installs java manually

java had already been installed automatically before centos 9. add an
override to install the jdk-17 packages manually

Fixes: https://tracker.ceph.com/issues/62536
Signed-off-by: Casey Bodley <cbodley@redhat.com>
21 months agorgw: fix radosgw-admin bucket check stat calculation bug
Cory Snyder [Fri, 22 Sep 2023 21:08:25 +0000 (21:08 +0000)]
rgw: fix radosgw-admin bucket check stat calculation bug

Fixes a regression with radosgw-admin bucket check stat
calculation and bucket reshard stat calculation when
there are objects that have transitioned from unversioned
to versioned. The bug was introduced in
152aadb71b61c53a4832a1c8cf82fce3d64b68d1.

Signed-off-by: Cory Snyder <csnyder@1111systems.com>
21 months agorgw: add test case to reproduce bucket check stats bug for versioned bucket
Cory Snyder [Fri, 22 Sep 2023 21:00:46 +0000 (21:00 +0000)]
rgw: add test case to reproduce bucket check stats bug for versioned bucket

Reproduces a regression where radosgw-admin bucket check incorrectly counts
objects that started as unversioned and later transitioned to versioned.

Signed-off-by: Cory Snyder <csnyder@1111systems.com>
21 months agorgw/sal: StoreBucket no longer wraps RGWBucketEnt 50611/head
Casey Bodley [Tue, 21 Mar 2023 18:21:26 +0000 (14:21 -0400)]
rgw/sal: StoreBucket no longer wraps RGWBucketEnt

`sal::Bucket` no longer needs to wrap `RGWBucketEnt` to support user
bucket listings, so can be represented by `RGWBucketInfo` alone. the
bucket stats interfaces that relied on RGWBucketEnt internally now
return their result as either `RGWBucketEnt` or `RGWStorageStats`

Signed-off-by: Casey Bodley <cbodley@redhat.com>
21 months agorgw/sal: list_buckets() returns RGWBucketEnts
Casey Bodley [Tue, 21 Mar 2023 17:36:56 +0000 (13:36 -0400)]
rgw/sal: list_buckets() returns RGWBucketEnts

`sal::User::list_buckets()` no longer returns a map of `sal::Bucket`
handles. it now uses `std::span<RGWBucketEnt>` for input and output.
`RGWBucketEnt` contains all of the information we need to satisfy
ListBuckets requests, and also stores the `rgw_bucket` key for use with
`Driver::get_bucket()` where a `sal::Bucket` handle is necessary

`sal::BucketList` contains the span of results and the `next_marker`.
the `is_truncated` flag was removed in favor of `!next_marker.empty()`

the checks for `user->get_max_buckets()` on bucket creation now use a
paginated `check_user_max_buckets()` helper function that limits the
number of allocated entries to `rgw_list_buckets_max_chunk`

Signed-off-by: Casey Bodley <cbodley@redhat.com>
21 months agodebian: call dh_python3 for ceph-{base,common,fuse,volume} 53546/head
Matthew Vernon [Wed, 20 Sep 2023 15:37:17 +0000 (16:37 +0100)]
debian: call dh_python3 for ceph-{base,common,fuse,volume}

In the cases of ceph-base, ceph-common, and ceph-fuse, this picks up
that these packages contain python scripts and adds a necessary
python3 dependency. In the case of ceph-volume it additionally parses
the requirements.txt file.

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
21 months agodebian: radosgw.init to installinit, remove auto_build override
Matthew Vernon [Wed, 20 Sep 2023 15:33:13 +0000 (16:33 +0100)]
debian: radosgw.init to installinit, remove auto_build override

Installation of init scripts properly belongs with dh_installinit, so
move the installation there.

That means we no longer need the override of dh_auto_build, which
simplifies the rules file.

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
21 months agodebian: specify a dependency on python3 for cephadm
Matthew Vernon [Wed, 20 Sep 2023 15:30:24 +0000 (16:30 +0100)]
debian: specify a dependency on python3 for cephadm

cephadm is a compressed zipapp, and dh3_python3 doesn't understand
this sort of binary file, so fails to produce the required python3
dependency. So specify this explicitly in debian/control

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
21 months agodebian: remove obsolete ceph-base.docs, restore dh_installdocs
Matthew Vernon [Wed, 20 Sep 2023 15:23:52 +0000 (16:23 +0100)]
debian: remove obsolete ceph-base.docs, restore dh_installdocs

debian/ceph-base.docs only referred to a README that doesn't exist, so
remove it. Because dpkg-source doesn't reflect deletions from debian/
cf the orig.tar.gz, also remove the file in dh_auto_clean.

Then do away with the removal of the empty override of dh_installdocs;
the main benefit of which here is that debian/copyright gets installed
in all of the built packages, which otherwise lack a copyright
file.

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
21 months agodebian: correct maintainer address
Matthew Vernon [Wed, 20 Sep 2023 15:15:54 +0000 (16:15 +0100)]
debian: correct maintainer address

This means that debian/control matches changelog entries, and that the
Maintainer address is up to date.

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
21 months agodebian: dh compat to 12, necessary init/systemd adjustments
Matthew Vernon [Wed, 20 Sep 2023 15:13:43 +0000 (16:13 +0100)]
debian: dh compat to 12, necessary init/systemd adjustments

Bring the dh compat level to 12, the most recent supported by the
oldest supported Ubuntu LTS release, 20.04. This necessitates changes
to how initscripts & systemd packaging are done.

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
21 months agodebian/copyright: update syntax, maintainer, add license stanzas
Matthew Vernon [Wed, 20 Sep 2023 12:27:15 +0000 (13:27 +0100)]
debian/copyright: update syntax, maintainer, add license stanzas

Update the header paragraph to link to the canonical URL for the
format, and point to dev@ceph.io as the Contact.

Also add License: stanzas to reflect the licences in use (and refer to
fuller versions in /usr/share/common-licenses/ as appropriate).

This means that packages containing this copyright file are better in
compliance with the licences concerned.

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
21 months agodebian: add missing item separators in debian/control
Matthew Vernon [Mon, 11 Sep 2023 15:52:49 +0000 (16:52 +0100)]
debian: add missing item separators in debian/control

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
21 months agodebian: remove {Build-,}Depends on essential packages
Matthew Vernon [Mon, 11 Sep 2023 15:49:19 +0000 (16:49 +0100)]
debian: remove {Build-,}Depends on essential packages

Unless there's a version requirement (which there isn't here),
packages should not declare a Build-Depends: or Depends: relationship
on essential packages. Policy link:

https://www.debian.org/doc/debian-policy/ch-binary.html#dependencies

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
21 months agodebian: specify interpreters for ceph-mon and ceph-osd postinsts
Matthew Vernon [Mon, 11 Sep 2023 15:48:17 +0000 (16:48 +0100)]
debian: specify interpreters for ceph-mon and ceph-osd postinsts

These were previously missing. The requirement for interpreters is in
Debian policy section 10.4:
https://www.debian.org/doc/debian-policy/ch-files.html#s-scripts

Debian's packaging already adds the #! to these two postinsts. In
practice, a text executible without a #! line will likely be executed
by the calling shell, so a lot of the time we'd get away with it
unless the administrator is using an incompatible shell like tcsh.

This behaviour of shells is documented in POSIX section 1(e)(i)(b)
here:
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#tag_18_09_01_01

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
21 months agodebian: Build-Depend on g++ 11 or greater
Matthew Vernon [Wed, 20 Sep 2023 16:43:30 +0000 (17:43 +0100)]
debian: Build-Depend on g++ 11 or greater

Rely on the packaging system to provide a suitable g++ of version 11
or greater, and removing the corresponding hard-coding from
debian/rules, since cmake will then find a suitable version. This
seems better than trying to hard-code a particular version in
debian/rules, and Debian package building tools like e.g. sbuild will
then do the right thing.

This enables Reef (v18.2.0) to build on Debian bookworm in a clean
chroot.

Fixes: https://tracker.ceph.com/issues/61845
Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
21 months agoMerge pull request #52524 from dparmar18/wip-62072
Rishabh Dave [Fri, 22 Sep 2023 14:45:04 +0000 (20:15 +0530)]
Merge pull request #52524 from dparmar18/wip-62072

tools/cephfs_mirror: only perform actions if init succeed

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge PR #53407 into main
Venky Shankar [Fri, 22 Sep 2023 14:41:49 +0000 (20:11 +0530)]
Merge PR #53407 into main

* refs/pull/53407/head:
Client: Fix nonblocking-io zero by read

Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge PR #53279 into main
Venky Shankar [Fri, 22 Sep 2023 14:41:12 +0000 (20:11 +0530)]
Merge PR #53279 into main

* refs/pull/53279/head:
qa: descrease pgbench scale factor to 32 for postgresql database test

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
21 months agoMerge PR #52747 into main
Venky Shankar [Fri, 22 Sep 2023 14:40:42 +0000 (20:10 +0530)]
Merge PR #52747 into main

* refs/pull/52747/head:
cephfs-mirror: restart failed/blocklisted replayer instances
cephfs-mirror: do not run concurrent C_RestartMirroring context

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
21 months agoMerge PR #53418 into main
Venky Shankar [Fri, 22 Sep 2023 14:39:44 +0000 (20:09 +0530)]
Merge PR #53418 into main

* refs/pull/53418/head:
qa: use exisitng ignorelist override list for fs:mirror[-ha]

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
21 months agoMerge pull request #48027 from lxbsz/wip-57154
Rishabh Dave [Fri, 22 Sep 2023 14:38:10 +0000 (20:08 +0530)]
Merge pull request #48027 from lxbsz/wip-57154

mds/client: check the cephx mds auth access in client side

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
21 months agoMerge pull request #52576 from cfsnyder/wip-62075
Casey Bodley [Fri, 22 Sep 2023 14:33:25 +0000 (15:33 +0100)]
Merge pull request #52576 from cfsnyder/wip-62075

rgw: add radosgw-admin bucket check olh/unlinked commands

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #52042 from rishabh-d-dave/better-errmsg-for-perm
Rishabh Dave [Fri, 22 Sep 2023 14:32:40 +0000 (20:02 +0530)]
Merge pull request #52042 from rishabh-d-dave/better-errmsg-for-perm

MDSAuthCaps: print better error message for perm flag in MDS caps

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
21 months agoMerge pull request #47533 from rishabh-d-dave/ceph-fuse-cmd
Rishabh Dave [Fri, 22 Sep 2023 14:31:13 +0000 (20:01 +0530)]
Merge pull request #47533 from rishabh-d-dave/ceph-fuse-cmd

qa/cephfs: cleanup code for ceph-fuse command

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
21 months agoMerge pull request #52259 from cbodley/wip-61859
Casey Bodley [Fri, 22 Sep 2023 14:08:36 +0000 (15:08 +0100)]
Merge pull request #52259 from cbodley/wip-61859

qa/rgw: disable 'rgw lc debug interval' in most suites

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
21 months agoMerge pull request #53531 from ronen-fr/wip-rf-squeue2 53263/head
Ronen Friedman [Fri, 22 Sep 2023 13:46:38 +0000 (16:46 +0300)]
Merge pull request #53531 from ronen-fr/wip-rf-squeue2

osd/scrub: extract scrub initiation code out of the OSD

Reviewed-by: Samuel Just <sjust@redhat.com>
21 months agoMerge pull request #53311 from idryomov/wip-62711
Ilya Dryomov [Fri, 22 Sep 2023 13:44:35 +0000 (15:44 +0200)]
Merge pull request #53311 from idryomov/wip-62711

qa/suites/{rbd,krbd}: disable POOL_APP_NOT_ENABLED health check

Reviewed-by: Ramana Raja <rraja@redhat.com>
21 months agomgr/dashboard: fix cephfs forms validations 53596/head
Nizamudeen A [Fri, 22 Sep 2023 12:37:39 +0000 (18:07 +0530)]
mgr/dashboard: fix cephfs forms validations

1. CephFS Edit Form didnt had any validation for name eventhough the
   create had. So reused the Create form to display the Edit as well

2. Add Name Validations to Subvoume and Subvolume group forms

3. Removed the datePipe from the cephfs list template since we are using
   the relativeDate.

Fixes: https://tracker.ceph.com/issues/62939
Signed-off-by: Nizamudeen A <nia@redhat.com>
21 months agorgw: radosgw-admin bucket check should only print index entries with --check-objects... 52576/head
Cory Snyder [Fri, 22 Sep 2023 08:35:16 +0000 (08:35 +0000)]
rgw: radosgw-admin bucket check should only print index entries with --check-objects flag

Printing all index entries can be very time consuming for large
buckets and the inability to switch this behavior off makes it
cumbersome to use the command for fixing bucket stats. This was
also preventing the command from outputting recalculated bucket
stats when the --fix flag wasn't specified.

Signed-off-by: Cory Snyder <csnyder@1111systems.com>
21 months agomgr/dashboard: update nodejs to 18.17.0
Nizamudeen A [Mon, 28 Aug 2023 14:45:06 +0000 (20:15 +0530)]
mgr/dashboard: update nodejs to 18.17.0

the latest npm doesn't support setting python as a config like `npm
config set python3` instead it needs to be either set in the node-gyp
explicitly using the node-gyp command or through an environment
variable.
Since we are calling the node-gyp through npm, we need to set the
environment variable which is documented here: https://github.com/nodejs/node-gyp?tab=readme-ov-file#configuring-python-dependency

Accordingly the CMakeLists.txt for dashboard is adapted

Fixes: https://tracker.ceph.com/issues/62844
Signed-off-by: Nizamudeen A <nia@redhat.com>
21 months agomgr/dashboard: update to angular v15
Nizamudeen A [Sat, 5 Aug 2023 12:09:53 +0000 (17:39 +0530)]
mgr/dashboard: update to angular v15

- The scss import was broken because of the ~ symbol. Looks like its not
needed.

- Login username/password label was somehow broken because of the
placeholder class and color. instead of applying the color through a
class I applied the color directly to the attribute and it worked

- Typescript 4.9 uses ES2022 and it complaints about using some items
  before its initialization. There were other typescript fixes need to
be delivered because of this change.

- Reverting back the badge to rectangular shape (because I feel like the
  round leaves out some empty spaces)

Fixes: https://tracker.ceph.com/issues/62844
Signed-off-by: Nizamudeen A <nia@redhat.com>
21 months agoMerge pull request #53528 from rishabh-d-dave/cephfs-qa-mdtest
Rishabh Dave [Fri, 22 Sep 2023 06:26:03 +0000 (11:56 +0530)]
Merge pull request #53528 from rishabh-d-dave/cephfs-qa-mdtest

qa/cephfs: fix build failure for mdtest project

Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoqa/rgw: enable s3tests for 'storage classes' 52259/head
Casey Bodley [Thu, 21 Sep 2023 14:59:42 +0000 (10:59 -0400)]
qa/rgw: enable s3tests for 'storage classes'

other than the rgw/lifecycle subsuite, all of the other subsuites were just
adding storage classes to the rgw task, but not the s3tests task that
enables the storage class test cases

Signed-off-by: Casey Bodley <cbodley@redhat.com>
21 months agoqa/rgw: disable 'rgw lc debug interval' in most suites
Casey Bodley [Thu, 29 Jun 2023 14:54:03 +0000 (10:54 -0400)]
qa/rgw: disable 'rgw lc debug interval' in most suites

this has a performance cost, and the teuthology environment can
already be sluggish. if lifecycle expiration/transition testing
was limited to the rgw/lifecycle and rgw/cloud-transition suites,
the others would probably run significantly faster

Fixes: https://tracker.ceph.com/issues/61859
Signed-off-by: Casey Bodley <cbodley@redhat.com>
21 months agoqa/s3tests: use cloudtier_tests and lifecycle_tests to control filters
Casey Bodley [Thu, 29 Jun 2023 14:40:16 +0000 (10:40 -0400)]
qa/s3tests: use cloudtier_tests and lifecycle_tests to control filters

when `extra_attrs` was made additive, these tests were adding both
'not lifecycle_expiration' and 'lifecycle_expiration' to the command
line. use a yaml flag instead to control whether or not the s3tests task
adds the 'not' filter

Signed-off-by: Casey Bodley <cbodley@redhat.com>
21 months agoqa/rgw: remove duplicate overrides in rgw/lifecycle
Casey Bodley [Thu, 29 Jun 2023 14:44:02 +0000 (10:44 -0400)]
qa/rgw: remove duplicate overrides in rgw/lifecycle

Signed-off-by: Casey Bodley <cbodley@redhat.com>
21 months agoqa/suites/krbd: disable POOL_APP_NOT_ENABLED health check 53311/head
Ilya Dryomov [Fri, 15 Sep 2023 13:33:27 +0000 (15:33 +0200)]
qa/suites/krbd: disable POOL_APP_NOT_ENABLED health check

... same as for rbd suite.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
21 months agoqa/suites/rbd: drop POOL_APP_NOT_ENABLED from ignorelists
Ilya Dryomov [Fri, 15 Sep 2023 13:33:27 +0000 (15:33 +0200)]
qa/suites/rbd: drop POOL_APP_NOT_ENABLED from ignorelists

With "mon warn on pool no app = false" in the config, it's obviously
redundant.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
21 months agoqa/suites/rbd: disable POOL_APP_NOT_ENABLED health check
Ilya Dryomov [Fri, 15 Sep 2023 13:33:27 +0000 (15:33 +0200)]
qa/suites/rbd: disable POOL_APP_NOT_ENABLED health check

Commit 990806e635a1 ("mon, qa: issue pool application warning even
if pool is empty") made it impossible to create a pool without raising
a (bogus) health alert.  See [1] for details.

[1] https://lists.ceph.io/hyperkitty/list/dev@ceph.io/thread/ZTDYC5HN677RR26EB4P6PORN6L2IFH4R/

Fixes: https://tracker.ceph.com/issues/62711
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
21 months agoMerge pull request #53448 from cbodley/wip-62378
Casey Bodley [Thu, 21 Sep 2023 21:15:37 +0000 (22:15 +0100)]
Merge pull request #53448 from cbodley/wip-62378

rgw/crypt: don't deref null manifest_bl

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
21 months agoMerge pull request #53045 from smanjara/wip-shilpa-revert-51772
Casey Bodley [Thu, 21 Sep 2023 19:59:59 +0000 (20:59 +0100)]
Merge pull request #53045 from smanjara/wip-shilpa-revert-51772

rgw/multisite: fixes assertion failure during realm reload

Reviewed-by: Casey Bodley <cbodley@redhat.com>