]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
20 months agodoc/install: simplify cephadm docs 54230/head
Zac Dover [Sun, 29 Oct 2023 11:47:04 +0000 (21:47 +1000)]
doc/install: simplify cephadm docs

Simplify the explanation of cephadm.

Signed-off-by: Zac Dover <zac.dover@proton.me>
20 months agoMerge pull request #54082 from pdvian/wip-qa-suites-fix
Yuri Weinstein [Fri, 27 Oct 2023 18:42:52 +0000 (11:42 -0700)]
Merge pull request #54082 from pdvian/wip-qa-suites-fix

qa/smoke,orch,perf-basic: add POOL_APP_NOT_ENABLED to ignorelist

Reviewed-by: Laura Flores <lflores@redhat.com>
20 months agoMerge pull request #53003 from alimaredia/wip-rgw-perf-counters-cache
Casey Bodley [Fri, 27 Oct 2023 13:40:19 +0000 (14:40 +0100)]
Merge pull request #53003 from alimaredia/wip-rgw-perf-counters-cache

Perf counters cache + Labeled RGW Op counters

Reviewed-by: Casey Bodley <cbodley@redhat.com>
20 months agoMerge pull request #54218 from zdover23/wip-doc-2023-10-27-rados-troubleshooting...
Anthony D'Atri [Fri, 27 Oct 2023 08:43:12 +0000 (04:43 -0400)]
Merge pull request #54218 from zdover23/wip-doc-2023-10-27-rados-troubleshooting-troubleshooting-pg

doc/rados: edit troubleshooting-pg.rst

20 months agoMerge pull request #54219 from zdover23/wip-doc-2023-10-27-rados-ops-pools-cache...
Anthony D'Atri [Fri, 27 Oct 2023 08:16:07 +0000 (04:16 -0400)]
Merge pull request #54219 from zdover23/wip-doc-2023-10-27-rados-ops-pools-cache-tiering-removal

doc/rados: remove cache-tiering-related keys

20 months agoMerge pull request #53976 from phlogistonjohn/jjm-cephadm-gdb-extd-doc
zdover23 [Fri, 27 Oct 2023 07:16:16 +0000 (17:16 +1000)]
Merge pull request #53976 from phlogistonjohn/jjm-cephadm-gdb-extd-doc

cephadm: document extended gdb debugging techniques

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
20 months agodoc/rados: remove cache-tiering-related keys 54219/head
Zac Dover [Fri, 27 Oct 2023 06:58:28 +0000 (16:58 +1000)]
doc/rados: remove cache-tiering-related keys

Remove information related to cache-tiering-related keys from
doc/rados/operations/pools.rst. Cache-tiering is deprecated in Reef.
This PR is suitable for backporting to the Reef release branch, but not
to release branches prior to Reef.

Signed-off-by: Zac Dover <zac.dover@proton.me>
20 months agodoc/rados: edit troubleshooting-pg.rst 54218/head
Zac Dover [Fri, 27 Oct 2023 05:22:34 +0000 (15:22 +1000)]
doc/rados: edit troubleshooting-pg.rst

s/placement group/pool/ in a sentence that, prior to this change, was
confusing. Suitable for backports prior to Reef.

Signed-off-by: Zac Dover <zac.dover@proton.me>
20 months agoMerge pull request #54200 from zdover23/wip-doc-2023-10-26-hitset-remove-for-reef...
zdover23 [Fri, 27 Oct 2023 03:04:38 +0000 (13:04 +1000)]
Merge pull request #54200 from zdover23/wip-doc-2023-10-26-hitset-remove-for-reef-and-later

doc/rados: remove HitSet-related key information

Reviewed-by: Samuel Just <sjust@redhat.com>
20 months agodoc/rados: remove HitSet-related key information 54200/head
Zac Dover [Wed, 25 Oct 2023 23:48:57 +0000 (09:48 +1000)]
doc/rados: remove HitSet-related key information

Remove HitSet-related key information from
doc/rados/operations/pools.rst. HitSet-related keys are relevant only to
releases of Ceph that support cache tiering. Only Quincy and earlier
(inclusive) releases of Ceph support cache tiering. Backport this commit
from main to Reef, but not to Quincy or to release branches earlier than
Quincy.

Signed-off-by: Zac Dover <zac.dover@proton.me>
20 months agoMerge pull request #53909 from aclamk/aclamk-fix-63121
Adam Kupczyk [Thu, 26 Oct 2023 14:20:37 +0000 (16:20 +0200)]
Merge pull request #53909 from aclamk/aclamk-fix-63121

os/kv_test: Fix estimate functions

20 months agoMerge pull request #54155 from jrchyang/fix-divide-zero
Igor Fedotov [Wed, 25 Oct 2023 10:35:38 +0000 (13:35 +0300)]
Merge pull request #54155 from jrchyang/fix-divide-zero

os/bluestore: fix crash caused by dividing by 0

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
20 months agoMerge pull request #53807 from rhcs-dashboard/fix-63088-main
Aashish Sharma [Wed, 25 Oct 2023 07:31:03 +0000 (13:01 +0530)]
Merge pull request #53807 from rhcs-dashboard/fix-63088-main

mgr/dashboard: Consider null values as zero in grafana panels

Reviewed-by: Nizamudeen A <nia@redhat.com>
20 months agodoc/cephadm: extend container debugging to cover live processes 53976/head
John Mulligan [Mon, 11 Sep 2023 21:55:36 +0000 (17:55 -0400)]
doc/cephadm: extend container debugging to cover live processes

Signed-off-by: John Mulligan <jmulligan@redhat.com>
20 months agodoc/cephadm: clean up debugging section
John Mulligan [Mon, 11 Sep 2023 18:58:43 +0000 (14:58 -0400)]
doc/cephadm: clean up debugging section

Signed-off-by: John Mulligan <jmulligan@redhat.com>
20 months agocephadm: add a --dry-run option to cephadm shell
John Mulligan [Wed, 11 Oct 2023 18:05:17 +0000 (14:05 -0400)]
cephadm: add a --dry-run option to cephadm shell

Instead of creating the shell, the --dry-run option prints the container
command that would be used. This can be used as a starting point for
creating custom container commands similar to what cephadm shell would
generate but with tweaks.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
20 months agoMerge pull request #54148 from ivoalmeida/fix-edit-user-bucket-quota
Pedro Gonzalez Gomez [Tue, 24 Oct 2023 09:43:15 +0000 (11:43 +0200)]
Merge pull request #54148 from ivoalmeida/fix-edit-user-bucket-quota

mgr/dashboard: fixed edit user quota form error

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
20 months agoos/bluestore: fix crash caused by dividing by 0 54155/head
jrchyang [Tue, 24 Oct 2023 02:03:09 +0000 (10:03 +0800)]
os/bluestore: fix crash caused by dividing by 0

In Allocator::create() => ZonedAllocator::ZonedAllocator()
num_zones is calculated by size / zone_size,
causing a crash when zone_size is set to 0

Signed-off-by: Jrchyang Yu <yuzhiqiang_yewu@cmss.chinamobile.com>
20 months agomgr/dashboard: fixed edit user quota form error 54148/head
Ivo Almeida [Mon, 23 Oct 2023 11:02:47 +0000 (12:02 +0100)]
mgr/dashboard: fixed edit user quota form error

Fixes: https://tracker.ceph.com/issues/63287
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
20 months agoMerge PR #54030 into main
Venky Shankar [Mon, 23 Oct 2023 02:07:10 +0000 (07:37 +0530)]
Merge PR #54030 into main

* refs/pull/54030/head:
client: always refresh mds feature bits on session open

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
20 months agoMerge pull request #54025 from yuvalif/wip-yuval-fix-63205
Yuval Lifshitz [Sun, 22 Oct 2023 15:26:30 +0000 (18:26 +0300)]
Merge pull request #54025 from yuvalif/wip-yuval-fix-63205

rgw/notifications/test: fix rabbitmq and kafka issues in centos9

reviewed-by: cbodley

20 months agorgw/notifications/test: install java for kafka build 54025/head
Yuval Lifshitz [Sun, 15 Oct 2023 15:54:07 +0000 (15:54 +0000)]
rgw/notifications/test: install java for kafka build

also use kafka binaries insted of building from source

Fixes: https://tracker.ceph.com/issues/63205
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
20 months agoMerge pull request #54136 from yuvalif/wip-yuval-remove-pubsub-doc
Yuval Lifshitz [Sun, 22 Oct 2023 08:12:02 +0000 (11:12 +0300)]
Merge pull request #54136 from yuvalif/wip-yuval-remove-pubsub-doc

rgw/doc: pubsub capabilities reference was removed from docs

reviewed-by: @zdover23

20 months agodoc/rgw: pubsub capabilities reference was removed from docs 54136/head
Yuval Lifshitz [Sun, 22 Oct 2023 07:09:22 +0000 (07:09 +0000)]
doc/rgw: pubsub capabilities reference was removed from docs

most pubsub docs were removed in
0fecbe2476afbb06de7ea731b7c92066ae40cfc4
however, the text removed described functionality that is only
supported bia pubsub

Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
21 months agoMerge pull request #54107 from anthonyeleven/anthonyeleven/clarify-checklist
zdover23 [Fri, 20 Oct 2023 23:00:35 +0000 (09:00 +1000)]
Merge pull request #54107 from anthonyeleven/anthonyeleven/clarify-checklist

.github: Clarify checklist details

Reviewed-by: Zac Dover <zac.dover@proton.me>
21 months agoMerge pull request #49954 from caffeinism/fix-bug-in-ceph-volume-device
Zack Cerza [Fri, 20 Oct 2023 20:20:56 +0000 (14:20 -0600)]
Merge pull request #49954 from caffeinism/fix-bug-in-ceph-volume-device

ceph-volume: fix a bug in _check_generic_reject_reasons

21 months agorgw: remove move's, rename put/get counters, revert exporter changes 53003/head
Ali Maredia [Thu, 19 Oct 2023 20:44:52 +0000 (20:44 +0000)]
rgw: remove move's, rename put/get counters, revert exporter changes

Signed-off-by: Ali Maredia <amaredia@redhat.com>
21 months agoclient: always refresh mds feature bits on session open 54030/head
Venky Shankar [Mon, 16 Oct 2023 04:11:19 +0000 (00:11 -0400)]
client: always refresh mds feature bits on session open

Fixes: http://tracker.ceph.com/issues/63188
Signed-off-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge pull request #54109 from ceph/wip-yuri-crontab-main
Yuri Weinstein [Fri, 20 Oct 2023 14:29:47 +0000 (07:29 -0700)]
Merge pull request #54109 from ceph/wip-yuri-crontab-main

qa/tests: enabled smoke tests on main, quincy and reef

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
21 months agoMerge pull request #53923 from adk3798/test-mgr-cephadm-image-base
Adam King [Fri, 20 Oct 2023 14:25:24 +0000 (10:25 -0400)]
Merge pull request #53923 from adk3798/test-mgr-cephadm-image-base

mgr/cephadm: add unit test to for upgrade check with --ceph-version

Reviewed-by: John Mulligan <jmulligan@redhat.com>
21 months agoMerge PR #54042 into main
Patrick Donnelly [Fri, 20 Oct 2023 13:06:41 +0000 (09:06 -0400)]
Merge PR #54042 into main

* refs/pull/54042/head:
cmake: populate liburing include and library paths down to rocksdb external project
cmake: promote uring package search to top-level

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge PR #53822 into main
Venky Shankar [Fri, 20 Oct 2023 10:34:34 +0000 (16:04 +0530)]
Merge PR #53822 into main

* refs/pull/53822/head:
CLIENT: C_Read_Async_Finisher should assume client_lock is held

Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge PR #53710 into main
Venky Shankar [Fri, 20 Oct 2023 09:56:55 +0000 (15:26 +0530)]
Merge PR #53710 into main

* refs/pull/53710/head:
doc/cephfs-shell: drop installing packaging module
cephfs-shell: use pkg_resources rather than packaging module

Reviewed-by: Jos Collin <jcollin@redhat.com>
21 months agoMerge PR #53571 into main
Venky Shankar [Fri, 20 Oct 2023 09:54:07 +0000 (15:24 +0530)]
Merge PR #53571 into main

* refs/pull/53571/head:
client: queue a delay cap flushing if there are ditry caps/snapcaps

Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge PR #53839 into main
Venky Shankar [Fri, 20 Oct 2023 09:14:27 +0000 (14:44 +0530)]
Merge PR #53839 into main

* refs/pull/53839/head:
qa: enhance test cases
mds: erase clients getting evicted from laggy_clients
mds: report clients laggy due laggy OSDs only after checking any OSD is laggy

Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge pull request #53994 from rhcs-dashboard/add-port-endpoints-import-multisite
Aashish Sharma [Fri, 20 Oct 2023 09:06:44 +0000 (14:36 +0530)]
Merge pull request #53994 from rhcs-dashboard/add-port-endpoints-import-multisite

mgr/dashboard: add port and zone endpoints to import realm token form in rgw multisite

Reviewed-by: Nizamudeen A <nia@redhat.com>
21 months agoMerge PR #53651 into main
Venky Shankar [Fri, 20 Oct 2023 05:13:19 +0000 (10:43 +0530)]
Merge PR #53651 into main

* refs/pull/53651/head:
qa: add test_subvolume_group_rm_when_its_not_empty
mgr/volumes: fix `subvolume group rm` error message

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge PR #53280 into main
Venky Shankar [Fri, 20 Oct 2023 05:11:08 +0000 (10:41 +0530)]
Merge PR #53280 into main

* refs/pull/53280/head:
mds: fix issuing redundant reintegrate/migrate_stray requests
mds: record the internal client request and receive client reply

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
21 months agoMerge pull request #54084 from zdover23/wip-doc-2023-10-19-rados-troubleshooting...
zdover23 [Fri, 20 Oct 2023 04:05:16 +0000 (14:05 +1000)]
Merge pull request #54084 from zdover23/wip-doc-2023-10-19-rados-troubleshooting-troubleshooting-pg-2-of-x

doc/rados: edit troubleshooting-pg (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agoMerge pull request #54099 from jmolmo/monitoring_doc
zdover23 [Thu, 19 Oct 2023 21:56:17 +0000 (07:56 +1000)]
Merge pull request #54099 from jmolmo/monitoring_doc

doc: Documentation about main Ceph metrics

Reviewed-by: Zac Dover <zac.dover@gmail.com>
21 months agodoc: Documentation about main Ceph metrics 54099/head
Juan Miguel Olmo Martínez [Wed, 11 Oct 2023 16:00:15 +0000 (18:00 +0200)]
doc: Documentation about main Ceph metrics

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Zac Dover <zac.dover@proton.me>
Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@ibm.com>
21 months agodoc/rados: edit troubleshooting-pg (2 of x) 54084/head
Zac Dover [Wed, 18 Oct 2023 22:25:38 +0000 (08:25 +1000)]
doc/rados: edit troubleshooting-pg (2 of x)

Edit doc/rados/troubleshooting/troubleshooting-pg.rst (1 of x).

Follows https://github.com/ceph/ceph/pull/54052.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agoqa/tests: enabled smoke tests on main, quincy and reef 54109/head
Yuri Weinstein [Thu, 19 Oct 2023 17:26:55 +0000 (10:26 -0700)]
qa/tests: enabled smoke tests on main, quincy and reef

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
21 months agoMerge pull request #53929 from ivancich/wip-indexless-test
J. Eric Ivancich [Thu, 19 Oct 2023 17:16:54 +0000 (13:16 -0400)]
Merge pull request #53929 from ivancich/wip-indexless-test

rgw: only buckets with reshardable layouts need to be considered for resharing

Reviewed-by: Casey Bodley <cbodley@redhat.com>
21 months agoMerge pull request #53813 from cfsnyder/wip-63092
J. Eric Ivancich [Thu, 19 Oct 2023 17:15:55 +0000 (13:15 -0400)]
Merge pull request #53813 from cfsnyder/wip-63092

rgw: add versioning info to radosgw-admin bucket stats output

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
21 months agoMerge pull request #53801 from BBoozmen/oozmen_sts_keygen
J. Eric Ivancich [Thu, 19 Oct 2023 17:14:46 +0000 (13:14 -0400)]
Merge pull request #53801 from BBoozmen/oozmen_sts_keygen

RGW/STS: when generating keys, take the trailing null character into account

Reviewed-by: Pritha Srivastava <prsrivas@redhat.com>
21 months agoMerge pull request #53750 from Inode1/rgw-user-policy-check-subuser
J. Eric Ivancich [Thu, 19 Oct 2023 17:13:27 +0000 (13:13 -0400)]
Merge pull request #53750 from Inode1/rgw-user-policy-check-subuser

rgw: fix user.rgw.user-policy attr remove by modify user

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
21 months ago.github: Clarify checklist details 54107/head
Anthony D'Atri [Thu, 19 Oct 2023 15:28:07 +0000 (11:28 -0400)]
.github: Clarify checklist details

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
21 months agorgw/notifications/test: use dnf and systemctl to setup rabbitmq
Yuval Lifshitz [Sun, 15 Oct 2023 11:31:54 +0000 (11:31 +0000)]
rgw/notifications/test: use dnf and systemctl to setup rabbitmq

Fixes: https://tracker.ceph.com/issues/63205
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
21 months agoqa: enhance test cases 53839/head
Dhairya Parmar [Thu, 12 Oct 2023 12:29:04 +0000 (17:59 +0530)]
qa: enhance test cases

Fixes: https://tracker.ceph.com/issues/63105
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
21 months agoMerge pull request #53653 from rhcs-dashboard/fix-alert-generation
Nizamudeen A [Thu, 19 Oct 2023 04:27:06 +0000 (09:57 +0530)]
Merge pull request #53653 from rhcs-dashboard/fix-alert-generation

mgr/dashboard: fix broken alert generator

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
21 months agoMerge pull request #53327 from zmc/cv-disk-unbound-var
Zack Cerza [Wed, 18 Oct 2023 21:02:20 +0000 (15:02 -0600)]
Merge pull request #53327 from zmc/cv-disk-unbound-var

ceph-volume: Fix unbound var in disk.get_devices()

21 months agoqa/smoke,orch,perf-basic: add POOL_APP_NOT_ENABLED to ignorelist 54082/head
Prashant D [Wed, 18 Oct 2023 20:07:47 +0000 (16:07 -0400)]
qa/smoke,orch,perf-basic: add POOL_APP_NOT_ENABLED to ignorelist

Some of the smoke, orch and perf-basic tests are failing due
to POOL_APP_NOT_ENABLED health check failure. Add
POOL_APP_NOT_ENABLED to ignorelist for these tests.

Signed-off-by: Prashant D <pdhange@redhat.com>
21 months agoMerge pull request #54051 from NUABO/tanchangzhi
zdover23 [Wed, 18 Oct 2023 19:41:28 +0000 (05:41 +1000)]
Merge pull request #54051 from NUABO/tanchangzhi

doc: Update mClock QOS documentation to discard osd_mclock_cost_per_*

Reviewed-by: Zac Dover <zac.dover@proton.me>
21 months agoMerge pull request #52897 from cloudbehl/navigation-improvements
Nizamudeen A [Wed, 18 Oct 2023 16:43:07 +0000 (22:13 +0530)]
Merge pull request #52897 from cloudbehl/navigation-improvements

mgr/dashboard: Left navigation improvements

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
21 months agorgw: check if bucket index layout can be resharded before progressing 53929/head
J. Eric Ivancich [Tue, 10 Oct 2023 15:24:08 +0000 (11:24 -0400)]
rgw: check if bucket index layout can be resharded before progressing

Adds a test for a reshardable index layout when a bucket is considered
for immediate, scheduled, or dynamic resharding.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
21 months agoMerge pull request #53910 from rkachach/fix_issue_63123
Adam King [Wed, 18 Oct 2023 12:47:32 +0000 (08:47 -0400)]
Merge pull request #53910 from rkachach/fix_issue_63123

mgr/rook: fixing rook-ceph-exporter daemon type handling

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@ibm.com>
Reviewed-by: travisn <tnielsen@redhat.com>
21 months agomgr/dashboard: add port and zone endpoints to import realm token form in 53994/head
Aashish Sharma [Fri, 13 Oct 2023 08:23:23 +0000 (13:53 +0530)]
mgr/dashboard: add port and zone endpoints to import realm token form in
rgw multisite

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
21 months agoMerge pull request #54052 from zdover23/wip-doc-2023-10-17-rados-troubleshooting...
zdover23 [Wed, 18 Oct 2023 09:58:30 +0000 (19:58 +1000)]
Merge pull request #54052 from zdover23/wip-doc-2023-10-17-rados-troubleshooting-troubleshooting-pg-1-of-x

doc/rados: edit troubleshooting-pg.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agoMerge pull request #54028 from anthonyeleven/anthonyeleven/hw-recs
zdover23 [Wed, 18 Oct 2023 09:27:14 +0000 (19:27 +1000)]
Merge pull request #54028 from anthonyeleven/anthonyeleven/hw-recs

doc/start: Modernize and clarify hardware-recommendations.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
21 months agodoc/rados: edit troubleshooting-pg.rst (1 of x) 54052/head
Zac Dover [Tue, 17 Oct 2023 09:13:01 +0000 (19:13 +1000)]
doc/rados: edit troubleshooting-pg.rst (1 of x)

Edit doc/rados/troubleshooting/troubleshooting-pg.rst (1 of x).

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agoMerge pull request #53991 from rhcs-dashboard/fix-cephfs-edit-form-placement
Nizamudeen A [Wed, 18 Oct 2023 06:49:57 +0000 (12:19 +0530)]
Merge pull request #53991 from rhcs-dashboard/fix-cephfs-edit-form-placement

mgr/dashboard: disable hosts field while editing the filesystem

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
21 months agocmake: populate liburing include and library paths down to rocksdb external project 54042/head
Patrick Donnelly [Mon, 16 Oct 2023 14:07:04 +0000 (10:07 -0400)]
cmake: populate liburing include and library paths down to rocksdb external project

There are two problems:

1) The librocksdb does not use the built liburing if present.
2) You cannot turn off rocksdb's use of liburing with WITH_LIBURING=OFF.

This is to fix errors like:

FAILED: bin/ceph_test_keyvaluedb_iterators
: && /opt/rh/gcc-toolset-11/root/usr/bin/g++ -Og -g -rdynamic -pie src/test/ObjectMap/CMakeFiles/ceph_test_keyvaluedb_iterators.dir/test_keyvaluedb_iterators.cc.o src/test/ObjectMap/CMakeFiles/ceph_test_keyvaluedb_iterators.dir/KeyValueDBMemory.cc.o -o bin/ceph_test_keyvaluedb_iterators  -Wl,-rpath,/home/pdonnell/scratch/build/lib  lib/libos.a  lib/libgmock_maind.a  lib/libgmockd. a  lib/libgtestd.a  -lpthread  -ldl  lib/libglobal.a  -ldl  /usr/lib64/librt.so  -lresolv  -ldl  lib/libblk.a  /lib64/libaio.so  src/liburing/src/liburing.a  lib/libkv.a  lib/libheap_profiler.a  /lib64/libtcmalloc.so  src/rocksdb/librocksdb.a  /lib64/libsnappy.so  /usr/lib64/liblz4.so  /usr/lib64/libz.so  /usr/lib64/libfuse.so  lib/libceph-common.so.2  src/opentelemetry-cpp/sdk/src/trace/libopentelemetry_trace.a  src/opentelemetry-cpp/sdk/src/resource/libopentelemetry_resources.a  src/opentelemetry-cpp/sdk/src/common/libopentelemetry_common.a  src/opentelemetry-cpp/exporters/jaeger/libopentelemetry_exporter_jaeger_trace.a  src/opentelemetry-cpp/ext/src/http/client/curl/libopentelemetry_http_client_curl.a  /usr/lib64/libcurl.so  /usr/lib64/libthrift.so  lib/libjson_spirit.a  lib/libcommon_utf8.a  lib/liberasure_code.a  lib/libextblkdev.a  -lcap  boost/lib/libboost_thread.a  boost/lib/libboost_chrono.a  boost/lib/libboost_atomic.a  boost/lib/libboost_system.a  boost/lib/libboost_random.a  boost/lib/libboost_program_options.a  boost/lib/libboost_date_time.a  boost/lib/libboost_iostreams.a  boost/lib/libboost_regex.a  lib/libfmtd.a  /usr/lib64/libblkid.so  -lpthread  /usr/lib64/libcrypto.so  /usr/lib64/libudev.so  /usr/lib64/libz.so  -ldl  -lresolv   -Wl,--as-needed -latomic && :
/opt/rh/gcc-toolset-11/root/usr/bin/ld: src/rocksdb/librocksdb.a(fs_posix.cc.o): in function `io_uring_wait_cqe_nr':
/home/pdonnell/scratch/build/src/liburing/src/include/liburing.h:494: undefined reference to `__io_uring_get_cqe'
/opt/rh/gcc-toolset-11/root/usr/bin/ld: src/rocksdb/librocksdb.a(fs_posix.cc.o): in function `rocksdb::(anonymous namespace)::PosixFileSystem::AbortIO(std::vector<void*, std::allocator<void*> >&)':
/home/pdonnell/ceph/src/rocksdb/env/fs_posix.cc:1125: undefined reference to `io_uring_get_sqe'
/opt/rh/gcc-toolset-11/root/usr/bin/ld: /home/pdonnell/ceph/src/rocksdb/env/fs_posix.cc:1134: undefined reference to `io_uring_submit'
/opt/rh/gcc-toolset-11/root/usr/bin/ld: src/rocksdb/librocksdb.a(fs_posix.cc.o): in function `rocksdb::CreateIOUring()':
/home/pdonnell/ceph/src/rocksdb/env/io_posix.h:272: undefined reference to `io_uring_queue_init'
/opt/rh/gcc-toolset-11/root/usr/bin/ld: src/rocksdb/librocksdb.a(io_posix.cc.o): in function `io_uring_wait_cqe_nr':
/home/pdonnell/scratch/build/src/liburing/src/include/liburing.h:494: undefined reference to `__io_uring_get_cqe'
/opt/rh/gcc-toolset-11/root/usr/bin/ld: src/rocksdb/librocksdb.a(io_posix.cc.o): in function `rocksdb::PosixRandomAccessFile::MultiRead(rocksdb::FSReadRequest*, unsigned long, rocksdb::IOOptions const&, rocksdb::IODebugContext*)':
/home/pdonnell/ceph/src/rocksdb/env/io_posix.cc:674: undefined reference to `io_uring_get_sqe'
/opt/rh/gcc-toolset-11/root/usr/bin/ld: /home/pdonnell/ceph/src/rocksdb/env/io_posix.cc:684: undefined reference to `io_uring_submit_and_wait'
/opt/rh/gcc-toolset-11/root/usr/bin/ld: src/rocksdb/librocksdb.a(io_posix.cc.o): in function `rocksdb::PosixRandomAccessFile::ReadAsync(rocksdb::FSReadRequest&, rocksdb::IOOptions const&, std::function<void (rocksdb::FSReadRequest const&, void*)>, void*, void**, std::function<void (void*)>*, rocksdb::IODebugContext*)':
/home/pdonnell/ceph/src/rocksdb/env/io_posix.cc:901: undefined reference to `io_uring_get_sqe'
/opt/rh/gcc-toolset-11/root/usr/bin/ld: /home/pdonnell/ceph/src/rocksdb/env/io_posix.cc:910: undefined reference to `io_uring_submit'
collect2: error: ld returned 1 exit status

Fixes: https://tracker.ceph.com/issues/63218
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
21 months agocmake: promote uring package search to top-level
Patrick Donnelly [Tue, 17 Oct 2023 16:59:41 +0000 (12:59 -0400)]
cmake: promote uring package search to top-level

For use by multiple projects, rocksdb in particular.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
21 months agoMerge pull request #54002 from idryomov/wip-63028
Ilya Dryomov [Tue, 17 Oct 2023 11:20:59 +0000 (13:20 +0200)]
Merge pull request #54002 from idryomov/wip-63028

pybind/rbd: don't produce info on errors in aio_mirror_image_get_info()

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
21 months agoMerge pull request #53800 from batrick/cmake-debug-wrn
Ilya Dryomov [Tue, 17 Oct 2023 11:14:25 +0000 (13:14 +0200)]
Merge pull request #53800 from batrick/cmake-debug-wrn

CMakeLists: warn if CMAKE_BUILD_TYPE is set/unset

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
21 months agomgr/dashboard: Left navigation improvements 52897/head
cloudbehl [Wed, 9 Aug 2023 07:09:47 +0000 (12:39 +0530)]
mgr/dashboard: Left navigation improvements

Fixes: https://tracker.ceph.com/issues/62366
Signed-off-by: cloudbehl <cloudbehl@gmail.com>
21 months agodoc: Update mClock QOS documentation to discard osd_mclock_cost_per_* 54051/head
tanchangzhi [Tue, 17 Oct 2023 08:48:51 +0000 (16:48 +0800)]
doc: Update mClock QOS documentation to discard osd_mclock_cost_per_*

The cost parameters (osd_mclock_cost_per_*) have been removed.
The cost of an operation is now determined using the random IOPS
and maximum sequential bandwidth capability of the OSD's underlying device.

Fixes: https://tracker.ceph.com/issues/58529
Signed-off-by: tanchangzhi <544463199@qq.com>
21 months agodoc/start: Modernize and clarify hardware-recommendations.rst 54028/head
Anthony D'Atri [Mon, 16 Oct 2023 01:27:44 +0000 (21:27 -0400)]
doc/start: Modernize and clarify hardware-recommendations.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
21 months agoMerge pull request #53802 from phlogistonjohn/jjm-cephadm-dtypes-2
Adam King [Mon, 16 Oct 2023 19:33:53 +0000 (15:33 -0400)]
Merge pull request #53802 from phlogistonjohn/jjm-cephadm-dtypes-2

cephadm: convert more types to be based on ContainerDaemonForm

Reviewed-by: Adam King <adking@redhat.com>
21 months agoMerge pull request #53351 from ceph/QE_defect_fixes
Casey Bodley [Mon, 16 Oct 2023 16:02:52 +0000 (17:02 +0100)]
Merge pull request #53351 from ceph/QE_defect_fixes

rgw/s3select: fix per QE defect.

21 months agoCMakeLists: warn if CMAKE_BUILD_TYPE is set/unset 53800/head
Patrick Donnelly [Tue, 3 Oct 2023 16:01:40 +0000 (16:01 +0000)]
CMakeLists: warn if CMAKE_BUILD_TYPE is set/unset

At some point the debug builds for wip branches no longer had the .git
directory available so the Debug build type was unset. This meant we are
no longer doing numerous checks (like mutex ownership checks) that we
would normally be doing in the qa suite.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
21 months agoMerge pull request #54022 from zdover23/wip-doc-2023-10-15-rados-troubleshooting...
zdover23 [Sun, 15 Oct 2023 23:39:20 +0000 (09:39 +1000)]
Merge pull request #54022 from zdover23/wip-doc-2023-10-15-rados-troubleshooting-troubleshooting-osd-3-of-x

doc/rados: Edit troubleshooting-osd (3 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agodoc/rados: Edit troubleshooting-osd (3 of x) 54022/head
Zac Dover [Sun, 15 Oct 2023 12:43:39 +0000 (22:43 +1000)]
doc/rados: Edit troubleshooting-osd (3 of x)

Edit doc/rados/troubleshooting/troubleshooting-osd.rst (3 of x).

Follows https://github.com/ceph/ceph/pull/53986.

Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agoMerge pull request #53547 from yuvalif/wip-yuval-req-context
Yuval Lifshitz [Sun, 15 Oct 2023 06:51:25 +0000 (09:51 +0300)]
Merge pull request #53547 from yuvalif/wip-yuval-req-context

rgw: adding request context structure

reviewed-by: dang, cbodley

21 months agorgw: cleanup from previous commit
Ali Maredia [Sat, 14 Oct 2023 20:50:07 +0000 (16:50 -0400)]
rgw: cleanup from previous commit

Signed-off-by: Ali Maredia <amaredia@redhat.com>
21 months agoMerge pull request #54006 from zdover23/wip-doc-2023-10-14-filestore-deprecation
Anthony D'Atri [Fri, 13 Oct 2023 18:50:21 +0000 (14:50 -0400)]
Merge pull request #54006 from zdover23/wip-doc-2023-10-14-filestore-deprecation

doc/rados: remove FileStore material (in Reef)

21 months agodoc/rados: remove FileStore material (in Reef) 54006/head
Zac Dover [Fri, 13 Oct 2023 18:40:26 +0000 (04:40 +1000)]
doc/rados: remove FileStore material (in Reef)

Remove FileStore-related material because FileStore is not supported in
Reef.

Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agoMerge pull request #54005 from zdover23/wip-doc-2023-10-14-dev-cache-pool-removal
Anthony D'Atri [Fri, 13 Oct 2023 18:25:59 +0000 (14:25 -0400)]
Merge pull request #54005 from zdover23/wip-doc-2023-10-14-dev-cache-pool-removal

doc/dev: remove cache-pool

21 months agodoc/dev: remove cache-pool 54005/head
Zac Dover [Fri, 13 Oct 2023 18:17:44 +0000 (04:17 +1000)]
doc/dev: remove cache-pool

Remove cache-pool, which is deprecated in Reef.

Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agoMerge pull request #53979 from kamoltat/wip-ksirivad-fix-63183
Kamoltat (Junior) Sirivadhna [Fri, 13 Oct 2023 15:44:36 +0000 (11:44 -0400)]
Merge pull request #53979 from kamoltat/wip-ksirivad-fix-63183

src/mon/Monitor: Fix set_elector_disallowed_leaders
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
21 months agomgr/rbd_support: make type hits on aio_mirror_image_*() callbacks better 54002/head
Ilya Dryomov [Thu, 12 Oct 2023 19:32:53 +0000 (21:32 +0200)]
mgr/rbd_support: make type hits on aio_mirror_image_*() callbacks better

Make it clear that mirror mode, mirror info and snap ID can be None if
the respective operation fails.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
21 months agopybind/rbd: don't produce info on errors in aio_mirror_image_get_info()
Ilya Dryomov [Thu, 12 Oct 2023 17:03:10 +0000 (19:03 +0200)]
pybind/rbd: don't produce info on errors in aio_mirror_image_get_info()

Check completion return value before attemting to decode c_info.
Otherwise we are guaranteed to access invalid memory in decode_cstr()
while trying to compute global_id string length when the client is
blocklisted for example.

Fixes: https://tracker.ceph.com/issues/63028
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
21 months agoMerge pull request #53732 from pereman2/bluefs-expand-bug
Adam Kupczyk [Fri, 13 Oct 2023 14:07:57 +0000 (16:07 +0200)]
Merge pull request #53732 from pereman2/bluefs-expand-bug

os/bluestore: fix bluefs _extend_log seq update

21 months agoMerge pull request #53986 from zdover23/wip-doc-2023-10-12-rados-troubleshooting...
zdover23 [Fri, 13 Oct 2023 13:40:38 +0000 (23:40 +1000)]
Merge pull request #53986 from zdover23/wip-doc-2023-10-12-rados-troubleshooting-troubleshooting-osd-2-of-x

doc/rados: Edit troubleshooting-osd (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
21 months agodoc/rados: Edit troubleshooting-osd (2 of x) 53986/head
Zac Dover [Thu, 12 Oct 2023 08:33:58 +0000 (18:33 +1000)]
doc/rados: Edit troubleshooting-osd (2 of x)

Edit doc/rados/troubleshooting/troubleshooting.rst (2 of x).

Follows https://github.com/ceph/ceph/pull/53936.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
21 months agorgw: fix user.rgw.user-policy attr remove by modify user 53750/head
ivan [Mon, 2 Oct 2023 12:25:56 +0000 (15:25 +0300)]
rgw: fix user.rgw.user-policy attr remove by modify user

Signed-off-by: ivan <i.makarychev@tinkoff.ru>
21 months agoMerge pull request #53234 from xxhdx1985126/wip-seastore-onode-manager-replay
Yingxin [Fri, 13 Oct 2023 08:28:34 +0000 (16:28 +0800)]
Merge pull request #53234 from xxhdx1985126/wip-seastore-onode-manager-replay

crimson/os/seastore/onode_manager: populate delta recorders for each onode modification

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
21 months agomgr/dashboard: disable hosts field while editing the filesystem 53991/head
Nizamudeen A [Fri, 13 Oct 2023 07:47:05 +0000 (13:17 +0530)]
mgr/dashboard: disable hosts field while editing the filesystem

Even though the Placement field was disabled, the Host field was still
showing up in UI while Editing. That option is not possible in fs form.

Fixes: https://tracker.ceph.com/issues/63193
Signed-off-by: Nizamudeen A <nia@redhat.com>
21 months agomgr/dashboard: fix broken alert generator 53653/head
Nizamudeen A [Mon, 25 Sep 2023 13:28:06 +0000 (18:58 +0530)]
mgr/dashboard: fix broken alert generator

Currently the alert generator is broken if you try to run `tox
-ealerts-fix`. I fixed it and ran the command and it built a new json
file as well.

Signed-off-by: Nizamudeen A <nia@redhat.com>
21 months agofix per QE defect. 53351/head
galsalomon66 [Sat, 9 Sep 2023 13:38:23 +0000 (16:38 +0300)]
fix per QE defect.
s3select submodule

s3select engine changes

s3select submodule
aggregation functions upon no data

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
21 months agosrc/mon/Monitor: Fix set_elector_disallowed_leaders 53979/head
Kamoltat [Wed, 11 Oct 2023 21:12:03 +0000 (21:12 +0000)]
src/mon/Monitor: Fix set_elector_disallowed_leaders

Problem:

In the monitors we hold 2 copies of disallowed_leader ...
1. MonMap class 2. Elector class.
When computing the ConnectivityScore for the monitors during
the election, we use the `disallowed_leader` from Elector
class to determine which monitors we shouldn't allow to lead.

Now, we rely on the function `set_elector_disallowed_leaders`
to set the `disallowed_leader` of the Elector class, MonMap
class copy of the `disallowed_leader` contains the
`tiebreaker_monitor` so we inherit that plus we also add the
monitors that are dead due to a zone failure.

Hence, the `adding dead monitors` phase is only allowed if we can
enter stretch_mode. However, there is a problem when failing over a stretch cluster
zone and reviving the entire zone back up, the revived monitors
couldn't enter stretch_mode when they are at the state of "probing"
since PaxosServices like osdmon becomes unreadable (this is expected)

Solution:

We unconditionally add monitors that are in
`monmap->stretch_marked_down_mons` to the
`disallowed_leaders` list in
`Monitor::set_elector_disallowed_leaders` since
if the monitors are in `monmap->stretch_marked_down_mons`
we know that they probably belong in a marked down
zone and is not fit for lead.

This will fix the problem of newly revived monitors
having different disallowed_leaders set
and getting stuck in election.

Fixes: https://tracker.ceph.com/issues/63183
Signed-off-by: Kamoltat <ksirivad@redhat.com>
21 months agorgw: misc labeled op counters work
Ali Maredia [Fri, 8 Sep 2023 15:16:02 +0000 (11:16 -0400)]
rgw: misc labeled op counters work

Highlights of this commit include:
- splitting the rgw perf counters cache int two
caches for bucket labeled and user labeled op counters
- add config overrides to verify suite for CI
- add tenant label for op counters
- misc cleanup cleanup
- add docs for rgw metrics

Signed-off-by: Ali Maredia <amaredia@redhat.com>
21 months agoexporter: check key exists before json::object at()
Ali Maredia [Wed, 23 Aug 2023 05:05:37 +0000 (01:05 -0400)]
exporter: check key exists before json::object at()

Signed-off-by: Ali Maredia <amaredia@redhat.com>
21 months agocommon: perf counters cache + rgw op labeled counters
Ali Maredia [Tue, 2 May 2023 20:22:19 +0000 (16:22 -0400)]
common: perf counters cache + rgw op labeled counters

This commit contains the following features:
- a perf counters cache per CephContext that acts
as a wrapper around perf counters for storing and
modifying labeled perf counters per CephContext
- instrumentation of the rgw with labeled perf
injest counters for the major rgw ops

Signed-off-by: Ali Maredia <amaredia@redhat.com>
21 months agoMerge pull request #53914 from idryomov/wip-63149
Ilya Dryomov [Thu, 12 Oct 2023 19:29:05 +0000 (21:29 +0200)]
Merge pull request #53914 from idryomov/wip-63149

qa/suites/rbd: drop cache tiering workload tests

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>
21 months agoMerge pull request #51416 from adk3798/jaeger-agent-dep
Adam King [Thu, 12 Oct 2023 19:24:26 +0000 (15:24 -0400)]
Merge pull request #51416 from adk3798/jaeger-agent-dep

mgr/cephadm: make jaeger-collector a dep for jaeger-agent

Reviewed-by: John Mulligan <jmulligan@redhat.com>
21 months agoMerge pull request #53980 from ceph/wip-yuri-crontab-main
Yuri Weinstein [Thu, 12 Oct 2023 14:56:01 +0000 (07:56 -0700)]
Merge pull request #53980 from ceph/wip-yuri-crontab-main

qa/tests: fixed typo and added `--force-priority` in missing places

Reviewed-by: Laura Flores <lflores@redhat.com>
21 months agoMerge pull request #53062 from xxhdx1985126/wip-seastore-list-objects
Yingxin [Thu, 12 Oct 2023 06:44:11 +0000 (14:44 +0800)]
Merge pull request #53062 from xxhdx1985126/wip-seastore-list-objects

crimson/os/seastore: return ghobject_t::max as the end when list_objects reaches the end of the listing

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
21 months agoMerge pull request #53936 from zdover23/wip-doc-2023-10-11-rados-troubleshooting...
zdover23 [Thu, 12 Oct 2023 05:15:58 +0000 (15:15 +1000)]
Merge pull request #53936 from zdover23/wip-doc-2023-10-11-rados-troubleshooting-troubleshooting-osd-1-of-x

doc/rados: edit troubleshooting-osd (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>