]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
15 months agomds,client: update the oldest_client_tid via the renew caps 54468/head
Xiubo Li [Tue, 31 Oct 2023 02:23:09 +0000 (10:23 +0800)]
mds,client: update the oldest_client_tid via the renew caps

Update the oldest_client_tid via the session renew caps msg to
make sure that the MDSs won't pile up the completed request list
in a very large size.

Fixes: https://tracker.ceph.com/issues/63364
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 0cff6d5d487972a850e7c64b1e3b8ca283bf3c03)

15 months agomds: add trim_completed_request_list() helper
Xiubo Li [Tue, 31 Oct 2023 02:30:18 +0000 (10:30 +0800)]
mds: add trim_completed_request_list() helper

Fixes: https://tracker.ceph.com/issues/63364
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 188aed9d779a168d999be9f652bcceecbfd64f05)

15 months agoclient: return false if cannot link all the way to mountpoint
Xiubo Li [Mon, 9 Oct 2023 04:15:02 +0000 (12:15 +0800)]
client: return false if cannot link all the way to mountpoint

Just in case we cannot link all the way to our mount point we will
force to do sync requests instead and let the MDS do the auth access
check.

Introduced-by: fd7aaab2907 client: add make_path_string() helpers support
Fixes: https://github.com/ceph/ceph/pull/48027#issuecomment-1752324457
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit c7bc4523ffec65d132eef217ce87eaf344144e35)

15 months agoclient: use the fs' full path instead of from mountpoint's root
Xiubo Li [Thu, 19 Oct 2023 02:20:55 +0000 (10:20 +0800)]
client: use the fs' full path instead of from mountpoint's root

The mountpoint's root ino# possibly not be the full CephFS
filesystem root, it's just the mountpoint of this particular client.
Just prepend the mountpoint path to the full path.

Introduced-by: c1bf8d88e9d client: check the cephx mds auth access for setattr
Introduced-by: ce216595c03 client: check the cephx mds auth access for open
Fixes: https://github.com/ceph/ceph/pull/48027#issuecomment-1741019086
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit e46dc20cdfb157f94781032451057d1e138535cc)

15 months agoqa/tasks/cephfs/test_admin: run root_squash tests only for FUSE client
Ramana Raja [Thu, 24 Nov 2022 20:48:27 +0000 (15:48 -0500)]
qa/tasks/cephfs/test_admin: run root_squash tests only for FUSE client

kclient doesn't have CEPHFS_FEATURE_MDS_AUTH_CAPS required to
enforce root_squash. Run root_squash tests only for FUSE client.

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit a04044670c615b67d633185d50eda12d53e5766b)

15 months agoqa/tasks/cephfs: Add reproducer for https://tracker.ceph.com/issues/56067
Ramana Raja [Mon, 8 Aug 2022 18:33:06 +0000 (14:33 -0400)]
qa/tasks/cephfs: Add reproducer for https://tracker.ceph.com/issues/56067

A kernel CephFS client with MDS root_squash caps is able to write to a
file as non-root user. However, the data written is lost after clearing
the kernel client cache, or re-mounting the client. This issue is not
observed with a FUSE CephFS client.

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit c8bae07f70453577d36e83e0bb02c3410ef9cade)

15 months agoqa: add test for checking access in client side of root_squash
Xiubo Li [Wed, 2 Nov 2022 01:12:16 +0000 (09:12 +0800)]
qa: add test for checking access in client side of root_squash

Test the 'chown' and 'truncate', which will call the setattr and
'cat' will open the files. Before each testing will open the file
by non-root user and keep it to make sure the Fxw caps are issued,
and then user the 'sudo' do to the tests, which will set the uid/gid
to 0/0.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 28023f84d714488a5dfd17b2191790ed15909fb3)

Conflicts:
qa/tasks/cephfs/caps_helper.py: missed dependency commit
f0ffade0525("qa/cephfs/cap_tester: simplify CapTester and its
instantiation")

15 months agoqa: add sudo paramter for read_file()
Xiubo Li [Wed, 2 Nov 2022 01:45:57 +0000 (09:45 +0800)]
qa: add sudo paramter for read_file()

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 4af6a3f7441345766fddcf2a9086d3b777c9717a)

15 months agotest/libcephfs: remove reduntant test for acccess
Xiubo Li [Tue, 25 Apr 2023 11:09:41 +0000 (19:09 +0800)]
test/libcephfs: remove reduntant test for acccess

The test.cc will be included in ceph_test_libcephfs, no need to
include it to access.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 77ac1009793016c9f4904eef6bf699105caa0b16)

15 months agomds/Server: disallow clients that have root_squash
Ramana Raja [Tue, 15 Nov 2022 19:00:24 +0000 (14:00 -0500)]
mds/Server: disallow clients that have root_squash

... MDS auth caps but don't have CEPHFS_FEATURE_MDS_AUTH_CAPS_CHECK
feature bit (i.e., can't check the auth caps sent back to it by the
MDS) from establishing a session. Do this in
Server::handle_client_session(), and Server::handle_client_reconnect(),
where old clients try to reconnect to MDS servers after an upgrade.

If the client doesn't have the ability to authorize session access
based on the MDS auth caps send back to it by the MDS, then the
client may buffer changes locally during open and setattr operations
when it's not supposed to, e.g., when enforcing root_squash MDS auth
caps.

Fixes: https://tracker.ceph.com/issues/56067
Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit e64931b6a80d0f3e365ed0fe305b73562cbca502)

15 months agomds/Locker: remove session check access when doing cap updates
Ramana Raja [Fri, 29 Jul 2022 21:51:14 +0000 (17:51 -0400)]
mds/Locker: remove session check access when doing cap updates

as it's too late. Session access authorization already happens
before new caps are issued.

Fixes: https://tracker.ceph.com/issues/56067
Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit 96305b5eef06e2b379ed95a086edf9e4809a7e70)

15 months agoclient: check the cephx mds auth access for open
Xiubo Li [Fri, 9 Sep 2022 04:32:17 +0000 (12:32 +0800)]
client: check the cephx mds auth access for open

Before opening the file locally we need to check the cephx access.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit ce216595c0391fc4b7e3c0f5b3be88aa4f67d245)

15 months agoclient: always set the caller_uid/gid to -1
Xiubo Li [Fri, 9 Sep 2022 04:17:06 +0000 (12:17 +0800)]
client: always set the caller_uid/gid to -1

Since the setattr will check the cephx mds auth access before
buffering the changes, so it makes no sense any more to let the
cap update to check the access in MDS again.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit f474203aee2ff183d6812a62f43d85b3f25eae0d)

Conflicts:
src/client/Client.cc: missed dependency commit a8d0158d0df
("Client/Inode: wait_for_caps fixups")

15 months agomds: add CEPHFS_FEATURE_MDS_AUTH_CAPS_CHECK feature bit
Xiubo Li [Wed, 14 Sep 2022 13:13:21 +0000 (21:13 +0800)]
mds: add CEPHFS_FEATURE_MDS_AUTH_CAPS_CHECK feature bit

This feature bit could be used to distinguish old and new clients.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit b2046fc7ca30a988094a473c654a0d1cef8ea945)

15 months agoclient: check the cephx mds auth access for setattr
Xiubo Li [Fri, 9 Sep 2022 03:36:31 +0000 (11:36 +0800)]
client: check the cephx mds auth access for setattr

If couldn't get the absolute path string we need to force it to
do the sync setattr.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit c1bf8d88e9d41c275fbae824c799d41d39d3ab4a)

15 months agoclient: save the cap_auths in client when session being opened
Xiubo Li [Wed, 7 Dec 2022 07:03:35 +0000 (15:03 +0800)]
client: save the cap_auths in client when session being opened

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 01a93986bff4340b1e8fecfd4e83ad92afc79b5d)

Conflicts:
src/client/Client.cc: conflict with commit 997b917c84e
("client: always refresh mds feature bits on session open")

15 months agoclient: add make_path_string() helpers support
Xiubo Li [Tue, 25 Apr 2023 09:31:25 +0000 (17:31 +0800)]
client: add make_path_string() helpers support

Will use this to get the path string to do the mds auth check. It
may fail when the there is no any dentry in local cache, which could
be caused by just unlinking the last dentry while the inode keeps
opening and then try to change the mode.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit fd7aaab290728e47ff699063fa26ad63f848bbf1)

15 months agoclient: add _get_root_ino() helper support
Xiubo Li [Tue, 25 Apr 2023 02:51:08 +0000 (10:51 +0800)]
client: add _get_root_ino() helper support

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 429aafbb18d147646e6f52e1a8af4de7a0fd68bd)

15 months agotest/libcephfs: add a tag for each test unique directory
Xiubo Li [Tue, 25 Apr 2023 06:20:49 +0000 (14:20 +0800)]
test/libcephfs: add a tag for each test unique directory

Make it to be easier to debug when searching the debug logs.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit fa687be805898e8da86056153e34acf1386a6daa)

15 months agoclient: rename MAY_* to CLIENT_MAY_* to avoid conflicts
Xiubo Li [Wed, 14 Sep 2022 05:07:05 +0000 (13:07 +0800)]
client: rename MAY_* to CLIENT_MAY_* to avoid conflicts

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 27f73a9b9e4c7efb11adb7dbb17035d8ca978727)

15 months agomds: send the cap_auths to clients when openning the sessions
Xiubo Li [Mon, 5 Dec 2022 07:49:26 +0000 (15:49 +0800)]
mds: send the cap_auths to clients when openning the sessions

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit c1cbb9acadc311f155b176d6108975835a616a5f)

Conflicts:
src/mds/MDSAuthCaps.h: missed dependency commit 23f1fdbcb3d
("AuthMonitor: allow "fs authorize" to update caps")

15 months agomds: add cap_auths in MClientSession
Xiubo Li [Mon, 5 Dec 2022 07:26:28 +0000 (15:26 +0800)]
mds: add cap_auths in MClientSession

It will include the uid/gids and path in each cap_auth.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 213a27aab0455c83284bdb2187540e4895b18e6d)

15 months agomds: add MDSCapAuth support
Xiubo Li [Tue, 20 Dec 2022 04:39:22 +0000 (12:39 +0800)]
mds: add MDSCapAuth support

Need to add writeable/readable members and send them back to clients.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 6e4a6448022051ba9a33f4cb4b0af2298f2622aa)

15 months agomds: encode/decode the MDSCapMatch
Xiubo Li [Tue, 20 Dec 2022 04:30:09 +0000 (12:30 +0800)]
mds: encode/decode the MDSCapMatch

Will send this to clients.

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 53caf313957b414ab7fcc77ff23bd1470cca1724)

15 months agomds: add assign operator support for MDSCapMatch
Xiubo Li [Tue, 20 Dec 2022 04:21:31 +0000 (12:21 +0800)]
mds: add assign operator support for MDSCapMatch

Fixes: https://tracker.ceph.com/issues/57154
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 5b6634c23d4e21b06064fddd49998ee949c34e5c)

15 months agoMerge pull request #55394 from dparmar18/wip-64220-reef
Yuri Weinstein [Tue, 26 Mar 2024 16:27:59 +0000 (09:27 -0700)]
Merge pull request #55394 from dparmar18/wip-64220-reef

reef: mgr/nfs: include pseudo in JSON output when nfs export apply -i fails

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoMerge pull request #54185 from rishabh-d-dave/wip-62332-reef
Yuri Weinstein [Tue, 26 Mar 2024 16:26:48 +0000 (09:26 -0700)]
Merge pull request #54185 from rishabh-d-dave/wip-62332-reef

reef: MDSAuthCaps: minor improvements

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoMerge pull request #56471 from rhcs-dashboard/wip-65137-reef
Nizamudeen A [Tue, 26 Mar 2024 14:20:00 +0000 (19:50 +0530)]
Merge pull request #56471 from rhcs-dashboard/wip-65137-reef

reef: mgr/dashboard: add system users to rgw user form

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
15 months agoMerge pull request #56466 from zdover23/wip-doc-2024-03-26-backport-56436-to-reef
Anthony D'Atri [Tue, 26 Mar 2024 14:06:30 +0000 (10:06 -0400)]
Merge pull request #56466 from zdover23/wip-doc-2024-03-26-backport-56436-to-reef

reef: doc/start: improve MDS explanation

15 months agoMerge pull request #56259 from guits/wip-64943-reef
Guillaume Abrioux [Tue, 26 Mar 2024 12:43:07 +0000 (13:43 +0100)]
Merge pull request #56259 from guits/wip-64943-reef

reef: ceph-volume: add missing import

15 months agomgr/dashboard: add system users to rgw user form 56471/head
Pedro Gonzalez Gomez [Fri, 22 Mar 2024 14:20:48 +0000 (15:20 +0100)]
mgr/dashboard: add system users to rgw user form

Fixes: https://tracker.ceph.com/issues/65074
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit b658bb9c32ad31608921e77603003c004ab0f15b)

15 months agoMerge pull request #55987 from joscollin/wip-64743-reef
Venky Shankar [Tue, 26 Mar 2024 09:30:05 +0000 (15:00 +0530)]
Merge pull request #55987 from joscollin/wip-64743-reef

reef: mds: add a command to dump directory information

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agodoc/start: improve MDS explanation 56466/head
Zac Dover [Sun, 24 Mar 2024 21:19:24 +0000 (07:19 +1000)]
doc/start: improve MDS explanation

Improve the explanation of MDS as requested by Anthony D'Atri here:

https://github.com/ceph/ceph/pull/56367#discussion_r1536667249

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e7eff3cf8738ddd378c2fd70075ac61dbac3cf55)

15 months agoMerge pull request #56452 from rhcs-dashboard/wip-65111-reef
Nizamudeen A [Tue, 26 Mar 2024 06:59:59 +0000 (12:29 +0530)]
Merge pull request #56452 from rhcs-dashboard/wip-65111-reef

reef: mgr/dashboard: sanitize dashboard user creation

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
15 months agoMerge pull request #56151 from sseshasa/wip-64881-reef
Yuri Weinstein [Mon, 25 Mar 2024 21:24:51 +0000 (14:24 -0700)]
Merge pull request #56151 from sseshasa/wip-64881-reef

reef: qa: Add benign cluster warning from ec-inconsistent-hinfo test to ignorelist

Reviewed-by: Laura Flores <lflores@redhat.com>
15 months agoMerge pull request #54981 from sseshasa/wip-63874-reef
Yuri Weinstein [Mon, 25 Mar 2024 21:23:12 +0000 (14:23 -0700)]
Merge pull request #54981 from sseshasa/wip-63874-reef

reef: osd: Apply randomly selected scheduler type across all OSD shards

Reviewed-by: Laura Flores <lflores@redhat.com>
15 months agoMerge pull request #56325 from adk3798/wip-64994-reef
Adam King [Mon, 25 Mar 2024 19:25:31 +0000 (15:25 -0400)]
Merge pull request #56325 from adk3798/wip-64994-reef

reef: mgr/cephadm: refresh public_network for config checks before checking

Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agoMerge pull request #56307 from adk3798/reef-timemaster
Adam King [Mon, 25 Mar 2024 19:22:53 +0000 (15:22 -0400)]
Merge pull request #56307 from adk3798/reef-timemaster

reef: cephadm: add timemaster to timesync services list

Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agoMerge pull request #56302 from adk3798/reef-only-bind-to-network
Adam King [Mon, 25 Mar 2024 19:21:08 +0000 (15:21 -0400)]
Merge pull request #56302 from adk3798/reef-only-bind-to-network

reef: mgr/cephadm: allow grafana and prometheus to only bind to specific network

Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agoMerge pull request #56292 from adk3798/reef-cephadm-pull-usage
Adam King [Mon, 25 Mar 2024 19:20:48 +0000 (15:20 -0400)]
Merge pull request #56292 from adk3798/reef-cephadm-pull-usage

reef: cephadm: improve cephadm pull usage message

Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agoMerge pull request #56286 from adk3798/reef-haproxy-healthcheck-interval
Adam King [Mon, 25 Mar 2024 19:19:45 +0000 (15:19 -0400)]
Merge pull request #56286 from adk3798/reef-haproxy-healthcheck-interval

reef: cephadm: adjust the ingress ha proxy health check interval

Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agoMerge pull request #56221 from adk3798/reef-regex-host-pattern
Adam King [Mon, 25 Mar 2024 19:19:24 +0000 (15:19 -0400)]
Merge pull request #56221 from adk3798/reef-regex-host-pattern

reef: mgr/cephadm: support for regex based host patterns

Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agoMerge pull request #56443 from rhcs-dashboard/wip-65103-reef
Nizamudeen A [Mon, 25 Mar 2024 14:14:37 +0000 (19:44 +0530)]
Merge pull request #56443 from rhcs-dashboard/wip-65103-reef

reef: mgr/dashboard: rm warning/error threshold for cpu usage

Reviewed-by: afreen23 <NOT@FOUND>
15 months agomgr/dashboard: sanitize dashboard user creation 56452/head
Pedro Gonzalez Gomez [Thu, 21 Mar 2024 07:56:58 +0000 (08:56 +0100)]
mgr/dashboard: sanitize dashboard user creation

Fixes: https://tracker.ceph.com/issues/65030
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 9951a3a7f314c7cd1eb147fb1b398ac6c5212806)

15 months agoMerge pull request #56439 from rhcs-dashboard/wip-65108-reef
Nizamudeen A [Mon, 25 Mar 2024 09:51:57 +0000 (15:21 +0530)]
Merge pull request #56439 from rhcs-dashboard/wip-65108-reef

reef: mgr/dashboard: fix empty tags

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
15 months agomgr/dashboard: rm warning/error threshold for cpu usage 56443/head
Nizamudeen A [Tue, 19 Mar 2024 14:57:13 +0000 (20:27 +0530)]
mgr/dashboard: rm warning/error threshold for cpu usage

for multi-core cpu's the value can be more than 100% so it doesn't make
sense to show warning/error when the usage is at or more than 100%.
hence removing it

Fixes: https://tracker.ceph.com/issues/58838
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 131a70754a6bfbbb2d1481ba74436953c6ecc226)

15 months agomgr/dashboard: fix empty tags 56439/head
Pedro Gonzalez Gomez [Thu, 14 Mar 2024 06:58:36 +0000 (07:58 +0100)]
mgr/dashboard: fix empty tags

Fixes: https://tracker.ceph.com/issues/64911
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit a60f82566551e731987b4a02d1bb2bf4cfb9a9ce)

15 months agoMerge pull request #56419 from rhcs-dashboard/wip-65078-reef
Nizamudeen A [Mon, 25 Mar 2024 04:39:57 +0000 (10:09 +0530)]
Merge pull request #56419 from rhcs-dashboard/wip-65078-reef

reef: Snapshot schedule show subvolume path

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56426 from zdover23/wip-doc-2024-08-24-backport-56367-to-reef
Anthony D'Atri [Sun, 24 Mar 2024 13:27:32 +0000 (09:27 -0400)]
Merge pull request #56426 from zdover23/wip-doc-2024-08-24-backport-56367-to-reef

reef: doc/start: improve MDS explanation

15 months agoMerge pull request #56410 from zdover23/wip-doc-2024-03-23-backport-56377-to-reef
Zac Dover [Sun, 24 Mar 2024 07:32:16 +0000 (17:32 +1000)]
Merge pull request #56410 from zdover23/wip-doc-2024-03-23-backport-56377-to-reef

reef: doc/start: link to mon map command

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agodoc/start: improve MDS explanation 56426/head
Zac Dover [Thu, 21 Mar 2024 12:48:10 +0000 (22:48 +1000)]
doc/start: improve MDS explanation

Remove a prolix "on behalf of" and streamline some sentences explaining
the benefits of MDS.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2da1812a1de7e32395cb95c2e0ebeea689c1b810)

15 months agomgr/dashboard: show full subvol path snap schedule 56419/head
Ivo Almeida [Wed, 20 Mar 2024 10:35:52 +0000 (10:35 +0000)]
mgr/dashboard: show full subvol path snap schedule

Show full subvolume path when adding snap schedule

Fixes: https://tracker.ceph.com/issues/65000
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit b6dbf0f24d189d5b75148f07f1dc7f332d23b64a)

15 months agoMerge pull request #56387 from rhcs-dashboard/wip-64959-reef
Ivo Almeida [Fri, 22 Mar 2024 19:30:44 +0000 (19:30 +0000)]
Merge pull request #56387 from rhcs-dashboard/wip-64959-reef

reef: mgr/dashboard: fixed nfs attach command

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
15 months agoMDSAuthCaps: use string and vector directly 54185/head
Rishabh Dave [Sat, 24 Jun 2023 04:15:03 +0000 (09:45 +0530)]
MDSAuthCaps: use string and vector directly

Since std::string and std::vector are brought into the current namespace
at the beginning of MDSAuthCaps.cc, write "string" and "vector" instead
of "std::string" and "std::vector" respectively.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 34f2243b8c89ed13760eb55994bef5f1a679ab24)

Conflicts:
src/mds/MDSAuthCaps.cc: some code using string/vector was
deleted by a different Reef backport due to which some patches
from this commit weren't applicable.

15 months agoMDSAuthCaps: bring std::string_view in main scope before using it
Rishabh Dave [Wed, 21 Jun 2023 20:58:40 +0000 (02:28 +0530)]
MDSAuthCaps: bring std::string_view in main scope before using it

Bring std::string_view to the main scope of MDSAuthCaps.cc before using
it. This reduces typing effort and improves readability.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 4a37d66a6a6fed24b4c206b140abc6f589de598a)

15 months agoMerge pull request #56385 from rhcs-dashboard/wip-65068-reef
Ivo Almeida [Fri, 22 Mar 2024 16:33:04 +0000 (16:33 +0000)]
Merge pull request #56385 from rhcs-dashboard/wip-65068-reef

reef: mgr/dashboard: fix subvolume group edit size

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agodoc/start: link to mon map command 56410/head
Zac Dover [Thu, 21 Mar 2024 22:12:16 +0000 (08:12 +1000)]
doc/start: link to mon map command

Link to the "ceph mon stat" command when "Intro to Ceph" document first
mentions Monitor Maps.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5d300db825316db25706111bbe577d41d41ab4b3)

15 months agoMerge pull request #56215 from rhcs-dashboard/applitools-disable-reef
Nizamudeen A [Fri, 22 Mar 2024 16:11:11 +0000 (21:41 +0530)]
Merge pull request #56215 from rhcs-dashboard/applitools-disable-reef

reef: mgr/dashboard: disable applitools e2e

Reviewed-by: ivoalmeida <NOT@FOUND>
15 months agomgr/dashboard: fixed nfs attach command 56387/head
Ivo Almeida [Thu, 14 Mar 2024 16:14:25 +0000 (16:14 +0000)]
mgr/dashboard: fixed nfs attach command

Fixes: https://tracker.ceph.com/issues/64933
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit db724a8fef183f6f5200bc0e93428a19c69d1342)

15 months agomgr/dashboard: fix subvolume group edit size 56385/head
Ivo Almeida [Thu, 21 Mar 2024 16:13:48 +0000 (16:13 +0000)]
mgr/dashboard: fix subvolume group edit size

Removed the 'infinite' string which was set when no value was provided

Fixes: https://tracker.ceph.com/issues/65049
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit a19f2b6e3c4b51b605be1b5683c0ddad2b9d959f)

15 months agoMerge pull request #56370 from rhcs-dashboard/wip-65046-reef
Nizamudeen A [Fri, 22 Mar 2024 10:15:40 +0000 (15:45 +0530)]
Merge pull request #56370 from rhcs-dashboard/wip-65046-reef

reef: mgr/dashboard: fix retention add for subvolume

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56363 from rhcs-dashboard/wip-65036-reef
Nizamudeen A [Fri, 22 Mar 2024 10:14:54 +0000 (15:44 +0530)]
Merge pull request #56363 from rhcs-dashboard/wip-65036-reef

reef: mgr/dashboard: fix M retention frequency display

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #55575 from rhcs-dashboard/rwg-reef-backports
Nizamudeen A [Fri, 22 Mar 2024 07:27:37 +0000 (12:57 +0530)]
Merge pull request #55575 from rhcs-dashboard/rwg-reef-backports

reef: mgr/dashboard: rgw bucket features

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agomgr/dashboard: fix retention add for subvolume 56370/head
Ivo Almeida [Wed, 21 Feb 2024 13:02:19 +0000 (13:02 +0000)]
mgr/dashboard: fix retention add for subvolume

- Added parameters for subvolume and subvolume group when adding a new
snap schedule.
- Added call to remove retention policies when removing a snap schedule
  in case it is the last one with same path

Fixes: https://tracker.ceph.com/issues/64524
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit 80e1207f4b536fe6edbc81e61cbf951e135eba54)

15 months agomgr/dashboard: fix M retention frequency display 56363/head
Ivo Almeida [Tue, 19 Mar 2024 13:13:17 +0000 (13:13 +0000)]
mgr/dashboard: fix M retention frequency display

Fix snap schedule list monthly retention frequency display

Fixes: https://tracker.ceph.com/issues/64982
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit 0bd8d3b6bc8ecbe99e22545549a63de3444e5f75)

15 months agoMerge pull request #56340 from zdover23/wip-doc-2024-03-20-backport-56333-to-reef
Zac Dover [Thu, 21 Mar 2024 02:03:24 +0000 (12:03 +1000)]
Merge pull request #56340 from zdover23/wip-doc-2024-03-20-backport-56333-to-reef

reef: doc/cephfs: fix architecture link to correct relative path

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agoMerge pull request #56268 from zdover23/wip-doc-2024-08-19-backport-56240-to-reef
Zac Dover [Thu, 21 Mar 2024 02:02:59 +0000 (12:02 +1000)]
Merge pull request #56268 from zdover23/wip-doc-2024-08-19-backport-56240-to-reef

reef: doc/rados: update common.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agoMerge pull request #56062 from mchangir/wip-64811-reef
Yuri Weinstein [Wed, 20 Mar 2024 15:35:38 +0000 (08:35 -0700)]
Merge pull request #56062 from mchangir/wip-64811-reef

reef: mds: add debug logs during setxattr ceph.dir.subvolume

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agoMerge pull request #55502 from cbodley/wip-64361-reef
Yuri Weinstein [Wed, 20 Mar 2024 15:34:57 +0000 (08:34 -0700)]
Merge pull request #55502 from cbodley/wip-64361-reef

reef: cmake/modules/BuildRocksDB.cmake: inherit parent's CMAKE_CXX_FLAGS

Reviewed-by: Mark Nelson <mnelson@redhat.com>
15 months agoMerge pull request #54711 from mchangir/wip-63590-reef
Yuri Weinstein [Wed, 20 Mar 2024 15:33:28 +0000 (08:33 -0700)]
Merge pull request #54711 from mchangir/wip-63590-reef

reef: qa: run kernel_untar_build with newer tarball

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agoMerge pull request #56213 from idryomov/wip-63770-reef
Yuri Weinstein [Wed, 20 Mar 2024 15:31:03 +0000 (08:31 -0700)]
Merge pull request #56213 from idryomov/wip-63770-reef

reef: librbd: account for discards that truncate in ObjectListSnapsRequest

Reviewed-by: Ramana Raja <rraja@redhat.com>
15 months agoMerge pull request #56004 from prazumovsky/wip-63684-reef-backport
Yuri Weinstein [Wed, 20 Mar 2024 15:29:57 +0000 (08:29 -0700)]
Merge pull request #56004 from prazumovsky/wip-63684-reef-backport

reef: RGW - Swift retarget needs bucket set on object

Reviewed-by: Casey Bodley <cbodley@redhat.com>
15 months agoMerge pull request #55692 from neesingh-rh/wip-64518-reef
Yuri Weinstein [Wed, 20 Mar 2024 15:27:16 +0000 (08:27 -0700)]
Merge pull request #55692 from neesingh-rh/wip-64518-reef

reef: mgr/volumes: support to reject CephFS clones if cloner threads are not available

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agodoc/cephfs: fix architecture link to correct relative path 56340/head
molpako [Wed, 20 Mar 2024 09:43:42 +0000 (18:43 +0900)]
doc/cephfs: fix architecture link to correct relative path

Signed-off-by: molpako <35787116+molpako@users.noreply.github.com>
(cherry picked from commit ceeb1ca4b38dc307e493b04a59d5d07fed23971f)

16 months agoMerge pull request #55541 from rhcs-dashboard/wip-63728-reef
Nizamudeen A [Wed, 20 Mar 2024 10:46:04 +0000 (16:16 +0530)]
Merge pull request #55541 from rhcs-dashboard/wip-63728-reef

reef: mgr/dashboard: add support for editing and deleting rgw roles

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
16 months agoMerge pull request #56254 from rhcs-dashboard/wip-64930-reef
Pedro Gonzalez Gomez [Wed, 20 Mar 2024 07:46:10 +0000 (08:46 +0100)]
Merge pull request #56254 from rhcs-dashboard/wip-64930-reef

reef: mgr/dashboard: ceph authenticate user from fs

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agoMerge pull request #56290 from zdover23/wip-doc-2024-03-20-backport-56109-to-reef
Adam King [Tue, 19 Mar 2024 21:07:17 +0000 (17:07 -0400)]
Merge pull request #56290 from zdover23/wip-doc-2024-03-20-backport-56109-to-reef

reef: doc/cephadm/services: Improve monitoring.rst

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
16 months agoMerge pull request #56230 from adk3798/reef-docs-typo-replace-osd
Adam King [Tue, 19 Mar 2024 21:01:07 +0000 (17:01 -0400)]
Merge pull request #56230 from adk3798/reef-docs-typo-replace-osd

reef: doc: cephadm/services/osd: fix typo

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
16 months agomgr/cephadm: refresh public_network for config checks before checking 56325/head
Adam King [Wed, 13 Mar 2024 19:30:25 +0000 (15:30 -0400)]
mgr/cephadm: refresh public_network for config checks before checking

The place it was being run before meant it would only grab the
public_network setting once at startup of the module. This meant
if a user changed the setting, which they are likely to do if they
get the warning, cephadm would ignore the change and continue
reporting that the hosts don't match up with the old setting
for the public_network. This moves the call to refresh the
setting to right before we actually run the checks. It does
mean we'll do the `ceph config dump --format json` call
each serve loop iteration, but I've found that only tends
to take a few milliseconds, which is nothing compared to
the time to refresh other things we check during the serve
loop.

I additionally modified the use of this option to use
the attribute on the mgr, rather than calling
`get_module_option`. This was just to get it more in
line with how we tend to handle other config options

Fixes: https://tracker.ceph.com/issues/64902
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 129c10b4da518b8843ac0bc5397276eb695d4033)

16 months agocephadm.py: add timemaster to timesync services list 56307/head
Florent Carli [Tue, 12 Mar 2024 17:31:16 +0000 (18:31 +0100)]
cephadm.py: add timemaster to timesync services list

On debian/ubuntu, if you need PTP, it's possible to use the linuxptp package for time-synchonization.
In that case the systemd service is called timemaster and is a wrapper for chrony/ntpd/phc2sys/ptp4l.

Signed-off-by: Florent Carli <florent.carli@rte-france.com>
(cherry picked from commit 4ee1c761e50e3c3feed89ccc5c450ac96681b778)

16 months agomgr/cephadm: allow having prometheus bind on specific network 56302/head
Adam King [Thu, 29 Feb 2024 18:04:43 +0000 (13:04 -0500)]
mgr/cephadm: allow having prometheus bind on specific network

To avoid port conflicts in certain setups where
something else is using the same port on a different
network on the host.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit e6943dd61374ee8ce337751e9ef9ba55f10a83ed)

Conflicts:
src/cephadm/cephadmlib/daemons/monitoring.py
src/cephadm/tests/test_deploy.py

16 months agomgr/cephadm: add option for grafana to bind on specific network
Adam King [Wed, 18 Oct 2023 20:22:18 +0000 (16:22 -0400)]
mgr/cephadm: add option for grafana to bind on specific network

For example, with a spec like

```
[root@vm-00 ~]# cat grafana.yaml
service_type: grafana
service_name: grafana
placement:
  count: 1
networks:
  - 10.2.1.0/24
spec:
  anonymous_access: true
  protocol: https
  only_bind_port_on_networks: true
```

where the networks is set and the
"only_bind_port_on_networks" option is
set to true, the grafana daemon will bind
to its port (3000 in this case since it's
the default and I didn't set a port) only
on an IP from that network. I tested this
by holding port 3000 on an IP from a different
network on the host and then deploying
grafana. Without this patch it would have
failed with a port conflict error.

```
[root@vm-00 ~]# netstat -tulpn | grep 3000
tcp        0      0 10.2.1.61:3000          0.0.0.0:*               LISTEN      34178/grafana
tcp        0      0 192.168.122.251:3000    0.0.0.0:*               LISTEN      33274/nc
```

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 6ee5fff0c8dc71c4789496a587e2599ff2e0bc13)

16 months agomgr/dashboard: support rgw roles updating 55541/head
Nizamudeen A [Wed, 18 Oct 2023 06:38:21 +0000 (12:08 +0530)]
mgr/dashboard: support rgw roles updating

Right now only the modification of max_session_duration is supported via
the roles update command. To update, we need to use `policy modify`
command which is not added in this PR. That should be done separately

Refer: https://docs.ceph.com/en/latest/radosgw/role/#update-a-role

Fixes: https://tracker.ceph.com/issues/63230
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 5c28d78a45d87d2be6b9ea2961be42689673e252)

16 months agomgr/dashboard: support rgw roles removal
Nizamudeen A [Wed, 18 Oct 2023 06:36:47 +0000 (12:06 +0530)]
mgr/dashboard: support rgw roles removal

Fixes: https://tracker.ceph.com/issues/63230
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 2e06ab0b8c730f063e1376b2f330c3b78089af67)

16 months agocephadm: improve cephadm pull usage message 56292/head
Adam King [Fri, 1 Mar 2024 18:22:44 +0000 (13:22 -0500)]
cephadm: improve cephadm pull usage message

Generally, it's uncommon for users to run this
directly, but in case they need to for debugging
purposes, we should include how to pass the
image to be pulled in the usage message.

Additionally, include that this is only to be used
for pulling ceph images in the help message, as
that isn't necessarily clear. Pulling anything
else will result in a traceback as it tries
to run `ceph --version` inside the container.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 90b8ba9fc09ace4e4114152b194239061c7acb31)

16 months agodoc/cephadm/services: Improve monitoring.rst 56290/head
Anthony D'Atri [Sun, 10 Mar 2024 21:36:37 +0000 (17:36 -0400)]
doc/cephadm/services: Improve monitoring.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit ead944be18781ddccd52af5aa5cff414d15bb39d)

16 months agoMerge pull request #55928 from ajarr/wip-64668-reef
Ilya Dryomov [Tue, 19 Mar 2024 14:05:58 +0000 (15:05 +0100)]
Merge pull request #55928 from ajarr/wip-64668-reef

reef: qa: add diff-continuous and compare-mirror-image tests to rbd and krbd suites respectively

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
16 months agocephadm: adjust the ingress ha proxy health check interval 56286/head
Jiffin Tony Thottan [Wed, 2 Aug 2023 07:53:12 +0000 (13:23 +0530)]
cephadm: adjust the ingress ha proxy health check interval

Currently health checker uses default value of 2s, it is send list
bucket request for every 2s. This seems to be frequent and need to
adjust properly. Hence introducing new setting health_check_interval in
the ingress spec for haproxy.

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Apply suggestions from code review

Co-authored-by: Adam King <47704447+adk3798@users.noreply.github.com>
Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
(cherry picked from commit 75327c5b56591c6a29ad47745df24d16320f5a99)

16 months agoMerge pull request #56196 from vshankar/wip-64926-reef
Venky Shankar [Tue, 19 Mar 2024 13:21:44 +0000 (18:51 +0530)]
Merge pull request #56196 from vshankar/wip-64926-reef

reef: mds: disable `defer_client_eviction_on_laggy_osds' by default

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
16 months agoqa/suites: add diff-continuous and compare-mirror-image tests 55928/head
Ramana Raja [Thu, 29 Feb 2024 17:12:19 +0000 (12:12 -0500)]
qa/suites: add diff-continuous and compare-mirror-image tests

... to rbd and krbd suites respectively.

This allows the compare-mirror-image tests introduced in ea3a567
to be run against various kernel branches, e.g., testing branch.
And allows diff_continuous test in rbd_suite to run against distro
kernel.

Fixes: https://tracker.ceph.com/issues/64574
Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit 92b254138dd43755490392ffcf5ebca04872e116)

16 months agoqa/suites/rbd: rename nbd folder to device folder
Ramana Raja [Thu, 29 Feb 2024 16:55:08 +0000 (11:55 -0500)]
qa/suites/rbd: rename nbd folder to device folder

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit af43f6162464a20625319a2783a104f7032ba21e)

16 months agoMerge pull request #55762 from ajarr/wip-64554-reef
Ilya Dryomov [Tue, 19 Mar 2024 10:08:05 +0000 (11:08 +0100)]
Merge pull request #55762 from ajarr/wip-64554-reef

reef: qa: Add tests to validate synced images on rbd-mirror

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
16 months agodoc/rados: update common.rst 56268/head
Zac Dover [Sun, 17 Mar 2024 09:27:11 +0000 (19:27 +1000)]
doc/rados: update common.rst

Clarify some overwritten paragraphs in
doc/rados/configuration/common.rst. Cf.
https://github.com/ceph/ceph/pull/50795/files#r1153897231.

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 233b670704d15c3a69b8d91885b60f3fb101ec58)

16 months agoMerge pull request #56262 from zdover23/wip-doc-2024-03-19-backport-56247-to-reef
Zac Dover [Mon, 18 Mar 2024 17:39:38 +0000 (03:39 +1000)]
Merge pull request #56262 from zdover23/wip-doc-2024-03-19-backport-56247-to-reef

reef: docs/rbd: fix typo in arg name

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
16 months agodocs/rbd: fix typo in arg name 56262/head
N Balachandran [Mon, 18 Mar 2024 04:02:39 +0000 (09:32 +0530)]
docs/rbd: fix typo in arg name

Replace "{image-}" with "{image-id}" in the "rbd trash rm"
command description.

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit f3eb489520fd4fae057e61275d16c6c8fd596f3f)

docs/rbd: replace introspect with inspect

Replace "introspect" with "inspect" in the rbd basic commands
description.

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit ebf2f60f784728c04d8ec59015d666bafcef8218)

docs/rbd: typo in "retrieving image information"

Replace "for the image" with "of the image".

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit 4fd5c134536d652ae1f9e05ecf52cb81adb3b850)

16 months agoMerge pull request #56256 from zdover23/wip-doc-2024-03-18-backport-56248-to-reef
Anthony D'Atri [Mon, 18 Mar 2024 14:06:04 +0000 (10:06 -0400)]
Merge pull request #56256 from zdover23/wip-doc-2024-03-18-backport-56248-to-reef

reef: doc/rbd: minor changes to the rbd man page

16 months agoceph-volume: add missing import 56259/head
Guillaume Abrioux [Wed, 13 Mar 2024 14:04:28 +0000 (15:04 +0100)]
ceph-volume: add missing import

This adds the missing import `List` (from typing).

Probably missed by 36c83bf54243.

Fixes: https://tracker.ceph.com/issues/64898
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 1abd3e659ff59d7b0c5c2360a665c395a748e3ff)

16 months agodoc/rbd: minor changes to the rbd man page 56256/head
N Balachandran [Mon, 18 Mar 2024 12:22:47 +0000 (17:52 +0530)]
doc/rbd: minor changes to the rbd man page

Fixes typos and grammar for some commands. Adds
additional details for some commandds.

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit 5dcff6a4b8d835fc55e454af977dc5ebad99d37f)

16 months agoMerge pull request #56252 from guits/wip-64932-reef
Guillaume Abrioux [Mon, 18 Mar 2024 10:39:37 +0000 (11:39 +0100)]
Merge pull request #56252 from guits/wip-64932-reef

reef: node-proxy: fix RedFishClient.logout() method

16 months agomgr/dashboard: ceph authenticate user from fs 56254/head
Pedro Gonzalez Gomez [Fri, 1 Mar 2024 12:43:12 +0000 (13:43 +0100)]
mgr/dashboard: ceph authenticate user from fs

Fixes: https://tracker.ceph.com/issues/64660
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 19a9f79b5f218d8cb757579bf8c0f5d610dde3a8)