osd: add more debug logs for sparse read

This will be very important to get to know what exactly has happened
when client get a very large number of extents.

URL: https://tracker.ceph.com/issues/63586
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 1cf5ecb93fb73a5ed4a82935f635f98efccf7de6)

Merge pull request #54601 from zdover23/wip-doc-2023-11-22-backport-54598-to-reef

reef: doc/rados: edit "recovering broken monmap"

doc/rados: edit "recovering broken monmap"

Edit the section "Recovering a monitor's broken monmap" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6ccb9f3ca10e814c42effb49c8441c23da911adc)

Merge pull request #54541 from aaSharma14/wip-63568-reef

reef: mgr/dashboard: Consider null values as zero in grafana panels

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #54579 from zdover23/wip-doc-2023-11-21-backport-54574-to-reef

reef: doc/rados: edit "understanding mon_status"

doc/rados: edit "understanding mon_status"

Edit the section "Understanding mon_status" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 08c16aa113dc22dfec3387f575752a5049b7af42)

Merge pull request #54576 from zdover23/wip-doc-2023-11-21-backport-54565-to-reef

reef: doc/rados: edit "Using the Monitor's Admin Socket"

doc/rados: edit "Using the Monitor's Admin Socket"

Edit the section "Using the Monitor's Admin Socket" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit f627445806dadcc956fe1256cfc3886cb5b8e1ef)

Merge pull request #54572 from zdover23/wip-doc-2023-11-21-backport-54561-to-reef

reef: doc/start: update release names

doc/start: update release names

Update "Quincy" to "Reef" and "Pacific" to "Quincy" in the section
"Viewing Old Ceph Documentation" in /doc/start/documenting-ceph.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 83ff8f2b67f1a784ebb3ca7d0b7ca2c385f99343)

Merge pull request #54559 from zdover23/wip-doc-2023-11-19-backport-54545-to-reef

reef: doc/start: explain "OSD"

doc/start: explain "OSD"

Explain the initialism "OSD" and link to its definition in the glossary.
This PR is raised in response to an anonymous documentation bug that reads

  "Paragraph 2 uses the acronym OSD without any explanation.
   This makes it very difficult to understand this part of
   the documentation as there is no indication of what this
   acronym is until much further into the documentation. Replace
   first occurence of OSD with Object Storage Daemon (OSD) or
   link it to the glossary."
     -- https://pad.ceph.com/p/Report_Documentation_Bugs

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a78fe85470c2471574aceb723cd304498cde1afb)

Merge pull request #54551 from zdover23/wip-doc-2023-11-19-backport-54523-to-reef

reef: doc/man: edit ceph-osd description

doc/man: edit ceph-osd description

Improve the English grammar and reduce the ambiguity and unclear writing
in the "Description" section of doc/man/8/ceph-osd.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2921dacf1e7b7ad2aa62f52d6e8914d8ec50a610)

mgr/dashboard: Consider null values as zero in grafana panels

After upgrading from RHCS4 to RHCS5..some of the grafana charts broke.
This is because in RHCS5 we do not generate the metrics if its value is
zero as a result the null value from that metric breaks the grafana
charts or graphs. This PR is to fix the above mentioned issue.

Fixes: https://tracker.ceph.com/issues/63088
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 6f3f58cb8e4ce100cc7186858465b4d11d5c2c49)

Merge pull request #54521 from guits/wip-63554-reef

reef: ceph-volume: fix a regression in `raw list`

ceph-volume: fix a regression in `raw list`

'ceph-volume raw list' is broken for a specific use case (rook).

rook copies devices from /dev/ to /mnt for specific/internal needs.

when ceph-volume raw list is passed a device from /mnt then
ceph-volume ignores it and return an empty dict.
That prevent rook from creating OSDs properly.

https://tracker.ceph.com/issues/63545

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit e67dce7120954fff9b7b936348bed0b2ac6c1155)

Merge pull request #54509 from zdover23/wip-doc-2023-11-15-backport-54497-to-reef

reef: doc/glossary: add "Quorum" to glossary

doc/glossary: add "Quorum" to glossary

Add the term "Quorum" to the glossary and link to the part of
architecture.rst concerning Monitors. The sticky header at the top of
the docs.ceph.com website gets in the way of the location linked to in
this commit, but fatigue and disgust prevent me from spending time today
trial-and-erroring my way through the hostile and ill-documented
wilderness of scroll-margin so that the link goes where it should.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c2f6a770bf0e12296c334d99ac86ff4732ec29b7)

Merge pull request #54502 from zdover23/wip-doc-2023-11-15-backport-54496-to-reef

reef: doc/rados: edit "troubleshooting-mon"

doc/rados: edit "troubleshooting-mon"

Edit the text in the "Initial Troubleshooting" section of
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit fa8129a7466b3b48b56124eaf1d9ca8e8fd51fbc)

Merge pull request #54480 from zdover23/wip-doc-2023-11-14-backport-54479-to-reef

reef: doc/start: fix typo in hardware-recommendations.rst

doc/start: fix typo in hardware-recommendations.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 48fd7ff1e13ccfeca04b9283b13641ce59316723)

Merge pull request #54477 from zdover23/wip-doc-2023-11-13-backport-54473-to-reef

reef: doc/rados: format "initial troubleshooting"

doc/rados: format "initial troubleshooting"

Format the steps in the "Initial Troubleshooting" section of
doc/rados/troubleshooting/troubleshooting-mon.rst. A near-future PR (not
this one) will add context to this section and explain that the steps
described here are the first steps that you should undertake when you
determine that you have an unresponsive or down Monitor. This PR is
merely for formatting.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c581018caf626fa0dd50bd244766bfa9755c9a16)

Merge pull request #54224 from rkachach/fix_issue_63266

reef: backport of rook orchestrator fixes and e2e automated testing

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #54463 from zdover23/wip-doc-2023-11-13-backport-54457-to-reef

reef: doc/config: edit "ceph-conf.rst"

Merge pull request #54461 from zdover23/wip-doc-2023-11-12-backport-54458-to-reef

reef: doc/rados: parallelize t-mon headings

doc/config: edit "ceph-conf.rst"

Edit the first section of doc/rados/configuration/ceph-conf.rst.
Initially I just wanted to change "series" to "set", but once I got my
hands dirty I ended up simplifying some sentences.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c886e05404ce9c50454d40e692ababdc55f346c6)

doc/rados: parallelize t-mon headings

Give parallel structure to the questions in the Q&A section of the "The
Cluster Has Quorum But At Least One Monitor Is Down" subsection of the
"Most Common Monitor Issues" section of
doc/rados/troubleshooting/troubleshooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 010e5a13b9e4e6a860c676f1b3090a495592d715)

Merge pull request #54455 from zdover23/wip-doc-2023-11-11-backport-54452-to-reef

reef: doc/rados: edit t-mon "common issues" (5 of x)

doc/rados: edit t-mon "common issues" (5 of x)

Edit the fifth part of the section "Most Common Monitor Issues" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Follows https://github.com/ceph/ceph/pull/54440.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d98222db9b4436841102d23c979f05a9d958bb1f)

Merge pull request #54443 from zdover23/wip-doc-2023-11-10-backport-54440-to-reef

reef: doc/rados: edit t-mon "common issues" (4 of x)

doc/rados: edit t-mon "common issues" (4 of x)

Edit the fourth part of the section "Most Common Monitor Issues" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Follows https://github.com/ceph/ceph/pull/54432.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit f6b686ac3118507baab719f1587c8c360499e929)

Merge pull request #54438 from zdover23/wip-doc-2023-11-10-backport-54432-to-reef

reef: doc/rados: edit t-mon "common issues" (3 of x)

doc/rados: edit t-mon "common issues" (3 of x)

Edit the second part of the section "Most Common Monitor Issues" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Follows https://github.com/ceph/ceph/pull/54417.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 91ed10bc734bd93605b60c87037393d2704a16bc)

Merge pull request #54436 from ceph/wip-yuriw-quincy-x-reef

qa/tests: added - \(POOL_APP_NOT_ENABLED\) to the ignore list

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Prashant D <pdhange@redhat.com>

qa/tests: added - \(POOL_APP_NOT_ENABLED\) to the ignore list

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>

Merge pull request #54429 from guits/wip-63491-reef

reef: ceph-volume: Revert "ceph-volume: fix raw list for lvm devices"

ceph-volume: fix raw list for non-existent device

ceph-volume should not crash when given a device which doesn't exist.

Fixes: https://tracker.ceph.com/issues/63391
Signed-off-by: Matthew Booth <mbooth@redhat.com>
(cherry picked from commit e009b1a319c834a504947423ae1dd55387809235)
(cherry picked from commit 0e17f8b5aebb51ee69ce0689dabe2a9111055716)

ceph-volume: Revert "ceph-volume: fix raw list for lvm devices"

This reverts commit e5e429617c1c27dcd631171f65d30571e32f7266.
This commit introduced a regression, see linked tracker for details.

Fixes: https://tracker.ceph.com/issues/63391
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 916a22ef031953056771eceb1f49cab7eb746978)

Merge pull request #54427 from zdover23/wip-doc-2023-11-09-backport-54412-to-reef

reef: doc/rados: edit t-shooting-mon.rst

doc/rados: edit t-shooting-mon.rst

Improve the front matter of the section "Troubleshooting Monitors" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e6e3fda2efb8f4a4345ba5f939baade844c5d582)

Merge pull request #54421 from zdover23/wip-doc-2023-11-09-backport-54417-to-reef

reef: doc/rados: edit t-mon "common issues" (2 of x)

doc/rados: edit t-mon "common issues" (2 of x)

Edit the second part of the section "Most Common Monitor Issues" in
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 7dcfa9132ce6ca97d2c414014fc5de0a0c7e106e)

Merge pull request #54418 from zdover23/wip-doc-2023-11-08-backport-54413-to-reef

reef: doc/rados: edit t-mon "common issues" (1 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rados: edit t-mon "common issues" (1 of x)

Edit the first part of the section "Most Common Monitor Issues" in
doc/rados/troubleshooting/troublehsooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 434d8967a37d49bdce3effae4e9b4c69a8586a56)

backport: https://github.com/ceph/ceph/pull/54364

Signed-off-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #54395 from aaSharma14/wip-63470-reef

reef: mgr/dashboard: fix rgw multi-site import form helper

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #54380 from vshankar/tr-62539

reef: qa: add POOL_APP_NOT_ENABLED to ignorelist for cephfs tests

mgr/dashboard: fix rgw multi-site import form helper

Before : To obtain the token, generate it from your primary Ceph cluster. This token includes encoded information about the secondary cluster's endpoint, access key, and secret key.
Fix: To obtain the token, generate it from your primary Ceph cluster. This token includes encoded information about the primary cluster's endpoint, access key, and secret key.

Fixes: https://tracker.ceph.com/issues/63469
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit 157f21022e5a065e1457e5ac534d0dd7c66aaab1)

Merge pull request #54388 from zdover23/wip-doc-2023-11-07-backport-54384-to-reef

reef: doc/cephadm: fix typo in set ssh key command

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #54376 from ljflores/wip-pool-app-reef

reef: qa/smoke,orch,perf-basic: add POOL_APP_NOT_ENABLED to ignorelist

Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Prashant D <pdhange@redhat.com>

doc/cephadm: fix typo in set ssh key command

Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
(cherry picked from commit e9654b77eda12a3862eefb93c65dc5f15715833d)

Merge pull request #54371 from cbodley/wip-63452-reef

reef: rgw: fetch_remote_obj() uses uncompressed size for encrypted objects

Reviewed-by: Yuri Weinstein <yuriw@redhat.com>

backport: https://github.com/ceph/ceph/pull/54056

Signed-off-by: Redouane Kachach <rkachach@redhat.com>

Revert "Revert "Merge PR #53077 into main""

This reverts commit af4558f0ac3b0dc23a8b3cbba63b9c8acc498ea4.

Fixes: http://tracker.ceph.com/issues/62482
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 7d5795dc37fc903121f2caa584bec55773fb61ee)

qa: do not create rbd pool for CephFS QA

Fixes: https://tracker.ceph.com/issues/62482
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 636d2a44c7a935426788ed61e9a77432dc49ca5e)

Revert "Merge PR #53077 into main"

This reverts commit b8bf0c62b96cb76ae547d5d2f13d2a68417e79e9, reversing
changes made to fe07f64396e504c373bd1b621dda0b7893753fe8.

Silencing this health warning is unnecessary if we stop creating the rbd pool
in CephFS testing.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit af4558f0ac3b0dc23a8b3cbba63b9c8acc498ea4)

qa: add `POOL_APP_NOT_ENABLED` to ignorelist for cephfs tests

Fixes: http://tracker.ceph.com/issues/62508
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 97b76a480b9708f8557222de14058f644746a4a6)

qa/smoke,orch,perf-basic: add POOL_APP_NOT_ENABLED to ignorelist

Some of the smoke, orch and perf-basic tests are failing due
to POOL_APP_NOT_ENABLED health check failure. Add
POOL_APP_NOT_ENABLED to ignorelist for these tests.

Signed-off-by: Prashant D <pdhange@redhat.com>
(cherry picked from commit 4ecec7a777e90fce31317bc805fc70e1b40cba74)

Merge pull request #54368 from zdover23/wip-doc-2023-11-07-backport-54342-to-reef

reef: doc/radosgw: Improve dynamicresharding.rst

Merge pull request #54366 from zdover23/wip-doc-2023-11-07-backport-54352-to-reef

reef:doc/rados: format Q&A list in tshooting-mon.rst

rgw: fetch_remote_obj() uses uncompressed size for encrypted objects

use the original size from RGW_ATTR_COMPRESSION as the accounted size in
the bucket index for objects that were transferred in their
encrypted/compressed form

Fixes: https://tracker.ceph.com/issues/63306
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 526643826246fa8dbe35ea2f65bf9ad0ef9566ff)

Conflicts:
        src/rgw/driver/rados/rgw_rados.cc no req_context

rgw: rename 'expected' to 'accounted' size in fetch_remote_obj()

and use it instead of cb.get_data_len() after testing for equality

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 999d539f76bdb4baa0b8342fff74a9e3fd1cdc12)

Conflicts:
src/rgw/driver/rados/rgw_rados.cc no req_context

doc/radosgw: Improve dynamicresharding.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit a9bf0c13e3dc866bd1cb724a10e23ae215e15437)

doc/rados: format Q&A list in tshooting-mon.rst

Bold the questions in a Q&A list in the "Most Common Monitor Issues"
section of doc/rados/troubleshooting/troubleshooting-mon.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 0d953d27cb6503dfde7f4f7ecb9a386c533c30c9)

backport: https://github.com/ceph/ceph/pull/53747
backport: https://github.com/ceph/ceph/pull/54151

Signed-off-by: Redouane Kachach <rkachach@redhat.com>

backport of: https://github.com/ceph/ceph/pull/54307

Signed-off-by: Redouane Kachach <rkachach@redhat.com>

Merge pull request #54353 from zdover23/wip-doc-2023-11-06-backport-54286-to-reef

reef: doc/cephfs: edit mount-using-fuse.rst

doc/cephfs: edit mount-using-fuse.rst

Fixes missing dash that lead to unnecessary debugging.

Signed-off-by: Jaanus Torp <jaanus@saun.ee>
(cherry picked from commit 9fcb98411bfeb9147f61bef4424a78d98c63cadc)

Merge pull request #54349 from zdover23/wip-doc-2023-11-06-backport-54344-to-reef

reef: doc/rados: edit t-mon.rst text

doc/rados: edit t-mon.rst text

Clarify the text in the "Clock Skew" section of
doc/rados/troubleshooting/troubleshooting-mon.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5496bd426f35c0ab91ae7d544ae92ed3b517c7eb)

Merge pull request #54345 from zdover23/wip-doc-2023-11-05-backport-54343-to-reef

reef: doc/rados: format Q&A list in t-mon.rst

doc/rados: format Q&A list in t-mon.rst

Format a Q&A list in doc/rados/troubleshooting/troubleshooting.rst, in
the "Clock Skews" section.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit aadb87aeb5cd8b413937ddfe4562411d424c4bb1)

Merge pull request #54161 from cbodley/wip-61352-reef

reef: rgw/s3: ListObjectsV2 returns correct object owners

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #54267 from ronen-fr/wip-63371-reef

reef: osd: fix use-after-move in build_incremental_map_msg()

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #54191 from cfsnyder/wip-63252-reef

reef: rgw: add versioning info to radosgw-admin bucket stats output

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #54163 from galsalomon66/wip-63297-reef

reef: rgw/s3select: fix per QE defect.

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #54124 from cbodley/wip-63279-reef

reef: rgw: don't dereference nullopt in DeleteMultiObj

Reviewed by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: Cory Snyder <csnyder@iland.com>

Merge pull request #53516 from yuvalif/wip-61919-reef

reef: rgw/amqp: remove possible race conditions with the amqp connections

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #54254 from pkalever/wip-63350-reef

reef: rbd-nbd: fix stuck with disable request

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #54276 from ljflores/wip-63375-reef

reef: osd: fix logic in check_pg_upmaps

Reviewed-by: Josh Salomon <josh.salomon@gmail.com>

Merge pull request #54329 from zdover23/wip-doc-2023-11-04-backport-54274-to-reef

reef: doc: Update dynamicresharding.rst

Merge pull request #54320 from zdover23/wip-doc-2023-11-03-backport-54303-to-reef

reef: doc/cephadm: edit troubleshooting.rst (2 of x)

Merge pull request #54323 from zdover23/wip-doc-2023-11-03-backport-54322-to-reef

reef: doc/cephadm/services: remove excess rendered indentation in osd.rst

doc: Update dynamicresharding.rst

"3, After resharding completed:" should be
"3. After resharding completed:"

Signed-off-by: Aliaksei Makarau <aliaksei.makarau@ibm.com>
(cherry picked from commit e96cef78bb97491e6488999d6bc4a068cd1c5a8d)

doc/cephadm/services: remove excess rendered indentation in osd.rst

Start bash command blocks at the left margin, removing
excessive padding/indentation that would render the
block too much towards the right.

At the same time ident the source consistently:
- Two spaces for command blocks and output blocks.
- Four spaces for notes, code blocks.

There seems to be no uniform style for this, sometimes
commands are indented with three spaces but it would
seem two spaces is common. In the end it all renders
the same I guess.

Signed-off-by: Ville Ojamo <14869000+bluikko@users.noreply.github.com>
(cherry picked from commit 329df4959d08e9bc90d6e1d83f99bd344a13dc1e)

doc/cephadm: edit troubleshooting.rst (2 of x)

Edit doc/cephadm/troubleshooting.rst. This commit and the PR of which it
is a part was raised in response to https://github.com/ceph/ceph/pull/53976.

Co-authored-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b096c21c7c4df2bf177f3ba84093cc75ecd71d49)

Merge pull request #54291 from ajarr/wip-63387-reef

reef: qa/suites/rbd: add test to check rbd_support module recovery

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #54289 from ajarr/wip-63384-reef

reef: mgr/rbd_support: fix recursive locking on CreateSnapshotRequests lock

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #54283 from zdover23/wip-doc-2023-11-01-backport-54281-to-reef

reef: doc/cephadm: edit troubleshooting.rst (1 of x)

qa/suites/rbd: add test to check rbd_support module recovery

... on repeated blocklisting of its client.

There were issues with rbd_support module not being able to recover
from its RADOS client being repeatedly blocklisted. This occured for
example in clusters with OSDs slow to process RBD requests while the
module's mirror_snapshot_scheduler was taking mirror snapshots by
requesting exclusive locks on the RBD images and workloads were running
on the snapshotted images via kernel clients.

Fixes: https://tracker.ceph.com/issues/62891
Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit 2f2cd3bcff82afc3a4d251143eb462e700e7fc60)

mgr/rbd_support: remove CreateSnapshotRequests __del__()

There is no need for CreateSnapshotRequests.__del__() that calls
CreateSnapshotRequests.wait_for_pending().
MirrorSnapshotScheduleHandler.shutdown() already calls
CreateSnapshotRequests.wait_for_pending().

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit fed1e87685a698876cf167b3681327e5b0066ee6)

mgr/rbd_support: fix recursive locking on CreateSnapshotRequests lock

The MirrorSnapshotScheduleHandler's run thread issues asynchronous
create snapshot requests using a CreateSnapshotRequests instance. When
the thread invokes a CreateSnapshotRequests instance's get_ioctx(),
the instance's class variable lock is acquired. With the class
variable lock held, the garbage collection of a CreateSnapshotRequests
instance may race in the thread. The thread would then call
CreateSnapshotRequests __del__() that tries to acquire the class
variable lock that the thread already holds. Fix this
recursive deadlock by converting the CreateSnapshotRequests lock from
a class variable to an instance variable. There is no need to share
the lock across CreateSnapshotRequests instances.

Also convert MirrorSnapshotScheduleHandler, PerfHandler and
TrashPurgeScheduleHandler class variables to instance variables
that don't need to be shared across the instances.

Fixes: https://tracker.ceph.com/issues/62994
Signed-off-by: Ramana Raja <rraja@redhat.com>
Co-Authored-By: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 4452bc22d1c6c8499cf55d6e39090adf7ae1dcbf)

doc/cephadm: edit troubleshooting.rst (1 of x)

Edit doc/cephadm/troubleshooting.rst. This commit and the PR of which it
is a part was raised in response to
https://github.com/ceph/ceph/pull/53976. The limits of reStructuredText
are particularly visible here in every instance of a BASH for-loop and
in every instance of a command stretched over multiple lines.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 69472c26af5419faa9ed93c071ed5933d03fa67f)

Merge pull request #54265 from zdover23/wip-doc-2023-10-31-backport-54239-to-reef

reef: doc/glossary: improve "BlueStore" entry

osd: fix logic in check_pg_upmaps

The logic was changed in check_pg_upmaps
in a Reef refactor, which results in recommendations
made by the upmap balancer even when it says there are
no optimizations.

Fixes: https://tracker.ceph.com/issues/63029
Signed-off-by: Laura Flores <lflores@ibm.com>
(cherry picked from commit ae11bbe6b2805740d3621cc47c68a5f0da493df0)

Merge pull request #54270 from zdover23/wip-doc-2023-10-31-backport-54238-to-reef

reef: doc/rados: improve "scrubbing" explanation

doc/rados: improve "scrubbing" explanation

Improve the English describing the operation of scrubbing PGs in
doc/rados/configuration/osd-config-ref.rst.

Co-authored-by: Ronen Friedman <rfriedma@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 19b139932d8aef9b47e1fa9c400c3f73b5cb3d7b)