]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Dhairya Parmar [Mon, 1 Jan 2024 11:43:12 +0000 (17:13 +0530)]
doc/cephfs: Update disaster-recovery-experts.rst to mention Slack
Signed-off-by: Dhairya Parmar <dparmar@redhat.com>
Anthony D'Atri [Mon, 1 Jan 2024 00:30:47 +0000 (19:30 -0500)]
Merge pull request #55031 from zdover23/wip-doc-2024-01-01-mgr-nfs-mounting-windows
doc/mgr: document lack of MSWin NFS 4.x support
Zac Dover [Mon, 1 Jan 2024 00:10:42 +0000 (10:10 +1000)]
doc/mgr: document lack of MSWin NFS 4.x support
Document that no version of Microsoft Windows supports mounting an NFS
v4.x export natively, as of the time of this commit.
This commit has been made in response to an anonymous note left on
https://pad.ceph.com/p/Report_Documentation_Bugs.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Anthony D'Atri [Sun, 31 Dec 2023 14:22:51 +0000 (09:22 -0500)]
Merge pull request #55030 from zdover23/wip-doc-2023-12-31-radosgw-admin-remove-user-subuser-rewrite
doc/radosgw: edit "remove a subuser"
Zac Dover [Sun, 31 Dec 2023 06:22:33 +0000 (16:22 +1000)]
doc/radosgw: edit "remove a subuser"
Edit the English language in the section "Remove a Subuser" in
doc/radosgw/admin.rst. This commit is made in response to Matt
Benjamin's request for improvement of this section
(https://github.com/ceph/ceph/pull/55028#discussion_r1438599833).
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Sat, 30 Dec 2023 12:23:51 +0000 (22:23 +1000)]
Merge pull request #55023 from zdover23/wip-doc-2023-12-29-radosgw-admin-remove-user-subuser
doc/radosgw: edit sections
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 29 Dec 2023 08:32:04 +0000 (18:32 +1000)]
doc/radosgw: edit sections
Edit the following sections in doc/radosgw/admin.rst:
* Remove a User
* Remove a Subuser
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Ronen Friedman [Thu, 28 Dec 2023 20:48:46 +0000 (22:48 +0200)]
Merge pull request #54982 from ronen-fr/wip-rf-be-error
osd/scrub: unhandled scrub backend errors should cause an abort
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Yuri Weinstein [Thu, 28 Dec 2023 17:08:12 +0000 (09:08 -0800)]
Merge pull request #54907 from ljflores/wip-balancer-incremental
osd: fix Incremental decode for new/old_pg_upmap_primary
Reviewed-by: Josh Salomon <josh.salomon@gmail.com>
Yuri Weinstein [Thu, 28 Dec 2023 17:06:45 +0000 (09:06 -0800)]
Merge pull request #54627 from maydaycc/wip-63615
mgr: set MMgrBeacon high priority
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Yuri Weinstein [Thu, 28 Dec 2023 17:05:44 +0000 (09:05 -0800)]
Merge pull request #54194 from ifed01/wip-ifed-refresh-perf-counters
os: introduce ObjectStore::refresh_perf_counters() method
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Yuri Weinstein [Thu, 28 Dec 2023 17:05:10 +0000 (09:05 -0800)]
Merge pull request #54047 from lxbsz/wip-62081
osd: clean up the sparse-read related code
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Ilya Dryomov [Thu, 28 Dec 2023 17:03:24 +0000 (18:03 +0100)]
Merge pull request #54644 from idryomov/wip-63607
librados: make querying pools for selfmanaged snaps reliable
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
zdover23 [Thu, 28 Dec 2023 00:44:17 +0000 (10:44 +1000)]
Merge pull request #55011 from zdover23/wip-doc-2023-12-27-radosgw-admin-create-a-subuser
doc/radosgw: admin.rst - edit "Create a Subuser"
Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Ronen Friedman [Wed, 27 Dec 2023 19:15:29 +0000 (21:15 +0200)]
Merge pull request #54998 from ronen-fr/wip-rf-lmap-event
osd/scrub: remove unused PGScrubGotLocalMap message
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
zdover23 [Wed, 27 Dec 2023 14:48:20 +0000 (00:48 +1000)]
Merge pull request #55016 from zdover23/wip-doc-2023-12-27-radosgw-user-info-suspend-enable
doc/radosgw: admin.rst - edit sections
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 27 Dec 2023 12:14:59 +0000 (22:14 +1000)]
doc/radosgw: admin.rst - edit sections
Edit the following sections in doc/radosgw/admin.rst:
- Get User Info
- Modify User Info
- User Suspend/Enable (I split this into two sections)
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Nizamudeen A [Wed, 27 Dec 2023 10:30:07 +0000 (16:00 +0530)]
Merge pull request #54835 from rhcs-dashboard/directories-fixes
mgr/dashboard: small fixes to directories view
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Zac Dover [Wed, 27 Dec 2023 04:28:51 +0000 (14:28 +1000)]
doc/radosgw: admin.rst - edit "Create a Subuser"
Edit the section "Create a Subuser" in doc/radosgw/admin.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Yuri Weinstein [Tue, 26 Dec 2023 17:54:35 +0000 (09:54 -0800)]
Merge pull request #54663 from Matan-B/wip-matanb-cot-pgmeta-attrs
tools/ceph_objectstore_tool: action_on_all_objects_in_pg to skip pgmeta
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Yuri Weinstein [Tue, 26 Dec 2023 16:27:37 +0000 (08:27 -0800)]
Merge pull request #54597 from sseshasa/wip-mclk-snaptrim-cost
osd: Tune snap trim item cost to reflect a PGs' average object size for mClock scheduler
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Tue, 26 Dec 2023 16:27:02 +0000 (08:27 -0800)]
Merge pull request #54518 from NitzanMordhai/wip-nitzan-cleanomap-rados-optional
Tools/rados: Improve Error Messaging for Object Name Resolution
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
Yuri Weinstein [Tue, 26 Dec 2023 16:26:03 +0000 (08:26 -0800)]
Merge pull request #54498 from Matan-B/wip-matanb-send-inc-map-refactor
osd/OSD: rewrite send_incremental_map()
Reviewed-by: Samuel Just <sjust@redhat.com>
zdover23 [Tue, 26 Dec 2023 08:34:10 +0000 (18:34 +1000)]
Merge pull request #55003 from zdover23/wip-doc-2023-12-26-radosgw-admin-create-a-user
doc/radosgw: admin.rst - edit "Create a User"
Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Zac Dover [Tue, 26 Dec 2023 04:32:35 +0000 (14:32 +1000)]
doc/radosgw: admin.rst - edit "Create a User"
Edit the section "Create a User" in doc/radosgw/admin.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Sun, 24 Dec 2023 20:46:30 +0000 (06:46 +1000)]
Merge pull request #54997 from zdover23/wip-doc-2023-12-24-radosgw-admin-main
doc/radosgw: edit admin.rst 1 of x
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sun, 24 Dec 2023 10:24:26 +0000 (20:24 +1000)]
doc/radosgw: edit admin.rst 1 of x
Edit doc/radosgw/admin.rst to the end of the section "User Management".
Correct grammar (mostly awkward prepositions) and tidy up weird clauses.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Ronen Friedman [Sat, 23 Dec 2023 18:19:06 +0000 (12:19 -0600)]
osd/scrub: remove unused PGScrubGotLocalMap message
The relevant event (IntLocalMapDone) is processed directly within the
scrubber, instead of being queued to the OSD events queue.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Tue, 28 Nov 2023 15:46:01 +0000 (09:46 -0600)]
osd/scrub: unhandled scrub backend errors should cause an abort
... as we do not have any mechanism to handle them.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Laura Flores [Fri, 22 Dec 2023 21:39:20 +0000 (15:39 -0600)]
Merge pull request #54801 from WangWNico/balancer_project
Improve Ceph Balancer Status Output
Laura Flores [Fri, 22 Dec 2023 20:16:49 +0000 (14:16 -0600)]
Merge pull request #53191 from rzarzynski/wip-all-kickoff-s-2
kickoff v19 squid
Anthony D'Atri [Fri, 22 Dec 2023 17:51:43 +0000 (12:51 -0500)]
Merge pull request #54989 from zdover23/wip-doc-2023-12-22-radosgw-compression-supported-plugins
doc/radosgw: list supported plugins-compression.rst
Zac Dover [Fri, 22 Dec 2023 07:39:20 +0000 (17:39 +1000)]
doc/radosgw: list supported plugins-compression.rst
List supported compression plugins in doc/radosgw/compression.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
zdover23 [Thu, 21 Dec 2023 11:06:55 +0000 (21:06 +1000)]
Merge pull request #54970 from zdover23/wip-doc-2023-12-20-radosgw-compression-grammar
doc/radosgw: edit compression.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 20 Dec 2023 05:00:38 +0000 (15:00 +1000)]
doc/radosgw: edit compression.rst
Improve the grammar and simplify the sentence structure of
doc/radosgw/compression.rst. This commit is made in anticipation of a
near-future commit that will list the compression algorithms available
to users of Ceph.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Kefu Chai [Thu, 21 Dec 2023 03:04:44 +0000 (11:04 +0800)]
Merge pull request #54918 from tchaikov/cmake-build-rockdb-with-cxxflags
cmake/modules/BuildRocksDB.cmake: inherit parent's CMAKE_CXX_FLAGS
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Ronen Friedman [Wed, 20 Dec 2023 19:57:37 +0000 (21:57 +0200)]
Merge pull request #54936 from ronen-fr/wip-rf-pcnt3
osd/scrub: initial set of performance counters
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Ronen Friedman [Sun, 17 Dec 2023 18:14:53 +0000 (12:14 -0600)]
osd/scrub: collect replica reservations performance counters
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Sat, 16 Dec 2023 10:10:22 +0000 (04:10 -0600)]
test/osd: log scrub performance counters in osd-scrub-test.sh
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Sat, 16 Dec 2023 10:02:54 +0000 (04:02 -0600)]
osd/scrub: provide selected counters set to Scrubber & FSM
also - move most time keeping from the Scrubber to the FSM.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Thu, 14 Dec 2023 14:27:13 +0000 (08:27 -0600)]
osd/scrub: add a basic set of performance counters
Add a labeled set of performance counters, with the labels selecting
one of four copies of the counters - one per each scrub level and
pool type combination.
Inside the Scrubber, the relevant set of counters is selected
when the scrub is initialized.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Wed, 20 Dec 2023 16:53:27 +0000 (18:53 +0200)]
Merge pull request #54828 from ronen-fr/wip-rf-dec-fixes-1
osd/scrub: don't block high-priority scrubs on local resources
Reviewed-by: Samuel Just <sjust@redhat.com>-
Yuri Weinstein [Wed, 20 Dec 2023 15:24:11 +0000 (07:24 -0800)]
Merge pull request #54023 from Matan-B/wip-matanb-objectstore-tool-superblock
tools/ceph_objectstore_tool: Support get/set/superblock
Reviewed-by: Samuel Just <sjust@redhat.com>
Igor Fedotov [Wed, 20 Dec 2023 12:18:41 +0000 (15:18 +0300)]
Merge pull request #54195 from ifed01/wip-ifed-silent-warns
core: silent a couple of compiler warnings on uninitialized vars.
Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
NitzanMordhai [Wed, 20 Dec 2023 07:43:03 +0000 (09:43 +0200)]
Merge pull request #52871 from NitzanMordhai/wip-nitzan-ceph-dencoder-extend-osd-type-available
ceph-dencoder: OSD - Add missing types
NitzanMordhai [Wed, 28 Jun 2023 09:57:11 +0000 (09:57 +0000)]
ceph-dencoder: osd - Add missing types
Currently, ceph-dencoder lacks certain osd types, preventing us from accurately checking the ceph corpus for encode-decode mismatches.
This pull request aims to address this issue by adding the missing types to ceph-dencoder.
To successfully incorporate these types into ceph-dencoder, we need to introduce the necessary `dump` and `generate_test_instances`
functions that was missing in some types. These functions are essential for proper encode and decode of the added types.
This PR will enhance the functionality of ceph-dencoder by including the missing types, enabling a comprehensive analysis of encode-decode consistency.
With the addition of these types, we can ensure the robustness and correctness of the ceph corpus.
This update will significantly contribute to improving the overall reliability and accuracy of ceph-dencoder.
It allows for a more comprehensive assessment of the encode-decode behavior, leading to enhanced data integrity and stability within the ceph ecosystem.
Fixes: https://tracker.ceph.com/issues/61788
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
Kefu Chai [Wed, 20 Dec 2023 02:14:38 +0000 (10:14 +0800)]
Merge pull request #54916 from tchaikov/cmake-boost-workaround
cmake: only apply workaround for boost < 1.84
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Kefu Chai [Wed, 20 Dec 2023 02:14:17 +0000 (10:14 +0800)]
Merge pull request #54919 from tchaikov/cmake-boost-1.84
cmake: add 1.82 and 1.83 to known versions
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Yuri Weinstein [Tue, 19 Dec 2023 23:00:22 +0000 (15:00 -0800)]
Merge pull request #53591 from EdwardVitor/fix-makecheck-warning
kv: resolve three compilation warnings
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Yuri Weinstein [Tue, 19 Dec 2023 22:59:25 +0000 (14:59 -0800)]
Merge pull request #53524 from sseshasa/wip-fix-osd-op-queue-rndmize-62171
osd: Apply randomly selected scheduler type across all OSD shards
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Tue, 19 Dec 2023 22:57:48 +0000 (14:57 -0800)]
Merge pull request #53228 from rzarzynski/wip-bug-62645
common/weighted_shuffle: don't feed std::discrete_distribution with all-zero weights
Reviewed-by: Neha Ojha <nojha@redhat.com>
Ilya Dryomov [Tue, 19 Dec 2023 21:12:15 +0000 (22:12 +0100)]
Merge pull request #54953 from ljflores/wip-fix-18.2.1-doc
doc/releases: specify dashboard improvements
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Laura Flores [Mon, 18 Dec 2023 21:09:43 +0000 (15:09 -0600)]
doc/releases: specify dashboard improvements
...and address other nits
Signed-off-by: Laura Flores <lflores@ibm.com>
Yuval Lifshitz [Tue, 19 Dec 2023 17:57:47 +0000 (19:57 +0200)]
Merge pull request #54935 from yuvalif/wip-yuval-return-lua-devel
build/rgw/lua: return lua-devel runtime dependency
reviewed-by: cbodley
Nizamudeen A [Tue, 19 Dec 2023 13:48:20 +0000 (19:18 +0530)]
Merge pull request #54710 from kalaspuffar/replace_jwt_with_pure_python
mgr/dashboard: Simplify authentication protocol
Reviewed-by: Fabian-Gruenbichler <NOT@FOUND>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Adam Kupczyk [Tue, 19 Dec 2023 13:40:18 +0000 (14:40 +0100)]
Merge pull request #54897 from aclamk/wip-aclamk-bs-fix-esb-multichunk-alloc
os/bluestore: Fix assert() caused by ESB
Matan Breizman [Tue, 19 Dec 2023 10:12:53 +0000 (12:12 +0200)]
Merge pull request #54609 from xxhdx1985126/wip-crimson-rollback-fixes
crimson/osd/pg_backend: fix rollback on whiteouts
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
zdover23 [Tue, 19 Dec 2023 09:53:04 +0000 (19:53 +1000)]
Merge pull request #54960 from zdover23/wip-doc-2023-12-19-install-clone-source-submodule-update
doc/install: update "update submodules"
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Zac Dover [Tue, 19 Dec 2023 09:15:57 +0000 (19:15 +1000)]
doc/install: update "update submodules"
Remove misleading material that would give readers the wrong idea about
when stale submodules are present. This commit is made in response to
information given to me by Ilya Dryomov here: https://github.com/ceph/ceph/pull/54929#issuecomment-
1859237986 .
Signed-off-by: Zac Dover <zac.dover@proton.me>
Nizamudeen A [Thu, 7 Dec 2023 17:28:52 +0000 (22:58 +0530)]
mgr/dashboard: small fixes to directories view
Increased the precedence for Directories
Expand the node by default and select them as well
Fixes: https://tracker.ceph.com/issues/63754
Signed-off-by: Nizamudeen A <nia@redhat.com>
Xuehan Xu [Wed, 22 Nov 2023 05:16:36 +0000 (13:16 +0800)]
crimson/osd/pg_backend: whiteout objects if they will have clones when
rolling back
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Kefu Chai [Tue, 19 Dec 2023 04:57:41 +0000 (12:57 +0800)]
Merge pull request #54917 from tchaikov/cmake-cephfs-sans-libcephfs
cmake: differentiate WITH_CEPHFS from WITH_LIBCEPHFS
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Samuel Just [Tue, 19 Dec 2023 01:37:26 +0000 (17:37 -0800)]
Merge pull request #54931 from athanatos/sjust/wip-crimson-2023-12-13-fixes
crimson: misc fixes
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Laura Flores [Mon, 18 Dec 2023 20:57:53 +0000 (14:57 -0600)]
Merge pull request #54506 from ceph/wip-yuriw-release-18.2.1-main
doc: Add Reef 18.2.1 release notes
Casey Bodley [Mon, 18 Dec 2023 18:28:45 +0000 (18:28 +0000)]
Merge pull request #52495 from adamemerson/wip-neorados-learning-from-experience
neorados: Learning from experience
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Matan Breizman [Sun, 19 Nov 2023 15:19:29 +0000 (15:19 +0000)]
osd/OSD: rewrite build_incremental_map_msg()
* use lambda to maintain size limits.
* avoid copying by std::move the bl into the message.
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Mon, 18 Dec 2023 14:36:49 +0000 (16:36 +0200)]
Merge pull request #53227 from Matan-B/wip-matanb-cleanup-stale-osdmap
osd/OSD: introduce trim_stale_maps
Reviewed-by: Samuel Just <sjust@redhat.com>
Matan Breizman [Thu, 16 Nov 2023 11:38:51 +0000 (11:38 +0000)]
osd/OSD: send_incremental_map fix log message
from:
```
send_incremental_map 88 -> 88 to 0xab1c880 v2:172.21.5.151:6820/
252144826
send_incremental_map 89 -> 89 to 0xab1a900 v2:172.21.5.151:6812/
1097023676
```
to:
```
send_incremental_map epoch range: (75, 75] to osd.1 v2:172.21.5.151:6812/
3634942927
send_incremental_map epoch range: (76, 77] to osd.1 v2:172.21.5.151:6812/
3634942927
send_incremental_map epoch range: (78, 78] to osd.1 v2:172.21.5.151:6812/
3634942927
```
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Thu, 16 Nov 2023 11:06:56 +0000 (11:06 +0000)]
osd/OSD: send_incremental_map pass correct send_from
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Thu, 16 Nov 2023 10:24:51 +0000 (10:24 +0000)]
osd/OSD: remove unused send_map()
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Thu, 16 Nov 2023 10:24:29 +0000 (10:24 +0000)]
osd/OSD: further cleanup send_incremental_map()
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Thu, 16 Nov 2023 10:19:51 +0000 (10:19 +0000)]
osd/OSD: optimize send_incremental_map
Previosuly, if `since` was earlier than the oldest_map,
only the lastest full osdmap would be sent.
However, we could actually send inc/full maps from oldest_map
up to the current epoch.
Moreover, build_incremental_map_msg is suited to handle this case as well.
if `since` is earlier than `cluster_osdmap_trim_lower_bound` it
will be adjusted accordingly.
At any point, the cluster_osdmap_trim_lower_bound is later (or equal) to
the superblock's oldest_map. See: past_intervals.rst (OSDSuperblock::maps)
Hence, if since < oldest_map, and oldest_map <= clutser_lower_bound
then since < cluster_lower_bound.
Note: oldest_map stands as a mark to indicate up until which epoch
the current OSD trimmed its osdmaps. See OSD::trim_maps().
Meaning, the OSDMaps in the range of [oldest_map, trim_lower_bound]
may be at hand to be shared. Nevertheless, we should actually use
the cluster_trim_lower_bound to set the correct range.
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Tue, 14 Nov 2023 14:36:58 +0000 (14:36 +0000)]
osd/OSD: cleanup send_incremental_map
See:
9fba69a11aa940ed36339bb24b05cb92165db516
build_incremental_map_msg() no longer returns NULL on failures.
while(!m) if-case is removed.
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Thu, 26 Oct 2023 10:18:59 +0000 (10:18 +0000)]
qa/tasks/ceph_manager: thrash - add trim stale osdmaps
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Wed, 30 Aug 2023 08:57:18 +0000 (08:57 +0000)]
osd/OSD: introduce trim_stale_maps
```
/**
* trim_stale_maps
*
* trim_maps had a possible (rare) leak which resulted in stale osdmaps.
* This method will cleanup any existing osdmaps from the store
* with an epoch earlier than the superblock's oldest_map epoch.
* See: https://tracker.ceph.com/issues/61962
*/
```
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Kefu Chai [Fri, 15 Dec 2023 10:18:01 +0000 (18:18 +0800)]
cmake: differentiate WITH_CEPHFS from WITH_LIBCEPHFS
WITH_CEPHFS is used for enabling the server side of cephfs, i.e., mds,
while WITH_LIBCEPHFS is for the client side of it, namely libcephfs
and its python bindings. since we have these two different options,
in theory, user is allowed to build with WITH_CEPHFS=ON and
WITH_LIBCEPHFS=OFF, and in that case, `vstart` should not depend on
the non-existent target of cephfs and cython_cephfs. the same applies to
the build of cython_cephfs. this is an unusual combination, but
it is a valid one.
in this change, we
* build the python binding only if WITH_LIBCEPHFS is ON
* add cephfs and cython_cephfs as dependencies of vstart only if
WITH_LIBCEPHFS is ON
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Mon, 18 Dec 2023 07:16:38 +0000 (15:16 +0800)]
cmake: add deps to vstart and vstart-base with loop
so we don't have to repeat the settings enabling a given target
when adding the deps to vstart and vstart-base
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
zdover23 [Mon, 18 Dec 2023 04:19:58 +0000 (14:19 +1000)]
Merge pull request #54929 from dann1/main
doc: Improve documentation regarding OpenNebula integration with ceph
Reviewed-by: Zac Dover <zac.dover@proton.me>
Kefu Chai [Mon, 18 Dec 2023 02:25:54 +0000 (10:25 +0800)]
Merge pull request #54937 from gruenich/feature/cmake-drop-redundant-policies
cmake: Do not set CMake policy to new that are set anyway
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Daniel Clavijo Coca [Fri, 15 Dec 2023 15:54:02 +0000 (09:54 -0600)]
docs: Add information about OpenNebula integration
- Exclude doc build output from git
- Fix missing doc build dependency
- Also includes some involuntary automatically persistent linting by vscode
Co-authored-by: Ilya Dryomov <idryomov@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Co-authored-by: Zac Dover <zac.dover@proton.me>
Signed-off-by: Daniel Clavijo <dclavijo@opennebula.io>
Christoph Grüninger [Sun, 17 Dec 2023 21:18:43 +0000 (22:18 +0100)]
cmake: Do not set CMake policy to new that are set anyway
CMP0097 and below are all implicitly set to new because
the minimum required CMake version is 3.16 and these
policies are older.
Signed-off-by: Christoph Grüninger <foss@grueninger.de>
Yuval Lifshitz [Sun, 17 Dec 2023 16:29:41 +0000 (18:29 +0200)]
Merge pull request #52474 from vedanshbhartia/coverity_1515850
rgw: Fix potential null dereference in rgw/driver/dbstore/sqlite/statement.cc
reviewed-by: thotz, yuvalif
Yuval Lifshitz [Sun, 17 Dec 2023 16:29:01 +0000 (18:29 +0200)]
Merge pull request #52276 from vedanshbhartia/coverity_1523402
rgw: Add a wrapper for librados::AioCompletion to prevent memory leaks
reviewed-by: cbodley, yuvalif
Yuval Lifshitz [Sun, 17 Dec 2023 16:27:27 +0000 (18:27 +0200)]
Merge pull request #53902 from vedanshbhartia/coverity_except_main
rgw: Add coverity annotations for uncaught exceptions in standalone binaries
reviewed-by: yuvalif
Yuval Lifshitz [Tue, 12 Dec 2023 08:11:57 +0000 (08:11 +0000)]
build/rgw/lua: return lua-devel runtime dependency
reverting:
b0a77a53ab86b9b24a2cfb46049957d40a8c80aa
after sepia lab issue is resolved
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
Ilya Dryomov [Sun, 17 Dec 2023 10:27:11 +0000 (11:27 +0100)]
Merge pull request #54547 from idryomov/wip-53897
librbd: don't report HOLE_UPDATED when diffing against a hole
Reviewed-by: Mykola Golub <mgolub@suse.com>
Yuval Lifshitz [Sun, 17 Dec 2023 10:12:48 +0000 (12:12 +0200)]
Merge pull request #54569 from AliMasarweh/wip-alimasa-multi-pubsub-etag
RGW: pubsub publish commit with etag populated
revieweed-by: cbodley, yuvalif
Anthony D'Atri [Sat, 16 Dec 2023 19:11:54 +0000 (14:11 -0500)]
Merge pull request #52354 from bluikko/patch-13
doc/radosgw/admin.rst: use underscores in config var names
Casey Bodley [Sat, 16 Dec 2023 16:25:14 +0000 (16:25 +0000)]
Merge pull request #54888 from cbodley/wip-rgw-multisite-forward-empty-buffer
rgw/multisite: forwarded requests always pass a bufferlist
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Casey Bodley [Sat, 16 Dec 2023 16:24:57 +0000 (16:24 +0000)]
Merge pull request #54739 from cbodley/wip-qa-rgw-upgrade-distros
qa/rgw/upgrade: stop testing upgrade from pacific
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Samuel Just [Sat, 16 Dec 2023 00:26:30 +0000 (00:26 +0000)]
crimson/.../client_request_common: skip non-existent oids in recover_missings
See comment.
Introduced:
38cc750f
Fixes: https://tracker.ceph.com/issues/63821
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Thu, 14 Dec 2023 06:41:00 +0000 (22:41 -0800)]
crimson/.../client_request_common: simplify recover_missings
- Modify ClientRequest::snaps_need_to_recover() to return all
relevant snaps including the operation target.
- Update ClientRequest::snaps_need_to_recover() and
CommonClientRequest::recover_missings to use set::set
for snaps.
- Remove special handling for soid from
CommonClientRequest::recover_missings
- Simplify CommonClientRequest::recover_missings.
Signed-off-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Tue, 14 Nov 2023 21:14:46 +0000 (13:14 -0800)]
doc: Add Reef 18.2.1 release notes
Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
Signed-off-by: Laura Flores <lflores@ibm.com>
Casey Bodley [Fri, 15 Dec 2023 18:34:25 +0000 (18:34 +0000)]
Merge pull request #54841 from cbodley/wip-rgw-multisite-rados-crash
rgw/multisite: error repo coroutines store raw_obj by value
Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Casey Bodley [Fri, 15 Dec 2023 16:40:07 +0000 (16:40 +0000)]
Merge pull request #54920 from tchaikov/cls-2pc-reserv-dencode
cls/queue: always set member variables in ctor
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Kefu Chai [Fri, 15 Dec 2023 12:20:46 +0000 (20:20 +0800)]
cls/queue: always set member variables in ctor
this should address the test failures like
```
/tmp/typ-WWFeFl6yK /tmp/typ-sMfwoaGMU differ: byte 24, line 1
**** cls_2pc_reservation test 2 binary reencode check failed ****
ceph-dencoder type cls_2pc_reservation select_test 2 encode export /tmp/typ-WWFeFl6yK
ceph-dencoder type cls_2pc_reservation select_test 2 encode decode encode export /tmp/typ-sMfwoaGMU
2c2
<
00000010 00 00 00 00 00 00 c0 c6 92 10 |..........|
---
>
00000010 00 00 00 00 00 00 c0 e6 cd 53 |.........S|
```
where we
1. encode the 2nd sample created by `generate_test_instances()`,
2. encode, decode, and encode again, the same sample
and compare the encoded blobs.
but if we fail to set any of the fields in `cls_2pc_reservation`,
we are at the mercy of the random bits on stack/heap.
in this change, all bits are initialized.
the flaky test was introduced by
1d7cabf3
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Patrick Donnelly [Fri, 15 Dec 2023 13:18:28 +0000 (08:18 -0500)]
Merge PR #52196 into main
* refs/pull/52196/head:
qa: configure balancer for multi-mds workloads
qa: create qa subvolumes in named subvolumegroup
qa: do not rely on default max_mds value
qa: add automate_balance to dashboard qa schema
doc/cephfs: add docs for balance_automate
doc/cephfs: use bash prompt for shell code
mds: add balance_automate fs setting
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Kefu Chai [Fri, 15 Dec 2023 09:28:37 +0000 (17:28 +0800)]
cmake: add 1.82 and 1.83 to known versions
this change should silence the warning when building Ceph with Boost 1.82:
```
CMake Warning at cmake/modules/FindBoost.cmake:1384 (message):
New Boost version may have incorrect or missing dependencies and imported
targets
Call Stack (most recent call first):
cmake/modules/FindBoost.cmake:1507 (_Boost_COMPONENT_DEPENDENCIES)
cmake/modules/FindBoost.cmake:2125 (_Boost_MISSING_DEPENDENCIES)
CMakeLists.txt:687 (find_package)
```
despite that
244c5ebb added boost to `_Boost_KNOWN_VERSIONS`, it was
not enough. would be better to sync up the CMake upstream for an updated
version of this file like we did before.
in this change
* syncs this file with
https://github.com/Kitware/CMake/blob/
897a149067b84375d094700632255c0b54f5e44c /Modules/FindBoost.cmak
* re-apply the change of
06824bc1ecbe68b6809c1f47f0f5d636842746b5
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
cmake: adapt FindBoost.cmake to our needs
the vanilla FindBoost.cmake pulled from cmake has couple assumptions
which do not hold in our environment. so address them case by case.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Fri, 15 Dec 2023 11:03:57 +0000 (19:03 +0800)]
cmake/modules/BuildRocksDB.cmake: inherit parent's CMAKE_CXX_FLAGS
CMake allows us to customize `CMAKE_CXX_FLAGS` by setting CXXFLAGS
environmental variable. and Debian's debhelper also sets CXXFLAGS
when it builds cmake projects for customizing the building flags.
but we fail to populate this setting down when building external
projects. this is important when it comes to the projects which
is critical to the performance. RocksDB is one of them.
in this change, we pass the `CMAKE_CXX_FLAGS` down in
`BuildRocksDB.cmake` so that its `CMAKE_CXX_FLAGS` contains
the same set of `CMAKE_CXX_FLAGS` used by its parent project.
this should help with the performance in the bluestore, where
RocksDB is used.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Fri, 15 Dec 2023 11:01:46 +0000 (19:01 +0800)]
cmake/modules/BuildRocksDB.cmake: use string(APPEND ..) when appropriate
less repeatings this way.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>