]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
17 months agobug fixes per QE recent defects 55183/head
galsalomon66 [Mon, 15 Jan 2024 14:38:19 +0000 (16:38 +0200)]
bug fixes per QE recent defects
update for the engine_version message
s3select submodule

Signed-off-by: galsalomon66 <gal.salomon@gmail.com>
18 months agoMerge PR #54041 into main
Venky Shankar [Wed, 17 Jan 2024 14:29:22 +0000 (19:59 +0530)]
Merge PR #54041 into main

* refs/pull/54041/head:
qa: fix error reporting string in assert_cluster_log

Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
18 months agoMerge pull request #55105 from ronen-fr/wip-rf-nonorecovery
Ronen Friedman [Wed, 17 Jan 2024 12:02:26 +0000 (14:02 +0200)]
Merge pull request #55105 from ronen-fr/wip-rf-nonorecovery

osd/scrub: allow replicas to scrub even if their OSDs have ongoing backfills

Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
18 months agoMerge pull request #54070 from rhcs-dashboard/add-multisite-sync-status-unit-tests
Pedro Gonzalez Gomez [Wed, 17 Jan 2024 10:03:03 +0000 (11:03 +0100)]
Merge pull request #54070 from rhcs-dashboard/add-multisite-sync-status-unit-tests

mgr/dashboard: add frontend unit tests for rgw multisite sync status card

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
18 months agoMerge pull request #54765 from Matan-B/wip-matanb-crimson-submit-error-cleanup
Matan Breizman [Wed, 17 Jan 2024 09:39:38 +0000 (11:39 +0200)]
Merge pull request #54765 from Matan-B/wip-matanb-crimson-submit-error-cleanup

crimson/osd: submit_error_log cleanup

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
18 months agoMerge pull request #55171 from Matan-B/wip-matanb-crimson-return-no-supp
Matan Breizman [Wed, 17 Jan 2024 08:51:37 +0000 (10:51 +0200)]
Merge pull request #55171 from Matan-B/wip-matanb-crimson-return-no-supp

crimson/osd/osd_operations/client_request: return OpInfo errors

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
18 months agoMerge pull request #55175 from ronen-fr/wip-rf-max-test-options
Ronen Friedman [Wed, 17 Jan 2024 08:48:33 +0000 (10:48 +0200)]
Merge pull request #55175 from ronen-fr/wip-rf-max-test-options

qa/suites/rados/thrash: modify selection of max-scrubs configuration values

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
18 months agoMerge pull request #55189 from zhscn/fix-clone-indiect-mapping
Yingxin [Wed, 17 Jan 2024 08:20:30 +0000 (16:20 +0800)]
Merge pull request #55189 from zhscn/fix-clone-indiect-mapping

crimson/os/seastore: correct the parameter passed to LBAManager::clone_mapping

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
18 months agoMerge pull request #55115 from ljflores/wip-tracker-63967
Laura Flores [Tue, 16 Jan 2024 19:07:10 +0000 (13:07 -0600)]
Merge pull request #55115 from ljflores/wip-tracker-63967

qa/tasks: fix syntax for deep-scrub command

18 months agoMerge pull request #54966 from yuvalif/wip-yuval-63855
Yuval Lifshitz [Tue, 16 Jan 2024 14:12:31 +0000 (16:12 +0200)]
Merge pull request #54966 from yuvalif/wip-yuval-63855

rgw/notifications: dont send notifications if op has failed

reviewed-by: cbodley

18 months agoMerge pull request #55169 from zdover23/wip-doc-2024-01-14-radosgw-admin-enable-disab...
zdover23 [Tue, 16 Jan 2024 13:51:29 +0000 (23:51 +1000)]
Merge pull request #55169 from zdover23/wip-doc-2024-01-14-radosgw-admin-enable-disable-user-rate-limit

docs/radosgw: edit admin.rst "enable/disable user rate limit"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
18 months agoMerge pull request #55148 from cbodley/wip-63994
Casey Bodley [Tue, 16 Jan 2024 13:22:30 +0000 (13:22 +0000)]
Merge pull request #55148 from cbodley/wip-63994

rgw: fix use of creds in forward_iam_request()

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
18 months agoMerge pull request #54803 from rhcs-dashboard/increase-plottable-graphs-dashboard
Pedro Gonzalez Gomez [Tue, 16 Jan 2024 13:15:48 +0000 (14:15 +0100)]
Merge pull request #54803 from rhcs-dashboard/increase-plottable-graphs-dashboard

mgr/dashboard: increase the number of plottable graphs in charts

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
18 months agocrimson/osd/osd_operations/client_request: return OpInfo errors 55171/head
Matan Breizman [Sun, 14 Jan 2024 12:33:52 +0000 (12:33 +0000)]
crimson/osd/osd_operations/client_request: return OpInfo errors

See NeoRadosCls.DNE or LibRadosCls.DNE

Fixes: https://tracker.ceph.com/issues/64000
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agocrimson/osd/pg: move maybe_submit_error_log 54765/head
Matan Breizman [Wed, 20 Dec 2023 08:29:45 +0000 (08:29 +0000)]
crimson/osd/pg: move maybe_submit_error_log

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agocrimson/osd/pg: on_removal to assert empty log_entry map
Matan Breizman [Thu, 30 Nov 2023 14:57:06 +0000 (14:57 +0000)]
crimson/osd/pg: on_removal to assert empty log_entry map

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agocrimson/osd/pg: submit_error_log cleanup
Matan Breizman [Thu, 7 Dec 2023 13:48:02 +0000 (13:48 +0000)]
crimson/osd/pg: submit_error_log cleanup

* error log completion logic is moved into maybe_submit_error_log
* renamed it and it2
* maybe_submit_error_log is moved outside of failure_func
* failure_func no longer gets rep_tid and record_error params
* log_entry_version is removed, submit_error_log returns the version instead

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agocrimson/osd/pg: do_osd_ops_execute drop error_func_ptr
Matan Breizman [Sun, 3 Dec 2023 10:27:23 +0000 (10:27 +0000)]
crimson/osd/pg: do_osd_ops_execute drop error_func_ptr

std::move to the only user instead

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agoMerge pull request #54484 from batrick/mds-const-mdreqref
Rishabh Dave [Tue, 16 Jan 2024 12:18:21 +0000 (17:48 +0530)]
Merge pull request #54484 from batrick/mds-const-mdreqref

mds: use const qualifier for MDRequestRef

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
18 months agoMerge pull request #54390 from shminjs/feat-purgequeue-executed-ops
Rishabh Dave [Tue, 16 Jan 2024 12:17:21 +0000 (17:47 +0530)]
Merge pull request #54390 from shminjs/feat-purgequeue-executed-ops

mds/purgequeue: add l_pq_executed_ops counter

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
18 months agoMerge pull request #53670 from mchangir/mds-enqueue-all-child-frags-for-scrub-for...
Rishabh Dave [Tue, 16 Jan 2024 12:16:08 +0000 (17:46 +0530)]
Merge pull request #53670 from mchangir/mds-enqueue-all-child-frags-for-scrub-for-a-given-fragset

mds/scrub: enqueue all child frags for a given fragset

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
18 months agoMerge pull request #54208 from neesingh-rh/json_asok_fix
Rishabh Dave [Tue, 16 Jan 2024 12:15:09 +0000 (17:45 +0530)]
Merge pull request #54208 from neesingh-rh/json_asok_fix

qa: fix rank_asok() to handle errors from asok commands

Reviewed-by: Kotresh HR <khiremat@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
18 months agoMerge pull request #54381 from lxbsz/wip-cleanup-auth
Rishabh Dave [Tue, 16 Jan 2024 12:14:04 +0000 (17:44 +0530)]
Merge pull request #54381 from lxbsz/wip-cleanup-auth

mds: misc fixes for MDSAuthCaps code

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
18 months agoMerge pull request #54406 from vshankar/wip-63482
Rishabh Dave [Tue, 16 Jan 2024 12:12:37 +0000 (17:42 +0530)]
Merge pull request #54406 from vshankar/wip-63482

qa: enable debug mds/client for fs/nfs suite

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
18 months agoMerge pull request #54519 from lxbsz/wip-63552
Rishabh Dave [Tue, 16 Jan 2024 12:10:59 +0000 (17:40 +0530)]
Merge pull request #54519 from lxbsz/wip-63552

mds: use explicitly sized types for network and disk encoding

Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
18 months agoMerge pull request #54590 from vshankar/wip-57087
Rishabh Dave [Tue, 16 Jan 2024 12:09:21 +0000 (17:39 +0530)]
Merge pull request #54590 from vshankar/wip-57087

qa: set mds config with `config set` for a particular test

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
18 months agoMerge pull request #55185 from rhcs-dashboard/docs-build-fix
Nizamudeen A [Tue, 16 Jan 2024 12:05:23 +0000 (17:35 +0530)]
Merge pull request #55185 from rhcs-dashboard/docs-build-fix

admin/doc-requirements: bump Sphinx to 5.0.2

Reviewed-by: Matan-B <NOT@FOUND>
18 months agomgr/dashboard: add frontend unit tests for rgw multisite sync status 54070/head
Aashish Sharma [Wed, 18 Oct 2023 08:23:51 +0000 (13:53 +0530)]
mgr/dashboard: add frontend unit tests for rgw multisite sync status
card

Fixes: https://tracker.ceph.com/issues/64039
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
18 months agoadmin/doc-requirements: bump Sphinx to 5.0.2 55185/head
Nizamudeen A [Tue, 16 Jan 2024 05:21:56 +0000 (10:51 +0530)]
admin/doc-requirements: bump Sphinx to 5.0.2

```
Running Sphinx v4.5.0

Sphinx version error:
The sphinxcontrib.applehelp extension used by this project needs at least Sphinx v5.0; it therefore cannot be built with this version.
```

Signed-off-by: Nizamudeen A <nia@redhat.com>
18 months agocrimson/os/seastore: correct the parameter passed to LBAManager::clone_mapping 55189/head
Zhang Song [Tue, 16 Jan 2024 08:13:03 +0000 (16:13 +0800)]
crimson/os/seastore: correct the parameter passed to LBAManager::clone_mapping

Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
18 months agoMerge pull request #55143 from afreen23/main
Nizamudeen A [Tue, 16 Jan 2024 07:49:20 +0000 (13:19 +0530)]
Merge pull request #55143 from afreen23/main

mgr/dashboard: Fixes multisite topology page breadcrumb

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
18 months agoMerge pull request #54645 from rhcs-dashboard/revert-tls-1.2-main
Nizamudeen A [Tue, 16 Jan 2024 06:34:18 +0000 (12:04 +0530)]
Merge pull request #54645 from rhcs-dashboard/revert-tls-1.2-main

Revert "mgr/dashboard: allow tls 1.2 with a config option"

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
18 months agoMerge pull request #55120 from rhcs-dashboard/snapshot-delete
Pedro Gonzalez Gomez [Mon, 15 Jan 2024 10:19:32 +0000 (11:19 +0100)]
Merge pull request #55120 from rhcs-dashboard/snapshot-delete

mgr/dashboard: delete cephfs snapshot

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
18 months agomgr/dashboard: increase the number of plottable graphs in charts 54803/head
Aashish Sharma [Tue, 5 Dec 2023 05:58:25 +0000 (11:28 +0530)]
mgr/dashboard: increase the number of plottable graphs in charts

Fixes: https://tracker.ceph.com/issues/64024
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
18 months agotest/scrub: modify selection of max-scrubs configuration values 55175/head
Ronen Friedman [Sun, 14 Jan 2024 18:53:38 +0000 (20:53 +0200)]
test/scrub: modify selection of max-scrubs configuration values

As the osd-max-scrubs default was increased from 1 to (currently) 3, the
original set of optional values under rados/thrash/3-scrub-overrides are
no longer useful.  This commits changes the set of optional values to
reflect the current default.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
18 months agoMerge pull request #54974 from fweimer-rh/c99
Ilya Dryomov [Sun, 14 Jan 2024 17:54:12 +0000 (18:54 +0100)]
Merge pull request #54974 from fweimer-rh/c99

GCC 14 compatibility fixes

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #55039 from cyx1231st/wip-crimson-alienstore-submit-concurrently
Matan Breizman [Sun, 14 Jan 2024 08:37:08 +0000 (10:37 +0200)]
Merge pull request #55039 from cyx1231st/wip-crimson-alienstore-submit-concurrently

crimson/os/alienstore: submit from the alien world concurrently

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
18 months agodocs/radosgw: edit admin.rst "enable/disable user rate limit" 55169/head
Zac Dover [Sat, 13 Jan 2024 18:06:12 +0000 (04:06 +1000)]
docs/radosgw: edit admin.rst "enable/disable user rate limit"

Edit "Enable/Disable User Rate Limit" in doc/radosgw/admin.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
18 months agorgw/common: rgw_bl_str(bl) avoids bl.c_str() 55148/head
Casey Bodley [Fri, 12 Jan 2024 16:19:11 +0000 (11:19 -0500)]
rgw/common: rgw_bl_str(bl) avoids bl.c_str()

where bl contains multiple buffer segments, c_str() has to
rellocate and copy those segments into a single buffer. use c_str()
instead, which just copies each segment into the resulting string

this allows the function to take the bufferlist argument by const ref

Signed-off-by: Casey Bodley <cbodley@redhat.com>
18 months agorgw: forward_iam_request_to_master() trims trailing null from response
Casey Bodley [Fri, 12 Jan 2024 16:08:38 +0000 (11:08 -0500)]
rgw: forward_iam_request_to_master() trims trailing null from response

fix a regression from commit d3ad0efaee6a19c84b2af9b3dfa1b6c902674774
which changed how we parse the response bufferlist:

-  std::string r = response.c_str();
+  std::string r = response.to_str();

when the response contains a trailing null character, this now ends up in
`r` and breaks json parsing in `parser.parse(r.c_str(), r.length(), 1)`

replace `response.to_str()` with `rgw_bl_str(response)` which trims
trailing nulls

Signed-off-by: Casey Bodley <cbodley@redhat.com>
18 months agotest/rgw: metadata sync checkpoint waits on global 'sync' status
Casey Bodley [Fri, 12 Jan 2024 16:05:48 +0000 (11:05 -0500)]
test/rgw: metadata sync checkpoint waits on global 'sync' status

in testing, i was seeing meta sync checkpoints finish even though sync
hadn't started yet:
```
rgw_multi.tests: DEBUG: current meta sync status={
    "sync_status": {
        "info": {
            "status": "building-full-sync-maps",
```

wait for the global status to reach "sync" before starting to compare
period epochs or sync markers

Signed-off-by: Casey Bodley <cbodley@redhat.com>
18 months agomgr/dashboard: delete cephfs snapshot 55120/head
Nizamudeen A [Wed, 10 Jan 2024 06:42:23 +0000 (12:12 +0530)]
mgr/dashboard: delete cephfs snapshot

Fixes: https://tracker.ceph.com/issues/63990
Signed-off-by: Nizamudeen A <nia@redhat.com>
18 months agocrimson/os/alienstore: submit from the alien world concurrently 55039/head
Yingxin Cheng [Wed, 27 Dec 2023 05:16:11 +0000 (13:16 +0800)]
crimson/os/alienstore: submit from the alien world concurrently

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
18 months agoMerge pull request #53678 from cbodley/wip-qa-rgw-upgrade-reef
Casey Bodley [Thu, 11 Jan 2024 16:08:24 +0000 (16:08 +0000)]
Merge pull request #53678 from cbodley/wip-qa-rgw-upgrade-reef

qa/rgw/upgrade: add reef as a starting release

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
18 months agorgw: fix use of creds in forward_iam_request()
Casey Bodley [Thu, 11 Jan 2024 15:28:01 +0000 (10:28 -0500)]
rgw: fix use of creds in forward_iam_request()

variable `creds` was moved into the `RGWRESTConn` constructor before being
passed into `forward_iam_request()`. change `forward_iam_request()` so
it uses the member variable from the constructor instead of taking it as
an argument

Fixes: https://tracker.ceph.com/issues/63994
Signed-off-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54882 from Svelar/isa_xor_dev
Mark Nelson [Thu, 11 Jan 2024 15:10:44 +0000 (09:10 -0600)]
Merge pull request #54882 from Svelar/isa_xor_dev

erasure-code/isa/xor_op: add neon-based region_xor implementation

18 months agoMerge pull request #55142 from zdover23/wip-doc-2024-01-11-radosgw-user-rate-limit-ops
Anthony D'Atri [Thu, 11 Jan 2024 14:30:47 +0000 (09:30 -0500)]
Merge pull request #55142 from zdover23/wip-doc-2024-01-11-radosgw-user-rate-limit-ops

doc/radosgw - edit admin.rst "set user rate limit"

18 months agoMerge pull request #55146 from zdover23/wip-doc-2024-01-11-radosgw-get-user-rate...
Anthony D'Atri [Thu, 11 Jan 2024 14:21:29 +0000 (09:21 -0500)]
Merge pull request #55146 from zdover23/wip-doc-2024-01-11-radosgw-get-user-rate-limit

doc/radosgw: edit admin.rst "get user rate limit"

18 months agodoc/radosgw: edit admin.rst "get user rate limit" 55146/head
Zac Dover [Thu, 11 Jan 2024 13:40:25 +0000 (23:40 +1000)]
doc/radosgw: edit admin.rst "get user rate limit"

Edit "Get User Rate Limit" in doc/radosgw/admin.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
18 months agomgr/dashboard: Fixes multisite topology page breadcrumb 55143/head
Afreen Misbah [Thu, 11 Jan 2024 07:49:39 +0000 (13:19 +0530)]
mgr/dashboard: Fixes multisite topology page breadcrumb

The multi-site topology page just says object in breadcrumb.
The fix adds the missing "multi-site" breadcrumb.

Fixes https://tracker.ceph.com/issues/63635

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
18 months agodoc/radosgw - edit admin.rst "set user rate limit" 55142/head
Zac Dover [Thu, 11 Jan 2024 08:32:09 +0000 (18:32 +1000)]
doc/radosgw - edit admin.rst "set user rate limit"

Edit "Set User Rate Limit" in doc/radosgw/admin.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
18 months agoMerge PR #53999 into main
Milind Changire [Thu, 11 Jan 2024 05:01:31 +0000 (10:31 +0530)]
Merge PR #53999 into main

* refs/pull/53999/head:
PendingReleaseNotes: support for subvolumes and subvolume groups in snap_schedule
snap_schedule/tests: fix db upgrade issue
qa: add yaml for on demand subvol version testing
qa: add test cases for testing --subvol and --group arguments
mgr/volumes: conditionalize subvolume upgrade
mgr/volumes: ensure correct init of v1 subvol
mgr/snap_schedule: add subvol and subvol group arguments to cli
mds/snap_schedule: add subvolume group column management
mgr/volumes: add remote helper methods to fetch subvolume info

Reviewed-by: Venky Shankar <vshankar@redhat.com>
18 months agoMerge pull request #55101 from Matan-B/wip-matanb-crimson-snaptrim_event-cleanup
Matan Breizman [Wed, 10 Jan 2024 19:38:00 +0000 (21:38 +0200)]
Merge pull request #55101 from Matan-B/wip-matanb-crimson-snaptrim_event-cleanup

crimson/osd/osd_operations: snaptrim_event cleanup

Reviewed-by: Samuel Just <sjust@redhat.com>
18 months agoMerge pull request #52815 from adk3798/upgrade-nfs-migration-check
Adam King [Wed, 10 Jan 2024 14:01:12 +0000 (09:01 -0500)]
Merge pull request #52815 from adk3798/upgrade-nfs-migration-check

qa/cephadm: mgr-nfs-upgrade, match any migration > 2

Reviewed-by: Michael Fritch <mfritch@suse.com>
18 months agoMerge pull request #51963 from adk3798/async-timeout-fixup
Adam King [Wed, 10 Jan 2024 13:59:51 +0000 (08:59 -0500)]
Merge pull request #51963 from adk3798/async-timeout-fixup

mgr/cephadm: fixups for asyncio based timeout

Reviewed-by: John Mulligan <jmulligan@redhat.com>
18 months agoMerge pull request #54721 from adk3798/pull-stable-compiled-cephadm
Adam King [Wed, 10 Jan 2024 13:57:58 +0000 (08:57 -0500)]
Merge pull request #54721 from adk3798/pull-stable-compiled-cephadm

qa/cephadm: add support to pull compiled cephadm for stable branches

Reviewed-by: John Mulligan <jmulligan@redhat.com>
18 months agoMerge pull request #55106 from zdover23/wip-doc-2024-01-09-radosgw-admin-rate-limit
zdover23 [Wed, 10 Jan 2024 11:51:58 +0000 (21:51 +1000)]
Merge pull request #55106 from zdover23/wip-doc-2024-01-09-radosgw-admin-rate-limit

doc/rgw: edit admin.rst - rate limit management

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
18 months agodoc/rgw: edit admin.rst - rate limit management 55106/head
Zac Dover [Tue, 9 Jan 2024 13:42:34 +0000 (23:42 +1000)]
doc/rgw: edit admin.rst - rate limit management

Edit the "Rate Limit Management" section in doc/radosgw/admin.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
18 months agocrimson/osd/osd_operations: let pg reference destruct last 55101/head
Matan Breizman [Tue, 28 Nov 2023 15:41:35 +0000 (15:41 +0000)]
crimson/osd/osd_operations: let pg reference destruct last

Prevent from SnapTrimEvent::handle destruct before SnapTrimEvent::pg.
The pg reference should be destructed last.

May releate to: https://tracker.ceph.com/issues/63647

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agocrimson/osd/osd_operations/background_recovery: cleanup unused logger
Matan Breizman [Tue, 28 Nov 2023 15:58:18 +0000 (15:58 +0000)]
crimson/osd/osd_operations/background_recovery: cleanup unused logger

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agocrimson/osd: cleanup SubOpBlocker::emplace_back usage
Matan Breizman [Mon, 27 Nov 2023 16:08:01 +0000 (16:08 +0000)]
crimson/osd: cleanup SubOpBlocker::emplace_back usage

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agocrimson/osd/osd_operations/snaptrim_event: using snap_trim_*_ret_t
Matan Breizman [Mon, 27 Nov 2023 12:11:38 +0000 (12:11 +0000)]
crimson/osd/osd_operations/snaptrim_event: using snap_trim_*_ret_t

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agocrimson/osd/osd_operations/snaptrim_event: move SubOpBlocker to seperate file
Matan Breizman [Mon, 27 Nov 2023 11:33:48 +0000 (11:33 +0000)]
crimson/osd/osd_operations/snaptrim_event: move SubOpBlocker to seperate file

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agoosd/scrub: allow replicas to scrub even if OSD has recovery in progress 55105/head
Ronen Friedman [Tue, 9 Jan 2024 12:51:46 +0000 (06:51 -0600)]
osd/scrub: allow replicas to scrub even if OSD has recovery in progress

Limit the check ("not scrubbing if the OSD is performing recovery on
some PG") to the primary OSD. Otherwise - a small number of backfills may
prevent a large number of PGs from scrubbing.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
18 months agoMerge pull request #54965 from rhcs-dashboard/osd-e2e-fix
Nizamudeen A [Wed, 10 Jan 2024 05:27:41 +0000 (10:57 +0530)]
Merge pull request #54965 from rhcs-dashboard/osd-e2e-fix

mgr/dashboard: fix e2e failure related to landing page

Reviewed-by: Nizamudeen A <nia@redhat.com>
18 months agoMerge pull request #55012 from rhcs-dashboard/snapshot-creation
Nizamudeen A [Wed, 10 Jan 2024 05:26:30 +0000 (10:56 +0530)]
Merge pull request #55012 from rhcs-dashboard/snapshot-creation

mgr/dashboard: subvolume snapshot creation form

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
18 months agoMerge pull request #55100 from petrutlucian94/boost_ceph_mirror
Ilya Dryomov [Tue, 9 Jan 2024 19:27:16 +0000 (20:27 +0100)]
Merge pull request #55100 from petrutlucian94/boost_ceph_mirror

win32_deps_build.sh: download Boost from Ceph mirror

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #54812 from adk3798/osd-spec-needs-id
Adam King [Tue, 9 Jan 2024 18:33:50 +0000 (13:33 -0500)]
Merge pull request #54812 from adk3798/osd-spec-needs-id

mgr/orchestrator: block OSD specs with no service id

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>
18 months agoMerge pull request #54948 from mgfritch/cephadm-build-rpm
Adam King [Tue, 9 Jan 2024 18:32:49 +0000 (13:32 -0500)]
Merge pull request #54948 from mgfritch/cephadm-build-rpm

cephadm: add runtime python minor version to RPM query macro

Reviewed-by: John Mulligan <jmulligan@redhat.com>
18 months agoMerge pull request #54977 from pcuzner/fix-host-threads-output
Adam King [Tue, 9 Jan 2024 18:31:41 +0000 (13:31 -0500)]
Merge pull request #54977 from pcuzner/fix-host-threads-output

orchestrator: Fix representation of CPU threads in host ls --detail command

Reviewed-by: Adam King <adking@redhat.com>
18 months agoMerge pull request #54978 from pcuzner/add-device-count-summary
Adam King [Tue, 9 Jan 2024 18:30:47 +0000 (13:30 -0500)]
Merge pull request #54978 from pcuzner/add-device-count-summary

orchestrator: Add summary line to orch device ls output

Reviewed-by: Adam King <adking@redhat.com>
18 months agoqa/tasks: fix syntax for deep-scrub command 55115/head
Laura Flores [Tue, 9 Jan 2024 16:54:01 +0000 (10:54 -0600)]
qa/tasks: fix syntax for deep-scrub command

Fixes: https://tracker.ceph.com/issues/63967
Signed-off-by: Laura Flores <lflores@ibm.com>
18 months agoMerge pull request #54913 from jianwei1216/visualize_osd_superblock_oldest_map_newest...
Yuri Weinstein [Tue, 9 Jan 2024 16:05:45 +0000 (08:05 -0800)]
Merge pull request #54913 from jianwei1216/visualize_osd_superblock_oldest_map_newest_map_main

OSD: oldest_map and newest_map should be displayed directly

Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
18 months agoMerge pull request #54634 from NitzanMordhai/wip-nitzan-mgr-restful-mod-leaking-memor...
Yuri Weinstein [Tue, 9 Jan 2024 16:05:12 +0000 (08:05 -0800)]
Merge pull request #54634 from NitzanMordhai/wip-nitzan-mgr-restful-mod-leaking-memory-results

mgr/BaseMgrModule: Optimize CPython Call in Finish Function

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
18 months agoMerge pull request #54829 from awojno-bloomberg/wip-fix-role-delete-replication
Casey Bodley [Tue, 9 Jan 2024 14:53:46 +0000 (14:53 +0000)]
Merge pull request #54829 from awojno-bloomberg/wip-fix-role-delete-replication

rgw/iam: fix role deletion replication

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agoMerge pull request #53156 from qiuxinyidian/rgw-dev
Casey Bodley [Tue, 9 Jan 2024 14:53:22 +0000 (14:53 +0000)]
Merge pull request #53156 from qiuxinyidian/rgw-dev

rgw: modify string match_wildcards with fnmatch

Reviewed-by: Casey Bodley <cbodley@redhat.com>
18 months agomgr/dashboard: subvolume snapshot creation form 55012/head
Nizamudeen A [Wed, 27 Dec 2023 09:14:53 +0000 (14:44 +0530)]
mgr/dashboard: subvolume snapshot creation form

Fixes: https://tracker.ceph.com/issues/63934
Signed-off-by: Nizamudeen A <nia@redhat.com>
18 months agoMerge pull request #55009 from ronen-fr/wip-rf-actpr-requeue
Ronen Friedman [Tue, 9 Jan 2024 12:37:03 +0000 (14:37 +0200)]
Merge pull request #55009 from ronen-fr/wip-rf-actpr-requeue

osd/scrub: remove scrub_clear_state()

Reviewed-by: Samuel Just <sjust@redhat.com>
18 months agowin32_deps_build.sh: download Boost from Ceph mirror 55100/head
Lucian Petrut [Tue, 9 Jan 2024 08:15:34 +0000 (08:15 +0000)]
win32_deps_build.sh: download Boost from Ceph mirror

We've recently changed the Boost mirror since the previous one
became unavailable.

As pointed out in PR comments, it's even better to use the Ceph
hosted source in order to save Ceph lab bandwidth.

We're adding bzip2 as a dependency. xz-utils was missing, so we're
adding it to our list.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
18 months agomgr/dashboard: fix e2e failure related to landing page 54965/head
Pedro Gonzalez Gomez [Tue, 19 Dec 2023 15:48:32 +0000 (16:48 +0100)]
mgr/dashboard: fix e2e failure related to landing page

Fixes: https://tracker.ceph.com/issues/59142
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
18 months agocrimson/osd/osd_operations/snaptrim_event: add op lifetime comment
Matan Breizman [Mon, 27 Nov 2023 11:33:28 +0000 (11:33 +0000)]
crimson/osd/osd_operations/snaptrim_event: add op lifetime comment

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agoRevert "crimson/osd/osd_operations/snaptrim_event: fix lifetime on finally()"
Matan Breizman [Mon, 27 Nov 2023 09:49:38 +0000 (09:49 +0000)]
Revert "crimson/osd/osd_operations/snaptrim_event: fix lifetime on finally()"

This reverts commit 84c5b6c578c1e64807eca5098d51193ee71e6106.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agoRevert "crimson/osd/osd_operations/snaptrim_event: lifetime fixes"
Matan Breizman [Mon, 27 Nov 2023 09:48:46 +0000 (09:48 +0000)]
Revert "crimson/osd/osd_operations/snaptrim_event: lifetime fixes"

This reverts commit abceb1652239629ed11187a5fc670a3b1a3a5bb1.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
18 months agoRevert "mgr/dashboard: allow tls 1.2 with a config option" 54645/head
Nizamudeen A [Fri, 24 Nov 2023 05:25:07 +0000 (10:55 +0530)]
Revert "mgr/dashboard: allow tls 1.2 with a config option"

This reverts commit 219c62bea60083c0e59a86454b0cecf8afaf9780.

Signed-off-by: Nizamudeen A <nia@redhat.com>
18 months agoMerge pull request #54870 from Svelar/crimson_g_conf
Samuel Just [Tue, 9 Jan 2024 02:55:55 +0000 (18:55 -0800)]
Merge pull request #54870 from Svelar/crimson_g_conf

crimson: add set_val and rm_val to global conf

Reviewed-by: Samuel Just <sjust@redhat.com>
18 months agoMerge pull request #52315 from ronen-fr/wip-rf-rgw-tasserts
Casey Bodley [Mon, 8 Jan 2024 19:30:32 +0000 (19:30 +0000)]
Merge pull request #52315 from ronen-fr/wip-rf-rgw-tasserts

test/rgw: annotating variables with maybe_unused

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
18 months agoMerge pull request #55088 from cbodley/wip-make-dist-wget
Laura Flores [Mon, 8 Jan 2024 18:00:27 +0000 (12:00 -0600)]
Merge pull request #55088 from cbodley/wip-make-dist-wget

18 months agoMerge pull request #54587 from cbodley/wip-45736
Casey Bodley [Mon, 8 Jan 2024 17:49:38 +0000 (17:49 +0000)]
Merge pull request #54587 from cbodley/wip-45736

rgw: add headers to guide cache update in 304 response

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
18 months agoMerge pull request #54715 from rkachach/fix_issue_63678
Adam King [Mon, 8 Jan 2024 16:40:09 +0000 (11:40 -0500)]
Merge pull request #54715 from rkachach/fix_issue_63678

mgr/rook: fixing inconsistencies on the dashboard 'services' view

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
18 months agoMerge pull request #54676 from rkachach/fix_list_devices_issue
Adam King [Mon, 8 Jan 2024 16:38:35 +0000 (11:38 -0500)]
Merge pull request #54676 from rkachach/fix_list_devices_issue

mgr/rook: fixing devices listing on rook

Reviewed-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
18 months agomake-dist: don't use --continue option for wget 55088/head
Casey Bodley [Mon, 8 Jan 2024 16:24:18 +0000 (08:24 -0800)]
make-dist: don't use --continue option for wget

the boost jfrog mirror is broken and returns an HTML error page instead
of the archive. the file size of this page is 11534 bytes

when download_from() retries the download from download.ceph.com, the -c
option tells it to resume the download of the existing file. the
resulting boost_1_82_0.tar.bz2 ends up with the correct total file size
of 121325129 bytes, but the first 11534 bytes still correspond to the
HTML from jfrog. that causes the sha256sum mismatch

remove the -c option so that wget fetches the archive in its entirety

Signed-off-by: Casey Bodley <cbodley@redhat.com>
18 months agoqa/cephadm: mgr-nfs-upgrade, match any migration > 2 52815/head
Adam King [Fri, 4 Aug 2023 17:30:55 +0000 (13:30 -0400)]
qa/cephadm: mgr-nfs-upgrade, match any migration > 2

I believe this check was originally added because
the 2->3 migration migrated some nfs related bits. Since
then we've had to update the migration this checks
for every time we bump the max migration. This change
is intended to instead just have it check for a
miration > 2 so we don't have to keep updating it.

Signed-off-by: Adam King <adking@redhat.com>
18 months agoqa/upgrade/reef-x: pull compiled cephadm to start upgrades from reef 54721/head
Adam King [Wed, 29 Nov 2023 16:49:38 +0000 (11:49 -0500)]
qa/upgrade/reef-x: pull compiled cephadm to start upgrades from reef

The compiled zipapp cephadm that began in reef needs
to be pulled differently than the old single python script
cephadm from earlier releases. This commit updates the reef-x
upgrade suite to pull cephadm in this new way.

Signed-off-by: Adam King <adking@redhat.com>
18 months agoqa/cephadm: support to pull stable branch compiled cephadm
Adam King [Wed, 16 Aug 2023 23:56:38 +0000 (19:56 -0400)]
qa/cephadm: support to pull stable branch compiled cephadm

This is to allow us to pull the latest build of
cephadm off of a stable branch (currently the only
valid option for that is reef, although this hopefully
will work with squid, T release, etc. in the future).

This should allow us to bootstrap cliusters based on
those stable branches for use in upgrade testing

Signed-off-by: Adam King <adking@redhat.com>
18 months agoMerge pull request #55081 from petrutlucian94/boost_mirror
Ilya Dryomov [Mon, 8 Jan 2024 11:56:51 +0000 (12:56 +0100)]
Merge pull request #55081 from petrutlucian94/boost_mirror

win32_deps_build.sh: change Boost URL

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
18 months agopybind: Fix C type errors in Cython-generated Python bindings 54974/head
Florian Weimer [Wed, 20 Dec 2023 13:59:19 +0000 (14:59 +0100)]
pybind: Fix C type errors in Cython-generated Python bindings

Several Ceph APIs use bool * types, which correspond to
libcpp.bool * types in Cython.  The bint type has an incorrect
size 4 and cannot be used as a replacement.

This prevents a compilation failure with future compilers:

…-build/src/pybind/rbd/rbd.c: In function ‘__pyx_pf_3rbd_3RBD_104namespace_exists’:
…-build/src/pybind/rbd/rbd.c:42165:76: error: passing argument 3 of ‘rbd_namespace_exists’ from incompatible pointer type
42165 |         __pyx_v_ret = rbd_namespace_exists(__pyx_v__ioctx, __pyx_v__name, (&__pyx_v__exists));
      |                                                                           ~^~~~~~~~~~~~~~~~~
      |                                                                            |
      |                                                                            int *
In file included from …-build/src/pybind/rbd/rbd.c:1268:
…/src/include/rbd/librbd.h:1496:45: note: expected ‘_Bool *’ but argument is of type ‘int *’
 1496 |                                       bool *exists);
      |                                             ^

Signed-off-by: Florian Weimer <fweimer@redhat.com>
18 months agotracing: Fix C type errors in librados tracing
Florian Weimer [Wed, 20 Dec 2023 13:16:19 +0000 (14:16 +0100)]
tracing: Fix C type errors in librados tracing

This fixes type errors like this:

In file included from /usr/include/lttng/tracepoint-event.h:69,
                 from …-build/include/tracing/librados.h:4143,
                 from …/src/tracing/librados.c:6
:
…-build/include/tracing/librados.h:
 In function ‘lttng_ust__event_probe__librados___rados_mon_command_exit’:
…-build/include/tracing/librados.h:477:9: error: initialization of ‘size_t’ {aka ‘long unsigned int’} from ‘size_t *’ {aka ‘long unsigned int *’} makes integer from pointer without a cast
  477 |         ceph_ctf_integerp(size_t, outslen, outslen)
      |         ^~~~~~~~~~~~~~~~~

GCC 14 will likely treat these type mismatches as an error
and fail the build.

Signed-off-by: Florian Weimer <fweimer@redhat.com>
18 months agoMerge pull request #55075 from zdover23/wip-doc-2024-01-07-radosgw-admin-quota
zdover23 [Mon, 8 Jan 2024 10:31:21 +0000 (20:31 +1000)]
Merge pull request #55075 from zdover23/wip-doc-2024-01-07-radosgw-admin-quota

doc/radosgw: edit admin.rst - quota

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
18 months agodoc/radosgw: edit admin.rst - quota 55075/head
Zac Dover [Sun, 7 Jan 2024 12:10:59 +0000 (22:10 +1000)]
doc/radosgw: edit admin.rst - quota

Edit the "Quota Management" section (all of it) in
doc/radosgw/admin.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
18 months agowin32_deps_build.sh: change Boost URL 55081/head
Lucian Petrut [Mon, 8 Jan 2024 08:44:51 +0000 (08:44 +0000)]
win32_deps_build.sh: change Boost URL

The Boost download URL is broken again [1], we'll switch to a
working mirror.

[1] https://github.com/boostorg/boost/issues/842

Fixes: https://tracker.ceph.com/issues/63952
Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>