]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
16 months agoPendingReleaseNotes: support for subvolumes and subvolume groups in snap_schedule 55210/head
Milind Changire [Thu, 14 Dec 2023 07:25:08 +0000 (12:55 +0530)]
PendingReleaseNotes: support for subvolumes and subvolume groups in snap_schedule

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit b3ff5f794985c173ba87926f34e6d9793c5d5c67)

16 months agosnap_schedule/tests: fix db upgrade issue
Milind Changire [Tue, 17 Oct 2023 04:36:48 +0000 (10:06 +0530)]
snap_schedule/tests: fix db upgrade issue

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit dfc35a4679495a3d7136927374e838409c29ab4a)

16 months agoqa: add yaml for on demand subvol version testing
Milind Changire [Thu, 14 Dec 2023 11:01:05 +0000 (16:31 +0530)]
qa: add yaml for on demand subvol version testing

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 2533ac5b90f367dd55f61c1e95dee0e154940930)

16 months agoqa: add test cases for testing --subvol and --group arguments
Milind Changire [Mon, 20 Nov 2023 10:39:57 +0000 (16:09 +0530)]
qa: add test cases for testing --subvol and --group arguments

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 006c68f492044327594fbf7204774d7d7d4ee518)

Conflicts:
- qa/tasks/cephfs/test_snap_schedules.py
  Minor conflict due missing refactor of command runner helper

16 months agomgr/volumes: conditionalize subvolume upgrade
Milind Changire [Thu, 7 Dec 2023 08:31:42 +0000 (14:01 +0530)]
mgr/volumes: conditionalize subvolume upgrade

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 0c5804ab4e5eb284d127044c5e51fbc870f5727a)

16 months agomgr/volumes: ensure correct init of v1 subvol
Milind Changire [Wed, 22 Nov 2023 09:50:17 +0000 (15:20 +0530)]
mgr/volumes: ensure correct init of v1 subvol

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 614d112cff522439c08e554a14472f1f391dd125)

16 months agomgr/snap_schedule: add subvol and subvol group arguments to cli
Milind Changire [Thu, 9 Nov 2023 07:55:02 +0000 (13:25 +0530)]
mgr/snap_schedule: add subvol and subvol group arguments to cli

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit 5b250907d03196bf99fe4a56ea00245a4c830264)

16 months agomds/snap_schedule: add subvolume group column management
Milind Changire [Thu, 9 Nov 2023 07:08:48 +0000 (12:38 +0530)]
mds/snap_schedule: add subvolume group column management

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit ffa197c03159e2acb7c3892f09a1ed616b9c1cd8)

16 months agomgr/volumes: add remote helper methods to fetch subvolume info
Milind Changire [Thu, 7 Dec 2023 08:33:39 +0000 (14:03 +0530)]
mgr/volumes: add remote helper methods to fetch subvolume info

  * add remote method to fetch subvolume path
  * add remote method to list subvolumes
  * add remote method to fetch subvolume attributes

Signed-off-by: Milind Changire <mchangir@redhat.com>
(cherry picked from commit d2205bf8247edec08a456377c1e8988428e9ba29)

16 months agoMerge pull request #54315 from batrick/wip-63420-quincy
Venky Shankar [Thu, 14 Mar 2024 01:17:42 +0000 (06:47 +0530)]
Merge pull request #54315 from batrick/wip-63420-quincy

quincy: mds: ensure next replay is queued on req drop

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
16 months agoMerge pull request #55318 from adk3798/wip-62447-quincy
Adam King [Wed, 13 Mar 2024 18:21:12 +0000 (14:21 -0400)]
Merge pull request #55318 from adk3798/wip-62447-quincy

quincy: mgr/cephadm: Add "networks" parameter to orch apply rgw

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #53425 from adk3798/quincy-tcmu-custom-configs
Adam King [Wed, 13 Mar 2024 18:20:20 +0000 (14:20 -0400)]
Merge pull request #53425 from adk3798/quincy-tcmu-custom-configs

quincy: cephadm: make custom_configs work for tcmu-runner container

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55473 from idryomov/wip-47287-quincy
Ilya Dryomov [Wed, 13 Mar 2024 18:05:23 +0000 (19:05 +0100)]
Merge pull request #55473 from idryomov/wip-47287-quincy

quincy: librbd: return ENOENT from Snapshot::get_timestamp for nonexistent snap_id

Reviewed-by: Ramana Raja <rraja@redhat.com>
16 months agoMerge pull request #55235 from ifed01/wip-ifed-cache-ratios-qui
Igor Fedotov [Wed, 13 Mar 2024 15:15:50 +0000 (18:15 +0300)]
Merge pull request #55235 from ifed01/wip-ifed-cache-ratios-qui

quincy: osd: make _set_cache_sizes ratio aware of cache_kv_onode_ratio

Reviewed-by: Mark Nelson <mark.nelson@clyso.com>
Reviewed-by: Pere Diaz Bou <pere-altea@hotmail.com>
16 months agoMerge pull request #55556 from adk3798/quincy-cephadm-asyncio-timeout-fixup
Adam King [Wed, 13 Mar 2024 14:41:04 +0000 (10:41 -0400)]
Merge pull request #55556 from adk3798/quincy-cephadm-asyncio-timeout-fixup

quincy: mgr/cephadm: fixups for asyncio based timeout

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55174 from ronen-fr/wip-64018-quincy
Ronen Friedman [Wed, 13 Mar 2024 12:50:39 +0000 (14:50 +0200)]
Merge pull request #55174 from ronen-fr/wip-64018-quincy

quincy: osd/scrub: increasing max_osd_scrubs to 3

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Pere Diaz Bou <pere-altea@hotmail.com>
16 months agoMerge pull request #56134 from zdover23/wip-doc-2024-03-12-backport-56113-to-quincy-2
zdover23 [Wed, 13 Mar 2024 03:45:57 +0000 (13:45 +1000)]
Merge pull request #56134 from zdover23/wip-doc-2024-03-12-backport-56113-to-quincy-2

quincy: doc/cephadm: Improve multiple files

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agoosd/scrub: increasing max_osd_scrubs to 3 55174/head
Ronen Friedman [Mon, 22 May 2023 15:09:28 +0000 (18:09 +0300)]
osd/scrub: increasing max_osd_scrubs to 3

Bug reports seem to hint that the current default value of
'1' is too low: the cluster is susceptible to scrub scheduling
delays and issues stemming from local software/networking/hardware
problems, even if affecting a very small number of OSDs.

Squid will include a major overhaul of the way scrubs are counted
in the cluster, providing a better solution to the problem. For
now - modifying the default is an effective stop-gap measure.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
(cherry picked from commit cc7b4afda972c144d7ebc679ff7f42d86f1dc493)

16 months agodoc/cephadm: Improve multiple files 56134/head
Anthony D'Atri [Mon, 11 Mar 2024 07:04:47 +0000 (03:04 -0400)]
doc/cephadm: Improve multiple files

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 800dd29e60fcd2bcd27db56d3fe45c58ddf10c8a)

16 months agoMerge pull request #56128 from adk3798/wip-64837-quincy
Nizamudeen A [Tue, 12 Mar 2024 13:22:52 +0000 (18:52 +0530)]
Merge pull request #56128 from adk3798/wip-64837-quincy

quincy: mgr/dashboard: debugging make check failure

16 months agoMerge PR #54374 into quincy
Patrick Donnelly [Tue, 12 Mar 2024 13:17:58 +0000 (09:17 -0400)]
Merge PR #54374 into quincy

* refs/pull/54374/head:
common: resolve config proxy deadlock using refcounted pointers
common: add missing locks in config_proxy methods
common/ceph_mutex: note whether mutex debug methods are usable
qa: add reproducer for obs removal deadlock
qa: narrow search to debug_asok

Reviewed-by: Laura Flores <lflores@redhat.com>
16 months agomgr/dashboard: debugging make check failure 56128/head
Nizamudeen A [Mon, 4 Mar 2024 12:52:48 +0000 (18:22 +0530)]
mgr/dashboard: debugging make check failure

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 958c60d8a74e3c38abe043e7f2cfbe4224cfb411)

16 months agoMerge pull request #55554 from ceph/wip-yuriw-disable-rbd-upgarde-p2p-quincy
Yuri Weinstein [Mon, 11 Mar 2024 15:20:10 +0000 (08:20 -0700)]
Merge pull request #55554 from ceph/wip-yuriw-disable-rbd-upgarde-p2p-quincy

quincy: qa/suites/upgrade/quincy-p2p: run librbd python API tests from quincy tip

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
16 months agoMerge pull request #55425 from petrutlucian94/wip-64293-quincy
Yuri Weinstein [Mon, 11 Mar 2024 15:16:55 +0000 (08:16 -0700)]
Merge pull request #55425 from petrutlucian94/wip-64293-quincy

quincy: msg: update MOSDOp() to use ceph_tid_t instead of long

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
16 months agoMerge pull request #56112 from zdover23/wip-doc-2024-03-11-backport-56091-to-quincy
Anthony D'Atri [Mon, 11 Mar 2024 07:06:15 +0000 (03:06 -0400)]
Merge pull request #56112 from zdover23/wip-doc-2024-03-11-backport-56091-to-quincy

quincy: doc/cephadm: improve host-management.rst

16 months agodoc/cephadm: improve host-management.rst 56112/head
Anthony D'Atri [Sun, 10 Mar 2024 19:49:35 +0000 (15:49 -0400)]
doc/cephadm: improve host-management.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 9fb51bb537e8bd9ea60633091acfc48a58262c3b)

16 months agoMerge pull request #55975 from adk3798/wip-62800-quincy
Adam King [Sun, 10 Mar 2024 18:34:45 +0000 (14:34 -0400)]
Merge pull request #55975 from adk3798/wip-62800-quincy

quincy: cephadm: run tcmu-runner through script to do restart on failure

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55974 from adk3798/wip-62796-quincy
Adam King [Sun, 10 Mar 2024 18:26:47 +0000 (14:26 -0400)]
Merge pull request #55974 from adk3798/wip-62796-quincy

quincy: mgr/cephadm: don't use image tag in orch upgrade ls

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55966 from adk3798/wip-62468-quincy
Adam King [Sun, 10 Mar 2024 18:22:13 +0000 (14:22 -0400)]
Merge pull request #55966 from adk3798/wip-62468-quincy

quincy: cephadm: add tcmu-runner to logrotate config

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55965 from adk3798/wip-62461-quincy
Adam King [Sun, 10 Mar 2024 18:21:13 +0000 (14:21 -0400)]
Merge pull request #55965 from adk3798/wip-62461-quincy

quincy: cephadm: support for CA signed keys

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55964 from adk3798/wip-61965-quincy
Adam King [Sun, 10 Mar 2024 18:19:36 +0000 (14:19 -0400)]
Merge pull request #55964 from adk3798/wip-61965-quincy

quincy: mgr/cephadm: add is_host_<status> functions to HostCache

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55962 from adk3798/wip-61685-quincy
Adam King [Sun, 10 Mar 2024 18:18:13 +0000 (14:18 -0400)]
Merge pull request #55962 from adk3798/wip-61685-quincy

quincy: python-common/drive_group: handle fields outside of 'spec' even when 'spec' is provided

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55961 from adk3798/wip-61682-quincy
Adam King [Sun, 10 Mar 2024 18:00:02 +0000 (14:00 -0400)]
Merge pull request #55961 from adk3798/wip-61682-quincy

quincy: python-common/drive_selection: lower log level of limit policy message

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55959 from adk3798/wip-61543-quincy
Adam King [Sun, 10 Mar 2024 17:58:49 +0000 (13:58 -0400)]
Merge pull request #55959 from adk3798/wip-61543-quincy

quincy: cephadm: Adding support to configure public_network cfg section

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55958 from adk3798/quincy-test-custom-config
Adam King [Sun, 10 Mar 2024 17:57:56 +0000 (13:57 -0400)]
Merge pull request #55958 from adk3798/quincy-test-custom-config

quincy: qa/cephadm: testing for extra daemon/container features

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56074 from zdover23/wip-doc-2024-03-09-backport-56068-to-quincy
zdover23 [Sat, 9 Mar 2024 13:39:11 +0000 (23:39 +1000)]
Merge pull request #56074 from zdover23/wip-doc-2024-03-09-backport-56068-to-quincy

quincy: doc/glossary: add "Crimson" entry

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
16 months agodoc/glossary: add "Crimson" entry 56074/head
Zac Dover [Fri, 8 Mar 2024 17:17:59 +0000 (03:17 +1000)]
doc/glossary: add "Crimson" entry

Add a "Crimson" entry to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b31e061cc087b31a7e9e841dd21e7403a2197378)

16 months agoMerge pull request #56042 from zdover23/wip-doc-2024-03-08-backport-56010-to-quincy
zdover23 [Sat, 9 Mar 2024 04:32:14 +0000 (14:32 +1000)]
Merge pull request #56042 from zdover23/wip-doc-2024-03-08-backport-56010-to-quincy

quincy: doc/start: add Slack invite link

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agoMerge pull request #56058 from zdover23/wip-doc-2024-03-08-backport-56045-to-quincy
Anthony D'Atri [Fri, 8 Mar 2024 16:00:09 +0000 (11:00 -0500)]
Merge pull request #56058 from zdover23/wip-doc-2024-03-08-backport-56045-to-quincy

quincy: doc/rados: restore PGcalc tool

16 months agodoc/rados: restore PGcalc tool 56058/head
Zac Dover [Thu, 7 Mar 2024 17:29:50 +0000 (03:29 +1000)]
doc/rados: restore PGcalc tool

Restore the PGcalc tool to the documentation suite.

Co-authored-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit eaaf72253123de1a66f163f651046817faa97a1a)

16 months agodoc/start: add Slack invite link 56042/head
Zac Dover [Thu, 7 Mar 2024 03:01:47 +0000 (13:01 +1000)]
doc/start: add Slack invite link

Add a link to the ceph-storage Slack invitation page. Previously the
link went to a plain old "this is the ceph-storage Slack" page that did
not direct the reader to sign up.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dee319e61204b2ee9ac13562c2c7075ef0f2ea4b)

16 months agoMerge pull request #56013 from zdover23/wip-doc-2024-03-07-backport-55995-to-quincy
Anthony D'Atri [Thu, 7 Mar 2024 15:35:06 +0000 (10:35 -0500)]
Merge pull request #56013 from zdover23/wip-doc-2024-03-07-backport-55995-to-quincy

quincy: doc/architecture: correct typo

16 months agodoc/architecture: correct typo 56013/head
Zac Dover [Wed, 6 Mar 2024 11:40:10 +0000 (21:40 +1000)]
doc/architecture: correct typo

s/client/clients/ where necessary, and add a link to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ae08855cf870173dce2a47a28f3bbb22e7ae0ca2)

16 months agocephadm: make custom_configs work for tcmu-runner container 53425/head
Adam King [Mon, 21 Aug 2023 17:48:56 +0000 (13:48 -0400)]
cephadm: make custom_configs work for tcmu-runner container

This is intended to be a temporary workaround to make
custom config files be able to be mounted into
the tcmu-runner container. The hope is to refactor
cephadm's iscsi handling for squid, but a patch
like this could be useful for iscsi in older
releases where currently custom config files
are unusable for the tcmu-runner container

What this patch actually does is have us write the
custom config files to a dir for the tcmu-runner
container so that the rest of the logic works without
change. I thought this would be easier to remove later
than a patch that integrates more with the container
mounts or general deployment

The use case in mind is something like

service_type: iscsi
service_id: foo
service_name: iscsi.foo
placement:
  hosts:
  - host1
custom_configs:
  -  mount_path: /etc/tcmu/tcmu.conf
     content: |
       log_level = 4
spec:
  api_password: admin
  api_port: 5000
  api_user: admin
  pool: foo

which would allow users to modify the logging of the
tcmu-runner container for debugging purposes

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit de92392708bf456bba975cc18b3138035d79ae05)

16 months agocephadm: run tcmu-runner through script to do restart on failure 55975/head
Adam King [Tue, 13 Jun 2023 23:54:30 +0000 (19:54 -0400)]
cephadm: run tcmu-runner through script to do restart on failure

Currently, cephadm runs tcmu-runner as a background
process inside the unit file deployed for iscsi
(rbd-target-api is the primary process). This means
if tcmu-runner crashes for whatever reason, systemd
will not attempt to restart it. This commits sets
up a script to serve as the container entrypoint
for the tcmu-runner container that will run
tcmu-runner and also restart it on failure
(unless there are too many failures in a short
period, at which point it gives up).

The hope is to eventually drop use of this script
for a better solution in squid onward, but this
should be helpful on older releases (quincy and
pacific at least) where we won't be able to
bring that better solution

Fixes: https://tracker.ceph.com/issues/61667
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 47eb6b3f62afe993073429b02051ae0343d7aea3)

Conflicts:
src/cephadm/tests/test_cephadm.py

16 months agocephadm: Fix extra_container_args for iSCSI
Raimund Sacherer [Fri, 26 May 2023 15:52:57 +0000 (17:52 +0200)]
cephadm: Fix extra_container_args for iSCSI

extra_container_args where only applied for rbd_target_api container and not for
tcmu-runner container.

Signed-off-by: Raimund Sacherer <rsachere@redhat.com>
(cherry picked from commit ad60fc3db644b8bf44a582e79888e2fb15d7ce3a)

Conflicts:
src/cephadm/cephadm

16 months agoModify how Iscsi tcmu-runner container is started within systemd
Teoman ONAY [Tue, 31 May 2022 08:34:05 +0000 (10:34 +0200)]
Modify how Iscsi tcmu-runner container is started within systemd

Modify Iscsi tcmu-runner container to be run demonized in the same
systemd slice as all other ceph processes

Signed-off-by: Teoman ONAY <tonay@redhat.com>
(cherry picked from commit 79c51938e88dc903f03faa42a94070ff8874a7fa)

16 months agoqa: test_iscsi_pids_limit.sh: increase sleep time
Ilya Dryomov [Mon, 11 Apr 2022 10:45:02 +0000 (12:45 +0200)]
qa: test_iscsi_pids_limit.sh: increase sleep time

It could take longer than 30 seconds to fork off 40000 processes on
a busy system.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit a23b9c99387858fb5299a42e7b79f319ece03641)

16 months agomgr/cephadm: don't use image tag in orch upgrade ls 55974/head
Adam King [Fri, 1 Sep 2023 13:05:04 +0000 (09:05 -0400)]
mgr/cephadm: don't use image tag in orch upgrade ls

Using the tag seems to screw up the auth URL generated
and is unnecessary since we're trying to get a list
of tags for the image anyway.

Fixes: https://tracker.ceph.com/issues/62679
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 0f4426d3a085fc2f5137593029469c3b20ace77e)

16 months agocephadm: add tcmu-runner to logrotate config 55966/head
Adam King [Fri, 2 Jun 2023 00:06:35 +0000 (20:06 -0400)]
cephadm: add tcmu-runner to logrotate config

This process could be used to set up the tcmu-runner
to log to a file much like other ceph daemons

- create /etc/tcmu directory
- create /etc/tcmu/tcmu.conf directory with default options
- change dir to /var/log
- change log level to 4
- add -v /etc/tcmu:/etc/tcmu to tcmu-runner container podman line in unit.run

In order to support this (mostly for debugging) we should
add tcmu-runner to the logrotate config

Fixes: https://tracker.ceph.com/issues/61571
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit d5d40e07cae8a1d6a94029c4354d146b0baa3971)

16 months agoqa/cephadm: add test for ca signed keys 55965/head
Adam King [Fri, 7 Jul 2023 15:03:56 +0000 (11:03 -0400)]
qa/cephadm: add test for ca signed keys

Test that bootstraps with a CA signed key using
the use_ca_signed_key cephadm override. Then follows
up by doing a check-host on each host which verifies
the cephadm mgr module can reach and authenticate with
the nodes using the new key setup.

This probably should really be a workunit, but
I didn't want to create a full new section for
this test and I needed a section that didn't
already run the cephadm task for every test. I could
see this being moved into some sort of
"test_special_deployment_scenarios" section in the future

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 141af1c6b156da34418100629cd1407b74c681ad)

16 months agoqa/cephadm: add ca signed key to cephadm task
Adam King [Fri, 7 Jul 2023 14:36:39 +0000 (10:36 -0400)]
qa/cephadm: add ca signed key to cephadm task

To allow bootstrapping a cluster using a CA signed
key instead of the standard pubkey authentication.
Will allow explicit testing of this as we add support
for it

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit bef9617c51b426b1479c374f2055f34e3fe20ed1)

Conflicts:
qa/tasks/cephadm.py

16 months agodoc/cephadm: document setting up CA signed keys in running cluster
Adam King [Sat, 3 Jun 2023 19:42:19 +0000 (15:42 -0400)]
doc/cephadm: document setting up CA signed keys in running cluster

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 2c837ea9cff44d6199ef68c03307e7ff3104adcf)

16 months agodoc/cephadm: document bootstrapping with CA signed keys
Adam King [Sat, 3 Jun 2023 19:28:05 +0000 (15:28 -0400)]
doc/cephadm: document bootstrapping with CA signed keys

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 6b4d9b4427608cb5d1c6e1b3fc958fba3ce0c22d)

16 months agodoc/cephadm: document how to pass self made SSH key pairs to bootstrap
Adam King [Sat, 3 Jun 2023 18:39:05 +0000 (14:39 -0400)]
doc/cephadm: document how to pass self made SSH key pairs to bootstrap

This didn't seem to exist in the install section of
the cephadm docs. Wanted to add it in before adding
documentation for bootstrapping with CA signed keys.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit e09a3765476eedae28905b51b666bee92c6fcf8e)

16 months agomgr/cephadm: add support for CA signed SSH keys setups
Adam King [Sat, 3 Jun 2023 17:31:58 +0000 (13:31 -0400)]
mgr/cephadm: add support for CA signed SSH keys setups

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 50f74d6063b820230f57608a1f800dc2507a3e1f)

16 months agomgr/cephadm: add is_host_<status> functions to HostCache 55964/head
Adam King [Thu, 1 Jun 2023 23:23:45 +0000 (19:23 -0400)]
mgr/cephadm: add is_host_<status> functions to HostCache

A bunch of places were doing list compression to see if a host
was unreachable/draining/schedulable by hostname. This is meant to
replace all those instances of list compression with a function
call that does the same

Fixes: https://tracker.ceph.com/issues/61548
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit b4002529b6ec4fae83ae3958f9fc288b22106f90)

16 months agopython-common/drive_group: handle fields outside of 'spec' even when 'spec' is provided 55962/head
Adam King [Wed, 31 May 2023 17:08:35 +0000 (13:08 -0400)]
python-common/drive_group: handle fields outside of 'spec' even when 'spec' is provided

Otherwise certain specs such as

service_type: osd
service_id: xxx
service_name: osd.xxx
placement:
  hosts:
  - vm-00
spec:
  osds_per_device: 2
data_devices:
  paths:
  - /dev/vde

fail to apply with

Error EINVAL: ServiceSpec: 'dict' object has no attribute 'validate'

which is not a useful error message. This is caused by the
spec assuming all osd specific fields are either defined
in the 'spec' section or outside of it, but not mixed in.
We could also just consider these specs to be invalid
and just raise a better error message, but it seems easier
to make the minor adjustment for it to work, given there doesn't
seem to be an issue with mixing the styles for specs for
other service types.

Fixes: https://tracker.ceph.com/issues/61533
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 12901f617d9f21dcc4de9b039b7ab6484fbc99ca)

16 months agopython-common/drive_selection: lower log level of limit policy message 55961/head
Adam King [Mon, 5 Jun 2023 17:18:06 +0000 (13:18 -0400)]
python-common/drive_selection: lower log level of limit policy message

This gets logged every time cephadm tries to apply a
relevant OSD spec and ends up spamming the logs. There's no reason
we really need this to be at info rather than debug level,
so let's lower it.

Fixes: https://tracker.ceph.com/issues/61592
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 20478025696b4ef39ca3e50c7cbfdb1250f85cfd)

16 months agocephadm: Adding support to configure public_network cfg section 55959/head
Redouane Kachach [Mon, 22 May 2023 09:15:07 +0000 (11:15 +0200)]
cephadm: Adding support to configure public_network cfg section
Fixes: https://tracker.ceph.com/issues/61330
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
(cherry picked from commit 50811d114ec91a3e5e340f6845870597ea498b35)

16 months agoqa/cephadm: test for extra daemon features 55958/head
Adam King [Mon, 19 Jun 2023 18:24:23 +0000 (14:24 -0400)]
qa/cephadm: test for extra daemon features

Specifically, extra_container_args, extra_entrypoint_args,
and custom_configs.

This also provides testing for the CustomContainer
class which previously had no usage in any
of the teuthology tests

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 031bbbc17fda3c7b28b12d11b976629d8c1297ed)

16 months agomgr/cephadm: add extra_entrypoint_args to mon spec
Adam King [Mon, 19 Jun 2023 20:07:31 +0000 (16:07 -0400)]
mgr/cephadm: add extra_entrypoint_args to mon spec

There was no reason for the mon spec to not include
this option. I believe this was just an oversight caused
by the addition of the mon spec and extra_entrypoint_args
in separate PRs around the same time.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 370836d46475d8daa6b26acd6f5330abb932bfed)

Conflicts:
src/python-common/ceph/deployment/service_spec.py

16 months agomgr/cephadm: add extra_container_args and custom_configs to CustomContainer
Adam King [Mon, 19 Jun 2023 19:46:45 +0000 (15:46 -0400)]
mgr/cephadm: add extra_container_args and custom_configs to CustomContainer

CustomContainer was skipped previously for the extra_container_args
and custom_configs feature as these could already be done
using other fields within the custom container service spec
(the "args" and "files" fields respectively). It seems
desirable for us to allow setting these things for custom
containers the same as for other services for uniformity sake
and this allows us to use custom containers to test
these features.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit b66892a668d487f4b7ede147eb8855d166c3d1f9)

Conflicts:
src/python-common/ceph/deployment/service_spec.py

16 months agoMerge pull request #55516 from afreen23/wip-64368-quincy
Nizamudeen A [Tue, 5 Mar 2024 08:08:44 +0000 (13:38 +0530)]
Merge pull request #55516 from afreen23/wip-64368-quincy

quincy: mgr/dashboard: fix error while accessing roles tab when policy attached

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agoMerge pull request #55937 from zdover23/wip-doc-2024-03-05-backport-55918-to-quincy
Anthony D'Atri [Tue, 5 Mar 2024 00:57:25 +0000 (19:57 -0500)]
Merge pull request #55937 from zdover23/wip-doc-2024-03-05-backport-55918-to-quincy

quincy: doc/rados: link to pg setting commands

16 months agoMerge pull request #55934 from zdover23/wip-doc-2024-03-05-backport-55924-to-quincy
Anthony D'Atri [Tue, 5 Mar 2024 00:52:29 +0000 (19:52 -0500)]
Merge pull request #55934 from zdover23/wip-doc-2024-03-05-backport-55924-to-quincy

quincy: doc/architecture: remove pleonasm

16 months agodoc/rados: link to pg setting commands 55937/head
Zac Dover [Mon, 4 Mar 2024 10:41:16 +0000 (20:41 +1000)]
doc/rados: link to pg setting commands

Link to the instructions for manually setting the number of PGs per
pool, from the mention of placement groups. These instructions are
included here in response to a request from Ronen Friedman on the
occasion of the removal of links to the PGcalc (see
https://github.com/ceph/ceph/pull/55899#pullrequestreview-1912940118).

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9da81b87ca161370c869b49f5d4e6b50edd54a0e)

16 months agodoc/architecture: remove pleonasm 55934/head
Zac Dover [Mon, 4 Mar 2024 13:41:20 +0000 (23:41 +1000)]
doc/architecture: remove pleonasm

Remove the word "detailed" in a sentence immediately following a
sentence containing the word "detail".

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 7791509741d8c21e273a46374a087dcca53a2816)

16 months agoMerge pull request #55446 from zdover23/wip-doc-2024-02-05-backport-55434-to-quincy
zdover23 [Tue, 5 Mar 2024 00:33:01 +0000 (10:33 +1000)]
Merge pull request #55446 from zdover23/wip-doc-2024-02-05-backport-55434-to-quincy

quincy: src/common/options: Correct typo in rgw.yaml.in

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agoMerge pull request #55166 from kamoltat/wip-ksirivad-backport-quincy
Yuri Weinstein [Mon, 4 Mar 2024 20:46:12 +0000 (12:46 -0800)]
Merge pull request #55166 from kamoltat/wip-ksirivad-backport-quincy

quincy: mon/ConnectionTracker.cc: disregard connection scores from mon_rank = -1

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
16 months agoMerge pull request #55134 from ifed01/wip-ifed-fast-shutdown-assert-qui
Yuri Weinstein [Mon, 4 Mar 2024 20:45:10 +0000 (12:45 -0800)]
Merge pull request #55134 from ifed01/wip-ifed-fast-shutdown-assert-qui

quincy: osd: do not assert on fast shutdown timeout

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
16 months agoMerge pull request #55117 from pdvian/wip-63986-quincy
Yuri Weinstein [Mon, 4 Mar 2024 20:44:26 +0000 (12:44 -0800)]
Merge pull request #55117 from pdvian/wip-63986-quincy

quincy: mon: add exception handling to ceph health mute

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
16 months agoMerge pull request #54877 from ifed01/wip-ifed-no-alloc-lba-align-qui
Yuri Weinstein [Mon, 4 Mar 2024 20:42:55 +0000 (12:42 -0800)]
Merge pull request #54877 from ifed01/wip-ifed-no-alloc-lba-align-qui

quincy: os/bluestore: get rid off resulting lba alignment in allocators

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
16 months agomgr/dashboard: fix roles page for roles without policies 55516/head
Nizamudeen A [Tue, 27 Feb 2024 07:18:56 +0000 (12:48 +0530)]
mgr/dashboard: fix roles page for roles without policies

If there is no permission policies attached to a role, it fails the
UI with an exception.

Fixes: https://tracker.ceph.com/issues/64588
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 5f3f31921c9f3ed909a94f287bfd4cc3f0987649)

16 months agomgr/dashboard: fix error while accessing roles tab when policy attached
Afreen [Tue, 6 Feb 2024 09:43:58 +0000 (15:13 +0530)]
mgr/dashboard: fix error while accessing roles tab when policy attached

Fixes https://tracker.ceph.com/issues/64270

Issue:
======
Accessing Object->Users-Roles tab causing 500 internal servor error.
This is due to the "PermissionPolicies" which are attached to role and
backend was not handling this field for rgw roles.

Fix:
====
Added "PermissionPolicies" as the valid field in backend and updated
frontend to render the attached policy in formatted JSON

Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit 5247d7d19455a5ab7d1bb56b9586c6b08843b15d)

 Conflicts:
src/pybind/mgr/dashboard/controllers/rgw.py
src/pybind/mgr/dashboard/frontend/src/app/shared/models/crud-table-metadata.ts

16 months agoMerge pull request #55593 from afreen23/wip-update-mypy-ver-quincy
Laura Flores [Mon, 4 Mar 2024 00:21:32 +0000 (18:21 -0600)]
Merge pull request #55593 from afreen23/wip-update-mypy-ver-quincy

quincy: batch backport of #50743,  #55342, #48557

16 months agoMerge pull request #55902 from zdover23/wip-doc-2024-03-03-backport-55899-to-quincy
Anthony D'Atri [Sun, 3 Mar 2024 13:07:20 +0000 (08:07 -0500)]
Merge pull request #55902 from zdover23/wip-doc-2024-03-03-backport-55899-to-quincy

quincy: doc/rados: remove PGcalc from docs

16 months agodoc/rados: remove PGcalc from docs 55902/head
Zac Dover [Sun, 3 Mar 2024 10:28:00 +0000 (20:28 +1000)]
doc/rados: remove PGcalc from docs

Remove mention of the "PG calc" tool from the documentation. I have
removed all mention of this in one fell swoop to help posterity restore
mention of this tool if we decide we need to do so.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ccb851d2a431647124754e1252df66ed11d0e900)

16 months agoMerge pull request #55881 from zdover23/wip-doc-2024-03-02-backport-55869-to-quincy
Anthony D'Atri [Fri, 1 Mar 2024 23:59:34 +0000 (18:59 -0500)]
Merge pull request #55881 from zdover23/wip-doc-2024-03-02-backport-55869-to-quincy

quincy:doc/install: add manual RADOSGW install procedure

16 months agodoc/install: add manual RADOSGW install procedure 55881/head
Zac Dover [Fri, 1 Mar 2024 12:11:14 +0000 (22:11 +1000)]
doc/install: add manual RADOSGW install procedure

Add a manual RADOSGW installation procedure to
doc/install/manual-deployment.rst. This procedure was developed by Janne
Johansson and reported to the ceph-users mailing list on 29 Jan 2024
here: https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/message/LB3YRIKAPOHXYCW7MKLVUJPYWYRQVARU/

Co-authored-by: Janne Johansson <icepic.dz@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 565bc9503838906995fa48f59debcd2843775b18)

16 months agoMerge pull request #55853 from zdover23/wip-doc-2024-03-01-backport-55834-to-quincy
Anthony D'Atri [Fri, 1 Mar 2024 01:34:38 +0000 (20:34 -0500)]
Merge pull request #55853 from zdover23/wip-doc-2024-03-01-backport-55834-to-quincy

quincy: doc/dev: edit internals.rst

16 months agodoc/dev: edit internals.rst 55853/head
Zac Dover [Thu, 29 Feb 2024 07:40:57 +0000 (17:40 +1000)]
doc/dev: edit internals.rst

Edit doc/dev/internals.rst. Make a few sentences pithier.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e16ab1df72c3640db907e377da7ca97ce3eaa26e)

16 months agoMerge pull request #55850 from zdover23/wip-doc-2024-03-01-backport-55835-to-quincy
Anthony D'Atri [Thu, 29 Feb 2024 23:46:47 +0000 (18:46 -0500)]
Merge pull request #55850 from zdover23/wip-doc-2024-03-01-backport-55835-to-quincy

quincy: doc/glossary: improve "MDS" entry

16 months agodoc/glossary: improve "MDS" entry 55850/head
Zac Dover [Thu, 29 Feb 2024 08:08:10 +0000 (18:08 +1000)]
doc/glossary: improve "MDS" entry

Improve the entry for "MDS" in doc/glossary.rst by linking to the
"ceph-mds" man page and mentioning the relationship between clients and
MDS (or MDSes).

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2c6983d8b4e841f2bfbc4e4f82bb0e41e10aec7e)

16 months agoMerge pull request #55800 from zdover23/wip-doc-2024-02-28-backport-55782-to-quincy
Anthony D'Atri [Tue, 27 Feb 2024 23:51:51 +0000 (18:51 -0500)]
Merge pull request #55800 from zdover23/wip-doc-2024-02-28-backport-55782-to-quincy

quincy: doc/rados: add "change public network" procedure

16 months agodoc/rados: add "change public network" procedure 55800/head
Zac Dover [Mon, 26 Feb 2024 10:03:48 +0000 (20:03 +1000)]
doc/rados: add "change public network" procedure

Add a procedure to /doc/rados/operations/add-or-rm-mons.rst that
explains how to change the public_network in a Ceph cluster deployed
with cephadm. This procedure was developed by Eugen Block, and can be
seen in its original form here:
https://heiterbiswolkig.blogs.nde.ag/2024/02/22/cephadm-change-public-network/

Co-authored-by: Eugen Block <eblock@nde.ag>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 0b6739a4aa2dd931d97b8af9b3a352969f8767c2)

16 months agocephadm: fix base class behavior on python3.6 55593/head
John Mulligan [Wed, 12 Oct 2022 18:15:59 +0000 (14:15 -0400)]
cephadm: fix base class behavior on python3.6

This fixes the cephadm test files when running tox/pytest on python3.6
(centos/rhel 8).
Long story short, combining classmethod and property on py3.6 behaves
differently from py3.7 and up. Since the classmethod is actually
unnecessary for the base class to behave as it does, we drop that
decorator.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit 7440d7a3c07d3e83ebb2ea7ac9cbbd94762e78ed)

16 months agocephadm: fix running test suite on python3.6
John Mulligan [Wed, 12 Oct 2022 18:06:40 +0000 (14:06 -0400)]
cephadm: fix running test suite on python3.6

While a new version of pyfakefs is available, version 5 is not available
for python 3.6. In order to run the test suite on centos 8 we will
continue to work with pyfakefs version 4.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
(cherry picked from commit b5218528d63ae87ca77229bce1635c62411959e8)

16 months agomgr/dashboard: Add # type ignore to fix ci failure
Afreen [Thu, 15 Feb 2024 15:33:36 +0000 (21:03 +0530)]
mgr/dashboard: Add # type ignore to fix ci failure

issue:
=====
The run_tox py is failing :
dashboard/module.py:34: note: In module imported here,
dashboard/__init__.py:60: note: ... from here:
dashboard/services/rgw_client.py: note: In member "_is_system_user" of class "RgwClient":
dashboard/services/rgw_client.py:483: error: Incompatible return value type (got "Literal[0, 1]", expected "bool")
Found 1 error in 1 file (checked 32 source files)
mypy: exit 1 (82.29 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/src/pybind/mgr> mypy --config-file=../../mypy.ini -m alerts -m balancer -m cephadm -m crash -m dashboard -m devicehealth -m diskprediction_local -m hello -m influx -m iostat -m localpool -m mds_autoscaler -m mgr_module -m mgr_util -m mirroring -m nfs -m orchestrator -m pg_autoscaler -m progress -m prometheus -m rbd_support -m rgw -m rook -m snap_schedule -m selftest -m stats -m status -m telegraf -m telemetry -m test_orchestrator -m volumes -m zabbix pid=235356
mypy: FAIL ✖ in 3 minutes 11.62 secondstake your time..you can postpone too

Fix:
===
Added "# type ignore" to ignore the type check to _is_system_user's
response

Signed-off-by: Afreen <afreen23.git@gmail.com>
Co-authored-by: Laura Flores <lflores@ibm.com>
Co-authored-by: Afreen <afreen23.git@gmail.com>
16 months agoMerge pull request #55755 from zdover23/wip-doc-2024-02-26-backport-55683-to-quincy
zdover23 [Mon, 26 Feb 2024 10:26:11 +0000 (20:26 +1000)]
Merge pull request #55755 from zdover23/wip-doc-2024-02-26-backport-55683-to-quincy

quincy: doc/man/8/mount.ceph.rst: add more mount options

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
16 months agodoc/man/8/mount.ceph.rst: add more mount options 55755/head
Xiubo Li [Wed, 22 Nov 2023 08:13:08 +0000 (16:13 +0800)]
doc/man/8/mount.ceph.rst: add more mount options

Fixes: https://tracker.ceph.com/issues/62837
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit d5639cc670d248da7c84e6f2eaf73ce40bd93db4)

16 months agoMerge pull request #55750 from zdover23/wip-doc-2024-02-26-backport-55739-to-quincy
Anthony D'Atri [Mon, 26 Feb 2024 06:08:50 +0000 (01:08 -0500)]
Merge pull request #55750 from zdover23/wip-doc-2024-02-26-backport-55739-to-quincy

quincy: doc/glossary: Add "OMAP" to glossary

16 months agodoc/glossary: Add "OMAP" to glossary 55750/head
Zac Dover [Sun, 25 Feb 2024 21:14:25 +0000 (07:14 +1000)]
doc/glossary: Add "OMAP" to glossary

Add an entry for "OMAP" to the glossary. This commit represents only the
first improvement to the documentation of OMAP in the Ceph docs suite.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 1d8baa1d4c3583f4a8dc0f46d81f198a3d027e4d)

16 months agosrc/common/options: Correct typo in rgw.yaml.in 55446/head
Anthony D'Atri [Sat, 3 Feb 2024 07:18:25 +0000 (02:18 -0500)]
src/common/options: Correct typo in rgw.yaml.in

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 1796022aa4778226c2d7e04c1cb989ab9d025272)

16 months agoMerge pull request #55738 from zdover23/wip-doc-2024-02-25-backport-55731-to-quincy
Anthony D'Atri [Sun, 25 Feb 2024 05:58:08 +0000 (00:58 -0500)]
Merge pull request #55738 from zdover23/wip-doc-2024-02-25-backport-55731-to-quincy

quincy: doc/dev: fix spelling in crimson.rst

16 months agodoc/dev: fix spelling in crimson.rst 55738/head
Zac Dover [Fri, 23 Feb 2024 16:21:54 +0000 (02:21 +1000)]
doc/dev: fix spelling in crimson.rst

Repair a confusing sentence in doc/dev/crimson.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dfdb5e124a19e0c5ce1e7ba47e574e0504e7091f)

16 months agoMerge pull request #55649 from zdover23/wip-doc-2024-02-20-backport-55637-to-quincy
zdover23 [Wed, 21 Feb 2024 22:55:16 +0000 (08:55 +1000)]
Merge pull request #55649 from zdover23/wip-doc-2024-02-20-backport-55637-to-quincy

quincy: doc/cephfs: edit add-remove-mds

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
16 months agoMerge pull request #55681 from zdover23/wip-doc-2024-02-21-backport-55670-to-quincy
Anthony D'Atri [Wed, 21 Feb 2024 00:59:33 +0000 (19:59 -0500)]
Merge pull request #55681 from zdover23/wip-doc-2024-02-21-backport-55670-to-quincy

quincy: doc/rados: fix broken links

16 months agoMerge pull request #55679 from zdover23/wip-doc-2024-02-21-backport-55677-to-quincy
Anthony D'Atri [Tue, 20 Feb 2024 23:47:50 +0000 (18:47 -0500)]
Merge pull request #55679 from zdover23/wip-doc-2024-02-21-backport-55677-to-quincy

quincy: doc/rados/configuration/osd-config-ref: fix typo

16 months agodoc/rados: fix broken links 55681/head
Zac Dover [Tue, 20 Feb 2024 18:07:07 +0000 (04:07 +1000)]
doc/rados: fix broken links

Fix broken links in doc/rados/operations/add-or-rm-mons.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2e2519367099461415248353d7c7725c0567511d)