]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
16 months agodoc/rados: link to pg setting commands 55918/head
Zac Dover [Mon, 4 Mar 2024 10:41:16 +0000 (20:41 +1000)]
doc/rados: link to pg setting commands

Link to the instructions for manually setting the number of PGs per
pool, from the mention of placement groups. These instructions are
included here in response to a request from Ronen Friedman on the
occasion of the removal of links to the PGcalc (see
https://github.com/ceph/ceph/pull/55899#pullrequestreview-1912940118).

Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agoMerge pull request #55897 from Matan-B/wip-matanb-crimson-seastar-sub-march24
Kefu Chai [Mon, 4 Mar 2024 06:17:16 +0000 (14:17 +0800)]
Merge pull request #55897 from Matan-B/wip-matanb-crimson-seastar-sub-march24

src/seastar: update seastar submodule to fix FTBFS

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
16 months agoMerge pull request #55659 from batrick/i64503
Venky Shankar [Mon, 4 Mar 2024 06:00:22 +0000 (11:30 +0530)]
Merge pull request #55659 from batrick/i64503

client: log debug message when requesting unmount

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agosrc/seastar: update seastar submodule to fix FTBFS 55897/head
Matan Breizman [Sun, 3 Mar 2024 09:45:56 +0000 (09:45 +0000)]
src/seastar: update seastar submodule to fix FTBFS

See: https://github.com/ceph/seastar/commit/d382f247629a7349afc0cea495a1cd0502dc0b22

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
16 months agoMerge pull request #55899 from zdover23/wip-doc-2024-03-02-rados-radosgw-pgcalc
zdover23 [Sun, 3 Mar 2024 10:41:23 +0000 (20:41 +1000)]
Merge pull request #55899 from zdover23/wip-doc-2024-03-02-rados-radosgw-pgcalc

doc/rados: remove PGcalc from docs

Reviewed-by: Ronen Friedman <rfriedman@redhat.com>
16 months agodoc/rados: remove PGcalc from docs 55899/head
Zac Dover [Sun, 3 Mar 2024 10:28:00 +0000 (20:28 +1000)]
doc/rados: remove PGcalc from docs

Remove mention of the "PG calc" tool from the documentation. I have
removed all mention of this in one fell swoop to help posterity restore
mention of this tool if we decide we need to do so.

Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agoMerge pull request #52540 from petrutlucian94/single_process
Ilya Dryomov [Sat, 2 Mar 2024 18:53:06 +0000 (19:53 +0100)]
Merge pull request #52540 from petrutlucian94/single_process

rbd-wnbd: use a single daemon process per host

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
16 months agoMerge pull request #55787 from tchaikov/wip-cmake-liburing-2.5
Kefu Chai [Sat, 2 Mar 2024 09:58:08 +0000 (17:58 +0800)]
Merge pull request #55787 from tchaikov/wip-cmake-liburing-2.5

cmake: bump liburing from 0.7 to 2.5

Reviewed-by: Casey Bodley <cbodley@redhat.com>
16 months agocmake: bump liburing from 0.7 to 2.5 55787/head
Kefu Chai [Tue, 27 Feb 2024 14:25:32 +0000 (22:25 +0800)]
cmake: bump liburing from 0.7 to 2.5

this allows us to use newer liburing features. Seastar is using
some of them which are not provided by liburing 0.7.

in this change, `--use-libc` is passed to configure. otherwise
it does not link against libc, and the symbles like memset()
won't be available when compiling liburing.so with -fPIC using
clang, which does not pull libc in that case.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
16 months agoMerge pull request #55878 from athanatos/sjust/wip-seastar-module
Samuel Just [Sat, 2 Mar 2024 02:43:02 +0000 (18:43 -0800)]
Merge pull request #55878 from athanatos/sjust/wip-seastar-module

crimson: update seastar submodule to fix prometheus build error

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
16 months agocrimson/.../interruptible_future: remove SEASTAR_CONCEPT guard 55878/head
Samuel Just [Fri, 1 Mar 2024 20:00:32 +0000 (20:00 +0000)]
crimson/.../interruptible_future: remove SEASTAR_CONCEPT guard

Seastar commit 8dc3398a removed this macro, no longer necessary.

Signed-off-by: Samuel Just <sjust@redhat.com>
16 months agosrc/seastar: update seastar submodule to fix prometheus build failure
Samuel Just [Fri, 1 Mar 2024 19:10:00 +0000 (19:10 +0000)]
src/seastar: update seastar submodule to fix prometheus build failure

Fixes: https://tracker.ceph.com/issues/64589
Signed-off-by: Samuel Just <sjust@redhat.com>
16 months agoMerge pull request #55856 from dmick/wip-workflow-update
Dan Mick [Fri, 1 Mar 2024 23:10:48 +0000 (15:10 -0800)]
Merge pull request #55856 from dmick/wip-workflow-update

.github/workflows/create-backport-trackers.yml: update actions

16 months agoMerge pull request #55869 from zdover23/wip-doc-2024-03-01-install-manual-radosgw
zdover23 [Fri, 1 Mar 2024 23:02:35 +0000 (09:02 +1000)]
Merge pull request #55869 from zdover23/wip-doc-2024-03-01-install-manual-radosgw

doc/install: add manual RADOSGW install procedure

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months ago.github/workflows/create-backport-trackers.yml: update versions of actions 55856/head
Dan Mick [Thu, 29 Feb 2024 19:36:51 +0000 (11:36 -0800)]
.github/workflows/create-backport-trackers.yml: update versions of actions

Getting warning about node16 being deprecated.  The workflow doesn't use node
directly, but through the external actions.  Moving to node20 requires
changing setup-python version; Bhacaz/checkout-files is deprecated and
recommends actions/checkout.

Signed-off-by: Dan Mick <dmick@redhat.com>
16 months agodoc/install: add manual RADOSGW install procedure 55869/head
Zac Dover [Fri, 1 Mar 2024 12:11:14 +0000 (22:11 +1000)]
doc/install: add manual RADOSGW install procedure

Add a manual RADOSGW installation procedure to
doc/install/manual-deployment.rst. This procedure was developed by Janne
Johansson and reported to the ceph-users mailing list on 29 Jan 2024
here: https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/message/LB3YRIKAPOHXYCW7MKLVUJPYWYRQVARU/

Co-authored-by: Janne Johansson <icepic.dz@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agoMerge pull request #55797 from ajarr/wip-64574
Ilya Dryomov [Fri, 1 Mar 2024 17:56:26 +0000 (18:56 +0100)]
Merge pull request #55797 from ajarr/wip-64574

qa: add diff-continuous and compare-mirror-image tests to rbd and krbd suites respectively

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
16 months agorbd-wnbd: use the right AdminSocket instance 52540/head
Lucian Petrut [Tue, 26 Sep 2023 11:52:31 +0000 (11:52 +0000)]
rbd-wnbd: use the right AdminSocket instance

The rbd-wnbd daemon currently caches one rados context per cluster.
However, it's registering hooks against the global context
admin socket, which won't be available. For this reason,
the "rbd-wnbd stats" command no longer works.

To address this issue, we'll ensure that rbd-wnbd sets command hooks
against the right admin socket instance, leveraging the image
context.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
16 months agorbd-wnbd: adjust admin socket hook to accept image path
Lucian Petrut [Tue, 26 Sep 2023 08:00:19 +0000 (08:00 +0000)]
rbd-wnbd: adjust admin socket hook to accept image path

For each rbd-wnbd mapping we set an admin socket hook that can
be used to retrieve IO stats.

Now that the same daemon is reused for multiple mappings, we need
to distinguish the images when receiving a "stats" request.

For this reason, we'll add the image identifier to "wnbd stats"
admin socket commands.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
16 months agoqa: update rbd-wnbd test, retrying image rm operations
Lucian Petrut [Wed, 2 Aug 2023 09:50:37 +0000 (09:50 +0000)]
qa: update rbd-wnbd test, retrying image rm operations

The "rbd-wnbd unmap" command is currently telling the WNBD driver
to remove the mapping without contacting the rbd-wnbd daemon
and waiting for it to perform its cleanup.

For this reason, attempting to delete the image immediately after
unmapping it can fail due to existing watchers.

As a temporary solution, we'll retry the image remove operation.
At a later time, we'll update the "rbd-wnbd unmap" command to go
through the rbd-wnbd daemon, ensuring that all the necessary
cleanup is performed before returning.

While at it, we're dropping a redundant LOG.error call so that we
won't print expected exceptions.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
16 months agorbd-wnbd: update registry settings handling
Lucian Petrut [Wed, 19 Jul 2023 12:32:40 +0000 (12:32 +0000)]
rbd-wnbd: update registry settings handling

This commit will store the mapping config in the Windows registry
only after initializing the mapping. This ensures that we aren't
replacing the registry settings for already mapped images.

We'll also check if the registry setting was added by us before
cleaning it up.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
16 months agorbd-wnbd: use one daemon process per host
Lucian Petrut [Mon, 12 Jun 2023 13:16:39 +0000 (13:16 +0000)]
rbd-wnbd: use one daemon process per host

We're currently using one rbd-wnbd process per image mapping.
Since OSD connections aren't shared across those processes,
we end up with an excessive amount of TCP sessions, potentially
exceeding Windows limits:
https://ask.cloudbase.it/question/3598/ceph-for-windows-tcp-session-count/

In order to improve rbd-wnbd's scalability, we're going to use
a single process per host (unless "-f" is passed when mapping the
image, in which case the daemon will run as part of the same
process). This allows OSD sessions to be shared across image
mappings.

Another advantage is that the "ceph-rbd" service starts faster,
especially when having a large number of image mappings.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
16 months agorbd-wnbd: introduce RbdMapping class
Lucian Petrut [Mon, 12 Jun 2023 08:00:40 +0000 (08:00 +0000)]
rbd-wnbd: introduce RbdMapping class

We're moving most of the WNBD mapping handling to a separate
class called RbdMapping. This simplifies cleanup and makes it
easier to reuse.

The WnbdHandler class covers WNBD specific operations and IO
callbacks while the RbdMapping wrapper will take care of RBD
operations.

A subsequent change will make use of it while switching from
one process per mapping to a single process per host.

While at it, we're also moving the rbd-wnbd config helpers
to separate files.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
16 months agoMerge pull request #54767 from climb-mountain123/worm_multipart
Casey Bodley [Fri, 1 Mar 2024 17:19:58 +0000 (17:19 +0000)]
Merge pull request #54767 from climb-mountain123/worm_multipart

src/rgw: fix for the multipart interface in the WORM function

Reviewed-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge pull request #55719 from phlogistonjohn/jjm-teuth-tasks-cephadm-jt
Adam King [Fri, 1 Mar 2024 16:54:14 +0000 (11:54 -0500)]
Merge pull request #55719 from phlogistonjohn/jjm-teuth-tasks-cephadm-jt

qa/tasks/cephadm: add generic templating where subst_vip was used

Reviewed-by: Adam King <adking@redhat.com>
16 months agorgw: remove unused object lock stuff from CompleteMultipart 54767/head
Casey Bodley [Fri, 1 Mar 2024 15:15:27 +0000 (10:15 -0500)]
rgw: remove unused object lock stuff from CompleteMultipart

Signed-off-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge pull request #55817 from rkhudov/src-test-common-test_hobject-remove-constexpr
Ronen Friedman [Fri, 1 Mar 2024 14:54:37 +0000 (16:54 +0200)]
Merge pull request #55817 from rkhudov/src-test-common-test_hobject-remove-constexpr

src/test/common/test_hobject: remove constexpr

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
16 months agoMerge pull request #55727 from cbodley/wip-64549
Casey Bodley [Fri, 1 Mar 2024 13:28:41 +0000 (13:28 +0000)]
Merge pull request #55727 from cbodley/wip-64549

rgw/auth: do_aws4_auth_completion() catches exceptions

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
16 months agoMerge pull request #55855 from xxhdx1985126/wip-seastore-interface
Yingxin [Fri, 1 Mar 2024 05:48:10 +0000 (13:48 +0800)]
Merge pull request #55855 from xxhdx1985126/wip-seastore-interface

crimson/os/seastore: adjust SeaStore::_omap_set_kvs() params

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agocrimson/os/seastore: adjust SeaStore::_omap_set_kvs() params 55855/head
Xuehan Xu [Fri, 1 Mar 2024 02:32:32 +0000 (10:32 +0800)]
crimson/os/seastore: adjust SeaStore::_omap_set_kvs() params

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
16 months agoMerge pull request #55834 from zdover23/wip-doc-2024-02-29-dev-internals
zdover23 [Fri, 1 Mar 2024 00:13:46 +0000 (10:13 +1000)]
Merge pull request #55834 from zdover23/wip-doc-2024-02-29-dev-internals

doc/dev: edit internals.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agoMerge pull request #55835 from zdover23/wip-doc-2024-02-29-glossary-mds
zdover23 [Thu, 29 Feb 2024 23:32:07 +0000 (09:32 +1000)]
Merge pull request #55835 from zdover23/wip-doc-2024-02-29-glossary-mds

doc/glossary: improve "MDS" entry

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agodoc/glossary: improve "MDS" entry 55835/head
Zac Dover [Thu, 29 Feb 2024 08:08:10 +0000 (18:08 +1000)]
doc/glossary: improve "MDS" entry

Improve the entry for "MDS" in doc/glossary.rst by linking to the
"ceph-mds" man page and mentioning the relationship between clients and
MDS (or MDSes).

Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agoqa/suites: add diff-continuous and compare-mirror-image tests 55797/head
Ramana Raja [Thu, 29 Feb 2024 17:12:19 +0000 (12:12 -0500)]
qa/suites: add diff-continuous and compare-mirror-image tests

... to rbd and krbd suites respectively.

This allows the compare-mirror-image tests introduced in ea3a567
to be run against various kernel branches, e.g., testing branch.
And allows diff_continuous test in rbd_suite to run against distro
kernel.

Fixes: https://tracker.ceph.com/issues/64574
Signed-off-by: Ramana Raja <rraja@redhat.com>
16 months agoqa/suites/rbd: rename nbd folder to device folder
Ramana Raja [Thu, 29 Feb 2024 16:55:08 +0000 (11:55 -0500)]
qa/suites/rbd: rename nbd folder to device folder

Signed-off-by: Ramana Raja <rraja@redhat.com>
16 months agorgw: don't overwrite target attrs checking mpu info
Matt Benjamin [Wed, 13 Dec 2023 18:53:46 +0000 (13:53 -0500)]
rgw: don't overwrite target attrs checking mpu info

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
16 months agosrc/rgw: fix for the multipart interface in the WORM function
daijufang [Mon, 4 Dec 2023 07:46:29 +0000 (07:46 +0000)]
src/rgw: fix for the multipart interface in the WORM function

1. Save the WORM configuration information in the initialization chunk information for use when merging chunks.
2. Support x-amz-bypass-governance-retention when merging chunks.

Fixes: https://tracker.ceph.com/issues/63724
Signed-off-by: daijufang <daijufang_yewu@cmss.chinamobile.com>
16 months agoMerge pull request #55594 from ifed01/wip-ifed-fix-64443
Igor Fedotov [Thu, 29 Feb 2024 16:07:10 +0000 (19:07 +0300)]
Merge pull request #55594 from ifed01/wip-ifed-fix-64443

test/store_test: fix DeferredWrite test when prefer_deferred_size=0

Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
16 months agoqa/tasks: replace uses of subst_vip with new templating function 55719/head
John Mulligan [Thu, 22 Feb 2024 18:51:16 +0000 (13:51 -0500)]
qa/tasks: replace uses of subst_vip with new templating function

Signed-off-by: John Mulligan <jmulligan@redhat.com>
16 months agoqa/tasks: add templating functions to cephadm module
John Mulligan [Thu, 22 Feb 2024 18:49:10 +0000 (13:49 -0500)]
qa/tasks: add templating functions to cephadm module

Add functions to cephadm.py that will be later used to template
strings within the yaml files in the cephadm suites. This will be used
to replace the specific subst_vip call with generic calls that let
tests access "any" variables stored on the test ctx.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
16 months agoqa/tasks: fix VIPs log line
John Mulligan [Tue, 20 Feb 2024 15:09:50 +0000 (10:09 -0500)]
qa/tasks: fix VIPs log line

While testing my previous patches were correct I noticed that the string
here was logged exactly as written, and was thus pretty useless.  This
was probably meant to be an f-string. So make it one. Also get rid of
the unnecessary map call, the list and IP address type can repr
themselves just fine IMO.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
16 months agoqa/tasks: make _map_vips private
John Mulligan [Tue, 20 Feb 2024 00:18:08 +0000 (19:18 -0500)]
qa/tasks: make _map_vips private

Nothing outside of vip.py called map_vips, so let us make sure this
is considered a private function and prefix it with the underscore.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
16 months agoqa/tasks: change map_vips to raise exceptions instead of returning None
John Mulligan [Tue, 20 Feb 2024 00:14:52 +0000 (19:14 -0500)]
qa/tasks: change map_vips to raise exceptions instead of returning None

None of the callers of map_vips ever checks for a None return. So
instead of handling any error conditions it would always just blow
up with a semi-obscure TypeError. Convert the function to always
raise an exception (one that tries to breifly explain the condition)
when something goes wrong. I also take the opportunity to make
more clearer logging and reduce an indentation level.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55534 from clwluvw/cephadm-device-class
Guillaume Abrioux [Thu, 29 Feb 2024 12:47:08 +0000 (13:47 +0100)]
Merge pull request #55534 from clwluvw/cephadm-device-class

cephadm: remove restriction for crush device classes

16 months agodoc/dev: edit internals.rst 55834/head
Zac Dover [Thu, 29 Feb 2024 07:40:57 +0000 (17:40 +1000)]
doc/dev: edit internals.rst

Edit doc/dev/internals.rst. Make a few sentences pithier.

Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agoMerge pull request #55806 from xxhdx1985126/wip-seastore-clone-attrs-omaps
Yingxin [Thu, 29 Feb 2024 05:49:33 +0000 (13:49 +0800)]
Merge pull request #55806 from xxhdx1985126/wip-seastore-clone-attrs-omaps

crimson/os/seastore: copy attrs and omaps when cloning objects

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
16 months agoMerge pull request #55771 from rhcs-dashboard/e2e-fix
Nizamudeen A [Thu, 29 Feb 2024 05:48:24 +0000 (11:18 +0530)]
Merge pull request #55771 from rhcs-dashboard/e2e-fix

mgr/dashboard: fix roles page for roles without policies

Reviewed-by: afreen23 <NOT@FOUND>
16 months agoMerge pull request #55510 from pcuzner/add-nvmeof-alerts
Aashish Sharma [Thu, 29 Feb 2024 05:06:58 +0000 (10:36 +0530)]
Merge pull request #55510 from pcuzner/add-nvmeof-alerts

ceph-mixin: Update mixin to include alerts for the nvmeof gateway(s)

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
16 months agoMerge pull request #55822 from dmick/wip-release-build-prerelease-update
Dan Mick [Thu, 29 Feb 2024 02:31:30 +0000 (18:31 -0800)]
Merge pull request #55822 from dmick/wip-release-build-prerelease-update

doc/dev/release-process.rst: modify for prerelease mechanism

16 months agodoc/dev/release-process.rst: modify for prerelease mechanism 55822/head
Dan Mick [Wed, 28 Feb 2024 02:59:46 +0000 (18:59 -0800)]
doc/dev/release-process.rst: modify for prerelease mechanism

Signed-off-by: Dan Mick <dmick@redhat.com>
16 months agoMerge pull request #55710 from rhcs-dashboard/nvmeof-prometheus-endpoint
Adam King [Wed, 28 Feb 2024 20:10:21 +0000 (15:10 -0500)]
Merge pull request #55710 from rhcs-dashboard/nvmeof-prometheus-endpoint

cephadm/nvmeof: scrape nvmeof prometheus endpoint

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Paul Cuzner <pcuzner@ibm.com>
16 months agoMerge pull request #55600 from adk3798/no-agent-workunits
Adam King [Wed, 28 Feb 2024 19:34:11 +0000 (14:34 -0500)]
Merge pull request #55600 from adk3798/no-agent-workunits

qa/cephadm: don't test certain workunits with agent

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55588 from adk3798/rm-cluster-podman-auth
Adam King [Wed, 28 Feb 2024 19:32:49 +0000 (14:32 -0500)]
Merge pull request #55588 from adk3798/rm-cluster-podman-auth

cephadm: rm podman-auth.json if removing last cluster

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55788 from rkachach/fix_issue_64596
Adam King [Wed, 28 Feb 2024 19:30:10 +0000 (14:30 -0500)]
Merge pull request #55788 from rkachach/fix_issue_64596

doc: adding documentation for secure monitoring stack configuration

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
16 months agoMerge pull request #55620 from adk3798/cephadm-timeout-cancelled-error
Adam King [Wed, 28 Feb 2024 18:43:12 +0000 (13:43 -0500)]
Merge pull request #55620 from adk3798/cephadm-timeout-cancelled-error

mgr/cephadm: catch CancelledError in asyncio timeout handler

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55650 from adk3798/cephadm-ceph-exporter-sock-dir
Adam King [Wed, 28 Feb 2024 18:41:06 +0000 (13:41 -0500)]
Merge pull request #55650 from adk3798/cephadm-ceph-exporter-sock-dir

cephadm: create ceph-exporter sock dir if it's not present

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55531 from roysahar/roys/wip-nvmeof-new-mount-for-logs
Adam King [Wed, 28 Feb 2024 18:26:45 +0000 (13:26 -0500)]
Merge pull request #55531 from roysahar/roys/wip-nvmeof-new-mount-for-logs

nvmeof: Add mount for log location

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Aviv Caro <Aviv.Caro@ibm.com>
16 months agosrc/test/common/test_hobject: remove constexpr 55817/head
rkhudov [Wed, 28 Feb 2024 17:27:39 +0000 (17:27 +0000)]
src/test/common/test_hobject: remove constexpr

Signed-off-by: rkhudov <rhudov@gmail.com>
16 months agoMerge pull request #55273 from pcuzner/add-nvmeof-to-autotune
Adam King [Wed, 28 Feb 2024 16:42:45 +0000 (11:42 -0500)]
Merge pull request #55273 from pcuzner/add-nvmeof-to-autotune

cephadm: Add nvmeof to autotuner calculation

Reviewed-by: Adam King <adking@redhat.com>
16 months agoMerge pull request #53840 from rhcs-dashboard/add-health-check-haproxy
Adam King [Wed, 28 Feb 2024 16:41:22 +0000 (11:41 -0500)]
Merge pull request #53840 from rhcs-dashboard/add-health-check-haproxy

mgr/cephadm is not defining haproxy tcp healthchecks for Ganesha

Reviewed-by: Adam King <adking@redhat.com>
16 months agoMerge pull request #55812 from ivoalmeida/add-snap-schedule-repeat-frequencies
Pedro Gonzalez Gomez [Wed, 28 Feb 2024 16:35:24 +0000 (17:35 +0100)]
Merge pull request #55812 from ivoalmeida/add-snap-schedule-repeat-frequencies

mgr/dashboard: add snap schedule M, Y frequencies

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agoMerge PR #55207 into main
Venky Shankar [Wed, 28 Feb 2024 15:43:44 +0000 (21:13 +0530)]
Merge PR #55207 into main

* refs/pull/55207/head:
mds: check file layout in mknod

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agodoc: adding documentation for secure monitoring stack configuration 55788/head
Redouane Kachach [Tue, 27 Feb 2024 14:52:25 +0000 (15:52 +0100)]
doc: adding documentation for secure monitoring stack configuration
Fixes: https://tracker.ceph.com/issues/64596
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
16 months agoMerge pull request #55794 from kamoltat/wip-ksirivad-ceph-backport-script
Kamoltat (Junior) Sirivadhna [Wed, 28 Feb 2024 14:57:05 +0000 (09:57 -0500)]
Merge pull request #55794 from kamoltat/wip-ksirivad-ceph-backport-script

src/scripts/ceph-backport.sh: Add PR checklist
Reviewed by: Laura Flores <lfores@ibm.com>

16 months agoMerge pull request #55809 from ivoalmeida/fix-snap-schedule-month
Pedro Gonzalez Gomez [Wed, 28 Feb 2024 14:37:14 +0000 (15:37 +0100)]
Merge pull request #55809 from ivoalmeida/fix-snap-schedule-month

mgr/dashboard: fix snap schedule date format

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agomgr/dashboard: add snap schedule M, Y frequencies 55812/head
Ivo Almeida [Mon, 26 Feb 2024 11:56:18 +0000 (11:56 +0000)]
mgr/dashboard: add snap schedule M, Y frequencies

Added M and Y (month and year) repeat frequencies to snap schedule
create form.

Fixes: https://tracker.ceph.com/issues/64614
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
16 months agomgr/dashboard: fix snap schedule date format 55809/head
Ivo Almeida [Wed, 28 Feb 2024 09:53:57 +0000 (09:53 +0000)]
mgr/dashboard: fix snap schedule date format

Fixes: https://tracker.ceph.com/issues/64613
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
16 months agocrimson/os/seastore: copy attrs and omaps when cloning objects 55806/head
Xuehan Xu [Wed, 28 Feb 2024 05:42:04 +0000 (13:42 +0800)]
crimson/os/seastore: copy attrs and omaps when cloning objects

At present, we just copy attrs and omaps one by one, which is not
efficient but very important in terms of functionality especially for
the teuthology tests

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
16 months agomgr/dashboard: fix roles page for roles without policies 55771/head
Nizamudeen A [Tue, 27 Feb 2024 07:18:56 +0000 (12:48 +0530)]
mgr/dashboard: fix roles page for roles without policies

If there is no permission policies attached to a role, it fails the
UI with an exception.

Fixes: https://tracker.ceph.com/issues/64588
Signed-off-by: Nizamudeen A <nia@redhat.com>
16 months agoMerge pull request #55757 from rhcs-dashboard/replace-piechart-panel-plugin-grafana
Nizamudeen A [Wed, 28 Feb 2024 05:42:33 +0000 (11:12 +0530)]
Merge pull request #55757 from rhcs-dashboard/replace-piechart-panel-plugin-grafana

mgr/dashboard: replace piechart plugin charts with native pie chart panel

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agoMerge PR #52258 into main
Venky Shankar [Wed, 28 Feb 2024 04:02:42 +0000 (09:32 +0530)]
Merge PR #52258 into main

* refs/pull/52258/head:
client: check mds down status bofore getting mds_gid_t from mdsmap
mgr/dashboard: allow sending back error status code fetching clients fails

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
16 months agoMerge pull request #55772 from xxhdx1985126/wip-seastore-attr-related-bug-fixes
Yingxin [Wed, 28 Feb 2024 03:38:16 +0000 (11:38 +0800)]
Merge pull request #55772 from xxhdx1985126/wip-seastore-attr-related-bug-fixes

crimson/os/seastore: two attrs related bug fixes

Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agoMerge pull request #55782 from zdover23/wip-doc-2024-02-27-rados-operations-add-or...
zdover23 [Tue, 27 Feb 2024 23:42:10 +0000 (09:42 +1000)]
Merge pull request #55782 from zdover23/wip-doc-2024-02-27-rados-operations-add-or-rm-mons

doc/rados: add "change public network" procedure

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agoMerge pull request #53222 from myoungwon/wip-62167
Kamoltat (Junior) Sirivadhna [Tue, 27 Feb 2024 20:55:12 +0000 (15:55 -0500)]
Merge pull request #53222 from myoungwon/wip-62167

osd: check if adjacent clones are unreadable when rollback is called.
Reviewed-by: athanatos
16 months agoMerge pull request #55147 from Matan-B/wip-matanb-skip-past-interval-cheeck
Kamoltat (Junior) Sirivadhna [Tue, 27 Feb 2024 20:54:45 +0000 (15:54 -0500)]
Merge pull request #55147 from Matan-B/wip-matanb-skip-past-interval-cheeck

osd/PeeringState: introduce osd_skip_check_past_interval_bounds
Reviewed-by athanatos

16 months agoMerge pull request #55227 from Svelar/wip-ci-clang
Kamoltat (Junior) Sirivadhna [Tue, 27 Feb 2024 20:54:01 +0000 (15:54 -0500)]
Merge pull request #55227 from Svelar/wip-ci-clang

ARM CI: clang should >= 12 for supporting C++20
Reviewed by: Laura Flores <lajefl@gmail.com>

16 months agosrc/scripts/ceph-backport.sh: Add PR checklist 55794/head
Kamoltat [Tue, 27 Feb 2024 19:21:57 +0000 (19:21 +0000)]
src/scripts/ceph-backport.sh: Add PR checklist

Signed-off-by: Kamoltat <ksirivad@redhat.com>
16 months agoMerge pull request #54872 from amathuria/wip-amat-mclock-adjust-deletion-cost
Yuri Weinstein [Tue, 27 Feb 2024 16:38:21 +0000 (08:38 -0800)]
Merge pull request #54872 from amathuria/wip-amat-mclock-adjust-deletion-cost

osd: Change PG Deletion cost for mClock

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
16 months agoMerge pull request #52891 from kamoltat/wip-ksirivad-fix-59172
Yuri Weinstein [Tue, 27 Feb 2024 16:37:34 +0000 (08:37 -0800)]
Merge pull request #52891 from kamoltat/wip-ksirivad-fix-59172

qa/tasks/ceph_manager.py: Rewrite test_pool_min_size

Reviewed-by: Samuel Just <sjust@redhat.com>
16 months agoMerge pull request #55760 from cbodley/wip-64568
Casey Bodley [Tue, 27 Feb 2024 16:05:51 +0000 (16:05 +0000)]
Merge pull request #55760 from cbodley/wip-64568

test/rgw: increase timeouts in unittest_rgw_dmclock_scheduler

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
16 months agomds: check file layout in mknod 55207/head
Yantao xue [Tue, 30 Jan 2024 09:14:43 +0000 (17:14 +0800)]
mds: check file layout in mknod
Fixes: https://tracker.ceph.com/issues/64061
Signed-off-by: Xue Yantao <xueyantao2114@163.com>
16 months agoMerge pull request #55752 from rhcs-dashboard/fix-vol-create
Pedro Gonzalez Gomez [Tue, 27 Feb 2024 12:27:23 +0000 (13:27 +0100)]
Merge pull request #55752 from rhcs-dashboard/fix-vol-create

mgr/dashboard: fix volume creation with multiple hosts

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agodoc/rados: add "change public network" procedure 55782/head
Zac Dover [Mon, 26 Feb 2024 10:03:48 +0000 (20:03 +1000)]
doc/rados: add "change public network" procedure

Add a procedure to /doc/rados/operations/add-or-rm-mons.rst that
explains how to change the public_network in a Ceph cluster deployed
with cephadm. This procedure was developed by Eugen Block, and can be
seen in its original form here:
https://heiterbiswolkig.blogs.nde.ag/2024/02/22/cephadm-change-public-network/

Co-authored-by: Eugen Block <eblock@nde.ag>
Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agocrimson/os/seastore: also remove xattrs when removing onodes 55772/head
Xuehan Xu [Tue, 27 Feb 2024 08:27:58 +0000 (16:27 +0800)]
crimson/os/seastore: also remove xattrs when removing onodes

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
16 months agomgr/dashboard: replace piechart plugin charts with native pie chart 55757/head
Aashish Sharma [Mon, 26 Feb 2024 09:32:19 +0000 (15:02 +0530)]
mgr/dashboard: replace piechart plugin charts with native pie chart
panel

Fixes: https://tracker.ceph.com/issues/64579
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
16 months agocrimson/os/seastore: get_attrs should return all attrs
Xuehan Xu [Tue, 27 Feb 2024 08:18:57 +0000 (16:18 +0800)]
crimson/os/seastore: get_attrs should return all attrs

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
16 months agocrimson/os/seastore: attr related debug outputs
Xuehan Xu [Tue, 27 Feb 2024 08:06:02 +0000 (16:06 +0800)]
crimson/os/seastore: attr related debug outputs

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
16 months agoMerge PR #52859 into main
Venky Shankar [Tue, 27 Feb 2024 05:53:13 +0000 (11:23 +0530)]
Merge PR #52859 into main

* refs/pull/52859/head:
qa: test cases to make sure invalid paths don't get updated
mgr/nfs: use helper to validate cephfs path
mgr/nfs: validate path before updating a cephfs export
mgr/nfs: add a helper to validate cephfs path

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge PR #54687 into main
Venky Shankar [Tue, 27 Feb 2024 05:50:54 +0000 (11:20 +0530)]
Merge PR #54687 into main

* refs/pull/54687/head:
mds: allow lock state to be LOCK_MIX_SYNC in replica for filelock

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge PR #55435 into main
Venky Shankar [Tue, 27 Feb 2024 05:47:13 +0000 (11:17 +0530)]
Merge PR #55435 into main

* refs/pull/55435/head:
qa: Fix fs/full suite

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #55751 from cyx1231st/wip-fix-test-socket
Samuel Just [Mon, 26 Feb 2024 23:26:00 +0000 (15:26 -0800)]
Merge pull request #55751 from cyx1231st/wip-fix-test-socket

test/crimson/test_socket: complete write-side errors in test_unexpected_down()

Reviewed-by: Samuel Just <sjust@redhat.com>
16 months agoceph-mixins: Update MIB to include nvmeof notification 55510/head
Paul Cuzner [Thu, 15 Feb 2024 22:56:03 +0000 (11:56 +1300)]
ceph-mixins: Update MIB to include nvmeof notification

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
16 months agoceph-mixins: Add test cases for nvmeof alerts
Paul Cuzner [Tue, 13 Feb 2024 00:55:24 +0000 (13:55 +1300)]
ceph-mixins: Add test cases for nvmeof alerts

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
16 months agoceph-mixins: nvmeof alerts added
Paul Cuzner [Tue, 13 Feb 2024 00:54:48 +0000 (13:54 +1300)]
ceph-mixins: nvmeof alerts added

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
16 months agoceph-mixins: Add nvmeof alerts
Paul Cuzner [Fri, 9 Feb 2024 04:00:28 +0000 (17:00 +1300)]
ceph-mixins: Add nvmeof alerts

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
16 months agomgr/cephadm: catch CancelledError in asyncio timeout handler 55620/head
Adam King [Fri, 16 Feb 2024 16:24:32 +0000 (11:24 -0500)]
mgr/cephadm: catch CancelledError in asyncio timeout handler

Specifically, concurrent.futures.CancelledError. At least on
python 3.9, this error can be raised when certain commands
being run asynchronously fail. Not catching this results in
the whole cephadm module crashing with something like

Traceback (most recent call last):
  File "/usr/share/ceph/mgr/cephadm/utils.py", line 94, in do_work
    return f(*arg)
  File "/usr/share/ceph/mgr/cephadm/serve.py", line 267, in refresh
    r = self._refresh_facts(host)
  File "/usr/share/ceph/mgr/cephadm/serve.py", line 370, in _refresh_facts
    val = self.mgr.wait_async(self._run_cephadm_json(
  File "/usr/share/ceph/mgr/cephadm/module.py", line 671, in wait_async
    return self.event_loop.get_result(coro, timeout)
  File "/usr/share/ceph/mgr/cephadm/ssh.py", line 64, in get_result
    return future.result(timeout)
  File "/lib64/python3.9/concurrent/futures/_base.py", line 444, in result
    raise CancelledError()
concurrent.futures._base.CancelledError

Fixes: https://tracker.ceph.com/issues/64473
Signed-off-by: Adam King <adking@redhat.com>
16 months agoMerge pull request #54999 from Matan-B/wip-matanb-mon-osd-epochs
Yuri Weinstein [Mon, 26 Feb 2024 15:47:57 +0000 (07:47 -0800)]
Merge pull request #54999 from Matan-B/wip-matanb-mon-osd-epochs

mon/OSDMonitor: fix get_min_last_epoch_clean()

Reviewed-by: Samuel Just <sjust@redhat.com>
16 months agotest/rgw: increase timeouts in unittest_rgw_dmclock_scheduler 55760/head
Casey Bodley [Mon, 26 Feb 2024 14:38:52 +0000 (09:38 -0500)]
test/rgw: increase timeouts in unittest_rgw_dmclock_scheduler

1ms sleeps are generally below the timer's resolution. increase run_for()
durations to 50ms to make the tests far less sensitive to timing. in
practice, none of the sleeps actually wait the full 50ms

Fixes: https://tracker.ceph.com/issues/64568
Signed-off-by: Casey Bodley <cbodley@redhat.com>
16 months agoclient: check mds down status bofore getting mds_gid_t from mdsmap 52258/head
yite.gu [Mon, 29 Jan 2024 10:26:20 +0000 (18:26 +0800)]
client: check mds down status bofore getting mds_gid_t from mdsmap

Get mds_gid_t from up of MDSMap, will cause to core dump if target
mds_rank_t does not exist up map:

from: src/mds/MDSMap.h
  const auto& get_info(mds_rank_t m) const {
    return mds_info.at(up.at(m));
  }

reproduct:
1. ceph fs fail <fs_name>
2. curl -X GET "example.com:8080/api/cephfs/1/clients" ...
up.at(m) will cause to core dump.

Fixes: https://tracker.ceph.com/issues/61844
Signed-off-by: Yite Gu <yitegu0@gmail.com>
16 months agoMerge pull request #55683 from lxbsz/wip-62837-new
Ilya Dryomov [Mon, 26 Feb 2024 09:17:25 +0000 (10:17 +0100)]
Merge pull request #55683 from lxbsz/wip-62837-new

doc/man/8/mount.ceph.rst: add more mount options

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>