qa/suites: add diff-continuous and compare-mirror-image tests

... to rbd and krbd suites respectively.

This allows the compare-mirror-image tests introduced in ea3a567
to be run against various kernel branches, e.g., testing branch.
And allows diff_continuous test in rbd_suite to run against distro
kernel.

Fixes: https://tracker.ceph.com/issues/64574
Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit 92b254138dd43755490392ffcf5ebca04872e116)

qa/suites/rbd: rename nbd folder to device folder

Signed-off-by: Ramana Raja <rraja@redhat.com>
(cherry picked from commit af43f6162464a20625319a2783a104f7032ba21e)

Merge pull request #56261 from zdover23/wip-doc-2024-03-19-backport-56247-to-squid

squid: docs/rbd: fix typo in arg name

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

docs/rbd: fix typo in arg name

Replace "{image-}" with "{image-id}" in the "rbd trash rm"
command description.

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit f3eb489520fd4fae057e61275d16c6c8fd596f3f)

docs/rbd: replace introspect with inspect

Replace "introspect" with "inspect" in the rbd basic commands
description.

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit ebf2f60f784728c04d8ec59015d666bafcef8218)

docs/rbd: typo in "retrieving image information"

Replace "for the image" with "of the image".

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit 4fd5c134536d652ae1f9e05ecf52cb81adb3b850)

Merge pull request #56255 from zdover23/wip-doc-2024-03-18-backport-56248-to-squid

squid: doc/rbd: minor changes to the rbd man page

doc/rbd: minor changes to the rbd man page

Fixes typos and grammar for some commands. Adds
additional details for some commandds.

Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit 5dcff6a4b8d835fc55e454af977dc5ebad99d37f)

Merge pull request #56251 from guits/wip-64931-squid

squid: node-proxy: fix RedFishClient.logout() method

node-proxy: support more Location value formats

After some tests, it turns out that depending on the hardware,
the header 'Location' which is returned by the server after logged can be different.
I could notice the following:

either:

Location: scheme://address:port/redfish/v1/SessionService/Session

or

Location: /redfish/v1/SessionService/Session

a previous tracker [1] was opened because I thought only the first one existed, which is wrong.

Fixes: https://tracker.ceph.com/issues/64951
[1] https://tracker.ceph.com/issues/64894

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit d7ccf26983c41344a12f33b2a30fc79b65cc548f)

node-proxy: fix RedFishClient.logout() method

the endpoint passed down to util.query() is wrong:
is passes the full url (scheme://addr:port/path) where it should only
pass the path. The cause is that RedFishClient.login() basically stores
the value of the Location header in `self.location`.

The consequence of this is that it makes the client unable to properly logout.

Fixes: https://tracker.ceph.com/issues/64894
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit b1d828d1d2f31c02f225bb375d915353582d158a)

Merge pull request #56125 from cbodley/wip-64834-squid

squid: RGW - Swift retarget needs bucket set on object

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #56144 from cbodley/wip-64876-squid

squid: rgw_lc:  replace strftime w/fmt and chrono:calendar

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #56156 from yuvalif/wip-64887-squid

squid: rgw/kafka: set message timeout to 5 seconds

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #56181 from ivancich/wip-64909-squid

squid: rgw: rgw-restore-bucket-index -- sort uses specified temp dir

Reviewed-by: Michael Kidd <linuxkidd@gmail.com>

Merge pull request #56216 from idryomov/wip-63770-squid

squid: librbd: account for discards that truncate in ObjectListSnapsRequest

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #55761 from ajarr/wip-64553-squid

squid: qa: Add tests to validate synced images on rbd-mirror

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #56234 from zdover23/wip-doc-2024-03-16-backport-56182-to-squid

squid: doc/glossary: add "librados" entry

doc/glossary: add "librados" entry

Add a "librados" entry to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2a93a8e837a42559f8a81c6fd9274b24f4fdf7f6)

Merge pull request #55715 from cbodley/wip-64541-squid

squid: rgw: RGWSI_SysObj_Cache::remove() invalidates after successful delete

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

rgwlc: implement Filter size limit checks

i.e., this implements ObjectSizeGreaterThan and ObjectSizeLessThan
for supported expiration and transition actions.

Fixes: https://tracker.ceph.com/issues/63304
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit c9b19be15362c63526e92f4d968f942a40cab150)

rgwlc: implement NewerNoncurrentVersions

Per AWS doc, this value controls "how many noncurrent versions
Amazon S3 will retain." [1]  We understand this to mean, retain
NewerNoncurrentVersions of any object, regardless of expiration.

Removed unused RGWLifecycleConfiguration::has_same_action() (cleanup)

[1] https://docs.aws.amazon.com/AmazonS3/latest/API/API_NoncurrentVersionExpiration.html.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit a4313e77a31c5165254068b53dfac3d277b0a6a8)

Merge pull request #56207 from zdover23/wip-doc-2024-03-15-backport-56188-to-squid

squid: doc/rbd: add clone mapping command

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

test/librbd: add DiffIterateTruncate and DiffIterateWriteAndTruncate

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit d84485ec534ccf42327242a9141906f4881c030e)

librbd: don't clip expanded diff on truncate in ObjectListSnapsRequest

If the diff was expanded due to LIST_SNAPS_FLAG_WHOLE_OBJECT, clipping
it when handling a truncate is wrong -- when subtracting that interval,
we either split the expanded extent into two or chop off a piece of it.
However the point of LIST_SNAPS_FLAG_WHOLE_OBJECT is to report a single
extent covering the entire object.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 0ebca5fe22d976f1a17f8078f20a47c49a057edb)

librados/snap_set_diff: ignore truncates above size at start

Because currently calc_snap_set_diff() only ever appends to the running
diff, an excessive (either too large or completely bogus) zero extent
is reported in cases where an object is first expanded (with a snapshot
taken at that point) and then truncated but still above the size of the
object as of the starting snapshot.

Fixes: https://tracker.ceph.com/issues/63770
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 5b11fb314abefea390c5663c33e9e1ace6179974)

Merge pull request #56155 from rhcs-dashboard/wip-64884-squid

squid: mgr/dashboard: fix snap schedule time format

Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/rbd: add clone mapping command

Add a command that explains how to map a formatted clone when the parent
image and the formatted clone have different encryption types.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit d34c1879c8886ec7f19c7a93490c4736ae9a6d20)

Merge pull request #56185 from zdover23/wip-doc-2024-03-14-backport-56160-to-squid

squid: doc/rbd: add map information for clone images to rbd-encryption.rst

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

doc/rbd: add map information for clone images to rbd-encryption.rst

Add information on the arguments required when mapping the
formatted clone of an encrypted parent image.

Co-authored-by: Zac Dover <zac.dover@proton.me>
Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit 7a2e324a6e1c3e145d3b1e04e6f006defbe0e0b4)

rgw: rgw-restore-bucket-index -- sort uses specified temp dir

The sort command sometimes makes use of temporary files. When the user
specifies a directory to be used for temp files, have the sort command
use that same directory.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit a14dad152c651ab8048f9e10898d4d2cc61b0d42)

rgw/kafka: set message timeout to 5 seconds

also increase the idle timeout to 30 seconds.
test instructions:
https://gist.github.com/yuvalif/33487bff19883e3409caa8a843a0b353

Fixes: https://tracker.ceph.com/issues/64710
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
(cherry picked from commit 1c13850f24dbb90c33a12c6da338956c2e83811b)

mgr/dashboard: fix snap schedule time format

Fixes: https://tracker.ceph.com/issues/64831
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit a2942f01ae9bde76c6d562374a0bd8aceeee317e)

Merge pull request #56116 from rhcs-dashboard/wip-64825-squid

squid: mgr/dashboard: fix snap schedule list toggle cols

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #56043 from cbodley/wip-64795-squid

squid: rgw: compatibility issues on BucketPublicAccessBlock

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

rgw_lc:  replace strftime w/fmt and chrono:calendar

It's reliably claimed that std::strftime is not
mt-safe, and this would be a likely root cause of
intermittent scrambled expiration header output cases
that have been reported.

Fixes: https://tracker.ceph.com/issues/63973
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
(cherry picked from commit 96a5cbb9aa47ed1a2b51e720475ebc08012cb4cc)

Merge pull request #56036 from cbodley/wip-64768-squid

squid: rgw_sigv4: handle '0;' as trailer-chunk boundary

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #56037 from cbodley/wip-64764-squid

squid: rgw/beast: Enable SSL session-id reuse speedup mechanism

Reviewed-by: Mark Kogan <mkogan@redhat.com>

Merge pull request #55871 from cbodley/wip-64661-squid

squid: rgw/auth: do_aws4_auth_completion() catches exceptions

Reviewed-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #55876 from cbodley/wip-64664-squid

squid: src/rgw: fix for the multipart interface in the WORM function

Reviewed-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #56048 from cbodley/wip-qa-rgw-squid-tests

squid: qa/rgw: point rgw test repos at ceph-squid release branch

Reviewed-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #55653 from cbodley/wip-64493-squid

squid: rgw/user: add 'active' flag to RGWAccessKey

Reviewed-by: Ali Maredia <amaredia@redhat.com>

Merge pull request #56009 from ivancich/wip-64773-squid

squid: rgw: make rgw-restore-bucket-index more robust

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #55816 from rhcs-dashboard/wip-64625-squid

squid: mgr/dashboard: fix snap schedule date format

Reviewed-by: Afreen <afreen23.git@gmail.com>

Merge pull request #55785 from rhcs-dashboard/wip-64594-squid

squid: mgr/dashboard: fix volume creation with multiple hosts

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #56126 from adk3798/wip-64838-squid

squid: mgr/dashboard: debugging make check failure

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #56129 from zdover23/wip-doc-2024-03-12-backport-56113-to-squid

squid: doc/cephadm: Improve multiple files

qa/workunits/rbd: switch rbd-mirror workunits to bash

By making use of here strings in commit ea3a567f7f03 ("qa/workunits:
make wait_for_status_in_pool_dir() reentrant") we grew a dependency on
bash.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 166a2362378b1ff93e43f483f354c428fd6cef9e)

Merge pull request #55941 from galsalomon66/wip-64694-squid

squid: rgw/s3select: Wip 64694 squid

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #55842 from ivancich/wip-squid-manifest

squid: rgw: add new `object manifest` sub-command

Reviewed-by: Casey Bodley <cbodley@redhat.com>

doc/cephadm: Improve multiple files

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 800dd29e60fcd2bcd27db56d3fe45c58ddf10c8a)

mgr/dashboard: debugging make check failure

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 958c60d8a74e3c38abe043e7f2cfbe4224cfb411)

RGW - Swift retarget needs bucket set on object

When a bucket list is retargeted to an object get, then the object may
not yet have it's bucket set.  Ensure the bucket is set on the object.

Fixes: https://tracker.ceph.com/issues/56029
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
(cherry picked from commit 2d4a3ca5c94908a6865dce0192677d8346e1f848)

Merge pull request #56060 from rhcs-dashboard/wip-64808-squid

squid: mgr/dashboard: add snap schedule M, Y frequencies

Reviewed-by: afreen23 <NOT@FOUND>

mgr/dashboard: fix snap schedule list toggle cols

Added isInvisible property to CdColumnTable interface to hide column
from 'toggle columns' drop down checkboxes.

Fixes: https://tracker.ceph.com/issues/64813
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit 1b77baea8dd0781fa897ec6c1f1e06c57a265ed7)

Merge pull request #56110 from zdover23/wip-doc-2024-03-11-backport-56091-to-squid

squid: doc/cephadm: improve host-management.rst

doc/cephadm: improve host-management.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 9fb51bb537e8bd9ea60633091acfc48a58262c3b)

Merge pull request #56072 from zdover23/wip-doc-2024-03-09-backport-56068-to-squid

squid: doc/glossary: add "Crimson" entry

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

doc/glossary: add "Crimson" entry

Add a "Crimson" entry to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b31e061cc087b31a7e9e841dd21e7403a2197378)

Merge pull request #56039 from zdover23/wip-doc-2024-03-08-backport-56010-to-squid

squid: doc/start: add Slack invite link

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #55998 from guits/wip-64749-squid

squid: mgr/node-proxy: handle 'None' statuses returned by RedFish

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #56056 from zdover23/wip-doc-2024-03-08-backport-56045-to-squid

squid: doc/rados: restore PGcalc tool

mgr/dashboard: add snap schedule M, Y frequencies

Added M and Y (month and year) repeat frequencies to snap schedule
create form.

Fixes: https://tracker.ceph.com/issues/64614
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit be3bb09cca7ff8d10a36a59702bb16fd10aba84e)

doc/rados: restore PGcalc tool

Restore the PGcalc tool to the documentation suite.

Co-authored-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit eaaf72253123de1a66f163f651046817faa97a1a)

qa/rgw: point rgw test repos at ceph-squid release branch

Signed-off-by: Casey Bodley <cbodley@redhat.com>

rgw: return 204 on bucket public access block deletion

According to AWS doc (https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeletePublicAccessBlock.html#API_DeletePublicAccessBlock_ResponseSyntax) 204 shall be returned on delete request.

Fixes: https://tracker.ceph.com/issues/64492
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 48a454971c9979dfd9a95cc9619ca864aeda26a5)

rgw: return 404 on no bucket public access block

Return 404 when there is no public access block on the bucket.

Fixes: https://tracker.ceph.com/issues/64492
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 146d4d98698d48dcbc0f036de0793e0a5f9bb8a6)

rgw: fix the op in GetBucketPublicAccessBlock verify_permission

s3GetBucketPublicAccessBlock needs to be checked for RGWGetBucketPublicAccessBlock operation.

Fixes: https://tracker.ceph.com/issues/64492
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 54bc5eba002cff04e5c4e25168aeb2408ba100b2)

rgw: fix root element for GetPublicAccessBlock

From the AWS doc (https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetPublicAccessBlock.html) it needs to be PublicAccessBlockConfiguration.

Fixes: https://tracker.ceph.com/issues/64492
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit db74c10e008caeb7092eb4c1268cbd6f044afa19)

doc/start: add Slack invite link

Add a link to the ceph-storage Slack invitation page. Previously the
link went to a plain old "this is the ceph-storage Slack" page that did
not direct the reader to sign up.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dee319e61204b2ee9ac13562c2c7075ef0f2ea4b)

Merge pull request #56011 from zdover23/wip-doc-2024-03-07-backport-55995-to-squid

squid: doc/architecture: correct typo

rgw/beast: enablment of SSL session-id reuse speedup mechanism

Enable the OpenSSL session-id reuse acceleration mechanism that is described in:

https://www.openssl.org/docs/man1.0.2/man3/SSL_CTX_set_session_id_context.html
SSL_CTX_set_session_id_context, SSL_set_session_id_context - set context
within which session can be reused (server side only)

Fixes: https://tracker.ceph.com/issues/64719
Signed-off-by: Mark Kogan <mkogan@redhat.com>
(cherry picked from commit 6fb4c5d0c0694c9cfdbf0ed729d9f95886a0673f)

Merge pull request #55926 from idryomov/wip-pr-55897-squid

squid: src/seastar: update seastar submodule to fix FTBFS

Reviewed-by: Kefu Chai <kefu.chai@scylladb.com>

rgw_sigv4: handle '0;' as trailer-chunk boundary

https://tracker.ceph.com/issues/64676

Signed-off-by: matt benjamin <mbenjamin@redhat.com>
(cherry picked from commit ef1111a17084f6672fd40e366f92f8168a09d0a0)

Merge pull request #55992 from rhcs-dashboard/wip-64731-squid

squid: mgr/dashboard: fixed cephfs mount command

Reviewed-by: Nizamudeen A <nia@redhat.com>

doc/architecture: correct typo

s/client/clients/ where necessary, and add a link to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ae08855cf870173dce2a47a28f3bbb22e7ae0ca2)

rgw: make rgw-restore-bucket-index more robust

This experimental tool write a series of temporary files, the combined
size of which is roughly proportional to some combination of the
number of objects in the bucket and their respective sizes. Previously
the script stored all temporary files in /tmp, which may not be
sufficiently large in many cases.

There are now two enhancements. First, using the "-t" command-line
argument, the directory for temporary files can be specified. Second,
if the script consumes all available space on the file system
containing the temporary directory, an error message to that effect is
displayed, so the user understands what corrective action to take.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
(cherry picked from commit a8cf37b6e8e33c53d9be4cc1998d3b2f80700fbd)

Merge pull request #56001 from zdover23/wip-doc-2024-03-07-backport-55982-to-squid

squid: doc/dev: edit teuthology workflow

doc/dev: edit teuthology workflow

Improve a couple of sentences in
doc/dev/developer_guide_testing_integration_tests/tests-integration-testing-teutology-workflow.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 51796e80f35da8ca13b72f31eeafefd4c1e40773)

mgr/node-proxy: handle 'None' statuses returned by RedFish

Looks like RedFish might return 'None' values for some attributes.

for instance:

```
[root@ceph-node-01 ~]# curl -s -k -X GET https://169.254.1.1/redfish/v1/Systems/System.Embedded.1/Storage/AHCI.SL.6-1/Drives/Disk.Direct.0-0:AHCI.SL.6-1 -H "X-Auth-Token: 3264251c28191fa5e7c9ebec49ef90fc"  | jq .Status
{
  "Health": "OK",
  "HealthRollup": "OK",
  "State": "Enabled"
}
[root@ceph-node-01 ~]# curl -s -k -X GET https://169.254.1.1/redfish/v1/Systems/System.Embedded.1/Storage/NonRAID.Slot.2-1/Drives/Disk.Bay.0:Enclosure.Internal.0-1:NonRAID.Slot.2-1 -H "X-Auth-Token: 3264251c28191fa5e7c9ebec49ef90fc" | jq .Status
{
  "Health": null,
  "HealthRollup": null,
  "State": "Enabled"
}
[root@ceph-node-01 ~]#
```

Although this seems to be a bug from RedFish, we need to handle
the case when it happens otherwise it makes the mgr orchestrator module
throw an error.

The idea here is to create a new status "unknown" when we can't fetch the
real status of a component.

Fixes: https://tracker.ceph.com/issues/64712
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit cc279a3dd23d9219e508b80512f363a4ae577392)

mgr/dashboard: fixed cephfs mount command

Fixes: https://tracker.ceph.com/issues/64716
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit eeb09b19581d353fb68f86bb4c2871f026a35c29)

using the it.length() for segment processing.
s3select submodule

Signed-off-by: Gal Salomon <gal.salomon@gmail.com>
(cherry picked from commit 8fedb30c1bd6cd393becf88f8d2fe07ea9c6040c)

add a fix related to RGW crash upon compression (assert is replaced by exception)

Signed-off-by: Gal Salomon <gal.salomon@gmail.com>
(cherry picked from commit 9d8f5d7132741c996a3f66d62a8ec9e9a34fa0c0)

adding recent update: json-output and more

Signed-off-by: Gal Salomon <gal.salomon@gmail.com>
(cherry picked from commit f50385ef71a3d0ac175018cb070dbf2e767e6ed3)

Merge pull request #55935 from zdover23/wip-doc-2024-03-05-backport-55918-to-squid

squid: doc/rados: link to pg setting commands

Merge pull request #55932 from zdover23/wip-doc-2024-03-05-backport-55924-to-squid

squid: doc/architecture: remove pleonasm

doc/rados: link to pg setting commands

Link to the instructions for manually setting the number of PGs per
pool, from the mention of placement groups. These instructions are
included here in response to a request from Ronen Friedman on the
occasion of the removal of links to the PGcalc (see
https://github.com/ceph/ceph/pull/55899#pullrequestreview-1912940118).

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9da81b87ca161370c869b49f5d4e6b50edd54a0e)

doc/architecture: remove pleonasm

Remove the word "detailed" in a sentence immediately following a
sentence containing the word "detail".

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 7791509741d8c21e273a46374a087dcca53a2816)

Merge pull request #55893 from petrutlucian94/wip-64675-squid

squid: rbd-wnbd: use a single daemon process per host

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

src/seastar: update seastar submodule to fix FTBFS

See: https://github.com/ceph/seastar/commit/d382f247629a7349afc0cea495a1cd0502dc0b22

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit 945b18195465583334cb88ba69c12bbf42aedd6d)

Merge pull request #55873 from cbodley/wip-64663-squid

squid: unittest-seastar-socket: tolerate connection_reset in test_unexpected_down

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #55907 from idryomov/wip-64589-squid

squid: crimson: update seastar submodule to fix prometheus build error

Reviewed-by: Samuel Just <sjust@redhat.com>

crimson/.../interruptible_future: remove SEASTAR_CONCEPT guard

Seastar commit 8dc3398a removed this macro, no longer necessary.

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 2806cdb15109c391c828b3419e9d141991d4003d)

src/seastar: update seastar submodule to fix prometheus build failure

Fixes: https://tracker.ceph.com/issues/64589
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 7f42b1d0b7295c2b62d204d14ebe38b6654ba0ac)

Merge pull request #55900 from zdover23/wip-doc-2024-03-03-backport-55899-to-squid

squid: doc/rados: remove PGcalc from docs

doc/rados: remove PGcalc from docs

Remove mention of the "PG calc" tool from the documentation. I have
removed all mention of this in one fell swoop to help posterity restore
mention of this tool if we decide we need to do so.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ccb851d2a431647124754e1252df66ed11d0e900)

rbd-wnbd: use the right AdminSocket instance

The rbd-wnbd daemon currently caches one rados context per cluster.
However, it's registering hooks against the global context
admin socket, which won't be available. For this reason,
the "rbd-wnbd stats" command no longer works.

To address this issue, we'll ensure that rbd-wnbd sets command hooks
against the right admin socket instance, leveraging the image
context.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
(cherry picked from commit a14003c492ad26ed4eef13e3d73e42212dd2bd93)

rbd-wnbd: adjust admin socket hook to accept image path

For each rbd-wnbd mapping we set an admin socket hook that can
be used to retrieve IO stats.

Now that the same daemon is reused for multiple mappings, we need
to distinguish the images when receiving a "stats" request.

For this reason, we'll add the image identifier to "wnbd stats"
admin socket commands.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
(cherry picked from commit 83d58ab307063b4a37f3a297af2b0e6ba27e84dc)

qa: update rbd-wnbd test, retrying image rm operations

The "rbd-wnbd unmap" command is currently telling the WNBD driver
to remove the mapping without contacting the rbd-wnbd daemon
and waiting for it to perform its cleanup.

For this reason, attempting to delete the image immediately after
unmapping it can fail due to existing watchers.

As a temporary solution, we'll retry the image remove operation.
At a later time, we'll update the "rbd-wnbd unmap" command to go
through the rbd-wnbd daemon, ensuring that all the necessary
cleanup is performed before returning.

While at it, we're dropping a redundant LOG.error call so that we
won't print expected exceptions.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
(cherry picked from commit 0d73d31b6f92d45c602d704b39d11d11536b0a93)

rbd-wnbd: update registry settings handling

This commit will store the mapping config in the Windows registry
only after initializing the mapping. This ensures that we aren't
replacing the registry settings for already mapped images.

We'll also check if the registry setting was added by us before
cleaning it up.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
(cherry picked from commit 5f9c69d53c522f3b939c91c974cedb9fdd085a60)

rbd-wnbd: use one daemon process per host

We're currently using one rbd-wnbd process per image mapping.
Since OSD connections aren't shared across those processes,
we end up with an excessive amount of TCP sessions, potentially
exceeding Windows limits:
https://ask.cloudbase.it/question/3598/ceph-for-windows-tcp-session-count/

In order to improve rbd-wnbd's scalability, we're going to use
a single process per host (unless "-f" is passed when mapping the
image, in which case the daemon will run as part of the same
process). This allows OSD sessions to be shared across image
mappings.

Another advantage is that the "ceph-rbd" service starts faster,
especially when having a large number of image mappings.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
(cherry picked from commit 661c55002db8bc91037d8150278dacb9a1cfe46b)

rbd-wnbd: introduce RbdMapping class

We're moving most of the WNBD mapping handling to a separate
class called RbdMapping. This simplifies cleanup and makes it
easier to reuse.

The WnbdHandler class covers WNBD specific operations and IO
callbacks while the RbdMapping wrapper will take care of RBD
operations.

A subsequent change will make use of it while switching from
one process per mapping to a single process per host.

While at it, we're also moving the rbd-wnbd config helpers
to separate files.

Signed-off-by: Lucian Petrut <lpetrut@cloudbasesolutions.com>
(cherry picked from commit 96e8850ff3b6661c86eb361051282c8d66ca2031)