]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
16 months agocephadm: fix get_version for nvmeof 56099/head
Adam King [Mon, 29 Jan 2024 16:23:54 +0000 (11:23 -0500)]
cephadm: fix get_version for nvmeof

This needed to be using the container id it was
passed, instead of ctx.image which is likely to
be `None` when this is run.

Fixes: https://tracker.ceph.com/issues/64229
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 70c00e8ba787d9e9106934cfee0e0afa606ce326)

Conflicts:
src/cephadm/cephadmlib/daemons/nvmeof.py

16 months agoMerge pull request #56073 from zdover23/wip-doc-2024-03-09-backport-56068-to-reef
zdover23 [Sat, 9 Mar 2024 13:39:02 +0000 (23:39 +1000)]
Merge pull request #56073 from zdover23/wip-doc-2024-03-09-backport-56068-to-reef

reef: doc/glossary: add "Crimson" entry

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
16 months agodoc/glossary: add "Crimson" entry 56073/head
Zac Dover [Fri, 8 Mar 2024 17:17:59 +0000 (03:17 +1000)]
doc/glossary: add "Crimson" entry

Add a "Crimson" entry to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b31e061cc087b31a7e9e841dd21e7403a2197378)

16 months agoMerge pull request #56041 from zdover23/wip-doc-2024-03-08-backport-56010-to-reef
zdover23 [Sat, 9 Mar 2024 05:11:18 +0000 (15:11 +1000)]
Merge pull request #56041 from zdover23/wip-doc-2024-03-08-backport-56010-to-reef

reef: doc/start: add Slack invite link

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agodoc/start: add Slack invite link 56041/head
Zac Dover [Thu, 7 Mar 2024 03:01:47 +0000 (13:01 +1000)]
doc/start: add Slack invite link

Add a link to the ceph-storage Slack invitation page. Previously the
link went to a plain old "this is the ceph-storage Slack" page that did
not direct the reader to sign up.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dee319e61204b2ee9ac13562c2c7075ef0f2ea4b)

16 months agoMerge pull request #55999 from guits/wip-64750-reef
Adam King [Fri, 8 Mar 2024 20:16:25 +0000 (15:16 -0500)]
Merge pull request #55999 from guits/wip-64750-reef

reef: mgr/node-proxy: handle 'None' statuses returned by RedFish

Reviewed-by: Adam King <adking@redhat.com>
16 months agoMerge pull request #56057 from zdover23/wip-doc-2024-03-08-backport-56045-to-reef
Anthony D'Atri [Fri, 8 Mar 2024 15:59:56 +0000 (10:59 -0500)]
Merge pull request #56057 from zdover23/wip-doc-2024-03-08-backport-56045-to-reef

reef: doc/rados: restore PGcalc tool

16 months agodoc/rados: restore PGcalc tool 56057/head
Zac Dover [Thu, 7 Mar 2024 17:29:50 +0000 (03:29 +1000)]
doc/rados: restore PGcalc tool

Restore the PGcalc tool to the documentation suite.

Co-authored-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit eaaf72253123de1a66f163f651046817faa97a1a)

16 months agoMerge pull request #56012 from zdover23/wip-doc-2024-03-07-backport-55995-to-reef
Anthony D'Atri [Thu, 7 Mar 2024 15:35:00 +0000 (10:35 -0500)]
Merge pull request #56012 from zdover23/wip-doc-2024-03-07-backport-55995-to-reef

reef: doc/architecture: correct typo

16 months agoMerge pull request #55640 from vshankar/wip-64485-reef
Venky Shankar [Thu, 7 Mar 2024 06:40:19 +0000 (12:10 +0530)]
Merge pull request #55640 from vshankar/wip-64485-reef

reef: mds,cephfs_mirror: add labelled per-client and replication metrics

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #55395 from dparmar18/wip-63691-reef
Venky Shankar [Thu, 7 Mar 2024 06:40:04 +0000 (12:10 +0530)]
Merge pull request #55395 from dparmar18/wip-63691-reef

reef: mgr/(object_format && nfs/export): enhance nfs export update failure response

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #55302 from neesingh-rh/wip-64144-reef
Venky Shankar [Thu, 7 Mar 2024 06:39:05 +0000 (12:09 +0530)]
Merge pull request #55302 from neesingh-rh/wip-64144-reef

reef: qa: fix rank_asok() to handle errors from asok commands

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #54538 from aaSharma14/wip-63571-reef
Nizamudeen A [Thu, 7 Mar 2024 05:18:56 +0000 (10:48 +0530)]
Merge pull request #54538 from aaSharma14/wip-63571-reef

reef: mgr/dashboard: Show the OSDs Out and Down panels as red whenever an OSD is in Out or Down state in Ceph Cluster grafana dashboard

Reviewed-by: Ejdesgaard <NOT@FOUND>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
16 months agoMerge pull request #55993 from rhcs-dashboard/wip-64732-reef
Nizamudeen A [Thu, 7 Mar 2024 04:31:37 +0000 (10:01 +0530)]
Merge pull request #55993 from rhcs-dashboard/wip-64732-reef

reef: mgr/dashboard: fixed cephfs mount command

Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agodoc/architecture: correct typo 56012/head
Zac Dover [Wed, 6 Mar 2024 11:40:10 +0000 (21:40 +1000)]
doc/architecture: correct typo

s/client/clients/ where necessary, and add a link to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ae08855cf870173dce2a47a28f3bbb22e7ae0ca2)

16 months agoMerge pull request #56002 from zdover23/wip-doc-2024-03-07-backport-55982-to-reef
Anthony D'Atri [Wed, 6 Mar 2024 18:39:47 +0000 (13:39 -0500)]
Merge pull request #56002 from zdover23/wip-doc-2024-03-07-backport-55982-to-reef

reef: doc/dev: edit teuthology workflow

16 months agoMerge pull request #55836 from vshankar/wip-reef-raw-cluster-cmd
Yuri Weinstein [Wed, 6 Mar 2024 16:05:37 +0000 (08:05 -0800)]
Merge pull request #55836 from vshankar/wip-reef-raw-cluster-cmd

reef: use raw_cluster_cmd instead of run_ceph_cmd

Reviewed-by: Rishabh Dave <ridave@redhat.com>
16 months agoMerge pull request #55943 from vshankar/wip-64705-reef
Yuri Weinstein [Wed, 6 Mar 2024 16:04:37 +0000 (08:04 -0800)]
Merge pull request #55943 from vshankar/wip-64705-reef

reef: qa: remove error string checks and check w/ return value

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #55300 from neesingh-rh/wip-64098-reef
Yuri Weinstein [Wed, 6 Mar 2024 16:01:21 +0000 (08:01 -0800)]
Merge pull request #55300 from neesingh-rh/wip-64098-reef

reef: src/mount: kernel mount command returning misleading error message

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #54467 from lxbsz/wip-63262
Yuri Weinstein [Wed, 6 Mar 2024 15:59:15 +0000 (07:59 -0800)]
Merge pull request #54467 from lxbsz/wip-63262

reef: mds: fix issuing redundant reintegrate/migrate_stray requests

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agodoc/dev: edit teuthology workflow 56002/head
Zac Dover [Wed, 6 Mar 2024 07:15:20 +0000 (17:15 +1000)]
doc/dev: edit teuthology workflow

Improve a couple of sentences in
doc/dev/developer_guide_testing_integration_tests/tests-integration-testing-teutology-workflow.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 51796e80f35da8ca13b72f31eeafefd4c1e40773)

16 months agomgr/node-proxy: handle 'None' statuses returned by RedFish 55999/head
Guillaume Abrioux [Tue, 5 Mar 2024 10:05:18 +0000 (10:05 +0000)]
mgr/node-proxy: handle 'None' statuses returned by RedFish

Looks like RedFish might return 'None' values for some attributes.

for instance:

```
[root@ceph-node-01 ~]# curl -s -k -X GET https://169.254.1.1/redfish/v1/Systems/System.Embedded.1/Storage/AHCI.SL.6-1/Drives/Disk.Direct.0-0:AHCI.SL.6-1 -H "X-Auth-Token: 3264251c28191fa5e7c9ebec49ef90fc"  | jq .Status
{
  "Health": "OK",
  "HealthRollup": "OK",
  "State": "Enabled"
}
[root@ceph-node-01 ~]# curl -s -k -X GET https://169.254.1.1/redfish/v1/Systems/System.Embedded.1/Storage/NonRAID.Slot.2-1/Drives/Disk.Bay.0:Enclosure.Internal.0-1:NonRAID.Slot.2-1 -H "X-Auth-Token: 3264251c28191fa5e7c9ebec49ef90fc" | jq .Status
{
  "Health": null,
  "HealthRollup": null,
  "State": "Enabled"
}
[root@ceph-node-01 ~]#
```

Although this seems to be a bug from RedFish, we need to handle
the case when it happens otherwise it makes the mgr orchestrator module
throw an error.

The idea here is to create a new status "unknown" when we can't fetch the
real status of a component.

Fixes: https://tracker.ceph.com/issues/64712
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit cc279a3dd23d9219e508b80512f363a4ae577392)

16 months agomgr/dashboard: fixed cephfs mount command 55993/head
Ivo Almeida [Tue, 5 Mar 2024 12:37:21 +0000 (12:37 +0000)]
mgr/dashboard: fixed cephfs mount command

Fixes: https://tracker.ceph.com/issues/64716
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit eeb09b19581d353fb68f86bb4c2871f026a35c29)

16 months agoqa: remove error string checks and check w/ return value 55943/head
Venky Shankar [Thu, 25 Jan 2024 09:32:33 +0000 (15:02 +0530)]
qa: remove error string checks and check w/ return value

I ran into this failure once #54972 was merged. The test is validating
the error string returned due to the failed mount. There aren't any
return value checks - which is a _more_ important check. Generic error
string checks will fail once a (error) string is changed (typo, etc..).

Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 7cd17931b1690029d182954b0382acc45b9ccb2b)

16 months agoMerge pull request #55936 from zdover23/wip-doc-2024-03-05-backport-55918-to-reef
Anthony D'Atri [Tue, 5 Mar 2024 00:57:19 +0000 (19:57 -0500)]
Merge pull request #55936 from zdover23/wip-doc-2024-03-05-backport-55918-to-reef

reef: doc/rados: link to pg setting commands

16 months agoMerge pull request #55933 from zdover23/wip-doc-2024-03-05-backport-55924-to-reef
Anthony D'Atri [Tue, 5 Mar 2024 00:52:19 +0000 (19:52 -0500)]
Merge pull request #55933 from zdover23/wip-doc-2024-03-05-backport-55924-to-reef

reef: doc/architecture: remove pleonasm

16 months agodoc/rados: link to pg setting commands 55936/head
Zac Dover [Mon, 4 Mar 2024 10:41:16 +0000 (20:41 +1000)]
doc/rados: link to pg setting commands

Link to the instructions for manually setting the number of PGs per
pool, from the mention of placement groups. These instructions are
included here in response to a request from Ronen Friedman on the
occasion of the removal of links to the PGcalc (see
https://github.com/ceph/ceph/pull/55899#pullrequestreview-1912940118).

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9da81b87ca161370c869b49f5d4e6b50edd54a0e)

16 months agodoc/architecture: remove pleonasm 55933/head
Zac Dover [Mon, 4 Mar 2024 13:41:20 +0000 (23:41 +1000)]
doc/architecture: remove pleonasm

Remove the word "detailed" in a sentence immediately following a
sentence containing the word "detail".

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 7791509741d8c21e273a46374a087dcca53a2816)

16 months agoMerge pull request #55709 from mcv21/wip-64509-reef
Yuri Weinstein [Mon, 4 Mar 2024 19:12:36 +0000 (11:12 -0800)]
Merge pull request #55709 from mcv21/wip-64509-reef

reef: debian/*.postinst: add adduser as a dependency and specify --home when adduser

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
16 months agoMerge pull request #55901 from zdover23/wip-doc-2024-03-03-backport-55899-to-reef
Anthony D'Atri [Sun, 3 Mar 2024 13:06:51 +0000 (08:06 -0500)]
Merge pull request #55901 from zdover23/wip-doc-2024-03-03-backport-55899-to-reef

reef: doc/rados: remove PGcalc from docs

16 months agodoc/rados: remove PGcalc from docs 55901/head
Zac Dover [Sun, 3 Mar 2024 10:28:00 +0000 (20:28 +1000)]
doc/rados: remove PGcalc from docs

Remove mention of the "PG calc" tool from the documentation. I have
removed all mention of this in one fell swoop to help posterity restore
mention of this tool if we decide we need to do so.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ccb851d2a431647124754e1252df66ed11d0e900)

16 months agoMerge pull request #54879 from batrick/wip-63796-reef
Yuri Weinstein [Sat, 2 Mar 2024 00:02:45 +0000 (16:02 -0800)]
Merge pull request #54879 from batrick/wip-63796-reef

reef: pybind/mgr/devicehealth: replace SMART data if exists for same DATETIME

Reviewed-by: Laura Flores <lflores@redhat.com>
16 months agoMerge pull request #55880 from zdover23/wip-doc-2024-03-02-backport-55869-to-reef
Anthony D'Atri [Fri, 1 Mar 2024 23:59:20 +0000 (18:59 -0500)]
Merge pull request #55880 from zdover23/wip-doc-2024-03-02-backport-55869-to-reef

reef: doc/install: add manual RADOSGW install procedure

16 months agoMerge pull request #54122 from batrick/wip-63277-reef
Yuri Weinstein [Fri, 1 Mar 2024 23:57:21 +0000 (15:57 -0800)]
Merge pull request #54122 from batrick/wip-63277-reef

reef: cmake: use or turn off liburing for rocksdb

Reviewed-by: Laura Flores <lflores@redhat.com>
16 months agodoc/install: add manual RADOSGW install procedure 55880/head
Zac Dover [Fri, 1 Mar 2024 12:11:14 +0000 (22:11 +1000)]
doc/install: add manual RADOSGW install procedure

Add a manual RADOSGW installation procedure to
doc/install/manual-deployment.rst. This procedure was developed by Janne
Johansson and reported to the ceph-users mailing list on 29 Jan 2024
here: https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/message/LB3YRIKAPOHXYCW7MKLVUJPYWYRQVARU/

Co-authored-by: Janne Johansson <icepic.dz@gmail.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 565bc9503838906995fa48f59debcd2843775b18)

16 months agoMerge pull request #55827 from afreen23/wip-64640-reef
Nizamudeen A [Fri, 1 Mar 2024 05:14:50 +0000 (10:44 +0530)]
Merge pull request #55827 from afreen23/wip-64640-reef

reef: mgr/dashboard: fix roles page for roles without policies

Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agoMerge pull request #55852 from zdover23/wip-doc-2024-03-01-backport-55834-to-reef
Anthony D'Atri [Fri, 1 Mar 2024 01:34:52 +0000 (20:34 -0500)]
Merge pull request #55852 from zdover23/wip-doc-2024-03-01-backport-55834-to-reef

reef: doc/dev: edit internals.rst

16 months agodoc/dev: edit internals.rst 55852/head
Zac Dover [Thu, 29 Feb 2024 07:40:57 +0000 (17:40 +1000)]
doc/dev: edit internals.rst

Edit doc/dev/internals.rst. Make a few sentences pithier.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit e16ab1df72c3640db907e377da7ca97ce3eaa26e)

16 months agoMerge pull request #55849 from zdover23/wip-doc-2024-03-01-backport-55835-to-reef
Anthony D'Atri [Thu, 29 Feb 2024 23:46:53 +0000 (18:46 -0500)]
Merge pull request #55849 from zdover23/wip-doc-2024-03-01-backport-55835-to-reef

reef: doc/glossary: improve "MDS" entry

16 months agodoc/glossary: improve "MDS" entry 55849/head
Zac Dover [Thu, 29 Feb 2024 08:08:10 +0000 (18:08 +1000)]
doc/glossary: improve "MDS" entry

Improve the entry for "MDS" in doc/glossary.rst by linking to the
"ceph-mds" man page and mentioning the relationship between clients and
MDS (or MDSes).

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2c6983d8b4e841f2bfbc4e4f82bb0e41e10aec7e)

16 months agoMerge pull request #55712 from rzarzynski/wip-64406-reef
Yuri Weinstein [Thu, 29 Feb 2024 21:24:56 +0000 (13:24 -0800)]
Merge pull request #55712 from rzarzynski/wip-64406-reef

reef: src/osd/OSDMap.cc: Fix encoder to produce same bytestream

Reviewed-by: Kamoltat (Junior) Sirivadhna <ksirivad@redhat.com>
16 months agoMerge PR #55669 into reef
Patrick Donnelly [Thu, 29 Feb 2024 14:18:45 +0000 (09:18 -0500)]
Merge PR #55669 into reef

* refs/pull/55669/head:
qa: test fuse/kclient for mds upgrade seq
qa: ignore OSD_DOWN during cephadm upgrades
qa: ignore warning "Replacing daemon"
qa: ignore MDS_INSUFFICIENT_STANDBY
qa: remove ignorelist error parenthesis
mds: update comment on kclient decoding of MDSMap
qa: do upgrades from quincy and older reef minor releases
mds: reverse MDSMap encoding of max_xattr_size/bal_rank_mask

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #55811 from rhcs-dashboard/wip-64610-reef
Nizamudeen A [Thu, 29 Feb 2024 11:08:57 +0000 (16:38 +0530)]
Merge pull request #55811 from rhcs-dashboard/wip-64610-reef

reef: mgr/dashboard: fix subvolume group edit

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
16 months agoreef: use raw_cluster_cmd instead of run_ceph_cmd 55836/head
Venky Shankar [Thu, 29 Feb 2024 10:31:24 +0000 (16:01 +0530)]
reef: use raw_cluster_cmd instead of run_ceph_cmd

Due to https://github.com/ceph/ceph/pull/50569 not being backported

Signed-off-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #55786 from rhcs-dashboard/wip-64595-reef
Nizamudeen A [Thu, 29 Feb 2024 10:32:18 +0000 (16:02 +0530)]
Merge pull request #55786 from rhcs-dashboard/wip-64595-reef

reef: mgr/dashboard: fix volume creation with multiple hosts

Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agomgr/dashboard: fix roles page for roles without policies 55827/head
Nizamudeen A [Tue, 27 Feb 2024 07:18:56 +0000 (12:48 +0530)]
mgr/dashboard: fix roles page for roles without policies

If there is no permission policies attached to a role, it fails the
UI with an exception.

Fixes: https://tracker.ceph.com/issues/64588
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 5f3f31921c9f3ed909a94f287bfd4cc3f0987649)

16 months agoMerge pull request #55665 from idryomov/wip-64423-reef
Yuri Weinstein [Wed, 28 Feb 2024 20:33:06 +0000 (12:33 -0800)]
Merge pull request #55665 from idryomov/wip-64423-reef

reef: librbd: fix split() for SparseExtent and SparseBufferlistExtent

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
16 months agoMerge pull request #55617 from trociny/wip-64464-reef
Yuri Weinstein [Wed, 28 Feb 2024 20:31:56 +0000 (12:31 -0800)]
Merge pull request #55617 from trociny/wip-64464-reef

reef: tools/rbd: make 'children' command support --image-id

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
16 months agoMerge pull request #55714 from ceph/wip-yuriw-p2p-reef
Yuri Weinstein [Wed, 28 Feb 2024 15:43:27 +0000 (07:43 -0800)]
Merge pull request #55714 from ceph/wip-yuriw-p2p-reef

qa/tests: added the initial reef-p2p suite

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
16 months agomgr/dashboard: fix subvolume group edit 55811/head
Ivo Almeida [Mon, 19 Feb 2024 12:42:34 +0000 (12:42 +0000)]
mgr/dashboard: fix subvolume group edit

Fixes: https://tracker.ceph.com/issues/64487
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit 8aaa0bca47fa49073e797ee427bcec282ef1adbe)

16 months agoMerge pull request #55799 from zdover23/wip-doc-2024-02-28-backport-55782-to-reef
Anthony D'Atri [Tue, 27 Feb 2024 23:51:36 +0000 (18:51 -0500)]
Merge pull request #55799 from zdover23/wip-doc-2024-02-28-backport-55782-to-reef

reef: doc/rados: add "change public network" procedure

16 months agodoc/rados: add "change public network" procedure 55799/head
Zac Dover [Mon, 26 Feb 2024 10:03:48 +0000 (20:03 +1000)]
doc/rados: add "change public network" procedure

Add a procedure to /doc/rados/operations/add-or-rm-mons.rst that
explains how to change the public_network in a Ceph cluster deployed
with cephadm. This procedure was developed by Eugen Block, and can be
seen in its original form here:
https://heiterbiswolkig.blogs.nde.ag/2024/02/22/cephadm-change-public-network/

Co-authored-by: Eugen Block <eblock@nde.ag>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 0b6739a4aa2dd931d97b8af9b3a352969f8767c2)

16 months agoqa/tests: added the initial reef-p2p suite 55714/head
Yuri Weinstein [Thu, 22 Feb 2024 16:18:34 +0000 (08:18 -0800)]
qa/tests: added the initial reef-p2p suite

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
16 months agomgr/dashboard: fix volume creation with multiple hosts 55786/head
Pedro Gonzalez Gomez [Thu, 22 Feb 2024 10:06:21 +0000 (11:06 +0100)]
mgr/dashboard: fix volume creation with multiple hosts

Fixes: https://tracker.ceph.com/issues/64559
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 4313f9a59c676067ca23242808c8e87068d0d953)

16 months agoMerge pull request #55358 from ljflores/wip-revert-pr-55263
Laura Flores [Mon, 26 Feb 2024 18:47:42 +0000 (12:47 -0600)]
Merge pull request #55358 from ljflores/wip-revert-pr-55263

reef: Revert "doc/rados/operations: document `ceph balancer status detail`"

16 months agoMerge pull request #55754 from zdover23/wip-doc-2024-02-26-backport-55683-to-reef
zdover23 [Mon, 26 Feb 2024 10:26:04 +0000 (20:26 +1000)]
Merge pull request #55754 from zdover23/wip-doc-2024-02-26-backport-55683-to-reef

reef: doc/man/8/mount.ceph.rst: add more mount options

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
16 months agoMerge pull request #55704 from afreen23/wip-64528-reef
Nizamudeen A [Mon, 26 Feb 2024 09:40:05 +0000 (15:10 +0530)]
Merge pull request #55704 from afreen23/wip-64528-reef

reef: mgr/dashboard: Handle errors for /api/osd/settings

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agodoc/man/8/mount.ceph.rst: add more mount options 55754/head
Xiubo Li [Wed, 22 Nov 2023 08:13:08 +0000 (16:13 +0800)]
doc/man/8/mount.ceph.rst: add more mount options

Fixes: https://tracker.ceph.com/issues/62837
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit d5639cc670d248da7c84e6f2eaf73ce40bd93db4)

16 months agoMerge pull request #55749 from zdover23/wip-doc-2024-02-26-backport-55739-to-reef
Anthony D'Atri [Mon, 26 Feb 2024 06:09:10 +0000 (01:09 -0500)]
Merge pull request #55749 from zdover23/wip-doc-2024-02-26-backport-55739-to-reef

reef: doc/glossary: Add "OMAP" to glossary

16 months agodoc/glossary: Add "OMAP" to glossary 55749/head
Zac Dover [Sun, 25 Feb 2024 21:14:25 +0000 (07:14 +1000)]
doc/glossary: Add "OMAP" to glossary

Add an entry for "OMAP" to the glossary. This commit represents only the
first improvement to the documentation of OMAP in the Ceph docs suite.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 1d8baa1d4c3583f4a8dc0f46d81f198a3d027e4d)

16 months agoMerge pull request #55737 from zdover23/wip-doc-2024-02-25-backport-55731-to-reef
Anthony D'Atri [Sun, 25 Feb 2024 05:57:54 +0000 (00:57 -0500)]
Merge pull request #55737 from zdover23/wip-doc-2024-02-25-backport-55731-to-reef

reef: doc/dev: fix spelling in crimson.rst

16 months agodoc/dev: fix spelling in crimson.rst 55737/head
Zac Dover [Fri, 23 Feb 2024 16:21:54 +0000 (02:21 +1000)]
doc/dev: fix spelling in crimson.rst

Repair a confusing sentence in doc/dev/crimson.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dfdb5e124a19e0c5ce1e7ba47e574e0504e7091f)

16 months agodoc: Revert "doc/rados/operations: document `ceph balancer status detail`" 55358/head
Laura Flores [Mon, 29 Jan 2024 17:18:54 +0000 (11:18 -0600)]
doc: Revert "doc/rados/operations: document `ceph balancer status detail`"

This reverts commit fdf274e25ab100bec038011b794dfd0bfd4f8667.

Signed-off-by: Laura Flores <lflores@ibm.com>
16 months agoMerge pull request #55732 from zdover23/wip-doc-2024-02-24-backport-55729-to-reef
Anthony D'Atri [Fri, 23 Feb 2024 17:31:54 +0000 (12:31 -0500)]
Merge pull request #55732 from zdover23/wip-doc-2024-02-24-backport-55729-to-reef

reef: doc/rbd: repair ordered list

16 months agodoc/rbd: repair ordered list 55732/head
Zac Dover [Fri, 23 Feb 2024 16:05:42 +0000 (02:05 +1000)]
doc/rbd: repair ordered list

Fix the numbering in an ordered list. The numbering was thrown off
because a ".. prompt" directive was improperly indented (it wasn't
indented at all).

See https://github.com/ceph/ceph/pull/55540#discussion_r1500051264

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 6df12da2cd0946092fa49f8dbb7661e4487c3c22)

16 months agoMerge pull request #55730 from zdover23/wip-doc-2024-02-24-backport-55699-to-reef
Anthony D'Atri [Fri, 23 Feb 2024 17:02:28 +0000 (12:02 -0500)]
Merge pull request #55730 from zdover23/wip-doc-2024-02-24-backport-55699-to-reef

reef: doc/crimson: cleanup duplicate seastore description

16 months agodoc/crimson: cleanup duplicate seastore description 55730/head
Rongqi Sun [Thu, 22 Feb 2024 02:41:43 +0000 (10:41 +0800)]
doc/crimson: cleanup duplicate seastore description

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
(cherry picked from commit 8d766c57173cf6bdea0d8fcfa8fa3c1b61fd10ef)

16 months agoMerge pull request #55724 from zdover23/wip-doc-2024-02-23-backport-55540-to-reef
zdover23 [Fri, 23 Feb 2024 16:07:40 +0000 (02:07 +1000)]
Merge pull request #55724 from zdover23/wip-doc-2024-02-23-backport-55540-to-reef

reef: doc: Add NVMe-oF gateway documentation

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agoMerge pull request #55689 from mcv21/wip-63529-reef
Nizamudeen A [Fri, 23 Feb 2024 04:49:07 +0000 (10:19 +0530)]
Merge pull request #55689 from mcv21/wip-63529-reef

Reef: mgr/dashboard: Simplify authentication protocol

Reviewed-by: Daniel Persson <mailto.woden@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agodoc: Add NVMe-oF gateway documentation 55724/head
Orit Wasserman [Mon, 12 Feb 2024 12:39:38 +0000 (14:39 +0200)]
doc: Add NVMe-oF gateway documentation

- Add nvmeof-initiator-esx.rst
- Add nvmeof-initiator-linux.rst
- Add nvmeof-initiators.rst
- Add nvmeof-overview.rst
- Add nvmeof-requirements.rst
- Add nvmeof-target-configure.rst
- Add links to rbd-integrations.rst

Co-authored-by: Ilya Dryomov <idryomov@redhat.com>
Co-authored-by: Zac Dover <zac.dover@proton.me>
Signed-off-by: Orit Wasserman <owasserm@ibm.com>
(cherry picked from commit 9f86c35a0d308c6ff24d3a033f5314ec86bf896b)

16 months agoMerge pull request #55706 from rkachach/fix_issue_64520
Redouane Kachach [Thu, 22 Feb 2024 15:06:44 +0000 (16:06 +0100)]
Merge pull request #55706 from rkachach/fix_issue_64520

reef: backport rook/mgr recent changes

16 months agosrc/osd/OSDMap.cc: Fix encoder to produce same bytestream 55712/head
Kamoltat [Wed, 31 Jan 2024 15:25:10 +0000 (15:25 +0000)]
src/osd/OSDMap.cc: Fix encoder to produce same bytestream

Fixes: https://tracker.ceph.com/issues/63389
Signed-off-by: Kamoltat <ksirivad@redhat.com>
(cherry picked from commit a3bdffb4e0366af8288258539f17bafeae17e3c4)

16 months agodebian/cephadm.postinst: stop using adduser --gecos 55709/head
Kefu Chai [Sat, 3 Feb 2024 05:46:05 +0000 (13:46 +0800)]
debian/cephadm.postinst: stop using adduser --gecos

--gecos option of adduser is deprecated in debian/bookworm, and
will be removed in debian/trixie,
see https://manpages.debian.org/bookworm/adduser/adduser.8.en.html.
so to be future-proof, let's switch to `usermod --comment`. please
note, since we still need to support ubuntu/jammy which is used in
our CI, and `adduser` shipped by ubuntu/jammy does not support
`--comment` yet, so we cannot use this option.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit e74ec0b27dfb480a2951f85bf00072e95d944772)

16 months agodebian/cephadm.postinst: replace tab with spaces
Kefu Chai [Wed, 17 Jan 2024 15:52:48 +0000 (23:52 +0800)]
debian/cephadm.postinst: replace tab with spaces

for better readability, and to be more consistent with the rest
of this file, and other .postinst scripts of this project.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 013eebf5357666cf2509a37eecf69ef4ac349321)

16 months agodebian/cephadm.postinst: specify --home when adduser
Kefu Chai [Wed, 17 Jan 2024 15:47:39 +0000 (23:47 +0800)]
debian/cephadm.postinst: specify --home when adduser

quote from adduser/NEWS.Debian.gz:

>  System user home defaults to /nonexistent if --home is not specified.
>  Packages that call adduser to create system accounts should explicitly
>  specify a location for /home (see Lintian check
>  maintainer-script-lacks-home-in-adduser).

so let's follow this change in adduser. otherwise "cephadm"
would have a $HOME at `/nonexistent`.

Fixes: https://tracker.ceph.com/issues/64069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 90bc0369243077c2aaf67f0de2bab5810b217f4e)

16 months agodebian/cephadm.postinst: wrap command line lines which is too long
Kefu Chai [Wed, 17 Jan 2024 15:44:23 +0000 (23:44 +0800)]
debian/cephadm.postinst: wrap command line lines which is too long

for better readability.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit c517d0b0e95b20cd9bd979405d0248b9419e5c85)

16 months agodebian/ceph-common.postinst: set user directory using adduser
Kefu Chai [Wed, 17 Jan 2024 15:36:12 +0000 (23:36 +0800)]
debian/ceph-common.postinst: set user directory using adduser

now that adduser allows us to set its home directory, we can do
this using adduser instead of using usermod. this change also
silences the warning from lintian
"maintainer-script-lacks-home-in-adduser". lintian complains if
`adduser --system` is called without passing `--home` option.

also, take this opportunity to s/-c/--comment/ in the command line
of `usermod`, for better readability.

Fixes: https://tracker.ceph.com/issues/64069
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit a1a857698cad4f2feeea0b56fd781350e44078b7)

16 months agodebian/control: add adduser to Depends of cephadm and ceph-common
Kefu Chai [Wed, 17 Jan 2024 15:09:02 +0000 (23:09 +0800)]
debian/control: add adduser to Depends of cephadm and ceph-common

in `debian/ceph-common.postinst` and `debian/cephadm.postinst`, we
use `adduser --system` to create the system user when configuring
the corresponding package.

before this change, the dependency is not listed in the runtime
`Depends` section of ceph-common and cephadm.

in this change, the dependency is added. this is also suggested
by Securing Debian Manual, see
https://www.debian.org/doc/manuals/securing-debian-manual/bpp-lower-privs.en.html

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 2a30ddccd04b204821f0496856847e8ffc07835d)

16 months agomgr/rook: removing HostPattern references 55706/head
Redouane Kachach [Thu, 22 Feb 2024 09:36:40 +0000 (10:36 +0100)]
mgr/rook: removing HostPattern references

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
16 months agomgr/dashboard: Updated test dependencies 55689/head
Daniel Persson [Sun, 3 Dec 2023 09:46:56 +0000 (09:46 +0000)]
mgr/dashboard: Updated test dependencies

Seemed that the test dependencies was separated in two different requirements files
one for the testing and one for linting. Added the JWT dependency in the linting file
as well.

Signed-off-by: Daniel Persson <mailto.woden@gmail.com>
(cherry picked from commit 06765e648acb1676d5d563c631b8d8fc08b5323c)

16 months agomgr/dashboard: Changes suggested after review by @epuertat.
Daniel Persson [Sun, 3 Dec 2023 08:03:47 +0000 (08:03 +0000)]
mgr/dashboard: Changes suggested after review by @epuertat.

Move the JWT requirement to the test requirements file. Also remove JWT from ceph specification and debian build.

Signed-off-by: Daniel Persson <mailto.woden@gmail.com>
(cherry picked from commit c1ea66fe12f86e7a63681cba860fb91b1ea86e12)

16 months agomgr/dashboard: Simplify authentication protocol
Daniel Persson [Wed, 29 Nov 2023 09:39:51 +0000 (09:39 +0000)]
mgr/dashboard: Simplify authentication protocol
By removing the dependency to PyJWT we also remove the dependency to the cryptographic library which
in the dashboard module will create a crash. In newer implementations of the library PyO3 is used to run
rust code in order to encrypt with Elliptic Curves. This is never used in the dashboard communication so
a much simpler implementation where we only use the hmac sha256 algorithm to create the signed JWT message
could be used.

Fixes: https://forum.proxmox.com/threads/ceph-warning-post-upgrade-to-v8.129371
Signed-off-by: Daniel Persson <mailto.woden@gmail.com>
(cherry picked from commit c616a9d017b5fcc85bb5c1556bccf4c77cc3899e)

16 months agomgr/rook: adding empty calls to upgrade_ls and upgrade_status
Redouane Kachach [Thu, 22 Feb 2024 09:04:11 +0000 (10:04 +0100)]
mgr/rook: adding empty calls to upgrade_ls and upgrade_status

added empty calls to upgrade_ls and upgrade_status to avoid
dashboard errors when entering the view Cluster > Upgrade. Empty
calls are used because we don't support the upgrade functionality
in rook as we do for normal Ceph deployments. In case of rook user
has to follow a different process to upgrade Ceph.

Fixes: https://tracker.ceph.com/issues/64516
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
16 months agomgr/dashboard: Handle errors for /api/osd/settings 55704/head
Afreen [Tue, 13 Feb 2024 10:26:09 +0000 (15:56 +0530)]
mgr/dashboard: Handle errors for /api/osd/settings

Fixes https://tracker.ceph.com/issues/62089

issue:
=====
/api/osd/settings returns "TypeError: string indices must be
integers" sometimes.
The result is coming from `osd dump` command which instead of returning
an object returns an error message which then displays error on
dashboard.

fix:
====
Added a try-catch block to handle error and updated frontend code to
handle those

Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit 518bff9c7ed6f6756aff8aa8013c48a5bfdd7b32)

16 months agomgr/rook: raise an exception when user calls OSD related methods
Redouane Kachach [Thu, 22 Feb 2024 08:48:41 +0000 (09:48 +0100)]
mgr/rook: raise an exception when user calls OSD related methods

Signed-off-by: Redouane Kachach <rkachach@redhat.com>
16 months agomgr/rook: removing all the code related to OSDs creation/removal
Redouane Kachach [Thu, 22 Feb 2024 08:48:06 +0000 (09:48 +0100)]
mgr/rook: removing all the code related to OSDs creation/removal
Fixes: https://tracker.ceph.com/issues/64211
Signed-off-by: Redouane Kachach <rkachach@redhat.com>
16 months agoMerge pull request #55648 from zdover23/wip-doc-2024-02-20-backport-55637-to-reef
zdover23 [Wed, 21 Feb 2024 22:54:56 +0000 (08:54 +1000)]
Merge pull request #55648 from zdover23/wip-doc-2024-02-20-backport-55637-to-reef

reef: doc/cephfs: edit add-remove-mds

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
16 months agoMerge pull request #55581 from ivoalmeida/wip-63793-reef
Ivo Almeida [Wed, 21 Feb 2024 14:23:04 +0000 (11:23 -0300)]
Merge pull request #55581 from ivoalmeida/wip-63793-reef

reef: mgr/.dashboard: batch backport of cephfs snapshot schedule management

Reviewed-by: afreen23 <NOT@FOUND>
16 months agoMerge pull request #55680 from zdover23/wip-doc-2024-02-21-backport-55670-to-reef
Anthony D'Atri [Wed, 21 Feb 2024 00:59:18 +0000 (19:59 -0500)]
Merge pull request #55680 from zdover23/wip-doc-2024-02-21-backport-55670-to-reef

reef: doc/rados: fix broken links

16 months agoMerge pull request #55678 from zdover23/wip-doc-2024-02-21-backport-55677-to-reef
Anthony D'Atri [Tue, 20 Feb 2024 23:47:59 +0000 (18:47 -0500)]
Merge pull request #55678 from zdover23/wip-doc-2024-02-21-backport-55677-to-reef

reef: doc/rados/configuration/osd-config-ref: fix typo

16 months agodoc/rados: fix broken links 55680/head
Zac Dover [Tue, 20 Feb 2024 18:07:07 +0000 (04:07 +1000)]
doc/rados: fix broken links

Fix broken links in doc/rados/operations/add-or-rm-mons.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 2e2519367099461415248353d7c7725c0567511d)

16 months agodoc/rados/configuration/osd-config-ref: fix typo 55678/head
Pierre Riteau [Tue, 20 Feb 2024 21:54:01 +0000 (22:54 +0100)]
doc/rados/configuration/osd-config-ref: fix typo

Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
(cherry picked from commit d25b6b9dd2cee81d33f2ad2f0718c6ccdeadbe2b)

16 months agoMerge pull request #55671 from zdover23/wip-doc-2024-02-21-backport-55667-to-reef
Anthony D'Atri [Tue, 20 Feb 2024 19:03:51 +0000 (14:03 -0500)]
Merge pull request #55671 from zdover23/wip-doc-2024-02-21-backport-55667-to-reef

reef: doc/radosgw: edit multisite.rst

16 months agodoc/radosgw: edit multisite.rst 55671/head
Zac Dover [Tue, 20 Feb 2024 12:06:11 +0000 (22:06 +1000)]
doc/radosgw: edit multisite.rst

Edit "Varieties of Multi-Site Configuration" in
doc/radosgw/multisite.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 8af910f877d1c7b873c2a13cec5d4ea1a4de4a79)

16 months agoqa: test fuse/kclient for mds upgrade seq 55669/head
Patrick Donnelly [Fri, 16 Feb 2024 18:25:52 +0000 (13:25 -0500)]
qa: test fuse/kclient for mds upgrade seq

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 182f4c0f54385ab15ba13e1f06c1146ba16fd64b)

16 months agoqa: ignore OSD_DOWN during cephadm upgrades
Patrick Donnelly [Fri, 16 Feb 2024 15:09:53 +0000 (10:09 -0500)]
qa: ignore OSD_DOWN during cephadm upgrades

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 4bcaaa45eb45f12df2d1835831c01fe0eb6ca595)

16 months agoqa: ignore warning "Replacing daemon"
Patrick Donnelly [Fri, 16 Feb 2024 14:46:18 +0000 (09:46 -0500)]
qa: ignore warning "Replacing daemon"

This is expected for cephadm deployments where join_fs is configured, causing
affinity replacements.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 75d76f97b0d7c842bd52cb609b00ffe3508c01b5)

16 months agoqa: ignore MDS_INSUFFICIENT_STANDBY
Patrick Donnelly [Fri, 16 Feb 2024 01:23:32 +0000 (20:23 -0500)]
qa: ignore MDS_INSUFFICIENT_STANDBY

This is expected when bringing a volume and its mds up initially.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 560300f1c5ea44a3c81d87f3bf9d10727622901c)

16 months agoqa: remove ignorelist error parenthesis
Patrick Donnelly [Fri, 16 Feb 2024 01:16:20 +0000 (20:16 -0500)]
qa: remove ignorelist error parenthesis

Some messages are duplicated to the cluster log lookign like:

    2024-02-15T22:54:31.244 INFO:teuthology.orchestra.run.smithi033.stdout:2024-02-15T22:50:00.000263+0000 mon.smithi033 (mon.0) 558 : cluster 4 [ERR] MDS_ALL_DOWN: 1 filesystem is offline

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 0e5e847f087cde893cc49ed3434c78006055d0b5)

16 months agomds: update comment on kclient decoding of MDSMap
Patrick Donnelly [Thu, 15 Feb 2024 19:31:47 +0000 (14:31 -0500)]
mds: update comment on kclient decoding of MDSMap

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 427ad7c0f93d374db45b86073f2c7787d2e8cb9a)