]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
16 months agomgr/dashboard: disable applitools e2e 56215/head
Nizamudeen A [Thu, 7 Mar 2024 08:43:54 +0000 (14:13 +0530)]
mgr/dashboard: disable applitools e2e

Temporarily disabling this so the CI could turn green. Meanwhile I'll
research for a proper way to handle the applitools e2es which I'll track
on https://tracker.ceph.com/issues/64783

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 09c50063a3763fc5d29f604a9daeb844252a31da)

16 months agoMerge pull request #55356 from cbodley/wip-64228-reef
Yuri Weinstein [Thu, 14 Mar 2024 19:46:29 +0000 (12:46 -0700)]
Merge pull request #55356 from cbodley/wip-64228-reef

reef: rgw/rest: fix url decode of post params for iam/sts/sns

Reviewed-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge pull request #56186 from zdover23/wip-doc-2024-03-14-backport-56160-to-reef
Zac Dover [Thu, 14 Mar 2024 19:44:46 +0000 (05:44 +1000)]
Merge pull request #56186 from zdover23/wip-doc-2024-03-14-backport-56160-to-reef

reef: doc/rbd: add map information for clone images to rbd-encryption.rst

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
16 months agoMerge pull request #55197 from rzarzynski/wip-rocksdb-compression-reef
Yuri Weinstein [Thu, 14 Mar 2024 17:06:58 +0000 (10:06 -0700)]
Merge pull request #55197 from rzarzynski/wip-rocksdb-compression-reef

reef: common/options: Set LZ4 compression for bluestore RocksDB.

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
16 months agoMerge pull request #56161 from zdover23/wip-doc-2024-03-13-backport-54173-to-reef
Zac Dover [Thu, 14 Mar 2024 16:34:19 +0000 (02:34 +1000)]
Merge pull request #56161 from zdover23/wip-doc-2024-03-13-backport-54173-to-reef

reef: doc/dev: backport zipapp docs to reef

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agodoc/rbd: add map information for clone images to rbd-encryption.rst 56186/head
N Balachandran [Wed, 13 Mar 2024 11:57:49 +0000 (17:27 +0530)]
doc/rbd: add map information for clone images to rbd-encryption.rst

Add information on the arguments required when mapping the
formatted clone of an encrypted parent image.

Co-authored-by: Zac Dover <zac.dover@proton.me>
Signed-off-by: N Balachandran <nibalach@redhat.com>
(cherry picked from commit 7a2e324a6e1c3e145d3b1e04e6f006defbe0e0b4)

16 months agoMerge pull request #56154 from rhcs-dashboard/wip-64883-reef
Nizamudeen A [Thu, 14 Mar 2024 07:17:05 +0000 (12:47 +0530)]
Merge pull request #56154 from rhcs-dashboard/wip-64883-reef

reef: mgr/dashboard: fix snap schedule time format

Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agoMerge pull request #56102 from adk3798/wip-64627-reef
Adam King [Wed, 13 Mar 2024 14:08:18 +0000 (10:08 -0400)]
Merge pull request #56102 from adk3798/wip-64627-reef

reef: cephadm: create ceph-exporter sock dir if it's not present

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56101 from adk3798/wip-64622-reef
Adam King [Wed, 13 Mar 2024 14:06:13 +0000 (10:06 -0400)]
Merge pull request #56101 from adk3798/wip-64622-reef

reef: mgr/cephadm is not defining haproxy tcp healthchecks for Ganesha

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56100 from adk3798/wip-64620-reef
Adam King [Wed, 13 Mar 2024 14:04:40 +0000 (10:04 -0400)]
Merge pull request #56100 from adk3798/wip-64620-reef

reef: cephadm: Add nvmeof to autotuner calculation

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56092 from adk3798/wip-63447-reef
Adam King [Wed, 13 Mar 2024 13:59:21 +0000 (09:59 -0400)]
Merge pull request #56092 from adk3798/wip-63447-reef

reef: mgr/cephadm: support for removing host entry from crush map during host removal

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
16 months agodoc/dev: backport zipapp docs to reef 56161/head
Zac Dover [Wed, 13 Mar 2024 12:04:35 +0000 (22:04 +1000)]
doc/dev: backport zipapp docs to reef

Backport the docs changes in https://github.com/ceph/ceph/pull/54173 to
the Reef release branch. This was not previously done because the docs
changes in PR#54173 were bundled with code changes.

Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agomgr/dashboard: fix snap schedule time format 56154/head
Ivo Almeida [Mon, 11 Mar 2024 15:09:57 +0000 (15:09 +0000)]
mgr/dashboard: fix snap schedule time format

Fixes: https://tracker.ceph.com/issues/64831
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit a2942f01ae9bde76c6d562374a0bd8aceeee317e)

16 months agoMerge pull request #56115 from rhcs-dashboard/wip-64826-reef
Nizamudeen A [Wed, 13 Mar 2024 06:20:58 +0000 (11:50 +0530)]
Merge pull request #56115 from rhcs-dashboard/wip-64826-reef

reef: mgr/dashboard: fix snap schedule list toggle cols

Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agoqa/cephadm: adjust host drain test to handle explicit placement warning 56092/head
Adam King [Mon, 6 Nov 2023 16:19:09 +0000 (11:19 -0500)]
qa/cephadm: adjust host drain test to handle explicit placement warning

Since we're adding a warning if any host is listed explicitly
in the placement of any service when removing the host,
we need to adjust the host drain test that removes a host
without the --force flag to not have the explicit hostname
in the placement for the mon service.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit b4db5e4ffcf0fb345c99986718b16853f76b148a)

16 months agomgr/cephadm: warn when draining host explicitly listed in placement
Adam King [Mon, 16 Oct 2023 19:15:54 +0000 (15:15 -0400)]
mgr/cephadm: warn when draining host explicitly listed in placement

In the case you apply a spec like

```
service_type: node-exporter
placement:
  hosts:
  - host3
```

and then you run `ceph orch host drain host3`, cephadm will remove
the daemon from that host and the placement would now match nothing.

This is definitely an issue that should be able to be bypassed as
it generally isn't serious, but it would be good to let users
know they have the host listed explicitly in placements like this
when they want to drain it.

Fixes: https://tracker.ceph.com/issues/63220
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 434e5fe6aa69cad11454d437002015cff55b727a)

16 months agoqa/cephadm: test --rm-crush-entry host rm flag in host drain test
Adam King [Fri, 29 Sep 2023 20:52:37 +0000 (16:52 -0400)]
qa/cephadm: test --rm-crush-entry host rm flag in host drain test

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 7870538dc1e19760cd96a3d343ae3d3235f71eb2)

16 months agoqa/cephadm: add teuthology test for host draining
Adam King [Fri, 29 Sep 2023 20:09:48 +0000 (16:09 -0400)]
qa/cephadm: add teuthology test for host draining

This was a gap in our testing in general, but I'm
adding it here right now specifically to use it
to test the "--rm-crush-entry" flag in a follow
up commit

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 13f16e8d7bb029980d6688680390521253970e9a)

16 months agomgr/cephadm: add --rm-crush-entry flag to host removal
Adam King [Fri, 29 Sep 2023 18:39:10 +0000 (14:39 -0400)]
mgr/cephadm: add --rm-crush-entry flag to host removal

This will tell cephadm to try and remove the
crush bucket for the host at the end of the host
removal process. If this fails, we still consider the
host as having been successfully remove from
cephadm's POV, but the user will get back an error
message telling them we failed to remove the
host from the crush map

Fixes: https://tracker.ceph.com/issues/63031
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit fa0f62aa57755c45c713367620dc834530276b25)

Conflicts:
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/orchestrator/_interface.py

16 months agoMerge pull request #56108 from adk3798/wip-64635-reef
Adam King [Wed, 13 Mar 2024 01:40:27 +0000 (21:40 -0400)]
Merge pull request #56108 from adk3798/wip-64635-reef

reef: cephadm/nvmeof: scrape nvmeof prometheus endpoint

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56107 from adk3798/wip-64689-reef
Adam King [Wed, 13 Mar 2024 01:39:13 +0000 (21:39 -0400)]
Merge pull request #56107 from adk3798/wip-64689-reef

reef: mgr/cephadm: fix placement with label and host pattern

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56106 from adk3798/wip-64644-reef
Adam King [Wed, 13 Mar 2024 01:38:30 +0000 (21:38 -0400)]
Merge pull request #56106 from adk3798/wip-64644-reef

reef: cephadm: remove restriction for crush device classes

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56105 from adk3798/wip-64634-reef
Adam King [Wed, 13 Mar 2024 01:37:56 +0000 (21:37 -0400)]
Merge pull request #56105 from adk3798/wip-64634-reef

reef: cephadm: rm podman-auth.json if removing last cluster

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56099 from adk3798/wip-64414-reef
Adam King [Wed, 13 Mar 2024 01:36:46 +0000 (21:36 -0400)]
Merge pull request #56099 from adk3798/wip-64414-reef

reef: cephadm: fix get_version for nvmeof

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56098 from adk3798/wip-63985-reef
Adam King [Wed, 13 Mar 2024 01:36:15 +0000 (21:36 -0400)]
Merge pull request #56098 from adk3798/wip-63985-reef

reef: orchestrator: Add summary line to orch device ls output

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56097 from adk3798/wip-63984-reef
Adam King [Wed, 13 Mar 2024 01:35:30 +0000 (21:35 -0400)]
Merge pull request #56097 from adk3798/wip-63984-reef

reef: orchestrator: Fix representation of CPU threads in host ls --detail command

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56096 from adk3798/wip-63817-reef
Adam King [Wed, 13 Mar 2024 01:34:55 +0000 (21:34 -0400)]
Merge pull request #56096 from adk3798/wip-63817-reef

reef: python-common/drive_selection: fix limit with existing devices

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56095 from adk3798/wip-63815-reef
Adam King [Wed, 13 Mar 2024 01:34:16 +0000 (21:34 -0400)]
Merge pull request #56095 from adk3798/wip-63815-reef

reef: python-common: fix osdspec_affinity check

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56093 from adk3798/wip-63448-reef
Adam King [Wed, 13 Mar 2024 01:33:04 +0000 (21:33 -0400)]
Merge pull request #56093 from adk3798/wip-63448-reef

reef: mgr/cephadm: discovery service (port 8765) fails on ipv6 only clusters

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55957 from adk3798/reef-test-custom-config
Adam King [Wed, 13 Mar 2024 01:31:04 +0000 (21:31 -0400)]
Merge pull request #55957 from adk3798/reef-test-custom-config

reef: qa/cephadm: testing for extra daemon/container features

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56090 from adk3798/wip-63434-reef
Adam King [Wed, 13 Mar 2024 01:29:55 +0000 (21:29 -0400)]
Merge pull request #56090 from adk3798/wip-63434-reef

reef: mgr/cephadm: update timestamp on repeat daemon/service events

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #56089 from adk3798/wip-63190-reef
Adam King [Wed, 13 Mar 2024 01:29:39 +0000 (21:29 -0400)]
Merge pull request #56089 from adk3798/wip-63190-reef

reef: mgr/cephadm: make jaeger-collector a dep for jaeger-agent

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55819 from adk3798/reef-cephadm-nvmeof-log-mount
Adam King [Wed, 13 Mar 2024 01:29:17 +0000 (21:29 -0400)]
Merge pull request #55819 from adk3798/reef-cephadm-nvmeof-log-mount

reef: cephadm: Add mount for nvmeof log location

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55555 from adk3798/reef-cephadm-asyncio-timeout-fixup
Adam King [Wed, 13 Mar 2024 01:28:52 +0000 (21:28 -0400)]
Merge pull request #55555 from adk3798/reef-cephadm-asyncio-timeout-fixup

reef: mgr/cephadm: fixups for asyncio based timeout

Reviewed-by: John Mulligan <jmulligan@redhat.com>
16 months agoMerge pull request #55097 from cbodley/wip-63839-reef
Casey Bodley [Tue, 12 Mar 2024 12:32:36 +0000 (12:32 +0000)]
Merge pull request #55097 from cbodley/wip-63839-reef

reef: qa: remove vstart runner from radosgw_admin task

Reviewed-by: Yuri Weinstein <yuriw@redhat.com>
16 months agoMerge pull request #55815 from rhcs-dashboard/wip-64624-reef
afreen23 [Tue, 12 Mar 2024 10:59:43 +0000 (16:29 +0530)]
Merge pull request #55815 from rhcs-dashboard/wip-64624-reef

reef: mgr/dashboard: fix snap schedule date format

Reviewed-by: Afreen <afreen23.git@gmail.com>
16 months agoMerge pull request #56127 from adk3798/wip-64836-reef
Nizamudeen A [Tue, 12 Mar 2024 06:09:23 +0000 (11:39 +0530)]
Merge pull request #56127 from adk3798/wip-64836-reef

reef: mgr/dashboard: debugging make check failure

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agoMerge pull request #56130 from zdover23/wip-doc-2024-03-12-backport-56113-to-reef
Anthony D'Atri [Mon, 11 Mar 2024 23:01:42 +0000 (19:01 -0400)]
Merge pull request #56130 from zdover23/wip-doc-2024-03-12-backport-56113-to-reef

reef: doc/cephadm: Improve multiple files

16 months agoMerge pull request #55969 from galsalomon66/wip-64693-reef
Yuri Weinstein [Mon, 11 Mar 2024 18:32:23 +0000 (11:32 -0700)]
Merge pull request #55969 from galsalomon66/wip-64693-reef

reef: rgw/S3select: remove assert from csv-parser, adding updates

Reviewed-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge pull request #55790 from cbodley/wip-64600-reef
Yuri Weinstein [Mon, 11 Mar 2024 18:31:35 +0000 (11:31 -0700)]
Merge pull request #55790 from cbodley/wip-64600-reef

reef: test/rgw: increase timeouts in unittest_rgw_dmclock_scheduler

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
16 months agoMerge pull request #55655 from cbodley/wip-64500-reef
Yuri Weinstein [Mon, 11 Mar 2024 18:29:39 +0000 (11:29 -0700)]
Merge pull request #55655 from cbodley/wip-64500-reef

reef: rgw/datalog: RGWDataChangesLog::add_entry() uses null_yield

Reviewed-by: Adam Emerson <aemerson@redhat.com>
16 months agoMerge pull request #55621 from cbodley/wip-64426-reef
Yuri Weinstein [Mon, 11 Mar 2024 18:28:36 +0000 (11:28 -0700)]
Merge pull request #55621 from cbodley/wip-64426-reef

reef: rgw/putobj: RadosWriter uses part head object for multipart parts

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
16 months agoMerge pull request #55606 from jzhu116-bloomberg/wip-64448-reef
Yuri Weinstein [Mon, 11 Mar 2024 18:28:01 +0000 (11:28 -0700)]
Merge pull request #55606 from jzhu116-bloomberg/wip-64448-reef

reef: rgw: do not copy olh attributes in versioning suspended bucket

Reviewed-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge pull request #55289 from jzhu116-bloomberg/wip-64088-reef
Yuri Weinstein [Mon, 11 Mar 2024 18:26:10 +0000 (11:26 -0700)]
Merge pull request #55289 from jzhu116-bloomberg/wip-64088-reef

reef: rgw/lc: do not add datalog/bilog for some lc actions

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
16 months agoMerge pull request #55094 from cbodley/wip-63960-reef
Yuri Weinstein [Mon, 11 Mar 2024 18:24:11 +0000 (11:24 -0700)]
Merge pull request #55094 from cbodley/wip-63960-reef

reef: rgw: add headers to guide cache update in 304 response

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
16 months agoMerge pull request #55061 from cbodley/wip-63940-reef
Yuri Weinstein [Mon, 11 Mar 2024 18:23:14 +0000 (11:23 -0700)]
Merge pull request #55061 from cbodley/wip-63940-reef

reef: radosgw-admin: 'zone set' won't overwrite existing default-placement

Reviewed-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge pull request #54866 from trociny/wip-63777-reef
Yuri Weinstein [Mon, 11 Mar 2024 18:21:38 +0000 (11:21 -0700)]
Merge pull request #54866 from trociny/wip-63777-reef

reef: [rgw][lc][rgw_lifecycle_work_time] adjust timing if the configured end time is less than the start time

Reviewed-by: Casey Bodley <cbodley@redhat.com>
16 months agodoc/cephadm: Improve multiple files 56130/head
Anthony D'Atri [Mon, 11 Mar 2024 07:04:47 +0000 (03:04 -0400)]
doc/cephadm: Improve multiple files

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 800dd29e60fcd2bcd27db56d3fe45c58ddf10c8a)

16 months agomgr/dashboard: debugging make check failure 56127/head
Nizamudeen A [Mon, 4 Mar 2024 12:52:48 +0000 (18:22 +0530)]
mgr/dashboard: debugging make check failure

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 958c60d8a74e3c38abe043e7f2cfbe4224cfb411)

16 months agoMerge pull request #55931 from ceph/reef-release
Yuri Weinstein [Mon, 11 Mar 2024 15:04:09 +0000 (08:04 -0700)]
Merge pull request #55931 from ceph/reef-release

v18.2.2

Reviewed-by: Laura Flores <lflores@redhat.com>
16 months agoMerge pull request #56059 from rhcs-dashboard/wip-64807-reef
Pedro Gonzalez Gomez [Mon, 11 Mar 2024 13:09:52 +0000 (14:09 +0100)]
Merge pull request #56059 from rhcs-dashboard/wip-64807-reef

reef: mgr/dashboard: add snap schedule M, Y frequencies

Reviewed-by: afreen23 <NOT@FOUND>
16 months agomgr/dashboard: fix snap schedule list toggle cols 56115/head
Ivo Almeida [Fri, 8 Mar 2024 11:40:41 +0000 (11:40 +0000)]
mgr/dashboard: fix snap schedule list toggle cols

Added isInvisible property to CdColumnTable interface to hide column
from 'toggle columns' drop down checkboxes.

Fixes: https://tracker.ceph.com/issues/64813
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit 1b77baea8dd0781fa897ec6c1f1e06c57a265ed7)

16 months agoMerge pull request #56111 from zdover23/wip-doc-2024-03-11-backport-56091-to-reef
Anthony D'Atri [Mon, 11 Mar 2024 07:06:09 +0000 (03:06 -0400)]
Merge pull request #56111 from zdover23/wip-doc-2024-03-11-backport-56091-to-reef

reef: doc/cephadm: improve host-management.rst

16 months agodoc/cephadm: improve host-management.rst 56111/head
Anthony D'Atri [Sun, 10 Mar 2024 19:49:35 +0000 (15:49 -0400)]
doc/cephadm: improve host-management.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 9fb51bb537e8bd9ea60633091acfc48a58262c3b)

16 months agoqa/cephadm: don't test certain workunits with agent 55555/head
Adam King [Thu, 15 Feb 2024 14:24:23 +0000 (09:24 -0500)]
qa/cephadm: don't test certain workunits with agent

There are a handful of workunits that don't work
with or don't make sense with the agent.
The test for the cephadm timeout only works if
the mgr directly runs ceph-volume inventory which
it won't do with the agent present. The adoption
test is just running direct cephadm commands that
are irrelevant to the agent. The test_orch_cli tests
rely on refresh timings that are different with
the agent running, causing spurious failures.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 7953fe1b3920c92c086c981bf4e3d2c41ea7e450)

16 months agocephadm/nvmeof: scrape nvmeof prometheus endpoint 56108/head
Avan Thakkar [Thu, 22 Feb 2024 11:00:06 +0000 (16:30 +0530)]
cephadm/nvmeof: scrape nvmeof prometheus endpoint

Fixes: https://tracker.ceph.com/issues/64536
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 93ec6284fb3002b4778c4e54972ff1d864060922)

Conflicts:
src/cephadm/cephadmlib/constants.py
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/cephadm/templates/services/nvmeof/ceph-nvmeof.conf.j2
src/pybind/mgr/cephadm/tests/test_services.py

16 months agomgr/cephadm: fix placement with label and host pattern 56107/head
Adam King [Wed, 14 Feb 2024 16:28:11 +0000 (11:28 -0500)]
mgr/cephadm: fix placement with label and host pattern

Previously, when both the label and host pattern were
provided, only the label was actually used for the placement

Fixes: https://tracker.ceph.com/issues/64428
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 106f34ba31c82dd87f4c3f9ad82d8ace81e6c689)

16 months agocephadm: remove restriction for crush device classes 56106/head
Seena Fallah [Sun, 11 Feb 2024 21:50:05 +0000 (22:50 +0100)]
cephadm: remove restriction for crush device classes

A restriction has been introduced here (https://github.com/ceph/ceph/commit/6c6cb2f5130dbcf8e42cf03666173948411fc92b) which doesn't let OSDs be created with custom crush device classes.
Crush Device Class is the key that helps the crush distinguish between multiple storage classes, so it must accept any custom names.

Fixes: https://tracker.ceph.com/issues/64382
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
(cherry picked from commit 5999196f37bc5cb12de26d5f0aa077229e3ffc42)

16 months agocephadm: rm podman-auth.json if removing last cluster 56105/head
Adam King [Wed, 14 Feb 2024 17:02:09 +0000 (12:02 -0500)]
cephadm: rm podman-auth.json if removing last cluster

We have points in rm-cluster where we check that
there are no other clusters on the host. If that
is the case, we can also clear /etc/ceph/podman-auth.json
which gets written out when we log in to a registry
while using podman

Fixes: https://tracker.ceph.com/issues/64433
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit d203a97e1bf1e06433365ea38e3ab2b6430cefff)

16 months agocephadm: create ceph-exporter sock dir if it's not present 56102/head
Adam King [Sun, 10 Mar 2024 20:42:51 +0000 (16:42 -0400)]
cephadm: create ceph-exporter sock dir if it's not present

Since this is usually /var/run/ceph/ which ends up getting
created by other daemons as well, it was common to see
ceph-exporter fail to deploy and then deploy fine after
once other daemons were down on the host. I don't see any
reason we can't just try to make the directory here instead
of bailing out.

This patch had to be rewritten for reef, as it depended on
changes in cephadm that will not be backported to reef.

Fixes: https://tracker.ceph.com/issues/64491
Signed-off-by: Adam King <adking@redhat.com>
16 months agomgr/cephadm is not defining haproxy tcp healthchecks for Ganesha 56101/head
avanthakkar [Thu, 5 Oct 2023 12:18:34 +0000 (17:48 +0530)]
mgr/cephadm is not defining haproxy tcp healthchecks for Ganesha

Fixes: https://tracker.ceph.com/issues/62638
Signed-off-by: avanthakkar <avanjohn@gmail.com>
(cherry picked from commit 6a6a9ddd46e5dd2135dfd241fc0dff8ff7472a06)

16 months agocephadm: add testcase to autotuner 56100/head
Paul Cuzner [Wed, 24 Jan 2024 21:22:37 +0000 (10:22 +1300)]
cephadm: add testcase to autotuner

Adds a testcase for the presence of the nvmeof daemon

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
(cherry picked from commit 2d4bd1604246436136e11d14bc447c31a1e26a97)

16 months agocephadm: Add nvmeof to autotuner calculation
Paul Cuzner [Wed, 24 Jan 2024 21:22:13 +0000 (10:22 +1300)]
cephadm: Add nvmeof to autotuner calculation

Add nvmeof to the list of daemons when calculating the
memory to use for OSDs.

Fixes: https://tracker.ceph.com/issues/64020
Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
(cherry picked from commit 31e4b8de9631eef2b4b5d9865725b0520637d603)

16 months agocephadm: fix get_version for nvmeof 56099/head
Adam King [Mon, 29 Jan 2024 16:23:54 +0000 (11:23 -0500)]
cephadm: fix get_version for nvmeof

This needed to be using the container id it was
passed, instead of ctx.image which is likely to
be `None` when this is run.

Fixes: https://tracker.ceph.com/issues/64229
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 70c00e8ba787d9e9106934cfee0e0afa606ce326)

Conflicts:
src/cephadm/cephadmlib/daemons/nvmeof.py

16 months agoorchestrator: Add summary line to orch device ls 56098/head
Paul Cuzner [Thu, 21 Dec 2023 01:12:45 +0000 (20:12 -0500)]
orchestrator: Add summary line to orch device ls

This patch just adds a summary line to the plain
text output of orch device ls when the --summary
switch is given. This helps to quickly understand your
device countswhen managing hosts with many devices.

Fixes: https://tracker.ceph.com/issues/63864
Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
(cherry picked from commit 50a4cd3a18ce510f25908531d6228e7447f5e72c)

16 months agoorchestrator: Fix representation of threads in host ls 56097/head
Paul Cuzner [Wed, 20 Dec 2023 23:47:51 +0000 (18:47 -0500)]
orchestrator: Fix representation of threads in host ls

This patch fixes the calculation when determining the
number of threads for hosts when using the --detail
parameter.

Signed-off-by: Paul Cuzner <pcuzner@ibm.com>
(cherry picked from commit 5bc735fb6ffbdcacffc3e678b7682f91fe7593c2)

16 months agopython-common/drive_selection: fix limit with existing devices 56096/head
Adam King [Mon, 27 Nov 2023 20:04:42 +0000 (15:04 -0500)]
python-common/drive_selection: fix limit with existing devices

When devices have already been used for OSDs, they are still
allowed to pass filtering as they are still needed for the
resulting ceph-volume lvm batch command. This was causing an
issue with limit however. Limit adds the devices we've found
that match the filter and existing OSD daemons tied to the spec.
This allows double counting of devices that hae been used for
OSDs, as they're counted in terms of being an existing device
and that they match the filter. To avoid this issue, devices
should only be counted towards the limit if they are not already
part of an OSD.

An additional note: The limit feature is only applied for
data devices, so there is no need to worry about the effect
of this change on selection of db, wal, or journal devices.
Also, we would still want to not count these devices if they
did end up passing the data device filter but had been used
for a db/wal/journal device previously.

Fixes: https://tracker.ceph.com/issues/63525
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit d3f1a0e1c0b98b9f1251837ecc8edc367e590dad)

16 months agopython-common: fix osdspec_affinity check 56095/head
Guillaume Abrioux [Tue, 5 Dec 2023 16:58:07 +0000 (17:58 +0100)]
python-common: fix osdspec_affinity check

When no `service_id` is provided to service spec (osd) it results in
OSDs created with "osdspec_affinity" attribute set to a string
containing "None".

The DriveSelection class relies on the comparison of the actual
value of this attribute with the value of the service_id which has
the python type `None` in that case.

If any existing deployments were created without the service_id
attribute, we now have to support this case and make sure the check
won't filter out devices unexpectedly.

Fixes: https://tracker.ceph.com/issues/63729
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit c68b5af0fb639fccc89d26606c7924c6834bf606)

16 months agomgr/dashboard: discovery service (port 8765) fails on ipv6 only clusters 56093/head
Theofilos Mouratidis [Wed, 1 Nov 2023 09:55:37 +0000 (10:55 +0100)]
mgr/dashboard: discovery service (port 8765) fails on ipv6 only clusters

Having ms_bind_ipv4=false and ipv6=true the code that the Ceph dashboard runs
for the discovery service (port 8765) fails, because it requests the address
of the mgr container which returns ipv6 and the mgr code expects ipv4 address

Fixes: https://tracker.ceph.com/issues/63388
Signed-off-by: Theofilos Mouratidis <mtheofilos@gmail.com>
(cherry picked from commit 647b5d67a8a800091acea68d20e87354373b0fac)

16 months agomgr/cephadm: update timestamp on repeat daemon/service events 56090/head
Adam King [Wed, 18 Oct 2023 18:00:05 +0000 (14:00 -0400)]
mgr/cephadm: update timestamp on repeat daemon/service events

If you have a daemon/service event and then an identical
event happens later (e.g. the same daemon is redeployed
multiple times) the events are not updated on the repeat
instances. In cases like this I think it makes more
sense to update the timestamp so users can see the most
recent time the event happened.

Fixes: https://tracker.ceph.com/issues/63238
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 13512cc202c90abd6c5f1e2747d121cc07689d1b)

16 months agomgr/cephadm: make jaeger-collector urls a dep for jaeger-agent 56089/head
Adam King [Tue, 9 May 2023 19:06:41 +0000 (15:06 -0400)]
mgr/cephadm: make jaeger-collector urls a dep for jaeger-agent

the jaeger-agent's need to know the url for the collector(s)
that have been deployed. If a collector moves, or we deployed
the agents before the collector, we need to reconfig the agents
with updated info about the collectors. Failure to do so can
leave the jager-agents down reporting

```
Could not create collector proxy","error":"at least one collector hostPort address is required when resolver is not available"
```

Fixes: https://tracker.ceph.com/issues/59704
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit acc26d7b17316d1e45bfc3a882355b46db19d053)

16 months agoMerge pull request #56073 from zdover23/wip-doc-2024-03-09-backport-56068-to-reef
zdover23 [Sat, 9 Mar 2024 13:39:02 +0000 (23:39 +1000)]
Merge pull request #56073 from zdover23/wip-doc-2024-03-09-backport-56068-to-reef

reef: doc/glossary: add "Crimson" entry

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
16 months agodoc/glossary: add "Crimson" entry 56073/head
Zac Dover [Fri, 8 Mar 2024 17:17:59 +0000 (03:17 +1000)]
doc/glossary: add "Crimson" entry

Add a "Crimson" entry to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit b31e061cc087b31a7e9e841dd21e7403a2197378)

16 months agoMerge pull request #56041 from zdover23/wip-doc-2024-03-08-backport-56010-to-reef
zdover23 [Sat, 9 Mar 2024 05:11:18 +0000 (15:11 +1000)]
Merge pull request #56041 from zdover23/wip-doc-2024-03-08-backport-56010-to-reef

reef: doc/start: add Slack invite link

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agodoc/start: add Slack invite link 56041/head
Zac Dover [Thu, 7 Mar 2024 03:01:47 +0000 (13:01 +1000)]
doc/start: add Slack invite link

Add a link to the ceph-storage Slack invitation page. Previously the
link went to a plain old "this is the ceph-storage Slack" page that did
not direct the reader to sign up.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit dee319e61204b2ee9ac13562c2c7075ef0f2ea4b)

16 months agoMerge pull request #55999 from guits/wip-64750-reef
Adam King [Fri, 8 Mar 2024 20:16:25 +0000 (15:16 -0500)]
Merge pull request #55999 from guits/wip-64750-reef

reef: mgr/node-proxy: handle 'None' statuses returned by RedFish

Reviewed-by: Adam King <adking@redhat.com>
16 months agoMerge pull request #56057 from zdover23/wip-doc-2024-03-08-backport-56045-to-reef
Anthony D'Atri [Fri, 8 Mar 2024 15:59:56 +0000 (10:59 -0500)]
Merge pull request #56057 from zdover23/wip-doc-2024-03-08-backport-56045-to-reef

reef: doc/rados: restore PGcalc tool

16 months agomgr/dashboard: add snap schedule M, Y frequencies 56059/head
Ivo Almeida [Mon, 26 Feb 2024 11:56:18 +0000 (11:56 +0000)]
mgr/dashboard: add snap schedule M, Y frequencies

Added M and Y (month and year) repeat frequencies to snap schedule
create form.

Fixes: https://tracker.ceph.com/issues/64614
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit be3bb09cca7ff8d10a36a59702bb16fd10aba84e)

16 months agodoc/rados: restore PGcalc tool 56057/head
Zac Dover [Thu, 7 Mar 2024 17:29:50 +0000 (03:29 +1000)]
doc/rados: restore PGcalc tool

Restore the PGcalc tool to the documentation suite.

Co-authored-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit eaaf72253123de1a66f163f651046817faa97a1a)

16 months agoMerge pull request #56012 from zdover23/wip-doc-2024-03-07-backport-55995-to-reef
Anthony D'Atri [Thu, 7 Mar 2024 15:35:00 +0000 (10:35 -0500)]
Merge pull request #56012 from zdover23/wip-doc-2024-03-07-backport-55995-to-reef

reef: doc/architecture: correct typo

16 months agoMerge pull request #55640 from vshankar/wip-64485-reef
Venky Shankar [Thu, 7 Mar 2024 06:40:19 +0000 (12:10 +0530)]
Merge pull request #55640 from vshankar/wip-64485-reef

reef: mds,cephfs_mirror: add labelled per-client and replication metrics

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #55395 from dparmar18/wip-63691-reef
Venky Shankar [Thu, 7 Mar 2024 06:40:04 +0000 (12:10 +0530)]
Merge pull request #55395 from dparmar18/wip-63691-reef

reef: mgr/(object_format && nfs/export): enhance nfs export update failure response

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #55302 from neesingh-rh/wip-64144-reef
Venky Shankar [Thu, 7 Mar 2024 06:39:05 +0000 (12:09 +0530)]
Merge pull request #55302 from neesingh-rh/wip-64144-reef

reef: qa: fix rank_asok() to handle errors from asok commands

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #54538 from aaSharma14/wip-63571-reef
Nizamudeen A [Thu, 7 Mar 2024 05:18:56 +0000 (10:48 +0530)]
Merge pull request #54538 from aaSharma14/wip-63571-reef

reef: mgr/dashboard: Show the OSDs Out and Down panels as red whenever an OSD is in Out or Down state in Ceph Cluster grafana dashboard

Reviewed-by: Ejdesgaard <NOT@FOUND>
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
16 months agoMerge pull request #55993 from rhcs-dashboard/wip-64732-reef
Nizamudeen A [Thu, 7 Mar 2024 04:31:37 +0000 (10:01 +0530)]
Merge pull request #55993 from rhcs-dashboard/wip-64732-reef

reef: mgr/dashboard: fixed cephfs mount command

Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agodoc/architecture: correct typo 56012/head
Zac Dover [Wed, 6 Mar 2024 11:40:10 +0000 (21:40 +1000)]
doc/architecture: correct typo

s/client/clients/ where necessary, and add a link to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit ae08855cf870173dce2a47a28f3bbb22e7ae0ca2)

16 months agoMerge pull request #56002 from zdover23/wip-doc-2024-03-07-backport-55982-to-reef
Anthony D'Atri [Wed, 6 Mar 2024 18:39:47 +0000 (13:39 -0500)]
Merge pull request #56002 from zdover23/wip-doc-2024-03-07-backport-55982-to-reef

reef: doc/dev: edit teuthology workflow

16 months agoMerge pull request #55836 from vshankar/wip-reef-raw-cluster-cmd
Yuri Weinstein [Wed, 6 Mar 2024 16:05:37 +0000 (08:05 -0800)]
Merge pull request #55836 from vshankar/wip-reef-raw-cluster-cmd

reef: use raw_cluster_cmd instead of run_ceph_cmd

Reviewed-by: Rishabh Dave <ridave@redhat.com>
16 months agoMerge pull request #55943 from vshankar/wip-64705-reef
Yuri Weinstein [Wed, 6 Mar 2024 16:04:37 +0000 (08:04 -0800)]
Merge pull request #55943 from vshankar/wip-64705-reef

reef: qa: remove error string checks and check w/ return value

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #55300 from neesingh-rh/wip-64098-reef
Yuri Weinstein [Wed, 6 Mar 2024 16:01:21 +0000 (08:01 -0800)]
Merge pull request #55300 from neesingh-rh/wip-64098-reef

reef: src/mount: kernel mount command returning misleading error message

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #54467 from lxbsz/wip-63262
Yuri Weinstein [Wed, 6 Mar 2024 15:59:15 +0000 (07:59 -0800)]
Merge pull request #54467 from lxbsz/wip-63262

reef: mds: fix issuing redundant reintegrate/migrate_stray requests

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agodoc/dev: edit teuthology workflow 56002/head
Zac Dover [Wed, 6 Mar 2024 07:15:20 +0000 (17:15 +1000)]
doc/dev: edit teuthology workflow

Improve a couple of sentences in
doc/dev/developer_guide_testing_integration_tests/tests-integration-testing-teutology-workflow.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 51796e80f35da8ca13b72f31eeafefd4c1e40773)

16 months agomgr/node-proxy: handle 'None' statuses returned by RedFish 55999/head
Guillaume Abrioux [Tue, 5 Mar 2024 10:05:18 +0000 (10:05 +0000)]
mgr/node-proxy: handle 'None' statuses returned by RedFish

Looks like RedFish might return 'None' values for some attributes.

for instance:

```
[root@ceph-node-01 ~]# curl -s -k -X GET https://169.254.1.1/redfish/v1/Systems/System.Embedded.1/Storage/AHCI.SL.6-1/Drives/Disk.Direct.0-0:AHCI.SL.6-1 -H "X-Auth-Token: 3264251c28191fa5e7c9ebec49ef90fc"  | jq .Status
{
  "Health": "OK",
  "HealthRollup": "OK",
  "State": "Enabled"
}
[root@ceph-node-01 ~]# curl -s -k -X GET https://169.254.1.1/redfish/v1/Systems/System.Embedded.1/Storage/NonRAID.Slot.2-1/Drives/Disk.Bay.0:Enclosure.Internal.0-1:NonRAID.Slot.2-1 -H "X-Auth-Token: 3264251c28191fa5e7c9ebec49ef90fc" | jq .Status
{
  "Health": null,
  "HealthRollup": null,
  "State": "Enabled"
}
[root@ceph-node-01 ~]#
```

Although this seems to be a bug from RedFish, we need to handle
the case when it happens otherwise it makes the mgr orchestrator module
throw an error.

The idea here is to create a new status "unknown" when we can't fetch the
real status of a component.

Fixes: https://tracker.ceph.com/issues/64712
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit cc279a3dd23d9219e508b80512f363a4ae577392)

16 months agomgr/dashboard: fixed cephfs mount command 55993/head
Ivo Almeida [Tue, 5 Mar 2024 12:37:21 +0000 (12:37 +0000)]
mgr/dashboard: fixed cephfs mount command

Fixes: https://tracker.ceph.com/issues/64716
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit eeb09b19581d353fb68f86bb4c2871f026a35c29)

16 months agousing the it.length() for segment processing. 55969/head
Gal Salomon [Sun, 3 Mar 2024 12:44:49 +0000 (14:44 +0200)]
using the it.length() for segment processing.
s3select submodule

Signed-off-by: Gal Salomon <gal.salomon@gmail.com>
(cherry picked from commit 8fedb30c1bd6cd393becf88f8d2fe07ea9c6040c)

16 months agoadd a fix related to RGW crash upon compression (assert is replaced by exception)
Gal Salomon [Fri, 1 Mar 2024 12:48:13 +0000 (14:48 +0200)]
add a fix related to RGW crash upon compression (assert is replaced by exception)

Signed-off-by: Gal Salomon <gal.salomon@gmail.com>
(cherry picked from commit 9d8f5d7132741c996a3f66d62a8ec9e9a34fa0c0)

16 months agoadding recent update: json-output and more
Gal Salomon [Tue, 13 Feb 2024 15:47:26 +0000 (17:47 +0200)]
adding recent update: json-output and more

Signed-off-by: Gal Salomon <gal.salomon@gmail.com>
(cherry picked from commit f50385ef71a3d0ac175018cb070dbf2e767e6ed3)

16 months agoqa/cephadm: test for extra daemon features 55957/head
Adam King [Mon, 19 Jun 2023 18:24:23 +0000 (14:24 -0400)]
qa/cephadm: test for extra daemon features

Specifically, extra_container_args, extra_entrypoint_args,
and custom_configs.

This also provides testing for the CustomContainer
class which previously had no usage in any
of the teuthology tests

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 031bbbc17fda3c7b28b12d11b976629d8c1297ed)

16 months agopython-common/service_spec: add extra_entrypoint_args to CephExporter Spec
Adam King [Mon, 26 Jun 2023 20:42:52 +0000 (16:42 -0400)]
python-common/service_spec: add extra_entrypoint_args to CephExporter Spec

Similar to the mon, there's no reason for Ceph Exporter
in particular not to have this, it's just missing because
of the timing of when it was merged in.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 654a5925a401f4a7a26f170ce8885713d35f8cda)

16 months agomgr/cephadm: add extra_entrypoint_args to mon spec
Adam King [Mon, 19 Jun 2023 20:07:31 +0000 (16:07 -0400)]
mgr/cephadm: add extra_entrypoint_args to mon spec

There was no reason for the mon spec to not include
this option. I believe this was just an oversight caused
by the addition of the mon spec and extra_entrypoint_args
in separate PRs around the same time.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 370836d46475d8daa6b26acd6f5330abb932bfed)