]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
16 months agorgw_file: fix mv/rename cases broken by zipper integration 56220/head
Matt Benjamin [Thu, 14 Mar 2024 00:19:01 +0000 (20:19 -0400)]
rgw_file: fix mv/rename cases broken by zipper integration

There were two problems.  First, leaf object names must be
expressed as fully-qualified to the bucket as input to the
copy-object step.  Second, handle s->object in the same step
indicates the being-created destination object of the copy,
this was correct in the original zipper change but broken
later.

* add a rename/mv unit test

Tests for the following cases added:

1. move between two sub-directory paths in a single bucket
2. move between two names at the top level of a single bucket
3. move between sub-directory paths in different buckets (cross-bucket rename)

Fixes: https://tracker.ceph.com/issues/64950
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
16 months agoMerge PR #54485 into main
Patrick Donnelly [Wed, 13 Mar 2024 13:04:40 +0000 (09:04 -0400)]
Merge PR #54485 into main

* refs/pull/54485/head:
mds/quiesce-db: keep the db thread alive until shutdown
mds/quiesce-db: incorporate review comments
mds/quiesce: declare QuiesceDbPeerListing and QuiesceDbPeerAck
mds/quiesce: resolve the quiesce cluster at the mds monitor
include/types: add an I/O helper for std::unordered_map
messages: avoid using mutable members in MMDSQuiesce*
mds/quiesce-db: incorporate review comments
doc/cephfs/fs-volumes: doc fixes and updates
pybind/mgr: correct type hints for `get_quiesce_leader_info`
mds/quiesce: only use ACTIVE daemons for the quiesce cluster
mds,messages: quiesce db inter-rank messaging
mds/quiesce: MDSRankQuiesce - integration of the quiesce db manager
doc/cephfs/fs-volumes: Add info about the quiesce command
doc: fixes for local dev builds
mgr/volumes: support for `fs subvolume quiesce`
mgr/volumes: use `volume_exception_to_retval` as a decorator
pybind/mgr: add a `one-shot` parameter to send_command
mds/quiesce: QuiesceAgent implementation and unit tests
mds/quiesce: QuiesceDb.h and QuiesceDbManager with tests
common/Timer.cc: improve debug messages from the timer_thread
mds: MDSRank.cc: return status from `send_message_mds`
encoding: add emplace variants for map dencoders
common/Cond: make C_SaferCond private members protected to facilitate inheritance
qa/tasks/cephfs: give the tests more time to run heavy fs workloads

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
16 months agoMerge pull request #55952 from yuvalif/wip-yuval-64710
Yuval Lifshitz [Wed, 13 Mar 2024 10:28:35 +0000 (12:28 +0200)]
Merge pull request #55952 from yuvalif/wip-yuval-64710

rgw/kafka: set message timeout to 5 seconds

reviewed-by: kchheda3

16 months agoMerge pull request #56124 from ivoalmeida/fix-snap-schedule-time-format
Ivo Almeida [Wed, 13 Mar 2024 09:19:43 +0000 (09:19 +0000)]
Merge pull request #56124 from ivoalmeida/fix-snap-schedule-time-format

mgr/dashboard: fix snap schedule time format

Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agoMerge pull request #56028 from cyx1231st/wip-seastore-cleanup-lba
Yingxin [Wed, 13 Mar 2024 02:27:51 +0000 (10:27 +0800)]
Merge pull request #56028 from cyx1231st/wip-seastore-cleanup-lba

crimson/os/seastore: cleanups around lba parent-child pointer

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
16 months agoMerge pull request #55644 from linuxbox2/wip-rgw-dtexpire
Casey Bodley [Tue, 12 Mar 2024 19:12:21 +0000 (19:12 +0000)]
Merge pull request #55644 from linuxbox2/wip-rgw-dtexpire

rgw_lc:  replace strftime w/fmt and chrono:calendar

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
16 months agoMerge pull request #55764 from sseshasa/wip-fix-ec-inconsisten-hinfo-wrn
Yuri Weinstein [Tue, 12 Mar 2024 18:24:35 +0000 (11:24 -0700)]
Merge pull request #55764 from sseshasa/wip-fix-ec-inconsisten-hinfo-wrn

qa: Add benign cluster warning from ec-inconsistent-hinfo test to ignorelist

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
16 months agoMerge pull request #55455 from sseshasa/wip-fix-cluster-log-level-str
Yuri Weinstein [Tue, 12 Mar 2024 18:24:02 +0000 (11:24 -0700)]
Merge pull request #55455 from sseshasa/wip-fix-cluster-log-level-str

common/LogEntry: Add log level to str helper for fmt::formatter<LogEntry>

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
16 months agoMerge pull request #49730 from pdvian/wip-clog-fix
Yuri Weinstein [Tue, 12 Mar 2024 18:21:17 +0000 (11:21 -0700)]
Merge pull request #49730 from pdvian/wip-clog-fix

common/LogEntry: Reintroduce human readable log level for clog messages

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
16 months agoMerge PR #56082 into main
Patrick Donnelly [Tue, 12 Mar 2024 13:07:35 +0000 (09:07 -0400)]
Merge PR #56082 into main

* refs/pull/56082/head:
qa/crontab: simplify and minimize argument specification
qa/nightlies: move schedule_subset script alongside cron_wrapper
qa/crontab: correct script paths and environment
qa/nightlies: simplify cron_wrapper and log to syslog

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agorgw_lc: replace strftime w/fmt and chrono:calendar 55644/head
Matt Benjamin [Mon, 19 Feb 2024 14:01:48 +0000 (09:01 -0500)]
rgw_lc:  replace strftime w/fmt and chrono:calendar

It's reliably claimed that std::strftime is not
mt-safe, and this would be a likely root cause of
intermittent scrambled expiration header output cases
that have been reported.

Fixes: https://tracker.ceph.com/issues/63973
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
16 months agoMerge pull request #56005 from cbodley/wip-qa-rgw-realm
Casey Bodley [Mon, 11 Mar 2024 21:22:05 +0000 (21:22 +0000)]
Merge pull request #56005 from cbodley/wip-qa-rgw-realm

qa/rgw: teach rgw.py to create an optional realm

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
16 months agoqa/crontab: simplify and minimize argument specification 56082/head
Patrick Donnelly [Mon, 11 Mar 2024 14:46:05 +0000 (10:46 -0400)]
qa/crontab: simplify and minimize argument specification

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
16 months agoqa/nightlies: move schedule_subset script alongside cron_wrapper
Patrick Donnelly [Mon, 11 Mar 2024 14:08:15 +0000 (10:08 -0400)]
qa/nightlies: move schedule_subset script alongside cron_wrapper

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
16 months agoqa/crontab: correct script paths and environment
Patrick Donnelly [Sun, 10 Mar 2024 15:22:09 +0000 (11:22 -0400)]
qa/crontab: correct script paths and environment

At some point the links to the shell scripts in ceph.git were broken in the
$HOME for [1]. Unless a run was done manually with `teuthology-suite` in the
crontab, the job was basically skipped. This is probably one of the reasons
nightlies fell out of use.

I've updated the home directory according to the document (comments) in this
change. The teuthology user now has persistent clones of ceph.git and
teuthology.git. The clones are updated daily by this same crontab.

Instead of using a link in teuthology's $HOME/bin to the scripts used in this
crontab, we just have a cron variable referencing where the script should be in
the ceph.git/teuthology.git clone. Adding to this, the .bash_environment file
sources the virtualenv activate script instead of adding the teuthology binary
directory to its $PATH.

I've updated the hour for these jobs to actually be done "nightly". The first
set of jobs will be scheduled around 4pm EST. Additionally, it was necessary to
include --force-priority as some jobs are below the priority thresholds.

[1] teuthology@teuthology.front.sepia.ceph.com.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
16 months agoqa/nightlies: simplify cron_wrapper and log to syslog
Patrick Donnelly [Mon, 11 Mar 2024 01:21:38 +0000 (21:21 -0400)]
qa/nightlies: simplify cron_wrapper and log to syslog

Instead of logging to a separate file which must be rotated manually, use the
syslog (journald on teuthology.front).

Keep a temporary unlinked file around in case we want to dump that to the
cronjob stdout for a mail status.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
16 months agoMerge pull request #56077 from idryomov/wip-rbd-mirror-bash
Ilya Dryomov [Mon, 11 Mar 2024 17:19:36 +0000 (18:19 +0100)]
Merge pull request #56077 from idryomov/wip-rbd-mirror-bash

qa/workunits/rbd: switch rbd-mirror workunits to bash

16 months agoMerge pull request #56113 from anthonyeleven/moar-improvements
Anthony D'Atri [Mon, 11 Mar 2024 16:17:48 +0000 (12:17 -0400)]
Merge pull request #56113 from anthonyeleven/moar-improvements

doc/cephadm: Improve multiple files

16 months agoMerge pull request #56003 from prazumovsky/wip-63684-reef
Casey Bodley [Mon, 11 Mar 2024 15:32:45 +0000 (15:32 +0000)]
Merge pull request #56003 from prazumovsky/wip-63684-reef

RGW - Swift retarget needs bucket set on object

Reviewed-by: Casey Bodley <cbodley@redhat.com>
16 months agomgr/dashboard: fix snap schedule time format 56124/head
Ivo Almeida [Mon, 11 Mar 2024 15:09:57 +0000 (15:09 +0000)]
mgr/dashboard: fix snap schedule time format

Fixes: https://tracker.ceph.com/issues/64831
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
16 months agoMerge pull request #55972 from ceph/wip-yuriw-release-18.2.2-main
Yuri Weinstein [Mon, 11 Mar 2024 15:05:56 +0000 (08:05 -0700)]
Merge pull request #55972 from ceph/wip-yuriw-release-18.2.2-main

doc: reef 18.2.2 release notes

Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
16 months agoMerge pull request #55708 from Matan-B/wip-matanb-crimson-multicore-cluster-msgr
Matan Breizman [Mon, 11 Mar 2024 14:25:15 +0000 (16:25 +0200)]
Merge pull request #55708 from Matan-B/wip-matanb-crimson-multicore-cluster-msgr

crimson/osd/main: Enable multicore cluster messenger

Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agoMerge pull request #55866 from afreen23/fix-rgw-locking
Pedro Gonzalez Gomez [Mon, 11 Mar 2024 13:29:33 +0000 (14:29 +0100)]
Merge pull request #55866 from afreen23/fix-rgw-locking

mgr/dashboard: Locking improvements in bucket create form

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agodoc/cephadm: Improve multiple files 56113/head
Anthony D'Atri [Mon, 11 Mar 2024 07:04:47 +0000 (03:04 -0400)]
doc/cephadm: Improve multiple files

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
16 months agoMerge pull request #55920 from rhcs-dashboard/pytest-fix
Ernesto Puerta [Mon, 11 Mar 2024 10:20:26 +0000 (11:20 +0100)]
Merge pull request #55920 from rhcs-dashboard/pytest-fix

mgr/dashboard: debugging make check failure

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: ronen-fr <NOT@FOUND>
Reviewed-by: Kefu Chai <kchai@redhat.com>
16 months agoMerge pull request #56063 from ivoalmeida/fix-snap-schedule-list-toggle-columns
Ivo Almeida [Mon, 11 Mar 2024 09:21:44 +0000 (09:21 +0000)]
Merge pull request #56063 from ivoalmeida/fix-snap-schedule-list-toggle-columns

mgr/dashboard: fix snap schedule list toggle cols

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
16 months agoMerge pull request #56091 from anthonyeleven/aad-tweak-cephadm
Anthony D'Atri [Mon, 11 Mar 2024 04:05:07 +0000 (00:05 -0400)]
Merge pull request #56091 from anthonyeleven/aad-tweak-cephadm

doc/cephadm: improve host-management.rst

16 months agodoc/cephadm: improve host-management.rst 56091/head
Anthony D'Atri [Sun, 10 Mar 2024 19:49:35 +0000 (15:49 -0400)]
doc/cephadm: improve host-management.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
16 months agoqa/workunits/rbd: switch rbd-mirror workunits to bash 56077/head
Ilya Dryomov [Sat, 9 Mar 2024 21:53:44 +0000 (22:53 +0100)]
qa/workunits/rbd: switch rbd-mirror workunits to bash

By making use of here strings in commit ea3a567f7f03 ("qa/workunits:
make wait_for_status_in_pool_dir() reentrant") we grew a dependency on
bash.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
16 months agoMerge pull request #56076 from zdover23/wip-doc-2024-03-10-glossary-crimson
Anthony D'Atri [Sun, 10 Mar 2024 16:01:43 +0000 (12:01 -0400)]
Merge pull request #56076 from zdover23/wip-doc-2024-03-10-glossary-crimson

doc/glossary: improve "Crimson" entry

16 months agocrimson/osd/osd: handle_scrub_message on any core 55708/head
Matan Breizman [Thu, 7 Mar 2024 09:49:34 +0000 (09:49 +0000)]
crimson/osd/osd: handle_scrub_message on any core

After enabling multicore cluster messenger, there is no
guarantee which core will handle the request.
See: OSDSingletonState::send_to_osd()

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
16 months agodoc/glossary: improve "Crimson" entry 56076/head
Zac Dover [Sun, 10 Mar 2024 10:43:52 +0000 (20:43 +1000)]
doc/glossary: improve "Crimson" entry

Improve the glossary entry for "Crimson" in accordance with Anthony
D'Atri's suggestions here:
https://github.com/ceph/ceph/pull/56068#discussion_r1518580402

Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agoMerge pull request #56068 from zdover23/wip-doc-2024-03-09-glossary-crimson
zdover23 [Sat, 9 Mar 2024 12:47:08 +0000 (22:47 +1000)]
Merge pull request #56068 from zdover23/wip-doc-2024-03-09-glossary-crimson

doc/glossary: add "Crimson" entry

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
16 months agodoc/glossary: add "Crimson" entry 56068/head
Zac Dover [Fri, 8 Mar 2024 17:17:59 +0000 (03:17 +1000)]
doc/glossary: add "Crimson" entry

Add a "Crimson" entry to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agoMerge PR #56071 into main
Patrick Donnelly [Fri, 8 Mar 2024 23:13:27 +0000 (18:13 -0500)]
Merge PR #56071 into main

* refs/pull/56071/head:
qa: fix syntax bug with invalid 60 minute specification

Reviewed-by: Zack Cerza <zack@redhat.com>
16 months agoqa: fix syntax bug with invalid 60 minute specification 56071/head
Patrick Donnelly [Fri, 8 Mar 2024 19:39:17 +0000 (14:39 -0500)]
qa: fix syntax bug with invalid 60 minute specification

Use 8 minute cycles instead.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
16 months agoMerge pull request #55657 from ceph/wip-rgw-meta-topic wip-rgw-meta-topic
Casey Bodley [Fri, 8 Mar 2024 18:10:34 +0000 (18:10 +0000)]
Merge pull request #55657 from ceph/wip-rgw-meta-topic

rgw: replicate v2 topic/notification metadata

Reviewed-by: Krunal Chheda <kchheda3@bloomberg.net>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
16 months agoMerge pull request #56006 from afreen23/http-error-pools-page
Pedro Gonzalez Gomez [Fri, 8 Mar 2024 13:14:12 +0000 (14:14 +0100)]
Merge pull request #56006 from afreen23/http-error-pools-page

mgr/dashboard: handle infinite values for pools

16 months agomgr/dashboard: fix snap schedule list toggle cols 56063/head
Ivo Almeida [Fri, 8 Mar 2024 11:40:41 +0000 (11:40 +0000)]
mgr/dashboard: fix snap schedule list toggle cols

Added isInvisible property to CdColumnTable interface to hide column
from 'toggle columns' drop down checkboxes.

Fixes: https://tracker.ceph.com/issues/64813
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
16 months agoMerge pull request #55984 from xxhdx1985126/wip-rbd-cls-sparsify-test
Ilya Dryomov [Fri, 8 Mar 2024 11:26:13 +0000 (12:26 +0100)]
Merge pull request #55984 from xxhdx1985126/wip-rbd-cls-sparsify-test

test/cls_rbd/test_cls_rbd: change to check for 4KB-aligned sparse read

Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
16 months agomgr/dashboard: handle infinite values for pools 56006/head
Afreen [Wed, 6 Mar 2024 20:22:16 +0000 (01:52 +0530)]
mgr/dashboard: handle infinite values for pools

Fixes https://tracker.ceph.com/issues/64724

Issue:
======
Json parsing is failing because of Infinity values present in pools
meteadata. "read_balance": {"score_acting": Infinity, "score_stable":
Infinity,}
Due to this entire pool list is not rendered.

Fix:
====
Added a handler for checking "inf" values and replacing them with a
string "Infinity" so that json parsing does not fail on frontend.

Signed-off-by: Afreen <afreen23.git@gmail.com>
16 months agoMerge pull request #56045 from zdover23/wip-doc-2024-03-07-pgcalc
zdover23 [Fri, 8 Mar 2024 08:42:19 +0000 (18:42 +1000)]
Merge pull request #56045 from zdover23/wip-doc-2024-03-07-pgcalc

doc/rados: restore PGcalc tool

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agoMerge pull request #55981 from xxhdx1985126/wip-64728
Yingxin [Fri, 8 Mar 2024 07:57:54 +0000 (15:57 +0800)]
Merge pull request #55981 from xxhdx1985126/wip-64728

crimson/os/seastore/collection_manager: allow empty-delta-buffer collection nodes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agoMerge pull request #55888 from myoungwon/wip-seastore-cleanup-is-stable-fix
Yingxin [Fri, 8 Mar 2024 07:56:49 +0000 (15:56 +0800)]
Merge pull request #55888 from myoungwon/wip-seastore-cleanup-is-stable-fix

crimson/os/seastore: cleanup and use LBAMapping::is_stable()

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agocrimson/os/seastore/transaction_manager: minor refinement to remap_pin() asserts 56028/head
Yingxin Cheng [Fri, 8 Mar 2024 07:48:06 +0000 (15:48 +0800)]
crimson/os/seastore/transaction_manager: minor refinement to remap_pin() asserts

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agotest/crimson: drop cout from seastore tests
Yingxin Cheng [Fri, 8 Mar 2024 07:39:40 +0000 (15:39 +0800)]
test/crimson: drop cout from seastore tests

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agocrimson/os/seastore/../fixed_kv_node: add comment to copy-from-source
Yingxin Cheng [Thu, 7 Mar 2024 08:41:25 +0000 (16:41 +0800)]
crimson/os/seastore/../fixed_kv_node: add comment to copy-from-source

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agocrimson/os/seastore: reuse link_phy_tree_root_node()
Yingxin Cheng [Thu, 7 Mar 2024 08:20:07 +0000 (16:20 +0800)]
crimson/os/seastore: reuse link_phy_tree_root_node()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agocrimson/os/cache: get_extent_viewable_by_trans, the extent should be valid
Yingxin Cheng [Thu, 7 Mar 2024 07:46:34 +0000 (15:46 +0800)]
crimson/os/cache: get_extent_viewable_by_trans, the extent should be valid

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agomgr/dashboard: Locking improvements in bucket create form 55866/head
Afreen [Fri, 1 Mar 2024 07:26:25 +0000 (12:56 +0530)]
mgr/dashboard: Locking improvements in bucket create form

Fixes https://tracker.ceph.com/issues/64658
- Addition of help texts
- Addition of info/warnings related to modes and versioning
- change of Locking section layout
- renaming locking to 'Object Locking'
- changes default retention period to 10
- edit bucket only shows lock when its enabled

Signed-off-by: Afreen <afreen23.git@gmail.com>
16 months agodoc/rados: restore PGcalc tool 56045/head
Zac Dover [Thu, 7 Mar 2024 17:29:50 +0000 (03:29 +1000)]
doc/rados: restore PGcalc tool

Restore the PGcalc tool to the documentation suite.

Co-authored-by: Josh Durgin <jdurgin@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agoqa/rgw: notification suite creates a realm 56005/head
Casey Bodley [Thu, 7 Mar 2024 23:07:38 +0000 (18:07 -0500)]
qa/rgw: notification suite creates a realm

Signed-off-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge pull request #55652 from clwluvw/rgw-blockaccesspublic
Casey Bodley [Thu, 7 Mar 2024 16:02:39 +0000 (16:02 +0000)]
Merge pull request #55652 from clwluvw/rgw-blockaccesspublic

rgw: compatibility issues on BucketPublicAccessBlock

Reviewed-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge pull request #56010 from zdover23/wip-doc-2024-03-07-start-get-involved
Anthony D'Atri [Thu, 7 Mar 2024 15:31:55 +0000 (10:31 -0500)]
Merge pull request #56010 from zdover23/wip-doc-2024-03-07-start-get-involved

doc/start: add Slack invite link

16 months agoMerge pull request #55390 from qiuxinyidian/rgw-admin
Casey Bodley [Thu, 7 Mar 2024 15:12:07 +0000 (15:12 +0000)]
Merge pull request #55390 from qiuxinyidian/rgw-admin

rgw: add help info for radosgw-admin list object in bucket

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
16 months agoMerge pull request #56027 from Matan-B/wip-matanb-crimson-docs-walkthrough
Matan Breizman [Thu, 7 Mar 2024 13:29:29 +0000 (15:29 +0200)]
Merge pull request #56027 from Matan-B/wip-matanb-crimson-docs-walkthrough

doc/dev/crimson: add Code Walkthroughs

Reviewed-by: Rongqi Sun <sunrongqi@huawei.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
16 months agoMerge pull request #55226 from rhcs-dashboard/fix-64080-main
Pedro Gonzalez Gomez [Thu, 7 Mar 2024 13:06:38 +0000 (14:06 +0100)]
Merge pull request #55226 from rhcs-dashboard/fix-64080-main

mgr/dashboard: Allow the user to add the access/secret key on zone edit and not on zone creation

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agorgw/kafka: set message timeout to 5 seconds 55952/head
Yuval Lifshitz [Tue, 5 Mar 2024 10:14:06 +0000 (10:14 +0000)]
rgw/kafka: set message timeout to 5 seconds

also increase the idle timeout to 30 seconds.
test instructions:
https://gist.github.com/yuvalif/33487bff19883e3409caa8a843a0b353

Fixes: https://tracker.ceph.com/issues/64710
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
16 months agocrimson/os/cache: cleanup get_extent(_by_type)
Yingxin Cheng [Thu, 7 Mar 2024 07:34:06 +0000 (15:34 +0800)]
crimson/os/cache: cleanup get_extent(_by_type)

Distinguish caching vs absent get_extent interfaces, and misc related
cleanups.

After the lba parent-child pointer optimization, the absent path should
be used.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agocrimson/os/seastore: remove unecessary public interfaces
Yingxin Cheng [Thu, 7 Mar 2024 07:30:39 +0000 (15:30 +0800)]
crimson/os/seastore: remove unecessary public interfaces

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agodoc/dev/crimson: add Code Walkthroughs 56027/head
Matan Breizman [Thu, 7 Mar 2024 09:14:03 +0000 (09:14 +0000)]
doc/dev/crimson: add Code Walkthroughs

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
16 months agocrimson/os/seastore/collection_manager: allow empty-delta-buffer 55981/head
Xuehan Xu [Wed, 6 Mar 2024 05:49:43 +0000 (13:49 +0800)]
crimson/os/seastore/collection_manager: allow empty-delta-buffer
collection nodes

Fixes: https://tracker.ceph.com/issues/64728
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
16 months agocrimson/os/seastore/cache: drop the unnecessary friend fixed_kv_btree
Yingxin Cheng [Thu, 7 Mar 2024 05:42:51 +0000 (13:42 +0800)]
crimson/os/seastore/cache: drop the unnecessary friend fixed_kv_btree

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agoMerge pull request #55804 from rhcs-dashboard/nvmf-traddr-fix
Nizamudeen A [Thu, 7 Mar 2024 05:27:17 +0000 (10:57 +0530)]
Merge pull request #55804 from rhcs-dashboard/nvmf-traddr-fix

mgr/dashboard: listener addr is always none

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>
Reviewed-by: Yehuda Sadeh <yehuda@redhat.com>
16 months agoMerge pull request #55995 from zdover23/wip-doc-2024-03-06-architecture
zdover23 [Thu, 7 Mar 2024 03:17:53 +0000 (13:17 +1000)]
Merge pull request #55995 from zdover23/wip-doc-2024-03-06-architecture

doc/architecture: correct typo

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agodoc/start: add Slack invite link 56010/head
Zac Dover [Thu, 7 Mar 2024 03:01:47 +0000 (13:01 +1000)]
doc/start: add Slack invite link

Add a link to the ceph-storage Slack invitation page. Previously the
link went to a plain old "this is the ceph-storage Slack" page that did
not direct the reader to sign up.

Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agotest/cls_rbd/test_cls_rbd: change to check for 4KB-aligned sparse read 55984/head
Xuehan Xu [Wed, 6 Mar 2024 07:42:58 +0000 (15:42 +0800)]
test/cls_rbd/test_cls_rbd: change to check for 4KB-aligned sparse read

SeaStore::fiemap() can only supported 4096-aligned sparse read.

Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
16 months agoMerge pull request #55967 from mkogan1/wip-rgw-ssl-ses-id-reuse
J. Eric Ivancich [Thu, 7 Mar 2024 01:53:13 +0000 (20:53 -0500)]
Merge pull request #55967 from mkogan1/wip-rgw-ssl-ses-id-reuse

rgw/beast: Enable SSL session-id reuse speedup mechanism

Reviewed-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge pull request #55895 from linuxbox2/wip-sigv4-boundary
J. Eric Ivancich [Thu, 7 Mar 2024 01:52:59 +0000 (20:52 -0500)]
Merge pull request #55895 from linuxbox2/wip-sigv4-boundary

rgw_sigv4: handle '0;' as trailer-chunk boundary

Reviewed-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge pull request #55885 from ivancich/wip-enhance-restore-bi
J. Eric Ivancich [Thu, 7 Mar 2024 01:52:31 +0000 (20:52 -0500)]
Merge pull request #55885 from ivancich/wip-enhance-restore-bi

rgw: make rgw-restore-bucket-index more robust

Reviewed-by: Michael Kidd <linuxkidd@gmail.com>
16 months agoMerge pull request #55977 from myoungwon/wip-allow-dirty-remap
Yingxin [Thu, 7 Mar 2024 01:39:02 +0000 (09:39 +0800)]
Merge pull request #55977 from myoungwon/wip-allow-dirty-remap

crimson/os/seastore: allow to remap the dirty extent

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
16 months agoMerge PR #55909 into main
Venky Shankar [Thu, 7 Mar 2024 01:36:39 +0000 (07:06 +0530)]
Merge PR #55909 into main

* refs/pull/55909/head:
qa/cephfs: add `MON_DOWN' and `deprecated feature inline_data' to ignorelist

Reviewed-by: Rishabh Dave <ridave@redhat.com>
16 months agoMerge PR #55908 into main
Venky Shankar [Thu, 7 Mar 2024 01:35:20 +0000 (07:05 +0530)]
Merge PR #55908 into main

* refs/pull/55908/head:
qa: ignore container checkpoint/restore related selinux denials for centos9
qa: use allowlist instead of whitelist for selinux denials

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
16 months agoMerge PR #55639 into main
Venky Shankar [Thu, 7 Mar 2024 01:33:51 +0000 (07:03 +0530)]
Merge PR #55639 into main

* refs/pull/55639/head:
mds: relax certain asserts in mdlog replay thread

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
16 months agoqa/rgw: teach rgw.py to create an optional realm
Casey Bodley [Wed, 6 Mar 2024 19:04:46 +0000 (14:04 -0500)]
qa/rgw: teach rgw.py to create an optional realm

Signed-off-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge pull request #56000 from cbodley/wip-64678
Casey Bodley [Wed, 6 Mar 2024 21:07:11 +0000 (21:07 +0000)]
Merge pull request #56000 from cbodley/wip-64678

rpm: disable system_qat for non-x86_64 arch

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
16 months agomds/quiesce-db: keep the db thread alive until shutdown 54485/head
Leonid Usov [Wed, 6 Mar 2024 16:06:50 +0000 (18:06 +0200)]
mds/quiesce-db: keep the db thread alive until shutdown

With the change we can now avoid having to join it during the membership update, preventing potential deadlocks

Signed-off-by: Leonid Usov <leonid.usov@ibm.com>
16 months agoRGW - Swift retarget needs bucket set on object 56003/head
Daniel Gryniewicz [Thu, 16 Jun 2022 15:46:24 +0000 (11:46 -0400)]
RGW - Swift retarget needs bucket set on object

When a bucket list is retargeted to an object get, then the object may
not yet have it's bucket set.  Ensure the bucket is set on the object.

Fixes: https://tracker.ceph.com/issues/56029
Signed-off-by: Daniel Gryniewicz <dang@redhat.com>
16 months agorpm: disable system_qat for non-x86_64 arch 56000/head
Casey Bodley [Wed, 6 Mar 2024 14:25:18 +0000 (09:25 -0500)]
rpm: disable system_qat for non-x86_64 arch

Fixes: https://tracker.ceph.com/issues/64678
Signed-off-by: Casey Bodley <cbodley@redhat.com>
16 months agoMerge PR #55820 into main
Patrick Donnelly [Wed, 6 Mar 2024 13:58:43 +0000 (08:58 -0500)]
Merge PR #55820 into main

* refs/pull/55820/head:
qa/crontab: bring back nightlies of release branches
qa/crontab: update upgrade runs for squid/main
qa/crontab: update reef upgrade tests
qa/crontab: update quincy upgrade tests
qa/crontab: remove EOL branches
qa/crontab: add spacing
qa/crontab: update smoke tests for releases

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
16 months agoMerge pull request #55955 from guits/node-proxy-fixes-7.1-blockers-1
Adam King [Wed, 6 Mar 2024 13:37:45 +0000 (08:37 -0500)]
Merge pull request #55955 from guits/node-proxy-fixes-7.1-blockers-1

mgr/node-proxy: handle 'None' statuses returned by RedFish

Reviewed-by: Adam King <adking@redhat.com>
16 months agoMerge pull request #55536 from Matan-B/wip-crimson-snapmapper-get_next
Matan Breizman [Wed, 6 Mar 2024 13:19:40 +0000 (15:19 +0200)]
Merge pull request #55536 from Matan-B/wip-crimson-snapmapper-get_next

osd/SnapMapper: Crimson - fix OSDriver::get_next

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
16 months agorgw: add help info for radosgw-admin list object in bucket 55390/head
Zhipeng Li [Wed, 31 Jan 2024 08:59:58 +0000 (16:59 +0800)]
rgw: add help info for radosgw-admin list object in bucket
Fixes:https://tracker.ceph.com/issues/64264

Signed-off-by: Zhipeng Li <qiuxinyidian@gmail.com>
16 months agodoc/architecture: correct typo 55995/head
Zac Dover [Wed, 6 Mar 2024 11:40:10 +0000 (21:40 +1000)]
doc/architecture: correct typo

s/client/clients/ where necessary, and add a link to the glossary.

Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agoMerge pull request #55982 from zdover23/wip-doc-2024-03-06-dev-developer-guide-testin...
Anthony D'Atri [Wed, 6 Mar 2024 10:51:46 +0000 (05:51 -0500)]
Merge pull request #55982 from zdover23/wip-doc-2024-03-06-dev-developer-guide-testing-integration-tests-workflow

doc/dev: edit teuthology workflow

16 months agoqa/cephfs: add `MON_DOWN' and `deprecated feature inline_data' to ignorelist 55909/head
Venky Shankar [Mon, 26 Feb 2024 05:42:07 +0000 (11:12 +0530)]
qa/cephfs: add `MON_DOWN' and `deprecated feature inline_data' to ignorelist

Fixes: http://tracker.ceph.com/issues/64746
Signed-off-by: Venky Shankar <vshankar@redhat.com>
16 months agoqa: ignore container checkpoint/restore related selinux denials for centos9 55908/head
Venky Shankar [Mon, 4 Mar 2024 01:15:11 +0000 (06:45 +0530)]
qa: ignore container checkpoint/restore related selinux denials for centos9

Fixes: http://tracker.ceph.com/issues/64616
Signed-off-by: Venky Shankar <vshankar@redhat.com>
16 months agoqa: use allowlist instead of whitelist for selinux denials
Venky Shankar [Mon, 4 Mar 2024 01:09:06 +0000 (06:39 +0530)]
qa: use allowlist instead of whitelist for selinux denials

https://github.com/ceph/teuthology/pull/1757 introduced this change,
however, qa/distros continued to use `whitelist' keyword.

Signed-off-by: Venky Shankar <vshankar@redhat.com>
16 months agomgr/node-proxy: handle 'None' statuses returned by RedFish 55955/head
Guillaume Abrioux [Tue, 5 Mar 2024 10:05:18 +0000 (10:05 +0000)]
mgr/node-proxy: handle 'None' statuses returned by RedFish

Looks like RedFish might return 'None' values for some attributes.

for instance:

```
[root@ceph-node-01 ~]# curl -s -k -X GET https://169.254.1.1/redfish/v1/Systems/System.Embedded.1/Storage/AHCI.SL.6-1/Drives/Disk.Direct.0-0:AHCI.SL.6-1 -H "X-Auth-Token: 3264251c28191fa5e7c9ebec49ef90fc"  | jq .Status
{
  "Health": "OK",
  "HealthRollup": "OK",
  "State": "Enabled"
}
[root@ceph-node-01 ~]# curl -s -k -X GET https://169.254.1.1/redfish/v1/Systems/System.Embedded.1/Storage/NonRAID.Slot.2-1/Drives/Disk.Bay.0:Enclosure.Internal.0-1:NonRAID.Slot.2-1 -H "X-Auth-Token: 3264251c28191fa5e7c9ebec49ef90fc" | jq .Status
{
  "Health": null,
  "HealthRollup": null,
  "State": "Enabled"
}
[root@ceph-node-01 ~]#
```

Although this seems to be a bug from RedFish, we need to handle
the case when it happens otherwise it makes the mgr orchestrator module
throw an error.

The idea here is to create a new status "unknown" when we can't fetch the
real status of a component.

Fixes: https://tracker.ceph.com/issues/64712
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
16 months agoMerge pull request #52267 from xxhdx1985126/wip-crimson-pg-snapmapper-obj
Matan Breizman [Wed, 6 Mar 2024 09:00:59 +0000 (11:00 +0200)]
Merge pull request #52267 from xxhdx1985126/wip-crimson-pg-snapmapper-obj

crimson/osd: put snapmapper's key-value pairs into dedicated objs

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
16 months agoMerge pull request #55910 from zhscn/fix-int-string
Matan Breizman [Wed, 6 Mar 2024 08:56:13 +0000 (10:56 +0200)]
Merge pull request #55910 from zhscn/fix-int-string

osd/SnapManager: Crimson - fix std::string constructed from 0

Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
16 months agoMerge pull request #55801 from xxhdx1985126/wip-counting-semaphore
Matan Breizman [Wed, 6 Mar 2024 08:54:49 +0000 (10:54 +0200)]
Merge pull request #55801 from xxhdx1985126/wip-counting-semaphore

crimson/os/alienstore: use homebrew counting_semaphore

Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <kefu.chai@scylladb.com>
16 months agoMerge PR #54202 into main
Venky Shankar [Wed, 6 Mar 2024 08:44:22 +0000 (14:14 +0530)]
Merge PR #54202 into main

* refs/pull/54202/head:
mds: fix `dump dir` indicate dir is not cached

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
16 months agoMerge PR #55457 into main
Venky Shankar [Wed, 6 Mar 2024 08:41:12 +0000 (14:11 +0530)]
Merge PR #55457 into main

* refs/pull/55457/head:
client: check for bad file handle in low level I/O APIs
client: check for bad file handle in ll_preadv_pwritev
client: add function to check if file handle exists
src/test: test async I/O with invalid/closed file handle

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge PR #55619 into main
Venky Shankar [Wed, 6 Mar 2024 08:39:23 +0000 (14:09 +0530)]
Merge PR #55619 into main

* refs/pull/55619/head:
client: fix leak of file handles

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
16 months agomgr/dashboard: Allow the user to add the access/secret key on zone edit 55226/head
Aashish Sharma [Thu, 18 Jan 2024 06:44:42 +0000 (12:14 +0530)]
mgr/dashboard: Allow the user to add the access/secret key on zone edit
and not on zone creation

Fixes: https://tracker.ceph.com/issues/64080
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
16 months agodoc/dev: edit teuthology workflow 55982/head
Zac Dover [Wed, 6 Mar 2024 07:15:20 +0000 (17:15 +1000)]
doc/dev: edit teuthology workflow

Improve a couple of sentences in
doc/dev/developer_guide_testing_integration_tests/tests-integration-testing-teutology-workflow.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agoMerge pull request #55954 from ivoalmeida/fix-cephfs-attach-command
Nizamudeen A [Wed, 6 Mar 2024 06:41:30 +0000 (12:11 +0530)]
Merge pull request #55954 from ivoalmeida/fix-cephfs-attach-command

mgr/dashboard: fixed cephfs mount command

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
16 months agoMerge pull request #54964 from rhcs-dashboard/add-prometheus-federation-cli
Nizamudeen A [Wed, 6 Mar 2024 06:29:08 +0000 (11:59 +0530)]
Merge pull request #54964 from rhcs-dashboard/add-prometheus-federation-cli

mgr/dashboard: add prometheus federation config for mullti-cluster monitoring

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: frittentheke <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
16 months agomgr/dashboard: fix nvmeof api documentation 55804/head
Nizamudeen A [Tue, 5 Mar 2024 10:39:25 +0000 (16:09 +0530)]
mgr/dashboard: fix nvmeof api documentation

From Aviv:
POST /api/nvmeof/hosts - the description of the command it wrong IMO. It is not about creating a host. It is about allowing a host X to access subsystem Y.
GET /api/nvmeof/hosts/{subsystem_nqn} - also the description is not accurate. The command lists all hosts that are allowed to access this subsystem.
DELETE /api/nvmeof/hosts/{subsystem_nqn}/{host_nqn} - again the description should be changed as above.
POST /api/nvmeof/namespace - bad formatting of the description
GET /api/nvmeof/subsystem - the description is wrong, should say - "List all NVMeoF subsystems". And it shouldn't get any param.
POST /api/nvmeof/subsystem - few issues here. The serial_number, and max_namespaces are optional (we need to mention that). Also it is missing the --enable-ha argument that is also optional.
Some commands are missing: log_level, connection.i

Fixes: https://tracker.ceph.com/issues/64714
Signed-off-by: Nizamudeen A <nia@redhat.com>