]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
15 months agoscript/ptl-tool: add switch for tags 56859/head
Patrick Donnelly [Fri, 12 Apr 2024 13:55:32 +0000 (09:55 -0400)]
script/ptl-tool: add switch for tags

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoscript/ptl-tool: conditionally add "QA Release" field
Patrick Donnelly [Fri, 12 Apr 2024 13:54:52 +0000 (09:54 -0400)]
script/ptl-tool: conditionally add "QA Release" field

Use the redmine default.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoMerge pull request #56845 from Svelar/asan_rgw_crypto
Casey Bodley [Fri, 12 Apr 2024 12:59:07 +0000 (13:59 +0100)]
Merge pull request #56845 from Svelar/asan_rgw_crypto

test/test_rgw_crypto: free allocated test_in

Reviewed-by: Casey Bodley <cbodley@redhat.com>
15 months agoMerge pull request #55320 from rishabh-d-dave/mdscaps-update-issues
Rishabh Dave [Fri, 12 Apr 2024 12:56:21 +0000 (18:26 +0530)]
Merge pull request #55320 from rishabh-d-dave/mdscaps-update-issues

cephfs,mon: fix bugs related to updating MDS caps

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agoMerge pull request #56854 from Svelar/asan_bluestore_type
Igor Fedotov [Fri, 12 Apr 2024 11:59:01 +0000 (14:59 +0300)]
Merge pull request #56854 from Svelar/asan_bluestore_type

bluestore/bluestore_types: check 'it' valid before using

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
15 months agoMerge pull request #56758 from ivoalmeida/snapshot-schedule-fix-rentention-policy...
Ivo Almeida [Fri, 12 Apr 2024 11:44:20 +0000 (12:44 +0100)]
Merge pull request #56758 from ivoalmeida/snapshot-schedule-fix-rentention-policy-delete-arg

mgr/dashboard: fix snap schedule delete retention

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
15 months agoMerge pull request #56827 from guits/cv-func-tests
Guillaume Abrioux [Fri, 12 Apr 2024 09:14:42 +0000 (11:14 +0200)]
Merge pull request #56827 from guits/cv-func-tests

ceph-volume: update functional testing

15 months agoMerge pull request #56829 from Svelar/asan_fix_mds
Rongqi Sun [Fri, 12 Apr 2024 08:33:23 +0000 (16:33 +0800)]
Merge pull request #56829 from Svelar/asan_fix_mds

test/TestQuiesceAgent: free quiesce_requests Context

15 months agoceph-volume: update functional testing 56827/head
Guillaume Abrioux [Thu, 11 Apr 2024 07:43:47 +0000 (09:43 +0200)]
ceph-volume: update functional testing

various changes for fixing ceph-volume functional testing.
cleaning up deploy.yml (drop py2 references)

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
15 months agoMerge pull request #56831 from zdover23/wip-doc-2024-04-11-cephfs-client-auth-3-of-3
Zac Dover [Fri, 12 Apr 2024 06:59:50 +0000 (16:59 +1000)]
Merge pull request #56831 from zdover23/wip-doc-2024-04-11-cephfs-client-auth-3-of-3

doc/cephfs: refine client-auth (3 of 3)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agobluestore/bluestore_types: check 'it' valid before using 56854/head
Rongqi Sun [Fri, 12 Apr 2024 06:51:34 +0000 (06:51 +0000)]
bluestore/bluestore_types: check 'it' valid before using

When sanitizer is enabled, unittest_bluestore_types fails as following
```
[ RUN      ] sb_info_space_efficient_map_t.basic
=================================================================
==143714==ERROR: AddressSanitizer: heap-buffer-overflow on address 0xffff99f8b7f4 at pc 0xaaaab50bde18 bp 0xffffebefcdb0 sp 0xffffebefcda8
READ of size 8 at 0xffff99f8b7f4 thread T0
    #0 0xaaaab50bde14 in sb_info_t::get_sbid() const /root/ceph/src/os/bluestore/bluestore_types.h:1337:30
    #1 0xaaaab50a5908 in sb_info_space_efficient_map_t::find(unsigned long) /root/ceph/src/os/bluestore/bluestore_types.h:1385:10
    #2 0xaaaab50bd638 in sb_info_space_efficient_map_t::_add(long) /root/ceph/src/os/bluestore/bluestore_types.h:1424:15
    #3 0xaaaab50a52bc in sb_info_space_efficient_map_t::add_maybe_stray(unsigned long) /root/ceph/src/os/bluestore/bluestore_types.h:1358:12
    #4 0xaaaab4fec03c in sb_info_space_efficient_map_t_basic_Test::TestBody() /root/ceph/src/test/objectstore/test_bluestore_types.cc:113:11
    #5 0xaaaab51e9a40 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2605:10
    #6 0xaaaab5197040 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2641:14
    #7 0xaaaab51488a4 in testing::Test::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:2680:5
    #8 0xaaaab514a7e8 in testing::TestInfo::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:2858:11
    #9 0xaaaab514bde8 in testing::TestSuite::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:3012:28
    #10 0xaaaab5167bac in testing::internal::UnitTestImpl::RunAllTests() /root/ceph/src/googletest/googletest/src/gtest.cc:5723:44
    #11 0xaaaab51f3940 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2605:10
    #12 0xaaaab519e5d8 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2641:14
    #13 0xaaaab5167024 in testing::UnitTest::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:5306:10
    #14 0xaaaab50b4d6c in RUN_ALL_TESTS() /root/ceph/src/googletest/googletest/include/gtest/gtest.h:2486:46
    #15 0xaaaab50a1080 in main /root/ceph/src/test/objectstore/test_bluestore_types.cc:2847:10
    #16 0xffff9d6c73f8 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #17 0xffff9d6c74c8 in __libc_start_main csu/../csu/libc-start.c:392:3
    #18 0xaaaab4f3812c in _start (/root/ceph/build/bin/unittest_bluestore_types+0xe4812c) (BuildId: cb75399658026f83a4e89012de8fb02f08f6d239)

0xffff99f8b7f4 is located 0 bytes to the right of 20-byte region [0xffff99f8b7e0,0xffff99f8b7f4)
allocated by thread T0 here:
    #0 0xaaaab4fe636c in operator new[](unsigned long) (/root/ceph/build/bin/unittest_bluestore_types+0xef636c) (BuildId: cb75399658026f83a4e89012de8fb02f08f6d239)
    #1 0xaaaab50c0d2c in mempool::pool_allocator<(mempool::pool_index_t)11, sb_info_t>::allocate(unsigned long, void*) /root/ceph/src/include/mempool.h:375:33
    #2 0xaaaab50c0c0c in std::allocator_traits<mempool::pool_allocator<(mempool::pool_index_t)11, sb_info_t> >::allocate(mempool::pool_allocator<(mempool::pool_index_t)11, sb_info_t>&, unsigned long) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/alloc_traits.h:318:20
    #3 0xaaaab50c044c in std::_Vector_base<sb_info_t, mempool::pool_allocator<(mempool::pool_index_t)11, sb_info_t> >::_M_allocate(unsigned long) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/stl_vector.h:346:20
    #4 0xaaaab50bf954 in void std::vector<sb_info_t, mempool::pool_allocator<(mempool::pool_index_t)11, sb_info_t> >::_M_realloc_insert<long&>(__gnu_cxx::__normal_iterator<sb_info_t*, std::vector<sb_info_t, mempool::pool_allocator<(mempool::pool_index_t)11, sb_info_t> > >, long&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/vector.tcc:440:33
    #5 0xaaaab50be0d8 in sb_info_t& std::vector<sb_info_t, mempool::pool_allocator<(mempool::pool_index_t)11, sb_info_t> >::emplace_back<long&>(long&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/vector.tcc:121:4
    #6 0xaaaab50bd760 in sb_info_space_efficient_map_t::_add(long) /root/ceph/src/os/bluestore/bluestore_types.h:1429:24
    #7 0xaaaab50a5e78 in sb_info_space_efficient_map_t::add_or_adopt(unsigned long) /root/ceph/src/os/bluestore/bluestore_types.h:1361:15
    #8 0xaaaab4feb07c in sb_info_space_efficient_map_t_basic_Test::TestBody() /root/ceph/src/test/objectstore/test_bluestore_types.cc:103:11
    #9 0xaaaab51e9a40 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2605:10
    #10 0xaaaab5197040 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2641:14
    #11 0xaaaab51488a4 in testing::Test::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:2680:5
    #12 0xaaaab514a7e8 in testing::TestInfo::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:2858:11
    #13 0xaaaab514bde8 in testing::TestSuite::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:3012:28
    #14 0xaaaab5167bac in testing::internal::UnitTestImpl::RunAllTests() /root/ceph/src/googletest/googletest/src/gtest.cc:5723:44
    #15 0xaaaab51f3940 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2605:10
    #16 0xaaaab519e5d8 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2641:14
    #17 0xaaaab5167024 in testing::UnitTest::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:5306:10
    #18 0xaaaab50b4d6c in RUN_ALL_TESTS() /root/ceph/src/googletest/googletest/include/gtest/gtest.h:2486:46
    #19 0xaaaab50a1080 in main /root/ceph/src/test/objectstore/test_bluestore_types.cc:2847:10
    #20 0xffff9d6c73f8 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #21 0xffff9d6c74c8 in __libc_start_main csu/../csu/libc-start.c:392:3
    #22 0xaaaab4f3812c in _start (/root/ceph/build/bin/unittest_bluestore_types+0xe4812c) (BuildId: cb75399658026f83a4e89012de8fb02f08f6d239)

SUMMARY: AddressSanitizer: heap-buffer-overflow /root/ceph/src/os/bluestore/bluestore_types.h:1337:30 in sb_info_t::get_sbid() const
Shadow bytes around the buggy address:
  0x200ff33f16a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ff33f16b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ff33f16c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ff33f16d0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ff33f16e0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
=>0x200ff33f16f0: fa fa fa fa fa fa fa fa fa fa fa fa 00 00[04]fa
  0x200ff33f1700: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ff33f1710: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ff33f1720: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ff33f1730: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
  0x200ff33f1740: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa
Shadow byte legend (one shadow byte represents 8 application bytes):
  Addressable:           00
  Partially addressable: 01 02 03 04 05 06 07
  Heap left redzone:       fa
  Freed heap region:       fd
  Stack left redzone:      f1
  Stack mid redzone:       f2
  Stack right redzone:     f3
  Stack after return:      f5
  Stack use after scope:   f8
  Global redzone:          f9
  Global init order:       f6
  Poisoned by user:        f7
  Container overflow:      fc
  Array cookie:            ac
  Intra object redzone:    bb
  ASan internal:           fe
  Left alloca redzone:     ca
  Right alloca redzone:    cb
==143714==ABORTING
```

'it' might be invalid, so before using 'it', need to figure validity out

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
15 months agoMerge PR #53564 into main
Venky Shankar [Fri, 12 Apr 2024 05:15:56 +0000 (10:45 +0530)]
Merge PR #53564 into main

* refs/pull/53564/head:
qa: add split/merge dirfrag tests for scrub
mds: Add fragment to scrub

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
15 months agotest/test_rgw_crypto: free allocated test_in 56845/head
Rongqi Sun [Fri, 12 Apr 2024 02:34:01 +0000 (02:34 +0000)]
test/test_rgw_crypto: free allocated test_in

When sanitizer is enabled, unittest__rgw_crypto shows

```
=================================================================
==136464==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 75023 byte(s) in 22 object(s) allocated from:
    #0 0xaaaabf7fb86c in operator new[](unsigned long) (/root/ceph/build/bin/unittest_rgw_crypto+0x48b86c) (BuildId: 8023dc30820215da92d6d4883620bedd8ac1190d)
    #1 0xaaaabf81db48 in TestRGWCrypto_verify_Encrypt_Decrypt_Test::TestBody() /root/ceph/src/test/rgw/test_rgw_crypto.cc:780:24
    #2 0xaaaabf9018ac in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2605:10
    #3 0xaaaabf8b08a4 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2641:14
    #4 0xaaaabf861f88 in testing::Test::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:2680:5
    #5 0xaaaabf863ecc in testing::TestInfo::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:2858:11
    #6 0xaaaabf8654cc in testing::TestSuite::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:3012:28
    #7 0xaaaabf881290 in testing::internal::UnitTestImpl::RunAllTests() /root/ceph/src/googletest/googletest/src/gtest.cc:5723:44
    #8 0xaaaabf90b7ac in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2605:10
    #9 0xaaaabf8b7ac0 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2641:14
    #10 0xaaaabf880708 in testing::UnitTest::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:5306:10
    #11 0xaaaabf823d70 in RUN_ALL_TESTS() /root/ceph/src/googletest/googletest/include/gtest/gtest.h:2486:46
    #12 0xaaaabf81f390 in main /root/ceph/src/test/rgw/test_rgw_crypto.cc:822:10
    #13 0xffff878673f8 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #14 0xffff878674c8 in __libc_start_main csu/../csu/libc-start.c:392:3
    #15 0xaaaabf74d62c in _start (/root/ceph/build/bin/unittest_rgw_crypto+0x3dd62c) (BuildId: 8023dc30820215da92d6d4883620bedd8ac1190d)

SUMMARY: AddressSanitizer: 75023 byte(s) leaked in 22 allocation(s).
```

test_in should be freed to address the warning.

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
15 months agoMerge pull request #56784 from zdover23/wip-doc-2024-04-09-cephfs-client-auth-2-of-3
Zac Dover [Fri, 12 Apr 2024 02:01:57 +0000 (12:01 +1000)]
Merge pull request #56784 from zdover23/wip-doc-2024-04-09-cephfs-client-auth-2-of-3

doc/cephfs: refine client-auth (2 of 3)

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
15 months agoMerge pull request #56734 from zmc/cmake-sccache
Zack Cerza [Fri, 12 Apr 2024 00:53:44 +0000 (18:53 -0600)]
Merge pull request #56734 from zmc/cmake-sccache

cmake: Support sccache

15 months agoMerge PR #56839 into main
Patrick Donnelly [Thu, 11 Apr 2024 23:00:53 +0000 (19:00 -0400)]
Merge PR #56839 into main

* refs/pull/56839/head:
script/ptl-tool: push branch to shaman for qa runs
script/ptl-tool: add release name to branch with switch
script/ptl-tool: alphabetize arguments
script/ptl-tool: avoid repo specific remotes entirely
script/ptl-tool: improve help text for envvars

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
15 months agoscript/ptl-tool: push branch to shaman for qa runs 56839/head
Patrick Donnelly [Thu, 11 Apr 2024 19:13:10 +0000 (15:13 -0400)]
script/ptl-tool: push branch to shaman for qa runs

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoscript/ptl-tool: add release name to branch with switch
Patrick Donnelly [Thu, 11 Apr 2024 19:16:18 +0000 (15:16 -0400)]
script/ptl-tool: add release name to branch with switch

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoscript/ptl-tool: alphabetize arguments
Patrick Donnelly [Thu, 11 Apr 2024 19:08:43 +0000 (15:08 -0400)]
script/ptl-tool: alphabetize arguments

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoscript/ptl-tool: avoid repo specific remotes entirely
Patrick Donnelly [Thu, 11 Apr 2024 19:06:48 +0000 (15:06 -0400)]
script/ptl-tool: avoid repo specific remotes entirely

So we don't need to configure the remote name or paths at all. Just use
universal ssh remote URLs instead.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoscript/ptl-tool: improve help text for envvars
Patrick Donnelly [Thu, 11 Apr 2024 18:34:34 +0000 (14:34 -0400)]
script/ptl-tool: improve help text for envvars

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoMerge PR #56835 into main
Patrick Donnelly [Thu, 11 Apr 2024 17:10:59 +0000 (13:10 -0400)]
Merge PR #56835 into main

* refs/pull/56835/head:
script/ptl-tool: create qa trackers for test branches
script/ptl-tool: add switch for debugging
script/ptl-tool: add --stop-at-built flag

Reviewed-by: Yuri Weinstein <yweins@redhat.com>
15 months agoscript/ptl-tool: create qa trackers for test branches 56835/head
Patrick Donnelly [Thu, 11 Apr 2024 16:47:04 +0000 (12:47 -0400)]
script/ptl-tool: create qa trackers for test branches

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoscript/ptl-tool: add switch for debugging
Patrick Donnelly [Thu, 11 Apr 2024 16:35:02 +0000 (12:35 -0400)]
script/ptl-tool: add switch for debugging

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoscript/ptl-tool: add --stop-at-built flag
Patrick Donnelly [Thu, 11 Apr 2024 13:23:30 +0000 (09:23 -0400)]
script/ptl-tool: add --stop-at-built flag

To make modifications to the branch before it is tagged and a branch name
created.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoMerge pull request #55381 from linuxbox2/wip-rgw-sigxfsz
Casey Bodley [Thu, 11 Apr 2024 14:29:15 +0000 (15:29 +0100)]
Merge pull request #55381 from linuxbox2/wip-rgw-sigxfsz

rgw: ignore SIGXFSZ, which apparently can triggered by heavy ops-log …

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
15 months agoMerge pull request #56794 from adk3798/cephadm-raw-osd-teuthology-test
Guillaume Abrioux [Thu, 11 Apr 2024 13:30:59 +0000 (15:30 +0200)]
Merge pull request #56794 from adk3798/cephadm-raw-osd-teuthology-test

qa/cephadm: teuthology test for deploying raw OSDs

15 months agoMerge pull request #56785 from cbodley/wip-uninstall-motr
Casey Bodley [Thu, 11 Apr 2024 12:42:59 +0000 (13:42 +0100)]
Merge pull request #56785 from cbodley/wip-uninstall-motr

install-deps: remove cortx-motr integration

Reviewed-by: Zack Cerza <zack@redhat.com>
15 months agodoc/cephfs: refine client-auth (3 of 3) 56831/head
Zac Dover [Thu, 11 Apr 2024 11:18:53 +0000 (21:18 +1000)]
doc/cephfs: refine client-auth (3 of 3)

Refine the final third of doc/cephfs/client-auth.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
15 months agotest/TestQuiesceAgent: free quiesce_requests Context 56829/head
Rongqi Sun [Thu, 11 Apr 2024 08:18:29 +0000 (08:18 +0000)]
test/TestQuiesceAgent: free quiesce_requests Context

When sanitizer is enabled, unittest_mds_quiesce_agent fails as following

```
[==========] Running 5 tests from 1 test suite.
[----------] Global test environment set-up.
[----------] 5 tests from QuiesceAgentTest
[ RUN      ] QuiesceAgentTest.ThreadManagement
[       OK ] QuiesceAgentTest.ThreadManagement (3 ms)
[ RUN      ] QuiesceAgentTest.DbUpdates
[       OK ] QuiesceAgentTest.DbUpdates (1 ms)
[ RUN      ] QuiesceAgentTest.QuiesceProtocol
[       OK ] QuiesceAgentTest.QuiesceProtocol (3 ms)
[ RUN      ] QuiesceAgentTest.DuplicateQuiesceRequest
[       OK ] QuiesceAgentTest.DuplicateQuiesceRequest (2 ms)
[ RUN      ] QuiesceAgentTest.TimeoutBeforeComplete
[       OK ] QuiesceAgentTest.TimeoutBeforeComplete (2 ms)
[----------] 5 tests from QuiesceAgentTest (11 ms total)

[----------] Global test environment tear-down
[==========] 5 tests from 1 test suite ran. (11 ms total)
[  PASSED  ] 5 tests.

=================================================================
==3975692==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 64 byte(s) in 1 object(s) allocated from:
    #0 0xaaaadd81c7c8 in operator new(unsigned long) (/root/ceph/build/bin/unittest_mds_quiesce_agent+0x1fc7c8) (BuildId: 7d45344ba1e43661d9de484f0a5d129377c4d4ae)
    #1 0xaaaadd8878d8 in QuiesceAgent::agent_thread_main() /root/ceph/src/mds/QuiesceAgent.cc:136:68
    #2 0xaaaadd86de38 in QuiesceAgent::AgentThread::entry() /root/ceph/src/mds/QuiesceAgent.h:244:24
    #3 0xffff83d6b554 in Thread::entry_wrapper() /root/ceph/src/common/Thread.cc:87:10
    #4 0xffff83d6b314 in Thread::_entry_func(void*) /root/ceph/src/common/Thread.cc:74:29
    #5 0xffff8154d5c4 in start_thread nptl/./nptl/pthread_create.c:442:8
    #6 0xffff815b5ed8  misc/../sysdeps/unix/sysv/linux/aarch64/clone.S:79

Indirect leak of 120 byte(s) in 1 object(s) allocated from:
    #0 0xaaaadd81c7c8 in operator new(unsigned long) (/root/ceph/build/bin/unittest_mds_quiesce_agent+0x1fc7c8) (BuildId: 7d45344ba1e43661d9de484f0a5d129377c4d4ae)
    #1 0xaaaadd8af4f4 in __gnu_cxx::new_allocator<std::_Sp_counted_ptr_inplace<QuiesceAgent::TrackedRoot, std::allocator<QuiesceAgent::TrackedRoot>, (__gnu_cxx::_Lock_policy)2> >::allocate(unsigned long, void const*) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:127:27
    #2 0xaaaadd8af3d8 in std::allocator<std::_Sp_counted_ptr_inplace<QuiesceAgent::TrackedRoot, std::allocator<QuiesceAgent::TrackedRoot>, (__gnu_cxx::_Lock_policy)2> >::allocate(unsigned long) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/allocator.h:185:32
    #3 0xaaaadd8af3d8 in std::allocator_traits<std::allocator<std::_Sp_counted_ptr_inplace<QuiesceAgent::TrackedRoot, std::allocator<QuiesceAgent::TrackedRoot>, (__gnu_cxx::_Lock_policy)2> > >::allocate(std::allocator<std::_Sp_counted_ptr_inplace<QuiesceAgent::TrackedRoot, std::allocator<QuiesceAgent::TrackedRoot>, (__gnu_cxx::_Lock_policy)2> >&, unsigned long) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/alloc_traits.h:464:20
    #4 0xaaaadd8aef00 in std::__allocated_ptr<std::allocator<std::_Sp_counted_ptr_inplace<QuiesceAgent::TrackedRoot, std::allocator<QuiesceAgent::TrackedRoot>, (__gnu_cxx::_Lock_policy)2> > > std::__allocate_guarded<std::allocator<std::_Sp_counted_ptr_inplace<QuiesceAgent::TrackedRoot, std::allocator<QuiesceAgent::TrackedRoot>, (__gnu_cxx::_Lock_policy)2> > >(std::allocator<std::_Sp_counted_ptr_inplace<QuiesceAgent::TrackedRoot, std::allocator<QuiesceAgent::TrackedRoot>, (__gnu_cxx::_Lock_policy)2> >&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/allocated_ptr.h:98:21
    #5 0xaaaadd8aec14 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::__shared_count<QuiesceAgent::TrackedRoot, std::allocator<QuiesceAgent::TrackedRoot>, QuiesceState&, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >&>(QuiesceAgent::TrackedRoot*&, std::_Sp_alloc_shared_tag<std::allocator<QuiesceAgent::TrackedRoot> >, QuiesceState&, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:648:19
    #6 0xaaaadd8ae988 in std::__shared_ptr<QuiesceAgent::TrackedRoot, (__gnu_cxx::_Lock_policy)2>::__shared_ptr<std::allocator<QuiesceAgent::TrackedRoot>, QuiesceState&, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >&>(std::_Sp_alloc_shared_tag<std::allocator<QuiesceAgent::TrackedRoot> >, QuiesceState&, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr_base.h:1342:14
    #7 0xaaaadd8ae70c in std::shared_ptr<QuiesceAgent::TrackedRoot>::shared_ptr<std::allocator<QuiesceAgent::TrackedRoot>, QuiesceState&, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >&>(std::_Sp_alloc_shared_tag<std::allocator<QuiesceAgent::TrackedRoot> >, QuiesceState&, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr.h:409:4
    #8 0xaaaadd8ae484 in std::shared_ptr<QuiesceAgent::TrackedRoot> std::allocate_shared<QuiesceAgent::TrackedRoot, std::allocator<QuiesceAgent::TrackedRoot>, QuiesceState&, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >&>(std::allocator<QuiesceAgent::TrackedRoot> const&, QuiesceState&, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr.h:862:14
    #9 0xaaaadd88ff0c in std::shared_ptr<QuiesceAgent::TrackedRoot> std::make_shared<QuiesceAgent::TrackedRoot, QuiesceState&, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >&>(QuiesceState&, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/shared_ptr.h:878:14
    #10 0xaaaadd884a6c in QuiesceAgent::db_update(QuiesceMap&) /root/ceph/src/mds/QuiesceAgent.cc:60:26
    #11 0xaaaadd84a840 in QuiesceAgentTest::update(QuiesceDbVersion, std::initializer_list<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, QuiesceMap::RootInfo> >) /root/ceph/src/test/mds/TestQuiesceAgent.cc:156:18
    #12 0xaaaadd84985c in QuiesceAgentTest::update(unsigned long, std::initializer_list<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, QuiesceMap::RootInfo> >) /root/ceph/src/test/mds/TestQuiesceAgent.cc:165:14
    #13 0xaaaadd8288a8 in QuiesceAgentTest_DbUpdates_Test::TestBody() /root/ceph/src/test/mds/TestQuiesceAgent.cc:213:16
    #14 0xaaaadd977230 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2605:10
    #15 0xaaaadd924590 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2641:14
    #16 0xaaaadd8d4a40 in testing::Test::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:2680:5
    #17 0xaaaadd8d6984 in testing::TestInfo::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:2858:11
    #18 0xaaaadd8d7f84 in testing::TestSuite::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:3012:28
    #19 0xaaaadd8f3d48 in testing::internal::UnitTestImpl::RunAllTests() /root/ceph/src/googletest/googletest/src/gtest.cc:5723:44
    #20 0xaaaadd981130 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2605:10
    #21 0xaaaadd92bb64 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /root/ceph/src/googletest/googletest/src/gtest.cc:2641:14
    #22 0xaaaadd8f31c0 in testing::UnitTest::Run() /root/ceph/src/googletest/googletest/src/gtest.cc:5306:10
    #23 0xaaaadd820710 in RUN_ALL_TESTS() /root/ceph/src/googletest/googletest/include/gtest/gtest.h:2486:46
    #24 0xaaaadd81ed3c in main /root/ceph/src/test/unit.cc:45:10
    #25 0xffff814f73f8 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
    #26 0xffff814f74c8 in __libc_start_main csu/../csu/libc-start.c:392:3
    #27 0xaaaadd76e6ac in _start (/root/ceph/build/bin/unittest_mds_quiesce_agent+0x14e6ac) (BuildId: 7d45344ba1e43661d9de484f0a5d129377c4d4ae)

SUMMARY: AddressSanitizer: 184 byte(s) leaked in 2 allocation(s).
```

quiesce_requests Context should be freed.

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
15 months agoMerge pull request #56561 from phlogistonjohn/jjm-issue65122-maint-cmd
Adam King [Wed, 10 Apr 2024 17:36:43 +0000 (13:36 -0400)]
Merge pull request #56561 from phlogistonjohn/jjm-issue65122-maint-cmd

cephadm: fix host-maintenance command always exiting with a failure

Reviewed-by: Adam King <adking@redhat.com>
15 months agoMerge pull request #56716 from adk3798/test_cephadm_images
Adam King [Wed, 10 Apr 2024 17:34:31 +0000 (13:34 -0400)]
Merge pull request #56716 from adk3798/test_cephadm_images

qa/cephadm: update images for test_cephadm workunit

Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agoMerge pull request #56481 from adk3798/test-cephadm-idmap-conf
Adam King [Wed, 10 Apr 2024 17:30:31 +0000 (13:30 -0400)]
Merge pull request #56481 from adk3798/test-cephadm-idmap-conf

cephadm: add idmap.conf to nfs sample file

Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agoMerge pull request #56791 from adk3798/nvmeof-mon-setting
Adam King [Wed, 10 Apr 2024 17:20:46 +0000 (13:20 -0400)]
Merge pull request #56791 from adk3798/nvmeof-mon-setting

mgr/cephadm: make enable_monitor_client configurable for nvmeof

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agoMerge pull request #56613 from NitzanMordhai/wip-nitzan-osd-down-ignore-cephadm-suites
Adam King [Wed, 10 Apr 2024 17:17:08 +0000 (13:17 -0400)]
Merge pull request #56613 from NitzanMordhai/wip-nitzan-osd-down-ignore-cephadm-suites

suites/rados/cephadm: adding OSD_DOWN to the log-ignorelist

Reviewed-by: Adam King <adking@redhat.com>
15 months agoMerge pull request #56765 from cbodley/wip-65373
Casey Bodley [Wed, 10 Apr 2024 16:35:03 +0000 (17:35 +0100)]
Merge pull request #56765 from cbodley/wip-65373

rgw/multisite: x-rgw-replicated-at uses dump_time_header()

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
15 months agoMerge pull request #55661 from shreyanshjain7174/tracker_63791
Casey Bodley [Wed, 10 Apr 2024 14:25:43 +0000 (15:25 +0100)]
Merge pull request #55661 from shreyanshjain7174/tracker_63791

RGW: a subuser with no permission can still list buckets and create buckets

Reviewed-by: Jiffin Tony Thottan <jthottan@redhat.com>
15 months agoMerge pull request #56789 from cbodley/wip-65334
Ali Maredia [Wed, 10 Apr 2024 13:31:19 +0000 (09:31 -0400)]
Merge pull request #56789 from cbodley/wip-65334

qa/rgw: barbican uses branch stable/2023.1

Reviewed-by: Ali Maredia <amaredia@redhat.com>
15 months agoMerge pull request #56728 from pritha-srivastava/wip-rgw-d4n-compilation-errors
J. Eric Ivancich [Wed, 10 Apr 2024 12:52:53 +0000 (08:52 -0400)]
Merge pull request #56728 from pritha-srivastava/wip-rgw-d4n-compilation-errors

rgw/d4n: fix compilation issue when WITH_RADOSGW_D4N=OFF.

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
15 months agoMerge pull request #56704 from cbodley/wip-rgw-default-http-error
Casey Bodley [Wed, 10 Apr 2024 12:52:12 +0000 (13:52 +0100)]
Merge pull request #56704 from cbodley/wip-rgw-default-http-error

rgw: don't map to EIO in rgw_http_error_to_errno()

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
15 months agoMerge PR #56629 into main
Venky Shankar [Wed, 10 Apr 2024 11:56:16 +0000 (17:26 +0530)]
Merge PR #56629 into main

* refs/pull/56629/head:
mds: log at a lower level when stopping

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
15 months agoMerge pull request #55663 from yuvalif/wip-yuval-63909
Yuval Lifshitz [Wed, 10 Apr 2024 10:29:19 +0000 (13:29 +0300)]
Merge pull request #55663 from yuvalif/wip-yuval-63909

test/rgw/notifications: do not delay http responses to notifications

Reviewed-by: Casey Bodley <cbodley@redhat.com>, Ali Marsawa <ali.masarwa@ibm.com>, Krunal Chheda <kchheda3@bloomberg.net>
15 months agocmake: Support sccache 56734/head
Zack Cerza [Thu, 14 Mar 2024 21:24:30 +0000 (15:24 -0600)]
cmake: Support sccache

Signed-off-by: Zack Cerza <zack@redhat.com>
15 months agoMerge pull request #56774 from idryomov/wip-doc-releases-reef-latest
Anthony D'Atri [Tue, 9 Apr 2024 21:28:26 +0000 (17:28 -0400)]
Merge pull request #56774 from idryomov/wip-doc-releases-reef-latest

doc: reorder "releases" entries for reef to fix the diagram

15 months agoMerge pull request #56796 from zdover23/wip-doc-2024-04-10-mgr-zabbix
Zac Dover [Tue, 9 Apr 2024 20:18:56 +0000 (06:18 +1000)]
Merge pull request #56796 from zdover23/wip-doc-2024-04-10-mgr-zabbix

doc/mgr: remove Zabbix 1 information

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agodoc/mgr: remove Zabbix 1 information 56796/head
Zac Dover [Tue, 9 Apr 2024 20:04:28 +0000 (06:04 +1000)]
doc/mgr: remove Zabbix 1 information

Remove information about the installation of the Zabbix module and link
to a discussion of the reasoning behind Ceph's refusal to support
Zabbix.

John Jasen developed a procedure explaining how to install "Zabbix 2".
This commit removes outdated procedures and explains why those
procedures were removed. Immediately following this explanation, the
text includes an explanation of how to install "Zabbix 2".

Signed-off-by: Zac Dover <zac.dover@proton.me>
15 months agoqa/cephadm: add test that deploys raw OSDs 56794/head
Adam King [Tue, 9 Apr 2024 18:01:23 +0000 (14:01 -0400)]
qa/cephadm: add test that deploys raw OSDs

The test relies on the fact that
'ceph-volume lvm list' returns a nonzero
rc when there are no lvm OSDs present

```
root@smithi156:/# ceph-volume lvm list
No valid Ceph lvm devices found
root@smithi156:/# echo $?
1
```

with lvm OSDs present, it will instead
reports on the lvs and give a zero rc

```
root@smithi097:/# ceph-volume lvm list

====== osd.0 =======

  [block]       /dev/ceph-ffeadaf4-...

...

root@smithi097:/# echo $?
0
```

Assuming the override this test has works
properly and all the OSDs we see are raw,
we can use the nonzero rc to confirm the
OSDs ar raw

Signed-off-by: Adam King <adking@redhat.com>
15 months agoqa/cephadm: add ability to deploy raw OSDS from cephadm task
Adam King [Tue, 9 Apr 2024 17:59:56 +0000 (13:59 -0400)]
qa/cephadm: add ability to deploy raw OSDS from cephadm task

For now, it only works in a roleless fashion as OSD deployment
with roles is a bit more complicated. Unless we want to deploy
a mix of raw and lvm OSDs in one test, having it work in roleless
setups should be enough.

Signed-off-by: Adam King <adking@redhat.com>
15 months agotest/rgw/notification: fix threading issue in test 55663/head
Yuval Lifshitz [Tue, 9 Apr 2024 10:00:08 +0000 (10:00 +0000)]
test/rgw/notification: fix threading issue in test

test_ps_s3_persistent_topic_stats may delete boto client threads
before they are done.
also, no need to run the http server twice

Fixes: https://tracker.ceph.com/issues/63909
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
15 months agoqa/rgw: barbican uses branch stable/2023.1 56789/head
Casey Bodley [Tue, 9 Apr 2024 15:14:51 +0000 (11:14 -0400)]
qa/rgw: barbican uses branch stable/2023.1

the stable/xena branch no longer exists. it was moved to
unmaintained/xena. use the same stable/2023.1 branch as keystone

Fixes: https://tracker.ceph.com/issues/65334
Signed-off-by: Casey Bodley <cbodley@redhat.com>
15 months agomgr/cephadm: make enable_monitor_client configurable for nvmeof 56791/head
Adam King [Tue, 9 Apr 2024 16:19:06 +0000 (12:19 -0400)]
mgr/cephadm: make enable_monitor_client configurable for nvmeof

Currently, the mon client work is not merged on main, but our
default nvmeof container will attempt to make use of it by default,
causing it to crash. This makes it configurable and defaults the
behavior to false. That can be changed once the work is actually
present in main.

Signed-off-by: Adam King <adking@redhat.com>
15 months agoMerge pull request #56577 from nbalacha/wip-nbalacha-code-cleanup
Ilya Dryomov [Tue, 9 Apr 2024 14:05:35 +0000 (16:05 +0200)]
Merge pull request #56577 from nbalacha/wip-nbalacha-code-cleanup

rbd-mirror: rename on_stop_journal_replay() and some operator<< arguments

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
15 months agoinstall-deps: remove cortx-motr integration 56785/head
Casey Bodley [Tue, 9 Apr 2024 12:47:49 +0000 (08:47 -0400)]
install-deps: remove cortx-motr integration

Signed-off-by: Casey Bodley <cbodley@redhat.com>
15 months agodoc/cephfs: refine client-auth (2 of 3) 56784/head
Zac Dover [Tue, 9 Apr 2024 12:04:46 +0000 (22:04 +1000)]
doc/cephfs: refine client-auth (2 of 3)

Refine the second third of doc/cephfs/client-auth.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
15 months agoMerge pull request #56754 from zdover23/wip-doc-2024-04-08-cephfs-client-auth-1-of-3
Zac Dover [Tue, 9 Apr 2024 11:30:49 +0000 (21:30 +1000)]
Merge pull request #56754 from zdover23/wip-doc-2024-04-08-cephfs-client-auth-1-of-3

doc/cephfs: refine client-auth (1 of 3)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agoMerge pull request #56459 from ronen-fr/wip-rf-nohist3
Ronen Friedman [Tue, 9 Apr 2024 09:55:05 +0000 (12:55 +0300)]
Merge pull request #56459 from ronen-fr/wip-rf-nohist3

osd/scrub: implement reservation state as a ReplicaActive flag

Reviewed-by: Samuel Just <sjust@redhat.com>
15 months agoMerge pull request #56641 from rhcs-dashboard/wip-65268-main
Ernesto Puerta [Tue, 9 Apr 2024 09:29:18 +0000 (11:29 +0200)]
Merge pull request #56641 from rhcs-dashboard/wip-65268-main

mgr/dashboard: update NVMeoF gRPC: "listener add" changes

Reviewed-by: gbregman <NOT@FOUND>
15 months agotest/rgw/notification: use polling instead of sleep
Yuval Lifshitz [Thu, 4 Apr 2024 17:14:31 +0000 (17:14 +0000)]
test/rgw/notification: use polling instead of sleep

when checking persistent stats queue length

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
15 months agotest/rgw/notification: cleanup leftover topics
Yuval Lifshitz [Thu, 4 Apr 2024 16:25:33 +0000 (16:25 +0000)]
test/rgw/notification: cleanup leftover topics

this may happen when a test fails, and does not cleanup topics
it created. other tests that verify the number of topics may fail
because of that.
all tests that verify number of topics, should delete all topics at the
start of the test.

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
15 months agotest/rgw/notification: use simpler multithreaded http server
Yuval Lifshitz [Mon, 25 Mar 2024 11:11:31 +0000 (11:11 +0000)]
test/rgw/notification: use simpler multithreaded http server

Fixes: https://tracker.ceph.com/issues/63909
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
15 months agoMerge pull request #56383 from xxhdx1985126/wip-seastore-btree-cleanup
Yingxin [Tue, 9 Apr 2024 08:36:38 +0000 (16:36 +0800)]
Merge pull request #56383 from xxhdx1985126/wip-seastore-btree-cleanup

crimson/os/seastore/btree: clean up `FixedKVLeafNode::get_logical_child()`

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
15 months agodoc: reorder "releases" entries for reef to fix the diagram 56774/head
Ilya Dryomov [Tue, 9 Apr 2024 07:29:03 +0000 (09:29 +0200)]
doc: reorder "releases" entries for reef to fix the diagram

The Gantt diagram currently shows "reef (latest 18.2.0)" instead of
18.2.2.  This is because ReleasesGantt expects releases array to be
sorted in reverse order:

    for code_name, info in releases.items():
        last_release = info['releases'][0]
        first_release = info['releases'][-1]

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
15 months agorbd_mirror: rename method 56577/head
N Balachandran [Tue, 9 Apr 2024 02:26:47 +0000 (07:56 +0530)]
rbd_mirror: rename method

Rename on_stop_journal_replay to on_stop_replay as the
function doesn't do anything journal specific.

Signed-off-by: N Balachandran <nibalach@redhat.com>
15 months agoMerge pull request #56764 from ceph/wip-yuriw-archive-pacific-main
Josh Durgin [Mon, 8 Apr 2024 21:40:57 +0000 (14:40 -0700)]
Merge pull request #56764 from ceph/wip-yuriw-archive-pacific-main

doc: moved pacific release to Archived Releases

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Josh Durgin <jdurgin@ibm.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
15 months agoMerge pull request #56469 from asm0deuz/bz2270211_ganesha_nlm
Adam King [Mon, 8 Apr 2024 20:08:30 +0000 (16:08 -0400)]
Merge pull request #56469 from asm0deuz/bz2270211_ganesha_nlm

mgr/cephadm: Allows enabling NFS Ganesha NLM

Reviewed-by: Adam King <adking@redhat.com>
15 months agoMerge pull request #56637 from adk3798/node-proxy-service-expected-daemon-count
Adam King [Mon, 8 Apr 2024 19:59:11 +0000 (15:59 -0400)]
Merge pull request #56637 from adk3798/node-proxy-service-expected-daemon-count

mgr/cephadm: fix node-proxy service size

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>
15 months agoMerge pull request #56674 from adk3798/wrong-grafana-uid
Adam King [Mon, 8 Apr 2024 19:57:22 +0000 (15:57 -0400)]
Merge pull request #56674 from adk3798/wrong-grafana-uid

mgr/cephadm: pass daemon's current image when reconfiguring

Reviewed-by: Laura Flores <lflores@ibm.com>
15 months agomgr/dashboard: update NVMeoF gRPC 56641/head
Ernesto Puerta [Tue, 2 Apr 2024 17:36:21 +0000 (19:36 +0200)]
mgr/dashboard: update NVMeoF gRPC

To include latest changes to the listener add call.

Fixes: https://tracker.ceph.com/issues/65268
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
15 months agoMerge pull request #56705 from adk3798/no-osd-require-osd-release
Adam King [Mon, 8 Apr 2024 19:50:17 +0000 (15:50 -0400)]
Merge pull request #56705 from adk3798/no-osd-require-osd-release

mgr/cephadm: handle setting required osd release with no OSDs during upgrade

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>
15 months agoMerge pull request #56713 from adk3798/client-keyring-ceph-conf
Adam King [Mon, 8 Apr 2024 19:48:24 +0000 (15:48 -0400)]
Merge pull request #56713 from adk3798/client-keyring-ceph-conf

mgr/cephadm: make client-keyring deploying ceph.conf optional

Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agodoc: moved pacific release to Archived Releases 56764/head
Yuri Weinstein [Mon, 8 Apr 2024 15:41:12 +0000 (08:41 -0700)]
doc: moved pacific release to Archived Releases

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
15 months agotest/rgw/notifications: do not delay http responses to notifications
Yuval Lifshitz [Tue, 20 Feb 2024 10:12:26 +0000 (10:12 +0000)]
test/rgw/notifications: do not delay http responses to notifications

we also increase the wating time after rerunning the http server
to allow fo the persistent notifications retries to finish

Fixes: https://tracker.ceph.com/issues/63909
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
15 months agoMerge pull request #56760 from adk3798/cephadm-pin-pyfakefs-version
Adam King [Mon, 8 Apr 2024 18:24:08 +0000 (14:24 -0400)]
Merge pull request #56760 from adk3798/cephadm-pin-pyfakefs-version

cephadm: pin pyfakefs version for tox tests

Reviewed-by: Casey Bodley <cbodley@redhat.com>
15 months agoMerge pull request #56712 from kchheda3/wip-notif-reload-bkt
Casey Bodley [Mon, 8 Apr 2024 17:50:54 +0000 (18:50 +0100)]
Merge pull request #56712 from kchheda3/wip-notif-reload-bkt

rgw/notify: fix crashes in lc due to reload of bucket.

Reviewed-by: Casey Bodley <cbodley@redhat.com>
15 months agorgw/multisite: x-rgw-replicated-at uses dump_time_header() 56765/head
Casey Bodley [Mon, 8 Apr 2024 16:23:12 +0000 (12:23 -0400)]
rgw/multisite: x-rgw-replicated-at uses dump_time_header()

dump_time() encodes this timestamp as json/xml. use dump_time_header()
instead

Fixes: https://tracker.ceph.com/issues/65373
Signed-off-by: Casey Bodley <cbodley@redhat.com>
15 months agoMerge pull request #56619 from ljflores/wip-tracker-64864
Laura Flores [Mon, 8 Apr 2024 15:04:16 +0000 (10:04 -0500)]
Merge pull request #56619 from ljflores/wip-tracker-64864

qa/suites: add "mon down" log variations to ignorelist

15 months agocephadm: pin pyfakefs version for tox tests 56760/head
Adam King [Mon, 8 Apr 2024 14:48:18 +0000 (10:48 -0400)]
cephadm: pin pyfakefs version for tox tests

5.4.0 seems to have caused a number of permission issues
in the test. In order to unblock make check, let's pin it
to 5.3.5 for now.

Signed-off-by: Adam King <adking@redhat.com>
15 months agomgr/dashboard: fix snap schedule delete retention 56758/head
Ivo Almeida [Mon, 8 Apr 2024 13:39:49 +0000 (14:39 +0100)]
mgr/dashboard: fix snap schedule delete retention

Fixes: https://tracker.ceph.com/issues/65370
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
15 months agodoc/cephfs: refine client-auth (1 of 3) 56754/head
Zac Dover [Mon, 8 Apr 2024 12:07:38 +0000 (22:07 +1000)]
doc/cephfs: refine client-auth (1 of 3)

Refine the first third of doc/cephfs/client-auth.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
15 months agoMerge pull request #56530 from rhcs-dashboard/enable-grpc-copr
Ernesto Puerta [Mon, 8 Apr 2024 11:50:54 +0000 (13:50 +0200)]
Merge pull request #56530 from rhcs-dashboard/enable-grpc-copr

install-deps: enable copr ceph/grpc

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
15 months agorgw: ignore SIGXFSZ, which apparently can triggered by heavy ops-log traffic 55381/head
Matt Benjamin [Tue, 30 Jan 2024 20:35:07 +0000 (15:35 -0500)]
rgw: ignore SIGXFSZ, which apparently can triggered by heavy ops-log traffic

Fixes: https://tracker.ceph.com/issues/64244
That is, it causes radosgw to ignore SIGXFSZ, which in the apparent
reproducer should not cause radosgw to terminate.

Updated to call unregister_async_signal_handler (frees a structure).

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
15 months agoMerge pull request #54955 from leonid-s-usov/always_on_config
Ilya Dryomov [Mon, 8 Apr 2024 07:56:16 +0000 (09:56 +0200)]
Merge pull request #54955 from leonid-s-usov/always_on_config

MgrMonitor: consider the build config when defining the always-on modules

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
15 months agoMerge pull request #54335 from batrick/i63432
Venky Shankar [Mon, 8 Apr 2024 06:19:37 +0000 (11:49 +0530)]
Merge pull request #54335 from batrick/i63432

qa: test test_kill_mdstable for all mount types

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agocrimson/os/seastore/btree: clean up `FixedKVLeafNode::get_logical_child()` 56383/head
Xuehan Xu [Fri, 22 Mar 2024 07:22:46 +0000 (15:22 +0800)]
crimson/os/seastore/btree: clean up `FixedKVLeafNode::get_logical_child()`

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
15 months agoMerge pull request #56627 from zhscn/wip-rewrite-snap-refcount
Yingxin [Mon, 8 Apr 2024 01:15:38 +0000 (09:15 +0800)]
Merge pull request #56627 from zhscn/wip-rewrite-snap-refcount

crimson/os/seastore: alloc mapping with refcount when rewriting logical extents

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
15 months agoMerge pull request #56738 from zdover23/wip-doc-2024-04-05-dev-peering-concepts-4...
Anthony D'Atri [Sat, 6 Apr 2024 18:05:20 +0000 (14:05 -0400)]
Merge pull request #56738 from zdover23/wip-doc-2024-04-05-dev-peering-concepts-4-of-3

doc/dev: refine "Concepts" 4 of 3

15 months agoMerge pull request #56703 from tchaikov/rgw-test_posix_bucket_cache-fixture
Kefu Chai [Sat, 6 Apr 2024 07:56:05 +0000 (15:56 +0800)]
Merge pull request #56703 from tchaikov/rgw-test_posix_bucket_cache-fixture

test/rgw/test_posix_bucket_cache: structure tests with fixture

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
15 months agodoc/dev: refine "Concepts" 4 of 3 56738/head
Zac Dover [Sat, 6 Apr 2024 04:43:16 +0000 (14:43 +1000)]
doc/dev: refine "Concepts" 4 of 3

s/PG's PG logs/PG's logs/

re https://github.com/ceph/ceph/pull/56727#discussion_r1553541922

Signed-off-by: Zac Dover <zac.dover@proton.me>
15 months agoMerge pull request #55711 from rishabh-d-dave/fsshell-deprecation
Rishabh Dave [Fri, 5 Apr 2024 19:36:52 +0000 (01:06 +0530)]
Merge pull request #55711 from rishabh-d-dave/fsshell-deprecation

cephfs-shell: prints warning, hangs and aborts when launched

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
15 months agoMerge pull request #56535 from linuxbox2/wip-lc-65188
Casey Bodley [Fri, 5 Apr 2024 17:18:30 +0000 (18:18 +0100)]
Merge pull request #56535 from linuxbox2/wip-lc-65188

rgwlc: check for no-bucket at bucket_lc_process() preamble

Reviewed-by: Lei Zhang <1091517373@qq.com>
Reviewed-by: Jiffin Tony Thottan <jthottan@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
15 months agoMerge pull request #56657 from soumyakoduri/wip-skoduri-cloud-trans
Casey Bodley [Fri, 5 Apr 2024 16:39:14 +0000 (17:39 +0100)]
Merge pull request #56657 from soumyakoduri/wip-skoduri-cloud-trans

rgw/cloud: Handle RGWRESTStreamS3PutObj initialization failures

Reviewed-by: Casey Bodley <cbodley@redhat.com>
15 months agoMerge pull request #56727 from zdover23/wip-doc-2024-04-05-dev-peering-concepts-3...
Zac Dover [Fri, 5 Apr 2024 13:48:18 +0000 (23:48 +1000)]
Merge pull request #56727 from zdover23/wip-doc-2024-04-05-dev-peering-concepts-3-of-3

doc/dev: refine "Concepts" 3 of 3

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agotest/rgw/test_posix_bucket_cache: structure tests with fixture 56703/head
Kefu Chai [Thu, 4 Apr 2024 12:46:37 +0000 (20:46 +0800)]
test/rgw/test_posix_bucket_cache: structure tests with fixture

before this change, we use individual tests to setup/teardown
the fixtures. this renders it difficult to run a certain test.

in this change, we structure the tests with fixtures, so that
we can run any test without worrying the dependencies between
them.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
15 months agoinstall-deps: enable copr ceph/grpc 56530/head
Nizamudeen A [Wed, 27 Mar 2024 16:29:55 +0000 (21:59 +0530)]
install-deps: enable copr ceph/grpc

In dashboard, to generate nvmeof apis in el8 this is needed so that it
can download the python3-grpcio packages.
https://copr.fedorainfracloud.org/coprs/ceph/grpc/

Fixes: https://tracker.ceph.com/issues/65184
Signed-off-by: Nizamudeen A <nia@redhat.com>
16 months agorgw/d4n: fix compilation issue when WITH_RADOSGW_D4N=OFF. 56728/head
Pritha Srivastava [Fri, 5 Apr 2024 04:48:25 +0000 (10:18 +0530)]
rgw/d4n: fix compilation issue when WITH_RADOSGW_D4N=OFF.

Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
16 months agodoc/dev: refine "Concepts" 3 of 3 56727/head
Zac Dover [Fri, 5 Apr 2024 06:43:47 +0000 (16:43 +1000)]
doc/dev: refine "Concepts" 3 of 3

Refine the third third of the entries in the section "Concepts" in
doc/dev/peering.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
16 months agoMerge pull request #55725 from neesingh-rh/wip-63699
Venky Shankar [Fri, 5 Apr 2024 06:17:36 +0000 (11:47 +0530)]
Merge pull request #55725 from neesingh-rh/wip-63699

qa: fixing tests in test_cephfs_shell.TestShellOpts

Reviewed-by: Venky Shankar <vshankar@redhat.com>
16 months agoMerge pull request #56646 from zdover23/wip-doc-2024-04-02-dev-peering-concepts-2...
Zac Dover [Fri, 5 Apr 2024 03:49:24 +0000 (13:49 +1000)]
Merge pull request #56646 from zdover23/wip-doc-2024-04-02-dev-peering-concepts-2-of-3

doc/dev: refine "Concepts" 2 of 3

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
16 months agoMerge pull request #56645 from ivancich/wip-remove-example-ldap-domain
J. Eric Ivancich [Thu, 4 Apr 2024 23:32:00 +0000 (19:32 -0400)]
Merge pull request #56645 from ivancich/wip-remove-example-ldap-domain

rgw: udpate options yaml file so LDAP uri isn't an invalid example

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
16 months agoMerge pull request #55203 from jzhu116-bloomberg/wip-63995
J. Eric Ivancich [Thu, 4 Apr 2024 23:29:18 +0000 (19:29 -0400)]
Merge pull request #55203 from jzhu116-bloomberg/wip-63995

rgw/lc: delete expired delete-marker when processing Expiration lc action with Days specified

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>