]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Zac Dover [Sat, 13 Apr 2024 10:48:21 +0000 (20:48 +1000)]
doc/cephfs: disambiguate "Reporting Free Space"
Make a few sentences clearer in doc/cephfs/ceph-auth.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
788ccff18149b16cb01947c5bcf3bde380090df0 )
Anthony D'Atri [Fri, 12 Apr 2024 14:04:40 +0000 (10:04 -0400)]
Merge pull request #56852 from zdover23/wip-doc-2024-04-12-backport-56831-to-quincy
quincy: doc/cephfs: refine client-auth (3 of 3)
Rishabh Dave [Fri, 12 Apr 2024 09:09:55 +0000 (14:39 +0530)]
Merge pull request #54946 from rishabh-d-dave/wip-63407-quincy
quincy: MDSAuthCaps: print better error message for perm flag in MDS caps
Reviewed-by: Milind Changire <mchangir@redhat.com>
Zac Dover [Thu, 11 Apr 2024 11:18:53 +0000 (21:18 +1000)]
doc/cephfs: refine client-auth (3 of 3)
Refine the final third of doc/cephfs/client-auth.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
44d1eeed703e968b374ec4d12fff3a2466a4c276 )
Anthony D'Atri [Fri, 12 Apr 2024 03:11:37 +0000 (23:11 -0400)]
Merge pull request #56843 from zdover23/wip-doc-2024-04-12-backport-56784-to-quincy
quincy: doc/cephfs: refine client-auth (2 of 3)
Zac Dover [Tue, 9 Apr 2024 12:04:46 +0000 (22:04 +1000)]
doc/cephfs: refine client-auth (2 of 3)
Refine the second third of doc/cephfs/client-auth.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
083f56352b4fff662dff3c78b6a0c455605d02ff )
Rishabh Dave [Mon, 24 Jan 2022 18:46:32 +0000 (00:16 +0530)]
qa/vstart_runner: set LocalCephManager.cluster
Use LocalContext instance to set LocalCephManager.cluster.
Fixes: https://tracker.ceph.com/issues/53601
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit
d9fbf65f77ea69355a0f2aeeb8ee6e6d95a14a26 )
Rishabh Dave [Thu, 7 Mar 2024 12:49:21 +0000 (18:19 +0530)]
qa/cephfs: fix caps_helper.py
Replace calls to run_cluster_cmd() by calls to run_ceph_cmd().
Ideally, a backport should have fixed this issue but the method under
inspection here, "get_mon_cap_from_keyring()", has gone through lots of
changes, compared to the main branch, along with rest of caps_helper.py.
To avoid backporting large amount of QA changes, writing a specific fix
will be easier and faster.
This will also help with rest of Quincy backports since this patch
series/PR makes an important change to QA code.
Signed-off-by: Rishabh Dave <ridave@redhat.com>
Yuri Weinstein [Wed, 10 Apr 2024 14:40:11 +0000 (07:40 -0700)]
Merge pull request #56480 from batrick/wip-65154-quincy
quincy: pybind/mgr/devicehealth: skip legacy objects that cannot be loaded
Reviewed-by: Laura Flores <lflores@redhat.com>
Yuri Weinstein [Wed, 10 Apr 2024 14:32:22 +0000 (07:32 -0700)]
Merge pull request #56360 from Svelar/wip-65026-quincy
quincy: mgr/dashboard/frontend:Ceph dashboard supports multiple languages
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Yuri Weinstein [Wed, 10 Apr 2024 14:31:28 +0000 (07:31 -0700)]
Merge pull request #55779 from ifed01/wip-ifed-fix-63795-qui
quincy: test/store_test: fix deferred writing test cases
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Anthony D'Atri [Tue, 9 Apr 2024 21:27:26 +0000 (17:27 -0400)]
Merge pull request #56781 from zdover23/wip-doc-2024-04-09-backport-56754-to-quincy
quincy: doc/cephfs: refine client-auth (1 of 3)
Anthony D'Atri [Tue, 9 Apr 2024 20:58:50 +0000 (16:58 -0400)]
Merge pull request #56799 from zdover23/wip-doc-2024-04-10-backport-56796-to-quincy
quincy: doc/mgr: remove Zabbix 1 information
Zac Dover [Tue, 9 Apr 2024 20:04:28 +0000 (06:04 +1000)]
doc/mgr: remove Zabbix 1 information
Remove information about the installation of the Zabbix module and link
to a discussion of the reasoning behind Ceph's refusal to support
Zabbix.
John Jasen developed a procedure explaining how to install "Zabbix 2".
This commit removes outdated procedures and explains why those
procedures were removed. Immediately following this explanation, the
text includes an explanation of how to install "Zabbix 2".
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
29ac627956c5e5cdd4ed5f1316c20bc9e1fe0ff7 )
Adam King [Tue, 9 Apr 2024 15:30:29 +0000 (11:30 -0400)]
Merge pull request #56763 from adk3798/quincy-cephadm-pin-pyfakefs-version
quincy: cephadm: pin pyfakefs version for tox tests
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Zac Dover [Mon, 8 Apr 2024 12:07:38 +0000 (22:07 +1000)]
doc/cephfs: refine client-auth (1 of 3)
Refine the first third of doc/cephfs/client-auth.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
82c5bac5df553f1e13a2df3a107b2692efa6fc27 )
Adam King [Mon, 8 Apr 2024 14:48:18 +0000 (10:48 -0400)]
cephadm: pin pyfakefs version for tox tests
5.4.0 seems to have caused a number of permission issues
in the test. In order to unblock make check, let's pin it
to 5.3.5 for now.
Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit
ce71ce10b7551a649c9a64be992c0eddfa7e7243 )
Aashish Sharma [Mon, 8 Apr 2024 04:34:13 +0000 (10:04 +0530)]
Merge pull request #56737 from rhcs-dashboard/fix-65286-quincy
mgr/dashboard: add Table Schema to grafonnet
Reviewed-by: Nizamudeen A <nia@redhat.com>
Anthony D'Atri [Sun, 7 Apr 2024 12:28:49 +0000 (08:28 -0400)]
Merge pull request #56741 from zdover23/wip-doc-2024-05-07-backport-56738-to-quincy
quincy: doc/dev: refine "Concepts" 4 of 3
Zac Dover [Sat, 6 Apr 2024 04:43:16 +0000 (14:43 +1000)]
doc/dev: refine "Concepts" 4 of 3
s/PG's PG logs/PG's logs/
re https://github.com/ceph/ceph/pull/56727#discussion_r1553541922
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
221d734760b6f680e4d17cd2f0bfcd39f914c8d6 )
Zac Dover [Sat, 6 Apr 2024 04:39:49 +0000 (14:39 +1000)]
Merge pull request #56730 from zdover23/wip-doc-2024-04-05-backport-56727-to-quincy
quincy: doc/dev: refine "Concepts" 3 of 3
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Aashish Sharma [Sat, 6 Apr 2024 03:43:48 +0000 (09:13 +0530)]
mgr/dashboard: add Table Schema to grafonnet
Backport of #56509 in quincy didn't include the Table Schema in the utils.libsonnet because of which the json generation ias failing. This PR tends to add the Table Schema
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Zac Dover [Fri, 5 Apr 2024 06:43:47 +0000 (16:43 +1000)]
doc/dev: refine "Concepts" 3 of 3
Refine the third third of the entries in the section "Concepts" in
doc/dev/peering.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
512e2dc9d52fdd14dfdd87ccd141e535d3098fb7 )
Anthony D'Atri [Fri, 5 Apr 2024 12:34:40 +0000 (08:34 -0400)]
Merge pull request #56726 from zdover23/wip-doc-2024-04-05-backport-56646-to-quincy
quincy: doc/dev: refine "Concepts" 2 of 3
Aashish Sharma [Fri, 5 Apr 2024 04:51:43 +0000 (10:21 +0530)]
Merge pull request #56680 from aaSharma14/wip-65286-quincy
quincy: mgr/dashboard: replace deprecated table panel in grafana with a newer table panel
Reviewed-by: Nizamudeen A <nia@redhat.com>
Zac Dover [Wed, 3 Apr 2024 05:02:29 +0000 (15:02 +1000)]
doc/dev: refine "Concepts" 2 of 3
Refine the second third of the entries in the section "Concepts" in
doc/dev/peering.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
7bb35282da27f0c18ffbe36f2c0852a827c5bc2f )
Zac Dover [Thu, 4 Apr 2024 11:39:14 +0000 (21:39 +1000)]
Merge pull request #56685 from zdover23/wip-doc-2024-04-04-backport-56662-to-quincy
quincy: doc/mgr: credit John Jasen for Zabbix 2
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Nizamudeen A [Thu, 4 Apr 2024 05:49:13 +0000 (11:19 +0530)]
Merge pull request #56558 from afreen23/wip-65206-quincy
quincy: mgr/dashboard: make ceph logo redirect to dashboard
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Zac Dover [Wed, 3 Apr 2024 12:21:04 +0000 (22:21 +1000)]
doc/mgr: credit John Jasen for Zabbix 2
Credit John Jasen for the development of the procedures describing the
installation of Zabbix 2.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
28aa556448cf02dc943653e76a7ef89e10ae93e9 )
Aashish Sharma [Wed, 27 Mar 2024 08:16:24 +0000 (13:46 +0530)]
mgr/dashboard: replace deprecated table panel in grafana with a newer
table panel
Fixes: https://tracker.ceph.com/issues/65174
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit
c2f4aa7887d8322bc58cd1cb322746246ccebe32 )
Aashish Sharma [Thu, 4 Apr 2024 02:18:49 +0000 (07:48 +0530)]
Merge pull request #56655 from aaSharma14/wip-65287-quincy
quincy: mgr/dashboard: replace piechart plugin charts with native pie chart panel
Reviewed-by: Nizamudeen A <nia@redhat.com>
Anthony D'Atri [Wed, 3 Apr 2024 16:08:02 +0000 (12:08 -0400)]
Merge pull request #56661 from zdover23/wip-doc-2024-04-03-backport-56635-to-quincy
quincy: doc/dev: refine "Concepts"
Aashish Sharma [Wed, 3 Apr 2024 14:54:47 +0000 (20:24 +0530)]
Merge pull request #56653 from aaSharma14/wip-65282-quincy
quincy: mgr/dashboard: upgrade from old 'graph' type panels to the new 'timeseries' panel
Reviewed-by: Nizamudeen A <nia@redhat.com>
Zac Dover [Tue, 2 Apr 2024 12:23:13 +0000 (22:23 +1000)]
doc/dev: refine "Concepts"
Refine the text in the first third of the entries in the section
"Concepts" in doc/dev/peering.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
530b11be24c6e702d4d9b9227649db8ca34591e4 )
Aashish Sharma [Mon, 26 Feb 2024 09:32:19 +0000 (15:02 +0530)]
mgr/dashboard: replace piechart plugin charts with native pie chart
panel
Fixes: https://tracker.ceph.com/issues/64579
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit
6e5efb626f4b3503a12371a8f609fdb5175a3ebe )
Aashish Sharma [Wed, 4 Oct 2023 09:07:42 +0000 (14:37 +0530)]
mgr/dashboard: upgrade from old 'graph' type panels to the new
'timeseries' panel
The graph panel type is deprecated, and disappears after Grafana v9.1 (current version is 10.0) to prevent more old type panels being created. These should be migrated to the timeseries panel type, to avoid potential problems with future Grafana versions.
Fixes: https://tracker.ceph.com/issues/61720
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit
2573426f54aab237ed855a4e88d5b89ddbd76acd )
Anthony D'Atri [Tue, 2 Apr 2024 15:07:33 +0000 (11:07 -0400)]
Merge pull request #56632 from zdover23/wip-doc-2024-04-02-backport-56614-to-quincy
quincy: doc/mgr: update zabbix information
Zac Dover [Fri, 29 Mar 2024 11:06:28 +0000 (21:06 +1000)]
doc/mgr: update zabbix information
Include information from John Jasen about how to install Zabbix.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
ebe7651dd85ae1f1570d8c34479b9bdd1249d83c )
Anthony D'Atri [Mon, 1 Apr 2024 01:55:30 +0000 (21:55 -0400)]
Merge pull request #56604 from zdover23/wip-doc-2024-04-01-backport-56600-to-quincy
quincy: doc/dev: update leads list
Zac Dover [Mon, 1 Apr 2024 01:17:39 +0000 (11:17 +1000)]
doc/dev: update leads list
Remove Joao Luis from the list of component leads.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
158b0403bd66cdf6c4b456146705f42d69f56730 )
Anthony D'Atri [Sun, 31 Mar 2024 02:53:51 +0000 (22:53 -0400)]
Merge pull request #56595 from zdover23/wip-doc-2024-03-31-backport-56592-to-quincy
quincy: doc/rados/operations: Improve crush_location docs
Niklas Hambüchen [Sat, 30 Mar 2024 16:42:48 +0000 (17:42 +0100)]
doc/rados/operations: Improve crush_location docs
* Fix incorrect syntax
* Use underscores for config options, like other ceph docs did
* Fix incorrect statement that crush_location_hook adds fiels; it replaces
* Explain `root=default host=HOSTNAME` is not set if `crush_location` is given
* Remove duplication across sections
* Point out that `root=default` is important
Signed-off-by: Niklas Hambüchen <mail@nh2.me>
(cherry picked from commit
d91e75e1e92b73bf967740575b3c27a86ef844d5 )
Anthony D'Atri [Sat, 30 Mar 2024 13:34:03 +0000 (09:34 -0400)]
Merge pull request #56590 from zdover23/wip-doc-2024-03-30-backport-56581-to-quincy
quincy: doc/dev: update leads list
Zac Dover [Fri, 29 Mar 2024 11:14:21 +0000 (21:14 +1000)]
doc/dev: update leads list
Update the list of component leads in
doc/dev/developer_guide/essentials.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
57e9427eac08b4057999f5afc44cf0fc77a3068f )
Venky Shankar [Fri, 29 Mar 2024 08:17:57 +0000 (13:47 +0530)]
Merge pull request #55944 from vshankar/wip-64704-quincy
quincy: qa: remove error string checks and check w/ return value
Reviewed-by: Milind Changire <mchangir@redhat.com>
Zac Dover [Fri, 29 Mar 2024 07:36:18 +0000 (17:36 +1000)]
Merge pull request #56467 from zdover23/wip-doc-2024-03-26-backport-56436-to-quincy
quincy: doc/start: improve MDS explanation
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 29 Mar 2024 07:35:55 +0000 (17:35 +1000)]
Merge pull request #56524 from zdover23/wip-doc-2024-03-27-backport-56173-to-quincy
quincy: doc/dev: osd_internals/snaps.rst: add clone_overlap doc
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Nizamudeen A [Fri, 29 Mar 2024 06:44:33 +0000 (12:14 +0530)]
Merge pull request #56551 from rhcs-dashboard/wip-65197-quincy
quincy: mgr/dashboard: sanitize dashboard user creation
Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
Afreen [Wed, 27 Mar 2024 10:01:12 +0000 (15:31 +0530)]
mgr/dashboard: make ceph logo redirect to dashboard
Fixes https://tracker.ceph.com/issues/64734
Clicking on ceph logo in navigation takes back to overview dashboard.
Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit
44e7bb336c26da77f49fb027578509975b5b2633 )
Venky Shankar [Thu, 28 Mar 2024 11:21:05 +0000 (16:51 +0530)]
Merge pull request #56050 from lxbsz/wip-64586
quincy: mds: allow lock state to be LOCK_MIX_SYNC in replica for filelock
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 28 Mar 2024 11:20:17 +0000 (16:50 +0530)]
Merge pull request #55828 from kotreshhr/wip-64581-quincy
quincy: qa: Fix fs/full suite
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 28 Mar 2024 11:19:56 +0000 (16:49 +0530)]
Merge pull request #54187 from rishabh-d-dave/wip-57929-quincy
quincy: qa/cephfs: handle non-numeric values for json.loads()
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 28 Mar 2024 11:19:37 +0000 (16:49 +0530)]
Merge pull request #54186 from rishabh-d-dave/wip-62878-quincy
quincy: cephfs: upgrade cephfs-shell's path wherever necessary
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Thu, 28 Mar 2024 11:18:34 +0000 (16:48 +0530)]
Merge pull request #50730 from vshankar/tr-59041
quincy: client, mds: update mtime and change attr for snapdir when snaps are created, deleted and renamed
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Guillaume Abrioux [Thu, 28 Mar 2024 09:45:59 +0000 (10:45 +0100)]
Merge pull request #56260 from guits/wip-64944-quincy
quincy: ceph-volume: add missing import
Guillaume Abrioux [Thu, 28 Mar 2024 09:44:04 +0000 (10:44 +0100)]
Merge pull request #55480 from guits/wip-64336-quincy
quincy: ceph-volume: fix zap_partitions() in devices.lvm.zap
Pedro Gonzalez Gomez [Thu, 21 Mar 2024 07:56:58 +0000 (08:56 +0100)]
mgr/dashboard: sanitize dashboard user creation
Fixes: https://tracker.ceph.com/issues/65030
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit
9951a3a7f314c7cd1eb147fb1b398ac6c5212806 )
Guillaume Abrioux [Tue, 30 Jan 2024 14:17:35 +0000 (14:17 +0000)]
ceph-volume: fix zap_partitions() in devices.lvm.zap
The current logic is unable to find the holders for the
partition being zapped.
This commit fixes this issue.
Fixes: https://tracker.ceph.com/issues/64248
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit
36c83bf5424308214228b1c86d8e1d215b8519c5 )
Guillaume Abrioux [Fri, 26 Jan 2024 20:35:18 +0000 (21:35 +0100)]
ceph-volume: fix partitions support in disk.get_devices()
The following:
```
is_part = get_file_contents(os.path.join(_sys_dev_block_path, item, 'partition')) == "1"
```
assumes any `/sys/dev/block/x:y/partition` contains '1' which is wrong.
This file actually contains the corresponding partition number.
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit
f72100bbd17539d9774ae72215afefee16f20775 )
Guillaume Abrioux [Tue, 3 Oct 2023 23:11:32 +0000 (01:11 +0200)]
ceph-volume: fix util.get_partitions
The current logic makes it report only the first
partitions of devices.
Fixes: https://tracker.ceph.com/issues/63086
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit
b14ff07e6344d9f097259265d468f6300818b053 )
Matan Breizman [Wed, 13 Mar 2024 14:19:59 +0000 (14:19 +0000)]
doc/dev: osd_internals/snaps.rst: add clone_overlap doc
snapdir concept was removed in: https://github.com/ceph/ceph/pull/17579
Co-authored-by: Zac Dover <zac.dover@proton.me>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit
6a7f2b0fda74aedb213067abe5c0a64b68fbbdc7 )
Zac Dover [Wed, 27 Mar 2024 13:33:20 +0000 (23:33 +1000)]
Merge pull request #56496 from zdover23/wip-doc-2024-03-27-backport-56450-to-quincy
quincy: docs/rados: remove incorrect ceph command
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Nizamudeen A [Wed, 27 Mar 2024 05:20:20 +0000 (10:50 +0530)]
Merge pull request #55543 from rhcs-dashboard/wip-61715-quincy
quincy: mgr/dashboard: fix the jsonschema issue in install-deps
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
Nizamudeen A [Wed, 27 Mar 2024 05:19:48 +0000 (10:49 +0530)]
Merge pull request #55545 from rhcs-dashboard/wip-61659-quincy
quincy: mgr/dashboard: change deprecated grafana URL in daemon logs
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
Taha Jahangir [Mon, 25 Mar 2024 10:02:12 +0000 (13:32 +0330)]
docs/rados: remove incorrect ceph command
The removed line was (incorrectly changed) output of the previous command.
Signed-off-by: Taha Jahangir <mtjahangir@gmail.com>
(cherry picked from commit
3cd39e3582ed830f86c55d2203ece72fa0f9426b )
Yuri Weinstein [Tue, 26 Mar 2024 16:07:14 +0000 (09:07 -0700)]
Merge pull request #56212 from idryomov/wip-63770-quincy
quincy: librbd: account for discards that truncate in ObjectListSnapsRequest
Reviewed-by: Ramana Raja <rraja@redhat.com>
Yuri Weinstein [Tue, 26 Mar 2024 16:06:36 +0000 (09:06 -0700)]
Merge pull request #55501 from cbodley/wip-64363-quincy
quincy: cmake/modules/BuildRocksDB.cmake: inherit parent's CMAKE_CXX_FLAGS
Reviewed-by: Mark Nelson <mnelson@redhat.com>
Yuri Weinstein [Tue, 26 Mar 2024 16:05:56 +0000 (09:05 -0700)]
Merge pull request #55154 from rzarzynski/wip-64007-quincy
quincy: common/weighted_shuffle: don't feed std::discrete_distribution with all-zero weights
Reviewed-by: Prashant D <pdhange@redhat.com>
Yuri Weinstein [Tue, 26 Mar 2024 16:04:30 +0000 (09:04 -0700)]
Merge pull request #54904 from kamoltat/wip-ksirivad-backport-quincy-52633
quincy: pybind/mgr/pg_autoscaler: Cut back osdmap.get_pools calls
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Patrick Donnelly [Thu, 21 Dec 2023 13:48:33 +0000 (08:48 -0500)]
pybind/mgr/devicehealth: skip legacy objects that cannot be loaded
Log looks like after test:
2023-12-21T16:09:28.804+0000
7fbe7fd86700 0 [devicehealth DEBUG root] loading object ABC_DEADB33F_FA
2023-12-21T16:09:28.805+0000
7fbe7fd86700 0 [devicehealth DEBUG root] object rados.Object(ioctx=<rados.Ioctx object at 0x7fbeee0c4668>,key=ABC_DEADB33F_FA,nspace=--default--,locator=None) does not exist because it is deleted in HEAD
2023-12-21T16:09:28.805+0000
7fbe7fd86700 0 [devicehealth DEBUG root] finished reading legacy pool, complete = True
Credit to Greg Farnum for postulating the cause.
Fixes: https://tracker.ceph.com/issues/63882
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit
5e6fc0bf5f52732966d5cf2987e679abee8a384d )
Patrick Donnelly [Thu, 21 Dec 2023 15:39:03 +0000 (10:39 -0500)]
qa: test devicehealth legacy load of deleted snap obj
Failure without fix looks like:
2023-12-21T16:05:55.737+0000
7fbe585b0700 0 [devicehealth DEBUG root] loading object ABC_DEADB33F_FA
2023-12-21T16:05:55.737+0000
7fbe585b0700 -1 log_channel(cluster) log [ERR] : Unhandled exception from module 'devicehealth' while running on mgr.x: [errno 2] RADOS object not found (Failed to operate read op for oid ABC_DEADB33F_FA)
2023-12-21T16:05:55.737+0000
7fbe585b0700 -1 devicehealth.serve:
2023-12-21T16:05:55.737+0000
7fbe585b0700 -1 Traceback (most recent call last):
File "/home/pdonnell/ceph/src/pybind/mgr/devicehealth/module.py", line 394, in serve
self._do_serve()
File "/home/pdonnell/ceph/src/pybind/mgr/mgr_module.py", line 524, in check
return func(self, *args, **kwargs)
File "/home/pdonnell/ceph/src/pybind/mgr/devicehealth/module.py", line 354, in _do_serve
finished_loading_legacy = self.check_legacy_pool()
File "/home/pdonnell/ceph/src/pybind/mgr/devicehealth/module.py", line 326, in check_legacy_pool
if self._load_legacy_object(ioctx, obj.key):
File "/home/pdonnell/ceph/src/pybind/mgr/devicehealth/module.py", line 300, in _load_legacy_object
ioctx.operate_read_op(op, oid)
File "rados.pyx", line 3723, in rados.Ioctx.operate_read_op
rados.ObjectNotFound: [errno 2] RADOS object not found (Failed to operate read op for oid ABC_DEADB33F_FA)
Credit to Greg Farnum for postulating the cause.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit
aa30adbaa7616c8e24b3ccaad9dbcda7c0c663fc )
Patrick Donnelly [Thu, 21 Dec 2023 16:11:03 +0000 (11:11 -0500)]
qa: allow failing whatever the active mgr is
Vanilla `mgr fail` will just fail the active.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit
a066467c9dc6f34a58e4085d05238a5db3f45cba )
Patrick Donnelly [Wed, 10 Jan 2024 17:52:04 +0000 (12:52 -0500)]
qa: add unit tests for MgrMap down flag
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit
9ebcbdbed0fbaf37d60fbd8db321742ee5721d8c )
Patrick Donnelly [Wed, 10 Jan 2024 17:50:51 +0000 (12:50 -0500)]
mon/MgrMonitor: add "down" setting to simplify testing
This flag prevents promotion of a standby manager to the active. It also drops
the current active.
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit
2e2a3f15cdd9125029fca78b834b8b5bb53edbb1 )
Igor Fedotov [Tue, 26 Mar 2024 11:28:59 +0000 (14:28 +0300)]
Merge pull request #54785 from ifed01/wip-ifed-better-osd-robust-qui
quincy: osd: improve OSD robustness.
Reviewed-by: Pere Diaz Bou <pere-altea@hotmail.com>
Venky Shankar [Tue, 26 Mar 2024 10:46:36 +0000 (16:16 +0530)]
Merge pull request #56121 from xhernandez/wip-64736-quincy
quincy: client: fix leak of file handles
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Tue, 26 Mar 2024 10:46:16 +0000 (16:16 +0530)]
Merge pull request #56061 from mchangir/wip-64810-quincy
quincy: mds: add debug logs during setxattr ceph.dir.subvolume
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Tue, 26 Mar 2024 10:46:06 +0000 (16:16 +0530)]
Merge pull request #55986 from joscollin/wip-64742-quincy
quincy: mds: add a command to dump directory information
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Tue, 26 Mar 2024 10:45:26 +0000 (16:15 +0530)]
Merge pull request #55299 from neesingh-rh/wip-64097-quincy
quincy: src/mount: kernel mount command returning misleading error message
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Venky Shankar [Tue, 26 Mar 2024 10:45:00 +0000 (16:15 +0530)]
Merge pull request #54465 from lxbsz/wip-63274
quincy: client: queue a delay cap flushing if there are ditry caps/snapcaps
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Nizamudeen A [Tue, 26 Mar 2024 09:28:04 +0000 (14:58 +0530)]
Merge pull request #56441 from rhcs-dashboard/wip-65101-quincy
quincy: mgr/dashboard: rm warning/error threshold for cpu usage
Reviewed-by: afreen23 <NOT@FOUND>
Zac Dover [Sun, 24 Mar 2024 21:19:24 +0000 (07:19 +1000)]
doc/start: improve MDS explanation
Improve the explanation of MDS as requested by Anthony D'Atri here:
https://github.com/ceph/ceph/pull/56367#discussion_r1536667249
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
e7eff3cf8738ddd378c2fd70075ac61dbac3cf55 )
Nizamudeen A [Tue, 19 Mar 2024 14:57:13 +0000 (20:27 +0530)]
mgr/dashboard: rm warning/error threshold for cpu usage
for multi-core cpu's the value can be more than 100% so it doesn't make
sense to show warning/error when the usage is at or more than 100%.
hence removing it
Fixes: https://tracker.ceph.com/issues/58838
Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit
131a70754a6bfbbb2d1481ba74436953c6ecc226 )
Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/shared/components/usage-bar/usage-bar.component.html
- some changes are not in quincy for the threasholds. so adapting it
Anthony D'Atri [Sun, 24 Mar 2024 13:27:49 +0000 (09:27 -0400)]
Merge pull request #56427 from zdover23/wip-doc-2024-08-24-backport-56367-to-quincy
quincy: doc/start: improve MDS explanation
Zac Dover [Sun, 24 Mar 2024 07:32:25 +0000 (17:32 +1000)]
Merge pull request #56411 from zdover23/wip-doc-2024-03-23-backport-56377-to-quincy
quincy: doc/start: link to mon map command
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 21 Mar 2024 12:48:10 +0000 (22:48 +1000)]
doc/start: improve MDS explanation
Remove a prolix "on behalf of" and streamline some sentences explaining
the benefits of MDS.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
2da1812a1de7e32395cb95c2e0ebeea689c1b810 )
Zac Dover [Thu, 21 Mar 2024 22:12:16 +0000 (08:12 +1000)]
doc/start: link to mon map command
Link to the "ceph mon stat" command when "Intro to Ceph" document first
mentions Monitor Maps.
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit
5d300db825316db25706111bbe577d41d41ab4b3 )
Igor Fedotov [Thu, 9 Mar 2023 18:03:12 +0000 (21:03 +0300)]
osd: read osd superblock from both disk and omap and choose the best
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
(cherry picked from commit
e7c08ec996105e453549b8622c9f24eb702bf6e8 )
Igor Fedotov [Thu, 29 Sep 2022 11:52:45 +0000 (14:52 +0300)]
osd: improve OSD robustness.
Achieved by
1. osd superblock data is replicated in onode's OMAP - hence one can
recover from that after onode's content is corrupted.
2. pg_num_history object gets full overwrite which eliminatess the need to
merge with previous data (and hence reading corrupted data wouldn't
kill OSD).
Signed-off-by: Igor Fedotov <ifedotov@croit.io>
(cherry picked from commit
2e9c723b3eddd71b8226be790cc71f5c065e819d )
TomNewChao [Fri, 26 Jan 2024 03:49:05 +0000 (11:49 +0800)]
fix review about mgr/dashboard/frontend:Ceph dashboard supports multiple languages
1.Set the default value of DASHBOARD_FRONTEND_LANGS to 'ALL'.
2.Fix bug about receive the `"ALL"` or `'ALL'`from process.env.DASHBOARD_FRONTEND_LANGS that is not equal 'ALL' in cd.js.
3.When we use the make-dist script to build the front-end UI to release the ceph, we should add DASHBOARD_FRONTEND_LANGS="ALL" to support multiple languages.
Signed-off-by: TomNewChao <chaotomzhu@gmail.com>
(cherry picked from commit
913b52d6eefc1c1c763c03f2e6e54cceae5601ff )
TomNewChao [Tue, 25 Jul 2023 07:08:44 +0000 (15:08 +0800)]
Ceph dashboard supports multiple languages
mgr/dashboard/frontend:Ceph dashboard supports multiple languages
Signed-off-by: TomNewChao <chaotomzhu@gmail.com>
(cherry picked from commit
1a2744282c46ca113f5f9f168d1f4d66c734e64d )
Zac Dover [Thu, 21 Mar 2024 02:04:01 +0000 (12:04 +1000)]
Merge pull request #56341 from zdover23/wip-doc-2024-03-20-backport-56333-to-quincy
quincy: doc/cephfs: fix architecture link to correct relative path
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Thu, 21 Mar 2024 02:03:06 +0000 (12:03 +1000)]
Merge pull request #56269 from zdover23/wip-doc-2024-08-19-backport-56240-to-quincy
quincy: doc/rados: update common.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Yuri Weinstein [Wed, 20 Mar 2024 23:20:14 +0000 (16:20 -0700)]
Merge pull request #55014 from Matan-B/wip-63879-quincy
quincy: tools/ceph_objectstore_tool: Support get/set/superblock
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
molpako [Wed, 20 Mar 2024 09:43:42 +0000 (18:43 +0900)]
doc/cephfs: fix architecture link to correct relative path
Signed-off-by: molpako <35787116+molpako@users.noreply.github.com>
(cherry picked from commit
ceeb1ca4b38dc307e493b04a59d5d07fed23971f )
Xavi Hernandez [Fri, 16 Feb 2024 18:14:07 +0000 (19:14 +0100)]
client: fix leak of file handles
Based on posix specification, the fd passed to fdopendir() will be
closed by closedir(). However CephFS client wasn't doing that. If the
user opened a directory using ceph_openat(), for example, and then
passed the returned fd to ceph_fdopendir(), the created Fh associated
with the new open was never destroyed.
This patch records the fd used in ceph_fdopendir() so that it can be
closed when ceph_closedir() is called.
Fixes: https://tracker.ceph.com/issues/64479
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
(cherry picked from commit
fe5c13d2e207473d48aa818484584d67dc3d23b5 )
Venky Shankar [Wed, 20 Mar 2024 05:04:57 +0000 (10:34 +0530)]
Merge pull request #56195 from vshankar/wip-64925-quincy
quincy: mds: disable `defer_client_eviction_on_laggy_osds' by default
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Yuri Weinstein [Tue, 19 Mar 2024 14:47:01 +0000 (07:47 -0700)]
Merge pull request #55549 from k0ste/wip-64396-quincy
quincy: mon: fix health store size growing infinitely
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
Yuri Weinstein [Tue, 19 Mar 2024 14:45:37 +0000 (07:45 -0700)]
Merge pull request #55698 from pdvian/wip-63843-quincy
quincy: osd: Report health error if OSD public address is not within subnet
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Ilya Dryomov [Tue, 19 Mar 2024 14:40:10 +0000 (15:40 +0100)]
Merge pull request #55929 from ajarr/wip-64667-quincy
quincy: qa: add diff-continuous and compare-mirror-image tests to rbd and krbd suites respectively
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>