]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
14 months agodoc/cephadm: remove downgrade reference from upgrade docs 57086/head
Adam King [Tue, 23 Apr 2024 16:04:39 +0000 (12:04 -0400)]
doc/cephadm: remove downgrade reference from upgrade docs

This has been in here for years, but cephadm will block
attempted upgrades to lower versions and we generally
don't want people to think this is supported or safe.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 787130175d3d40d3671be88a81c4b8843655b01e)

14 months agoMerge pull request #57073 from zdover23/wip-doc-2024-04-24-backport-57051-to-reef
Anthony D'Atri [Wed, 24 Apr 2024 13:19:40 +0000 (09:19 -0400)]
Merge pull request #57073 from zdover23/wip-doc-2024-04-24-backport-57051-to-reef

reef: doc/rados: remove dual-stack docs

14 months agodoc/rados: remove dual-stack docs 57073/head
Zac Dover [Tue, 23 Apr 2024 06:37:27 +0000 (16:37 +1000)]
doc/rados: remove dual-stack docs

Remove references to dual-stack mode in
doc/rados/configuration/network-config-ref.rst and
doc/rados/configuration/msgr2.rst. This feature seems to have been
planned but never to have been completely implemented.

See the tracker issue listed below for an email exchange detailing the
confusion caused by the presence in the documentation of this
now-removed information.

Fixes: https://tracker.ceph.com/issues/65631
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit c65d2056c27d75f91af44e004d8defe7ffbf5fc8)

14 months agoMerge pull request #56541 from cybozu/wip-65172-reef
Yuri Weinstein [Tue, 23 Apr 2024 18:13:03 +0000 (11:13 -0700)]
Merge pull request #56541 from cybozu/wip-65172-reef

reef: debian: add ceph-exporter package

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
14 months agoMerge pull request #54662 from k0ste/wip-63638-reef
Yuri Weinstein [Tue, 23 Apr 2024 18:12:06 +0000 (11:12 -0700)]
Merge pull request #54662 from k0ste/wip-63638-reef

reef: debian: add missing bcrypt to ceph-mgr .requires to fix resulting package dependencies

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
14 months agoMerge pull request #57048 from zdover23/wip-doc-2024-04-23-backport-57032-to-reef
Anthony D'Atri [Tue, 23 Apr 2024 14:03:07 +0000 (10:03 -0400)]
Merge pull request #57048 from zdover23/wip-doc-2024-04-23-backport-57032-to-reef

reef: doc/rados: fix outdated value for ms_bind_port_max

14 months agodoc/rados: fix outdated value for ms_bind_port_max 57048/head
Pierre Riteau [Mon, 22 Apr 2024 09:28:53 +0000 (11:28 +0200)]
doc/rados: fix outdated value for ms_bind_port_max

The highest port number used by OSD or MDS daemons was increased from
7300 to 7568 in [1] but the documentation still refers to 7300 in
multiple locations.

[1] https://github.com/ceph/ceph/pull/42210

Fixes: https://tracker.ceph.com/issues/65609
Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
(cherry picked from commit 23d2740241af2118652fef6e7d6a286f338a18f2)

14 months agoMerge pull request #57040 from zdover23/wip-doc-2024-04-23-backport-57022-to-reef
Anthony D'Atri [Mon, 22 Apr 2024 20:38:41 +0000 (16:38 -0400)]
Merge pull request #57040 from zdover23/wip-doc-2024-04-23-backport-57022-to-reef

reef: doc/rados: remove redundant pg repair commands

14 months agodoc/rados: remove redundant pg repair commands 57040/head
Zac Dover [Mon, 22 Apr 2024 06:59:15 +0000 (16:59 +1000)]
doc/rados: remove redundant pg repair commands

Incorporate the material in /doc/rados/operations/pg-repair into
/doc/rados/troubleshooting/troubleshooting-pg. Remove
/doc/rados/operations/pg-repair from the documentation. Redirect all
links to the old location to the new location.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 3c2e8d35a9ab3f78619bfbe32b2017cd47ffb3ff)

14 months agoMerge pull request #57024 from zdover23/wip-doc-2024-04-22-backport-56962-to-reef
Anthony D'Atri [Mon, 22 Apr 2024 14:20:13 +0000 (10:20 -0400)]
Merge pull request #57024 from zdover23/wip-doc-2024-04-22-backport-56962-to-reef

reef: doc/radosgw: use 'confval' directive for reshard config options

14 months agoMerge pull request #57027 from zdover23/wip-doc-2024-04-22-backport-57016-to-reef
Anthony D'Atri [Mon, 22 Apr 2024 14:19:28 +0000 (10:19 -0400)]
Merge pull request #57027 from zdover23/wip-doc-2024-04-22-backport-57016-to-reef

reef: doc/rados: add bucket rename command

14 months agodoc/rados: add bucket rename command 57027/head
Zac Dover [Sun, 21 Apr 2024 12:46:18 +0000 (22:46 +1000)]
doc/rados: add bucket rename command

Add "ceph osd crush rename bucket" command. This commit is made in
response to a request from Michele Giacomoli.

Fixes: https://tracker.ceph.com/issues/65599
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 1030b572fa1680792b4c5843a6cf517bd31511ae)

14 months agodoc/radosgw: use 'confval' directive for reshard config options 57024/head
Casey Bodley [Wed, 17 Apr 2024 17:17:40 +0000 (13:17 -0400)]
doc/radosgw: use 'confval' directive for reshard config options

this will render the config options with their descriptions/defaults
taken directly from common/options/rgw.yaml.in

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 50ebbc538c02352950d9c04e8b41b2d88701c552)

14 months agoMerge pull request #57018 from zdover23/wip-doc-2024-04-21-backport-56904-to-reef
Anthony D'Atri [Sun, 21 Apr 2024 14:56:43 +0000 (10:56 -0400)]
Merge pull request #57018 from zdover23/wip-doc-2024-04-21-backport-56904-to-reef

reef: doc/security: update CVE list

14 months agodoc/security: update CVE list 57018/head
Zac Dover [Mon, 15 Apr 2024 15:41:51 +0000 (01:41 +1000)]
doc/security: update CVE list

Update the list of CVEs in doc/security/cves.rst.

Co-authored-by: Ilya Dryomov <idryomov@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 8381259a46fbd04218946b67e73e140cb054e3d8)

15 months agoMerge pull request #57008 from zdover23/wip-doc-2024-04-20-backport-56996-to-reef
Anthony D'Atri [Fri, 19 Apr 2024 23:27:17 +0000 (19:27 -0400)]
Merge pull request #57008 from zdover23/wip-doc-2024-04-20-backport-56996-to-reef

reef: doc/dev: repair broken image

15 months agodoc/dev: repair broken image 57008/head
Zac Dover [Fri, 19 Apr 2024 03:22:33 +0000 (13:22 +1000)]
doc/dev: repair broken image

Replace the ".. graphviz" directive with an ".. image" directive that
correctly displays an image where previously an unusably zoomed-in image
appeared.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 5ff768dc73adf9c8794bf01c74f765a7eab13765)

15 months agoMerge pull request #56968 from zdover23/wip-doc-2024-04-18-backport-56879-to-reef
Anthony D'Atri [Wed, 17 Apr 2024 20:58:20 +0000 (16:58 -0400)]
Merge pull request #56968 from zdover23/wip-doc-2024-04-18-backport-56879-to-reef

reef: doc/cephfs: improve ceph-fuse command

15 months agodoc/cephfs: improve ceph-fuse command 56968/head
Zac Dover [Mon, 15 Apr 2024 07:43:23 +0000 (17:43 +1000)]
doc/cephfs: improve ceph-fuse command

Instruct readers to use "mkdir /mnt/cephfs1" to create a mountpoint
before using "ceph-fuse" to mount a filesystem, if "/mnt/cephfs1"
doesn't already exist. cf.
https://github.com/ceph/ceph/pull/56831#discussion_r1561102227

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit bdfee45d3a8267db97fc697c369a3c8a945ae993)

15 months agoMerge pull request #56921 from afreen23/wip-65504-reef
Ivo Almeida [Wed, 17 Apr 2024 09:52:04 +0000 (10:52 +0100)]
Merge pull request #56921 from afreen23/wip-65504-reef

reef: mgr/dashboard: Move features to advanced section and expand by default rbd config section

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
15 months agoMerge pull request #56552 from aruniiird/release-reef-add-rbd-mirror-mon-alerts
Juan Miguel Olmo [Wed, 17 Apr 2024 08:13:48 +0000 (10:13 +0200)]
Merge pull request #56552 from aruniiird/release-reef-add-rbd-mirror-mon-alerts

add RBD Mirror monitoring alerts

15 months agoMerge pull request #56917 from rhcs-dashboard/wip-65500-reef
Ivo Almeida [Tue, 16 Apr 2024 13:40:53 +0000 (14:40 +0100)]
Merge pull request #56917 from rhcs-dashboard/wip-65500-reef

reef: mgr/dashboard: remove minutely from retention

Reviewed-by: afreen23 <NOT@FOUND>
15 months agoMerge pull request #56914 from zdover23/wip-doc-2024-04-16-backport-56905-to-reef
Anthony D'Atri [Tue, 16 Apr 2024 12:15:03 +0000 (08:15 -0400)]
Merge pull request #56914 from zdover23/wip-doc-2024-04-16-backport-56905-to-reef

reef: doc/security: remove old GPG information

15 months agomgr/dashboard: Move features to advanced section 56921/head
Afreen [Thu, 4 Apr 2024 07:41:11 +0000 (13:11 +0530)]
mgr/dashboard: Move features to advanced section

Fixes https://tracker.ceph.com/issues/65207

- Moves "features" section in rbd image create form to "Advanced" section.
- makes rbd configuration section to be expanded by default rather than
  being collapsed as it has only single section. This will improve user experience as it will not
require two clicks.
- updates e2e test

Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit 921a5249fd1b1b2828d055bc92abf2fa428875ce)

15 months agomgr/dashboard: remove minutely from retention dd 56917/head
Ivo Almeida [Mon, 15 Apr 2024 15:50:41 +0000 (16:50 +0100)]
mgr/dashboard: remove minutely from retention dd

Removed "minutely" from retention policy dropdown

Fixes: https://tracker.ceph.com/issues/65493
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit 406f48d1c18858d5e6894c6aa521b395e8697ae4)

15 months agodoc/security: remove old GPG information 56914/head
Zac Dover [Mon, 15 Apr 2024 15:45:10 +0000 (01:45 +1000)]
doc/security: remove old GPG information

Remove a GPG key that was lost in a server upgrade, and remove the text
that describes it.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 95ec06a59a29ad2528471312ebc2931f7097213b)

15 months agoMerge pull request #56862 from rhcs-dashboard/wip-65459-reef
Ivo Almeida [Mon, 15 Apr 2024 10:42:09 +0000 (11:42 +0100)]
Merge pull request #56862 from rhcs-dashboard/wip-65459-reef

reef: mgr/dashboard: fix snap schedule delete retention

Reviewed-by: afreen23 <NOT@FOUND>
15 months agoMerge pull request #56880 from rhcs-dashboard/wip-65464-reef
Ivo Almeida [Mon, 15 Apr 2024 09:56:06 +0000 (10:56 +0100)]
Merge pull request #56880 from rhcs-dashboard/wip-65464-reef

reef: mgr/dashboard: snapshot schedule repeat frequency validation

Reviewed-by: afreen23 <NOT@FOUND>
15 months agomgr/dashboard: fix repeat frequency validation 56880/head
Ivo Almeida [Tue, 19 Mar 2024 12:44:40 +0000 (12:44 +0000)]
mgr/dashboard: fix repeat frequency validation

Fixed snap schedule repeat frequency validation

Fixes: https://tracker.ceph.com/issues/64980
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit 92b40f91c07086406103c865af7c645b99d43806)

15 months agoMerge pull request #56872 from zdover23/wip-doc-2024-04-14-backport-56870-to-reef
Anthony D'Atri [Sat, 13 Apr 2024 21:51:14 +0000 (17:51 -0400)]
Merge pull request #56872 from zdover23/wip-doc-2024-04-14-backport-56870-to-reef

reef: doc/cephfs: disambiguate "Reporting Free Space"

15 months agodoc/cephfs: disambiguate "Reporting Free Space" 56872/head
Zac Dover [Sat, 13 Apr 2024 10:48:21 +0000 (20:48 +1000)]
doc/cephfs: disambiguate "Reporting Free Space"

Make a few sentences clearer in doc/cephfs/ceph-auth.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 788ccff18149b16cb01947c5bcf3bde380090df0)

15 months agoMerge pull request #56857 from guits/update-cv-func-tests-reef
Guillaume Abrioux [Sat, 13 Apr 2024 03:59:07 +0000 (05:59 +0200)]
Merge pull request #56857 from guits/update-cv-func-tests-reef

ceph-volume: update functional testing

15 months agomgr/dashboard: fix snap schedule delete retention 56862/head
Ivo Almeida [Mon, 8 Apr 2024 13:39:49 +0000 (14:39 +0100)]
mgr/dashboard: fix snap schedule delete retention

Fixes: https://tracker.ceph.com/issues/65370
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
(cherry picked from commit 985637825a48a678b0d88887c5e322de65599fc7)

15 months agoMerge pull request #56851 from zdover23/wip-doc-2024-04-12-backport-56831-to-reef
Anthony D'Atri [Fri, 12 Apr 2024 14:04:24 +0000 (10:04 -0400)]
Merge pull request #56851 from zdover23/wip-doc-2024-04-12-backport-56831-to-reef

reef: doc/cephfs: refine client-auth (3 of 3)

15 months agoceph-volume: update functional testing 56857/head
Guillaume Abrioux [Thu, 11 Apr 2024 07:43:47 +0000 (09:43 +0200)]
ceph-volume: update functional testing

various changes for fixing ceph-volume functional testing.
cleaning up deploy.yml (drop py2 references)

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit 90bfaaa2f0ab7e28c0f78189ccb83635e944e758)
(cherry picked from commit bf448e3f637f8c8e42f095b1b5ff709e3633dc11)

15 months agoMerge pull request #54942 from rishabh-d-dave/wip-63834-reef
Rishabh Dave [Fri, 12 Apr 2024 09:10:53 +0000 (14:40 +0530)]
Merge pull request #54942 from rishabh-d-dave/wip-63834-reef

reef: cephfs: add command "ceph fs swap"

Reviewed-by: Milind Changire <mchangir@redhat.com>
15 months agodoc/cephfs: refine client-auth (3 of 3) 56851/head
Zac Dover [Thu, 11 Apr 2024 11:18:53 +0000 (21:18 +1000)]
doc/cephfs: refine client-auth (3 of 3)

Refine the final third of doc/cephfs/client-auth.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 44d1eeed703e968b374ec4d12fff3a2466a4c276)

15 months agoMerge pull request #56842 from zdover23/wip-doc-2024-04-12-backport-56784-to-reef
Anthony D'Atri [Fri, 12 Apr 2024 03:11:57 +0000 (23:11 -0400)]
Merge pull request #56842 from zdover23/wip-doc-2024-04-12-backport-56784-to-reef

reef: doc/cephfs: refine client-auth (2 of 3)

15 months agodoc/cephfs: refine client-auth (2 of 3) 56842/head
Zac Dover [Tue, 9 Apr 2024 12:04:46 +0000 (22:04 +1000)]
doc/cephfs: refine client-auth (2 of 3)

Refine the second third of doc/cephfs/client-auth.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 083f56352b4fff662dff3c78b6a0c455605d02ff)

15 months agoMerge pull request #56780 from zdover23/wip-doc-2024-04-09-backport-56754-to-reef
Anthony D'Atri [Tue, 9 Apr 2024 21:27:10 +0000 (17:27 -0400)]
Merge pull request #56780 from zdover23/wip-doc-2024-04-09-backport-56754-to-reef

reef: doc/cephfs: refine client-auth (1 of 3)

15 months agoMerge pull request #56798 from zdover23/wip-doc-2024-04-10-backport-56796-to-reef
Anthony D'Atri [Tue, 9 Apr 2024 20:59:20 +0000 (16:59 -0400)]
Merge pull request #56798 from zdover23/wip-doc-2024-04-10-backport-56796-to-reef

reef: doc/mgr: remove Zabbix 1 information

15 months agodoc/mgr: remove Zabbix 1 information 56798/head
Zac Dover [Tue, 9 Apr 2024 20:04:28 +0000 (06:04 +1000)]
doc/mgr: remove Zabbix 1 information

Remove information about the installation of the Zabbix module and link
to a discussion of the reasoning behind Ceph's refusal to support
Zabbix.

John Jasen developed a procedure explaining how to install "Zabbix 2".
This commit removes outdated procedures and explains why those
procedures were removed. Immediately following this explanation, the
text includes an explanation of how to install "Zabbix 2".

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 29ac627956c5e5cdd4ed5f1316c20bc9e1fe0ff7)

15 months agoMerge pull request #56762 from adk3798/reef-cephadm-pin-pyfakefs-version
Adam King [Tue, 9 Apr 2024 15:29:56 +0000 (11:29 -0400)]
Merge pull request #56762 from adk3798/reef-cephadm-pin-pyfakefs-version

reef: cephadm: pin pyfakefs version for tox tests

Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agodoc/cephfs: refine client-auth (1 of 3) 56780/head
Zac Dover [Mon, 8 Apr 2024 12:07:38 +0000 (22:07 +1000)]
doc/cephfs: refine client-auth (1 of 3)

Refine the first third of doc/cephfs/client-auth.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 82c5bac5df553f1e13a2df3a107b2692efa6fc27)

15 months agoMerge pull request #56672 from batrick/wip-65294-reef
Yuri Weinstein [Mon, 8 Apr 2024 18:18:25 +0000 (11:18 -0700)]
Merge pull request #56672 from batrick/wip-65294-reef

reef: mds: skip sr moves when target is an unlinked dir

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agoMerge pull request #53635 from vshankar/wip-62287-reef
Yuri Weinstein [Mon, 8 Apr 2024 18:17:47 +0000 (11:17 -0700)]
Merge pull request #53635 from vshankar/wip-62287-reef

reef: test: explicitly link to ceph-common for some libcephfs tests

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agoMerge pull request #53357 from k0ste/wip-61993-reef
Yuri Weinstein [Mon, 8 Apr 2024 18:16:37 +0000 (11:16 -0700)]
Merge pull request #53357 from k0ste/wip-61993-reef

reef: mds/MDSRank: Add set_history_slow_op_size_and_threshold for op_tracker

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agocephadm: pin pyfakefs version for tox tests 56762/head
Adam King [Mon, 8 Apr 2024 14:48:18 +0000 (10:48 -0400)]
cephadm: pin pyfakefs version for tox tests

5.4.0 seems to have caused a number of permission issues
in the test. In order to unblock make check, let's pin it
to 5.3.5 for now.

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit ce71ce10b7551a649c9a64be992c0eddfa7e7243)

15 months agoMerge pull request #56736 from rhcs-dashboard/fix-65285-reef
Aashish Sharma [Mon, 8 Apr 2024 04:33:39 +0000 (10:03 +0530)]
Merge pull request #56736 from rhcs-dashboard/fix-65285-reef

mgr/dashboard: add Table Schema to grafonnet

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56740 from zdover23/wip-doc-2024-05-07-backport-56738-to-reef
Anthony D'Atri [Sun, 7 Apr 2024 12:28:31 +0000 (08:28 -0400)]
Merge pull request #56740 from zdover23/wip-doc-2024-05-07-backport-56738-to-reef

reef: doc/dev: refine "Concepts" 4 of 3

15 months agodoc/dev: refine "Concepts" 4 of 3 56740/head
Zac Dover [Sat, 6 Apr 2024 04:43:16 +0000 (14:43 +1000)]
doc/dev: refine "Concepts" 4 of 3

s/PG's PG logs/PG's logs/

re https://github.com/ceph/ceph/pull/56727#discussion_r1553541922

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 221d734760b6f680e4d17cd2f0bfcd39f914c8d6)

15 months agoqa/cephfs: allow finer control on test runs 54942/head
Rishabh Dave [Thu, 2 Nov 2023 19:02:06 +0000 (00:32 +0530)]
qa/cephfs: allow finer control on test runs

When working with large group tests (18 in this case), it gets very
tedious to debug and fix tests when all 18 have to be run again for
every mistake. Cheap fix for this to split these 18 tests into several
classes.

But when modification are made to the feature, all these 18 tests needs
to exercised and previous solution forces developer to intitiate all
these test classes to run one by one.

Best of both worlds can be achieved if we split tests into group but
move all these related group to a new file.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 9c547ad2a570a325ea453ccc9419be2b8bc06b28)

15 months agomon/FSCommands: use alias for higher brevity
Rishabh Dave [Thu, 28 Sep 2023 13:26:22 +0000 (18:56 +0530)]
mon/FSCommands: use alias for higher brevity

Create an alias so "APP_NAME_CEPHFS" can be written instead of
"pg_pool_t::APPLICATION_NAME_CEPHFS".

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 4a12f6eb6c16722f1d68e0949390cd7d30f44bc6)

Conflicts:
src/mon/FSCommands.cc
* Conflict occured because variable in Reef is "fs" and in Main
  branch is "fsp".

15 months agocephfs: add command "ceph fs swap"
Rishabh Dave [Sun, 29 Jan 2023 20:48:54 +0000 (02:18 +0530)]
cephfs: add command "ceph fs swap"

Add a FS command that enables users to swap names of two file systems in
a single PAXOS transaction. Add an option to this command that swaps
FSCIDS along with FS names. This commands also updates the application
pool tags and fails when mirroring is enabled on either or both FSs.

Fixes: https://tracker.ceph.com/issues/58129
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 717031454243898071bdb254b2cadc7048057903)

Conflicts:
doc/man/8/ceph.rst
Conflict occurred because Ceph man page contians lesser amout of
CephFS commands in it in Reef branch

src/mds/FSMap.h
* Methods like set_fscid() can be cherry-picked as it is but due
  to different lines around, patch couldn't be applied as it is.
* Methods like get_fscid(), get_mds_map() are absent in Reef
  branch. They have been kept/added during this conflict
  resolution.

15 months agoqa/cephfs: log commands on INFO logging level
Rishabh Dave [Tue, 10 Oct 2023 11:00:00 +0000 (16:30 +0530)]
qa/cephfs: log commands on INFO logging level

Commands issued by negtest_ceph_cmd() aren't printed because log level
(due to code for teuthology) changes from DEBUG to INFO in case of some
files.

This patch ensures that users can see commands being executed regardless
of whether log level is changed or not.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 03df86b7c54325fd577bacec6a1f4c6441117e72)

15 months agoqa: log stdout for commands being run through negtest_ceph_cmd
Rishabh Dave [Tue, 10 Oct 2023 10:42:13 +0000 (16:12 +0530)]
qa: log stdout for commands being run through negtest_ceph_cmd

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit bd4cb58f7abca4fa20ec283f675f31d1ede14752)

15 months agoqa: minor improvement in ceph_test_case.py
Rishabh Dave [Tue, 10 Oct 2023 10:39:20 +0000 (16:09 +0530)]
qa: minor improvement in ceph_test_case.py

When two values (say x and y) are being printed because assert for
equality of both failed (assert x == y), print both the values on a new
line.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit edec8f35abc2d7bb6aef68ea9b841e33e12012dd)

15 months agoqa/cephfs: minor improvement caps_helper.py
Rishabh Dave [Tue, 3 Oct 2023 08:11:54 +0000 (13:41 +0530)]
qa/cephfs: minor improvement caps_helper.py

When assert fails for equality of two variables and when both the
variables are printed in error message, print each variable on a new
line.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 6ac58b0a12324ea13c724cbba3107e1eae9a96c3)

15 months agoqa/cephfs: import only sleep() from time
Rishabh Dave [Mon, 2 Oct 2023 19:47:42 +0000 (01:17 +0530)]
qa/cephfs: import only sleep() from time

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 69e4c9e4729fd0d29ed43fb1f6e94cb1804a3f74)

Conflicts:
* qa/tasks/cephfs/test_admin.py
  The commit needs an update so that importing "sleep" from "time"
  instead of importing "time" fully works on Reef branch too.

15 months agomds/FSMap: add logging facility
Rishabh Dave [Mon, 2 Oct 2023 19:47:09 +0000 (01:17 +0530)]
mds/FSMap: add logging facility

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit be78b3ea68f75319da05700276630f7f331bbd63)

15 months agoqa/cephfs/cap_tester: simplify CapTester and its instantiation
Rishabh Dave [Tue, 18 Apr 2023 14:55:01 +0000 (20:25 +0530)]
qa/cephfs/cap_tester: simplify CapTester and its instantiation

Class CapTester contains two distinct immiscible group of methods: one
that tests MON caps and other that tests MDS caps. When using CapTester
for the former reason the instantiation neither needs mount object and
the path where files for testing will be created nor it needs to run the
method that creates files for testing rw permissions. When using
this class for latter the case is the exact opposite.

Create 2 separate classes for each of these purpose and class that
inherits both of these classes so that instantiating the class becomes
as simple as it can be.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit f0ffade0525674b1f851797b1107060d8aa93d5c)

Conflicts:
 - qa/tasks/cephfs/caps_helper.py:
   This file went through changes due to merging of commit 59c9104c54d6.

15 months agoqa/cephfs: update method caps_helper.CapTester.run_cap_tests()
Rishabh Dave [Tue, 18 Apr 2023 07:15:03 +0000 (12:45 +0530)]
qa/cephfs: update method caps_helper.CapTester.run_cap_tests()

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 95c6daa45b0982348d775210e5945eeeae2ac5ca)

15 months agoqa/cephfs: move few methods such that they can be reused
Rishabh Dave [Thu, 6 Apr 2023 09:42:14 +0000 (15:12 +0530)]
qa/cephfs: move few methods such that they can be reused

Move get_mon_cap_from_keyring() and get_fsnmes_from_moncap() from class
CapTester to main namespace of caps_helper.py so that they can be
imported freely and reused by tests.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit ea9f13e5536120c135e85c4962bb989e83910d6b)

15 months agoqa/cephfs: improve caps_helper.CapTester.run_mon_cap_tests()
Rishabh Dave [Thu, 6 Apr 2023 09:23:17 +0000 (14:53 +0530)]
qa/cephfs: improve caps_helper.CapTester.run_mon_cap_tests()

This method checks if the output of the command "ceph fs ls" for client
ID it receives is same as the output printed for client.admin. Don't do
so, limit the test to only checking if "ceph fs ls --id client.x -k
keyring_file" prints fs name for which client.x has permissions.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit ad68a5512105e102a87d1fe9648257eebd4c432e)

15 months agoqa/cephfs: improve caps_helper.CapTester
Rishabh Dave [Fri, 31 Mar 2023 19:14:52 +0000 (00:44 +0530)]
qa/cephfs: improve caps_helper.CapTester

Improvement #1:

CapTester.write_test_files() not only creates the test file but also
does the following for every mount object it receives in parameters -

* carefully produces the path for the test file as per parameters
  received
* generates the unique data for each test file on a CephFS mount
* creates a data structure -- list of lists -- that holds all this
  information along with mount object itself for each mount object so
  that tests can be conducted at a later point

Untangle this mess of code by splitting this method into 3 separate
methods -

1. To produce the path for test file (as per user's need).
2. To generate the data that will be written into the test file.
3. To actually create the test file on CephFS.

Improvement #2:

Remove the internal data structure used for testing -- self.test_set --
and use separate class attributes to store all the data required for
testing instead of a tuple. This serves two purpose -

One, it makes it easy to manipulate all this data from helper methods
and during debugging session, especially while using a PDB session.

And two, make it impossible to have multiple mounts/multiple "test sets"
within same CapTester instance for the sake of simplicity. Users can
instead create two instances of CapTester instances if needed.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 008dbe91e2994a654cba37e07ca6a9ae7c98fa2f)

Conflicts:
  qa/tasks/cephfs/caps_helper.py
  - Conflict occurred because this file went under modification due to
    commit 59c9104c54d6.
  qa/tasks/cephfs/test_admin.py
  - Conflict occurred because code region located around the patch has
    changed.

15 months agoMerge pull request #56729 from zdover23/wip-doc-2024-04-05-backport-56727-to-reef
Zac Dover [Sat, 6 Apr 2024 04:39:26 +0000 (14:39 +1000)]
Merge pull request #56729 from zdover23/wip-doc-2024-04-05-backport-56727-to-reef

reef: doc/dev: refine "Concepts" 3 of 3

15 months agomgr/dashboard: add Table Schema to grafonnet 56736/head
Aashish Sharma [Sat, 6 Apr 2024 03:36:51 +0000 (09:06 +0530)]
mgr/dashboard: add Table Schema to grafonnet

Backport of #56509 in reef didn't include the Table Schema in the
utils.libsonnet because of which the json generation ias failing. This
PR tends to add the Table Schema

Signed-off-by: Aashish Sharma <aasharma@redhat.com>
15 months agoMerge pull request #56707 from afreen23/wip-65209-reef
Nizamudeen A [Fri, 5 Apr 2024 17:27:17 +0000 (22:57 +0530)]
Merge pull request #56707 from afreen23/wip-65209-reef

reef: mgr/dashboard:Update encryption and tags in bucket form

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56710 from afreen23/wip-65333-reef
Nizamudeen A [Fri, 5 Apr 2024 17:26:10 +0000 (22:56 +0530)]
Merge pull request #56710 from afreen23/wip-65333-reef

reef: mgr/dashboard:Use advanced fieldset for rbd image

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agodoc/dev: refine "Concepts" 3 of 3 56729/head
Zac Dover [Fri, 5 Apr 2024 06:43:47 +0000 (16:43 +1000)]
doc/dev: refine "Concepts" 3 of 3

Refine the third third of the entries in the section "Concepts" in
doc/dev/peering.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 512e2dc9d52fdd14dfdd87ccd141e535d3098fb7)

15 months agoMerge pull request #56725 from zdover23/wip-doc-2024-04-05-backport-56646-to-reef
Anthony D'Atri [Fri, 5 Apr 2024 12:34:21 +0000 (08:34 -0400)]
Merge pull request #56725 from zdover23/wip-doc-2024-04-05-backport-56646-to-reef

reef: doc/dev: refine "Concepts" 2 of 3

15 months agoMerge pull request #56682 from aaSharma14/wip-65285-reef
Aashish Sharma [Fri, 5 Apr 2024 04:52:48 +0000 (10:22 +0530)]
Merge pull request #56682 from aaSharma14/wip-65285-reef

reef: mgr/dashboard: replace deprecated table panel in grafana with a newer table panel

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agodoc/dev: refine "Concepts" 2 of 3 56725/head
Zac Dover [Wed, 3 Apr 2024 05:02:29 +0000 (15:02 +1000)]
doc/dev: refine "Concepts" 2 of 3

Refine the second third of the entries in the section "Concepts" in
doc/dev/peering.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 7bb35282da27f0c18ffbe36f2c0852a827c5bc2f)

15 months agomgr/dashboard:Use advanced fieldset for rbd image 56710/head
Afreen [Wed, 27 Mar 2024 09:35:58 +0000 (15:05 +0530)]
mgr/dashboard:Use advanced fieldset for rbd image

Fixes https://tracker.ceph.com/issues/65025

- using cd-advanced-fieldset component for advanced section
- this will align advanced sections of forms in dashboard
- changed heading of sections of rbd-configuration to h5 to better represent it
  as a sub section.
- added unit tests for rbd image config

Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit 25552117b433dbe39bf245aeda99761def5749eb)

15 months agomgr/dashboard:Update encryption and tags in bucket form 56707/head
Afreen [Mon, 25 Mar 2024 08:39:08 +0000 (14:09 +0530)]
mgr/dashboard:Update encryption and tags in bucket form

Fixes https://tracker.ceph.com/issues/65110

- renamed Security to Encryption
- aligned security fieldset with rest of the form using `cd-help-text`
  and aligning it with object locking in UX
- aligned security fieldset top use `cd-help-text`
- changed help text of Tags

Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit 96b21d7cf5bb698102dc0cfce6fef05204b82d2e)

15 months agoMerge pull request #56692 from afreen23/wip-65304-reef
Nizamudeen A [Thu, 4 Apr 2024 16:34:52 +0000 (22:04 +0530)]
Merge pull request #56692 from afreen23/wip-65304-reef

reef: mgr/dashboard: Add advanced fieldset component

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
15 months agoMerge pull request #56323 from adk3798/wip-64844-reef
Yuri Weinstein [Thu, 4 Apr 2024 15:31:35 +0000 (08:31 -0700)]
Merge pull request #56323 from adk3798/wip-64844-reef

reef: ceph-volume: Use safe accessor to get TYPE info

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
15 months agoMerge pull request #56648 from zdover23/wip-doc-2024-04-03-backport-56228-to-reef
Zac Dover [Thu, 4 Apr 2024 12:55:35 +0000 (22:55 +1000)]
Merge pull request #56648 from zdover23/wip-doc-2024-04-03-backport-56228-to-reef

reef: doc: fixing doc/cephfs/fs-volumes

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
15 months agoqa/cephfs: simplify some code in test_multifs_auth.py
Rishabh Dave [Fri, 24 Mar 2023 11:47:36 +0000 (17:17 +0530)]
qa/cephfs: simplify some code in test_multifs_auth.py

test_mutlifs_auth.TestMDSCaps._create_client() not only creates a client
but also generate caps strings for the client as per the parameter this
method receives and and then writes the keyring to all remote machines.
This creates confusion when reading code on test methods in TestMDSCaps.
Let's re-arrange this code such that this confusion is avoided.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 265abc79b300c0a5b5ccdad85ac68f52a76aa6dc)

15 months agoqa/cephfs: don't inherit CephFSTestCase in CapTester
Rishabh Dave [Thu, 13 Apr 2023 19:08:33 +0000 (00:38 +0530)]
qa/cephfs: don't inherit CephFSTestCase in CapTester

Inheritting CephFSTestCase in CapTester just for methods assertEqual()
and assertIn() from class unittest.TestCase is odd and heavy-weight.
Don't inherit CephFSTestCase and use simple assert instead.

Reference: https://github.com/ceph/ceph/pull/50882#discussion_r1160611549.

To avoid code duplication, a couple of similar methods have been added
instead.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit e8bdf94b814eb09f859e6d1e31d53e826a7bffcc)

Conflicts:
  qa/tasks/cephfs/caps_helper.py
  - Conflict occured because code on Reef branch changed due to merging of
    commit 59c9104c54d6.

15 months agoqa/cephfs: minor improvement in caps_helper
Rishabh Dave [Thu, 30 Mar 2023 19:36:13 +0000 (01:06 +0530)]
qa/cephfs: minor improvement in caps_helper

Use Python type list instead of tuple since it get's necessary to modify
members of this sequence.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 1a7ca489b4b84ae48c831ec63b201c024047b295)

15 months agoqa/cephfs: minor corrections in caps_helper.py
Rishabh Dave [Mon, 13 Mar 2023 12:15:57 +0000 (17:45 +0530)]
qa/cephfs: minor corrections in caps_helper.py

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 1428fb1e738626801326b865340b011003ea6f14)

15 months agoqa/cephfs: add more helper methods to caps_helper.py
Rishabh Dave [Mon, 13 Mar 2023 10:46:13 +0000 (16:16 +0530)]
qa/cephfs: add more helper methods to caps_helper.py

Add methods that will accept read/write permissions, CephFS names and
CephFS mount point and in return will generate string form of MON, OSD
and MDS caps exactly as it is reported in Ceph keyrings.

Replace similar code in test_multifs_auth.py with calls to these helper
methods.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 969a93d0dcf1848623b0bd581b8e2e9a5a556839)

15 months agoMerge pull request #56684 from zdover23/wip-doc-2024-04-04-backport-56662-to-reef
Zac Dover [Thu, 4 Apr 2024 11:39:21 +0000 (21:39 +1000)]
Merge pull request #56684 from zdover23/wip-doc-2024-04-04-backport-56662-to-reef

reef: doc/mgr: credit John Jasen for Zabbix 2

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agoMerge pull request #54945 from rishabh-d-dave/wip-63405-reef
Rishabh Dave [Thu, 4 Apr 2024 10:24:48 +0000 (15:54 +0530)]
Merge pull request #54945 from rishabh-d-dave/wip-63405-reef

reef: MDSAuthCaps: print better error message for perm flag in MDS caps

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agomgr/dashboard: Add advanced fieldset component 56692/head
Afreen [Fri, 1 Mar 2024 07:26:25 +0000 (12:56 +0530)]
mgr/dashboard: Add advanced fieldset component

Fixes https://tracker.ceph.com/issues/65024

- adds a new shared component for displaying advanced fields in /shared
- utilizes that component in bucket form
- placement targets are under advanced fieldset
- minor help text changes in object locking help text
- updated e2e tests

Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit d0979e9c5223231a0fd3ef6408323d2fd5cd2ac5)

Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/shared/components/components.module.ts

15 months agoMerge pull request #56171 from vshankar/wip-64218-reef
Venky Shankar [Thu, 4 Apr 2024 06:57:43 +0000 (12:27 +0530)]
Merge pull request #56171 from vshankar/wip-64218-reef

reef: qa: `fs volume rename` requires `fs fail` and `refuse_client_session` set

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
15 months agoMerge pull request #56169 from vshankar/wip-64047-reef
Venky Shankar [Thu, 4 Apr 2024 06:57:10 +0000 (12:27 +0530)]
Merge pull request #56169 from vshankar/wip-64047-reef

reef: qa: set mds config with `config set` for a particular test

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
15 months agoMerge pull request #56167 from vshankar/wip-64250-reef
Venky Shankar [Thu, 4 Apr 2024 06:56:40 +0000 (12:26 +0530)]
Merge pull request #56167 from vshankar/wip-64250-reef

reef: qa: correct usage of DEBUGFS_META_DIR in dedent

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
15 months agoMerge pull request #56016 from vshankar/wip-64759-reef
Venky Shankar [Thu, 4 Apr 2024 06:49:54 +0000 (12:19 +0530)]
Merge pull request #56016 from vshankar/wip-64759-reef

reef: mds: relax certain asserts in mdlog replay thread

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
15 months agoMerge pull request #56557 from afreen23/wip-65205-reef
Nizamudeen A [Thu, 4 Apr 2024 05:49:41 +0000 (11:19 +0530)]
Merge pull request #56557 from afreen23/wip-65205-reef

reef: mgr/dashboard: make ceph logo redirect to dashboard

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56621 from afreen23/wip-65211-reef
Nizamudeen A [Thu, 4 Apr 2024 05:47:51 +0000 (11:17 +0530)]
Merge pull request #56621 from afreen23/wip-65211-reef

reef: mgr/dashboard: Mark placement targets as non-required

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56049 from lxbsz/wip-64584
Venky Shankar [Thu, 4 Apr 2024 04:29:10 +0000 (09:59 +0530)]
Merge pull request #56049 from lxbsz/wip-64584

reef: mds: allow lock state to be LOCK_MIX_SYNC in replica for filelock

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agodoc/mgr: credit John Jasen for Zabbix 2 56684/head
Zac Dover [Wed, 3 Apr 2024 12:21:04 +0000 (22:21 +1000)]
doc/mgr: credit John Jasen for Zabbix 2

Credit John Jasen for the development of the procedures describing the
installation of Zabbix 2.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 28aa556448cf02dc943653e76a7ef89e10ae93e9)

15 months agomgr/dashboard: replace deprecated table panel in grafana with a newer 56682/head
Aashish Sharma [Wed, 27 Mar 2024 08:16:24 +0000 (13:46 +0530)]
mgr/dashboard: replace deprecated table panel in grafana with a newer
table panel

Fixes: https://tracker.ceph.com/issues/65174
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit c2f4aa7887d8322bc58cd1cb322746246ccebe32)

15 months agoMerge pull request #56347 from cbodley/wip-65003-reef
Yuri Weinstein [Wed, 3 Apr 2024 22:04:30 +0000 (15:04 -0700)]
Merge pull request #56347 from cbodley/wip-65003-reef

reef: rgw: Add missing empty checks to the split string in is_string_in_set().

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
15 months agoMerge pull request #56197 from ifed01/wip-ifed-fix-estimate-kv-reef
Yuri Weinstein [Wed, 3 Apr 2024 22:03:38 +0000 (15:03 -0700)]
Merge pull request #56197 from ifed01/wip-ifed-fix-estimate-kv-reef

reef: os/kv_test: Fix estimate functions

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
15 months agoMerge pull request #55867 from trociny/wip-64650-reef
Yuri Weinstein [Wed, 3 Apr 2024 22:02:44 +0000 (15:02 -0700)]
Merge pull request #55867 from trociny/wip-64650-reef

reef: mon/OSDMonitor: fix get_min_last_epoch_clean()

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
15 months agoMerge pull request #55777 from ifed01/wip-ifed-fix-expand-with-ncb-reef
Yuri Weinstein [Wed, 3 Apr 2024 22:01:23 +0000 (15:01 -0700)]
Merge pull request #55777 from ifed01/wip-ifed-fix-expand-with-ncb-reef

reef: os/bluestore: fix free space update after bdev-expand in NCB mode

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
15 months agoMerge pull request #55548 from k0ste/wip-64397-reef
Yuri Weinstein [Wed, 3 Apr 2024 21:58:18 +0000 (14:58 -0700)]
Merge pull request #55548 from k0ste/wip-64397-reef

reef: mon: fix health store size growing infinitely

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>