]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Adam King [Mon, 29 Apr 2024 17:54:37 +0000 (13:54 -0400)]
qa/cephadm: ignore stray daemon warning during rados_api_tests
The "stray daemon" that is getting logged about in this test is
from "stray daemon laundry.pid70383 on host smithi027 not managed by cephadm".
It seems the rados_api_tests is creating some additional "laundry" entity
during these tests that gets reported as an actual daemon in the mgr,
but cephadm is unaware of it, resulting in the warning. Originally
we thought to maybe add "laundry" itself to the ignorelist, but
without an additional patch that added extra logging for debug
purposes (which can't be merged) the log statement found in
the logs due to this problem will not say what daemon it found
to be stray. There will just be a generic warning about a stray
daemon. In a real cluster, a user would then check "ceph health detail"
to find out what daemon is stray, but the log scraper can't do this
and just fails the test due to the presence of the warning.
Signed-off-by: Adam King <adking@redhat.com>
Anthony D'Atri [Mon, 29 Apr 2024 12:24:37 +0000 (08:24 -0400)]
Merge pull request #57136 from zdover23/wip-doc-2024-04-29-radosgw-bucketpolicy
doc/radosgw: disambiguate version-added remarks
Zac Dover [Mon, 29 Apr 2024 10:23:13 +0000 (20:23 +1000)]
doc/radosgw: disambiguate version-added remarks
Rewrite two sentences so that they explain precisely what was added to
Ceph and when it was added to Ceph.
This commit is made in response to a request made by Dr Per Mildner on
https://pad.ceph.com/p/Report_Documentation_Bugs.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Yingxin [Mon, 29 Apr 2024 08:44:36 +0000 (16:44 +0800)]
Merge pull request #55449 from xxhdx1985126/wip-seastore-extent-chksum
crimson/os/seastore: support extent checksum verification
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
Yingxin [Mon, 29 Apr 2024 06:50:01 +0000 (14:50 +0800)]
Merge pull request #57088 from xxhdx1985126/wip-seastore-update-onode-size
crimson/os/seastore: only update onode sizes when necessary
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Xuehan Xu [Mon, 29 Apr 2024 06:20:12 +0000 (14:20 +0800)]
Merge pull request #57118 from xxhdx1985126/wip-65673
test/ceph_crypto: define __has_feature if the compiler doesn't have it
Reviewed-by: Kefu Chai <kefu.chai@scylladb.com>
Zac Dover [Mon, 29 Apr 2024 02:37:53 +0000 (12:37 +1000)]
Merge pull request #57119 from zdover23/wip-doc-2024-04-28-cephfs-client-auth
doc/cephfs: edit front matter in client-auth.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Sun, 28 Apr 2024 13:18:50 +0000 (23:18 +1000)]
doc/cephfs: edit front matter in client-auth.rst
Clarify the front matter in doc/cephfs/client-auth.rst.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Kefu Chai [Sun, 28 Apr 2024 15:14:49 +0000 (23:14 +0800)]
Merge pull request #57112 from tchaikov/erasure-code-free
erasure-code/shec: use free() to release alloc()'ed memory chunk
Reviewed-by: Rongqi Sun <sunrongqi@huawei.com>
Kefu Chai [Sun, 28 Apr 2024 12:27:03 +0000 (20:27 +0800)]
Merge pull request #57113 from tchaikov/erasure-code-free-crush-wrapper
test//erasure-code/TestErasureCodeLrc: free allocated CrushWrapper
Reviewed-by: Rongqi Sun <sunrongqi@huawei.com>
Kefu Chai [Sun, 28 Apr 2024 12:26:21 +0000 (20:26 +0800)]
Merge pull request #57111 from tchaikov/erasure-code-nullptr
erasure-code/shec: replace 0 with nullptr when appropriate
Reviewed-by: Rongqi Sun <sunrongqi@huawei.com>
Xuehan Xu [Sun, 28 Apr 2024 03:11:57 +0000 (11:11 +0800)]
test/ceph_crypto: define __has_feature if the compiler doesn't have it
Refer to https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005ffeature.html
and https://clang.llvm.org/docs/LanguageExtensions.html#has-feature-and-has-extension
for further information
Fixes: https://tracker.ceph.com/issues/65673
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Kefu Chai [Sun, 28 Apr 2024 01:05:07 +0000 (09:05 +0800)]
test//erasure-code/TestErasureCodeLrc: free allocated CrushWrapper
in TestErasureCodeLrc.cc, we create a `CrushWrapper` without
destroying and freeing it. and ASan points this out:
```
Indirect leak of 72000 byte(s) in 1000 object(s) allocated from:
#0 0x559e00acc2bd in operator new(unsigned long) (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_erasure_code_lrc+0x1ed2bd) (BuildId:
1cd93d0f231006242239eb0d81a8d677e36aeba2 )
#1 0x559e00b2bb76 in __gnu_cxx::new_allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::allocate(unsigned long, void const*) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:127:27
#2 0x559e00b2bb00 in std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::allocate(unsigned long) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/allocator.h:185:32
#3 0x559e00b2bb00 in std::allocator_traits<std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > > >::allocate(std::allocator<std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >&, unsigned long) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/alloc_traits.h:464:20
#4 0x559e00b2b9d1 in std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::_M_get_node() /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_tree.h:561:16
#5 0x559e00b2aae4 in std::_Rb_tree_node<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> >* std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::_M_create_node<std::piecewise_construct_t const&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&>, std::tuple<> >(std::piecewise_construct_t const&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&>&&, std::tuple<>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_tree.h:611:23
#6 0x559e00b29520 in std::_Rb_tree_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > std::_Rb_tree<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int>, std::_Select1st<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::_M_emplace_hint_unique<std::piecewise_construct_t const&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&>, std::tuple<> >(std::_Rb_tree_const_iterator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> >, std::piecewise_construct_t const&, std::tuple<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&>&&, std::tuple<>&&) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_tree.h:2431:19
#7 0x559e00b255c2 in std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, int, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, int> > >::operator[](std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/stl_map.h:501:15
#8 0x559e00b188da in CrushWrapper::set_item_name(int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) /home/jenkins-build/build/workspace/ceph-pull-requests/src/crush/CrushWrapper.h:466:7
#9 0x7feb54a4dcc2 in CrushWrapper::insert_item(ceph::common::CephContext*, int, float, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&, bool) /home/jenkins-build/build/workspace/ceph-pull-requests/src/crush/CrushWrapper.cc:1119:5
#10 0x559e00ada922 in ErasureCodeTest_create_rule_Test::TestBody() /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/erasure-code/TestErasureCodeLrc.cc:127:5
#11 0x559e00c0e0a6 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2605:10
```
so, in this change, let's manage the lifecycle of the `CrushWrapper`
instance with a smart pointer, so that it is destroyed and free'd
properly, and this should silence the ASan warning.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sun, 28 Apr 2024 00:51:03 +0000 (08:51 +0800)]
erasure-code/shec: use free() to release alloc()'ed memory chunk
ASan warns
```
==445793==ERROR: AddressSanitizer: alloc-dealloc-mismatch (malloc vs operator delete) on 0x602000039b10
#0 0x5604a544112d in operator delete(void*) (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_erasure_code_shec_all+0x1e012d) (BuildId:
8cfc74d22471b6905f9b23304aed2af945265a13 )
#1 0x7fc14752f588 in ErasureCodeShecTableCache::~ErasureCodeShecTableCache() /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/shec/ErasureCodeShecTableCache.cc:61:19
#2 0x5604a544ccbe in ParameterTest_parameter_all_Test::TestBody() /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/erasure-code/TestErasureCodeShec_all.cc:263:1
...
0x602000039b10 is located 0 bytes inside of 4-byte region [0x602000039b10,0x602000039b14)
allocated by thread T0 here:
#0 0x5604a5405afe in malloc (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_erasure_code_shec_all+0x1a4afe) (BuildId:
8cfc74d22471b6905f9b23304aed2af945265a13 )
#1 0x7fc1474c9617 in reed_sol_vandermonde_coding_matrix /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/jerasure/jerasure/src/reed_sol.c:86:10
#2 0x7fc147528634 in ErasureCodeShec::shec_reedsolomon_coding_matrix(int) /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/shec/ErasureCodeShec.cc:514:12
#3 0x7fc147526cd8 in ErasureCodeShecReedSolomonVandermonde::prepare() /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/shec/ErasureCodeShec.cc:390:14
#4 0x7fc1475187aa in ErasureCodeShec::init(std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&, std::ostream*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/shec/ErasureCodeShec.cc:57:3
```
where we use `delete` to free the encoder matrix allocated using
`malloc()`. as jerasure is a library implemented in C language,
unless we want to reimplment it in C++, we should use `free()` to
free the memory chunk allocated by
`reed_sol_vandermonde_coding_matrix()`. also, please note,
jerasure does not provide a function to free the memory allocated
by this function, we have to explore its implementation, and use
`malloc()` directly. this should silence the ASan warning.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sun, 28 Apr 2024 00:36:09 +0000 (08:36 +0800)]
erasure-code/shec: replace 0 with nullptr when appropriate
0 fails to send the message to human readers that the variable is
a pointer, but nullptr does. for improving the readability, let's
use nullptr when the variable in question is a pointer.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Zac Dover [Fri, 26 Apr 2024 23:08:52 +0000 (09:08 +1000)]
Merge pull request #57105 from zdover23/wip-doc-2024-04-26-mgr-dashboard
doc/mgr: explain error message - dashboard.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Fri, 26 Apr 2024 11:59:09 +0000 (21:59 +1000)]
doc/mgr: explain error message - dashboard.rst
Explain that an error message received in response to
"redirect_resolve_ip_addr True" might be caused by having an
insufficiently recent release of Ceph running in your cluster.
Fixes: https://tracker.ceph.com/issues/61312
Signed-off-by: Zac Dover <zac.dover@proton.me>
Rishabh Dave [Fri, 26 Apr 2024 10:56:48 +0000 (16:26 +0530)]
Merge pull request #52024 from lxbsz/wip-61660
mds: fix the description for inotable testing only options
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Yingxin [Fri, 26 Apr 2024 02:08:53 +0000 (10:08 +0800)]
Merge pull request #57035 from xxhdx1985126/wip-65610
test/crimson/seastore/test_object_data_handler: remap pins through the transaction that created the pins
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin [Fri, 26 Apr 2024 02:07:07 +0000 (10:07 +0800)]
Merge pull request #56844 from cyx1231st/wip-crimson-fix-tri-mutex
crimson/common/tri_mutex: make locking/promotion atomic if possible
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Fri, 26 Apr 2024 00:41:48 +0000 (08:41 +0800)]
Merge pull request #57093 from tchaikov/wip-ceph_crypto-matcher
test: remove extraneous ")" after literal string for matcher
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Thu, 25 Apr 2024 14:52:36 +0000 (15:52 +0100)]
Merge pull request #56926 from samarahu/rgw-update-boost-redis
RGW: boost/redis: Point to 1.85 tag
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Thu, 25 Apr 2024 14:33:51 +0000 (15:33 +0100)]
Merge pull request #56486 from soumyakoduri/wip-skoduri-lc-stall
rgw/lc: advance head if the current entry doesn't exist
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Kefu Chai [Tue, 2 Apr 2024 10:15:14 +0000 (18:15 +0800)]
test: remove extraneous ")" after literal string for matcher
this is a follow-up of
fbbb336de961e433fc796dbdf6db650a836e9ef9 ,
which added an extraneous ")" at the end of the string literal.
and it breaks the build if ASan is enabled.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Casey Bodley [Thu, 25 Apr 2024 13:09:27 +0000 (14:09 +0100)]
Merge pull request #56860 from clwluvw/rgw-crypt-ssl
rgw: eliminate ssl enforcement for sse-s3 encryption
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Thu, 25 Apr 2024 13:09:17 +0000 (14:09 +0100)]
Merge pull request #56868 from clwluvw/request-payer
rgw: exclude logging of request payer for 403 requests
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Thu, 25 Apr 2024 13:08:06 +0000 (14:08 +0100)]
Merge pull request #56394 from cbodley/wip-rgw-cache-size
rgw: increase default metadata cache size for accounts
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Matan Breizman [Thu, 25 Apr 2024 11:32:49 +0000 (14:32 +0300)]
Merge pull request #56606 from guojidan/num_bytes
crimson/osd/ops_executer: fix snap overlap range error
Reviewed-by: Samuel Just <sjust@redhat.com>
Xuehan Xu [Thu, 25 Apr 2024 06:24:47 +0000 (14:24 +0800)]
crimson/os/seastore: only update onode sizes when necessary
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Rongqi Sun [Thu, 25 Apr 2024 03:07:27 +0000 (20:07 -0700)]
Merge pull request #56942 from Svelar/fix_tox_cephadm
test/cephadm: extend timeout again
Adam King [Wed, 24 Apr 2024 16:02:11 +0000 (12:02 -0400)]
Merge pull request #57057 from adk3798/no-downgrade
doc/cephadm: remove downgrade reference from upgrade docs
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Kefu Chai [Wed, 24 Apr 2024 15:21:31 +0000 (23:21 +0800)]
Merge pull request #56644 from tchaikov/wip-warning-not-fatal
test: do not consider warning from Sanitizer as fatal
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Igor Fedotov [Wed, 24 Apr 2024 14:29:42 +0000 (17:29 +0300)]
Merge pull request #55950 from ifed01/wip-ifed-omap-pcounters
os/bluestore: add omap_set* perf counters
Reviewed-by: akupczyk@ibm.com
Reviewed-by: rfriedma@ibm.com
Anthony D'Atri [Wed, 24 Apr 2024 13:21:27 +0000 (09:21 -0400)]
Merge pull request #57071 from zdover23/wip-doc-2024-04-24-rados-troubleshooting-pg
doc/rados: improve t-shooting pg
Zac Dover [Wed, 24 Apr 2024 11:51:32 +0000 (21:51 +1000)]
Merge pull request #57051 from zdover23/wip-doc-2024-04-23-rados-dual-stack
doc/rados: remove dual-stack docs
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Wed, 24 Apr 2024 11:48:20 +0000 (21:48 +1000)]
doc/rados: improve t-shooting pg
Incorporate Anthony D'Atri's suggestions from
https://github.com/ceph/ceph/pull/57022 into the text in
doc/rados/troubleshooting/troubleshooting-pg.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Ronen Friedman [Wed, 24 Apr 2024 10:59:10 +0000 (13:59 +0300)]
Merge pull request #56745 from ronen-fr/wip-rf-pgtell
tests/scripts: use 'tell pg deep-scrub pgid' instead of 'tell pgid deep-scrub'
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Yuri Weinstein [Tue, 23 Apr 2024 23:35:24 +0000 (16:35 -0700)]
Merge pull request #56420 from rzarzynski/wip-tools-rados-get-with-offset
tools: rados get takes --offset now
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Tue, 23 Apr 2024 23:35:03 +0000 (16:35 -0700)]
Merge pull request #56067 from myoungwon/wip-ceph-dedup-daemon
tool: separating ceph-dedup-tool into tool and daemon
Reviewed-by: Samuel Just <sjust@redhat.com>
Yuri Weinstein [Tue, 23 Apr 2024 23:33:29 +0000 (16:33 -0700)]
Merge pull request #55949 from NitzanMordhai/wip-nitzan-safe-to-destroy-test-build-vars
test/osd/safe-to-destroy.sh: Add checks for the test
Reviewed-by: Samuel Just <sjust@redhat.com>
Laura Flores [Tue, 23 Apr 2024 22:49:04 +0000 (17:49 -0500)]
Merge pull request #54979 from pdvian/wip-mgr-optracker
mgr: integrate optracker in ceph-mgr
Ilya Dryomov [Tue, 23 Apr 2024 19:37:20 +0000 (21:37 +0200)]
Merge pull request #57053 from idryomov/wip-labeler-rbd
.github: sync the list of paths for rbd label with CODEOWNERS
Reviewed-by: Laura Flores <lflores@redhat.com>
Adam King [Tue, 23 Apr 2024 16:04:39 +0000 (12:04 -0400)]
doc/cephadm: remove downgrade reference from upgrade docs
This has been in here for years, but cephadm will block
attempted upgrades to lower versions and we generally
don't want people to think this is supported or safe.
Signed-off-by: Adam King <adking@redhat.com>
Casey Bodley [Tue, 23 Apr 2024 16:34:55 +0000 (17:34 +0100)]
Merge pull request #56986 from cbodley/wip-65551
rgw/account: add bucket_quota to RGWAccountInfo
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Oguzhan Ozmen <oozmen@bloomberg.net>
Adam King [Tue, 23 Apr 2024 15:57:53 +0000 (11:57 -0400)]
Merge pull request #57038 from adk3798/mixin-max-nvme-gws-per-group
monitoring/ceph-mixin: set NVMeoFMaxGatewaysPerGroup to 4
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Casey Bodley [Tue, 23 Apr 2024 13:39:04 +0000 (14:39 +0100)]
Merge pull request #56990 from cbodley/wip-doc-rgw-realm-change
doc/rgw: add release note for changes to rgw_realm init
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Leonid S. Usov [Tue, 23 Apr 2024 12:20:28 +0000 (15:20 +0300)]
Merge pull request #55983 from lxbsz/wip-64572
qa/fsx: use the master branch to build the xfstest-dev
Soumya Koduri [Wed, 10 Apr 2024 19:34:17 +0000 (01:04 +0530)]
rgw/lc: cleanup duplicate code
Cleaning up duplicate code around updating head
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Soumya Koduri [Mon, 25 Mar 2024 18:08:57 +0000 (23:38 +0530)]
rgw/lc: advance head if the current entry doesn't exist
This is extension to https://github.com/ceph/ceph/pull/47595.
When skipping the non-exist LC entry, instead of get_next_entry(),
use advance_head() to fetch the next entry. In case the cycle
is finished for that shard, head should be reset to avoid lc process
being stuck in indefinite loop.
Fixes: https://tracker.ceph.com/issues/65160
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
Ilya Dryomov [Tue, 23 Apr 2024 11:00:08 +0000 (13:00 +0200)]
.github: sync the list of paths for rbd label with CODEOWNERS
With https://github.com/actions/labeler/issues/483 still pending, do it
manually.
A couple of entries matching both files and directories were expanded
since, unlike fnmatch(3), minimatch treats slashes specially:
- src/include/rbd* -> src/include/rbd* src/include/rbd/**
- src/rbd* -> src/rbd* src/rbd*/**
- src/test/rbd* -> src/test/rbd* src/test/rbd*/**
A bunch of entries under src/tools were combined into:
- src/tools/rbd*/**
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Tue, 23 Apr 2024 10:57:49 +0000 (12:57 +0200)]
CODEOWNERS: assign ceph-rbd-mirror systemd service to RBD
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Zac Dover [Tue, 23 Apr 2024 06:37:27 +0000 (16:37 +1000)]
doc/rados: remove dual-stack docs
Remove references to dual-stack mode in
doc/rados/configuration/network-config-ref.rst and
doc/rados/configuration/msgr2.rst. This feature seems to have been
planned but never to have been completely implemented.
See the tracker issue listed below for an email exchange detailing the
confusion caused by the presence in the documentation of this
now-removed information.
Fixes: https://tracker.ceph.com/issues/65631
Signed-off-by: Zac Dover <zac.dover@proton.me>
Rongqi Sun [Wed, 17 Apr 2024 08:02:36 +0000 (08:02 +0000)]
test/cephadm: extend timeout limit again to fix timeout issue
When run make check(arm64) on omani series servers,
Shows:
python: timeout after 60 seconds
INFO root:call_wrappers.py:284 Non-zero exit code 124 from /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/cephadm/.tox/py3/bin/python -c for i in range(
1000000 ): print(i, flush=True)
Seems like 60s is not enough, extend to 300s would be fine.
Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
Gil Bregman [Mon, 22 Apr 2024 21:57:03 +0000 (00:57 +0300)]
Merge pull request #57033 from gbregman/main
mgr/cephadm: Some changes to nvmeof conf file defaults
Patrick Donnelly [Mon, 22 Apr 2024 19:08:11 +0000 (15:08 -0400)]
Merge PR #54067 into main
* refs/pull/54067/head:
mds: add dispatch killpoint and delay configs
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Patrick Donnelly [Mon, 22 Apr 2024 19:07:27 +0000 (15:07 -0400)]
Merge PR #56047 into main
* refs/pull/56047/head:
mgr: process map before notifying clients
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Patrick Donnelly [Mon, 22 Apr 2024 19:05:40 +0000 (15:05 -0400)]
Merge PR #56638 into main
* refs/pull/56638/head:
qa: do not iterate list being modified
qa: remove unnecessary background job cleanup
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Patrick Donnelly [Mon, 22 Apr 2024 19:04:50 +0000 (15:04 -0400)]
Merge PR #56669 into main
* refs/pull/56669/head:
qa: make teardown behavior consistent for kclient/fuse mounts
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Patrick Donnelly [Mon, 22 Apr 2024 19:03:51 +0000 (15:03 -0400)]
Merge PR #56723 into main
* refs/pull/56723/head:
mds: use mds_cache_quiesce_decay_rate to init quiesce_counter
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Patrick Donnelly [Mon, 22 Apr 2024 18:52:48 +0000 (14:52 -0400)]
Merge PR #57010 into main
* refs/pull/57010/head:
qa: update quiesce tests to expect ipolicy lock
mds: add missing policylock to test F_QUIESCE_BLOCK
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Zac Dover [Mon, 22 Apr 2024 14:59:35 +0000 (00:59 +1000)]
Merge pull request #57022 from zdover23/wip-doc-2024-04-22-rados-operations-pg-troubleshooting
doc/rados: remove redundant pg repair commands
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Casey Bodley [Mon, 22 Apr 2024 14:50:01 +0000 (10:50 -0400)]
rgw: apply default quota config on account creation
add new default quota config options for accounts analogous to
rgw_user_default_quota_max_objects/size. apply the default bucket quota
config options as-is
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Anthony D'Atri [Mon, 22 Apr 2024 14:11:33 +0000 (10:11 -0400)]
Merge pull request #57032 from stackhpc/doc-update-ms-bind-port-max
doc/rados: fix outdated value for ms_bind_port_max
Anthony D'Atri [Mon, 22 Apr 2024 14:09:10 +0000 (10:09 -0400)]
Merge pull request #57036 from stackhpc/fix-typo-radosgw-metrics
doc/radosgw: fix typo in metrics.rst
Adam King [Mon, 22 Apr 2024 12:48:15 +0000 (08:48 -0400)]
monitoring/ceph-mixin: set NVMeoFMaxGatewaysPerGroup to 4
Recommendation from the nvmeof team
Signed-off-by: Adam King <adking@redhat.com>
Rixin Luo [Mon, 22 Apr 2024 12:40:27 +0000 (20:40 +0800)]
Merge pull request #56448 from Svelar/arm_pass_check_shard_select
test/test_mempool: skip check_shard_select test on ARM64
Pierre Riteau [Mon, 22 Apr 2024 12:29:19 +0000 (14:29 +0200)]
doc/radosgw: fix typo in metrics.rst
Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Xuehan Xu [Wed, 20 Mar 2024 07:12:28 +0000 (15:12 +0800)]
test/crimson/seastore: add test profile for full integrity check
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Mon, 22 Apr 2024 10:11:55 +0000 (18:11 +0800)]
test/crimson/seastore/test_object_data_handler: remap pins through the
transaction that created the pins
Fixes: https://tracker.ceph.com/issues/65610
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Mon, 22 Apr 2024 10:10:33 +0000 (18:10 +0800)]
crimson/os/seastore/btree: assert that the transaction getting logical
extents from pins are the one that created the pins
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Gil Bregman [Mon, 22 Apr 2024 09:32:15 +0000 (12:32 +0300)]
mgr/cephadm: some changes to nvmeof conf file defaults
Fixes https://tracker.ceph.com/issues/65566
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Gil Bregman [Mon, 22 Apr 2024 09:31:16 +0000 (12:31 +0300)]
python-common/ceph/deployment: some changes to nvmeof conf file defaults
Fixes https://tracker.ceph.com/issues/65566
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Pierre Riteau [Mon, 22 Apr 2024 09:28:53 +0000 (11:28 +0200)]
doc/rados: fix outdated value for ms_bind_port_max
The highest port number used by OSD or MDS daemons was increased from
7300 to 7568 in [1] but the documentation still refers to 7300 in
multiple locations.
[1] https://github.com/ceph/ceph/pull/42210
Fixes: https://tracker.ceph.com/issues/65609
Signed-off-by: Pierre Riteau <pierre@stackhpc.com>
Zac Dover [Mon, 22 Apr 2024 08:05:55 +0000 (18:05 +1000)]
Merge pull request #57016 from zdover23/wip-doc-2024-04-21-rados-operations-crush-map
doc/rados: add bucket rename command
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Mon, 22 Apr 2024 06:59:15 +0000 (16:59 +1000)]
doc/rados: remove redundant pg repair commands
Incorporate the material in /doc/rados/operations/pg-repair into
/doc/rados/troubleshooting/troubleshooting-pg. Remove
/doc/rados/operations/pg-repair from the documentation. Redirect all
links to the old location to the new location.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Zac Dover [Sun, 21 Apr 2024 12:46:18 +0000 (22:46 +1000)]
doc/rados: add bucket rename command
Add "ceph osd crush rename bucket" command. This commit is made in
response to a request from Michele Giacomoli.
Fixes: https://tracker.ceph.com/issues/65599
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Xuehan Xu [Wed, 21 Feb 2024 08:09:59 +0000 (16:09 +0800)]
crimson/os/seastore/transaction_manager: fully load extents when
remapping extents with full extent integrity check enabled
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Wed, 21 Feb 2024 06:50:47 +0000 (14:50 +0800)]
test/crimson/seastore/test_object_data_handler: disable max_extent_size
for remap related cases
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Tue, 20 Feb 2024 10:06:25 +0000 (18:06 +0800)]
test/crimson/seastore/test_transaction_manager: disable max_extent_size for remap related tests
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Wed, 21 Feb 2024 06:53:33 +0000 (14:53 +0800)]
crimson/os/seastore/transaction_manager: add the max_data_allocation_size
configuration
Limit the max size of extents in seastore, which can avoid much read
amplification in case of remapping extents when extents integrity check
is mandatory
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Wed, 21 Feb 2024 06:52:41 +0000 (14:52 +0800)]
crimson/os/seastore/lba_manager: add the alloc_extents interface
This is necessary because continuous data may be splitted into multiple
extents if the size of each data extent is constrained
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Fri, 9 Feb 2024 06:34:03 +0000 (14:34 +0800)]
crimson/os/seastore/lba_manager: clean up lba_manager's alloc_extent related interfaces
Signed-off-by: Xuehan Xu <xxhdx1985126@gmail.com>
Xuehan Xu [Thu, 29 Feb 2024 12:17:33 +0000 (20:17 +0800)]
crimson/os/seastore/cached_extent: rename get_crc32c to calc_crc32c
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Mon, 5 Feb 2024 05:41:17 +0000 (13:41 +0800)]
crimson/os/seastore/transaction_manager: check checksums when loading
logical extents
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Sun, 4 Feb 2024 09:54:26 +0000 (17:54 +0800)]
crimson/os/seastore: record extents' chksums in the lba tree
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Sun, 4 Feb 2024 09:23:18 +0000 (17:23 +0800)]
crimson/os/seastore/transaction: change delayed_alloc_list/pre_alloc_list to CachedExtents
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Yingxin [Mon, 22 Apr 2024 01:41:02 +0000 (09:41 +0800)]
Merge pull request #56353 from myoungwon/wip-apply-shallow-copy-rbm-overwrite
crimson/os/seastore: avoid new allocation when overwriting data in RBM for performance
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Rongqi Sun [Mon, 22 Apr 2024 01:12:49 +0000 (18:12 -0700)]
Merge pull request #56855 from Svelar/asan_osd_types
test/osd/types: free PriorSet::pcontdec memory
Matan Breizman [Sun, 21 Apr 2024 13:17:44 +0000 (16:17 +0300)]
Merge pull request #56025 from xxhdx1985126/wip-seastore-onode-loc-key
crimson/osd/osd_operations/client_requests: we don't support rados locator keys
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Zac Dover [Sun, 21 Apr 2024 12:56:25 +0000 (22:56 +1000)]
Merge pull request #56904 from zdover23/wip-doc-2024-04-16-security-cves
doc/security: update CVE list
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Zac Dover [Mon, 15 Apr 2024 15:41:51 +0000 (01:41 +1000)]
doc/security: update CVE list
Update the list of CVEs in doc/security/cves.rst.
Co-authored-by: Ilya Dryomov <idryomov@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Matan Breizman [Sun, 21 Apr 2024 11:55:33 +0000 (14:55 +0300)]
Merge pull request #56916 from Matan-B/wip-matanb-crimson-recovery-misc
crimson/osd/replicated_backend: misc fixes
Reviewed-by: Samuel Just <sjust@redhat.com>
Matan Breizman [Sun, 21 Apr 2024 11:53:38 +0000 (14:53 +0300)]
Merge pull request #56848 from xxhdx1985126/wip-65453
crimson/osd/recovery_backends: discard outdated recovery ops
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Sun, 21 Apr 2024 09:41:13 +0000 (12:41 +0300)]
Merge pull request #56277 from amathuria/wip-amat-crimson-fix-pool-compression
crimson: Add support for pool compression
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: chunmei-liu <chunmei.liu@intel.com>
Matan Breizman [Sun, 21 Apr 2024 09:40:00 +0000 (12:40 +0300)]
Merge pull request #56611 from Matan-B/wip-matanb-crimson-replicated-peering
crimson/osd/replicated_recovery_backend: prepare_pull use pg_info
Reviewed-by: Samuel Just <sjust@redhat.com>
Matan Breizman [Sun, 21 Apr 2024 09:39:07 +0000 (12:39 +0300)]
Merge pull request #56875 from xxhdx1985126/wip-65474
crimson/osd/osd_meta: load incremental osdmap from "inc_osdmap.XXX"
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Kefu Chai [Sat, 20 Apr 2024 12:37:30 +0000 (20:37 +0800)]
Merge pull request #57012 from tchaikov/wip-python-common-pep8
python-common: PEP8 related cleanups
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Kefu Chai [Mon, 30 Oct 2023 02:33:06 +0000 (10:33 +0800)]
python-common: remove spaces around `=`
to be more PEP8 compliant
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Mon, 30 Oct 2023 02:32:14 +0000 (10:32 +0800)]
python-common: remove trailing spaces
for better readability.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Patrick Donnelly [Fri, 19 Apr 2024 23:32:27 +0000 (19:32 -0400)]
qa: update quiesce tests to expect ipolicy lock
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>