cmake: disable WITH_QATLIB/ZIP on non-x86

This feature is only relevant to x86 hosts.

Signed-off-by: Ken Dreyer <kdreyer@ibm.com>
Fixes: https://tracker.ceph.com/issues/66016
Signed-off-by: Ken Dreyer <kdreyer@ibm.com>
(cherry picked from commit 487cd2fddbab784269af9f48206a130e63f1eca3)

Merge pull request #57316 from Matan-B/wip-56027-squid

squid: doc/dev/crimson: add Code Walkthroughs

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57484 from Matan-B/wip-56534-squid

squid: crimson: introduce INTERNAL_PG_LOCAL_NS, use for snapmapper

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57483 from Matan-B/wip-56378-squid

squid: crimson/osd/osd_operations/snaptrim_event: update PG's stats

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57482 from Matan-B/wip-56246-squid

squid: crimson/os/seastore/btree: check for reserved ptrs when determining children stability

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57481 from Matan-B/wip-55947-squid

squid: crimson/os/seastore: handle OP_COLL_MOVE_RENAME

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57480 from Matan-B/wip-55708-squid

squid: crimson/osd/main: Enable multicore cluster messenger

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57270 from Matan-B/wip-55632-squid

squid: debian/control: add new dependencies protobuf for crismon

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57287 from Matan-B/wip-55751-squid

squid: test/crimson/test_socket: complete write-side errors in test_unexpected_down()

Reviewed-by: Samuel Just <sjust@redhat.com>

common/hobject: make hobject_t formatter methods const

this is an alternative to 6021129f0c5c1c133436e471741c73f6e315c5dd
Since https://github.com/ceph/ceph/pull/55583 is not backported to S.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

crimson/.../scrub_events: use PGBackend::list_objects in ScrubScan::run

Fixes: https://tracker.ceph.com/issues/64975
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit e69883ad2a05afab9d9ab02b098ad2418a4eec8a)

crimson/.../scrub_events: convert ScrubScan::run to coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 0d042f9d18fb191c3c8d6dbbf7c5bae54b8ed0fb)

crimson/.../scrub_events: use PGBackend::list_objects in ScrubFindRange::run

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 9f39124f33e878e321b330e58e97efc0a1cf1242)

crimson/.../scrub_events: convert ScrubFindRange::run to a coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 5b0416ae100443f43361e1308e2d28e2763ba725)

crimson: move snapmapper object into INTERNAL_PG_LOCAL_NS

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 1b7e3c4fb773a6e0a16145114013a07aa85edcc5)

crimson/osd/pg_backend: introduce INTERNAL_PG_LOCAL_NS, skip in PGBackend::list_objects

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit f32b37a599592d35ea948e66e7cfdfef7113b8ac)

crimson/osd/pg_backend: convert PGBackend::list_objects to a coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 4f056a4c1e9f01e4b04c96e85ebcfa29e6469adc)

crimson/osd/pg_backend: generalize PGBackend::list_objects, add overloads

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 22a628534307d35e3fa90fb36a98f81cbf7cb7f6)

crimson/osd/osd_operations/snaptrim_event: update PG's stats

Fixes: https://tracker.ceph.com/issues/63307
Signed-off-by: junxiang Mu <1948535941@qq.com>
(cherry picked from commit 4a180f559a3fff1615664898603fc832cfd8d72c)

crimson/os/seastore/btree: always check the stability of extents within
the current transaction's view

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
(cherry picked from commit 7dcd74ac098201d2ea6f9d1c723f9944ade6bf33)

crimson/os/seastore/cached_extent: add comments to elaborate why
MUTATION_PENDING and under-io extents are "stable"

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
(cherry picked from commit b1c59ca077597e14a053d47d4961b12ba7a2a1b0)

crimson/os/seastore/btree: check for reserved ptrs when determining
children stability

Fixes: https://tracker.ceph.com/issues/64957
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
(cherry picked from commit 7aa972def9f53fd9ed2f708aa87ce83362765cbf)

test/crimson/seastore: add the test case for renaming objects

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
(cherry picked from commit 2520927590ac48783cb35feb570285ec066964a4)

crimson/os/seastore: handle OP_COLL_MOVE_RENAME

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
(cherry picked from commit 70245c5b207eca6349920d1877ea237ec687f93d)

crimson/osd/osd: handle_scrub_message on any core

After enabling multicore cluster messenger, there is no
guarantee which core will handle the request.
See: OSDSingletonState::send_to_osd()

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit cbad3e4517e91476b19a8766f98240c81df40a36)

crimson/osd/main: Enable multicore cluster messenger

Taken from: f78e99c

Co-authored-by: Yingxin Cheng <yingxin.cheng@intel.com>
Co-authored-by: Chunmei Liu <chunmei.liu@intel.com>
Co-authored-by: Xinyu Huang <xinyu.huang@intel.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
(cherry picked from commit ab239ad6cc5eb1cb4ca71d5b409bc4001124342f)

Merge pull request #57347 from Matan-B/wip-56375-squid

squid: crimson/.../scrub_events: fix progress lifetime in deep_scan_object

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57328 from Matan-B/wip-55840-squid

squid: crimson/os/seastore/omap_manager: expand omap tree nodes

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57327 from Matan-B/wip-55887-squid

squid: crimson/os/seastore: omap_get_values with range [start, "infinite") should return all results from "start"

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57325 from Matan-B/wip-55889-squid

squid: crimson/os/seastore/async_cleaner: add comments to clarify what kind of extents would be considered dead by the cleaner

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57321 from Matan-B/wip-55770-squid

squid: CMakeLists: disable Seastar_IO_URING to fix seastar unittest timeout

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57323 from Matan-B/wip-55801-squid

squid: crimson/os/alienstore: use homebrew counting_semaphore

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57320 from Matan-B/wip-56028-squid

squid: crimson/os/seastore: cleanups around lba parent-child pointer

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57317 from Matan-B/wip-55888-squid

squid: crimson/os/seastore: cleanup and use LBAMapping::is_stable()

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57290 from Matan-B/wip-55806-squid

squid: crimson/os/seastore: copy attrs and omaps when cloning objects

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57324 from Matan-B/wip-52267-squid

squid: crimson/osd: put snapmapper's key-value pairs into dedicated objs

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57281 from Matan-B/wip-55684-squid

squid: crimson: fixes for stack-use-after-return on recent clang and gcc versions

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57350 from Matan-B/wip-56217-squid

squid: test/crimson/sesastore/test_block: add constructor to construct

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57349 from Matan-B/wip-56462-squid

squid: crimson/os/seastore: fix use after free error

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57348 from Matan-B/wip-56332-squid

squid: crimson/os/pg_map: allow multiple shards to create new pg mappings at the same time

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57346 from Matan-B/wip-56374-squid

squid: crimson/osd/osd.h: declare osdmap after OSDSingletonState

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57345 from Matan-B/wip-56250-squid

squid: crimson/os/seastore: cache metadata during trimming to prevent from disk read

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57344 from Matan-B/wip-55846-squid

squid: crimson: add coroutine support for errorated and interruptible futures

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57326 from Matan-B/wip-55855-squid

squid: crimson/os/seastore: adjust SeaStore::_omap_set_kvs() params

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57322 from Matan-B/wip-55981-squid

squid: crimson/os/seastore/collection_manager: allow empty-delta-buffer collection nodes

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57315 from Matan-B/wip-55977-squid

squid: crimson/os/seastore: allow to remap the dirty extent

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57314 from Matan-B/wip-55536-squid

squid: osd/SnapMapper: Crimson - fix OSDriver::get_next

Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>

Merge pull request #57312 from Matan-B/wip-55910-squid

squid: osd/SnapManager: Crimson - fix std::string constructed from 0

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57311 from Matan-B/wip-55946-squid

squid: crimson/os/seastore: make less verbose log when testing performance on RBM

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57289 from Matan-B/wip-55772-squid

squid: crimson/os/seastore: two attrs related bug fixes

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57288 from Matan-B/wip-55705-squid

squid: crimson/os/seastore: fix wrong-positioned asserts

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57286 from Matan-B/wip-55407-squid

squid: crimson/osd/shard_services: make sure that only up/acting members can create pgs

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #57283 from Matan-B/wip-55641-squid

squid: crimson/osd/main: Enable multicore client messenger

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #56508 from rosinL/wip-65164-squid

squid: cmake/AddCephTest: bind crimson unittest to different cores

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #57465 from idryomov/wip-51845-squid

squid: qa/suites/krbd: drop pre-single-major and move "layering only" coverage

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #57461 from frittentheke/wip-65838-squid

squid: monitoring/ceph-mixin: Cleanup of variables, queries and tests (to fix showMultiCluster=True)

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

qa/suites/krbd: rename no-object-map to no-exclusive-lock

Exclusive lock has always been disabled by this facet, so it might as
well be reflected in its name.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit ad6a95d8af42b1c3ed9d244c6161e5269356c7c9)

qa/suites/krbd: move "layering only" coverage to fsx

It makes much more sense there since it's where we actually create
clones and flatten them a lot.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 7b9f28e74325aad17c3774d594c3f0e1c4e25dc2)

qa/suites/krbd: drop pre-single-major test

Single-major mapping scheme was introduced in 2014 and became the
default in 2017.  It's getting increasingly difficult to build and,
more importantly, to boot a 10 year old kernel with recent userspace
(systemd, etc).  If someone is still running such a kernel, it's
really unlikely that they would have the most recent rbd CLI tool
installed.

Fixes: https://tracker.ceph.com/issues/51845
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 39a579144cd8b97dd338bfcf36c06ad4bcaed526)

Cleanup of variables, queries and tests to enable showMultiCluster=True

Rendering the dashboards with showMultiCluster=True allows for
them to work with multiple clusters storing their metrics in a single
Prometheus instance. This works via the cluster label and that functionality
already existed. This just fixes some inconsistencies in applying the label
filters.

Additionally this contains updates to the tests to have them succeed with
with both configurations and avoid the introduction of regressions in
regards to multiCluster in the future.

There also are some consistency cleanups here and there:
 * `datasource` was not used consistently
 * `cluster` label_values are determined from `ceph_health_status`
 * `job` template and filters on this label were removed to align multi cluster
    support solely via the `cluster` label
 * `ceph_hosts` filter now uses label_values from any ceph_metadata metrici
    to now show all instance values, but those of hosts with some Ceph
    component / daemon.
 *  Enable showMultiCluster=True since `cluster` label is now always present,
    via https://github.com/ceph/ceph/pull/54964

Improves: https://tracker.ceph.com/issues/64321
Signed-off-by: Christian Rohmann <christian.rohmann@inovex.de>
(cherry picked from commit 090b8e17f1e84d8b20e05143d5dd7ff107031176)

Merge pull request #57426 from zdover23/wip-doc-2024-05-13-backport-57420-to-squid

squid: doc/cephfs: edit fs-volumes.rst (1 of x) followup

doc/cephfs: edit fs-volumes.rst (1 of x) followup

Include the suggestions for improving doc/cephfs/fs-volumes.rst made by
Anthony D'Atri here
https://github.com/ceph/ceph/pull/57415#discussion_r1597362110

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit cb700d804b4390fd9f55444dcfc04dfebac3a1bf)

Merge pull request #57417 from zdover23/wip-doc-2024-05-12-backport-57415-to-squid

squid: doc/cephfs: edit fs-volumes.rst (1 of x)

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #56519 from rhcs-dashboard/wip-65133-squid

squid: mgr/dashboard: add support for NFSv3 exports

Reviewed-by: afreen23 <NOT@FOUND>

Merge pull request #57422 from zdover23/wip-doc-2024-05-12-backport-57421-to-squid

squid: doc/dev: s/to asses/to assess/

doc/dev: s/to asses/to assess/

s/to asses/to assess/ in doc/deve/developer_guide/dash-devel.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 832358b072ec5cb4672de8a7a7aebf10a39fd0e5)

doc/cephfs: edit fs-volumes.rst (1 of x)

Edit doc/cephfs/fs-volumes to the section "FS Subvolumes" (but not
including the section "FS Subvolumes").

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 0acbb278fc712c32334fd7340b887d2865dbfb86)

Merge pull request #57390 from zdover23/wip-doc-2024-05-10-backport-57372-to-squid

squid: doc/cephfs: expand the role of quiesce in consistent backups

Reviewed-by: Cole Mitchell <cole.mitchell@gmail.com>

Merge pull request #57364 from zdover23/wip-doc-2024-05-09-radosgw-bucketpolicy-squid

squid: doc/radosgw: update Squid S3 action list

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #57335 from zdover23/wip-doc-2024-05-08-backport-57298-to-squid

squid: doc/mgr: edit "Overview" in dashboard.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #57295 from zdover23/wip-doc-2024-05-07-backport-57273-to-squid

squid: doc/mgr: edit "Resolve IP address to hostname before redirect"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephfs: expand the role of quiesce in consistent backups

Signed-off-by: Leonid Usov <leonid.usov@ibm.com>
Fixes: https://tracker.ceph.com/issues/65881
(cherry picked from commit 34ec2a4c6a065028d593b1e959600a3ce87541a8)

Merge pull request #57310 from idryomov/wip-65624-squid

squid: pybind/rbd: expose CLONE_FORMAT and FLATTEN image options

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #57307 from idryomov/wip-65487-squid

squid: rbd-mirror: clean up stale pool replayers and callouts better

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #57031 from idryomov/wip-65481-squid

squid: qa: fix krbd_msgr_segments and krbd_rxbounce failing on 8.stream

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #57370 from weirdwiz/wip-65879-squid

squid: exporter: handle exceptions gracefully

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>

exporter: handle exceptions gracefully

ceph exporter crahes, and fails to handle exceptions in
dump_asok_metrics(). add try and catch blocks to handle the exceptions gracefully.

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
(cherry picked from commit e442ee479987f339afdc333582b6b64c66ba6846)

Merge pull request #57303 from ronen-fr/wip-rf-reinstate-q-squid

squid:osd/scrub: reinstate scrub reservation queuing

doc/radosgw: update Squid S3 action list

Update the list of S3 actions supported in the Squid release of Ceph.

Note: The list of S3 actions supported in Squid is not the list of S3
actions supported in Reef or in Quincy.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #57092 from idryomov/wip-65573-squid

squid: librbd: make group and group snapshot IDs more random

Reviewed-by: Mykola Golub <mgolub@suse.com>

Merge pull request #57242 from cbodley/wip-65767-squid

squid: rgw/multisite-notification: retry storing bucket notification attrs for ECANCELED(ConcurrentModification) errors.

Reviewed-by: Krunal Chheda <kchheda3@bloomberg.net>

Merge pull request #57006 from rzarzynski/wip-65185-squid

squid: osd/PGBackend::be_scan_list: only call stat, getattrs once per object

Merge pull request #57300 from cbodley/wip-65821-squid

squid: rgw: fix CompleteMultipart error handling regression

Reviewed-by: Ali Masarwa <amasarwa@redhat.com>

Merge pull request #57104 from soumyakoduri/wip-skoduri-squid

[squid] rgw/lc: advance head if the current entry doesn't exist

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #57231 from galsalomon66/wip-65244-squid

squid: rgw/s3select: s3select response handler refactor

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #57254 from aaSharma14/wip-65790-squid

squid: mgr/dashboard: add prometheus federation config for multi-cluster monitoring

Reviewed-by: Nizamudeen A <nia@redhat.com>

test/crimson/sesastore/test_block: add constructor to construct
non-fully-loaded TestBlocks

Before this commit, all TestBlocks are fully-loaded whether they do have
data or not.

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
(cherry picked from commit 61d7f8821fa06cf48911230228687abdf747dba2)

crimson/os/seastore: fix use after free error

Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
(cherry picked from commit 1b5ca67ef8e9de48221d52b6e46f89aad1a731eb)

crimson/os/pg_map: allow multiple shards to create new pg mappings at the same time

Also:
* Better detections in case of inconsistent racings, such as:
  * The new mapping is creating towards different cores.
  * Mapping creation is racing with its eracing.
  * Multiple shards are erasing the same mapping at the same time.
* Add more logs to debug in case of unexpected issues.

Fixes: https://tracker.ceph.com/issues/64934
Fixes: https://tracker.ceph.com/issues/64009
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit 2422817b7578da44090ea5e2f540c505bbce1412)

crimson/osd/shard_services: fix log

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit de2e66723586d2e9c5fd838e5199547b0d2d5f4f)

crimson/osd/pg_map/PGShardMapping: cleanups

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
(cherry picked from commit b35ed71e23ac5eabfed1c47361ee499bab77cd14)

crimson/.../scrub_events: fix progress lifetime in deep_scan_object

seastar::repeat may or may not move the passed action after the first
invocation, so we can't actually rely on references to variables
captured by value being stable.  Instead, allocate with std::make_unique
and move into a finally lambda.

Fixes: https://tracker.ceph.com/issues/64996
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 3276ad571640bc91fe290832a0001bd96f1f26de)

crimson/osd/osd.h: declare osdmap after OSDSingletonState

Otherwise, destructing the osdmap cached_map_t tries to manipulate
OSDSingletonState::osdmaps after it has already been destroyed.

Fixes: https://tracker.ceph.com/issues/64935
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit b623594c44df1c7d75fa7a8d4e8b90f8829d249f)

crimson/os/seastore: cache metadata during trimming to prevent from disk read

I encountered continous disk reads during trimming even though there are sufficient
cache available, in 4K random write test with RBM (RBD).
This is because metadata is note cached if its source is background transaction
within touch_extent(). So, seastore, including the trimming process,  needs to
constantly retrieve metadata (e.g., BACKREF_LEAF).

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
(cherry picked from commit 7f253ce5aa98018b5b209fd6e062078d151ad567)

crimson/common: add coroutine integration for crimson futures

Adds coroutine machinery for crimson errorated and interruptible futures.

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 1126ec3cf6285abbf6a875ab27daff397f09220b)

crimson/common: expose unsafe_get0 for interruptible errorated futures

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 11698a6da9d518329003a90777b0ef31454d2bfd)

crimson/common: add interruptible_errorator::make_interruptible

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 52800dcee08164f9d17d9d293e01cce173670f63)

crimson/.../errorator: expose get_exception

Useful for intentionally ignoring an exceptional future.  Otherwise,
seastar warns.

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 0afd9fa4326d4e7fe5966347a37623379072fd98)

crimson/common/interruptible_future: add interruptor::future convenience declaration

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 1f152bf9861dd04ace70a62ba8a82c33136b5fb0)

crimson/common: expose set_coroutine for crimson future specializations/wrappers

Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 53c4acde1d6b00ed703a71c3137bee92df4be46a)