]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
13 months agotest/rbd: free remote_journaler in PrepareRemoteImageRequest tests 57609/head
Rongqi Sun [Wed, 22 May 2024 06:47:50 +0000 (06:47 +0000)]
test/rbd: free remote_journaler in PrepareRemoteImageRequest tests

When sanitizer is enabled, unittest_rbd_mirror shows

```
=================================================================
==1377627==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 2 byte(s) in 2 object(s) allocated from:
    #0 0xaaaac462d088 in operator new(unsigned long) (/root/ceph/build/bin/unittest_rbd_mirror+0x30cd088) (BuildId: 054d3b6699c622daad91c7f70e36616220fbd5ad)
    #1 0xaaaac522f13c in rbd::mirror::image_replayer::PrepareRemoteImageRequest<librbd::(anonymous namespace)::MockTestImageCtx>::get_client() /root/ceph/src/tools/rbd_mirror/image_replayer/PrepareRemoteImageRequest.cc:148:24
    #2 0xaaaac522e60c in rbd::mirror::image_replayer::PrepareRemoteImageRequest<librbd::(anonymous namespace)::MockTestImageCtx>::handle_get_mirror_info(int) /root/ceph/src/tools/rbd_mirror/image_replayer/PrepareRemoteImageRequest.cc:120:5
    #3 0xaaaac5232d1c in librbd::util::detail::C_CallbackAdapter<rbd::mirror::image_replayer::PrepareRemoteImageRequest<librbd::(anonymous namespace)::MockTestImageCtx>, &(rbd::mirror::image_replayer::PrepareRemoteImageRequest<librbd::(anonymous namespace)::MockTestImageCtx>::handle_get_mirror_info(int))>::finish(int) /root/ceph/src/librbd/Utils.h:63:5
    #4 0xaaaac4863428 in Context::complete(int) /root/ceph/src/include/Context.h:99:5
    #5 0xaaaac489ac30 in librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()::operator()() const /root/ceph/src/librbd/asio/ContextWQ.h:31:12
    #6 0xaaaac489aaf4 in boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>::operator()() /root/ceph/build/boost/include/boost/asio/detail/bind_handler.hpp:60:5
    #7 0xaaaac489aaac in void boost::asio::asio_handler_invoke<boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()> >(boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>&, ...) /root/ceph/build/boost/include/boost/asio/handler_invoke_hook.hpp:88:3
    #8 0xaaaac489aa4c in void boost_asio_handler_invoke_helpers::invoke<boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>, librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>(boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>&, librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()&) /root/ceph/build/boost/include/boost/asio/detail/handler_invoke_helpers.hpp:54:3
    #9 0xaaaac489a9ec in void boost::asio::detail::asio_handler_invoke<boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>, librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>(boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>&, boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>*) /root/ceph/build/boost/include/boost/asio/detail/bind_handler.hpp:111:3
    #10 0xaaaac4899c00 in void boost_asio_handler_invoke_helpers::invoke<boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>, boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()> >(boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>&, boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>&) /root/ceph/build/boost/include/boost/asio/detail/handler_invoke_helpers.hpp:54:3
    #11 0xaaaac489c814 in boost::asio::detail::executor_op<boost::asio::detail::binder0<librbd::asio::ContextWQ::queue(Context*, int)::'lambda'()>, std::allocator<void>, boost::asio::detail::scheduler_operation>::do_complete(void*, boost::asio::detail::scheduler_operation*, boost::system::error_code const&, unsigned long) /root/ceph/build/boost/include/boost/asio/detail/executor_op.hpp:71:7
    #12 0xaaaac489fb4c in boost::asio::detail::scheduler_operation::complete(void*, boost::system::error_code const&, unsigned long) /root/ceph/build/boost/include/boost/asio/detail/scheduler_operation.hpp:40:5
    #13 0xaaaac489f074 in boost::asio::detail::strand_executor_service::run_ready_handlers(std::shared_ptr<boost::asio::detail::strand_executor_service::strand_impl>&) /root/ceph/build/boost/include/boost/asio/detail/impl/strand_executor_service.ipp:150:8
    #14 0xaaaac489ed2c in boost::asio::detail::strand_executor_service::invoker<boost::asio::io_context::basic_executor_type<std::allocator<void>, 0ul> const, void>::operator()() /root/ceph/build/boost/include/boost/asio/detail/impl/strand_executor_service.hpp:136:5
    #15 0xaaaac489ebd4 in void boost::asio::asio_handler_invoke<boost::asio::detail::strand_executor_service::invoker<boost::asio::io_context::basic_executor_type<std::allocator<void>, 0ul> const, void> >(boost::asio::detail::strand_executor_service::invoker<boost::asio::io_context::basic_executor_type<std::allocator<void>, 0ul> const, void>&, ...) /root/ceph/build/boost/include/boost/asio/handler_invoke_hook.hpp:88:3
    #16 0xaaaac489e284 in void boost_asio_handler_invoke_helpers::invoke<boost::asio::detail::strand_executor_service::invoker<boost::asio::io_context::basic_executor_type<std::allocator<void>, 0ul> const, void>, boost::asio::detail::strand_executor_service::invoker<boost::asio::io_context::basic_executor_type<std::allocator<void>, 0ul> const, void> >(boost::asio::detail::strand_executor_service::invoker<boost::asio::io_context::basic_executor_type<std::allocator<void>, 0ul> const, void>&, boost::asio::detail::strand_executor_service::invoker<boost::asio::io_context::basic_executor_type<std::allocator<void>, 0ul> const, void>&) /root/ceph/build/boost/include/boost/asio/detail/handler_invoke_helpers.hpp:54:3
    #17 0xaaaac48a3e08 in boost::asio::detail::executor_op<boost::asio::detail::strand_executor_service::invoker<boost::asio::io_context::basic_executor_type<std::allocator<void>, 0ul> const, void>, std::allocator<void>, boost::asio::detail::scheduler_operation>::do_complete(void*, boost::asio::detail::scheduler_operation*, boost::system::error_code const&, unsigned long) /root/ceph/build/boost/include/boost/asio/detail/executor_op.hpp:71:7
    #18 0xaaaac489fb4c in boost::asio::detail::scheduler_operation::complete(void*, boost::system::error_code const&, unsigned long) /root/ceph/build/boost/include/boost/asio/detail/scheduler_operation.hpp:40:5
    #19 0xaaaac6766b1c in boost::asio::detail::scheduler::do_run_one(boost::asio::detail::conditionally_enabled_mutex::scoped_lock&, boost::asio::detail::scheduler_thread_info&, boost::system::error_code const&) /root/ceph/build/boost/include/boost/asio/detail/impl/scheduler.ipp:493:12
    #20 0xaaaac67660a4 in boost::asio::detail::scheduler::run(boost::system::error_code&) /root/ceph/build/boost/include/boost/asio/detail/impl/scheduler.ipp:210:10
    #21 0xaaaac7562d48 in boost::asio::io_context::run() /root/ceph/build/boost/include/boost/asio/impl/io_context.ipp:64:24
    #22 0xaaaac7562bcc in ceph::async::io_context_pool::start(short)::'lambda'()::operator()() const /root/ceph/src/common/async/context_pool.h:69:16
    #23 0xaaaac7562b18 in void std::__invoke_impl<void, ceph::async::io_context_pool::start(short)::'lambda'()>(std::__invoke_other, ceph::async::io_context_pool::start(short)::'lambda'()&&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61:14
    #24 0xaaaac7562960 in std::__invoke_result<ceph::async::io_context_pool::start(short)::'lambda'()>::type std::__invoke<ceph::async::io_context_pool::start(short)::'lambda'()>(ceph::async::io_context_pool::start(short)::'lambda'()&&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:96:14
    #25 0xaaaac7562804 in std::invoke_result<ceph::async::io_context_pool::start(short)::'lambda'()>::type std::invoke<ceph::async::io_context_pool::start(short)::'lambda'()>(ceph::async::io_context_pool::start(short)::'lambda'()&&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/functional:97:14
    #26 0xaaaac75627dc in auto std::thread make_named_thread<ceph::async::io_context_pool::start(short)::'lambda'()>(std::basic_string_view<char, std::char_traits<char> >, ceph::async::io_context_pool::start(short)::'lambda'()&&)::'lambda'(ceph::async::io_context_pool::start(short)::'lambda'()&&)::operator()<ceph::async::io_context_pool::start(short)::'lambda'()>(ceph::async::io_context_pool::start(short)::'lambda'()&&) const /root/ceph/src/common/Thread.h:79:10
    #27 0xaaaac7562728 in ceph::async::io_context_pool::start(short)::'lambda'() std::__invoke_impl<void, std::thread make_named_thread<ceph::async::io_context_pool::start(short)::'lambda'()>(std::basic_string_view<char, std::char_traits<char> >, ceph::async::io_context_pool::start(short)::'lambda'()&&)::'lambda'(ceph::async::io_context_pool::start(short)::'lambda'()&&), ceph::async::io_context_pool::start(short)::'lambda'()>(std::__invoke_other, std::thread make_named_thread<ceph::async::io_context_pool::start(short)::'lambda'()>(std::basic_string_view<char, std::char_traits<char> >, ceph::async::io_context_pool::start(short)::'lambda'()&&)::'lambda'(ceph::async::io_context_pool::start(short)::'lambda'()&&)&&, ceph::async::io_context_pool::start(short)::'lambda'()&&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:61:14
    #28 0xaaaac75624ec in std::__invoke_result<ceph::async::io_context_pool::start(short)::'lambda'()>::type std::__invoke<std::thread make_named_thread<ceph::async::io_context_pool::start(short)::'lambda'()>(std::basic_string_view<char, std::char_traits<char> >, ceph::async::io_context_pool::start(short)::'lambda'()&&)::'lambda'(ceph::async::io_context_pool::start(short)::'lambda'()&&), ceph::async::io_context_pool::start(short)::'lambda'()>(ceph::async::io_context_pool::start(short)::'lambda'()&&) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/invoke.h:96:14
    #29 0xaaaac756231c in void std::thread::_Invoker<std::tuple<std::thread make_named_thread<ceph::async::io_context_pool::start(short)::'lambda'()>(std::basic_string_view<char, std::char_traits<char> >, ceph::async::io_context_pool::start(short)::'lambda'()&&)::'lambda'(ceph::async::io_context_pool::start(short)::'lambda'()&&), ceph::async::io_context_pool::start(short)::'lambda'()> >::_M_invoke<0ul, 1ul>(std::_Index_tuple<0ul, 1ul>) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/std_thread.h:259:13

SUMMARY: AddressSanitizer: 2 byte(s) leaked in 2 allocation(s).
```

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
15 months agoMerge pull request #56390 from rhcs-dashboard/rgw-add-system-user
Nizamudeen A [Tue, 26 Mar 2024 07:03:02 +0000 (12:33 +0530)]
Merge pull request #56390 from rhcs-dashboard/rgw-add-system-user

mgr/dashboard: add system users to rgw user form

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56055 from rhcs-dashboard/add-nfsv3-support
Nizamudeen A [Tue, 26 Mar 2024 05:58:15 +0000 (11:28 +0530)]
Merge pull request #56055 from rhcs-dashboard/add-nfsv3-support

mgr/dashboard: add support for NFSv3 exports

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
15 months agoMerge pull request #56332 from cyx1231st/wip-fix-racing-get-or-create-pg-mapping
Yingxin [Tue, 26 Mar 2024 03:41:42 +0000 (11:41 +0800)]
Merge pull request #56332 from cyx1231st/wip-fix-racing-get-or-create-pg-mapping

crimson/os/pg_map: allow multiple shards to create new pg mappings at the same time

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
15 months agoMerge pull request #56455 from tchaikov/wip-test-test_rgw_iam_policy-fix-leak
Kefu Chai [Tue, 26 Mar 2024 02:09:56 +0000 (10:09 +0800)]
Merge pull request #56455 from tchaikov/wip-test-test_rgw_iam_policy-fix-leak

test/rgw/test_rgw_iam_policy: do not increase ref when creating intru…

Reviewed-by: Casey Bodley <cbodley@redhat.com>
15 months agoMerge pull request #55068 from phlogistonjohn/jjm-cephadm-smb-svc-spec
Adam King [Mon, 25 Mar 2024 20:24:54 +0000 (16:24 -0400)]
Merge pull request #55068 from phlogistonjohn/jjm-cephadm-smb-svc-spec

cephadm: add a new SMB service to the mgr module

Reviewed-by: Adam King <adking@redhat.com>
15 months agoMerge pull request #56142 from Matan-B/wip-matanb-fix_hobject_to_str
Yuri Weinstein [Mon, 25 Mar 2024 18:30:45 +0000 (11:30 -0700)]
Merge pull request #56142 from Matan-B/wip-matanb-fix_hobject_to_str

common/hobject: fix hobject_t::to_str()

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
15 months agoMerge pull request #55676 from baergj/cod-for-all-upstream
Yuri Weinstein [Mon, 25 Mar 2024 18:29:46 +0000 (11:29 -0700)]
Merge pull request #55676 from baergj/cod-for-all-upstream

kv/RocksDBStore: Configure compact-on-deletion for all CFs

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
15 months agoMerge pull request #55599 from ifed01/wip-ifed-kill-build-warns
Yuri Weinstein [Mon, 25 Mar 2024 18:28:58 +0000 (11:28 -0700)]
Merge pull request #55599 from ifed01/wip-ifed-kill-build-warns

os/bluestore: eliminate build warnings

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
15 months agoMerge pull request #55562 from Matan-B/wip-matanb-fix-lookup-purged-snaps
Yuri Weinstein [Mon, 25 Mar 2024 18:27:16 +0000 (11:27 -0700)]
Merge pull request #55562 from Matan-B/wip-matanb-fix-lookup-purged-snaps

osd/SnapMapper: fix _lookup_purged_snap

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
15 months agoMerge pull request #55609 from ljflores/wip-telemetry-opt-in-to-new-collection
Laura Flores [Mon, 25 Mar 2024 17:13:43 +0000 (12:13 -0500)]
Merge pull request #55609 from ljflores/wip-telemetry-opt-in-to-new-collection

qa/workunits: opt in to new collection after upgrade from reef to main

15 months agotest/rgw/test_rgw_iam_policy: do not increase ref when creating intrusive_ptr<CephCon... 56455/head
Kefu Chai [Mon, 25 Mar 2024 14:56:28 +0000 (22:56 +0800)]
test/rgw/test_rgw_iam_policy: do not increase ref when creating intrusive_ptr<CephContext>

before this change, we increment the refcount when constructing
`cct` instrusive_ptr, but nobody owns this smart pointer. also,
`CephContext` 's constructor set its refcount to 1. so, when the
test finishes, the refcount is 1, and this leads to a leakage of
the `CephContext` instance. and LeakSanitizer points this out:

```
Indirect leak of 10880000 byte(s) in 1 object(s) allocated from:
    #0 0xaaaac359c7c8 in operator new(unsigned long) (/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/bin/unittest_rgw_iam_policy+0x211c7c8) (BuildId: 060fadb10da261b52fd5757c7b1e9812d34542f1)
    #1 0xffff96f764e4 in __gnu_cxx::new_allocator<ceph::logging::ConcreteEntry>::allocate(unsigned long, void const*) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:127:27
    #2 0xffff96f757cc in std::allocator<ceph::logging::ConcreteEntry>::allocate(unsigned long) /usr/bin/../lib/gcc/aarch64-linux-gnu/11/../../../../include/c++/11/bits/allocator.h:185:32
    #3 0xffff96f757cc in boost::circular_buffer<ceph::logging::ConcreteEntry, std::allocator<ceph::logging::ConcreteEntry> >::allocate(unsigned long) /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/boost/include/boost/circular_buffer/base.hpp:2396:39
    #4 0xffff96f75500 in boost::circular_buffer<ceph::logging::ConcreteEntry, std::allocator<ceph::logging::ConcreteEntry> >::initialize_buffer(unsigned long) /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/boost/include/boost/circular_buffer/base.hpp:2494:18
    #5 0xffff96f6ec4c in boost::circular_buffer<ceph::logging::ConcreteEntry, std::allocator<ceph::logging::ConcreteEntry> >::circular_buffer(unsigned long, std::allocator<ceph::logging::ConcreteEntry> const&) /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/build/boost/include/boost/circular_buffer/base.hpp:1039:9
    #6 0xffff96f63528 in ceph::logging::Log::Log(ceph::logging::SubsystemMap const*) /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/log/Log.cc:53:5
    #7 0xffff96045300 in ceph::common::CephContext::CephContext(unsigned int, ceph::common::CephContext::create_options const&) /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/common/ceph_context.cc:729:16
    #8 0xffff960446ec in ceph::common::CephContext::CephContext(unsigned int, code_environment_t, int) /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/common/ceph_context.cc:697:5
    #9 0xaaaac3629238 in IPPolicyTest::IPPolicyTest() /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/test/rgw/test_rgw_iam_policy.cc:864:15
    #10 0xaaaac3628da0 in IPPolicyTest_MaskedIPOperations_Test::IPPolicyTest_MaskedIPOperations_Test() /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/test/rgw/test_rgw_iam_policy.cc:869:1
    #11 0xaaaac3628d3c in testing::internal::TestFactoryImpl<IPPolicyTest_MaskedIPOperations_Test>::CreateTest() /home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/googletest/googletest/include/gtest/internal/gtest-internal.h:472:44
```

so, in this change, we do not increase the refcount when creating cct.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
15 months agoMerge pull request #56437 from tchaikov/wip-cephcontext-leak-fixes
Kefu Chai [Mon, 25 Mar 2024 14:18:26 +0000 (22:18 +0800)]
Merge pull request #56437 from tchaikov/wip-cephcontext-leak-fixes

test: fix the leakages of `CephContext` identified by LeakSanitizer

Reviewed-by: Casey Bodley <cbodley@redhat.com>
15 months agoMerge pull request #56173 from Matan-B/wip-matanb-clone-overlap-doc
Matan Breizman [Mon, 25 Mar 2024 10:15:22 +0000 (12:15 +0200)]
Merge pull request #56173 from Matan-B/wip-matanb-clone-overlap-doc

doc/dev: osd_internals/snaps.rst: add clone_overlap doc

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>
15 months agoMerge pull request #56357 from rhcs-dashboard/sanitize-users-form
Nizamudeen A [Mon, 25 Mar 2024 10:01:15 +0000 (15:31 +0530)]
Merge pull request #56357 from rhcs-dashboard/sanitize-users-form

mgr/dashboard: sanitize dashboard user creation

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56438 from tchaikov/wip-test-unittest-mem-fix-leak
Kefu Chai [Mon, 25 Mar 2024 07:38:17 +0000 (15:38 +0800)]
Merge pull request #56438 from tchaikov/wip-test-unittest-mem-fix-leak

test/common: do not leak in MemoryIsZeroSmallTest

Reviewed-by: Rongqi Sun <sunrongqi@huawei.com>
15 months agocrimson/os/pg_map: allow multiple shards to create new pg mappings at the same time 56332/head
Yingxin Cheng [Wed, 20 Mar 2024 07:25:33 +0000 (15:25 +0800)]
crimson/os/pg_map: allow multiple shards to create new pg mappings at the same time

Also:
* Better detections in case of inconsistent racings, such as:
  * The new mapping is creating towards different cores.
  * Mapping creation is racing with its eracing.
  * Multiple shards are erasing the same mapping at the same time.
* Add more logs to debug in case of unexpected issues.

Fixes: https://tracker.ceph.com/issues/64934
Fixes: https://tracker.ceph.com/issues/64009
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
15 months agomgr/dashboard: add system users to rgw user form 56390/head
Pedro Gonzalez Gomez [Fri, 22 Mar 2024 14:20:48 +0000 (15:20 +0100)]
mgr/dashboard: add system users to rgw user form

Fixes: https://tracker.ceph.com/issues/65074
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
15 months agoMerge PR #56276 into main
Venky Shankar [Mon, 25 Mar 2024 04:57:42 +0000 (10:27 +0530)]
Merge PR #56276 into main

* refs/pull/56276/head:
MDS metrics typo fix

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agoMerge PR #56293 into main
Venky Shankar [Mon, 25 Mar 2024 04:51:58 +0000 (10:21 +0530)]
Merge PR #56293 into main

* refs/pull/56293/head:
qa/suites/fs: link in pg_health ignorelist
qa/cephfs: add probabilistic ignorelist for pg_health

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
15 months agoMerge pull request #56164 from rhcs-dashboard/wip-64890-main
Nizamudeen A [Mon, 25 Mar 2024 04:49:40 +0000 (10:19 +0530)]
Merge pull request #56164 from rhcs-dashboard/wip-64890-main

mgr/dashboard: fix NVMeoF API

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56295 from rhcs-dashboard/cpu-usage-rm-danger-indicator
Nizamudeen A [Mon, 25 Mar 2024 04:46:09 +0000 (10:16 +0530)]
Merge pull request #56295 from rhcs-dashboard/cpu-usage-rm-danger-indicator

mgr/dashboard: rm warning/error threshold for cpu usage

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: ivoalmeida <NOT@FOUND>
15 months agoMerge pull request #56297 from rhcs-dashboard/grafana-issue-multi-cluster
Nizamudeen A [Mon, 25 Mar 2024 04:44:44 +0000 (10:14 +0530)]
Merge pull request #56297 from rhcs-dashboard/grafana-issue-multi-cluster

mgr/dashboard: update grafana api url when switching cluster

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
15 months agotest/common: do not leak in MemoryIsZeroSmallTest 56438/head
Kefu Chai [Mon, 25 Mar 2024 03:19:35 +0000 (11:19 +0800)]
test/common: do not leak in MemoryIsZeroSmallTest

before this change, we allocate memory chunks with specified
size using `new []`, but we never free them. when testing with
LeakSanitizer enabled, it rightly points identifies the leakage:

```
Direct leak of 8754 byte(s) in 184 object(s) allocated from:
    #0 0x55c0b2470f0d in operator new[](unsigned long) (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_memory+0x196f0d) (BuildId: d3267dd8819427b804c4729e0467dbe7601fb321)
    #1 0x55c0b247456c in MemoryIsZeroSmallTest_MemoryIsZeroTestSmall_Test::TestBody() /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/common/test_memory.cc:33:18
    #2 0x55c0b2598ee6 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2605:10
    #3 0x55c0b2553b92 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2641:14
    #4 0x55c0b25049dc in testing::Test::Run() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2680:5
    #5 0x55c0b2506a12 in testing::TestInfo::Run() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2858:11
    #6 0x55c0b250804b in testing::TestSuite::Run() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:3012:28
    #7 0x55c0b25254d8 in testing::internal::UnitTestImpl::RunAllTests() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:5723:44
    #8 0x55c0b25a16f6 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2605:10
    #9 0x55c0b255a502 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2641:14
    #10 0x55c0b2524862 in testing::UnitTest::Run() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:5306:10
    #11 0x55c0b24ab4c0 in RUN_ALL_TESTS() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/include/gtest/gtest.h:2486:46
    #12 0x55c0b24ab451 in main /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googlemock/src/gmock_main.cc:70:10
    #13 0x7f45e065ad8f in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16
```

in this change, we free the allocate memory.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
15 months agotest/common: avoid leakage of CephContext 56437/head
Kefu Chai [Sun, 24 Mar 2024 23:43:26 +0000 (07:43 +0800)]
test/common: avoid leakage of CephContext

before this change, in test_util.cc, we increment the refcount of
when constructing it. but at that moment, nobody really owns it.
also, `CephContext` 's refcount is set to 1 in its constructor.
so, we should not do this. otherwise, the created `CephContext`
is leaked as LeakSanitizer rightly points out:
```
Indirect leak of 10880000 byte(s) in 1 object(s) allocated from:
    #0 0x5632320d27ed in operator new(unsigned long) (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_util+0x1917ed) (BuildId: ff1df1455bd07b651ad580584a17ea204afeb36e)
    #1 0x7ff9d535b189 in __gnu_cxx::new_allocator<ceph::logging::ConcreteEntry>::allocate(unsigned long, void const*) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:127:27
    #2 0x7ff9d535a563 in std::allocator<ceph::logging::ConcreteEntry>::allocate(unsigned long) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/allocator.h:185:32
    #3 0x7ff9d535a563 in boost::circular_buffer<ceph::logging::ConcreteEntry, std::allocator<ceph::logging::ConcreteEntry> >::allocate(unsigned long) /opt/ceph/include/boost/circular_buffer/base.hpp:2396:39
    #4 0x7ff9d535a2c0 in boost::circular_buffer<ceph::logging::ConcreteEntry, std::allocator<ceph::logging::ConcreteEntry> >::initialize_buffer(unsigned long) /opt/ceph/include/boost/circular_buffer/base.hpp:2494:18
    #5 0x7ff9d5354192 in boost::circular_buffer<ceph::logging::ConcreteEntry, std::allocator<ceph::logging::ConcreteEntry> >::circular_buffer(unsigned long, std::allocator<ceph::logging::ConcreteEntry> const&) /opt/ceph/include/boost/circular_buffer/base.hpp:1039:9
    #6 0x7ff9d53471e4 in ceph::logging::Log::Log(ceph::logging::SubsystemMap const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/log/Log.cc:53:5
    #7 0x7ff9d461d96d in ceph::common::CephContext::CephContext(unsigned int, ceph::common::CephContext::create_options const&) /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/ceph_context.cc:729:16
    #8 0x7ff9d461c93b in ceph::common::CephContext::CephContext(unsigned int, code_environment_t, int) /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/ceph_context.cc:697:5
    #9 0x5632320d52e0 in util_collect_sys_info_Test::TestBody() /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/common/test_util.cc:34:27
    #10 0x563232205c16 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2605:10
    #11 0x5632321c2742 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2641:14
    #12 0x5632321736dc in testing::Test::Run() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2680:5
```
in this change, instead of using a raw pointer, let's
use `boost::intrusive_ptr<CephContext>` to manage the lifecyle
of `CephContext`, this also address the leakage reported by
LeakSanitizer.

the same applies to common/test_context.cc

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
15 months agotest: do not increase ref when creating intrusive_ptr<CephContext>
Kefu Chai [Sun, 24 Mar 2024 23:37:58 +0000 (07:37 +0800)]
test: do not increase ref when creating intrusive_ptr<CephContext>

before this change, we increment the refcount when constructing
`cct` instrusive_ptr, but nobody owns this smart pointer. also,
`CephContext` 's constructor set its refcount to 1. so, when the
test finishes, the refcount is 1, and this leads to a leakage of
the `CephContext` instance, this not only annoys ASan, and defeats
the purpose of 14d878c8.
```
Indirect leak of 10880000 byte(s) in 1 object(s) allocated from:
    #0 0x5564d173537d in operator new(unsigned long) (/home/jenkins-build/build/workspace/ceph-pull-requests/build/bin/unittest_ipaddr+0x19b37d) (BuildId: 45c0c7f28b253c04fcb7bb1a43aed52a5526d734)
    #1 0x7fe7f2ccd189 in __gnu_cxx::new_allocator<ceph::logging::ConcreteEntry>::allocate(unsigned long, void const*) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:127:27
    #2 0x7fe7f2ccc563 in std::allocator<ceph::logging::ConcreteEntry>::allocate(unsigned long) /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/allocator.h:185:32
    #3 0x7fe7f2ccc563 in boost::circular_buffer<ceph::logging::ConcreteEntry, std::allocator<ceph::logging::ConcreteEntry> >::allocate(unsigned long) /opt/ceph/include/boost/circular_buffer/base.hpp:2396:39
    #4 0x7fe7f2ccc2c0 in boost::circular_buffer<ceph::logging::ConcreteEntry, std::allocator<ceph::logging::ConcreteEntry> >::initialize_buffer(unsigned long) /opt/ceph/include/boost/circular_buffer/base.hpp:2494:18
    #5 0x7fe7f2cc6192 in boost::circular_buffer<ceph::logging::ConcreteEntry, std::allocator<ceph::logging::ConcreteEntry> >::circular_buffer(unsigned long, std::allocator<ceph::logging::ConcreteEntry> const&) /opt/ceph/include/boost/circular_buffer/base.hpp:1039:9
    #6 0x7fe7f2cb91e4 in ceph::logging::Log::Log(ceph::logging::SubsystemMap const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/log/Log.cc:53:5
    #7 0x7fe7f1f8f96d in ceph::common::CephContext::CephContext(unsigned int, ceph::common::CephContext::create_options const&) /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/ceph_context.cc:729:16
    #8 0x7fe7f1f8e93b in ceph::common::CephContext::CephContext(unsigned int, code_environment_t, int) /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/ceph_context.cc:697:5
    #9 0x5564d1752eb9 in pick_address_find_ip_in_subnet_list_Test::TestBody() /home/jenkins-build/build/workspace/ceph-pull-requests/src/test/test_ipaddr.cc:706:47
    #10 0x5564d18694d6 in void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2605:10
    #11 0x5564d1820fc2 in void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, void (testing::Test::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2641:14
    #12 0x5564d17d19dc in testing::Test::Run() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2680:5
    #13 0x5564d17d3a12 in testing::TestInfo::Run() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2858:11
    #14 0x5564d17d504b in testing::TestSuite::Run() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:3012:28
    #15 0x5564d17f24d8 in testing::internal::UnitTestImpl::RunAllTests() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:5723:44
    #16 0x5564d1871d06 in bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2605:10
    #17 0x5564d1827932 in bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, bool (testing::internal::UnitTestImpl::*)(), char const*) /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:2641:14
    #18 0x5564d17f1862 in testing::UnitTest::Run() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:5306:10
    #19 0x5564d1775d80 in RUN_ALL_TESTS() /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/include/gtest/gtest.h:2486:46
    #20 0x5564d1775d11 in main /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googlemock/src/gmock_main.cc:70:10
```

so, in this change, we do not increase the refcount when
creating cct.

the same applies to `test/common/test_fault_injector.cc`.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
15 months agoMerge pull request #56287 from rzarzynski/wip-ec-profile-set-paranoid-on-override
Zac Dover [Sun, 24 Mar 2024 20:57:30 +0000 (06:57 +1000)]
Merge pull request #56287 from rzarzynski/wip-ec-profile-set-paranoid-on-override

mon, doc: overriding ec profile requires --yes-i-really-mean-it

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
15 months agodoc/dev: osd_internals/snaps.rst: add clone_overlap doc 56173/head
Matan Breizman [Wed, 13 Mar 2024 14:19:59 +0000 (14:19 +0000)]
doc/dev: osd_internals/snaps.rst: add clone_overlap doc

snapdir concept was removed in: https://github.com/ceph/ceph/pull/17579

Co-authored-by: Zac Dover <zac.dover@proton.me>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
15 months agoMerge pull request #56367 from zdover23/wip-doc-2024-03-21-intro-mds
Zac Dover [Sun, 24 Mar 2024 07:27:20 +0000 (17:27 +1000)]
Merge pull request #56367 from zdover23/wip-doc-2024-03-21-intro-mds

doc/start: improve MDS explanation

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agoMerge pull request #56375 from athanatos/sjust/wip-64996-deepscrub-crash
Samuel Just [Sun, 24 Mar 2024 02:42:51 +0000 (19:42 -0700)]
Merge pull request #56375 from athanatos/sjust/wip-64996-deepscrub-crash

crimson/.../scrub_events: fix progress lifetime in deep_scan_object

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
15 months agoMerge PR #56354 into main
Patrick Donnelly [Sat, 23 Mar 2024 13:02:43 +0000 (09:02 -0400)]
Merge PR #56354 into main

* refs/pull/56354/head:
qa/suites/fs/workload: enable snap_schedule early

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
15 months agomgr/dashboard: sanitize dashboard user creation 56357/head
Pedro Gonzalez Gomez [Thu, 21 Mar 2024 07:56:58 +0000 (08:56 +0100)]
mgr/dashboard: sanitize dashboard user creation

Fixes: https://tracker.ceph.com/issues/65030
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
15 months agoMerge PR #56296 into main
Patrick Donnelly [Fri, 22 Mar 2024 17:54:04 +0000 (13:54 -0400)]
Merge PR #56296 into main

* refs/pull/56296/head:
qa/cephfs: add mgr debugging

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agomgr/dashboard: fix NVMeoF API 56164/head
Ernesto Puerta [Wed, 13 Mar 2024 13:06:10 +0000 (14:06 +0100)]
mgr/dashboard: fix NVMeoF API

* Update NVMe-oF gRPC Proto to 1.0.0
* Error handling,
* Missing PATCH for certain namespace ops (resize, set QoS, set balance
  groups),
* Stop bypassing gRPC payloads and validate those in the back-end,
* Fix incorrect HTTP 1.1 semantics for some POST/DELETE and URIs.
* Catch errors/exceptions.
* Clean-up EndpointDoc Params
* Run Black linter.
* Remove most of NVMeoFClient glue code between gRPC and controller.
* Fix namespace delete endpoint by exposing trsvcid
* nvmeof io_stats support

Fixes: https://tracker.ceph.com/issues/64890
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
15 months agoMerge pull request #56374 from athanatos/sjust/wip-64935-osd-osdmap-destruction-order
Samuel Just [Fri, 22 Mar 2024 17:49:47 +0000 (10:49 -0700)]
Merge pull request #56374 from athanatos/sjust/wip-64935-osd-osdmap-destruction-order

crimson/osd/osd.h: declare osdmap after OSDSingletonState

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
15 months agoqa/suites/fs/workload: enable snap_schedule early 56354/head
Patrick Donnelly [Thu, 21 Mar 2024 01:52:11 +0000 (21:52 -0400)]
qa/suites/fs/workload: enable snap_schedule early

Otherwise it can cause client evictions when the volumes plugin has mounted
cephfs.

Fixes: https://tracker.ceph.com/issues/64988
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoMerge pull request #56377 from zdover23/wip-doc-2024-03-22-start-intro-mon-map
Zac Dover [Fri, 22 Mar 2024 16:16:51 +0000 (02:16 +1000)]
Merge pull request #56377 from zdover23/wip-doc-2024-03-22-start-intro-mon-map

doc/start: link to mon map command

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
15 months agoMerge PR #56271 into main
Patrick Donnelly [Fri, 22 Mar 2024 15:56:08 +0000 (11:56 -0400)]
Merge PR #56271 into main

* refs/pull/56271/head:
qa/cephfs: stop ignoring MON_DOWN globally
qa: extend mon timeout coming up after mondb creation
qa: update dashboard schema for mon_status
mon: do not log MON_DOWN if monitor uptime is less than threshold

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agoMerge pull request #56053 from rhcs-dashboard/delete-bucket-notification
Nizamudeen A [Fri, 22 Mar 2024 15:28:40 +0000 (20:58 +0530)]
Merge pull request #56053 from rhcs-dashboard/delete-bucket-notification

mgr/dashboard: add a notification when deleting rgw bucket

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56335 from ivoalmeida/snapshot-schedule-show-subvolume-path
Ivo Almeida [Fri, 22 Mar 2024 15:27:03 +0000 (15:27 +0000)]
Merge pull request #56335 from ivoalmeida/snapshot-schedule-show-subvolume-path

Snapshot schedule show subvolume path

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoqa/suites/fs: link in pg_health ignorelist 56293/head
Patrick Donnelly [Tue, 19 Mar 2024 14:19:15 +0000 (10:19 -0400)]
qa/suites/fs: link in pg_health ignorelist

Fixes: https://tracker.ceph.com/issues/64984
Related-to: https://tracker.ceph.com/issues/52624
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoqa/cephfs: add probabilistic ignorelist for pg_health
Patrick Donnelly [Tue, 19 Mar 2024 13:56:20 +0000 (09:56 -0400)]
qa/cephfs: add probabilistic ignorelist for pg_health

PG_AVAILABILITY/PG_DEGRADED warnings are dominating fs runs. We want the
underlying issue fixed but it cannot continue to fail all of our tests 100% of
the time. Use a probabilistic addition of these warnings to the ignorelist.

Fixes: https://tracker.ceph.com/issues/64984
Related-to: https://tracker.ceph.com/issues/52624
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agomgr/dashboard: show full subvol path snap schedule 56335/head
Ivo Almeida [Wed, 20 Mar 2024 10:35:52 +0000 (10:35 +0000)]
mgr/dashboard: show full subvol path snap schedule

Show full subvolume path when adding snap schedule

Fixes: https://tracker.ceph.com/issues/65000
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
15 months agoMerge pull request #56337 from ronen-fr/wip-rf-qslow
Ronen Friedman [Fri, 22 Mar 2024 10:50:21 +0000 (12:50 +0200)]
Merge pull request #56337 from ronen-fr/wip-rf-qslow

osd/scrub: no "slow response" warning for queued reservations

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
15 months agoMerge pull request #56372 from ivoalmeida/fix-edit-subvolume-group-size
Ivo Almeida [Fri, 22 Mar 2024 09:40:02 +0000 (09:40 +0000)]
Merge pull request #56372 from ivoalmeida/fix-edit-subvolume-group-size

mgr/dashboard: fix subvolume group edit size

Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agomgr/dashboard: update grafana api url when switching cluster 56297/head
Nizamudeen A [Tue, 19 Mar 2024 15:09:09 +0000 (20:39 +0530)]
mgr/dashboard: update grafana api url when switching cluster

do a force refresh on the settings service so it picks up the new api
url of grafana

Fixes: https://tracker.ceph.com/issues/65052
Signed-off-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #55953 from afreen23/wip-pg-targets
Nizamudeen A [Fri, 22 Mar 2024 08:34:03 +0000 (14:04 +0530)]
Merge pull request #55953 from afreen23/wip-pg-targets

mgr/dashboard: Mark placement targets as non-required

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agomgr/dashboard: add a notification when deleting rgw bucket 56053/head
Pedro Gonzalez Gomez [Fri, 8 Mar 2024 05:40:16 +0000 (06:40 +0100)]
mgr/dashboard: add a notification when deleting rgw bucket

Fixes: https://tracker.ceph.com/issues/64855
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
15 months agoMerge PR #54581 into main
Venky Shankar [Fri, 22 Mar 2024 07:24:29 +0000 (12:54 +0530)]
Merge PR #54581 into main

* refs/pull/54581/head:
doc/dev: update quiesce developer document
qa: wrap quiesce verification to dump debugging on error
qa: update quiesce tests for control via locallock
qa: set archive path in vstart_runner
qa: refactor CephFSMount.kill_background to optionally kill all background jobs
qa: use kwarg for rank parameter
qa: simplify calls to (rank|mds)_(tell|asok)
Revert "pybind/mgr/volumes: block quiesce for critical .meta file"
mds: remove is_root indication on quiesce_inode op
mds: prevent new lock cache cons when invalidating an existing one
mds: use XLOCK_WAIT For local lock xlockers
mds: prevent new wrlocks on LocalLock if there exists any xlock waiter
mds: block import discover when parent directory inode is quiesced
mds: avoid issuing exclusive caps to clients lacking w caps
mds: print lock cache during invalidation
mds: use inodeno_t to track quiesce requests
mds: dispatch quiesce_inode ops after dir traversal
mds: remove quiescelock handling for SimpleLock type
mds: quiescelock as local lock + cap masking
qa: run quiesce unit tests in fs:functional
qa: add quiesce protocol unit tests
qa: detect partial migrations during large config of dist epin
qa: use stdin-killer to timeout run_shell_payload
qa: simplify run_shell argument processing
doc: add dev docs for quiesce protocol
pybind/mgr/volumes: block quiesce for critical .meta file
mds: add vxattr to block quiesce on an inode
mds: convert encoded ephemeral dist pin to flags
mds: add counter to throttle quiesce
mds: add quiesce set feature flag
mds: skip non-head inodes for quiesce
mds: add quiesce op
mds: print all SimpleLock flags in debug output
mds: pretty print mutation when dumping lock
mds: add new inode quiescelock
mds: use 128 bits for waiters on MDSCacheObject
mds: provide mechanism to authpin while freezing
mds: add command to get specific op
mds: finish request before completing internal req
mds: complete internal op if killed
mds: avoid killing dead requests
mds: add command to kill request
mds: add path argument to `ops` and `dump tree` to stream result to local file
mds: print internal_request filepaths if present
mds: add more information to debug message
mds: remove redundant parenthesis
mds: implement Mutation::dump method
mds: make LockType fields const
mds: annotate mdr with try_rdlock_snap_layout failure
mds: refactor if into switch
mds: call Locker method using this
mds: simplify assert
mds: dump locks passed to Locker::acquire_locks
mds: add LockOp::print method for debugging
mds: use new insert template via print
mds: add request result to mutation for analysis by tests
mds: add comment on locking order rules
mds: allow specifying rdlock position
mds: remove dead method
common: provide a template for object dumps
common: support long running ops without slow warnings
common: simplify loop
common: add JSONFormatterFile class
common: use more efficient vector for stack
include: use larger int for large gathers

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
15 months agoMerge PR #56219 into main
Venky Shankar [Fri, 22 Mar 2024 07:21:33 +0000 (12:51 +0530)]
Merge PR #56219 into main

* refs/pull/56219/head:
qa: change log-whitelist to log-ignorelist

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
15 months agoMerge PR #56245 into main
Venky Shankar [Fri, 22 Mar 2024 07:20:11 +0000 (12:50 +0530)]
Merge PR #56245 into main

* refs/pull/56245/head:
mds/quiesce-db: always clear the db if a membership is lost

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
15 months agoMerge pull request #56298 from batrick/i64986
Venky Shankar [Fri, 22 Mar 2024 07:16:58 +0000 (12:46 +0530)]
Merge pull request #56298 from batrick/i64986

qa/cephfs: ignorelist clog of MDS_UP_LESS_THAN_MAX

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agoMerge PR #56299 into main
Venky Shankar [Fri, 22 Mar 2024 07:15:10 +0000 (12:45 +0530)]
Merge PR #56299 into main

* refs/pull/56299/head:
qa/suites/fs/nfs: use standard health ignorelist

Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agoMerge pull request #56054 from rhcs-dashboard/open-swagger-new-tab
Nizamudeen A [Fri, 22 Mar 2024 06:12:06 +0000 (11:42 +0530)]
Merge pull request #56054 from rhcs-dashboard/open-swagger-new-tab

mgr/dashboard: open api swagger in new tab

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
15 months agoMerge pull request #56379 from Svelar/doc_oE
Rongqi Sun [Fri, 22 Mar 2024 05:56:29 +0000 (13:56 +0800)]
Merge pull request #56379 from Svelar/doc_oE

doc/install: fix typos in openEuler-installation doc

15 months agoMerge pull request #56246 from xxhdx1985126/wip-64957
Yingxin [Fri, 22 Mar 2024 05:56:03 +0000 (13:56 +0800)]
Merge pull request #56246 from xxhdx1985126/wip-64957

crimson/os/seastore/btree: check for reserved ptrs when determining children stability

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Chunmei Liu <chunmei.liu@intel.com>
15 months agoMerge pull request #56237 from rhcs-dashboard/store-token-in-cookie
Nizamudeen A [Fri, 22 Mar 2024 05:54:28 +0000 (11:24 +0530)]
Merge pull request #56237 from rhcs-dashboard/store-token-in-cookie

mgr/dashboard: securely store remote cluster token

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
15 months agocrimson/os/seastore/btree: always check the stability of extents within 56246/head
Xuehan Xu [Thu, 21 Mar 2024 01:54:42 +0000 (09:54 +0800)]
crimson/os/seastore/btree: always check the stability of extents within
the current transaction's view

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
15 months agodoc/install: fix typos in openEuler-installation doc 56379/head
Rongqi Sun [Fri, 22 Mar 2024 03:12:09 +0000 (03:12 +0000)]
doc/install: fix typos in openEuler-installation doc

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
15 months agoqa/suites/orch: add minimal smb non-AD test 55068/head
Shachar Sharon [Wed, 13 Mar 2024 14:43:29 +0000 (16:43 +0200)]
qa/suites/orch: add minimal smb non-AD test

Test minimal SMB deployment over CephFS, using local users (non-AD).
Upon successful deployment run minima smbclient command ('ls') to probe
Samba's share liveness.

Co-authored-by: John Mulligan <jmulligan@redhat.com>
Signed-off-by: Shachar Sharon <ssharon@redhat.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agoqa/tasks: add a cephadm samba container helper func independent of AD DC
John Mulligan [Fri, 15 Mar 2024 17:48:35 +0000 (13:48 -0400)]
qa/tasks: add a cephadm samba container helper func independent of AD DC

To have the standalone (non-AD) server test function similarly to the AD
member server test we need to set a variable for samba client container
command similar to how the AD setup command does it.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agoqa/suites/orch: add a new smb service cephadm sub-suite and test
John Mulligan [Sat, 24 Feb 2024 15:52:53 +0000 (10:52 -0500)]
qa/suites/orch: add a new smb service cephadm sub-suite and test

Start a new subdir under cephadm suite for the new smb service
that cephadm can deploy. Add one new test that checks that a
smb service with domain membership can be deployed and connect
to it with smbclient from the samba client container image.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agoqa/tasks: add error condition to exec functions
John Mulligan [Tue, 27 Feb 2024 14:48:25 +0000 (09:48 -0500)]
qa/tasks: add error condition to exec functions

Looking at the code that expands `all-roles` and `all-hosts` there's no
proper error checking for when these values appear but there are >1
top-level roles in the task config. If a user does this it'll fail
but in a somewhat unclear manner. Add a new condition that raises a
clear exception in this case hopefully saving someone future debugging
time.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agoqa/tasks: reduce duplicated code
John Mulligan [Tue, 27 Feb 2024 14:44:51 +0000 (09:44 -0500)]
qa/tasks: reduce duplicated code

All `exec`-style function in teuthology appear to have a transformation
block that expands names like `all-roles` and `all-hosts`. With the new
cephadm.exec task that block appeared twice in cephadm.py. This change
removes the duplication by creating an _expand_roles function that
can be called from the command executing functions.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agoqa/tasks: add a template filter to map a role name to a remote
John Mulligan [Mon, 26 Feb 2024 21:17:22 +0000 (16:17 -0500)]
qa/tasks: add a template filter to map a role name to a remote

Add a `role_to_remote` template filter function that has the ability to
map a role name to a remote. Attributes of the remote can then be
used to get the actual node ip or name.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agoqa/tasks: a new cephadm exec task similar to vip.exec but generalized
John Mulligan [Mon, 26 Feb 2024 21:16:57 +0000 (16:16 -0500)]
qa/tasks: a new cephadm exec task similar to vip.exec but generalized

Add a new cephadm.exec task that works similarly to the existing
vip.exec but instead of only considering VIP related string replacements
it uses that templating feature that was recently added to the
cephadm module for generalized string templating.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agoqa/tasks: add a cephadm.exclude role
John Mulligan [Mon, 26 Feb 2024 18:47:04 +0000 (13:47 -0500)]
qa/tasks: add a cephadm.exclude role

Add a cephadm.exclude role that excludes a test node from cluster setup
and related commands. I need this as I have  test node that will be set
up as an AD Domain Controller for testing Samba and do not want that
node to be have *any* other services running on it.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agoqa/tasks: allow passing stdin string to cephadm shell commands
John Mulligan [Sat, 24 Feb 2024 19:26:36 +0000 (14:26 -0500)]
qa/tasks: allow passing stdin string to cephadm shell commands

There are cases where I want to pass some large-ish strings to ceph
commands executed via cephadm shell. Allow items within the commands
list to be dicts containing a command (as before) and an optional
stdin variable. This change also supports possible future extensions as
well.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agoqa/tasks: add a new cephadm task for setting up samba ad dc
John Mulligan [Tue, 20 Feb 2024 23:28:58 +0000 (18:28 -0500)]
qa/tasks: add a new cephadm task for setting up samba ad dc

Add a new task function to cephadm.py that sets up a container running
the Samba based domain controller on a node using podman or docker.
Much of the function actually deals with disabling systemd-resolved
because that service conflicts with the DNS server component of the DC.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agodoc/cephadm: add a file documenting the smb service
John Mulligan [Sat, 10 Feb 2024 14:06:53 +0000 (09:06 -0500)]
doc/cephadm: add a file documenting the smb service

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agomgr/cephadm: add some tests for the new smb service
John Mulligan [Thu, 14 Dec 2023 00:36:46 +0000 (19:36 -0500)]
mgr/cephadm: add some tests for the new smb service

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agomgr/cephadm: simplify _get_container_image a bit
John Mulligan [Fri, 5 Jan 2024 15:45:08 +0000 (10:45 -0500)]
mgr/cephadm: simplify _get_container_image a bit

Because the "if-ladder" was only ever assigning a single variable with
a value it can be directly replaced by a dict & dict-lookup which is
much more succinct.
Also take the opportunity to sort the (non-comment) lines as there's
no meaning to the previous order and this makes it easier for a reader
to scan through.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agomgr/cephadm: add the samba container image for smb daemons
John Mulligan [Fri, 15 Dec 2023 18:15:19 +0000 (13:15 -0500)]
mgr/cephadm: add the samba container image for smb daemons

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agomgr/cepahdm: add various touch points to enable smb service
John Mulligan [Thu, 4 Jan 2024 21:38:08 +0000 (16:38 -0500)]
mgr/cepahdm: add various touch points to enable smb service

Add the smb service by name or by type to one of the many, many touch
points in the orchestrator and cephadm packages needed to get the
orchestrator aware of smb.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agomgr/cephadm: add a new smb ceph service subclass
John Mulligan [Wed, 13 Dec 2023 21:10:11 +0000 (16:10 -0500)]
mgr/cephadm: add a new smb ceph service subclass

Will be used in a later commit to implement deploying smb instances.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agopython-common: define a new SMBSpec service spec type
John Mulligan [Wed, 13 Dec 2023 21:10:37 +0000 (16:10 -0500)]
python-common: define a new SMBSpec service spec type

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agopython-common: reformat ServiceSpec class level service type lists
John Mulligan [Thu, 14 Dec 2023 00:20:45 +0000 (19:20 -0500)]
python-common: reformat ServiceSpec class level service type lists

Reformat the ServiceSpec classes properties KNOWN_SERVICE_TYPES and
REQUIRES_SERVICE_ID. These were previously strings that were converted
to lists via a call to split. With a string there's very little a human
or a tool can do to validate the content. Changing these into proper
lists in the source code brings clarity of intent and the ability to
analyze the code. Because there's no semantic difference what services
are listed where (this means the type could probably be a set - a quest
for another day) I also took the opportunity to sort the contents of the
lists and add some basic comments for what these lists are for.

It also removes the use of (ugly, IMO) line continuations. The downside
is that it makes more total lines, but if that bugs you - use code
folding :-).

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agomgr/cephadm: refactor keyring simplification out of get_keyring_with_caps
John Mulligan [Fri, 5 Jan 2024 15:24:10 +0000 (10:24 -0500)]
mgr/cephadm: refactor keyring simplification out of get_keyring_with_caps

Refactor get_keyring_with_caps such that the keyring simplification code
is moved into a new function that can be used in other locations.
get_keyring_with_caps will now call the new function to return the
simplified & consistent keyring output.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agomgr/cephadm: reformat the _service_classes variable
John Mulligan [Wed, 13 Dec 2023 20:49:12 +0000 (15:49 -0500)]
mgr/cephadm: reformat the _service_classes variable

Reformat the _service_classes variable so that it uses a multi-line list
with a single item on each line in a more black-ish style that is more
readable (especially if you use code-folding wisely).
Sort the list while we're at it.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agomgr/orchestrator: fix the sorting of the imports
John Mulligan [Wed, 13 Dec 2023 21:05:27 +0000 (16:05 -0500)]
mgr/orchestrator: fix the sorting of the imports

While ceph doesn't enforce sorted imports I prefer them when possible. I
had once sorted these imports but then nvmeof came along an ruined
things. Put nvmeof back in it's place.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agomgr/orchestrator: clean up import style
John Mulligan [Wed, 13 Dec 2023 19:37:17 +0000 (14:37 -0500)]
mgr/orchestrator: clean up import style

In the seemingly never-ending fight against line continuations and just
blatting tons of stuff onto single lines another small victory is won.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agomgr/cephadm: fix test failure on newer python
John Mulligan [Wed, 13 Dec 2023 19:33:20 +0000 (14:33 -0500)]
mgr/cephadm: fix test failure on newer python

Tests that touch this enum fail for me locally but pass in the CI. This
seems to be due to new enum related behavior in Python 3.11.
See: https://blog.pecar.me/python-enum
Instead of fixing it as suggested in the above blog, adding a __str__
method works on all python versions I care to know about.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agocephadm: fix issue joining to ad by using a virtual hostname
John Mulligan [Tue, 16 Jan 2024 20:37:27 +0000 (15:37 -0500)]
cephadm: fix issue joining to ad by using a virtual hostname

The not-a-real-fqdn hostname that the containers got were causing
performance issues joining AD (and running testjoin and winbind).
Define a virtual hostname that can be passed in from the service or
automatically derived from the system's hostname.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agocephadm: add a basic deployment test for an smb daemon
John Mulligan [Wed, 6 Dec 2023 20:14:32 +0000 (15:14 -0500)]
cephadm: add a basic deployment test for an smb daemon

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agocephadm: import and enable deployment of SMB daemon class
John Mulligan [Wed, 6 Dec 2023 20:14:32 +0000 (15:14 -0500)]
cephadm: import and enable deployment of SMB daemon class

Enable the use of the SMB container daemon form class by importing, and
thus registering, it. Note that the only way to invoke this feature is
by hand rolling some JSON to feed to the `ceph _orch deploy` command.
Connecting this with the cephadm mgr module is left as a future task.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agocephadm: add an SMB daemon module and classes
John Mulligan [Wed, 6 Dec 2023 20:14:31 +0000 (15:14 -0500)]
cephadm: add an SMB daemon module and classes

Add an incomplete but largely viable SMB/Samba container daemon form
implementation to cephadm. Currently unused but it lays out some of the
basics needed to create smb sharing using samba containers under cephadm
orchestration.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agocephadm: add a default constant value for samba server container image
John Mulligan [Tue, 21 Nov 2023 22:11:37 +0000 (17:11 -0500)]
cephadm: add a default constant value for samba server container image

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agocephadm: add generic methods for sharing namespaces across containers
John Mulligan [Sun, 3 Dec 2023 16:01:05 +0000 (11:01 -0500)]
cephadm: add generic methods for sharing namespaces across containers

In the future, some sidecar containers will need to share namespaces
with the primary container (or each other). Make it easy to set this up
by creating a enable_shared_namespaces function and Namespace enum.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
15 months agodoc/start: link to mon map command 56377/head
Zac Dover [Thu, 21 Mar 2024 22:12:16 +0000 (08:12 +1000)]
doc/start: link to mon map command

Link to the "ceph mon stat" command when "Intro to Ceph" document first
mentions Monitor Maps.

Signed-off-by: Zac Dover <zac.dover@proton.me>
15 months agoMerge pull request #55886 from tchaikov/wip-ceph.spec-gcc-13
Samuel Just [Thu, 21 Mar 2024 21:24:39 +0000 (14:24 -0700)]
Merge pull request #55886 from tchaikov/wip-ceph.spec-gcc-13

ceph.spec.in: bump gcc-toolset to 13 and use it on rhel>=8

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
15 months agoMerge pull request #56369 from adk3798/nvmeof-new-fields
Adam King [Thu, 21 Mar 2024 19:33:24 +0000 (15:33 -0400)]
Merge pull request #56369 from adk3798/nvmeof-new-fields

mgr/cephadm: add some NVMEof gateway fields to be configurable by cephadm

Reviewed-by: Gil Bregman <gbregman@il.ibm.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
15 months agomgr/dashboard: add support for NFSv3 exports 56055/head
Avan Thakkar [Fri, 8 Mar 2024 07:15:44 +0000 (12:45 +0530)]
mgr/dashboard: add support for NFSv3 exports

Fixes: https://tracker.ceph.com/issues/64812
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
15 months agoMerge pull request #56283 from Svelar/remove_WITH_ZBD
Dan Mick [Thu, 21 Mar 2024 18:20:11 +0000 (11:20 -0700)]
Merge pull request #56283 from Svelar/remove_WITH_ZBD

run-make: remove WITH_ZBD

15 months agomgr/dashboard: fix subvolume group edit size 56372/head
Ivo Almeida [Thu, 21 Mar 2024 16:13:48 +0000 (16:13 +0000)]
mgr/dashboard: fix subvolume group edit size

Removed the 'infinite' string which was set when no value was provided

Fixes: https://tracker.ceph.com/issues/65049
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
15 months agoMerge pull request #55691 from ivoalmeida/snapshot-schedule-retention-fix
Ivo Almeida [Thu, 21 Mar 2024 15:36:26 +0000 (15:36 +0000)]
Merge pull request #55691 from ivoalmeida/snapshot-schedule-retention-fix

mgr/dashboard: fix retention add for subvolume

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
15 months agomgr/cephadm: add nvmeof configuration fields 56369/head
Gil Bregman [Thu, 21 Mar 2024 09:06:52 +0000 (11:06 +0200)]
mgr/cephadm: add nvmeof configuration fields

Fixes: https://tracker.ceph.com/issues/64821
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
15 months agopython-common/ceph/deployment: add nvmeof configuration fields
Gil Bregman [Thu, 21 Mar 2024 09:07:54 +0000 (11:07 +0200)]
python-common/ceph/deployment: add nvmeof configuration fields

Fixes: https://tracker.ceph.com/issues/64821
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
15 months agoMerge pull request #56008 from kchheda3/wip-notification-subsys
Casey Bodley [Thu, 21 Mar 2024 15:08:35 +0000 (15:08 +0000)]
Merge pull request #56008 from kchheda3/wip-notification-subsys

rgw/notification: add rgw notification specific debug log subsystem

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
15 months agoosd/scrub: removing the slow reservation response configuration option 56337/head
Ronen Friedman [Thu, 21 Mar 2024 15:06:13 +0000 (17:06 +0200)]
osd/scrub: removing the slow reservation response configuration option

Removing 'osd_scrub_slow_reservation_response', as it is not in use
anymore.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
15 months agoMerge pull request #55348 from chenyuanrun/fix-io-ctx-impl-flags
Yuri Weinstein [Thu, 21 Mar 2024 14:48:01 +0000 (07:48 -0700)]
Merge pull request #55348 from chenyuanrun/fix-io-ctx-impl-flags

librados: use CEPH_OSD_FLAG_FULL_FORCE for IoCtxImpl::remove

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>