]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
12 months agodoc/rados: update how to install c++ header files 58287/head
Pere Diaz Bou [Wed, 26 Jun 2024 13:57:47 +0000 (15:57 +0200)]
doc/rados: update how to install c++ header files

In this example librados2-devel only install C header files on fedora 40,
therefore I added libradospp-devel to the command to include C++ header files.

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
12 months agoMerge pull request #57125 from xxhdx1985126/wip-65679
Matan Breizman [Wed, 26 Jun 2024 13:38:08 +0000 (16:38 +0300)]
Merge pull request #57125 from xxhdx1985126/wip-65679

crimson/osd/pg: reset the snap mapper's backend when pg interval changes

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
12 months agoMerge pull request #58270 from Svelar/adminsocket
Rongqi Sun [Wed, 26 Jun 2024 05:59:47 +0000 (13:59 +0800)]
Merge pull request #58270 from Svelar/adminsocket

test/admin_socket: increase slack

12 months agoMerge pull request #58226 from zdover23/wip-doc-2024-06-24-rados-troubleshooting...
Zac Dover [Wed, 26 Jun 2024 05:53:07 +0000 (15:53 +1000)]
Merge pull request #58226 from zdover23/wip-doc-2024-06-24-rados-troubleshooting-osd-debugging-slow-requests

doc/rados: edit troubleshooting-osd.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
12 months agotest/admin_socket: increase slack 58270/head
Rongqi Sun [Wed, 26 Jun 2024 03:01:33 +0000 (03:01 +0000)]
test/admin_socket: increase slack

fixes: https://tracker.ceph.com/issues/66638

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
12 months agoMerge pull request #57986 from rhcs-dashboard/fix_duplicated_token_status_polling
Nizamudeen A [Tue, 25 Jun 2024 18:17:19 +0000 (23:47 +0530)]
Merge pull request #57986 from rhcs-dashboard/fix_duplicated_token_status_polling

mgr/dashboard: fix token status being polled continously

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
12 months agoMerge PR #53503 into main
Patrick Donnelly [Tue, 25 Jun 2024 16:27:28 +0000 (12:27 -0400)]
Merge PR #53503 into main

* refs/pull/53503/head:
qa: add tests for `mds last-seen` command
doc/cephfs: add documentation for `mds last-seen`
PendingReleaseNotes: add note on last-seen command
mon/MDSMonitor: add command to lookup when mds was last seen
mon/MDSMonitor: set birth time on FSMap during encode
pybind/mgr/dashboard: show context diff for openapi check

Reviewed-by: Venky Shankar <vshankar@redhat.com>
12 months agoMerge pull request #56876 from pponnuvel/no_crash_if_nfs_unavailable
Avan [Tue, 25 Jun 2024 16:12:01 +0000 (21:42 +0530)]
Merge pull request #56876 from pponnuvel/no_crash_if_nfs_unavailable

mgr/nfs: Don't crash ceph-mgr if NFS clusters are unavailable.

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
12 months agoMerge pull request #53849 from dvanders/dvanders_alma
Casey Bodley [Tue, 25 Jun 2024 15:10:21 +0000 (16:10 +0100)]
Merge pull request #53849 from dvanders/dvanders_alma

install-deps.sh, do_cmake.sh: almalinux is another el flavour

Reviewed-by: John Mulligan <jmulligan@redhat.com>
12 months agoMerge pull request #58141 from ljflores/wip-tracker-65852
Yuri Weinstein [Tue, 25 Jun 2024 13:47:14 +0000 (06:47 -0700)]
Merge pull request #58141 from ljflores/wip-tracker-65852

qa/suites/rados/thrash/workloads: remove cache tiering workload

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
12 months agoMerge pull request #58139 from bill-scales/fix_num_shards_repaired_stat
Yuri Weinstein [Tue, 25 Jun 2024 13:46:46 +0000 (06:46 -0700)]
Merge pull request #58139 from bill-scales/fix_num_shards_repaired_stat

osd/ECBackend.cc: Fix double increment of num_shards_repaired stat

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
12 months agoMerge pull request #57401 from kamoltat/wip-ksirivad-fix-65826
Yuri Weinstein [Tue, 25 Jun 2024 13:44:44 +0000 (06:44 -0700)]
Merge pull request #57401 from kamoltat/wip-ksirivad-fix-65826

qa/tasks/mgr/test_progress.py: deal with pre-exisiting pool

Reviewed-by: Laura Flores <lflores@redhat.com>
12 months agoMerge pull request #56531 from rzarzynski/wip-bug-65183
Yuri Weinstein [Tue, 25 Jun 2024 13:44:07 +0000 (06:44 -0700)]
Merge pull request #56531 from rzarzynski/wip-bug-65183

mon, qa: suites override ec profiles with --yes_i_really_mean_it; monitors accept that

Reviewed-by: Laura Flores <lflores@redhat.com>
12 months agoMerge pull request #58192 from kshtsk/wip-suse-remove-zoned-namespace
Pere Diaz Bou [Tue, 25 Jun 2024 11:58:03 +0000 (13:58 +0200)]
Merge pull request #58192 from kshtsk/wip-suse-remove-zoned-namespace

os/bluestore: remove zoned namespace support

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
12 months agoMerge pull request #58243 from zdover23/wip-doc-2024-06-25-rados-ops-stretch-mode...
Zac Dover [Tue, 25 Jun 2024 11:18:11 +0000 (21:18 +1000)]
Merge pull request #58243 from zdover23/wip-doc-2024-06-25-rados-ops-stretch-mode-credit

doc/rados: credit Prashant for a procedure

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
12 months agoMerge pull request #58223 from Matan-B/wip-matanb-crimson-revert-56994
Matan Breizman [Tue, 25 Jun 2024 09:28:35 +0000 (12:28 +0300)]
Merge pull request #58223 from Matan-B/wip-matanb-crimson-revert-56994

Revert "crimson/osd/osd_operation: fix dump_historic_slow_ops command…

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
12 months agoMerge pull request #58110 from rhcs-dashboard/bring-back-cluster-swticher
Nizamudeen A [Tue, 25 Jun 2024 08:27:42 +0000 (13:57 +0530)]
Merge pull request #58110 from rhcs-dashboard/bring-back-cluster-swticher

mgr/dashboard: fix (multi) cluster switcher disappearance after carbon UI shell

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
12 months agoMerge pull request #57930 from rhcs-dashboard/get-replication-info
Nizamudeen A [Tue, 25 Jun 2024 07:43:05 +0000 (13:13 +0530)]
Merge pull request #57930 from rhcs-dashboard/get-replication-info

mgr/dashboard: get and update bucket replication policies

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
12 months agodoc/rados: credit Prashant for a procedure 58243/head
Zac Dover [Tue, 25 Jun 2024 04:49:13 +0000 (14:49 +1000)]
doc/rados: credit Prashant for a procedure

Credit Prashant D for creating the stretch-mode workaround procedure for
retrieving the correct size of datacenters.

Follows: https://github.com/ceph/ceph/pull/58109

Signed-off-by: Zac Dover <zac.dover@proton.me>
12 months agoMerge PR #56052 into main
Venky Shankar [Tue, 25 Jun 2024 07:10:25 +0000 (12:40 +0530)]
Merge PR #56052 into main

* refs/pull/56052/head:
qa/suites: ignore unresponsive client when the test passes
qa: enhance per-client labelled perf counters test

Reviewed-by: Venky Shankar <vshankar@redhat.com>
12 months agoMerge PR #56429 into main
Venky Shankar [Tue, 25 Jun 2024 07:09:33 +0000 (12:39 +0530)]
Merge PR #56429 into main

* refs/pull/56429/head:
mds: fix rank root doesn't insert root ino into its subtree map when starting
mds: flush mds log before finishing STATE_STARTING
mds/FSMap: go back to STARTING state when rank doesn't make it pass STARTING

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
12 months agoMerge PR #57034 into main
Venky Shankar [Tue, 25 Jun 2024 07:07:56 +0000 (12:37 +0530)]
Merge PR #57034 into main

* refs/pull/57034/head:
qa: cleanup snapshots before subvolume delete

Reviewed-by: Venky Shankar <vshankar@redhat.com>
12 months agoMerge PR #57085 into main
Venky Shankar [Tue, 25 Jun 2024 07:06:29 +0000 (12:36 +0530)]
Merge PR #57085 into main

* refs/pull/57085/head:
mds: set the correct WRLOCK flag always in wrlock_force()

Reviewed-by: Venky Shankar <vshankar@redhat.com>
12 months agoMerge PR #57576 into main
Venky Shankar [Tue, 25 Jun 2024 07:04:22 +0000 (12:34 +0530)]
Merge PR #57576 into main

* refs/pull/57576/head:
src/test: add testcase file for low level sync io code paths

Reviewed-by: Venky Shankar <vshankar@redhat.com>
12 months agomgr/dashboard: fix token status being polled continously 57986/head
Nizamudeen A [Wed, 12 Jun 2024 06:58:05 +0000 (12:28 +0530)]
mgr/dashboard: fix token status being polled continously

subscribe only once rather than continously subscribing

Fixes: https://tracker.ceph.com/issues/66665
Signed-off-by: Nizamudeen A <nia@redhat.com>
12 months agomgr/dashboard: fix (multi) cluster switcher disappearance after carbon UI 58110/head
Nizamudeen A [Tue, 18 Jun 2024 07:44:02 +0000 (13:14 +0530)]
mgr/dashboard: fix (multi) cluster switcher disappearance after carbon UI

Fixes: https://tracker.ceph.com/issues/66538
Signed-off-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #57001 from rhcs-dashboard/cheroot-upgrade
Nizamudeen A [Tue, 25 Jun 2024 05:11:16 +0000 (10:41 +0530)]
Merge pull request #57001 from rhcs-dashboard/cheroot-upgrade

mgr/dashboard: bump cheroot to > 10.0

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
12 months agoMerge pull request #57977 from athanatos/sjust/wip-66308-obc-locking
Samuel Just [Mon, 24 Jun 2024 20:05:44 +0000 (13:05 -0700)]
Merge pull request #57977 from athanatos/sjust/wip-66308-obc-locking

crimson: simplify obc loading by locking excl for load and demoting to needed lock

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
12 months agoMerge pull request #58142 from adk3798/rgw-zone-create-error-handling
Adam King [Mon, 24 Jun 2024 12:38:34 +0000 (08:38 -0400)]
Merge pull request #58142 from adk3798/rgw-zone-create-error-handling

mgr/rgw: fix error handling in rgw zone create

Reviewed-by: John Mulligan <jmulligan@redhat.com>
12 months agoMerge pull request #57339 from phlogistonjohn/jjm-smb-login-control
Adam King [Mon, 24 Jun 2024 12:35:29 +0000 (08:35 -0400)]
Merge pull request #57339 from phlogistonjohn/jjm-smb-login-control

smb: add login control access parameters to share resource

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
12 months agodoc/rados: edit troubleshooting-osd.rst 58226/head
Zac Dover [Mon, 24 Jun 2024 10:32:30 +0000 (20:32 +1000)]
doc/rados: edit troubleshooting-osd.rst

Make minor changes to the "Debugging Slow Requests" section of
doc/rados/troubleshooting/troubleshooting-osd.rst in preparation
for an expansion of this section in response to a reqeust from Joel
Davidow.

Signed-off-by: Zac Dover <zac.dover@proton.me>
12 months agoMerge pull request #57927 from rhcs-dashboard/expand-cluster-improvements
Nizamudeen A [Mon, 24 Jun 2024 10:01:09 +0000 (15:31 +0530)]
Merge pull request #57927 from rhcs-dashboard/expand-cluster-improvements

mgr/dashboard: Expand Cluster improvements

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #56658 from afreen23/wip-nfs-route
Nizamudeen A [Mon, 24 Jun 2024 09:35:09 +0000 (15:05 +0530)]
Merge pull request #56658 from afreen23/wip-nfs-route

mgr/dashboard: Fix NFS routing

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agocrimson/osd/pg: reset the snap mapper's backend when pg interval changes 57125/head
Xuehan Xu [Mon, 29 Apr 2024 04:11:51 +0000 (12:11 +0800)]
crimson/osd/pg: reset the snap mapper's backend when pg interval changes

Fixes: https://tracker.ceph.com/issues/65679
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
12 months agoRevert "crimson/osd/osd_operation: fix dump_historic_slow_ops command works" 58223/head
Matan Breizman [Mon, 24 Jun 2024 08:07:42 +0000 (08:07 +0000)]
Revert "crimson/osd/osd_operation: fix dump_historic_slow_ops command works"

This reverts commit 834ab99efc6453f91183a47849f56617cf73c112.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
12 months agocrimson/.../object_context_loader: add missing dpp argument to debug statement 57977/head
Samuel Just [Fri, 21 Jun 2024 01:54:58 +0000 (18:54 -0700)]
crimson/.../object_context_loader: add missing dpp argument to debug statement

Signed-off-by: Samuel Just <sjust@redhat.com>
12 months agocrimson/.../tri_mutex: use hobject_t for tri_mutex::name debug value
Samuel Just [Fri, 21 Jun 2024 00:48:04 +0000 (17:48 -0700)]
crimson/.../tri_mutex: use hobject_t for tri_mutex::name debug value

Useful for distinguishing between tri_mutex instances on different clones.

Signed-off-by: Samuel Just <sjust@redhat.com>
12 months agocrimson/.../tri_mutex: no need to store waiter_name on waiter_t
Samuel Just [Fri, 21 Jun 2024 00:46:11 +0000 (17:46 -0700)]
crimson/.../tri_mutex: no need to store waiter_name on waiter_t

It's going to be the same as tri_mutex::name for any waiter on
a tri_mutex.

Signed-off-by: Samuel Just <sjust@redhat.com>
12 months agocrimson/.../object_context: drop recovery_read_marker
Samuel Just [Wed, 19 Jun 2024 04:10:34 +0000 (21:10 -0700)]
crimson/.../object_context: drop recovery_read_marker

This doesn't seem to serve a purpose with current crimson.  classic
uses ObjectState::recovery_read_marker to indicate that backfill
should be requeued upon wakeup, but that hasn't been necessary so
far in crimson.  We can reintroduce this if it becomes useful.

Signed-off-by: Samuel Just <sjust@redhat.com>
12 months agocrimson/.../object_context: drop unused maybe_get_excl
Samuel Just [Wed, 19 Jun 2024 04:09:04 +0000 (21:09 -0700)]
crimson/.../object_context: drop unused maybe_get_excl

Signed-off-by: Samuel Just <sjust@redhat.com>
12 months agocrimson/.../object_context: remove loading_mutex
Samuel Just [Mon, 10 Jun 2024 21:15:16 +0000 (21:15 +0000)]
crimson/.../object_context: remove loading_mutex

Now that we acquire and demote an exclusive lock during loading without
blocking, a seperate loading_mutex shouldn't be necessary.

Signed-off-by: Samuel Just <sjust@redhat.com>
12 months agocrimson/.../tri_mutex: lock() methods return normal future
Samuel Just [Thu, 13 Jun 2024 00:47:08 +0000 (00:47 +0000)]
crimson/.../tri_mutex: lock() methods return normal future

f63d76a2 modified the lock() variants on tri_mutex so that the obc
loading pathway wouldn't invoke .then() on returned future known
statically to be ready.  Now that the loading pathway uses demotion
mechanisms that cannot block and do not return futures, we no longer
have any users like that and can drop the extra std::nullopt
possibility.

In a larger sense, if lock() *can* return a non-ready future in a
particular pathway, there's no semantic difference between returning
std::optional<future<>> and future<> as the caller would still have to
deal with a possible non-ready future return even if std::nullopt is
also possible.  If the pathway can be demonstrated statically to be
non-blocking, as with the obc loading mechanism, we really want to use a
mechanism that obviously cannot block rather relying on a mechanism with
a return signature of std::optional<future<>> to return std::nullopt.

Signed-off-by: Samuel Just <sjust@redhat.com>
12 months agoMerge PR #58125 into main
Patrick Donnelly [Sun, 23 Jun 2024 18:32:41 +0000 (14:32 -0400)]
Merge PR #58125 into main

* refs/pull/58125/head:
common/TrackedOp: do not count the ops marked as nowarn

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
12 months agoMerge PR #58121 into main
Patrick Donnelly [Sun, 23 Jun 2024 18:32:00 +0000 (14:32 -0400)]
Merge PR #58121 into main

* refs/pull/58121/head:
doc: add documentation for `ceph auth rotate`
PendingReleaseNotes: add note for new `auth rotate`
qa: test `auth rotate`
mon/AuthMonitor: add `ceph auth rotate` command

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
12 months agoMerge PR #57993 into main
Patrick Donnelly [Sun, 23 Jun 2024 18:31:28 +0000 (14:31 -0400)]
Merge PR #57993 into main

* refs/pull/57993/head:
mds: initialize epoch for quiescedb

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
12 months agoMerge PR #57754 into main
Patrick Donnelly [Sun, 23 Jun 2024 18:29:53 +0000 (14:29 -0400)]
Merge PR #57754 into main

* refs/pull/57754/head:
mds: set the proper extra bl for the create request
mds: encode the correct extra info depending on the feature bits
mds: add set_reply_extra_bl() helper support
mds: cleanup the code to make it to be more readable

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
12 months agoMerge PR #57084 into main
Patrick Donnelly [Sun, 23 Jun 2024 18:29:13 +0000 (14:29 -0400)]
Merge PR #57084 into main

* refs/pull/57084/head:
mds: drop client metrics during recovery

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
12 months agoMerge PR #56828 into main
Patrick Donnelly [Sun, 23 Jun 2024 18:28:38 +0000 (14:28 -0400)]
Merge PR #56828 into main

* refs/pull/56828/head:
mds: do remove the cap when seqs equal or larger than last issue

Reviewed-by: Leonid Usov <leonid.usov@ibm.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
12 months agoMerge pull request #58200 from zdover23/wip-doc-2024-06-22-start-begin-links
Zac Dover [Sun, 23 Jun 2024 08:15:26 +0000 (18:15 +1000)]
Merge pull request #58200 from zdover23/wip-doc-2024-06-22-start-begin-links

doc/start: add links to Beginner's Guide

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
12 months agodoc/start: add links to Beginner's Guide 58200/head
Zac Dover [Sat, 22 Jun 2024 06:28:12 +0000 (16:28 +1000)]
doc/start: add links to Beginner's Guide

Add two links to Sage Weil's overview talks about Ceph.

Signed-off-by: Zac Dover <zac.dover@proton.me>
12 months agoMerge pull request #58099 from athanatos/sjust/wip-66461-obc-with-lock
Samuel Just [Sun, 23 Jun 2024 00:42:37 +0000 (17:42 -0700)]
Merge pull request #58099 from athanatos/sjust/wip-66461-obc-with-lock

crimson: fix ObjectContext::_with_lock to only unlock if lock is taken

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
12 months agoMerge pull request #57866 from rhcs-dashboard/fix-66348-main
Nizamudeen A [Sat, 22 Jun 2024 11:18:58 +0000 (16:48 +0530)]
Merge pull request #57866 from rhcs-dashboard/fix-66348-main

mgr/dashboard: Block -> Images -> Create form improvements

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Sunil Angadi <Sunil.Angadi@ibm.com>
12 months agoMerge pull request #58156 from zdover23/wip-doc-2024-06-20-rados-troubleshooting-mon
Zac Dover [Sat, 22 Jun 2024 06:21:20 +0000 (16:21 +1000)]
Merge pull request #58156 from zdover23/wip-doc-2024-06-20-rados-troubleshooting-mon

doc/rados: followup to PR#58057

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
13 months agocrimson: eliminate lock promotion from object_context and tri_mutex
Samuel Just [Mon, 10 Jun 2024 20:47:07 +0000 (20:47 +0000)]
crimson: eliminate lock promotion from object_context and tri_mutex

Since we now load obc's via ObjectContext::load_then_with_lock, we no
longer need to promote locks.  Eliminate support for now.

Signed-off-by: Samuel Just <sjust@redhat.com>
13 months agocrimson/.../object_context_loader: simplify obc loading
Samuel Just [Mon, 10 Jun 2024 20:40:43 +0000 (20:40 +0000)]
crimson/.../object_context_loader: simplify obc loading

Because we just constructed the obc, we know that we can get an
exclusive lock without blocking.  Introduce
ObjectContext::load_then_with_lock to take an exclusive lock
unconditionally, load, downgrade (which we also know must be safe), and
then run the passed function.

Signed-off-by: Samuel Just <sjust@redhat.com>
13 months agocrimson/.../object_context_loader: consolidate obc loading
Samuel Just [Sat, 8 Jun 2024 01:30:03 +0000 (01:30 +0000)]
crimson/.../object_context_loader: consolidate obc loading

Signed-off-by: Samuel Just <sjust@redhat.com>
13 months agocrimson/.../object_context_loader: remove impossible branch in get_or_load_obc
Samuel Just [Sat, 8 Jun 2024 00:31:53 +0000 (00:31 +0000)]
crimson/.../object_context_loader: remove impossible branch in get_or_load_obc

Signed-off-by: Samuel Just <sjust@redhat.com>
13 months agocrimson: fix ObjectContext::_with_lock to only unlock if lock is taken 58099/head
Samuel Just [Thu, 13 Jun 2024 00:41:55 +0000 (00:41 +0000)]
crimson: fix ObjectContext::_with_lock to only unlock if lock is taken

Fixes: https://tracker.ceph.com/issues/66461
Signed-off-by: Samuel Just <sjust@redhat.com>
13 months agoMerge pull request #57974 from ljflores/wip-tracker-65189
Laura Flores [Fri, 21 Jun 2024 21:48:27 +0000 (16:48 -0500)]
Merge pull request #57974 from ljflores/wip-tracker-65189

Telemetry upgrade test fixes

13 months agoos/bluestore: remove zoned namespace support 58192/head
Kyr Shatskyy [Fri, 21 Jun 2024 10:23:30 +0000 (12:23 +0200)]
os/bluestore: remove zoned namespace support

This is actually a follow up patch for the PR #55054 and
commit 03e11acca048a43ce183be68a5db1c039b7ca485
and makes clean up for suse based distros.

Fixes: 03e11acca048a43ce183be68a5db1c039b7ca485
Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@gmail.com>
13 months agoqa/suites/upgrade/telemetry-upgrade/quincy-x: update image reference 57974/head
Laura Flores [Wed, 19 Jun 2024 23:01:31 +0000 (18:01 -0500)]
qa/suites/upgrade/telemetry-upgrade/quincy-x: update image reference

`quay.io/ceph/daemon-base:latest-quincy` points to the latest quincy tag (v17.2.7),
not the tip of quincy, which is actually what we want to test.

Pulling the daemon-base:latest-quincy image shows it is running v17.2.7:
```
lflores:ceph$ podman run --rm -it daemon-base:latest-quincy
[root@e4eb265e7fa0 /]# ceph -v
ceph version 17.2.7 (b12291d110049b2f35e32e0de30d70e9a4c060d2) quincy (stable)
```

It is important that we test the tip of quincy in case there is a fix there that
we want to pick up.

I referenced this commit to make the change: https://github.com/ceph/ceph/commit/d0381ed7e68a6de7c9ff1e4220698ed8eab28ac6

Signed-off-by: Laura Flores <lflores@ibm.com>
13 months agoqa/suites/upgrade/telemetry-upgrade/reef-x: update how cephadm is pulled and change...
Laura Flores [Wed, 19 Jun 2024 21:57:45 +0000 (16:57 -0500)]
qa/suites/upgrade/telemetry-upgrade/reef-x: update how cephadm is pulled and change image reference

Update how cephadm is pulled:

`cephadm_git_url` and `cephadm_branch` are used in releases older than reef
to install cephadm. Both of these keys are needed to install it from the github
repo.

However, in reef and on, the compiled zipapp cephadm needs to be pulled differently
than the old single python script `cephadm` from earlier releases.

This commit is what I referenced for this change: https://github.com/ceph/ceph/commit/967716f2e6c8cd3f7d810a5f8e5e49448717e513

-------

Change image reference:

`quay.io/ceph/daemon-base:latest-reef` points to the latest reef tag (v18.2.2),
not the tip of reef, which is actually what we want to test.

Pulling the daemon-base:latest-reef image shows it is running v18.2.2:
```
lflores:ceph$ podman run --rm -it daemon-base:latest-reef
[root@d4d9a0eb04be /]# ceph -v
ceph version 18.2.2 (531c0d11a1c5d39fbfe6aa8a521f023abf3bf3e2) reef (stable)
```

It is important that we test the tip of reef in case there is a fix there that we
want to pick up.

I referenced this commit to make the change: https://github.com/ceph/ceph/commit/d0381ed7e68a6de7c9ff1e4220698ed8eab28ac6

Signed-off-by: Laura Flores <lflores@ibm.com>
13 months agoqa/suites/upgrade/telemetry-upgrade: add more ignorelist items and require_osd_releas...
Laura Flores [Wed, 19 Jun 2024 21:07:31 +0000 (16:07 -0500)]
qa/suites/upgrade/telemetry-upgrade: add more ignorelist items and require_osd_release=squid

The warnings added to the ignorelist show up in the cluster log, but they are
expected during upgrades and should thus be ignored.

We also need to set require_osd_release=squid to avoid this warning:
```
cluster [WRN] Health check failed: all OSDs are running squid or later but require_osd_release < squid (OSD_UPGRADE_FINISHED)
```

Signed-off-by: Laura Flores <lflores@ibm.com>
13 months agoMerge pull request #58178 from ljflores/wip-tracker-66556
Radoslaw Zarzynski [Fri, 21 Jun 2024 14:41:12 +0000 (16:41 +0200)]
Merge pull request #58178 from ljflores/wip-tracker-66556

Revert "test: reproduce flap peering bug (wip)"

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Dan van der Ster <daniel.vanderster@cern.ch>
13 months agoMerge pull request #58175 from batrick/label-scripts
Ilya Dryomov [Fri, 21 Jun 2024 13:21:40 +0000 (15:21 +0200)]
Merge pull request #58175 from batrick/label-scripts

.github/labeler: add script label to script changes

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
13 months agomgr/dashboard: edit replication policy 57930/head
Nizamudeen A [Fri, 7 Jun 2024 13:22:19 +0000 (18:52 +0530)]
mgr/dashboard: edit replication policy

Fixes: https://tracker.ceph.com/issues/66240
Signed-off-by: Nizamudeen A <nia@redhat.com>
13 months agomgr/dashboard: get bucket replication info
Nizamudeen A [Fri, 7 Jun 2024 13:13:00 +0000 (18:43 +0530)]
mgr/dashboard: get  bucket replication info

- Show bucket replication status and replication policy in the details
view

Fixes: https://tracker.ceph.com/issues/66241
Signed-off-by: Nizamudeen A <nia@redhat.com>
13 months agomgr/dashboard: select default daemon based on the default zonegroup
Nizamudeen A [Fri, 7 Jun 2024 07:45:06 +0000 (13:15 +0530)]
mgr/dashboard: select default daemon based on the default zonegroup

if multisite is configured, the default daemon needs to be selected
based on the default zonegroup. Otherwise dashboard gives you incorrect
details when doing the period commit

The issue occurs when you do a period update --commit and you reload one
of the block page, the api assigns the zonegroup of the second gateway
because for a moment, the first gateway reflects the period changes...
This is not true because the default zonegroup is of the previous active
gateway but even though the back-end correctly says the active
zonegroup, the dashboard api says it wrongly.

Fixes: https://tracker.ceph.com/issues/66394
Signed-off-by: Nizamudeen A <nia@redhat.com>
13 months agoMerge pull request #55675 from douglasawh/patch-2
Zac Dover [Fri, 21 Jun 2024 09:17:54 +0000 (19:17 +1000)]
Merge pull request #55675 from douglasawh/patch-2

doc/src: invadvisable is not a word

Reviewed-by: Zac Dover <zac.dover@proton.me>
13 months agomgr/dashboard: Block -> Images -> Create form improvements 57866/head
Aashish Sharma [Tue, 4 Jun 2024 12:29:34 +0000 (17:59 +0530)]
mgr/dashboard: Block -> Images -> Create form improvements

Fixes: https://tracker.ceph.com/issues/66348
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
13 months agoMerge pull request #58109 from zdover23/wip-doc-2024-06-18-rados-ops-stretch-mode
Zac Dover [Fri, 21 Jun 2024 05:49:01 +0000 (15:49 +1000)]
Merge pull request #58109 from zdover23/wip-doc-2024-06-18-rados-ops-stretch-mode

doc/rados: add stretch_rule workaround

Reviewed-by: Prashant D <pdhange@redhat.com>
13 months agoMerge PR #58174 into main
Patrick Donnelly [Fri, 21 Jun 2024 01:50:25 +0000 (21:50 -0400)]
Merge PR #58174 into main

* refs/pull/58174/head:
script/backport-create-issue: update tag custom field

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
13 months agomgr/dashboard: Expand Cluster improvements 57927/head
Naman Munet [Fri, 7 Jun 2024 10:49:23 +0000 (16:19 +0530)]
mgr/dashboard: Expand Cluster improvements

worked on expand cluster screen hide/show and persisting osd form values

Fixes: https://tracker.ceph.com/issues/66344
Signed-off-by: Naman Munet <nmunet@redhat.com>
13 months agoqa: add tests for `mds last-seen` command 53503/head
Patrick Donnelly [Tue, 11 Jun 2024 15:46:15 +0000 (11:46 -0400)]
qa: add tests for `mds last-seen` command

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agodoc/cephfs: add documentation for `mds last-seen`
Patrick Donnelly [Tue, 11 Jun 2024 15:45:29 +0000 (11:45 -0400)]
doc/cephfs: add documentation for `mds last-seen`

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoPendingReleaseNotes: add note on last-seen command
Patrick Donnelly [Tue, 19 Sep 2023 19:24:10 +0000 (15:24 -0400)]
PendingReleaseNotes: add note on last-seen command

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agomon/MDSMonitor: add command to lookup when mds was last seen
Patrick Donnelly [Mon, 18 Sep 2023 17:34:39 +0000 (13:34 -0400)]
mon/MDSMonitor: add command to lookup when mds was last seen

For use by high-level storage operators like Rook.

Fixes: https://tracker.ceph.com/issues/62849
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agomon/MDSMonitor: set birth time on FSMap during encode
Patrick Donnelly [Mon, 18 Sep 2023 14:58:12 +0000 (10:58 -0400)]
mon/MDSMonitor: set birth time on FSMap during encode

So we can begin to answer questions like: when did we last see an MDS?

Fixes: https://tracker.ceph.com/issues/62849
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agopybind/mgr/dashboard: show context diff for openapi check
Patrick Donnelly [Wed, 12 Jun 2024 14:43:47 +0000 (10:43 -0400)]
pybind/mgr/dashboard: show context diff for openapi check

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agodoc: add documentation for `ceph auth rotate` 58121/head
Patrick Donnelly [Tue, 18 Jun 2024 18:07:31 +0000 (14:07 -0400)]
doc: add documentation for `ceph auth rotate`

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoPendingReleaseNotes: add note for new `auth rotate`
Patrick Donnelly [Tue, 18 Jun 2024 17:47:29 +0000 (13:47 -0400)]
PendingReleaseNotes: add note for new `auth rotate`

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoqa: test `auth rotate`
Patrick Donnelly [Tue, 18 Jun 2024 18:17:00 +0000 (14:17 -0400)]
qa: test `auth rotate`

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agomon/AuthMonitor: add `ceph auth rotate` command
Patrick Donnelly [Tue, 18 Jun 2024 17:31:14 +0000 (13:31 -0400)]
mon/AuthMonitor: add `ceph auth rotate` command

Add command to rotate the permanent key of an entity. This avoids the need to
delete / recreate the key when it is compromised, lost, or just scheduled for
rotation.

Fixes: https://tracker.ceph.com/issues/66509
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agodoc/src: invadvisable is not a word 55675/head
Doug Whitfield [Tue, 20 Feb 2024 21:13:14 +0000 (15:13 -0600)]
doc/src: invadvisable is not a word

changed to inadvisable on line 4997

Signed-off-by: Doug Whitfield <douglasawh@gmail.com>
13 months agoRevert "test: reproduce flap peering bug (wip)" 58178/head
Laura Flores [Thu, 20 Jun 2024 18:52:07 +0000 (13:52 -0500)]
Revert "test: reproduce flap peering bug (wip)"

This reverts commit c89f9c4e80a4ac45ae5ea86ea7e9c41999299f27.

Note from Dan van der Ster:
This is a test that should succeed,
it definitely used to succeed back in the L/O days of Ceph. At some
point peering code changed and this behaviour regressed. In short,
an OSD goes down then comes up, and no objects were modified in the mean time.
There should be no degraded PGs in this case.

As this commit is currently breaking make check on all PRs, I think it should
be re-evaluated and merged so whatever fix is needed along with this test to
make it work are merged together.

Fixes: https://tracker.ceph.com/issues/66556
Signed-off-by: Laura Flores <lflores@ibm.com>
13 months ago.github/labeler: add script label to script changes 58175/head
Patrick Donnelly [Thu, 20 Jun 2024 16:00:05 +0000 (12:00 -0400)]
.github/labeler: add script label to script changes

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoscript/backport-create-issue: update tag custom field 58174/head
Patrick Donnelly [Thu, 20 Jun 2024 15:43:17 +0000 (11:43 -0400)]
script/backport-create-issue: update tag custom field

The redmineup_tags was added and, apparently, the old "Tags" custom field with
id == 3 was deleted and then recreated with id == 31. This broke the script.
Update and refactor the id for that "Tags" custom field.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoMerge pull request #57412 from adk3798/stray-laundry2
Adam King [Thu, 20 Jun 2024 16:06:18 +0000 (12:06 -0400)]
Merge pull request #57412 from adk3798/stray-laundry2

qa/cephadm: fix ignorelist of CEPHADM_STRAY_DAEMON for rados_api_tests

Reviewed-by: Laura Flores <lflores@ibm.com>
13 months agoMerge pull request #58055 from zmc/qemu-task-version
Ilya Dryomov [Thu, 20 Jun 2024 15:05:11 +0000 (17:05 +0200)]
Merge pull request #58055 from zmc/qemu-task-version

qa/tasks/qemu: Fix OS version comparison

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
13 months agoMerge pull request #57079 from kchheda3/wip-lc-notification
Casey Bodley [Thu, 20 Jun 2024 14:19:18 +0000 (15:19 +0100)]
Merge pull request #57079 from kchheda3/wip-lc-notification

rgw/lifecycle-notification: Do not block lc processing for notification errors.

Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
13 months agoMerge pull request #57933 from samarahu/d4n_copy_test_fix
Casey Bodley [Thu, 20 Jun 2024 14:04:47 +0000 (15:04 +0100)]
Merge pull request #57933 from samarahu/d4n_copy_test_fix

d4n/directory: Comment out `copy` unit tests and remove unnecessary `copy_object` implementation in filter

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
13 months agoMerge pull request #58147 from zdover23/wip-doc-2024-06-20-start-beginners-guide...
Zac Dover [Thu, 20 Jun 2024 13:53:42 +0000 (23:53 +1000)]
Merge pull request #58147 from zdover23/wip-doc-2024-06-20-start-beginners-guide-wiki

doc/start: add wiki to Beginner's Guide

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
13 months agomgr/dashboard: Fix NFS routing 56658/head
Afreen [Wed, 3 Apr 2024 02:15:32 +0000 (07:45 +0530)]
mgr/dashboard: Fix NFS routing

Fixes https://tracker.ceph.com/issues/65310

The NFS tab in object and File nav uses same route due to which both
gets activated when one of them is clicked.
Hence, this PR separates the routing for Object and File nav.
Object-> NFS: /rgw/nfs
File-> NFS: /cephfs/nfs

Both routes use same NFS List and Form component but under different
routes as mentioned above.

Changes summary
- updated route for File from "/fs" to "/cephfs/<any_other_sub_route>"
  to support both fs and nfs tabs. Since using `/fs` and `/fs/nfs` will
activate both paths and it will be an undesirable user experience.
- `getFsalRouteFromPath` helper function to set the storage backend from
  route.
- removed `stoarge-backend` field from nfs form as now route decides teh
  storage backend
- breadcrumbs redirect to respective navs
- updated e2e tests
- updated unit tests
- changes list page of object-> nfs page to say Bucket instead of Path

Signed-off-by: Afreen <afreen23.git@gmail.com>
13 months agoMerge pull request #58069 from rhcs-dashboard/multiple-alert-panel-dashboard
Nizamudeen A [Thu, 20 Jun 2024 12:48:24 +0000 (18:18 +0530)]
Merge pull request #58069 from rhcs-dashboard/multiple-alert-panel-dashboard

mgr/dashboard: fix alert broken for multiple alerts

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: ivoalmeida <NOT@FOUND>
13 months agoMerge pull request #51566 from rhcs-dashboard/fix-pool-application
Avan [Thu, 20 Jun 2024 12:29:05 +0000 (17:59 +0530)]
Merge pull request #51566 from rhcs-dashboard/fix-pool-application

mgr/dashboard: make application field for pool creation mandatory

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Sunil Angadi <Sunil.Angadi@ibm.com>
13 months agodoc/rados: followup to PR#58057 58156/head
Zac Dover [Thu, 20 Jun 2024 11:43:53 +0000 (21:43 +1000)]
doc/rados: followup to PR#58057

Incorporate Anthony D'Atri's suggestions in
https://github.com/ceph/ceph/pull/58057

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
13 months agoMerge pull request #58068 from rhcs-dashboard/disable-telemetry-notifications-in-e2e
Nizamudeen A [Thu, 20 Jun 2024 06:25:44 +0000 (11:55 +0530)]
Merge pull request #58068 from rhcs-dashboard/disable-telemetry-notifications-in-e2e

mgr/dashboard: disable telemetry notification in e2e

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: nmunet <NOT@FOUND>
13 months agoMerge pull request #58138 from guits/fix-dmcrypt-check
Guillaume Abrioux [Thu, 20 Jun 2024 05:45:03 +0000 (07:45 +0200)]
Merge pull request #58138 from guits/fix-dmcrypt-check

ceph-volume: fix regex usage in `set_dmcrypt_no_workqueue`

13 months agoMerge pull request #57946 from ceph/wip-lusov-qdb-bootstrap-event
Leonid S. Usov [Thu, 20 Jun 2024 04:56:09 +0000 (07:56 +0300)]
Merge pull request #57946 from ceph/wip-lusov-qdb-bootstrap-event

mds: QuiesceDbManager: mark next retry event during bootstrap

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
13 months agoMerge pull request #57980 from ceph/wip-lusov-qdb-root-ttl
Leonid S. Usov [Thu, 20 Jun 2024 04:55:36 +0000 (07:55 +0300)]
Merge pull request #57980 from ceph/wip-lusov-qdb-root-ttl

mds/quiesce-db: calculate_quiesce_map: aggregate quiesce roots' TTL as `max`

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>