]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
12 months agodoc/dev: edit "Principles for format change" 58451/head
Zac Dover [Sun, 7 Jul 2024 03:59:15 +0000 (13:59 +1000)]
doc/dev: edit "Principles for format change"

Improve "Principles for format change" in doc/dev/encoding.rst. This
commit started as a response to Anthony D'Atri's suggestion here: https://github.com/ceph/ceph/pull/58299/files#r1656985564

Review of this section suggested to me that certain minor English usage
improvements would be of benefit. The numbered lists in this section
could still be made a bit clearer.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
12 months agoMerge pull request #58324 from kamoltat/wip-ksirivad-fix-63784
Laura Flores [Fri, 12 Jul 2024 18:43:12 +0000 (13:43 -0500)]
Merge pull request #58324 from kamoltat/wip-ksirivad-fix-63784

qa/standalone/mon: Fix mkfs  test & TEST_LOG failures

12 months agoMerge pull request #58554 from ceph/wip-yuriw-release-process-main
Yuri Weinstein [Fri, 12 Jul 2024 15:12:49 +0000 (08:12 -0700)]
Merge pull request #58554 from ceph/wip-yuriw-release-process-main

docs: removed centos 8 and added squid to the build matrix

Reviewed-by: Casey Bodley <cbodley@redhat.com>
12 months agodocs: removed centos 8 and added squid to the build matrix 58554/head
Yuri Weinstein [Fri, 12 Jul 2024 13:42:02 +0000 (06:42 -0700)]
docs: removed centos 8 and added squid to the build matrix

Signed-off-by: Yuri Weinstein <yweinste@redhat.com>
12 months agoMerge pull request #58416 from cbodley/wip-cmake-zfs
Casey Bodley [Fri, 12 Jul 2024 12:44:45 +0000 (13:44 +0100)]
Merge pull request #58416 from cbodley/wip-cmake-zfs

cmake/os: remove WITH_ZFS option

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
12 months agoMerge pull request #58311 from rishabh-d-dave/fs-auth-nonalpha-test
Rishabh Dave [Fri, 12 Jul 2024 10:53:47 +0000 (16:23 +0530)]
Merge pull request #58311 from rishabh-d-dave/fs-auth-nonalpha-test

Reviewed-by: Xiubo Li <xiubli@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
12 months agoMerge pull request #58386 from YiteGu/dashboard-rename-api
Nizamudeen A [Fri, 12 Jul 2024 07:24:47 +0000 (12:54 +0530)]
Merge pull request #58386 from YiteGu/dashboard-rename-api

mgr/dashboard: add cephfs rename REST API

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #58531 from rhcs-dashboard/fix-66901-main
Nizamudeen A [Fri, 12 Jul 2024 07:23:39 +0000 (12:53 +0530)]
Merge pull request #58531 from rhcs-dashboard/fix-66901-main

mgr/dashboard: fix rgw configuration e2e test

Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #57989 from rhcs-dashboard/multicluster-e2e
Nizamudeen A [Fri, 12 Jul 2024 07:19:29 +0000 (12:49 +0530)]
Merge pull request #57989 from rhcs-dashboard/multicluster-e2e

mgr/dashboard: multicluster management e2e tests

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
12 months agoMerge pull request #57712 from rhcs-dashboard/dashboard-nvmf-mtls-conf
Nizamudeen A [Fri, 12 Jul 2024 05:10:02 +0000 (10:40 +0530)]
Merge pull request #57712 from rhcs-dashboard/dashboard-nvmf-mtls-conf

mgr/dashboard: use secure_channel for grpc requests

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: baum <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@redhat.com>
12 months agoMerge pull request #58101 from rishabh-d-dave/async-clone-race
Rishabh Dave [Fri, 12 Jul 2024 03:55:26 +0000 (09:25 +0530)]
Merge pull request #58101 from rishabh-d-dave/async-clone-race

mgr/vol: handle case where clone index entry goes missing

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh HR <khiremat@redhat.com>
12 months agoqa/cephfs: fix test_single_path_authorize_on_nonalphanumeric_fsname 58311/head
Rishabh Dave [Wed, 26 Jun 2024 13:35:35 +0000 (19:05 +0530)]
qa/cephfs: fix test_single_path_authorize_on_nonalphanumeric_fsname

This test deletes the CephFS already present on the cluster at the very
beginning and unmounts the first client beforehand. But it leaves the
second client mounted on this deleted CephFS that doesn't exist for the
rest of the test. And then at the very end of this test it attempts to
remount the second client (during tearDown()) which hangs and causes
test runner to crash.

Unmount the second client beforehand to prevent the bug and delete
mount_b object to avoid confusion for the readers in future about
whether or not 2nd mountpoint exists.

Fixes: https://tracker.ceph.com/issues/66077
Signed-off-by: Rishabh Dave <ridave@redhat.com>
12 months agomgr/vol: handle case where clone index entry goes missing 58101/head
Rishabh Dave [Mon, 17 Jun 2024 19:03:28 +0000 (00:33 +0530)]
mgr/vol: handle case where clone index entry goes missing

In `async_cloner.py`, clone index entry is fetched to get next clone job
that needs to be executed. It might happen that the clone job was
cancelled just when it was going to be picked for execution (IOW, when
it was about to move from pending state to in-progress state).

Currently, MGR hangs in such a case because exception `ObjectNotFound`
from CephFS Python bindings is raised and is left uncaught. To prevent
this issue catch the exception, log it and return None to tell
`get_job()` of `async_job.py` to look for next job in the queue.

Increase the scope of try-except in method `get_oldest_clone_entry()` of
`async_cloner.py` so that when exception `cephfs.Error` or any exception
under it is thrown by `self.fs.lstat()` is not left uncaught.

FS object is also passed to the method `list_one_entry_at_a_time()`, so
increasing scope of try-except is useful as it will not allow exceptions
raised in other calls to CephFS Python binding methods to be left
uncaught.

Fixes: https://tracker.ceph.com/issues/66560
Signed-off-by: Rishabh Dave <ridave@redhat.com>
12 months agoMerge pull request #58491 from cbodley/wip-66880
Casey Bodley [Thu, 11 Jul 2024 14:33:21 +0000 (15:33 +0100)]
Merge pull request #58491 from cbodley/wip-66880

rgw/datalog: fix LazyFIFO race fix

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
12 months agoMerge pull request #58530 from zdover23/wip-doc-2024-07-11-radosgw-s3-authentication
Anthony D'Atri [Thu, 11 Jul 2024 12:06:29 +0000 (08:06 -0400)]
Merge pull request #58530 from zdover23/wip-doc-2024-07-11-radosgw-s3-authentication

doc/radosgw: s/http/HTTP/

12 months agoMerge pull request #58507 from idryomov/wip-66886
Ilya Dryomov [Thu, 11 Jul 2024 12:03:16 +0000 (14:03 +0200)]
Merge pull request #58507 from idryomov/wip-66886

qa: account for rbd_trash object in krbd_data_pool.sh + related ceph{,adm} task fixes

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: N Balachandran <nibalach@redhat.com>
12 months agoMerge pull request #57492 from rishabh-d-dave/qa-fs-mds-fail-improve
Rishabh Dave [Thu, 11 Jul 2024 11:07:16 +0000 (16:37 +0530)]
Merge pull request #57492 from rishabh-d-dave/qa-fs-mds-fail-improve

qa/cephfs: improvements for "mds fail" and "fs fail"

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
12 months agoMerge pull request #58225 from guojidan/fix-mem-leak
Matan Breizman [Thu, 11 Jul 2024 09:13:58 +0000 (12:13 +0300)]
Merge pull request #58225 from guojidan/fix-mem-leak

crimson/osd/osd_operation: fix dump_historic_slow_ops command works

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
12 months agoMerge pull request #58396 from NitzanMordhai/wip-nitzan-crimson-stat-pybind-test
Matan Breizman [Thu, 11 Jul 2024 08:47:29 +0000 (11:47 +0300)]
Merge pull request #58396 from NitzanMordhai/wip-nitzan-crimson-stat-pybind-test

suite/crimson: enable stats tests

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
12 months agomgr/dashboard: fix rgw configuration e2e test 58531/head
Aashish Sharma [Thu, 11 Jul 2024 07:05:59 +0000 (12:35 +0530)]
mgr/dashboard: fix rgw configuration e2e test

Fixes: https://tracker.ceph.com/issues/66901
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
12 months agomgr/dashboard: multicluster management e2e tests 57989/head
Nizamudeen A [Wed, 12 Jun 2024 08:28:17 +0000 (13:58 +0530)]
mgr/dashboard: multicluster management e2e tests

auth, edit, reconnect and disconnect another cluster

Signed-off-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #58224 from Serrini/fix-66490-main
Nizamudeen A [Thu, 11 Jul 2024 06:19:30 +0000 (11:49 +0530)]
Merge pull request #58224 from Serrini/fix-66490-main

mgr/dashboard: add restful api for creating crush rule with type of 'erasure'

Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agodoc/radosgw: s/http/HTTP/ 58530/head
Zac Dover [Thu, 11 Jul 2024 03:48:39 +0000 (13:48 +1000)]
doc/radosgw: s/http/HTTP/

s/http/HTTP/ in doc/radosgw/s3/authentication.rst, as suggested by
Anthony D'Atri in the location linked in the "Fixes:" line below.

Fixes: https://github.com/ceph/ceph/pull/58436#discussion_r1667088045
Signed-off-by: Zac Dover <zac.dover@proton.me>
12 months agoMerge pull request #58382 from adk3798/cephadm-upgrade-test-start-points
Adam King [Wed, 10 Jul 2024 17:09:33 +0000 (13:09 -0400)]
Merge pull request #58382 from adk3798/cephadm-upgrade-test-start-points

qa/cephadm: change upgrade test start point to reef/squid

Reviewed-by: John Mulligan <jmulligan@redhat.com>
12 months agoMerge pull request #58440 from jmolmo/tls_4_exporter
Redouane Kachach [Wed, 10 Jul 2024 16:17:20 +0000 (18:17 +0200)]
Merge pull request #58440 from jmolmo/tls_4_exporter

exporter: Added https(TLSv13) support

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
12 months agoMerge pull request #58343 from skritik098/rgw-module-period-commit-retry-fix
Adam King [Wed, 10 Jul 2024 15:15:45 +0000 (11:15 -0400)]
Merge pull request #58343 from skritik098/rgw-module-period-commit-retry-fix

mgr/rgw: Adding a retry config while calling zone_create()

Reviewed-by: Adam King <adking@redhat.com>
12 months agoMerge pull request #58326 from adk3798/mgr-rgw-realm-token
Adam King [Wed, 10 Jul 2024 15:14:04 +0000 (11:14 -0400)]
Merge pull request #58326 from adk3798/mgr-rgw-realm-token

mgr/rgw: fix setting rgw realm token in secondary site rgw spec

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
12 months agoMerge pull request #58321 from adk3798/jinja2-cephadm-rhel9
Adam King [Wed, 10 Jul 2024 15:08:02 +0000 (11:08 -0400)]
Merge pull request #58321 from adk3798/jinja2-cephadm-rhel9

cephadm: make cephadm compatible with jinja2 2.11.3

Reviewed-by: Adam King <adking@redhat.com>
12 months agomgr/dashboard: fall back to server_cert 57712/head
Nizamudeen A [Mon, 27 May 2024 04:35:21 +0000 (10:05 +0530)]
mgr/dashboard: fall back to server_cert

if root_ca is not found

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 0a393ca9bde714524da369caaef1c097472f791c)

12 months agoMerge pull request #58298 from thegreenbear/cephadm-ingress-fix-ipv6-binding
Adam King [Wed, 10 Jul 2024 14:39:23 +0000 (10:39 -0400)]
Merge pull request #58298 from thegreenbear/cephadm-ingress-fix-ipv6-binding

Ingress service: Fix HAProxy to listen on IPv4 and IPv6

Reviewed-by: Adam King <adking@redhat.com>
12 months agoMerge pull request #57535 from rkachach/fix_issue_66095
Adam King [Wed, 10 Jul 2024 14:33:06 +0000 (10:33 -0400)]
Merge pull request #57535 from rkachach/fix_issue_66095

Adding support for ceph mgmt-gateway

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
12 months agoMerge pull request #58048 from mohit84/issue_66268
Yuri Weinstein [Wed, 10 Jul 2024 13:41:56 +0000 (06:41 -0700)]
Merge pull request #58048 from mohit84/issue_66268

mgr: the mojibake characters in the MGR OP tracker output

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
12 months agoMerge pull request #57808 from rzarzynski/wip-bug-66297
Yuri Weinstein [Wed, 10 Jul 2024 13:41:32 +0000 (06:41 -0700)]
Merge pull request #57808 from rzarzynski/wip-bug-66297

 mon: validate everybody understands MSR on set-require-min-compat-client

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
12 months agoMerge pull request #57777 from rzarzynski/wip-bug-66285
Yuri Weinstein [Wed, 10 Jul 2024 13:40:50 +0000 (06:40 -0700)]
Merge pull request #57777 from rzarzynski/wip-bug-66285

osd: bump versions of decoders for upmap-primary

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Josh Salomon <josh.salomon@gmail.com>
12 months agoMerge pull request #57005 from cfsnyder/wip-cfsnyder-63195
Yuri Weinstein [Wed, 10 Jul 2024 13:39:33 +0000 (06:39 -0700)]
Merge pull request #57005 from cfsnyder/wip-cfsnyder-63195

mgr/Mgr.cc: clear daemon health metrics instead of removing down/out osd from daemon state

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
12 months agoMerge pull request #58506 from aclamk/wip-aclamk-fix-deferred-tests
Adam Kupczyk [Wed, 10 Jul 2024 13:17:27 +0000 (15:17 +0200)]
Merge pull request #58506 from aclamk/wip-aclamk-fix-deferred-tests

test/objectstore: Fix DeferredReplayTest

12 months agoqa/tasks/cephadm: drop --cluster and sudo in create_rbd_pool() 58507/head
Ilya Dryomov [Wed, 10 Jul 2024 09:53:05 +0000 (11:53 +0200)]
qa/tasks/cephadm: drop --cluster and sudo in create_rbd_pool()

The cluster (name) is already specified in the arguments passed to
_shell() and this command doesn't need privileges.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
12 months agoqa/tasks/cephadm: don't wait for OSDs in create_rbd_pool()
Ilya Dryomov [Wed, 10 Jul 2024 09:02:47 +0000 (11:02 +0200)]
qa/tasks/cephadm: don't wait for OSDs in create_rbd_pool()

This fails because teuthology.wait_until_osds_up() wants to use
adjust-ulimits wrapper which isn't available in "cephadm shell"
environment.  The whole thing is also redundant because cephadm task
is supposed to wait for OSDs to come up earlier, in ceph_osds().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
12 months agoqa/tasks: initialize rbd pool instead of just tagging it
Ilya Dryomov [Wed, 10 Jul 2024 07:10:02 +0000 (09:10 +0200)]
qa/tasks: initialize rbd pool instead of just tagging it

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
12 months agoqa: krbd_data_pool.sh: account for rbd_trash object
Ilya Dryomov [Wed, 10 Jul 2024 07:10:02 +0000 (09:10 +0200)]
qa: krbd_data_pool.sh: account for rbd_trash object

... created since commit 0bcb5cfce9a2 ("librbd/image: create rbd_trash
object during RBD pool initialization").

Fixes: https://tracker.ceph.com/issues/66886
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
12 months agotest/objectstore: Fix DeferredReplayTest 58506/head
Adam Kupczyk [Wed, 10 Jul 2024 08:19:21 +0000 (08:19 +0000)]
test/objectstore: Fix DeferredReplayTest

Created ch = CollectionHandle was not reset, causing valgrind & other
problems.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
12 months agoMerge pull request #55196 from rzarzynski/wip-osd-ec-partial-reads
Radoslaw Zarzynski [Wed, 10 Jul 2024 07:21:51 +0000 (09:21 +0200)]
Merge pull request #55196 from rzarzynski/wip-osd-ec-partial-reads

osd: EC Partial Stripe Reads (Retry of #23138 and #52746)

Reviewed-by: Samuel Just <sjust@redhat.com>
12 months agoexporter: Added https(TLSv13) support 58440/head
Juan Miguel Olmo Martínez [Fri, 5 Jul 2024 08:09:25 +0000 (10:09 +0200)]
exporter: Added https(TLSv13) support

Ceph exporter can run now as http or https server

Signed-off-by: Juan Miguel Olmo Martínez <jolmomar@redhat.com>
12 months agomgr/dashboard: add restful api for creating crush rule with type of 'erasure' 58224/head
sunlan [Mon, 24 Jun 2024 08:29:38 +0000 (16:29 +0800)]
mgr/dashboard: add restful api for creating crush rule with type of 'erasure'
Fixes: https://tracker.ceph.com/issues/66490
Signed-off-by: sunlan <sunlan@asiainfo.com>
12 months agorgw/datalog: fix LazyFIFO race fix 58491/head
Casey Bodley [Tue, 9 Jul 2024 21:40:03 +0000 (17:40 -0400)]
rgw/datalog: fix LazyFIFO race fix

initialize `fifo_tmp` to prevent the race on member variable `fifo` that
was identified in 8fa844383f9c22e758f39ecdda74f70de054ad68

Fixes: https://tracker.ceph.com/issues/66880
Signed-off-by: Casey Bodley <cbodley@redhat.com>
12 months agoMerge pull request #58484 from mcv21/patch-2
Zac Dover [Tue, 9 Jul 2024 21:27:00 +0000 (07:27 +1000)]
Merge pull request #58484 from mcv21/patch-2

doc: Correct link to "Device management"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
12 months agodoc: Correct link to "Device management" 58484/head
Matthew Vernon [Tue, 9 Jul 2024 16:02:31 +0000 (17:02 +0100)]
doc: Correct link to "Device management"

The current link goes to `cephadm/services/rados/operations/devices` which is a 404, it instead needs to be `rados/operations/devices/`.

Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
12 months agomgr/cephadm: introducing nobody/nogroup constants 57535/head
Redouane Kachach [Thu, 27 Jun 2024 10:11:55 +0000 (12:11 +0200)]
mgr/cephadm: introducing nobody/nogroup constants

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
12 months agomgr/cephadm: adding documentation for cephadm mgmt-gateway service
Redouane Kachach [Tue, 9 Jul 2024 12:17:59 +0000 (14:17 +0200)]
mgr/cephadm: adding documentation for cephadm mgmt-gateway service

Signed-off-by: Redouane Kachach <rkachach@ibm.com>
12 months agomgr/cephadm: adding new cephadm service mgmt-gateway
Redouane Kachach [Fri, 17 May 2024 13:19:35 +0000 (15:19 +0200)]
mgr/cephadm: adding new cephadm service mgmt-gateway

adding mgmt-gateway, a new cephadm service based on nginx, to act as
the front-end and single entry point to the cluster. This gateway
offers unified access to all Ceph applications, including the
Ceph dashboard and monitoring tools (Prometheus, Grafana, ..),
while enhancing security and simplifying access management
through nginx.

Fixes: https://tracker.ceph.com/issues/66095
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
12 months agoMerge pull request #58466 from Svelar/test_cookie_cleanup
Ilya Dryomov [Tue, 9 Jul 2024 11:33:01 +0000 (13:33 +0200)]
Merge pull request #58466 from Svelar/test_cookie_cleanup

test/librbd: clean up unused TEST_COOKIE variable

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
12 months agoMerge pull request #55906 from pereman2/synthetic-seed
Adam Kupczyk [Tue, 9 Jul 2024 11:23:08 +0000 (13:23 +0200)]
Merge pull request #55906 from pereman2/synthetic-seed

os/bluestore: store_test reproducible tests with seeds

12 months agoMerge pull request #57890 from aclamk/fix-aclamk-66361
Adam Kupczyk [Tue, 9 Jul 2024 11:21:39 +0000 (13:21 +0200)]
Merge pull request #57890 from aclamk/fix-aclamk-66361

os/bluestore: Fix ExtentDecoderPartial::_consume_new_blob

12 months agoMerge pull request #57369 from YiteGu/bluestore-offline-trim
Adam Kupczyk [Tue, 9 Jul 2024 11:20:19 +0000 (13:20 +0200)]
Merge pull request #57369 from YiteGu/bluestore-offline-trim

tools/bluestore: Add command 'trim' to ceph-bluestore-tool

12 months agoMerge pull request #54327 from pereman2/buffer-space-onode
Adam Kupczyk [Tue, 9 Jul 2024 11:14:54 +0000 (13:14 +0200)]
Merge pull request #54327 from pereman2/buffer-space-onode

os/bluestore: BufferSpace per Onode

12 months agomgr/cephadm: create OrchSecretNotFound exception type
Adam King [Mon, 8 Jul 2024 21:08:00 +0000 (17:08 -0400)]
mgr/cephadm: create OrchSecretNotFound exception type

This exception type is made to handle the formatting
of errors where we try to find a cert/key in the
cert/key store and can't

Signed-off-by: Adam King <adking@redhat.com>
12 months agomgr/dashboard: use secure_channel for grpc requests
Nizamudeen A [Mon, 27 May 2024 04:35:21 +0000 (10:05 +0530)]
mgr/dashboard: use secure_channel for grpc requests

Store the certificates to config-key stores and then later on used by
dashboard to set-up the secure_channel for grpc nvmeof requests

By storing the certificates we can ensure that the dashboard nvmeof apis
will be configurable even if the deployments are not cephadm based

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 0a393ca9bde714524da369caaef1c097472f791c)

12 months agomgr/cephadm: fix nvmeof conf unit test
Adam King [Wed, 3 Jul 2024 20:22:32 +0000 (16:22 -0400)]
mgr/cephadm: fix nvmeof conf unit test

This needed changes to reflect changes made
to the conf to not have the certs stored at a
relative path and the addition of the root ca
cert

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 91883b9efc396779dfb61494e9aa140251f22b54)

12 months agomgr/cephadm: add get cert/key commands
Adam King [Wed, 3 Jul 2024 19:55:12 +0000 (15:55 -0400)]
mgr/cephadm: add get cert/key commands

In order to be able to grab certs/keys stored
in the new CertKeyStore class

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 2dd0ce91a53a898b8b3635f8943cc2d0e39b4ec1)

12 months agomgr/cephadm: integrate nvmeof spec certs/keys into cert/key store
Adam King [Wed, 3 Jul 2024 19:27:03 +0000 (15:27 -0400)]
mgr/cephadm: integrate nvmeof spec certs/keys into cert/key store

Now that we're taking actual certs/keys in the spec, they
should go into the cert/key store with the others

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 3b1ec5851902c6b672db2ea81ae7eebcb1002101)

12 months agotest/ librbd: clean up unused 'TEST_COOKIE' 58466/head
Rongqi Sun [Tue, 9 Jul 2024 02:55:27 +0000 (02:55 +0000)]
test/ librbd: clean up unused 'TEST_COOKIE'

Clean them up because
```
/home/jenkins-build/build/workspace/ceph-pull-requests-arm64/src/test/librbd/exclusive_lock/test_mock_PreAcquireRequest.cc:47:26: error: unused variable 'TEST_COOKIE' [-Werror,-Wunused-const-variable]
static const std::string TEST_COOKIE("auto 123");
                         ^
1 error generated.
```

Ref: https://jenkins.ceph.com/job/ceph-pull-requests-arm64/59242/consoleFull#-5120798632a811ea2-3e7b-466b-84b4-d13df7e35809

Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
12 months agoMerge pull request #58303 from rhcs-dashboard/nfs-export-subvol
Nizamudeen A [Tue, 9 Jul 2024 07:35:12 +0000 (13:05 +0530)]
Merge pull request #58303 from rhcs-dashboard/nfs-export-subvol

mgr/dashboard: nfs export enhancement for CEPHFS

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
12 months agoMerge pull request #58462 from rkhudov/src-test-objecstore-allocism-ops_replayer_fix_...
Pere Diaz Bou [Tue, 9 Jul 2024 05:50:27 +0000 (07:50 +0200)]
Merge pull request #58462 from rkhudov/src-test-objecstore-allocism-ops_replayer_fix_import_rados_buffer_fwd

src/test/objectstore/allocism/ops_replayer.cc: fix rados import

Reviewed-by: Svelar <NOT@FOUND>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
12 months agoMerge PR #53301 into main
Venky Shankar [Tue, 9 Jul 2024 05:38:26 +0000 (11:08 +0530)]
Merge PR #53301 into main

* refs/pull/53301/head:
qa: adding test for preventing scrub when mds is inactive
mds: prevent scrub start for standby-replay MDS

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
12 months agopython-common/service_spec: add root_ca_cert to nvmeof spec
Adam King [Wed, 3 Jul 2024 18:54:47 +0000 (14:54 -0400)]
python-common/service_spec: add root_ca_cert to nvmeof spec

Also improves the error messaging around when spec/key
attributes are missing when enable_auth is set to true

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit 9212914be65fe3adde2108f5a2cfd2587d17c0ff)

12 months agomgr/cephadm: allow passing client/server cert/key in nvmeof spec
Adam King [Thu, 23 May 2024 16:54:25 +0000 (12:54 -0400)]
mgr/cephadm: allow passing client/server cert/key in nvmeof spec

Before this patch the client/server cert/key fields were
just filepaths that told the nvmeof gw daemon where to look
for the cert/key. There's not much reason why users would
care where in the nvmeof gw container the cert goes. It's more
useful to use these fields as a way to pass the certs/keys
to the daemon and then just hardcode where in the container
we'll place the certs/keys

Signed-off-by: Adam King <adking@redhat.com>
(cherry picked from commit e9fca39092348e6c08022341116875e831c175f0)

12 months agosrc/test/objectstore/allocism/ops_replayer.cc: fix rados import 58462/head
rkhudov [Mon, 8 Jul 2024 18:38:04 +0000 (19:38 +0100)]
src/test/objectstore/allocism/ops_replayer.cc: fix rados import

src/test/objectstore/allocism/ops_replayer.cc: fix rados import

Signed-off-by: rkhudov <rkhudov@gmail.com>
12 months agoMerge pull request #58454 from spdfnet/docs
Anthony D'Atri [Mon, 8 Jul 2024 12:51:52 +0000 (08:51 -0400)]
Merge pull request #58454 from spdfnet/docs

doc/cephfs: fix typo

12 months agoMerge pull request #57353 from Svelar/asan_shec
Kefu Chai [Mon, 8 Jul 2024 12:05:45 +0000 (20:05 +0800)]
Merge pull request #57353 from Svelar/asan_shec

crush/builder: free 'crush_rule' before return

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
12 months agoMerge pull request #55917 from Aequitosh/fix-ceph-crash-permissions
Kefu Chai [Mon, 8 Jul 2024 11:57:38 +0000 (19:57 +0800)]
Merge pull request #55917 from Aequitosh/fix-ceph-crash-permissions

debian: recursively adjust permissions of /var/lib/ceph/crash

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
12 months agoqa: adding test for preventing scrub when mds is inactive 53301/head
neeraj pratap singh [Tue, 10 Oct 2023 05:55:31 +0000 (11:25 +0530)]
qa: adding test for preventing scrub when mds is inactive

Fixes: https://tracker.ceph.com/issues/62537
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
12 months agoMerge pull request #58423 from pereman2/scrapper-replayer-argparse
Pere Diaz Bou [Mon, 8 Jul 2024 08:27:29 +0000 (10:27 +0200)]
Merge pull request #58423 from pereman2/scrapper-replayer-argparse

test/allocsim: ops scrapper arg parsing

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
12 months agodoc/cephfs: fix typo 58454/head
spdfnet [Mon, 8 Jul 2024 08:03:28 +0000 (09:03 +0100)]
doc/cephfs: fix typo

blanacer -> balancer

Signed-off-by: spdfnet <32593931+spdfnet@users.noreply.github.com>
12 months agoMerge pull request #58114 from rhcs-dashboard/add-configuration-page-rgw
Nizamudeen A [Mon, 8 Jul 2024 07:57:16 +0000 (13:27 +0530)]
Merge pull request #58114 from rhcs-dashboard/add-configuration-page-rgw

mgr/dashboard: add a new configuration page in side nav bar  Object > Configuration

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #57864 from afreen23/wip-nvmeof-gateways
Ankush Behl [Mon, 8 Jul 2024 06:08:50 +0000 (11:38 +0530)]
Merge pull request #57864 from afreen23/wip-nvmeof-gateways

mgr/dashboard: Introduce NVMe/TCP navigation

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agomgr/dashboard: add a new configuration page in side nav bar Object > 58114/head
Aashish Sharma [Tue, 18 Jun 2024 11:13:07 +0000 (16:43 +0530)]
mgr/dashboard: add a new configuration page in side nav bar  Object >
Configuration

Fixes: https://tracker.ceph.com/issues/66543
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
12 months agoMerge pull request #57828 from xxhdx1985126/wip-seastore-btree-better-ut-asserts
Yingxin [Mon, 8 Jul 2024 02:59:01 +0000 (10:59 +0800)]
Merge pull request #57828 from xxhdx1985126/wip-seastore-btree-better-ut-asserts

crimson/os/seastore/btree: improve lba pointer related UT checks

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
12 months agoMerge pull request #58356 from xxhdx1985126/wip-seastore-onode-name
Yingxin [Mon, 8 Jul 2024 02:57:43 +0000 (10:57 +0800)]
Merge pull request #58356 from xxhdx1985126/wip-seastore-onode-name

crimson/os/seastore/onode: add hobject_t into Onode

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
12 months agoMerge pull request #58179 from cbodley/wip-rgw-assert-async
Casey Bodley [Fri, 5 Jul 2024 14:50:45 +0000 (15:50 +0100)]
Merge pull request #58179 from cbodley/wip-rgw-assert-async

rgw: test that no asio threads are blocked on null_yield

Reviewed-by: Adam Emerson <aemerson@redhat.com>
12 months agoMerge pull request #58288 from cbodley/wip-66705
Casey Bodley [Fri, 5 Jul 2024 14:50:19 +0000 (15:50 +0100)]
Merge pull request #58288 from cbodley/wip-66705

rgw: fix multipart get part when count==1

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
12 months agoMerge pull request #56834 from galsalomon66/fix_error_message_flow
Casey Bodley [Fri, 5 Jul 2024 14:03:51 +0000 (15:03 +0100)]
Merge pull request #56834 from galsalomon66/fix_error_message_flow

rgw/s3select : fix for error flow. add an option to disable s3select-request.

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
12 months agomgr/dashboard: nfs export enhancement for CEPHFS 58303/head
Avan Thakkar [Thu, 27 Jun 2024 10:06:42 +0000 (15:36 +0530)]
mgr/dashboard: nfs export enhancement for CEPHFS

Fixes: https://tracker.ceph.com/issues/66718
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
12 months agoMerge pull request #58199 from tchaikov/wip-python3.9
Kefu Chai [Fri, 5 Jul 2024 13:30:17 +0000 (21:30 +0800)]
Merge pull request #58199 from tchaikov/wip-python3.9

mgr: use un-deprecated APIs to initialize Python interpretor

Reviewed-by: Adam King <adking@redhat.com>
12 months agotest/allocsim: ops scrapper arg parsing 58423/head
Pere Diaz Bou [Thu, 4 Jul 2024 10:20:07 +0000 (12:20 +0200)]
test/allocsim: ops scrapper arg parsing

```
fedora :: pere/scrapper-replayer/build 130 » ./bin/replayer -h
All options:

Options:
  -h [ --help ]                 produce help message
  -i arg (=input.txt)           Input file (output of op_scraper.py)
  --ceph-conf arg (=ceph.conf)  Path to ceph conf
  --io-depth arg (=64)          I/O depth
  --parser-threads arg (=16)    Number of parser threads
  --worker-threads arg (=16)    Number of I/O worker threads
  --pool arg (=test_pool)       Pool to use for I/O
```

Signed-off-by: Pere Diaz Bou <pere-altea@hotmail.com>
12 months agomgr/dashboard: fix service form count bugs 57864/head
Afreen Misbah [Sat, 22 Jun 2024 02:18:33 +0000 (07:48 +0530)]
mgr/dashboard: fix service form count bugs

Fixes https://tracker.ceph.com/issues/66608

- for services which do not have a count set default count to be null, otherwise the previous selected service's count is used which is wrong
- make count null when label is selected for placement

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
12 months agomgr/dashboard: Introduce NVMe/TCP navigation
Afreen [Fri, 31 May 2024 07:54:27 +0000 (13:24 +0530)]
mgr/dashboard: Introduce NVMe/TCP navigation

Fixes https://tracker.ceph.com/issues/66346

- adds NVMe/TCP tab under Block nav
- adds overview page for NVMe/TCP nav
- overview page lists gateways
- add default error page when no nvmeof service running
- added unit tests
- fixes service page e2e test

Signed-off-by: Afreen <afreen23.git@gmail.com>
12 months agoMerge pull request #58427 from Matan-B/wip-matanb-seastar-string
Adam Kupczyk [Fri, 5 Jul 2024 07:54:11 +0000 (09:54 +0200)]
Merge pull request #58427 from Matan-B/wip-matanb-seastar-string

seastar: fix makecheck error: missing 'typename'

12 months agoMerge pull request #58414 from cbodley/wip-cmake-object-library-legacy-headers
Casey Bodley [Thu, 4 Jul 2024 21:31:06 +0000 (22:31 +0100)]
Merge pull request #58414 from cbodley/wip-cmake-object-library-legacy-headers

cmake: more object libraries depend on legacy-option-headers

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
12 months agoMerge pull request #58428 from cbodley/wip-rm-boost-redis-again
Casey Bodley [Thu, 4 Jul 2024 20:16:15 +0000 (21:16 +0100)]
Merge pull request #58428 from cbodley/wip-rm-boost-redis-again

submodule: remove the boost_redis submodule again

Reviewed-by: Adam Emerson <aemerson@redhat.com>
12 months agoMerge pull request #58434 from cbodley/wip-42888
Casey Bodley [Thu, 4 Jul 2024 20:12:22 +0000 (21:12 +0100)]
Merge pull request #58434 from cbodley/wip-42888

doc/rgw: update s3 authentication

Reviewed-by: Zac Dover <zac.dover@proton.me>
12 months agodoc/rgw: update s3 authentication 58434/head
Casey Bodley [Thu, 4 Jul 2024 19:17:52 +0000 (15:17 -0400)]
doc/rgw: update s3 authentication

authentication.rst described the steps to generate a v2 signature,
without reference to aws docs. replace that with sections that reference
aws docs for v2 and v4 signatures. list which values of the request
header x-amz-content-sha256 are supported for v4

Fixes: https://tracker.ceph.com/issues/42888
Signed-off-by: Casey Bodley <cbodley@redhat.com>
12 months agoMerge pull request #58429 from cbodley/wip-rgw-xxhash-debug
Casey Bodley [Thu, 4 Jul 2024 19:38:58 +0000 (20:38 +0100)]
Merge pull request #58429 from cbodley/wip-rgw-xxhash-debug

cmake: work around xxhash 'inlining failed' errors in debug builds

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
12 months agoMerge pull request #58368 from zdover23/wip-doc-2024-07-01-rados-config-mon-lookup-dns
Zac Dover [Thu, 4 Jul 2024 18:25:25 +0000 (04:25 +1000)]
Merge pull request #58368 from zdover23/wip-doc-2024-07-01-rados-config-mon-lookup-dns

doc/rados: document manually passing search domain

Reviewed-by: Lander Duncan <landerduncan@nyu.edu>
Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
12 months agocmake: work around xxhash 'inlining failed' errors in debug builds 58429/head
Casey Bodley [Wed, 26 Jun 2024 22:17:13 +0000 (18:17 -0400)]
cmake: work around xxhash 'inlining failed' errors in debug builds

rgw enables the XXH_INLINE_ALL define, but this causes debug builds to
fail with errors like "inlining failed in call to ‘always_inline’"

for build types Debug and RelWithDebInfo, add extra define
XXH_NO_INLINE_HINTS to remove the always_inline hints causing this error

Signed-off-by: Casey Bodley <cbodley@redhat.com>
12 months agosubmodule: remove the boost_redis submodule again 58428/head
Casey Bodley [Thu, 4 Jul 2024 16:20:27 +0000 (12:20 -0400)]
submodule: remove the boost_redis submodule again

b6d585645ca7d469fd9fe453ff37ca6bdb914d98 accidentally added back the
boost_redis submodule that was removed in 862246cdefc12acfbd2711c7677a252c59634c9d

Signed-off-by: Casey Bodley <cbodley@redhat.com>
12 months agomgr/dashboard: add cephfs rename REST API 58386/head
yite.gu [Tue, 2 Jul 2024 06:17:52 +0000 (14:17 +0800)]
mgr/dashboard: add cephfs rename REST API

Introduce rename for the cephfs REST API controller, we can
rename the existing file or directory by it.

Fixes: https://tracker.ceph.com/issues/66797
Signed-off-by: Yite Gu <yitegu0@gmail.com>
12 months agoMerge pull request #58387 from rhcs-dashboard/rgw-sync-policy-crud-ops
Nizamudeen A [Thu, 4 Jul 2024 14:48:00 +0000 (20:18 +0530)]
Merge pull request #58387 from rhcs-dashboard/rgw-sync-policy-crud-ops

mgr/dashboard: RGW sync policy crud operations

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoseastar: fix makecheck error: missing 'typename' 58427/head
Matan Breizman [Thu, 4 Jul 2024 13:39:09 +0000 (16:39 +0300)]
seastar: fix makecheck error: missing 'typename'

update seastar submodule to wip-matanb-seastar-july4
Reverting https://github.com/scylladb/seastar/commit/8a3dc425dd9bff7a00ffa3345768e01b1a24825f

This revert is pushed to not block all other PRs that are failing make
check due to this.

Fixes: https://tracker.ceph.com/issues/66834
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
12 months agoMerge pull request #58408 from AliMasarweh/wip-alimasa-http-to-kafka
Ali Masarwa [Thu, 4 Jul 2024 13:17:49 +0000 (16:17 +0300)]
Merge pull request #58408 from AliMasarweh/wip-alimasa-http-to-kafka

RGW|BN : change endpoint for http failing tests

Reviewed-by: yuvalif<ylifshit@redhat.com>
12 months agoMerge pull request #57716 from rhcs-dashboard/add-rgw-multisite-wizard-api
Aashish Sharma [Thu, 4 Jul 2024 12:05:00 +0000 (17:35 +0530)]
Merge pull request #57716 from rhcs-dashboard/add-rgw-multisite-wizard-api

mgr/dashboard: add api for rgw multisite replication wizard

Reviewed-by: Nizamudeen A <nia@redhat.com>