]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
11 months agodoc: Amend dev mailing list subscribe instructions. 58695/head
Paulo E. Castro [Sat, 20 Jul 2024 16:32:17 +0000 (17:32 +0100)]
doc: Amend dev mailing list subscribe instructions.

Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
12 months agoMerge pull request #58591 from idryomov/wip-aio-completion-prep-for-atomic-wait
Ilya Dryomov [Sat, 20 Jul 2024 09:05:47 +0000 (11:05 +0200)]
Merge pull request #58591 from idryomov/wip-aio-completion-prep-for-atomic-wait

librbd: fix inconsistency between AioCompletion is_complete() and wait_for_complete()

Reviewed-by: N Balachandran <nibalach@redhat.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
12 months agoMerge pull request #58180 from guojidan/format
Ilya Dryomov [Sat, 20 Jul 2024 09:03:52 +0000 (11:03 +0200)]
Merge pull request #58180 from guojidan/format

rbd: add the validate of the format and clone_format

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
12 months agoMerge pull request #52639 from ljflores/wip-tracker-58925
Laura Flores [Fri, 19 Jul 2024 18:18:55 +0000 (13:18 -0500)]
Merge pull request #52639 from ljflores/wip-tracker-58925

qa: suppress Leak_StillReachable mon leak in centos 9 jobs

12 months agoMerge pull request #58671 from zdover23/wip-doc-2024-07-19-start-get-involved
Zac Dover [Fri, 19 Jul 2024 17:10:17 +0000 (03:10 +1000)]
Merge pull request #58671 from zdover23/wip-doc-2024-07-19-start-get-involved

doc/start: update mailing list links

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
12 months agoMerge pull request #58678 from cbodley/wip-doc-cephadm-quay-ci
Zac Dover [Fri, 19 Jul 2024 14:57:01 +0000 (00:57 +1000)]
Merge pull request #58678 from cbodley/wip-doc-cephadm-quay-ci

doc/cephadm/upgrade: ceph-ci containers are hosted at quay.ceph.io

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Adam King <adking@redhat.com>
12 months agodoc/cephadm/upgrade: ceph-ci containers are hosted by quay.ceph.io 58678/head
Casey Bodley [Fri, 19 Jul 2024 14:10:38 +0000 (10:10 -0400)]
doc/cephadm/upgrade: ceph-ci containers are hosted by quay.ceph.io

Signed-off-by: Casey Bodley <cbodley@redhat.com>
12 months agoMerge pull request #57737 from Svelar/asan_rgw_amqp
Yuval Lifshitz [Fri, 19 Jul 2024 13:47:35 +0000 (16:47 +0300)]
Merge pull request #57737 from Svelar/asan_rgw_amqp

rgw/amqp: lock erase and create connection before emplace

12 months agoMerge pull request #58662 from yuvalif/wip-yuval-64690-again
Yuval Lifshitz [Fri, 19 Jul 2024 13:42:39 +0000 (16:42 +0300)]
Merge pull request #58662 from yuvalif/wip-yuval-64690-again

test/rgw/amqp: skip TestAMQP.MaxConnections test

12 months agoMerge pull request #58656 from rhcs-dashboard/rgw-sync-policy-routing-fix
Nizamudeen A [Fri, 19 Jul 2024 13:25:42 +0000 (18:55 +0530)]
Merge pull request #58656 from rhcs-dashboard/rgw-sync-policy-routing-fix

mgr/dashboard: Rgw sync policy routing fix

Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #56331 from rhcs-dashboard/update-mon-stacks
Nizamudeen A [Fri, 19 Jul 2024 07:40:40 +0000 (13:10 +0530)]
Merge pull request #56331 from rhcs-dashboard/update-mon-stacks

mgr/cephadm: bump monitoring stacks versions

12 months agodoc/start: update mailing list links 58671/head
Zac Dover [Fri, 19 Jul 2024 06:44:44 +0000 (16:44 +1000)]
doc/start: update mailing list links

Update the User and Dev mailing list subscription links. This commit is
made in response to a request from Dan van der Ster.

Signed-off-by: Zac Dover <zac.dover@proton.me>
12 months agoMerge pull request #58636 from afreen23/wip-nvmeof-namespace
Nizamudeen A [Fri, 19 Jul 2024 05:59:42 +0000 (11:29 +0530)]
Merge pull request #58636 from afreen23/wip-nvmeof-namespace

mgr/dashboard: Add namespaces views in dashboard

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #58519 from smanjara/wip-fix-copy-obj-replication
J. Eric Ivancich [Thu, 18 Jul 2024 20:02:58 +0000 (16:02 -0400)]
Merge pull request #58519 from smanjara/wip-fix-copy-obj-replication

rgw/multisite: don't retain RGW_ATTR_OBJ_REPLICATION_TRACE attr on copy_object

Reviewed-by: Casey Bodley <cbodley@redhat.com>
12 months agoMerge pull request #56937 from Svelar/asan_bluestore_type
Yuri Weinstein [Thu, 18 Jul 2024 19:48:07 +0000 (12:48 -0700)]
Merge pull request #56937 from Svelar/asan_bluestore_type

bluestore/bluestore_types: avoid heap-buffer-overflow in another way to keep code uniformity

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
12 months agoMerge pull request #56352 from ifed01/wip-ifed-many-many-extents-read
Yuri Weinstein [Thu, 18 Jul 2024 19:47:09 +0000 (12:47 -0700)]
Merge pull request #56352 from ifed01/wip-ifed-many-many-extents-read

blk/aio: fix long batch (64+K entries) submission.

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
12 months agoMerge pull request #54988 from Matan-B/wip-matanb-mapgap-fix
Yuri Weinstein [Thu, 18 Jul 2024 19:46:36 +0000 (12:46 -0700)]
Merge pull request #54988 from Matan-B/wip-matanb-mapgap-fix

osd/OSD: rewrite track_pools_and_pg_num_changes logic

Reviewed-by: Samuel Just <sjust@redhat.com>
12 months agoqa: suppress Leak_StillReachable mon leaks 52639/head
Laura Flores [Thu, 18 Jul 2024 15:52:58 +0000 (10:52 -0500)]
qa: suppress Leak_StillReachable mon leaks

These leaks came about when we changed the distro
from centos 8 to centos 9.

Fixes: https://tracker.ceph.com/issues/61774
Signed-off-by: Laura Flores <lflores@ibm.com>
12 months agoMerge pull request #57817 from phlogistonjohn/jjm-smb-sqlite
Adam King [Thu, 18 Jul 2024 14:58:16 +0000 (10:58 -0400)]
Merge pull request #57817 from phlogistonjohn/jjm-smb-sqlite

mgr/smb: add sqlite internal store backend for smb mgr module

Reviewed-by: Adam King <adking@redhat.com>
12 months agoMerge pull request #58518 from anoopcs9/smb-mgr-updates
Adam King [Thu, 18 Jul 2024 14:56:11 +0000 (10:56 -0400)]
Merge pull request #58518 from anoopcs9/smb-mgr-updates

mgr/smb: improvements to smb mgr module and docs

Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
12 months agomgr/dashboard: Add namespaces views in dashboard 58636/head
Afreen Misbah [Tue, 16 Jul 2024 07:03:26 +0000 (12:33 +0530)]
mgr/dashboard: Add namespaces views in dashboard

Fixes https://tracker.ceph.com/issues/66990

- list namespaces
- create namespaces
- edit namespaces
- delete namespaces
- update NQN regex

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
12 months agoMerge pull request #58644 from rhcs-dashboard/fix-66994-main
Ankush Behl [Thu, 18 Jul 2024 13:24:29 +0000 (18:54 +0530)]
Merge pull request #58644 from rhcs-dashboard/fix-66994-main

mgr/dashboard: Add a new chart for replication delta per shard in rgw sync overview grafana dashboard

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
12 months agoMerge pull request #58649 from cbodley/wip-64173
Casey Bodley [Thu, 18 Jul 2024 13:00:09 +0000 (14:00 +0100)]
Merge pull request #58649 from cbodley/wip-64173

rgw/rados: set_attrs() falls back to existing attrs for index update

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
12 months agomgr/dashboard: rgw sync policy routing fixes 58656/head
Naman Munet [Wed, 17 Jul 2024 10:04:55 +0000 (15:34 +0530)]
mgr/dashboard: rgw sync policy routing fixes

Fixes: https://tracker.ceph.com/issues/66977
Signed-off-by: Naman Munet <nmunet@redhat.com>
12 months agoMerge pull request #58173 from ronen-fr/wip-rf-targets-j13
Ronen Friedman [Thu, 18 Jul 2024 11:15:04 +0000 (14:15 +0300)]
Merge pull request #58173 from ronen-fr/wip-rf-targets-j13

osd/scrub: no shared scrub-job ownership between PGs and the scrub queue

Reviewed-by: Samuel Just <sjust@redhat.com>
12 months agotest/rgw/amqp: skip TestAMQP.MaxConnections test 58662/head
Yuval Lifshitz [Thu, 18 Jul 2024 11:11:25 +0000 (11:11 +0000)]
test/rgw/amqp: skip TestAMQP.MaxConnections test

not really a fix, mainly a workaround until we do
the amqp refactoring: https://tracker.ceph.com/issues/67011

Fixes: https://tracker.ceph.com/issues/64690
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
12 months agoMerge pull request #58555 from rhcs-dashboard/rgw-multisite-sync-pipe
Pedro Gonzalez Gomez [Thu, 18 Jul 2024 10:32:10 +0000 (12:32 +0200)]
Merge pull request #58555 from rhcs-dashboard/rgw-multisite-sync-pipe

 mgr/dashboard: RGW multisite sync pipe

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
12 months agoMerge pull request #58648 from afreen23/wip-nvmeof-listener
Nizamudeen A [Thu, 18 Jul 2024 06:48:09 +0000 (12:18 +0530)]
Merge pull request #58648 from afreen23/wip-nvmeof-listener

Allow listeners creation and deletion

Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #58551 from xxhdx1985126/wip-66924
Yingxin [Thu, 18 Jul 2024 06:09:54 +0000 (14:09 +0800)]
Merge pull request #58551 from xxhdx1985126/wip-66924

crimson/os/seastore/transaction_manager: consider inconsistency between backrefs and lbas acceptable when cleaning segments

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
12 months agoMerge pull request #58441 from rhcs-dashboard/add-nfs-export-route
Ankush Behl [Thu, 18 Jul 2024 05:49:59 +0000 (11:19 +0530)]
Merge pull request #58441 from rhcs-dashboard/add-nfs-export-route

mgr/dashboard: add NFS export button for subvolume/ grp

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #57591 from aclamk/wip-aclamk-denc-compat-check
Radoslaw Zarzynski [Wed, 17 Jul 2024 23:52:42 +0000 (01:52 +0200)]
Merge pull request #57591 from aclamk/wip-aclamk-denc-compat-check

common, os/bluestore: Fix lack of checking for compat on DENC_START

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
12 months agomgr/dashboard: Create and delete listeners 58648/head
Afreen Misbah [Wed, 17 Jul 2024 10:16:23 +0000 (15:46 +0530)]
mgr/dashboard: Create and delete listeners

Fixes https://tracker.ceph.com/issues/66996

- list listener under subsystems
- delete listener
- create listener

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
12 months agomgr/dashboard: RGW multisite sync pipe 58555/head
Naman Munet [Thu, 11 Jul 2024 18:40:51 +0000 (00:10 +0530)]
mgr/dashboard: RGW multisite sync pipe

Fixes: https://tracker.ceph.com/issues/66926
Signed-off-by: Naman Munet <nmunet@redhat.com>
12 months agorgw/rados: set_attrs() falls back to existing attrs for index update 58649/head
Casey Bodley [Wed, 17 Jul 2024 14:28:08 +0000 (10:28 -0400)]
rgw/rados: set_attrs() falls back to existing attrs for index update

set_attrs() needs the ACLOwner, etag, content-type and storage class for
the bucket index update. if those attrs aren't being updated, consult
their existing attrs in state->attrset

Fixes: https://tracker.ceph.com/issues/64173
Signed-off-by: Casey Bodley <cbodley@redhat.com>
12 months agomgr/dashboard: add NFS export route from subvolume/subvolume grp 58441/head
Avan Thakkar [Fri, 5 Jul 2024 09:29:13 +0000 (14:59 +0530)]
mgr/dashboard: add NFS export route from subvolume/subvolume grp

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
12 months agomgr/dashboard: Add a new chart for replication delta per shard in rgw sync overview... 58644/head
Aashish Sharma [Wed, 17 Jul 2024 09:07:49 +0000 (14:37 +0530)]
mgr/dashboard: Add a new chart for replication delta per shard in rgw sync overview grafana dashboard

Fixes: https://tracker.ceph.com/issues/66994
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
12 months agoMerge pull request #57722 from sajibreadd/wip-62500
Adam Kupczyk [Wed, 17 Jul 2024 09:57:45 +0000 (11:57 +0200)]
Merge pull request #57722 from sajibreadd/wip-62500

os/bluestore: Warning added for slow operations and stalled read

12 months agolibrbd: get rid of AIO_STATE_CALLBACK in AioCompletion 58591/head
Ilya Dryomov [Mon, 15 Jul 2024 09:39:11 +0000 (11:39 +0200)]
librbd: get rid of AIO_STATE_CALLBACK in AioCompletion

After commit 002afa0fe375 ("librbd: avoid using lock within AIO
completion where possible"), the only method whose behavior would
change if AIO_STATE_CALLBACK is removed is is_complete() and it
actually needs fixing anyway: because of state != AIO_STATE_PENDING
test, is_complete() returns true both for AIO_STATE_CALLBACK and
AIO_STATE_COMPLETE, while wait_for_complete() still blocks on
AIO_STATE_CALLBACK and returns only on AIO_STATE_COMPLETE.  These
methods back public APIs, so this inconsistency is exposed to users.

If we move to setting state to AIO_STATE_COMPLETE at the top of
mark_complete_and_notify() (i.e. before event socket notification), the
transient state for callbacks can be eliminated entirely and the
inconsistency goes away.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
12 months agoMerge pull request #58571 from zdover23/wip-doc-2024-07-13-cephfs-mount-using-fuse
Zac Dover [Wed, 17 Jul 2024 07:24:43 +0000 (17:24 +1000)]
Merge pull request #58571 from zdover23/wip-doc-2024-07-13-cephfs-mount-using-fuse

doc/cephfs: improve mount-using-fuse

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
12 months agodoc/cephfs: improve mount-using-fuse 58571/head
Zac Dover [Sat, 13 Jul 2024 00:32:31 +0000 (10:32 +1000)]
doc/cephfs: improve mount-using-fuse

Improve the first twenty percent of doc/cephfs/mount-using-fuse.rst.
This commit changes the text so that it is clearer that FUSE is an
alternative to mounting CephFS with the kernel driver. This commit also
links to the kernel driver page from the "FUSE-mount" page.

Signed-off-by: Zac Dover <zac.dover@proton.me>
12 months agocrimson/os/seastore/transaction_manager: consider inconsistency between 58551/head
Xuehan Xu [Fri, 12 Jul 2024 10:14:53 +0000 (18:14 +0800)]
crimson/os/seastore/transaction_manager: consider inconsistency between
backrefs and lbas acceptable when cleaning segments

Consider the following scene:
1. Trans.A writes the final record of Segment S, in which it overwrite
   another extent E in the same segment S;
2. Before Trans.A "complete_commit", Trans.B tries to rewrite new
   records and roll the segments, which closes Segment S;
3. Before Trans.A "complete_commit", a new cleaner Transaction C tries
   to clean the segment;

In this scenario, C might see a part of extent E's laddr space mapped
to another location within the same segment S. This is actually a valid
case.

Fixes: https://tracker.ceph.com/issues/66924
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
12 months agoMerge pull request #57169 from jagombar/fixCpatch
Josh Durgin [Tue, 16 Jul 2024 22:54:41 +0000 (15:54 -0700)]
Merge pull request #57169 from jagombar/fixCpatch

cpatch: Search base image when patching files.

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
12 months agoMerge pull request #57906 from kamoltat/wip-ksirivad-stretch-mode-netsplit-test
Yuri Weinstein [Tue, 16 Jul 2024 22:08:20 +0000 (15:08 -0700)]
Merge pull request #57906 from kamoltat/wip-ksirivad-stretch-mode-netsplit-test

mon/ElectionLogic: tie-breaker mon ignore proposal from marked down mon

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
12 months agoMerge pull request #57592 from Svelar/asan_ec_shec_t
Yuri Weinstein [Tue, 16 Jul 2024 22:07:14 +0000 (15:07 -0700)]
Merge pull request #57592 from Svelar/asan_ec_shec_t

ec: free plugin memory when it destructs and repeated loads

Reviewed-by: Kefu Chai <tchaikov@gmail.com>
12 months agoMerge pull request #57201 from NitzanMordhai/wip-nitzan-standalone-pg-split-merge...
Yuri Weinstein [Tue, 16 Jul 2024 22:06:23 +0000 (15:06 -0700)]
Merge pull request #57201 from NitzanMordhai/wip-nitzan-standalone-pg-split-merge-daemon-commands

test: ceph daemon command with asok path

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
12 months agoMerge pull request #56982 from NitzanMordhai/wip-nitzan-neorados-watch-notify-test...
Yuri Weinstein [Tue, 16 Jul 2024 22:05:00 +0000 (15:05 -0700)]
Merge pull request #56982 from NitzanMordhai/wip-nitzan-neorados-watch-notify-test-reconnect

test/neorados: timeout test won't reconnect at timeout

Reviewed-by: Adam Emerson <aemerson@redhat.com>
12 months agoMerge pull request #56605 from myoungwon/wip-65241
Yuri Weinstein [Tue, 16 Jul 2024 22:03:53 +0000 (15:03 -0700)]
Merge pull request #56605 from myoungwon/wip-65241

osd: fix use-after-free before calling finish_unreadable_object()

Reviewed-by: Samuel Just <sjust@redhat.com>
12 months agoMerge pull request #58354 from ivancich/wip-appropriate-min-objs-shard
J. Eric Ivancich [Tue, 16 Jul 2024 18:43:56 +0000 (14:43 -0400)]
Merge pull request #58354 from ivancich/wip-appropriate-min-objs-shard

rgw: make sure min objs per shard is appropriate

Reviewed-by: Casey Bodley <cbodley@redhat.com>
12 months agoMerge pull request #58442 from clwluvw/getlocation-contenttype
J. Eric Ivancich [Tue, 16 Jul 2024 18:42:56 +0000 (14:42 -0400)]
Merge pull request #58442 from clwluvw/getlocation-contenttype

rgw: add missing content-type for RGWGetBucketLocation

Reviewed-by: Casey Bodley <cbodley@redhat.com>
12 months agoMerge pull request #57640 from cbodley/wip-rgw-beast-realm-reload
J. Eric Ivancich [Tue, 16 Jul 2024 16:27:22 +0000 (12:27 -0400)]
Merge pull request #57640 from cbodley/wip-rgw-beast-realm-reload

rgw/beast: realm reload closes connections so requests drain quickly

Reviewed-by: Oguzhan Ozmen <oozmen@bloomberg.net>
12 months agoMerge pull request #58567 from ivancich/wip-reshard-cleanups
J. Eric Ivancich [Tue, 16 Jul 2024 16:25:45 +0000 (12:25 -0400)]
Merge pull request #58567 from ivancich/wip-reshard-cleanups

rgw: add reshard status to bucket stats plus minor misc items

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
12 months agomgr/dashboard: nvmf apis broken for insecure channel
Nizamudeen A [Tue, 16 Jul 2024 14:33:24 +0000 (20:03 +0530)]
mgr/dashboard: nvmf apis broken for insecure channel

because when no certificate, it raises an exception which stops the api call
abruptly.

Signed-off-by: Nizamudeen A <nia@redhat.com>
12 months agoosd/scrub: fix job requeue conditions 58173/head
Ronen Friedman [Wed, 10 Jul 2024 07:06:09 +0000 (02:06 -0500)]
osd/scrub: fix job requeue conditions

Previous commits handled the following two cases correctly:
- requeueing a scrub job while the OSD is still the primary, and
- not restoring the scrub job to the queue if the PG is not there;
Here we handle the missed scenario: the PG is there (we were able to
lock it), but is no longer the primary.

Also - a configuration change must not cause a re-queue of a
scrub-job for a PG that is in the middle of scrubbing.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
12 months agotest/osd: delete test_scrub_sched (for now)
Ronen Friedman [Sun, 7 Jul 2024 10:19:39 +0000 (05:19 -0500)]
test/osd: delete test_scrub_sched (for now)

removing this unit-test, as it must be rewritten to match the
changes in the implementation of the scrub scheduling mechanism,
and that implementation is still in flux.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
12 months agoosd/scrub: making osd_scrub_sched.cc compatible with Clang-14
Ronen Friedman [Thu, 4 Jul 2024 15:37:09 +0000 (10:37 -0500)]
osd/scrub: making osd_scrub_sched.cc compatible with Clang-14

Removing the use of C++ ranges, as
Clang versions below 16 are buggy when libstd++ ranges are used.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
12 months agoqa/standalone/scrub: fix osd-scrub-test.sh
Ronen Friedman [Wed, 26 Jun 2024 15:02:19 +0000 (10:02 -0500)]
qa/standalone/scrub: fix osd-scrub-test.sh

following changes in scrub code

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
12 months agoosd/scrub: scheduling the next scrub following scrub completion
Ronen Friedman [Thu, 20 Jun 2024 13:04:41 +0000 (08:04 -0500)]
osd/scrub: scheduling the next scrub following scrub completion

or after an aborted scrub.

To note: one of the important changes in this commit:
merging the functionality of adjust_target_time() &
update_schedule() into a single function - adjust_schedule().

Regarding the handling of aborts:

Most of the time - all that is required following a scrub abort is to
requeue the scrub job - the one that triggered the aborted scrub -
with just a delay added to its n.b..

But we must take into account scenarios where "something" caused the
parameters prepared for the *next* scrub to show higher urgency or
priority. "Something" - as in an operator command requiring immediate
scrubbing, or a change in the pool/cluster configuration.
In such cases - the current requested flags and the parameters of
the aborted scrub must be merged.

Note that the current implementation is a temporary solution, to be
replaced by a per-level updating of the relevant target.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
12 months agoosd/scrub: improve update_scrub_job()
Ronen Friedman [Mon, 1 Jul 2024 14:06:54 +0000 (09:06 -0500)]
osd/scrub: improve update_scrub_job()

...and on_scrub_schedule_input_change()
by accepting a parameter to control whether the scheduled time for
periodic scrubs that are already due should be updated.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
12 months agoosd/scrub: passing the scrub-job copy through the scrubber
Ronen Friedman [Sun, 16 Jun 2024 15:49:27 +0000 (10:49 -0500)]
osd/scrub: passing the scrub-job copy through the scrubber

moving the scrubbed sjob copy thru the scrubber - from scrub
session initiation to its termination (or abort - where we use the
handed "old version" of the sjob to update the new one).

Note that in this version - not all the information that was used to
determine the specifics of the initiated scrub is passed to the
scrubber and back. In this half-baked stage of the refactoring,
the resulting implementation handling of corner cases, still using
the "planned scrub" flags, is less than optimal.

The next step (dual targets, replacing the 'planned scrub' flags with
specific attributes in the scheduling target) fixes this.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
12 months agoosd/scrub: fix adjust_target_time()
Ronen Friedman [Sat, 15 Jun 2024 12:58:30 +0000 (07:58 -0500)]
osd/scrub: fix adjust_target_time()

... to use populate_config_params() output

Also: fix determine_scrub_time() to use the same already-available
data. determine_scrub_time() renamed to determine_initial_schedule(),
to better reflect its purpose.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
12 months agoosd/scrub: modify scrub registration implementation details
Ronen Friedman [Sat, 15 Jun 2024 12:29:30 +0000 (07:29 -0500)]
osd/scrub: modify scrub registration implementation details

following the change to the queue into holding a copy of the
ScrubJob, the registration process - initiated by
schedule_scrub_with_osd() - can now be simplified.

adjust_target_time() is relocated as is. It will be refactored
in the next commit.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
12 months agoosd/scrub: the scrub queue now holds a copy of the ScrubJob
Ronen Friedman [Thu, 13 Jun 2024 10:38:29 +0000 (05:38 -0500)]
osd/scrub: the scrub queue now holds a copy of the ScrubJob

... and not a shared pointer to it.
The PG's entry in the scrub queue and the scrub-job object that
is part of the scrubber are now separate entities, that can be
modified separately - each with its own locking mechanism.

the interaction between OsdScrub (the OSD's scrub scheduler
object) and the scrub queue during scrub initiation is simplified:
instead of fetching from the queue a list of scrub targets
possibly ready to be scrubbed, the OsdScrub now picks only one
candidate - the top of the queue.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
12 months agoosd/scrub: Modify osd_scrub_sched.h high-level diagram
Ronen Friedman [Thu, 13 Jun 2024 10:33:00 +0000 (05:33 -0500)]
osd/scrub: Modify osd_scrub_sched.h high-level diagram

to convey the change in the scheduling data ownership: no longer
a scrub-job object shared between the Scrubber and the OSD
scrub queue. Instead - the scrub queue holds a copied snapshot
of the scheduling data.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
12 months agoinclude/denc.h: Review fixes 57591/head
Adam Kupczyk [Tue, 16 Jul 2024 13:15:38 +0000 (13:15 +0000)]
include/denc.h: Review fixes

- Added note to release-checklist
- Created specialized DENC_START_OSD_REQID
- Use CEPH_RELEASE_SQUID (19) value

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
12 months agoMerge pull request #57120 from NUABO/tancz
Adam Kupczyk [Tue, 16 Jul 2024 11:38:53 +0000 (13:38 +0200)]
Merge pull request #57120 from NUABO/tancz

os/bluestore: allow use BtreeAllocator

12 months agoMerge pull request #58544 from rhcs-dashboard/rgw-multisite-sync-pipe-and-flow
Nizamudeen A [Tue, 16 Jul 2024 11:20:00 +0000 (16:50 +0530)]
Merge pull request #58544 from rhcs-dashboard/rgw-multisite-sync-pipe-and-flow

mgr/dashboard: RGW multisite sync flow

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #58334 from aclamk/wip-aclamk-patch-bluerocksenv
Adam Kupczyk [Tue, 16 Jul 2024 10:46:36 +0000 (12:46 +0200)]
Merge pull request #58334 from aclamk/wip-aclamk-patch-bluerocksenv

os/bluestore: Fix BlueRocksEnv attempts to use POSIX

12 months agomgr/dashboard: RGW multisite sync flow 58544/head
Naman Munet [Thu, 11 Jul 2024 18:40:51 +0000 (00:10 +0530)]
mgr/dashboard: RGW multisite sync flow

Fixes: https://tracker.ceph.com/issues/66915
Signed-off-by: Naman Munet <nmunet@redhat.com>
12 months agoMerge pull request #57715 from rhcs-dashboard/add-rgw-multisite-wizard
Aashish Sharma [Tue, 16 Jul 2024 06:02:58 +0000 (11:32 +0530)]
Merge pull request #57715 from rhcs-dashboard/add-rgw-multisite-wizard

mgr/dashboard: add a wizard to setup rgw multisite replication

Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #58596 from batrick/superuser-doc
Zac Dover [Tue, 16 Jul 2024 04:49:28 +0000 (14:49 +1000)]
Merge pull request #58596 from batrick/superuser-doc

doc: clarify superuser note for ceph-fuse

Reviewed-by: Zac Dover <zac.dover@proton.me>
12 months agoMerge pull request #55265 from vshankar/wip-58878
Venky Shankar [Tue, 16 Jul 2024 04:14:54 +0000 (09:44 +0530)]
Merge pull request #55265 from vshankar/wip-58878

osdc/Journaler: derr log when header update get (possibly) overwritten out-of-order

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
12 months agoMerge pull request #58517 from phlogistonjohn/jjm-cephadm-ranked-by-spec
Adam King [Mon, 15 Jul 2024 22:13:49 +0000 (18:13 -0400)]
Merge pull request #58517 from phlogistonjohn/jjm-cephadm-ranked-by-spec

mgr/cephadm: allow services to be conditionally ranked

Reviewed-by: Adam King <adking@redhat.com>
12 months agoMerge pull request #58514 from phlogistonjohn/jjm-smb-fix-show-no-shares
Adam King [Mon, 15 Jul 2024 22:12:31 +0000 (18:12 -0400)]
Merge pull request #58514 from phlogistonjohn/jjm-smb-fix-show-no-shares

mgr/smb: fix ceph smb show when a cluster has not associated shares

Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
12 months agoMerge pull request #58379 from adk3798/no-cgroups-split-bootstrap
Adam King [Mon, 15 Jul 2024 22:10:06 +0000 (18:10 -0400)]
Merge pull request #58379 from adk3798/no-cgroups-split-bootstrap

cephadm: turn off cgroups_split setting  when bootstrapping with --no-cgroups-split

Reviewed-by: John Mulligan <jmulligan@redhat.com>
12 months agoMerge pull request #57853 from rhcs-dashboard/cache-subvol-smb
Adam King [Mon, 15 Jul 2024 22:08:43 +0000 (18:08 -0400)]
Merge pull request #57853 from rhcs-dashboard/cache-subvol-smb

mgr/smb: cache subvolume (& subvolume group) path lookups

Reviewed-by: John Mulligan <jmulligan@redhat.com>
12 months agoMerge pull request #58566 from ljflores/wip-tracker-66881
Laura Flores [Mon, 15 Jul 2024 14:59:23 +0000 (09:59 -0500)]
Merge pull request #58566 from ljflores/wip-tracker-66881

qa/workunits/cephtool: add extra privileges to cephtool script

12 months agoMerge pull request #58374 from kamoltat/wip-ksirivad-fix-65824
Kamoltat (Junior) Sirivadhna [Mon, 15 Jul 2024 14:18:23 +0000 (10:18 -0400)]
Merge pull request #58374 from kamoltat/wip-ksirivad-fix-65824

qa/suites/rados/thrash-old-clients: Add noscrub, nodeep-scrub to ignorelist
Reviewed by: Laura Flores <lflores@ibm.com>

12 months agodoc: elide superuser discussion from mount prereq 58596/head
Patrick Donnelly [Mon, 15 Jul 2024 14:18:15 +0000 (10:18 -0400)]
doc: elide superuser discussion from mount prereq

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
12 months agodoc: clarify superuser note for ceph-fuse
Patrick Donnelly [Mon, 15 Jul 2024 14:12:24 +0000 (10:12 -0400)]
doc: clarify superuser note for ceph-fuse

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
12 months agoMerge pull request #57775 from rhcs-dashboard/add-urls
Ankush Behl [Mon, 15 Jul 2024 14:02:18 +0000 (19:32 +0530)]
Merge pull request #57775 from rhcs-dashboard/add-urls

mgr/dashboard: adds links to the services

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #58143 from rhcs-dashboard/add-ec-profile-fields
Pedro Gonzalez Gomez [Mon, 15 Jul 2024 13:44:50 +0000 (15:44 +0200)]
Merge pull request #58143 from rhcs-dashboard/add-ec-profile-fields

mgr/dashboard: add fields to EC profile form

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #58581 from rkhudov/src-test-rgw-test_multi-update-documentation
Casey Bodley [Mon, 15 Jul 2024 12:55:54 +0000 (13:55 +0100)]
Merge pull request #58581 from rkhudov/src-test-rgw-test_multi-update-documentation

src/test/rgw/test_multlti.md:update documentation for multi tests run

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
12 months agoMerge pull request #49974 from neesingh-rh/wip-58619
Venky Shankar [Mon, 15 Jul 2024 10:25:20 +0000 (15:55 +0530)]
Merge pull request #49974 from neesingh-rh/wip-58619

mds: fix session/client evict command.

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
12 months agoMerge pull request #56193 from joscollin/wip-B64927-test_cephfs_mirror_blocklist...
Venky Shankar [Mon, 15 Jul 2024 09:55:19 +0000 (15:25 +0530)]
Merge pull request #56193 from joscollin/wip-B64927-test_cephfs_mirror_blocklist-fail

cephfs_mirror, qa: fix mirror daemon doesn't restart when blocklisted or failed

Reviewed-by: Venky Shankar <vshankar@redhat.com>
12 months agoMerge pull request #57859 from vshankar/wip-debug-reclaim-noaddrs
Venky Shankar [Mon, 15 Jul 2024 09:54:09 +0000 (15:24 +0530)]
Merge pull request #57859 from vshankar/wip-debug-reclaim-noaddrs

mds: derr log and dump sessionmap when reclaim session uuid isn't found

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
12 months agoMerge pull request #58216 from hit1943/56288_fix
Venky Shankar [Mon, 15 Jul 2024 09:41:44 +0000 (15:11 +0530)]
Merge pull request #58216 from hit1943/56288_fix

client: retry readdir if dir is invalidated

Reviewed-by: Venky Shankar <vshankar@redhat.com>
12 months agolibrbd: fold complete_event_socket() into notify_callbacks_complete()
Ilya Dryomov [Mon, 15 Jul 2024 09:28:12 +0000 (11:28 +0200)]
librbd: fold complete_event_socket() into notify_callbacks_complete()

Since commit 50694f790245 ("librbd: fix race condition with AIO
completion callbacks"), the former is always called before the latter.
Move event socket notification code into notify_callbacks_complete()
and rename it to mark_complete_and_notify().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
12 months agomgr/dashboard: add fields to EC profile form 58143/head
Pedro Gonzalez Gomez [Wed, 19 Jun 2024 20:23:11 +0000 (22:23 +0200)]
mgr/dashboard: add fields to EC profile form

Fixes: https://tracker.ceph.com/issues/66571
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
12 months agomgr/dashboard: add url links to services 57775/head
Pedro Gonzalez Gomez [Wed, 29 May 2024 18:35:15 +0000 (20:35 +0200)]
mgr/dashboard: add url links to services

Fixes: https://tracker.ceph.com/issues/66736
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
12 months agoMerge pull request #58167 from rhcs-dashboard/multi-cluster-cleanup
Nizamudeen A [Mon, 15 Jul 2024 05:45:01 +0000 (11:15 +0530)]
Merge pull request #58167 from rhcs-dashboard/multi-cluster-cleanup

mgr/dashboard: Multi-cluster cleanup

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agoMerge pull request #58241 from afreen23/wip-nvmeof-subsystems
Nizamudeen A [Mon, 15 Jul 2024 05:44:42 +0000 (11:14 +0530)]
Merge pull request #58241 from afreen23/wip-nvmeof-subsystems

mgr/dashboard: Configure subsystems from dashboard

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
12 months agomgr/dashboard: add a wizard to setup rgw multisite replication 57715/head
Aashish Sharma [Tue, 7 May 2024 03:47:24 +0000 (09:17 +0530)]
mgr/dashboard: add a wizard to setup rgw multisite replication

Fixes: https://tracker.ceph.com/issues/66227
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
12 months agoMerge pull request #58357 from xxhdx1985126/wip-seastore-btree-interruptible-bug-fix
Yingxin [Mon, 15 Jul 2024 01:57:10 +0000 (09:57 +0800)]
Merge pull request #58357 from xxhdx1985126/wip-seastore-btree-interruptible-bug-fix

crimson/os/seastore/btree: interrupt transactions immediately when getting children

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
12 months agoMerge pull request #58467 from cyx1231st/wip-seastore-track-outstanding
Yingxin [Mon, 15 Jul 2024 01:54:30 +0000 (09:54 +0800)]
Merge pull request #58467 from cyx1231st/wip-seastore-track-outstanding

crimson/os/seastore: track transactions/conflicts/outstanding periodically

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
12 months agoMerge pull request #58250 from cyx1231st/wip-seastore-optimize-ool-padding
Yingxin [Mon, 15 Jul 2024 01:53:16 +0000 (09:53 +0800)]
Merge pull request #58250 from cyx1231st/wip-seastore-optimize-ool-padding

crimson/os/seastore: write ool extents without padding

Reviewed-by: Samuel Just <sjust@redhat.com>
12 months agosrc/test/rgw/test_multlti.md:update documentation for multi tests run 58581/head
rkhudov [Sun, 14 Jul 2024 16:46:27 +0000 (17:46 +0100)]
src/test/rgw/test_multlti.md:update documentation for multi tests run

Signed-off-by: rkhudov <rhudov@gmail.com>
12 months agoMerge pull request #58574 from zdover23/wip-doc-2024-07-13-cephfs-mount-using-kernel...
Zac Dover [Sun, 14 Jul 2024 14:03:06 +0000 (00:03 +1000)]
Merge pull request #58574 from zdover23/wip-doc-2024-07-13-cephfs-mount-using-kernel-driver

doc/cephfs: edit "is mount helper present"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
12 months agoMerge pull request #58451 from zdover23/wip-doc-2024-07-07-dev-encoding
Zac Dover [Sun, 14 Jul 2024 07:45:25 +0000 (17:45 +1000)]
Merge pull request #58451 from zdover23/wip-doc-2024-07-07-dev-encoding

doc/dev: edit "Principles for format change"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
12 months agodoc/dev: edit "Principles for format change" 58451/head
Zac Dover [Sun, 7 Jul 2024 03:59:15 +0000 (13:59 +1000)]
doc/dev: edit "Principles for format change"

Improve "Principles for format change" in doc/dev/encoding.rst. This
commit started as a response to Anthony D'Atri's suggestion here: https://github.com/ceph/ceph/pull/58299/files#r1656985564

Review of this section suggested to me that certain minor English usage
improvements would be of benefit. The numbered lists in this section
could still be made a bit clearer.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
12 months agodoc/cephfs: edit "is mount helper present" 58574/head
Zac Dover [Sun, 14 Jul 2024 06:40:14 +0000 (16:40 +1000)]
doc/cephfs: edit "is mount helper present"

Edit the section called "Is mount helper present?", the title of which
prior to this commit was "Is mount helper is present?". Other small
disambiguating improvements have been made to the text in the section.
An unselectable prompt has been added before a command.

Signed-off-by: Zac Dover <zac.dover@proton.me>