suite/crimson: enable stats tests

Fixes: https://tracker.ceph.com/issues/66382
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
(cherry picked from commit d66d9f35d39174ac62450611fd8f9a15654ab99d)

Merge pull request #58774 from zdover23/wip-doc-2024-07-24-backport-58524-to-squid

squid: doc/cephfs: streamline a paragraph

Merge pull request #58679 from rhcs-dashboard/squid-sync-policy-routing-fix

squid: mgr/dashboard: rgw sync policy routing fixes

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

doc/cephfs: streamline a paragraph

Streamline a paragraph in doc/cephfs/index.rst.

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 820f8ead8919483df37c751400bd6842d4c1bd92)

Merge pull request #58743 from zdover23/wip-doc-2024-07-23-backport-58705-to-squid

squid: doc/dev/crimson: clarify and rearrange for userability

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #58623 from adk3798/wip-66413-squid

squid: mgr/prometheus: s/pkg_resources.packaging/packaging/

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #58516 from adk3798/squid-jinja2-cephadm-rhel9

squid: cephadm: make cephadm compatible with jinja2 2.11.3

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Ken Dreyer <kdreyer@ibm.com>

Merge pull request #58729 from zdover23/wip-doc-2024-07-23-backport-58725-to-squid

squid: doc/dev_guide: add needs-upgrade-testing label info

Merge pull request #58737 from zdover23/wip-doc-2024-07-23-backport-58600-to-squid

squid: doc/dev: add formatting to basic workflow

Merge pull request #58668 from cbodley/wip-67024-squid

squid: rgw/rados: set_attrs() falls back to existing attrs for index update

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #58570 from cbodley/wip-66210-squid

squid: rgw/notify: decouple add/remove_persistent_topic() from Manager

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #58569 from cbodley/wip-66243-squid

squid: test/rgw/notifications: allow http server to buffer more requests

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

doc/dev/crimson: clarify and rearrange for userability

Signed-off-by: gitkenan <kenan.mth@gmail.com>
(cherry picked from commit 92fea64c1f28a010336b3696863d3f003cd684ef)

doc/dev: add formatting to basic workflow

Add some formatting to a few sections near the end of
doc/dev/developer_guide_basic-workflow.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 4c4063a09759dc3412d89ecafb9ac55a55e6bc01)

doc/dev_guide: add needs-upgrade-testing label info

Add an explanation of the "needs-upgrade-testing" label and explain when
to use it.

Laura is the true author of this text.

Co-authored-by: Laura Flores <lflores@ibm.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 02d5a6a3371c9fa52a32124cf07da16b89a11e27)

Merge pull request #58720 from zdover23/wip-doc-2024-07-22-backport-56517-to-squid

squid: doc/start/os-recommendations: remove 16.2.z support for CentOS 7

doc/start/os-recommendations: remove 16.2.z support for CentOS 7

(cherry picked from commit 92b07ddece5f717454e5aeaa00ec70e5649539c0)

Merge pull request #58712 from zdover23/wip-doc-2024-07-22-backport-58639-to-squid

squid: doc/start: add tested container host oses

doc/start: add tested container host oses

Add a list of OSes that have been tested as container hosts. This commit
is added in response to a request made by Josh Durgin on Slack.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 9485f9723fcf58a0efbc08def27dd85ffe645764)

mgr/dashboard: rgw sync policy routing fixes

Fixes: https://tracker.ceph.com/issues/66977
Signed-off-by: Naman Munet <nmunet@redhat.com>
(cherry picked from commit ca4759b8f48fc62ff61fd290657586abd75c293c)

Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-details/rgw-multisite-details.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-details/rgw-multisite-details.component.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw-multisite-wizard/rgw-multisite-wizard.component.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/rgw/rgw.module.ts

Merge pull request #58557 from rishabh-d-dave/wip-66928-squid

squid: mgr/vol: handle case where clone index entry goes missing

Merge pull request #58561 from rishabh-d-dave/wip-66932-squid

squid: qa/cephfs: fix test_single_path_authorize_on_nonalphanumeric_fsname

Merge pull request #58562 from rishabh-d-dave/wip-66935-squid

squid: qa/cephfs: improvements for "mds fail" and "fs fail"

Merge pull request #58621 from joscollin/wip-66975-squid

squid: cephfs_mirror, qa: fix mirror daemon doesn't restart when blocklisted or failed

Merge pull request #58331 from mchangir/wip-66669-squid

squid: qa: cleanup snapshots before subvolume delete

Merge pull request #58394 from joscollin/wip-66774-squid

squid: mds: fix bug and error handling of mds STATE_STARTING

Merge pull request #58494 from joscollin/wip-66869-squid

squid: mds: prevent scrubbing for standby-replay MDS

Merge pull request #58495 from joscollin/wip-66728-squid

squid: qa/cephfs: mark file system joinable for fs rename tests before unmounting clients

Merge pull request #58496 from joscollin/wip-66666-squid

squid: mds: set the correct WRLOCK flag always in wrlock_force()

Merge pull request #58498 from joscollin/wip-66615-squid

squid: common/TrackedOp: do not count the ops marked as nowarn

Merge pull request #58525 from joscollin/wip-66781-squid

squid: mon/MDSMonitor: set birth time on FSMap during encode

Merge pull request #58526 from joscollin/wip-66777-squid

squid: mds/client: return -ENODATA when xattr doesn't exist for removexattr

Merge pull request #58527 from joscollin/wip-66626-squid

squid: mds: set the proper extra bl for the create request

Merge pull request #58696 from zdover23/wip-doc-2024-07-21-backport-58695-to-squid

squid: doc: Amend dev mailing list subscribe instructions.

doc: Amend dev mailing list subscribe instructions.

Signed-off-by: Paulo E. Castro <pecastro@wormholenet.com>
(cherry picked from commit 3b0360bc2ea1e0b5f7a7c6b04ade483f77e4b5c6)

Merge pull request #58680 from zdover23/wip-doc-2024-07-20-backport-58678-to-squid

squid: doc/cephadm/upgrade: ceph-ci containers are hosted by quay.ceph.io

Merge pull request #58683 from zdover23/wip-doc-2024-07-20-backport-58671-to-squid

squid: doc/start: update mailing list links

doc/start: update mailing list links

Update the User and Dev mailing list subscription links. This commit is
made in response to a request from Dan van der Ster.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a242fe3d940d5764cd766dba8e42449501986765)

doc/cephadm/upgrade: ceph-ci containers are hosted by quay.ceph.io

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 9c77963300fee804f249d512c980cdeac06f14f7)

Merge pull request #57403 from k0ste/wip-65915-squid

squid: kv/RocksDBStore: Configure compact-on-deletion for all CFs

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #58667 from afreen23/wip-backport-nvmeof

Batch backport for nvme listener, namesapces and regression fix

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #58625 from rhcs-dashboard/wip-66982-squid

squid: mgr/dashboard: add fields to EC profile form

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

mgr/dashboard: Add namespaces views in dashboard

Fixes https://tracker.ceph.com/issues/66990

- list namespaces
- create namespaces
- edit namespaces
- delete namespaces
- update NQN regex

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
(cherry picked from commit b45eb5579611b56ee033410a4688984ff468fdcd)

Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/shared/pipes/pipes.module.ts

mgr/dashboard: Create and delete listeners

Fixes https://tracker.ceph.com/issues/66996

- list listener under subsystems
- delete listener
- create listener

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
(cherry picked from commit a4f2eefe21f973d532a7e08d1ce4e977f39dfe88)

 Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/shared/datatable/table/table.component.ts
src/pybind/mgr/dashboard/frontend/src/app/shared/enum/cell-template.enum.ts

mgr/dashboard: nvmf apis broken for insecure channel

because when no certificate, it raises an exception which stops the api call
abruptly.

Signed-off-by: Nizamudeen A <nia@redhat.com>
(cherry picked from commit 36a4a72959c1428d7295f3e24e5f94c937cff6a6)

Merge pull request #58655 from rhcs-dashboard/wip-67002-squid

squid: mgr/dashboard: add NFS export button for subvolume/ grp

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #58619 from ceph/squid-sync-policy

squid: mgr/dashboard: rgw multisite sync policy management

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #57457 from badone/wip-tracker-59196-lazy-omap-regex-segfault-squid

squid: test/lazy-omap-stats: Convert to boost::regex

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>

rgw/rados: set_attrs() falls back to existing attrs for index update

set_attrs() needs the ACLOwner, etag, content-type and storage class for
the bucket index update. if those attrs aren't being updated, consult
their existing attrs in state->attrset

Fixes: https://tracker.ceph.com/issues/64173
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit f433e2ff4568416619af4885314d43c621fb4db9)

mgr/dashboard: RGW multisite sync pipe

Fixes: https://tracker.ceph.com/issues/66926
Signed-off-by: Naman Munet <nmunet@redhat.com>
(cherry picked from commit d451b4d1795e1429b0a530940558cf646579cdb9)

mgr/dashboard: add NFS export route from subvolume/subvolume grp

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit c0b2db74b2a99eb0ee4e4a37997d6516d8622855)

Merge pull request #58620 from rhcs-dashboard/squid-expand-cluster-improvements

squid: mgr/dashboard: Expand Cluster improvements

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #58599 from afreen23/wip-backport-nvmeof

Batch backport nvmeof nav and subystems

Reviewed-by: Avan Thakkar <athakkar@redhat.com>

Merge pull request #58640 from aaSharma14/wip-66993-squid

squid: mgr/dashboard: Block -> Images -> Create form improvements

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #58614 from zdover23/wip-doc-2024-07-16-backport-58596-to-squid

squid: doc: clarify superuser note for ceph-fuse

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>

Merge pull request #58650 from aclamk/wip-aclamk-denc-compat-check-squid

squid: common, os/bluestore: Fix lack of checking for compat on DENC_START

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

include/denc.h: Review fixes

- Added note to release-checklist
- Created specialized DENC_START_OSD_REQID
- Use CEPH_RELEASE_SQUID (19) value

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 6143b80ef7fd9730705ea564f72542caacf7e379)

include/denc: Not use fmt::format

fmt::format caused linking problems in some compilations.
Instead of fixing them all, discontinue usage.
Moved compatibility throw to separate function.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 71ca41dbaa5640cc41589d9c2b04ca1b2967ab16)

test/encoding.cc: Harmonize expected text with exception

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit d4a83b7170657e7eb59507d0c8696238ac62fe32)

build: split ceph_ver.h

Split ceph_ver.h into:
1) ceph_ver.h containing git-related macros
2) ceph_release.h containing just human written ceph version number /
   ceph version name.

The benefit is that denc.h which needs to know CEPH_RELEASE value
can skip including git-related macros. There are many compilation units
that use denc.h and only few that need git-related macros.
Reduces amount of files to recompile after SHA1 changes.
It is only relevant for developer environment.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 1a56293f2c890d9222fab5e1e91c34e2d864aef9)

include/encoding.h: Fix message on compat failure

Change misleading message printed when compat is not met.
Was:
FUNC no longer understand old encoding version 5 < 7
Is:
Decoder at FUNC v=5 cant decode v=11 minimal_decoder=7

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit ebd8283e2f2923ca5787483919bb1ab9a3faddea)

include/denc: Add protection against bumping up compat

Added protection against bumping up compat until U_____ release (SQUID+2)

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit c94c8baf012b66ba2fe13abbeb2f27c16c717df4)

include/denc: Add missing check for compat

Now decoder throws if compat signalled in message is higher than version of decoder.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 62aba6df38df7203b2565f77afc2fb09e4bc43d6)

test/denc: Add check for compat

Add unittest that checks if code throws exception if decoder is outside compat range.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit 59c48b1202b324f0ddffeb4bad1029e799121813)

qa: Wait for mirror daemon restart before getting new rados_inst

After blocklisted/failed, wait for the mirror daemon restart
which is after 30 seconds timeout and then check for the new rados_inst.

Fixes: https://tracker.ceph.com/issues/64927
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit a9a56919ff95d2face436da2ca08fd26580fadb9)

cephfs_mirror: Fixed negative seconds

Fixes: https://tracker.ceph.com/issues/64927
Fixes: https://tracker.ceph.com/issues/51964
Fixes: https://tracker.ceph.com/issues/63931
Fixes: https://tracker.ceph.com/issues/63089
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 96c3f8f33d789a065c7ed418679afd53faffa3d8)

cephfs_mirror: Add ErrorListener to maintain blocklisted/failed timestamp in FSMirror

Have FSMirror register a listener with InstanceWatcher/MirrorWatcher which would get invoked when the mirror daemon is blocklisted or failed.
Thus FSMirror can maintain the last blocklisted/failed timestamp and use that for restarting the mirror daemon.

Fixes: https://tracker.ceph.com/issues/64927
Fixes: https://tracker.ceph.com/issues/51964
Fixes: https://tracker.ceph.com/issues/63931
Fixes: https://tracker.ceph.com/issues/63089
Signed-off-by: Jos Collin <jcollin@redhat.com>
(cherry picked from commit 77ec7bfde7a349b0e06b34ecdf328996c7642d43)

Merge pull request #57678 from batrick/wip-66188-squid

squid: mds: use regular dispatch for processing metrics

mgr/dashboard: Block -> Images -> Create form improvements

Fixes: https://tracker.ceph.com/issues/66348
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
(cherry picked from commit e3c656440f69fed1a93ed6fa92e2b9e6adf27e45)

Merge pull request #58476 from rhcs-dashboard/wip-66872-squid

squid: mgr/dashboard: nfs export enhancement for CEPHFS

Reviewed-by: afreen23 <NOT@FOUND>

Merge pull request #58593 from rhcs-dashboard/wip-66785-squid

squid: mgr/dashboard: add RGW lifecycle management

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

mgr/dashboard: add fields to EC profile form

Fixes: https://tracker.ceph.com/issues/66571
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
(cherry picked from commit 8f7a5de584b04b1dcba04799d1d9301af325d64b)

 Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.ts

mgr/prometheus: s/pkg_resources.packaging/packaging/

instead of relying on the internal implementation of pkg_resources,
let's import packaging directly.

in this change, we also add the dependency to the packaging module
in the packaging recipes.

See also https://github.com/pypa/setuptools/issues/4385

Fixes https://tracker.ceph.com/issues/66201
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 844b66de419d7bf5f622980b0de3c69b5ad8bc9c)

mgr/dashboard: nfs export enhancement for CEPHFS

Fixes: https://tracker.ceph.com/issues/66718
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 69a45db9c3cc9ed4ac36e7f2d6db78bd7940530b)

mgr/dashboard: Expand Cluster improvements

worked on expand cluster screen hide/show and persisting osd form values

Fixes: https://tracker.ceph.com/issues/66344
Signed-off-by: Naman Munet <nmunet@redhat.com>
(cherry picked from commit aa4d6b58459079a3b59ffdd1c9913c0a07a1549a)

Merge pull request #58553 from adk3798/squid-cephadm-cert-store

squid: mgr/cephadm: Cert Store + use secure_channel for grpc requests

Reviewed-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: RGW multisite sync flow

Fixes: https://tracker.ceph.com/issues/66915
Signed-off-by: Naman Munet <nmunet@redhat.com>
(cherry picked from commit 41d46b7b507f95603ec432c061fdf0569f12dc3b)

mgr/dashboard: RGW sync policy crud operations

sync group crud ops added

Fixes: https://tracker.ceph.com/issues/66798
Signed-off-by: Naman Munet <nmunet@redhat.com>
(cherry picked from commit a784b71abf64ec26d3f424c6298b5ecc97d296e3)

mgr/dashborad: RGW sync policy

Fixes: https://tracker.ceph.com/issues/66576
Signed-off-by: Naman Munet <nmunet@redhat.com>
(cherry picked from commit 94f9a2bf18f43cc5b05dd8c216fe9e0975969106)

Merge pull request #58347 from idryomov/wip-66570-squid

squid: librbd: make diff-iterate in fast-diff mode aware of encryption

Reviewed-by: Ramana Raja <rraja@redhat.com>

doc: elide superuser discussion from mount prereq

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 7290bdce6f4dd93be88be6ad54030fa90a8c1ec0)

doc: clarify superuser note for ceph-fuse

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit d100de9c9ce884beee6e9551b2b221c686b775b5)

Merge pull request #57610 from vshankar/wip-65988-squid

squid: qa: ignore cluster warnings generated from forward-scrub task

Merge pull request #57918 from batrick/wip-66386-squid

squid: qa: disable mon_warn_on_pool_no_app in fs suite

Merge pull request #57922 from batrick/wip-66385-squid

squid: qa: correct json lookup for new `lock path` output

Merge pull request #58155 from vshankar/wip-66325-squid

squid: qa: enable debug logs for fs:cephadm:multivolume subsuite

Merge pull request #58233 from batrick/wip-66593-squid

squid: tools/cephfs: recover alternate_name of dentries from journal

Merge pull request #58237 from batrick/wip-66619-squid

squid: mds: initialize epoch for quiescedb

Merge pull request #58252 from joscollin/wip-66674-squid

squid: qa: enhance per-client labelled perf counters test

Merge pull request #58294 from batrick/wip-66623-squid

squid: mds: do remove the cap when seqs equal or larger than last issue

Merge pull request #58317 from batrick/wip-66585-squid

squid: mds: QuiesceDbManager: mark next retry event during bootstrap

Merge pull request #58318 from batrick/wip-66572-squid

squid: mds/quiesce-db: calculate_quiesce_map: aggregate quiesce roots' TTL as `max`

Merge pull request #58319 from batrick/wip-66542-squid

squid: mds: dump formatter even for errors

mgr/dashboard: Configure subsystems from dashboard

Fixes https://tracker.ceph.com/issues/66659

- adds subsytems tab
- adds subsystem listing view
- adds create subsystem modal
- adds delete subsystem
- adds unit tests

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
(cherry picked from commit b85f982def41320003ecb632e2b03a8779567fbe)

mgr/dashboard: Introduce NVMe/TCP navigation

Fixes https://tracker.ceph.com/issues/66346

- adds NVMe/TCP tab under Block nav
- adds overview page for NVMe/TCP nav
- overview page lists gateways
- add default error page when no nvmeof service running
- added unit tests
- fixes service page e2e test

Signed-off-by: Afreen <afreen23.git@gmail.com>
(cherry picked from commit 442346f0efbb5d7d3af3ebdf847586bbe3f93f6d)

Conflicts:
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.html
src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html

librbd: make diff-iterate in fast-diff mode aware of encryption

diff-iterate wasn't updated when librbd was being prepared to support
encryption in commit 8d6a47933269 ("librbd: add crypto image dispatch
layer").  This is even noted in [1]:

> The two places I skipped for now are DiffIterate and TrimRequest.

CryptoImageDispatch has since been removed, but diff-iterate in
fast-diff mode is still unaware of encryption and just assumes that all
offsets are raw.  This means that the callback gets invoked with
incorrect image offsets when encryption is loaded.  For example, for
a LUKS1-formatted image with some data at offsets 0 and 20971520,
diff-iterate with encryption loaded reports

  0~4194304
  4194304~4194304
  25165824~4194304

instead of

  0~4194304
  20971520~4194304

as "exists".  For any piece of code that is using diff-iterate to
optimize block-by-block processing (e.g. copy an encrypted source image
to a differently-encrypted destination image), this is fatal: it would
skip processing block 20971520 which has data and instead process block
25165824 which doesn't have any data and was to be skipped, producing
a corrupted destination image.

[1] https://github.com/ceph/ceph/pull/37935#issue-735278403

Fixes: https://tracker.ceph.com/issues/66570
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit cdeb0efce3f9f857ad6d5b7ff3965f3292cb571a)

test/librbd: extend DiffIterateTest.DiffIterateDeterministic{,PP}

Currently we are laying data only at the beginning of an object.
Extend the skeletons to write to three different offsets in the middle
and also at the end of the object.

Separately, make C and C++ API test variants slightly different in
terms of offsets being targeted to not go through exactly the same
scenario twice.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit da69d1fdbf69cf37ba8b75ea9a230634bb25ae76)

test/librbd: refactor DiffIterateTest.DiffIterateDeterministic{,PP}

In preparation for extending coverage, extract test logic into a couple
of parametrized helpers.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 1df87998dc30be6e3b4c90f5833539c7ccc70911)

Merge pull request #58541 from idryomov/wip-66886-squid

squid: qa: account for rbd_trash object in krbd_data_pool.sh + related ceph{,adm} task fixes

Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #58212 from idryomov/wip-66418-squid

squid: librbd: diff-iterate shouldn't crash on an empty byte range

Reviewed-by: Mykola Golub <mgolub@suse.com>