]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
11 months agodoc/rgw/notification: persistent notification queue full behavior 59219/head
Yuval Lifshitz [Wed, 14 Aug 2024 11:02:09 +0000 (11:02 +0000)]
doc/rgw/notification: persistent notification queue full behavior

Fixes: https://tracker.ceph.com/issues/50610
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
11 months agoMerge pull request #59168 from zdover23/wip-doc-2024-08-12-cephfs-cache-configuration
Zac Dover [Wed, 14 Aug 2024 10:09:38 +0000 (20:09 +1000)]
Merge pull request #59168 from zdover23/wip-doc-2024-08-12-cephfs-cache-configuration

doc/cephfs: improve cache-configuration.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
11 months agoMerge pull request #59186 from rhcs-dashboard/replace-cluster-capacity-with-usage-bar
naman munet [Wed, 14 Aug 2024 05:57:02 +0000 (11:27 +0530)]
Merge pull request #59186 from rhcs-dashboard/replace-cluster-capacity-with-usage-bar

mgr/dashboard: replace individual cluster's capacity info with Usage bar in Multi-Cluster

11 months agoMerge PR #59025 into main
Venky Shankar [Wed, 14 Aug 2024 04:58:09 +0000 (10:28 +0530)]
Merge PR #59025 into main

* refs/pull/59025/head:
tools/rados: Fix extra NL in getxattr

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Gabriel Benhanokh <gbenhano@redhat.com>
11 months agoMerge pull request #58485 from ivoalmeida/carbon-datatable
Nizamudeen A [Wed, 14 Aug 2024 04:18:04 +0000 (09:48 +0530)]
Merge pull request #58485 from ivoalmeida/carbon-datatable

mgr/dashboard: replace ngx-datatable by carbon datatable

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
11 months agoMerge pull request #58140 from guits/cv-tpm2-support
Guillaume Abrioux [Tue, 13 Aug 2024 19:27:42 +0000 (21:27 +0200)]
Merge pull request #58140 from guits/cv-tpm2-support

ceph-volume: add TPM2 token enrollment support for encrypted OSDs

11 months agoMerge pull request #58956 from ThomasLamprecht/ceph-volume-debian-dependency
Guillaume Abrioux [Tue, 13 Aug 2024 19:18:33 +0000 (21:18 +0200)]
Merge pull request #58956 from ThomasLamprecht/ceph-volume-debian-dependency

debian pkg: record python3-packaging dependency for ceph-volume

11 months agomgr/dashboard: replace ngx-datatable by carbon 58485/head
Ivo Almeida [Wed, 26 Jun 2024 14:42:12 +0000 (15:42 +0100)]
mgr/dashboard: replace ngx-datatable by carbon

Fixes: https://tracker.ceph.com/issues/66965
* replaced ngx-datatable by carbon datatable
* created carbon themes for content and tables
* redesigned table actions to render as kebab menu options per data row
* keep only primary actions on datatable toolbar
* implemented carbon batch actions

Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
11 months agoMerge pull request #59112 from idryomov/wip-67353
Ilya Dryomov [Tue, 13 Aug 2024 14:39:05 +0000 (16:39 +0200)]
Merge pull request #59112 from idryomov/wip-67353

qa: adjust expected io_opt in krbd_discard_granularity.t

Reviewed-by: Ramana Raja <rraja@redhat.com>
11 months agoMerge pull request #54504 from aclamk/wip-aclamk-bs-refactor-write-path
Adam Kupczyk [Tue, 13 Aug 2024 13:15:50 +0000 (15:15 +0200)]
Merge pull request #54504 from aclamk/wip-aclamk-bs-refactor-write-path

os/bluestore: Recompression, part 2. New write path.

11 months agoMerge pull request #59001 from cbodley/wip-rgw-async-inline-gc
Casey Bodley [Tue, 13 Aug 2024 12:25:53 +0000 (08:25 -0400)]
Merge pull request #59001 from cbodley/wip-rgw-async-inline-gc

rgw/rados: delete_objs_inline() uses rgw_rados_operate()

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
11 months agomgr/dashboard: replace individual cluster's capacity info with Usage bar in Multi... 59186/head
Naman Munet [Tue, 13 Aug 2024 07:38:32 +0000 (13:08 +0530)]
mgr/dashboard: replace individual cluster's capacity info with Usage bar in Multi-Cluster

fixes: https://tracker.ceph.com/issues/67193

Signed-off-by: Naman Munet <nmunet@redhat.com>
11 months agoMerge pull request #58410 from bill-scales/erasure_coding_design_document
Zac Dover [Tue, 13 Aug 2024 02:34:05 +0000 (12:34 +1000)]
Merge pull request #58410 from bill-scales/erasure_coding_design_document

doc: doc/dev/osd_interals/erasure_coding/enhancements.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Sam Just <sjust@redhat.com>
11 months agoMerge pull request #59177 from anthonyeleven/aad-qat-followup
Zac Dover [Tue, 13 Aug 2024 02:17:25 +0000 (12:17 +1000)]
Merge pull request #59177 from anthonyeleven/aad-qat-followup

doc/radosgw: improve qat-accel.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
11 months agodoc/radosgw: improve qat-accel.rst 59177/head
Anthony D'Atri [Tue, 13 Aug 2024 01:38:52 +0000 (21:38 -0400)]
doc/radosgw: improve qat-accel.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
11 months agoMerge PR #58532 into main
Patrick Donnelly [Mon, 12 Aug 2024 16:11:16 +0000 (12:11 -0400)]
Merge PR #58532 into main

* refs/pull/58532/head:
qa: improve and add commit ID to comment for context

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
11 months agodoc/cephfs: improve cache-configuration.rst 59168/head
Zac Dover [Mon, 12 Aug 2024 12:47:08 +0000 (22:47 +1000)]
doc/cephfs: improve cache-configuration.rst

Improve the text in the section about dealing with cache-pressure alerts
that was added in https://github.com/ceph/ceph/pull/59077. The changes
in this commit were suggested by Anthony D'Atri.

Co-authored-by: Patrick Donnelly <pdonnelly@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
11 months agoMerge pull request #55050 from rhcs-dashboard/nfs-monitoring
Adam King [Mon, 12 Aug 2024 14:22:50 +0000 (10:22 -0400)]
Merge pull request #55050 from rhcs-dashboard/nfs-monitoring

mgr/nfs: scrape nfs monitoring endpoint

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
11 months agoMerge pull request #54075 from aclamk/wip-aclamk-bs-nice-print
Adam Kupczyk [Mon, 12 Aug 2024 13:47:53 +0000 (15:47 +0200)]
Merge pull request #54075 from aclamk/wip-aclamk-bs-nice-print

os/bluestore: Recompression, part 1. Nice debugs.

11 months agoMerge pull request #59164 from toficly/patch-2
Anthony D'Atri [Mon, 12 Aug 2024 13:22:10 +0000 (06:22 -0700)]
Merge pull request #59164 from toficly/patch-2

doc:update e-mail addresses governance

11 months agodoc:update e-mail addresses governance 59164/head
Tobias Fischer [Mon, 12 Aug 2024 09:30:48 +0000 (11:30 +0200)]
doc:update e-mail addresses governance

with the consent of my colleagues
- Dan van der Ster
- João Eduardo Luis
- Mark Nelson

changed their e-mail addresses to the current one

Signed-off-by: Tobias Fischer <tobias.fischer@clyso.com>
Signed-off-by: Tobias Fischer <138117964+toficly@users.noreply.github.com>
11 months agoceph-volume: refactor device path handling for LVM lookups 58140/head
Guillaume Abrioux [Tue, 6 Aug 2024 13:37:30 +0000 (13:37 +0000)]
ceph-volume: refactor device path handling for LVM lookups

This consolidates the conditional checks for device paths to
reduce redundancy and improve readability and adds logic to
handle both '/dev/mapper' and '/dev/dm-' paths uniformly by
introducing a utility function `get_lvm_mapper_path_from_dm()`.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
11 months agoceph-volume: add TPM2 token enrollment support for encrypted OSDs
Guillaume Abrioux [Thu, 16 May 2024 15:47:19 +0000 (11:47 -0400)]
ceph-volume: add TPM2 token enrollment support for encrypted OSDs

This adds the required changes to ceph-volume and cephadm in order to support
deploying tpm2 token enrolled encrypted OSDs.

Adding `--with-tpm` when deploying with `--dmcrypt` will enroll a tpm2
token to the corresponding LUKS2 devices.

Example of a osd service spec:

```
service_type: osd
service_id: tpm2_osds
placement:
  host_pattern: '*'
spec:
  data_devices:
    paths:
      - /dev/sdb
  encrypted: true
  tpm2: true
```

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
11 months agoMerge pull request #59098 from athanatos/sjust/wip-67415-alienstore-mkfs-crash
Matan Breizman [Mon, 12 Aug 2024 07:13:06 +0000 (10:13 +0300)]
Merge pull request #59098 from athanatos/sjust/wip-67415-alienstore-mkfs-crash

crimson: clear AlienStore::coll_map in umount rather than in stop

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
11 months agoMerge pull request #59077 from zdover23/wip-doc-2024-08-07-cephfs-cache-configuration...
Zac Dover [Sun, 11 Aug 2024 10:53:14 +0000 (20:53 +1000)]
Merge pull request #59077 from zdover23/wip-doc-2024-08-07-cephfs-cache-configuration-cache-pressure

doc/cephfs: add cache pressure information

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
11 months agoMerge pull request #58951 from rhcs-dashboard/ceph-users-doc-fix
Zac Dover [Sat, 10 Aug 2024 11:07:15 +0000 (21:07 +1000)]
Merge pull request #58951 from rhcs-dashboard/ceph-users-doc-fix

mgr/dashboard: fix ceph-users api

Reviewed-by: Zac Dover <zac.dover@proton.me>
11 months agoMerge pull request #58976 from athanatos/sjust/for-review/wip-nvmeofpaxosservice...
Samuel Just [Fri, 9 Aug 2024 22:19:38 +0000 (15:19 -0700)]
Merge pull request #58976 from athanatos/sjust/for-review/wip-nvmeofpaxosservice-cosmetic-fixes

mon: cosmetic fixes for NVMeofGwMon files

Reviewed-by: Alexander Indenbaum <aindenba@redhat.com>
Reviewed-by: Leonid Chernin <lechernin@gmail.com>
Reviewed-by: Orit Wasserman <owasserm@redhat.com>
Reviewed-by: Aviv Caro <Aviv.Caro@ibm.com>
11 months agoMerge pull request #57003 from linuxkidd/wip-pool-max-avail
Michael J. Kidd [Fri, 9 Aug 2024 22:10:03 +0000 (15:10 -0700)]
Merge pull request #57003 from linuxkidd/wip-pool-max-avail

PGMap: remove pool max_avail scale factor

11 months agoMerge pull request #58573 from idryomov/wip-selinux-drop-ignore-agetty
Ilya Dryomov [Fri, 9 Aug 2024 18:22:12 +0000 (20:22 +0200)]
Merge pull request #58573 from idryomov/wip-selinux-drop-ignore-agetty

qa: agetty entry in selinux allowlist is redundant now

Reviewed-by: Venky Shankar <vshankar@redhat.com>
11 months agoMerge PR #58784 into main
Patrick Donnelly [Fri, 9 Aug 2024 16:07:45 +0000 (12:07 -0400)]
Merge PR #58784 into main

* refs/pull/58784/head:
script/backport-create-issue: add debug messages for retry

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
11 months agoqa: cover a custom object size in krbd_discard_granularity.t 59112/head
Ilya Dryomov [Thu, 8 Aug 2024 20:01:47 +0000 (22:01 +0200)]
qa: cover a custom object size in krbd_discard_granularity.t

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
11 months agoqa: adjust expected io_opt in krbd_discard_granularity.t
Ilya Dryomov [Thu, 8 Aug 2024 19:50:40 +0000 (21:50 +0200)]
qa: adjust expected io_opt in krbd_discard_granularity.t

With linux.git commit a00d4bfce7c6 ("rbd: increase io_opt again"),
io_opt is set to object set size.

Fixes: https://tracker.ceph.com/issues/67353
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
11 months agoMerge pull request #58605 from adk3798/upgrade-suite-upgrade-in-progress-checks
Adam King [Fri, 9 Aug 2024 14:00:31 +0000 (10:00 -0400)]
Merge pull request #58605 from adk3798/upgrade-suite-upgrade-in-progress-checks

qa/upgrade: fix checks to make sure upgrade is still in progress

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
11 months agomgr/dashboard: fix ceph-users api doc 58951/head
Nizamudeen A [Wed, 31 Jul 2024 06:40:39 +0000 (12:10 +0530)]
mgr/dashboard: fix ceph-users api doc

Fixes: https://tracker.ceph.com/issues/67224
Signed-off-by: Nizamudeen A <nia@redhat.com>
11 months agomgr/nfs: scrape nfs monitoring endpoint 55050/head
avanthakkar [Wed, 3 Jan 2024 11:52:33 +0000 (17:22 +0530)]
mgr/nfs: scrape nfs monitoring endpoint

Fixes: https://tracker.ceph.com/issues/62558
Signed-off-by: avanthakkar <avanjohn@gmail.com>
11 months agodoc/cephfs: add cache pressure information 59077/head
Zac Dover [Wed, 7 Aug 2024 13:11:11 +0000 (23:11 +1000)]
doc/cephfs: add cache pressure information

Add information to doc/cephfs/cache-configuration.rst about how to deal
with a message that reads "clients failing to respond to cache
pressure". This procedure explains how to slow the growth of the
recall_caps value so that it does not exceed the
mds_recall_warning_threshold.

The information in this commit was developed by Eugen Block. See
https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/thread/5ROH5CWKKOEIQMVXOVRT5OO7CWK2HPM3/#J65DFUPP4BY57MICPANXKI7KAXSZ5Z5P
and https://www.spinics.net/lists/ceph-users/msg73188.html.

Fixes: https://tracker.ceph.com/issues/57115
Co-authored-by: Eugen Block <eblock@nde.ag>
Signed-off-by: Zac Dover <zac.dover@proton.me>
11 months agoMerge pull request #59087 from kamoltat/wip-ksirivad-fix-stretch-device-class-docs
Zac Dover [Fri, 9 Aug 2024 00:14:25 +0000 (10:14 +1000)]
Merge pull request #59087 from kamoltat/wip-ksirivad-fix-stretch-device-class-docs

docs/rados/operations/stretch-mode: warn device class is not supported

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
11 months agoMerge pull request #58736 from amathuria/wip-66922-amat
Laura Flores [Thu, 8 Aug 2024 20:41:18 +0000 (15:41 -0500)]
Merge pull request #58736 from amathuria/wip-66922-amat

qa/rados/dashboard: Add PG_DEGRADED to ignorelist

11 months agoMerge pull request #57037 from adk3798/cephadm-limit-shell-mounts
Guillaume Abrioux [Thu, 8 Aug 2024 19:12:38 +0000 (21:12 +0200)]
Merge pull request #57037 from adk3798/cephadm-limit-shell-mounts

cephadm: limit mounts for shell and ceph-volume commands

11 months agoMerge PR #58861 into main
Venky Shankar [Thu, 8 Aug 2024 16:54:18 +0000 (22:24 +0530)]
Merge PR #58861 into main

* refs/pull/58861/head:
mds: only authpin on wrlock when not a locallock

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
11 months agoPGMap: remove pool max_avail scale factor 57003/head
Michael J. Kidd [Fri, 19 Apr 2024 14:20:22 +0000 (07:20 -0700)]
PGMap: remove pool max_avail scale factor

The scaling of max_avail by the ratio of non-degraded to total objects
count results in the reported max_avail increasing proportionally to the
number of OSDs marked `down` but not `out`.  This is counter intuitive
since OSDs going `down` should never result in more space being
available.

Removing the scale factor allows max_avail to remain unchanged until the
OSDs are marked `out`.

Signed-off-by: Michael J. Kidd <linuxkidd@gmail.com>
11 months agoMerge pull request #59091 from zdover23/wip-doc-2024-08-08-README-md-alerts
Zac Dover [Thu, 8 Aug 2024 15:18:08 +0000 (01:18 +1000)]
Merge pull request #59091 from zdover23/wip-doc-2024-08-08-README-md-alerts

doc/README.md - add "tip" alert styling

Reviewed-by: Cole Mitchell <cole.mitchell.ceph@gmail.com>
11 months agoMerge pull request #59030 from ljflores/wip-fix-crontab-2
Laura Flores [Thu, 8 Aug 2024 14:53:36 +0000 (09:53 -0500)]
Merge pull request #59030 from ljflores/wip-fix-crontab-2

qa/crontab: force priority for main rados nightlies

11 months agoMerge pull request #58583 from lxbsz/wip-66946
Venky Shankar [Thu, 8 Aug 2024 12:25:24 +0000 (17:55 +0530)]
Merge pull request #58583 from lxbsz/wip-66946

qa/cephfs: fix TestRenameCommand and unmount the clinet before failin…

Reviewed-by: Venky Shankar <vshankar@redhat.com>
11 months agodoc: doc/dev/osd_internals/erasure_coding/enhancements.rst 58410/head
Bill Scales [Wed, 3 Jul 2024 13:09:19 +0000 (13:09 +0000)]
doc: doc/dev/osd_internals/erasure_coding/enhancements.rst

Erasure coding enhancements design document

Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>
11 months agodoc/README.md - add "tip" alert styling 59091/head
Zac Dover [Thu, 8 Aug 2024 07:04:45 +0000 (17:04 +1000)]
doc/README.md - add "tip" alert styling

Add "tip" alert styling (what in Docbook XML is called "an admonition")
to information about Ninja in an ordered list (which is what markdown
has here instead of procedures).

Signed-off-by: Zac Dover <zac.dover@proton.me>
11 months agoMerge pull request #59049 from zdover23/wip-doc-2024-08-06-README-building-ceph
Zac Dover [Thu, 8 Aug 2024 06:59:43 +0000 (16:59 +1000)]
Merge pull request #59049 from zdover23/wip-doc-2024-08-06-README-building-ceph

doc/README.md - allocate information correctly

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
11 months agoMerge pull request #58913 from cyx1231st/wip-seastore-unlock-ool
Yingxin [Thu, 8 Aug 2024 06:19:04 +0000 (14:19 +0800)]
Merge pull request #58913 from cyx1231st/wip-seastore-unlock-ool

crimson/os/seastore: move ool writes from collection lock to concurrent DeviceSubmission phase

Reviewed-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
11 months agoMerge pull request #58787 from xxhdx1985126/wip-67106
Yingxin [Thu, 8 Aug 2024 06:16:26 +0000 (14:16 +0800)]
Merge pull request #58787 from xxhdx1985126/wip-67106

crimson/os/seastore: consider segment_header_t::modify_time as the segments' modify_time for no-tail OOL segments

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
11 months agoMerge pull request #57911 from gardran/wip-gdran-mds-better-clease-handling
Venky Shankar [Thu, 8 Aug 2024 05:44:41 +0000 (11:14 +0530)]
Merge pull request #57911 from gardran/wip-gdran-mds-better-clease-handling

mds: some optimizations around client Capability and Lease tracking

Reviewed-by: Venky Shankar <vshankar@redhat.com>
11 months agocrimson/.../alien_store: clear coll_map in umount rather than stop 59098/head
Samuel Just [Thu, 8 Aug 2024 03:05:09 +0000 (20:05 -0700)]
crimson/.../alien_store: clear coll_map in umount rather than stop

As of a926a4a54ced, BlueStore::umount expects outstanding CollectionRef's
to already have been released.

Previously, 8389471b3 updated alien_store.cc to release coll_map in
stop() in in the alien tp.

Fixes: https://tracker.ceph.com/issues/67415
Signed-off-by: Samuel Just <sjust@redhat.com>
11 months agoMerge pull request #58983 from cyx1231st/wip-seastore-cleanup-cache
Yingxin [Thu, 8 Aug 2024 02:46:38 +0000 (10:46 +0800)]
Merge pull request #58983 from cyx1231st/wip-seastore-cleanup-cache

crimson/os/seastore/cache: cleanups and comments

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
11 months agoMerge pull request #58869 from xxhdx1985126/wip-seastore-lba-leaf-node-minor-bug-fix
Yingxin [Thu, 8 Aug 2024 02:04:46 +0000 (10:04 +0800)]
Merge pull request #58869 from xxhdx1985126/wip-seastore-lba-leaf-node-minor-bug-fix

crimson/os/seastore/lba_manager: correct the range end of lba mappings

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
11 months agoMerge PR #59029 into main
Patrick Donnelly [Thu, 8 Aug 2024 00:58:17 +0000 (20:58 -0400)]
Merge PR #59029 into main

* refs/pull/59029/head:
qa: simplify postmerge construction

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
11 months agocrimson/osd/osd.cc: convert fmt::print to INFO in OSD::mkfs
Samuel Just [Thu, 8 Aug 2024 00:24:56 +0000 (17:24 -0700)]
crimson/osd/osd.cc: convert fmt::print to INFO in OSD::mkfs

Signed-off-by: Samuel Just <sjust@redhat.com>
11 months agocrimson/osd/osd.cc: convert OSD::mkfs to a coroutine
Samuel Just [Thu, 8 Aug 2024 00:18:16 +0000 (00:18 +0000)]
crimson/osd/osd.cc: convert OSD::mkfs to a coroutine

Signed-off-by: Samuel Just <sjust@redhat.com>
11 months agoMerge pull request #44366 from orozery/rbd-crypto-migration
Ilya Dryomov [Wed, 7 Aug 2024 22:30:24 +0000 (00:30 +0200)]
Merge pull request #44366 from orozery/rbd-crypto-migration

librbd/crypto: fix issue when live-migrating from encrypted export

Reviewed-by: Ramana Raja <rraja@redhat.com>
11 months agoMerge pull request #58002 from nbalacha/wip-nbalacha-sorted-snaps
Ilya Dryomov [Wed, 7 Aug 2024 21:41:45 +0000 (23:41 +0200)]
Merge pull request #58002 from nbalacha/wip-nbalacha-sorted-snaps

cls/rbd: add group_snap_list_order method to enable sorting snapshots in creation order

Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
11 months agodocs/rados/operations/stretch-mode: warn device class is not supported 59087/head
Kamoltat Sirivadhna [Wed, 7 Aug 2024 19:20:41 +0000 (19:20 +0000)]
docs/rados/operations/stretch-mode: warn device class is not supported

Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
11 months agoMerge pull request #59073 from anoopcs9/cephadm-docs-smb-spec
Zac Dover [Wed, 7 Aug 2024 13:57:24 +0000 (23:57 +1000)]
Merge pull request #59073 from anoopcs9/cephadm-docs-smb-spec

doc/cephadm/smb: Add missing user_sources option to service spec

Reviewed-by: Zac Dover <zac.dover@proton.me>
11 months agoMerge pull request #56233 from kamoltat/wip-ksirivad-fix-64802
Kamoltat (Junior) Sirivadhna [Wed, 7 Aug 2024 13:45:54 +0000 (09:45 -0400)]
Merge pull request #56233 from kamoltat/wip-ksirivad-fix-64802

RADOS: Generalize stretch mode pg temp handling to be usable without stretch mode
Samuel Just <sjust@redhat.com>

11 months agoMerge pull request #57381 from kamoltat/wip-ksirivad-fix-65371
Kamoltat (Junior) Sirivadhna [Wed, 7 Aug 2024 13:41:39 +0000 (09:41 -0400)]
Merge pull request #57381 from kamoltat/wip-ksirivad-fix-65371

PeeringState.cc: Only populate want_acting when num_osds < bucket_max
Reviewed by: Samuel Just <sjust@redhat.com>

11 months agoMerge pull request #58585 from anoopcs9/cephadm-update-smbd-version
Adam King [Wed, 7 Aug 2024 12:46:10 +0000 (08:46 -0400)]
Merge pull request #58585 from anoopcs9/cephadm-update-smbd-version

cephadm/smb: Determine samba version within container

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #52489 from ifed01/wip-ifed-alloc2
Adam Kupczyk [Wed, 7 Aug 2024 12:42:35 +0000 (14:42 +0200)]
Merge pull request #52489 from ifed01/wip-ifed-alloc2

os/bluestore: introduce hybrid_btree2 allocator

11 months agoos/bluestore: Write_v2 changes 54504/head
Adam Kupczyk [Tue, 6 Aug 2024 13:35:11 +0000 (13:35 +0000)]
os/bluestore: Write_v2 changes

4) remove Writer::shared_changed and use txc::shared_blobs directly

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Write_v2 changes
Adam Kupczyk [Thu, 1 Aug 2024 11:54:21 +0000 (11:54 +0000)]
os/bluestore: Write_v2 changes

1) moved stats and blobs update to Writer::do_write
2) preallocate space in Writer:_split_data
3) fixed Writer::_write_expand_l that could check one extent too much

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agotests/bluestore_types: Fixed data generation bluestore_blob_t::release_extents
Adam Kupczyk [Mon, 29 Jul 2024 13:32:58 +0000 (13:32 +0000)]
tests/bluestore_types: Fixed data generation bluestore_blob_t::release_extents

The #1 and #2 elements could form a continuous sequence but still not
joined:
Expected equality of these values:
  result
    Which is: { 0x7b138000~48000, 0x883b0000~48000, 0xf0c10000~10000, 0x727b8000~38000 }
  mid
    Which is: { 0x7b138000~30000, 0x7b168000~18000, 0x883b0000~48000, 0xf0c10000~10000, 0x727b8000~38000 }

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoqa/bluestore: Add write_v1/v2 selection
Adam Kupczyk [Thu, 25 Jul 2024 17:10:50 +0000 (17:10 +0000)]
qa/bluestore: Add write_v1/v2 selection

Add framework for various random options for debug bluestore.
Use framework to select:
- write_v1
- write_v2
- write_v1 / write_v2 selected at random

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Add conf.bluestore_write_v2_random
Adam Kupczyk [Thu, 25 Jul 2024 07:48:14 +0000 (07:48 +0000)]
os/bluestore: Add conf.bluestore_write_v2_random

Added conf.bluestore_write_v2_random. This is useful only for testing.
If set, it overrides value of bluestore_write_v2 with a random
true/false selection.
It is useful for v1 / v2 compatibility testing.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Add compression fallback
Adam Kupczyk [Thu, 25 Jul 2024 07:47:04 +0000 (07:47 +0000)]
os/bluestore: Add compression fallback

For write_v2 create fallback to write_v1 if compression is selected.
This is temporary until compression dedicated to benefit from v2 is
merged.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Writer, fix find_mutable_blob
Adam Kupczyk [Thu, 25 Jul 2024 07:41:46 +0000 (07:41 +0000)]
os/bluestore: Writer, fix find_mutable_blob

1) Algorithm assumed that blob->blob_start() is aligned to csum size.
It is true for blobs created by write_v2, but write_v1 can generate
blob like: begin = 0x9000, size = 0x6000, csum = 0x2000.
2) Blobs with unused were selected even if those need to be expanded.
This is illegal since we cannot expand unused.

Fixed blob selection algorithm.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Writer, improved calculation of need_size
Adam Kupczyk [Mon, 15 Jul 2024 14:33:24 +0000 (14:33 +0000)]
os/bluestore: Writer, improved calculation of need_size

More diligent calcualtion algorithm of need_size.
Takes into account front and back alignment.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Writer, fix for clang
Adam Kupczyk [Mon, 15 Jul 2024 06:33:55 +0000 (06:33 +0000)]
os/bluestore: Writer, fix for clang

Clang fails at _construct_at().

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agocrimson/alienstore: New write path & debug
Adam Kupczyk [Sun, 14 Jul 2024 16:29:49 +0000 (16:29 +0000)]
crimson/alienstore: New write path & debug

Added missing files to alienstore CMake list.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Add Writer::_crop_allocs_to_io
Adam Kupczyk [Sat, 13 Jul 2024 18:08:16 +0000 (18:08 +0000)]
os/bluestore: Add Writer::_crop_allocs_to_io

Usually the data we put to disk is AU aligned.
In weird cases like AU=16K we put less data than we allocated.
_crop_allocs_to_io trims allocated extents into disk block extents
to reflect real IO.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Fix after rebase
Adam Kupczyk [Tue, 9 Jul 2024 18:48:19 +0000 (18:48 +0000)]
os/bluestore: Fix after rebase

BufferSpace is not with Onode, not Blob.
Modify code to adapt to this change.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Review fixes to Writer
Adam Kupczyk [Fri, 21 Jun 2024 08:45:18 +0000 (08:45 +0000)]
os/bluestore: Review fixes to Writer

Plus making const& variables in `for`.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Add perf counters to Writer
Adam Kupczyk [Wed, 22 May 2024 11:36:51 +0000 (13:36 +0200)]
os/bluestore: Add perf counters to Writer

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Writer, fix _try_reuse_allocated_l/r
Adam Kupczyk [Fri, 24 May 2024 07:50:04 +0000 (09:50 +0200)]
os/bluestore: Writer, fix _try_reuse_allocated_l/r

It was not checked if necessary location is still within blob range.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Cleanup on bluestore_blob_t::release_extents
Adam Kupczyk [Wed, 22 May 2024 16:01:16 +0000 (18:01 +0200)]
os/bluestore: Cleanup on bluestore_blob_t::release_extents

Result of ongoing review.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Writer, rename _deferred_decision -> _defer_or_allocate
Adam Kupczyk [Wed, 22 May 2024 15:59:52 +0000 (17:59 +0200)]
os/bluestore: Writer, rename _deferred_decision -> _defer_or_allocate

A review proposal.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Review fixes of Writer
Adam Kupczyk [Wed, 22 May 2024 11:55:53 +0000 (13:55 +0200)]
os/bluestore: Review fixes of Writer

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Fix _try_reuse_allocated_r in Writer.cc
Adam Kupczyk [Wed, 22 May 2024 11:53:11 +0000 (13:53 +0200)]
os/bluestore: Fix _try_reuse_allocated_r in Writer.cc

The search must go over entire range where we can have aligned mutable blobs.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Modify _write_expand_l/r
Adam Kupczyk [Wed, 22 May 2024 11:43:54 +0000 (13:43 +0200)]
os/bluestore: Modify _write_expand_l/r

We need to scan all extents that are under proposed read / padding.
It was broken and we could clear out something defined.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Add bluestore_write_v2 conf variable
Adam Kupczyk [Tue, 16 Jan 2024 10:16:09 +0000 (10:16 +0000)]
os/bluestore: Add bluestore_write_v2 conf variable

Add new conf variable.
bluestore_write_v2 = true : use new _do_write_v2() function
bluestore_write_v2 = false : use legacy _do_write() function
This variable is read only at start time.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Added new write path with BlueStore
Adam Kupczyk [Tue, 16 Jan 2024 10:37:07 +0000 (10:37 +0000)]
os/bluestore: Added new write path with BlueStore

Added _do_write_v2 function to BlueStore.
Function is not integrated yet.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Add "write_lat" perf counter
Adam Kupczyk [Tue, 16 Jan 2024 10:22:53 +0000 (10:22 +0000)]
os/bluestore: Add "write_lat" perf counter

New "write_lat" tracks wallclock time spent in execution of BlueStore::_write().

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Add unit test for BlueStore::Writer
Adam Kupczyk [Fri, 5 Jan 2024 09:10:36 +0000 (09:10 +0000)]
os/bluestore: Add unit test for BlueStore::Writer

Extensive tests for BlueStore::Writer.
Some extra debug hooks for BlueStore.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Introducing BlueStore::Writer
Adam Kupczyk [Fri, 5 Jan 2024 08:08:09 +0000 (08:08 +0000)]
os/bluestore: Introducing BlueStore::Writer

BlueStore::Writer is a toolkit to give more options to control write.
It gives more control over compression process, letting user of the class
manually split incoming data to blobs.
Now for large writes all but last blob can be fully filled with data.

There is now a single place that decides on deferred/direct.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Functions to manipulate Blob
Adam Kupczyk [Fri, 5 Jan 2024 07:54:05 +0000 (07:54 +0000)]
os/bluestore: Functions to manipulate Blob

Set of various simple functions to simplify code.
No special logic here.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Add csum_type to WriteContext
Adam Kupczyk [Thu, 16 Nov 2023 17:18:37 +0000 (17:18 +0000)]
os/bluestore: Add csum_type to WriteContext

It is more organized this way.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agotests/bluestore_types: Fix % 0 in tests
Adam Kupczyk [Fri, 28 Jun 2024 12:16:52 +0000 (12:16 +0000)]
tests/bluestore_types: Fix % 0 in tests

It was possible to get x % 0. It generated exception.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Unit tests for punch_hole_2
Adam Kupczyk [Tue, 14 Nov 2023 16:46:32 +0000 (16:46 +0000)]
os/bluestore: Unit tests for punch_hole_2

Comprehensive tests for punch_hole_2.
New formulation of punch_hole_2 makes it very easy to
create patterns and inspect results.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Refactor of write path. New punch_hole_2 function.
Adam Kupczyk [Tue, 14 Nov 2023 16:25:01 +0000 (16:25 +0000)]
os/bluestore: Refactor of write path. New punch_hole_2 function.

Introducing new logic of Onode processing during write.
New punch_hole_2 function empties range, but keeps track of elements:
- allocations that are no longer used
- blobs that are now empty
- shared blobs that got modified
- statfs changes to apply later

This change allows to reuse allocation for deferred freely, which means
that we can use allocations in deferred mode in other blob then they come from.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Add ExtentMap::split_at and ExtentMap::maybe_split_at
Adam Kupczyk [Tue, 14 Nov 2023 14:10:31 +0000 (14:10 +0000)]
os/bluestore: Add ExtentMap::split_at and ExtentMap::maybe_split_at

Created dedicated mutator of ExtentMap that is useful when
a logical extent must be split.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Add bluestore_blob_use_tracker_t::put_simple
Adam Kupczyk [Thu, 9 Nov 2023 01:14:30 +0000 (01:14 +0000)]
os/bluestore: Add bluestore_blob_use_tracker_t::put_simple

New version of put().
It is simpler and faster, but does not allow for
overprovisioning of used AUs.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoinclude/intarith: add p2remain
Adam Kupczyk [Thu, 9 Nov 2023 01:06:38 +0000 (01:06 +0000)]
include/intarith: add p2remain

p2remain gives remaining data in a block.
It simialar to p2nphase, but for 0 offset returns full size.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: New variant of bluestore_blob_t::release_extents
Adam Kupczyk [Wed, 8 Nov 2023 13:37:15 +0000 (13:37 +0000)]
os/bluestore: New variant of bluestore_blob_t::release_extents

Created new variant of bluestore_blob_t::release_extents function.
Now the function takes range [offset~length] as an argument,
a simplification that allows it to have much better performance.

Created comprehensive unit test, tests 40k random blobs.
The unit test does not test for a potential case of having
bluestore_blob_t.extents that are not allocation unit aligned.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Fix debug after rebase 54075/head
Adam Kupczyk [Tue, 9 Jul 2024 13:27:54 +0000 (13:27 +0000)]
os/bluestore: Fix debug after rebase

BufferSpace moved from Blob to Onode.
Moved relevant code from Blob::operator<< to Onode::operator<<.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
11 months agoos/bluestore: Add ability to partially print Onode
Adam Kupczyk [Fri, 14 Jun 2024 10:54:01 +0000 (10:54 +0000)]
os/bluestore: Add ability to partially print Onode

Now Onode can be printed in selected range.
It is useful in high-level dout modes that operate on a fragment of
entire Onode.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>