]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
10 months agorgw/multisite: fix sync_error_trim command. 59347/head
Shilpa Jagannath [Wed, 4 Oct 2023 19:22:41 +0000 (15:22 -0400)]
rgw/multisite: fix sync_error_trim command.
without --marker option, we trim everthing.
if --marker option is passed in, we trim upto that marker.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>
(cherry picked from commit a0491a4f63885be9ea14a15c67cabd8903f19641)

10 months agoMerge pull request #54796 from k0ste/wip-59494-quincy
Yuri Weinstein [Mon, 19 Aug 2024 18:24:01 +0000 (11:24 -0700)]
Merge pull request #54796 from k0ste/wip-59494-quincy

quincy: cmake/rgw: librgw tests depend on ALLOC_LIBS

Reviewed-by: Casey Bodley <cbodley@redhat.com>
10 months agoMerge pull request #54695 from k0ste/wip-63662-quincy
Laura Flores [Mon, 19 Aug 2024 16:29:13 +0000 (11:29 -0500)]
Merge pull request #54695 from k0ste/wip-63662-quincy

quincy: doc/rados/configuration/bluestore-config-ref: Fix lowcase typo

10 months agoMerge pull request #59296 from zdover23/wip-doc-2024-08-19-backport-59256-to-quincy
Anthony D'Atri [Mon, 19 Aug 2024 12:54:28 +0000 (05:54 -0700)]
Merge pull request #59296 from zdover23/wip-doc-2024-08-19-backport-59256-to-quincy

quincy: doc/cephfs: s/mountpoint/mount point/

10 months agoMerge pull request #58558 from rishabh-d-dave/wip-66929-quincy
Xiubo Li [Mon, 19 Aug 2024 12:08:02 +0000 (20:08 +0800)]
Merge pull request #58558 from rishabh-d-dave/wip-66929-quincy

quincy: mgr/vol: handle case where clone index entry goes missing

10 months agoMerge pull request #55301 from neesingh-rh/wip-64143-quincy
Rishabh Dave [Mon, 19 Aug 2024 10:54:36 +0000 (16:24 +0530)]
Merge pull request #55301 from neesingh-rh/wip-64143-quincy

quincy: qa: fix rank_asok() to handle errors from asok commands

Reviewed-by: Rishabh Dave <ridave@redhat.com>
10 months agoMerge pull request #55916 from mchangir/wip-64224-quincy
Rishabh Dave [Mon, 19 Aug 2024 10:54:03 +0000 (16:24 +0530)]
Merge pull request #55916 from mchangir/wip-64224-quincy

quincy: qa: bump up scrub status command timeout

Reviewed-by: Rishabh Dave <ridave@redhat.com>
10 months agoMerge pull request #57526 from batrick/wip-66045-quincy
Rishabh Dave [Mon, 19 Aug 2024 10:53:19 +0000 (16:23 +0530)]
Merge pull request #57526 from batrick/wip-66045-quincy

quincy: qa: unmount clients before damaging the fs

Reviewed-by: Rishabh Dave <ridave@redhat.com>
10 months agoMerge pull request #57564 from dparmar18/wip-66062-quincy
Rishabh Dave [Mon, 19 Aug 2024 10:53:11 +0000 (16:23 +0530)]
Merge pull request #57564 from dparmar18/wip-66062-quincy

quincy: qa: add a YAML to ignore MGR_DOWN warning

Reviewed-by: Rishabh Dave <ridave@redhat.com>
10 months agoMerge pull request #58278 from joscollin/wip-56590-quincy
Rishabh Dave [Mon, 19 Aug 2024 10:52:51 +0000 (16:22 +0530)]
Merge pull request #58278 from joscollin/wip-56590-quincy

quincy: qa/suites/fs: skip check-counters for iogen workload

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agodoc/cephfs: s/mountpoint/mount point/ 59296/head
Zac Dover [Sat, 17 Aug 2024 03:37:58 +0000 (13:37 +1000)]
doc/cephfs: s/mountpoint/mount point/

Change the string "mountpoint" to "mount point" in English-language
strings (as opposed to in commands, where the string "mountpoint"
sometimes appears and is correct).

cf. https://github.com/ceph/ceph/pull/58908#discussion_r1697715486
in which page 345 of The IBM Style Guide is referenced to back up this
change.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 57ed73eaa6945c69059d299ea5310eaac57e2299)

11 months agoMerge pull request #59144 from idryomov/wip-53674-quincy
Yuri Weinstein [Sun, 18 Aug 2024 17:46:59 +0000 (10:46 -0700)]
Merge pull request #59144 from idryomov/wip-53674-quincy

quincy: librbd/crypto: fix issue when live-migrating from encrypted export

Reviewed-by: Ramana Raja <rraja@redhat.com>
11 months agoMerge pull request #59288 from zdover23/wip-doc-2024-08-18-backport-59257-to-quincy
Anthony D'Atri [Sat, 17 Aug 2024 21:20:28 +0000 (14:20 -0700)]
Merge pull request #59288 from zdover23/wip-doc-2024-08-18-backport-59257-to-quincy

quincy: doc/cephfs: s/mountpoint/mount point/

11 months agodoc/cephfs: s/mountpoint/mount point/ 59288/head
Zac Dover [Sat, 17 Aug 2024 03:44:30 +0000 (13:44 +1000)]
doc/cephfs: s/mountpoint/mount point/

Change the string "mountpoint" to "mount point" in English-language
strings (as opposed to in commands, where the string "mountpoint"
sometimes appears and is correct).

cf. https://github.com/ceph/ceph/pull/58908#discussion_r1697715486 in
which page 345 of The IBM Style Guide is referenced to back up this
change.

This commit alters only English-language text and example commands in
which the string "{mount point}" is meant to be replaced. No commands
meant for cutting-and-pasting have been altered in this commit.

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit a0f81cfb5094164630f55a717efbbcdce45bce58)

11 months agoMerge pull request #59252 from zdover23/wip-doc-2024-08-16-backport-59167-to-quincy
Anthony D'Atri [Fri, 16 Aug 2024 22:53:12 +0000 (15:53 -0700)]
Merge pull request #59252 from zdover23/wip-doc-2024-08-16-backport-59167-to-quincy

quincy: doc/cephfs: improve "layout fields" text

11 months agodoc/cephfs: improve "layout fields" text 59252/head
Zac Dover [Mon, 12 Aug 2024 12:38:14 +0000 (22:38 +1000)]
doc/cephfs: improve "layout fields" text

Improve "layout fields" text in doc/cephfs/file-layouts.rst, as suggesed
by Anthony D'Atri in these comments:

https://github.com/ceph/ceph/pull/59021#discussion_r1704108581
https://github.com/ceph/ceph/pull/59021#discussion_r1704112320

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 0949b410433837f0509fb73169fa7f22c8f6c256)

11 months agoMerge pull request #59023 from zdover23/wip-doc-2024-08-05-backport-58891-to-quincy
Zac Dover [Fri, 16 Aug 2024 09:26:48 +0000 (19:26 +1000)]
Merge pull request #59023 from zdover23/wip-doc-2024-08-05-backport-58891-to-quincy

quincy: doc/cephfs: edit "Layout Fields" text

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
11 months agoMerge pull request #59235 from zdover23/wip-doc-2024-08-15-backport-59219-to-quincy
Anthony D'Atri [Thu, 15 Aug 2024 23:27:00 +0000 (16:27 -0700)]
Merge pull request #59235 from zdover23/wip-doc-2024-08-15-backport-59219-to-quincy

quincy: doc/rgw/notification: persistent notification queue full behavior

11 months agoMerge pull request #59230 from idryomov/wip-67353-quincy
Ilya Dryomov [Thu, 15 Aug 2024 22:26:44 +0000 (00:26 +0200)]
Merge pull request #59230 from idryomov/wip-67353-quincy

quincy: qa: adjust expected io_opt in krbd_discard_granularity.t

Reviewed-by: Ramana Raja <rraja@redhat.com>
11 months agoMerge pull request #58284 from pponnuvel/wip-66700-quincy
Yuri Weinstein [Thu, 15 Aug 2024 16:08:02 +0000 (09:08 -0700)]
Merge pull request #58284 from pponnuvel/wip-66700-quincy

quincy: mgr/nfs: Don't crash ceph-mgr if NFS clusters are unavailable.

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
11 months agoMerge pull request #56201 from ifed01/wip-ifed-fix-64443-quincy
Yuri Weinstein [Thu, 15 Aug 2024 14:43:44 +0000 (07:43 -0700)]
Merge pull request #56201 from ifed01/wip-ifed-fix-64443-quincy

quincy: test/store_test: fix DeferredWrite test when prefer_deferred_size=0

Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
11 months agoMerge pull request #55776 from ifed01/wip-ifed-fix-expand-with-ncb-qui
Yuri Weinstein [Thu, 15 Aug 2024 14:42:36 +0000 (07:42 -0700)]
Merge pull request #55776 from ifed01/wip-ifed-fix-expand-with-ncb-qui

quincy: os/bluestore: fix free space update after bdev-expand in NCB mode.

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
11 months agoMerge pull request #54692 from Matan-B/wip-63650-quincy
Yuri Weinstein [Thu, 15 Aug 2024 14:40:41 +0000 (07:40 -0700)]
Merge pull request #54692 from Matan-B/wip-63650-quincy

quincy: tools/ceph_objectstore_tool: action_on_all_objects_in_pg to skip pgmeta

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
11 months agoMerge pull request #59057 from yuvalif/wip-67365-quincy
Yuval Lifshitz [Thu, 15 Aug 2024 08:08:47 +0000 (11:08 +0300)]
Merge pull request #59057 from yuvalif/wip-67365-quincy

quincy: common/dout: fix FTBFS on GCC 14

Reviewed-By: Yuri Weinstein <yweinste@ibm.com>, Radoslaw Zarzynski <Radoslaw.Adam.Zarzynski@ibm.com>, Pere Diaz Bou <pdiazbou@ibm.com>
11 months agodoc/rgw/notification: persistent notification queue full behavior 59235/head
Yuval Lifshitz [Wed, 14 Aug 2024 11:02:09 +0000 (11:02 +0000)]
doc/rgw/notification: persistent notification queue full behavior

Fixes: https://tracker.ceph.com/issues/50610
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
(cherry picked from commit d12ba11741dc749bcce315bf467078595fa95b24)

11 months agoqa: cover a custom object size in krbd_discard_granularity.t 59230/head
Ilya Dryomov [Thu, 8 Aug 2024 20:01:47 +0000 (22:01 +0200)]
qa: cover a custom object size in krbd_discard_granularity.t

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit e8126bf2f6411069da5074ac3a5a2ea16c0bba0c)

11 months agoqa: adjust expected io_opt in krbd_discard_granularity.t
Ilya Dryomov [Thu, 8 Aug 2024 19:50:40 +0000 (21:50 +0200)]
qa: adjust expected io_opt in krbd_discard_granularity.t

With linux.git commit a00d4bfce7c6 ("rbd: increase io_opt again"),
io_opt is set to object set size.

Fixes: https://tracker.ceph.com/issues/67353
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 144270eb737850159614abd63c261baaa83a8afc)

11 months agoMerge pull request #58704 from kshtsk/wip-67064-quincy
kyr [Wed, 14 Aug 2024 17:59:11 +0000 (19:59 +0200)]
Merge pull request #58704 from kshtsk/wip-67064-quincy

quincy: common: fix compilation warnings in numa.cc

11 months agoMerge pull request #59042 from NitzanMordhai/wip-67350-quincy
Yuri Weinstein [Wed, 14 Aug 2024 14:11:54 +0000 (07:11 -0700)]
Merge pull request #59042 from NitzanMordhai/wip-67350-quincy

quincy: Test: osd-recovery-space.sh extends the wait time for "recovery toofull"

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
11 months agoMerge pull request #58742 from ifed01/wip-ifed-async-compact-qui
Yuri Weinstein [Wed, 14 Aug 2024 14:08:18 +0000 (07:08 -0700)]
Merge pull request #58742 from ifed01/wip-ifed-async-compact-qui

quincy: os/bluestore: enable async manual compactions

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Pere Diaz Bou <pdiazbou@redhat.com>
11 months agoMerge pull request #59216 from zdover23/wip-doc-2024-08-14-backport-59168-to-quincy
Anthony D'Atri [Wed, 14 Aug 2024 13:18:13 +0000 (06:18 -0700)]
Merge pull request #59216 from zdover23/wip-doc-2024-08-14-backport-59168-to-quincy

quincy: doc/cephfs: improve cache-configuration.rst

11 months agodoc/cephfs: improve cache-configuration.rst 59216/head
Zac Dover [Mon, 12 Aug 2024 12:47:08 +0000 (22:47 +1000)]
doc/cephfs: improve cache-configuration.rst

Improve the text in the section about dealing with cache-pressure alerts
that was added in https://github.com/ceph/ceph/pull/59077. The changes
in this commit were suggested by Anthony D'Atri.

Co-authored-by: Patrick Donnelly <pdonnelly@redhat.com>
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit aa3bdae2314fef2fca8fc12dca006af657235e17)

11 months agoMerge pull request #59150 from zdover23/wip-doc-2024-08-11-backport-59077-to-quincy
Anthony D'Atri [Sun, 11 Aug 2024 15:37:59 +0000 (08:37 -0700)]
Merge pull request #59150 from zdover23/wip-doc-2024-08-11-backport-59077-to-quincy

quincy: doc/cephfs: add cache pressure information

11 months agodoc/cephfs: add cache pressure information 59150/head
Zac Dover [Wed, 7 Aug 2024 13:11:11 +0000 (23:11 +1000)]
doc/cephfs: add cache pressure information

Add information to doc/cephfs/cache-configuration.rst about how to deal
with a message that reads "clients failing to respond to cache
pressure". This procedure explains how to slow the growth of the
recall_caps value so that it does not exceed the
mds_recall_warning_threshold.

The information in this commit was developed by Eugen Block. See
https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/thread/5ROH5CWKKOEIQMVXOVRT5OO7CWK2HPM3/#J65DFUPP4BY57MICPANXKI7KAXSZ5Z5P
and https://www.spinics.net/lists/ceph-users/msg73188.html.

Fixes: https://tracker.ceph.com/issues/57115
Co-authored-by: Eugen Block <eblock@nde.ag>
Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit bf26274ae4737417193f8c2b56bea20eb2a358aa)

11 months agolibrbd/migration: make ImageDispatch handle encryption for non-native formats 59144/head
Ilya Dryomov [Fri, 2 Aug 2024 07:27:42 +0000 (09:27 +0200)]
librbd/migration: make ImageDispatch handle encryption for non-native formats

With NativeFormat now being handled via dispatch, handling encryption
for non-native formats (i.e. mapping to raw image extents and performing
decryption/mapping back on completion) in the migration layer is really
straightforward.

Note that alignment doesn't need to be performed in the migration layer
because it happens on the destination image -- the "align and resubmit"
logic in C_UnalignedObjectReadRequest should kick in before the call to
read_parent().

Fixes: https://tracker.ceph.com/issues/53674
Co-authored-by: Or Ozeri <oro@il.ibm.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 0000c3447407772039121bb4499f243df1c889da)

Conflicts:
qa/workunits/rbd/luks-encryption.sh [
          - commit 9892ead7fcd9 ("librbd/crypto: allow loading luks
            format without specifying version") not in quincy -- pass
            through $format to test_migration_read_and_copyup() and
            test_migration_native_with_snaps()
          - commit 1d3de19c4005 ("tools/rbd: add encryption format
            support for cloned image") not in quincy -- drop
            test_migration_clone() ]
src/librbd/migration/ImageDispatch.cc [ ImageArea support and
  commit 20aee5bbbcb5 ("neorados: Make IOContext getters/setters
  less weird") not in quincy ]

11 months agolibrbd: don't make an extra copy of image_extents in C_ImageReadRequest ctor
Ilya Dryomov [Mon, 29 Jul 2024 09:01:17 +0000 (11:01 +0200)]
librbd: don't make an extra copy of image_extents in C_ImageReadRequest ctor

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit b20a897061feabc4e22c339c4e7a8aa5155151e8)

11 months agoqa/workunits/rbd: perform cleanup in test_clone_encryption()
Ilya Dryomov [Tue, 6 Aug 2024 11:24:02 +0000 (13:24 +0200)]
qa/workunits/rbd: perform cleanup in test_clone_encryption()

... so that RAW_DEV can be unmapped and future tests can reuse testimg
and other image names without bumping into watchers and older snapshots.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 82d26909cb12b62d88f69f90eb8af692e497bddb)

 Conflicts:
qa/workunits/rbd/luks-encryption.sh [ commit 1d3de19c4005
  ("tools/rbd: add encryption format support for cloned image")
  not in quincy ]

11 months agoqa/workunits/rbd: no need to chmod in luks-encryption.sh
Ilya Dryomov [Sat, 3 Aug 2024 17:31:03 +0000 (19:31 +0200)]
qa/workunits/rbd: no need to chmod in luks-encryption.sh

Most workunits expect the user to be a member of "disk" group, so we
can pretty much rely on that being the case at this point.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 830cbee7a5f875af04f335266b02ad96e4cd71c4)

Conflicts:
qa/workunits/rbd/luks-encryption.sh [ commit 1d3de19c4005
  ("tools/rbd: add encryption format support for cloned image")
  not in quincy ]

11 months agolibrbd/migration: make FormatInterface::read() void again
Ilya Dryomov [Fri, 26 Jul 2024 14:54:31 +0000 (16:54 +0200)]
librbd/migration: make FormatInterface::read() void again

Now that NativeFormat is handled via dispatch, FormatInterface::read()
can be void again for consistency with FormatInterface::list_snaps().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit b6c7f69b8044f9206aa982c2aba6466c49fd2bea)

Conflicts:
src/librbd/migration/ImageDispatch.cc [ commit 20aee5bbbcb5
  ("neorados: Make IOContext getters/setters less weird") not
  in quincy ]

11 months agolibrbd/migration: close source image in OpenSourceImageRequest
Ilya Dryomov [Fri, 26 Jul 2024 10:13:08 +0000 (12:13 +0200)]
librbd/migration: close source image in OpenSourceImageRequest

Currently, on errors in FormatInterface::open(), RawFormat disposes
of src_image_ctx, but QCOWFormat doesn't, which is a leak.  Rather than
having each format do it internally, do it in OpenSourceImageRequest.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 63159d6b431470f5edc4b110cebf46865c550689)

11 months agolibrbd/migration: don't instantiate NativeFormat, handle it via dispatch
Ilya Dryomov [Thu, 18 Jul 2024 16:11:18 +0000 (18:11 +0200)]
librbd/migration: don't instantiate NativeFormat, handle it via dispatch

Trying to shoehorn NativeFormat under FormatInterface doesn't really
work.  It fundamentally doesn't fit in:

- Unlike for RawFormat and QCOWFormat, src_image_ctx for NativeFormat
  is not dummy -- it's an ImageCtx for a real RBD image.  Pre-creating
  it in OpenSourceImageRequest with the expectation that placeholder
  values would be overridden later forces NativeFormat to reach into
  ImageCtx guts, duplicating the logic in the constructor.  This also
  necessitates calling snap_set() in a separate step, since snap_id
  isn't known at the time ImageCtx is created.

- Unlike for RawFormat and QCOWFormat, get_image_size() and
  get_snapshots() implementations for NativeFormat are dummy.

- read() and list_snaps() implementations for NativeFormat are
  inconsistent: read() passes through io::ImageDispatch layer, but
  list_snaps() doesn't.  Both can be passing through, meaning that in
  essence these are also dummy.

All of this is with today's code.  Additional complications arise with
planned support for migrating from external clusters where src_image_ctx
would require more invasive patching to "move" to an IoCtx belonging to
an external cluster's CephContext and also with other work.

With the above in mind, NativeFormat actually consists of:

1. Code that parses the "type: native" source spec
2. Code that patches ImageCtx, working around the fact that it's
   pre-created in OpenSourceImageRequest
3. A bunch of dummy implementations for FormatInterface

With this change, (1) is wrapped into a static method that also creates
ImageCtx after all required parameters are known and (2) and (3) go away
entirely.  NativeFormat no longer implements FormatInterface and doesn't
get instantiated at all.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit cacf7ca941876f64f9a04867ffc6cdcb484d89b9)

Conflicts:
src/librbd/migration/NativeFormat.cc [ ImageArea support not in
  quincy ]

11 months agolibrbd/migration/NativeFormat: refactor source spec parsing
Ilya Dryomov [Wed, 17 Jul 2024 19:11:51 +0000 (21:11 +0200)]
librbd/migration/NativeFormat: refactor source spec parsing

In preparation for not instantiating NativeFormat and losing a copy of
the source spec JSON object in m_json_object, refactor the parsing code
to use only const methods (which std::map's operator[] isn't) and local
variables where possible.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 3bbf1f5ddbaa4a8c252d70a384e23852f0c537c1)

11 months agolibrbd/migration/NativeFormat: do pool lookup instead of creating io_ctx
Ilya Dryomov [Wed, 17 Jul 2024 18:05:08 +0000 (20:05 +0200)]
librbd/migration/NativeFormat: do pool lookup instead of creating io_ctx

A Rados instance is sufficient to map the pool name to the pool ID,
no need to involve an IoCtx instance as well.  While at it, report
distinctive errors for a non-existing pool and an invalid JSON value
for pool_name key cases.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 1ba9a32598f50073b574b4649736d76b678a1c58)

11 months agolibrbd/migration: make SourceSpecBuilder::parse_source_spec() static
Ilya Dryomov [Wed, 17 Jul 2024 13:06:33 +0000 (15:06 +0200)]
librbd/migration: make SourceSpecBuilder::parse_source_spec() static

In preparation for divorcing NativeFormat from FormatInterface and
changing when/how src_image_ctx is created, make parse_source_spec()
independent of src_image_ctx.  The "invalid source-spec JSON" error is
duplicated by the "failed to parse migration source-spec" error, so
just get rid of the former to spare having to pass CephContext to
parse_source_spec().

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit f172fb97be9a6129be7cdbaa87346dc6c8e8ccb1)

11 months agolibrbd/migration/OpenSourceImageRequest: rename io_ctx -> dst_io_ctx
Ilya Dryomov [Tue, 30 Jul 2024 20:56:17 +0000 (22:56 +0200)]
librbd/migration/OpenSourceImageRequest: rename io_ctx -> dst_io_ctx

For now, this is just slightly clearer.  The distinction would become
important with planned support for migrating from external clusters.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit c14356b1f9eea0988e071f40dc0df005f70edd4d)

11 months agolibrbd/migration: massage some error messages
Ilya Dryomov [Sun, 14 Jul 2024 17:48:33 +0000 (19:48 +0200)]
librbd/migration: massage some error messages

Add missing spaces, don't use the word stream when reporting errors
on POSIX file operations (open() and lseek64()) and fix a cut-and-paste
typo in RawSnapshot.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 789df2ce38f35ffb3e86974e02868e5fff71e72c)

11 months agolibrbd/api: clean up leftovers in Migration::prepare_import()
Ilya Dryomov [Sun, 14 Jul 2024 17:21:47 +0000 (19:21 +0200)]
librbd/api: clean up leftovers in Migration::prepare_import()

Dead code after return and an unused variable.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit b92ad49a35536fff87d840ffbf171aee61b05424)

11 months agoMerge pull request #51136 from RaminNietzsche/wip-cloud-sync-fixes-to-the-quincy
Shilpa Jagannath [Fri, 9 Aug 2024 17:10:34 +0000 (10:10 -0700)]
Merge pull request #51136 from RaminNietzsche/wip-cloud-sync-fixes-to-the-quincy

cloud sync: fix crash due to objs on cr stack

11 months agoMerge pull request #56166 from vshankar/wip-64249-quincy
Rishabh Dave [Fri, 9 Aug 2024 06:49:38 +0000 (12:19 +0530)]
Merge pull request #56166 from vshankar/wip-64249-quincy

quincy: qa: correct usage of DEBUGFS_META_DIR in dedent

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #53626 from lxbsz/wip-62513
Rishabh Dave [Fri, 9 Aug 2024 06:48:47 +0000 (12:18 +0530)]
Merge pull request #53626 from lxbsz/wip-62513

quincy: qa/cephfs: switch to python3 for centos stream 9

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #53629 from lxbsz/wip-62867
Rishabh Dave [Fri, 9 Aug 2024 06:48:40 +0000 (12:18 +0530)]
Merge pull request #53629 from lxbsz/wip-62867

quincy: qa: increase the http postBuffer size and disable sslVerify

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #55392 from dparmar18/wip-64067-quincy
Rishabh Dave [Fri, 9 Aug 2024 06:48:27 +0000 (12:18 +0530)]
Merge pull request #55392 from dparmar18/wip-64067-quincy

quincy: qa: fix error reporting string in assert_cluster_log

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #55745 from lxbsz/wip-64221
Rishabh Dave [Fri, 9 Aug 2024 06:48:15 +0000 (12:18 +0530)]
Merge pull request #55745 from lxbsz/wip-64221

quincy: qa/tasks/cephfs/test_misc: switch duration to timeout

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #56404 from batrick/wip-65062-quincy
Rishabh Dave [Fri, 9 Aug 2024 06:48:02 +0000 (12:18 +0530)]
Merge pull request #56404 from batrick/wip-65062-quincy

quincy: qa/cephfs: ignorelist clog of MDS_UP_LESS_THAN_MAX

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #59101 from zdover23/wip-doc-2024-08-09-backport-59807-to-quincy
Anthony D'Atri [Fri, 9 Aug 2024 01:03:11 +0000 (18:03 -0700)]
Merge pull request #59101 from zdover23/wip-doc-2024-08-09-backport-59807-to-quincy

quincy: docs/rados/operations/stretch-mode: warn device class is not supported

11 months agodocs/rados/operations/stretch-mode: warn device class is not supported 59101/head
Kamoltat Sirivadhna [Wed, 7 Aug 2024 19:20:41 +0000 (19:20 +0000)]
docs/rados/operations/stretch-mode: warn device class is not supported

Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
(cherry picked from commit aa1d8cf4fa321e24e850bd5f687a6ddad3ce05e3)

11 months agoMerge pull request #54015 from k0ste/wip-59362-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 21:00:59 +0000 (14:00 -0700)]
Merge pull request #54015 from k0ste/wip-59362-quincy

quincy: rgw: fix rgw cache invalidation after unregister_watch() error

11 months agoMerge pull request #53471 from k0ste/wip-57636-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 21:00:13 +0000 (14:00 -0700)]
Merge pull request #53471 from k0ste/wip-57636-quincy

quincy: rgw: Drain async_processor request queue during shutdown

11 months agoMerge pull request #53462 from k0ste/wip-55678-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:59:11 +0000 (13:59 -0700)]
Merge pull request #53462 from k0ste/wip-55678-quincy

quincy: rgw: remove potentially conficting definition of dout_subsys

11 months agoMerge pull request #53438 from k0ste/wip-62824-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:58:17 +0000 (13:58 -0700)]
Merge pull request #53438 from k0ste/wip-62824-quincy

quincy: RadosGW API: incorrect bucket quota in response to HEAD /{bucket}/?usage

11 months agoMerge pull request #53374 from jzhu116-bloomberg/wip-59694-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:57:10 +0000 (13:57 -0700)]
Merge pull request #53374 from jzhu116-bloomberg/wip-59694-quincy

quincy: rgw/notification: remove non x-amz-meta-* attributes from bucket notifications

11 months agoMerge pull request #52995 from k0ste/wip-59025-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:55:58 +0000 (13:55 -0700)]
Merge pull request #52995 from k0ste/wip-59025-quincy

quincy: rgw: use unique_ptr for flat_map emplace in BucketTrimWatche

11 months agoMerge pull request #52937 from k0ste/wip-58904-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:53:24 +0000 (13:53 -0700)]
Merge pull request #52937 from k0ste/wip-58904-quincy

quincy: rgw: Fix Browser POST content-length-range min value

11 months agoMerge pull request #52935 from k0ste/wip-54610-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:52:10 +0000 (13:52 -0700)]
Merge pull request #52935 from k0ste/wip-54610-quincy

quincy: RGW - Get quota on OPs with a bucket

11 months agoMerge pull request #52606 from cbodley/wip-62139-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:51:09 +0000 (13:51 -0700)]
Merge pull request #52606 from cbodley/wip-62139-quincy

quincy: rgw: s3 object lock avoids overflow in retention date

11 months agoMerge pull request #52054 from trociny/wip-61431-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:49:52 +0000 (13:49 -0700)]
Merge pull request #52054 from trociny/wip-61431-quincy

quincy: rgw: multisite data log flag not used

11 months agoMerge pull request #51446 from k0ste/wip-59730-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:48:20 +0000 (13:48 -0700)]
Merge pull request #51446 from k0ste/wip-59730-quincy

quincy: RGW: Solving the issue of not populating etag in Multipart upload result

11 months agoMerge pull request #51257 from k0ste/wip-55062-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:47:51 +0000 (13:47 -0700)]
Merge pull request #51257 from k0ste/wip-55062-quincy

quincy: radosgw-admin: fix segfault on pipe modify without source/dest zone specified

11 months agoMerge pull request #50539 from k0ste/wip-55151-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:46:47 +0000 (13:46 -0700)]
Merge pull request #50539 from k0ste/wip-55151-quincy

quincy: rgw: Update "CEPH_RGW_DIR_SUGGEST_LOG_OP" for remove entries

11 months agoMerge pull request #50520 from k0ste/wip-54227-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:44:35 +0000 (13:44 -0700)]
Merge pull request #50520 from k0ste/wip-54227-quincy

quincy: rgw: Erase old storage class attr when the object is rewrited using r…

11 months agoMerge pull request #50519 from k0ste/wip-54201-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:44:10 +0000 (13:44 -0700)]
Merge pull request #50519 from k0ste/wip-54201-quincy

quincy: rgw: CopyObject works with x-amz-copy-source-if-* headers

11 months agoMerge pull request #48082 from pritha-srivastava/wip-57509-quincy
Shilpa Jagannath [Thu, 8 Aug 2024 20:43:42 +0000 (13:43 -0700)]
Merge pull request #48082 from pritha-srivastava/wip-57509-quincy

quincy: rgw/sts: modify max_session_duration using update role REST API/ radosgw-admin command.

11 months agoMerge pull request #57488 from ljflores/wip-66040-quincy
Yuri Weinstein [Thu, 8 Aug 2024 14:55:37 +0000 (07:55 -0700)]
Merge pull request #57488 from ljflores/wip-66040-quincy

quincy: qa/suites/rados/singleton: add POOL_APP_NOT_ENABLED to ignorelist

Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
11 months agoMerge pull request #50551 from rzarzynski/wip-59084-quincy
Yuri Weinstein [Thu, 8 Aug 2024 14:51:05 +0000 (07:51 -0700)]
Merge pull request #50551 from rzarzynski/wip-59084-quincy

quincy: mon: add proxy to cache tier options

nReviewed-by: Neha Ojha <nojha@redhat.com>

11 months agoMerge pull request #58753 from adk3798/quincy-only-bind-to-network
Adam King [Wed, 7 Aug 2024 21:37:48 +0000 (17:37 -0400)]
Merge pull request #58753 from adk3798/quincy-only-bind-to-network

quincy: mgr/cephadm: add ability for haproxy, prometheus, grafana to bind on specific ip

Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #59080 from zdover23/wip-doc-2024-08-07-backport-59040-to-quincy
Anthony D'Atri [Wed, 7 Aug 2024 19:26:24 +0000 (15:26 -0400)]
Merge pull request #59080 from zdover23/wip-doc-2024-08-07-backport-59040-to-quincy

quincy: doc: documenting the feature that scrub clear the entries from damage…

11 months agoMerge pull request #58762 from adk3798/wip-66477-quincy
Adam King [Wed, 7 Aug 2024 19:07:34 +0000 (15:07 -0400)]
Merge pull request #58762 from adk3798/wip-66477-quincy

quincy: qa/suites: add "mon down" log variations to ignorelist

Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #58761 from adk3798/wip-66957-quincy
Adam King [Wed, 7 Aug 2024 19:06:34 +0000 (15:06 -0400)]
Merge pull request #58761 from adk3798/wip-66957-quincy

quincy: cephadm: turn off cgroups_split setting  when bootstrapping with --no-cgroups-split

Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #58756 from adk3798/wip-65726-quincy
Adam King [Wed, 7 Aug 2024 19:05:46 +0000 (15:05 -0400)]
Merge pull request #58756 from adk3798/wip-65726-quincy

quincy: python-common: handle "anonymous_access: false" in to_json of Grafana spec

Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #56308 from adk3798/quincy-timemaster
Adam King [Wed, 7 Aug 2024 19:05:09 +0000 (15:05 -0400)]
Merge pull request #56308 from adk3798/quincy-timemaster

quincy: cephadm: add timemaster to timesync services list

Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #57442 from joscollin/wip-65984-quincy
Rishabh Dave [Wed, 7 Aug 2024 18:46:01 +0000 (00:16 +0530)]
Merge pull request #57442 from joscollin/wip-65984-quincy

quincy: mgr/stats: initialize mx_last_updated in FSPerfStats

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #54712 from mchangir/wip-63589-quincy
Rishabh Dave [Wed, 7 Aug 2024 18:39:57 +0000 (00:09 +0530)]
Merge pull request #54712 from mchangir/wip-63589-quincy

quincy: qa: run kernel_untar_build with newer tarball

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #56393 from batrick/wip-65059-quincy
Rishabh Dave [Wed, 7 Aug 2024 18:35:02 +0000 (00:05 +0530)]
Merge pull request #56393 from batrick/wip-65059-quincy

quincy: qa/suites/fs/nfs: use standard health ignorelist

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #56417 from batrick/wip-65089-quincy
Rishabh Dave [Wed, 7 Aug 2024 18:30:31 +0000 (00:00 +0530)]
Merge pull request #56417 from batrick/wip-65089-quincy

quincy: qa/cephfs: add mgr debugging

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #56667 from batrick/wip-65107-quincy
Rishabh Dave [Wed, 7 Aug 2024 18:25:57 +0000 (23:55 +0530)]
Merge pull request #56667 from batrick/wip-65107-quincy

quincy: qa/cephfs: add probabilistic ignorelist for pg_health

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #52986 from leonid-s-usov/backport/strip-nofail/quincy
Rishabh Dave [Wed, 7 Aug 2024 18:07:13 +0000 (23:37 +0530)]
Merge pull request #52986 from leonid-s-usov/backport/strip-nofail/quincy

quincy: nofail option in fstab not supported

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #55238 from joscollin/wip-64074-quincy
Rishabh Dave [Wed, 7 Aug 2024 17:59:32 +0000 (23:29 +0530)]
Merge pull request #55238 from joscollin/wip-64074-quincy

quincy: pybind/mgr/mirroring: drop mon_host from peer_list

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #56168 from vshankar/wip-64046-quincy
Rishabh Dave [Wed, 7 Aug 2024 17:54:25 +0000 (23:24 +0530)]
Merge pull request #56168 from vshankar/wip-64046-quincy

quincy: qa: set mds config with `config set` for a particular test

Reviewed-by: Rishabh Dave <ridave@redhat.com>
11 months agoMerge pull request #58316 from cbodley/wip-66725
Yuri Weinstein [Wed, 7 Aug 2024 14:25:06 +0000 (07:25 -0700)]
Merge pull request #58316 from cbodley/wip-66725

quincy: build: Make boost_url a list

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Kyr Shatskyy <kyrylo.shatskyy@suse.com>
11 months agoMerge pull request #56815 from Matan-B/wip-65307-quincy
Yuri Weinstein [Wed, 7 Aug 2024 14:21:47 +0000 (07:21 -0700)]
Merge pull request #56815 from Matan-B/wip-65307-quincy

quincy: osd/SnapMapper: fix _lookup_purged_snap

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
11 months agoMerge pull request #55868 from trociny/wip-64649-quincy
Yuri Weinstein [Wed, 7 Aug 2024 14:21:16 +0000 (07:21 -0700)]
Merge pull request #55868 from trociny/wip-64649-quincy

quincy: mon/OSDMonitor: fix get_min_last_epoch_clean()

Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
11 months agodoc: documenting the feature that scrub clear the entries from damage table on repair 59080/head
neeraj pratap singh [Mon, 5 Aug 2024 19:50:35 +0000 (01:20 +0530)]
doc: documenting the feature that scrub clear the entries from damage table on repair

Fixes: https://tracker.ceph.com/issues/67337
Signed-off-by: Neeraj Pratap Singh <neesingh@redhat.com>
(cherry picked from commit 140e77638dc95fefcf62f01fe7e45bc0729439be)

11 months agoMerge pull request #58760 from adk3798/wip-66790-quincy
Adam King [Wed, 7 Aug 2024 13:22:07 +0000 (09:22 -0400)]
Merge pull request #58760 from adk3798/wip-66790-quincy

quincy: cephadm: disable ms_bind_ipv4 if we will enable ms_bind_ipv6

Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #58759 from adk3798/wip-65967-quincy
Adam King [Wed, 7 Aug 2024 13:21:29 +0000 (09:21 -0400)]
Merge pull request #58759 from adk3798/wip-65967-quincy

quincy: mgr/cephadm: make setting --cgroups=split configurable for adopted daemons

Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #58757 from adk3798/wip-65950-quincy
Adam King [Wed, 7 Aug 2024 13:20:49 +0000 (09:20 -0400)]
Merge pull request #58757 from adk3798/wip-65950-quincy

quincy: mgr/cephadm: cleanup iscsi keyring upon daemon removal

Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #58755 from adk3798/wip-65419-quincy
Adam King [Wed, 7 Aug 2024 13:19:23 +0000 (09:19 -0400)]
Merge pull request #58755 from adk3798/wip-65419-quincy

quincy: cephadm: fix host-maintenance command always exiting with a failure

Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #58754 from adk3798/wip-65380-quincy
Adam King [Wed, 7 Aug 2024 13:18:31 +0000 (09:18 -0400)]
Merge pull request #58754 from adk3798/wip-65380-quincy

quincy: mgr/cephadm: make client-keyring deploying ceph.conf optional

Reviewed-by: John Mulligan <jmulligan@redhat.com>
11 months agoMerge pull request #56930 from adk3798/wip-65513-quincy
Adam King [Wed, 7 Aug 2024 13:13:46 +0000 (09:13 -0400)]
Merge pull request #56930 from adk3798/wip-65513-quincy

quincy: mgr/dashboard: fix duplicate grafana panels when on mgr failover

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
11 months agocephadm.py: add timemaster to timesync services list 56308/head
Florent Carli [Tue, 12 Mar 2024 17:31:16 +0000 (18:31 +0100)]
cephadm.py: add timemaster to timesync services list

On debian/ubuntu, if you need PTP, it's possible to use the linuxptp package for time-synchonization.
In that case the systemd service is called timemaster and is a wrapper for chrony/ntpd/phc2sys/ptp4l.

Signed-off-by: Florent Carli <florent.carli@rte-france.com>
(cherry picked from commit 4ee1c761e50e3c3feed89ccc5c450ac96681b778)

Conflicts:
src/cephadm/cephadm.py

11 months agoMerge pull request #56837 from rishabh-d-dave/wip-65441-quincy
Xiubo Li [Wed, 7 Aug 2024 11:52:00 +0000 (19:52 +0800)]
Merge pull request #56837 from rishabh-d-dave/wip-65441-quincy

quincy: qa/cephfs: CephFSTestCase.create_client() must keyring