]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Zac Dover [Fri, 6 Sep 2024 07:56:27 +0000 (17:56 +1000)]
doc/README.md: edit "Build Prerequisites"
Make the sentences in the "Build Prerequisites" section of README.md
more direct.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Thu, 5 Sep 2024 17:21:47 +0000 (13:21 -0400)]
Merge pull request #56597 from liangmingyuanneo/optimize-reshard
rgw reshard: optimize reshard process to minimum blocking time
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Guillaume Abrioux [Thu, 5 Sep 2024 15:04:51 +0000 (17:04 +0200)]
Merge pull request #59170 from guits/remove-legacy-disk-sorting
ceph-volume: switch over to new disk sorting behavior
Guillaume Abrioux [Thu, 5 Sep 2024 15:00:04 +0000 (17:00 +0200)]
Merge pull request #59604 from guits/wip-osd-id-raw
ceph-volume: pass self.osd_id to create_id() call
Mark Kogan [Thu, 5 Sep 2024 14:23:30 +0000 (17:23 +0300)]
Merge pull request #59386 from mkogan1/wip-qlen_qactive
rgw: decrement qlen/qactive perf counters on error
Anthony D'Atri [Thu, 5 Sep 2024 13:54:59 +0000 (09:54 -0400)]
Merge pull request #59613 from zdover23/wip-doc-2024-09-05-rados-config-mon-lookup-dns
doc/rados: add link to messenger v2 info in mon-lookup-dns.rst
Patrick Donnelly [Thu, 5 Sep 2024 12:37:24 +0000 (08:37 -0400)]
Merge PR #59414 into main
* refs/pull/59414/head:
mds: move fscrypt_last_block to vector in mds_co mempool
mds: move fscrypt_file inode_t metadata to mds_co mempool
mds: move fscrypt_auth inode_t metadata to mds_co mempool
include/buffer: add helpers for uint8_t vectors
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Zac Dover [Thu, 5 Sep 2024 07:59:15 +0000 (17:59 +1000)]
doc/rados: add link to messenger v2 info in mon-lookup-dns.rst
Add a link to the page about Messenger v2 to the end of
doc/rados/configuration/mon-lookup-dns.rst.
Fixes: https://tracker.ceph.com/issues/58752
Signed-off-by: Zac Dover <zac.dover@proton.me>
Yingxin [Thu, 5 Sep 2024 02:29:09 +0000 (10:29 +0800)]
Merge pull request #58438 from myoungwon/wip-batched-ool-writes
crimson/os/seastore/rbm: write merge-able ool extents at once
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin [Thu, 5 Sep 2024 02:28:32 +0000 (10:28 +0800)]
Merge pull request #59570 from zhscn/fix-node-capacity
crimson/os/seastore: cleanup lba/backref node capacity
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Laura Flores [Thu, 5 Sep 2024 01:03:28 +0000 (20:03 -0500)]
Merge pull request #59474 from athanatos/sjust/for-review/wip-67755-fix-msr-feature
osd: fix require_min_compat_client handling for msr rules
Yuval Lifshitz [Wed, 4 Sep 2024 14:13:17 +0000 (17:13 +0300)]
Merge pull request #59490 from Suyashd999/fix-mfr1
rgw/rgw_aio: forwarding reference passed to std::move()
Reviewed-By: Adam Emerson <aemerson@ibm.com>, Yuval Lifshitz <ylifshit@ibm.com>
Nizamudeen A [Wed, 4 Sep 2024 13:57:52 +0000 (19:27 +0530)]
Merge pull request #59530 from rhcs-dashboard/api_test_mgr_module_failure
qa/tests: fix test_list_enabled_modules timeout error
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Guillaume Abrioux [Wed, 4 Sep 2024 13:12:12 +0000 (15:12 +0200)]
ceph-volume: pass self.osd_id to create_id() call
This fixes a regression
(most likely introduced with
04c93a1ed42 )
Current (broken) behavior:
```
[root@devel1-1 /]# ceph osd tree
ID CLASS WEIGHT TYPE NAME STATUS REWEIGHT PRI-AFF
-1 0 root default
0 0 osd.0 destroyed 0 1.00000
[root@devel1-1 /]# ceph-volume raw prepare --bluestore --data /dev/vdb --osd-id 0
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring -i - osd new
543e0268 -ea66-451f-a2f6-
95ae60ab6146
Running command: /usr/bin/mount -t tmpfs tmpfs /var/lib/ceph/osd/ceph-1
Running command: /usr/sbin/restorecon /var/lib/ceph/osd/ceph-1
Running command: /usr/bin/chown -R ceph:ceph /dev/vdb
Running command: /usr/bin/ln -s /dev/vdb /var/lib/ceph/osd/ceph-1/block
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring mon getmap -o /var/lib/ceph/osd/ceph-1/activate.monmap
stderr: got monmap epoch 1
--> Creating keyring file for osd.1
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-1/keyring
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-1/
Running command: /usr/bin/ceph-osd --cluster ceph --osd-objectstore bluestore --mkfs -i 1 --monmap /var/lib/ceph/osd/ceph-1/activate.monmap --keyfile - --osd-data /var/lib/ceph/osd/ceph-1/ --osd-uuid
543e0268 -ea66-451f-a2f6-
95ae60ab6146 --setuser ceph --setgroup ceph
stderr: 2024-09-04T11:46:54.283+0000
7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-1//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T11:46:54.283+0000
7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-1//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T11:46:54.283+0000
7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-1//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T11:46:54.283+0000
7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1/) _read_fsid unparsable uuid
--> ceph-volume raw dmcrypt prepare successful for: /dev/vdb
[root@devel1-1 /]# ceph osd tree
ID CLASS WEIGHT TYPE NAME STATUS REWEIGHT PRI-AFF
-1 0 root default
0 0 osd.0 destroyed 0 1.00000
1 0 osd.1 down 1.00000 1.00000
```
A new osd id has been generated while we want to reuse the existing one (0 in this case).
Expected (fixed) behavior:
```
[root@devel1-1 /]# ceph osd tree
ID CLASS WEIGHT TYPE NAME STATUS REWEIGHT PRI-AFF
-1 0 root default
0 0 osd.0 destroyed 0 1.00000
[root@devel1-1 /]# ceph-volume raw prepare --bluestore --data /dev/vdb --osd-id 0
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring osd tree -f json
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring -i - osd new
c87841fb -f56f-40a2-a653-
62bb092e8e95 0
Running command: /usr/bin/mount -t tmpfs tmpfs /var/lib/ceph/osd/ceph-0
Running command: /usr/sbin/restorecon /var/lib/ceph/osd/ceph-0
Running command: /usr/bin/chown -R ceph:ceph /dev/vdb
Running command: /usr/bin/ln -s /dev/vdb /var/lib/ceph/osd/ceph-0/block
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring mon getmap -o /var/lib/ceph/osd/ceph-0/activate.monmap
stderr: got monmap epoch 1
--> Creating keyring file for osd.0
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-0/keyring
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-0/
Running command: /usr/bin/ceph-osd --cluster ceph --osd-objectstore bluestore --mkfs -i 0 --monmap /var/lib/ceph/osd/ceph-0/activate.monmap --keyfile - --osd-data /var/lib/ceph/osd/ceph-0/ --osd-uuid
c87841fb -f56f-40a2-a653-
62bb092e8e95 --setuser ceph --setgroup ceph
stderr: 2024-09-04T13:07:39.125+0000
7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-0//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T13:07:39.125+0000
7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-0//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T13:07:39.126+0000
7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-0//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T13:07:39.126+0000
7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0/) _read_fsid unparsable uuid
--> ceph-volume raw dmcrypt prepare successful for: /dev/vdb
[root@devel1-1 /]# ceph osd tree
ID CLASS WEIGHT TYPE NAME STATUS REWEIGHT PRI-AFF
-1 0 root default
0 0 osd.0 down 0 1.00000
```
Fixes: https://tracker.ceph.com/issues/67898
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
Guillaume Abrioux [Wed, 4 Sep 2024 11:21:03 +0000 (13:21 +0200)]
Merge pull request #59573 from guits/tracker-67873
ceph-volume: fix generic activation with raw osds
Ilya Dryomov [Wed, 4 Sep 2024 11:03:04 +0000 (13:03 +0200)]
Merge pull request #59551 from idryomov/wip-67845
librbd/migration: prune snapshot extents in RawFormat::list_snaps()
Reviewed-by: Ramana Raja <rraja@redhat.com>
Yuval Lifshitz [Wed, 4 Sep 2024 10:21:05 +0000 (13:21 +0300)]
Merge pull request #59562 from yuvalif/wip-yuval-67857
rgw/notifications: update release notes with fix to principalId
Reviewed-By: Casey Bodley <cbodley@ibm.com>
Matan Breizman [Wed, 4 Sep 2024 09:30:38 +0000 (12:30 +0300)]
Merge pull request #59102 from xxhdx1985126/wip-67450
crimson/osd/pg: fix wrong lambda capture of transactions in `PG::submit_error_log()`
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Nizamudeen A [Fri, 30 Aug 2024 11:46:57 +0000 (17:16 +0530)]
qa/tests: fix test_list_enabled_modules timeout error
This test deals with enabling/disabling the modules. The assumption I
have is after enabling the
module test will wait for an active mgr but its not able to find it in
time and it fails. so taking inspiration from https://github.com/ceph/ceph/pull/58995/commits/
6c7253be6f6fbfa6faed7a539cb78847fec04580 adding retries and logs to see if that's the case
Fixes: https://tracker.ceph.com/issues/62972
Signed-off-by: Nizamudeen A <nia@redhat.com>
Rishabh Dave [Wed, 4 Sep 2024 06:17:10 +0000 (11:47 +0530)]
Merge pull request #57896 from mchangir/ptl-tool.py-fix-escape-sequences
ptl-tool.py: replace regular strings with raw string literal for regular expressions
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Samuel Just [Wed, 4 Sep 2024 05:38:14 +0000 (22:38 -0700)]
Merge pull request #59588 from athanatos/sjust/wip-nvmeof-reenable
mon: enable nvmeof gw monitor
Reviewed-by: Alexander Indenbaum <aindenba@redhat.com>
Yuval Lifshitz [Wed, 4 Sep 2024 04:48:47 +0000 (07:48 +0300)]
Merge pull request #57878 from Suyashd999/fix-uam4
cls: avoid reusing moved-from buffers in cls_queue_src.cc
Yuval Lifshitz [Wed, 4 Sep 2024 04:47:28 +0000 (07:47 +0300)]
Merge pull request #59489 from Suyashd999/fix-sia1
rgw/cls_rgw: integer is being interpreted as a character code when assigning it to a string
Yuval Lifshitz [Wed, 4 Sep 2024 04:43:40 +0000 (07:43 +0300)]
Merge pull request #57854 from adamemerson/wip-66335
neorados: Fix use-after-move in Builder::build_
liangmingyuan [Sat, 24 Aug 2024 09:03:13 +0000 (17:03 +0800)]
cls/rgw: add a helper function for calls to cls_cxx_map_remove_key()
Add some testing cases and do cleanup too.
Signed-off-by: Mingyuan Liang <liangmingyuan@baidu.com>
Casey Bodley [Wed, 4 Sep 2024 00:43:34 +0000 (20:43 -0400)]
Merge pull request #59535 from cbodley/wip-qa-rgw-multisite-account-zone
qa/rgw/multisite: specify realm/zonegroup/zone args for 'account create'
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Anthony D'Atri [Tue, 3 Sep 2024 19:36:13 +0000 (15:36 -0400)]
Merge pull request #59577 from cityofships/main
doc/mds: improve wording
Matan Breizman [Tue, 3 Sep 2024 16:02:51 +0000 (19:02 +0300)]
Merge pull request #59185 from NitzanMordhai/wip-nitzan-crimson-help-args
crimson: early config checks and version
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Tue, 3 Sep 2024 15:55:30 +0000 (18:55 +0300)]
Merge pull request #59407 from xxhdx1985126/wip-67675
crimson/osd/pg: only mutate obc for user triggerred transactions
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Anthony D'Atri [Tue, 3 Sep 2024 15:44:33 +0000 (11:44 -0400)]
Merge pull request #59546 from anthonyeleven/improve-rados-operations-health-checks.rst
doc/rados/operations: Improve health-checks.rst
Anthony D'Atri [Sun, 1 Sep 2024 00:32:17 +0000 (20:32 -0400)]
doc/rados/operations: Improve health-checks.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Zac Dover [Tue, 3 Sep 2024 11:32:08 +0000 (21:32 +1000)]
Merge pull request #59545 from anthonyeleven/improve-radosgw-configref
doc/radosgw: Improve config-ref.rst
Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Piotr Parczewski [Tue, 3 Sep 2024 11:25:26 +0000 (13:25 +0200)]
doc/mds: improve wording
Signed-off-by: Piotr Parczewski <piotr@stackhpc.com>
Matan Breizman [Tue, 3 Sep 2024 08:53:56 +0000 (11:53 +0300)]
Merge pull request #59368 from xxhdx1985126/wip-crimson-backfill-cancel-part2
crimson/osd: support backfill cancellation ---- part2
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Guillaume Abrioux [Tue, 3 Sep 2024 08:20:34 +0000 (10:20 +0200)]
ceph-volume: fix generic activation with raw osds
Typical failure:
```
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph-authtool --gen-print-key
--> Failed to activate via raw: activate() takes 1 positional argument but 5 were given
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph-authtool --gen-print-key
--> Failed to activate via LVM: could not find osd.0 with osd_fsid
1e764f4a -db4b-4b41-86eb-
468efe4c3f44
--> Failed to activate via simple: 'Namespace' object has no attribute 'json_config'
--> Failed to activate any OSD(s)
```
04c93a1ed42 seems to have broken it.
This commit fixes it.
Fixes: https://tracker.ceph.com/issues/67873
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
Zhang Song [Tue, 3 Sep 2024 07:26:59 +0000 (15:26 +0800)]
crimson/os/seastore: update the capacity calculation for lba/backref internal/leaf nodes
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
Zhang Song [Tue, 3 Sep 2024 07:14:56 +0000 (15:14 +0800)]
crimson/os/seastore: validate the node capacity for lba/backref node
correct the LEAF_NODE_CAPACITY for backref nodes
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
Zhang Song [Tue, 3 Sep 2024 07:09:04 +0000 (15:09 +0800)]
crimson/os/seastore: backref_node_meta_le_t should use paddr_le_t as template parameter
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
Zhang Song [Tue, 3 Sep 2024 07:06:36 +0000 (15:06 +0800)]
crimson/os/seastore: add packed attribute to lba/backref map value
Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
afreen23 [Tue, 3 Sep 2024 06:42:56 +0000 (12:12 +0530)]
Merge pull request #59554 from rhcs-dashboard/WrongUIDForUSer
mgr/dashboard: Wrong(half) uid is observed in dashboard
Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
Vallari Agrawal [Tue, 3 Sep 2024 05:59:01 +0000 (11:29 +0530)]
Merge pull request #59178 from VallariAg/wip-nvmeof-teuthology-v6
qa: add namespace and scale testing for nvmeof teuthology suite
Ilya Dryomov [Mon, 2 Sep 2024 19:49:48 +0000 (21:49 +0200)]
Merge pull request #59478 from idryomov/wip-67752
rbd: amend "rbd {group,} rename" and "rbd mirror pool" command descriptions
Reviewed-by: Ramana Raja <rraja@redhat.com>
Reviewed-by: N Balachandran <nibalach@redhat.com>
Vallari Agrawal [Mon, 26 Aug 2024 13:18:24 +0000 (18:48 +0530)]
qa/suites/nvmeof: wait for service "nvmeof.mypool.mygroup0"
This is because nvmeof gateway group names are now
part of service id.
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Vallari Agrawal [Thu, 22 Aug 2024 13:12:42 +0000 (18:42 +0530)]
qa/suites/nvmeof: increase hosts in cluster setup
In "nvmeof" task, change "client" config to "installer"
which allows to take inputs like "host.a".
nvmeof/basic: change 2-gateway-2-initiator to
4-gateway-2-inititator cluster
nvmeof/thrash: change 3-gateway-1-initiator to
4-gateway-1-inititaor cluster
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Nizamudeen A [Mon, 2 Sep 2024 13:09:05 +0000 (18:39 +0530)]
Merge pull request #58478 from rhcs-dashboard/carbon-forms-fs
mgr/dashboard: carbonize fs forms
Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: ivoalmeida <NOT@FOUND>
Reviewed-by: sayaleeraut <NOT@FOUND>
Nizamudeen A [Mon, 2 Sep 2024 11:56:36 +0000 (17:26 +0530)]
Merge pull request #59496 from rhcs-dashboard/ws-carbon-table
mgr/dashboard: carbon datatable minor bug fixes
Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: ivoalmeida <NOT@FOUND>
Vallari Agrawal [Wed, 21 Aug 2024 09:38:21 +0000 (15:08 +0530)]
qa: move nvmeof shell scripts to qa/workunits/nvmeof
Move all scripts qa/workunits/rbd/nvmeof_*.sh
to qa/workunits/nvmeof/*.sh
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Yuval Lifshitz [Mon, 2 Sep 2024 11:07:19 +0000 (14:07 +0300)]
rgw/notifications: update release notes with fix to principalId
Fixes: https://tracker.ceph.com/issues/67857
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
Dnyaneshwari [Mon, 2 Sep 2024 06:29:23 +0000 (11:59 +0530)]
mgr/dashboard: Wrong(half) uid is observed in dashboard
Fixes: https://tracker.ceph.com/issues/67850
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>
Zac Dover [Mon, 2 Sep 2024 10:17:08 +0000 (20:17 +1000)]
Merge pull request #59556 from mcv21/patch-2
doc: Correct link to Prometheus docs
Reviewed-by: Zac Dover <zac.dover@proton.me>
Venky Shankar [Mon, 2 Sep 2024 09:43:34 +0000 (15:13 +0530)]
Merge pull request #58543 from rishabh-d-dave/tracker-65808
cephfs: disallow removing root_squash via "fs authorize" cmd
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Matthew Vernon [Mon, 2 Sep 2024 09:16:36 +0000 (10:16 +0100)]
doc: Correct link to Prometheus docs
The link is to the `#http_sd_config` anchor in the prometheus config docs; that link only works without the trailing `/`.
This correction would ideally get backported to at least reef & squid.
Signed-off-by: Matthew Vernon <mvernon@wikimedia.org>
Nizamudeen A [Thu, 29 Aug 2024 06:16:58 +0000 (11:46 +0530)]
mgr/dashboard: carbon datatable minor bug fixes
- fixes empty white spaces in the table
- fixes some tables detail component where it didn't had carbon table
- fix the multi-site details view table not showing up
- fix the nvmeof modals like namespace deletion not getting opened
- fix the cached reload button status not showing correctly in rgw table
- fix show button in the rgw users detail page broken
- fix the multi-cluster list component issue where details component is
not following carbon attributes
- fixing the configuration page where it does a page reload on form
submit. instead doing a table refresh
- additionally fixed a validation issue in the service form
fixes the test failures
Fixes: https://tracker.ceph.com/issues/67788
Fixes: https://tracker.ceph.com/issues/67552
Signed-off-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Tue, 9 Jul 2024 09:18:21 +0000 (14:48 +0530)]
mgr/dashboard: carbonize cephfs forms
This commit also covers the nfs form
Fixes: https://tracker.ceph.com/issues/67663
Signed-off-by: Nizamudeen A <nia@redhat.com>
Ilya Dryomov [Sun, 1 Sep 2024 13:50:37 +0000 (15:50 +0200)]
librbd/migration: don't include ImageState.h in formats
src_image_ctx, whether dummy for RawFormat and QCOWFormat or real for
NativeFormat, is managed by OpenSourceImageRequest.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Sat, 31 Aug 2024 10:33:55 +0000 (12:33 +0200)]
librbd/migration: prune snapshot extents in RawFormat::list_snaps()
list-snaps is exempt from clipping in ImageDispatcher::PreprocessVisitor
because it's considered to be an internal API. Further, reads issued
by ObjectCopyRequest based on list-snaps results may also be exempt
because of READ_FLAG_DISABLE_CLIPPING.
Since RawFormat allows specifying a set of snapshots (possibly of
varying size!) to be imported, it needs to compensate for that in its
list-snaps implementation. Otherwise, an out-of-bounds read will
eventually be submitted to the stream.
Fixes: https://tracker.ceph.com/issues/67845
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Gil Bregman [Sun, 1 Sep 2024 17:21:57 +0000 (20:21 +0300)]
Merge pull request #59547 from gbregman/main
Revert SPDK rpc fields in nvmeof configuration
Ilya Dryomov [Sat, 31 Aug 2024 10:00:48 +0000 (12:00 +0200)]
librbd: factor out prune_extents() from prune_parent_extents()
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Gil Bregman [Sun, 1 Sep 2024 11:51:36 +0000 (14:51 +0300)]
mgr/cephadm: revert SPDK RPC fields in nvmeof configuration
Fixes https://tracker.ceph.com/issues/67844
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Myoungwon Oh [Wed, 3 Jul 2024 07:52:45 +0000 (16:52 +0900)]
crimson/os/seastore/rbm: write merged-able ool extents at once
This commit intens to write meraged-able ool extents, each of
which is located at consecutive address, to the RBM at once.
Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
Gil Bregman [Sun, 1 Sep 2024 11:50:50 +0000 (14:50 +0300)]
python-common/ceph/deployment: revert SPDK RPC fields in nvmeof configuration
Fixes https://tracker.ceph.com/issues/67844
Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
Zac Dover [Sun, 1 Sep 2024 10:15:46 +0000 (20:15 +1000)]
Merge pull request #59544 from VallariAg/wip-teuthology-workflow
doc: update tests-integration-testing-teuthology-workflow.rst
Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Vallari Agrawal [Sat, 31 Aug 2024 14:27:25 +0000 (19:57 +0530)]
doc: update tests-integration-testing-teuthology-workflow.rst
* add "Infrastructure" section.
* move "Naming the ceph-ci branch" section under
"Getting binaries - Build Ceph". Also mention
about centos9-only trick.
* in "Teuthology Archives", mention about developer
playground machines and ceph log files.
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Anthony D'Atri [Sat, 31 Aug 2024 23:53:35 +0000 (19:53 -0400)]
doc/radosgw: Improve config-ref.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Anthony D'Atri [Sat, 31 Aug 2024 23:39:05 +0000 (19:39 -0400)]
Merge pull request #59512 from bugwz/alerts-receivers
mgr/dashboard: alerts module supports setting multiple email recipients
Suyash Dongre [Wed, 28 Aug 2024 19:11:53 +0000 (00:41 +0530)]
integer being interpreted as a character code when assigning to a string
clang-tidy original warning:
`src/cls/rgw/cls_rgw.cc: warning: an integer is interpreted as a character code when assigning it to a string; if this is intended, cast the integer to the appropriate character type; if you want a string representation, use the appropriate conversion facility [bugprone-string-integer-assignment]
key = BI_PREFIX_CHAR;
^
/home/suyash/ceph/src/cls/rgw/cls_rgw.cc:51:24: note: expanded from macro 'BI_PREFIX_CHAR' #define BI_PREFIX_CHAR 0x80`
**On the following lines we are getting the warning:**
1. 138
2. 319
3. 342
4. 2875
5. 2966
6. 3294
7. 3304
8. 3307
9. 3418
10. 3421
Signed-off-by: Suyash Dongre <suyashd999@gmail.com>
Yuval Lifshitz [Sat, 31 Aug 2024 14:28:24 +0000 (17:28 +0300)]
Merge pull request #59508 from rkhudov/src-test-rgw-bucket_notification-update-documentation
src/test/rgw/bucket_notification/README.rst: update RabbitMQ documentation for RGW notification tests
Radoslaw Zarzynski [Tue, 10 Jan 2023 14:39:31 +0000 (14:39 +0000)]
test/crimson: verify the backfill cancellation & resumption
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Radoslaw Zarzynski [Tue, 10 Jan 2023 14:38:31 +0000 (14:38 +0000)]
test/crimson: add event-type-checking next_round2() to BackfillFixture
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Radoslaw Zarzynski [Mon, 9 Jan 2023 15:02:36 +0000 (15:02 +0000)]
crimson/osd: wire up backfill resumption
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Radoslaw Zarzynski [Mon, 9 Jan 2023 14:59:53 +0000 (14:59 +0000)]
crimson/osd: BackfillMachine does support cancel and resume now
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Ilya Dryomov [Sat, 31 Aug 2024 07:10:46 +0000 (09:10 +0200)]
Merge pull request #59531 from nbalacha/wip-nbalacha-unit-test-fix
test/rbd-mirror: fix BootstrapReplayer tests that use expect_is_linked()
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Zac Dover [Sat, 31 Aug 2024 04:40:00 +0000 (14:40 +1000)]
Merge pull request #59528 from zdover23/wip-doc-2024-08-30-ceph-volume-lvm-newdb-bluefs-spillover
doc/ceph-volume: add spillover fix procedure
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Neha Ojha [Fri, 30 Aug 2024 21:14:18 +0000 (14:14 -0700)]
Merge pull request #59484 from shraddhaag/add-email-contact
mailmap, githubmap, organisationmap: Add Shraddha Agrawal
Reviewed-by: Neha Ojha <nojha@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Casey Bodley [Fri, 30 Aug 2024 17:52:01 +0000 (13:52 -0400)]
qa/rgw/multisite: add optional --default arg to 'realm pull'
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 30 Aug 2024 15:29:52 +0000 (11:29 -0400)]
qa/rgw/multisite: fix spelling of is_default in realm configs
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Fri, 30 Aug 2024 15:21:50 +0000 (11:21 -0400)]
qa/rgw/multisite: specify realm/zonegroup/zone args for 'account create'
in the rgw/multisite suite, jobs fail on user creation:
> radosgw-admin --cluster c1 account create --account-id RGW11111111111111111
> radosgw-admin --cluster c1 user create --uid rgw-multisite-test-user --account-id RGW11111111111111111 --account-root --rgw-zone test-zone1 --rgw-zonegroup test-zonegroup --rgw-realm test-realm --display-name TestUser --gen-access-key --gen-secret
> could not create user: unable to create user, Failed to load account by id
realms/two-zones.yaml misspells `is_default` as `is default` for the
realm, so it doesn't get set as default. the `account create` command
doesn't specify a realm/zonegroup/zone, so operates on the "default"
zone and zonegroup
use `zone_args()` to add the explicit realm/zonegroup/zone arguments
Fixes: https://tracker.ceph.com/issues/67839
Signed-off-by: Casey Bodley <cbodley@redhat.com>
afreen23 [Fri, 30 Aug 2024 12:49:18 +0000 (18:19 +0530)]
Merge pull request #59448 from rhcs-dashboard/improve-prometheus-service
mgr/dashboard: improve prometheus service request handling
Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
Venky Shankar [Fri, 30 Aug 2024 12:23:31 +0000 (17:53 +0530)]
Merge PR #59309 into main
* refs/pull/59309/head:
qa: ignore warnings variations
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
N Balachandran [Fri, 30 Aug 2024 12:14:27 +0000 (17:44 +0530)]
tests/rbd-mirror: fixes BootstrapReplayer test
When run with debug_rbd_mirror >= 10, is_linked() is also
called as part of a log message. This causes the tests using
expect_is_linked() to fail.
Signed-off-by: N Balachandran <nibalach@redhat.com>
Ilya Dryomov [Fri, 30 Aug 2024 12:00:44 +0000 (14:00 +0200)]
rbd: mention namespace in "rbd mirror pool" command descriptions
Commit
5e64748927d0 ("doc/rbd: add namespace information for mirror
commands") did this for the man page, update the built-in help as well.
The "by default" bit in the description of "rbd mirror pool enable" and
"rbd mirror pool disable" commands is specific to pool mode which is in
turn specific to journal-based mirroring, so it's removed.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Zac Dover [Fri, 30 Aug 2024 11:16:57 +0000 (21:16 +1000)]
doc/ceph-volume: add spillover fix procedure
Add a procedure that explains how, after an upgrade, to move bytes that
have spilled over to a relatively slow device back to the faster device.
This procedure was developed by Chris Dunlop on the [ceph-users] mailing
list, here: https://lists.ceph.io/hyperkitty/list/ceph-users@ceph.io/message/POPUFSZGXR3P2RPYPJ4WJ4HGHZ3QESF6/
Eugen Block requested the addition of this procedure to the
documentation on 30 Aug 2024.
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Milind Changire [Wed, 5 Jun 2024 15:36:08 +0000 (21:06 +0530)]
ptl-tool.py: replace regex strings with raw string literal
Signed-off-by: Milind Changire <mchangir@redhat.com>
Venky Shankar [Fri, 30 Aug 2024 05:33:26 +0000 (11:03 +0530)]
Merge PR #58547 into main
* refs/pull/58547/head:
qa: failfast mount for better performance
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Nizamudeen A [Fri, 30 Aug 2024 04:39:51 +0000 (10:09 +0530)]
Merge pull request #59510 from afreen23/main
mgr/dashboard: Fix banner and scroll issue
Reviewed-by: Nizamudeen A <nia@redhat.com>
Yingxin [Fri, 30 Aug 2024 02:38:59 +0000 (10:38 +0800)]
Merge pull request #59182 from zhscn/wip-4k-laddr
crimson/os/seastore: make laddr_t block aligned
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Samuel Just [Fri, 30 Aug 2024 00:34:46 +0000 (00:34 +0000)]
qa/tasks/ceph_manager: set-require-min-compat-client to squid for msr profiles
Signed-off-by: Samuel Just <sjust@redhat.com>
Ilya Dryomov [Thu, 29 Aug 2024 19:00:18 +0000 (21:00 +0200)]
Merge pull request #59507 from nbalacha/wip-nbalacha-rbd-manpage
doc/rbd: add namespace information for mirror commands
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Patrick Donnelly [Thu, 29 Aug 2024 17:40:41 +0000 (13:40 -0400)]
Merge PR #58950 into main
* refs/pull/58950/head:
mds: add the event when creating the batch head
mds: print the path depth to help debug mds issue
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Patrick Donnelly [Thu, 29 Aug 2024 17:39:56 +0000 (13:39 -0400)]
Merge PR #59310 into main
* refs/pull/59310/head:
qa: load all dirfrags before testing altname recovery
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Milind Changire <mchangir@redhat.com>
bugwz [Thu, 29 Aug 2024 14:50:07 +0000 (22:50 +0800)]
mgr/dashboard: alerts module supports setting multiple email recipients
Signed-off-by: bugwz <xbugwz@gmail.com>
N Balachandran [Thu, 29 Aug 2024 09:04:44 +0000 (14:34 +0530)]
doc/rbd: add namespace information for mirror commands
Updates the rbd man page to clarify that some mirror commands
can apply to pools and namespaces.
Signed-off-by: N Balachandran <nibalach@redhat.com>
Casey Bodley [Thu, 29 Aug 2024 13:21:44 +0000 (09:21 -0400)]
Merge pull request #59469 from smanjara/fix-multisite-script-default-realm
test-rgw-multisite: create default realm in multisite test script
Reviewed-by: Casey Bodley <cbodley@redhat.com>
rkhudov [Thu, 29 Aug 2024 13:09:33 +0000 (14:09 +0100)]
examples/rgw/boto3/README.md: update documentation for boto3 extension installation. Fixes: https://tracker.ceph.com/issues/67768
Signed-off-by: rkhudov <rhudov@gmail.com>
rkhudov [Thu, 29 Aug 2024 13:08:04 +0000 (14:08 +0100)]
src/test/rgw/bucket_notification/README.rst: use systemctl, update rabbitmq installation process. Fixes: https://tracker.ceph.com/issues/67768
Signed-off-by: rkhudov <rhudov@gmail.com>
rkhudov [Thu, 29 Aug 2024 10:46:39 +0000 (11:46 +0100)]
src/test/rgw/bucket_notification/README.rst: update RabbitMQ documentation. Fixes: https://tracker.ceph.com/issues/67768
Signed-off-by: rkhudov <rhudov@gmail.com>
Afreen Misbah [Thu, 29 Aug 2024 12:01:02 +0000 (17:31 +0530)]
mgr/dashboard: Fix banner and scroll issue
- includes fix to make banner visible again
- includes fix to allow scrolling on longer pages like, expand cluster and upgrade
Fixes https://tracker.ceph.com/issues/67795
Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
Adam King [Thu, 29 Aug 2024 11:11:24 +0000 (07:11 -0400)]
Merge pull request #59363 from adk3798/cephadm-mount-nvmeof-certs
cephadm: mount nvmeof certs into container
Reviewed-by: Alexander Indenbaum <aindenba@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
afreen23 [Thu, 29 Aug 2024 09:19:15 +0000 (14:49 +0530)]
Merge pull request #58778 from rhcs-dashboard/fix-67103-main
mgr/dashboard: Zone details showing incorrect data for data pool values and compression info for Storage Classes
Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
Matan Breizman [Thu, 29 Aug 2024 08:23:39 +0000 (11:23 +0300)]
Merge pull request #59495 from zhscn/fix-fmt-missing-arg
crimson/osd/pg: fix missing priority argument
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>