]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Matan Breizman [Tue, 10 Sep 2024 11:51:32 +0000 (11:51 +0000)]
crimson/osd/ops_executer: cleanup snap_map_*
Since https://github.com/ceph/ceph/pull/58868, snap map updates
are now maintained via PG::update_snap_map.
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Xuehan Xu [Sun, 8 Sep 2024 04:55:23 +0000 (12:55 +0800)]
crimson/osd/osd_operations/snaptrim_event: only increase
osd_osd_param_t::at_version after clone adjustments
Fixes: https://tracker.ceph.com/issues/67945
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Sun, 8 Sep 2024 04:31:28 +0000 (12:31 +0800)]
crimson/osd/osd_operations/snaptrim_event: we do SnapMapper updates in
ReplicatedBackend::submit_transaction(), drop all SnapMapper updates
before that
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Zac Dover [Tue, 10 Sep 2024 09:10:42 +0000 (19:10 +1000)]
Merge pull request #59675 from zdover23/wip-doc-2024-09-10-README-md-vstart
doc/README.md: improve formatting
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Matan Breizman [Tue, 10 Sep 2024 06:45:08 +0000 (09:45 +0300)]
Merge pull request #58986 from NitzanMordhai/wip-nitzan-crimson-op_gate-alianstore-multi-core
crimson: use gate per shard for AlienStore and OSD
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Matan Breizman [Tue, 10 Sep 2024 06:30:55 +0000 (09:30 +0300)]
Merge pull request #58868 from xxhdx1985126/wip-crimson-clean_region-based-clone-recovery
crimson/osd/pg: properly propagate snap mapper updates and do clean-region-based clone objects recovery
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Anthony D'Atri [Tue, 10 Sep 2024 03:47:00 +0000 (23:47 -0400)]
Merge pull request #59677 from zdover23/wip-doc-2024-09-10-man-ceph-bluestore-tool
doc/man: edit ceph-bluestore-tool.rst
Zac Dover [Mon, 9 Sep 2024 19:39:34 +0000 (05:39 +1000)]
doc/man: edit ceph-bluestore-tool.rst
Edit the section "bluefs-bdev-migrate" in
doc/man/8/ceph-bluestore-tool.rst to add the information that this
operation expands the target storage by updating its size label, making
"bluefs-bdev-expand" unnecessary.
Improve the subject-verb agreement in this section, and supply some
absent definite articles.
Co-authored-by: Peter Gervai <grin@drop.grin.hu>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Mon, 9 Sep 2024 18:02:38 +0000 (14:02 -0400)]
Merge pull request #58603 from cbodley/wip-rgw-sal-concrete-lc
rgw/sal: LCHead and LCEntry don't need abstraction
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Zac Dover [Mon, 9 Sep 2024 15:21:18 +0000 (01:21 +1000)]
doc/README.md: improve formatting
Improve the formatting of the section "Building Ceph" in the file
README.md.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Ivo Almeida [Mon, 9 Sep 2024 14:05:02 +0000 (15:05 +0100)]
Merge pull request #59297 from ivoalmeida/carbon-datatable-performance
mgr/dashboard: datatable performance improvement
Reviewed-by: Nizamudeen A <nia@redhat.com>
Adam King [Mon, 9 Sep 2024 13:30:47 +0000 (09:30 -0400)]
Merge pull request #58815 from synarete/samba-metrics-exporter
cephadm: samba metrics exporter
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Casey Bodley [Mon, 9 Sep 2024 12:51:48 +0000 (08:51 -0400)]
Merge pull request #59534 from cbodley/wip-rgw-listing-max-entries
rgw: raise default rgw_max_listing_results=5000
Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Casey Bodley [Mon, 9 Sep 2024 12:51:30 +0000 (08:51 -0400)]
Merge pull request #57635 from clwluvw/trans-id
rgw: log x-amz-request-id along with the request
Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Casey Bodley [Mon, 9 Sep 2024 12:51:09 +0000 (08:51 -0400)]
Merge pull request #58082 from jzhu116-bloomberg/wip-66516
rgw/multipart: use cls_version to avoid racing between part upload and multipart complete
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Casey Bodley [Mon, 9 Sep 2024 12:50:16 +0000 (08:50 -0400)]
Merge pull request #59014 from liangmingyuanneo/wip-bugfix-beast-socket-accept
rgw/beast: optimize for accept when meeting error in listenning
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Matan Breizman [Sun, 8 Sep 2024 13:49:23 +0000 (13:49 +0000)]
crimson/osd/ops_executer: pass MutFunc by value
Since we now co_await mut_func, we should not pass it by rvalue ref.
```
DEBUG 2024-09-01 15:54:46,212 [shard 0:main] osd - do_osd_ops_execute: object 2:
c4c92e5a :::rbd_trash:head submitting txn
=================================================================
==17416==ERROR: AddressSanitizer: stack-use-after-return on address 0x7f590008a430 at pc 0x0000040a367a bp 0x7ffc0b1d5ff0 sp 0x7ffc0b1d5fe0
Address 0x7f590008a430 is located in stack of thread T0 at offset 48 in frame
#0 0x40b0a2b in crimson::osd::PG::do_osd_ops_execute ... lambda(std::error_code const&)#1}&&)::{lambda()#1}::operator()() const (/usr/bin/ceph-osd+0x40b0a2b)
```
Co-authored-by: Xuehan Xu <xuxuehan@qianxin.com>
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Mon, 26 Aug 2024 10:10:35 +0000 (10:10 +0000)]
crimson/osd/ops_executer: avoid seastar::async comment
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Mon, 26 Aug 2024 10:18:08 +0000 (10:18 +0000)]
crimson/osd/osd_operations/snaptrim_event: make use of process_and_submit
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Mon, 26 Aug 2024 10:07:36 +0000 (10:07 +0000)]
crimson/osd/osd_operations/snaptrim_event: introduce process_and_submit
We should be carful with using capturing lambdas with coroutines.
Avoid capturing [this] by passing process_and_submit instead.
See: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rcoro-capture
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Wed, 21 Aug 2024 13:37:13 +0000 (13:37 +0000)]
crimson/osd/ops_executer: flush_changes_n_do_ops_effects to use
coroutines
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Tue, 20 Aug 2024 14:11:25 +0000 (14:11 +0000)]
crimson/osd/osd_operations/snaptrim_event: start to use coroutines
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Tue, 20 Aug 2024 13:08:35 +0000 (13:08 +0000)]
crimson/osd/pg: make use of SnapMapper::update_snap_map
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Ivo Almeida [Wed, 14 Aug 2024 15:19:05 +0000 (16:19 +0100)]
mgr/dashboard: datatable performance improvement
Fixes: https://tracker.ceph.com/issues/67796:
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
Ilya Dryomov [Mon, 9 Sep 2024 09:15:10 +0000 (11:15 +0200)]
Merge pull request #59657 from eriksjolund/fix-sign-of-errno
tools/rbd_ggate: fix sign of errno
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Mon, 9 Sep 2024 08:51:49 +0000 (10:51 +0200)]
Merge pull request #59000 from connorfawcett/rbd-random
rbd/bench: Add ability to write a random string of bytes or a specific byte with --pattern-byte option
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Yuval Lifshitz [Mon, 9 Sep 2024 08:37:20 +0000 (11:37 +0300)]
Merge pull request #59607 from yuvalif/wip-yuval-67658
rgw/notifications: free completion pointer using unique_ptr
Reviewed-By: Adam Emerson <aemerson@ibm.com>, Casey Bodley <cbodley@ibm.com>
Zac Dover [Mon, 9 Sep 2024 02:44:33 +0000 (12:44 +1000)]
Merge pull request #59642 from zdover23/wip-doc-2024-09-06-cephadm-upgrade
doc/cephadm: add malformed-JSON removal instructions
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Yingxin [Mon, 9 Sep 2024 02:10:22 +0000 (10:10 +0800)]
Merge pull request #59553 from cyx1231st/wip-seastore-more-reports3
crimson/os/seastore/cache: report cache access stats
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Zac Dover [Fri, 6 Sep 2024 13:31:21 +0000 (23:31 +1000)]
doc/cephadm: add malformed-JSON removal instructions
Add instructions for removing malformed JSON that causes the cephadm
module to fail to start, which in turn makes the orchestrator fail to
start.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Ronen Friedman [Sun, 8 Sep 2024 13:59:22 +0000 (16:59 +0300)]
Merge pull request #59590 from ronen-fr/wip-rf-delay-conf
osd/scrub: add configuration parameters to control delay duration
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Erik Sjölund [Sun, 8 Sep 2024 12:24:09 +0000 (14:24 +0200)]
tools/rbd_ggate: fix sign of errno
Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
Zac Dover [Sun, 8 Sep 2024 10:54:06 +0000 (20:54 +1000)]
Merge pull request #59628 from zdover23/wip-doc-2024-09-06-dev-release-checklist-rtd-activation
doc/dev: add "activate latest release" RTD step
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Neha Ojha <nojha@redhat.com>
Aviv Caro [Sun, 8 Sep 2024 07:23:59 +0000 (10:23 +0300)]
Merge pull request #59592 from leonidc/wip-leonidc0409-blocklist-fix
leonidc0409 blocklist fix
Ilya Dryomov [Sat, 7 Sep 2024 10:07:27 +0000 (12:07 +0200)]
Merge pull request #44640 from effi-ofer/live-migration-nbd
librbd/migration: add NBD stream
Reviewed-by: Mykola Golub <mgolub@suse.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
Venky Shankar [Fri, 6 Sep 2024 14:03:52 +0000 (19:33 +0530)]
Merge pull request #57388 from mchangir/mgr-snap_schedule-correctly-fetch-mds_max_snaps_per_dir-from-mds
mgr/snap_schedule: correctly fetch mds_max_snaps_per_dir from mds
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Aviv Caro [Fri, 6 Sep 2024 13:22:26 +0000 (16:22 +0300)]
Merge pull request #59579 from leonidc/wip-leonidc0309-gw-deleting-state
gw deleting state
Rishabh Dave [Fri, 6 Sep 2024 13:01:13 +0000 (18:31 +0530)]
Merge pull request #44359 from mchangir/mds-uninline-file-during-scrub
mds: un-inline data on scrub
Reviewed-by: Xiubo Li <xiubli@redhat.com>
Ilya Dryomov [Thu, 5 Sep 2024 13:43:07 +0000 (15:43 +0200)]
librbd/migration/NBDStream: abstract out libnbd and add unit tests
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Tue, 3 Sep 2024 15:03:55 +0000 (17:03 +0200)]
qa/suites/rbd: add snippets for migration import from NBD
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Mon, 2 Sep 2024 20:21:23 +0000 (22:21 +0200)]
librbd/migration/NBDStream: call nbd_shutdown() in close()
Avoid warnings like
qemu-nbd: Disconnect client, due to: Failed to read request:
Unexpected end-of-file before all bytes were read
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Mon, 2 Sep 2024 20:17:40 +0000 (22:17 +0200)]
librbd/migration/NBDStream: switch to NBD URIs
This removes the constraint on the transport being TCP, allowing to
use a Unix domain socket or other options. It also allows specifying
export names which a) are needed in case of serving different content
on different exports and b) some servers may require regardless.
Additionally, NBD URIs are future proof as all that NBDStream needs to
do is forward the string to libnbd.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Mon, 2 Sep 2024 20:14:27 +0000 (22:14 +0200)]
librbd/migration/NBDStream: check for nbd_get_size() errors
nbd_get_size() can fail with EOVERFLOW and possibly other errors.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Mon, 2 Sep 2024 20:11:29 +0000 (22:11 +0200)]
librbd/migration/NBDStream: introduce from_nbd_errno()
Errors returned by nbd_get_errno() can't be used to complete Contexts
directly because a) these errors are positive while complete() in most
cases expects a negative error and b) nbd_get_errno() can return 0 even
after libnbd call fails (i.e. returns -1).
Introduce a helper with EIO as a default/fallback error.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Sun, 25 Aug 2024 11:10:58 +0000 (13:10 +0200)]
librbd/migration/NBDStream: be more thorough around nbd_block_status()
nbd_block_status() is specified to be really loose: it can return
more status (go beyond the requested range), less status (cover only
some part of the requested range) or nothing at all. The former would
likely violate some assumptions in ObjectCopyRequest, while the latter
would lead to straight data corruption -- parent blocks that weren't
covered would never get copied up into the destination image.
On top of that, the current implementation is very suboptimal.
Because only "nr_entries == 2" responses are effectively processed,
any extent which has a small amount of data and is otherwise zeroed
(e.g. 8K of data in a 4M object) gets listed as DATA. A copyup for
such an object would write 4M worth of data instead of 8K, consuming
space in the destination image unnecessarily.
Also, it's unclear whether zero-sized entries can be returned.
Currently, if it happens we would hit an assert in interval_map.
This fixes all of these issues.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Effi Ofer [Tue, 18 Jan 2022 12:43:32 +0000 (14:43 +0200)]
librbd/migration: add nbd stream
Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Effi Ofer <effio@il.ibm.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Anthony D'Atri [Fri, 6 Sep 2024 11:49:13 +0000 (07:49 -0400)]
Merge pull request #59630 from zdover23/wip-doc-2024-09-06-README-md-build-prerequisites
doc/README.md: edit "Build Prerequisites"
Aashish Sharma [Fri, 6 Sep 2024 10:24:21 +0000 (15:54 +0530)]
Merge pull request #59575 from juan-ferrer-toribio/tracker-67849
mgr/dashboard: Fix variable capitalization in embedded rbd-details panel
Reviewed-by: Nizamudeen A <nia@redhat.com>
Connor Fawcett [Tue, 6 Aug 2024 17:29:56 +0000 (18:29 +0100)]
rbd/bench: Add ability to write a random string of bytes or a specific byte with --pattern-bytes option
Fixes: https://tracker.ceph.com/issues/67319
Signed-off-by: Connor Fawcett <connorfa@uk.ibm.com>
Zac Dover [Fri, 6 Sep 2024 07:56:27 +0000 (17:56 +1000)]
doc/README.md: edit "Build Prerequisites"
Make the sentences in the "Build Prerequisites" section of README.md
more direct.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Leonid Chernin [Wed, 4 Sep 2024 08:54:59 +0000 (08:54 +0000)]
mon/NVMeofGw*:
1. fix blocklist bug - blockist was not called
2. originally monitor only bloklisted specific ana groups but since we allow
the changing of ns ana grp on the fly for the sake of ns load balance,
it is not good enough and we need to blocklist all the cluster contexts
of the failing gateway
Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
Zac Dover [Thu, 5 Sep 2024 23:31:47 +0000 (09:31 +1000)]
doc/dev: add "activate latest release" RTD step
Add a step to the section called "First Stable Release" that explains
how to activate the latest release in Read the Docs.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Casey Bodley [Thu, 5 Sep 2024 17:21:47 +0000 (13:21 -0400)]
Merge pull request #56597 from liangmingyuanneo/optimize-reshard
rgw reshard: optimize reshard process to minimum blocking time
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Guillaume Abrioux [Thu, 5 Sep 2024 15:04:51 +0000 (17:04 +0200)]
Merge pull request #59170 from guits/remove-legacy-disk-sorting
ceph-volume: switch over to new disk sorting behavior
Guillaume Abrioux [Thu, 5 Sep 2024 15:00:04 +0000 (17:00 +0200)]
Merge pull request #59604 from guits/wip-osd-id-raw
ceph-volume: pass self.osd_id to create_id() call
Yuval Lifshitz [Tue, 27 Aug 2024 20:05:21 +0000 (20:05 +0000)]
rgw/notifications: free completion pointer using unique_ptr
also fix access to possible dpp dangling pointer
Fixes: https://tracker.ceph.com/issues/67658
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
Mark Kogan [Thu, 5 Sep 2024 14:23:30 +0000 (17:23 +0300)]
Merge pull request #59386 from mkogan1/wip-qlen_qactive
rgw: decrement qlen/qactive perf counters on error
Anthony D'Atri [Thu, 5 Sep 2024 13:54:59 +0000 (09:54 -0400)]
Merge pull request #59613 from zdover23/wip-doc-2024-09-05-rados-config-mon-lookup-dns
doc/rados: add link to messenger v2 info in mon-lookup-dns.rst
Patrick Donnelly [Thu, 5 Sep 2024 12:37:24 +0000 (08:37 -0400)]
Merge PR #59414 into main
* refs/pull/59414/head:
mds: move fscrypt_last_block to vector in mds_co mempool
mds: move fscrypt_file inode_t metadata to mds_co mempool
mds: move fscrypt_auth inode_t metadata to mds_co mempool
include/buffer: add helpers for uint8_t vectors
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Nitzan Mordechai [Wed, 28 Aug 2024 12:49:27 +0000 (12:49 +0000)]
crimson/common/gated: Comment out ceph_assert for shard ID check
After adding sid (shard ID) to Gated, each shard should have its own gate.
However, some users of Gated had a single instance, which either failed
these assertions or created the Gated object on the wrong shard.
A tracker issue #67773 was opened for this, and this commit comments out
the assertions until the issue is resolved.
Signed-off-by: NitzanMordhai <nmordech@redhat.com>
Nitzan Mordechai [Wed, 28 Aug 2024 09:08:26 +0000 (09:08 +0000)]
crimson/net/io_handler: ctor add gate ctor with shard id
IOHandler::to_new_sid provides a mechanism to switch to a new core from the current one used.
This behavior is tricky for making sure that we keep the IOHandler::shard_states_t::gate instance to be used on the same core that it was created.
In order to resolve this, we should be able to construct Gated out of specified core_id (and not from this_shard_id).
See: https://github.com/ceph/ceph/pull/58986#discussion_r1733782952
Signed-off-by: NitzanMordhai <nmordech@redhat.com>
Zac Dover [Thu, 5 Sep 2024 07:59:15 +0000 (17:59 +1000)]
doc/rados: add link to messenger v2 info in mon-lookup-dns.rst
Add a link to the page about Messenger v2 to the end of
doc/rados/configuration/mon-lookup-dns.rst.
Fixes: https://tracker.ceph.com/issues/58752
Signed-off-by: Zac Dover <zac.dover@proton.me>
Milind Changire [Fri, 10 May 2024 09:52:51 +0000 (15:22 +0530)]
qa: test fetching foreign config item
Signed-off-by: Milind Changire <mchangir@redhat.com>
Milind Changire [Fri, 10 May 2024 09:04:43 +0000 (14:34 +0530)]
mgr/snap_schedule: correctly fetch mds_max_snaps_per_dir from mds
Fixes: https://tracker.ceph.com/issues/65895
Signed-off-by: Milind Changire <mchangir@redhat.com>
Leonid Chernin [Sun, 1 Sep 2024 13:17:45 +0000 (13:17 +0000)]
mon/NVMeofGw*: Fix issue when ana group of deleted GW was not serviced.
Introduced GW Deleting state
Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
Yingxin [Thu, 5 Sep 2024 02:29:09 +0000 (10:29 +0800)]
Merge pull request #58438 from myoungwon/wip-batched-ool-writes
crimson/os/seastore/rbm: write merge-able ool extents at once
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Yingxin [Thu, 5 Sep 2024 02:28:32 +0000 (10:28 +0800)]
Merge pull request #59570 from zhscn/fix-node-capacity
crimson/os/seastore: cleanup lba/backref node capacity
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Laura Flores [Thu, 5 Sep 2024 01:03:28 +0000 (20:03 -0500)]
Merge pull request #59474 from athanatos/sjust/for-review/wip-67755-fix-msr-feature
osd: fix require_min_compat_client handling for msr rules
Yuval Lifshitz [Wed, 4 Sep 2024 14:13:17 +0000 (17:13 +0300)]
Merge pull request #59490 from Suyashd999/fix-mfr1
rgw/rgw_aio: forwarding reference passed to std::move()
Reviewed-By: Adam Emerson <aemerson@ibm.com>, Yuval Lifshitz <ylifshit@ibm.com>
Nizamudeen A [Wed, 4 Sep 2024 13:57:52 +0000 (19:27 +0530)]
Merge pull request #59530 from rhcs-dashboard/api_test_mgr_module_failure
qa/tests: fix test_list_enabled_modules timeout error
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Guillaume Abrioux [Wed, 4 Sep 2024 13:12:12 +0000 (15:12 +0200)]
ceph-volume: pass self.osd_id to create_id() call
This fixes a regression
(most likely introduced with
04c93a1ed42 )
Current (broken) behavior:
```
[root@devel1-1 /]# ceph osd tree
ID CLASS WEIGHT TYPE NAME STATUS REWEIGHT PRI-AFF
-1 0 root default
0 0 osd.0 destroyed 0 1.00000
[root@devel1-1 /]# ceph-volume raw prepare --bluestore --data /dev/vdb --osd-id 0
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring -i - osd new
543e0268 -ea66-451f-a2f6-
95ae60ab6146
Running command: /usr/bin/mount -t tmpfs tmpfs /var/lib/ceph/osd/ceph-1
Running command: /usr/sbin/restorecon /var/lib/ceph/osd/ceph-1
Running command: /usr/bin/chown -R ceph:ceph /dev/vdb
Running command: /usr/bin/ln -s /dev/vdb /var/lib/ceph/osd/ceph-1/block
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring mon getmap -o /var/lib/ceph/osd/ceph-1/activate.monmap
stderr: got monmap epoch 1
--> Creating keyring file for osd.1
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-1/keyring
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-1/
Running command: /usr/bin/ceph-osd --cluster ceph --osd-objectstore bluestore --mkfs -i 1 --monmap /var/lib/ceph/osd/ceph-1/activate.monmap --keyfile - --osd-data /var/lib/ceph/osd/ceph-1/ --osd-uuid
543e0268 -ea66-451f-a2f6-
95ae60ab6146 --setuser ceph --setgroup ceph
stderr: 2024-09-04T11:46:54.283+0000
7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-1//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T11:46:54.283+0000
7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-1//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T11:46:54.283+0000
7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-1//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T11:46:54.283+0000
7f0027d2b640 -1 bluestore(/var/lib/ceph/osd/ceph-1/) _read_fsid unparsable uuid
--> ceph-volume raw dmcrypt prepare successful for: /dev/vdb
[root@devel1-1 /]# ceph osd tree
ID CLASS WEIGHT TYPE NAME STATUS REWEIGHT PRI-AFF
-1 0 root default
0 0 osd.0 destroyed 0 1.00000
1 0 osd.1 down 1.00000 1.00000
```
A new osd id has been generated while we want to reuse the existing one (0 in this case).
Expected (fixed) behavior:
```
[root@devel1-1 /]# ceph osd tree
ID CLASS WEIGHT TYPE NAME STATUS REWEIGHT PRI-AFF
-1 0 root default
0 0 osd.0 destroyed 0 1.00000
[root@devel1-1 /]# ceph-volume raw prepare --bluestore --data /dev/vdb --osd-id 0
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph-authtool --gen-print-key
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring osd tree -f json
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring -i - osd new
c87841fb -f56f-40a2-a653-
62bb092e8e95 0
Running command: /usr/bin/mount -t tmpfs tmpfs /var/lib/ceph/osd/ceph-0
Running command: /usr/sbin/restorecon /var/lib/ceph/osd/ceph-0
Running command: /usr/bin/chown -R ceph:ceph /dev/vdb
Running command: /usr/bin/ln -s /dev/vdb /var/lib/ceph/osd/ceph-0/block
Running command: /usr/bin/ceph --cluster ceph --name client.bootstrap-osd --keyring /var/lib/ceph/bootstrap-osd/ceph.keyring mon getmap -o /var/lib/ceph/osd/ceph-0/activate.monmap
stderr: got monmap epoch 1
--> Creating keyring file for osd.0
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-0/keyring
Running command: /usr/bin/chown -R ceph:ceph /var/lib/ceph/osd/ceph-0/
Running command: /usr/bin/ceph-osd --cluster ceph --osd-objectstore bluestore --mkfs -i 0 --monmap /var/lib/ceph/osd/ceph-0/activate.monmap --keyfile - --osd-data /var/lib/ceph/osd/ceph-0/ --osd-uuid
c87841fb -f56f-40a2-a653-
62bb092e8e95 --setuser ceph --setgroup ceph
stderr: 2024-09-04T13:07:39.125+0000
7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-0//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T13:07:39.125+0000
7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-0//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T13:07:39.126+0000
7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0//block) _read_bdev_label unable to decode label /var/lib/ceph/osd/ceph-0//block at offset 102: void bluestore_bdev_label_t::decode(ceph::buffer::v15_2_0::list::const_iterator&) decode past end of struct encoding: Malformed input [buffer:3]
stderr: 2024-09-04T13:07:39.126+0000
7ff02baaa640 -1 bluestore(/var/lib/ceph/osd/ceph-0/) _read_fsid unparsable uuid
--> ceph-volume raw dmcrypt prepare successful for: /dev/vdb
[root@devel1-1 /]# ceph osd tree
ID CLASS WEIGHT TYPE NAME STATUS REWEIGHT PRI-AFF
-1 0 root default
0 0 osd.0 down 0 1.00000
```
Fixes: https://tracker.ceph.com/issues/67898
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
Ronen Friedman [Tue, 3 Sep 2024 09:25:36 +0000 (04:25 -0500)]
osd/scrub: implement existing 'interval' as a distinct delay reason
allowing setting specific delay times for scrubs that were aborted
due to the interval being changed. The specified delay should be
lower than the default delay used for the other types of
mid-scrub aborts.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Wed, 4 Sep 2024 09:11:55 +0000 (04:11 -0500)]
test/osd: fix 'recovery scrub' standalone test
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Mon, 2 Sep 2024 18:09:13 +0000 (13:09 -0500)]
osd/scrub: add 'snap-trimming' as a distinct delay reason
allowing the configuration of lower delay times (compared
to 'pg_state', now denoting PGs that are not active or
not clean) for PGs that failed to be scrubbed due to performing
snap-trimming.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Sun, 1 Sep 2024 11:25:08 +0000 (06:25 -0500)]
test/osd/scrub: set new scrub-related config options to test values
shortening the delay times following various scrub events.
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Ronen Friedman [Sun, 1 Sep 2024 07:07:47 +0000 (02:07 -0500)]
osd/scrub: add configuration parameters to control length of delay
to apply to a scrub target following a scrub failure
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
Guillaume Abrioux [Wed, 4 Sep 2024 11:21:03 +0000 (13:21 +0200)]
Merge pull request #59573 from guits/tracker-67873
ceph-volume: fix generic activation with raw osds
Ilya Dryomov [Wed, 4 Sep 2024 11:03:04 +0000 (13:03 +0200)]
Merge pull request #59551 from idryomov/wip-67845
librbd/migration: prune snapshot extents in RawFormat::list_snaps()
Reviewed-by: Ramana Raja <rraja@redhat.com>
Yuval Lifshitz [Wed, 4 Sep 2024 10:21:05 +0000 (13:21 +0300)]
Merge pull request #59562 from yuvalif/wip-yuval-67857
rgw/notifications: update release notes with fix to principalId
Reviewed-By: Casey Bodley <cbodley@ibm.com>
Matan Breizman [Tue, 20 Aug 2024 12:34:56 +0000 (12:34 +0000)]
osd/SnapMapper: introduce SnapMapper::update_snap_map
Moved from PG::update_snap_map to be used by Crimson as well
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
Xuehan Xu [Sun, 18 Aug 2024 04:43:32 +0000 (12:43 +0800)]
crimson/osd/osd_operations/snaptrim_event: encapsulate new snaps in the
pglog entry
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Samuel Just [Wed, 24 Jul 2024 05:10:58 +0000 (22:10 -0700)]
crimson/osd: update snaps based on log entries on primary and replica
Signed-off-by: Samuel Just <sjust@redhat.com>
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Samuel Just [Wed, 24 Jul 2024 04:56:39 +0000 (21:56 -0700)]
crimson/osd/pg: convert PG::handle_rep_op to coroutine
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Wed, 24 Jul 2024 04:37:29 +0000 (21:37 -0700)]
crimson/osd/pg: convert PG::handle_rep_op to logging macros
Signed-off-by: Samuel Just <sjust@redhat.com>
Samuel Just [Wed, 24 Jul 2024 04:35:23 +0000 (21:35 -0700)]
crimson/osd/pg: skip unnecessary stopping check in PG::handle_rep_op
The interruptible_future context should already ensure that branch
won't be taken.
Signed-off-by: Samuel Just <sjust@redhat.com>
Xuehan Xu [Thu, 25 Jul 2024 07:37:29 +0000 (15:37 +0800)]
crimson/osd/object_metadata_helper: take clone objects' clean regions
into account when recovering them
There are cases in which clone objects' omaps/xattrs are modified, we
want to avoid recover the data contents when recovering those clone
objects
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Xuehan Xu [Thu, 25 Jul 2024 07:36:56 +0000 (15:36 +0800)]
crimson/osd/ops_executer: set correct clean regions for CLONE pg log
entry
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
Matan Breizman [Wed, 4 Sep 2024 09:30:38 +0000 (12:30 +0300)]
Merge pull request #59102 from xxhdx1985126/wip-67450
crimson/osd/pg: fix wrong lambda capture of transactions in `PG::submit_error_log()`
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Nizamudeen A [Fri, 30 Aug 2024 11:46:57 +0000 (17:16 +0530)]
qa/tests: fix test_list_enabled_modules timeout error
This test deals with enabling/disabling the modules. The assumption I
have is after enabling the
module test will wait for an active mgr but its not able to find it in
time and it fails. so taking inspiration from https://github.com/ceph/ceph/pull/58995/commits/
6c7253be6f6fbfa6faed7a539cb78847fec04580 adding retries and logs to see if that's the case
Fixes: https://tracker.ceph.com/issues/62972
Signed-off-by: Nizamudeen A <nia@redhat.com>
Rishabh Dave [Wed, 4 Sep 2024 06:17:10 +0000 (11:47 +0530)]
Merge pull request #57896 from mchangir/ptl-tool.py-fix-escape-sequences
ptl-tool.py: replace regular strings with raw string literal for regular expressions
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Samuel Just [Wed, 4 Sep 2024 05:38:14 +0000 (22:38 -0700)]
Merge pull request #59588 from athanatos/sjust/wip-nvmeof-reenable
mon: enable nvmeof gw monitor
Reviewed-by: Alexander Indenbaum <aindenba@redhat.com>
Yuval Lifshitz [Wed, 4 Sep 2024 04:48:47 +0000 (07:48 +0300)]
Merge pull request #57878 from Suyashd999/fix-uam4
cls: avoid reusing moved-from buffers in cls_queue_src.cc
Yuval Lifshitz [Wed, 4 Sep 2024 04:47:28 +0000 (07:47 +0300)]
Merge pull request #59489 from Suyashd999/fix-sia1
rgw/cls_rgw: integer is being interpreted as a character code when assigning it to a string
Yuval Lifshitz [Wed, 4 Sep 2024 04:43:40 +0000 (07:43 +0300)]
Merge pull request #57854 from adamemerson/wip-66335
neorados: Fix use-after-move in Builder::build_
liangmingyuan [Sat, 24 Aug 2024 09:03:13 +0000 (17:03 +0800)]
cls/rgw: add a helper function for calls to cls_cxx_map_remove_key()
Add some testing cases and do cleanup too.
Signed-off-by: Mingyuan Liang <liangmingyuan@baidu.com>
Casey Bodley [Wed, 4 Sep 2024 00:43:34 +0000 (20:43 -0400)]
Merge pull request #59535 from cbodley/wip-qa-rgw-multisite-account-zone
qa/rgw/multisite: specify realm/zonegroup/zone args for 'account create'
Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
Anthony D'Atri [Tue, 3 Sep 2024 19:36:13 +0000 (15:36 -0400)]
Merge pull request #59577 from cityofships/main
doc/mds: improve wording
Matan Breizman [Tue, 3 Sep 2024 16:02:51 +0000 (19:02 +0300)]
Merge pull request #59185 from NitzanMordhai/wip-nitzan-crimson-help-args
crimson: early config checks and version
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Matan Breizman [Tue, 3 Sep 2024 15:55:30 +0000 (18:55 +0300)]
Merge pull request #59407 from xxhdx1985126/wip-67675
crimson/osd/pg: only mutate obc for user triggerred transactions
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Anthony D'Atri [Tue, 3 Sep 2024 15:44:33 +0000 (11:44 -0400)]
Merge pull request #59546 from anthonyeleven/improve-rados-operations-health-checks.rst
doc/rados/operations: Improve health-checks.rst