]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
9 months agocrimson/os/seastore/transaction_manager: refine logs 59692/head
Yingxin Cheng [Tue, 10 Sep 2024 03:55:05 +0000 (11:55 +0800)]
crimson/os/seastore/transaction_manager: refine logs

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore/transaction_manager: misc cleanups
Yingxin Cheng [Tue, 10 Sep 2024 03:52:56 +0000 (11:52 +0800)]
crimson/os/seastore/transaction_manager: misc cleanups

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore: workaround log linkage issue under clang14
Yingxin Cheng [Sun, 29 Sep 2024 05:47:17 +0000 (13:47 +0800)]
crimson/os/seastore: workaround log linkage issue under clang14

The logs printing lambda-captured variables cannot be linked correctly
with SeaStore::Shard::repeat_with_onode() under clang14.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore: refine logs of seastore.h/cc
Yingxin Cheng [Sun, 29 Sep 2024 03:47:46 +0000 (11:47 +0800)]
crimson/os/seastore: refine logs of seastore.h/cc

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore: adjust op names
Yingxin Cheng [Sun, 29 Sep 2024 03:14:14 +0000 (11:14 +0800)]
crimson/os/seastore: adjust op names

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore: convert length logs to the hex format
Yingxin Cheng [Tue, 10 Sep 2024 03:41:15 +0000 (11:41 +0800)]
crimson/os/seastore: convert length logs to the hex format

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agocrimson/os/seastore: misc cleanups
Yingxin Cheng [Fri, 6 Sep 2024 08:54:22 +0000 (16:54 +0800)]
crimson/os/seastore: misc cleanups

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
9 months agoMerge pull request #60162 from zdover23/wip-doc-2024-10-07-governance-reset
Zac Dover [Mon, 7 Oct 2024 23:55:13 +0000 (09:55 +1000)]
Merge pull request #60162 from zdover23/wip-doc-2024-10-07-governance-reset

doc/governance: revert d7c144c0d7e490bfda9715a0c8462bb67cffc764

Reviewed-by: Patrick Donnelly <pdonnelly@redhat.com>
9 months agoMerge pull request #60109 from idryomov/wip-63184
Ilya Dryomov [Mon, 7 Oct 2024 18:15:54 +0000 (20:15 +0200)]
Merge pull request #60109 from idryomov/wip-63184

librbd/crypto/LoadRequest: clone format for migration source image

Reviewed-by: Sunil Angadi <Sunil.Angadi@ibm.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>
9 months agoMerge pull request #57582 from sajibreadd/wip-66059
Md Mahamudur Rahaman Sajib [Mon, 7 Oct 2024 18:07:40 +0000 (20:07 +0200)]
Merge pull request #57582 from sajibreadd/wip-66059

OSD: PG stat is not synchronized between osds after deep-scrub

9 months agoMerge pull request #59857 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence
Jon Bailey [Mon, 7 Oct 2024 14:48:06 +0000 (15:48 +0100)]
Merge pull request #59857 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence

src/test/osd: create ceph_test_rados_io_sequence testing tool

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
9 months agoMerge pull request #60146 from spuiuk/smb_version
Zac Dover [Mon, 7 Oct 2024 14:34:01 +0000 (00:34 +1000)]
Merge pull request #60146 from spuiuk/smb_version

doc: remove note for smb3 support

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
9 months agoMerge pull request #60001 from cbodley/wip-65654-debug
Casey Bodley [Mon, 7 Oct 2024 13:12:05 +0000 (09:12 -0400)]
Merge pull request #60001 from cbodley/wip-65654-debug

qa/rgw: add debug log to help diagnose 'bucket check unlinked' failure

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
9 months agoMerge pull request #60020 from soumyakoduri/wip-skoduri-lc-process
Casey Bodley [Mon, 7 Oct 2024 13:11:36 +0000 (09:11 -0400)]
Merge pull request #60020 from soumyakoduri/wip-skoduri-lc-process

rgw/lc: Fix a bug in LCOpAction_Transition::check()

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
9 months agoMerge pull request #59884 from cbodley/wip-51786
Casey Bodley [Mon, 7 Oct 2024 13:10:41 +0000 (09:10 -0400)]
Merge pull request #59884 from cbodley/wip-51786

cls/user: reset stats only returns marker when truncated

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
9 months agoMerge pull request #59983 from tobias-urdin/rgw-presigned-500
Casey Bodley [Mon, 7 Oct 2024 13:10:03 +0000 (09:10 -0400)]
Merge pull request #59983 from tobias-urdin/rgw-presigned-500

rgw/auth: fix internal server error for presigned urls

Reviewed-by: Casey Bodley <cbodley@redhat.com>
9 months agodoc/governance: revert d7c144c0d7e490bfda9715a0c8462bb67cffc764 60162/head
Zac Dover [Mon, 7 Oct 2024 12:50:44 +0000 (22:50 +1000)]
doc/governance: revert d7c144c0d7e490bfda9715a0c8462bb67cffc764

Revert the commit (manually, by restoring the file by hand to the state
it was in prior to d7c144c) to the state that it was in before I added
the Executive Council Responsibilities document to governance.rst. This
document cannot be edited at will, but must be voted on by the
Leadership Team.

Signed-off-by: Zac Dover <zac.dover@proton.me>
9 months agoMerge pull request #60113 from rhcs-dashboard/fix-68384-main
Aashish Sharma [Mon, 7 Oct 2024 12:41:25 +0000 (18:11 +0530)]
Merge pull request #60113 from rhcs-dashboard/fix-68384-main

mgr/dashboard: increase timeout to detect replication user in the secondary cluster

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agoMerge pull request #60114 from rhcs-dashboard/fix-68386-main
Aashish Sharma [Mon, 7 Oct 2024 12:33:21 +0000 (18:03 +0530)]
Merge pull request #60114 from rhcs-dashboard/fix-68386-main

mgr/dashboard: Enable refresh button on Manage Clusters - Clusters List table

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agoMerge pull request #58701 from jecluis/wip-makedist-fix
kyr [Mon, 7 Oct 2024 09:49:39 +0000 (11:49 +0200)]
Merge pull request #58701 from jecluis/wip-makedist-fix

make-dist: replace all '-' for '.' for rpm release

9 months agoMerge pull request #60049 from rhcs-dashboard/fix-68307-main
afreen23 [Mon, 7 Oct 2024 07:41:39 +0000 (13:11 +0530)]
Merge pull request #60049 from rhcs-dashboard/fix-68307-main

mgr/dashboard: Do not display restart gateway message on completion of Setup Multisite Replication wizard

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agoMerge PR #58966 into main
Venky Shankar [Mon, 7 Oct 2024 07:18:52 +0000 (12:48 +0530)]
Merge PR #58966 into main

* refs/pull/58966/head:
qa: test 'ceph fs snapshot mirror ls' command
doc: update docs for 'fs snapshot mirror ls' command
cephfs_mirror: ceph fs snapshot mirror ls command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
9 months agoMerge PR #59699 into main
Venky Shankar [Mon, 7 Oct 2024 07:17:15 +0000 (12:47 +0530)]
Merge PR #59699 into main

* refs/pull/59699/head:
mgr/status: Fix 'fs status' json output
qa: Add test for 'fs status' in standby-replay mds setup

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
9 months agoMerge pull request #56118 from joscollin/wip-B64711-qa-failure_cancel-mirroring-and...
Venky Shankar [Mon, 7 Oct 2024 07:08:40 +0000 (12:38 +0530)]
Merge pull request #56118 from joscollin/wip-B64711-qa-failure_cancel-mirroring-and-readd

cephfs_mirror, qa: fix test failure test_cephfs_mirror_cancel_mirroring_and_readd

Reviewed-by: Venky Shankar <vshankar@redhat.com>
9 months agoMerge pull request #59870 from rhcs-dashboard/ignore-exception-nvmf
Nizamudeen A [Mon, 7 Oct 2024 06:47:15 +0000 (12:17 +0530)]
Merge pull request #59870 from rhcs-dashboard/ignore-exception-nvmf

mgr/dashboard: ignore exceptions raised when no cert/key found

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
9 months agomgr/dashboard: Enable refresh button on Manage Clusters - Clusters List table 60114/head
Aashish Sharma [Fri, 4 Oct 2024 11:32:55 +0000 (17:02 +0530)]
mgr/dashboard: Enable refresh button on Manage Clusters - Clusters List table

Add fetchData() to the clusters list table to refresh the data and
enable refresh button in the table for the same.

Fixes: https://tracker.ceph.com/issues/68386
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
9 months agomgr/dashboard: increase timeout to detect replication user in the secondary cluster 60113/head
Aashish Sharma [Fri, 4 Oct 2024 10:54:02 +0000 (16:24 +0530)]
mgr/dashboard: increase timeout to detect replication user in the secondary cluster

Increase timeout to detect replication user in the secondary cluster in rgw multisite automation wizard. Currently its set to 2 mins, increase it to 5 minutes.
when you import realm token to the secondary cluster, we wait for the replication/system user we created in the primary cluster to be present in the secondary cluster and when we find that user we set the credentials in the secondary cluster using ceph dashboard set-rgw-crdentials . The timeout for this is set to 2 minutes and sometimes it takes more than 2 minutes for the user to be replicated in the secondary cluster

Fixes: https://tracker.ceph.com/issues/68384
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
9 months agodoc: remove note for smb3 support 60146/head
Sachin Prabhu [Sun, 6 Oct 2024 21:37:47 +0000 (22:37 +0100)]
doc: remove note for smb3 support

We support SMB2, SMB2.1 and SMB 3 at the moment. We are not limited to
just SMB3 as noted in the documentation.

Signed-off-by: Sachin Prabhu <sp@spui.uk>
9 months agoMerge pull request #60115 from zdover23/wip-doc-2024-10-04-governance
Zac Dover [Sun, 6 Oct 2024 10:35:53 +0000 (20:35 +1000)]
Merge pull request #60115 from zdover23/wip-doc-2024-10-04-governance

doc/governance: add exec council responsibilites

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
9 months agoMerge pull request #59868 from dmick/wip-container
Dan Mick [Sat, 5 Oct 2024 01:40:04 +0000 (18:40 -0700)]
Merge pull request #59868 from dmick/wip-container

Add Containerfile and build.sh to build it.

9 months agoMerge pull request #60019 from sungjoon-koh/fix-get-part-number
Casey Bodley [Fri, 4 Oct 2024 21:20:16 +0000 (17:20 -0400)]
Merge pull request #60019 from sungjoon-koh/fix-get-part-number

rgw: decrypt multipart get part when encrypted

Reviewed-by: Casey Bodley <cbodley@redhat.com>
9 months agoMerge pull request #59977 from tobias-urdin/rgw-cors-v2-auth
Casey Bodley [Fri, 4 Oct 2024 20:26:31 +0000 (16:26 -0400)]
Merge pull request #59977 from tobias-urdin/rgw-cors-v2-auth

rgw: handle http options CORS with v2 auth

Reviewed-by: Casey Bodley <cbodley@redhat.com>
9 months agoMerge pull request #59770 from cbodley/wip-qa-unpin-tox
Casey Bodley [Fri, 4 Oct 2024 18:04:18 +0000 (14:04 -0400)]
Merge pull request #59770 from cbodley/wip-qa-unpin-tox

qa/tasks/tox: unpin tox version

Reviewed-by: Adam Emerson <aemerson@redhat.com>
9 months agoMerge pull request #60066 from ceph/wip-openssf-main
Ernesto Puerta [Fri, 4 Oct 2024 17:35:00 +0000 (18:35 +0100)]
Merge pull request #60066 from ceph/wip-openssf-main

README: add OpenSSF Best Practices Badge

9 months agoMerge pull request #60116 from zdover23/wip-doc-2024-10-04-governance-zdover-email
Anthony D'Atri [Fri, 4 Oct 2024 15:11:28 +0000 (11:11 -0400)]
Merge pull request #60116 from zdover23/wip-doc-2024-10-04-governance-zdover-email

doc/governance: add Zac Dover's updated email

9 months agoMerge pull request #59927 from rkachach/fix_issue_mgmt_gw_health_endpoint
Adam King [Fri, 4 Oct 2024 13:57:07 +0000 (09:57 -0400)]
Merge pull request #59927 from rkachach/fix_issue_mgmt_gw_health_endpoint

mgr/cephadm: adding health check endpoint for mgmt-gateway

Reviewed-by: Adam King <adking@redhat.com>
9 months agodoc/governance: add Zac Dover's updated email 60116/head
Zac Dover [Fri, 4 Oct 2024 13:25:30 +0000 (23:25 +1000)]
doc/governance: add Zac Dover's updated email

Update Zac Dover's email address.

Signed-off-by: Zac Dover <zac.dover@proton.me>
9 months agodoc/governance: add exec council responsibilites 60115/head
Zac Dover [Fri, 4 Oct 2024 13:21:32 +0000 (23:21 +1000)]
doc/governance: add exec council responsibilites

Add the Ceph Executive Council's responsibilties to the
doc/governance.rst document. It was decided during the weekly CLT
meeting on 30 Sep 2024 to add this to the ceph/ceph git repository.

Signed-off-by: Zac Dover <zac.dover@proton.me>
9 months agoMerge pull request #59580 from smanjara/rgw-data-sync-redundant-retries
Casey Bodley [Fri, 4 Oct 2024 13:09:58 +0000 (09:09 -0400)]
Merge pull request #59580 from smanjara/rgw-data-sync-redundant-retries

rgw/multisite: avoid redundant error repo entry logging

Reviewed-by: Adam Emerson <aemerson@redhat.com>
9 months agoMerge pull request #60095 from adamemerson/wip-40692
Casey Bodley [Fri, 4 Oct 2024 12:58:12 +0000 (08:58 -0400)]
Merge pull request #60095 from adamemerson/wip-40692

global: Call getnam_r with a 64KiB buffer on the heap

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
9 months agoMerge pull request #60044 from avanthakkar/fix-smb-earmark-split
Adam King [Fri, 4 Oct 2024 12:50:20 +0000 (08:50 -0400)]
Merge pull request #60044 from avanthakkar/fix-smb-earmark-split

mgr/smb: fix condition for smb earmark when cluster_id doesn't match

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
9 months agomgr/dashboard: Donot display restart gateway message on completion of 60049/head
Aashish Sharma [Mon, 30 Sep 2024 05:40:32 +0000 (11:10 +0530)]
mgr/dashboard: Donot display restart gateway message on completion of
Setup Multisite Replication wizard

On completion of multi-site replication wizard, stop showing message to
restart the rgw services

Fixes: https://tracker.ceph.com/issues/68307
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
9 months agoMerge pull request #60083 from phlogistonjohn/jjm-issue68322
Adam King [Thu, 3 Oct 2024 20:15:14 +0000 (16:15 -0400)]
Merge pull request #60083 from phlogistonjohn/jjm-issue68322

cephadm: use a shared smb.conf for clustered smb container sets

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Sachin Prabhu <sp@spui.uk>
9 months agoglobal: Call getnam_r with a 64KiB buffer on the heap 60095/head
Adam Emerson [Wed, 2 Oct 2024 18:42:52 +0000 (14:42 -0400)]
global: Call getnam_r with a 64KiB buffer on the heap

Fixes: https://tracker.ceph.com/issues/40692
Signed-off-by: Adam Emerson <aemerson@redhat.com>
9 months agoMerge pull request #59311 from soumyakoduri/wip-skoduri-cloud-restore
Soumya Koduri [Thu, 3 Oct 2024 18:14:11 +0000 (23:44 +0530)]
Merge pull request #59311 from soumyakoduri/wip-skoduri-cloud-restore

rgw/cloudtier: initial MVP of the feature RestoreObject from cloud

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
9 months agomgr/smb: fix condition for smb earmark when cluster_id doesn't match 60044/head
Avan Thakkar [Sun, 29 Sep 2024 14:38:59 +0000 (20:08 +0530)]
mgr/smb: fix condition for smb earmark when cluster_id doesn't match

This commit resolves an issue where accessing `earmark.split('.')[2]` would cause a
"list index out of range" error when the earmark is set to just "smb" without additional scopes.
The fix introduces a parsing function to safely handle earmarks, ensuring proper behavior
even when no cluster ID or additional scopes are present.

Fixes: https://tracker.ceph.com/issues/68342
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
9 months agolibrbd/crypto/LoadRequest: clone format for migration source image 60109/head
Ilya Dryomov [Thu, 3 Oct 2024 15:54:07 +0000 (17:54 +0200)]
librbd/crypto/LoadRequest: clone format for migration source image

Migration source and migration target images naturally have the same
encryption format, but the user shouldn't have to need to specify it
for the image that they can't even immediately see -- migration source
image gets moved to the RBD trash to avoid mistaken usage while
migration is in progress.

Fixes: https://tracker.ceph.com/issues/63184
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
9 months agolibrbd/crypto/LoadRequest: rename m_is_current_format_cloned
Ilya Dryomov [Mon, 16 Sep 2024 09:37:49 +0000 (11:37 +0200)]
librbd/crypto/LoadRequest: rename m_is_current_format_cloned

Formats must also be cloned if the image is under migration, so
rename m_is_current_format_cloned to m_is_current_format_assumed to
avoid potential confusion with clone() being called in two places but
m_is_current_format_cloned being set in only one place.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
9 months agoMerge pull request #59513 from cbodley/wip-isal-ext
Casey Bodley [Thu, 3 Oct 2024 15:31:29 +0000 (11:31 -0400)]
Merge pull request #59513 from cbodley/wip-isal-ext

cmake: use ExternalProjects to build isa-l and isa-l_crypto libraries

Reviewed-by: Jamie Pryde <jamiepry@uk.ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Mark Kogan <mkogan@ibm.com>
9 months agoMerge pull request #59479 from YiteGu/optimize-stop-discard-thread-while-close-dev
Igor Fedotov [Thu, 3 Oct 2024 15:27:48 +0000 (18:27 +0300)]
Merge pull request #59479 from YiteGu/optimize-stop-discard-thread-while-close-dev

blk/KernelDevice: using join() to wait thread end is more safe

9 months agocephadm: use a shared smb.conf for clustered smb container sets 60083/head
John Mulligan [Tue, 1 Oct 2024 15:27:44 +0000 (11:27 -0400)]
cephadm: use a shared smb.conf for clustered smb container sets

Use a shared smb.conf when deploying ctdb enabled containers. There was
a problem updating configs on the ctdb enabled clusters and the issue
was that the configwatch sidecar was not using CTDB, rather it had a
"default" copy of smb.conf that enabled only registry config, but not
CTDB. Examining the cluster this problem was found to be general to all
sidecars that are either sambacc based (not starting smbd, winbindd,
etc) and the smbmetrics sidecar.

Fixes: https://tracker.ceph.com/issues/68322
Signed-off-by: John Mulligan <jmulligan@redhat.com>
9 months agoMerge pull request #60022 from ShwetaBhosale1/add-email
Adam King [Thu, 3 Oct 2024 11:56:53 +0000 (07:56 -0400)]
Merge pull request #60022 from ShwetaBhosale1/add-email

mailmap, githubmap, organisationmap: Add Shweta

Reviewed-by: Laura Flores <lflores@ibm.com>
9 months agoMerge pull request #58293 from Suyashd999/fix-uam9
SrinivasaBharathKanta [Thu, 3 Oct 2024 09:45:47 +0000 (15:15 +0530)]
Merge pull request #58293 from Suyashd999/fix-uam9

ceph_osd: false use-after-move on store

9 months agoMerge pull request #60072 from rhcs-dashboard/delete-popover
afreen23 [Thu, 3 Oct 2024 09:30:17 +0000 (15:00 +0530)]
Merge pull request #60072 from rhcs-dashboard/delete-popover

mgr/dashboard: Unable to delete realm via dashboard

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agoRGW: Cloud Restore cli and its corresponding response for user. 59311/head
shreyanshjain7174 [Mon, 5 Aug 2024 07:44:52 +0000 (02:44 -0500)]
RGW: Cloud Restore cli and its corresponding response for user.

* For first and repititive request 202 Accepted will be corresponding response code.
* For CloudRestored status 200 OK will be corresponding response code.
* For conflicting requests 409 Conflict corresponding response code.

Also Fixed storage class update while listing objects.

Earlier while restoring object temporarily list-objects (s3api) and
radosgw-admin bucket list didn't have updated storage class. With this
fixed it now has the cloudtier storage class.

Signed-off-by: shreyanshjain7174 <ssanchet@redhat.com>
9 months agocloud restore: completing read through
Jiffin Tony Thottan [Fri, 21 Jun 2024 09:12:07 +0000 (14:42 +0530)]
cloud restore: completing read through

What are all supported :

* It allows read-through for cloud-tiered objects via restore_obj_from_cloud
* New tier config options user need to set allow_read_through to true and
  read_through_restore_days more than 1 for this feature to work, also
  objects with retain_head_object will be available for this feature.
* First get request will fail with restoring in progress error, objects
  are downloaded asynchronously.
* The objects restore are temporary.
* Tested `aws s3api get-object`, `aws s3api head-object` and `aws s3 cp`

In addition send timeout errors for first readthrough request

Also addressed lint warning and other cleanup(review comments)

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
9 months agorgw/cloudtier: Restore object from cloud endpoint
Soumya Koduri [Thu, 3 Oct 2024 02:33:20 +0000 (08:03 +0530)]
rgw/cloudtier: Restore object from cloud endpoint

1)Add functionality to restore cloud-transitioned objects on demand.

Current commit has below -
* Given <bucket,object>, fetch the object from the cloud endpoint.
* if days provided and > 0, the restore is marked temporary with expiry date.
* Without <days>, it is marked as permanent restore.

2)Use ObjectExpirer/delete_at attr to delete temp objects

For temporarily restored objects, set delete_at attr to the expiration time.
This will add those objects to ObjectExpirer list. Use LC worker thread to
scan that list and delete expired objects. By delete here, it means to delete
restored object data and reset HEAD object as Cloud-transitioned object as it
was before restore.

In addition below changes are done -
* If temporary, object is still marked RGWObj::CloudTiered and mtime is set same as
transition time.
* If permanent, object is marked RGWObj::Main and mtime is set to restore time (now()).
* rgw_restore_debug_interval option added to set configure restore Days (similar to rgw_lc_debug_interval)

There is an issue with ObjectExpirer code where in if an object is added
to ObjectExpirer list and is re-written, it is not deleted from the expirer list
and hence the new object may get deleted. Fixed the same and also addressed
minor review comments.

3)Design doc added

4) ObjCategory should be set to CloudTiered only for cloud-transitioned
objects and temporarily restored objects. Permanent copies are to be
treated as regular objects.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
9 months agoAdd Containerfile and build.sh to build it. 59868/head
Dan Mick [Wed, 26 Jun 2024 02:07:41 +0000 (19:07 -0700)]
Add Containerfile and build.sh to build it.

The intent is to replace ceph-container.git, at first for ci containers
only, and eventually production containers as well.

There is code present for production containers, including
a separate "make-manifest-list.py" to scan for and glue the two
arch-specific containers into a 'manifest-list' 'fat' container,
but that code is not yet fully tested.

This code will not be used until a corresponding change to the
Jenkins jobs in ceph-build.git is pushed.

Note that this tooling does not authenticate to the container repo;
it is assumed that will be done elsewhere.  Authentication is
verified by pushing a minimal image to the requested repo.

Signed-off-by: Dan Mick <dmick@redhat.com>
9 months agoMerge pull request #60069 from leonidc/fix-corruption-upon-add-gw
leonidc [Wed, 2 Oct 2024 07:30:42 +0000 (10:30 +0300)]
Merge pull request #60069 from leonidc/fix-corruption-upon-add-gw

 mon/nvmeofgw*:fix monitor database corruption upon add gw

9 months agoMerge pull request #60005 from idryomov/wip-68213
Ilya Dryomov [Wed, 2 Oct 2024 05:50:27 +0000 (07:50 +0200)]
Merge pull request #60005 from idryomov/wip-68213

qa/suites/rbd/iscsi: enable all supported container hosts

Reviewed-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
9 months agomailmap, githubmap, organisationmap: Add Shweta Bhosale 60022/head
Shweta Bhosale [Fri, 27 Sep 2024 09:29:16 +0000 (14:59 +0530)]
mailmap, githubmap, organisationmap: Add Shweta Bhosale

Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
9 months agoMerge pull request #59745 from cbodley/wip-qa-rgw-multifs-combined
Casey Bodley [Tue, 1 Oct 2024 20:46:15 +0000 (16:46 -0400)]
Merge pull request #59745 from cbodley/wip-qa-rgw-multifs-combined

qa/rgw/multifs: add tasks/+ to concatenate tasks into same job

Reviewed-by: Adam Emerson <aemerson@redhat.com>
9 months agoqa/tasks/tox: unpin tox version 59770/head
Casey Bodley [Wed, 11 Sep 2024 22:17:09 +0000 (18:17 -0400)]
qa/tasks/tox: unpin tox version

Signed-off-by: Casey Bodley <cbodley@redhat.com>
9 months agoMerge pull request #56980 from sajibreadd/device-class-mask-65228
Yuri Weinstein [Tue, 1 Oct 2024 15:04:04 +0000 (08:04 -0700)]
Merge pull request #56980 from sajibreadd/device-class-mask-65228

osd: class:device-class config database mask does not work for osd_compact_on_start

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
9 months agoMerge pull request #55334 from trociny/wip-rados-setomapheader
Yuri Weinstein [Tue, 1 Oct 2024 15:00:33 +0000 (08:00 -0700)]
Merge pull request #55334 from trociny/wip-rados-setomapheader

tools/rados: allow to read setomapheader value from file

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
9 months agoMerge pull request #59978 from afreen23/nvme-gateway-fix
afreen23 [Tue, 1 Oct 2024 14:27:34 +0000 (19:57 +0530)]
Merge pull request #59978 from afreen23/nvme-gateway-fix

mgr/dashboard: Fix adding listener and null issue for groups

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agoMerge pull request #60015 from Kushal-deb/kushaldeb-add-email-contact
Adam King [Tue, 1 Oct 2024 12:53:38 +0000 (08:53 -0400)]
Merge pull request #60015 from Kushal-deb/kushaldeb-add-email-contact

mailmap, githubmap, organisationmap: Add Kushal

Reviewed-by: Laura Flores <lflores@ibm.com>
9 months agomgr/dashboard: Unable to delete realm via dashboard 60072/head
Dnyaneshwari [Tue, 1 Oct 2024 11:48:13 +0000 (17:18 +0530)]
mgr/dashboard: Unable to delete realm via dashboard

Replacing Bootstrap Modal Service (ModalService) with Carbon Modal Service (ModalCdsService)

Fixes: https://tracker.ceph.com/issues/68290
Signed-off-by: Dnyaneshwari talwekar <dtalweka@redhat.com>
9 months agoMerge pull request #59159 from rhcs-dashboard/rbd-table
Pedro Gonzalez Gomez [Tue, 1 Oct 2024 09:11:25 +0000 (11:11 +0200)]
Merge pull request #59159 from rhcs-dashboard/rbd-table

mgr/dashboard: rbd table actions enhancements

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
9 months agomgr/dashboard: Allow adding all listeners unders a subsystems 59978/head
Afreen Misbah [Wed, 25 Sep 2024 11:15:10 +0000 (16:45 +0530)]
mgr/dashboard: Allow adding all listeners unders a subsystems

Issue:

- Currently a user cannot add all listeners under a subsystem
- This results into an error: `Failure adding nqn.2001-07.com.ceph:1725013182540 listener at 10.70.44.140:4420: Gateway's host name must match current host (dhcp47-54)`

Reason:

- The gateway address used while creating listener is random now in nvmeof client
- After checking the gateway logs of each node, its is found that no grpc request recieved for adding listener on the respective node rather going to the node that is chosen by default in nvmeof client.
- But nvmeof backend check that current gateway matches the one with sent in request for adding listener (ref: https://github.com/ceph/ceph-nvmeof/blob/devel/control/grpc.py#L2104)

Fix:

- Using `traddr` from listener API to set the current gateway address
- Since `traddr` gives only IP address, without port therefore extracting full address from `NvmeofGatewaysConfig.get_gateways_config()`
- This ensures correct path usage

Fixes https://tracker.ceph.com/issues/68229
Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agoMerge pull request #60006 from guits/tracker_64353
Guillaume Abrioux [Tue, 1 Oct 2024 07:37:13 +0000 (09:37 +0200)]
Merge pull request #60006 from guits/tracker_64353

ceph-volume: add new class UdevData

9 months ago mon/nvmeofgw*:fix monitor database corruption upon add gw 60069/head
Leonid Chernin [Mon, 30 Sep 2024 16:43:38 +0000 (16:43 +0000)]
 mon/nvmeofgw*:fix monitor database corruption upon add gw

Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
9 months agoMerge pull request #59875 from joscollin/wip-B68131-revert-sync-duration
Venky Shankar [Tue, 1 Oct 2024 04:08:40 +0000 (09:38 +0530)]
Merge pull request #59875 from joscollin/wip-B68131-revert-sync-duration

cephfs_mirror: revert sync_duration to seconds

Reviewed-by: Venky Shankar <vshankar@redhat.com>
9 months agorgw: decrypt multipart get part when encrypted 60019/head
sungjoon-koh [Fri, 27 Sep 2024 07:31:26 +0000 (16:31 +0900)]
rgw: decrypt multipart get part when encrypted

Copy crypt related attrs for get object with partNumber

Signed-off-by: sungjoon-koh <sungjoon_koh@linecorp.com>
9 months agoMerge pull request #52636 from baergj/subsecond-history-slow-op-upstream
Laura Flores [Mon, 30 Sep 2024 21:29:38 +0000 (16:29 -0500)]
Merge pull request #52636 from baergj/subsecond-history-slow-op-upstream

TrackedOp: Make history_slow_op_threshold a float

9 months agoMerge pull request #58749 from rzarzynski/wip-bug-67087
Laura Flores [Mon, 30 Sep 2024 21:29:16 +0000 (16:29 -0500)]
Merge pull request #58749 from rzarzynski/wip-bug-67087

osd: fix partial reading during multi-region EC reads

9 months agoREADME: add OpenSSF Best Practices Badge 60066/head
Ernesto Puerta [Mon, 30 Sep 2024 20:06:17 +0000 (22:06 +0200)]
README: add OpenSSF Best Practices Badge

This effort was started long time ago by Mike Perez.[1] I now completed the remaining steps to achieve the Passing level of the OpenSSF Best Practices Badge.[2]

It should be used as an opportunity to implement best practices in the Ceph community. For example, the Passing level was achieved without meeting the optional compliance with Dynamic Analysis or Security Scanning.

[1] https://www.bestpractices.dev/en/projects/2220
[2] https://www.bestpractices.dev/en/criteria/0

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>
9 months agoMerge pull request #59998 from cbodley/wip-63935
Casey Bodley [Mon, 30 Sep 2024 18:03:53 +0000 (14:03 -0400)]
Merge pull request #59998 from cbodley/wip-63935

rgw/rados: don't rely on IoCtx::get_last_version() for async ops

Reviewed-by: Adam Emerson <aemerson@redhat.com>
9 months agoMerge pull request #59815 from athanatos/sjust/wip-68068
Samuel Just [Mon, 30 Sep 2024 17:21:51 +0000 (10:21 -0700)]
Merge pull request #59815 from athanatos/sjust/wip-68068

crimson: don't retain InternalClientRequest on interval change even if primary does not change

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
9 months agomgr/dashboard: Fix `null` gateway group
Afreen Misbah [Tue, 24 Sep 2024 11:13:41 +0000 (16:43 +0530)]
mgr/dashboard: Fix `null` gateway group

- when no group is set a bad request is made `?gw_group=null`
- this causes a dashboard exception to be raised as well
- avoiding sending any request when no group is present
- fixes casing of "hostname" in gateway column

Fixes https://tracker.ceph.com/issues/68230

Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>
9 months agoMerge pull request #59567 from clwluvw/rgw-datachangelog
Casey Bodley [Mon, 30 Sep 2024 14:45:08 +0000 (10:45 -0400)]
Merge pull request #59567 from clwluvw/rgw-datachangelog

rgw: remove rgw_data_log_obj_prefix

Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
9 months agoMerge branch 'ceph:main' into kushaldeb-add-email-contact 60015/head
Kushal-deb [Mon, 30 Sep 2024 14:03:02 +0000 (19:33 +0530)]
Merge branch 'ceph:main' into kushaldeb-add-email-contact

9 months agoMerge branch 'ceph:main' into JonBailey1993/ceph_test_rados_io_sequence 59857/head
Jon Bailey [Mon, 30 Sep 2024 12:09:43 +0000 (13:09 +0100)]
Merge branch 'ceph:main' into JonBailey1993/ceph_test_rados_io_sequence

9 months agoMerge pull request #59842 from chanyoung/set-journaling-feature
Ilya Dryomov [Mon, 30 Sep 2024 10:27:07 +0000 (12:27 +0200)]
Merge pull request #59842 from chanyoung/set-journaling-feature

rbd: set journaling feature when --mirror-image-mode is journal

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
9 months agoMerge PR #59874 into main
Venky Shankar [Mon, 30 Sep 2024 10:08:04 +0000 (15:38 +0530)]
Merge PR #59874 into main

* refs/pull/59874/head:
mds: invalid id for client eviction is to be treated as success

Reviewed-by: Neeraj Pratap Singh <neesingh@redhat.com>
9 months agoMerge pull request #60029 from rhcs-dashboard/fix-68295
Pedro Gonzalez Gomez [Mon, 30 Sep 2024 09:13:44 +0000 (11:13 +0200)]
Merge pull request #60029 from rhcs-dashboard/fix-68295

mgr/dashboard: fix doc links in rgw-multisite

Reviewed-by: Nizamudeen A <nia@redhat.com>
9 months agoceph-volume: add new class UdevData 60006/head
Guillaume Abrioux [Thu, 26 Sep 2024 14:58:56 +0000 (16:58 +0200)]
ceph-volume: add new class UdevData

This adds a new class `UdevData` to represent
udev data for a given device.

Fixes: https://tracker.ceph.com/issues/64353
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
9 months agoMerge pull request #60031 from guits/cv-quick-fix
Guillaume Abrioux [Mon, 30 Sep 2024 08:56:35 +0000 (10:56 +0200)]
Merge pull request #60031 from guits/cv-quick-fix

ceph-volume: docstring and typing corrections

9 months agoMerge PR #52623 into main
Venky Shankar [Mon, 30 Sep 2024 06:58:05 +0000 (12:28 +0530)]
Merge PR #52623 into main

* refs/pull/52623/head:
ceph-dencoder: MDS - Add missing types

Reviewed-by: Venky Shankar <vshankar@redhat.com>
9 months agorgw/lc: Fix a bug in LCOpAction_Transition::check() 60020/head
Soumya Koduri [Fri, 27 Sep 2024 07:42:56 +0000 (13:12 +0530)]
rgw/lc: Fix a bug in LCOpAction_Transition::check()

transition.days should be initialized to -1 by default to be able to
correctly process the LC rules which may have `Date` specified.

Fixes: https://tracker.ceph.com/issues/68288
Signed-off-by: Soumya Koduri <skoduri@redhat.com>
9 months agoMerge pull request #60039 from zdover23/wip-doc-2024-09-29-rados-tshooting-tshooting-pg
Zac Dover [Mon, 30 Sep 2024 04:12:48 +0000 (14:12 +1000)]
Merge pull request #60039 from zdover23/wip-doc-2024-09-29-rados-tshooting-tshooting-pg

doc/rados: edit "Placement Groups Never Get Clean"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
9 months agoMerge pull request #59999 from leonidc/tracking-gw-deleting
leonidc [Sun, 29 Sep 2024 12:36:19 +0000 (15:36 +0300)]
Merge pull request #59999 from leonidc/tracking-gw-deleting

mon/nvmeofgw*: fix tracking gateways in DELETING state

9 months agodoc/rados: edit "Placement Groups Never Get Clean" 60039/head
Zac Dover [Sun, 29 Sep 2024 06:10:29 +0000 (16:10 +1000)]
doc/rados: edit "Placement Groups Never Get Clean"

Make grammar improvements (and correct a verb disagreement) in the
section "Placement Groups Never Get Clean" in
doc/rados/troubleshooting/troubleshooting-pg.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>
9 months agoMerge pull request #60036 from solmagd/main
Zac Dover [Sun, 29 Sep 2024 05:48:27 +0000 (15:48 +1000)]
Merge pull request #60036 from solmagd/main

reef: doc: Adds release date.

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
9 months agoMerge pull request #60038 from zdover23/wip-doc-2024-09-28-releases-squid-dashboard
Anthony D'Atri [Sat, 28 Sep 2024 12:44:25 +0000 (08:44 -0400)]
Merge pull request #60038 from zdover23/wip-doc-2024-09-28-releases-squid-dashboard

doc/releases: move Dashboard items from CephFS

9 months agodoc/releases: move Dashboard items from CephFS 60038/head
Zac Dover [Sat, 28 Sep 2024 11:49:03 +0000 (21:49 +1000)]
doc/releases: move Dashboard items from CephFS

Move three dashboard-related items from beneath a heading reading
"CephFS" and put them beneath a heading reading "Dashboard".

Fixes: https://github.com/ceph/ceph/pull/59539#discussion_r1777960130
Signed-off-by: Zac Dover <zac.dover@proton.me>
9 months agoMerge pull request #59366 from athanatos/sjust/wip-67640-module-fix
Samuel Just [Sat, 28 Sep 2024 02:05:57 +0000 (19:05 -0700)]
Merge pull request #59366 from athanatos/sjust/wip-67640-module-fix

.gitmodules: remove shallow=true config from nvmeof/gateway

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
9 months agodoc: Adds release date. 60036/head
Joel Davidow [Fri, 27 Sep 2024 22:44:54 +0000 (22:44 +0000)]
doc: Adds release date.

Signed-off-on-by: Joel Davidow <jdavidow@nso.edu>
9 months agoMerge pull request #58598 from sajibreadd/wip-66215
SrinivasaBharathKanta [Fri, 27 Sep 2024 21:45:24 +0000 (03:15 +0530)]
Merge pull request #58598 from sajibreadd/wip-66215

common/Formatter: dump inf/nan as null

9 months agoMerge pull request #57659 from mkogan1/wip-graceful-shutdown
SrinivasaBharathKanta [Fri, 27 Sep 2024 21:44:45 +0000 (03:14 +0530)]
Merge pull request #57659 from mkogan1/wip-graceful-shutdown

rgw: delay the RGW process exit until all actice requests have completed