mgr/cephadm: add ok_to_stop func for smb service

Fixes: https://tracker.ceph.com/issues/68527
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

Merge PR #60219 into main

* refs/pull/60219/head:
qa/cephfs: update earmark values to valid ones in test_volumes.py

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #60247 from leonidc/101024-fix-no-listeners

mon/nvmeofgw*: fix HA usecase when gateway has no listeners: behaves …

Merge pull request #59905 from rhcs-dashboard/osd-perf-impr

mgr/dashboard: introduce server side pagination for osds

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #60259 from afreen23/wip-listener-del

mgr/dashboard: Fix listener deletion

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #59572 from xxhdx1985126/wip-67874

crimson/osd/backfill_state: add the object to be pushed in the peer missing set of PeeringState

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #59878 from xxhdx1985126/wip-68147

crimson/osd/backfill_state: push peer pg infos' last_backfills only when all objects before them are backfilled

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #60198 from ronen-fr/wip-rf-rm-recovery-2

qa/standalone/scrub: remove TEST_recovery_scrub_2

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #59916 from xxhdx1985126/wip-68175

crimson/osd/backfill_state: do at least one time of replica scanning if necessary in the Enqueuing state

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #59776 from xxhdx1985126/wip-68061

crimson/osd/backfill_state: always go to Enqueuing when object is pushed during Waiting

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #59853 from xxhdx1985126/wip-crimson-pg-purge-strays

crimson/osd: purge strays when PGs go clean

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #60255 from dmick/wip-fix-container-arch

container/build.sh: fix arm architecture tagging

Merge pull request #60028 from rkachach/fix_issue_add_internal_mtls_check

mgr/cephadm: adding config to enforce clients cert check for internal nginx (mTLS)

Reviewed-by: Adam King <adking@redhat.com>

mgr/dashboard: Fix listener deletion

Listener deletion is broken due to passing wrong gateway address.
Including `traddr` in DELETE API of listener to choose correct gateway address for deletion.

The same fix we did for POST API here: https://github.com/afreen23/ceph/commit/287ff3b3603291763b3cd08f9b1543fe60d5f3b9

Fixes: https://tracker.ceph.com/issues/68506
Signed-off-by: Afreen Misbah <afreen23.git@gmail.com>

mgr/dashboard: introduce server side pagination for osds

Fixes: https://tracker.ceph.com/issues/56511
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #59720 from myoungwon/wip-fix-overlapped-write

crimson/os/seastore: fix data inconsistency during ool writes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

container/build.sh: fix arm architecture tagging

The wrong string was used for comparison, and for tagging,
so the arm64 branch and sha1 images overwrote and destroyed
the amd64 images.

Signed-off-by: Dan Mick <dmick@redhat.com>

Merge pull request #60147 from rhcs-dashboard/sync-policy-pipe-edit-fixes

mgr/dashboard: unable to edit pipe config for bucket level policy of bucket

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #59045 from pereman2/ignore-pg-degrade-upgrade

qa/rados/upgrade: ignore PG_DEGRADED

Merge pull request #60206 from VallariAg/wip-nvmeof-fix-test

qa/suites/nvmeof: Fix broken suite by using --no-group-append tag

qa/standalone/scrub: remove TEST_recovery_scrub_2

That test does no longer match the actual requirements and
implementation of scrubbing.
It was already deactivated in
https://github.com/ceph/ceph/pull/59590. Here - it is
fully removed, mainly for the sake of backporting.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #60243 from zdover23/wip-doc-2024-10-10-dev-dev-guide-essentials-backporting

doc/dev: remove "Stable Releases and Backports"

mon/nvmeofgw*: fix HA usecase when gateway has no listeners: behaves like no-subsystems

Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>

Merge PR #60011 into main

* refs/pull/60011/head:
qa: do not fail cephfs QA tests for slow bluestore ops

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>

mgr/dashboard: unable to edit pipe config for bucket level policy of a bucket

Fixes: https://tracker.ceph.com/issues/68387
Fixes Includes:
1) Passing additional parameter for 'user' and 'mode' as the user can be either system/dashboard or other values while creating pipe.
2) Previously while removing the src/dest bucket field, we were getting same old values on editing pipe, but now it will become '*' if empty value passed from frontend.

Signed-off-by: Naman Munet <namanmunet@li-ff83bccc-26af-11b2-a85c-a4b04bfb1003.ibm.com>

doc/dev: remove "Stable Releases and Backports"

Remove mention of "Stable Releases and Backports" from
doc/dev/developer_guide/essentials.rst.

Co-authored-by: Laura Flores <lflores@ibm.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #59987 from kotreshhr/licephfs-aio-nfsganesha

client: Fix libcephfs aio metadata corruption.

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #60161 from NitzanMordhai/wip-nitzan-crimson-perf-suites-adding-ssh-auth

qa/suites/crimson-rados/perf: add ssh keys

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

qa/workunits/nvmeof/setup_subsystem.sh: use --no-group-append

In newer version of nvmeof cli, "subsystem add" needs
this tag to ensure subsystem name is value of --subsystem.
Otherwise, in newer cli version, the gateway group is appended
at the end of the subsystem name.

This fixes the teuthology nvmeof suite (currently all jobs fails
because of this).

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>

qa/suites/nvmeof: use "latest" image of gateway and cli

Change nvmeof gateway and cli image from 1.2 to "latest".

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>

Merge pull request #59692 from cyx1231st/wip-seastore-improve-log

crimson/os/seastore: refine seastore and transaction_manager logs, cleanups

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #60079 from yuvalif/wip-yuval-gcc-14-test-posix

test/rgw/posix: missing std include with GCC 14

Merge pull request #60168 from yuvalif/wip-yuval-68336

test/rgw/lua: use stats polling instead of sleep

Merge pull request #60101 from rhcs-dashboard/fix-68376-main

mgr/dashboard: fix gateways section error:”404 - Not Found RGW Daemon not found: None”

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #60050 from rhcs-dashboard/non-default-realm-sync-status

mgr/dashboard: show non default realm sync status in rgw overview page

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #60211 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence_lock_fix

common/io_exerciser: Modify is_locked_by_me call in ceph_test_rados_io_sequence

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

Merge PR #60210 into main

* refs/pull/60210/head:
doc: update 'header get' output in cephfs-journal-tool.rst

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge PR #60204 into main

* refs/pull/60204/head:
doc: fix email

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
Reviewed-by: Juan Miguel Olmo <jolmomar@redhat.com>

qa/cephfs: update earmark values to valid ones in test_volumes.py

smb.test is an invalid earmark now it should be either smb or
smb.cluster.<cluster_id>. Update the test_volumes.py to set
valid earmarks wherever used.

Fixes: https://tracker.ceph.com/issues/68448
Signed-off-by: Avan Thakkar <athakkar@redhat.com>

Merge PR #60012 into main

* refs/pull/60012/head:
qa: ignore pg availability/degraded warnings

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>

common/io_exerciser: Modify is_locked_by_me call in ceph_test_rados_io_sequence

is_locked_by_me() is a function of ceph::mutex which is only used in debug builds. By using the ceph_mutex_is_locked_by_me macro, we can neatly make sure we only run this function in debug mode, allowing compilation to no longer be affected when running in release mode.

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>

doc: update 'header get' output in cephfs-journal-tool.rst

Signed-off-by: Jos Collin <jcollin@redhat.com>

Merge pull request #60186 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence_add_version

common/io_exerciser: Add version argument to callbacks in ceph_radios_io_sequence

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #60150 from rhcs-dashboard/add-gwgroups-to-missing-endpoints

mgr/dashboard: add gw_groups to all nvmeof endpoints

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

doc: fix email

Signed-off-by: Ernesto Puerta <37327689+epuertat@users.noreply.github.com>

Merge PR #60032 into main

* refs/pull/60032/head:
mds: do not dump empty bufptr

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge PR #60037 into main

* refs/pull/60037/head:
test/common: add death test for double !recursive lock
common/test: do not test exception raised from recursive lock
test/common: fix invalid vim mode
common,osdc: remove obsolete ceph::mutex_debugging
common: assert debug mutex lock is not held if !recursive

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

qa: do not fail cephfs QA tests for slow bluestore ops

Fixes: https://tracker.ceph.com/issues/68283
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #60163 from zdover23/wip-doc-2024-10-07-man-mount-ceph

doc/man: supplant "wsync" with "nowsync" as the default

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnelly@redhat.com>

common/io_exerciser: Add version argument to callbacks in ceph_radios_io_sequence

Add new version that was missing from ceph_test_rados_io_sequence callbacks due to interface changes

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>

crimson/osd/backfill_state: add the object to be pushed in the peer
missing set of PeeringState

Fixes: https://tracker.ceph.com/issues/67874
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

crimson/os/seastore/transaction_manager: refine logs

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/transaction_manager: misc cleanups

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: workaround log linkage issue under clang14

The logs printing lambda-captured variables cannot be linked correctly
with SeaStore::Shard::repeat_with_onode() under clang14.

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: refine logs of seastore.h/cc

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: adjust op names

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: convert length logs to the hex format

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: misc cleanups

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #60162 from zdover23/wip-doc-2024-10-07-governance-reset

doc/governance: revert d7c144c0d7e490bfda9715a0c8462bb67cffc764

Reviewed-by: Patrick Donnelly <pdonnelly@redhat.com>

Merge pull request #60109 from idryomov/wip-63184

librbd/crypto/LoadRequest: clone format for migration source image

Reviewed-by: Sunil Angadi <Sunil.Angadi@ibm.com>
Reviewed-by: Ramana Raja <rraja@redhat.com>

Merge pull request #57582 from sajibreadd/wip-66059

OSD: PG stat is not synchronized between osds after deep-scrub

test/rgw/lua: use stats polling instead of sleep

this makes the test more consistent as well as faster

fixes: https://tracker.ceph.com/issues/68335

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #59857 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence

src/test/osd: create ceph_test_rados_io_sequence testing tool

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #60146 from spuiuk/smb_version

doc: remove note for smb3 support

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/man: supplant "wsync" with "nowsync" as the default

Change the default from "wsync" to "nowsync". "nowsync" has been the
default since kernel version 5.16.

This information was reported on
https://pad.ceph.com/p/Report_Documentation_Bugs by Benjamin Mare on 07
Oct 2024.

The commit relevant to this change can be seen here, in Linus's main
branch:
https://github.com/torvalds/linux/commit/f7a67b463fb83a4b9b11ceaa8ec4950b8fb7f902

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #60001 from cbodley/wip-65654-debug

qa/rgw: add debug log to help diagnose 'bucket check unlinked' failure

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #60020 from soumyakoduri/wip-skoduri-lc-process

rgw/lc: Fix a bug in LCOpAction_Transition::check()

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #59884 from cbodley/wip-51786

cls/user: reset stats only returns marker when truncated

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #59983 from tobias-urdin/rgw-presigned-500

rgw/auth: fix internal server error for presigned urls

Reviewed-by: Casey Bodley <cbodley@redhat.com>

doc/governance: revert d7c144c0d7e490bfda9715a0c8462bb67cffc764

Revert the commit (manually, by restoring the file by hand to the state
it was in prior to d7c144c) to the state that it was in before I added
the Executive Council Responsibilities document to governance.rst. This
document cannot be edited at will, but must be voted on by the
Leadership Team.

Signed-off-by: Zac Dover <zac.dover@proton.me>

qa/suites/crimson-rados/perf: add ssh keys

cbt use ssh connection by defualt, without ssh_keys the task
won't generate public key and the cbt task will fail

Fixes: https://tracker.ceph.com/issues/68421
Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>

Merge pull request #60113 from rhcs-dashboard/fix-68384-main

mgr/dashboard: increase timeout to detect replication user in the secondary cluster

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge pull request #60114 from rhcs-dashboard/fix-68386-main

mgr/dashboard: Enable refresh button on Manage Clusters - Clusters List table

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

mgr/dashboard: fix gateways section error:”404 - Not Found RGW Daemon not found: None”

A case was missed here where we do have a default realm created but no default_zonegorup, in that case, the existing behavior should prevail and that's not being handled. If a default_realm is created but no default_zonegroup is there, weshould continue getting the keys from daemon_name = next(iter(daemon_keys))

Fixes: https://tracker.ceph.com/issues/68376
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: show non default realm sync status in rgw overview page

Currently, we just show the sync status of the default realm in rgw
overview page. This PR is to show the sync status of non-default realms
as well. Multisite sync status can be viewed for any of the active daemon
which runs in default/non-default realm.

Fixes: https://tracker.ceph.com/issues/68329
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

common: missing std include with GCC 14

In file included from src/rgw/driver/posix/bucket_cache.h:19,
                 from src/test/rgw/test_posix_bucket_cache.cc:4:
src/common/cohort_lru.h: In member function _void cohort::lru::TreeX<T, TTree, CLT, CEQ, K, LK>::lock()_:
src/common/cohort_lru.h:334:14: error: _for_each_ is not a member of _std_
  334 |         std::for_each(locks.begin(), locks.end(),
      |              ^~~~~~~~
src/common/cohort_lru.h: In member function _void cohort::lru::TreeX<T, TTree, CLT, CEQ, K, LK>::unlock()_:
/home/yuvalif/ceph5/src/common/cohort_lru.h:339:14: error: _for_each_ is not a member of _std_
  339 |         std::for_each(locks.begin(), locks.end(),
      |              ^~~~~~~~

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #58701 from jecluis/wip-makedist-fix

make-dist: replace all '-' for '.' for rpm release

Merge pull request #60049 from rhcs-dashboard/fix-68307-main

mgr/dashboard: Do not display restart gateway message on completion of Setup Multisite Replication wizard

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>

Merge PR #58966 into main

* refs/pull/58966/head:
qa: test 'ceph fs snapshot mirror ls' command
doc: update docs for 'fs snapshot mirror ls' command
cephfs_mirror: ceph fs snapshot mirror ls command

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge PR #59699 into main

* refs/pull/59699/head:
mgr/status: Fix 'fs status' json output
qa: Add test for 'fs status' in standby-replay mds setup

Reviewed-by: Jos Collin <jcollin@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #56118 from joscollin/wip-B64711-qa-failure_cancel-mirroring-and-readd

cephfs_mirror, qa: fix test failure test_cephfs_mirror_cancel_mirroring_and_readd

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #59870 from rhcs-dashboard/ignore-exception-nvmf

mgr/dashboard: ignore exceptions raised when no cert/key found

Reviewed-by: afreen23 <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

mgr/dashboard: add gw_groups to all nvmeof endpoints

This was missed in the previous implementation

Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: Enable refresh button on Manage Clusters - Clusters List table

Add fetchData() to the clusters list table to refresh the data and
enable refresh button in the table for the same.

Fixes: https://tracker.ceph.com/issues/68386
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: increase timeout to detect replication user in the secondary cluster

Increase timeout to detect replication user in the secondary cluster in rgw multisite automation wizard. Currently its set to 2 mins, increase it to 5 minutes.
when you import realm token to the secondary cluster, we wait for the replication/system user we created in the primary cluster to be present in the secondary cluster and when we find that user we set the credentials in the secondary cluster using ceph dashboard set-rgw-crdentials . The timeout for this is set to 2 minutes and sometimes it takes more than 2 minutes for the user to be replicated in the secondary cluster

Fixes: https://tracker.ceph.com/issues/68384
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

doc: remove note for smb3 support

We support SMB2, SMB2.1 and SMB 3 at the moment. We are not limited to
just SMB3 as noted in the documentation.

Signed-off-by: Sachin Prabhu <sp@spui.uk>

Merge pull request #60115 from zdover23/wip-doc-2024-10-04-governance

doc/governance: add exec council responsibilites

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #59868 from dmick/wip-container

Add Containerfile and build.sh to build it.

Merge pull request #60019 from sungjoon-koh/fix-get-part-number

rgw: decrypt multipart get part when encrypted

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #59977 from tobias-urdin/rgw-cors-v2-auth

rgw: handle http options CORS with v2 auth

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #59770 from cbodley/wip-qa-unpin-tox

qa/tasks/tox: unpin tox version

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #60066 from ceph/wip-openssf-main

README: add OpenSSF Best Practices Badge

client: Fix aio zerobyte file read

The following test fails when run with objectcacher
disabled.

TestClient.LlreadvLlwritevZeroBytes Failure - nonblocking.cc

ceph/src/osdc/Striper.cc: 186: FAILED ceph_assert(len > 0)

Traceback:
 ceph version Development (no_version) squid (dev)
 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x125) [0x7fc0a340aafe]
 2: (ceph::register_assert_context(ceph::common::CephContext*)+0) [0x7fc0a340ad20]
 3: (Striper::file_to_extents(ceph::common::CephContext*, file_layout_t const*, ...)+0x184) [0x562727e13ab4]
 4: (Striper::file_to_extents(ceph::common::CephContext*, char const*, ...)+0x97) [0x562727e145d1]
 5: (Striper::file_to_extents(ceph::common::CephContext*, inodeno_t, ...)+0x75) [0x562727d29520]
 6: (Filer::read_trunc(inodeno_t, file_layout_t const*, snapid_t, ...)+0x61) [0x562727d66ea5]
 7: (Client::C_Read_Sync_NonBlocking::retry()+0x10c) [0x562727cd8a8e]
 8: (Client::_read(Fh*, long, unsigned long, ceph::buffer::v15_2_0::list*, Context*)+0x578) [0x562727d10cb6]
 9: (Client::_preadv_pwritev_locked(Fh*, iovec const*, int, long, bool, ...)+0x3a7) [0x562727d18159]
 10: (Client::ll_preadv_pwritev(Fh*, iovec const*, int, long, bool, ...)+0x179) [0x562727d18b99]
 11: (TestClient_LlreadvLlwritevZeroBytes_Test::TestBody()+0x592) [0x562727ca5352]
 12: (void testing::internal::HandleSehExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, ...)+0x1b) [0x562727d9dea3]
 13: (void testing::internal::HandleExceptionsInMethodIfSupported<testing::Test, void>(testing::Test*, ...)+0x80) [0x562727da2b26]
 14: (testing::Test::Run()+0xb4) [0x562727d927ae]
 15: (testing::TestInfo::Run()+0x104) [0x562727d92988]
 16: (testing::TestSuite::Run()+0xb2) [0x562727d92b34]
 17: (testing::internal::UnitTestImpl::RunAllTests()+0x36b) [0x562727d95303]
 18: (bool testing::internal::HandleSehExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, ...)(), char const*)+0x1b) [0x562727d9e15f]
 19: (bool testing::internal::HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>(testing::internal::UnitTestImpl*, ...)+0x80) [0x562727da3083]
 20: (testing::UnitTest::Run()+0x63) [0x562727d92813]
 21: (RUN_ALL_TESTS()+0x11) [0x562727c828d9]
 22: main()

The patch fixes the same.

Fixes: https://tracker.ceph.com/issues/68309
Signed-off-by: Kotresh HR <khiremat@redhat.com>

client: Fix caps_ref[c]<0 assert

When libcephfs aio tests (src/test/client) are run
with objectcacher disabled (ceph_test_client --client_oc=false),
the TestClient.LlreadvLlwritev fails and core dumps. The client
hits the assert 'caps_ref[c]<0'.

This patch fixes the same. There is no need to give out cap_ref
and take it again between multiple read because of short reads.
In some cases, the get_caps used to fail in C_Read_Sync_NonBlocking::finish
causing cap_ref to go negative when put_cap_ref is done at last in
C_Read_Finish::finish_io

Fixes: https://tracker.ceph.com/issues/68308
Signed-off-by: Kotresh HR <khiremat@redhat.com>

client: Fix libcephfs aio metadata corruption.

Problem:
With cephfs nfs-ganesha, there were following
asserts hit while doing write on a file.

1. FAILED ceph_assert((bool)_front == (bool)_size)
2. FAILED ceph_assert(cap_refs[c] > 0)

Cause:
In aio path, the client_lock was not being held
in the internal callback after the io is done where
it's expected to be taken leading to corruption.

Fix:
Take client_lock in the callback

Fixes: https://tracker.ceph.com/issues/68146
Signed-off-by: Kotresh HR <khiremat@redhat.com>

test/client: Fix aio nonblocking test

The same bufferlist is used without cleaning
for multiple calls. The test 'LlreadvLlwritev'
used to fail because of it. Fixed the same.

Fixes: https://tracker.ceph.com/issues/68146
Signed-off-by: Kotresh HR <khiremat@redhat.com>

qa: Add libcephfs client test with objectcacher disabled

Fixes: https://tracker.ceph.com/issues/68146
Signed-off-by: Kotresh HR <khiremat@redhat.com>

qa: Add data read/write test for nfs-ganesha

Fixes: https://tracker.ceph.com/issues/68146
Signed-off-by: Kotresh HR <khiremat@redhat.com>

Merge pull request #60116 from zdover23/wip-doc-2024-10-04-governance-zdover-email

doc/governance: add Zac Dover's updated email

Merge pull request #59927 from rkachach/fix_issue_mgmt_gw_health_endpoint

mgr/cephadm: adding health check endpoint for mgmt-gateway

Reviewed-by: Adam King <adking@redhat.com>