mds: fix option mds_bal_overload_epochs

When option mds_bal_overload_epochs was added, two positions
should have been modified, but one of them was overlooked.

Fixes: https://tracker.ceph.com/issues/68953
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>

Merge pull request #61510 from dmick/container-no-repo-creds

container/build.sh: don't require repo creds on NO_PUSH

Merge pull request #61566 from zdover23/wip-doc-2025-01-30-cephadm-services-osd

doc/cephadm: simplify confusing math proposition

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #61530 from aza547/ssl_cert

cephadm: rgw: allow specifying the ssl_certificate by filepath

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #61511 from phlogistonjohn/jjm-ctr-label-ceph

container: add label ceph=True back

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #61565 from AliMasarweh/wip-alimasa-bn-policy-with-tenant

RGW | bucket notifications: support cross tenant operations

Reviewed-by: yuvalif<ylifshit@redhat.com>

Merge pull request #61559 from linuxbox2/wip-new-zppbits

rgw: update to latest zpp_bits.h to compile w/gcc-14 & clang 19

Merge pull request #60246 from jamiepryde/SIMD-align-64

erasure-code: Increase SIMD_ALIGN from 32 to 64

Merge pull request #59679 from ceph/add-new-ec-plugins-for-qa

qa/erasure-code: add new teuthology isa configs

doc/cephadm: simplify confusing math proposition

s/This means that the exact device size is 3.64 * 1000, or 3640GB"/This
means that the exact device size is 3.64TB, or 3640 GB"/

In the original text, the number "3.64" appears to refer to a quantity
(and indeed, it is a quantity of Terabytes), but it is unlabeled. Also,
on repeated recent readings of this sentence I found it more puzzling
than enlightening. So I made this commit.

Signed-off-by: Zac Dover <zac.dover@proton.me>

RGW | bucket notifications: support cross tenant operations

Signed-off-by: Ali Masarwa <amasarwa@redhat.com>

Merge pull request #61123 from rhcs-dashboard/raise-smb-msg-exception

mgr/dashboard: smb raise exception for unsucessful resource update

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #61317 from rhcs-dashboard/add-smb-service-msg

mgr/dashboard: add warning message on smb service management

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #61033 from rhcs-dashboard/rgw-user-accounts-ui

mgr/dashboard: RGW user accounts UI

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #60819 from rhcs-dashboard/smb-cluster-form

mgr/dashboard: create smb cluster

Reviewed-by: Afreen Misbah <afreen@ibm.com>

rgw: update to latest zpp_bits.h to compile w/gcc-14 & clang 19

Fixes: https://tracker.ceph.com/issues/69696
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>

Merge pull request #61549 from zdover23/2025-01-28-radosgw-multisite

doc/radosgw: s/zonegroup/pools/

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #60735 from adk3798/cephadm-remove-daemon-service-name

mgr/cephadm: set service name for DaemonDescription object used during daemon removal

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #61215 from ArbitCode/wip-rgw-raja-feature-64526

RGW:support x-amz-expected-bucket-owner to verify bucket ownership wi…

mgr/dashboard: smb raise exception for unsucessful resource update

Adds a decorator to raise a DashboardException with the msg error of an unsucessful smb resource update

Fixes: https://tracker.ceph.com/issues/69286
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>

doc/radosgw: s/zonegroup/pools/

s/zonegroup/pools/, where this change makes the text clearer.

This change was made in reponse to an upstream comment on
https://pad.ceph.com/p/Report_Documentation_Bugs.

Fixes: https://tracker.ceph.com/issues/69689
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61551 from leonidc/level_of_critical_mon_ev

nvmeofgw*: change log level of critical nvmeof monitor events to 1

Merge pull request #61449 from mohit84/issue_69405

neorados_pool_test: Call create_pool at the end of NeoRados delete_pool related test

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

mgr/dashboard: create smb cluster

Fixes: https://tracker.ceph.com/issues/69156
Signed-off-by: Dnyaneshwari Talwekar <dtalwekar@redhat.com>

nvmeofgw*: change log level of critical nvmeof monitor events to 1

Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>

Allow passing ssl_certificate as an rgw_frontend_extra_arg.

Fixes: https://tracker.ceph.com/issues/69567
Signed-off-by: Alexander Hussein-Kershaw <alexhus@microsoft.com>
fix markup

Merge pull request #61392 from Hezko/nvmeof-gw-info-cli

Dashboard: Introduce nvmeof cli commands

Merge PR #60996 into main

* refs/pull/60996/head:
mds/SimpleLock: add is_xlocked_by()
mds/SimpleLock: add has_xlock_by()

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #61250 into main

* refs/pull/61250/head:
mds: avoid acquiring the wrlock twice for a single request
mds: add 'mds_allow_async_dirops' opt to allow/disable async dirop

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #61327 into main

* refs/pull/61327/head:
client: Fix signed comparison warning

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #60935 from rhcs-dashboard/smb-cluster-delete

mgr/dashboard: delete smb cluster

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #60993 from MaxKellermann/types__backward_backward

include/types.h, tools/cephfs: remove _BACKWARD_BACKWARD_WARNING_H

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

mgr/dashboard: Introduce nvmeof cli

Extends ceph cli with nvmeof commands

fixes: https://tracker.ceph.com/issues/62705

Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MBP.lan>

mgr/dashboard: delete smb cluster
Fixes: https://tracker.ceph.com/issues/69191
       https://tracker.ceph.com/issues/69605

Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>

Merge pull request #57895 from rhcs-dashboard/kcli-multi-cluster

mgr/dashboard: adapt kcli plan to improve multi-cluster deployment

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #61382 from nbalacha/dashboard-typo

mgr/dashboard: Typo in NVMe-oF create service

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #61525 from zdover23/wip-doc-2025-01-26-cephadm-host-management

doc/cephadm: correct note

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #61506 from ronen-fr/wip-rf-scrub-formatters

osd/scrub: use ObjectSection & ArraySection
Reviewed-by: Samuel Just <sjust@redhat.com>

doc/cephadm: correct note

Correct the English in a note in doc/cephadm/host-management.rst.

This commit was made in response to
https://github.com/ceph/ceph/pull/50340, which corrected some of this
note in Quincy.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61520 from idryomov/wip-osdcap-syntax-doc

doc/rados: pool and namespace are independent osdcap restrictions

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #61503 from zdover23/wip-doc-2025-01-24-cephfs-disaster-recovery-experts

doc/cephfs: edit disaster-recovery-experts (6 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephfs: edit disaster-recovery-experts (6 of x)

In doc/cephfs/disaster-recovery-experts.rst, incorporate Anthony's
suggestions in

https://github.com/ceph/ceph/pull/61462#discussion_r1923917812
and
https://github.com/ceph/ceph/pull/61462#discussion_r1923920724

and reword the sentences in the section "Using an alternate metadata
pool for recovery" to be in the imperative mood, which better suits the
ordered list format that was introduced in
https://github.com/ceph/ceph/pull/61493.

Follows https://github.com/ceph/ceph/pull/61493.

https://tracker.ceph.com/issues/69557

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

doc/rados: pool and namespace are independent osdcap restrictions

For the "profile {name}" syntax, pool and namespace restrictions are
independent of each other (i.e. specifying namespace doesn't also
require specifying pool like is currently suggested).  A cap can look
like "profile rbd namespace=myns", signifying that the RBD profile is
to be allowed in myns namespace of any pool.

For the "allow {access-spec}" syntax, pool restriction is optional.
A cap can look like "allow r namespace=myns", "allow w object_prefix
myprefix" or "allow rw namespace=myns object_prefix myprefix", for
example.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #61477 from caroav/caroav-update-nvmeof-docs

doc/rbd: update nvme docs

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/rbd: Update nvme documentation

Signed-off-by: Aviv Caro <133020857+caroav@users.noreply.github.com>
Update nvmeof-requirements.rst

Signed-off-by: Aviv Caro <133020857+caroav@users.noreply.github.com>
Update nvmeof-initiator-linux.rst

Signed-off-by: Aviv Caro <133020857+caroav@users.noreply.github.com>
Update nvmeof-initiator-esx.rst

Signed-off-by: Aviv Caro <133020857+caroav@users.noreply.github.com>
Update nvmeof-target-configure.rst

Signed-off-by: Aviv Caro <133020857+caroav@users.noreply.github.com>
doc/rbd: fix broken .rst

Fix .rst errors introduced in https://github.com/ceph/ceph/pull/61477.
This commit will be squashed.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61492 from idryomov/wip-69619

librbd: clear ctx before initiating close in Image::{aio_,}close()

Reviewed-by: Ramana Raja <rraja@redhat.com>

container: add label ceph=True back

Add a label used by cephadm internally that was always set by
ceph-container [1] back to the new containerfile. This should
prevent issues with cephadm shell command thinking official ceph images
are not official ceph images.

[1] https://github.com/ceph/ceph-container/blob/30dc8b9a55f70a40983fd2da6ac31e1b9e977143/src/__DOCKERFILE_TRACEABILITY_LABELS__#L5

Signed-off-by: John Mulligan <jmulligan@redhat.com>

container/build.sh: don't require repo creds on NO_PUSH

Signed-off-by: Dan Mick <dan.mick@redhat.com>

osd/scrub: use ObjectSection & ArraySection

Use the RAII wrappers for the dump Formatters,
instead of manually opening and closing sections.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #61351 from ronen-fr/wip-rf-no-load

osd/scrub: increase the default scrub load limit

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #61493 from zdover23/wip-doc-2025-01-23-cephfs-disaster-recovery-experts

doc/cephfs: edit disaster-recovery-experts (5 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #61396 from ShwetaBhosale1/fix_issue_69541_after_nvmeof_deployment_10008_port_not_opened

mgr/cephadm: After deploying nvmeof gateway group, the prometheus port 10008/tcp is not opened

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #61293 from adk3798/ceph-exporter-sock-dir

cephadm: fix handling of ceph-exporter sock-dir

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

Merge pull request #60943 from anuradhagadge/fix_69081_ca_cert_with_fsid

mgr/cephadm: Changes for creating root cert with manager cluster fsid

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

Merge pull request #60858 from Kushal-deb/fix_issue_2097853-upgrade_status_message

cephadm: ceph orch upgrade status - Display easily understandable message

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #60842 from ShwetaBhosale1/fix_issue_68979_command_to_upgrade_non_ceph_daemon_images

mgr/cephadm: Command to upgrade non-ceph image services with custom image

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #60590 from JoshuaGabriel/joshua_67905

mgr/cephadm: Retry command when SSH connection closes

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #61467 from rhcs-dashboard/revert-cdsModal

mgr/dashboard: revert ModalCdsService for uncarbonized pool form

Reviewed-by: nmunet <nmunet@redhat.com>

Merge pull request #61233 from anoopcs9/rm-stray-backslash

script/ceph-backport: Remove stray `\` from grep command

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #61258 from guits/cv-hints

ceph-volume: type annotations

Merge pull request #61253 from Matan-B/wip-matanb-crimson-tri_mutex_pointer

crimson/common/tri_mutex: improve logging

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>

Merge pull request #56446 from guojidan/metrics

crimson/mgr/client.cc: daemon_health_metrics support

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

doc/cephfs: edit disaster-recovery-experts (5 of x)

Put the procedure in the section called "Using an alternate metadata
pool for recovery" into an ordered list, so that it is in a proper
procedure format.

This commit is meant only to break the procedure into steps. The English
language in each of these steps could be improved, but that improvement
will be done after this formatting has been merged and backported.

Follows https://github.com/ceph/ceph/pull/61462.

https://tracker.ceph.com/issues/69557

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61489 from dmick/wip-fix-container-tags

container/build.sh: fix up org vs. repo naming

container/build.sh: fix up org vs. repo naming

release builds were using the wrong container repo name because of
confused variable naming and inadequate separation.  Keep the hostname,
org name, and repo name in separate variables, and assemble the full
path with a version when tagging is done.

Signed-off-by: Dan Mick <dan.mick@redhat.com>

librbd: clear ctx before initiating close in Image::{aio_,}close()

Image::aio_close() must clear ctx before initiating close.  Otherwise
the provided callback may see a non-NULL ctx and attempt to close the
image again from Image destructor, leading to an invalid memory access
as ImageCtx and ImageState are both freed immediately after the image
is closed (i.e. before AioCompletion is completed and the callback is
executed).

The same adjustment is made to Image::close() just for consistency.

Fixes: https://tracker.ceph.com/issues/69619
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #57997 from guojidan/migration-child

test/librbd: add unit test for flatten migration

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #61277 from lightmelodies/rgw

rgw/lc: make lc worker thread name shorter

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #60800 from rkachach/fix_issue_deps_refactoring

mgr/cephadm: Refactoring and consolidating services dependencies calculation logic

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #61462 from zdover23/wip-doc-2025-01-21-cephfs-disaster-recovery-experts

doc/cephfs: edit disaster-recovery-experts (4 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

mgr/dashboard: Added unit tests and fixed minor issues

Fixes: https://tracker.ceph.com/issues/69140
Signed-off-by: Naman Munet <naman.munet@ibm.com>

mgr/dashboard: Delete account integrated

Fixes: https://tracker.ceph.com/issues/69140
Signed-off-by: Naman Munet <naman.munet@ibm.com>

mgr/dashboard: account edit functionality added

Fixes: https://tracker.ceph.com/issues/69140
Signed-off-by: Naman Munet <naman.munet@ibm.com>

mgr/dashboard: added Create Account Functionality

Fixes: https://tracker.ceph.com/issues/69140
Signed-off-by: Naman Munet <naman.munet@ibm.com>

mgr/dashboard: RGW user accounts UI

--> Integrated list endpoint

Fixes: https://tracker.ceph.com/issues/69140
Signed-off-by: Naman Munet <namanmunet@li-ff83bccc-26af-11b2-a85c-a4b04bfb1003.ibm.com>

Merge pull request #61436 from soumyakoduri/wip-skoduri-dbstore

rgw/dbstore: Update bucket attrs as part of put_info()

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #60647 from soumyakoduri/wip-skoduri-lc-crash

rgw: Add object expirer API to the SAL interface

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

test/librbd: add unit test for flatten migration

Fixes: https://tracker.ceph.com/issues/65743
Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: junxiang Mu <1948535941@qq.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #59050 from mohit84/issue_67270

mon: Create a local copy of scrub_state to avoid a crash

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #60984 from ljflores/wip-fix-telemetry-tests

qa/suites/upgrade/telemetry-upgrade: update telemetry tests

Merge pull request #61007 from kamoltat/wip-ksirivad-fix-68602

qa/tasks/thrashosds-health.yaml: Add osds down to ignorelist

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #58052 from jamiepryde/isal-default

core: Change the default plugin for Ceph erasure coded pools from Jerasure to ISA-L

Reviewed-by: Afreen Misbah <afreen23.git@gmail.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>

Merge pull request #56180 from yehudasa/wip-objecter-local-read

objecter: use configurable to set local and balanced reads

Reviewed-by: Mark Kogan <mkogan@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #61098 from anoopcs9/add-libcephfs-daemon-containerfile

Containerfile: Add `libcephfs-daemon` package

Merge pull request #61175 from ronen-fr/wip-rf-nvme-this

mon/nvme: fix unused lambda capture warnings
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: baum <alexander.indenbaum@gmail.com>

Merge pull request #61282 from oshrey16/wip-lua-oshrey

rgw/lua: add configurable runtime limit for the lua state

Merge pull request #61388 from AliMasarweh/wip-alimasa-bucket-logging-log-info

RGW\logging: added missing fields

Reviewed-by: yuvalif<ylifshit@redhat.com>

mgr/dashboard: revert ModalCdsService for uncarbonized pool form

Fixes: https://tracker.ceph.com/issues/69607
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>

neorados_pool_test: Erase a pool name from local map during delete_pool

The test case itself call CoTearDown function by the end of every test case
and the function call delete_pool on the basis of pool name exists in
local set <created_pools> and if the pool does not exist during CoTearDown
it throws an exception so the test case expects the pool should be exists
before leaving the test case.

Solution: During delete_pool erase a pool name from a local map
          and CoTearDown iterate over local copy instead of the
          orignal copy.

Fixes: https://tracker.ceph.com/issues/69405
Signed-off-by: Mohit Agrawal <moagrawa@redhat.com>

doc/cephfs: edit disaster-recovery-experts (4 of x)

Edit the seventh and final section of
doc/cephfs/disaster-recovery-experts.rst in preparation for adding
deeper explanations of the contexts in which one should use the various
commands listed on that page.

The section edited in this commit is

 * Using an alternate metadata pool for recovery

A future commit might beneficially put this section into the format of
an ordered list. If so, such a commit should only reformat the
content and should not make any changes to the English. It's enough to
verify content or format. Let's not overload our editorial faculties by
forcing ourselves to walk and chew gum at the same time.

Follows https://github.com/ceph/ceph/pull/61442

https://tracker.ceph.com/issues/69557

Signed-off-by: Zac Dover <zac.dover@proton.me>

RGW\logging: adding transport layer fields

Signed-off-by: Ali Masarwa <amasarwa@redhat.com>

Merge pull request #61249 from zdover23/wip-doc-2025-01-07-cephfs-snapshots

doc/cephfs: edit grammar in snapshots.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

mgr/dashboard: add warning message on smb service management

Fixes: https://tracker.ceph.com/issues/69485
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>

Merge pull request #61267 from athanatos/sjust/wip-rep-pipeline-fix

crimson/.../replicated_request: fix pg lifetime in with_pg finally

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #61442 from zdover23/wip-doc-2025-01-18-cephfs-disaster-recovery-experts

doc/cephfs: edit disaster-recovery-experts (3 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

ceph-volume: update unit tests

This commit consolidates all necessary changes to address unit tests
related to the introduction of Python type annotations.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>

ceph-volume: remove duplicate code

This check is already performed in `arg_validators.py`.
By the way, this check is only valid when the user passes a VG/LV with
the `<vg>/<lv>` format.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>

ceph-volume: add type annotations to devices.lvm.batch

This commit adds the Python type annotations to `devices.lvm.batch`.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>

ceph-volume: add type annotations to devices.lvm.listing

This commit adds the Python type annotations to `devices.lvm.listing`.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>

ceph-volume: improve clarity and consistency in List.single_report

- Rename the parameter `arg` to `osd` for better readability.
- Simplify the check for numeric OSD identifiers using `isdigit()`.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>