]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
7 months agoRGW/logging: add rest API to flush logging bucket 60697/head
Ali Masarwa [Mon, 11 Nov 2024 13:16:30 +0000 (15:16 +0200)]
RGW/logging: add rest API to flush logging bucket

Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
7 months agotest/rgw/logging: add bucket logging test suite to teuthology 59808/head
Yuval Lifshitz [Mon, 11 Nov 2024 17:48:39 +0000 (17:48 +0000)]
test/rgw/logging: add bucket logging test suite to teuthology

this is depended with this s3test PR:
https://github.com/ceph/s3-tests/pull/576

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
7 months agorgw/logging: add support for GetBucketLogging and PutBucketLogging
Yuval Lifshitz [Wed, 6 Dec 2023 18:51:59 +0000 (18:51 +0000)]
rgw/logging: add support for GetBucketLogging and PutBucketLogging

this is based on AWS server access logs:
- https://docs.aws.amazon.com/AmazonS3/latest/userguide/enable-server-access-logging.html
- https://docs.aws.amazon.com/AmazonS3/latest/userguide/ServerLogs.html
- https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutBucketLogging.html
- https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketLogging.html

however, a new mode was added called "journal" where:
- logs of PUT, COPY and MPU are guaranteed
- we have logs of DELETE and multi-DELETE operations (not guaranteed)
- log records hold only minimal amount of information

Fixes: https://tracker.ceph.com/issues/984
Signed-off-by: Yuval Lifshitz <ylifshit@redhat.com>
7 months agoMerge pull request #60668 from ronen-fr/wip-rf-mconf
Ronen Friedman [Wed, 20 Nov 2024 06:08:45 +0000 (08:08 +0200)]
Merge pull request #60668 from ronen-fr/wip-rf-mconf

osd/scrub: cache frequently used configuration parameters

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
8 months agoMerge pull request #60769 from gbregman/main
Adam King [Tue, 19 Nov 2024 20:07:07 +0000 (15:07 -0500)]
Merge pull request #60769 from gbregman/main

mgr/cephadm: Add resource limits to nvmeof configuration

Reviewed-by: Adam King <adking@redhat.com>
8 months agoMerge pull request #60588 from AlexonOliveiraRH/wip-doc-templates
Anthony D'Atri [Tue, 19 Nov 2024 19:49:58 +0000 (14:49 -0500)]
Merge pull request #60588 from AlexonOliveiraRH/wip-doc-templates

doc/cephadm/services: Update monitoring.rst to add additional templates

8 months agoMerge pull request #60598 from xxhdx1985126/wip-68808
Matan Breizman [Tue, 19 Nov 2024 16:23:00 +0000 (18:23 +0200)]
Merge pull request #60598 from xxhdx1985126/wip-68808

crimson/osd/replicate_backend: add the skipped newly created clone object to the push queue after the clone request completes

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
8 months agocommon: rm the cast operator of md_config_cacher_t 60668/head
Ronen Friedman [Thu, 14 Nov 2024 12:12:23 +0000 (06:12 -0600)]
common: rm the cast operator of md_config_cacher_t

as its replacement - the type-deduced operator() - is now in use,
and the resulting code is more readable and less error-prone.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
8 months agoosd: rm all uses of the cast operator of md_config_cacher_t
Ronen Friedman [Thu, 14 Nov 2024 12:01:50 +0000 (06:01 -0600)]
osd: rm all uses of the cast operator of md_config_cacher_t

as this interface is to be removed in the next commit.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
8 months agoosd/scrub: cache frequently used configuration parameters
Ronen Friedman [Wed, 6 Nov 2024 14:33:12 +0000 (08:33 -0600)]
osd/scrub: cache frequently used configuration parameters

using the md_config_cacher_t, which is a cache object that registers
itself to the config observer and caches the up-to-date configuration
value.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
8 months agocommon: a simple API to extract md_config_cacher_t cached value
Ronen Friedman [Wed, 13 Nov 2024 09:02:00 +0000 (03:02 -0600)]
common: a simple API to extract md_config_cacher_t cached value

Using a type-deduced operator() (i.e. my_opt() ), instead of the
existing ValueT() operator (which requires a type-matching cast).

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
8 months agomgr/cephadm: Add resource limits to nvmeof configuration 60769/head
Gil Bregman [Tue, 19 Nov 2024 11:51:37 +0000 (13:51 +0200)]
mgr/cephadm: Add resource limits to nvmeof configuration
Fixes https://tracker.ceph.com/issues/68967

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
8 months agopython-common/ceph/deployment: Add resource limits to nvmeof configuration
Gil Bregman [Tue, 19 Nov 2024 11:51:01 +0000 (13:51 +0200)]
python-common/ceph/deployment: Add resource limits to nvmeof configuration
Fixes https://tracker.ceph.com/issues/68967

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
8 months agoMerge pull request #60572 from xxhdx1985126/wip-68787 60757/head
Matan Breizman [Tue, 19 Nov 2024 11:24:23 +0000 (13:24 +0200)]
Merge pull request #60572 from xxhdx1985126/wip-68787

crimson/osd/backfill_state: don't try to do object backfills when primary_bi is empty

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
8 months agoMerge pull request #60661 from ronen-fr/wip-rf-scheduledeep
Ronen Friedman [Tue, 19 Nov 2024 08:47:26 +0000 (10:47 +0200)]
Merge pull request #60661 from ronen-fr/wip-rf-scheduledeep

osd/scrub: fix 'schedule-deepscrub' test asok command

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
8 months agoMerge pull request #60674 from oshrey16/bugfix-rgw-ps-list-topics-op
Yuval Lifshitz [Tue, 19 Nov 2024 06:20:00 +0000 (08:20 +0200)]
Merge pull request #60674 from oshrey16/bugfix-rgw-ps-list-topics-op

rgw/notification: Fix segmentation fault in RGWPSListTopicsOp::execute() and correct topic listing to use get_topics_v2

Reviewed-By: Joseph Mundackal <jmundackal@bloomberg.net>, Yuval Lifshitz <ylifshit@ibm.com>
8 months agoMerge pull request #60765 from zdover23/wip-doc-2024-11-19-os-recommendations
Anthony D'Atri [Tue, 19 Nov 2024 01:04:55 +0000 (20:04 -0500)]
Merge pull request #60765 from zdover23/wip-doc-2024-11-19-os-recommendations

doc/start: update os-recommendations.rst

8 months agodoc/start: update os-recommendations.rst 60765/head
Zac Dover [Tue, 19 Nov 2024 00:37:56 +0000 (10:37 +1000)]
doc/start: update os-recommendations.rst

Remove information about the operating systems that support Ceph's
official container images from the "Platforms" table in
doc/start/os-recommendations.rst and add that information to the (new)
table that shows the operating systems that support Ceph's official
container images.

Credit for this change should go to Enrico Bocchi, who noticed a
discrepancy that motivated it.

Signed-off-by: Zac Dover <zac.dover@proton.me>
8 months agoMerge pull request #60309 from linuxbox2/wip-cksum-68537
Casey Bodley [Mon, 18 Nov 2024 16:51:32 +0000 (11:51 -0500)]
Merge pull request #60309 from linuxbox2/wip-cksum-68537

rgw_cksum:  treat mpu checksums w/o part count as valid in CompleteMu…

Reviewed-by: Casey Bodley <cbodley@redhat.com>
8 months agoMerge pull request #60711 from soumyakoduri/wip-skoduri-dbstore
Soumya Koduri [Mon, 18 Nov 2024 15:01:36 +0000 (20:31 +0530)]
Merge pull request #60711 from soumyakoduri/wip-skoduri-dbstore

rgw: Update README for DBStore and Posix drivers

Reviewed-by: Casey Bodley <cbodley@redhat.com>
8 months agorgw/notification: fix segmentation fault and topic listing logic 60674/head
Oshrey Avraham [Mon, 18 Nov 2024 10:06:22 +0000 (12:06 +0200)]
rgw/notification: fix segmentation fault and topic listing logic

- Fixed a segmentation fault caused by a null bucket pointer in RGWPSListTopicsOp::execute()
- Corrected logic to use get_topics_v2 when supported, with fallback otherwise

Fixes: https://tracker.ceph.com/issues/68756
Signed-off-by: Oshrey Avraham <oshrey16@gmail.com>
8 months agocrimson/osd/replicate_backend: add the skipped newly created clone 60598/head
Xuehan Xu [Mon, 4 Nov 2024 09:30:10 +0000 (17:30 +0800)]
crimson/osd/replicate_backend: add the skipped newly created clone
object to the push queue after the clone request completes

Fixes: https://tracker.ceph.com/issues/68808
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
8 months agoMerge pull request #60655 from xxhdx1985126/wip-seastore-move-out-root-meta
Yingxin [Fri, 15 Nov 2024 08:51:05 +0000 (16:51 +0800)]
Merge pull request #60655 from xxhdx1985126/wip-seastore-move-out-root-meta

crimson/os/seastore: move the root meta out of the root block

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
8 months agoMerge pull request #60209 from myoungwon/wip-init-onode-layout
Yingxin [Fri, 15 Nov 2024 08:50:17 +0000 (16:50 +0800)]
Merge pull request #60209 from myoungwon/wip-init-onode-layout

crimson/os/seastore: initialize oi and ss in onode_layout_t to zero

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
8 months agoMerge pull request #60715 from ronen-fr/wip-rf-dumpsched
Ronen Friedman [Thu, 14 Nov 2024 13:55:36 +0000 (15:55 +0200)]
Merge pull request #60715 from ronen-fr/wip-rf-dumpsched

osd/scrub: list additional information when dumping the queue

Reviewed-by: Samuel Just <sjust@redhat.com>
8 months agoMerge pull request #60727 from guits/dmcrypt-activate
Guillaume Abrioux [Thu, 14 Nov 2024 13:02:16 +0000 (14:02 +0100)]
Merge pull request #60727 from guits/dmcrypt-activate

ceph-volume: fix dmcrypt activation regression

8 months agoMerge pull request #60404 from VallariAg/wip-nvmeof-listeners-prometheus-alerts
Vallari Agrawal [Thu, 14 Nov 2024 10:53:55 +0000 (16:23 +0530)]
Merge pull request #60404 from VallariAg/wip-nvmeof-listeners-prometheus-alerts

monitoring: add 2 nvmeof alerts to prometheus_alerts.yaml

8 months agoMerge pull request #51766 from zhsgao/mds_clear_session_failed
Venky Shankar [Thu, 14 Nov 2024 07:08:35 +0000 (12:38 +0530)]
Merge pull request #51766 from zhsgao/mds_clear_session_failed

mds: session in the importing state cannot be cleared if an export subtree task is interrupted while the state of importer is acking

Reviewed-by: Venky Shankar <vshankar@redhat.com>
8 months agoMerge pull request #60067 from VallariAg/wip-nvmeof-healthcheck
Vallari Agrawal [Thu, 14 Nov 2024 03:10:43 +0000 (08:40 +0530)]
Merge pull request #60067 from VallariAg/wip-nvmeof-healthcheck

mon: add nvmeof healthchecks

8 months agoceph-volume: fix dmcrypt activation regression 60727/head
Guillaume Abrioux [Wed, 13 Nov 2024 15:23:36 +0000 (16:23 +0100)]
ceph-volume: fix dmcrypt activation regression

`ceph.with_tpm` tag is actually a `str`, which means that
`bool('0')` will return `True`.

Fixes: https://tracker.ceph.com/issues/68944
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
8 months agoMerge pull request #60554 from jshen28/fix-legacy-addr-mismatch
Ilya Dryomov [Wed, 13 Nov 2024 12:25:08 +0000 (13:25 +0100)]
Merge pull request #60554 from jshen28/fix-legacy-addr-mismatch

Make mon_info_t consistent with mon_addr

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
8 months agomds: client is evicted when an export subtree task is interrupted 51766/head
Zhansong Gao [Mon, 3 Jul 2023 09:18:14 +0000 (17:18 +0800)]
mds: client is evicted when an export subtree task is interrupted

The importer will force open some sessions provided by the exporter but the client does not know about
the new sessions until the exporter notifies it, and the notifications cannot be sent if the exporter
is interrupted. The client does not renew the sessions regularly that it does not know about, so the client
will be evicted by the importer after `session_autoclose` seconds (300 seconds by default).

The sessions that are forced opened in the importer need to be closed when the import process is reversed.

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
8 months agoqa: add test for importer's unexpected client eviction after an export subtree task...
Zhansong Gao [Mon, 3 Jul 2023 08:42:34 +0000 (16:42 +0800)]
qa: add test for importer's unexpected client eviction after an export subtree task is interrupted

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
8 months agomds: session in the importing state cannot be cleared if an export subtree task is...
Zhansong Gao [Fri, 26 May 2023 04:20:17 +0000 (12:20 +0800)]
mds: session in the importing state cannot be cleared if an export subtree task is interrupted while the state of importer is acking

The related sessions in the importer are in the importing state(`Session::is_importing` return true) when the state of importer is `acking`,
`Migrator::import_reverse` called by `MDCache::handle_resolve` should reverse the process to clear the importing state if the exporter restarts
at this time, but it doesn't do that actually because of its bug. And it will cause these sessions to not be cleared when the client is
unmounted(evicted or timeout) until the mds is restarted.

The bug in `import_reverse` is that it contains the code to handle state `IMPORT_ACKING` but it will never be executed because
the state is modified to `IMPORT_ABORTING` at the beginning. Move `stat.state = IMPORT_ABORTING` to the end of import_reverse
so that it can handle the state `IMPORT_ACKING`.

Fixes: https://tracker.ceph.com/issues/61459
Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
8 months agoqa: add test for importer's session cleanup after an export subtree task is interrupted
Zhansong Gao [Fri, 26 May 2023 04:58:42 +0000 (12:58 +0800)]
qa: add test for importer's session cleanup after an export subtree task is interrupted

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
8 months agoqa/suites/nvmeof: add nvmeof warnings to log-ignorelist 60067/head
Vallari Agrawal [Tue, 15 Oct 2024 12:40:20 +0000 (18:10 +0530)]
qa/suites/nvmeof: add nvmeof warnings to log-ignorelist

Add NVMEOF_SINGLE_GATEWAY and NVMEOF_GATEWAY_DOWN
warnings to nvmeof:thrash job's log-ignorelist

Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
8 months agomds: the assert should be before the journal entry submit otherwise it's racy
Zhansong Gao [Fri, 16 Jun 2023 04:30:40 +0000 (12:30 +0800)]
mds: the assert should be before the journal entry submit otherwise it's racy

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
8 months agomds: add `importing_count` to session dump
Zhansong Gao [Fri, 26 May 2023 04:25:10 +0000 (12:25 +0800)]
mds: add `importing_count` to session dump

Signed-off-by: Zhansong Gao <zhsgao@hotmail.com>
8 months agoMerge PR #60464 into main
Patrick Donnelly [Wed, 13 Nov 2024 03:17:59 +0000 (22:17 -0500)]
Merge PR #60464 into main

* refs/pull/60464/head:
mds: add or update MDS thread names
log: cache recent threads up to a day
common: cache pthread names
log: concatenate thread names and print once per thread

Reviewed-by: Milind Changire <mchangir@redhat.com>
8 months agoMerge PR #60327 into main
Patrick Donnelly [Wed, 13 Nov 2024 03:16:54 +0000 (22:16 -0500)]
Merge PR #60327 into main

* refs/pull/60327/head:
mon/MDSMonitor: send reply to beacons with `state=DNE`

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
8 months agoMerge PR #60381 into main
Patrick Donnelly [Wed, 13 Nov 2024 03:14:20 +0000 (22:14 -0500)]
Merge PR #60381 into main

* refs/pull/60381/head:
doc: remove refrences to `mds_log_major_segment_event_ratio`
mds: start a new major segment after reaching minor segment threshold
mds: make parts of mdlog reusable to be used by beacon

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
8 months agoMerge PR #60325 into main
Patrick Donnelly [Wed, 13 Nov 2024 03:13:46 +0000 (22:13 -0500)]
Merge PR #60325 into main

* refs/pull/60325/head:
mds/Beacon: wake up the thread in shutdown()

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
8 months agoMerge PR #60283 into main
Patrick Donnelly [Wed, 13 Nov 2024 03:12:27 +0000 (22:12 -0500)]
Merge PR #60283 into main

* refs/pull/60283/head:
mds: add issue_seq to all cap messages
include/ceph_fs: correct ceph_mds_cap_peer field name
include/ceph_fs: correct ceph_mds_cap_item field name
messages/MClientCaps: use correct ceph_seq_t for cap sequence types
messages/MClientCaps: dump issue_seq for debugging
mds: remove dead code

Reviewed-by: Venky Shankar <vshankar@redhat.com>
8 months agoMerge PR #60226 into main
Patrick Donnelly [Wed, 13 Nov 2024 03:10:57 +0000 (22:10 -0500)]
Merge PR #60226 into main

* refs/pull/60226/head:
mds/QuiesceDbEncoding: add `inline` to work around linker error

Reviewed-by: Rishabh Dave <ridave@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
8 months agoMerge PR #58586 into main
Patrick Donnelly [Wed, 13 Nov 2024 03:09:30 +0000 (22:09 -0500)]
Merge PR #58586 into main

* refs/pull/58586/head:
qa/suites/fs/thrash: add convolve operator for overrides
qa/cephfs: s/prefetch_dirfrags/prefetch_oft_dirfrags

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
8 months agoMerge pull request #60675 from zmc/make-dist-quiet
Zack Cerza [Tue, 12 Nov 2024 19:21:23 +0000 (12:21 -0700)]
Merge pull request #60675 from zmc/make-dist-quiet

8 months agoosd/scrub: list additional information when dumping the queue 60715/head
Ronen Friedman [Tue, 12 Nov 2024 14:21:25 +0000 (08:21 -0600)]
osd/scrub: list additional information when dumping the queue

Extend the information provided for operator dump commands, to
include the basic identity and scheduling information of the
entries in the scrub queue.

This change mostly benefits automatic QA and our internal
testing.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
8 months agorgw: Update README for DBStore and Posix drivers 60711/head
Soumya Koduri [Tue, 12 Nov 2024 06:34:33 +0000 (12:04 +0530)]
rgw: Update README for DBStore and Posix drivers

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
8 months agocrimson/osd/replicated_backend: add the dedicated method to construct
Xuehan Xu [Mon, 4 Nov 2024 07:19:26 +0000 (15:19 +0800)]
crimson/osd/replicated_backend: add the dedicated method to construct
MOSDRepOp

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
8 months agocrimson/osd/pg: add is_missing_on_peer()
Xuehan Xu [Mon, 4 Nov 2024 07:18:19 +0000 (15:18 +0800)]
crimson/osd/pg: add is_missing_on_peer()

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
8 months agocrimson/osd/pg: reuse already defined methods as many as possible to
Xuehan Xu [Mon, 4 Nov 2024 07:17:19 +0000 (15:17 +0800)]
crimson/osd/pg: reuse already defined methods as many as possible to
improve readability

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
8 months agocrimson/osd/ops_executor: call OpsExecutor::apply_stats() before 60596/head
Xuehan Xu [Sat, 9 Nov 2024 06:59:45 +0000 (14:59 +0800)]
crimson/osd/ops_executor: call OpsExecutor::apply_stats() before
OpsExecutor::obc is moved out.

OpsExecutor::apply_stats() accesses OpsExecutor::obc indirectly

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
8 months agocrimson/osd/pg: fix dangerous lambda captures
Xuehan Xu [Sat, 2 Nov 2024 02:01:52 +0000 (10:01 +0800)]
crimson/osd/pg: fix dangerous lambda captures

In PG::submit_transaction(), osd_op_p was first moved to
ReplicatedBackend::submit_transaction(), and later its at_version is
captured in another lambda. The latter may be already empty at the time
of the capture.

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
8 months agoMerge pull request #60703 from zdover23/wip-doc-2024-11-12-rados-operations-add-or... 59906/head
Anthony D'Atri [Tue, 12 Nov 2024 01:18:56 +0000 (20:18 -0500)]
Merge pull request #60703 from zdover23/wip-doc-2024-11-12-rados-operations-add-or-rm-osds

doc/rados: correct "full ratio" note

8 months agoMerge pull request #60704 from zdover23/wip-doc-2024-11-12-start-hardware-recommendations
Anthony D'Atri [Tue, 12 Nov 2024 01:17:26 +0000 (20:17 -0500)]
Merge pull request #60704 from zdover23/wip-doc-2024-11-12-start-hardware-recommendations

doc/start: fix "are are" typo

8 months agoMerge pull request #60705 from zdover23/wip-doc-2024-11-12-radosgw-account
Anthony D'Atri [Tue, 12 Nov 2024 01:10:55 +0000 (20:10 -0500)]
Merge pull request #60705 from zdover23/wip-doc-2024-11-12-radosgw-account

doc/radosgw: s/Poliicy/Policy/

8 months agodoc/radosgw: s/Poliicy/Policy/ 60705/head
Zac Dover [Mon, 11 Nov 2024 23:54:56 +0000 (09:54 +1000)]
doc/radosgw: s/Poliicy/Policy/

Correct "AttachGroupPoliicy" to "AttachGroupPolicy".

Fixes: https://tracker.ceph.com/issues/68902
Signed-off-by: Zac Dover <zac.dover@proton.me>
8 months agodoc/start: fix "are are" typo 60704/head
Zac Dover [Mon, 11 Nov 2024 23:47:21 +0000 (09:47 +1000)]
doc/start: fix "are are" typo

Fix typo reading "They are are single-threaded".
s/are are/are/

Fixes: https://tracker.ceph.com/issues/68901
Signed-off-by: Zac Dover <zac.dover@proton.me>
8 months agoMerge pull request #60092 from connorfawcett/vstart_runner_bytes_fix
Connor Fawcett [Mon, 11 Nov 2024 23:39:41 +0000 (23:39 +0000)]
Merge pull request #60092 from connorfawcett/vstart_runner_bytes_fix

qa/vstart-runner: Only remove non-ASCII characters from string-based command outputs

8 months agodoc/rados: correct "full ratio" note 60703/head
Zac Dover [Mon, 11 Nov 2024 23:31:28 +0000 (09:31 +1000)]
doc/rados: correct "full ratio" note

Correct a note that directed users not to add an OSD after the cluster
has reached its "full ratio". The note now says "Do not let your cluster
reach its full ratio before adding an OSD."

Hat tip: Oskar Berggren

Fixes: https://tracker.ceph.com/issues/68900
Co-authored-by: Oskar Berggren <oskar.berggren@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
8 months agomonitoring: add tests for 2 new nvmeof alerts 60404/head
Vallari Agrawal [Wed, 30 Oct 2024 14:04:01 +0000 (19:34 +0530)]
monitoring: add tests for 2 new nvmeof alerts

Add test for alerts NVMeoFMissingListener and
NVMeoFZeroListenerSubsystem to test_alerts.yml.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
8 months agoMerge pull request #60529 from zdover23/wip-doc-2024-10-29-start-os-recommendations
Zac Dover [Mon, 11 Nov 2024 15:33:06 +0000 (01:33 +1000)]
Merge pull request #60529 from zdover23/wip-doc-2024-10-29-start-os-recommendations

doc/start: separate package chart from container chart

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
8 months agoMerge pull request #59328 from mkogan1/wip-d3n-umask
Mark Kogan [Mon, 11 Nov 2024 13:59:59 +0000 (15:59 +0200)]
Merge pull request #59328 from mkogan1/wip-d3n-umask

rgw: d3n: set access permissions for the D3N cache directory when creating

8 months agodoc/start: separate package chart from container chart 60529/head
Zac Dover [Tue, 29 Oct 2024 07:27:43 +0000 (17:27 +1000)]
doc/start: separate package chart from container chart

Separate the packages-and-containers chart into two charts:
   (1) a chart that shows which OSes Ceph builds packages for
   (2) a chart that shows which OSes support Ceph's containers

Signed-off-by: Zac Dover <zac.dover@proton.me>
8 months agomonitoring: add 2 new nvmeof alerts
Vallari Agrawal [Wed, 30 Oct 2024 14:02:41 +0000 (19:32 +0530)]
monitoring: add 2 new nvmeof alerts

Add NVMeoFMissingListener and NVMeoFZeroListenerSubsystem
alerts to prometheus_alerts.libsonnet.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
8 months agomonitoring: add 2 nvmeof alerts to prometheus_alerts.yaml
Vallari Agrawal [Tue, 8 Oct 2024 21:07:48 +0000 (02:37 +0530)]
monitoring: add 2 nvmeof alerts to prometheus_alerts.yaml

- `NVMeoFMissingListener`: trigger if all listeners
     are not created for each gateway in a subsystem
- `NVMeoFZeroListenerSubsystem`: trigger if a subsystem has no listeners

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
8 months agoMerge pull request #60626 from ivoalmeida/carbon-version-update
Nizamudeen A [Mon, 11 Nov 2024 10:42:43 +0000 (16:12 +0530)]
Merge pull request #60626 from ivoalmeida/carbon-version-update

mgr/dashboard: update carbon-components-angular

Reviewed-by: Afreen Misbah <afreen@ibm.com>
8 months agoMerge pull request #60511 from rhcs-dashboard/health-test-fix
Nizamudeen A [Mon, 11 Nov 2024 10:09:08 +0000 (15:39 +0530)]
Merge pull request #60511 from rhcs-dashboard/health-test-fix

qa/dashboard: fix tasks.mgr.dashboard.test_health.HealthTest

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
8 months agotest/crimson/seastore/test_object_data_handler: always access object 60655/head
Xuehan Xu [Fri, 8 Nov 2024 04:55:27 +0000 (12:55 +0800)]
test/crimson/seastore/test_object_data_handler: always access object
data based on offsets relative to the start of the object data base

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
8 months agotest/crimson/seastore/test_transaction_manager: take RootMetaBlock into
Xuehan Xu [Fri, 8 Nov 2024 01:38:43 +0000 (09:38 +0800)]
test/crimson/seastore/test_transaction_manager: take RootMetaBlock into
account

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
8 months agocrimson/os/seastore/cache: throw enospc when failed to alloc new extents
Xuehan Xu [Fri, 8 Nov 2024 01:38:11 +0000 (09:38 +0800)]
crimson/os/seastore/cache: throw enospc when failed to alloc new extents

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
8 months agocrimson/os/seastore: move the root meta out of the root block
Xuehan Xu [Thu, 7 Nov 2024 01:41:18 +0000 (09:41 +0800)]
crimson/os/seastore: move the root meta out of the root block

During massive data backfilling, new osdmaps keep being created due to
frequent pg status changes, which can lead to frequent osd meta updates.
Those updates will be translated into "SeaStore::write_meta"s, which
modifies the root block's meta field and invalidates all inflight
transactions. Since the osd meta updates can be very frequent, long
transactions may be kept invalidated and the corresponding IO requests
hang.

This commit moves the root meta out of the root block, so that updates
to it won't invalidate irrelevant transactions

Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
8 months agoqa/vstart-runner: Only remove non-ASCII characters from string-based command outputs 60092/head
Connor Fawcett [Wed, 2 Oct 2024 13:27:17 +0000 (14:27 +0100)]
qa/vstart-runner: Only remove non-ASCII characters from string-based command outputs

Signed-off-by: Connor Fawcett <connorfa@uk.ibm.com>
Fixes: https://tracker.ceph.com/issues/68368
8 months agoMerge pull request #60663 from leonidc/wip-publish-rebalance-ana-group
leonidc [Sat, 9 Nov 2024 13:29:25 +0000 (15:29 +0200)]
Merge pull request #60663 from leonidc/wip-publish-rebalance-ana-group

 mon/nvmeofgw*: monitors publish in nvme-gw show ana group responsible

8 months agoMerge pull request #60605 from zdover23/wip-doc-2024-11-04-cephadm-services-osd
Zac Dover [Sat, 9 Nov 2024 12:53:34 +0000 (22:53 +1000)]
Merge pull request #60605 from zdover23/wip-doc-2024-11-04-cephadm-services-osd

doc/cephadm: clean "Adv. OSD Service Specs"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Adam King <adking@redhat.com>
8 months agoMerge pull request #60592 from athanatos/sjust/wip-crimson-io-2
Samuel Just [Fri, 8 Nov 2024 21:26:17 +0000 (13:26 -0800)]
Merge pull request #60592 from athanatos/sjust/wip-crimson-io-2

crimson: switch to simple RAII obc locking mechanism

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
8 months agomake-dist: Quiet submodule operations in Jenkins 60675/head
Zack Cerza [Fri, 8 Nov 2024 19:43:16 +0000 (12:43 -0700)]
make-dist: Quiet submodule operations in Jenkins

Signed-off-by: Zack Cerza <zack@redhat.com>
8 months agoMerge pull request #60578 from zmc/rpm-sccache-toggle 60682/head
Zack Cerza [Fri, 8 Nov 2024 18:02:19 +0000 (11:02 -0700)]
Merge pull request #60578 from zmc/rpm-sccache-toggle

8 months agoMerge pull request #60621 from galsalomon66/mask_parquet_dependencies
Gal Salomon [Fri, 8 Nov 2024 12:15:06 +0000 (14:15 +0200)]
Merge pull request #60621 from galsalomon66/mask_parquet_dependencies

rgw: hiding parquet dependencies upon parquet-select option is off

8 months agoqa/dashboard: fix test_list_enabled_module failure 60511/head
Nizamudeen A [Wed, 30 Oct 2024 14:01:10 +0000 (19:31 +0530)]
qa/dashboard: fix test_list_enabled_module failure

Check the ports availability and go for a new port if the current one is
not available

Fixes: https://tracker.ceph.com/issues/62972
Signed-off-by: Nizamudeen A <nia@redhat.com>
8 months agoMerge pull request #60448 from anthonyeleven/improve-mgr-disable
Zac Dover [Fri, 8 Nov 2024 09:33:57 +0000 (19:33 +1000)]
Merge pull request #60448 from anthonyeleven/improve-mgr-disable

doc: improve pending release notes and CephFS

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
8 months ago mon/nvmeofgw*: monitors publish in nvme-gw show ana group responsible 60663/head
Leonid Chernin [Wed, 6 Nov 2024 11:04:16 +0000 (11:04 +0000)]
 mon/nvmeofgw*: monitors publish in nvme-gw show ana group responsible
 for  namespace rebalance

Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
8 months agoceph.spec.in: Add option to enable sccache 60578/head
Zack Cerza [Fri, 25 Oct 2024 22:49:10 +0000 (16:49 -0600)]
ceph.spec.in: Add option to enable sccache

Signed-off-by: Zack Cerza <zack@redhat.com>
8 months agomgr/dashboard: update carbon-components-angular 60626/head
Ivo Almeida [Tue, 5 Nov 2024 16:19:09 +0000 (16:19 +0000)]
mgr/dashboard: update carbon-components-angular

* update carbon-components-angular pkg to v5.48.0
* fixed change detection errors on unit tests
* fixed pagination page length when limit is 0 and data is empty

Fixes: https://tracker.ceph.com/issues/68837
Signed-off-by: Ivo Almeida <ialmeida@redhat.com>
8 months agocrimson/.../object_context: remove unused lock helpers 60592/head
Samuel Just [Thu, 7 Nov 2024 03:41:46 +0000 (03:41 +0000)]
crimson/.../object_context: remove unused lock helpers

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson/osd/object_context_loader.cc: retab remaining methods
Samuel Just [Sat, 26 Oct 2024 22:44:57 +0000 (15:44 -0700)]
crimson/osd/object_context_loader.cc: retab remaining methods

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson: InternalClientRequests require that the pg is already active
Samuel Just [Tue, 15 Oct 2024 21:19:48 +0000 (14:19 -0700)]
crimson: InternalClientRequests require that the pg is already active

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson/.../client_request: complete_request() only in with_pg_process
Samuel Just [Thu, 10 Oct 2024 00:59:20 +0000 (00:59 +0000)]
crimson/.../client_request: complete_request() only in with_pg_process

This avoids needing to annotate every exit point in
with_pg_process_interruptible with complete_request.  Regardless of the
result, completing with_pg_process_interruptible without an interruption
means that the request is over.

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson/.../client_request: always remove from orderer in complete_request
Samuel Just [Thu, 10 Oct 2024 00:42:36 +0000 (00:42 +0000)]
crimson/.../client_request: always remove from orderer in complete_request

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson/.../client_request: remove unnecessary get_handle().exit()
Samuel Just [Thu, 10 Oct 2024 00:39:08 +0000 (00:39 +0000)]
crimson/.../client_request: remove unnecessary get_handle().exit()

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson: rewrite with_[clone_]obc[_only] via manager, remove other helpers
Samuel Just [Sat, 26 Oct 2024 22:40:56 +0000 (15:40 -0700)]
crimson: rewrite with_[clone_]obc[_only] via manager, remove other helpers

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson: remove unused PG::with_locked_obc
Samuel Just [Thu, 3 Oct 2024 19:37:08 +0000 (12:37 -0700)]
crimson: remove unused PG::with_locked_obc

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson: convert PG::with_locked_obc users to use obc manager
Samuel Just [Thu, 3 Oct 2024 19:04:34 +0000 (19:04 +0000)]
crimson: convert PG::with_locked_obc users to use obc manager

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson: introduce RAII style obc lock mechanic
Samuel Just [Thu, 3 Oct 2024 00:41:34 +0000 (00:41 +0000)]
crimson: introduce RAII style obc lock mechanic

Currently, we rely on ObjectContextLoader::with_* wrappers to load,
lock, and guarrantee release of obcs.  That mechanism works well enough,
but the execution pathway is pretty tough to read as it spans
[Internal]ClientRequest, PG, ObjectContextLoader, ObjectContext, and
tri_mutex.  This mechanism cuts out PG and ObjectContext (mostly) and
uses coroutine support for auto variables to make the interface easier
to understand.

This mechanism will also allow a future PR to access the ObjectContext
state prior to loading it.  This will be important to using the
ObjectContext memory to host per-object pipeline states.

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson: track obcs unconditionally
Samuel Just [Thu, 3 Oct 2024 01:26:04 +0000 (18:26 -0700)]
crimson: track obcs unconditionally

Previously, we only interrupted head obcs.  I don't think that
distinction actually makes sense -- both head and clone obcs
can have ops blocked on the lock.  Let's just track them all.

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson: remove ObjectContextLoader::reload_obc
Samuel Just [Wed, 2 Oct 2024 23:35:03 +0000 (16:35 -0700)]
crimson: remove ObjectContextLoader::reload_obc

Unused.

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agocrimson/osd/object_context: add formatter for RWState::State
Samuel Just [Thu, 7 Nov 2024 02:32:17 +0000 (18:32 -0800)]
crimson/osd/object_context: add formatter for RWState::State

Signed-off-by: Samuel Just <sjust@redhat.com>
8 months agoMerge pull request #60600 from Matan-B/wip-matanb-crimson-enable-wait
Matan Breizman [Thu, 7 Nov 2024 16:12:08 +0000 (18:12 +0200)]
Merge pull request #60600 from Matan-B/wip-matanb-crimson-enable-wait

Revert "suites: crimson basic adding wait for test"

Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
8 months agoosd/scrub: fix 'schedule-deepscrub' test asok command 60661/head
Ronen Friedman [Wed, 6 Nov 2024 14:43:57 +0000 (08:43 -0600)]
osd/scrub: fix 'schedule-deepscrub' test asok command

The existing implementation of the 'schedule-deepscrub' Asok
command uses the set_last_deep_scrub_stamp() method to "fake"
the last-deep-scrub stamp. Unfortunately, this method also
updates the last-scrub stamp (as required for non-test usage).

Commit 9f3e18b fixed the comparator used when sorting the
scrub targets. An unintended side effect is that
following 'schedule-deepscrub' - the shallow target
is the one to be scrubbed next, instead of the deep target.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
8 months agoMerge pull request #56771 from nh2/doc-mclock-references
Kefu Chai [Thu, 7 Nov 2024 05:34:04 +0000 (13:34 +0800)]
Merge pull request #56771 from nh2/doc-mclock-references

doc: Document which options are disabled by mClock.

Reviewed-by: Kefu Chai <tchaikov@gmail.com>