]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
5 months agoqa/suites/nvmeof: use SCALING_DELAYS: '120' 61357/head
Vallari Agrawal [Tue, 4 Feb 2025 07:50:18 +0000 (13:20 +0530)]
qa/suites/nvmeof: use SCALING_DELAYS: '120'

Increase delays for qa/workunits/nvmeof/scalability_test.sh
as namespace rebalancing takes more time. After upscaling,
gateway initially could be 'CREATED', it is a valid state during
gateway initialization, but then the state should progress
to 'AVAILABLE' within couple of seconds.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
5 months agoqa/suites/nvmeof: Remove watchdog from thrasher
Vallari Agrawal [Thu, 30 Jan 2025 12:13:48 +0000 (17:43 +0530)]
qa/suites/nvmeof: Remove watchdog from thrasher

This commit does the following:
1. remove watchdog from thrasher
1. remove wait from fio_test
3. change thrasher switcher wait-time to 10 mins

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
5 months agoqa/tasks/nvmeof.py: Add teardown() method
Vallari Agrawal [Wed, 29 Jan 2025 15:34:04 +0000 (21:04 +0530)]
qa/tasks/nvmeof.py: Add teardown() method

Add teardown method to remove nvmeof service
before rest of the cluster tearsdown.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
5 months agoqa/tasks/nvmeof.py: Ignore systemctl_stop thrashing method
Vallari Agrawal [Tue, 28 Jan 2025 12:43:17 +0000 (18:13 +0530)]
qa/tasks/nvmeof.py: Ignore systemctl_stop thrashing method

Do not use systemctl_stop method to thrash daemons,
just use 'ceph orch daemon stop' and 'ceph orch daemon rm'
methods to thrash nvmeof gateways.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
5 months agoqa/tasks/nvmeof.py: Fix do_checks() method
Vallari Agrawal [Tue, 28 Jan 2025 09:18:15 +0000 (14:48 +0530)]
qa/tasks/nvmeof.py: Fix do_checks() method

All checks currently run on initator node, now
run all "ceph" commands on one of gateway hosts
instead of initator nodes. And run "nvme list"
and "nvme list-subsys" checks on initator node.

Add retry (5 times) to do_checks if any command fails.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
5 months agoqa/tasks/nvmeof.py: make seperate calls in do_checks()
Vallari Agrawal [Mon, 20 Jan 2025 11:43:44 +0000 (17:13 +0530)]
qa/tasks/nvmeof.py: make seperate calls in do_checks()

When running 'nvme list-subsys <device>' command
in do_checks(), instead of combining command for
all devices with '&&', make seperate calls.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
5 months agoqa/tasks/nvmeof.py: Do not use 'systemctl start' in thrasher
Vallari Agrawal [Tue, 14 Jan 2025 03:52:31 +0000 (09:22 +0530)]
qa/tasks/nvmeof.py: Do not use 'systemctl start' in thrasher

Instead use 'daemon start' in revive_daemon() to bring
up gateways thrashed with 'systemctl stop'.
This is because 'systemctl start' method seems to temporary
issues.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
5 months agoqa/workunits/nvmeof/fio_test.sh: fix fio filenames
Vallari Agrawal [Tue, 14 Jan 2025 03:49:03 +0000 (09:19 +0530)]
qa/workunits/nvmeof/fio_test.sh: fix fio filenames

Filenames were provided to fio as nvme1n1:nvme1n2,
it should be pull path (/dev/nvme1n1:/dev/nvme1n2).

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
5 months agoqa/tasks/nvmeof.py: Add stop_and_join method to thrasher
Vallari Agrawal [Mon, 13 Jan 2025 19:10:35 +0000 (00:40 +0530)]
qa/tasks/nvmeof.py: Add stop_and_join method to thrasher

Also add nvme-gw show command output in do_checks()
and revive daemons with 'ceph orch daemon start' in
revive_daemon() method.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
5 months agoqa: Add qa/suites/nvmeof/thrash/gateway-initiator-setup/2-subsys-8-namespace.yaml
Vallari Agrawal [Mon, 13 Jan 2025 09:39:39 +0000 (15:09 +0530)]
qa: Add qa/suites/nvmeof/thrash/gateway-initiator-setup/2-subsys-8-namespace.yaml

This allows to run nvmeof thrasher test on smaller
confgurations which finshes faster than 120subsys-8ns
config.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
5 months agoqa/tasks/nvmeof: Add --refresh flag in do_checks() cmds
Vallari Agrawal [Mon, 13 Jan 2025 09:33:27 +0000 (15:03 +0530)]
qa/tasks/nvmeof: Add --refresh flag in do_checks() cmds

This is to ensure latest state of the services are displayed.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
5 months agoMerge pull request #61540 from idryomov/wip-69679
Ilya Dryomov [Thu, 30 Jan 2025 10:23:16 +0000 (11:23 +0100)]
Merge pull request #61540 from idryomov/wip-69679

mon/OSDMonitor: relax cap enforcement for unmanaged snapshots

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 months agoMerge pull request #61471 from idryomov/wip-65889-more
Ilya Dryomov [Thu, 30 Jan 2025 08:38:29 +0000 (09:38 +0100)]
Merge pull request #61471 from idryomov/wip-65889-more

cls/rbd: don't use read API for write-like methods

Reviewed-by: Ramana Raja <rraja@redhat.com>
5 months agoMerge pull request #61545 from Hezko/nvmeof-cli-add-cmnds 60583/head
Hezko [Thu, 30 Jan 2025 07:07:27 +0000 (09:07 +0200)]
Merge pull request #61545 from Hezko/nvmeof-cli-add-cmnds

mgr/dashboard: Add additional API and CLI endpoints

5 months agoMerge pull request #61465 from ArbitCode/wip-raja-fix-multipart-upload-cant-get-obj-tag
Raja [Thu, 30 Jan 2025 06:29:44 +0000 (11:59 +0530)]
Merge pull request #61465 from ArbitCode/wip-raja-fix-multipart-upload-cant-get-obj-tag

RGW:fix obj by multipart upload cant get tag

5 months agoMerge pull request #61510 from dmick/container-no-repo-creds
Dan Mick [Wed, 29 Jan 2025 19:18:24 +0000 (11:18 -0800)]
Merge pull request #61510 from dmick/container-no-repo-creds

container/build.sh: don't require repo creds on NO_PUSH

5 months agoMerge pull request #61566 from zdover23/wip-doc-2025-01-30-cephadm-services-osd
Zac Dover [Wed, 29 Jan 2025 17:29:34 +0000 (03:29 +1000)]
Merge pull request #61566 from zdover23/wip-doc-2025-01-30-cephadm-services-osd

doc/cephadm: simplify confusing math proposition

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agoMerge pull request #61530 from aza547/ssl_cert
Adam King [Wed, 29 Jan 2025 16:28:18 +0000 (11:28 -0500)]
Merge pull request #61530 from aza547/ssl_cert

cephadm: rgw: allow specifying the ssl_certificate by filepath

Reviewed-by: Adam King <adking@redhat.com>
5 months agoMerge pull request #61511 from phlogistonjohn/jjm-ctr-label-ceph
Adam King [Wed, 29 Jan 2025 16:25:09 +0000 (11:25 -0500)]
Merge pull request #61511 from phlogistonjohn/jjm-ctr-label-ceph

container: add label ceph=True back

Reviewed-by: Adam King <adking@redhat.com>
5 months agoMerge pull request #61565 from AliMasarweh/wip-alimasa-bn-policy-with-tenant
Ali Masarwa [Wed, 29 Jan 2025 15:48:12 +0000 (17:48 +0200)]
Merge pull request #61565 from AliMasarweh/wip-alimasa-bn-policy-with-tenant

RGW | bucket notifications: support cross tenant operations

Reviewed-by: yuvalif<ylifshit@redhat.com>
5 months agoMerge pull request #61559 from linuxbox2/wip-new-zppbits
Matt Benjamin [Wed, 29 Jan 2025 14:50:35 +0000 (09:50 -0500)]
Merge pull request #61559 from linuxbox2/wip-new-zppbits

rgw: update to latest zpp_bits.h to compile w/gcc-14 & clang 19

5 months agoMerge pull request #60246 from jamiepryde/SIMD-align-64
SrinivasaBharathKanta [Wed, 29 Jan 2025 14:16:23 +0000 (19:46 +0530)]
Merge pull request #60246 from jamiepryde/SIMD-align-64

erasure-code: Increase SIMD_ALIGN from 32 to 64

5 months agoMerge pull request #59679 from ceph/add-new-ec-plugins-for-qa
SrinivasaBharathKanta [Wed, 29 Jan 2025 14:15:32 +0000 (19:45 +0530)]
Merge pull request #59679 from ceph/add-new-ec-plugins-for-qa

qa/erasure-code: add new teuthology isa configs

5 months agodoc/cephadm: simplify confusing math proposition 61566/head
Zac Dover [Wed, 29 Jan 2025 14:05:59 +0000 (00:05 +1000)]
doc/cephadm: simplify confusing math proposition

s/This means that the exact device size is 3.64 * 1000, or 3640GB"/This
means that the exact device size is 3.64TB, or 3640 GB"/

In the original text, the number "3.64" appears to refer to a quantity
(and indeed, it is a quantity of Terabytes), but it is unlabeled. Also,
on repeated recent readings of this sentence I found it more puzzling
than enlightening. So I made this commit.

Signed-off-by: Zac Dover <zac.dover@proton.me>
5 months agoRGW | bucket notifications: support cross tenant operations 61565/head
Ali Masarwa [Wed, 29 Jan 2025 12:09:22 +0000 (14:09 +0200)]
RGW | bucket notifications: support cross tenant operations

Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
5 months agoMerge pull request #61123 from rhcs-dashboard/raise-smb-msg-exception
Pedro Gonzalez Gomez [Wed, 29 Jan 2025 12:20:51 +0000 (13:20 +0100)]
Merge pull request #61123 from rhcs-dashboard/raise-smb-msg-exception

mgr/dashboard: smb raise exception for unsucessful resource update

Reviewed-by: Afreen Misbah <afreen@ibm.com>
5 months agoMerge pull request #61317 from rhcs-dashboard/add-smb-service-msg
afreen23 [Wed, 29 Jan 2025 09:28:37 +0000 (14:58 +0530)]
Merge pull request #61317 from rhcs-dashboard/add-smb-service-msg

mgr/dashboard: add warning message on smb service management

Reviewed-by: Afreen Misbah <afreen@ibm.com>
5 months agoMerge pull request #61033 from rhcs-dashboard/rgw-user-accounts-ui
Nizamudeen A [Wed, 29 Jan 2025 05:14:47 +0000 (10:44 +0530)]
Merge pull request #61033 from rhcs-dashboard/rgw-user-accounts-ui

mgr/dashboard: RGW user accounts UI

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
5 months agoMerge pull request #60819 from rhcs-dashboard/smb-cluster-form
afreen23 [Wed, 29 Jan 2025 05:09:22 +0000 (10:39 +0530)]
Merge pull request #60819 from rhcs-dashboard/smb-cluster-form

mgr/dashboard: create smb cluster

Reviewed-by: Afreen Misbah <afreen@ibm.com>
5 months agorgw: update to latest zpp_bits.h to compile w/gcc-14 & clang 19 61559/head
Matt Benjamin [Tue, 28 Jan 2025 20:07:06 +0000 (15:07 -0500)]
rgw: update to latest zpp_bits.h to compile w/gcc-14 & clang 19

Fixes: https://tracker.ceph.com/issues/69696
Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
5 months agoMerge pull request #61549 from zdover23/2025-01-28-radosgw-multisite
Zac Dover [Tue, 28 Jan 2025 18:10:00 +0000 (04:10 +1000)]
Merge pull request #61549 from zdover23/2025-01-28-radosgw-multisite

doc/radosgw: s/zonegroup/pools/

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agoMerge pull request #60735 from adk3798/cephadm-remove-daemon-service-name
Adam King [Tue, 28 Jan 2025 17:03:03 +0000 (12:03 -0500)]
Merge pull request #60735 from adk3798/cephadm-remove-daemon-service-name

mgr/cephadm: set service name for DaemonDescription object used during daemon removal

Reviewed-by: John Mulligan <jmulligan@redhat.com>
5 months agoMerge pull request #61215 from ArbitCode/wip-rgw-raja-feature-64526
Raja [Tue, 28 Jan 2025 16:30:26 +0000 (22:00 +0530)]
Merge pull request #61215 from ArbitCode/wip-rgw-raja-feature-64526

RGW:support x-amz-expected-bucket-owner to verify bucket ownership wi…

5 months agomgr/dashboard: smb raise exception for unsucessful resource update 61123/head
Pedro Gonzalez Gomez [Tue, 17 Dec 2024 20:08:55 +0000 (21:08 +0100)]
mgr/dashboard: smb raise exception for unsucessful resource update

Adds a decorator to raise a DashboardException with the msg error of an unsucessful smb resource update

Fixes: https://tracker.ceph.com/issues/69286
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
5 months agodoc/radosgw: s/zonegroup/pools/ 61549/head
Zac Dover [Tue, 28 Jan 2025 06:30:24 +0000 (16:30 +1000)]
doc/radosgw: s/zonegroup/pools/

s/zonegroup/pools/, where this change makes the text clearer.

This change was made in reponse to an upstream comment on
https://pad.ceph.com/p/Report_Documentation_Bugs.

Fixes: https://tracker.ceph.com/issues/69689
Signed-off-by: Zac Dover <zac.dover@proton.me>
5 months agomgr/dashboard: Add additional cli endpoints to align with existing nvmeof cli 61545/head
Tomer Haskalovitch [Wed, 15 Jan 2025 09:49:18 +0000 (11:49 +0200)]
mgr/dashboard: Add additional cli endpoints to align with existing nvmeof cli

Added new endpoints to ceph cli and dashboard API to align with cli commands that already exist in existing nvmeof cli.

fixes: https://tracker.ceph.com/issues/62705

Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MBP.lan>
5 months agoMerge pull request #61551 from leonidc/level_of_critical_mon_ev
leonidc [Tue, 28 Jan 2025 14:15:51 +0000 (16:15 +0200)]
Merge pull request #61551 from leonidc/level_of_critical_mon_ev

nvmeofgw*: change log level of critical nvmeof monitor events to 1

5 months agoMerge pull request #61449 from mohit84/issue_69405
Matan Breizman [Tue, 28 Jan 2025 10:29:43 +0000 (12:29 +0200)]
Merge pull request #61449 from mohit84/issue_69405

neorados_pool_test: Call create_pool at the end of NeoRados delete_pool related test

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
5 months agoosd/OSDCap: fix misleading grammar comments 61540/head
Ilya Dryomov [Mon, 27 Jan 2025 11:29:54 +0000 (12:29 +0100)]
osd/OSDCap: fix misleading grammar comments

The restrictions on pool name and namespace have been independent of
each other for ages.  Specifying namespace[=]<namespace> doesn't require
specifying pool[=]<pool> like is currently suggested -- neither for
regular "allow" grants nor for "profile" grants.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
5 months agomon/OSDMonitor: relax cap enforcement for unmanaged snapshots
Ilya Dryomov [Fri, 24 Jan 2025 19:47:11 +0000 (20:47 +0100)]
mon/OSDMonitor: relax cap enforcement for unmanaged snapshots

Since commit 4972e054b32c ("mon/OSDMonitor: enforce caps when
creating/deleting unmanaged snapshots"), a) write access to the MON
service, b) write access to the OSD service for a pool or c) permission
for "osd pool op unmanaged-snap" command for a pool is required.  For
"profile rbd" we configure read-only access to the MON service and rely
on write access to the OSD service, however the corresponding check in
is_osd_writable() is too strict.

A OSD cap like "profile rbd namespace=myns" or "allow w namespace=myns"
allows write access to myns namespace of any pool, but is_osd_writable()
disallows operations with unmanaged snapshots with such a cap because
its match.pool_namespace.pool_name.empty() is true.  This condition
appears to serve as the "doesn't include support for the application
tag" guard, but it should actually be match.pool_tag.is_match_all()
(or match.pool_tag.application.empty() if open-coded) -- no restriction
on the pool name doesn't automatically mean that there is a restriction
on the application tag.

Fixes: https://tracker.ceph.com/issues/69679
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
5 months agomgr/dashboard: create smb cluster 60819/head
Dnyaneshwari [Tue, 19 Nov 2024 07:01:52 +0000 (12:31 +0530)]
mgr/dashboard: create smb cluster

Fixes: https://tracker.ceph.com/issues/69156
Signed-off-by: Dnyaneshwari Talwekar <dtalwekar@redhat.com>
5 months agonvmeofgw*: change log level of critical nvmeof monitor events to 1 61551/head
Leonid Chernin [Tue, 28 Jan 2025 08:23:38 +0000 (08:23 +0000)]
nvmeofgw*: change log level of critical nvmeof monitor events to 1

Signed-off-by: Leonid Chernin <leonidc@il.ibm.com>
5 months agoAllow passing ssl_certificate as an rgw_frontend_extra_arg. 61530/head
aza547 [Sun, 26 Jan 2025 18:10:59 +0000 (18:10 +0000)]
Allow passing ssl_certificate as an rgw_frontend_extra_arg.

Fixes: https://tracker.ceph.com/issues/69567
Signed-off-by: Alexander Hussein-Kershaw <alexhus@microsoft.com>
fix markup

5 months agoMerge pull request #61392 from Hezko/nvmeof-gw-info-cli
Hezko [Mon, 27 Jan 2025 17:53:58 +0000 (19:53 +0200)]
Merge pull request #61392 from Hezko/nvmeof-gw-info-cli

Dashboard: Introduce nvmeof cli commands

5 months agoMerge PR #60996 into main
Venky Shankar [Mon, 27 Jan 2025 16:23:25 +0000 (21:53 +0530)]
Merge PR #60996 into main

* refs/pull/60996/head:
mds/SimpleLock: add is_xlocked_by()
mds/SimpleLock: add has_xlock_by()

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
5 months agoMerge PR #61250 into main
Venky Shankar [Mon, 27 Jan 2025 16:20:40 +0000 (21:50 +0530)]
Merge PR #61250 into main

* refs/pull/61250/head:
mds: avoid acquiring the wrlock twice for a single request
mds: add 'mds_allow_async_dirops' opt to allow/disable async dirop

Reviewed-by: Venky Shankar <vshankar@redhat.com>
5 months agoMerge PR #61327 into main
Venky Shankar [Mon, 27 Jan 2025 16:19:27 +0000 (21:49 +0530)]
Merge PR #61327 into main

* refs/pull/61327/head:
client: Fix signed comparison warning

Reviewed-by: John Mulligan <jmulligan@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
5 months agoMerge pull request #60935 from rhcs-dashboard/smb-cluster-delete
Pedro Gonzalez Gomez [Mon, 27 Jan 2025 12:38:38 +0000 (13:38 +0100)]
Merge pull request #60935 from rhcs-dashboard/smb-cluster-delete

mgr/dashboard: delete smb cluster

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Afreen Misbah <afreen@ibm.com>
5 months agoMerge pull request #60993 from MaxKellermann/types__backward_backward
Ilya Dryomov [Mon, 27 Jan 2025 11:03:13 +0000 (12:03 +0100)]
Merge pull request #60993 from MaxKellermann/types__backward_backward

include/types.h, tools/cephfs: remove _BACKWARD_BACKWARD_WARNING_H

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
5 months agomgr/dashboard: Introduce nvmeof cli 61392/head
Tomer Haskalovitch [Wed, 15 Jan 2025 09:49:18 +0000 (11:49 +0200)]
mgr/dashboard: Introduce nvmeof cli

Extends ceph cli with nvmeof commands

fixes: https://tracker.ceph.com/issues/62705

Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MBP.lan>
5 months agomgr/dashboard: delete smb cluster 60935/head
Dnyaneshwari [Wed, 4 Dec 2024 05:51:11 +0000 (11:21 +0530)]
mgr/dashboard: delete smb cluster
Fixes: https://tracker.ceph.com/issues/69191
       https://tracker.ceph.com/issues/69605

Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>
5 months agoMerge pull request #57895 from rhcs-dashboard/kcli-multi-cluster
Nizamudeen A [Mon, 27 Jan 2025 06:41:18 +0000 (12:11 +0530)]
Merge pull request #57895 from rhcs-dashboard/kcli-multi-cluster

mgr/dashboard: adapt kcli plan to improve multi-cluster deployment

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
5 months agoMerge pull request #61382 from nbalacha/dashboard-typo
Nizamudeen A [Mon, 27 Jan 2025 05:46:00 +0000 (11:16 +0530)]
Merge pull request #61382 from nbalacha/dashboard-typo

mgr/dashboard: Typo in NVMe-oF create service

Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
5 months agoMerge pull request #61525 from zdover23/wip-doc-2025-01-26-cephadm-host-management
Zac Dover [Sun, 26 Jan 2025 16:32:51 +0000 (02:32 +1000)]
Merge pull request #61525 from zdover23/wip-doc-2025-01-26-cephadm-host-management

doc/cephadm: correct note

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agoMerge pull request #61506 from ronen-fr/wip-rf-scrub-formatters
Ronen Friedman [Sun, 26 Jan 2025 07:51:31 +0000 (09:51 +0200)]
Merge pull request #61506 from ronen-fr/wip-rf-scrub-formatters

osd/scrub: use ObjectSection & ArraySection
Reviewed-by: Samuel Just <sjust@redhat.com>
5 months agodoc/cephadm: correct note 61525/head
Zac Dover [Sun, 26 Jan 2025 05:11:16 +0000 (15:11 +1000)]
doc/cephadm: correct note

Correct the English in a note in doc/cephadm/host-management.rst.

This commit was made in response to
https://github.com/ceph/ceph/pull/50340, which corrected some of this
note in Quincy.

Signed-off-by: Zac Dover <zac.dover@proton.me>
5 months agoMerge pull request #61520 from idryomov/wip-osdcap-syntax-doc
Ilya Dryomov [Sat, 25 Jan 2025 17:49:05 +0000 (18:49 +0100)]
Merge pull request #61520 from idryomov/wip-osdcap-syntax-doc

doc/rados: pool and namespace are independent osdcap restrictions

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agoMerge pull request #61503 from zdover23/wip-doc-2025-01-24-cephfs-disaster-recovery...
Zac Dover [Sat, 25 Jan 2025 17:06:43 +0000 (03:06 +1000)]
Merge pull request #61503 from zdover23/wip-doc-2025-01-24-cephfs-disaster-recovery-experts

doc/cephfs: edit disaster-recovery-experts (6 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agodoc/cephfs: edit disaster-recovery-experts (6 of x) 61503/head
Zac Dover [Fri, 24 Jan 2025 13:46:19 +0000 (23:46 +1000)]
doc/cephfs: edit disaster-recovery-experts (6 of x)

In doc/cephfs/disaster-recovery-experts.rst, incorporate Anthony's
suggestions in

https://github.com/ceph/ceph/pull/61462#discussion_r1923917812
and
https://github.com/ceph/ceph/pull/61462#discussion_r1923920724

and reword the sentences in the section "Using an alternate metadata
pool for recovery" to be in the imperative mood, which better suits the
ordered list format that was introduced in
https://github.com/ceph/ceph/pull/61493.

Follows https://github.com/ceph/ceph/pull/61493.

https://tracker.ceph.com/issues/69557

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
5 months agodoc/rados: pool and namespace are independent osdcap restrictions 61520/head
Ilya Dryomov [Sat, 25 Jan 2025 10:11:14 +0000 (11:11 +0100)]
doc/rados: pool and namespace are independent osdcap restrictions

For the "profile {name}" syntax, pool and namespace restrictions are
independent of each other (i.e. specifying namespace doesn't also
require specifying pool like is currently suggested).  A cap can look
like "profile rbd namespace=myns", signifying that the RBD profile is
to be allowed in myns namespace of any pool.

For the "allow {access-spec}" syntax, pool restriction is optional.
A cap can look like "allow r namespace=myns", "allow w object_prefix
myprefix" or "allow rw namespace=myns object_prefix myprefix", for
example.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
5 months agoMerge pull request #61477 from caroav/caroav-update-nvmeof-docs
Zac Dover [Sat, 25 Jan 2025 09:37:28 +0000 (19:37 +1000)]
Merge pull request #61477 from caroav/caroav-update-nvmeof-docs

doc/rbd: update nvme docs

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agodoc/rbd: Update nvme documentation 61477/head
Aviv Caro [Tue, 31 Dec 2024 13:45:14 +0000 (15:45 +0200)]
doc/rbd: Update nvme documentation

Signed-off-by: Aviv Caro <133020857+caroav@users.noreply.github.com>
Update nvmeof-requirements.rst

Signed-off-by: Aviv Caro <133020857+caroav@users.noreply.github.com>
Update nvmeof-initiator-linux.rst

Signed-off-by: Aviv Caro <133020857+caroav@users.noreply.github.com>
Update nvmeof-initiator-esx.rst

Signed-off-by: Aviv Caro <133020857+caroav@users.noreply.github.com>
Update nvmeof-target-configure.rst

Signed-off-by: Aviv Caro <133020857+caroav@users.noreply.github.com>
doc/rbd: fix broken .rst

Fix .rst errors introduced in https://github.com/ceph/ceph/pull/61477.
This commit will be squashed.

Signed-off-by: Zac Dover <zac.dover@proton.me>
5 months agoMerge pull request #61492 from idryomov/wip-69619
Ilya Dryomov [Fri, 24 Jan 2025 19:51:32 +0000 (20:51 +0100)]
Merge pull request #61492 from idryomov/wip-69619

librbd: clear ctx before initiating close in Image::{aio_,}close()

Reviewed-by: Ramana Raja <rraja@redhat.com>
5 months agocontainer: add label ceph=True back 61511/head
John Mulligan [Tue, 21 Jan 2025 21:28:42 +0000 (16:28 -0500)]
container: add label ceph=True back

Add a label used by cephadm internally that was always set by
ceph-container [1] back to the new containerfile. This should
prevent issues with cephadm shell command thinking official ceph images
are not official ceph images.

[1] https://github.com/ceph/ceph-container/blob/30dc8b9a55f70a40983fd2da6ac31e1b9e977143/src/__DOCKERFILE_TRACEABILITY_LABELS__#L5

Signed-off-by: John Mulligan <jmulligan@redhat.com>
5 months agocontainer/build.sh: don't require repo creds on NO_PUSH 61510/head
Dan Mick [Fri, 24 Jan 2025 19:00:28 +0000 (11:00 -0800)]
container/build.sh: don't require repo creds on NO_PUSH

Signed-off-by: Dan Mick <dan.mick@redhat.com>
5 months agoRGW:fix obj by multipart upload cant get tag 61465/head
Raja Sharma [Tue, 21 Jan 2025 09:55:59 +0000 (15:25 +0530)]
RGW:fix obj by multipart upload cant get tag
Fixes: https://tracker.ceph.com/issues/53016
Signed-off-by: Raja Sharma <raja@ibm.com>
5 months agoosd/scrub: use ObjectSection & ArraySection 61506/head
Ronen Friedman [Fri, 24 Jan 2025 16:37:34 +0000 (10:37 -0600)]
osd/scrub: use ObjectSection & ArraySection

Use the RAII wrappers for the dump Formatters,
instead of manually opening and closing sections.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
5 months agoMerge pull request #61351 from ronen-fr/wip-rf-no-load
Ronen Friedman [Fri, 24 Jan 2025 16:01:29 +0000 (18:01 +0200)]
Merge pull request #61351 from ronen-fr/wip-rf-no-load

osd/scrub: increase the default scrub load limit

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 months agoMerge pull request #61493 from zdover23/wip-doc-2025-01-23-cephfs-disaster-recovery...
Zac Dover [Fri, 24 Jan 2025 09:03:44 +0000 (19:03 +1000)]
Merge pull request #61493 from zdover23/wip-doc-2025-01-23-cephfs-disaster-recovery-experts

doc/cephfs: edit disaster-recovery-experts (5 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agoMerge pull request #61396 from ShwetaBhosale1/fix_issue_69541_after_nvmeof_deployment...
Adam King [Thu, 23 Jan 2025 19:25:11 +0000 (14:25 -0500)]
Merge pull request #61396 from ShwetaBhosale1/fix_issue_69541_after_nvmeof_deployment_10008_port_not_opened

mgr/cephadm: After deploying nvmeof gateway group, the prometheus port 10008/tcp is not opened

Reviewed-by: Adam King <adking@redhat.com>
5 months agoMerge pull request #61293 from adk3798/ceph-exporter-sock-dir
Adam King [Thu, 23 Jan 2025 19:24:19 +0000 (14:24 -0500)]
Merge pull request #61293 from adk3798/ceph-exporter-sock-dir

cephadm: fix handling of ceph-exporter sock-dir

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
5 months agoMerge pull request #60943 from anuradhagadge/fix_69081_ca_cert_with_fsid
Adam King [Thu, 23 Jan 2025 19:22:04 +0000 (14:22 -0500)]
Merge pull request #60943 from anuradhagadge/fix_69081_ca_cert_with_fsid

mgr/cephadm: Changes for creating root cert with manager cluster fsid

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
5 months agoMerge pull request #60858 from Kushal-deb/fix_issue_2097853-upgrade_status_message
Adam King [Thu, 23 Jan 2025 19:20:34 +0000 (14:20 -0500)]
Merge pull request #60858 from Kushal-deb/fix_issue_2097853-upgrade_status_message

cephadm: ceph orch upgrade status - Display easily understandable message

Reviewed-by: Adam King <adking@redhat.com>
5 months agoMerge pull request #60842 from ShwetaBhosale1/fix_issue_68979_command_to_upgrade_non_...
Adam King [Thu, 23 Jan 2025 19:19:30 +0000 (14:19 -0500)]
Merge pull request #60842 from ShwetaBhosale1/fix_issue_68979_command_to_upgrade_non_ceph_daemon_images

mgr/cephadm: Command to upgrade non-ceph image services with custom image

Reviewed-by: Adam King <adking@redhat.com>
5 months agoMerge pull request #60590 from JoshuaGabriel/joshua_67905
Adam King [Thu, 23 Jan 2025 19:18:23 +0000 (14:18 -0500)]
Merge pull request #60590 from JoshuaGabriel/joshua_67905

mgr/cephadm: Retry command when SSH connection closes

Reviewed-by: Adam King <adking@redhat.com>
5 months agoMerge pull request #61467 from rhcs-dashboard/revert-cdsModal
Pedro Gonzalez Gomez [Thu, 23 Jan 2025 19:13:41 +0000 (20:13 +0100)]
Merge pull request #61467 from rhcs-dashboard/revert-cdsModal

mgr/dashboard: revert ModalCdsService for uncarbonized pool form

Reviewed-by: nmunet <nmunet@redhat.com>
5 months agoMerge pull request #61233 from anoopcs9/rm-stray-backslash
Adam King [Thu, 23 Jan 2025 19:05:24 +0000 (14:05 -0500)]
Merge pull request #61233 from anoopcs9/rm-stray-backslash

script/ceph-backport: Remove stray `\` from grep command

Reviewed-by: Adam King <adking@redhat.com>
5 months agoMerge pull request #61258 from guits/cv-hints
Guillaume Abrioux [Thu, 23 Jan 2025 11:57:13 +0000 (12:57 +0100)]
Merge pull request #61258 from guits/cv-hints

ceph-volume: type annotations

5 months agoMerge pull request #61253 from Matan-B/wip-matanb-crimson-tri_mutex_pointer
Matan Breizman [Thu, 23 Jan 2025 10:47:26 +0000 (12:47 +0200)]
Merge pull request #61253 from Matan-B/wip-matanb-crimson-tri_mutex_pointer

crimson/common/tri_mutex: improve logging

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Aishwarya Mathuria <amathuri@redhat.com>
5 months agoMerge pull request #56446 from guojidan/metrics
Matan Breizman [Thu, 23 Jan 2025 10:42:25 +0000 (12:42 +0200)]
Merge pull request #56446 from guojidan/metrics

crimson/mgr/client.cc: daemon_health_metrics support

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
5 months agodoc/cephfs: edit disaster-recovery-experts (5 of x) 61493/head
Zac Dover [Thu, 23 Jan 2025 09:49:26 +0000 (19:49 +1000)]
doc/cephfs: edit disaster-recovery-experts (5 of x)

Put the procedure in the section called "Using an alternate metadata
pool for recovery" into an ordered list, so that it is in a proper
procedure format.

This commit is meant only to break the procedure into steps. The English
language in each of these steps could be improved, but that improvement
will be done after this formatting has been merged and backported.

Follows https://github.com/ceph/ceph/pull/61462.

https://tracker.ceph.com/issues/69557

Signed-off-by: Zac Dover <zac.dover@proton.me>
5 months agoMerge pull request #61489 from dmick/wip-fix-container-tags
Dan Mick [Thu, 23 Jan 2025 02:57:57 +0000 (18:57 -0800)]
Merge pull request #61489 from dmick/wip-fix-container-tags

container/build.sh: fix up org vs. repo naming

5 months agocontainer/build.sh: fix up org vs. repo naming 61489/head
Dan Mick [Thu, 23 Jan 2025 02:28:15 +0000 (18:28 -0800)]
container/build.sh: fix up org vs. repo naming

release builds were using the wrong container repo name because of
confused variable naming and inadequate separation.  Keep the hostname,
org name, and repo name in separate variables, and assemble the full
path with a version when tagging is done.

Signed-off-by: Dan Mick <dan.mick@redhat.com>
5 months agolibrbd: clear ctx before initiating close in Image::{aio_,}close() 61492/head
Ilya Dryomov [Wed, 22 Jan 2025 19:34:11 +0000 (20:34 +0100)]
librbd: clear ctx before initiating close in Image::{aio_,}close()

Image::aio_close() must clear ctx before initiating close.  Otherwise
the provided callback may see a non-NULL ctx and attempt to close the
image again from Image destructor, leading to an invalid memory access
as ImageCtx and ImageState are both freed immediately after the image
is closed (i.e. before AioCompletion is completed and the callback is
executed).

The same adjustment is made to Image::close() just for consistency.

Fixes: https://tracker.ceph.com/issues/69619
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
5 months agoMerge pull request #57997 from guojidan/migration-child
Ilya Dryomov [Wed, 22 Jan 2025 18:46:41 +0000 (19:46 +0100)]
Merge pull request #57997 from guojidan/migration-child

test/librbd: add unit test for flatten migration

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
5 months agoMerge pull request #61277 from lightmelodies/rgw
J. Eric Ivancich [Wed, 22 Jan 2025 15:50:23 +0000 (10:50 -0500)]
Merge pull request #61277 from lightmelodies/rgw

rgw/lc: make lc worker thread name shorter

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
5 months agoMerge pull request #60800 from rkachach/fix_issue_deps_refactoring
Adam King [Wed, 22 Jan 2025 13:18:37 +0000 (08:18 -0500)]
Merge pull request #60800 from rkachach/fix_issue_deps_refactoring

mgr/cephadm: Refactoring and consolidating services dependencies calculation logic

Reviewed-by: Adam King <adking@redhat.com>
5 months agoMerge pull request #61462 from zdover23/wip-doc-2025-01-21-cephfs-disaster-recovery...
Zac Dover [Wed, 22 Jan 2025 11:57:08 +0000 (21:57 +1000)]
Merge pull request #61462 from zdover23/wip-doc-2025-01-21-cephfs-disaster-recovery-experts

doc/cephfs: edit disaster-recovery-experts (4 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agomgr/dashboard: Added unit tests and fixed minor issues 61033/head
Naman Munet [Fri, 10 Jan 2025 11:46:39 +0000 (17:16 +0530)]
mgr/dashboard: Added unit tests and fixed minor issues

Fixes: https://tracker.ceph.com/issues/69140
Signed-off-by: Naman Munet <naman.munet@ibm.com>
5 months agomgr/dashboard: Delete account integrated
Naman Munet [Wed, 8 Jan 2025 07:41:58 +0000 (13:11 +0530)]
mgr/dashboard: Delete account integrated

Fixes: https://tracker.ceph.com/issues/69140
Signed-off-by: Naman Munet <naman.munet@ibm.com>
5 months agomgr/dashboard: account edit functionality added
Naman Munet [Tue, 7 Jan 2025 19:20:32 +0000 (00:50 +0530)]
mgr/dashboard: account edit functionality added

Fixes: https://tracker.ceph.com/issues/69140
Signed-off-by: Naman Munet <naman.munet@ibm.com>
5 months agomgr/dashboard: added Create Account Functionality
Naman Munet [Thu, 26 Dec 2024 11:48:03 +0000 (17:18 +0530)]
mgr/dashboard: added Create Account Functionality

Fixes: https://tracker.ceph.com/issues/69140
Signed-off-by: Naman Munet <naman.munet@ibm.com>
5 months agomgr/dashboard: RGW user accounts UI
Naman Munet [Mon, 9 Dec 2024 11:40:17 +0000 (17:10 +0530)]
mgr/dashboard: RGW user accounts UI

--> Integrated list endpoint

Fixes: https://tracker.ceph.com/issues/69140
Signed-off-by: Naman Munet <namanmunet@li-ff83bccc-26af-11b2-a85c-a4b04bfb1003.ibm.com>
5 months agoMerge pull request #61436 from soumyakoduri/wip-skoduri-dbstore
Soumya Koduri [Wed, 22 Jan 2025 09:35:34 +0000 (15:05 +0530)]
Merge pull request #61436 from soumyakoduri/wip-skoduri-dbstore

rgw/dbstore: Update bucket attrs as part of put_info()

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
5 months agoMerge pull request #60647 from soumyakoduri/wip-skoduri-lc-crash
Soumya Koduri [Wed, 22 Jan 2025 09:35:01 +0000 (15:05 +0530)]
Merge pull request #60647 from soumyakoduri/wip-skoduri-lc-crash

rgw: Add object expirer API to the SAL interface

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
5 months agotest/librbd: add unit test for flatten migration 57997/head
junxiang Mu [Wed, 11 Sep 2024 03:06:18 +0000 (11:06 +0800)]
test/librbd: add unit test for flatten migration

Fixes: https://tracker.ceph.com/issues/65743
Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: junxiang Mu <1948535941@qq.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
5 months agoMerge pull request #59050 from mohit84/issue_67270
Yuri Weinstein [Wed, 22 Jan 2025 00:53:51 +0000 (16:53 -0800)]
Merge pull request #59050 from mohit84/issue_67270

mon: Create a local copy of scrub_state to avoid a crash

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 months agocls/rbd: don't use read API for write-like methods 61471/head
Ilya Dryomov [Tue, 21 Jan 2025 20:07:08 +0000 (21:07 +0100)]
cls/rbd: don't use read API for write-like methods

This is a follow-up for commit af176311c476 (objclass: change objclass
exec read calls to write ones where needed) which missed mirror_uuid_set
and raced with the addition of mirror_remote_namespace_set.

Fixes: https://tracker.ceph.com/issues/65889
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
5 months agoMerge pull request #60984 from ljflores/wip-fix-telemetry-tests
Laura Flores [Tue, 21 Jan 2025 20:09:11 +0000 (14:09 -0600)]
Merge pull request #60984 from ljflores/wip-fix-telemetry-tests

qa/suites/upgrade/telemetry-upgrade: update telemetry tests

5 months agoMerge pull request #61007 from kamoltat/wip-ksirivad-fix-68602
Yuri Weinstein [Tue, 21 Jan 2025 18:56:39 +0000 (10:56 -0800)]
Merge pull request #61007 from kamoltat/wip-ksirivad-fix-68602

qa/tasks/thrashosds-health.yaml: Add osds down to ignorelist

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>