mgr/dashboard: Add 'Browse Dashboards' button in Grafana dashboards

Fixes: https://tracker.ceph.com/issues/69727
Signed-off-by: Piyush Agarwal <piyushagarwal14.pa@gmail.com>

Merge pull request #61040 from rhcs-dashboard/smb-module-check

mgr/module: Smb module check

Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>

Merge pull request #61445 from zdover23/wip-doc-2025-01-19-cephfs-disaster-recovery-experts

doc/cephfs: disaster-recovery-experts cleanup

doc/cephfs: disaster-recovery-experts cleanup

Properly wrap a poorly-formatted paragraph that looks just awful in an
80-column viewport and change MDS to "MDS daemons" where the latter
makes the sentence a lot clearer.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61427 from zdover23/wip-doc-2025-01-17-cephfs-disaster-recovery-experts-2

doc/cephfs: edit disaster-recovery-experts (2 of x)

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephfs: edit disaster-recovery-experts (2 of x)

Edit the third and fourth sections of
doc/cephfs/disaster-recovery-experts.rst in preparation for adding
deeper explanations of the contexts in which one should use the various
commands listed on that page.

Follows https://github.com/ceph/ceph/pull/61426

https://tracker.ceph.com/issues/69557

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61426 from zdover23/wip-doc-2025-01-17-cephfs-disaster-recovery-experts

doc/cephfs: remove link to undeveloped tool

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #61440 from zdover23/wip-doc-2025-01-18-backport-61429-to-squid

doc/releases: edit warning for balancer issues

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/releases: edit warning for balancer issues

Rephrase the balancer-related warning issued to people upgrading to
Ceph 19.2.0.

Follows https://github.com/ceph/ceph/pull/61429

Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61429 from laimis9133/squid-doc-patch

doc/releases /squid: add warning for balancer issues

Merge pull request #61407 from clwluvw/replication-status

rgw: update attrs with replication status to reflect in response

Reviewed-by: Alex Wojno <awojno@bloomberg.net>

Merge pull request #61406 from clwluvw/checkpoint-dstbucket

rgw: set dest bucket id in bucket sync checkpoint

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #61271 from clwluvw/datasync-usermode-err

rgw: set retcode on verify_bucket_permission in RGWObjFetchCR

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #61157 from aiivashchenko/fix_68195

rgw: add missing last_modified field to swift api

Reviewed-by: Casey Bodley <cbodley@redhat.com>

doc/releases/squid: add warning for balancer issues

This change is to update 19.2.0 Squid release documentation with a warning for users regarding potential placement group balancer issues.

Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>

Merge pull request #61387 from yuvalif/wip-yuval-69473

test/rgw/lua: install luarocks

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #59143 from Sean10/fix_rados_pybind_zero_param

pybind/rados: fix the incorrect order of offset,length in WriteOp.zero

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #61384 from sj14/sj/delete-policy-204

rgw: S3 Delete Bucket Policy should return 204 on success

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #61370 from yehudasa/wip-69536

rgw: RGWRados::get_olh() needs to use the correct attr

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #61285 from cbodley/wip-69462

rgw: /admin/user api dumps account-related user info

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>

Merge pull request #61244 from awojno-bloomberg/fix-bucket-sync-status

rgw: fix radosgw-admin use after free in bucket sync status

Reviewed-By: Adam Emerson <aemerson@ibm.com>
Reviewed-By: Oguzhan Ozmen <oozmen@bloomberg.net>

doc/cephfs: remove link to undeveloped tool

Remove a link to a tracker for a planned-but-never-developed tool that
would have facilitated the importation or exportation of a RADOS pool to
a file. This is a part of a project to improve the CephFS Disaster
Recovery documentation, which was requested by Eugen Block. See the
tracker issue below for more on this project.

Follows https://github.com/ceph/ceph/pull/61411

See https://github.com/ceph/ceph/pull/61411#discussion_r1918525109

https://tracker.ceph.com/issues/69557

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61411 from zdover23/wip-doc-2025-01-16-cephfs-disaster-recovery-experts

doc/cephfs: edit disaster-recovery-experts

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #59155 from badone/wip-tracker-67489-fixed-4-for-verify

qa/suites: Make fixed-4 an option for verify tests

Merge pull request #60556 from aclamk/wip-aclamk-bluefs-truncate-allocations-main

os/bluestore: Make truncate() drop unused allocations - addendum

Merge pull request #60363 from aclamk/wip-aclamk-fix-bluefs-bdev-expand

os/bluestore: Create additional bdev labels when expanding block device.

Merge pull request #61369 from laimis9133/patch-2

doc/radosgw/config-ref: fix lifecycle workload tuning description

Merge pull request #61412 from gbregman/main

mgr/cephadm/nvmeof: Add SPDK iobuf options field to NVMeOF configuration

Merge pull request #60265 from MaxKellermann/timeout_round_up

msg/async: round timeouts up (fix busy loops)

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>

Merge pull request #48539 from chrisphoffman/wip-57864

qa/tasks: Include stderr on tasks badness check

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

mgr/cephadm/nvmeof: Add SPDK iobuf options field to NVMeOF configuration
Fixes https://tracker.ceph.com/issues/69554

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>

test/rgw/lua: install luarocks

since it is only a suggestion for debian.
this is a regression from: https://github.com/ceph/ceph/pull/60666

Fixes: https://tracker.ceph.com/issues/69473
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #61393 from abhishek-kane/mapping_email

Add Abhishek Kane into peoplemap, githubmap, organizationmap, mailmap

Reviewed-by: Adam King <adking@redhat.com>

doc/cephfs: edit disaster-recovery-experts

Edit the first two sections of doc/cephfs/disaster-recovery-experts.rst
in preparation for adding deeper explanations of the contexts in which
one should use the various commands listed on that page.

https://tracker.ceph.com/issues/69557

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61349 from VallariAg/wip-vallari-nvmeof-ceph-version

mon: do not show nvmeof in 'ceph versions' output

Merge pull request #60889 from anoopcs9/fix-invalid-access-mds

mds: Fix invalid access of mdr->dn[0].back()

Add Abhishek Kane into peoplemap, githubmap, organizationmap, mailmap

Signed-off-by: abhishek-kane <abhishek.kane@ibm.com>

mon: do not show nvmeof in 'ceph versions' output

NVMeoF gateway version is independent of ceph version
so 'ceph version' shows wrong nvmeof version in output
(i.e. instead of gateway version, it shows Ceph version).
Hence, remove nvmeof in 'ceph versions' output.

To check for gateway version, use 'gw info' command.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>

Merge pull request #61218 from dmick/wip-containerfile-ceph-version

container/Containerfile: replace CEPH_VERSION label for backward compat

rgw: update attrs with replication status to reflect in response

In handle_replication_status_header() when the COMPLETED status is
being set to object's attr, it needs to be reflected to the current
live attrs for the corresponding request so it can be reflected in
the first try than the second.

Fixes: https://tracker.ceph.com/issues/69549
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

rgw: set dest bucket id in bucket sync checkpoint

bucket_source_sync_checkpoint() requires bucket id to lookup for
full-sync object and the dest pipe doesn't have it. by replcaning
the bucket key in the pipe with the bucket info we will ensure the
bucket id is set.

Fixes: https://tracker.ceph.com/issues/69548
Signed-off-by: Seena Fallah <seenafallah@gmail.com>

Merge pull request #60847 from cbodley/wip-rgw-boto-headbucket-stats

examples/rgw: register boto extension for HeadBucket stats

Reviewed-by: Seena Fallah <seenafallah@gmail.com>

Merge pull request #61211 from yuvalif/wip-yuval-logging-tenant

rgw/logging: add more validations to conf, cross tenant support and cleanup

Reviewed-By: Adam Emerson <aemerson@ibm.com>, Ali Masarwe <ali.masarwa@ibm.com>

Merge pull request #61373 from anthonyeleven/fix-file-descriptions

AsyncMessenger.cc : improve error messages

Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61289 from ronen-fr/wip-rf-catcher-fix

common: fix md_config_cacher_t
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

rgw: S3 Delete Bucket Policy should return 204 on success

Currently, RGW returns a 200 on a successful DELETE on a bucket policy but
the S3 API expects a 204:

    https://docs.aws.amazon.com/AmazonS3/latest/API/API_DeleteBucketPolicy.html

The sample response in the example above is a 204.

This patch checks the op_ret in `RGWDeleteBucketPolicy::send_response()`
and on a success we turn it to a 204 (or STATUS_NO_CONTENT).

Fixes: https://tracker.ceph.com/issues/69539
Signed-off-by: Simon Jürgensmeyer <simon.juergensmeyer@hetzner-cloud.de>

Merge pull request #61072 from pecastro/doc_and_test_fixes

Doc and test fixes

AsyncMessenger.cc : improve error messages

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

qa/tasks: Include stderr on tasks badness check.

Make sure that first_in_ceph_log() doesn't return None (which is
treated as success/"no badness" by the caller) if the cluster log file
is missing.

Fixes: https://tracker.ceph.com/issues/57864
Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Christopher Hoffman <choffman@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rgw: RGWRados::get_olh() needs to use the correct attr

Fixes: https://tracker.ceph.com/issues/69536
Signed-off-by: Yehuda Sadeh <ysadehwe@ibm.com>

doc/radosgw/config-ref: fix lifecycle workload tuning description

This commit updates RGW Config Reference - Lifecycle Settings section. In particular it changes the section where two different tunings for two different workloads are suggested. It aims for a more understandable description as asked by the contributors.

Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>

Merge pull request #59739 from sabaini/fix/ceph-volume-ep

[ceph-volume] fix importlib.metadata compat

Reviewed-by: Guillaume Abrioux <gabrioux@ibm.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #60073 from mkogan1/wip-fix-rate-lim

rgw: fix user rate limit is not enforced w/ global rate limit set

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #61322 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence_ostringstream_fix

common/io_exerciser: Ensure empty stringstream in ceph_test_rados_io_sequence RadosIO between ReST calls

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

qa/scrub: more delay when waiting for noscrub to take effect

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #61352 from zdover23/wip-doc-2025-01-14-releases-quincy-eol

doc/releases: add actual_eol for quincy

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

common: config_cacher: use set::contains() instead of count()

moved out of the main commit to
facilitate backporting it to pre-C++20.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

qa/scrub: change 'bin/ceph' to 'ceph'

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

common: fix md_config_cacher_t

In its get_tracked_conf_keys() member function, the
cacher (in the existing code) initializes a static
function-block variable ('keys'), and uses it for
registering the observer.

But the cacher is instantiated on the type of
the configuration value. Thus, multiple cacher
objects for which the configuration values are
of the same type - share the static 'keys'. Only
one of the observers is registered.

Note that the code could have been simplified
somewhat, if the signature of the
get_tracked_conf_keys() function
was changed to return 'const char* const *'.

Fixes: https://tracker.ceph.com/issues/69236
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #61314 from aclamk/wip-aclamk-bluefs-truncate-fix

os/bluestore: Fix BlueFS::truncate()

Merge pull request #61261 from xxhdx1985126/wip-seastore-lba-backref-mapping

crimson/os/seastore: refactor LBAMapping

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #60215 from MaxKellermann/osd_optimizations

OSD: Small optimizations

Merge pull request #61312 from adamemerson/wip-boost-1.86-fixes

{mgr, rbd, tests/os}: Fixes for Boost 1.86

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #61284 from shraddhaag/wip-shraddhaag-fix-rados-monthrash

rados/monthrash: add PG_DEGRADED to ignorelist

doc/releases: add actual_eol for quincy

Add the actual EOL date for the Quincy release (it's 2025-01-13).

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61311 from zdover23/wip-doc-2025-01-10-releases-remove-quincy-from-active

doc/releases: remove Quincy from "Active"

Reviewed by: Laura Flores <lflores@redhat.com>
Reviewed-by: Yuri Weinstein <yweinste@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #61208 from Yonatan-Zaken/restore_selinux_context_when_writing_remote_files_on_host

mgr/cephadm: Restore client file(s) default SELinux context type

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #61099 from rkachach/fix_issue_69252

mgr/cephadm: fixing logic in cert-store save_cert method

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #61035 from ShwetaBhosale1/fix_issue_69192_getting_error_if_yaml_file_has_trailing_tab

mgr/cephadm: mgr orchestrator module raise exception if there is trailing tab in yaml file

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #60888 from ShwetaBhosale1/fix_issue_69070_only_bind_ports_on_network_parameter_spec_for_alertmanager

mgr/cephadm: Add only_bind_ports_on_network spec parameter for Alertmanager

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #60828 from rkachach/fix_prometheus_targets_discovery_mtls

mgr/cephadm: fixing config files for prometheus and alertmanager

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #60690 from ShwetaBhosale1/fix_issue_68695_ceph_orch_commands_does_not_work_for_deployment_name_osd

mgr/cephadm:  ceph orch <start/stop/restart> commands should work for service name osd  and command to updated service name for osd

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #58604 from adk3798/cephadm-rgw-no-multisite-traffic

mgr/cephadm: allow disabling rgw_run_sync_thread through spec

Reviewed-by: Redouane Kachach <rkachach@ibm.com>

common/io_exerciser: Reorder lines in RadosIo send_command functions

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>

librbd/migration/HttpClient: Use asio::ssl::stream

`beast::ssl_stream` is deprecated as of 1.86, and its loss of the move
constructor keeps it from compiling on that version.

Hopefully this passes tests on 1.85, too, or it will have to wait
until the boost bump.

Signed-off-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #61272 from laimis9133/main

doc/radosgw/config-ref: fix lc worker thread tuning

Merge pull request #58924 from imtzw/tzw_ikey_lat

os/bluestore: record omapiter init latency

Reviewed-by: Igor Fedotov <ifedotov@suse.com>

Merge pull request #57617 from Matan-B/wip-matanb-fix-python-warnings

test/pybind/test_rados.py: fix warnings

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #60278 from rzarzynski/wip-os-fastomapiter

os, osd: bring the lightweight OMAP iteration

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
Reviewed-by: Mark Kogan <mkogan@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

common/io_exerciser: Clear the stringstream in RadosIO class

Ensures the stringstream is empty before sending a command in the RadosIO class

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>

Merge pull request #61000 from MaxKellermann/no_boost

Use `std` instead of Boost

Merge pull request #61278 from VallariAg/wip-vallari-nvmeof-alerts-update

monitoring: Update nvmeof alert limits in config

os/bluestore: Fix BlueFS::truncate()

In `struct bluefs_fnode_t` there is a vector `extents` and
the vector `extents_index` that is a log2 seek cache.

Until modifications to truncate() we never removed extents from files.
Modified truncate() did not update extents_index.

For example 10 extents long files when truncated to 0 will have:
0 extents, 10 extents_index.
After writing some data to file:
1 extents, 11 extents_index.

Now, `bluefs_fnode_t::seek` will binary search extents_index,
lets say it located seek at item #3.
It will then jump up from #0 extent (that exists) to #3 extent which
does not exist at.
The worst part is that code is now broken, as #3 != extent.end().

There are 3 parts of the fix:
1) assert in `bluefs_fnode_t::seek` to protect against
   jumping outside extents
2) code in BlueFS::truncate to sync up `extents_index` with `extents`
3) dampening down assert in _replay to give a way out of cases
   where incorrect "offset 12345" (12345 is file size) instead of
   "offset 20000" (allocations occupied) was written to log.

Fixes: https://tracker.ceph.com/issues/69481
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>

Merge pull request #60762 from ljflores/wip-tracker-67181

qa/suites/rados/verify/validater: ignore OSD_DOWN

Merge pull request #60261 from MaxKellermann/PyModule_no_lock

mgr/PyModule: do not lock in get_name(), get_error_string()

rgw/logging: clean pending objects

* when source bucket is deleted
* when logging is disabled
* when logging conf changes
* when target bucket is deleted

also add "bucket logging info" admin command
returning logging conf for source bucket, and list
of source buckets for log bucket

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

rgw/logging: retry attribuite set in case of race

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

rgw/logging: log bucket must not have encryption

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

rgw/logging: source and log bucket must be different

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

rgw/logging: support source and destination buckets on different tenants

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

mgr: Work around bug in Boost MPI/Python

Thanks to the maintainers of the Arch User Repository Ceph PKGBUILD
for this fix.

Signed-off-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #60958 from xxhdx1985126/wip-69120

crimson/osd/backfill_state: recheck whether needs to scan the primary at the end of Enqueuing::Enqueuing

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #60803 from xxhdx1985126/wip-69027

crimson/osd/replicate_backend: add standalone delete to the push queue if the object is deleted while it's being backfilled

Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #60795 from taodd/fix-rbd-sparsify-on-ec-image-slow

osd: optimize extent comparison in PrimaryLogPG

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #61313 from VallariAg/wip-vallari-teuthology-docs

doc: improve tests-integration-testing-teuthology-workflow.rst

Merge pull request #61291 from cbodley/wip-69470

doc/rgw: document UserName requirements for account migration

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #55259 from linuxbox2/wip-object-attributes

rgw: implement GetObjectAttributes

Merge pull request #60969 from idryomov/wip-69135

qa/suites/upgrade/reef-x: sync log-ignorelist with quincy-x

Reviewed-by: Laura Flores <lflores@ibm.com>
Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #60081 from anthonyeleven/anthonyeleven/tweak

src/exporter: improve usage message

rgw_attrs: fixes for 3 more iam/perms mappings

Help from Pritha and Casey appreciated

Plus, fix 3 explicit mapping tests in test_rgw_iam_policy.cc.

Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>