rbd-mirror: fix possible recursive lock of ImageReplayer::m_lock

If periodic status update (LambdaContext which is queued from
handle_update_mirror_image_replay_status()) races with shutdown and
ends up being the last in-flight operation that shutdown was pending
on, we attempt to recursively acquire m_lock in shut_down() because
m_in_flight_op_tracker.finish_op() is called with m_lock (and also
m_threads->timer_lock) held.  These locks are needed only for the call
to schedule_update_mirror_image_replay_status() and should be unlocked
immediately.

Fixes: https://tracker.ceph.com/issues/69978
Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: N Balachandran <nithya.balachandran@ibm.com>

Merge pull request #61827 from tchaikov/python3.12-on-ubuntu-noble

do_cmake: use Python 3.12 on ubuntu >= 24

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #61794 from MaxKellermann/cls__includes

cls: add missing includes

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #61608 from MaxKellermann/mon_includes

mon: include cleanup

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #61618 from ronen-fr/wip-rf-perf-sections

common/perf_counters: use the RAII helpers when dumping

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #61678 from phlogistonjohn/jjm-bwc-fixes-1

build-with-container fixes exec bit, dnf cache dir option

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>

cls/numops: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

cls/rbd: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

cls/cephfs: add missing forward declaration

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

cls/2pc_queue: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

journal: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

do_cmake: use Python 3.12 on ubuntu >= 24

the "official" Python shipped along with Ubuntu 24.04 (Noble Numbat) is
Python 3.12. And some of our building have been upgraded to Ubuntu
24.04. But we are still using Python 3.10 on Ubuntu >= 22, this breaks
the build. And CMake fails like:

```
CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Python3 (missing: Python3_EXECUTABLE Python3_INCLUDE_DIRS
  Python3_LIBRARIES Interpreter Development Development.Module
  Development.Embed) (Required is exact version "3.10")

      Reason given by package:
          Interpreter: Wrong version for the interpreter "/bin/python3"

Call Stack (most recent call first):
  /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  cmake/modules/FindPython/Support.cmake:3863 (find_package_handle_standard_args)
  cmake/modules/FindPython3.cmake:545 (include)
  CMakeLists.txt:597 (find_package)
```

This build failure should also happen on developers who build Ceph on
Ubuntu >= 24.

In this change, we use Python 3.12 on Ubuntu >= 24

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #61768 from idryomov/wip-69911

librbd: fix mirror image status summary in a namespace

Reviewed-by: N Balachandran <nibalach@redhat.com>

Merge pull request #61698 from afreen23/wip-fix-nsapi

mgr/dashboard: (refactor)fix image size in nvmeof namespace create/update api

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #61734 from rhcs-dashboard/delete-storage-class

mgr/dashboard: RGW - Delete storage class

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

common/perf_counters: use the RAII helpers when dumping

Using Formatter::ObjectSection & Formatter::ArraySection
to guarantee consistent dump sections opening & closing.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge PR #61763 into main

* refs/pull/61763/head:
pybind/mgr/mgr_module: turn off all automatic transactions

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #61688 from dmick/wip-ceph-release-docs

doc/dev/release-process.rst: release builds cannot build containers

Merge PR #61680 into main

* refs/pull/61680/head:
mds: do not schedule quiesce for non-head imported inodes

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge PR #61675 into main

* refs/pull/61675/head:
qa: do read checks with non-empty file

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #61700 from MaxKellermann/rgw_includes

rgw: add missing includes

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #60791 from Jayaprakash-ibm/jaya-branch

blk/kernel : Make bdev stop immediately

Reviewed-by : Adam Kupczyk <akupczyk@ibm.com>
Reviewed-by : Igor Fedotov <igor.fedotov@croit.io>

Merge pull request #56925 from ifed01/wip-ifed-dencoder-crc32

tools/ceph-dencoder: introduce add_crc32c command to append crc32 for…

Reviewed-by: Md Mahamudur Rahaman Sajib <mahamudur.sajib@croit.io>

Merge pull request #61428 from rhcs-dashboard/fix-69575-main

mgr/dashboard: fix service/daemon events not showing up in service details

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #61769 from Matan-B/wip-matanb-clang-14-only

script/lib-build: Use clang 14

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #61089 from pecastro/mgr_proto_build_generation

pybind/mgr: Protobuffer file generation for grpc deps.

Reviewed-by: baum <NOT@FOUND>
Reviewed-by: ceph-jenkins <NOT@FOUND>
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>

mon/ConfigMonitor: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/MonMap: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/mon_types: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/MDSMonitor: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/PGMap: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/FSCommands: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/Monitor: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/Paxos: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/ConfigMap: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/MonClient: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/MgrMap: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/Session: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

mon/ElectionLogic: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

krbd: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

Merge pull request #60994 from MaxKellermann/formatter

Formatter code cleanup

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #61759 from yuvalif/wip-yuval-boto-example-bucket-param

rgw/notification/logging: add bucket as context param

Merge pull request #60305 from MaxKellermann/blk_interface

blk/CMakeLists.txt: generate interface library if `libblk` is disabled

Reviewed-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #61699 from MaxKellermann/crimson_includes

crimson/backref_entry: add missing includes

Reviewed-By: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #61705 from MaxKellermann/neorados_includes

neorados: include cleanup

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #61775 from yuvalif/wip-yuval-fix-loggin-obj-name

rgw/logging: flush command should print flushed log object name

mgr/dashboard: RGW - Delete Storage Class

Fixes: https://tracker.ceph.com/issues/69880
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>

doc/dev/release-process.rst: release builds cannot build containers

Document that container images are not built by the ceph-build job,
but must be done manually after the package signing and upload
to download.ceph.com.

Signed-off-by: Dan Mick <dan.mick@redhat.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #61746 from adamemerson/wip-boost.1.87-fixes

Boost 1.87 Build Fixes

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #60995 from MaxKellermann/messages__includes

messages/*: add missing includes

Merge pull request #61418 from cbodley/wip-rgw-multisite-sync-delta-counters

rgw: add labeled counters for sync deltas of shards

Reviewed-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #61290 from BBoozmen/wip-oozmen-67846

RGW/S3: truncate S3 LastModified response (timestamp) to exact seconds

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #61009 from cbodley/wip-69169

rgw/rados: resolve CopyObject crash from remote zonegroup

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>

Merge pull request #61090 from soumyakoduri/wip-skoduri-cloud-restore

rgw/cloud-restore: Do not send internal headers to cloud-endpoint

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #61358 from richardpoole/main

rgw: allow management of `accounts` user caps

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #61573 from clwluvw/log-new-req-id

rgw: log request_id on start new request

Reviewed-by: Casey Bodley <cbodley@redhat.com>

mgr/dashboard: fix image size in nvmeof namespace create/update api

- Different name is used in POST and PATCH for `rbd_image_size`
- Using same name in both requests
- fixing typing issues in frontend

Fixes https://tracker.ceph.com/issues/69864

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #60175 from MaxKellermann/misc_optimizations

Misc optimizations

rgw/logging: flush command should print flushed log object name

and not the next pending log object name

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #61621 from joscollin/wip-B69669-fix-exception-smaller-pad-width

cephfs-top: exception when terminal size greater than PAD_WIDTH

Reviewed-by: Venky Shankar <vshankar@redhat.com>

script/lib-build: Use clang 14

In attempt to update to clang16 some of the code is not yet adapted
due to deprecated functions.
Let's disable clang 16 usage until https://github.com/ceph/ceph/pull/61740
is merged.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

qa/workunits/rbd: use create_image_and_enable_mirror() in bootstrap tests

The reason create_image() + enable_mirror() happens to work for
PARENT_POOL is that PARENT_POOL is enabled for mirroring in image mode
unconditionally, unlike POOL, POOL/NS1 or PARENT_POOL/NS1 for which
MIRROR_POOL_MODE setting is respected.  This isn't immediately obvious
because it's done in setup_pools() in rbd_mirror_helpers.sh.

Switch to create_image_and_enable_mirror() for clarity.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

rbd: don't clone ioctx before calling get_mirror_peer_sites()

get_mirror_peer_sites() transitions to the default namespace
internally, doing it in advance at the call sites is redundant.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd: fix mirror image status summary in a namespace

For the purposes of the summary with image counts, "rbd mirror pool
status" command is supposed to count each image only once.  To this
end, for unidirectional mirroring the status of the receiving site
should be taken while for bidirectional mirroring the statuses should
be combined/reduced.  For example, if mirroring is enabled on a single
image and everything is in order, the summary is expected to be

  image health: OK
  images: 1 total
      1 replaying

on both clusters even though on the primary the local status is
MIRROR_IMAGE_STATUS_STATE_STOPPED and only on the secondary it's
MIRROR_IMAGE_STATUS_STATE_REPLAYING.

Currently this isn't the case for custom namespaces.  In the same
scenario the primary ends up reporting

  image health: OK
  images: 1 total
      1 stopped

based solely on the local status in a namespace.

Fixes: https://tracker.ceph.com/issues/69911
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #61695 from MaxKellermann/tools_includes

tools: add missing includes

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #61723 from ljflores/wip-tracker-67913

pybind/mgr/mgr_module: turn off all automatic transactions

I misunderstood autocommit=False in prior patches. The sqlite3 binding will
still create transactions automatically which confused newer bindings using
autocommit.

So, turn off automatic transaction management completely to maintain backwards
compatibility.

Fixes: https://tracker.ceph.com/issues/69912
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

cephfs-top: exception when terminal size greater than PAD_WIDTH

Fixes: https://tracker.ceph.com/issues/69669
Signed-off-by: Jos Collin <jcollin@redhat.com>

Merge pull request #61758 from anthonyeleven/taipoh

doc/rados/operations: Improve pools.rst

Merge pull request #61607 from MaxKellermann/mgr_includes

mgr: include cleanup

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge PR #61755 into main

* refs/pull/61755/head:
script/clean-ci: allow specifying custom remote name to push/fetch
script/clean-ci: do not push if there is nothing to delete

Reviewed-by: David Galloway <dgallowa@redhat.com>

doc/rados/operations: Improve pools.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #61326 from adamemerson/wip-69240

os/bluestore: Fix signed comparison warning

Merge pull request #60123 from aclamk/wip-aclamk-cbt-add-bluefs-files

os/bluestore: Add 'bluefs-files' command to ceph-bluestore-tool.

Merge pull request #60120 from aclamk/wip-aclamk-improve-rocksdb-estimate-prefix

kv/RocksDBStore: Improve estimate_prefix_size.

script/clean-ci: allow specifying custom remote name to push/fetch

Github actions want to use remote==origin because of how ceph-ci is checked
out.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

script/clean-ci: do not push if there is nothing to delete

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #61742 from anthonyeleven/rgw-inlining

Improve rgw_max_chunk_size descriptions with respect to HEAD inlining

Merge PR #61709 into main

* refs/pull/61709/head:
script: add bash script to cleanup ceph-ci.git

Reviewed-by: David Galloway <dgallowa@redhat.com>

Merge PR #61662 into main

* refs/pull/61662/head:
qa: cut squid nightlies to one-per-week

Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>

Merge pull request #60909 from ifed01/wip-ifed-client-cache-trim-repro

libcephfs/client: pin inode/dentry for an opened directory

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #60103 from gardran/wip-gardran-no-autovec

kv/BinnedLRUCache: do not use autovector to track deleted cache entries.

Merge pull request #61743 from cbodley/wip-revert-stale-bot-backport

Revert ".github/workflows: Do not exempt PRs with milestone"

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Joseph Mundackal <jmundackal@bloomberg.net>

Merge pull request #61183 from rhcs-dashboard/smb-join_auth-usersgroups-mgmt

mgr/dashboard: smb join-auth and usersgroups resources listing

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #59943 from majianpeng/blk-iouring-busy

blk: Don't forget call io_uring_unregister_files.

Merge pull request #61456 from cyx1231st/wip-fix-crimson-net-66606

crimson/net/io_handler: drop io_state_t::none

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #61741 from cityofships/main

docs/mgr: fix typo

qa: cut squid nightlies to one-per-week

Now that it's released, we should go back to typical release branch cadence
(teuthology queue is also growing).

Also, update the priority (ahead of reef) now that it's released.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

tests/ceph_timer: Fix link error that keeps showing up

We keep hitting link errors from GTest trying to print the values and
iostreams for `<chrono>` being flaky.

Just make it a straight up `EXPECT_TRUE` so it stops breaking
differently on different platforms.

Signed-off-by: Adam Emerson <aemerson@redhat.com>

Merge pull request #61736 from phlogistonjohn/jjm-cephadm-test-list_daemons

cephadm: add a new set of specific tests for list_daemons

Reviewed-by: Adam King <adking@redhat.com>

exporter: Asio deprecations

Signed-off-by: Adam Emerson <aemerson@redhat.com>

rgw: Asio deprecations

Signed-off-by: Adam Emerson <aemerson@redhat.com>

immutable_object_cache: Asio deprecations

Signed-off-by: Adam Emerson <aemerson@redhat.com>

test/neorados: Use `asio::post` free function

Signed-off-by: Adam Emerson <aemerson@redhat.com>

common/Graylog: Fix Asio resolve call

Signed-off-by: Adam Emerson <aemerson@redhat.com>

src/common/options: improve rgw_max_chunk_size description

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

rgw/notification/logging: add bucket as context param

when URI has the form: "/{Bucket}?<action>"
the "Bucket" parameter has to be added as context parameter for
botocore based clients to send the operation as a bucket
operation

Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>

Merge pull request #61601 from phlogistonjohn/jjm-cephadm-small-moves-2

cephadm: move a few other small things out of cephadm.py

Reviewed-by: Adam King <adking@redhat.com>

Revert ".github/workflows: Do not exempt PRs with milestone"

This reverts commit 6054be59c56a13670abd7d00b828d43730c535c8.

Signed-off-by: Casey Bodley <cbodley@redhat.com>

script: add bash script to cleanup ceph-ci.git

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>