]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 months agoinstall-deps.sh: enable crb repository for centos 10 stream 61949/head
John Mulligan [Thu, 13 Feb 2025 21:00:27 +0000 (16:00 -0500)]
install-deps.sh: enable crb repository for centos 10 stream

The centos 10 stream distribution is like centos 9 and needs the crb
repository enabled to even think about building ceph. Note that I made
it a separate block in case more stuff needs to be added for it later.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
4 months agodo_cmake.sh: specify correct python version for centos 10 stream
John Mulligan [Thu, 13 Feb 2025 20:59:58 +0000 (15:59 -0500)]
do_cmake.sh: specify correct python version for centos 10 stream

Update the python version in the same tedious manner for centos 10
stream.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #60610 from rzarzynski/wip-no-getval-on-osd-stats
Laura Flores [Wed, 19 Feb 2025 19:13:02 +0000 (13:13 -0600)]
Merge pull request #60610 from rzarzynski/wip-no-getval-on-osd-stats

osd: avoid costly md_config_t::get_val<>() when preparing stats

4 months agoMerge pull request #61408 from adk3798/cephadm-nvmeof-more-group-validation
Adam King [Wed, 19 Feb 2025 18:04:42 +0000 (13:04 -0500)]
Merge pull request #61408 from adk3798/cephadm-nvmeof-more-group-validation

mgr/cephadm: validate no duplicate groups and group vs. service id for nvmeof

Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61778 from adk3798/cephadm-double-quotes-nfs-recovery-backend
Adam King [Wed, 19 Feb 2025 18:02:44 +0000 (13:02 -0500)]
Merge pull request #61778 from adk3798/cephadm-double-quotes-nfs-recovery-backend

mgr/cephadm: use double quotes for NFSv4 RecoveryBackend in ganesha conf

Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61694 from rkachach/fix_issue_69863
Adam King [Wed, 19 Feb 2025 18:00:09 +0000 (13:00 -0500)]
Merge pull request #61694 from rkachach/fix_issue_69863

mgr/cephadm: reconfig rgw and ingress daemons when certificate changes

Reviewed-by: Adam King <adking@redhat.com>
4 months agoMerge pull request #61890 from zhscn/fix-clang-19
Matan Breizman [Wed, 19 Feb 2025 17:55:29 +0000 (19:55 +0200)]
Merge pull request #61890 from zhscn/fix-clang-19

crimson: fix compile errors in clang 19

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge pull request #61765 from Kushal-deb/fix_orch_ls_to_display_smb_ports
Adam King [Wed, 19 Feb 2025 17:51:00 +0000 (12:51 -0500)]
Merge pull request #61765 from Kushal-deb/fix_orch_ls_to_display_smb_ports

cephadm: ceph orch ls to Display SMB Service Ports

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61749 from rhcs-dashboard/sqlite-recursive-error-fix
Adam King [Wed, 19 Feb 2025 16:13:26 +0000 (11:13 -0500)]
Merge pull request #61749 from rhcs-dashboard/sqlite-recursive-error-fix

mgr/smb: add threading lock for SqliteStore

Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61833 from Kushal-deb/add_v4v6_flag_to_bind_port
Adam King [Wed, 19 Feb 2025 16:10:34 +0000 (11:10 -0500)]
Merge pull request #61833 from Kushal-deb/add_v4v6_flag_to_bind_port

cephadm: ingress- Add v4v6 flag to HAProxy bind directive

Reviewed-by: Adam King <adking@redhat.com>
4 months agoMerge pull request #61722 from adk3798/stop-orch-on-cleanup
Adam King [Wed, 19 Feb 2025 16:06:48 +0000 (11:06 -0500)]
Merge pull request #61722 from adk3798/stop-orch-on-cleanup

qa/cephadm: stop cephadm mgr module during cleanup

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
4 months agoMerge pull request #61663 from adk3798/vrrp_interfaces_typo
Adam King [Wed, 19 Feb 2025 15:58:06 +0000 (10:58 -0500)]
Merge pull request #61663 from adk3798/vrrp_interfaces_typo

mgr/cephadm: fix typo with vrrp_interfaces in keepalive setup

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
4 months agoMerge pull request #61658 from ShwetaBhosale1/fix_issue_69808_numric_node_id_for_rado...
Adam King [Wed, 19 Feb 2025 15:56:56 +0000 (10:56 -0500)]
Merge pull request #61658 from ShwetaBhosale1/fix_issue_69808_numric_node_id_for_rados_kv_block

mgr/nfs: nodeid should be numeric for RADOS_KV block in ganesha.conf file

Reviewed-by: Adam King <adking@redhat.com>
4 months agoMerge pull request #61587 from Kushal-deb/display_comma_separated_ports_for_RGW_services
Adam King [Wed, 19 Feb 2025 15:55:20 +0000 (10:55 -0500)]
Merge pull request #61587 from Kushal-deb/display_comma_separated_ports_for_RGW_services

mgr/cephadm: Display comma separated ports for RGW services

Reviewed-by: Adam King <adking@redhat.com>
4 months agoMerge pull request #61564 from Sodani/shsodani_profile
Adam King [Wed, 19 Feb 2025 15:53:56 +0000 (10:53 -0500)]
Merge pull request #61564 from Sodani/shsodani_profile

mgr/smb: Add profiling configuration to global definition

Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61372 from adk3798/cephadm-orch-pause-test-failure
Adam King [Wed, 19 Feb 2025 15:51:20 +0000 (10:51 -0500)]
Merge pull request #61372 from adk3798/cephadm-orch-pause-test-failure

qa/cephadm: wait between starting and restarting osd in test_daemon_restart test

Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #60606 from Naveenaidu/naveen/telemetry-add-stretch-cluster
Laura Flores [Wed, 19 Feb 2025 15:51:06 +0000 (09:51 -0600)]
Merge pull request #60606 from Naveenaidu/naveen/telemetry-add-stretch-cluster

mgr/telemetry: add stretch cluster data

4 months agoMerge pull request #61853 from ArbitCode/wip-rgw-raja-remove-clientid-oidc-provider
Raja [Wed, 19 Feb 2025 14:52:05 +0000 (20:22 +0530)]
Merge pull request #61853 from ArbitCode/wip-rgw-raja-remove-clientid-oidc-provider

rgw/iam: add RemoveClientIDFromOpenIDConnectProvider

4 months agocrimson: fix -Wmissing-template-arg-list-after-template-kw 61890/head
Matan Breizman [Mon, 17 Feb 2025 10:08:11 +0000 (10:08 +0000)]
crimson: fix -Wmissing-template-arg-list-after-template-kw

See: https://github.com/llvm/llvm-project/commit/f46d1463b835560d90ad3ac02b63c771e4ebe566
```
common/interruptible_future.h:1182:16: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
 1182 |     ).template handle_interruption(std::move(efunc));
      |                ^
1 error generated.
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agocrimson/common/operation: fix decltype usage
Matan Breizman [Mon, 17 Feb 2025 10:00:34 +0000 (10:00 +0000)]
crimson/common/operation: fix decltype usage

```
ceph/src/crimson/common/operation.cc
In file included from /home/matan/ceph/src/crimson/common/operation.cc:4:
/home/matan/ceph/src/crimson/common/operation.h:312:31: error: no member named 'events' in 'AggregateBlockingEvent<T>'
  312 |       typename decltype(event.events)::iterator iter;
      |                         ~~~~~ ^
1 error generated.
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agocrimson/tools/perf_crimson_msgr: fix unused-lamda-capture
Matan Breizman [Mon, 17 Feb 2025 10:05:22 +0000 (10:05 +0000)]
crimson/tools/perf_crimson_msgr:  fix unused-lamda-capture

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agocrimson/osd: move the destructor of OpsExecuter to ops_executer.cc
Zhang Song [Wed, 19 Feb 2025 09:30:15 +0000 (17:30 +0800)]
crimson/osd: move the destructor of OpsExecuter to ops_executer.cc

Signed-off-by: Zhang Song <zhangsong02@qianxin.com>
4 months agoMerge pull request #60286 from salieri11/igolikov-wip-bug-64611
Igor Golikov [Wed, 19 Feb 2025 10:20:31 +0000 (12:20 +0200)]
Merge pull request #60286 from salieri11/igolikov-wip-bug-64611

mds: enforce usage of host error in cephfs, use errorcode32_t in MClientReply message
Fixes: https://tracker.ceph.com/issues/64611
4 months agoMerge pull request #61690 from rhcs-dashboard/bucket-tiering
Aashish Sharma [Wed, 19 Feb 2025 06:39:39 +0000 (12:09 +0530)]
Merge pull request #61690 from rhcs-dashboard/bucket-tiering

mgr/dashboard: bucket lifecycle policy management

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
4 months agoMerge pull request #60205 from Rethan/bluestore-aio-submit-retries
SrinivasaBharathKanta [Wed, 19 Feb 2025 03:14:15 +0000 (08:44 +0530)]
Merge pull request #60205 from Rethan/bluestore-aio-submit-retries

os/bluestore: make retry_max and initial_delay configurable for aio s…

4 months agorgw/iam: add RemoveClientIDFromOpenIDConnectProvider 61853/head
Raja Sharma [Mon, 17 Feb 2025 18:37:20 +0000 (00:07 +0530)]
rgw/iam: add RemoveClientIDFromOpenIDConnectProvider

Signed-off-by: Raja Sharma <raja@ibm.com>
Fixes : https://tracker.ceph.com/issues/70015

5 months agoMerge pull request #61347 from xxhdx1985126/wip-seastore-tree-pointer-abstract
Yingxin Cheng [Wed, 19 Feb 2025 01:28:29 +0000 (09:28 +0800)]
Merge pull request #61347 from xxhdx1985126/wip-seastore-tree-pointer-abstract

crimson/os/seastore: refactor fixed-kv-btree

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
5 months agoMerge pull request #61837 from anthonyeleven/osd-svc
Anthony D'Atri [Wed, 19 Feb 2025 01:21:45 +0000 (20:21 -0500)]
Merge pull request #61837 from anthonyeleven/osd-svc

doc/cephadm/services: Improve osd.rst

5 months agoMerge pull request #61883 from anthonyeleven/rgw-into-intro
Anthony D'Atri [Wed, 19 Feb 2025 00:57:07 +0000 (19:57 -0500)]
Merge pull request #61883 from anthonyeleven/rgw-into-intro

doc/start: Mention RGW in Intro to Ceph

5 months agodoc/cephadm/services: Improve osd.rst 61837/head
Anthony D'Atri [Sun, 16 Feb 2025 21:01:15 +0000 (16:01 -0500)]
doc/cephadm/services: Improve osd.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
5 months agoMerge pull request #61867 from anuradhagadge/doc_ca_cert_with_fsid
Zac Dover [Tue, 18 Feb 2025 23:53:24 +0000 (09:53 +1000)]
Merge pull request #61867 from anuradhagadge/doc_ca_cert_with_fsid

doc/mgr: Add root CA cert instructions to rgw.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
5 months agodoc/start: Mention RGW in Intro to Ceph 61883/head
Anthony D'Atri [Tue, 18 Feb 2025 21:31:47 +0000 (16:31 -0500)]
doc/start: Mention RGW in Intro to Ceph

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
5 months agoMerge pull request #61762 from liu-chunmei/compress_extentmap
Liu-Chunmei [Tue, 18 Feb 2025 18:50:29 +0000 (10:50 -0800)]
Merge pull request #61762 from liu-chunmei/compress_extentmap

os/bluestore: fix do_write_v2 extentmap compress issue

do_write_v2 insert extentmap by aligned offset which is adjusted in writer.do_write, if use original offset will cause extentmap can't do compress.

Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
5 months agomgr/dashboard: add bucket tiering option to create lifecycle policy 61690/head
Naman Munet [Fri, 7 Feb 2025 06:53:07 +0000 (12:23 +0530)]
mgr/dashboard: add bucket tiering option to create lifecycle policy

Fixes: https://tracker.ceph.com/issues/69649
Signed-off-by: Naman Munet <naman.munet@ibm.com>
5 months agoMerge pull request #61478 from rhcs-dashboard/critical-confirmation-modal-changes
afreen23 [Tue, 18 Feb 2025 16:30:11 +0000 (22:00 +0530)]
Merge pull request #61478 from rhcs-dashboard/critical-confirmation-modal-changes

mgr/dashboard: Add confirmation textbox for resource name on delete action

Reviewed-by: Afreen Misbah <afreen@ibm.com>
5 months agoMerge pull request #61871 from rhcs-dashboard/fix-70019-main
Ernesto Puerta [Tue, 18 Feb 2025 16:25:49 +0000 (17:25 +0100)]
Merge pull request #61871 from rhcs-dashboard/fix-70019-main

mgr/dashboard: fix Python xmlsec build issue

Reviewed-by: @afreen23
Reviewed-by: @aaSharma14
5 months agoMerge pull request #61847 from idryomov/wip-63798
Ilya Dryomov [Tue, 18 Feb 2025 16:19:27 +0000 (17:19 +0100)]
Merge pull request #61847 from idryomov/wip-63798

test/rbd_mirror: flush watch/notify callbacks in TestImageReplayer

Reviewed-by: Vinay Bhaskar Varada <vvarada@redhat.com>
5 months agoMerge pull request #61756 from dang/wip-dang-68336
Daniel Gryniewicz [Tue, 18 Feb 2025 15:00:44 +0000 (10:00 -0500)]
Merge pull request #61756 from dang/wip-dang-68336

RGW - Fix POSIX bucket notify test

5 months agodoc/mgr: edit grammar and formatting of rgw.rst 61867/head
Zac Dover [Tue, 18 Feb 2025 13:44:15 +0000 (23:44 +1000)]
doc/mgr: edit grammar and formatting of rgw.rst

Improve the grammar and correct the formatting of the "Upgrading root ca
certificates" procedure that was added to the documentation in https://github.com/ceph/ceph/pull/61867

Fixes: https://tracker.ceph.com/issues/70014
Signed-off-by: Zac Dover <zac.dover@proton.me>
5 months agoMerge pull request #61214 from aclamk/wip-aclamk-bs-fragmentation-health
Adam Kupczyk [Tue, 18 Feb 2025 14:24:33 +0000 (15:24 +0100)]
Merge pull request #61214 from aclamk/wip-aclamk-bs-fragmentation-health

os/bluestore: Add health warning for bluestore fragmentation

5 months agoMerge pull request #58752 from Matan-B/wip-matanb-replicated-backend-50608
Laura Flores [Tue, 18 Feb 2025 14:20:37 +0000 (08:20 -0600)]
Merge pull request #58752 from Matan-B/wip-matanb-replicated-backend-50608

5 months agodoc/mgr: Add root CA cert instructions to rgw.rst
Anuradha Gadge [Tue, 18 Feb 2025 09:09:31 +0000 (14:39 +0530)]
doc/mgr: Add root CA cert instructions to rgw.rst

Add documentation for adding fs_id in root_ca_cert upgrade path

Fixes: https://tracker.ceph.com/issues/70014
Signed-off-by: Anuradha Gadge <anuradha.gadge@ibm.com>
5 months agomds: use system error codes instead of CEPHFS_EXX codes 60286/head
Igor Golikov [Tue, 18 Feb 2025 12:47:52 +0000 (12:47 +0000)]
mds: use system error codes instead of CEPHFS_EXX codes

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/64611
5 months agomgr/dashboard: fix Python xmlsec build issue 61871/head
Ernesto Puerta [Tue, 18 Feb 2025 11:51:08 +0000 (12:51 +0100)]
mgr/dashboard: fix Python xmlsec build issue

It disables the specific pinning to a Python xmlsec version.

Fixes: https://tracker.ceph.com/issues/70019
Fixes: 37e633384b7c18893bc0e30a8f3967f6496da00b
Fixes: https://github.com/ceph/ceph/pull/61089
Signed-off-by: Ernesto Puerta <epuertat@redhat.com>
5 months agomds,client: change result field handling in the MClientReply message
Igor Golikov [Tue, 18 Feb 2025 11:45:57 +0000 (11:45 +0000)]
mds,client: change result field handling in the MClientReply message

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/64611
5 months agomds: prepare infra to replace CEPHFS_EXXX codes to system codes
Igor Golikov [Tue, 18 Feb 2025 11:44:17 +0000 (11:44 +0000)]
mds: prepare infra to replace CEPHFS_EXXX codes to system codes

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/64611
5 months agopybind/cephfs: switch CEPHFS_E error codes to system error codes
Igor Golikov [Tue, 18 Feb 2025 11:38:47 +0000 (11:38 +0000)]
pybind/cephfs: switch CEPHFS_E error codes to system error codes

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/64611
5 months agoPendingReleaseNotes: add note on client/mds error codes
Igor Golikov [Tue, 18 Feb 2025 11:36:10 +0000 (11:36 +0000)]
PendingReleaseNotes: add note on client/mds error codes

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/64611
5 months agomgr/dashboard: remaning critical-confirmation-modal to delete-confirmation-modal... 61478/head
Naman Munet [Mon, 10 Feb 2025 03:34:19 +0000 (09:04 +0530)]
mgr/dashboard: remaning critical-confirmation-modal to delete-confirmation-modal and keeping default demetion impact as medium

Fixes: https://tracker.ceph.com/issues/69628
Signed-off-by: Naman Munet <naman.munet@ibm.com>
5 months agomgr/dashboard: Add confirmation textbox for resource name on delete action
Naman Munet [Wed, 22 Jan 2025 10:59:20 +0000 (16:29 +0530)]
mgr/dashboard: Add confirmation textbox for resource name on delete action

Before:
=====
User was able to delete a single or multiple critical resources like (  images, snapshots, subvolumes, subvolume-groups, pools, hosts , OSDs, buckets, file system, services ) by just clicking on a checkbox.

After:
=====
User now has to type the resource name that they are deleting in the textbox on the delete modal, and then only they will be able to delete the critical resource.
Also from now onwards multiple selection for deletions of critical resources is not possible. Hence, user can delete only single resource at a time. On the other side, non-critical resources can be deleted in one go.

fixes: https://tracker.ceph.com/issues/69628

Signed-off-by: Naman Munet <naman.munet@ibm.com>
5 months agoMerge pull request #61836 from myoungwon/fix-crimson-osd-invalid-argument-print
Matan Breizman [Tue, 18 Feb 2025 10:21:12 +0000 (12:21 +0200)]
Merge pull request #61836 from myoungwon/fix-crimson-osd-invalid-argument-print

crimson/osd: remove invalid an argument when printing log

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
5 months agoosd/ReplicatedBackend: assert non-trivial obc existence 58752/head
Matan Breizman [Tue, 23 Jul 2024 13:12:50 +0000 (13:12 +0000)]
osd/ReplicatedBackend: assert non-trivial obc existence

Added to help debug: https://tracker.ceph.com/issues/50608

More information: https://gist.github.com/Matan-B/24b49e9b734259f06edf17fdfea5d24d

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
5 months agoMerge pull request #61469 from ronen-fr/wip-rf-assert-perf
Ronen Friedman [Tue, 18 Feb 2025 10:02:04 +0000 (12:02 +0200)]
Merge pull request #61469 from ronen-fr/wip-rf-assert-perf

common/perf-counters: replace 'assert' with 'ceph_assert'

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 months agoMerge pull request #61606 from rhcs-dashboard/create-storage-class
afreen23 [Tue, 18 Feb 2025 09:55:57 +0000 (15:25 +0530)]
Merge pull request #61606 from rhcs-dashboard/create-storage-class

mgr/dashboard: RGW - Create Storage Class

Reviewed-by: Afreen Misbah <afreen@ibm.com>
5 months agoMerge pull request #61793 from MaxKellermann/rados__includes
Ilya Dryomov [Tue, 18 Feb 2025 08:34:50 +0000 (09:34 +0100)]
Merge pull request #61793 from MaxKellermann/rados__includes

Add missing librbd includes

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
5 months agoMerge pull request #61814 from gbregman/main
Gil Bregman [Tue, 18 Feb 2025 06:41:57 +0000 (08:41 +0200)]
Merge pull request #61814 from gbregman/main

mgr/cephadm/nvmeof: Add QOS timeslice field to NVMeOF configuration

5 months agoMerge pull request #47189 from pdvian/wip-crush-df
Radoslaw Zarzynski [Mon, 17 Feb 2025 22:37:15 +0000 (23:37 +0100)]
Merge pull request #47189 from pdvian/wip-crush-df

crush/CrushWrapper: Merge weights if rule contains multiple take

Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 months agoMerge pull request #61752 from afreen23/wip-nvme-ns
afreen23 [Mon, 17 Feb 2025 20:21:55 +0000 (01:51 +0530)]
Merge pull request #61752 from afreen23/wip-nvme-ns

Add namespace counter in nvmeof namepsaces

Reviewed-by: Afreen Misbah <afreen@ibm.com>
5 months agoMerge PR #60983 into main
Patrick Donnelly [Mon, 17 Feb 2025 19:21:03 +0000 (14:21 -0500)]
Merge PR #60983 into main

* refs/pull/60983/head:
script: ceph-backport no longer launches firefox

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
5 months agoMerge PR #61552 into main
Patrick Donnelly [Mon, 17 Feb 2025 19:02:52 +0000 (14:02 -0500)]
Merge PR #61552 into main

* refs/pull/61552/head:
script/ceph-debug-docker.sh: fix manifest unknown error

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
5 months agoMerge PR #61776 into main
Patrick Donnelly [Mon, 17 Feb 2025 18:56:50 +0000 (13:56 -0500)]
Merge PR #61776 into main

* refs/pull/61776/head:
ceph-backport.sh: add squid to known milestones

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
5 months agoMerge PR #61813 into main
Patrick Donnelly [Mon, 17 Feb 2025 18:52:59 +0000 (13:52 -0500)]
Merge PR #61813 into main

* refs/pull/61813/head:
common: add missing mds op names

Reviewed-by: Greg Farnum <gfarnum@redhat.com>
5 months agoRGW - Fix POSIX bucket notify test 61756/head
Daniel Gryniewicz [Tue, 11 Feb 2025 16:51:22 +0000 (11:51 -0500)]
RGW - Fix POSIX bucket notify test

The BucketCacheFixtureInotify1.List2Inotify1 test was failing due to the
count being wrong.  Fix the count, and flesh out the test case to test
the cache for deleting and adding.  Also, move to per-test fixture, so
tests can't interfere with eachother due to inotify latency.

Fixes: https://tracker.ceph.com/issues/68336
Signed-off-by: Daniel Gryniewicz <dang@fprintf.net>
5 months agoMerge pull request #61785 from ceph/cve-34749-fix
David Galloway [Mon, 17 Feb 2025 17:11:37 +0000 (12:11 -0500)]
Merge pull request #61785 from ceph/cve-34749-fix

doc: Upgrade and unpin some python versions

5 months agomgr/dashboard: RGW - Create Storage Class 61606/head
Dnyaneshwari [Fri, 31 Jan 2025 09:35:12 +0000 (15:05 +0530)]
mgr/dashboard: RGW - Create Storage Class

Fixes: https://tracker.ceph.com/issues/69750
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>
5 months agomgr/cephadm/nvmeof: Add QOS timeslice field to NVMeOF configuration 61814/head
Gil Bregman [Thu, 13 Feb 2025 19:42:48 +0000 (21:42 +0200)]
mgr/cephadm/nvmeof: Add QOS timeslice field to NVMeOF configuration
Fixes https://tracker.ceph.com/issues/69952

Signed-off-by: Gil Bregman <gbregman@il.ibm.com>
5 months agotest/rbd_mirror: flush watch/notify callbacks in TestImageReplayer 61847/head
Ilya Dryomov [Mon, 17 Feb 2025 11:41:51 +0000 (12:41 +0100)]
test/rbd_mirror: flush watch/notify callbacks in TestImageReplayer

TestImageReplayer establishes its own (i.e. outside of the SUT code)
watch on the header of the remote image to be able to synchronize the
execution of the test with certain notifications.  This watch is
established before the remote image is opened and is teared down until
after the remote image is closed but while the image replayer is still
running.  The flush that is part of image close sequence thus isn't
guaranteed to cover all callbacks, especially for snapshot-based
mirroring where UnlinkPeerRequest spawned from Replayer::unlink_peer()
generates a notification on the remote image for each completed unlink.
Since TestImageReplayer further immediately deletes C_WatchCtx, pretty
much any test can segfault when C_WatchCtx::handle_notify() is invoked
by TestWatchNotify infrastructure.  Because it's a virtual method, the
segfault often involves a completely bogus instruction pointer:

  fn_anonymous[3176255]: segfault at b ip 000000000000000b sp 00007fffbceba7a8 error 14 in unittest_rbd_mirror[555555554000+96a000]
  Code: Bad RIP value.

Fixes: https://tracker.ceph.com/issues/63798
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
5 months agoMerge pull request #61702 from MaxKellermann/bluestore_includes
Max Kellermann [Mon, 17 Feb 2025 11:10:56 +0000 (12:10 +0100)]
Merge pull request #61702 from MaxKellermann/bluestore_includes

os/bluestore: include cleanup

Reviewed-by: Igor Fedotov <ifedotov@suse.com>
5 months agoMerge pull request #61808 from ronen-fr/wip-rf-store-ids
Ronen Friedman [Mon, 17 Feb 2025 10:12:25 +0000 (12:12 +0200)]
Merge pull request #61808 from ronen-fr/wip-rf-store-ids

osd/scrub: cleanup scrub-store IDs generation

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 months agoMerge pull request #61588 from rhcs-dashboard/smb-share-form-create
afreen23 [Mon, 17 Feb 2025 09:52:19 +0000 (15:22 +0530)]
Merge pull request #61588 from rhcs-dashboard/smb-share-form-create

mgr/dashboard: SMB Create Share

Reviewed-by: Afreen Misbah <afreen@ibm.com>
5 months agocephadm: ingress- Add v4v6 flag to HAProxy bind directive 61833/head
Kushal Deb [Fri, 14 Feb 2025 17:16:09 +0000 (22:46 +0530)]
cephadm: ingress- Add v4v6 flag to HAProxy bind directive

Signed-off-by: Kushal Deb <Kushal.Deb@ibm.com>
5 months agomgr/dashboard: Add namespace counter in nvmeof namepsaces 61752/head
Afreen Misbah [Fri, 7 Feb 2025 09:36:20 +0000 (15:06 +0530)]
mgr/dashboard: Add namespace counter in nvmeof namepsaces

Fixes https://tracker.ceph.com/issues/69900

Signed-off-by: Afreen Misbah <afreen@ibm.com>
5 months agomgr/dashboard: fix image size in nvmeof namespace create/update api
Afreen Misbah [Fri, 7 Feb 2025 11:43:51 +0000 (17:13 +0530)]
mgr/dashboard: fix image size in nvmeof namespace create/update api

- Different name is used in POST and PATCH for `rbd_image_size`
- Using same name in both requests
- fixing typing issues in frontend

Fixes https://tracker.ceph.com/issues/69864

Signed-off-by: Afreen Misbah <afreen@ibm.com>
5 months agoMerge pull request #61779 from yuvalif/wip-yuval-logging-fields-doc
Yuval Lifshitz [Mon, 17 Feb 2025 07:54:40 +0000 (09:54 +0200)]
Merge pull request #61779 from yuvalif/wip-yuval-logging-fields-doc

doc/rgw/logging: update field description

Reviewed-By: Anthony D'Atri <anthony.datri@gmail.com>, Ali Masarwe <ali.masarwa@ibm.com>
5 months agolibrbd: add missing includes 61793/head
Max Kellermann [Mon, 28 Oct 2024 08:17:15 +0000 (09:17 +0100)]
librbd: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
5 months agorbd_replay: add missing include
Max Kellermann [Mon, 28 Oct 2024 13:51:52 +0000 (14:51 +0100)]
rbd_replay: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
5 months agoSimpleRADOSStriper: add missing include
Max Kellermann [Sat, 2 Nov 2024 22:32:59 +0000 (23:32 +0100)]
SimpleRADOSStriper: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
5 months agolibrados: add missing includes
Max Kellermann [Sun, 27 Oct 2024 11:07:18 +0000 (12:07 +0100)]
librados: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
5 months agoMerge pull request #61597 from Hezko/nvmf-update-route
Hezko [Mon, 17 Feb 2025 06:24:22 +0000 (08:24 +0200)]
Merge pull request #61597 from Hezko/nvmf-update-route

mgr/dashboard: namespace update route robustness

5 months agoMerge pull request #61835 from nbalacha/wip-nbalacha-69978
Ilya Dryomov [Sun, 16 Feb 2025 20:41:48 +0000 (21:41 +0100)]
Merge pull request #61835 from nbalacha/wip-nbalacha-69978

rbd-mirror: fix possible recursive lock of ImageReplayer::m_lock

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
5 months agocrimson/osd: remove invalid argurment when printing log 61836/head
myoungwon oh [Sun, 16 Feb 2025 11:48:16 +0000 (11:48 +0000)]
crimson/osd: remove invalid argurment when printing log

Signed-off-by: Myoungwon Oh <myoungwon.oh@samsung.com>
5 months agoosd/scrub: clean-up scrub-store IDs generation 61808/head
Ronen Friedman [Tue, 11 Feb 2025 12:52:38 +0000 (06:52 -0600)]
osd/scrub: clean-up scrub-store IDs generation

The Scrub Store IDs (used to identify OMAP entries used for storing
object-specific error data) are generated by attaching some prefix to
the text representation of virtual (invented) hobjects.

This commit cleans up the code by moving the name generation
process (creating temporary un-needed objects, then
extracting the to_str() representation of their identity)
into separate functions.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
5 months agomgr/dashboard: ns update route robustness 61597/head
Tomer Haskalovitch [Thu, 30 Jan 2025 09:09:13 +0000 (11:09 +0200)]
mgr/dashboard: ns update route robustness

improve namespace update endpoint

fixes: https://tracker.ceph.com/issues/62705

Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MBP.lan>
5 months agorbd-mirror: fix possible recursive lock of ImageReplayer::m_lock 61835/head
N Balachandran [Sat, 15 Feb 2025 13:26:31 +0000 (18:56 +0530)]
rbd-mirror: fix possible recursive lock of ImageReplayer::m_lock

If periodic status update (LambdaContext which is queued from
handle_update_mirror_image_replay_status()) races with shutdown and
ends up being the last in-flight operation that shutdown was pending
on, we attempt to recursively acquire m_lock in shut_down() because
m_in_flight_op_tracker.finish_op() is called with m_lock (and also
m_threads->timer_lock) held.  These locks are needed only for the call
to schedule_update_mirror_image_replay_status() and should be unlocked
immediately.

Fixes: https://tracker.ceph.com/issues/69978
Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: N Balachandran <nithya.balachandran@ibm.com>
5 months agoqa/tasks/cephadm: don't fail if we've already cleaned up conf/keyring 61722/head
Adam King [Sat, 15 Feb 2025 18:55:12 +0000 (13:55 -0500)]
qa/tasks/cephadm: don't fail if we've already cleaned up conf/keyring

We run this rm command after the `cephadm rm-cluster`
which is also meant to clean these up. Honestly, I have no idea
why this wasn't already failing

Signed-off-by: Adam King <adking@redhat.com>
5 months agoqa/cephadm: stop cephadm mgr module during cleanup
Adam King [Fri, 7 Feb 2025 21:08:30 +0000 (16:08 -0500)]
qa/cephadm: stop cephadm mgr module during cleanup

We recommend this generally when tearing down a cluster
and do so in cephadm-ansible. Doing this avoids any
potential timings where the cephadm mgr module attempts
to undo any daemon removals as we're cleaning up

Signed-off-by: Adam King <adking@redhat.com>
5 months agoMerge pull request #61827 from tchaikov/python3.12-on-ubuntu-noble
Ilya Dryomov [Sat, 15 Feb 2025 11:12:58 +0000 (12:12 +0100)]
Merge pull request #61827 from tchaikov/python3.12-on-ubuntu-noble

do_cmake: use Python 3.12 on ubuntu >= 24

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
5 months agoMerge pull request #61794 from MaxKellermann/cls__includes
Max Kellermann [Sat, 15 Feb 2025 04:49:47 +0000 (05:49 +0100)]
Merge pull request #61794 from MaxKellermann/cls__includes

cls: add missing includes

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
5 months agoMerge pull request #61608 from MaxKellermann/mon_includes
Max Kellermann [Sat, 15 Feb 2025 04:48:51 +0000 (05:48 +0100)]
Merge pull request #61608 from MaxKellermann/mon_includes

mon: include cleanup

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
5 months agoMerge pull request #61618 from ronen-fr/wip-rf-perf-sections
Ronen Friedman [Fri, 14 Feb 2025 17:59:08 +0000 (19:59 +0200)]
Merge pull request #61618 from ronen-fr/wip-rf-perf-sections

common/perf_counters: use the RAII helpers when dumping

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
5 months agoMerge pull request #61678 from phlogistonjohn/jjm-bwc-fixes-1
Adam King [Fri, 14 Feb 2025 17:46:20 +0000 (12:46 -0500)]
Merge pull request #61678 from phlogistonjohn/jjm-bwc-fixes-1

build-with-container fixes exec bit, dnf cache dir option

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Redouane Kachach <rkachach@ibm.com>
5 months agocls/numops: add missing include 61794/head
Max Kellermann [Wed, 30 Oct 2024 19:41:11 +0000 (20:41 +0100)]
cls/numops: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
5 months agocls/rbd: add missing includes
Max Kellermann [Sun, 27 Oct 2024 12:35:26 +0000 (13:35 +0100)]
cls/rbd: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
5 months agocls/cephfs: add missing forward declaration
Max Kellermann [Sat, 26 Oct 2024 18:08:20 +0000 (20:08 +0200)]
cls/cephfs: add missing forward declaration

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
5 months agocls/2pc_queue: add missing include
Max Kellermann [Sat, 26 Oct 2024 17:40:39 +0000 (19:40 +0200)]
cls/2pc_queue: add missing include

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
5 months agojournal: add missing includes
Max Kellermann [Sat, 26 Oct 2024 17:52:06 +0000 (19:52 +0200)]
journal: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
5 months agomgr/dashboard: SMB Create Share 61588/head
Dnyaneshwari [Thu, 30 Jan 2025 08:14:06 +0000 (13:44 +0530)]
mgr/dashboard: SMB Create Share

Fixes: https://tracker.ceph.com/issues/69733
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>
5 months agodo_cmake: use Python 3.12 on ubuntu >= 24 61827/head
Kefu Chai [Fri, 14 Feb 2025 10:53:58 +0000 (18:53 +0800)]
do_cmake: use Python 3.12 on ubuntu >= 24

the "official" Python shipped along with Ubuntu 24.04 (Noble Numbat) is
Python 3.12. And some of our building have been upgraded to Ubuntu
24.04. But we are still using Python 3.10 on Ubuntu >= 22, this breaks
the build. And CMake fails like:

```
CMake Error at /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Python3 (missing: Python3_EXECUTABLE Python3_INCLUDE_DIRS
  Python3_LIBRARIES Interpreter Development Development.Module
  Development.Embed) (Required is exact version "3.10")

      Reason given by package:
          Interpreter: Wrong version for the interpreter "/bin/python3"

Call Stack (most recent call first):
  /usr/share/cmake-3.28/Modules/FindPackageHandleStandardArgs.cmake:600 (_FPHSA_FAILURE_MESSAGE)
  cmake/modules/FindPython/Support.cmake:3863 (find_package_handle_standard_args)
  cmake/modules/FindPython3.cmake:545 (include)
  CMakeLists.txt:597 (find_package)
```

This build failure should also happen on developers who build Ceph on
Ubuntu >= 24.

In this change, we use Python 3.12 on Ubuntu >= 24

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
5 months agoMerge pull request #61768 from idryomov/wip-69911
Ilya Dryomov [Fri, 14 Feb 2025 10:30:10 +0000 (11:30 +0100)]
Merge pull request #61768 from idryomov/wip-69911

librbd: fix mirror image status summary in a namespace

Reviewed-by: N Balachandran <nibalach@redhat.com>
5 months agoMerge pull request #61698 from afreen23/wip-fix-nsapi
afreen23 [Fri, 14 Feb 2025 09:34:48 +0000 (15:04 +0530)]
Merge pull request #61698 from afreen23/wip-fix-nsapi

mgr/dashboard: (refactor)fix image size in nvmeof namespace create/update api

Reviewed-by: Afreen Misbah <afreen@ibm.com>