]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 months agosrc/test/crimson/seastore/CMakeLists: disable unittest-transaction-manager 62032/head
Matan Breizman [Thu, 27 Feb 2025 14:26:16 +0000 (14:26 +0000)]
src/test/crimson/seastore/CMakeLists: disable unittest-transaction-manager

See: https://tracker.ceph.com/issues/70202

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge pull request #61985 from zdover23/wip-doc-2025-02-25-releases-squid-order
Zac Dover [Tue, 25 Feb 2025 06:57:50 +0000 (16:57 +1000)]
Merge pull request #61985 from zdover23/wip-doc-2025-02-25-releases-squid-order

doc/releases: correct squid release order

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agoMerge pull request #61788 from VallariAg/wip-nvmeof-teuthology-improve
Vallari Agrawal [Tue, 25 Feb 2025 06:36:36 +0000 (12:06 +0530)]
Merge pull request #61788 from VallariAg/wip-nvmeof-teuthology-improve

qa/suite/nvmeof: Add asserts to scalability_test and extra logs in fio_test

4 months agoMerge pull request #61984 from cbodley/wip-doc-rgw-path-style
Zac Dover [Tue, 25 Feb 2025 05:08:29 +0000 (15:08 +1000)]
Merge pull request #61984 from cbodley/wip-doc-rgw-path-style

doc/rgw: clarify path-style vs virtual-hosted-style access

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agodoc/releases: correct squid release order 61985/head
Zac Dover [Tue, 25 Feb 2025 04:57:11 +0000 (14:57 +1000)]
doc/releases: correct squid release order

Put the releases of Squid in descending order. This change alters the
order of the Squid releases so that it is the same as the order of the
other Ceph releases.

Signed-off-by: Zac Dover <zac.dover@proton.me>
4 months agoMerge pull request #61875 from rhcs-dashboard/update-bucket-details
Aashish Sharma [Tue, 25 Feb 2025 04:37:02 +0000 (10:07 +0530)]
Merge pull request #61875 from rhcs-dashboard/update-bucket-details

mgr/dashboard: Update bucket details section after making bucket lifecycle changes

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
4 months agoMerge PR #61979 into main
Patrick Donnelly [Mon, 24 Feb 2025 23:54:04 +0000 (18:54 -0500)]
Merge PR #61979 into main

* refs/pull/61979/head:
script/ceph-backport: remove upstream remote inferencing

Reviewed-by: Guillaume Abrioux <gabrioux@redhat.com>
4 months agodoc/rgw: clarify path-style vs virtual-hosted-style access 61984/head
Casey Bodley [Mon, 24 Feb 2025 21:50:39 +0000 (16:50 -0500)]
doc/rgw: clarify path-style vs virtual-hosted-style access

instead of referring to "vhost-style", copy the "path-style" and
"virtual-hosted-style" language from https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html

expand the FQDN acronym to avoid potential confusion

"The second method is deprecated by AWS" had incorrectly referred to the
vhost-style method - clarify that it refers to path-style access

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge PR #61943 into main
Patrick Donnelly [Mon, 24 Feb 2025 21:44:46 +0000 (16:44 -0500)]
Merge PR #61943 into main

* refs/pull/61943/head:
qa: ignore variant of down fs

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge PR #61792 into main
Patrick Donnelly [Mon, 24 Feb 2025 21:43:04 +0000 (16:43 -0500)]
Merge PR #61792 into main

* refs/pull/61792/head:
libcephsqlite: include cleanup

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61701 into main
Patrick Donnelly [Mon, 24 Feb 2025 21:41:59 +0000 (16:41 -0500)]
Merge PR #61701 into main

* refs/pull/61701/head:
client/Client: add missing include and forward declaration

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61697 into main
Patrick Donnelly [Mon, 24 Feb 2025 21:41:00 +0000 (16:41 -0500)]
Merge PR #61697 into main

* refs/pull/61697/head:
osdc/ObjectCacher: include cleanup
osdc/Objecter: include cleanup
osdc/Journaler: include cleanup
osdc/Striper: add missing includes
osdc/Filer: include cleanup
crush/CrushWrapper: un-inline methods to fix linker errors
client/Client: add missing include and forward declaration

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #61872 into main
Patrick Donnelly [Mon, 24 Feb 2025 21:39:41 +0000 (16:39 -0500)]
Merge PR #61872 into main

* refs/pull/61872/head:
crush/CrushWrapper: un-inline methods to fix linker errors

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #61733 from phlogistonjohn/jjm-ctr-cleaner
Adam King [Mon, 24 Feb 2025 20:56:44 +0000 (15:56 -0500)]
Merge pull request #61733 from phlogistonjohn/jjm-ctr-cleaner

container: small container image improvements

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dan Mick <dan.mick@redhat.com>
4 months agoMerge pull request #61400 from salieri11/igolikov-wip-fscrypt-68776
Christopher Hoffman [Mon, 24 Feb 2025 19:50:16 +0000 (14:50 -0500)]
Merge pull request #61400 from salieri11/igolikov-wip-fscrypt-68776

client: Use custom fscrypt cli in fs/fscrypt suite

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
4 months agoMerge pull request #61693 from aainscow/interval_set_strict
Adam Kupczyk [Mon, 24 Feb 2025 17:01:41 +0000 (18:01 +0100)]
Merge pull request #61693 from aainscow/interval_set_strict

include: interval_set: Re-introduce the original behaviour strict interval set

4 months agoMerge pull request #61679 from aclamk/wip-aclamk-fragmentation-histogram-defaults
Adam Kupczyk [Mon, 24 Feb 2025 17:01:15 +0000 (18:01 +0100)]
Merge pull request #61679 from aclamk/wip-aclamk-fragmentation-histogram-defaults

os/bluestore: Fix default base size for histogram

4 months agoMerge pull request #61455 from jbaergen-do/limit-discard-qlen-upstream
Adam Kupczyk [Mon, 24 Feb 2025 17:00:52 +0000 (18:00 +0100)]
Merge pull request #61455 from jbaergen-do/limit-discard-qlen-upstream

blk/KernelDevice: Introduce a cap on the number of pending discards

4 months agoMerge pull request #59740 from phlogistonjohn/jjm-smb-proxy-sidecar
Adam King [Mon, 24 Feb 2025 16:22:08 +0000 (11:22 -0500)]
Merge pull request #59740 from phlogistonjohn/jjm-smb-proxy-sidecar

smb: add support for proxy sidecar

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Sachin Prabhu <sp@spui.uk>
4 months agomgr/dashboard: Update bucket details section after making bucket lifecycle changesn 61875/head
Naman Munet [Tue, 18 Feb 2025 12:58:01 +0000 (18:28 +0530)]
mgr/dashboard: Update bucket details section after making bucket lifecycle changesn

Fixes: https://tracker.ceph.com/issues/69988
Signed-off-by: Naman Munet <naman.munet@ibm.com>
4 months agoMerge pull request #61949 from phlogistonjohn/jjm-c10s
Adam King [Mon, 24 Feb 2025 15:59:21 +0000 (10:59 -0500)]
Merge pull request #61949 from phlogistonjohn/jjm-c10s

build: a pair of needed changes to build on centos 10 stream

Reviewed-by: Kefu Chai <kefu.chai@scylladb.com>
4 months agoMerge pull request #61592 from hasan4791/issue-69732
Yuri Weinstein [Mon, 24 Feb 2025 15:38:41 +0000 (07:38 -0800)]
Merge pull request #61592 from hasan4791/issue-69732

Isolate the absl flags to ceph-mon & ceph-nvmeof-monitor-client targets

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
4 months agoMerge pull request #60213 from NitzanMordhai/wip-nitzan-thrash-old-client-ignore...
Yuri Weinstein [Mon, 24 Feb 2025 15:37:48 +0000 (07:37 -0800)]
Merge pull request #60213 from NitzanMordhai/wip-nitzan-thrash-old-client-ignore-list

suite: thrash old client ignore list expend

Reviewed-by: Laura Flores <lflores@redhat.com>
4 months agoMerge pull request #55103 from kamoltat/wip-ksirivad-fix-63861
Yuri Weinstein [Mon, 24 Feb 2025 15:33:41 +0000 (07:33 -0800)]
Merge pull request #55103 from kamoltat/wip-ksirivad-fix-63861

src/mon/OSDMonitor.cc: [Stretch Mode] WRN non-existent CRUSH location assigned to MON

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
4 months agoscript/ceph-backport: remove upstream remote inferencing 61979/head
Patrick Donnelly [Mon, 24 Feb 2025 13:48:32 +0000 (08:48 -0500)]
script/ceph-backport: remove upstream remote inferencing

It's unnecessary.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #61668 from badone/wip-fix-rados-verify-cluster-selection
Matan Breizman [Mon, 24 Feb 2025 09:43:13 +0000 (11:43 +0200)]
Merge pull request #61668 from badone/wip-fix-rados-verify-cluster-selection

qa/suites/rados/verify: Allow selection of 2 or 4 node cluster

Reviewed-by: Laura Flores <lflores@redhat.com>
4 months agoMerge pull request #61196 from xxhdx1985126/wip-crimson-mgr-dynamic-perf-report
Matan Breizman [Mon, 24 Feb 2025 09:42:37 +0000 (11:42 +0200)]
Merge pull request #61196 from xxhdx1985126/wip-crimson-mgr-dynamic-perf-report

crimson/osd: support mgr's dynamic perf stats

Reviewed-by: Samuel Just <sjust@redhat.com>
4 months agoMerge pull request #60185 from xxhdx1985126/wip-68306
Matan Breizman [Mon, 24 Feb 2025 09:41:55 +0000 (11:41 +0200)]
Merge pull request #60185 from xxhdx1985126/wip-68306

crimson/osd/pg_recovery: trigger BackfillState events synchronously

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
4 months agoMerge pull request #61848 from guits/split-db-block-collocated
Guillaume Abrioux [Mon, 24 Feb 2025 08:34:26 +0000 (09:34 +0100)]
Merge pull request #61848 from guits/split-db-block-collocated

ceph-volume: support splitting db even on collocated scenario

4 months agoMerge pull request #61941 from ronen-fr/wip-rf-test-match
Ronen Friedman [Mon, 24 Feb 2025 08:30:20 +0000 (10:30 +0200)]
Merge pull request #61941 from ronen-fr/wip-rf-test-match

qa/standalone/scrub: retry in TEST_abort_periodic_for_operator()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 months agoMerge pull request #61899 from rhcs-dashboard/disable-deleting-bucket-with-objects
Aashish Sharma [Mon, 24 Feb 2025 06:19:17 +0000 (11:49 +0530)]
Merge pull request #61899 from rhcs-dashboard/disable-deleting-bucket-with-objects

mgr/dashboard: disable deleting bucket with objects

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
4 months agoMerge pull request #61893 from laimis9133/main
Nizamudeen A [Mon, 24 Feb 2025 05:06:12 +0000 (10:36 +0530)]
Merge pull request #61893 from laimis9133/main

mgr/dashboard: update openapi specification for /api/cluster/user/export

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
4 months agoMerge pull request #60872 from ronen-fr/wip-rf-repaironly
Ronen Friedman [Sun, 23 Feb 2025 14:31:28 +0000 (16:31 +0200)]
Merge pull request #60872 from ronen-fr/wip-rf-repaironly

osd/scrub: remove config option osd_repair_during_recovery
Reviewed-by: Samuel Just <sjust@redhat.com>
4 months agoMerge pull request #61950 from anthonyeleven/improve-rgw-yaml
Anthony D'Atri [Fri, 21 Feb 2025 13:51:28 +0000 (08:51 -0500)]
Merge pull request #61950 from anthonyeleven/improve-rgw-yaml

src/common/options: Improve descriptions in rgw.yaml.in

4 months agodoc: fix syntax (squash this) 61950/head
Zac Dover [Fri, 21 Feb 2025 04:38:23 +0000 (14:38 +1000)]
doc: fix syntax (squash this)

Signed-off-by: Zac Dover <zac.dover@gmail.com>
4 months agodoc: fixup (squash this)
Zac Dover [Fri, 21 Feb 2025 03:47:07 +0000 (13:47 +1000)]
doc: fixup (squash this)

Remove a colon from a yaml field that will not accept a colon.

Signed-off-by: Zac Dover <zac.dover@proton.me>
4 months agoMerge pull request #61948 from anthonyeleven/osd-rst-reimprove
Zac Dover [Fri, 21 Feb 2025 03:10:45 +0000 (13:10 +1000)]
Merge pull request #61948 from anthonyeleven/osd-rst-reimprove

doc/cephadm/services: Re-improve osd.rst

Reviewed-by: Mike Perez <thingee@gmail.com>
4 months agomgr/dashboard: update openapi specification for /api/cluster/user/export 61893/head
Laimis Juzeliūnas [Wed, 19 Feb 2025 09:58:56 +0000 (11:58 +0200)]
mgr/dashboard: update openapi specification for /api/cluster/user/export

This commit updates the openapi specification for /api/cluster/user/export endpoint to reflect the current api behaviour.

Fixes: https://tracker.ceph.com/issues/70043
Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>
4 months agosrc/common/options: Improve descriptions in rgw.yaml.in
Anthony D'Atri [Thu, 20 Feb 2025 21:34:28 +0000 (16:34 -0500)]
src/common/options: Improve descriptions in rgw.yaml.in

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoinstall-deps.sh: enable crb repository for centos 10 stream 61949/head
John Mulligan [Thu, 13 Feb 2025 21:00:27 +0000 (16:00 -0500)]
install-deps.sh: enable crb repository for centos 10 stream

The centos 10 stream distribution is like centos 9 and needs the crb
repository enabled to even think about building ceph. Note that I made
it a separate block in case more stuff needs to be added for it later.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
4 months agodo_cmake.sh: specify correct python version for centos 10 stream
John Mulligan [Thu, 13 Feb 2025 20:59:58 +0000 (15:59 -0500)]
do_cmake.sh: specify correct python version for centos 10 stream

Update the python version in the same tedious manner for centos 10
stream.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
4 months agodoc/cephadm/services: Re-improve osd.rst 61948/head
Anthony D'Atri [Thu, 20 Feb 2025 21:13:44 +0000 (16:13 -0500)]
doc/cephadm/services: Re-improve osd.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoqa: ignore variant of down fs 61943/head
Patrick Donnelly [Thu, 20 Feb 2025 18:59:03 +0000 (13:59 -0500)]
qa: ignore variant of down fs

Fixes: https://tracker.ceph.com/issues/70107
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #61870 from afreen23/backward-compatibility
afreen23 [Thu, 20 Feb 2025 17:42:55 +0000 (23:12 +0530)]
Merge pull request #61870 from afreen23/backward-compatibility

mgr/dashboard: Make API backward compatible with size param change

Reviewed-by: Afreen Misbah <afreen@ibm.com>
4 months agotests: add call to fscrypt_cli_setup.sh to all fscrypt YAML files 61400/head
Igor Golikov [Thu, 20 Feb 2025 16:27:06 +0000 (18:27 +0200)]
tests: add call to fscrypt_cli_setup.sh to all fscrypt YAML files

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/68776
4 months agotests: use custom fscrypt cli for xfs tests
Igor Golikov [Thu, 20 Feb 2025 16:25:59 +0000 (18:25 +0200)]
tests: use custom fscrypt cli for xfs tests

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/68776
4 months agotests: add --verbose for better debugging of the custom fscript cli
Igor Golikov [Thu, 20 Feb 2025 16:25:12 +0000 (18:25 +0200)]
tests: add --verbose for better debugging of the custom fscript cli

Signed-off-by: Igor Golikov <igolikov@ibm.com>
4 months agotests: add new script for custom fscrypt cli setup
Igor Golikov [Thu, 20 Feb 2025 16:23:43 +0000 (18:23 +0200)]
tests: add new script for custom fscrypt cli setup

Signed-off-by: Igor Golikov <igolikov@ibm.com>
Fixes: https://tracker.ceph.com/issues/68776
4 months agoqa/standalone/scrub: retry in TEST_abort_periodic_for_operator() 61941/head
Ronen Friedman [Thu, 20 Feb 2025 16:15:44 +0000 (10:15 -0600)]
qa/standalone/scrub: retry in TEST_abort_periodic_for_operator()

The scenario created in the test requires two PGs that share the same
Primary, and at least one more member of their active sets.
The PR handles the (unlikely) case where the first PG tried does not
have a counterpart that matches the requirements.

A minor related fix in scrub-helpers.sh: using 'printf' to
return a value, instead of an out (ref) parameter.

Fixes: https://tracker.ceph.com/issues/69837
Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agoosdc/ObjectCacher: include cleanup 61697/head
Max Kellermann [Mon, 7 Oct 2024 03:37:31 +0000 (05:37 +0200)]
osdc/ObjectCacher: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoosdc/Objecter: include cleanup
Max Kellermann [Mon, 7 Oct 2024 03:28:45 +0000 (05:28 +0200)]
osdc/Objecter: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoosdc/Journaler: include cleanup
Max Kellermann [Mon, 7 Oct 2024 02:40:40 +0000 (04:40 +0200)]
osdc/Journaler: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoosdc/Striper: add missing includes
Max Kellermann [Mon, 7 Oct 2024 02:31:00 +0000 (04:31 +0200)]
osdc/Striper: add missing includes

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoosdc/Filer: include cleanup
Max Kellermann [Mon, 7 Oct 2024 02:27:49 +0000 (04:27 +0200)]
osdc/Filer: include cleanup

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agocrush/CrushWrapper: un-inline methods to fix linker errors
Max Kellermann [Thu, 9 Jan 2025 13:49:22 +0000 (14:49 +0100)]
crush/CrushWrapper: un-inline methods to fix linker errors

The `crush_objs` library is not part of the `libceph-common` ABI, so
applications linking with `libceph-common` may fail to build because
the linker cannot find `crush_destroy()`.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoclient/Client: add missing include and forward declaration
Max Kellermann [Thu, 10 Oct 2024 06:27:49 +0000 (08:27 +0200)]
client/Client: add missing include and forward declaration

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoMerge pull request #61880 from idryomov/wip-70041
Ilya Dryomov [Thu, 20 Feb 2025 15:14:12 +0000 (16:14 +0100)]
Merge pull request #61880 from idryomov/wip-70041

test/rbd_mirror: clear Namespace::s_instance at the end of a test

Reviewed-by: Vinay Bhaskar Varada <vvarada@redhat.com>
4 months agoMerge pull request #61841 from MaxKellermann/librbd__unordered_map
Ilya Dryomov [Thu, 20 Feb 2025 15:08:33 +0000 (16:08 +0100)]
Merge pull request #61841 from MaxKellermann/librbd__unordered_map

include/unordered_{map,set}: remove, use `std` directly instead

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
4 months agoMerge pull request #61315 from rhcs-dashboard/smb-join_auth-usersgroups-form-actions
Pedro Gonzalez Gomez [Thu, 20 Feb 2025 14:08:31 +0000 (15:08 +0100)]
Merge pull request #61315 from rhcs-dashboard/smb-join_auth-usersgroups-form-actions

mgr/dashboard: add actions for smb join-auth and usersgroups resources mgmt also updates smb cluster form

Reviewed-by: Afreen Misbah <afreen@ibm.com>
4 months agoceph-volume: migrate unit tests from 'mock' to 'unittest.mock' 61848/head
Guillaume Abrioux [Mon, 17 Feb 2025 12:43:14 +0000 (12:43 +0000)]
ceph-volume: migrate unit tests from 'mock' to 'unittest.mock'

unit tests in ceph-volume was still using the external 'mock' library
for unit tests, which is unnecessary since 'unittest.mock' is part
of the Python standard library (available since Python 3.3).
This commit updates all imports to use 'unittest.mock' instead,
ensuring better maintainability and removing the need for an extra
dependency.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
4 months agoceph-volume: refactor get_physical_osds()
Guillaume Abrioux [Fri, 14 Feb 2025 12:34:50 +0000 (12:34 +0000)]
ceph-volume: refactor get_physical_osds()

This refactors `get_physical_osds()`.
The calculation of `data_slots` is now more concise. The handling of
`dev_size`, `rel_data_size`, and `abs_size` is standardized.
The initialization of `free_size` is moved outside the loop
for clarity. Redundant checks and assignments are removed to simplify
the code.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
4 months agoceph-volume: support splitting db even on collocated scenario
Guillaume Abrioux [Tue, 11 Feb 2025 16:00:51 +0000 (16:00 +0000)]
ceph-volume: support splitting db even on collocated scenario

This change enables ceph-volume to create OSDs where the DB is
explicitly placed on a separate LVM partition, even in collocated
scenarios (i.e., block and DB on the same device).
This helps mitigate BlueStore fragmentation issues.

Given that ceph-volume can't automatically predict a proper default size for the db device,
the idea is to use the `--block-db-size` parameter:

Passing `--block-db-size` and `--db-devices` makes ceph-volume create db devices
on dedicated devices (current implementation):

```
Total OSDs: 2

  Type            Path                                                    LV Size         % of device
----------------------------------------------------------------------------------------------------
  data            /dev/vdb                                                200.00 GB       100.00%
  block_db        /dev/vdd                                                4.00 GB         2.00%
----------------------------------------------------------------------------------------------------
  data            /dev/vdc                                                200.00 GB       100.00%
  block_db        /dev/vdd                                                4.00 GB         2.00%
```

Passing `--block-db-size` without `--db-devices` makes ceph-volume create a separate
LV for db device on the same device (new behavior):
```
Total OSDs: 2

  Type            Path                                                    LV Size         % of device
----------------------------------------------------------------------------------------------------
  data            /dev/vdb                                                196.00 GB       98.00%
  block_db        /dev/vdb                                                4.00 GB         2.00%
----------------------------------------------------------------------------------------------------
  data            /dev/vdc                                                196.00 GB       98.00%
  block_db        /dev/vdc                                                4.00 GB         2.00%
```

This new behavior is supported with the `--osds-per-device` parameter:

```
Total OSDs: 4

  Type            Path                                                    LV Size         % of device
----------------------------------------------------------------------------------------------------
  data            /dev/vdb                                                96.00 GB        48.00%
  block_db        /dev/vdb                                                4.00 GB         2.00%
----------------------------------------------------------------------------------------------------
  data            /dev/vdb                                                96.00 GB        48.00%
  block_db        /dev/vdb                                                4.00 GB         2.00%
----------------------------------------------------------------------------------------------------
  data            /dev/vdc                                                96.00 GB        48.00%
  block_db        /dev/vdc                                                4.00 GB         2.00%
----------------------------------------------------------------------------------------------------
  data            /dev/vdc                                                96.00 GB        48.00%
  block_db        /dev/vdc                                                4.00 GB         2.00%
```

Fixes: https://tracker.ceph.com/issues/69996
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
4 months agoceph-volume: enhance BlockSysFs
Guillaume Abrioux [Mon, 10 Feb 2025 16:29:04 +0000 (16:29 +0000)]
ceph-volume: enhance BlockSysFs

This refactores `BlockSysFs` to introduce `_get_sysfs_file_content()` for
retrieving sysfs file contents in a cleaner and reusable way.

It renames `self.sys_dev_block` to `self.sys_dev_block_dir` for clarity.
I've added `_get_sysfs_file_content()` to centralize sysfs file reads.

3 new methodes are introduced:
`blocks`, `logical_block_size`, and `size` properties for computing block
device size in a structured manner.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
4 months agoMerge pull request #59615 from xxhdx1985126/wip-63844-67916
Matan Breizman [Thu, 20 Feb 2025 10:20:32 +0000 (12:20 +0200)]
Merge pull request #59615 from xxhdx1985126/wip-63844-67916

crimson/osd/recovery_backend: always set the primary osd's BackfillInterval::version to the last_update before the backfill scan

Reviewed-by: Samuel Just <sjust@redhat.com>
4 months agoMerge pull request #61225 from rhcs-dashboard/rgw-ratelimit-integration1
Nizamudeen A [Thu, 20 Feb 2025 09:10:28 +0000 (14:40 +0530)]
Merge pull request #61225 from rhcs-dashboard/rgw-ratelimit-integration1

mgr/dashboard: Rgw ratelimit feature for user and bucket

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Mark Nelson <mnelson@redhat.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Naman Munet <nmunet@redhat.com>
4 months agoqa/standalone/scrub: fix osd-scrub-repair() 60872/head
Ronen Friedman [Mon, 17 Feb 2025 14:58:41 +0000 (08:58 -0600)]
qa/standalone/scrub: fix osd-scrub-repair()

following changes to 'scrub while recovering' logic, the
'what type of scrubs are allowed to run when recovering'
tests were broken, and are now fixed.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agoqa/standalone/scrub: expand standard_scrub_cluster()
Ronen Friedman [Mon, 17 Feb 2025 14:51:28 +0000 (08:51 -0600)]
qa/standalone/scrub: expand standard_scrub_cluster()

Expand scrub-helpers.sh::standard_scrub_cluster() to cater for
non-standard (i.e. - not "3") pool default size. Also - to
allow clients to specify a "nopool" pool name, preventing the
automatic creation of a pool.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agoosd/scrub: remove config option osd_repair_during_recovery
Ronen Friedman [Sun, 24 Nov 2024 14:27:38 +0000 (08:27 -0600)]
osd/scrub: remove config option osd_repair_during_recovery

The option was used to allow repair to be explicitly ordered by the
operator, even if the Primary OSD was in the middle of a recovery.
This is no longer necessary, as the code now accepts both repair and
scrub operator requests, even during recovery.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agomgr/dashboard: add actions to create, edit and delete smb join-auth and usersgroups... 61315/head
Pedro Gonzalez Gomez [Fri, 10 Jan 2025 09:23:37 +0000 (10:23 +0100)]
mgr/dashboard: add actions to create, edit and delete smb join-auth and usersgroups resources

Add join-auth and usersgroups resources management and improve the way to select those from the smb cluster form using a dropdown.
Add option to navigate to join-auth/usersgroups resource create form from smb form
Add some additional fixes left over from previous work, such as adding helper texts or adding missing smb cluster form fields

Fixes: https://tracker.ceph.com/issues/69483
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
4 months agoMerge pull request #61812 from ronen-fr/wip-rf-fstab
Ronen Friedman [Thu, 20 Feb 2025 08:01:44 +0000 (10:01 +0200)]
Merge pull request #61812 from ronen-fr/wip-rf-fstab

qa/standalone: do not use /etc/fstab as an always-there bytes source
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 months agoMerge pull request #61353 from rhcs-dashboard/smb-share-delete
Pedro Gonzalez Gomez [Thu, 20 Feb 2025 07:58:11 +0000 (08:58 +0100)]
Merge pull request #61353 from rhcs-dashboard/smb-share-delete

mgr/dashboard: add smb delete share action

Reviewed-by: Afreen Misbah <afreen@ibm.com>
4 months agomgr/dashboard: disable deleting bucket with objects 61899/head
Naman Munet [Wed, 19 Feb 2025 15:14:26 +0000 (20:44 +0530)]
mgr/dashboard: disable deleting bucket with objects

Fixes: https://tracker.ceph.com/issues/70078
Signed-off-by: Naman Munet <naman.munet@ibm.com>
4 months agoinclude/unordered_{map,set}: remove, use `std` directly instead 61841/head
Max Kellermann [Mon, 17 Feb 2025 07:30:18 +0000 (08:30 +0100)]
include/unordered_{map,set}: remove, use `std` directly instead

This is only an alias for the `std` classes anyway.  This effectively
reverts commit 8e8672047ccc which added these aliases, probably
because C++11 was new and not all compilers supported it properly, but
that was 12 years ago and we're onl C++20 meanwhile.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>
4 months agoMerge pull request #61906 from nbalacha/wip-nbalacha-70075
nbalacha [Thu, 20 Feb 2025 01:20:21 +0000 (06:50 +0530)]
Merge pull request #61906 from nbalacha/wip-nbalacha-70075

librbd: fix a crash in get_rollback_snap_id

4 months agomgr/dashboard: Make API backward compatible with size param change 61870/head
Afreen Misbah [Tue, 18 Feb 2025 11:24:19 +0000 (16:54 +0530)]
mgr/dashboard: Make API backward compatible with size param change

- We changed the api with size and now its an issue for other folks utilizing the API
- Hence making it compatible to work backwards as well

Fixes https://tracker.ceph.com/issues/70020

Signed-off-by: Afreen Misbah <afreen@ibm.com>
4 months agomgr/dashboard: add smb share delete action 61353/head
Pedro Gonzalez Gomez [Mon, 13 Jan 2025 19:28:33 +0000 (20:28 +0100)]
mgr/dashboard: add smb share delete action

Fixes: https://tracker.ceph.com/issues/69521
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
4 months agoMerge pull request #60610 from rzarzynski/wip-no-getval-on-osd-stats
Laura Flores [Wed, 19 Feb 2025 19:13:02 +0000 (13:13 -0600)]
Merge pull request #60610 from rzarzynski/wip-no-getval-on-osd-stats

osd: avoid costly md_config_t::get_val<>() when preparing stats

4 months agoMerge pull request #61408 from adk3798/cephadm-nvmeof-more-group-validation
Adam King [Wed, 19 Feb 2025 18:04:42 +0000 (13:04 -0500)]
Merge pull request #61408 from adk3798/cephadm-nvmeof-more-group-validation

mgr/cephadm: validate no duplicate groups and group vs. service id for nvmeof

Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61778 from adk3798/cephadm-double-quotes-nfs-recovery-backend
Adam King [Wed, 19 Feb 2025 18:02:44 +0000 (13:02 -0500)]
Merge pull request #61778 from adk3798/cephadm-double-quotes-nfs-recovery-backend

mgr/cephadm: use double quotes for NFSv4 RecoveryBackend in ganesha conf

Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61694 from rkachach/fix_issue_69863
Adam King [Wed, 19 Feb 2025 18:00:09 +0000 (13:00 -0500)]
Merge pull request #61694 from rkachach/fix_issue_69863

mgr/cephadm: reconfig rgw and ingress daemons when certificate changes

Reviewed-by: Adam King <adking@redhat.com>
4 months agoMerge pull request #61890 from zhscn/fix-clang-19
Matan Breizman [Wed, 19 Feb 2025 17:55:29 +0000 (19:55 +0200)]
Merge pull request #61890 from zhscn/fix-clang-19

crimson: fix compile errors in clang 19

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge pull request #61765 from Kushal-deb/fix_orch_ls_to_display_smb_ports
Adam King [Wed, 19 Feb 2025 17:51:00 +0000 (12:51 -0500)]
Merge pull request #61765 from Kushal-deb/fix_orch_ls_to_display_smb_ports

cephadm: ceph orch ls to Display SMB Service Ports

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61749 from rhcs-dashboard/sqlite-recursive-error-fix
Adam King [Wed, 19 Feb 2025 16:13:26 +0000 (11:13 -0500)]
Merge pull request #61749 from rhcs-dashboard/sqlite-recursive-error-fix

mgr/smb: add threading lock for SqliteStore

Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61833 from Kushal-deb/add_v4v6_flag_to_bind_port
Adam King [Wed, 19 Feb 2025 16:10:34 +0000 (11:10 -0500)]
Merge pull request #61833 from Kushal-deb/add_v4v6_flag_to_bind_port

cephadm: ingress- Add v4v6 flag to HAProxy bind directive

Reviewed-by: Adam King <adking@redhat.com>
4 months agolibrbd: fix a crash in get_rollback_snap_id 61906/head
N Balachandran [Wed, 19 Feb 2025 16:10:29 +0000 (21:40 +0530)]
librbd: fix a crash in get_rollback_snap_id

get_rollback_snap_id() did not check if the snapshot it was
accessing was a mirror snapshot, causing it to crash if it wasn't.

Fixes: https://tracker.ceph.com/issues/70075
Signed-off-by: N Balachandran <nithya.balachandran@ibm.com>
4 months agoMerge pull request #61722 from adk3798/stop-orch-on-cleanup
Adam King [Wed, 19 Feb 2025 16:06:48 +0000 (11:06 -0500)]
Merge pull request #61722 from adk3798/stop-orch-on-cleanup

qa/cephadm: stop cephadm mgr module during cleanup

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
4 months agoMerge pull request #61663 from adk3798/vrrp_interfaces_typo
Adam King [Wed, 19 Feb 2025 15:58:06 +0000 (10:58 -0500)]
Merge pull request #61663 from adk3798/vrrp_interfaces_typo

mgr/cephadm: fix typo with vrrp_interfaces in keepalive setup

Reviewed-by: Redouane Kachach <rkachach@ibm.com>
4 months agoMerge pull request #61658 from ShwetaBhosale1/fix_issue_69808_numric_node_id_for_rado...
Adam King [Wed, 19 Feb 2025 15:56:56 +0000 (10:56 -0500)]
Merge pull request #61658 from ShwetaBhosale1/fix_issue_69808_numric_node_id_for_rados_kv_block

mgr/nfs: nodeid should be numeric for RADOS_KV block in ganesha.conf file

Reviewed-by: Adam King <adking@redhat.com>
4 months agoMerge pull request #61587 from Kushal-deb/display_comma_separated_ports_for_RGW_services
Adam King [Wed, 19 Feb 2025 15:55:20 +0000 (10:55 -0500)]
Merge pull request #61587 from Kushal-deb/display_comma_separated_ports_for_RGW_services

mgr/cephadm: Display comma separated ports for RGW services

Reviewed-by: Adam King <adking@redhat.com>
4 months agoMerge pull request #61564 from Sodani/shsodani_profile
Adam King [Wed, 19 Feb 2025 15:53:56 +0000 (10:53 -0500)]
Merge pull request #61564 from Sodani/shsodani_profile

mgr/smb: Add profiling configuration to global definition

Reviewed-by: Anoop C S <anoopcs@samba.org>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61372 from adk3798/cephadm-orch-pause-test-failure
Adam King [Wed, 19 Feb 2025 15:51:20 +0000 (10:51 -0500)]
Merge pull request #61372 from adk3798/cephadm-orch-pause-test-failure

qa/cephadm: wait between starting and restarting osd in test_daemon_restart test

Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #60606 from Naveenaidu/naveen/telemetry-add-stretch-cluster
Laura Flores [Wed, 19 Feb 2025 15:51:06 +0000 (09:51 -0600)]
Merge pull request #60606 from Naveenaidu/naveen/telemetry-add-stretch-cluster

mgr/telemetry: add stretch cluster data

4 months agoqa/standalone: do not use /etc/fstab as an always-there bytes source 61812/head
Ronen Friedman [Thu, 13 Feb 2025 16:53:53 +0000 (10:53 -0600)]
qa/standalone: do not use /etc/fstab as an always-there bytes source

Multiple tests use /etc/fstab when a small data file is
required as input. After all, as some comments say:
    # something that is always there

Alas - it's not always there. Not in containers.

Replacing with a newly-created temporary file filled with
random bytes.
For completeness - replacing similar references to
/etc/resolv.conf (as a source for random objects) in
the standalone tests, too.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agoMerge pull request #61853 from ArbitCode/wip-rgw-raja-remove-clientid-oidc-provider
Raja [Wed, 19 Feb 2025 14:52:05 +0000 (20:22 +0530)]
Merge pull request #61853 from ArbitCode/wip-rgw-raja-remove-clientid-oidc-provider

rgw/iam: add RemoveClientIDFromOpenIDConnectProvider

4 months agomgr/dashboard: Rgw ratelimit feature for user and bucket 61225/head
Achintk1491 [Fri, 13 Dec 2024 07:38:33 +0000 (13:08 +0530)]
mgr/dashboard: Rgw ratelimit feature for user and bucket

Fixes: https://tracker.ceph.com/issues/69233
Signed-off-by: Achint Kaur<ackaur@redhat.com>
Signed-off-by: Achintk1491 <achintk1491@gmail.com>
4 months agoqa/workunits/nvmeof/fio_test.sh: add more debug commands 61788/head
Vallari Agrawal [Wed, 19 Feb 2025 11:48:49 +0000 (17:18 +0530)]
qa/workunits/nvmeof/fio_test.sh: add more debug commands

Add more commands to debug when fio fails:
- nvme list-subsys /dev/nvme1n2
- nvme list from the initiator
- nvme list | wc -l
- nvme id-ns /dev/nvme1n2

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
4 months agoqa/suites/nvmeof: Run fio with scalability test
Vallari Agrawal [Thu, 13 Feb 2025 11:21:48 +0000 (16:51 +0530)]
qa/suites/nvmeof: Run fio with scalability test

Run fio in parallel with scalability test.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
4 months agoqa/suites/nvmeof: add more asserts to scalability_test
Vallari Agrawal [Thu, 13 Feb 2025 07:15:55 +0000 (12:45 +0530)]
qa/suites/nvmeof: add more asserts to scalability_test

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
4 months agoqa/workunits/nvmeof/fio_test: Log cluster status if fio fails
Vallari Agrawal [Tue, 11 Feb 2025 11:45:42 +0000 (17:15 +0530)]
qa/workunits/nvmeof/fio_test: Log cluster status if fio fails

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
4 months agocrimson: fix -Wmissing-template-arg-list-after-template-kw 61890/head
Matan Breizman [Mon, 17 Feb 2025 10:08:11 +0000 (10:08 +0000)]
crimson: fix -Wmissing-template-arg-list-after-template-kw

See: https://github.com/llvm/llvm-project/commit/f46d1463b835560d90ad3ac02b63c771e4ebe566
```
common/interruptible_future.h:1182:16: error: a template argument list is expected after a name prefixed by the template keyword [-Wmissing-template-arg-list-after-template-kw]
 1182 |     ).template handle_interruption(std::move(efunc));
      |                ^
1 error generated.
```

Signed-off-by: Matan Breizman <mbreizma@redhat.com>