]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 months agoqa/workunits/rbd: wait for resize to be applied in rbd-nbd 62189/head
Ilya Dryomov [Sun, 9 Mar 2025 21:10:08 +0000 (22:10 +0100)]
qa/workunits/rbd: wait for resize to be applied in rbd-nbd

Implement the same logic as in commit 6f3d0f570f1a ("test/librbd/fsx:
wait for resize to propagate in krbd_resize()").

Fixes: https://tracker.ceph.com/issues/66419
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 months agoMerge pull request #61651 from anthonyeleven/improve-radosgw-layout
Anthony D'Atri [Fri, 7 Mar 2025 14:34:21 +0000 (09:34 -0500)]
Merge pull request #61651 from anthonyeleven/improve-radosgw-layout

doc/radosgw: Improve layout.rst

4 months agoMerge pull request #62158 from dang/wip-dang-68336
Casey Bodley [Fri, 7 Mar 2025 14:34:09 +0000 (09:34 -0500)]
Merge pull request #62158 from dang/wip-dang-68336

RGW - Temporarily disable List2Inotify1 in the posix bucket cache uni…

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
4 months agoMerge pull request #61933 from NitzanMordhai/wip-nitzan-logmonitor-forward-msg-noreply
SrinivasaBharathKanta [Fri, 7 Mar 2025 06:11:07 +0000 (11:41 +0530)]
Merge pull request #61933 from NitzanMordhai/wip-nitzan-logmonitor-forward-msg-noreply

LogMonitor: set no_reply for forward MLog commands

4 months agoMerge pull request #61934 from NitzanMordhai/wip-nitzan-remove-tier-cache-tests-rados...
SrinivasaBharathKanta [Fri, 7 Mar 2025 03:07:59 +0000 (08:37 +0530)]
Merge pull request #61934 from NitzanMordhai/wip-nitzan-remove-tier-cache-tests-rados-suite

suites/rados: cache tier deprecated, no need to keep the tests for it

4 months agoMerge pull request #61404 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequenc...
SrinivasaBharathKanta [Fri, 7 Mar 2025 03:06:39 +0000 (08:36 +0530)]
Merge pull request #61404 from JonBailey1993/JonBailey1993/ceph_test_rados_io_sequence_plugin_support

common/io_exerciser: ceph_test_rados_io_sequence plugin/profile support

4 months agoMerge pull request #61348 from Naveenaidu/naveen/wip-tracker-65450
SrinivasaBharathKanta [Fri, 7 Mar 2025 03:05:51 +0000 (08:35 +0530)]
Merge pull request #61348 from Naveenaidu/naveen/wip-tracker-65450

qa/tasks/thrashosds-health: whitelist PG_BACKFILL_FULL

4 months agoRGW - Temporarily disable List2Inotify1 in the posix bucket cache unit tests, until... 62158/head
Daniel Gryniewicz [Thu, 6 Mar 2025 15:56:24 +0000 (10:56 -0500)]
RGW - Temporarily disable List2Inotify1 in the posix bucket cache unit tests, until we can find why inotify fails on CI machines

Signed-off-by: Daniel Gryniewicz <dang@fprintf.net>
4 months agoMerge pull request #61659 from Matan-B/wip-matanb-cmake-crimson-boost-asio
Matan Breizman [Thu, 6 Mar 2025 15:07:44 +0000 (17:07 +0200)]
Merge pull request #61659 from Matan-B/wip-matanb-cmake-crimson-boost-asio

crimson/CMakeLists: cleanup BOOST_ASIO_DISABLE_CONCEPTS

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 months agoMerge pull request #61569 from soumyakoduri/wip-skoduri-tier-config
J. Eric Ivancich [Thu, 6 Mar 2025 15:03:13 +0000 (10:03 -0500)]
Merge pull request #61569 from soumyakoduri/wip-skoduri-tier-config

rgw/cloudtier: Correct option ordering in RGWZoneGroupPlacementTier

Reviewed-by: J. Eric Ivancich (ivancich@redhat.com)
4 months agoMerge PR #62108 into main
Patrick Donnelly [Thu, 6 Mar 2025 13:38:52 +0000 (08:38 -0500)]
Merge PR #62108 into main

* refs/pull/62108/head:
cmake/cephfs: fix options to enable client and dependencies

Reviewed-by: Krunal Chheda <kchheda3@bloomberg.net>
Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #62107 into main
Patrick Donnelly [Thu, 6 Mar 2025 13:37:51 +0000 (08:37 -0500)]
Merge PR #62107 into main

* refs/pull/62107/head:
pybind/cephfs: use legacy noexcept for cdefs for cython 3.Y.Z
pybind/cephfs: increment ref before calling out to c++

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge pull request #62028 from Matan-B/wip-matanb-crimson-mgrc-con
Matan Breizman [Thu, 6 Mar 2025 13:30:53 +0000 (15:30 +0200)]
Merge pull request #62028 from Matan-B/wip-matanb-crimson-mgrc-con

crimson/mgr/client: fix _send_report empty conn usage

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 months agoMerge pull request #61647 from mohit84/crimson_throttle
Matan Breizman [Thu, 6 Mar 2025 09:26:51 +0000 (11:26 +0200)]
Merge pull request #61647 from mohit84/crimson_throttle

crimson: Trigger a wake operation via acquire_throttle

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge pull request #62084 from xxhdx1985126/wip-70202
Matan Breizman [Thu, 6 Mar 2025 09:21:16 +0000 (11:21 +0200)]
Merge pull request #62084 from xxhdx1985126/wip-70202

crimson/os/seastore/linked_tree_node: set reserved_ptr to an 8-byte aligned address

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge pull request #62026 from guits/cv-api-lvm-refact
Guillaume Abrioux [Thu, 6 Mar 2025 07:00:13 +0000 (08:00 +0100)]
Merge pull request #62026 from guits/cv-api-lvm-refact

ceph-volume: Refactor LVM object handling

4 months agoMerge pull request #62012 from VallariAg/wip-vallari-subsystem-limit-alert
Vallari Agrawal [Thu, 6 Mar 2025 05:23:52 +0000 (10:53 +0530)]
Merge pull request #62012 from VallariAg/wip-vallari-subsystem-limit-alert

monitoring: fix NVMeoFSubsystemNamespaceLimit

4 months agoMerge pull request #62020 from cbodley/wip-70191
Adam Emerson [Wed, 5 Mar 2025 22:53:11 +0000 (17:53 -0500)]
Merge pull request #62020 from cbodley/wip-70191

rgw: use object ARN for InitMultipart permissions

Reviewed-by: J. Eric Ivancich <ivancich@redhat.com>
4 months agodoc/radosgw: Improve layout.rst 61651/head
Anthony D'Atri [Tue, 4 Feb 2025 16:37:16 +0000 (11:37 -0500)]
doc/radosgw: Improve layout.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoMerge pull request #62016 from zmc/bwc-for-pipeline
Zack Cerza [Wed, 5 Mar 2025 21:28:15 +0000 (14:28 -0700)]
Merge pull request #62016 from zmc/bwc-for-pipeline

build-with-container: Updates to support ceph-dev-pipeline

4 months agobuild-with-container.py: Add --rpmbuild-extra-args 62016/head
Zack Cerza [Tue, 25 Feb 2025 16:15:32 +0000 (09:15 -0700)]
build-with-container.py: Add --rpmbuild-extra-args

Signed-off-by: Zack Cerza <zack@cerza.org>
4 months agoDockerfile.build: Install sccache
Zack Cerza [Mon, 24 Feb 2025 19:30:13 +0000 (12:30 -0700)]
Dockerfile.build: Install sccache

Note that it is not used automatically.

Signed-off-by: Zack Cerza <zack@cerza.org>
4 months agobuild-with-container.py: Add --ceph-version
Zack Cerza [Thu, 13 Feb 2025 00:10:23 +0000 (17:10 -0700)]
build-with-container.py: Add --ceph-version

So that we can build from an extracted tarball, as opposed to a git repo.

Signed-off-by: Zack Cerza <zack@cerza.org>
4 months agomake-srpm.sh: Skip make-dist if tarball is present
Zack Cerza [Thu, 13 Feb 2025 00:10:01 +0000 (17:10 -0700)]
make-srpm.sh: Skip make-dist if tarball is present

Signed-off-by: Zack Cerza <zack@cerza.org>
4 months agobuild-with-container.py: Add --env-file
Zack Cerza [Sat, 8 Feb 2025 00:16:20 +0000 (17:16 -0700)]
build-with-container.py: Add --env-file

Signed-off-by: Zack Cerza <zack@cerza.org>
4 months agoMerge pull request #61939 from phlogistonjohn/jjm-bwc-updates-20250219
Zack Cerza [Wed, 5 Mar 2025 20:13:02 +0000 (13:13 -0700)]
Merge pull request #61939 from phlogistonjohn/jjm-bwc-updates-20250219

build-with-container: fixes and enhancements

4 months agocmake/cephfs: fix options to enable client and dependencies 62108/head
Casey Bodley [Wed, 5 Mar 2025 18:22:38 +0000 (13:22 -0500)]
cmake/cephfs: fix options to enable client and dependencies

invoking cmake with -DWITH_LIBCEPHFS=OFF fails to configure the client target:

CMake Error at src/client/CMakeLists.txt:13 (target_link_libraries):
  Target "client" links to:

    Boost::locale

  but the target was not found.  Possible reasons include:

    * There is a typo in the target name.
    * A find_package call is missing for an IMPORTED target.
    * An ALIAS target is missing.

because the client target is not conditional on WITH_LIBCEPHFS in src/CMakeLists.txt:

add_subdirectory(client)

if(WITH_LIBCEPHFS)

because client is also needed for ceph-fuse, make the client and its
dependencies depend on WITH_LIBCEPHFS OR WITH_FUSE

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agopybind/cephfs: use legacy noexcept for cdefs for cython 3.Y.Z 62107/head
Patrick Donnelly [Tue, 4 Mar 2025 14:45:23 +0000 (09:45 -0500)]
pybind/cephfs: use legacy noexcept for cdefs for cython 3.Y.Z

For some newer versions of cython, it appears it requires explicitly specifying
noexcept but old versions of Cython 0.29.Z do not understand that attribute.

See: https://cython.readthedocs.io/en/latest/src/userguide/migrating_to_cy30.html#exception-values-and-noexcept

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agopybind/cephfs: increment ref before calling out to c++
Patrick Donnelly [Wed, 5 Mar 2025 16:15:20 +0000 (11:15 -0500)]
pybind/cephfs: increment ref before calling out to c++

At the time this construction seemed safe since the caller should have a
reference but it could conveivably be the only ref. We don't want the ref count
to reach 0.

Additionally, catch errors so this callback is genuinely noexcept.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agotest/osd: Code formatting changes for plugin support in ceph_test_rados_io_support 61404/head
Jon Bailey [Thu, 30 Jan 2025 16:57:03 +0000 (16:57 +0000)]
test/osd: Code formatting changes for plugin support in ceph_test_rados_io_support

Modified variables used in ceph_test_rados_io_sequence to use snake_case instead of camelCase to be consistent with prior work.

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
4 months agotest/osd: Added support for new plugins
Jon Bailey [Wed, 15 Jan 2025 13:12:40 +0000 (13:12 +0000)]
test/osd: Added support for new plugins

Added new command line options for specifying plugins along with optional readers for them. Added arguments to JSON structures for some optional arguments to encode and decode more information about profiles. Added more choices for random selections of different plugin values and changed structure so profiles are created as part of a pool specifically, encapsulating them.

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
4 months agosrc/test/osd: Split reader classes for program options into a seperate class
Jon Bailey [Fri, 10 Jan 2025 13:24:04 +0000 (13:24 +0000)]
src/test/osd: Split reader classes for program options into a seperate class

Split the program option readers out into a seperate class from the main logic controlling the operationg of ceph_test_rados_io_sequence

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
4 months agosrc/test/osd: Move ceph_test_rados_io_sequence to its own subfolder
Jon Bailey [Thu, 9 Jan 2025 16:06:47 +0000 (16:06 +0000)]
src/test/osd: Move ceph_test_rados_io_sequence to its own subfolder

Move files for setting up the cpeh_test_rados_io_sequence to their own subfolder of test/osd so they can be grouped together as more files are added in the future.

Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
4 months agoerasure-code: Add minimum granularity interface to EC plugins
Jamie Pryde [Tue, 26 Nov 2024 10:00:25 +0000 (10:00 +0000)]
erasure-code: Add minimum granularity interface to EC plugins

Add get_minimum_granularity() function to the EC plugin interface,
which returns the minimum size in bytes that can be used for partial writes.
This is based on the minimum size of coding chunk update
that the particular technique supports.

Signed-off-by: Jamie Pryde <jamiepry@uk.ibm.com>
Signed-off-by: Jon Bailey <jonathan.bailey1@ibm.com>
4 months agoMerge pull request #61771 from aainscow/new_io_sequencer_sequences
Alex Ainscow [Wed, 5 Mar 2025 15:45:35 +0000 (15:45 +0000)]
Merge pull request #61771 from aainscow/new_io_sequencer_sequences

test: Add new sequences to the IO sequencer.

4 months agoMerge pull request #61263 from aainscow/legacy_ec
SrinivasaBharathKanta [Wed, 5 Mar 2025 14:04:49 +0000 (19:34 +0530)]
Merge pull request #61263 from aainscow/legacy_ec

OSD: Refactor EC to have two versions: Legacy and New EC

4 months agoMerge pull request #62075 from ronen-fr/wip-rf-more5-keys
Ronen Friedman [Wed, 5 Mar 2025 13:48:19 +0000 (15:48 +0200)]
Merge pull request #62075 from ronen-fr/wip-rf-more5-keys

bluestore, librados, msg: replace obsolete get_tracked_conf_keys()

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 months agocrimson/mgr/client: add Client::retry_interval() 62028/head
Matan Breizman [Mon, 3 Mar 2025 11:59:53 +0000 (11:59 +0000)]
crimson/mgr/client: add Client::retry_interval()

Could be useful in the future, for now a mere refactor.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agocrimson/mgr/client:Introduce Client::send()
Matan Breizman [Sun, 2 Mar 2025 14:33:07 +0000 (14:33 +0000)]
crimson/mgr/client:Introduce Client::send()

Client::reconnect nullifies the connection used by the mgr client
before setting a new one.

In this time, we might re-use the nullptr connection due to tasks
that are being run in the background (See: dispatch_in_background).

To avoid this, we had multiple `if (!conn)` checks, some methods
even checked this condition twice to reduce the possibilty of using
undefined the connection.

Instead of introducing an additional check in Client::_send_report,
Introduce Client::send which would be responsible for:
a) Veryfing the connection is set
b) Trying to get a shared access to conn_lock

Client::reconnect will lock conn_lock exclusivly until the
connection is set. If we send is called while reconnecting,
sending will be dropped - same as before.

Fixes: https://tracker.ceph.com/issues/70179
Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge pull request #62009 from Jayaprakash-ibm/wip-bdev-skip-aio-zero-size
Adam Kupczyk [Wed, 5 Mar 2025 12:07:25 +0000 (13:07 +0100)]
Merge pull request #62009 from Jayaprakash-ibm/wip-bdev-skip-aio-zero-size

blk/kernel : skip AIO thread for zero-sized devices

4 months agoMerge pull request #59429 from rhcs-dashboard/carbon-forms-rgw
Nizamudeen A [Wed, 5 Mar 2025 11:03:18 +0000 (16:33 +0530)]
Merge pull request #59429 from rhcs-dashboard/carbon-forms-rgw

mgr/dashboard: carbonize rgw user and bucket form

4 months agotest: ceph_test_rados_io_sequence - seq 14 - write object filling gaps 61771/head
Bill Scales [Mon, 16 Dec 2024 13:03:51 +0000 (13:03 +0000)]
test: ceph_test_rados_io_sequence - seq 14 - write object filling gaps

New sequence - write object initially with gaps and fill in the holes
until the object is fully populated. Permutate the step (gap between
writes), start at randomized offsets to produce gaps at the start of
the object as well as between writes

Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>
4 months agotest: ceph_test_rados_io_sequence - scripting enhancements
Bill Scales [Wed, 11 Dec 2024 08:30:37 +0000 (08:30 +0000)]
test: ceph_test_rados_io_sequence - scripting enhancements

Scripting enhancements for interactive mode - ignore lines
begining with #, add a sleep command

Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>
4 months agotest: ceph_test_rados_io_sequence - add truncate
Bill Scales [Tue, 10 Dec 2024 10:51:16 +0000 (10:51 +0000)]
test: ceph_test_rados_io_sequence - add truncate

Add support for truncate I/O in interactive mode

Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>
4 months agotest: ceph_test_rados_io_sequence - add append with gaps sequence
Bill Scales [Fri, 29 Nov 2024 11:12:40 +0000 (11:12 +0000)]
test: ceph_test_rados_io_sequence - add append with gaps sequence

New I/O sequence - appends to objects by writing past the old
object length so there is a gap before the new written data.
Tests permutations of write length and gap length.

Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>
4 months agotest: ceph_test_rados_io_sequence append sequences
Bill Scales [Wed, 27 Nov 2024 13:07:14 +0000 (13:07 +0000)]
test: ceph_test_rados_io_sequence append sequences

Sequence 11 - sequential appends of fixed size
Sequence 12 - sequentiial overwrite+append of fixed size and different offsets

Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>
4 months agotest: ceph_test_rados_io_sequence support appends
Bill Scales [Wed, 27 Nov 2024 10:33:28 +0000 (10:33 +0000)]
test: ceph_test_rados_io_sequence support appends

1. Add append I/O to extend size of object
2. Allow write I/Os to extend size of object
3. Make interactive mode handle EOF gracefully

Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>
4 months agomgr/dashboard: carbonize rgw user and bucket form 59429/head
Nizamudeen A [Wed, 23 Oct 2024 15:12:21 +0000 (20:42 +0530)]
mgr/dashboard: carbonize rgw user and bucket form

Fixes: https://tracker.ceph.com/issues/70119
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agoMerge pull request #61744 from rhcs-dashboard/mgr-api-test-fixes
Nizamudeen A [Wed, 5 Mar 2025 05:24:29 +0000 (10:54 +0530)]
Merge pull request #61744 from rhcs-dashboard/mgr-api-test-fixes

qa/tests: retry the api call after making the request

4 months agoMerge pull request #61533 from clwluvw/prepare-op-cleanup
J. Eric Ivancich [Wed, 5 Mar 2025 02:17:40 +0000 (21:17 -0500)]
Merge pull request #61533 from clwluvw/prepare-op-cleanup

rgw: remove unused log op info from prepare_op

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge pull request #61942 from 9401adarsh/wip-adashoka-51855
J. Eric Ivancich [Wed, 5 Mar 2025 02:17:13 +0000 (21:17 -0500)]
Merge pull request #61942 from 9401adarsh/wip-adashoka-51855

rgw: add parameter for clients to time out incase they hit wrong url

Reviewed-by: Yuval Lifshitz <ylifshit@ibm.com>
4 months agoMerge pull request #61944 from kchheda3/wip-fix-opslog-crash
J. Eric Ivancich [Wed, 5 Mar 2025 02:16:47 +0000 (21:16 -0500)]
Merge pull request #61944 from kchheda3/wip-fix-opslog-crash

rgw/log: Fix crash during shutdown with ops-log enable.

Reviewed-By: Oguzhan Ozmen <oozmen@bloomberg.net>
4 months agoMerge pull request #62018 from cbodley/wip-rgw-admin-threads
J. Eric Ivancich [Wed, 5 Mar 2025 02:16:29 +0000 (21:16 -0500)]
Merge pull request #62018 from cbodley/wip-rgw-admin-threads

radosgw-admin: lower default thread pool size

Reviewed-By: Oguzhan Ozmen <oozmen@bloomberg.net>
4 months agoMerge pull request #61907 from cbodley/wip-70084
J. Eric Ivancich [Wed, 5 Mar 2025 02:15:45 +0000 (21:15 -0500)]
Merge pull request #61907 from cbodley/wip-70084

rgw: /admin/account APIs accept negative values

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
4 months agocrimson/os/seastore/linked_tree_node: set reserved_ptr to an 8-byte 62084/head
Xuehan Xu [Mon, 3 Mar 2025 10:07:25 +0000 (18:07 +0800)]
crimson/os/seastore/linked_tree_node: set reserved_ptr to an 8-byte
aligned address

Maybe we shouldn't be using an instant integer as the invalid pointer.

Fixes: https://tracker.ceph.com/issues/70202
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>
4 months agoMerge pull request #61158 from avanthakkar/fence-old-ranks-smb
Adam King [Tue, 4 Mar 2025 19:13:06 +0000 (14:13 -0500)]
Merge pull request #61158 from avanthakkar/fence-old-ranks-smb

cephadm: fence old ranks for SMB service

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #62103 from rhcs-dashboard/revert-pr-61089
Ernesto Puerta [Tue, 4 Mar 2025 19:10:13 +0000 (20:10 +0100)]
Merge pull request #62103 from rhcs-dashboard/revert-pr-61089

mgr/dashboard: Revert PR 61089

4 months agoMerge pull request #60844 from VinayBhaskar-V/main
Ilya Dryomov [Tue, 4 Mar 2025 18:53:54 +0000 (19:53 +0100)]
Merge pull request #60844 from VinayBhaskar-V/main

librbd: add rbd_diff_iterate3() API to take source snapshot by ID

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
4 months agoMerge pull request #62072 from idryomov/wip-70190
Ilya Dryomov [Tue, 4 Mar 2025 18:51:12 +0000 (19:51 +0100)]
Merge pull request #62072 from idryomov/wip-70190

librbd: fix a deadlock on image_lock caused by Mirror::image_disable()

Reviewed-by: Ramana Raja <rraja@redhat.com>
4 months agorgw/cloudtier: Correct option ordering in RGWZoneGroupPlacementTier 61569/head
Soumya Koduri [Wed, 29 Jan 2025 16:17:45 +0000 (21:47 +0530)]
rgw/cloudtier: Correct option ordering in RGWZoneGroupPlacementTier

Two tier-config options (related to `cloud-restore`) were incorrectly added
in the middle of the encoding and decoding methods of RGWZoneGroupPlacementTier.
This modification can cause compatibility issues with older decoders when
attempting to read v2-encoded REST objects.

The fix is to correct the option order and update the decode() function to
properly interpret the structure based on the encoded version.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
4 months agoMerge pull request #61930 from thotz/s3-tests-verify-restore
Soumya Koduri [Tue, 4 Mar 2025 16:39:04 +0000 (22:09 +0530)]
Merge pull request #61930 from thotz/s3-tests-verify-restore

qa/rgw: add new teuthology for cloud restore s3 tests

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Soumya Koduri <skoduri@redhat.com>
4 months agoMerge pull request #61364 from ifed01/wip-ifed-no-compression-plugin-reload
Jaya Prakash [Tue, 4 Mar 2025 15:03:31 +0000 (20:33 +0530)]
Merge pull request #61364 from ifed01/wip-ifed-no-compression-plugin-reload

os/bluestore: do cache locally compressor engines ever used.

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
4 months agoMerge pull request #61908 from Jayaprakash-ibm/wip-time-measure-fix
Jaya Prakash [Tue, 4 Mar 2025 15:01:37 +0000 (20:31 +0530)]
Merge pull request #61908 from Jayaprakash-ibm/wip-time-measure-fix

os/bluestore : Assigning a named variable to ceph::time_guard to prevent immediate destruction

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Reviewed-by: Radoslaw Zarzynski <rzarzynski@redhat.com>
4 months agoMerge pull request #61882 from liu-chunmei/fault_range
Jaya Prakash [Tue, 4 Mar 2025 15:00:06 +0000 (20:30 +0530)]
Merge pull request #61882 from liu-chunmei/fault_range

os/bluestore: fix fault_range for _do_write_v2

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
4 months agoMerge pull request #61843 from ifed01/wip-ifed-fix-expand
Jaya Prakash [Tue, 4 Mar 2025 14:59:36 +0000 (20:29 +0530)]
Merge pull request #61843 from ifed01/wip-ifed-fix-expand

os/bluestore: fix bdev expansion and more

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
4 months agoMerge pull request #61502 from Jayaprakash-ibm/wip-refactor-allocator-class
Jaya Prakash [Tue, 4 Mar 2025 14:57:54 +0000 (20:27 +0530)]
Merge pull request #61502 from Jayaprakash-ibm/wip-refactor-allocator-class

os/bluestore : Refactoring Allocator Class

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
4 months agoRevert "pybind/mgr: Protobuffer file generation for grpc deps." 62103/head
Nizamudeen A [Tue, 4 Mar 2025 14:13:26 +0000 (19:43 +0530)]
Revert "pybind/mgr: Protobuffer file generation for grpc deps."

This reverts commit 0ff89b041dcdb1a3322294a714630859412631d5.

Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agoRevert "pybind/mgr: Generate pb2 file in src/pybind/mgr/dashboard/services/proto...
Nizamudeen A [Tue, 4 Mar 2025 14:13:15 +0000 (19:43 +0530)]
Revert "pybind/mgr: Generate pb2 file in src/pybind/mgr/dashboard/services/proto using the protobuf file from the gateway submodule."

This reverts commit 7f2e1910af05803e5d19c993344a5b7f13040259.

Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agoRevert "Move proto generation code block out of if(WITH_MGR_DASHBOARD_FRONTEND)."
Nizamudeen A [Tue, 4 Mar 2025 14:12:46 +0000 (19:42 +0530)]
Revert "Move proto generation code block out of if(WITH_MGR_DASHBOARD_FRONTEND)."

This reverts commit 37e633384b7c18893bc0e30a8f3967f6496da00b.

Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agoMerge pull request #61596 from cbodley/wip-69741
Casey Bodley [Tue, 4 Mar 2025 14:32:40 +0000 (09:32 -0500)]
Merge pull request #61596 from cbodley/wip-69741

qa/rgw: fix user cleanup in s3tests task

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
4 months agocrimson/mgr/client: partial move to coroutines
Matan Breizman [Sun, 2 Mar 2025 10:48:37 +0000 (10:48 +0000)]
crimson/mgr/client: partial move to coroutines

Avoid moving capturing lambdas to coroutines.
Specifically lambdas which are passed to dispatch_in_background.

See: https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rcoro-capture

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agocrimson/mgr/client: update logger
Matan Breizman [Sun, 2 Mar 2025 09:55:13 +0000 (09:55 +0000)]
crimson/mgr/client: update logger

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agoqa/suites/orch: add a test to verify ctdb_status doesn't include GONE node 61158/head
Avan Thakkar [Thu, 9 Jan 2025 15:40:16 +0000 (21:10 +0530)]
qa/suites/orch: add a test to verify ctdb_status doesn't include GONE node

Signed-off-by: Avan Thakkar <athakkar@redhat.com>
4 months agoMerge PR #60726 into main
Venky Shankar [Tue, 4 Mar 2025 12:52:34 +0000 (18:22 +0530)]
Merge PR #60726 into main

* refs/pull/60726/head:
qa: add test checking 'journal import' from empty dump file
cephfs-journal-tool: fix segfault during 'journal import' from invalid dump file

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge pull request #60938 from joscollin/wip-fix-try-lock
Venky Shankar [Tue, 4 Mar 2025 12:51:23 +0000 (18:21 +0530)]
Merge pull request #60938 from joscollin/wip-fix-try-lock

cephfs_mirror: do not log the previous error

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge pull request #61073 from ljflores/tracker-69098
Venky Shankar [Tue, 4 Mar 2025 12:45:42 +0000 (18:15 +0530)]
Merge pull request #61073 from ljflores/tracker-69098

qa/suites/fs/upgrade/mds_upgrade_sequence/tasks: set require-osd-release

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge pull request #61076 from joscollin/wip-B69232-test_cephfs_mirror_stats_fail
Venky Shankar [Tue, 4 Mar 2025 12:44:33 +0000 (18:14 +0530)]
Merge pull request #61076 from joscollin/wip-B69232-test_cephfs_mirror_stats_fail

qa: fix test_cephfs_mirror_stats failure

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoqa/rgw: add new teuthology for cloud restore s3 tests 61930/head
Jiffin Tony Thottan [Tue, 18 Feb 2025 07:34:00 +0000 (13:04 +0530)]
qa/rgw: add new teuthology for cloud restore s3 tests

Signed-off-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
4 months agotest/pybind/rbd: fix read offset in write zeroes tests 60844/head
Ilya Dryomov [Mon, 3 Mar 2025 16:59:35 +0000 (17:59 +0100)]
test/pybind/rbd: fix read offset in write zeroes tests

Random data is written and write zeroes is invoked on 0~256, but the
read is done on 256~256.  This means that if write zeroes malfunctions
the test wouldn't catch it (especially in the thick provision case).

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 months agolibrbd: add rbd_diff_iterate3() API to take source snapshot by ID
VinayBhaskar-V [Tue, 26 Nov 2024 11:18:51 +0000 (16:48 +0530)]
librbd: add rbd_diff_iterate3() API to take source snapshot by ID

Allow a diff to start from a non-user snapshot.  This would be used by
"rbd du" command to account for non-user snapshots which are currently
just skipped potentially resulting in underreported space usage and in
other places.

Fixes: https://tracker.ceph.com/issues/65720
Co-authored-by: Ilya Dryomov <idryomov@gmail.com>
Signed-off-by: Vinay Bhaskar Varada <vvarada@redhat.com>
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
4 months agoMerge pull request #61433 from smanjara/wip-fix-tenant-replication
J. Eric Ivancich [Mon, 3 Mar 2025 19:02:19 +0000 (14:02 -0500)]
Merge pull request #61433 from smanjara/wip-fix-tenant-replication

rgw/multisite: fix forwarded requests for tenanted buckets

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge pull request #61421 from clwluvw/replication-conf
J. Eric Ivancich [Mon, 3 Mar 2025 19:01:12 +0000 (14:01 -0500)]
Merge pull request #61421 from clwluvw/replication-conf

rgw: handle destination bucket as an ARN in ReplicationConfiguration

Reviewed-by: Adam Emerson <aemerson@redhat.com>
4 months agoMerge pull request #60990 from umesh-mv/wip-umeshmv-67933
J. Eric Ivancich [Mon, 3 Mar 2025 18:58:07 +0000 (13:58 -0500)]
Merge pull request #60990 from umesh-mv/wip-umeshmv-67933

rgw/rgw_zone : fixing inline-data default value

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge pull request #61650 from cbodley/wip-rgw-delete-full-try
Casey Bodley [Mon, 3 Mar 2025 17:03:09 +0000 (12:03 -0500)]
Merge pull request #61650 from cbodley/wip-rgw-delete-full-try

rgw/rados: enable object deletion at rados pool quota

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
4 months agoMerge PR #61321 into main
Patrick Donnelly [Mon, 3 Mar 2025 13:34:58 +0000 (08:34 -0500)]
Merge PR #61321 into main

* refs/pull/61321/head:
qa: update require-osd-release to tentacle
tools/monmaptool: bump new cluster version to X
doc/dev/release-checklists: remove ceph-container task
script/ceph-release-notes: add squid/tentacle
doc/dev/release-checklists:: mark task complete
doc/dev/release-checklist: add nightlies task
doc/dev/release-checklists: update ceph-build for tentacle
doc/dev/release-checklists: note redmine is done
qa: update to tentacle
doc/dev/release-checklist: question telemetry tentacle test
osd/OSDMap: update to tentacle
qa/workunits/cephtool/test: update to tentacle
mon/OSDMonitor: update to tentacle
common/options/global.yaml.in: update for tentacle
mon/MgrMonitor: update for tentacle
qa/standalone/mon/misc: update for tentacle
doc: update compatset for tentacle
doc: no deprecated features
include/ceph_features: add SERVER_TENTACLE feature bit
cephadm,ceph-volume: update to tentacle
doc/dev/release-checklist: add backport-create-issue
script: update backport-resolve-issue to tentacle
*: add constants and release names
ceph_release: update to tentacle
librbd: bump version
CMakeLists.txt: update VERSION
doc: remove obsolete checklist item
doc: reset for tentacle

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Ilya Dryomov <idryomov@redhat.com>
4 months agoMerge PR #60746 into main v20.0.0
Patrick Donnelly [Mon, 3 Mar 2025 13:31:36 +0000 (08:31 -0500)]
Merge PR #60746 into main

* refs/pull/60746/head:
client: skip unexpected command replies
mgr: indicate map message is acked instead of unhandled
osdc/Objecter: convert to ms_dispatch2 for ack
client: indicate maps are acked not processed
msg: add alternate statuses for ms_dispatch2 handling
tools/cephfs_mirror: do not process maps with fast dispatch
doc: add docs for volumes interface for charmap
qa: add tests for subvolume charmap settings
pybind/mgr/volumes: wire up charmap for subvol/subvolgroup
pybind/mgr: send MDS commands through cephfs client
pybind/cephfs: wire up mds_command2
mgr: add module method to send notifications
libcephfs: add mds_command2 for asynchronous commands
mgr: excise CephFS client from mgr C++ base
mgr: use std namespace
doc: add docs for CephFS charmap config
qa: add charmap tests
qa: add helpful exceptions for attr changes
qa: ignore libicu leaks
client: add wrappings for charmap manipuluation of dentry names
client: add dir_result_t::dentry::print
win32: add libicu Windows build
CMakeLists: add boost::locale dependency for client
install-deps: unconditionally install boost libraries
test/libcephfs: update root operation return values
client: refactor all path traversals through path_walk
test/libcephfs: test parallel creates
test/libcephfs: add test for lookup failure after readdir
client: init dentry shared_gen with invalid value
client: add _lookup debugging
client: remove redundant check
client: dump InodeStat from mds
mds: encode optmetadata in InodeStat sent to clients
mds: check client features for charmap
mds: add client feature bit for charmap
mds: wire up vxattr for changing charmap
mds: inherit charmap on mkdir
mds,include: add charmap optmetadata
mds,include: add inode_t optional metadata
client: hide alternate_name from API
client: move alternate_name once
client: optimize alternate_name passing to helper
client: relocate definition
client: print dentry with alternate_name on dump
client: move inode dump to print method
mds: add debugging for encoding lease stat
mds: make encode_lease a proper method
mds: add fscrypt metadata for inode stat size
client: use DentryRef for ref counting in MetaRequest
client: add DentryRef
client: add helper for determining if a perm check is necessary
client: cache client_permissions config
client: add debugging for conf changes
client: sort configs
client/UserPerm: add print method
client: note mount parameters in debug log
client: print stat mode in octal
common: add missing op string
include/filepath: add empty path check

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge pull request #61735 from Matan-B/wip-matanb-crimson-seastar-feb-25
Matan Breizman [Mon, 3 Mar 2025 12:55:00 +0000 (14:55 +0200)]
Merge pull request #61735 from Matan-B/wip-matanb-crimson-seastar-feb-25

seastar: bump up seastar submodule

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 months agoMerge pull request #61983 from adk3798/cephadm-fix-apply-same-nvmeof-service
Adam King [Mon, 3 Mar 2025 12:38:49 +0000 (07:38 -0500)]
Merge pull request #61983 from adk3798/cephadm-fix-apply-same-nvmeof-service

mgr/cephadm: don't block matching group for identical nvmeof services

Reviewed-by: Aviv Caro <133020857+caroav@users.noreply.github.com>
4 months agoceph-volume: Refactor is_ceph_device to simplify error handling 62026/head
Guillaume Abrioux [Thu, 27 Feb 2025 07:53:59 +0000 (08:53 +0100)]
ceph-volume: Refactor is_ceph_device to simplify error handling

Replace the try-except block with a direct get() call on lv.tags to
check for ceph.osd_id. This avoids catching AttributeError unnecessarily
and makes the logic more concise. Additionally, the warning message is
now logged when osd_id is None or 'null', ensuring consistency in
error handling.
Also, this fixes the unit test `api/test_lvm.py::TestVolume::test_is_not_ceph_device()`
as `api.lvm.is_ceph_device()` expects a `Volume` object.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
4 months agoceph-volume: Introduce new `Lvm` base class to unify LVM object handling
Guillaume Abrioux [Mon, 3 Mar 2025 07:21:23 +0000 (08:21 +0100)]
ceph-volume: Introduce new `Lvm` base class to unify LVM object handling

This commit introduces a new `Lvm` base class to streamline LVM related objects
(`PVolume`, `VolumeGroup`, and `Volume`) by consolidating shared logic.

Key changes:
- `Lvm` centralizes common attributes like `name`, `tags`, `path`, and `binary_change`.
- `clear_tags`, `clear_tag`, `set_tag`, and `set_tags` are now defined in `Lvm`,
  reducing code duplication.
- `PVolume`, `VolumeGroup`, and `Volume` inherit from `Lvm`,
  simplifying their constructors.
- The redundant `_format_tag_args` and tag manipulation methods in
  child classes are removed.

This refactor improves maintainability by reducing code duplication
while preserving the existing API behavior.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
4 months agoceph-volume: refactors `api.lvm.Volume._format_tag_args`
Guillaume Abrioux [Thu, 27 Feb 2025 10:22:18 +0000 (11:22 +0100)]
ceph-volume: refactors `api.lvm.Volume._format_tag_args`

This replaces the previous approach using `list(sump(zip(repeat(op), tag_args), ()))` with a
more explicit loop-based implementation.
This makes the logic clearer while maintaining the same functionality.

Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
4 months agotest/crimson/seastore/CMakeLists: [arm64] disable omap manager 61735/head
Matan Breizman [Mon, 3 Mar 2025 09:31:56 +0000 (09:31 +0000)]
test/crimson/seastore/CMakeLists: [arm64] disable omap manager

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agocrimson: bump up seastar fixes
Matan Breizman [Sun, 9 Feb 2025 14:50:53 +0000 (14:50 +0000)]
crimson: bump up seastar fixes

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agoseastar: bump up seastar submodule
Matan Breizman [Sun, 9 Feb 2025 10:55:08 +0000 (10:55 +0000)]
seastar: bump up seastar submodule

Update branch to wip-matanb-seastar-feb-25

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge pull request #61494 from mohit84/seastar_configure
Matan Breizman [Mon, 3 Mar 2025 08:15:59 +0000 (10:15 +0200)]
Merge pull request #61494 from mohit84/seastar_configure

crimson: Provide an options to configure several seastar parameters

Reviewed-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge pull request #61874 from rhcs-dashboard/edit-storage-class
Nizamudeen A [Mon, 3 Mar 2025 05:23:42 +0000 (10:53 +0530)]
Merge pull request #61874 from rhcs-dashboard/edit-storage-class

mgr/dashboard: RGW - Edit Storage Class

Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
4 months agoMerge pull request #61866 from xxhdx1985126/wip-seastore-omap-binary-search
Yingxin Cheng [Mon, 3 Mar 2025 02:25:32 +0000 (10:25 +0800)]
Merge pull request #61866 from xxhdx1985126/wip-seastore-omap-binary-search

crimson/os/seastore/omap_manager: do binary search on omap nodes

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 months agoMerge pull request #62076 from anthonyeleven/clarify-stretch-device-class
Zac Dover [Sun, 2 Mar 2025 20:51:34 +0000 (06:51 +1000)]
Merge pull request #62076 from anthonyeleven/clarify-stretch-device-class

doc/rados/operations: Clarify stretch mode vs device class

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agoMerge pull request #61643 from rhcs-dashboard/nvmeof-img-trash
afreen23 [Sun, 2 Mar 2025 20:05:45 +0000 (01:35 +0530)]
Merge pull request #61643 from rhcs-dashboard/nvmeof-img-trash

mgr/dashboard: nvmeof trash rbd image on namespace rm

Reviewed-by: Afreen Misbah <afreen@ibm.com>
4 months agodoc/rados/operations: Clarify stretch mode vs device class 62076/head
Anthony D'Atri [Sun, 2 Mar 2025 15:43:18 +0000 (10:43 -0500)]
doc/rados/operations: Clarify stretch mode vs device class

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>