]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
4 months ago.github/workflows,script: add test for missing .qa links 62439/head
Patrick Donnelly [Fri, 21 Mar 2025 17:12:01 +0000 (13:12 -0400)]
.github/workflows,script: add test for missing .qa links

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoqa: add missing .qa links
Patrick Donnelly [Fri, 21 Mar 2025 16:52:49 +0000 (12:52 -0400)]
qa: add missing .qa links

    find qa/suites/ -type d -execdir ln -sfT ../.qa/ {}/.qa \;

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #61084 from adamemerson/wip-boost-1.87
Yuri Weinstein [Thu, 20 Mar 2025 22:40:53 +0000 (15:40 -0700)]
Merge pull request #61084 from adamemerson/wip-boost-1.87

Boost 1.87

Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>
4 months agoMerge pull request #62285 from cbodley/wip-rgw-iam-arnlike
J. Eric Ivancich [Thu, 20 Mar 2025 19:25:20 +0000 (15:25 -0400)]
Merge pull request #62285 from cbodley/wip-rgw-iam-arnlike

rgw/iam: add policy evaluation for Arn-based Conditions

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
4 months agoMerge pull request #62368 from ivancich/wip-radoslist-improvements
J. Eric Ivancich [Thu, 20 Mar 2025 19:23:42 +0000 (15:23 -0400)]
Merge pull request #62368 from ivancich/wip-radoslist-improvements

rgw: radoslist improvements primarily to better support gap list tool

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
4 months agoMerge pull request #62166 from rkachach/fix_issue_70352
Adam King [Thu, 20 Mar 2025 14:41:51 +0000 (10:41 -0400)]
Merge pull request #62166 from rkachach/fix_issue_70352

mgr/cephadm: use ip_hash to enforce the same prometheues upstream

Reviewed-by: Adam King <adking@redhat.com>
4 months agoMerge pull request #61873 from rhcs-dashboard/nfs-create-cluster
Nizamudeen A [Thu, 20 Mar 2025 11:59:46 +0000 (17:29 +0530)]
Merge pull request #61873 from rhcs-dashboard/nfs-create-cluster

mgr/dashboard: NFS Cluster and Export Listing

4 months agoMerge pull request #62387 from rhcs-dashboard/user-form-display-name-fix
afreen23 [Thu, 20 Mar 2025 11:02:10 +0000 (16:32 +0530)]
Merge pull request #62387 from rhcs-dashboard/user-form-display-name-fix

mgr/dashboard: Not able to edit user display/full name in user form

Reviewed-by: Afreen Misbah <afreen@ibm.com>
4 months agoMerge pull request #62397 from aainscow/interval_set_qf
Alex Ainscow [Thu, 20 Mar 2025 08:55:15 +0000 (08:55 +0000)]
Merge pull request #62397 from aainscow/interval_set_qf

test/common: skip google tests which create core dumps in test_interval_set

Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
4 months agoMerge pull request #61937 from vshankar/wip-file-block-diff
Kotresh HR [Thu, 20 Mar 2025 08:42:16 +0000 (14:12 +0530)]
Merge pull request #61937 from vshankar/wip-file-block-diff

mds/client: file blockdiff support

4 months agoMerge pull request #62244 from ronen-fr/wip-rf-cast-conf
Ronen Friedman [Thu, 20 Mar 2025 07:48:58 +0000 (09:48 +0200)]
Merge pull request #62244 from ronen-fr/wip-rf-cast-conf

common, osd: add cmd_getval_cast_or()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Alex Ainscow <aainscow@uk.ibm.com>
4 months agomgr/nfs: NFS Cluster and Export Listing 61873/head
Achintk1491 [Tue, 18 Feb 2025 12:31:22 +0000 (18:01 +0530)]
mgr/nfs: NFS Cluster and Export Listing

Fixes: https://tracker.ceph.com/issues/70022
Signed-off-by: Achint Kaur <ackaur@redhat.com>
4 months agoMerge pull request #61075 from rhcs-dashboard/topicmanagment
Nizamudeen A [Thu, 20 Mar 2025 05:29:44 +0000 (10:59 +0530)]
Merge pull request #61075 from rhcs-dashboard/topicmanagment

mgr/dashboard: Add RGW topics endpoint creation for create ,delete and list in dashboard

4 months agoMerge pull request #62323 from clwluvw/bucket-replication-mismatch
J. Eric Ivancich [Thu, 20 Mar 2025 04:40:12 +0000 (00:40 -0400)]
Merge pull request #62323 from clwluvw/bucket-replication-mismatch

rgw: reject PutBucketReplication policies with mismatched statuses, skip sync on update

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge pull request #62149 from rhcs-dashboard/fix-access-perm-ui
afreen23 [Thu, 20 Mar 2025 02:35:50 +0000 (08:05 +0530)]
Merge pull request #62149 from rhcs-dashboard/fix-access-perm-ui

mgr/dashboard: fix access control permissions for roles

Reviewed-by: Afreen Misbah <afreen@ibm.com>
4 months agorgw: radolist clean up, calculate obj info slightly earlier 62368/head
J. Eric Ivancich [Tue, 18 Mar 2025 19:10:35 +0000 (15:10 -0400)]
rgw: radolist clean up, calculate obj info slightly earlier

With recent changes, it's better to determine bucket and object names
earlier.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
4 months agorgw: modify radoslist to better support the rgw-gap-list tool
J. Eric Ivancich [Tue, 18 Mar 2025 18:33:42 +0000 (14:33 -0400)]
rgw: modify radoslist to better support the rgw-gap-list tool

When the `radosgw-admin bucket radoslist ...` sub-command was
introduced, it was written specifically for finding orphans. It has
since been updated to work for finding gaps, that is indexed RGW
objects that are missing one or more supporting rados objects.

When a head object was not found, it was ignored. Now it does produce
output with the oid and related information for the missing head
object.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
4 months agorgw: fix regression in radoslist with SLO manifests
J. Eric Ivancich [Tue, 18 Mar 2025 18:31:05 +0000 (14:31 -0400)]
rgw: fix regression in radoslist with SLO manifests

A regression was inadvertently introduced in commit
bcd7883d7212c96ebfb89c938c79fc7efbb80d2f that then prevented
`radosgw-admin bucket radoslist ...` from working properly with
buckets using SLO manifests. This corrects that regression.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
4 months agoMerge pull request #62394 from laimis9133/laims9133-notiffix
Zac Dover [Thu, 20 Mar 2025 01:29:33 +0000 (11:29 +1000)]
Merge pull request #62394 from laimis9133/laims9133-notiffix

doc/radosgw/notifications: fix topic details

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
4 months agoMerge pull request #62372 from tchaikov/libcephfs-proxy-compare-unsigned
Kefu Chai [Thu, 20 Mar 2025 01:26:40 +0000 (09:26 +0800)]
Merge pull request #62372 from tchaikov/libcephfs-proxy-compare-unsigned

libcephfs_proxy: remove redundant unsigned >= 0 comparison

Reviewed-by: Xavi Hernandez <xhernandez@gmail.com>
Reviewed-by: Sachin Punadikar <sachin.punadikar@ibm.com>
4 months agoMerge pull request #62206 from rhcs-dashboard/smb-overview
afreen23 [Wed, 19 Mar 2025 22:39:14 +0000 (04:09 +0530)]
Merge pull request #62206 from rhcs-dashboard/smb-overview

monitoring: add SMB overview grafana dashboard

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #62262 from ankitk18/fix/notification-icon-click
afreen23 [Wed, 19 Mar 2025 22:21:53 +0000 (03:51 +0530)]
Merge pull request #62262 from ankitk18/fix/notification-icon-click

mgr/dashboard:fixed issue with notification icon

Reviewed-by: Afreen Misbah <afreen@ibm.com>
4 months agoMerge pull request #62169 from anoopcs9/mgr-smb-add-ceph-snapshots
Adam King [Wed, 19 Mar 2025 18:01:41 +0000 (14:01 -0400)]
Merge pull request #62169 from anoopcs9/mgr-smb-add-ceph-snapshots

mgr/smb: Add ceph_snapshots vfs module to share definition

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>
4 months agomgr/dashboard: add types for mgr-module list 62149/head
Nizamudeen A [Fri, 14 Mar 2025 07:10:45 +0000 (12:40 +0530)]
mgr/dashboard: add types for mgr-module list

also introducing a const for rgw

Fixes: https://tracker.ceph.com/issues/70331
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: fix access control permissions for roles
Nizamudeen A [Wed, 5 Mar 2025 16:46:03 +0000 (22:16 +0530)]
mgr/dashboard: fix access control permissions for roles

Since prometheus is being used in the dashboard page we need to make
sure every role has prometheus read only access so that the dashboard
page can load the utilization metrics.

I also saw permission issue with the osd settings endpoint when its
trying to get the nearfull/full ratio. so instead of failing the entire
page i am proceeding with a chart that doesn't have those details when
the user doesn't have permission to access the config opt.

Multisite page was not accessible in the case of rgw-manager or
read-only user because its trying to show the status of rgw module. This
si also now gracefully handled to show the alert only when the user has
sufficient permission.

Fixes: https://tracker.ceph.com/issues/70331
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agotest/common: skip google tests which create core dumps in test_interval_set 62397/head
Alex Ainscow [Wed, 19 Mar 2025 13:59:35 +0000 (13:59 +0000)]
test/common: skip google tests which create core dumps in test_interval_set

CI Pipelines are being broken because this test is creating a number of core dumps. This
does not make the test fail, but it does create some core dumps. This appears to be
breaking something in the CI pipeline.  This commit is a workaround and I will find a
better solution later.

Fixes: https://tracker.ceph.com/issues/70543
Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
4 months agomgr/dashboard: Not able to edit user display/full name in user form 62387/head
Naman Munet [Wed, 19 Mar 2025 09:20:25 +0000 (14:50 +0530)]
mgr/dashboard: Not able to edit user display/full name in user form

Fixes: https://tracker.ceph.com/issues/70554
Signed-off-by: Naman Munet <naman.munet@ibm.com>
4 months agodoc/radosgw /notifications: fix topic details 62394/head
Laimis Juzeliūnas [Wed, 19 Mar 2025 12:33:04 +0000 (14:33 +0200)]
doc/radosgw /notifications: fix topic details

This commit fixes documentation about many-to-many topic relationship for notifications. The current sentence states the same fact twice instead of clarifying.

Fixes: https://tracker.ceph.com/issues/64956
Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>
4 months agomgr/dashboard:fixed issue with notification icon 62262/head
Ankit [Wed, 12 Mar 2025 17:45:55 +0000 (23:15 +0530)]
mgr/dashboard:fixed issue with notification icon

Fixes:https://tracker.ceph.com/issues/70253
Signed-off-by: Ankit Kumar <51ankitkp@gmail.com>
4 months agoMerge pull request #62275 from rhcs-dashboard/fix-70450-main
Aashish Sharma [Wed, 19 Mar 2025 09:10:19 +0000 (14:40 +0530)]
Merge pull request #62275 from rhcs-dashboard/fix-70450-main

mgr/dashboard: Fix rgw user key modal not shown

Reviewed-by: Nizamudeen A <nia@redhat.com>
4 months agotest/unitest_bluestore_types: fix a compilation error 62244/head
Ronen Friedman [Wed, 19 Mar 2025 07:52:35 +0000 (02:52 -0500)]
test/unitest_bluestore_types: fix a compilation error

The test was failing to compile because of a missing
'include' directive.
Problem was introduced in commit 2e73c875640

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agoosd: use cmd_getval_cast_or() to fetch shard-id
Ronen Friedman [Wed, 12 Mar 2025 09:28:37 +0000 (04:28 -0500)]
osd: use cmd_getval_cast_or() to fetch shard-id

as that interface alleviates the need to cast shard_id_t::NO_SHARD
back and forth to/from int.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agocommon: add cmd_getval_cast_or()
Ronen Friedman [Wed, 12 Mar 2025 09:26:54 +0000 (04:26 -0500)]
common: add cmd_getval_cast_or()

This slight variation of cmd_getval_or() can be used where
the object type is different from the configuration item
type (as when the object is a wrapper around an integer).
It allows specifying the 'default' value in the object type.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agoMerge pull request #61766 from aainscow/shard_id_t
Ronen Friedman [Wed, 19 Mar 2025 06:54:39 +0000 (08:54 +0200)]
Merge pull request #61766 from aainscow/shard_id_t

osd: Require explicit casting for shard_id_t

Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
4 months agomonitoring: add SMB overview grafana dashboard 62206/head
Pedro Gonzalez Gomez [Mon, 10 Mar 2025 21:09:08 +0000 (22:09 +0100)]
monitoring: add SMB overview grafana dashboard

Fixes: https://tracker.ceph.com/issues/70423
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
4 months agoMerge pull request #62367 from anthonyeleven/pg-autoscale-upgrade
Zac Dover [Wed, 19 Mar 2025 06:01:29 +0000 (16:01 +1000)]
Merge pull request #62367 from anthonyeleven/pg-autoscale-upgrade

doc/cephadm: Add PG autoscaler advice to upgrade.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agoMerge pull request #61055 from cybozu/osd_max_scrubs-take-effect-even-though-mclock...
Zac Dover [Wed, 19 Mar 2025 05:55:03 +0000 (15:55 +1000)]
Merge pull request #61055 from cybozu/osd_max_scrubs-take-effect-even-though-mclock-is-used

common/options: fix the description of osd_max_scrubs

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agolibcephfs_proxy: remove redundant unsigned >= 0 comparison 62372/head
Kefu Chai [Wed, 19 Mar 2025 01:52:18 +0000 (09:52 +0800)]
libcephfs_proxy: remove redundant unsigned >= 0 comparison

Fix a clang warning in proxy_async.c where an unsigned value was being
unnecessarily compared against 0:
```
/home/kefu/dev/ceph/src/libcephfs_proxy/proxy_async.c:29:12: warning: result of comparison of unsigned expression >= 0 is always true [-Wtautological-unsigned-zero-compare]
   29 |         if ((size >= 0) && !info->write) {
      |              ~~~~ ^  ~
1 warning generated.
```

Since unsigned values are always >= 0 by definition, remove this
tautological check to resolve the "-Wtautological-unsigned-zero-compare"
warning.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
4 months agoMerge pull request #62371 from laimis9133/laimis9133-mailinglists
Anthony D'Atri [Wed, 19 Mar 2025 00:56:57 +0000 (20:56 -0400)]
Merge pull request #62371 from laimis9133/laimis9133-mailinglists

doc/dev/developer_guide/essentials: update mailing lists

4 months agodoc/cephadm: Add PG autoscaler advice to upgrade.rst 62367/head
Anthony D'Atri [Tue, 18 Mar 2025 19:35:34 +0000 (15:35 -0400)]
doc/cephadm: Add PG autoscaler advice to upgrade.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agodoc/dev/developer_guide/essentials: update mailing lists 62371/head
Laimis Juzeliūnas [Tue, 18 Mar 2025 22:24:50 +0000 (00:24 +0200)]
doc/dev/developer_guide/essentials: update mailing lists

Update information for subscribing to Ceph development mailing lists as current documentation is outdated.

Fixes: https://tracker.ceph.com/issues/64580
Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>
4 months agoMerge pull request #57629 from clwluvw/policy-remove-self-access
Casey Bodley [Tue, 18 Mar 2025 21:15:48 +0000 (17:15 -0400)]
Merge pull request #57629 from clwluvw/policy-remove-self-access

rgw: implement ConfirmRemoveSelfBucketAccess header for bucket policy

Reviewed-by: Adam Emerson <aemerson@redhat.com>
4 months agoMerge PR #62359 into main
Patrick Donnelly [Tue, 18 Mar 2025 19:24:13 +0000 (15:24 -0400)]
Merge PR #62359 into main

* refs/pull/62359/head:
doc: add clarification note on how charmap is applied

Reviewed-by: Anthony D Atri <anthony.datri@gmail.com>
Reviewed-by: Zac Dover <zac.dover@gmail.com>
4 months agoMerge pull request #62140 from rzarzynski/wip-nitzan-pg_pool_t-encode-decode-versions... 61586/head
Radoslaw Zarzynski [Tue, 18 Mar 2025 17:41:22 +0000 (18:41 +0100)]
Merge pull request #62140 from rzarzynski/wip-nitzan-pg_pool_t-encode-decode-versions-compability

osd_type: decouple is_stretch_pool() from versioning of pg_pool_t's schema

Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
4 months agoMerge pull request #62165 from athanatos/sjust/wip-recovery-ops-leak-61594-with-history
Samuel Just [Tue, 18 Mar 2025 17:24:28 +0000 (10:24 -0700)]
Merge pull request #62165 from athanatos/sjust/wip-recovery-ops-leak-61594-with-history

osd: fix osd mclock queue item leak

Reviewed-by: Sridhar Seshasayee <sseshasa@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 months agoMerge pull request #61821 from pritha-srivastava/wip-rgw-sts-oidc-user
Casey Bodley [Tue, 18 Mar 2025 16:09:22 +0000 (12:09 -0400)]
Merge pull request #61821 from pritha-srivastava/wip-rgw-sts-oidc-user

rgw/sts: replacing load_stats with list_buckets

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge PR #62335 into main
Patrick Donnelly [Tue, 18 Mar 2025 16:06:46 +0000 (12:06 -0400)]
Merge PR #62335 into main

* refs/pull/62335/head:
crypto: remove unused include

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agodoc: add clarification note on how charmap is applied 62359/head
Patrick Donnelly [Tue, 18 Mar 2025 15:24:52 +0000 (11:24 -0400)]
doc: add clarification note on how charmap is applied

There was confusion about whether setting the charmap on a directory also
affects the name of the directory itself.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #62031 into main
Patrick Donnelly [Tue, 18 Mar 2025 13:29:31 +0000 (09:29 -0400)]
Merge PR #62031 into main

* refs/pull/62031/head:
qa: test fio with multiple versions of NFS

Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge pull request #62253 from adamemerson/wip-rgw-shutdown-notify-crash
Casey Bodley [Tue, 18 Mar 2025 13:16:20 +0000 (09:16 -0400)]
Merge pull request #62253 from adamemerson/wip-rgw-shutdown-notify-crash

rgw: Try to handle unwatch errors sensibly

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
4 months agoMerge pull request #62156 from cbodley/wip-70270
Casey Bodley [Tue, 18 Mar 2025 13:16:00 +0000 (09:16 -0400)]
Merge pull request #62156 from cbodley/wip-70270

rgw: sync fairness watcher reconnects on any error

Reviewed-by: Matt Benjamin <mbenjamin@redhat.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-By: Oguzhan Ozmen <oozmen@bloomberg.net>
4 months agoMerge pull request #61803 from clwluvw/duplicate-prio
Casey Bodley [Tue, 18 Mar 2025 13:15:11 +0000 (09:15 -0400)]
Merge pull request #61803 from clwluvw/duplicate-prio

rgw: check for duplicate rule priorities in replication configuration

Reviewed-by: Adam Emerson <aemerson@redhat.com>
4 months agomgr/dashboard: Fix rgw user key modal not shown 62275/head
Aashish Sharma [Thu, 13 Mar 2025 12:03:54 +0000 (17:33 +0530)]
mgr/dashboard: Fix rgw user key modal not shown

Fixes: https://tracker.ceph.com/issues/70450
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
4 months agoMerge pull request #60843 from rhcs-dashboard/fix-69055-main
Aashish Sharma [Tue, 18 Mar 2025 10:41:40 +0000 (16:11 +0530)]
Merge pull request #60843 from rhcs-dashboard/fix-69055-main

mgr/dashboard: When configuring the RGW Multisite endpoints from the UI allow FQDN(Not only IP)

Reviewed-by: Nizamudeen A <nia@redhat.com>
4 months agoMerge pull request #62336 from tchaikov/librbd-std-variant
Ilya Dryomov [Tue, 18 Mar 2025 10:27:18 +0000 (11:27 +0100)]
Merge pull request #62336 from tchaikov/librbd-std-variant

librbd: migrate from boost::variant to std::variant

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
4 months agoMerge pull request #62328 from ronen-fr/wip-rf-fin1-keys
Ronen Friedman [Tue, 18 Mar 2025 09:22:30 +0000 (11:22 +0200)]
Merge pull request #62328 from ronen-fr/wip-rf-fin1-keys

common: md_config_obs_impl: remove deprecated get_tracked_conf_keys()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 months agoMerge pull request #62343 from VallariAg/wip-nvmeof-prometheus-singlegateway-rename
Vallari Agrawal [Tue, 18 Mar 2025 07:04:16 +0000 (12:34 +0530)]
Merge pull request #62343 from VallariAg/wip-nvmeof-prometheus-singlegateway-rename

monitoring: rename NVMeoFSingleGatewayGroup alert

4 months agoMerge pull request #61004 from rishabh-d-dave/mgr-vol-EINVAL
Rishabh Dave [Tue, 18 Mar 2025 06:16:39 +0000 (11:46 +0530)]
Merge pull request #61004 from rishabh-d-dave/mgr-vol-EINVAL

mgr/vol: use error number instead of error message

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 months agoMerge pull request #62301 from rishabh-d-dave/mgr-vol-fix-flake8-err
Rishabh Dave [Tue, 18 Mar 2025 06:16:22 +0000 (11:46 +0530)]
Merge pull request #62301 from rishabh-d-dave/mgr-vol-fix-flake8-err

mgr/volumes: fix issues pointed by flake8

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 months agoMerge pull request #62203 from rishabh-d-dave/mgr-vol-fix-logger-name
Rishabh Dave [Tue, 18 Mar 2025 06:16:09 +0000 (11:46 +0530)]
Merge pull request #62203 from rishabh-d-dave/mgr-vol-fix-logger-name

mgr/vol: correct logger names

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 months agoMerge pull request #62334 from tchaikov/cmake-mark-cap-required
Kefu Chai [Tue, 18 Mar 2025 05:20:04 +0000 (13:20 +0800)]
Merge pull request #62334 from tchaikov/cmake-mark-cap-required

cmake: make libcap REQUIRED

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agolibrbd: migrate from boost::variant to std::variant 62336/head
Kefu Chai [Mon, 17 Mar 2025 10:06:17 +0000 (18:06 +0800)]
librbd: migrate from boost::variant to std::variant

This change is part of a broader effort to reduce dependencies on
third-party libraries by leveraging C++ standard library alternatives.

Migrating from boost::variant to std::variant improves code readability
and maintainability while reducing external dependencies.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
4 months agoMerge pull request #62190 from ljflores/wip-tracker-69760
Yuri Weinstein [Tue, 18 Mar 2025 01:17:36 +0000 (18:17 -0700)]
Merge pull request #62190 from ljflores/wip-tracker-69760

mon, osd: add command to remove invalid pg-upmap-primary entries

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Josh Salomon <josh.salomon@gmail.com>
4 months agomon, osd: add command to remove invalid pg-upmap-primary entries 62190/head
Laura Flores [Fri, 7 Mar 2025 06:22:00 +0000 (06:22 +0000)]
mon, osd: add command to remove invalid pg-upmap-primary entries

The current rm-pg-upmap-primary command checks that the pgid exists
in the pgmap before continuing to remove it. Due to https://tracker.ceph.com/issues/66867,
some invalid pg-upmap-primary entires may exist for pools that have been removed.
Currently, these mappings are impossible to remove since the pgids no longer
exist in the pgmap.

This new command, rm-pg-upmap-primary-all, allows users the ability to remove
any and all pg-upmap-primary mappings in the osdmap at once, which includes
valid and invalid entries.

This command may also be helpful when upgrading from versions where users
are plagued by https://tracker.ceph.com/issues/61948. Users may use an upgraded
mon to remove all pg-upmap-primray entries (valid and invalid) so they continue
to upgrade to a safe version.

See manual testing for this patch here: https://tracker.ceph.com/issues/67179#note-12

Fixes: https://tracker.ceph.com/issues/67179
Fixes: https://tracker.ceph.com/issues/69760
Signed-off-by: Laura Flores <lflores@ibm.com>
4 months agoMerge pull request #62110 from cbodley/wip-69842
Casey Bodley [Mon, 17 Mar 2025 20:18:46 +0000 (16:18 -0400)]
Merge pull request #62110 from cbodley/wip-69842

rgw: rgw_init_ioctx() adds set_pool_full_try()

Reviewed-by: Adam Emerson <aemerson@redhat.com>
4 months agomonitoring: rename NVMeoFSingleGatewayGroup alert 62343/head
Vallari Agrawal [Mon, 17 Mar 2025 16:28:19 +0000 (21:58 +0530)]
monitoring: rename NVMeoFSingleGatewayGroup alert

Rename the alert to NVMeoFSingleGateway.

The original name was confusing because it
accidently might convey that alert would be
triggered if there is a single gateway group.
Though 'NVMeoFSingleGatewayGroup' alert means that
there is single gateway in a group.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
4 months agoMerge pull request #62276 from Matan-B/wip-matanb-radosbench
Matan Breizman [Mon, 17 Mar 2025 15:06:08 +0000 (17:06 +0200)]
Merge pull request #62276 from Matan-B/wip-matanb-radosbench

qa/tasks/radosbench: fix missing concurrency usage (on write)

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
4 months agoMerge pull request #62331 from baum/nvmeof_1_5
baum [Mon, 17 Mar 2025 13:27:48 +0000 (15:27 +0200)]
Merge pull request #62331 from baum/nvmeof_1_5

nvmeof: bump image version to 1.5

4 months agoMerge pull request #61990 from aclamk/wip-aclamk-write-v2-dirty-reshard
Adam Kupczyk [Mon, 17 Mar 2025 11:14:13 +0000 (12:14 +0100)]
Merge pull request #61990 from aclamk/wip-aclamk-write-v2-dirty-reshard

os/bluestore: write_v2 resharding misplaced

4 months agocrypto: remove unused include 62335/head
Kefu Chai [Mon, 17 Mar 2025 09:52:25 +0000 (17:52 +0800)]
crypto: remove unused include

openssl_crypto_accel.cc does not need the declarations included by
openssl/engine.h, also, openssl/engine.h was deprecated in favor of
the provider API, the engine support was removed in fedora 41.

so, let's avoid including it. please note, the "ENGINE" struct's
definition is available in openssl/types.h.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
4 months agocmake: make libcap REQUIRED 62334/head
Kefu Chai [Mon, 17 Mar 2025 06:26:18 +0000 (14:26 +0800)]
cmake: make libcap REQUIRED

this header is required when building the extended block device plugins
on linux, without it the build fails like:

```
/home/kefu/dev/ceph/src/extblkdev/ExtBlkDevInterface.h:38:10: fatal error: 'sys/capability.h' file not found
   38 | #include <sys/capability.h>
      |          ^~~~~~~~~~~~~~~~~~
```

so, let's mark this package REQUIRED, so that we can fail early
when generating the building system.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
4 months agonvmeof: bump image version to 1.5 62331/head
Alexander Indenbaum [Mon, 17 Mar 2025 09:25:48 +0000 (11:25 +0200)]
nvmeof: bump image version to 1.5

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
4 months agomgr/dashboard: Add RGW topics endpoint creation for create ,delete and list in dashboard 61075/head
pujaoshahu [Fri, 13 Dec 2024 05:11:13 +0000 (10:41 +0530)]
mgr/dashboard: Add RGW topics endpoint creation for create ,delete and list in dashboard

Fixes: https://tracker.ceph.com/issues/69229
Signed-off-by: pujaoshahu <pshahu@redhat.com>
4 months agoMerge pull request #62079 from myoungwon/seastore-omap-log-cleanup
Yingxin Cheng [Mon, 17 Mar 2025 05:51:55 +0000 (13:51 +0800)]
Merge pull request #62079 from myoungwon/seastore-omap-log-cleanup

crimson/os/seastore: cleanups related to managing omap and log tree

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 months agoMerge pull request #60575 from steven-chien/systemd-prefix
SrinivasaBharathKanta [Mon, 17 Mar 2025 04:59:33 +0000 (10:29 +0530)]
Merge pull request #60575 from steven-chien/systemd-prefix

systemd: use CMake install prefix in templates

4 months agocommon: remove deprecated get_tracked_conf_keys() 62328/head
Ronen Friedman [Sun, 16 Mar 2025 11:40:52 +0000 (06:40 -0500)]
common: remove deprecated get_tracked_conf_keys()

This is the last PR in a set of PRs that
replaced the deprecated get_tracked_conf_keys()
with the new get_tracked_keys().

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agoMerge pull request #62185 from ronen-fr/wip-rf-more8-keys
Ronen Friedman [Sun, 16 Mar 2025 12:20:23 +0000 (14:20 +0200)]
Merge pull request #62185 from ronen-fr/wip-rf-more8-keys

kernel/KernelDevice: replace obsolete get_tracked_conf_keys()

Reviewed-by: Matt Vandermeulen <matt@reenigne.net>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 months agoMerge pull request #61672 from Matan-B/wip-matanb-cmake-crimson-v3
Matan Breizman [Sun, 16 Mar 2025 09:23:18 +0000 (11:23 +0200)]
Merge pull request #61672 from Matan-B/wip-matanb-cmake-crimson-v3

src: Cleanup WITH_ALIENSTORE

Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
4 months agoMerge pull request #62243 from NitzanMordhai/wip-nitzan-osd-destroyed-in-nodes-ls
NitzanMordhai [Sun, 16 Mar 2025 07:28:59 +0000 (09:28 +0200)]
Merge pull request #62243 from NitzanMordhai/wip-nitzan-osd-destroyed-in-nodes-ls

OSDMonitor: exclude destroyed OSDs from "ceph node ls" output

4 months agoMerge pull request #62182 from ronen-fr/wip-rf-more7cr-keys
NitzanMordhai [Sun, 16 Mar 2025 06:46:23 +0000 (08:46 +0200)]
Merge pull request #62182 from ronen-fr/wip-rf-more7cr-keys

test/crimson/test_config: replace obsolete get_tracked_conf_keys()

4 months agoMerge pull request #60491 from soumyakoduri/wip-skoduri-restore-vers
Soumya Koduri [Sat, 15 Mar 2025 11:41:43 +0000 (17:11 +0530)]
Merge pull request #60491 from soumyakoduri/wip-skoduri-restore-vers

rgw/cloud-restore: Handle versioned objects

Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Shreyansh Sancheti <ssanchet@redhat.com>
4 months agorgw: skip replication from lock enabled buckets to lock disbaled buckets 62323/head
Seena Fallah [Mon, 3 Mar 2025 16:18:22 +0000 (17:18 +0100)]
rgw: skip replication from lock enabled buckets to lock disbaled buckets

replicating lock enabled objects require the destination bucket to
have object lock enabled.

Fixes: https://tracker.ceph.com/issues/70486
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
4 months agorgw: skip versioned entries to non-versioned buckets and vice-versa
Seena Fallah [Mon, 3 Mar 2025 16:16:55 +0000 (17:16 +0100)]
rgw: skip versioned entries to non-versioned buckets and vice-versa

As instance field is preserved while replicating, this can make
confusion for versioned buckets having non-versioned objects and
non-versioned buckets having versioned objects.

Fixes: https://tracker.ceph.com/issues/70486
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
4 months agorgw: reject PutBucketReplication on mismatched versioning and lock
Seena Fallah [Thu, 6 Mar 2025 18:36:50 +0000 (19:36 +0100)]
rgw: reject PutBucketReplication on mismatched versioning and lock

Reject PutBucketReplication calls if versioning is not identical
between the source and destination buckets. This check also applies
to object lock configurations to ensure consistency.

Fixes: https://tracker.ceph.com/issues/70486
Signed-off-by: Seena Fallah <seenafallah@gmail.com>
4 months agoMerge pull request #62319 from anthonyeleven/rt
Zac Dover [Sat, 15 Mar 2025 02:57:03 +0000 (12:57 +1000)]
Merge pull request #62319 from anthonyeleven/rt

doc/rados/troubleshooting: Improve troubleshooting-pg.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agodoc/rados/troubleshooting: Improve troubleshooting-pg.rst 62319/head
Anthony D'Atri [Sat, 15 Mar 2025 02:44:18 +0000 (22:44 -0400)]
doc/rados/troubleshooting: Improve troubleshooting-pg.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoMerge pull request #62316 from anthonyeleven/cme
Zac Dover [Sat, 15 Mar 2025 02:22:03 +0000 (12:22 +1000)]
Merge pull request #62316 from anthonyeleven/cme

doc/rados/operations: improve crush-map-edits.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agodoc/rados/operations: improve crush-map-edits.rst 62316/head
Anthony D'Atri [Sat, 15 Mar 2025 01:59:57 +0000 (21:59 -0400)]
doc/rados/operations: improve crush-map-edits.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoMerge pull request #61816 from ljflores/wip-tracker-62776
SrinivasaBharathKanta [Fri, 14 Mar 2025 23:11:13 +0000 (04:41 +0530)]
Merge pull request #61816 from ljflores/wip-tracker-62776

qa/suites/rados/basic: ignore POOL_APP_NOT_ENABLED detail in cluster log

4 months agoMerge pull request #57046 from clwluvw/vault-del-bucketkey
Casey Bodley [Fri, 14 Mar 2025 20:12:44 +0000 (16:12 -0400)]
Merge pull request #57046 from clwluvw/vault-del-bucketkey

rgw: false assumption on vault bucket key deletion

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge PR #62231 into main
Patrick Donnelly [Fri, 14 Mar 2025 15:45:30 +0000 (11:45 -0400)]
Merge PR #62231 into main

* refs/pull/62231/head:
mds: set alternate_name for new fullbit dentries
qa: test alternate_name recovery during mds failover

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
4 months agoMerge pull request #62194 from rhcs-dashboard/fix-token-polling
Nizamudeen A [Fri, 14 Mar 2025 14:28:19 +0000 (19:58 +0530)]
Merge pull request #62194 from rhcs-dashboard/fix-token-polling

mgr/dashboard: fix token polling req in multi-cluster UI

4 months agoMerge pull request #61772 from rhcs-dashboard/fix-multisite-wizard-forms
Nizamudeen A [Fri, 14 Mar 2025 14:26:50 +0000 (19:56 +0530)]
Merge pull request #61772 from rhcs-dashboard/fix-multisite-wizard-forms

mgr/dashboard: fix multisite wizard form not showing

4 months agoMerge pull request #61781 from rhcs-dashboard/xml-fix
Nizamudeen A [Fri, 14 Mar 2025 14:25:47 +0000 (19:55 +0530)]
Merge pull request #61781 from rhcs-dashboard/xml-fix

mgr/dashboard: fix lifecycle get request

4 months agorgw/iam: add policy evaluation for Arn-based Conditions 62285/head
Casey Bodley [Thu, 13 Mar 2025 19:14:39 +0000 (15:14 -0400)]
rgw/iam: add policy evaluation for Arn-based Conditions

arn-based conditions like ArnEquals etc are recognized by the policy
parser, but not enforced during policy evaluation

Fixes: https://tracker.ceph.com/issues/70481
Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge PR #61877 into main
Venky Shankar [Fri, 14 Mar 2025 14:07:28 +0000 (19:37 +0530)]
Merge PR #61877 into main

* refs/pull/61877/head:
libcephfs_proxy: implement client side async rw operation
libcephfs_proxy: implement server side async rw operation
libcephfs_proxy: implement the async rw callback
libcephfs_proxy: define async rw opcode and structures
libcephfs_proxy: define some helper macros for callbacks
libcephfs_proxy: move pointer obfuscation functions to proxy_helpers.h
libcephfs_proxy: negotiate and use the async cbk feature
libcephfs_proxy: implement asynchronous callbacks
libcephfs_proxy: gracefully handle connection close
libcephfs_proxy: add negotiation documentation
libcephfs_proxy: replace legacy handshake by negotation in server side
libcephfs_proxy: replace legacy handshake by negotation in client side
libcephfs_proxy: implement server side negotiation
libcephfs_proxy: implement client side negotiation
libcephfs_proxy: implement receiving of negotiate structure
libcephfs_proxy: add negotiation structures
libcephfs_proxy: add support for control messages
libcephfs_proxy: reuse proxy_link_{read|write}

Reviewed-by: Sachin Prabhu <sp@spui.uk>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agomgr/volumes: fix issues pointed by flake8 62301/head
Rishabh Dave [Fri, 14 Mar 2025 13:38:31 +0000 (19:08 +0530)]
mgr/volumes: fix issues pointed by flake8

Fixes: https://tracker.ceph.com/issues/70480
Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 months agomgr/volumes: correct logger names 62203/head
Rishabh Dave [Mon, 10 Mar 2025 15:49:46 +0000 (21:19 +0530)]
mgr/volumes: correct logger names

Fixes: https://tracker.ceph.com/issues/70376
Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 months agoMerge PR #62228 into main
Patrick Donnelly [Fri, 14 Mar 2025 12:29:12 +0000 (08:29 -0400)]
Merge PR #62228 into main

* refs/pull/62228/head:
libcephfs: getcwd after chdir for API constraint
client: unwrap dentries for getcwd
client: refactor / optimize chdir
test/libcephfs: test getcwd with case insensitive dir
test/libcephfs: refactor ManyNestedDirs
include/filepath: add iterators for components

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge pull request #62296 from afreen23/wip-sso-fix
Pedro Gonzalez Gomez [Fri, 14 Mar 2025 11:19:34 +0000 (12:19 +0100)]
Merge pull request #62296 from afreen23/wip-sso-fix

mgr/dashboard: fix OAuth2 SSO when roles_path is empty

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>