]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 months agoosd: fix the tiering agent's shutdown wrt the OSD fast shutdown 62509/head
Radoslaw Zarzynski [Wed, 26 Mar 2025 01:17:56 +0000 (01:17 +0000)]
osd: fix the tiering agent's shutdown wrt the OSD fast shutdown

Fixes: https://tracker.ceph.com/issues/69724
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 months agoMerge pull request #60843 from rhcs-dashboard/fix-69055-main
Aashish Sharma [Tue, 18 Mar 2025 10:41:40 +0000 (16:11 +0530)]
Merge pull request #60843 from rhcs-dashboard/fix-69055-main

mgr/dashboard: When configuring the RGW Multisite endpoints from the UI allow FQDN(Not only IP)

Reviewed-by: Nizamudeen A <nia@redhat.com>
4 months agoMerge pull request #62336 from tchaikov/librbd-std-variant
Ilya Dryomov [Tue, 18 Mar 2025 10:27:18 +0000 (11:27 +0100)]
Merge pull request #62336 from tchaikov/librbd-std-variant

librbd: migrate from boost::variant to std::variant

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
4 months agoMerge pull request #62328 from ronen-fr/wip-rf-fin1-keys
Ronen Friedman [Tue, 18 Mar 2025 09:22:30 +0000 (11:22 +0200)]
Merge pull request #62328 from ronen-fr/wip-rf-fin1-keys

common: md_config_obs_impl: remove deprecated get_tracked_conf_keys()

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 months agoMerge pull request #62343 from VallariAg/wip-nvmeof-prometheus-singlegateway-rename
Vallari Agrawal [Tue, 18 Mar 2025 07:04:16 +0000 (12:34 +0530)]
Merge pull request #62343 from VallariAg/wip-nvmeof-prometheus-singlegateway-rename

monitoring: rename NVMeoFSingleGatewayGroup alert

4 months agoMerge pull request #61004 from rishabh-d-dave/mgr-vol-EINVAL
Rishabh Dave [Tue, 18 Mar 2025 06:16:39 +0000 (11:46 +0530)]
Merge pull request #61004 from rishabh-d-dave/mgr-vol-EINVAL

mgr/vol: use error number instead of error message

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 months agoMerge pull request #62301 from rishabh-d-dave/mgr-vol-fix-flake8-err
Rishabh Dave [Tue, 18 Mar 2025 06:16:22 +0000 (11:46 +0530)]
Merge pull request #62301 from rishabh-d-dave/mgr-vol-fix-flake8-err

mgr/volumes: fix issues pointed by flake8

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 months agoMerge pull request #62203 from rishabh-d-dave/mgr-vol-fix-logger-name
Rishabh Dave [Tue, 18 Mar 2025 06:16:09 +0000 (11:46 +0530)]
Merge pull request #62203 from rishabh-d-dave/mgr-vol-fix-logger-name

mgr/vol: correct logger names

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
4 months agoMerge pull request #62334 from tchaikov/cmake-mark-cap-required
Kefu Chai [Tue, 18 Mar 2025 05:20:04 +0000 (13:20 +0800)]
Merge pull request #62334 from tchaikov/cmake-mark-cap-required

cmake: make libcap REQUIRED

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agolibrbd: migrate from boost::variant to std::variant 62336/head
Kefu Chai [Mon, 17 Mar 2025 10:06:17 +0000 (18:06 +0800)]
librbd: migrate from boost::variant to std::variant

This change is part of a broader effort to reduce dependencies on
third-party libraries by leveraging C++ standard library alternatives.

Migrating from boost::variant to std::variant improves code readability
and maintainability while reducing external dependencies.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
4 months agoMerge pull request #62190 from ljflores/wip-tracker-69760
Yuri Weinstein [Tue, 18 Mar 2025 01:17:36 +0000 (18:17 -0700)]
Merge pull request #62190 from ljflores/wip-tracker-69760

mon, osd: add command to remove invalid pg-upmap-primary entries

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Josh Salomon <josh.salomon@gmail.com>
4 months agomon, osd: add command to remove invalid pg-upmap-primary entries 62190/head
Laura Flores [Fri, 7 Mar 2025 06:22:00 +0000 (06:22 +0000)]
mon, osd: add command to remove invalid pg-upmap-primary entries

The current rm-pg-upmap-primary command checks that the pgid exists
in the pgmap before continuing to remove it. Due to https://tracker.ceph.com/issues/66867,
some invalid pg-upmap-primary entires may exist for pools that have been removed.
Currently, these mappings are impossible to remove since the pgids no longer
exist in the pgmap.

This new command, rm-pg-upmap-primary-all, allows users the ability to remove
any and all pg-upmap-primary mappings in the osdmap at once, which includes
valid and invalid entries.

This command may also be helpful when upgrading from versions where users
are plagued by https://tracker.ceph.com/issues/61948. Users may use an upgraded
mon to remove all pg-upmap-primray entries (valid and invalid) so they continue
to upgrade to a safe version.

See manual testing for this patch here: https://tracker.ceph.com/issues/67179#note-12

Fixes: https://tracker.ceph.com/issues/67179
Fixes: https://tracker.ceph.com/issues/69760
Signed-off-by: Laura Flores <lflores@ibm.com>
4 months agoMerge pull request #62110 from cbodley/wip-69842
Casey Bodley [Mon, 17 Mar 2025 20:18:46 +0000 (16:18 -0400)]
Merge pull request #62110 from cbodley/wip-69842

rgw: rgw_init_ioctx() adds set_pool_full_try()

Reviewed-by: Adam Emerson <aemerson@redhat.com>
4 months agomonitoring: rename NVMeoFSingleGatewayGroup alert 62343/head
Vallari Agrawal [Mon, 17 Mar 2025 16:28:19 +0000 (21:58 +0530)]
monitoring: rename NVMeoFSingleGatewayGroup alert

Rename the alert to NVMeoFSingleGateway.

The original name was confusing because it
accidently might convey that alert would be
triggered if there is a single gateway group.
Though 'NVMeoFSingleGatewayGroup' alert means that
there is single gateway in a group.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>
4 months agoMerge pull request #62276 from Matan-B/wip-matanb-radosbench
Matan Breizman [Mon, 17 Mar 2025 15:06:08 +0000 (17:06 +0200)]
Merge pull request #62276 from Matan-B/wip-matanb-radosbench

qa/tasks/radosbench: fix missing concurrency usage (on write)

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
4 months agoMerge pull request #62331 from baum/nvmeof_1_5
baum [Mon, 17 Mar 2025 13:27:48 +0000 (15:27 +0200)]
Merge pull request #62331 from baum/nvmeof_1_5

nvmeof: bump image version to 1.5

4 months agoMerge pull request #61990 from aclamk/wip-aclamk-write-v2-dirty-reshard
Adam Kupczyk [Mon, 17 Mar 2025 11:14:13 +0000 (12:14 +0100)]
Merge pull request #61990 from aclamk/wip-aclamk-write-v2-dirty-reshard

os/bluestore: write_v2 resharding misplaced

4 months agocmake: make libcap REQUIRED 62334/head
Kefu Chai [Mon, 17 Mar 2025 06:26:18 +0000 (14:26 +0800)]
cmake: make libcap REQUIRED

this header is required when building the extended block device plugins
on linux, without it the build fails like:

```
/home/kefu/dev/ceph/src/extblkdev/ExtBlkDevInterface.h:38:10: fatal error: 'sys/capability.h' file not found
   38 | #include <sys/capability.h>
      |          ^~~~~~~~~~~~~~~~~~
```

so, let's mark this package REQUIRED, so that we can fail early
when generating the building system.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
4 months agonvmeof: bump image version to 1.5 62331/head
Alexander Indenbaum [Mon, 17 Mar 2025 09:25:48 +0000 (11:25 +0200)]
nvmeof: bump image version to 1.5

Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
4 months agoMerge pull request #62079 from myoungwon/seastore-omap-log-cleanup
Yingxin Cheng [Mon, 17 Mar 2025 05:51:55 +0000 (13:51 +0800)]
Merge pull request #62079 from myoungwon/seastore-omap-log-cleanup

crimson/os/seastore: cleanups related to managing omap and log tree

Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 months agoMerge pull request #60575 from steven-chien/systemd-prefix
SrinivasaBharathKanta [Mon, 17 Mar 2025 04:59:33 +0000 (10:29 +0530)]
Merge pull request #60575 from steven-chien/systemd-prefix

systemd: use CMake install prefix in templates

4 months agocommon: remove deprecated get_tracked_conf_keys() 62328/head
Ronen Friedman [Sun, 16 Mar 2025 11:40:52 +0000 (06:40 -0500)]
common: remove deprecated get_tracked_conf_keys()

This is the last PR in a set of PRs that
replaced the deprecated get_tracked_conf_keys()
with the new get_tracked_keys().

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>
4 months agoMerge pull request #62185 from ronen-fr/wip-rf-more8-keys
Ronen Friedman [Sun, 16 Mar 2025 12:20:23 +0000 (14:20 +0200)]
Merge pull request #62185 from ronen-fr/wip-rf-more8-keys

kernel/KernelDevice: replace obsolete get_tracked_conf_keys()

Reviewed-by: Matt Vandermeulen <matt@reenigne.net>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
4 months agoMerge pull request #61672 from Matan-B/wip-matanb-cmake-crimson-v3
Matan Breizman [Sun, 16 Mar 2025 09:23:18 +0000 (11:23 +0200)]
Merge pull request #61672 from Matan-B/wip-matanb-cmake-crimson-v3

src: Cleanup WITH_ALIENSTORE

Reviewed-by: Radosław Zarzyński <rzarzyns@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Adam Emerson <aemerson@redhat.com>
4 months agoMerge pull request #62243 from NitzanMordhai/wip-nitzan-osd-destroyed-in-nodes-ls
NitzanMordhai [Sun, 16 Mar 2025 07:28:59 +0000 (09:28 +0200)]
Merge pull request #62243 from NitzanMordhai/wip-nitzan-osd-destroyed-in-nodes-ls

OSDMonitor: exclude destroyed OSDs from "ceph node ls" output

4 months agoMerge pull request #62182 from ronen-fr/wip-rf-more7cr-keys
NitzanMordhai [Sun, 16 Mar 2025 06:46:23 +0000 (08:46 +0200)]
Merge pull request #62182 from ronen-fr/wip-rf-more7cr-keys

test/crimson/test_config: replace obsolete get_tracked_conf_keys()

4 months agoMerge pull request #60491 from soumyakoduri/wip-skoduri-restore-vers
Soumya Koduri [Sat, 15 Mar 2025 11:41:43 +0000 (17:11 +0530)]
Merge pull request #60491 from soumyakoduri/wip-skoduri-restore-vers

rgw/cloud-restore: Handle versioned objects

Reviewed-by: Jiffin Tony Thottan <thottanjiffin@gmail.com>
Reviewed-by: Shreyansh Sancheti <ssanchet@redhat.com>
4 months agoMerge pull request #62319 from anthonyeleven/rt
Zac Dover [Sat, 15 Mar 2025 02:57:03 +0000 (12:57 +1000)]
Merge pull request #62319 from anthonyeleven/rt

doc/rados/troubleshooting: Improve troubleshooting-pg.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agodoc/rados/troubleshooting: Improve troubleshooting-pg.rst 62319/head
Anthony D'Atri [Sat, 15 Mar 2025 02:44:18 +0000 (22:44 -0400)]
doc/rados/troubleshooting: Improve troubleshooting-pg.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoMerge pull request #62316 from anthonyeleven/cme
Zac Dover [Sat, 15 Mar 2025 02:22:03 +0000 (12:22 +1000)]
Merge pull request #62316 from anthonyeleven/cme

doc/rados/operations: improve crush-map-edits.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agodoc/rados/operations: improve crush-map-edits.rst 62316/head
Anthony D'Atri [Sat, 15 Mar 2025 01:59:57 +0000 (21:59 -0400)]
doc/rados/operations: improve crush-map-edits.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
4 months agoMerge pull request #61816 from ljflores/wip-tracker-62776
SrinivasaBharathKanta [Fri, 14 Mar 2025 23:11:13 +0000 (04:41 +0530)]
Merge pull request #61816 from ljflores/wip-tracker-62776

qa/suites/rados/basic: ignore POOL_APP_NOT_ENABLED detail in cluster log

4 months agoMerge pull request #57046 from clwluvw/vault-del-bucketkey
Casey Bodley [Fri, 14 Mar 2025 20:12:44 +0000 (16:12 -0400)]
Merge pull request #57046 from clwluvw/vault-del-bucketkey

rgw: false assumption on vault bucket key deletion

Reviewed-by: Casey Bodley <cbodley@redhat.com>
4 months agoMerge PR #62231 into main
Patrick Donnelly [Fri, 14 Mar 2025 15:45:30 +0000 (11:45 -0400)]
Merge PR #62231 into main

* refs/pull/62231/head:
mds: set alternate_name for new fullbit dentries
qa: test alternate_name recovery during mds failover

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Kotresh Hiremath Ravishankar <khiremat@redhat.com>
4 months agoMerge pull request #62194 from rhcs-dashboard/fix-token-polling
Nizamudeen A [Fri, 14 Mar 2025 14:28:19 +0000 (19:58 +0530)]
Merge pull request #62194 from rhcs-dashboard/fix-token-polling

mgr/dashboard: fix token polling req in multi-cluster UI

4 months agoMerge pull request #61772 from rhcs-dashboard/fix-multisite-wizard-forms
Nizamudeen A [Fri, 14 Mar 2025 14:26:50 +0000 (19:56 +0530)]
Merge pull request #61772 from rhcs-dashboard/fix-multisite-wizard-forms

mgr/dashboard: fix multisite wizard form not showing

4 months agoMerge pull request #61781 from rhcs-dashboard/xml-fix
Nizamudeen A [Fri, 14 Mar 2025 14:25:47 +0000 (19:55 +0530)]
Merge pull request #61781 from rhcs-dashboard/xml-fix

mgr/dashboard: fix lifecycle get request

4 months agoMerge PR #61877 into main
Venky Shankar [Fri, 14 Mar 2025 14:07:28 +0000 (19:37 +0530)]
Merge PR #61877 into main

* refs/pull/61877/head:
libcephfs_proxy: implement client side async rw operation
libcephfs_proxy: implement server side async rw operation
libcephfs_proxy: implement the async rw callback
libcephfs_proxy: define async rw opcode and structures
libcephfs_proxy: define some helper macros for callbacks
libcephfs_proxy: move pointer obfuscation functions to proxy_helpers.h
libcephfs_proxy: negotiate and use the async cbk feature
libcephfs_proxy: implement asynchronous callbacks
libcephfs_proxy: gracefully handle connection close
libcephfs_proxy: add negotiation documentation
libcephfs_proxy: replace legacy handshake by negotation in server side
libcephfs_proxy: replace legacy handshake by negotation in client side
libcephfs_proxy: implement server side negotiation
libcephfs_proxy: implement client side negotiation
libcephfs_proxy: implement receiving of negotiate structure
libcephfs_proxy: add negotiation structures
libcephfs_proxy: add support for control messages
libcephfs_proxy: reuse proxy_link_{read|write}

Reviewed-by: Sachin Prabhu <sp@spui.uk>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agomgr/volumes: fix issues pointed by flake8 62301/head
Rishabh Dave [Fri, 14 Mar 2025 13:38:31 +0000 (19:08 +0530)]
mgr/volumes: fix issues pointed by flake8

Fixes: https://tracker.ceph.com/issues/70480
Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 months agomgr/volumes: correct logger names 62203/head
Rishabh Dave [Mon, 10 Mar 2025 15:49:46 +0000 (21:19 +0530)]
mgr/volumes: correct logger names

Fixes: https://tracker.ceph.com/issues/70376
Signed-off-by: Rishabh Dave <ridave@redhat.com>
4 months agoMerge PR #62228 into main
Patrick Donnelly [Fri, 14 Mar 2025 12:29:12 +0000 (08:29 -0400)]
Merge PR #62228 into main

* refs/pull/62228/head:
libcephfs: getcwd after chdir for API constraint
client: unwrap dentries for getcwd
client: refactor / optimize chdir
test/libcephfs: test getcwd with case insensitive dir
test/libcephfs: refactor ManyNestedDirs
include/filepath: add iterators for components

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge pull request #62296 from afreen23/wip-sso-fix
Pedro Gonzalez Gomez [Fri, 14 Mar 2025 11:19:34 +0000 (12:19 +0100)]
Merge pull request #62296 from afreen23/wip-sso-fix

mgr/dashboard: fix OAuth2 SSO when roles_path is empty

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
4 months agorgw/cloud-restore: Handle "null" instance non-current objects 60491/head
Soumya Koduri [Tue, 4 Mar 2025 17:36:26 +0000 (23:06 +0530)]
rgw/cloud-restore: Handle "null" instance non-current objects

During restore, if the object instance is "null", clear it while updating
bi entry.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
4 months agorgw/cloud-restore: Handle versioned objects
Soumya Koduri [Fri, 3 Jan 2025 08:20:48 +0000 (13:50 +0530)]
rgw/cloud-restore: Handle versioned objects

While restoring non-current object versions, ensure they remain non-current.

Read `olh_epoch` from the restored object's metadata into a new attr
"RGW_ATTR_RESTORE_VERSIONED_EPOCH". This attr/olh_epoch is used while
updating bi entry and also to reset HEAD object post expiry of temporary
copies.

Signed-off-by: Soumya Koduri <skoduri@redhat.com>
4 months agomgr/dashboard: add basic e2e to verify wizard 61772/head
Nizamudeen A [Wed, 12 Feb 2025 14:14:15 +0000 (19:44 +0530)]
mgr/dashboard: add basic e2e to verify wizard

and topology viewer

Fixes: https://tracker.ceph.com/issues/69925
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: fix multisite wizard form not showing
Nizamudeen A [Wed, 12 Feb 2025 14:11:44 +0000 (19:41 +0530)]
mgr/dashboard: fix multisite wizard form not showing

Fixes: https://tracker.ceph.com/issues/69925
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agoMerge pull request #62119 from MartinNowak/patch-2
Zac Dover [Fri, 14 Mar 2025 06:54:17 +0000 (16:54 +1000)]
Merge pull request #62119 from MartinNowak/patch-2

doc/radosgw: Improve bucketpolicy.rst #58689 - document SSE-C IAM condition key

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
4 months agomgr/dashboard: fix OAuth2 SSO when roles_path is empty 62296/head
Afreen Misbah [Fri, 14 Mar 2025 05:50:30 +0000 (11:20 +0530)]
mgr/dashboard: fix OAuth2 SSO when roles_path is empty

Fixes https://tracker.ceph.com/issues/70454

Due to PR linter updates, this place remained not updated hence failing

Signed-off-by: Afreen Misbah <afreen@ibm.com>
4 months agoMerge pull request #62258 from dvanders/dvanders_doc_fix
Zac Dover [Fri, 14 Mar 2025 00:38:54 +0000 (10:38 +1000)]
Merge pull request #62258 from dvanders/dvanders_doc_fix

doc/rados/configuration/bluestore-config-ref: Fix lowercase typos

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #62232 into main
Patrick Donnelly [Thu, 13 Mar 2025 21:01:31 +0000 (17:01 -0400)]
Merge PR #62232 into main

* refs/pull/62232/head:
include/cephfs: dump optmetadata

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agomgr/dashboard: add xlmtodict import and fix lifecycle get request 61781/head
Pedro Gonzalez Gomez [Wed, 12 Feb 2025 19:24:57 +0000 (20:24 +0100)]
mgr/dashboard: add xlmtodict import and fix lifecycle get request

Fixes: https://tracker.ceph.com/issues/70128
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
4 months agoMerge pull request #62274 from phlogistonjohn/jjm-more-bwc-fixes
Dan Mick [Thu, 13 Mar 2025 20:10:52 +0000 (13:10 -0700)]
Merge pull request #62274 from phlogistonjohn/jjm-more-bwc-fixes

build-with-container: two small fixes

4 months agoMerge pull request #62252 from ronen-fr/wip-rf-fix-62188
Ilya Dryomov [Thu, 13 Mar 2025 19:42:27 +0000 (20:42 +0100)]
Merge pull request #62252 from ronen-fr/wip-rf-fix-62188

librbd/ConfigWatcher: fix a missing 'override'

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge PR #54396 into main
Venky Shankar [Thu, 13 Mar 2025 16:57:57 +0000 (22:27 +0530)]
Merge PR #54396 into main

* refs/pull/54396/head:
PendingReleaseNote: add note for pause_purging and pause_cloninig
doc/cephfs: add note for config option pause_purging and pause_cloning
qa/cephfs: add tests for mgr/vol config pause_cloning
qa/cephfs: extend wait for trash empty
qa/cephfs: add tests for config option pause_purging
qa/cephfs: don't strip any whitespace for get_shell_stdout
mgr/vol: add pause/resume mechanism for async jobs

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge PR #62240 into main
Patrick Donnelly [Thu, 13 Mar 2025 16:05:18 +0000 (12:05 -0400)]
Merge PR #62240 into main

* refs/pull/62240/head:
qa/cephfs: require-osd-release should now be tentacle

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoqa/tasks/radosbench: make use of concurrency flag 62276/head
Matan Breizman [Thu, 13 Mar 2025 14:29:31 +0000 (14:29 +0000)]
qa/tasks/radosbench: make use of concurrency flag

This affects mainly radosbench-high-concurrency.yaml
The concurrency flag was only used in non-write scenarios to
populate the initial data.
We should use this flag with `write` mode as well.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
4 months agoMerge PR #62200 into main
Patrick Donnelly [Thu, 13 Mar 2025 15:51:06 +0000 (11:51 -0400)]
Merge PR #62200 into main

* refs/pull/62200/head:
common/include: Add map type election and fmt::format to interval_map

Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #59780 from irq0/wip/osd-asok-messenger-dump
Marcel Lauhoff [Thu, 13 Mar 2025 15:40:53 +0000 (16:40 +0100)]
Merge pull request #59780 from irq0/wip/osd-asok-messenger-dump

Add Asok Command: Dump Messenger Status (Connections, TCP stats, ..)

4 months agoMerge PR #62230 into main
Patrick Donnelly [Thu, 13 Mar 2025 15:19:09 +0000 (11:19 -0400)]
Merge PR #62230 into main

* refs/pull/62230/head:
client: avoid multiple calls to path_walk

Reviewed-by: Christopher Hoffman <choffman@redhat.com>
4 months agoMerge pull request #61791 from MaxKellermann/common_includes
Max Kellermann [Thu, 13 Mar 2025 15:11:35 +0000 (16:11 +0100)]
Merge pull request #61791 from MaxKellermann/common_includes

common: add missing includes

Reviewed-By: Adam Emerson <aemerson@ibm.com>
4 months agoqa/rgw: suppress "pool(s) full" cluster warning for rados-pool-quota 62110/head
Casey Bodley [Wed, 12 Mar 2025 16:35:09 +0000 (12:35 -0400)]
qa/rgw: suppress "pool(s) full" cluster warning for rados-pool-quota

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agoqa/rgw: test_rgw_rados_pool_quota expects InsufficientCapacity
Casey Bodley [Tue, 4 Mar 2025 19:02:51 +0000 (14:02 -0500)]
qa/rgw: test_rgw_rados_pool_quota expects InsufficientCapacity

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agorgw/s3: map ENOSPC to 507 InsufficientCapacity
Casey Bodley [Tue, 4 Mar 2025 19:55:39 +0000 (14:55 -0500)]
rgw/s3: map ENOSPC to 507 InsufficientCapacity

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agorgw: rgw_init_ioctx() adds set_pool_full_try()
Casey Bodley [Tue, 4 Mar 2025 18:14:28 +0000 (13:14 -0500)]
rgw: rgw_init_ioctx() adds set_pool_full_try()

add librados::OPERATION_FULL_TRY globally so we never hang waiting for
space when the pool reaches its quota limit

Fixes: https://tracker.ceph.com/issues/69842
Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agorgw: RGWRadosRemoveCR uses rgw_init_ioctx()
Casey Bodley [Tue, 4 Mar 2025 18:12:07 +0000 (13:12 -0500)]
rgw: RGWRadosRemoveCR uses rgw_init_ioctx()

avoid direct calls to ioctx_create() so rgw_init_ioctx() can set
appropriate flags globally

Signed-off-by: Casey Bodley <cbodley@redhat.com>
4 months agoinclude/cephfs: dump optmetadata 62232/head
Patrick Donnelly [Tue, 11 Mar 2025 19:03:59 +0000 (15:03 -0400)]
include/cephfs: dump optmetadata

For inspection from `dump tree` MDS command.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agomds: set alternate_name for new fullbit dentries 62231/head
Patrick Donnelly [Tue, 11 Mar 2025 19:01:46 +0000 (15:01 -0400)]
mds: set alternate_name for new fullbit dentries

Fixes: 9fbf37ade38bc1d057eda2459b0ccfd2ab40626a
Fixes: https://tracker.ceph.com/issues/70409
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoqa: test alternate_name recovery during mds failover
Patrick Donnelly [Tue, 11 Mar 2025 19:18:03 +0000 (15:18 -0400)]
qa: test alternate_name recovery during mds failover

Fixes: https://tracker.ceph.com/issues/70409
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agolibcephfs: getcwd after chdir for API constraint 62228/head
Patrick Donnelly [Wed, 12 Mar 2025 14:33:02 +0000 (10:33 -0400)]
libcephfs: getcwd after chdir for API constraint

libcephfs semantics require that the old path to the cwd be returned when
getcwd is encounters an unlinked directory in the current working directory.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoclient: unwrap dentries for getcwd
Patrick Donnelly [Tue, 11 Mar 2025 14:51:38 +0000 (10:51 -0400)]
client: unwrap dentries for getcwd

This was missed in the path_walk refactor. readdir is not the only way to "get"
dentry names.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoclient: refactor / optimize chdir
Patrick Donnelly [Tue, 11 Mar 2025 14:49:50 +0000 (10:49 -0400)]
client: refactor / optimize chdir

In particular: there's no reason to do a getcwd after chdir.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agotest/libcephfs: test getcwd with case insensitive dir
Patrick Donnelly [Tue, 11 Mar 2025 16:13:33 +0000 (12:13 -0400)]
test/libcephfs: test getcwd with case insensitive dir

Unfortunately, it's not easy to refactor this test into a shared method without
setting up an explicit test class which has been avoided up to this point. So
I'm going to just copy the code. Sorry.

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agotest/libcephfs: refactor ManyNestedDirs
Patrick Donnelly [Tue, 11 Mar 2025 14:53:02 +0000 (10:53 -0400)]
test/libcephfs: refactor ManyNestedDirs

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoinclude/filepath: add iterators for components
Patrick Donnelly [Tue, 11 Mar 2025 14:50:50 +0000 (10:50 -0400)]
include/filepath: add iterators for components

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
4 months agoMerge pull request #62160 from cbodley/wip-qa-vault-list
Casey Bodley [Thu, 13 Mar 2025 13:18:05 +0000 (09:18 -0400)]
Merge pull request #62160 from cbodley/wip-qa-vault-list

qa/vault: create_secrets() cleanup checks for orphaned keys

Reviewed-by: Adam C. Emerson <aemerson@redhat.com>
4 months agoscript: ensure curl is always available in build containers 62274/head
John Mulligan [Thu, 13 Mar 2025 11:59:42 +0000 (07:59 -0400)]
script: ensure curl is always available in build containers

Ensure that curl is installed in all build containers regardless of
ceph's dependencies or other factors. This allows us to use curl in
any subsequent build steps/scripts.

Fixes: https://tracker.ceph.com/issues/70451
Signed-off-by: John Mulligan <jmulligan@redhat.com>
4 months agoscript/build-with-container: fix incorrect build invocation for tests
John Mulligan [Thu, 13 Mar 2025 11:48:28 +0000 (07:48 -0400)]
script/build-with-container: fix incorrect build invocation for tests

The `tests` build target was set to build the "normal" target but it
needs to build the tests.

Signed-off-by: John Mulligan <jmulligan@redhat.com>
4 months agoMerge pull request #61945 from kotreshhr/snapshot-referent-inodes
Venky Shankar [Thu, 13 Mar 2025 10:53:46 +0000 (16:23 +0530)]
Merge pull request #61945 from kotreshhr/snapshot-referent-inodes

mds: snapshot referent inodes feature

Reviewed-by: Venky Shankar <vshankar@redhat.com>
4 months agoMerge pull request #60014 from rhcs-dashboard/cephadm-e2e-endless-fix-1
afreen23 [Thu, 13 Mar 2025 10:21:12 +0000 (15:51 +0530)]
Merge pull request #60014 from rhcs-dashboard/cephadm-e2e-endless-fix-1

mgr/dashboard: fix cephadm dashboard e2e and a combobox issue

Reviewed-by: Afreen Misbah <afreen@ibm.com>
4 months agocrimson/os/seastore: introduce rename_omap_root() with src and dest onodes 62079/head
Yingxin Cheng [Thu, 13 Mar 2025 08:21:10 +0000 (16:21 +0800)]
crimson/os/seastore: introduce rename_omap_root() with src and dest onodes

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 months agocrimson/os/seastore: prevent omaptree_rm_key() to be called concurrently in the same...
Yingxin Cheng [Thu, 13 Mar 2025 07:57:17 +0000 (15:57 +0800)]
crimson/os/seastore: prevent omaptree_rm_key() to be called concurrently in the same transaction

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 months agocrimson/os/seastore: introduce and use omaptree_initialize()
Yingxin Cheng [Thu, 13 Mar 2025 07:46:49 +0000 (15:46 +0800)]
crimson/os/seastore: introduce and use omaptree_initialize()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 months agocrimson/os/seastore: reuse get_omap_root()
Yingxin Cheng [Thu, 13 Mar 2025 07:41:17 +0000 (15:41 +0800)]
crimson/os/seastore: reuse get_omap_root()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
4 months agoos/bluestore: Improve bluestore_blob_t::add_tail 61990/head
Adam Kupczyk [Mon, 10 Mar 2025 08:53:09 +0000 (08:53 +0000)]
os/bluestore: Improve bluestore_blob_t::add_tail

It could happen that target blob already had empty mapping at the end.
In such case, do not add more empty mappings, just expand exising one.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
4 months agoos/bluestore: Make write_v2 not need to use compress_extents, addendum
Adam Kupczyk [Mon, 10 Mar 2025 08:48:01 +0000 (08:48 +0000)]
os/bluestore: Make write_v2 not need to use compress_extents, addendum

There was possible case that affected rightmost changed extent.
It could be that 2 mergeable extents were next to each other.
This change melds them together.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
4 months agoos/bluestore: Make write_v2 calculate affected range
Adam Kupczyk [Tue, 25 Feb 2025 09:56:43 +0000 (09:56 +0000)]
os/bluestore: Make write_v2 calculate affected range

This reduces size for dirty_range and need_reshard range.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
4 months agoos/bluestore: Make write_v2 not need to use compress_extents
Adam Kupczyk [Thu, 6 Mar 2025 19:40:29 +0000 (19:40 +0000)]
os/bluestore: Make write_v2 not need to use compress_extents

Remove need to call compress_extents.
The only place that could produce compressable extents are
_try_reuse_allocated_[l/r] functions.

Create _place_extent_in_blob() function that adds mapping to blob.
If possible, it expands the extent; if not, creates the new one.
The function is used whenever we need new mapping to an existing Blob.

Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
4 months agoMerge pull request #62245 from afreen23/wip-disable-rgw-test
Nizamudeen A [Thu, 13 Mar 2025 05:56:13 +0000 (11:26 +0530)]
Merge pull request #62245 from afreen23/wip-disable-rgw-test

mgr/dashboard: Disable MFA test

4 months agoMerge pull request #62249 from anthonyeleven/improvedmi
Zac Dover [Thu, 13 Mar 2025 04:51:50 +0000 (14:51 +1000)]
Merge pull request #62249 from anthonyeleven/improvedmi

doc/monitoring: Improve index.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>
4 months agomgr/dashboard: skip nfs exports check 60014/head
Nizamudeen A [Sat, 8 Mar 2025 08:47:59 +0000 (14:17 +0530)]
mgr/dashboard: skip nfs exports check

nfs service creation is not working because of some issue with cephadm
for a while now. disabling it until its resolved

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: save video only on failure
Nizamudeen A [Fri, 7 Mar 2025 15:24:36 +0000 (20:54 +0530)]
mgr/dashboard: save video only on failure

as per
https://docs.cypress.io/app/guides/screenshots-and-videos#Delete-videos-for-specs-without-failing-or-retried-tests.

This would save storage as saving entire video is useless

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: fix rgw and osd regression in e2e
Nizamudeen A [Mon, 24 Feb 2025 09:23:54 +0000 (14:53 +0530)]
mgr/dashboard: fix rgw and osd regression in e2e

use aria-label as the selector in tests.

data-testid is not supported through this carbon cds-checkbox
input so we can't use it

regression started after started after #61319 and
https://github.com/ceph/ceph/pull/61478/files#diff-7bd2a1f48bd2a7bcebb744eb04d84706087b6b3c2651c4b1ad085b4b6e03fc6d
where multi-select is removed

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: undefined while creating rbd image
Nizamudeen A [Mon, 10 Feb 2025 04:37:28 +0000 (10:07 +0530)]
mgr/dashboard: undefined while creating rbd image

this only happens on a fresh cluster but consistently reproducible in a
test environment. also cephfs also throws some error occasionally which
is also being handled similarly

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: cypress failure after angular upgrade
Nizamudeen A [Sun, 9 Feb 2025 16:12:59 +0000 (21:42 +0530)]
mgr/dashboard: cypress failure after angular upgrade

after angular upgrade, the tests started failing with
An uncaught error was detected outside of a test:
     TypeError: The following error originated from your test code, not from Cypress.
Cannot read properties of undefined (reading 'value')

which seems to originate from the page-helper.po. So handling the
undefined value.

Example run: https://jenkins.ceph.com/job/ceph-dashboard-pull-requests/17541/consoleFull#204663575173a8703b-5adb-41c5-84a0-8cf4e065ba3d

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: fixing cephadm dashboard e2e failures
Nizamudeen A [Fri, 27 Sep 2024 05:28:41 +0000 (10:58 +0530)]
mgr/dashboard: fixing cephadm dashboard e2e failures

the wizard component changes caused issue to the e2e, so fixing it.
It was uncaught before because of the test were unable to run due to
some lab issues.

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: fix osd list search with id
Nizamudeen A [Thu, 9 Jan 2025 17:39:00 +0000 (23:09 +0530)]
mgr/dashboard: fix osd list search with id

The osd list search with id is broken after the pagination. So if you
search for any id it won't retrieve anything.

PS: One more broken item is the searching with any other cell name but
that's a known issue with server side pagination.

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: reorder test runs
Nizamudeen A [Thu, 9 Jan 2025 10:40:08 +0000 (16:10 +0530)]
mgr/dashboard: reorder test runs

I saw cypress starting the grafana tests even before the cluster is
setup through the expansion tests. so running grafana separately

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agomgr/dashboard: add custom items to combo box
Nizamudeen A [Fri, 27 Sep 2024 05:30:17 +0000 (11:00 +0530)]
mgr/dashboard: add custom items to combo box

previously we were able to add custom items to our select-badges like
custom labels for hosts. but it got dropped unintentionally due to the
carbon. fixing it here

Fixes: https://tracker.ceph.com/issues/68871
Signed-off-by: Nizamudeen A <nia@redhat.com>
4 months agocrimson/os/seastore: clear an omap root for log during _omap_clear
myoungwon oh [Thu, 13 Mar 2025 02:09:51 +0000 (02:09 +0000)]
crimson/os/seastore: clear an omap root for log during _omap_clear

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
Signed-off-by: Myoungwon Oh <ohmyoungwon@gmail.com>
4 months agoPendingReleaseNote: add note for pause_purging and pause_cloninig 54396/head
Rishabh Dave [Mon, 2 Sep 2024 14:13:45 +0000 (19:43 +0530)]
PendingReleaseNote: add note for pause_purging and pause_cloninig

Added release notes for mgr/vol config option "pause_purging and
"pause_cloning".

Signed-off-by: Rishabh Dave <ridave@redhat.com>