]>
git.apps.os.sepia.ceph.com Git - ceph.git/log
Kefu Chai [Sun, 30 Mar 2025 02:10:28 +0000 (10:10 +0800)]
cmake: do not pass PRE_BUILD to add_custom_command(OUTPUT)
Removes the invalid PRE_BUILD argument from add_custom_command(OUTPUT)
calls that was triggering CMake warnings. The PRE_BUILD option is only
valid for target-based custom commands and specifically with Visual
Studio generators.
Additionally sets the CMP0175 policy to NEW to ensure CMake fails on
invalid arguments to add_custom_command(), helping catch similar issues
earlier in the development process.
This change:
- Removes unnecessary PRE_BUILD argument from OUTPUT-based custom commands
- Sets CMP0175 policy to enforce validation of add_custom_command() arguments
- Resolves CMake warning in src/common/options/CMakeLists.txt
Reference:
https://cmake.org/cmake/help/latest/command/add_custom_command.html#build-events
The CMake warning looks like:
```
CMake Warning (dev) at src/common/options/CMakeLists.txt:34 (add_custom_command):
The following keywords are not supported when using
add_custom_command(OUTPUT): PRE_BUILD.
Policy CMP0175 is not set: add_custom_command() rejects invalid arguments.
Run "cmake --help-policy CMP0175" for policy details. Use the cmake_policy
command to set the policy and suppress this warning.
Call Stack (most recent call first):
src/common/options/CMakeLists.txt:85 (add_options)
This warning is for project developers. Use -Wno-dev to suppress it.
```
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sun, 30 Mar 2025 01:36:22 +0000 (09:36 +0800)]
Merge pull request #62550 from tchaikov/fmt-formattable
src: migrate to fmt::formattable for format support
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
Yuri Weinstein [Sat, 29 Mar 2025 14:08:25 +0000 (07:08 -0700)]
Merge pull request #62509 from rzarzynski/wip-bug-69724
osd: fix the tiering agent's shutdown wrt the OSD fast shutdown
Reviewed-by: Brad Hubbard <bhubbard@redhat.com>
Kefu Chai [Wed, 26 Mar 2025 03:43:43 +0000 (11:43 +0800)]
src: migrate to fmt::formattable for format support
Replace custom has_formatter concept with fmtlib's fmt::formattable
- Deprecate usage of fmt::has_formatter
- Resolve compiler warnings with recent fmtlib versions
The custom concept of has_formatter is no longer necessary with
recent updates to the fmtlib library, as fmt::formattable was introduced
in fmtlib v11.0.0. By switching to fmt::formattable, we simplify our
code and stop using the deprecated `fmt::has_formatter` template.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Sat, 29 Mar 2025 06:32:03 +0000 (14:32 +0800)]
Merge pull request #62474 from tchaikov/openssl-engine
common: disable OpenSSL engine support if it is disabled
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
baum [Fri, 28 Mar 2025 22:52:34 +0000 (01:52 +0300)]
Merge pull request #62141 from baum/nvmeof_cluster_alloc
NvmeofServiceSpec: ceph connection allocation strategies
Yuri Weinstein [Fri, 28 Mar 2025 22:27:55 +0000 (15:27 -0700)]
Merge pull request #62480 from tchaikov/erasure-code-free
erasure-code: use new/delete to alloc/free coefficients array
Reviewed-by: Alex Ainscow <aainscow@redhat.com>
Igor Fedotov [Fri, 28 Mar 2025 15:45:45 +0000 (18:45 +0300)]
Merge pull request #62174 from ifed01/wip-ifed-fix-bluefs-reserved2
os/bluestore: use block size (4K) as minimal allocation unit for dedicated DB/WAL volumes
Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
Igor Fedotov [Fri, 28 Mar 2025 13:54:50 +0000 (16:54 +0300)]
Merge pull request #62251 from ifed01/wip-ifed-print-discard-threads
blk/kernel: New perf counter to view amount of discard threads.
Reviewed-by: Yite Gu <yitegu0@gmail.com>
Kefu Chai [Fri, 28 Mar 2025 12:27:25 +0000 (20:27 +0800)]
Merge pull request #62546 from tchaikov/crimson-rados-qa
qa: add missing .qa links for crimson-rados tests
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Zac Dover [Fri, 28 Mar 2025 12:02:59 +0000 (22:02 +1000)]
Merge pull request #62537 from zdover23/wip-doc-2025-03-27-mon_warn_pg_not_scrubbed_ratio-guidance
src/common: add guidance for mon_warn_pg_not_scrubbed
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Adam Kupczyk [Fri, 28 Mar 2025 11:54:08 +0000 (12:54 +0100)]
Merge pull request #62471 from YiteGu/fix-invalid-iterator-usge-after-erase
blk/kerneldevice: fix invalid iterator usage after erase in discard_q…
Adam Kupczyk [Fri, 28 Mar 2025 11:53:34 +0000 (12:53 +0100)]
Merge pull request #62273 from aclamk/wip-aclamk-osd-superblock-corruption-resilient
osd/OSD.cc: make osd_superblock recovery more robust
Aashish Sharma [Fri, 28 Mar 2025 06:17:52 +0000 (11:47 +0530)]
Merge pull request #62476 from rhcs-dashboard/fix-70646-main
mgr/dashboard: fix bucket form encryption checkbox
Reviewed-by: Nizamudeen A <nia@redhat.com>
Alexander Indenbaum [Wed, 5 Mar 2025 17:32:56 +0000 (19:32 +0200)]
NvmeofServiceSpec: ceph connection allocation strategies
Co-authored-by: Adam King <47704447+adk3798@users.noreply.github.com>
Signed-off-by: Alexander Indenbaum <aindenba@redhat.com>
Kefu Chai [Fri, 28 Mar 2025 03:17:44 +0000 (11:17 +0800)]
qa: add missing .qa links for crimson-rados tests
follow the suggestion by src/script/verify-qa to address the
failure of qa-symlink.yml workflow. without this change, the
workflow consistently fails.
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Kefu Chai [Tue, 25 Mar 2025 04:03:30 +0000 (12:03 +0800)]
common: disable OpenSSL engine support if it is disabled
OpenSSL 3.0 documentation recommends moving from the ENGINE API to the
Providers API. Recent distributions may compile OpenSSL without engine
support by default, necessitating more flexible configuration handling.
So, in this change:
- Add a CMake option `WITH_OPENSSL_ENGINE` to explicitly control engine support
- Respect `openssl_engine_opts` when engine support is enabled
- Provide clear error messaging when engine options are set but support is disabled
See also:
- OpenSSL 3.0 documentation:
https://wiki.openssl.org/index.php/OpenSSL_3.0#Engines_and_.22METHOD.22_APIs
Fixes: https://tracker.ceph.com/issues/68059
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Ilya Dryomov [Thu, 27 Mar 2025 22:30:21 +0000 (23:30 +0100)]
Merge pull request #62521 from idryomov/wip-rbd-mirror-pool-status-fixups
rbd: "rbd mirror pool status --verbose" output fixups
Reviewed-by: Ramana Raja <rraja@redhat.com>
afreen23 [Thu, 27 Mar 2025 19:51:22 +0000 (01:21 +0530)]
Merge pull request #60351 from rhcs-dashboard/ngb-popover
mgr/dashboard: replace ngb-popover with carbon popover
Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Naman Munet <nmunet@redhat.com>
Zac Dover [Thu, 27 Mar 2025 12:24:13 +0000 (22:24 +1000)]
src/common: add guidance for mon_warn_pg_not_scrubbed
Add an explanation of how to set the value of
"mon_warn_pg_not_scrubbed_ratio" to the confval definition of that
variable. Although this variable contains the string "mon", it is set on
the Manager. I have added a note to direct users to set this value on
the Manager.
This issue was pointed out by Petr Tlapa on Slack in late March of 2025.
This issue is part of a small project that also encompasses
https://github.com/ceph/ceph/pull/62459, which is associated with commit
aeef59a50ee31072648ba0c7436b6522137614cd
Co-authored-by: Anthony D'Atri <anthony.datri@gmail.com>
Signed-off-by: Zac Dover <zac.dover@proton.me>
Avan [Thu, 27 Mar 2025 10:42:59 +0000 (16:12 +0530)]
Merge pull request #62105 from xhernandez/configure-case-sensitivity
pybind/mgr/volumes: configure case sensitivity
Reviewed-by: Avan Thakkar <athakkar@redhat.
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Anoop C S <anoopcs@cryptolab.net>
Aashish Sharma [Tue, 25 Mar 2025 05:51:59 +0000 (11:21 +0530)]
mgr/dashboard: fix bucket form encryption checkbox
The condition to disable/enable encryption checkbox on bucket form is broken because of the new structure of the get encryption config API response.
Fixes: https://tracker.ceph.com/issues/70646
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Hezko [Thu, 27 Mar 2025 09:33:46 +0000 (11:33 +0200)]
Merge pull request #61649 from Hezko/nvmeof-response-handling
mgr/dashboard: introduce "convert_to_model" and "pick" decorators
Yingxin Cheng [Thu, 27 Mar 2025 09:23:39 +0000 (17:23 +0800)]
Merge pull request #62373 from myoungwon/wip-qa-seastore-rbm-remaining
qa/suites/crimson-rados: add seastore with RBM test under the remaining tests
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Aashish Sharma [Thu, 27 Mar 2025 07:50:39 +0000 (13:20 +0530)]
Merge pull request #62489 from rhcs-dashboard/fix-70653-main
mgr/dashboard: fix image filter's query on rbd-details grafana panel
Reviewed-by: Nizamudeen A <nia@redhat.com>
Nizamudeen A [Thu, 27 Mar 2025 07:42:39 +0000 (13:12 +0530)]
Merge pull request #62392 from ceph/fix-70557-main
mgr/dashboard: fix blockUI implementation
Kefu Chai [Thu, 27 Mar 2025 07:09:44 +0000 (15:09 +0800)]
Merge pull request #62493 from tchaikov/clang-as-gcc
common/ceph_context: Fix std::atomic<std::shared_ptr> compatibility
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Reviewed-by: Max Kellermann <max.kellermann@ionos.com>
Ali Masarwa [Thu, 27 Mar 2025 01:30:56 +0000 (03:30 +0200)]
Merge pull request #62458 from AliMasarweh/wip-alimasa-bn-list-fix
RGW|Bucket Notification: fix for v2 topics rgw-admin list operation
Reviewed-by: yuvalif<ylifshit@redhat.com>
Tomer Haskalovitch [Sun, 2 Feb 2025 10:25:32 +0000 (12:25 +0200)]
mgr/dashboard: introduce "convert_to_model" util
fixes: https://tracker.ceph.com/issues/62705
Signed-off-by: Tomer Haskalovitch <il033030@Tomers-MacBook-Pro.local>
Kefu Chai [Tue, 25 Mar 2025 13:40:00 +0000 (21:40 +0800)]
common/ceph_context: Fix std::atomic<std::shared_ptr> compatibility
Previously, we relied on the __GNUC__ macro to check for std::atomic<std::shared_ptr>
support, which was inaccurate. This approach failed with Clang builds using libstdc++,
even when the feature was implemented. The warning looks like:
```
/usr/lib/gcc/x86_64-redhat-linux/15/../../../../include/c++/15/bits/shared_ptr_atomic.h:131:5: note: 'atomic_load_explicit<std::vector<entity_addrvec_t>>' has been explicitly marked deprecated here
131 | _GLIBCXX20_DEPRECATED_SUGGEST("std::atomic<std::shared_ptr<T>>")
| ^
```
This change uses a standard-compliant feature test macro (__cpp_lib_atomic_shared_ptr)
to correctly detect support for std::atomic<std::shared_ptr>. This resolves compilation
issues and improves portability across different compilers and standard library
implementations.
Refs
5b0d849730ce20d68ffafcb612c5f6fc8b87dd9a
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Joseph Mundackal [Wed, 26 Mar 2025 23:53:36 +0000 (19:53 -0400)]
Merge pull request #62520 from Thingee/update-slack-invite-link
doc: Update Slack invite links
Dan Mick [Wed, 26 Mar 2025 21:08:55 +0000 (14:08 -0700)]
Merge pull request #62324 from phlogistonjohn/jjm-bwc-fix-70470-clang-2
build-with-container: fix container build on docker and clang setup on ubuntu jammy [v2]
Casey Bodley [Wed, 26 Mar 2025 20:40:08 +0000 (16:40 -0400)]
Merge pull request #62463 from cbodley/wip-qa-rgw-lockdep
qa/rgw: enable lockdep config for radosgw
Reviewed-by: Adam Emerson <aemerson@redhat.com>
Adam King [Wed, 26 Mar 2025 19:55:22 +0000 (15:55 -0400)]
Merge pull request #61761 from phlogistonjohn/jjm-list_daemons-refactor
cephadm: refactor the core of list_daemons
Reviewed-by: Adam King <adking@redhat.com>
Ali Masarwa [Sun, 23 Mar 2025 11:31:38 +0000 (13:31 +0200)]
RGW|Bucket Notification: fix for v2 topics rgw-admin list operation
Signed-off-by: Ali Masarwa <amasarwa@redhat.com>
Ilya Dryomov [Thu, 20 Mar 2025 17:28:44 +0000 (18:28 +0100)]
rbd: mirror_uuids -> mirror_uuid in remote mirror peer listing
... in "rbd mirror image status" and "rbd mirror pool status --verbose"
formatted outputs. In unformatted outputs this value is shown in place
of a name in case a site name isn't available.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Thu, 20 Mar 2025 16:10:47 +0000 (17:10 +0100)]
rbd: extend use of "none" placeholder to IMAGES section
Currently if there are no mirror-enabled images, IMAGES section
in "rbd mirror pool status --verbose" output isn't terminated:
$ rbd mirror pool status data --verbose
health: OK
daemon health: OK
image health: OK
images: 0 total
DAEMONS
service 4388:
...
health: OK
IMAGES$
DAEMONS section has a "none" placeholder for when there are no
rbd-mirror daemons running. Fix some issues with the separator logic
and employ the placeholder in IMAGES section:
$ rbd mirror pool status data --verbose
health: OK
daemon health: OK
image health: OK
images: 0 total
DAEMONS
service 4388:
...
health: OK
IMAGES
none
$
$ rbd mirror pool status data --verbose
health: UNKNOWN
daemon health: UNKNOWN
image health: OK
images: 0 total
DAEMONS
none
IMAGES
none
$
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Thu, 20 Mar 2025 16:01:18 +0000 (17:01 +0100)]
rbd: drop redundant separator between DAEMONS and IMAGES sections
... in "rbd mirror pool status --verbose" output. Before:
DAEMONS
service 4388:
...
health: OK
IMAGES
a1:
global_id:
8f5531db -0ec5-41da-907b-
95f457f1b316
state: up+stopped
...
After:
DAEMONS
service 4388:
...
health: OK
IMAGES
a1:
global_id:
8f5531db -0ec5-41da-907b-
95f457f1b316
state: up+stopped
...
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Radoslaw Zarzynski [Wed, 26 Mar 2025 15:02:48 +0000 (16:02 +0100)]
Merge pull request #62515 from rzarzynski/wip-ftbfs-rgwzoneplctier
rgw: fix the version in DECODE_START() of RGWZoneGroupPlacementTier
Reviewed-by: Kefu Chai <tchaikov@gmail.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Mike Perez [Wed, 26 Mar 2025 14:12:38 +0000 (07:12 -0700)]
doc: Update Slack invite links
The invite links expire after 30 days. Here's a new one.
Signed-off-by: Mike Perez <thingee@gmail.com>
Radoslaw Zarzynski [Wed, 26 Mar 2025 08:12:39 +0000 (08:12 +0000)]
rgw: fix the version in DOCODE_START() of RGWZoneGroupPlacementTier
This commit fixes an undetected merge conflict between PRs #61745
and #60159. The dencoding problem has been introduced very recently,
it is straightforward and causes failures of the make check bot
everywhere, therefore -- if no objections -- I want to merge this
patch without the Teuthology testing.
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Ilya Dryomov [Wed, 26 Mar 2025 08:07:27 +0000 (09:07 +0100)]
Merge pull request #62452 from tchaikov/librbd-std-variant
librbd: migrate from boost::variant to std::variant
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Wed, 26 Mar 2025 08:05:15 +0000 (09:05 +0100)]
Merge pull request #62484 from idryomov/wip-70640
mgr/rbd_support: always parse interval and start_time in Schedules::remove()
Reviewed-by: Ramana Raja <rraja@redhat.com>
Prachi Goel [Wed, 16 Oct 2024 09:14:46 +0000 (14:44 +0530)]
mgr/dashboard: replace ngb-popover with carbon popover
Fixes: https://tracker.ceph.com/issues/68259
Signed-off-by: Prachi Goel <prachi@li-f0e8f2cc-27e0-11b2-a85c-b2772164128d.ibm.com>
Below are the changes from bootstrap popover to carbon popover:
1. Dashboard v3
2. Health Component
3. RGW sync data component
4. RGW sync metadata component
5. Upgrade component
Anthony D'Atri [Wed, 26 Mar 2025 05:02:16 +0000 (22:02 -0700)]
Merge pull request #62512 from anthonyeleven/iptableswarn
doc/rados/configuration: Add iptables change admonition to network-config.rst
Anthony D'Atri [Wed, 26 Mar 2025 03:13:52 +0000 (20:13 -0700)]
doc/rados/configuration: Add iptables change admonition to network-config.rst
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Kefu Chai [Wed, 26 Mar 2025 01:38:45 +0000 (09:38 +0800)]
Merge pull request #62475 from tchaikov/literal-operator
common: remove spaces before literal operator
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>
Radoslaw Zarzynski [Wed, 26 Mar 2025 01:17:56 +0000 (01:17 +0000)]
osd: fix the tiering agent's shutdown wrt the OSD fast shutdown
Fixes: https://tracker.ceph.com/issues/69724
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Radoslaw Zarzynski [Tue, 25 Mar 2025 22:13:55 +0000 (23:13 +0100)]
Merge pull request #60277 from rzarzynski/wip-tools-rados-omap-listbench
tools/rados: generalize the OMAP benchmarking to cover listing as well
Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
Radoslaw Zarzynski [Tue, 25 Mar 2025 22:04:42 +0000 (23:04 +0100)]
Merge pull request #60159 from rzarzynski/wip-denc-ctcheck-struct_v
dencoding: check struct_v against DECODE_START(v, ...) at compile-time
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Reviewed-by: Greg Farnum <gfarnum@redhat.com>
Reviewed-by: Jesse Williamson <jwilliamson@suse.de>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Nitzan Mordechai <nmordech@redhat.com>
Zac Dover [Tue, 25 Mar 2025 18:35:07 +0000 (04:35 +1000)]
Merge pull request #62459 from zdover23/wip-doc-2025-03-24-mon_warn_pg_not_deep_scrubbed-guidance
src/common: add guidance for deep-scrubbing ratio warning
Reviewed-by: David Galloway <david.galloway@ibm.com>
Patrick Donnelly [Tue, 25 Mar 2025 18:31:30 +0000 (14:31 -0400)]
Merge PR #62465 into main
* refs/pull/62465/head:
qa: add test for `mgr status` command
mgr: add status command
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Adam King [Tue, 25 Mar 2025 17:38:19 +0000 (13:38 -0400)]
Merge pull request #62215 from rkachach/fix_mgmt_gw_ha
mgr/cephadm: refactor oauth2-proxy certs and cookie-secret handling
Reviewed-by: Adam King <adking@redhat.com>
afreen23 [Tue, 25 Mar 2025 17:34:43 +0000 (23:04 +0530)]
Merge pull request #62477 from rhcs-dashboard/upgrade-grafana-10.4.16
mgr/cephadm: upgrade grafana to 10.4.16
Reviewed-by: Afreen Misbah <afreen@ibm.com>
Adam King [Tue, 25 Mar 2025 17:29:40 +0000 (13:29 -0400)]
Merge pull request #62229 from phlogistonjohn/jjm-teuth-ctdb-sebool
qa/cephadm/smb: set virt_sandbox_use_netlink selinux bool on ctdb tests
Reviewed-by: Adam King <adking@redhat.com>
Adam King [Tue, 25 Mar 2025 17:27:20 +0000 (13:27 -0400)]
Merge pull request #61824 from ShwetaBhosale1/fix_issue_69942_prometheus_not_adding_host_url_in_mgr_when_first_enabled
mgr/cephadm: Deploying prometheus service for the first time, does not update PROMETHEUS_API_HOST url under mgr module
Reviewed-by: Adam King <adking@redhat.com>
Patrick Donnelly [Tue, 25 Mar 2025 16:12:43 +0000 (12:12 -0400)]
Merge PR #62303 into main
* refs/pull/62303/head:
test/libcephfs: add missing cleanup
Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>
Patrick Donnelly [Tue, 25 Mar 2025 16:12:27 +0000 (12:12 -0400)]
Merge PR #62406 into main
* refs/pull/62406/head:
client: process path without inode anchor
test/client: add ll_walk test with cwd and root path
Reviewed-by: Dhairya Parmar <dparmar@redhat.com>
afreen23 [Tue, 25 Mar 2025 15:32:45 +0000 (21:02 +0530)]
Merge pull request #62423 from afreen23/wip-ns-kb
mgr/dashboard: KiB not supported size for namespace creation
Reviewed-by: Afreen Misbah <afreen@ibm.com>
Adam King [Tue, 25 Mar 2025 14:29:59 +0000 (10:29 -0400)]
Merge pull request #61727 from Kushal-deb/fix_issue_2330954-RGW_is_not_adding_a_SAN
cephadm: Ensure wildcard SAN is included in RGW self-signed certs
Reviewed-by: Adam King <adking@redhat.com>
Adam King [Tue, 25 Mar 2025 14:28:03 +0000 (10:28 -0400)]
Merge pull request #61209 from Kushal-deb/fix_issue-
2253832 -osd_service_issue
cephadm: link new OSDs to existing managed services
Reviewed-by: Adam King <adking@redhat.com>
Adam King [Tue, 25 Mar 2025 14:21:02 +0000 (10:21 -0400)]
Merge pull request #62199 from ShwetaBhosale1/fix_issue_70373_enable_logrotate_timer
cephadm: Enable logroate.timer service in bootstrap process
Reviewed-by: Adam King <adking@redhat.com>
Zac Dover [Tue, 25 Mar 2025 14:13:06 +0000 (00:13 +1000)]
Merge pull request #62485 from zdover23/wip-doc-2025-03-25-cephadm-certmgr
doc/cephadm: format "Configuration" in cephadm.rst
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Xavi Hernandez [Fri, 21 Mar 2025 16:08:45 +0000 (17:08 +0100)]
doc: update documentation for normalization and case sensitivity
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
Xavi Hernandez [Wed, 19 Mar 2025 12:08:43 +0000 (13:08 +0100)]
qa: add tests for case sensitivity configuration on subvolume creation
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
Xavi Hernandez [Tue, 4 Mar 2025 16:05:44 +0000 (17:05 +0100)]
pybind/mgr: add option to set case sensitivity to a subvolume
Add an option to explicitly set the case sensitivity of a CephFS
subvolume.
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
Xavi Hernandez [Wed, 19 Mar 2025 12:12:42 +0000 (13:12 +0100)]
qa: add tests for normalization configuration on subvolume creation
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
Xavi Hernandez [Wed, 19 Mar 2025 12:05:19 +0000 (13:05 +0100)]
pybind/mgr: add option to set unicode normalization to a subvolume
Add an option to explicitly set the unicode normalization form to use on
a CephFS subvolume.
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
Xavi Hernandez [Wed, 19 Mar 2025 11:59:59 +0000 (12:59 +0100)]
pybind/mgr: create normalization xattr in subvolumes
When a new subvolume is created, optionally set the
ceph.dir.normalization xattr to the root directory.
Signed-off-by: Xavi Hernandez <xhernandez@gmail.com>
Patrick Donnelly [Mon, 24 Mar 2025 15:52:15 +0000 (11:52 -0400)]
qa: add test for `mgr status` command
Fixes: https://tracker.ceph.com/issues/70571
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Adam King [Tue, 25 Mar 2025 13:16:20 +0000 (09:16 -0400)]
Merge pull request #62282 from adk3798/cephadm-ganesha-fix-server-scope
mgr/cephadm: fix Server_Scope in ganesha.conf
Reviewed-by: John Mulligan <jmulligan@redhat.com>
Adam King [Tue, 25 Mar 2025 13:13:59 +0000 (09:13 -0400)]
Merge pull request #62329 from NitzanMordhai/wip-nitzan-suite-rados-cephadmn-still-running-ignore
suites/rados/cephadm: add still running warning to the ignore list
Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Laura Flores <lflores@ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Kefu Chai [Mon, 24 Mar 2025 02:05:25 +0000 (10:05 +0800)]
librbd: migrate from boost::variant to std::variant
migrate from boost::variant to std::variant
Complete migration started in commit
017f3339c , replacing boost::variant with
std::variant throughout the librbd codebase. This change is part of our ongoing
effort to reduce third-party dependencies by leveraging C++ standard library
alternatives where possible.
Benefits include:
- Improved code readability and maintainability
- Reduced external dependency surface
- More consistent API usage with other components
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Aashish Sharma [Tue, 25 Mar 2025 11:35:05 +0000 (17:05 +0530)]
mgr/dashboard: fix image filter's query on rbd-details grafana panel
The image filter on the RBD Details grafana panel is using a query with a type "label_values(ceph_rbd_read_ops{cluster=~\"$cluster\", , pool=\"$pool\"}, image)". The extra comma needs to be removed.
Fixes: https://tracker.ceph.com/issues/70653
Signed-off-by: Aashish Sharma <aasharma@redhat.com>
Yite Gu [Tue, 25 Mar 2025 11:28:05 +0000 (19:28 +0800)]
common/interval_set: erase() func should be return an iterator
Signed-off-by: Yite Gu <guyite@bytedance.com>
Yite Gu [Tue, 25 Mar 2025 03:05:09 +0000 (11:05 +0800)]
blk/kerneldevice: fix invalid iterator usage after erase in discard_queued traversal
fixes: https://tracker.ceph.com/issues/70636
Signed-off-by: Yite Gu <guyite@bytedance.com>
Zac Dover [Tue, 25 Mar 2025 09:46:15 +0000 (19:46 +1000)]
doc/cephadm: format "Configuration" in cephadm.rst
Improve the formatting in the section "Configuration" in
doc/cephadm/certmgr/cephadm.rst.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Ilya Dryomov [Tue, 25 Mar 2025 08:13:27 +0000 (09:13 +0100)]
mgr/rbd_support: always parse interval and start_time in Schedules::remove()
Commit
1b62447071a9 ("mgr/rbd_support: fix schedule remove") addressed
the issue that it was concerned with in a rather suboptimal way: instead
of moving the parsing of interval and start_time upfront to be able to
bail early, it wrapped from_string() constructors with try/finally and
left the conditional behavior in place.
Fixes: https://tracker.ceph.com/issues/70640
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Nizamudeen A [Tue, 25 Mar 2025 08:01:29 +0000 (13:31 +0530)]
Merge pull request #62411 from rhcs-dashboard/notification-icon-fix
mgr/dashboard: fix notification icon size
Nizamudeen A [Tue, 25 Mar 2025 07:54:54 +0000 (13:24 +0530)]
Merge pull request #62410 from rhcs-dashboard/custom-pool-dashboard
mgr/dashboard: use existing pools for cephfs vol creation
Nizamudeen A [Tue, 25 Mar 2025 07:51:21 +0000 (13:21 +0530)]
Merge pull request #62027 from rhcs-dashboard/admin-ops-api-for-rgw-accounts
mgr/dashboard: Use admin ops API for rgw accounts
Nizamudeen A [Tue, 25 Mar 2025 07:50:34 +0000 (13:20 +0530)]
Merge pull request #62415 from rhcs-dashboard/tenanted-bucket-lifecycle-fix
mgr/dashboard: tenanted bucket lifecycle management fix
Kefu Chai [Tue, 25 Mar 2025 07:11:34 +0000 (15:11 +0800)]
erasure-code: use new/delete to alloc/free coefficients array
before this change, we allocate coefficients table with malloc() in
ErasureCodeIsaDefault::prepare(), but free them using delete.
so, in this change, we use new [] and delete [] to allocate and free
them, to be more consistent, and to silence this warning.
this issue was identified by AddressSanitizer:
```
2025-03-22T04:27:58.210 INFO:tasks.ceph.osd.3.smithi102.stderr:==42899==ERROR: AddressSanitizer: alloc-dealloc-mismatch (operator new [] vs free) on 0x611000570d40
2025-03-22T04:27:58.253 DEBUG:teuthology.orchestra.run.smithi102:> sudo adjust-ulimits ceph-coverage /home/ubuntu/cephtest/archive/coverage timeout 120 env ASAN_OPTIONS=detect_leaks=0,detect_odr_violation=0,alloc_dealloc_mismatch=0 LD_PRELOAD=/lib64/libasan.so.6 ceph --cluster ceph osd pool set cephfs_data_ec allow_ec_overwrites true
2025-03-22T04:27:58.442 INFO:tasks.ceph.osd.3.smithi102.stderr: #0 0x7efdc30b46b7 in free (/lib64/libasan.so.6+0xb46b7)
2025-03-22T04:27:58.442 INFO:tasks.ceph.osd.3.smithi102.stderr: #1 0x7efd9e2e5f26 in ErasureCodeIsaTableCache::setEncodingTable(int, int, int, unsigned char*) (/usr/lib64/ceph/erasure-code/libec_isa.so+0x3bf26)
2025-03-22T04:27:58.442 INFO:tasks.ceph.osd.3.smithi102.stderr: #2 0x7efd9e2f0fae in ErasureCodeIsaDefault::prepare() (/usr/lib64/ceph/erasure-code/libec_isa.so+0x46fae)
2025-03-22T04:27:58.442 INFO:tasks.ceph.osd.3.smithi102.stderr: #3 0x7efd9e2bfa3e in ErasureCodeIsa::init(std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&, std::ostream*) (/usr/lib64/ceph/erasure-code/libec_isa.so+0x15a3e)
2025-03-22T04:27:58.442 INFO:tasks.ceph.osd.3.smithi102.stderr: #4 0x7efd9e2ff510 in ErasureCodePluginIsa::factory(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&, std::shared_ptr<ceph::ErasureCodeInterface>*, std::ostream*) (/usr/lib64/ceph/erasure-code/libec_isa.so+0x55510)
2025-03-22T04:27:58.442 INFO:tasks.ceph.osd.3.smithi102.stderr: #5 0x55a7ef19b395 in ceph::ErasureCodePluginRegistry::factory(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&, std::shared_ptr<ceph::ErasureCodeInterface>*, std::ostream*) (/usr/bin/ceph-osd+0x4dcb395)
2025-03-22T04:27:58.442 INFO:tasks.ceph.osd.3.smithi102.stderr: #6 0x55a7eb9089d8 in PGBackend::build_pg_backend(pg_pool_t const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&, PGBackend::Listener*, coll_t, boost::intrusive_ptr<ObjectStore::CollectionImpl>&, ObjectStore*, ceph::common::CephContext*) (/usr/bin/ceph-osd+0x15389d8)
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr: #7 0x55a7eb4b63ec in PrimaryLogPG::PrimaryLogPG(OSDService*, std::shared_ptr<OSDMap const>, PGPool const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&, spg_t) (/usr/bin/ceph-osd+0x10e63ec)
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr: #8 0x55a7eaef1cc7 in OSD::_make_pg(std::shared_ptr<OSDMap const>, spg_t) (/usr/bin/ceph-osd+0xb21cc7)
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr: #9 0x55a7eaef8d69 in OSD::handle_pg_create_info(std::shared_ptr<OSDMap const> const&, PGCreateInfo const*) (/usr/bin/ceph-osd+0xb28d69)
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr: #10 0x55a7eafeb9ed in OSD::ShardedOpWQ::_process(unsigned int, ceph::heartbeat_handle_d*) (/usr/bin/ceph-osd+0xc1b9ed)
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr: #11 0x55a7ed04c9aa in ShardedThreadPool::shardedthreadpool_worker(unsigned int) (/usr/bin/ceph-osd+0x2c7c9aa)
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr: #12 0x55a7ed04d338 in ShardedThreadPool::WorkThreadSharded::entry() (/usr/bin/ceph-osd+0x2c7d338)
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr: #13 0x55a7ecf92b46 in Thread::entry_wrapper() (/usr/bin/ceph-osd+0x2bc2b46)
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr: #14 0x55a7ecf92b82 in Thread::_entry_func(void*) (/usr/bin/ceph-osd+0x2bc2b82)
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr: #15 0x7efdc1e8a3b1 in start_thread (/lib64/libc.so.6+0x8a3b1)
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr: #16 0x7efdc1f0f42f in __GI___clone3 (/lib64/libc.so.6+0x10f42f)
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr:
2025-03-22T04:27:58.443 INFO:tasks.ceph.osd.3.smithi102.stderr:0x611000570d40 is located 0 bytes inside of 256-byte region [0x611000570d40,0x611000570e40)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr:allocated by thread T817 here:
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #0 0x7efdc30b64d7 in operator new[](unsigned long) (/lib64/libasan.so.6+0xb64d7)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #1 0x7efd9e2f0e32 in ErasureCodeIsaDefault::prepare() (/usr/lib64/ceph/erasure-code/libec_isa.so+0x46e32)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #2 0x7efd9e2bfa3e in ErasureCodeIsa::init(std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&, std::ostream*) (/usr/lib64/ceph/erasure-code/libec_isa.so+0x15a3e)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #3 0x7efd9e2ff510 in ErasureCodePluginIsa::factory(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&, std::shared_ptr<ceph::ErasureCodeInterface>*, std::ostream*) (/usr/lib64/ceph/erasure-code/libec_isa.so+0x55510)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #4 0x55a7ef19b395 in ceph::ErasureCodePluginRegistry::factory(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > >&, std::shared_ptr<ceph::ErasureCodeInterface>*, std::ostream*) (/usr/bin/ceph-osd+0x4dcb395)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #5 0x55a7eb9089d8 in PGBackend::build_pg_backend(pg_pool_t const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&, PGBackend::Listener*, coll_t, boost::intrusive_ptr<ObjectStore::CollectionImpl>&, ObjectStore*, ceph::common::CephContext*) (/usr/bin/ceph-osd+0x15389d8)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #6 0x55a7eb4b63ec in PrimaryLogPG::PrimaryLogPG(OSDService*, std::shared_ptr<OSDMap const>, PGPool const&, std::map<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >, std::less<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >, std::allocator<std::pair<std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > > > > const&, spg_t) (/usr/bin/ceph-osd+0x10e63ec)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #7 0x55a7eaef1cc7 in OSD::_make_pg(std::shared_ptr<OSDMap const>, spg_t) (/usr/bin/ceph-osd+0xb21cc7)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #8 0x55a7eaef8d69 in OSD::handle_pg_create_info(std::shared_ptr<OSDMap const> const&, PGCreateInfo const*) (/usr/bin/ceph-osd+0xb28d69)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #9 0x55a7eafeb9ed in OSD::ShardedOpWQ::_process(unsigned int, ceph::heartbeat_handle_d*) (/usr/bin/ceph-osd+0xc1b9ed)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #10 0x55a7ed04c9aa in ShardedThreadPool::shardedthreadpool_worker(unsigned int) (/usr/bin/ceph-osd+0x2c7c9aa)
2025-03-22T04:27:58.444 INFO:tasks.ceph.osd.3.smithi102.stderr: #11 0x55a7ed04d338 in ShardedThreadPool::WorkThreadSharded::entry() (/usr/bin/ceph-osd+0x2c7d338)
2025-03-22T04:27:58.445 INFO:tasks.ceph.osd.3.smithi102.stderr: #12 0x55a7ecf92b46 in Thread::entry_wrapper() (/usr/bin/ceph-osd+0x2bc2b46)
2025-03-22T04:27:58.445 INFO:tasks.ceph.osd.3.smithi102.stderr: #13 0x55a7ecf92b82 in Thread::_entry_func(void*) (/usr/bin/ceph-osd+0x2bc2b82)
2025-03-22T04:27:58.445 INFO:tasks.ceph.osd.3.smithi102.stderr: #14 0x7efdc1e8a3b1 in start_thread (/lib64/libc.so.6+0x8a3b1)
2025-03-22T04:27:58.445 INFO:tasks.ceph.osd.3.smithi102.stderr:
```
Fixes: https://tracker.ceph.com/issues/70619
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Yingxin Cheng [Tue, 25 Mar 2025 06:31:37 +0000 (14:31 +0800)]
Merge pull request #62425 from cyx1231st/wip-seastore-cleanups
crimson/os/seastore: misc cleanups
Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>
Nizamudeen A [Tue, 25 Mar 2025 05:54:54 +0000 (11:24 +0530)]
mgr/cephadm: upgrade grafana to 10.4.16
Signed-off-by: Nizamudeen A <nia@redhat.com>
Kefu Chai [Tue, 25 Mar 2025 04:17:35 +0000 (12:17 +0800)]
common: remove spaces before literal operator
clang 20 complains when compiling a user-defined literal operator
with spaces before the underscore. so let's drop the space to be
compliant to
[CWG2521](https://cplusplus.github.io/CWG/issues/2521.html).
```
/home/kefu/dev/ceph/src/common/options.h:415:41: warning: identifier '_min' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
415 | constexpr unsigned long long operator"" _min (unsigned long long min) {
| ~~~~~~~~~~~^~~~
| operator""_min
```
Signed-off-by: Kefu Chai <tchaikov@gmail.com>
Afreen Misbah [Fri, 21 Mar 2025 01:53:32 +0000 (07:23 +0530)]
mgr/dashboard: KiB not supported size for namespace creation
Fixes https://tracker.ceph.com/issues/70106
Signed-off-by: Afreen Misbah <afreen@ibm.com>
Ilya Dryomov [Mon, 24 Mar 2025 23:04:50 +0000 (00:04 +0100)]
Merge pull request #62464 from idryomov/wip-70632
librbd: respect rbd_default_snapshot_quiesce_mode in group_snap_create()
Reviewed-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>
Laura Flores [Mon, 24 Mar 2025 20:39:47 +0000 (15:39 -0500)]
Merge pull request #62422 from ljflores/wip-pg-upmap-prim-release-note
PendingReleaseNotes; doc/rados/operations: document "rm-pg-upmap-primary-{all}" commands
Ilya Dryomov [Mon, 24 Mar 2025 19:07:03 +0000 (20:07 +0100)]
Merge pull request #62269 from nbalacha/wip-nbalacha-rbd-mirrorpool-errmsg
rbd: print the return codes on error for mirror pool commands
Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
Patrick Donnelly [Mon, 24 Mar 2025 15:50:50 +0000 (11:50 -0400)]
mgr: add status command
The Rook operator relies on a `status` (asok) command to the mgr to verify it
is operational. However, this command was actually served by the CephFS
`Client` library that the ceph-mgr daemon statically linked in and used for
sending MDS commands. That statically linked client was removed via
048fc68c
(case insensitive directory tree feature).
So, add a legitimate ceph-mgr status command which simply outputs an empty
dictionary and returns success (0). TBD on adding useful information.
Fixes: 048fc68c517f50b9978457f478ca4638f01caa09
Fixes: https://tracker.ceph.com/issues/70571
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
Casey Bodley [Mon, 24 Mar 2025 17:47:49 +0000 (13:47 -0400)]
Merge pull request #54957 from jzhu116-bloomberg/wip-63799
rgw: revert PR #41897 to allow multiple delete markers to be created
Reviewed-by: Casey Bodley <cbodley@redhat.com>
Igor Fedotov [Fri, 21 Mar 2025 10:25:41 +0000 (13:25 +0300)]
os/bluestore: introduce locking for the very first DB/WAL alloc unit.
Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
Ilya Dryomov [Fri, 21 Mar 2025 13:49:44 +0000 (14:49 +0100)]
librbd: don't use public API flags in Group::snap_create()
Use internal flags obtained from snap_create_flags_api_to_internal()
instead -- internal_flags variable was assigned but not used.
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Ilya Dryomov [Fri, 21 Mar 2025 13:43:50 +0000 (14:43 +0100)]
librbd: respect rbd_default_snapshot_quiesce_mode in group_snap_create()
Make group_snap_create() behave the same as snap_create() and
mirror_image_create_snapshot(): APIs that don't take RBD_SNAP_CREATE_
flags explicitly should respect rbd_default_snapshot_quiesce_mode
option.
Fixes: https://tracker.ceph.com/issues/70632
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
Casey Bodley [Mon, 24 Mar 2025 15:48:51 +0000 (11:48 -0400)]
qa/rgw: enable lockdep config for radosgw
lockdep.yaml was only enabling lockdep for osd/mon. if it's actually
worth running, we should enable it for radosgws too
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Kotresh HR [Mon, 24 Mar 2025 12:36:36 +0000 (18:06 +0530)]
Merge pull request #60684 from salieri11/wip-igolikov-asok-56442
mds: add MDS asok command for dumping stray directories
Patrick Donnelly [Mon, 24 Mar 2025 12:31:39 +0000 (08:31 -0400)]
Merge PR #62439 into main
* refs/pull/62439/head:
.github/workflows,script: add test for missing .qa links
qa: add missing .qa links
Reviewed-by: Ernesto Puerta <epuertat@redhat.com>
Zac Dover [Mon, 24 Mar 2025 12:26:11 +0000 (22:26 +1000)]
src/common: add guidance for deep-scrubbing ratio warning
Add an explanation of how to set the value of
"mon_warn_pg_not_deep_scrubbed_ratio" to the confval definition of that
variable. Although this variable contains the string "mon", it is set on
the Manager. I have added a note to direct users to set this value on
the Manager.
This issue was pointed out by Petr Tlapa on Slack in late March of 2025.
Signed-off-by: Zac Dover <zac.dover@proton.me>
Aashish Sharma [Wed, 19 Mar 2025 11:29:27 +0000 (16:59 +0530)]
mgr/dashboard: fix blockUI implementation
Enable/Disable mgr modules from SMB page, Rgw multisite Page and Mgr Modules page doesn't give proper message and doesn't block the UI
This PR intends to fix this issue
Fixes: https://tracker.ceph.com/issues/70557
Signed-off-by: Aashish Sharma <aasharma@redhat.com>