test/crimson/test_errorator: showcase assert_all/handle/pass_furhter

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #62649 from Matan-B/wip-matanb-crimson-coroutines-errors

test/crimson/test_crimson_coroutines: showcase errorator examples

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #62080 from xxhdx1985126/wip-70180

crimson/osd/pg_recovery: use OperationThrottler to throttle object pushes/pulls

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #62687 from anthonyeleven/acronym

doc/cephadm/services: improve rgw.rst and snmp-gateway.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>

doc/cephadm/services: improve rgw.rst and snmp-gateway.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #53799 from smanjara/wip-shilpa-cleanup-bi

rgw/multisite: bucket instance cleanup after deletion

rgw/multisite: account for zones opted out of sync and object filters
during bucket deletion

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw: remove unused objv tracker

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: check for both zonegroup and bucket level sync policies
when returning enotempty during bucket deletion

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

qa/tests: test for bucket enotempty check during delete

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/trim: restore update_mapping_update in RGWBucketInstanceMetadataHandler::remove
- fix testcase

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/trim: fix ENOENT return response from bucket sync status query.
only handle them when the bucket metadata is deleted. there is a case
when we get enoent when status objects have not been created yet,
for example when bucket metadata is created and synced but no data
exists yet and bucket sync status won't be initialized. these don't
need special handling.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

qa/multisite: test trimming bilog on all zonegroups

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

qa/multisite: test with checkpoint delays

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: don't sync metadata entry for bucket instance removal.
removal should happen locally

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: thread svc_datalog through RGWBucketCtl and BucketInstanceMetadataHandler

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multiiste: fix bucket enotempty check

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: move the remote bucket listing logic into a separate
function.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: in a multisite env with bucket sync policies configured,
we may end up orphaning objects on remote zones when a delete bucket
is issued on metadata master. to avoid this, list the buckets on remote
zones and delete bucket only when empty. if a zone is unreachable we
drop that zone and continue with bucket deletion. such zones might have
orphaned objects that will have to be cleaned up using radosgw-admin tool

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

qa/multisite: update test for bucket instance deletion

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: - add deleted layout on master zone
- handle the case when StatusShards returns -ENOENT

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

qa/multisite: add a bilog trim testcase with bucket deletion

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: add datalog entry when transitioning to 'DELETED' log layout

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: helper function to store bucket info flag

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: retry on detecting bucket instance metadata racing writes

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: - don't overwrite bucket attrs while storing bucket instance info.
- get rid of the helper function that adds the 'deleted' log layout.

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: add 'deleted' as a RGWBucketInfo flag

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: handle the 'deleted' index log addition in RGWBucketInstanceMetadataHandler.
create an async cr for removing bucket instance info in bilog trimming logic

Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

rgw/multisite: draft of bucket index cleanup after deletion

tracker: https://tracker.ceph.com/issues/20802
Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #62637 from smanjara/wip-rgw-revert-62323

rgw/multisite: revert pr 62323

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #62680 from tchaikov/cmake-deprecated-warning

cmake: Fix googletest deprecated warnings by using target_compile_options()

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #62511 from tchaikov/test-remove-unused-var

test/ObjectMap: Remove unused CONTROL_PREFIX variable

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

cmake: Fix googletest deprecated warnings by using target_compile_options()

Previously, we attempted to disable deprecated declarations warnings when
building gtest by adding `-Wno-deprecated-declarations` to the COMPILE_OPTIONS
property of the googletest directory. However, this approach failed to apply
the option when actually building gtest.

This change applies the compile option directly to the `gtest` target using
target_compile_options() instead. Verified by forcing the condition to TRUE
and confirming the option is included when building `gtest-all.cc` through
`cmake --build ~/dev/ceph/build --target gtest --verbose`.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

crimson/osd/pg_recovery: use OperationThrottler to throttle object
pushes/pulls

Instead of throttling recovery/backfill operations

Fixes: https://tracker.ceph.com/issues/70180
Signed-off-by: Xuehan Xu <xuxuehan@qianxin.com>

Merge pull request #61751 from VallariAg/wip-nvmeof-grafana-config

monitoring: add grafana nvmeof dashboard

Merge pull request #62661 from anthonyeleven/improve-62597

doc/radosgw: Improve cloud-restore and cloud-transition

doc/radosgw: Improve cloud-restore and cloud-transition

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Revert "rgw: reject PutBucketReplication on mismatched versioning and lock"

This reverts commit 7e47deede0ba672dab8d2a26c807d8a32d46a73a.
Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

Revert "rgw: skip versioned entries to non-versioned buckets and vice-versa"

This reverts commit 2c4b718162198e6db679113ce3196b391d8571e5.
Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

Revert "rgw: skip replication from lock enabled buckets to lock disbaled buckets"

This reverts commit 826d49368961677f05bc53fd1e4b6cc999057cdd.
Signed-off-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #62597 from soumyakoduri/wip-skoduri-restore-doc

rgw: Updating doc for cloud-restore feature

Merge pull request #62524 from ivancich/wip-fix-gap-list-tool

rgw: fix bug with rgw-gap-list

Reviewed-by: Jesse Williamson <jfw@ibm.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #56499 from adamemerson/wip-rgw-close-datalog-write-hole

rgw: Close datalog write hole

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #62583 from phlogistonjohn/jjm-refix-setsebool

qa/cephadm/smb: run setsebool with sudo

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #62639 from phlogistonjohn/jjm-doc-note-clustering-opt

doc/mgr: add a warning about the smb clustering option & placement

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Sachin Prabhu <sp@spui.uk>

Merge pull request #62604 from jzhu116-bloomberg/wip-70746

rgw: keep the tails when copying object to itself

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #62325 from Matan-B/wip-matanb-with-crimson

src: sed -i 's/WITH_SEASTAR/WITH_CRIMSON/'

Reviewed-by: Samuel Just <sjust@redhat.com>
Reviewed-by: Yingxin Cheng <yingxin.cheng@intel.com>
Reviewed-by: Casey Bodley <cbodley@redhat.com>

test/crimson/test_crimson_coroutines: showcase errorator examples

This came up in https://github.com/ceph/ceph/pull/62530.
Showcase an awaited throwing coroutine and a passed_further error.

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

monitoring: Add nvmeof performance grafana dashboard

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>

monitoring: Add nvmeof overview grafana dashboard

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>

monitoring: make timeSeriesPanel default fillOpacity=8

Change default value of fillOpacity from 0 to 8 for
timeseries graphs.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>

monitoring: add 'description' to timeSeriesPanel

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>

monitoring: add 'noValue' config to garfana panels

Add noValue param to garfana panel functions:
- timeSeriesPanel
- addStatPanel

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>

Merge pull request #61804 from aainscow/erasure_code_chunks

osd: Modify erasure code plugins ready for new EC

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #62233 from kamoltat/wip-ksirivad-ceph-s-leader-mon

mon: Add leader indicator && stretch mode to ceph -s output

Merge pull request #57806 from dongbula/wip-speed-oc-flush2

osdc/ObjectCacher: avoid io blocking for bufferheads exceed limit

Merge pull request #56612 from Matan-B/wip-matanb-remove-snapset-snaps

osd: cleanup Snapset::snaps

Merge pull request #62205 from leonidc/wip-leonidc-redeploy-fix

nvmeofgw* :do not allow failover for gws during redeploy (fast-reboot)

Merge pull request #62223 from aainscow/enable-switch-flag

osd:  Add ability to switch EC optimizations on

Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>|
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Samuel Just <sjust@redhat.com>

Merge pull request #62641 from tchaikov/cmake-set_property

cmake: Fix warning suppression for googletest build

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #62629 from rhcs-dashboard/cluster-mgr-role-fix

mgr/dashboard: add prometheus read permission to cluster_mgr role

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

ceph.spec.in, install-deps: sed -i 's/seastar/crimson/'

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

src: sed -i 's/WITH_SEASTAR/WITH_CRIMSON/'

Signed-off-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #62643 from zdover23/wip-doc-2025-04-03-cephadm-upgrade

doc/cephadm: s/confg/config/

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

doc/cephadm: s/confg/config/

Correct a misspelled command.

Re: https://github.com/ceph/ceph/pull/62367#discussion_r2025832937

Signed-off-by: Zac Dover <zac.dover@proton.me>

cmake: Fix warning suppression for googletest build

In commit 27e9d563, we attempted to disable deprecated warnings when building
googletest, but the implementation contained two errors:

1. The `set_property()` call occurred before adding the target directory,
   making it impossible to set properties on non-existent objects.
2. The `-Wno-deprecated-declarations` flag was incorrectly passed as an
   `APPEND` argument instead of a `PROPERTY` argument.

This caused build failures with libstdc++-12 and newer Clang versions:

```
CMake Error at src/CMakeLists.txt:772 (set_property):
  set_property given invalid argument "-Wno-deprecated-declarations".
```

This commit fixes both issues by:
- Moving the `set_property()` call after `add_subdirectory()`
- Correctly passing the warning flag as a `PROPERTY` argument

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #62592 from adk3798/cephadm-rgw-only-bind-on-networks

mgr/cephadm: add only_bind_port_on_networks support for rgw

Reviewed-by: Kushal Deb <Kushal.Deb@ibm.com>
Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>

Merge pull request #62362 from phlogistonjohn/jjm-mgr-smb-tweaks

mgr/smb: additional input and output controls

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: Sachin Prabhu <sp@spui.uk>

Merge pull request #61461 from NitzanMordhai/wip-nitzan-ec-clay-profile-config-wrong-d

erasure-code: clay wrong d calculation

test: IO sequence exerciser enable ec optimisations

The io sequencer has been written to primarily test the new EC code.  This commit
turns that flag on by default.  It also provides a flag to disable the new
optimizations, which we expect to drop in the future.

Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>

osd: EC Switcher actually switches between two (identical) EC implementations

Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>

osd: Create a new interval when the optimization flag gets switch on.

This allows for the old EC code to cleanly shutdown using the on_change
notification. The new code can then start up cleanly.

Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>

osd: Add EC_OPTIMIZATIONS flag and add ability to switch it on.

This is the basic command. On its own, this does nothing functional, except set
a flag which can be queried.

Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>

doc/mgr: add a warning about the smb clustering option & placement

Add a warning to the docs highlighting that `clustering` is an advanced
option and setting it without out also setting a compatible placement
value may lead to unexpected behavior.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #61638 from jamiepryde/58052-release-note

PendingReleaseNotes: add note about changing default EC plugin from Jerasure to ISA-L

Merge pull request #62543 from rhcs-dashboard/smb-carbonize-tabs

mgr/dashboard: carbonize smb tabs

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #62614 from rhcs-dashboard/fix-smb-placement

mgr/dashboard: fix smb cluster placement

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #62294 from rzarzynski/wip-bypassable-ceph-assert

common, *: make the abort() in ceph_assert() bypassable

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Laura Flores <lflores@redhat.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #55696 from bill-scales/main

common/mempool.cc: Improve performance of sharding

Reviewed-by: Adam Kupczyk <akupczyk@redhat.com>
Reviewed-by: Jose Juan Palacios-Perez <perezjos@uk.ibm.com>
Reviewed-by: John Agombar <agombar@uk.ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

Merge pull request #58652 from adk3798/mgr-rgw-create-ec-data-pool

mgr/rgw: add ability for rgw realm bootstrap to create pools

Reviewed-by: Kushal Deb <Kushal.Deb@ibm.com>

Merge pull request #62611 from rhcs-dashboard/ec-fixes

mgr/dashboard: add enhancements for pool rulest

Reviewed-by: Aashish Sharma <aasharma@redhat.com>

Merge pull request #60614 from adk3798/host-maintenance-exit-refresh-daemons

mgr/cephadm: trigger host metadata refresh when taking host out of maintenance

Reviewed-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>

rgw: remove keep_tail from RGWObjState

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>

mgr/dashboard: carbonize smb tabs

also removes share tab as was the only one in favour of title and description

Fixes: https://tracker.ceph.com/issues/70695
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>

Merge pull request #62622 from tchaikov/cmake-disable-deprecated-warning

cmake: disable deprecated warning when building googletest

Reviewed-by: Casey Bodley <cbodley@redhat.com>

mgr/dashboard: add prometheus read permission to cluster_mgr role

Fixes: https://tracker.ceph.com/issues/70768
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: fix smb cluster placement

Fixes: https://tracker.ceph.com/issues/70757
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>

mgr/dashboard: add enhancements for pool rulest

On EC pool:
- Use host count instead of device count for host crush-failure-domain
- Host warning for k+m+1
On replicated:
- Set 'All devices' as default

Fixes: https://tracker.ceph.com/issues/70764
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>

Merge pull request #62246 from aclamk/wip-aclamk-write-v2-tune-down-unused

os/bluestore/write-v2: Tune down usage of 'unused'

Merge pull request #62457 from rhcs-dashboard/nvmeof-upgrade-bug

mgr/dashboard: upgrading nvmeof doesn't update configuration

Merge pull request #62609 from aainscow/io_exerciser_restrict

test/common: EC Optimizations: rados io sequencer exerciser extensions

Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Reviewed-by: Jonathan Bailey <jonathan.bailey1@ibm.com>

Merge pull request #61696 from MaxKellermann/osd_includes

osd: include cleanup

Reviewed-by: Matan Breizman <mbreizma@redhat.com>

Merge pull request #62542 from rhcs-dashboard/smb-service-section

mgr/dashboard: add separation for service section in smb cluster form

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #62541 from rhcs-dashboard/fix-scroll

mgr/dashboard: fix domain settings modal scrollable

Reviewed-by: Nizamudeen A <nia@redhat.com>

PendingReleaseNotes: add note to change default EC plugin from Jerasure to ISA-L

Signed-off-by: Jamie Pryde <jamiepry@uk.ibm.com>

Merge pull request #62047 from rhcs-dashboard/fix-70226-main

monitoring: Fix OSDs panel in host-details grafana dashboard

Reviewed-by: Nizamudeen A <nia@redhat.com>

Merge pull request #62598 from rhcs-dashboard/nvmf-subsys-ha-default

mgr/dashboard: enable ha by default on subsystem POST API

cmake: disable deprecated warning when building googletest

In commit 986f6918, we updated the googletest submodule to silence a
CMake warning. However, this change broke the build due to a Clang issue
where it warns about deprecated declarations even from system headers
(see https://github.com/llvm/llvm-project/issues/76515). Since we use
`-Werror` in our compile options, these warnings become errors and fail
the build.

This change detects if we're affected by the specific combination of
compiler, standard library, and compile options that triggers this
issue. It then conditionally disables the `-Wdeprecated-declarations`
warning when building googletest to resolve build failures caused by
deprecated functions like `get_temporary_buffer<>` in the standard
library.

The build failure looks like:
```
FAILED: src/googletest/googletest/CMakeFiles/gtest.dir/src/gtest-all.cc.o
...
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest-all.cc:38:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/include/gtest/gtest.h:55:
In file included from /usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/memory:66:
/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_tempbuf.h:263:8: error: 'get_temporary_buffer<testing::TestInfo *>' is deprecated [-Werror,-Wdeprecated-declarations]
  263 |                 std::get_temporary_buffer<value_type>(_M_original_len));
      |                      ^
/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_algo.h:4996:15: note: in instantiation of member function 'std::_Temporary_buffer<__gnu_cxx::__normal_iterator<testing::TestInfo **, std::vector<testing::TestInfo *>>, testing::TestInfo *>::_Temporary_buffer' requested here
 4996 |       _TmpBuf __buf(__first, (__last - __first + 1) / 2);
      |               ^
/usr/lib/gcc/x86_64-linux-gnu/12/../../../../include/c++/12/bits/stl_algo.h:5070:23: note: in instantiation of function template specialization 'std::__stable_sort<__gnu_cxx::__normal_iterator<testing::TestInfo **, std::vector<testing::TestInfo *>>, __gnu_cxx::__ops::_Iter_comp_iter<(lambda at /home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:3024:20)>>' requested here
 5070 |       _GLIBCXX_STD_A::__stable_sort(__first, __last,
      |                       ^
/home/jenkins-build/build/workspace/ceph-pull-requests/src/googletest/googletest/src/gtest.cc:3023:8: note: in instantiation of function template specializatio
```

Signed-off-by: Kefu Chai <tchaikov@gmail.com>

Merge pull request #62617 from anthonyeleven/pushme-pullme

doc/rados/configuration: Correct admonition in ceph-conf.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>

doc/rgw: Updating doc for cloud-restore feature

Signed-off-by: Soumya Koduri <skoduri@redhat.com>