]> git.apps.os.sepia.ceph.com Git - ceph.git/log
ceph.git
3 months agodoc/cephadm/services: Fix formatting in osd.rst 62810/head
Anthony D'Atri [Mon, 14 Apr 2025 05:18:03 +0000 (01:18 -0400)]
doc/cephadm/services: Fix formatting in osd.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit c56d2a5aaf79a3440607946a55b9e59ca8a6de5b)

3 months agoMerge pull request #61323 from ljflores/wip-69493-squid
Laura Flores [Mon, 14 Apr 2025 15:17:02 +0000 (10:17 -0500)]
Merge pull request #61323 from ljflores/wip-69493-squid

squid: common/pick_address: Add IPv6 support to is_addr_in_subnet

3 months agoMerge pull request #62796 from zdover23/wip-doc-2025-04-14-backport-62784-to-squid
Anthony D'Atri [Mon, 14 Apr 2025 01:43:31 +0000 (21:43 -0400)]
Merge pull request #62796 from zdover23/wip-doc-2025-04-14-backport-62784-to-squid

squid: doc/cephadm: Add admonition re restarting an OSD service

3 months agodoc/cephadm: Add admonition re restarting an OSD service 62796/head
Anthony D'Atri [Fri, 11 Apr 2025 14:29:52 +0000 (10:29 -0400)]
doc/cephadm: Add admonition re restarting an OSD service

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 524db4609f5f0b4639828b327cfc972243e08ce7)

3 months agoMerge pull request #62711 from cbodley/wip-70783-squid
Casey Bodley [Fri, 11 Apr 2025 16:01:53 +0000 (12:01 -0400)]
Merge pull request #62711 from cbodley/wip-70783-squid

squid: rgw: keep the tails when copying object to itself

Reviewed-by: Jane Zhu <jzhu116@bloomberg.net>
3 months agoMerge pull request #62739 from ceph/squid-release
Yuri Weinstein [Thu, 10 Apr 2025 20:07:15 +0000 (13:07 -0700)]
Merge pull request #62739 from ceph/squid-release

v19.2.2

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #62311 from adamemerson/wip-63786-squid
Yuri Weinstein [Thu, 10 Apr 2025 14:53:09 +0000 (07:53 -0700)]
Merge pull request #62311 from adamemerson/wip-63786-squid

squid: test/cls_2pc_queue: fix multi-threaded access to non-atomic variables

Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>
3 months agoMerge pull request #62307 from adamemerson/wip-63378-squid
Yuri Weinstein [Thu, 10 Apr 2025 14:51:43 +0000 (07:51 -0700)]
Merge pull request #62307 from adamemerson/wip-63378-squid

squid: rgw/multisite: handle errors properly in RGWDataFullSyncSingleEntryCR()

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
3 months agoMerge pull request #60785 from awojno-bloomberg/wip-68995-squid
Yuri Weinstein [Thu, 10 Apr 2025 14:50:40 +0000 (07:50 -0700)]
Merge pull request #60785 from awojno-bloomberg/wip-68995-squid

squid: rgw: implement x-amz-replication-status for PENDING & COMPLETED

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 months agoMerge pull request #62731 from afreen23/wip-70836-squid
afreen23 [Thu, 10 Apr 2025 08:52:48 +0000 (14:22 +0530)]
Merge pull request #62731 from afreen23/wip-70836-squid

squid: mgr/dashboard: Fix empty ceph version in GET api/hosts

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Naman Munet <nmunet@redhat.com>
3 months agoMerge pull request #62395 from shraddhaag/wip-70135-squid
SrinivasaBharathKanta [Thu, 10 Apr 2025 01:20:47 +0000 (06:50 +0530)]
Merge pull request #62395 from shraddhaag/wip-70135-squid

squid: rados/test_crash.sh: add PG_DEGRADED to ignorelist

3 months agoMerge pull request #62402 from adamemerson/wip-70422-squid
Yuri Weinstein [Wed, 9 Apr 2025 19:31:57 +0000 (12:31 -0700)]
Merge pull request #62402 from adamemerson/wip-70422-squid

squid: rgw: Try to handle unwatch errors sensibly

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #61986 from zdover23/wip-doc-2025-02-25-backport-61984-to-squid
Yuri Weinstein [Wed, 9 Apr 2025 19:27:50 +0000 (12:27 -0700)]
Merge pull request #61986 from zdover23/wip-doc-2025-02-25-backport-61984-to-squid

squid: doc/rgw: clarify path-style vs virtual-hosted-style access

Reviewed-by: Casey Bodley <cbodley@redhat.com>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 months agoMerge pull request #62540 from jbaergen-do/btree2-backport-upstream-squid
Igor Fedotov [Wed, 9 Apr 2025 16:52:30 +0000 (19:52 +0300)]
Merge pull request #62540 from jbaergen-do/btree2-backport-upstream-squid

squid: Backport the hybrid_btree2 allocator and prereqs

Reviewed-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agoMerge pull request #62143 from ifed01/wip-ifed-no-compression-plugin-reload-squid
NitzanMordhai [Wed, 9 Apr 2025 07:26:54 +0000 (10:26 +0300)]
Merge pull request #62143 from ifed01/wip-ifed-no-compression-plugin-reload-squid

squid: os/bluestore: do cache locally compressor engines ever used

3 months agoMerge pull request #61854 from batrick/wip-69960-squid
NitzanMordhai [Wed, 9 Apr 2025 07:13:54 +0000 (10:13 +0300)]
Merge pull request #61854 from batrick/wip-69960-squid

squid: pybind/mgr/mgr_module: turn off all automatic transactions

3 months agoMerge pull request #62221 from ifed01/wip-ifed-limit-discard-qlen-squid
NitzanMordhai [Wed, 9 Apr 2025 07:09:05 +0000 (10:09 +0300)]
Merge pull request #62221 from ifed01/wip-ifed-limit-discard-qlen-squid

squid: blk/KernelDevice: Introduce a cap on the number of pending discards

3 months agoMerge pull request #60562 from rishabh-d-dave/wip-68678-squid
SrinivasaBharathKanta [Wed, 9 Apr 2025 00:56:59 +0000 (06:26 +0530)]
Merge pull request #60562 from rishabh-d-dave/wip-68678-squid

squid: mgr: allow disabling always-on modules

3 months agoMerge pull request #62211 from NitzanMordhai/wip-70383-squid
SrinivasaBharathKanta [Wed, 9 Apr 2025 00:55:12 +0000 (06:25 +0530)]
Merge pull request #62211 from NitzanMordhai/wip-70383-squid

squid: suites/rados: cache tier deprecated, no need to keep the tests for it

3 months ago19.2.2 62739/head v19.2.2
Ceph Release Team [Tue, 8 Apr 2025 21:08:38 +0000 (21:08 +0000)]
19.2.2

Signed-off-by: Ceph Release Team <ceph-maintainers@ceph.io>
3 months agoPendingReleaseNote: add release note that mgr/volumes plugin can be... 60562/head
Rishabh Dave [Sun, 28 Jul 2024 17:36:42 +0000 (23:06 +0530)]
PendingReleaseNote: add release note that mgr/volumes plugin can be...

disabled now.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 3232f6b7af15c011774c3ff37c8a98e5cf7c4887)

3 months agoqa/cephfs: test enable/disable of volumes plugin
Rishabh Dave [Sun, 28 Jul 2024 16:43:07 +0000 (22:13 +0530)]
qa/cephfs: test enable/disable of volumes plugin

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 0abc227131c3e16077013f25a7c0fcfe1b7285a1)

Conflicts:
qa/cephfs/overrides/ignorelist_health.yaml
- this file in main had more entries than on this (squid) branch,
  resulting in cherry-picking conflict.

qa/tasks/cephfs/test_admin.py
- this file in main had more tests and a new set of test adjacent to
  tests added by this patch-series, resulting in cherry-picking conflict.

3 months agomon/MgrMonitor: allow disabling always-on MGR modules
Rishabh Dave [Thu, 18 Jul 2024 19:38:07 +0000 (01:08 +0530)]
mon/MgrMonitor: allow disabling always-on MGR modules

Add a new command ("ceph mgr module force disable <module>") that allows
forcibly disabling an always-on module. This command should ideally only
be used to for cluster recovery.

Fixes: https://tracker.ceph.com/issues/66005
Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 9962772358048a98a6e871dccf1bfd0a15b4d791)

3 months agomon/MgrMontitor: add log entry to support debugging
Rishabh Dave [Thu, 8 Aug 2024 17:18:03 +0000 (22:48 +0530)]
mon/MgrMontitor: add log entry to support debugging

It becomes easier to understand logs when whether command succeeded or
not are also logged.

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit 4374ac74d283ce1c50616330a0127a53623d96c3)

3 months agomon/MgrMonitor: improve a log message
Rishabh Dave [Wed, 17 Jul 2024 12:35:33 +0000 (18:05 +0530)]
mon/MgrMonitor: improve a log message

Following log message has 3 distinct information (enabled modules,
modules that are alwats on and total number of commands enabled) printed
on the same line which makes it hard to find one of the information and
also makes it comparatively hard to read -

2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial initial modules iostat,nfs,volumes, always on modules balancer,crash,devicehealth,orchestrator,pg_autoscaler,progress,status,telemetry, 50 commands

With this commit it would be easier to read and find needed info -

2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial initial modules: iostat,nfs,volumes
2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial always on modules: balancer,crash,devicehealth,orchestrator,pg_autoscaler,progress,status,telemetry
2024-07-17T17:21:16.609+0530 7f534ae006c0  0 mon.a@0(leader).mgr e0 create_initial 50 commands

Signed-off-by: Rishabh Dave <ridave@redhat.com>
(cherry picked from commit e830f89240e382fdf5da676437ff783c4ea6ae42)

3 months agoMerge pull request #62270 from cybozu/wip-70445-squid
Ilya Dryomov [Tue, 8 Apr 2025 19:30:02 +0000 (21:30 +0200)]
Merge pull request #62270 from cybozu/wip-70445-squid

squid: debian: add ceph-exporter package

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>
3 months agomgr/dashboard: Fix empty ceph version in GET api/hosts 62731/head
Afreen Misbah [Mon, 7 Apr 2025 19:00:08 +0000 (00:30 +0530)]
mgr/dashboard: Fix empty ceph version in GET api/hosts

Fixes https://tracker.ceph.com/issues/70821

Due to the pagination the host list is being fetched from orchestrator which caused a regression as via orchestrator list ceph version is always marked empty.
Caused by https://github.com/ceph/ceph/pull/52154

Also fixed tests , as the new version addition causing whole json object mock to fail in tests

Signed-off-by: Afreen Misbah <afreen@ibm.com>
(cherry picked from commit 1aa74cf3fce6394ad08e83e91a90923d983b03c5)

3 months agoMerge pull request #61496 from ljflores/wip-69168-squid
Kamoltat (Junior) Sirivadhna [Tue, 8 Apr 2025 15:59:16 +0000 (11:59 -0400)]
Merge pull request #61496 from ljflores/wip-69168-squid

squid: qa/workunits/mon: ensure election strategy is "connectivity" for stretch mode
Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
3 months agorgw: remove keep_tail from RGWObjState
Jane Zhu [Wed, 2 Apr 2025 15:53:47 +0000 (15:53 +0000)]
rgw: remove keep_tail from RGWObjState

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>
(cherry picked from commit fd76b6466c298121994ba65cce3c0e76f8568841)

Conflicts:
src/rgw/rgw_sal_store.h RGWObjState is in rgw_sal.h on squid

3 months agorgw: keep the tails when copying object to itself
Jane Zhu [Tue, 1 Apr 2025 13:45:36 +0000 (13:45 +0000)]
rgw: keep the tails when copying object to itself

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>
(cherry picked from commit 333e4a9b0de745cf5be40c5f6c32df7a340b007a)

3 months agorgw: remove keep_tail from RGWObjState 62711/head
Jane Zhu [Wed, 2 Apr 2025 15:53:47 +0000 (15:53 +0000)]
rgw: remove keep_tail from RGWObjState

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>
(cherry picked from commit fd76b6466c298121994ba65cce3c0e76f8568841)

Conflicts:
src/rgw/rgw_sal_store.h RGWObjState is in rgw_sal.h on squid

3 months agorgw: keep the tails when copying object to itself
Jane Zhu [Tue, 1 Apr 2025 13:45:36 +0000 (13:45 +0000)]
rgw: keep the tails when copying object to itself

Signed-off-by: Jane Zhu <jzhu116@bloomberg.net>
(cherry picked from commit 333e4a9b0de745cf5be40c5f6c32df7a340b007a)

3 months agoMerge pull request #62625 from aaSharma14/wip-70763-squid
Aashish Sharma [Mon, 7 Apr 2025 06:46:12 +0000 (12:16 +0530)]
Merge pull request #62625 from aaSharma14/wip-70763-squid

squid: monitoring: Fix OSDs panel in host-details grafana dashboard

Reviewed-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>
3 months agoMerge pull request #62694 from zdover23/wip-doc-2025-04-07-backport-62687-to-squid
Anthony D'Atri [Sun, 6 Apr 2025 20:35:06 +0000 (16:35 -0400)]
Merge pull request #62694 from zdover23/wip-doc-2025-04-07-backport-62687-to-squid

squid: doc/cephadm/services: improve rgw.rst and snmp-gateway.rst

3 months agodoc/cephadm/services: improve rgw.rst and snmp-gateway.rst 62694/head
Anthony D'Atri [Sat, 5 Apr 2025 12:22:46 +0000 (08:22 -0400)]
doc/cephadm/services: improve rgw.rst and snmp-gateway.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 3d18222b46d65784335b4af0d651118b5e588d5e)

3 months agoMerge pull request #62213 from NitzanMordhai/wip-70380-squid
SrinivasaBharathKanta [Sat, 5 Apr 2025 05:24:38 +0000 (10:54 +0530)]
Merge pull request #62213 from NitzanMordhai/wip-70380-squid

squid: LogMonitor: set no_reply for forward MLog commands

3 months agoMerge pull request #62123 from ifed01/wip-ifed-some-recover-stuff-squi
Igor Fedotov [Fri, 4 Apr 2025 12:40:58 +0000 (15:40 +0300)]
Merge pull request #62123 from ifed01/wip-ifed-some-recover-stuff-squi

squid: tools/ceph-objectstore-tool: tricks to tolerate disk errors for "pg export" command

Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>
3 months agoMerge pull request #62053 from k0ste/wip-67124-squid
Igor Fedotov [Fri, 4 Apr 2025 12:40:03 +0000 (15:40 +0300)]
Merge pull request #62053 from k0ste/wip-67124-squid

squid: os/bluestore: Fix ExtentDecoderPartial::_consume_new_blob

Reviewed-by: Igor Fedotov <igor.fedtovo@croit.io>
3 months agoos/bluestore: Fix ExtentDecoderPartial::_consume_new_blob 62053/head
Adam Kupczyk [Wed, 5 Jun 2024 07:47:03 +0000 (07:47 +0000)]
os/bluestore: Fix ExtentDecoderPartial::_consume_new_blob

In case of corrupted data invalid iterator could be dereferenced.
Fixes: https://tracker.ceph.com/issues/66361
Signed-off-by: Adam Kupczyk <akupczyk@ibm.com>
(cherry picked from commit e59495b331765f4081d5aab66c939ec10b4b8344)

3 months agoMerge pull request #62666 from zdover23/wip-doc-2025-04-04-backport-62661-to-squid
Anthony D'Atri [Thu, 3 Apr 2025 20:30:29 +0000 (16:30 -0400)]
Merge pull request #62666 from zdover23/wip-doc-2025-04-04-backport-62661-to-squid

squid: doc/radosgw: Improve cloud-restore and cloud-transition

3 months agodoc/radosgw: Improve cloud-restore and cloud-transition 62666/head
Anthony D'Atri [Thu, 3 Apr 2025 17:58:49 +0000 (13:58 -0400)]
doc/radosgw: Improve cloud-restore and cloud-transition

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 6a6807470850ea972c5c3786be3735d26875b221)

3 months agoMerge pull request #62644 from zdover23/wip-doc-2025-04-03-backport-62643-to-squid
Anthony D'Atri [Thu, 3 Apr 2025 04:19:20 +0000 (00:19 -0400)]
Merge pull request #62644 from zdover23/wip-doc-2025-04-03-backport-62643-to-squid

squid: doc/cephadm: s/confg/config/

3 months agodoc/cephadm: s/confg/config/ 62644/head
Zac Dover [Thu, 3 Apr 2025 03:23:30 +0000 (13:23 +1000)]
doc/cephadm: s/confg/config/

Correct a misspelled command.

Re: https://github.com/ceph/ceph/pull/62367#discussion_r2025832937

Signed-off-by: Zac Dover <zac.dover@proton.me>
(cherry picked from commit 0f4d9a9ea29f12333609045928499963b37ba5f3)

3 months agoMerge pull request #62504 from batrick/wip-70667-squid
Yuri Weinstein [Wed, 2 Apr 2025 23:00:47 +0000 (16:00 -0700)]
Merge pull request #62504 from batrick/wip-70667-squid

squid: mgr: add status command

Reviewed-by: Laura Flores <lflores@redhat.com>
3 months agoMerge pull request #62620 from zdover23/wip-doc-2025-04-02-backport-62617-to-squid
Anthony D'Atri [Wed, 2 Apr 2025 15:31:50 +0000 (11:31 -0400)]
Merge pull request #62620 from zdover23/wip-doc-2025-04-02-backport-62617-to-squid

squid: doc/rados/configuration: Correct admonition in ceph-conf.rst

3 months agoMerge pull request #62605 from cbodley/wip-70753-squid
Casey Bodley [Wed, 2 Apr 2025 13:47:02 +0000 (09:47 -0400)]
Merge pull request #62605 from cbodley/wip-70753-squid

squid: cephfs-top, qa: Remove unnecessary global statements in tests

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
3 months agoMerge pull request #62420 from clwluvw/bucket-creation-multi-zg
Tejas [Wed, 2 Apr 2025 13:00:50 +0000 (18:30 +0530)]
Merge pull request #62420 from clwluvw/bucket-creation-multi-zg

squid: rgw: bucket creation fixes for multi-zonegroup scenario

3 months agoMerge pull request #62310 from adamemerson/wip-69124-squid
Tejas [Wed, 2 Apr 2025 13:00:10 +0000 (18:30 +0530)]
Merge pull request #62310 from adamemerson/wip-69124-squid

squid: rgw/multisite: fix forwarded requests for tenanted buckets

3 months agoMerge pull request #62305 from adamemerson/wip-65473-squid
Tejas [Wed, 2 Apr 2025 12:59:53 +0000 (18:29 +0530)]
Merge pull request #62305 from adamemerson/wip-65473-squid

squid: rgw: exclude logging of request payer for 403 requests

3 months agomonitoring: Fix OSDs panel in host-details grafana dashboard 62625/head
Aashish Sharma [Fri, 28 Feb 2025 06:12:13 +0000 (11:42 +0530)]
monitoring: Fix OSDs panel in host-details grafana dashboard

OSDs panel in host-details grafana dashboard shows total of all OSDs
across all hosts even if a particular host is selected from the
ceph_hosts filter. This PR intends to fix this issue

Fixes: https://tracker.ceph.com/issues/70226
Signed-off-by: Aashish Sharnma <aasharma@redhat.com>
(cherry picked from commit 223c1363791981a35bcb3cac841e665e080cc1f5)

3 months agodoc/rados/configuration: Correct admonition in ceph-conf.rst 62620/head
Anthony D'Atri [Tue, 1 Apr 2025 23:19:18 +0000 (19:19 -0400)]
doc/rados/configuration: Correct admonition in ceph-conf.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 5ff8e3e4381764822383ba769b2c4e73876fbc0c)

3 months agoMerge pull request #61330 from adamemerson/wip-66340-squid
Yuri Weinstein [Tue, 1 Apr 2025 18:10:40 +0000 (11:10 -0700)]
Merge pull request #61330 from adamemerson/wip-66340-squid

squid: rgw/multisite: Fix use-after-move in retry logic in logbacking

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #61430 from cbodley/wip-69580-squid
Yuri Weinstein [Tue, 1 Apr 2025 18:09:51 +0000 (11:09 -0700)]
Merge pull request #61430 from cbodley/wip-69580-squid

squid: rgw: /admin/user api dumps account-related user info

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #61431 from cbodley/wip-69576-squid
Yuri Weinstein [Tue, 1 Apr 2025 18:05:38 +0000 (11:05 -0700)]
Merge pull request #61431 from cbodley/wip-69576-squid

squid: rgw: S3 Delete Bucket Policy should return 204 on success

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 months agocephfs-top: Removes unused `global` statements 62605/head
Kefu Chai [Sun, 30 Mar 2025 03:59:12 +0000 (11:59 +0800)]
cephfs-top: Removes unused `global` statements

Recent flake8 runs were failing with:
```
py3: flake8==7.2.0,mccabe==0.7.0,pip==25.0.1,pycodestyle==2.13.0,pyflakes==3.3.0,setuptools==75.8.0,wheel==0.45.1
py3: commands[0] /home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/cephfs/top> flake8 --ignore=W503 --max-line-length=100 cephfs-top
cephfs-top:344:9: F824 `global fs_list` is unused: name is never assigned in scope
cephfs-top:466:13: F824 `global current_states` is unused: name is never assigned in scope
cephfs-top:872:9: F824 `global metrics_dict` is unused: name is never assigned in scope
cephfs-top:872:9: F824 `global current_states` is unused: name is never assigned in scope
cephfs-top:911:9: F824 `global fs_list` is unused: name is never assigned in scope
cephfs-top:981:9: F824 `global current_states` is unused: name is never assigned in scope
cephfs-top:1126:13: F824 `global current_states` is unused: name is never assigned in scope
py3: exit 1 (0.77 seconds) /home/jenkins-build/build/workspace/ceph-pull-requests/src/tools/cephfs/top> flake8 --ignore=W503 --max-line-length=100 cephfs-top pid=2309605
  py3: FAIL code 1 (8.15=setup[7.38]+cmd[0.77] seconds)
  evaluation failed :( (8.24 seconds)
```

Since these variables are only being referenced and not assigned within
their scopes, the `global` declarations are unnecessary and can be
safely removed. This change:

- Removes all flagged `global` statements
- Fixes the failing flake8 checks in the CI pipeline
- Maintains the original code behavior as variable references still work without the `global` keyword

The `global` keyword is only needed when assigning to global variables
within a function scope, not when simply referencing them.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit 39b262f7a6e1d69dc96255a1df62a68297d3f931)

3 months agoqa: Remove unnecessary global statements in tests
Kefu Chai [Sun, 30 Mar 2025 03:48:28 +0000 (11:48 +0800)]
qa: Remove unnecessary global statements in tests

Removes unused `global` statements from Python test files to fix flake8
F824 errors.

Recent flake8 runs were failing with:

```
./tasks/radosgw_admin.py:330:5: F824 `global log` is unused: name is never assigned in scope
./workunits/dencoder/test_readable.py:99:5: F824 `global incompat_paths` is unused: name is never assigned in scope
./workunits/dencoder/test_readable.py:164:5: F824 `global backward_compat` is unused: name is never assigned in scope
./workunits/dencoder/test_readable.py:165:5: F824 `global fast_shouldnt_skip` is unused: name is never assigned in scope
```

Since these variables are only being referenced and not assigned within
their scopes, the `global` declarations are unnecessary and can be
safely removed. This change:

- Removes all flagged `global` statements
- Fixes the failing flake8 checks in the CI pipeline
- Maintains the original code behavior as variable references still work
  without the `global` keyword

The `global` keyword is only needed when assigning to global variables
within a function scope, not when simply referencing them.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit bcc275f98cb26c9432c320cd24ee93ff629e0574)

3 months agoMerge pull request #62526 from cbodley/wip-69811-squid
Casey Bodley [Thu, 27 Mar 2025 21:48:57 +0000 (17:48 -0400)]
Merge pull request #62526 from cbodley/wip-69811-squid

squid: rgw/s3: remove local variable 'uri' that shadows member variable

Reviewed-by: Joseph Mundackal <jmundackal@bloomberg.net>
3 months agoos/bluestore: fix valgrind's "Invalid read" error in hybrid btree2 62540/head
Igor Fedotov [Thu, 11 Jul 2024 13:52:07 +0000 (16:52 +0300)]
os/bluestore: fix valgrind's "Invalid read" error in hybrid btree2
allocator.

Signed-off-by: Igor Fedotov <ifedotov@croit.io>
3 months agoos/bluestore: refactor allocator's ExtentCollectionTraits
Igor Fedotov [Thu, 7 Mar 2024 17:42:18 +0000 (20:42 +0300)]
os/bluestore: refactor allocator's ExtentCollectionTraits

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agoos/bluestore: refactor allocator histogram to use ExtentCollectionTraits
Igor Fedotov [Fri, 2 Feb 2024 18:16:18 +0000 (21:16 +0300)]
os/bluestore: refactor allocator histogram to use ExtentCollectionTraits

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agoos/bluestore: move and rename ExtentCache to Allocator class.
Igor Fedotov [Mon, 29 Jan 2024 18:49:48 +0000 (21:49 +0300)]
os/bluestore: move and rename ExtentCache to Allocator class.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agoos/bluestore: uniform allocator's error handling
Igor Fedotov [Mon, 24 Jul 2023 03:20:51 +0000 (06:20 +0300)]
os/bluestore: uniform allocator's error handling

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agoos/bluestore: introduce new allocator hybrid_btree2
Igor Fedotov [Fri, 14 Jul 2023 14:48:52 +0000 (17:48 +0300)]
os/bluestore: introduce new allocator hybrid_btree2

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agoinclude/intarith: introduce p2aligned()
Igor Fedotov [Mon, 29 Jan 2024 16:21:51 +0000 (19:21 +0300)]
include/intarith: introduce p2aligned()

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agotest/objecstore/store_test: be more specific with the desired allocator.
Igor Fedotov [Fri, 14 Jul 2023 14:36:37 +0000 (17:36 +0300)]
test/objecstore/store_test: be more specific with the desired allocator.

Test case depends strongly on avl allocator results. Hence sticking to
this allocator explicitly.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agoos/bluestore: make hybrid allocator implementation reusable
Igor Fedotov [Fri, 14 Jul 2023 14:25:45 +0000 (17:25 +0300)]
os/bluestore: make hybrid allocator implementation reusable

Refactor hybrid allocator in a way to permit alternative
hybrid allocator implementations using the same code base.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agoos/bluestore: Allocator's cosmetic cleanup/improvement.
Igor Fedotov [Fri, 14 Jul 2023 14:10:58 +0000 (17:10 +0300)]
os/bluestore: Allocator's cosmetic cleanup/improvement.

Intended for the forthcoming major update with new allocator
implementation.

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agotest/allocator_replay: print elapsed time for try_alloc command
Igor Fedotov [Thu, 22 Jun 2023 10:10:34 +0000 (13:10 +0300)]
test/allocator_replay: print elapsed time for try_alloc command

Signed-off-by: Igor Fedotov <igor.fedotov@croit.io>
3 months agoos/bluestore: remove unnecessary std::hex in dout
jrchyang [Thu, 28 Mar 2024 07:16:58 +0000 (07:16 +0000)]
os/bluestore: remove unnecessary std::hex in dout

Signed-off-by: Jrchyang Yu <yuzhiqiang_yewu@cmss.chinamobile.com>
3 months agoMerge pull request #62219 from idryomov/wip-66419-squid
Yuri Weinstein [Thu, 27 Mar 2025 14:20:40 +0000 (07:20 -0700)]
Merge pull request #62219 from idryomov/wip-66419-squid

squid: qa/workunits/rbd: wait for resize to be applied in rbd-nbd

Reviewed-by: Ramana Raja <rraja@redhat.com>
3 months agoMerge pull request #61817 from zdover23/wip-doc-2025-02-14-backport-61688-to-squid
Zac Dover [Thu, 27 Mar 2025 12:40:57 +0000 (22:40 +1000)]
Merge pull request #61817 from zdover23/wip-doc-2025-02-14-backport-61688-to-squid

squid: doc/dev/release-process.rst: release builds cannot build containers

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 months agoMerge pull request #61952 from zdover23/wip-doc-2025-02-21-backport-61948-to-squid
Zac Dover [Thu, 27 Mar 2025 12:40:38 +0000 (22:40 +1000)]
Merge pull request #61952 from zdover23/wip-doc-2025-02-21-backport-61948-to-squid

squid: doc/cephadm/services: Re-improve osd.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 months agoMerge pull request #61664 from zdover23/wip-doc-2025-02-06-backport-61616-to-squid
Zac Dover [Thu, 27 Mar 2025 12:39:40 +0000 (22:39 +1000)]
Merge pull request #61664 from zdover23/wip-doc-2025-02-06-backport-61616-to-squid

squid: doc/cephadm: clarify "Monitoring OSD State"

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
Reviewed-by: Adam King <adking@redhat.com>
3 months agoMerge pull request #62290 from zdover23/wip-doc-2025-03-14-backport-62258-to-squid
Zac Dover [Thu, 27 Mar 2025 12:33:43 +0000 (22:33 +1000)]
Merge pull request #62290 from zdover23/wip-doc-2025-03-14-backport-62258-to-squid

squid: doc/rados/configuration/bluestore-config-ref: Fix lowercase typos

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>
3 months agoMerge pull request #62377 from zdover23/wip-doc-2025-03-19-backport-61670-to-squid
Zac Dover [Thu, 27 Mar 2025 12:32:28 +0000 (22:32 +1000)]
Merge pull request #62377 from zdover23/wip-doc-2025-03-19-backport-61670-to-squid

squid: common/options: fix the description of osd_max_scrubs

Reviewed-by: Ronen Friedman <rfriedma@redhat.com>
3 months agorgw/s3: remove local variable 'uri' that shadows member variable 62526/head
Casey Bodley [Tue, 14 Jan 2025 16:26:26 +0000 (11:26 -0500)]
rgw/s3: remove local variable 'uri' that shadows member variable

fixes "Invalid group uri" errors from `s3cmd setacl --acl-public s3://bucketname`
introduced by account changes for squid

Fixes: https://tracker.ceph.com/issues/69527
Reported-by: Yixin Jin <yjin@akamai.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 4257d11936cfcf0c96e6fabda72514236bbeeb4a)

3 months agoMerge pull request #62346 from phlogistonjohn/wip-70154-squid
Adam King [Wed, 26 Mar 2025 19:39:50 +0000 (15:39 -0400)]
Merge pull request #62346 from phlogistonjohn/wip-70154-squid

squid: container: small container image improvements

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Dan Mick <dan.mick@redhat.com>
3 months agoMerge pull request #62155 from cbodley/wip-70343-squid
Casey Bodley [Wed, 26 Mar 2025 13:00:24 +0000 (09:00 -0400)]
Merge pull request #62155 from cbodley/wip-70343-squid

squid: radosgw-admin: lower default thread pool size

Reviewed-by: Daniel Gryniewicz <dang@redhat.com>
3 months agoMerge pull request #61159 from ivancich/wip-69295-squid
Yuri Weinstein [Tue, 25 Mar 2025 20:11:27 +0000 (13:11 -0700)]
Merge pull request #61159 from ivancich/wip-69295-squid

squid: rgw: append query string to redirect URL if present

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoqa: add test for `mgr status` command 62504/head
Patrick Donnelly [Mon, 24 Mar 2025 15:52:15 +0000 (11:52 -0400)]
qa: add test for `mgr status` command

Fixes: https://tracker.ceph.com/issues/70571
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
(cherry picked from commit 9074e2cdc750378f84debd0187b0b058aae40633)

3 months agomgr: add status command
Patrick Donnelly [Mon, 24 Mar 2025 15:50:50 +0000 (11:50 -0400)]
mgr: add status command

The Rook operator relies on a `status` (asok) command to the mgr to verify it
is operational. However, this command was actually served by the CephFS
`Client` library that the ceph-mgr daemon statically linked in and used for
sending MDS commands. That statically linked client was removed via 048fc68c
(case insensitive directory tree feature).

So, add a legitimate ceph-mgr status command which simply outputs an empty
dictionary and returns success (0). TBD on adding useful information.

Fixes: 048fc68c517f50b9978457f478ca4638f01caa09
Fixes: https://tracker.ceph.com/issues/70571
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
(cherry picked from commit 4a7976a57c1ff823753c1c25274b6482f0a8c8ea)

3 months agoMerge pull request #61092 from shashalu/fix-data-corruption-ETIMEDOUT-squid
Yuri Weinstein [Tue, 25 Mar 2025 17:36:26 +0000 (10:36 -0700)]
Merge pull request #61092 from shashalu/fix-data-corruption-ETIMEDOUT-squid

squid: rgw: fix data corruption when rados op return ETIMEDOUT

Reviewed-by: Casey Bodley <cbodley@redhat.com>
3 months agoMerge pull request #62467 from ljflores/wip-squid-62422
Laura Flores [Tue, 25 Mar 2025 16:53:07 +0000 (11:53 -0500)]
Merge pull request #62467 from ljflores/wip-squid-62422

squid: PendingReleaseNotes; doc/rados/operations: document "rm-pg-upmap-primary-{all}" commands

3 months agoMerge pull request #62309 from adamemerson/wip-55179-squid
Yuri Weinstein [Tue, 25 Mar 2025 15:20:21 +0000 (08:20 -0700)]
Merge pull request #62309 from adamemerson/wip-55179-squid

squid: rgw: Deleting an object with null version fix

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
3 months agoMerge pull request #62306 from adamemerson/wip-67207-squid
Yuri Weinstein [Tue, 25 Mar 2025 15:19:22 +0000 (08:19 -0700)]
Merge pull request #62306 from adamemerson/wip-67207-squid

squid: qa/multisite: add extra checkpoints in datalog_autotrim testcase

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>
3 months agoMerge pull request #61147 from cbodley/wip-69317-squid
Yuri Weinstein [Tue, 25 Mar 2025 15:17:51 +0000 (08:17 -0700)]
Merge pull request #61147 from cbodley/wip-69317-squid

squid: rgw/posix: std::ignore return value of write()

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #61134 from cbodley/wip-69297-squid
Yuri Weinstein [Tue, 25 Mar 2025 15:17:11 +0000 (08:17 -0700)]
Merge pull request #61134 from cbodley/wip-69297-squid

squid: rgw/abortmp: Race condition on AbortMultipartUpload

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #61104 from cbodley/wip-69260-squid
Yuri Weinstein [Tue, 25 Mar 2025 15:16:08 +0000 (08:16 -0700)]
Merge pull request #61104 from cbodley/wip-69260-squid

squid: <common> fix formatter buffer out-of-bounds

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #61051 from cbodley/wip-69213-squid
Yuri Weinstein [Tue, 25 Mar 2025 15:14:54 +0000 (08:14 -0700)]
Merge pull request #61051 from cbodley/wip-69213-squid

squid: rgw: fix bucket link operation

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #60982 from cbodley/wip-69152-squid
Yuri Weinstein [Tue, 25 Mar 2025 15:14:17 +0000 (08:14 -0700)]
Merge pull request #60982 from cbodley/wip-69152-squid

squid: radosgw-admin: bucket link/unlink support accounts

Reviewed-by: Adam Emerson <aemerson@redhat.com>
3 months agoMerge pull request #62327 from NitzanMordhai/wip-70496-squid
SrinivasaBharathKanta [Tue, 25 Mar 2025 04:16:30 +0000 (09:46 +0530)]
Merge pull request #62327 from NitzanMordhai/wip-70496-squid

squid: OSDMonitor: exclude destroyed OSDs from "ceph node ls" output

3 months agoPendingReleaseNotes; doc/rados/operations: document "rm-pg-upmap-primary-{all}" commands 62467/head
Laura Flores [Thu, 20 Mar 2025 21:19:30 +0000 (16:19 -0500)]
PendingReleaseNotes; doc/rados/operations: document "rm-pg-upmap-primary-{all}" commands

Added a release note for `ceph osd rm-pg-upmap-primary` and documentation to
complement #62190.

Signed-off-by: Laura Flores <lflores@ibm.com>
(cherry picked from commit 4dee7917bf010dc6d8e24f0ef437bd8a41c355c9)

*Note: PendingReleaseNotes was modified to have the release note under the v19.2.2 section.

3 months agoMerge pull request #62421 from ljflores/wip-70592-squid
NitzanMordhai [Mon, 24 Mar 2025 07:43:32 +0000 (09:43 +0200)]
Merge pull request #62421 from ljflores/wip-70592-squid

squid: mon, osd: add command to remove invalid pg-upmap-primary entries

3 months agoMerge pull request #62363 from athanatos/wip-70537-squid
NitzanMordhai [Mon, 24 Mar 2025 07:43:15 +0000 (09:43 +0200)]
Merge pull request #62363 from athanatos/wip-70537-squid

squid: osd: fix osd mclock queue item leak

3 months agoMerge pull request #62393 from rhcs-dashboard/wip-70556-squid
Nizamudeen A [Mon, 24 Mar 2025 06:45:14 +0000 (12:15 +0530)]
Merge pull request #62393 from rhcs-dashboard/wip-70556-squid

squid: mgr/dashboard: add xlmtodict import and fix lifecycle get request

3 months agoMerge pull request #62449 from zdover23/wip-doc-2025-03-23-backport-62366-to-squid
Anthony D'Atri [Sun, 23 Mar 2025 12:28:57 +0000 (08:28 -0400)]
Merge pull request #62449 from zdover23/wip-doc-2025-03-23-backport-62366-to-squid

squid: doc/radosgw: Improve layout.rst

3 months agodoc/radosgw: Improve layout.rst 62449/head
Anthony D'Atri [Tue, 18 Mar 2025 18:54:10 +0000 (14:54 -0400)]
doc/radosgw: Improve layout.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit a7e2fab008519416d5bd91f2163ea51e82c440af)

3 months agoMerge pull request #62443 from zdover23/wip-doc-2025-03-22-backport-62422-to-squid
Anthony D'Atri [Sat, 22 Mar 2025 14:54:28 +0000 (10:54 -0400)]
Merge pull request #62443 from zdover23/wip-doc-2025-03-22-backport-62422-to-squid

squid: doc/cephadm/services: Add mention of --zap for OSD removal

3 months agodoc/cephadm/services: Add mention of --zap for OSD removal 62443/head
Anthony D'Atri [Fri, 21 Mar 2025 21:59:02 +0000 (17:59 -0400)]
doc/cephadm/services: Add mention of --zap for OSD removal

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
(cherry picked from commit 20b621fceb865403e19e1d7876f81e670829ff59)

3 months agoMerge pull request #62427 from zdover23/wip-doc-2025-03-21-backport-62426-to-squid
Anthony D'Atri [Fri, 21 Mar 2025 16:07:33 +0000 (12:07 -0400)]
Merge pull request #62427 from zdover23/wip-doc-2025-03-21-backport-62426-to-squid

squid: doc/cephadm/services: Correct indentation in osd.rst