mgr/dashboard: fix some linting issues.
Fixes: https://tracker.ceph.com/issues/66995
Signed-off-by: Ankit Kumar <51ankitkp@gmail.com>

Merge PR #62303 into main

* refs/pull/62303/head:
test/libcephfs: add missing cleanup

Reviewed-by: Venky Shankar <vshankar@redhat.com>
Reviewed-by: Christopher Hoffman <choffman@redhat.com>

Merge PR #62406 into main

* refs/pull/62406/head:
client: process path without inode anchor
test/client: add ll_walk test with cwd and root path

Reviewed-by: Dhairya Parmar <dparmar@redhat.com>

Merge pull request #62423 from afreen23/wip-ns-kb

mgr/dashboard: KiB not supported size for namespace creation

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #61727 from Kushal-deb/fix_issue_2330954-RGW_is_not_adding_a_SAN

cephadm: Ensure wildcard SAN is included in RGW self-signed certs

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #61209 from Kushal-deb/fix_issue-2253832-osd_service_issue

cephadm: link new OSDs to existing managed services

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #62199 from ShwetaBhosale1/fix_issue_70373_enable_logrotate_timer

cephadm: Enable logroate.timer service in bootstrap process

Reviewed-by: Adam King <adking@redhat.com>

Merge pull request #62485 from zdover23/wip-doc-2025-03-25-cephadm-certmgr

doc/cephadm: format "Configuration" in cephadm.rst

Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #62282 from adk3798/cephadm-ganesha-fix-server-scope

mgr/cephadm: fix Server_Scope in ganesha.conf

Reviewed-by: John Mulligan <jmulligan@redhat.com>

Merge pull request #62329 from NitzanMordhai/wip-nitzan-suite-rados-cephadmn-still-running-ignore

suites/rados/cephadm: add still running warning to the ignore list

Reviewed-by: Adam King <adking@redhat.com>
Reviewed-by: Laura Flores <lflores@ibm.com>
Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

doc/cephadm: format "Configuration" in cephadm.rst

Improve the formatting in the section "Configuration" in
doc/cephadm/certmgr/cephadm.rst.

Signed-off-by: Zac Dover <zac.dover@proton.me>

Merge pull request #62411 from rhcs-dashboard/notification-icon-fix

mgr/dashboard: fix notification icon size

Merge pull request #62410 from rhcs-dashboard/custom-pool-dashboard

mgr/dashboard: use existing pools for cephfs vol creation

Merge pull request #62027 from rhcs-dashboard/admin-ops-api-for-rgw-accounts

mgr/dashboard: Use admin ops API for rgw accounts

Merge pull request #62415 from rhcs-dashboard/tenanted-bucket-lifecycle-fix

mgr/dashboard: tenanted bucket lifecycle management fix

Merge pull request #62425 from cyx1231st/wip-seastore-cleanups

crimson/os/seastore: misc cleanups

Reviewed-by: Xuehan Xu <xuxuehan@qianxin.com>
Reviewed-by: Matan Breizman <mbreizma@redhat.com>

mgr/dashboard: KiB not supported size for namespace creation

Fixes https://tracker.ceph.com/issues/70106

Signed-off-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #62464 from idryomov/wip-70632

librbd: respect rbd_default_snapshot_quiesce_mode in group_snap_create()

Reviewed-by: Prasanna Kumar Kalever <prasanna.kalever@redhat.com>

Merge pull request #62422 from ljflores/wip-pg-upmap-prim-release-note

PendingReleaseNotes; doc/rados/operations: document "rm-pg-upmap-primary-{all}" commands

Merge pull request #62269 from nbalacha/wip-nbalacha-rbd-mirrorpool-errmsg

rbd: print the return codes on error for mirror pool commands

Reviewed-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #54957 from jzhu116-bloomberg/wip-63799

rgw: revert PR #41897 to allow multiple delete markers to be created

Reviewed-by: Casey Bodley <cbodley@redhat.com>

librbd: don't use public API flags in Group::snap_create()

Use internal flags obtained from snap_create_flags_api_to_internal()
instead -- internal_flags variable was assigned but not used.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

librbd: respect rbd_default_snapshot_quiesce_mode in group_snap_create()

Make group_snap_create() behave the same as snap_create() and
mirror_image_create_snapshot(): APIs that don't take RBD_SNAP_CREATE_
flags explicitly should respect rbd_default_snapshot_quiesce_mode
option.

Fixes: https://tracker.ceph.com/issues/70632
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>

Merge pull request #60684 from salieri11/wip-igolikov-asok-56442

mds: add MDS asok command for dumping stray directories

Merge PR #62439 into main

* refs/pull/62439/head:
.github/workflows,script: add test for missing .qa links
qa: add missing .qa links

Reviewed-by: Ernesto Puerta <epuertat@redhat.com>

mgr/dashboard: tenanted bucket lifecycle management fix

Fixes: https://tracker.ceph.com/issues/70588
Signed-off-by: Naman Munet <naman.munet@ibm.com>
Before: As the tenant was not passed in lifecycle calls made through bucket details > tiering tab, & also account_id was not resolved to the user of the bucket, hence not able to manage the Tiering configuration lifecycle changes
After: Account_id is resolved to user_id and tenant is additionally passed to the lifecycle API so as to handle the tenanted bucket scenario

Merge pull request #62430 from ankitk18/fix/alignment-action-btn

mgr/dashboard:fixed alignment of create action button

rbd: print the return codes on error

The calls in the mirror pool cli do not always print the error code.
This is now done in order to make debugging easier.

Fixes: https://tracker.ceph.com/issues/70444
Signed-off-by: N Balachandran <nithya.balachandran@ibm.com>

Merge pull request #62366 from anthonyeleven/improve-radosgw-layout

doc/radosgw: Improve layout.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>

Merge pull request #62442 from anthonyeleven/improve-cephadm-svc-osd

doc/cephadm/services: Add mention of --zap for OSD removal

Reviewed-by: Zac Dover <zac.dover@proton.me>

doc/cephadm/services: Add mention of --zap for OSD removal

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

Merge pull request #62413 from ceph/pin-actions

workflows: Pin specific SHAs

PendingReleaseNotes; doc/rados/operations: document "rm-pg-upmap-primary-{all}" commands

Added a release note for `ceph osd rm-pg-upmap-primary` and documentation to
complement #62190.

Signed-off-by: Laura Flores <lflores@ibm.com>

.github/workflows,script: add test for missing .qa links

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

mgr/dashboard:fixed alignment of create action button

Fixes:https://tracker.ceph.com/issues/70433
Signed-off-by: Ankit Kumar <51ankitkp@gmail.com>

qa: add missing .qa links

    find qa/suites/ -type d -execdir ln -sfT ../.qa/ {}/.qa \;

Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #62370 from laimis9133/main

doc/rados/troubleshooting/log-and-debug: add separate section for Monitors

mgr/dashboard: e2e for cephfs creation with existing pools

Fixes: https://tracker.ceph.com/issues/70600
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: use existing pools for cephfs vol creation

We can use the newly introduced data and metadata params to create a vol
with those pools.

UI is being intelligent by filtering out the used pools and only uses
the pools that are labeled by cephfs and also not in use. To figure out
a pool is in use or not, we are fetching the pool stats and checking its
used_bytes.

Note: Using ec pools for data pool layout is something discouraged
according to offical doc: https://docs.ceph.com/en/latest/cephfs/createfs/#creating-a-file-system
We can force it but for now I have disabled it entirely in the dashboard
unless people say its okay to do it.

One more extra thing I am doing here is to add a note on deleting a
filesystem that the underlying pools and mds daemons will be removed.

Fixes: https://tracker.ceph.com/issues/70600
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #62101 from rhcs-dashboard/nfs-fix

mgr/dashboard: NFS - Fix Edit NFS export request

Merge pull request #60631 from kamoltat/wip-ksirivad-fix-3az-unset

[3AZ] src/mon : Allow user to specify crush_rule, size and min_size when unsetting a stretch pool

Merge pull request #62100 from rhcs-dashboard/bucket-lifecycle-fixes

mgr/dashboard: bucket lifecycle fixes after using xmltodict package

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>

mgr/dashboard: Use admin ops API for rgw accounts

Fixes: https://tracker.ceph.com/issues/69487
Signed-off-by: Naman Munet <naman.munet@ibm.com>

mgr/dashboard: NFS - Fix Edit NFS export request

Fixes: https://tracker.ceph.com/issues/70284
Signed-off-by: Dnyaneshwari Talwekar <dtalweka@redhat.com>

crimson/os/seastore/transaction: cleanup add_absent/present_to_retired_set

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #61646 from aclamk/wip-aclamk-teuto-better-bluestore-testing

qa/rados: Augmented bluestore testing

Merge pull request #61745 from soumyakoduri/wip-skoduri-glacier-cli

rgw/cloud-restore [PART1] : Add Restore support from Glacier/Tape cloud endpoints

Merge pull request #62426 from anthonyeleven/fixup-db_slots

doc/cephadm/services: Correct indentation in osd.rst

Reviewed-by: Zac Dover <zac.dover@proton.me>

doc/cephadm/services: Correct indentation in osd.rst

Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>

crimson/os/seastore/cache: make sure on_cache is called after extent initialization

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: misc renames

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: duplicate_for_write() to move set_laddr() into Cache

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: improve is_logical() checks

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore/lba_manager: drop unused get_mappings()

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

crimson/os/seastore: drop unused inc/decref_extent and dec_ref with tests

Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>

Merge pull request #61732 from rishabh-d-dave/mgr-vol-pools

mgr/vol: allow passing pool names to "fs volume create" cmd

Reviewed-by: Venky Shankar <vshankar@redhat.com>

Merge pull request #61084 from adamemerson/wip-boost-1.87

Boost 1.87

Reviewed-by: Matan Breizman <Matan.Brz@gmail.com>

Merge pull request #62285 from cbodley/wip-rgw-iam-arnlike

rgw/iam: add policy evaluation for Arn-based Conditions

Reviewed-by: Adam Emerson <aemerson@redhat.com>
Reviewed-by: Yuval Lifshitz <ylifshit@redhat.com>

Merge pull request #62368 from ivancich/wip-radoslist-improvements

rgw: radoslist improvements primarily to better support gap list tool

Reviewed-by: Shilpa Jagannath <smanjara@redhat.com>

Merge pull request #62166 from rkachach/fix_issue_70352

mgr/cephadm: use ip_hash to enforce the same prometheues upstream

Reviewed-by: Adam King <adking@redhat.com>

workflows: Pin specific SHAs

Fixes https://www.wiz.io/blog/new-github-action-supply-chain-attack-reviewdog-action-setup

Signed-off-by: David Galloway <david.galloway@ibm.com>

Merge pull request #61873 from rhcs-dashboard/nfs-create-cluster

mgr/dashboard: NFS Cluster and Export Listing

Merge pull request #62387 from rhcs-dashboard/user-form-display-name-fix

mgr/dashboard: Not able to edit user display/full name in user form

Reviewed-by: Afreen Misbah <afreen@ibm.com>

mgr/dashboard: fix notification icon size

Fixes: https://tracker.ceph.com/issues/70583
Signed-off-by: Nizamudeen A <nia@redhat.com>

Merge pull request #62397 from aainscow/interval_set_qf

test/common: skip google tests which create core dumps in test_interval_set

Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Reviewed-by: Adam Kupczyk <akupczyk@ibm.com>

Merge pull request #61937 from vshankar/wip-file-block-diff

mds/client: file blockdiff support

Merge pull request #62244 from ronen-fr/wip-rf-cast-conf

common, osd: add cmd_getval_cast_or()

Reviewed-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Reviewed-by: Alex Ainscow <aainscow@uk.ibm.com>

cephadm: Enable logroate.timer service in bootstrap process

Fixes: https://tracker.ceph.com/issues/70373
Signed-off-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>

PendingReleaseNote: add note that "volume create" accepts pool names...

in args.

Add a release note that "ceph fs volume create" command allows users to
pass pool names to "ceph fs volume create" command.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

doc/cephfs: mention new options for "fs volume create" cmd

Command "ceph fs volume create" accepts 2 new options to allow users to
pass data and metadata pool name. Update docs to include mention of both
the options.

Signed-off-by: Rishabh Dave <ridave@redhat.com>

mgr/nfs: NFS Cluster and Export Listing

Fixes: https://tracker.ceph.com/issues/70022
Signed-off-by: Achint Kaur <ackaur@redhat.com>

Merge pull request #61075 from rhcs-dashboard/topicmanagment

mgr/dashboard: Add RGW topics endpoint creation for create ,delete and list in dashboard

Merge pull request #62323 from clwluvw/bucket-replication-mismatch

rgw: reject PutBucketReplication policies with mismatched statuses, skip sync on update

Reviewed-by: Casey Bodley <cbodley@redhat.com>

Merge pull request #62149 from rhcs-dashboard/fix-access-perm-ui

mgr/dashboard: fix access control permissions for roles

Reviewed-by: Afreen Misbah <afreen@ibm.com>

rgw: radolist clean up, calculate obj info slightly earlier

With recent changes, it's better to determine bucket and object names
earlier.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

rgw: modify radoslist to better support the rgw-gap-list tool

When the `radosgw-admin bucket radoslist ...` sub-command was
introduced, it was written specifically for finding orphans. It has
since been updated to work for finding gaps, that is indexed RGW
objects that are missing one or more supporting rados objects.

When a head object was not found, it was ignored. Now it does produce
output with the oid and related information for the missing head
object.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

rgw: fix regression in radoslist with SLO manifests

A regression was inadvertently introduced in commit
bcd7883d7212c96ebfb89c938c79fc7efbb80d2f that then prevented
`radosgw-admin bucket radoslist ...` from working properly with
buckets using SLO manifests. This corrects that regression.

Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>

client: process path without inode anchor

ll_walk was wrongly coded to make the input file path relative to ino=0. That inode
does not exist and isn't considered the root inode.

Fixes: https://tracker.ceph.com/issues/70573
Fixes: e08210dda01f4e154561fcf008084e6d640e4683
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>

test/client: add ll_walk test with cwd and root path

Fixes: https://tracker.ceph.com/issues/70573
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>

Merge pull request #62394 from laimis9133/laims9133-notiffix

doc/radosgw/notifications: fix topic details

Reviewed-by: Zac Dover <zac.dover@proton.me>
Reviewed-by: Anthony D'Atri <anthony.datri@gmail.com>

Merge pull request #62372 from tchaikov/libcephfs-proxy-compare-unsigned

libcephfs_proxy: remove redundant unsigned >= 0 comparison

Reviewed-by: Xavi Hernandez <xhernandez@gmail.com>
Reviewed-by: Sachin Punadikar <sachin.punadikar@ibm.com>

Merge pull request #62206 from rhcs-dashboard/smb-overview

monitoring: add SMB overview grafana dashboard

Reviewed-by: Afreen Misbah <afreen@ibm.com>
Reviewed-by: Nizamudeen A <nia@redhat.com>
Reviewed-by: Aashish Sharma <aasharma@redhat.com>
Reviewed-by: Ankush Behl <cloudbehl@gmail.com>
Reviewed-by: Patrick Donnelly <pdonnell@ibm.com>

Merge pull request #62262 from ankitk18/fix/notification-icon-click

mgr/dashboard:fixed issue with notification icon

Reviewed-by: Afreen Misbah <afreen@ibm.com>

Merge pull request #62169 from anoopcs9/mgr-smb-add-ceph-snapshots

mgr/smb: Add ceph_snapshots vfs module to share definition

Reviewed-by: Avan Thakkar <athakkar@redhat.com>
Reviewed-by: John Mulligan <jmulligan@redhat.com>

mgr/dashboard: add types for mgr-module list

also introducing a const for rgw

Fixes: https://tracker.ceph.com/issues/70331
Signed-off-by: Nizamudeen A <nia@redhat.com>

mgr/dashboard: fix access control permissions for roles

Since prometheus is being used in the dashboard page we need to make
sure every role has prometheus read only access so that the dashboard
page can load the utilization metrics.

I also saw permission issue with the osd settings endpoint when its
trying to get the nearfull/full ratio. so instead of failing the entire
page i am proceeding with a chart that doesn't have those details when
the user doesn't have permission to access the config opt.

Multisite page was not accessible in the case of rgw-manager or
read-only user because its trying to show the status of rgw module. This
si also now gracefully handled to show the alert only when the user has
sufficient permission.

Fixes: https://tracker.ceph.com/issues/70331
Signed-off-by: Nizamudeen A <nia@redhat.com>

test/common: skip google tests which create core dumps in test_interval_set

CI Pipelines are being broken because this test is creating a number of core dumps. This
does not make the test fail, but it does create some core dumps. This appears to be
breaking something in the CI pipeline.  This commit is a workaround and I will find a
better solution later.

Fixes: https://tracker.ceph.com/issues/70543
Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>

mgr/dashboard: bucket lifecycle fixes after using xmltodict package

Fixes: https://tracker.ceph.com/issues/70275
Signed-off-by: Naman Munet <naman.munet@ibm.com>

mgr/dashboard: Not able to edit user display/full name in user form

Fixes: https://tracker.ceph.com/issues/70554
Signed-off-by: Naman Munet <naman.munet@ibm.com>

doc/radosgw /notifications: fix topic details

This commit fixes documentation about many-to-many topic relationship for notifications. The current sentence states the same fact twice instead of clarifying.

Fixes: https://tracker.ceph.com/issues/64956
Signed-off-by: Laimis Juzeliunas <laimis.juzeliunas@oxylabs.io>

qa/cephfs: test passing pool names to "fs volume create" cmd

Signed-off-by: Rishabh Dave <ridave@redhat.com>

qa/cephfs: separate the tests for "ceph fs volume create" cmd

Signed-off-by: Rishabh Dave <ridave@redhat.com>

mgr/vol: allow passing pool names to "fs volume create" cmd

Fixes: https://tracker.ceph.com/issues/69878
Signed-off-by: Rishabh Dave <ridave@redhat.com>

mgr/dashboard:fixed issue with notification icon

Fixes:https://tracker.ceph.com/issues/70253
Signed-off-by: Ankit Kumar <51ankitkp@gmail.com>

Merge pull request #62275 from rhcs-dashboard/fix-70450-main

mgr/dashboard: Fix rgw user key modal not shown

Reviewed-by: Nizamudeen A <nia@redhat.com>

test/unitest_bluestore_types: fix a compilation error

The test was failing to compile because of a missing
'include' directive.
Problem was introduced in commit 2e73c875640

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

osd: use cmd_getval_cast_or() to fetch shard-id

as that interface alleviates the need to cast shard_id_t::NO_SHARD
back and forth to/from int.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

common: add cmd_getval_cast_or()

This slight variation of cmd_getval_or() can be used where
the object type is different from the configuration item
type (as when the object is a wrapper around an integer).
It allows specifying the 'default' value in the object type.

Signed-off-by: Ronen Friedman <rfriedma@redhat.com>

Merge pull request #61766 from aainscow/shard_id_t

osd: Require explicit casting for shard_id_t

Reviewed-by: Bill Scales <bill_scales@uk.ibm.com>
Reviewed-by: Ronen Friedman <rfriedma@redhat.com>

monitoring: add SMB overview grafana dashboard

Fixes: https://tracker.ceph.com/issues/70423
Signed-off-by: Pedro Gonzalez Gomez <pegonzal@redhat.com>